Re: New Issue and PR

[David Jencks]

DavidCount++; //Dropping by to say hi…

David Jencks



> On May 26, 2019, at 10:04 PM, David Blevins  wrote:
> 
>> On May 26, 2019, at 3:53 AM, David Salter  
>> wrote:
>> 
>> Thanks. That makes sense. 
>> 
>> As long as I’m on track, I’ll keep going. I’ve got a few more updates I’ll 
>> create issues and PRs for :)
> 
> That sounds fantastic!  On this example, I regenerated and did a manual tweak 
> of the resulting html -- this seems to be what's required on "stuck" pages 
> for some reason.  Does this look good?
> 
> - http://localhost:8080/tomee-8.0/docs/activemqresourceadapter-config.html
> 
> Side note, it's fun to have another David on the project again :)  People 
> used to mistake me for David Jencks quite regularly.
> 
> I wonder how many Davids we can get on this thread :)
> 
> 
> -David
> 

Re: [VOTE] TomEE 8.0.0-M3 (staging-1136) - take two

[Thiago Veronezi]

+1

tx guys!


On Mon, May 27, 2019 at 3:42 PM Marco Ferreira <
marcoantoniobferre...@gmail.com> wrote:

> +1
>
> On Mon, 27 May 2019, 16:03 Jean-Louis Monteiro, 
> wrote:
>
> > +1
> > Thanks David
> >
> > Le jeu. 23 mai 2019 à 10:43, David Blevins  a
> > écrit :
> >
> > > Ok, the extra libraries have been removed and new M3 build created.
> Vote
> > > will be open for 72 hours or as needed.
> > >
> > > Maven Repo:
> > >
> > >  -
> > https://repository.apache.org/content/repositories/orgapachetomee-1136/
> > >
> > > Binaries & Source:
> > >
> > >  -
> > >
> https://dist.apache.org/repos/dist/dev/tomee/staging-1136/tomee-8.0.0-M3
> > >
> > > Binary comparison:
> > >
> > >  -
> > >
> >
> https://dist.apache.org/repos/dist/dev/tomee/staging-1136/tomee-8.0.0-M3/DIFF.txt
> > >
> > > Here is a diff of the staging-1135 and staging-1136 builds.
> > >
> > > apache-tomee 8.0.0-M3 webprofile (staging-1136)
> > >
> > >   DEL ant-1.10.5.jar [2216.65 ko]
> > >   DEL ant-launcher-1.10.5.jar [18.83 ko]
> > >   DEL codemodel-2.3.2.jar [159.21 ko]
> > >   DEL dtd-parser-1.4.1.jar [62.47 ko]
> > >   DEL istack-commons-tools-3.0.8.jar [29.29 ko]
> > >   DEL jaxb-xjc-2.3.2.jar [903.20 ko]
> > >   DEL relaxng-datatype-2.3.2.jar [19.88 ko]
> > >   DEL rngom-2.3.2.jar [315.64 ko]
> > >   DEL xsom-2.3.2.jar [415.37 ko]
> > >
> > >   change: -3.59 MB
> > >   total : 41.72 MB
> > >
> > > apache-tomee 8.0.0-M3 microprofile (staging-1136)
> > >
> > >   DEL ant-1.10.5.jar [2216.65 ko]
> > >   DEL ant-launcher-1.10.5.jar [18.83 ko]
> > >   DEL asm-all-5.0.3.jar [241.64 ko]
> > >   DEL codemodel-2.3.2.jar [159.21 ko]
> > >   DEL dtd-parser-1.4.1.jar [62.47 ko]
> > >   DEL istack-commons-tools-3.0.8.jar [29.29 ko]
> > >   DEL jaxb-xjc-2.3.2.jar [903.20 ko]
> > >   DEL relaxng-datatype-2.3.2.jar [19.88 ko]
> > >   DEL rngom-2.3.2.jar [315.64 ko]
> > >   DEL xsom-2.3.2.jar [415.37 ko]
> > >
> > >   change: -3.80 MB
> > >   total : 44.57 MB
> > >
> > > apache-tomee 8.0.0-M3 plus (staging-1136)
> > >
> > >   DEL ant-1.10.5.jar [2216.65 ko]
> > >   DEL ant-launcher-1.10.5.jar [18.83 ko]
> > >   DEL asm-all-5.0.3.jar [241.64 ko]
> > >   DEL codemodel-2.3.2.jar [159.21 ko]
> > >   DEL dtd-parser-1.4.1.jar [62.47 ko]
> > >   DEL istack-commons-tools-3.0.8.jar [29.29 ko]
> > >   DEL jaxb-xjc-2.3.2.jar [903.20 ko]
> > >   DEL relaxng-datatype-2.3.2.jar [19.88 ko]
> > >   DEL rngom-2.3.2.jar [315.64 ko]
> > >   DEL xsom-2.3.2.jar [415.37 ko]
> > >
> > >   change: -3.80 MB
> > >   total : 61.36 MB
> > >
> > > apache-tomee 8.0.0-M3 plume (staging-1136)
> > >
> > >   DEL ant-1.10.5.jar [2216.65 ko]
> > >   DEL ant-launcher-1.10.5.jar [18.83 ko]
> > >   DEL asm-all-5.0.3.jar [241.64 ko]
> > >   DEL codemodel-2.3.2.jar [159.21 ko]
> > >   DEL dtd-parser-1.4.1.jar [62.47 ko]
> > >   DEL istack-commons-tools-3.0.8.jar [29.29 ko]
> > >   DEL jaxb-xjc-2.3.2.jar [903.20 ko]
> > >   DEL relaxng-datatype-2.3.2.jar [19.88 ko]
> > >   DEL rngom-2.3.2.jar [315.64 ko]
> > >   DEL xsom-2.3.2.jar [415.37 ko]
> > >
> > >   change: -3.80 MB
> > >   total : 68.20 MB
> > >
> > >
> > >
> > >
> > > --
> > > David Blevins
> > > http://twitter.com/dblevins
> > > http://www.tomitribe.com
> > >
> > >
> >
>

TomEE Example for jax-rs json provider with jettison

[César Hernández Mendoza]

Hi list!

I created an example of how to configure on TomEE 7.x or later the legacy
JSON provider, Jettison, used by TomEE 1.7.x .
This scenario is useful when REST applications are migrated from TomEE
1.7.x into TomEE 7.x or later and you want to keep the legacy JSON output
from Jettison 1.3.7.

The following are the corresponding JIRA Ticket and PR number. They are
ready to be reviewed.

[1] https://issues.apache.org/jira/browse/TOMEE-2530
[2] https://github.com/apache/tomee/pull/474

-- 
Atentamente:
César Hernández.

Re: [VOTE] TomEE 8.0.0-M3 (staging-1136) - take two

[David Blevins]

> On May 27, 2019, at 2:03 PM, Jonathan Gallimore 
>  wrote:
> 
> I think this is looking great, and a big thank you for the changes. I have
> one question, and I apologize for not picking this up last time around -
> we're now picking up the Eclipse Implementation of JAXB -
> https://projects.eclipse.org/projects/ee4j.jaxb-impl, and LICENCE and
> NOTICE files have shown up in its jar artifact, which previous versions
> didn't have.
> 
> The license in jakarta.xml.bind-api-2.3.2.jar (and runtime) is:
> 
> 
>Copyright (c) 2017, 2018 Oracle and/or its affiliates. All rights
> reserved.
> 
>Redistribution and use in source and binary forms, with or without
>modification, are permitted provided that the following conditions
>are met:
> 
>  - Redistributions of source code must retain the above copyright
>notice, this list of conditions and the following disclaimer.
> 
>  - Redistributions in binary form must reproduce the above copyright
>notice, this list of conditions and the following disclaimer in the
>documentation and/or other materials provided with the distribution.
> 
>  - Neither the name of the Eclipse Foundation, Inc. nor the names of
> its
>contributors may be used to endorse or promote products derived
>from this software without specific prior written permission.
> 
>THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS
>IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
> TO,
>THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE COPYRIGHT OWNER OR
>CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
>EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
>PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
>PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
>LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
>NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
>SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> 
> 
> Is this the same licence that of the previous jaxb-api?
> 
> Similar LICENCE/NOTICE files appear in: FastInfoSet, stax-ex, txw2.
> 
> Going forward, do we need to make changes to our LICENCE/NOTICE files for
> Jakarta artifacts from Eclipse?

That license is EDL 1.0, which is basically the BSD license.

 - https://www.eclipse.org/org/documents/edl-v10.php

There are flavors of this in the LICENSE file already.  We can definitely add 
this to our LICENSE file for future releases.  The Jakarta artifacts should be 
typically under the EPL 2.0.  Implementations may differ.


-David

Re: [VOTE] TomEE 8.0.0-M3 (staging-1136) - take two

[Jonathan Gallimore]

I think this is looking great, and a big thank you for the changes. I have
one question, and I apologize for not picking this up last time around -
we're now picking up the Eclipse Implementation of JAXB -
https://projects.eclipse.org/projects/ee4j.jaxb-impl, and LICENCE and
NOTICE files have shown up in its jar artifact, which previous versions
didn't have.

The license in jakarta.xml.bind-api-2.3.2.jar (and runtime) is:


Copyright (c) 2017, 2018 Oracle and/or its affiliates. All rights
reserved.

Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions
are met:

  - Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.

  - Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.

  - Neither the name of the Eclipse Foundation, Inc. nor the names of
its
contributors may be used to endorse or promote products derived
from this software without specific prior written permission.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS
IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
TO,
THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE COPYRIGHT OWNER OR
CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.


Is this the same licence that of the previous jaxb-api?

Similar LICENCE/NOTICE files appear in: FastInfoSet, stax-ex, txw2.

Going forward, do we need to make changes to our LICENCE/NOTICE files for
Jakarta artifacts from Eclipse?

Jon


On Thu, May 23, 2019 at 9:43 AM David Blevins 
wrote:

> Ok, the extra libraries have been removed and new M3 build created.  Vote
> will be open for 72 hours or as needed.
>
> Maven Repo:
>
>  - https://repository.apache.org/content/repositories/orgapachetomee-1136/
>
> Binaries & Source:
>
>  -
> https://dist.apache.org/repos/dist/dev/tomee/staging-1136/tomee-8.0.0-M3
>
> Binary comparison:
>
>  -
> https://dist.apache.org/repos/dist/dev/tomee/staging-1136/tomee-8.0.0-M3/DIFF.txt
>
> Here is a diff of the staging-1135 and staging-1136 builds.
>
> apache-tomee 8.0.0-M3 webprofile (staging-1136)
>
>   DEL ant-1.10.5.jar [2216.65 ko]
>   DEL ant-launcher-1.10.5.jar [18.83 ko]
>   DEL codemodel-2.3.2.jar [159.21 ko]
>   DEL dtd-parser-1.4.1.jar [62.47 ko]
>   DEL istack-commons-tools-3.0.8.jar [29.29 ko]
>   DEL jaxb-xjc-2.3.2.jar [903.20 ko]
>   DEL relaxng-datatype-2.3.2.jar [19.88 ko]
>   DEL rngom-2.3.2.jar [315.64 ko]
>   DEL xsom-2.3.2.jar [415.37 ko]
>
>   change: -3.59 MB
>   total : 41.72 MB
>
> apache-tomee 8.0.0-M3 microprofile (staging-1136)
>
>   DEL ant-1.10.5.jar [2216.65 ko]
>   DEL ant-launcher-1.10.5.jar [18.83 ko]
>   DEL asm-all-5.0.3.jar [241.64 ko]
>   DEL codemodel-2.3.2.jar [159.21 ko]
>   DEL dtd-parser-1.4.1.jar [62.47 ko]
>   DEL istack-commons-tools-3.0.8.jar [29.29 ko]
>   DEL jaxb-xjc-2.3.2.jar [903.20 ko]
>   DEL relaxng-datatype-2.3.2.jar [19.88 ko]
>   DEL rngom-2.3.2.jar [315.64 ko]
>   DEL xsom-2.3.2.jar [415.37 ko]
>
>   change: -3.80 MB
>   total : 44.57 MB
>
> apache-tomee 8.0.0-M3 plus (staging-1136)
>
>   DEL ant-1.10.5.jar [2216.65 ko]
>   DEL ant-launcher-1.10.5.jar [18.83 ko]
>   DEL asm-all-5.0.3.jar [241.64 ko]
>   DEL codemodel-2.3.2.jar [159.21 ko]
>   DEL dtd-parser-1.4.1.jar [62.47 ko]
>   DEL istack-commons-tools-3.0.8.jar [29.29 ko]
>   DEL jaxb-xjc-2.3.2.jar [903.20 ko]
>   DEL relaxng-datatype-2.3.2.jar [19.88 ko]
>   DEL rngom-2.3.2.jar [315.64 ko]
>   DEL xsom-2.3.2.jar [415.37 ko]
>
>   change: -3.80 MB
>   total : 61.36 MB
>
> apache-tomee 8.0.0-M3 plume (staging-1136)
>
>   DEL ant-1.10.5.jar [2216.65 ko]
>   DEL ant-launcher-1.10.5.jar [18.83 ko]
>   DEL asm-all-5.0.3.jar [241.64 ko]
>   DEL codemodel-2.3.2.jar [159.21 ko]
>   DEL dtd-parser-1.4.1.jar [62.47 ko]
>   DEL istack-commons-tools-3.0.8.jar [29.29 ko]
>   DEL jaxb-xjc-2.3.2.jar [903.20 ko]
>   DEL relaxng-datatype-2.3.2.jar [19.88 ko]
>   DEL rngom-2.3.2.jar [315.64 ko]
>   DEL xsom-2.3.2.jar [415.37 ko]
>
>   change: -3.80 MB
>   total : 68.20 MB
>
>
>
>
> --
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
>
>

Re: [VOTE] TomEE 8.0.0-M3 (staging-1136) - take two

[Marco Ferreira]

+1

On Mon, 27 May 2019, 16:03 Jean-Louis Monteiro, 
wrote:

> +1
> Thanks David
>
> Le jeu. 23 mai 2019 à 10:43, David Blevins  a
> écrit :
>
> > Ok, the extra libraries have been removed and new M3 build created.  Vote
> > will be open for 72 hours or as needed.
> >
> > Maven Repo:
> >
> >  -
> https://repository.apache.org/content/repositories/orgapachetomee-1136/
> >
> > Binaries & Source:
> >
> >  -
> > https://dist.apache.org/repos/dist/dev/tomee/staging-1136/tomee-8.0.0-M3
> >
> > Binary comparison:
> >
> >  -
> >
> https://dist.apache.org/repos/dist/dev/tomee/staging-1136/tomee-8.0.0-M3/DIFF.txt
> >
> > Here is a diff of the staging-1135 and staging-1136 builds.
> >
> > apache-tomee 8.0.0-M3 webprofile (staging-1136)
> >
> >   DEL ant-1.10.5.jar [2216.65 ko]
> >   DEL ant-launcher-1.10.5.jar [18.83 ko]
> >   DEL codemodel-2.3.2.jar [159.21 ko]
> >   DEL dtd-parser-1.4.1.jar [62.47 ko]
> >   DEL istack-commons-tools-3.0.8.jar [29.29 ko]
> >   DEL jaxb-xjc-2.3.2.jar [903.20 ko]
> >   DEL relaxng-datatype-2.3.2.jar [19.88 ko]
> >   DEL rngom-2.3.2.jar [315.64 ko]
> >   DEL xsom-2.3.2.jar [415.37 ko]
> >
> >   change: -3.59 MB
> >   total : 41.72 MB
> >
> > apache-tomee 8.0.0-M3 microprofile (staging-1136)
> >
> >   DEL ant-1.10.5.jar [2216.65 ko]
> >   DEL ant-launcher-1.10.5.jar [18.83 ko]
> >   DEL asm-all-5.0.3.jar [241.64 ko]
> >   DEL codemodel-2.3.2.jar [159.21 ko]
> >   DEL dtd-parser-1.4.1.jar [62.47 ko]
> >   DEL istack-commons-tools-3.0.8.jar [29.29 ko]
> >   DEL jaxb-xjc-2.3.2.jar [903.20 ko]
> >   DEL relaxng-datatype-2.3.2.jar [19.88 ko]
> >   DEL rngom-2.3.2.jar [315.64 ko]
> >   DEL xsom-2.3.2.jar [415.37 ko]
> >
> >   change: -3.80 MB
> >   total : 44.57 MB
> >
> > apache-tomee 8.0.0-M3 plus (staging-1136)
> >
> >   DEL ant-1.10.5.jar [2216.65 ko]
> >   DEL ant-launcher-1.10.5.jar [18.83 ko]
> >   DEL asm-all-5.0.3.jar [241.64 ko]
> >   DEL codemodel-2.3.2.jar [159.21 ko]
> >   DEL dtd-parser-1.4.1.jar [62.47 ko]
> >   DEL istack-commons-tools-3.0.8.jar [29.29 ko]
> >   DEL jaxb-xjc-2.3.2.jar [903.20 ko]
> >   DEL relaxng-datatype-2.3.2.jar [19.88 ko]
> >   DEL rngom-2.3.2.jar [315.64 ko]
> >   DEL xsom-2.3.2.jar [415.37 ko]
> >
> >   change: -3.80 MB
> >   total : 61.36 MB
> >
> > apache-tomee 8.0.0-M3 plume (staging-1136)
> >
> >   DEL ant-1.10.5.jar [2216.65 ko]
> >   DEL ant-launcher-1.10.5.jar [18.83 ko]
> >   DEL asm-all-5.0.3.jar [241.64 ko]
> >   DEL codemodel-2.3.2.jar [159.21 ko]
> >   DEL dtd-parser-1.4.1.jar [62.47 ko]
> >   DEL istack-commons-tools-3.0.8.jar [29.29 ko]
> >   DEL jaxb-xjc-2.3.2.jar [903.20 ko]
> >   DEL relaxng-datatype-2.3.2.jar [19.88 ko]
> >   DEL rngom-2.3.2.jar [315.64 ko]
> >   DEL xsom-2.3.2.jar [415.37 ko]
> >
> >   change: -3.80 MB
> >   total : 68.20 MB
> >
> >
> >
> >
> > --
> > David Blevins
> > http://twitter.com/dblevins
> > http://www.tomitribe.com
> >
> >
>

Re: PR Reviews -- volunteers needed

[Jean-Louis Monteiro]

Reviewed and merged. Thanks
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, May 27, 2019 at 9:19 PM Carl Mosca  wrote:

> https://github.com/tomitribe/docker-tomee/pull/33
>
> On Mon, May 27, 2019 at 9:39 AM Jean-Louis Monteiro <
> jlmonte...@tomitribe.com> wrote:
>
> > Can you point us to the PRs you are mentioning?
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> >
> > On Mon, May 27, 2019 at 2:08 PM Carl Mosca  wrote:
> >
> > > On that note, are there folks who review the Docker Tomee project pull
> > > requests or has this effort been moved/merged somewhere?
> > >
> > >
> > > On Mon, May 27, 2019 at 2:18 AM David Blevins  >
> > > wrote:
> > >
> > > > If you're looking for ways to contribute, a very very ... very major
> > way
> > > > is to help review PRs.
> > > >
> > > > We currently have 27 open PRs:
> > > >
> > > >  - https://github.com/apache/tomee/pulls
> > > >
> > > > You do not need special permission, authority or to be someone of
> "high
> > > > regard" or any such nonsense to help review PRs.  Your very first
> > > > contribution to the project could be to give another first
> contributor
> > a
> > > > bit of positive or constructive feedback in their PR.
> > > >
> > > > In an ideal world, this is exactly what happens.
> > > >
> > > > Think of how excited you get when you file your PR.  You may go back
> > and
> > > > click reload on the page all day and for the next two days till
> > > eventually
> > > > you stop checking and just wait to be notified.
> > > >
> > > > You have the power to give other people that magical feeling of
> getting
> > > > quick feedback over their hard work.
> > > >
> > > > Let's imagine two kinds of contributor and ask ourselves which is the
> > > more
> > > > valuable person:
> > > >
> > > >  - Jane has reviewed 10 PRs
> > > >  - Joe has submitted 10 PRs
> > > >
> > > > Jane is hands down more valuable and I would vote her into the
> project
> > as
> > > > committer far before Joe.  I would do that even if Jane did not have
> > one
> > > > commit of her own.
> > > >
> > > > Of course there are philosophical reasons such as Jane is showing she
> > is
> > > > concerned for others, wants to help new people and is overall focused
> > on
> > > > building the community around the project.  She is putting others
> above
> > > > herself.
> > > >
> > > > But there is also math at play.  For every Joe you need a Jane or PRs
> > > > don't get in.  In practice, Janes are in very short supply.  In our
> > > current
> > > > state, there are 27 Joes and very few Janes.
> > > >
> > > > If you want to have a major impact in just an hour or two a week,
> your
> > > > todo list is not JIRA, it's right here:
> > > >
> > > >  - https://github.com/apache/tomee/pulls
> > > >
> > > >
> > > > --
> > > > David Blevins
> > > > http://twitter.com/dblevins
> > > > http://www.tomitribe.com
> > > >
> > > >
> > >
> > > --
> > > Carl J. Mosca
> > >
> >
>
>
> --
> Carl J. Mosca
>

Re: PR Reviews -- volunteers needed

[Carl Mosca]

https://github.com/tomitribe/docker-tomee/pull/33

On Mon, May 27, 2019 at 9:39 AM Jean-Louis Monteiro <
jlmonte...@tomitribe.com> wrote:

> Can you point us to the PRs you are mentioning?
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Mon, May 27, 2019 at 2:08 PM Carl Mosca  wrote:
>
> > On that note, are there folks who review the Docker Tomee project pull
> > requests or has this effort been moved/merged somewhere?
> >
> >
> > On Mon, May 27, 2019 at 2:18 AM David Blevins 
> > wrote:
> >
> > > If you're looking for ways to contribute, a very very ... very major
> way
> > > is to help review PRs.
> > >
> > > We currently have 27 open PRs:
> > >
> > >  - https://github.com/apache/tomee/pulls
> > >
> > > You do not need special permission, authority or to be someone of "high
> > > regard" or any such nonsense to help review PRs.  Your very first
> > > contribution to the project could be to give another first contributor
> a
> > > bit of positive or constructive feedback in their PR.
> > >
> > > In an ideal world, this is exactly what happens.
> > >
> > > Think of how excited you get when you file your PR.  You may go back
> and
> > > click reload on the page all day and for the next two days till
> > eventually
> > > you stop checking and just wait to be notified.
> > >
> > > You have the power to give other people that magical feeling of getting
> > > quick feedback over their hard work.
> > >
> > > Let's imagine two kinds of contributor and ask ourselves which is the
> > more
> > > valuable person:
> > >
> > >  - Jane has reviewed 10 PRs
> > >  - Joe has submitted 10 PRs
> > >
> > > Jane is hands down more valuable and I would vote her into the project
> as
> > > committer far before Joe.  I would do that even if Jane did not have
> one
> > > commit of her own.
> > >
> > > Of course there are philosophical reasons such as Jane is showing she
> is
> > > concerned for others, wants to help new people and is overall focused
> on
> > > building the community around the project.  She is putting others above
> > > herself.
> > >
> > > But there is also math at play.  For every Joe you need a Jane or PRs
> > > don't get in.  In practice, Janes are in very short supply.  In our
> > current
> > > state, there are 27 Joes and very few Janes.
> > >
> > > If you want to have a major impact in just an hour or two a week, your
> > > todo list is not JIRA, it's right here:
> > >
> > >  - https://github.com/apache/tomee/pulls
> > >
> > >
> > > --
> > > David Blevins
> > > http://twitter.com/dblevins
> > > http://www.tomitribe.com
> > >
> > >
> >
> > --
> > Carl J. Mosca
> >
>


-- 
Carl J. Mosca

Re: Build broken due to compilation issues on mp-metrics-gauge

[David Blevins]

> On May 27, 2019, at 11:40 AM, David Blevins  wrote:
> 
> Looks like there are some test failures with them.
> 
> I swear that one passed for me, but it may have been before the merge that I 
> tested it.

Fixed.

Next issue looks like we have intermittent failures in the itests.

Not sure what's going on there.

-David

Re: Build broken due to compilation issues on mp-metrics-gauge

[Jean-Louis Monteiro]

I fixed the compilation issue. That's it. Builds were running so dunno if
some tests were failing.

Le lun. 27 mai 2019 à 20:40, David Blevins  a
écrit :

> Looks like there are some test failures with them.
>
> I swear that one passed for me, but it may have been before the merge that
> I tested it.
>
>
> -David
>
> > On May 27, 2019, at 11:28 AM, Jean-Louis Monteiro <
> jlmonte...@tomitribe.com> wrote:
> >
> > I fixed it already never mind.
> >
> > Le lun. 27 mai 2019 à 20:23, David Blevins  a
> > écrit :
> >
> >>
> >>> On May 27, 2019, at 6:10 AM, Jean-Louis Monteiro <
> >> jlmonte...@tomitribe.com> wrote:
> >>>
> >>> Is someone working on the compilation issues with mp-metrics-gauge
> >> example?
> >>>
> >>> Looks like build is broken
> >>
> >> I'll take a look as I merged it.
> >>
> >> It compiled for me.
> >>
> >> -David
> >>
> >>
>
>

Re: [VOTE] TomEE 8.0.0-M3 (staging-1136) - take two

[Jean-Louis Monteiro]

+1
Thanks David

Le jeu. 23 mai 2019 à 10:43, David Blevins  a
écrit :

> Ok, the extra libraries have been removed and new M3 build created.  Vote
> will be open for 72 hours or as needed.
>
> Maven Repo:
>
>  - https://repository.apache.org/content/repositories/orgapachetomee-1136/
>
> Binaries & Source:
>
>  -
> https://dist.apache.org/repos/dist/dev/tomee/staging-1136/tomee-8.0.0-M3
>
> Binary comparison:
>
>  -
> https://dist.apache.org/repos/dist/dev/tomee/staging-1136/tomee-8.0.0-M3/DIFF.txt
>
> Here is a diff of the staging-1135 and staging-1136 builds.
>
> apache-tomee 8.0.0-M3 webprofile (staging-1136)
>
>   DEL ant-1.10.5.jar [2216.65 ko]
>   DEL ant-launcher-1.10.5.jar [18.83 ko]
>   DEL codemodel-2.3.2.jar [159.21 ko]
>   DEL dtd-parser-1.4.1.jar [62.47 ko]
>   DEL istack-commons-tools-3.0.8.jar [29.29 ko]
>   DEL jaxb-xjc-2.3.2.jar [903.20 ko]
>   DEL relaxng-datatype-2.3.2.jar [19.88 ko]
>   DEL rngom-2.3.2.jar [315.64 ko]
>   DEL xsom-2.3.2.jar [415.37 ko]
>
>   change: -3.59 MB
>   total : 41.72 MB
>
> apache-tomee 8.0.0-M3 microprofile (staging-1136)
>
>   DEL ant-1.10.5.jar [2216.65 ko]
>   DEL ant-launcher-1.10.5.jar [18.83 ko]
>   DEL asm-all-5.0.3.jar [241.64 ko]
>   DEL codemodel-2.3.2.jar [159.21 ko]
>   DEL dtd-parser-1.4.1.jar [62.47 ko]
>   DEL istack-commons-tools-3.0.8.jar [29.29 ko]
>   DEL jaxb-xjc-2.3.2.jar [903.20 ko]
>   DEL relaxng-datatype-2.3.2.jar [19.88 ko]
>   DEL rngom-2.3.2.jar [315.64 ko]
>   DEL xsom-2.3.2.jar [415.37 ko]
>
>   change: -3.80 MB
>   total : 44.57 MB
>
> apache-tomee 8.0.0-M3 plus (staging-1136)
>
>   DEL ant-1.10.5.jar [2216.65 ko]
>   DEL ant-launcher-1.10.5.jar [18.83 ko]
>   DEL asm-all-5.0.3.jar [241.64 ko]
>   DEL codemodel-2.3.2.jar [159.21 ko]
>   DEL dtd-parser-1.4.1.jar [62.47 ko]
>   DEL istack-commons-tools-3.0.8.jar [29.29 ko]
>   DEL jaxb-xjc-2.3.2.jar [903.20 ko]
>   DEL relaxng-datatype-2.3.2.jar [19.88 ko]
>   DEL rngom-2.3.2.jar [315.64 ko]
>   DEL xsom-2.3.2.jar [415.37 ko]
>
>   change: -3.80 MB
>   total : 61.36 MB
>
> apache-tomee 8.0.0-M3 plume (staging-1136)
>
>   DEL ant-1.10.5.jar [2216.65 ko]
>   DEL ant-launcher-1.10.5.jar [18.83 ko]
>   DEL asm-all-5.0.3.jar [241.64 ko]
>   DEL codemodel-2.3.2.jar [159.21 ko]
>   DEL dtd-parser-1.4.1.jar [62.47 ko]
>   DEL istack-commons-tools-3.0.8.jar [29.29 ko]
>   DEL jaxb-xjc-2.3.2.jar [903.20 ko]
>   DEL relaxng-datatype-2.3.2.jar [19.88 ko]
>   DEL rngom-2.3.2.jar [315.64 ko]
>   DEL xsom-2.3.2.jar [415.37 ko]
>
>   change: -3.80 MB
>   total : 68.20 MB
>
>
>
>
> --
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
>
>

Re: Build broken due to compilation issues on mp-metrics-gauge

[Jean-Louis Monteiro]

I fixed it already never mind.

Le lun. 27 mai 2019 à 20:23, David Blevins  a
écrit :

>
> > On May 27, 2019, at 6:10 AM, Jean-Louis Monteiro <
> jlmonte...@tomitribe.com> wrote:
> >
> > Is someone working on the compilation issues with mp-metrics-gauge
> example?
> >
> > Looks like build is broken
>
> I'll take a look as I merged it.
>
> It compiled for me.
>
> -David
>
>

Re: Build broken due to compilation issues on mp-metrics-gauge

[David Blevins]

> On May 27, 2019, at 6:10 AM, Jean-Louis Monteiro  
> wrote:
> 
> Is someone working on the compilation issues with mp-metrics-gauge example?
> 
> Looks like build is broken

I'll take a look as I merged it.

It compiled for me.

-David

Re: Breaking example rules

[David Blevins]

Good catch.  We definitely haven't changed the philosophy on examples. They all 
need to be fixed.


> On May 27, 2019, at 10:20 AM, Jean-Louis Monteiro  
> wrote:
> 
> Here is what I can see on master for example
> 
> *find . -name pom.xml |xargs grep ''*

Here's another way to try that

$ grep "" examples/*/pom.xml
examples/mp-metrics-gauge/pom.xml:
examples/mp-metrics-metered/pom.xml:  
examples/mp-opentracing-traced/pom.xml:  

I'll fix mp-metrics-gauge while I'm dealing with the compile issue.


-David

Re: Breaking example rules

[Jean-Louis Monteiro]

Here is what I can see on master for example

*find . -name pom.xml |xargs grep ''*
















*./polling-parent/polling-domain/pom.xml:
 ./polling-parent/polling-client/pom.xml:
 ./polling-parent/polling-web/pom.xml:
 ./polling-parent/polling-mdb/pom.xml:
 ./polling-parent/polling-core/pom.xml:
 ./connector-ear/connector-sample-ear/pom.xml:
 ./connector-ear/connector-sample-api/pom.xml:
 ./connector-ear/connector-sample-war/pom.xml:
 ./connector-ear/connector-sample-functional-tests/pom.xml:
 ./connector-ear/connector-sample-impl/pom.xml:
 ./connector-ear/connector-sample-rar/pom.xml:  ./pom.xml:
 ./quartz-app/quartz-beans/pom.xml:
 ./quartz-app/quartz-ra/pom.xml:
 ./resources-jmx-example/resources-jmx-ear/pom.xml:
 ./resources-jmx-example/resources-jmx-ejb/pom.xml:  *
*./mp-opentracing-traced/pom.xml:
*./simple-ear/moviefun-webapp/pom.xml:
 
./simple-ear/moviefun-business-model/pom.xml:  
./simple-ear/moviefun-ear/pom.xml:  
./simple-ear/moviefun-functional-tests/pom.xml:  
./simple-ear/moviefun-business-logic/pom.xml:  
./ear-testing/business-model/pom.xml:  
./ear-testing/business-logic/pom.xml:  
*./mp-metrics-metered/pom.xml:  *
./bval-evaluation-redeployment/WebApp1/pom.xml:  
./bval-evaluation-redeployment/runner/pom.xml:  
./bval-evaluation-redeployment/WebApp2/pom.xml:  

So far I can see 2 which are referencing a parent where they should not.
The other are multi-module samples so as soon as the aggregator does not
reference a parent, it's fine for sub-modules to do so

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, May 27, 2019 at 7:15 PM David Salter 
wrote:

> Hi Jean-Louis,
>
> I’m a fan of the simple samples and this is one of the things I love about
> TomEE.
>
> Do you have more details on which samples aren’t self contained?  I’d be
> happy to help do some refactoring to make them easier to understand.
>
> Thanks
>
> David.
>
> On Mon, 27 May 2019 at 14:24, Jean-Louis Monteiro <
> jlmonte...@tomitribe.com>
> wrote:
>
> > Hi,
> >
> > I started contributing a long time ago to TomEE. What made me get into
> Java
> > EE and TomEE was the examples.
> >
> > They were simple, easy to run and self contained.
> >
> > Looks like on the last part, we haven't done a good job.
> > Or did we decided to relax the "self contained" part and now have
> examples
> > depending on the TomEE reactor and build?
> >
> > I am currently fixing an microprofile example and realized that we were
> > breaking this rule.
> >
> > Any feedback is appreciated so I can fix the other examples too.
> >
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
>

Re: Breaking example rules

[David Salter]

Hi Jean-Louis,

I’m a fan of the simple samples and this is one of the things I love about
TomEE.

Do you have more details on which samples aren’t self contained?  I’d be
happy to help do some refactoring to make them easier to understand.

Thanks

David.

On Mon, 27 May 2019 at 14:24, Jean-Louis Monteiro 
wrote:

> Hi,
>
> I started contributing a long time ago to TomEE. What made me get into Java
> EE and TomEE was the examples.
>
> They were simple, easy to run and self contained.
>
> Looks like on the last part, we haven't done a good job.
> Or did we decided to relax the "self contained" part and now have examples
> depending on the TomEE reactor and build?
>
> I am currently fixing an microprofile example and realized that we were
> breaking this rule.
>
> Any feedback is appreciated so I can fix the other examples too.
>
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>

Re: New Issue and PR

[David Salter]

Davids FTW !

Thanks David.

The page looks all good now :)

I’ve added a comment into Jira stating this, so the issue can now be closed:

https://issues.apache.org/jira/browse/TOMEE-2527 


Thanks.

David.

> On 27 May 2019, at 06:04, David Blevins  wrote:
> 
>> On May 26, 2019, at 3:53 AM, David Salter  
>> wrote:
>> 
>> Thanks. That makes sense. 
>> 
>> As long as I’m on track, I’ll keep going. I’ve got a few more updates I’ll 
>> create issues and PRs for :)
> 
> That sounds fantastic!  On this example, I regenerated and did a manual tweak 
> of the resulting html -- this seems to be what's required on "stuck" pages 
> for some reason.  Does this look good?
> 
> - http://localhost:8080/tomee-8.0/docs/activemqresourceadapter-config.html
> 
> Side note, it's fun to have another David on the project again :)  People 
> used to mistake me for David Jencks quite regularly.
> 
> I wonder how many Davids we can get on this thread :)
> 
> 
> -David
> 

[GitHub] [tomee] rzo1 commented on issue #104: HTTP(s) basic auth failed if password contained ampersand passed via …

[GitBox]

rzo1 commented on issue #104: HTTP(s) basic auth failed if password contained 
ampersand passed via …
URL: https://github.com/apache/tomee/pull/104#issuecomment-496218991
 
 
   I can follow your explanation. I took a quick look into 
`MulticastConnectionFactory` and confirm, that the decoding is happening twice. 
I think, that we do not have a related JIRA ticket for this issue.
   
   I think, that we can enhance the test-case with `try-with-resources` and 
without the `e.printStacktrace()` statements inside the test-case.
   
   WDYT @jeanouii ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: PR Reviews -- volunteers needed

[Jean-Louis Monteiro]

Can you point us to the PRs you are mentioning?
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, May 27, 2019 at 2:08 PM Carl Mosca  wrote:

> On that note, are there folks who review the Docker Tomee project pull
> requests or has this effort been moved/merged somewhere?
>
>
> On Mon, May 27, 2019 at 2:18 AM David Blevins 
> wrote:
>
> > If you're looking for ways to contribute, a very very ... very major way
> > is to help review PRs.
> >
> > We currently have 27 open PRs:
> >
> >  - https://github.com/apache/tomee/pulls
> >
> > You do not need special permission, authority or to be someone of "high
> > regard" or any such nonsense to help review PRs.  Your very first
> > contribution to the project could be to give another first contributor a
> > bit of positive or constructive feedback in their PR.
> >
> > In an ideal world, this is exactly what happens.
> >
> > Think of how excited you get when you file your PR.  You may go back and
> > click reload on the page all day and for the next two days till
> eventually
> > you stop checking and just wait to be notified.
> >
> > You have the power to give other people that magical feeling of getting
> > quick feedback over their hard work.
> >
> > Let's imagine two kinds of contributor and ask ourselves which is the
> more
> > valuable person:
> >
> >  - Jane has reviewed 10 PRs
> >  - Joe has submitted 10 PRs
> >
> > Jane is hands down more valuable and I would vote her into the project as
> > committer far before Joe.  I would do that even if Jane did not have one
> > commit of her own.
> >
> > Of course there are philosophical reasons such as Jane is showing she is
> > concerned for others, wants to help new people and is overall focused on
> > building the community around the project.  She is putting others above
> > herself.
> >
> > But there is also math at play.  For every Joe you need a Jane or PRs
> > don't get in.  In practice, Janes are in very short supply.  In our
> current
> > state, there are 27 Joes and very few Janes.
> >
> > If you want to have a major impact in just an hour or two a week, your
> > todo list is not JIRA, it's right here:
> >
> >  - https://github.com/apache/tomee/pulls
> >
> >
> > --
> > David Blevins
> > http://twitter.com/dblevins
> > http://www.tomitribe.com
> >
> >
>
> --
> Carl J. Mosca
>

Breaking example rules

[Jean-Louis Monteiro]

Hi,

I started contributing a long time ago to TomEE. What made me get into Java
EE and TomEE was the examples.

They were simple, easy to run and self contained.

Looks like on the last part, we haven't done a good job.
Or did we decided to relax the "self contained" part and now have examples
depending on the TomEE reactor and build?

I am currently fixing an microprofile example and realized that we were
breaking this rule.

Any feedback is appreciated so I can fix the other examples too.

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com

[GitHub] [tomee] rzo1 commented on issue #427: TOMEE-2481 - Move code using PropertyEditors (deprectaed class) to PropertyEditorRegistry

[GitBox]

rzo1 commented on issue #427:  TOMEE-2481 - Move code using PropertyEditors 
(deprectaed class) to PropertyEditorRegistry
URL: https://github.com/apache/tomee/pull/427#issuecomment-496209284
 
 
   @danielsoro can you resolve the conflicht in `ClaimBean.java` ?
   
   @jgallimore I agree with your thoughs. I also think, that the 
`PropertyEditorRegistry` should be tied to the lifecycle of the component using 
it. Should we change this inside this PR or open a new JIRA and do this 
optimization work in a separate branch / take it as a feature? I would be +1 
for the JIRA option.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build broken due to compilation issues on mp-metrics-gauge

[Jean-Louis Monteiro]

Is someone working on the compilation issues with mp-metrics-gauge example?

Looks like build is broken

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com

Re: PR Reviews -- volunteers needed

[Daniel Dias Dos Santos]

very good it .
--
Daniel Dias dos Santos
Java Developer
SouJava & JCP Member
GitHub: https://github.com/Daniel-Dos
Linkedin: www.linkedin.com/in/danieldiasjava
Twitter: http://twitter.com/danieldiasjava

Em seg, 27 de mai de 2019 às 09:08, Carl Mosca  escreveu:
>
> On that note, are there folks who review the Docker Tomee project pull
> requests or has this effort been moved/merged somewhere?
>
>
> On Mon, May 27, 2019 at 2:18 AM David Blevins 
> wrote:
>
> > If you're looking for ways to contribute, a very very ... very major way
> > is to help review PRs.
> >
> > We currently have 27 open PRs:
> >
> >  - https://github.com/apache/tomee/pulls
> >
> > You do not need special permission, authority or to be someone of "high
> > regard" or any such nonsense to help review PRs.  Your very first
> > contribution to the project could be to give another first contributor a
> > bit of positive or constructive feedback in their PR.
> >
> > In an ideal world, this is exactly what happens.
> >
> > Think of how excited you get when you file your PR.  You may go back and
> > click reload on the page all day and for the next two days till eventually
> > you stop checking and just wait to be notified.
> >
> > You have the power to give other people that magical feeling of getting
> > quick feedback over their hard work.
> >
> > Let's imagine two kinds of contributor and ask ourselves which is the more
> > valuable person:
> >
> >  - Jane has reviewed 10 PRs
> >  - Joe has submitted 10 PRs
> >
> > Jane is hands down more valuable and I would vote her into the project as
> > committer far before Joe.  I would do that even if Jane did not have one
> > commit of her own.
> >
> > Of course there are philosophical reasons such as Jane is showing she is
> > concerned for others, wants to help new people and is overall focused on
> > building the community around the project.  She is putting others above
> > herself.
> >
> > But there is also math at play.  For every Joe you need a Jane or PRs
> > don't get in.  In practice, Janes are in very short supply.  In our current
> > state, there are 27 Joes and very few Janes.
> >
> > If you want to have a major impact in just an hour or two a week, your
> > todo list is not JIRA, it's right here:
> >
> >  - https://github.com/apache/tomee/pulls
> >
> >
> > --
> > David Blevins
> > http://twitter.com/dblevins
> > http://www.tomitribe.com
> >
> >
>
> --
> Carl J. Mosca

[GitHub] [tomee] jeanouii commented on issue #455: TOMEE-2504 - Upgrade xbean to 4.13

[GitBox]

jeanouii commented on issue #455: TOMEE-2504 - Upgrade xbean to 4.13
URL: https://github.com/apache/tomee/pull/455#issuecomment-496207622
 
 
   Closing this one to create a new one for 4.14
   Thanks @rzo1 for the heads up


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [tomee] jeanouii closed pull request #455: TOMEE-2504 - Upgrade xbean to 4.13

[GitBox]

jeanouii closed pull request #455: TOMEE-2504 - Upgrade xbean to 4.13
URL: https://github.com/apache/tomee/pull/455
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [tomee] jeanouii closed pull request #456: TOMEE-2504 - Upgrade xbean to 4.13

[GitBox]

jeanouii closed pull request #456: TOMEE-2504 - Upgrade xbean to 4.13
URL: https://github.com/apache/tomee/pull/456
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [tomee] jeanouii commented on issue #456: TOMEE-2504 - Upgrade xbean to 4.13

[GitBox]

jeanouii commented on issue #456: TOMEE-2504 - Upgrade xbean to 4.13
URL: https://github.com/apache/tomee/pull/456#issuecomment-496207392
 
 
   I'll close this PR and open a new one for 4.14


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: PR Reviews -- volunteers needed

[Carl Mosca]

On that note, are there folks who review the Docker Tomee project pull
requests or has this effort been moved/merged somewhere?


On Mon, May 27, 2019 at 2:18 AM David Blevins 
wrote:

> If you're looking for ways to contribute, a very very ... very major way
> is to help review PRs.
>
> We currently have 27 open PRs:
>
>  - https://github.com/apache/tomee/pulls
>
> You do not need special permission, authority or to be someone of "high
> regard" or any such nonsense to help review PRs.  Your very first
> contribution to the project could be to give another first contributor a
> bit of positive or constructive feedback in their PR.
>
> In an ideal world, this is exactly what happens.
>
> Think of how excited you get when you file your PR.  You may go back and
> click reload on the page all day and for the next two days till eventually
> you stop checking and just wait to be notified.
>
> You have the power to give other people that magical feeling of getting
> quick feedback over their hard work.
>
> Let's imagine two kinds of contributor and ask ourselves which is the more
> valuable person:
>
>  - Jane has reviewed 10 PRs
>  - Joe has submitted 10 PRs
>
> Jane is hands down more valuable and I would vote her into the project as
> committer far before Joe.  I would do that even if Jane did not have one
> commit of her own.
>
> Of course there are philosophical reasons such as Jane is showing she is
> concerned for others, wants to help new people and is overall focused on
> building the community around the project.  She is putting others above
> herself.
>
> But there is also math at play.  For every Joe you need a Jane or PRs
> don't get in.  In practice, Janes are in very short supply.  In our current
> state, there are 27 Joes and very few Janes.
>
> If you want to have a major impact in just an hour or two a week, your
> todo list is not JIRA, it's right here:
>
>  - https://github.com/apache/tomee/pulls
>
>
> --
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
>
>

-- 
Carl J. Mosca

[GitHub] [tomee] rzo1 commented on issue #456: TOMEE-2504 - Upgrade xbean to 4.13

[GitBox]

rzo1 commented on issue #456: TOMEE-2504 - Upgrade xbean to 4.13
URL: https://github.com/apache/tomee/pull/456#issuecomment-496177034
 
 
   Also updates to `asm7` in shaded artifacts, which is required for J11 :) - 
any ideas, if https://issues.apache.org/jira/browse/XBEAN-318 has an impact on 
this as well? (see also https://github.com/apache/tomee/pull/455)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [tomee] rzo1 commented on issue #452: Make ArrayEnumeration generics aware

[GitBox]

rzo1 commented on issue #452: Make ArrayEnumeration generics aware
URL: https://github.com/apache/tomee/pull/452#issuecomment-496175185
 
 
   We have a similar class `ArrayEnumeration` in `org.apache.openejb.client`. 
Shouldn't we change it there too?
   
   Besides that, I agree with @AndyGee : Some syntax changes -> shouldn't be a 
problem.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [tomee] rzo1 commented on issue #451: Deprecate unused method (tomee-2499)

[GitBox]

rzo1 commented on issue #451: Deprecate unused method (tomee-2499)
URL: https://github.com/apache/tomee/pull/451#issuecomment-496172893
 
 
   @dblevins This PR "only" adds a `@Deprecated` - I think, this is fine (no 
impact on the existing code-base), see 
https://issues.apache.org/jira/projects/TOMEE/issues/TOMEE-2499
   
   @doychin Shouldn't we backport it for 7.0.x / 7.1.x ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

PR Reviews -- volunteers needed

[David Blevins]

If you're looking for ways to contribute, a very very ... very major way is to 
help review PRs.

We currently have 27 open PRs:

 - https://github.com/apache/tomee/pulls

You do not need special permission, authority or to be someone of "high regard" 
or any such nonsense to help review PRs.  Your very first contribution to the 
project could be to give another first contributor a bit of positive or 
constructive feedback in their PR.  

In an ideal world, this is exactly what happens.

Think of how excited you get when you file your PR.  You may go back and click 
reload on the page all day and for the next two days till eventually you stop 
checking and just wait to be notified.

You have the power to give other people that magical feeling of getting quick 
feedback over their hard work.

Let's imagine two kinds of contributor and ask ourselves which is the more 
valuable person:

 - Jane has reviewed 10 PRs
 - Joe has submitted 10 PRs

Jane is hands down more valuable and I would vote her into the project as 
committer far before Joe.  I would do that even if Jane did not have one commit 
of her own.

Of course there are philosophical reasons such as Jane is showing she is 
concerned for others, wants to help new people and is overall focused on 
building the community around the project.  She is putting others above herself.

But there is also math at play.  For every Joe you need a Jane or PRs don't get 
in.  In practice, Janes are in very short supply.  In our current state, there 
are 27 Joes and very few Janes.

If you want to have a major impact in just an hour or two a week, your todo 
list is not JIRA, it's right here:

 - https://github.com/apache/tomee/pulls


-- 
David Blevins
http://twitter.com/dblevins
http://www.tomitribe.com