[GitHub] [yunikorn-release] craigcondit closed pull request #124: [YUNIKORN-1540] Fix default placeholder image in documentation
craigcondit closed pull request #124: [YUNIKORN-1540] Fix default placeholder image in documentation URL: https://github.com/apache/yunikorn-release/pull/124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit opened a new pull request, #124: [YUNIKORN-1540] Fix default placeholder image in documentation
craigcondit opened a new pull request, #124: URL: https://github.com/apache/yunikorn-release/pull/124 JIRA: https://issues.apache.org/jira/browse/YUNIKORN-1540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] yuchaoran2011 merged pull request #123: [YUNIKORN-1495]Update the copyright years in NOTICE files to 2023
yuchaoran2011 merged PR #123: URL: https://github.com/apache/yunikorn-release/pull/123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] HuangTing-Yao opened a new pull request, #123: [YUNIKORN-1495]Update the copyright years in NOTICE files to 2023
HuangTing-Yao opened a new pull request, #123: URL: https://github.com/apache/yunikorn-release/pull/123 update NOTICE files in root fodler and top-level-artifacts folder https://issues.apache.org/jira/browse/YUNIKORN-1495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] wilfred-s closed pull request #122: [YUNIKORN-1501] Update helm chart README.md to reflect K8s 1.26 support
wilfred-s closed pull request #122: [YUNIKORN-1501] Update helm chart README.md to reflect K8s 1.26 support URL: https://github.com/apache/yunikorn-release/pull/122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit opened a new pull request, #122: [YUNIKORN-1501] Update helm chart README.md to reflect K8s 1.26 support
craigcondit opened a new pull request, #122: URL: https://github.com/apache/yunikorn-release/pull/122 JIRA: https://issues.apache.org/jira/browse/YUNIKORN-1500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit closed pull request #121: [YUNIKORN-1474] Add LF to the end of Chart.yaml
craigcondit closed pull request #121: [YUNIKORN-1474] Add LF to the end of Chart.yaml URL: https://github.com/apache/yunikorn-release/pull/121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit closed pull request #120: [YUNIKORN-1470] Helm: Add permission to read priority classes
craigcondit closed pull request #120: [YUNIKORN-1470] Helm: Add permission to read priority classes URL: https://github.com/apache/yunikorn-release/pull/120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit opened a new pull request, #120: [YUNIKORN-1470] Helm: Add permission to read priority classes
craigcondit opened a new pull request, #120: URL: https://github.com/apache/yunikorn-release/pull/120 JIRA: https://issues.apache.org/jira/browse/YUNIKORN-1470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] elihschiff commented on a diff in pull request #116: [YUNIKORN-1371] Migrate to new ConfigMap configuration
elihschiff commented on code in PR #116:
URL: https://github.com/apache/yunikorn-release/pull/116#discussion_r1035312940
##
helm-charts/yunikorn/templates/deployment.yaml:
##
@@ -24,7 +24,7 @@ metadata:
release: {{ .Release.Name }}
heritage: {{ .Release.Service }}
spec:
- replicas: {{ .Values.replicaCount }}
+ replicas: 1
Review Comment:
Got it, thanks for the quick reply!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit commented on a diff in pull request #116: [YUNIKORN-1371] Migrate to new ConfigMap configuration
craigcondit commented on code in PR #116:
URL: https://github.com/apache/yunikorn-release/pull/116#discussion_r1035309845
##
helm-charts/yunikorn/templates/deployment.yaml:
##
@@ -24,7 +24,7 @@ metadata:
release: {{ .Release.Name }}
heritage: {{ .Release.Service }}
spec:
- replicas: {{ .Values.replicaCount }}
+ replicas: 1
Review Comment:
@elihschiff, it never did (for the scheduler itself), only for the admission
controller, which has its own variable. Setting it >1 causes a lot of problems,
so it was removed. YuniKorn is designed to recover very rapidly without any
shared state, so having two active schedulers is not necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] elihschiff commented on a diff in pull request #116: [YUNIKORN-1371] Migrate to new ConfigMap configuration
elihschiff commented on code in PR #116:
URL: https://github.com/apache/yunikorn-release/pull/116#discussion_r1035307098
##
helm-charts/yunikorn/templates/deployment.yaml:
##
@@ -24,7 +24,7 @@ metadata:
release: {{ .Release.Name }}
heritage: {{ .Release.Service }}
spec:
- replicas: {{ .Values.replicaCount }}
+ replicas: 1
Review Comment:
Hi @craigcondit
I am just curious about the decision on why the replicas value is now hard
coded. Does this feature no longer work with values > 1? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit closed pull request #119: [YUNIKORN-1429] Fix syntax ingress error
craigcondit closed pull request #119: [YUNIKORN-1429] Fix syntax ingress error URL: https://github.com/apache/yunikorn-release/pull/119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] yuchaoran2011 merged pull request #118: [YUNIKORN-1429] Add ingress for Web UI
yuchaoran2011 merged PR #118: URL: https://github.com/apache/yunikorn-release/pull/118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] marload commented on a diff in pull request #118: [YUNIKORN-1429] Add ingress for Web UI
marload commented on code in PR #118:
URL: https://github.com/apache/yunikorn-release/pull/118#discussion_r1034286297
##
helm-charts/yunikorn/templates/ingress.yaml:
##
@@ -0,0 +1,62 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+{{- if .Values.ingress.enabled -}}
+{{- $ingressPathType := .Values.ingress.pathType -}}
+{{- $svcPort := .Values.service.portWeb -}}
Review Comment:
I reflect your review. Thanks for you review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] wilfred-s closed pull request #117: [YUNIKORN-1171] update .asf.yaml with new options
wilfred-s closed pull request #117: [YUNIKORN-1171] update .asf.yaml with new options URL: https://github.com/apache/yunikorn-release/pull/117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit commented on a diff in pull request #118: [YUNIKORN-1429] Add ingress for Web UI
craigcondit commented on code in PR #118:
URL: https://github.com/apache/yunikorn-release/pull/118#discussion_r1034147274
##
helm-charts/yunikorn/templates/ingress.yaml:
##
@@ -0,0 +1,62 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+{{- if .Values.ingress.enabled -}}
+{{- $ingressPathType := .Values.ingress.pathType -}}
+{{- $svcPort := .Values.service.portWeb -}}
Review Comment:
I think we should only expose variables that are intended for the end user
to change. Variables are not intended as shorthand for the templates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] yuchaoran2011 commented on a diff in pull request #118: [YUNIKORN-1429] Add ingress for Web UI
yuchaoran2011 commented on code in PR #118:
URL: https://github.com/apache/yunikorn-release/pull/118#discussion_r1033186970
##
helm-charts/yunikorn/templates/ingress.yaml:
##
@@ -0,0 +1,62 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+{{- if .Values.ingress.enabled -}}
+{{- $ingressPathType := .Values.ingress.pathType -}}
+{{- $svcPort := .Values.service.portWeb -}}
Review Comment:
Nit: `.Values.ingress.pathType` and `.Values.service.portWeb` are only used
once each in this file, probably no need to have variables for them. On the
other hand, `.Values.ingress.tls` is referred to more than once and yet no
variable is created for it. I suggest just stick to using `.Values.`
in all places. The rest of the PR LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] marload opened a new pull request, #118: [YUNIKORN-1429] Add ingress for Web UI
marload opened a new pull request, #118: URL: https://github.com/apache/yunikorn-release/pull/118 Ingress is required for access from outside the cluster. Create an ingress resource. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] wilfred-s opened a new pull request, #117: [YUNIKORN-1171] update .asf.yaml with new options
wilfred-s opened a new pull request, #117: URL: https://github.com/apache/yunikorn-release/pull/117 Use the same settings for all code repositories. Turn off wiki on all repos. Remove incubating from the description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit commented on pull request #110: [YUNIKORN-1261] Add pre-upgrade hook
craigcondit commented on PR #110: URL: https://github.com/apache/yunikorn-release/pull/110#issuecomment-1320268836 Closing this as we resolved in a different way in https://issues.apache.org/jira/browse/YUNIKORN-1221. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit closed pull request #110: [YUNIKORN-1261] Add pre-upgrade hook
craigcondit closed pull request #110: [YUNIKORN-1261] Add pre-upgrade hook URL: https://github.com/apache/yunikorn-release/pull/110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit closed pull request #111: [YUNIKORN-1359] Bring-your-own ConfigMap
craigcondit closed pull request #111: [YUNIKORN-1359] Bring-your-own ConfigMap URL: https://github.com/apache/yunikorn-release/pull/111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit commented on pull request #111: [YUNIKORN-1359] Bring-your-own ConfigMap
craigcondit commented on PR #111: URL: https://github.com/apache/yunikorn-release/pull/111#issuecomment-1319332412 Closing in favor of the implementation done as part of https://issues.apache.org/jira/browse/YUNIKORN-1221. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit closed pull request #116: [YUNIKORN-1371] Migrate to new ConfigMap configuration
craigcondit closed pull request #116: [YUNIKORN-1371] Migrate to new ConfigMap configuration URL: https://github.com/apache/yunikorn-release/pull/116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit commented on pull request #113: [YUNIKORN-1376] update values and deployment helm chart of the admission controller
craigcondit commented on PR #113: URL: https://github.com/apache/yunikorn-release/pull/113#issuecomment-1318829225 Closing in favor of #116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit closed pull request #113: [YUNIKORN-1376] update values and deployment helm chart of the admission controller
craigcondit closed pull request #113: [YUNIKORN-1376] update values and deployment helm chart of the admission controller URL: https://github.com/apache/yunikorn-release/pull/113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit commented on pull request #115: [YUNIKORN-1367] Don't mount configmap into scheduler pod
craigcondit commented on PR #115: URL: https://github.com/apache/yunikorn-release/pull/115#issuecomment-1318802150 Closed in favor of #116. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit opened a new pull request, #116: [YUNIKORN-1371] Migrate to new ConfigMap configuration
craigcondit opened a new pull request, #116: URL: https://github.com/apache/yunikorn-release/pull/116 Updates Helm charts to deploy new yunikorn-defaults ConfigMap, and removes legacy configuration environment variables. JIRA: https://issues.apache.org/jira/browse/YUNIKORN-1371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit closed pull request #115: [YUNIKORN-1367] Don't mount configmap into scheduler pod
craigcondit closed pull request #115: [YUNIKORN-1367] Don't mount configmap into scheduler pod URL: https://github.com/apache/yunikorn-release/pull/115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit opened a new pull request, #115: [YUNIKORN-1367] Don't mount configmap into scheduler pod
craigcondit opened a new pull request, #115: URL: https://github.com/apache/yunikorn-release/pull/115 JIRA: https://issues.apache.org/jira/browse/YUNIKORN-1367 Now that https://issues.apache.org/jira/browse/YUNIKORN-1365 has landed, we no longer need to mount the configmap into the scheduler pod as it is no longer used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit closed pull request #112: [YUNIKORN-1334] Admission controller: look up user & group and add annotation if necessary
craigcondit closed pull request #112: [YUNIKORN-1334] Admission controller: look up user & group and add annotation if necessary URL: https://github.com/apache/yunikorn-release/pull/112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit closed pull request #114: [YUNIKORN-1349] [docs] Document support for K8s 1.21-1.25
craigcondit closed pull request #114: [YUNIKORN-1349] [docs] Document support for K8s 1.21-1.25 URL: https://github.com/apache/yunikorn-release/pull/114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] pbacsko commented on pull request #112: [YUNIKORN-1334] Admission controller: look up user & group and add annotation if necessary
pbacsko commented on PR #112: URL: https://github.com/apache/yunikorn-release/pull/112#issuecomment-1313848000 Note: this change has to go in order to stabilize the e2e tests for YUNIKORN-1334. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] wilfred-s commented on pull request #113: [YUNIKORN-1376] update values and deployment helm chart of the admission controller
wilfred-s commented on PR #113: URL: https://github.com/apache/yunikorn-release/pull/113#issuecomment-1311060942 If the delay of moving to the configmap is limited and manageable then that is surely preferred. We should try to prevent introducing variables and in the same release cycle remove them again. They hopefully will never show up in a real release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit commented on pull request #113: [YUNIKORN-1376] update values and deployment helm chart of the admission controller
craigcondit commented on PR #113: URL: https://github.com/apache/yunikorn-release/pull/113#issuecomment-1311042464 Can we use the configmap for this instead? I know that puts us behind a bit, but I'd rather not introduce even more admission controller env vars... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit commented on pull request #111: [YUNIKORN-1359] Bring-your-own ConfigMap
craigcondit commented on PR #111: URL: https://github.com/apache/yunikorn-release/pull/111#issuecomment-1302530920 This is looking better, but I think we should wait until at least https://issues.apache.org/jira/browse/YUNIKORN-1365 has landed, as this will allow the scheduler to start without a configmap present. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] DerekTBrown commented on pull request #111: [YUNIKORN-1359] Bring-your-own ConfigMap
DerekTBrown commented on PR #111: URL: https://github.com/apache/yunikorn-release/pull/111#issuecomment-1302518514 @craigcondit I have made the requested changes. Can you take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit commented on pull request #111: [YUNIKORN-1359] Bring-your-own ConfigMap
craigcondit commented on PR #111: URL: https://github.com/apache/yunikorn-release/pull/111#issuecomment-1299455530 @DerekTBrown, this is going to be incompatible with the configuration redesign that is in progress. I've updated the original JIR A you've opened, and have added my comments here for clarity. Please see the design doc in [YUNIKORN-1221](https://issues.apache.org/jira/browse/YUNIKORN-1221), which is our updated configuration design. Since we will be using a configmap for all configuration moving forward (and not just the core config), we need an alternative mechanism to implement disabling configmap generation. I would recommend adding a new Helm attribute: - enableConfigMap: true | false (default true for backwards compatibility) -- When true, ConfigMap will be generated as part of the Helm deployment (as it is currently). -- When false, no ConfigMap will be generated at all as part of Helm deployment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] DerekTBrown commented on pull request #111: [YUNIKORN-1359] Bring-your-own ConfigMap
DerekTBrown commented on PR #111: URL: https://github.com/apache/yunikorn-release/pull/111#issuecomment-1299418145 @wilfred-s could you take a look at this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] DerekTBrown commented on pull request #111: [YUNIKORN-1359] Bring-your-own ConfigMap
DerekTBrown commented on PR #111: URL: https://github.com/apache/yunikorn-release/pull/111#issuecomment-1283049530 > Wouldn't the real solution then be to allow changing the config map in the deployment? Combined with the current possibility of changing the yaml file you would have full control over the deployment. Both from a config map and from a yaml perspective. To summarize my understanding: As proposed in this PR: - User will create their own `ConfigMap` named `yunikorn-configs` - User will set `configuration=null` so that default `ConfigMap` is not created. As I believe you are proposing: - User will create their own `ConfigMap` named whatever they want. - User will then set something so that the YuniKorn Deployment will pull in that `ConfigMap`. - User will set something so that an extraneous `ConfigMap` is not created. My preference would be to stick with the approach proposed in this PR, as (1) it is strictly simpler than the other approach, and (2) I don't believe users need the ability to customize the `ConfigMap` name (since it is essentially irrelevant). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] DerekTBrown commented on pull request #111: [YUNIKORN-1359] Bring-your-own ConfigMap
DerekTBrown commented on PR #111: URL: https://github.com/apache/yunikorn-release/pull/111#issuecomment-1283043050 To describe the usecase a bit more; we need to be able to perform separate deployments for the infrastructure pieces (the YuniKorn scheduler) and the configuration (the queue ConfigMap in particular). There are a few reasons for this: 1. We want to release changes to the configuration at a different cadence / through a different process than the rest of the infrastructure. For instance, we want to automate the configuration of queues. In our particular case, we do this through multiple Argo applications. 2. We want to control the permissions to touch configuration and the infrastructure separately. I imagine that other users will have similar stories; they run YuniKorn as a piece of platform infrastructure, and want to be able to periodically re-deploy configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] wilfred-s commented on pull request #111: [YUNIKORN-1359] Bring-your-own ConfigMap
wilfred-s commented on PR #111: URL: https://github.com/apache/yunikorn-release/pull/111#issuecomment-1282937854 Wouldn't the real solution then be to allow changing the config map in the deployment? Combined with the current possibility of changing the yaml file you would have full control over the deployment. Both from a config map and from a yaml perspective. This solution feels like it is only a partial one. BTW: a start was made to move all the configs to config maps and move away from a lot of the command line settings. Which means we might have multiple in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] DerekTBrown commented on pull request #111: [YUNIKORN-1359] Bring-your-own ConfigMap
DerekTBrown commented on PR #111: URL: https://github.com/apache/yunikorn-release/pull/111#issuecomment-1281724817 > How are you handling the fact that we cannot start without a configuration? We fail and exit if we cannot read the config. It would fail the helm deployment. That means the config map must be there before you deploy. In our case the `ConfigMap` will already be present when we deploy YuniKorn. > We also already have the option to bring your [own config map](https://yunikorn.apache.org/docs/next/user_guide/queue_config#configuration) if you want. I am not quite sure what you are referring to? This section of the documentation describes the ability to use a different `.yaml` file for configuration. This doesn't solve the "bring your own" configuration problem, because the user would still need to mount the `ConfigMap` to the `Deployment` somehow, which requires modifying the official chart. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] wilfred-s commented on pull request #111: [Feature] Bring-your-own ConfigMap
wilfred-s commented on PR #111: URL: https://github.com/apache/yunikorn-release/pull/111#issuecomment-1281209375 How are you handling the fact that we cannot start without a configuration? We fail and exit if we cannot read the config. It would fail the helm deployment. That means the config map must be there before you deploy. We also already have the option to bring your [own config map](https://yunikorn.apache.org/docs/next/user_guide/queue_config#configuration) if you want. We could easily expose that but it does not change the fact that it must exist before we start. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] wilfred-s commented on pull request #111: [Feature] Bring-your-own ConfigMap
wilfred-s commented on PR #111: URL: https://github.com/apache/yunikorn-release/pull/111#issuecomment-1279796851 Please first open a jira for this. We track everything via jira. Check the [how to contribute](https://yunikorn.apache.org/community/how_to_contribute) document on the website. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] DerekTBrown opened a new pull request, #111: [Feature] Bring-your-own ConfigMap
DerekTBrown opened a new pull request, #111: URL: https://github.com/apache/yunikorn-release/pull/111 This PR adds a simple feature; if `Values.configuration` is empty, the chart will not create the `ConfigMap`. This enables users to create the ConfigMap in their own way. ## Test Plan ```bash > helm template ./helm-charts/yunikorn | gh gist create - Creating gist... ✓ Created gist https://gist.github.com/02127740f78187d4abf7a32716f73aa5 > helm template --set configuration=null ./helm-charts/yunikorn | gh gist create - Creating gist... ✓ Created gist https://gist.github.com/1ab6e9b97952e6becd60b44ef39b70e6 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] DerekTBrown commented on pull request #110: [YUNIKORN-1261] Add pre-upgrade hook
DerekTBrown commented on PR #110: URL: https://github.com/apache/yunikorn-release/pull/110#issuecomment-1279475756 @wilfred-s I apologize- I put this up-for-review prematurely. I think YuniKorn is in a highly similar place to Spark Operator in terms of Helm hooks: https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/pull/1624 What we really need is first-order support for resource ordering. Unfortunately, the hooks have weird semantics that make it hard for us to get the desired behavior. I am going to wait for the conversation in https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/pull/1624 to resolve, and then we can decide whether we want to adopt this same approach within YuniKorn. The Spark Operator only has 3 instances of the hook, whereas I see 12 in YuniKorn, so this might be more heavy-handed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] wilfred-s commented on pull request #110: [YUNIKORN-1261] Add pre-upgrade hook
wilfred-s commented on PR #110: URL: https://github.com/apache/yunikorn-release/pull/110#issuecomment-1278322727 By adding a pre-upgrade hook could we be triggering a `resource exists` error causing the upgrade to fail? Or are we relying on the default hook deletion policy `before-hook-creation`? One last question: has this been tested and how? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] DerekTBrown opened a new pull request, #110: Fix(YUNICORN-1261): Add pre-upgrade hook
DerekTBrown opened a new pull request, #110: URL: https://github.com/apache/yunikorn-release/pull/110 I believe `YUNICORN-1261` is caused because we are missing a lifecycle hook for upgrades: https://helm.sh/docs/topics/charts_hooks/#the-available-hooks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] wilfred-s closed pull request #106: [YUNIKORN-156] license check for release repo
wilfred-s closed pull request #106: [YUNIKORN-156] license check for release repo URL: https://github.com/apache/yunikorn-release/pull/106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] pbacsko closed pull request #109: [YUNIKORN-1308]validate_cluster.sh should auto-detect DOCKER_ARCH
pbacsko closed pull request #109: [YUNIKORN-1308]validate_cluster.sh should auto-detect DOCKER_ARCH URL: https://github.com/apache/yunikorn-release/pull/109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] HuangTing-Yao commented on a diff in pull request #106: [YUNIKORN-156] license check for release repo
HuangTing-Yao commented on code in PR #106:
URL: https://github.com/apache/yunikorn-release/pull/106#discussion_r968183845
##
check_license.sh:
##
@@ -0,0 +1,38 @@
+#!/usr/bin/env bash
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# Kernel (OS) Name
+OS=$(uname -s | tr '[:upper:]' '[:lower:]')
+# show that the check has started
+echo "checking license headers:"
+# run different finds on mac vs linux
+if [ "${OS}" = "darwin" ]; then
+ find -E . ! -path "./.git*" -regex
".*(Makefile|\.(go|sh|py|md|conf|yaml|yml|tpl))" -exec grep -L "Licensed to the
Apache Software Foundation" {} \; > LICRES
+else
+ find . ! -path "./.git*" -regex
".*\(Makefile\|\.\(go\|py\|sh\|md\|yaml\|yml\|tpl\)\)" -exec grep -L "Licensed
to the Apache Software Foundation" {} \; > LICRES
Review Comment:
I think we the `conf` is missing in this line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] HuangTing-Yao commented on pull request #109: [YUNIKORN-1308]validate_cluster.sh should auto-detect DOCKER_ARCH
HuangTing-Yao commented on PR #109:
URL: https://github.com/apache/yunikorn-release/pull/109#issuecomment-1243410087
> I do not think that we should copy this logic. Fixing the calls is a much
better solution. I also noticed that we do not pick up both of the vars in all
cases.
>
> Some investigations show that the difference is behaviour in shell and
make commands. This works on ubuntu and mac for me:
>
> ```
> diff --git a/release-top-level-artifacts/Makefile
b/release-top-level-artifacts/Makefile
> index 177386d..67021e4 100644
> --- a/release-top-level-artifacts/Makefile
> +++ b/release-top-level-artifacts/Makefile
> @@ -51,4 +51,4 @@ test:
>
> .PHONY: arch
> arch:
> - eval `$(MAKE) -C $(SHIM_DIR) arch`
> + @eval "$(MAKE) -C $(SHIM_DIR) arch"
> diff --git a/release-top-level-artifacts/validate_cluster.sh
b/release-top-level-artifacts/validate_cluster.sh
> index 5544df5..087b41e 100755
> --- a/release-top-level-artifacts/validate_cluster.sh
> +++ b/release-top-level-artifacts/validate_cluster.sh
> @@ -80,6 +80,7 @@ function run_detail() {
>echo " Kubernetes image:${KIND_IMAGE}"
>echo " Registry name: ${REGISTRY}"
>echo " Plugin mode: ${PLUGIN}"
> + echo " Executable Architecture: ${EXEC_ARCH}"
>echo " Image Architecture: ${DOCKER_ARCH}"
> }
>
> @@ -140,7 +141,7 @@ KIND_CONFIG="${KIND_CONFIG:-./kind.yaml}"
> HELMCHART="${HELMCHART:-./helm-charts/yunikorn}"
> PLUGIN="${PLUGIN:-false}"
> # load the docker architecture via make
> -eval "$(make arch)"
> +eval "$(make -s arch)"
>
> # show details for the run
> run_detail
> ```
>
> Can you check if this works on other systems.
It also works on my Ubuntu(both amd64 and arm64).
Agree with @wilfred-s, fixing the make arch call is a better solution.
Thank for your advice, @wilfred-s
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] HuangTing-Yao opened a new pull request, #109: [YUNIKORN-1308]validate_cluster.sh should auto-detect DOCKER_ARCH
HuangTing-Yao opened a new pull request, #109: URL: https://github.com/apache/yunikorn-release/pull/109 Set `HOST_ARCH` and `DOCKER_ARCH` in validate_cluster.sh https://issues.apache.org/jira/browse/YUNIKORN-1308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] wilfred-s closed pull request #108: [YUNIKORN-1316] The value of userLabelKey in scheduler is empty when yunikorn is deployed by helm.
wilfred-s closed pull request #108: [YUNIKORN-1316] The value of userLabelKey in scheduler is empty when yunikorn is deployed by helm. URL: https://github.com/apache/yunikorn-release/pull/108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] wilfred-s merged pull request #107: [YUNIKORN-1311] helm chart release for v1.1
wilfred-s merged PR #107: URL: https://github.com/apache/yunikorn-release/pull/107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] 0yukali0 opened a new pull request, #108: [YUNIKORN-1316] The value of userLabelKey in scheduler is empty when yunikorn is deployed by helm.
0yukali0 opened a new pull request, #108: URL: https://github.com/apache/yunikorn-release/pull/108 ### What is this PR for? UserLabelKey is empty when yunikorn is deployed by helm. ### What type of PR is it? * [x] - Bug Fix * [ ] - Improvement * [ ] - Feature * [ ] - Documentation * [ ] - Hot Fix * [ ] - Refactoring ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/YUNIKORN-1316 ### How should this be tested? ### Screenshots (if appropriate) https://user-images.githubusercontent.com/45888688/189310657-4f1a3d51-6bd7-488e-aded-c19ff92417de.png";> ### Questions: * [ ] - The licenses files need update. * [ ] - There is breaking changes for older versions. * [ ] - It needs documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] wilfred-s opened a new pull request, #106: [YUNIKORN-156] license check for release repo
wilfred-s opened a new pull request, #106: URL: https://github.com/apache/yunikorn-release/pull/106 Pre-commit worklfow to check license in release related files. Add workflow badge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] yangwwei merged pull request #105: [YUNIKORN-1292] Fix github pages issues after moving to TLP
yangwwei merged PR #105: URL: https://github.com/apache/yunikorn-release/pull/105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] yangwwei opened a new pull request, #105: [YUNIKORN-1292] Fix github pages issues after moving to TLP
yangwwei opened a new pull request, #105: URL: https://github.com/apache/yunikorn-release/pull/105 https://apache.github.io/yunikorn-release/ still has the out-of-dated issue. This was pointed out by the Spark community in this PR: https://github.com/apache/spark/pull/37622#discussion_r952877147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] yangwwei closed pull request #104: [YUNIKORN-1292] Fix github pages issues after moving to TLP
yangwwei closed pull request #104: [YUNIKORN-1292] Fix github pages issues after moving to TLP URL: https://github.com/apache/yunikorn-release/pull/104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] yangwwei opened a new pull request, #104: [YUNIKORN-1292] Fix github pages issues after moving to TLP
yangwwei opened a new pull request, #104: URL: https://github.com/apache/yunikorn-release/pull/104 https://apache.github.io/yunikorn-release/ still has the out-of-dated issue. This was pointed out by the Spark community in this PR: https://github.com/apache/spark/pull/37622#discussion_r952877147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit closed pull request #103: [YUNIKORN-1283] go dependency upgrades
craigcondit closed pull request #103: [YUNIKORN-1283] go dependency upgrades URL: https://github.com/apache/yunikorn-release/pull/103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] wilfred-s opened a new pull request, #103: [YUNIKORN-1283] go dependency upgrades
wilfred-s opened a new pull request, #103: URL: https://github.com/apache/yunikorn-release/pull/103 ### What is this PR for? Update go dependencies: * golang.org/x/crypto * golang.org/x/net * golang.org/x/sys * golang.org/x/text * golang.org/x/tools ### What type of PR is it? * [X] - Improvement ### What is the Jira issue? https://issues.apache.org/jira/browse/YUNIKORN-1283 ### How should this be tested? Dependency updates only, standard unit and e2e tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] wilfred-s closed pull request #102: [YUNIKORN-1256] license issues in deployments examples
wilfred-s closed pull request #102: [YUNIKORN-1256] license issues in deployments examples URL: https://github.com/apache/yunikorn-release/pull/102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] wilfred-s opened a new pull request, #102: [YUNIKORN-1256] license issues in deployments examples
wilfred-s opened a new pull request, #102: URL: https://github.com/apache/yunikorn-release/pull/102 ### What is this PR for? In the k8shim the tfjob contains files that are not part of Apache. The LICENSE file should show this. It also should show correctly in the source release and be merged as part of the release build. Fixing license issues: - inconsistent formatting (line endings and empty lines) - missing license in two k8shim files - update make target to cover new dile types ### What type of PR is it? * [X] - Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/YUNIKORN-1256 ### How should this be tested? build locally and ran all updated make targets -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] wilfred-s closed pull request #101: [YUNIKORN-1250] add .asf.yaml to release repo
wilfred-s closed pull request #101: [YUNIKORN-1250] add .asf.yaml to release repo URL: https://github.com/apache/yunikorn-release/pull/101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] lowc1012 commented on pull request #101: [YUNIKORN-1250] add .asf.yaml to release repo
lowc1012 commented on PR #101: URL: https://github.com/apache/yunikorn-release/pull/101#issuecomment-1203509925 Thanks @wilfred-s for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] lowc1012 opened a new pull request, #101: [YUNIKORN-1250] add .asf.yaml to release repo
lowc1012 opened a new pull request, #101: URL: https://github.com/apache/yunikorn-release/pull/101 Add .asf.yaml file Jira: [YUNIKORN-1250](https://issues.apache.org/jira/projects/YUNIKORN/issues/YUNIKORN-1250) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] wilfred-s closed pull request #100: [YUNIKORN-1265] fix shellcheck issues in our shell scripts
wilfred-s closed pull request #100: [YUNIKORN-1265] fix shellcheck issues in our shell scripts URL: https://github.com/apache/yunikorn-release/pull/100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] lowc1012 opened a new pull request, #100: [YUNIKORN-1265] fix shellcheck issues in our shell scripts
lowc1012 opened a new pull request, #100: URL: https://github.com/apache/yunikorn-release/pull/100 What is this PR for? Fix shellcheck issues in merge_pr.sh and validate_cluster.sh Todos Fix issues and add shellcheck into CI for other repos What is the Jira issue? [YUNIKORN-1265](https://issues.apache.org/jira/projects/YUNIKORN/issues/YUNIKORN-1265) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] wilfred-s closed pull request #99: [YUNIKORN-1262] stash local changes in merge_perge.sh
wilfred-s closed pull request #99: [YUNIKORN-1262] stash local changes in merge_perge.sh URL: https://github.com/apache/yunikorn-release/pull/99 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit closed pull request #98: [YUNIKORN-1251] Multi arch support in validation script
craigcondit closed pull request #98: [YUNIKORN-1251] Multi arch support in validation script URL: https://github.com/apache/yunikorn-release/pull/98 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] wilfred-s opened a new pull request, #98: [YUNIKORN-1251] Multi arch support in validation script
wilfred-s opened a new pull request, #98: URL: https://github.com/apache/yunikorn-release/pull/98 Add support for images build for specific architectures. Allow architecture change via the HOST_ARCH shell variable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] wilfred-s closed pull request #96: [YUNIKORN-1239] release script error handling
wilfred-s closed pull request #96: [YUNIKORN-1239] release script error handling URL: https://github.com/apache/yunikorn-release/pull/96 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] wilfred-s closed pull request #97: [YUNIKORN-1247] Update helm hook weights accordingly
wilfred-s closed pull request #97: [YUNIKORN-1247] Update helm hook weights accordingly URL: https://github.com/apache/yunikorn-release/pull/97 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit closed pull request #95: [YUNIKORN-1215] multi architecture build
craigcondit closed pull request #95: [YUNIKORN-1215] multi architecture build URL: https://github.com/apache/yunikorn-release/pull/95 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit commented on a diff in pull request #95: [YUNIKORN-1215] multi architecture build
craigcondit commented on code in PR #95:
URL: https://github.com/apache/yunikorn-release/pull/95#discussion_r900464720
##
tools/build-image.py:
##
@@ -0,0 +1,276 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import getopt
+import getpass
+import json
+import os
+import shutil
+import subprocess
+
+import sys
+
+# Supported host architectures for executables and docker images
+# Mapped to the correct settings in the Makefile
+architecture = {"x86_64": "amd64",
+"aarch64": "arm64v8"}
+# Make targets for the shim repo to generate the images
+targets = {"adm_image": "admission",
+ "sched_image": "scheduler",
+ "plugin_image": "scheduler-plugin"}
+# registry setting passed to Makefile to allow testing of the script
+repository = "apache"
+# authentication info for docker hub
+docker_user = ""
+docker_pass = ""
+docker_token = ""
+
+
+# fail the execution
+def fail(message):
+print(message)
+sys.exit(1)
+
+
+# get the command from the path
+def get_cmd(name):
+cmd = shutil.which(name)
+if not cmd:
+fail("command not found on the path: '%s'" % name)
+return cmd
+
+
+# load the config, based on the build-release.py code.
+def load_config():
+tools_dir = os.path.dirname(os.path.realpath(__file__))
+# load configs
+config_file = os.path.join(tools_dir, "release-configs.json")
+with open(config_file) as configs:
+try:
+data = json.load(configs)
+except json.JSONDecodeError:
+fail("load config: unexpected json decode failure")
+
+if "release" not in data:
+fail("load config: release data not found")
+release_meta = data["release"]
+if "version" not in release_meta:
+fail("load config: version data not found in release")
+version = release_meta["version"]
+release_package_name = "apache-yunikorn-{0}-src".format(version)
+if "repositories" not in data:
+fail("load config: repository list not found")
+repo_list = data["repositories"]
+
+staging_dir = os.path.join(os.path.dirname(tools_dir), "staging")
+release_base = os.path.join(staging_dir, release_package_name)
+
+print("release meta info:")
+print(" - version:%s" % version)
+print(" - base directory: %s" % release_base)
+print(" - package name: %s" % release_package_name)
+
+if not os.path.exists(release_base):
+fail("Staged release dir does not exist:\n\t%s" % release_base)
+return version, repo_list, release_base
+
+
+# Cleanup image tag
+def remove_tag(image_name):
+splits = image_name.split(":")
+if len(splits) != 2:
+fail("Image name is not in the required format")
+cmd = get_cmd("curl")
+curl = [cmd, "-X", "DELETE", "-H", "Authorization: JWT " + docker_token]
+curl.extend(["https://hub.docker.com/v2/repositories/"; + splits[0] +
"/tags/" + splits[1] + "/"])
+retcode = subprocess.call(curl)
+if retcode:
+fail("docker tag cleanup failed")
+
+
+# Push an image or manifest
+def push_image(cmd, image_name):
+push = [cmd, "push", image_name]
+retcode = subprocess.call(push, stdout=subprocess.DEVNULL)
+if retcode:
+fail("docker push failed")
+
+
+# get token for rest
+# 2FA is not supported by this code (yet) but can be added
+def get_token():
+cmd = get_cmd("curl")
+curl = [cmd, "-X", "POST", "-H", "Content-Type: application/json"]
+curl.extend(["-d", '{"username": "' + docker_user + '", "password": "' +
docker_pass + '"}'])
+curl.extend(["https://hub.docker.com/v2/users/login/";])
+p = subprocess.run(curl, capture_output=True)
+try:
+data = json.loads(p.stdout)
+except json.JSONDecodeError:
+fail("login failed: unexpected json decode failure: %s" %p.stdout)
+if "detail" in data:
+fail("authentication failed: %s" % data["detail"])
+if "token" not in data:
+fail("login failed: unexpected json content: %s" % data)
+global docker_token
+docker_token = data["token"]
+
+
+# get user and password on startup
+def get_auth():
+global docker_user
+docker_user = input("Enter docker hub username: ")
+global docker_pass
+docker_pass = getpass
[GitHub] [yunikorn-release] craigcondit commented on a diff in pull request #95: [YUNIKORN-1215] multi architecture build
craigcondit commented on code in PR #95:
URL: https://github.com/apache/yunikorn-release/pull/95#discussion_r900447615
##
tools/build-image.py:
##
@@ -0,0 +1,276 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import getopt
+import getpass
+import json
+import os
+import shutil
+import subprocess
+
+import sys
+
+# Supported host architectures for executables and docker images
+# Mapped to the correct settings in the Makefile
+architecture = {"x86_64": "amd64",
+"aarch64": "arm64v8"}
+# Make targets for the shim repo to generate the images
+targets = {"adm_image": "admission",
+ "sched_image": "scheduler",
+ "plugin_image": "scheduler-plugin"}
+# registry setting passed to Makefile to allow testing of the script
+repository = "apache"
+# authentication info for docker hub
+docker_user = ""
+docker_pass = ""
+docker_token = ""
+
+
+# fail the execution
+def fail(message):
+print(message)
+sys.exit(1)
+
+
+# get the command from the path
+def get_cmd(name):
+cmd = shutil.which(name)
+if not cmd:
+fail("command not found on the path: '%s'" % name)
+return cmd
+
+
+# load the config, based on the build-release.py code.
+def load_config():
+tools_dir = os.path.dirname(os.path.realpath(__file__))
+# load configs
+config_file = os.path.join(tools_dir, "release-configs.json")
+with open(config_file) as configs:
+try:
+data = json.load(configs)
+except json.JSONDecodeError:
+fail("load config: unexpected json decode failure")
+
+if "release" not in data:
+fail("load config: release data not found")
+release_meta = data["release"]
+if "version" not in release_meta:
+fail("load config: version data not found in release")
+version = release_meta["version"]
+release_package_name = "apache-yunikorn-{0}-src".format(version)
+if "repositories" not in data:
+fail("load config: repository list not found")
+repo_list = data["repositories"]
+
+staging_dir = os.path.join(os.path.dirname(tools_dir), "staging")
+release_base = os.path.join(staging_dir, release_package_name)
+
+print("release meta info:")
+print(" - version:%s" % version)
+print(" - base directory: %s" % release_base)
+print(" - package name: %s" % release_package_name)
+
+if not os.path.exists(release_base):
+fail("Staged release dir does not exist:\n\t%s" % release_base)
+return version, repo_list, release_base
+
+
+# Cleanup image tag
+def remove_tag(image_name):
+splits = image_name.split(":")
+if len(splits) != 2:
+fail("Image name is not in the required format")
+cmd = get_cmd("curl")
+curl = [cmd, "-X", "DELETE", "-H", "Authorization: JWT " + docker_token]
+curl.extend(["https://hub.docker.com/v2/repositories/"; + splits[0] +
"/tags/" + splits[1] + "/"])
+retcode = subprocess.call(curl)
+if retcode:
+fail("docker tag cleanup failed")
+
+
+# Push an image or manifest
+def push_image(cmd, image_name):
+push = [cmd, "push", image_name]
+retcode = subprocess.call(push, stdout=subprocess.DEVNULL)
+if retcode:
+fail("docker push failed")
+
+
+# get token for rest
+# 2FA is not supported by this code (yet) but can be added
+def get_token():
+cmd = get_cmd("curl")
+curl = [cmd, "-X", "POST", "-H", "Content-Type: application/json"]
+curl.extend(["-d", '{"username": "' + docker_user + '", "password": "' +
docker_pass + '"}'])
+curl.extend(["https://hub.docker.com/v2/users/login/";])
+p = subprocess.run(curl, capture_output=True)
+try:
+data = json.loads(p.stdout)
+except json.JSONDecodeError:
+fail("login failed: unexpected json decode failure: %s" %p.stdout)
+if "detail" in data:
+fail("authentication failed: %s" % data["detail"])
+if "token" not in data:
+fail("login failed: unexpected json content: %s" % data)
+global docker_token
+docker_token = data["token"]
+
+
+# get user and password on startup
+def get_auth():
+global docker_user
+docker_user = input("Enter docker hub username: ")
+global docker_pass
+docker_pass = getpass
[GitHub] [yunikorn-release] wilfred-s opened a new pull request, #96: [YUNIKORN-1239] release script error handling
wilfred-s opened a new pull request, #96: URL: https://github.com/apache/yunikorn-release/pull/96 Adding error handling to the release script Sync changes for git SHA in Makefiles into the release script -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] wilfred-s opened a new pull request, #95: [YUNIKORN-1215] multi architecture build
wilfred-s opened a new pull request, #95: URL: https://github.com/apache/yunikorn-release/pull/95 Build AMD and ARM images for YuniKorn. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit closed pull request #94: [YNIKORN-1229] fix version replacement in chart
craigcondit closed pull request #94: [YNIKORN-1229] fix version replacement in chart URL: https://github.com/apache/yunikorn-release/pull/94 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] yuchaoran2011 merged pull request #93: [YUNIKORN-1236] add artifacthub-repo.yml file
yuchaoran2011 merged PR #93: URL: https://github.com/apache/yunikorn-release/pull/93 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] wilfred-s opened a new pull request, #94: [YNIKORN-1229] fix version replacement in chart
wilfred-s opened a new pull request, #94: URL: https://github.com/apache/yunikorn-release/pull/94 The version replacement in the values.yaml is to liberal when it comes to the selection of text to replace. This breaks the plugin image link in the chart. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] wilfred-s opened a new pull request, #93: [YUNIKORN-1236] add artifacthub-repo.yml file
wilfred-s opened a new pull request, #93: URL: https://github.com/apache/yunikorn-release/pull/93 Ownership information to claim helm repo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] wilfred-s merged pull request #92: [YUNIKORN-993] helm chart update for v1.0.0
wilfred-s merged PR #92: URL: https://github.com/apache/yunikorn-release/pull/92 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit closed pull request #91: [YUNIKORN-1192] Update exclude list in release build
craigcondit closed pull request #91: [YUNIKORN-1192] Update exclude list in release build URL: https://github.com/apache/yunikorn-release/pull/91 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] wilfred-s opened a new pull request, #91: [YUNIKORN-1192] Update exclude list in release build
wilfred-s opened a new pull request, #91: URL: https://github.com/apache/yunikorn-release/pull/91 Removing non-existing entries: landmark, .travis.yml Removing .helmignore and .golangci.yml (need to be packed) Adding mac filesystem specific .DS_Store -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] wilfred-s closed pull request #90: [YUNIKORN-1189] Support plugin mode in release validation script
wilfred-s closed pull request #90: [YUNIKORN-1189] Support plugin mode in release validation script URL: https://github.com/apache/yunikorn-release/pull/90 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit opened a new pull request, #90: [YUNIKORN-1189] Support plugin mode in release validation script
craigcondit opened a new pull request, #90: URL: https://github.com/apache/yunikorn-release/pull/90 JIRA: https://issues.apache.org/jira/browse/YUNIKORN-1189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit closed pull request #89: [YUNIKORN-764] validations steps for a release
craigcondit closed pull request #89: [YUNIKORN-764] validations steps for a release URL: https://github.com/apache/yunikorn-release/pull/89 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] wilfred-s opened a new pull request, #89: [YUNIKORN-764] validations steps for a release
wilfred-s opened a new pull request, #89: URL: https://github.com/apache/yunikorn-release/pull/89 Add script to start a K8s cluster based on the release build images. Fix license headers and go version (yunikorn-core expects go 1.16) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit closed pull request #88: [YUNIKORN-197] update commit instructions script only
craigcondit closed pull request #88: URL: https://github.com/apache/yunikorn-release/pull/88 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] wilfred-s opened a new pull request #88: [YUNIKORN-197] update commit instructions script only
wilfred-s opened a new pull request #88: URL: https://github.com/apache/yunikorn-release/pull/88 Script to commit changes using command line. Referenced in the contribution documentation update in YUNIKORN-1048. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit closed pull request #87: [YUNIKORN-1148] Update release repo to remove incubator references
craigcondit closed pull request #87: URL: https://github.com/apache/yunikorn-release/pull/87 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit opened a new pull request #87: [YUNIKORN-1148] Update release repo to remove incubator references
craigcondit opened a new pull request #87: URL: https://github.com/apache/yunikorn-release/pull/87 JIRA: https://issues.apache.org/jira/browse/YUNIKORN-1148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [incubator-yunikorn-release] wilfred-s closed pull request #86: [YUNIKORN-1130] Update helm chart example with new resource unit types
wilfred-s closed pull request #86: URL: https://github.com/apache/incubator-yunikorn-release/pull/86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [incubator-yunikorn-release] craigcondit opened a new pull request #86: [YUNIKORN-1130] Update helm chart example with new resource unit types
craigcondit opened a new pull request #86: URL: https://github.com/apache/incubator-yunikorn-release/pull/86 JIRA: https://issues.apache.org/jira/browse/YUNIKORN-1130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[GitHub] [incubator-yunikorn-release] wilfred-s closed pull request #83: [YUNIKORN-638] Make placeholder image configurable
wilfred-s closed pull request #83: URL: https://github.com/apache/incubator-yunikorn-release/pull/83 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
