[jira] [Commented] (ZOOKEEPER-1870) flakey test in StandaloneDisabledTest.startSingleServerTest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13950432#comment-13950432
]
Michi Mutsuzaki commented on ZOOKEEPER-1870:
I can't reproduce it now, but I think there was a case where the quorum peer
incorrectly became a leader after shutdown got called if the proposedLeader
wasn't set to -1. I'm guessing it could happen if shutdown() gets called right
before this block of code gets executed. Maybe there is a way to shutdown the
leader election more cleanly?
{noformat}
/*
* This predicate is true once we don't read any new
* relevant message from the reception queue
*/
if (n == null) {
self.setPeerState((proposedLeader == self.getId()) ?
ServerState.LEADING: learningState());
Vote endVote = new Vote(proposedLeader,
proposedZxid, proposedEpoch);
leaveInstance(endVote);
return endVote;
}
{noformat}
Yes, I think we should fix this in 3.4. I'll upload a separate patch for 3.4.
flakey test in StandaloneDisabledTest.startSingleServerTest
---
Key: ZOOKEEPER-1870
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1870
Project: ZooKeeper
Issue Type: Bug
Components: tests
Affects Versions: 3.5.0
Reporter: Patrick Hunt
Assignee: Helen Hastings
Priority: Blocker
Attachments: ZOOKEEPER-1870.patch, ZOOKEEPER-1870.patch, test.log
I'm seeing lots of the following failure. Seems like a flakey test (passes
every so often).
{noformat}
junit.framework.AssertionFailedError: client could not connect to
reestablished quorum: giving up after 30+ seconds.
at
org.apache.zookeeper.test.ReconfigTest.testNormalOperation(ReconfigTest.java:143)
at
org.apache.zookeeper.server.quorum.StandaloneDisabledTest.startSingleServerTest(StandaloneDisabledTest.java:75)
at
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
{noformat}
I've found 3 problems:
1. QuorumCnxManager.Listener.run() leaks the socket depending on when the
shutdown flag gets set.
2. QuorumCnxManager.halt() doesn't wait for the listener to terminate.
3. QuorumPeer.shuttingDownLE flag doesn't get reset when restarting the
leader election.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
ZooKeeper_branch33_solaris - Build # 838 - Failure
See https://builds.apache.org/job/ZooKeeper_branch33_solaris/838/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 106640 lines...] [junit] 2014-03-28 06:56:37,765 - INFO [main:ZooKeeperServer@154] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test6086061840554778205.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test6086061840554778205.junit.dir/version-2 [junit] 2014-03-28 06:56:37,766 - INFO [main:NIOServerCnxn$Factory@143] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2014-03-28 06:56:37,768 - INFO [main:FileSnap@82] - Reading snapshot /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test6086061840554778205.junit.dir/version-2/snapshot.0 [junit] 2014-03-28 06:56:37,771 - INFO [main:FileTxnSnapLog@256] - Snapshotting: b [junit] 2014-03-28 06:56:37,774 - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2014-03-28 06:56:37,775 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn$Factory@251] - Accepted socket connection from /127.0.0.1:49086 [junit] 2014-03-28 06:56:37,775 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1237] - Processing stat command from /127.0.0.1:49086 [junit] 2014-03-28 06:56:37,776 - INFO [Thread-4:NIOServerCnxn$StatCommand@1153] - Stat command output [junit] 2014-03-28 06:56:37,778 - INFO [Thread-4:NIOServerCnxn@1435] - Closed socket connection for client /127.0.0.1:49086 (no session established for client) [junit] ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] expect:InMemoryDataTree [junit] found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] expect:StandaloneServer_port [junit] found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2014-03-28 06:56:37,780 - INFO [main:ClientBase@408] - STOPPING server [junit] 2014-03-28 06:56:37,782 - INFO [ProcessThread:-1:PrepRequestProcessor@128] - PrepRequestProcessor exited loop! [junit] 2014-03-28 06:56:37,782 - INFO [SyncThread:0:SyncRequestProcessor@151] - SyncRequestProcessor exited! [junit] 2014-03-28 06:56:37,783 - INFO [main:FinalRequestProcessor@370] - shutdown of request processor complete [junit] 2014-03-28 06:56:37,785 - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] ensureOnly:[] [junit] 2014-03-28 06:56:37,787 - INFO [main:ClientBase@401] - STARTING server [junit] 2014-03-28 06:56:37,787 - INFO [main:ZooKeeperServer@154] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test6086061840554778205.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test6086061840554778205.junit.dir/version-2 [junit] 2014-03-28 06:56:37,789 - INFO [main:NIOServerCnxn$Factory@143] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2014-03-28 06:56:37,790 - INFO [main:FileSnap@82] - Reading snapshot /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test6086061840554778205.junit.dir/version-2/snapshot.b [junit] 2014-03-28 06:56:37,793 - INFO [main:FileTxnSnapLog@256] - Snapshotting: b [junit] 2014-03-28 06:56:37,795 - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2014-03-28 06:56:37,796 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn$Factory@251] - Accepted socket connection from /127.0.0.1:49088 [junit] 2014-03-28 06:56:37,797 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1237] - Processing stat command from /127.0.0.1:49088 [junit] 2014-03-28 06:56:37,798 - INFO [Thread-5:NIOServerCnxn$StatCommand@1153] - Stat command output [junit] 2014-03-28 06:56:37,799 - INFO [Thread-5:NIOServerCnxn@1435] - Closed socket connection for client /127.0.0.1:49088 (no session established for client) [junit] ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] expect:InMemoryDataTree [junit] found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] expect:StandaloneServer_port [junit] found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2014-03-28 06:56:37,802 - INFO
RE: Thread handling
Thanks Camille. Then I'll raise an improvement task and will discuss it over
there and reach to an agreement.
Thanks,
Rakesh
-Original Message-
From: c...@renttherunway.com [mailto:c...@renttherunway.com] On Behalf Of
Camille Fournier
Sent: 27 March 2014 21:53
To: DevZooKeeper
Cc: u...@zookeeper.apache.org
Subject: Re: Thread handling
I love the idea. In general, it would be great to uplift the way we do
threading. It is a BIG project though, which is why it hasn't been tackled.
I think this will go best if you have a clear idea of how we can break down the
change so it isn't a several month dev/review process.
C
On Thu, Mar 27, 2014 at 10:38 AM, Rakesh R rake...@huawei.com wrote:
Hi All,
Server has many critical threads running and co-ordinating each other
like RequestProcessor chains et. When going through each threads,
most of them having the similar structure like:
public void run() {
try {
while(running)
// processing logic
}
} catch (InterruptedException e) {
LOG.error(Unexpected interruption, e);
} catch (RequestProcessorException e) {
LOG.error(Unexpected exception, e);
} catch (Exception e) {
LOG.error(Unexpected exception, e);
}
LOG.info(...exited loop!);
}
I feel, we could improve our threads in our system. From the design I
could see, there could be a chance of silently leaving the thread in
case of any exception(abnormal or any functional issue too) If this
happens in the production, the server would get hanged forever and
will not be able to deliver its role.
If we have a 'DeathWatcher 'or some other mechanism in place to
monitor all the critical threads. It can take a decision like - bring
down the process if required, or shutdown the quorumpeer and go for LE again
etc.
Now the monitoring or management tool will knows about the situation
and can act upon.
Appreciate any thoughts ?
Thanks in advance,
Rakesh R
[jira] [Commented] (ZOOKEEPER-1797) PurgeTxnLog may delete data logs during roll
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13950762#comment-13950762 ] Rakesh R commented on ZOOKEEPER-1797: - [~fpj] I've reviewed the code, AFAIK both autopurge and cron job will be affected and can mistakenly delete the log or snap files. Kindly see the proposed patch when you get sometime. Also, I've tried to simulate the case through one test case. Thanks. +Proposed algo:+ If logs are rolling or a new snapshot is created during this process, these newest N snapshots or logs will be excluded from current purging cycle. Here my idea is not to loose any info, anyway it can be taken care on next cycle. PurgeTxnLog may delete data logs during roll Key: ZOOKEEPER-1797 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1797 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.4.5 Reporter: Derek Dagit Assignee: Rakesh R Priority: Critical Fix For: 3.5.0 Attachments: ZOOKEEPER-1797.patch org.apache.zookeeper.server.PurgeTxnLog deletes old data logs and snapshots, keeping the newest N snapshots and any data logs that have been written since the snapshot. It does this by listing the available snapshots logs and creates a blacklist of snapshots and logs that should not be deleted. Then, it searches for and deletes all logs and snapshots that are not in this list. It appears that if logs are rolling or a new snapshot is created during this process, then these newer files will be unintentionally deleted. -- This message was sent by Atlassian JIRA (v6.2#6252)
Failed: ZOOKEEPER-1797 PreCommit Build #1991
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1797 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1991/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 299845 lines...] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12637398/ZOOKEEPER-1797.patch [exec] against trunk revision 1582572. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1991//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1991//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1991//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 5832291384f6f241e32529d99edb3a2f5f338996 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1674: exec returned: 1 Total time: 33 minutes 7 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-1797 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## 2 tests failed. REGRESSION: org.apache.zookeeper.server.quorum.StandaloneDisabledTest.startSingleServerTest Error Message: client could not connect to reestablished quorum: giving up after 30+ seconds. Stack Trace: junit.framework.AssertionFailedError: client could not connect to reestablished quorum: giving up after 30+ seconds. at org.apache.zookeeper.test.ReconfigTest.testNormalOperation(ReconfigTest.java:153) at org.apache.zookeeper.server.quorum.StandaloneDisabledTest.startSingleServerTest(StandaloneDisabledTest.java:75) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52) REGRESSION: org.apache.zookeeper.test.LETest.testLE Error Message: Threads didn't join Stack Trace: junit.framework.AssertionFailedError: Threads didn't join at org.apache.zookeeper.test.LETest.testLE(LETest.java:123) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
[jira] [Commented] (ZOOKEEPER-1423) 4lw and jmx should expose the size of the datadir/datalogdir
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1395#comment-1395
]
Rakesh R commented on ZOOKEEPER-1423:
-
Thanks Edward for the patch, lgtm mostly. I've few comments, please see:
# Format issues, please correct
{code}
+ public long getDataDirSize();
+public long getLogDirSize();
{code}
{code}
+
+public long getDataDirSize() {
+ return provider.getDataDirSize();
+}
+
+public long getLogDirSize() {
+ return provider.getLogDirSize();
+}
{code}
# Can we print the o/p in a single line like:
{code}
datadir: + dir + size: + dataSize
logdir: + dir + size: + logSize
{code}
# Small correction,
{code}
the total size of data and log (snapshot) directories' content in bytes.
{code}
Actually it should be snapshot and log, can we rephrase like:
{code}
the total size of snapshot and log files in bytes
{code}
# I feel, its good to expose the dirs path in MBean too.
# please provide javadocs for #getDataDirSize() and #getLogDirSize()
4lw and jmx should expose the size of the datadir/datalogdir
Key: ZOOKEEPER-1423
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1423
Project: ZooKeeper
Issue Type: Improvement
Components: jmx
Affects Versions: 3.5.0
Reporter: Patrick Hunt
Assignee: Edward Ribeiro
Labels: newbie
Attachments: ZOOKEEPER-1423.2.patch, ZOOKEEPER-1423.3.patch,
ZOOKEEPER-1423.patch
There are no metrics currently available on the size of the
datadir/datalogdir. These grow w/o bound unless the cleanup script is run. It
would be good to expose these metrics through jmx/4lw such that monitoring
can be done on the size. Would key ppl in on whether cleanup was actually
running. In particular this could be monitored/alerted on by third party
systems (nagios, ganglia and the like).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1423) 4lw and jmx should expose the size of the datadir/datalogdir
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13951114#comment-13951114 ] Hadoop QA commented on ZOOKEEPER-1423: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12566406/ZOOKEEPER-1423.3.patch against trunk revision 1582572. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1992//console This message is automatically generated. 4lw and jmx should expose the size of the datadir/datalogdir Key: ZOOKEEPER-1423 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1423 Project: ZooKeeper Issue Type: Improvement Components: jmx Affects Versions: 3.5.0 Reporter: Patrick Hunt Assignee: Edward Ribeiro Labels: newbie Attachments: ZOOKEEPER-1423.2.patch, ZOOKEEPER-1423.3.patch, ZOOKEEPER-1423.patch There are no metrics currently available on the size of the datadir/datalogdir. These grow w/o bound unless the cleanup script is run. It would be good to expose these metrics through jmx/4lw such that monitoring can be done on the size. Would key ppl in on whether cleanup was actually running. In particular this could be monitored/alerted on by third party systems (nagios, ganglia and the like). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (ZOOKEEPER-1797) PurgeTxnLog may delete data logs during roll
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-1797: Attachment: ZOOKEEPER-1797.patch Reattaching the same patch again to see testcase execution PurgeTxnLog may delete data logs during roll Key: ZOOKEEPER-1797 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1797 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.4.5 Reporter: Derek Dagit Assignee: Rakesh R Priority: Critical Fix For: 3.5.0 Attachments: ZOOKEEPER-1797.patch, ZOOKEEPER-1797.patch org.apache.zookeeper.server.PurgeTxnLog deletes old data logs and snapshots, keeping the newest N snapshots and any data logs that have been written since the snapshot. It does this by listing the available snapshots logs and creates a blacklist of snapshots and logs that should not be deleted. Then, it searches for and deletes all logs and snapshots that are not in this list. It appears that if logs are rolling or a new snapshot is created during this process, then these newer files will be unintentionally deleted. -- This message was sent by Atlassian JIRA (v6.2#6252)
Failed: ZOOKEEPER-1423 PreCommit Build #1992
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1423 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1992/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 79 lines...] [exec] patching file src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java [exec] Hunk #1 FAILED at 18. [exec] Hunk #2 succeeded at 52 (offset -1 lines). [exec] Hunk #3 succeeded at 837 (offset 6 lines). [exec] Hunk #4 succeeded at 956 (offset 6 lines). [exec] 1 out of 4 hunks FAILED -- saving rejects to file src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java.rej [exec] patching file src/java/main/org/apache/zookeeper/server/ZooKeeperServerBean.java [exec] patching file src/java/main/org/apache/zookeeper/server/ServerCnxn.java [exec] patching file src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml [exec] Hunk #1 succeeded at 1431 (offset 110 lines). [exec] PATCH APPLICATION FAILED [exec] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12566406/ZOOKEEPER-1423.3.patch [exec] against trunk revision 1582572. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] -1 patch. The patch command could not apply the patch. [exec] [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1992//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 306fbcf7294dcd4ddc6051a1a6735d0b9701129b logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1674: exec returned: 1 Total time: 41 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-1423 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## No tests ran.
[jira] [Commented] (ZOOKEEPER-1402) Upload Zookeeper package to Maven Central
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13951130#comment-13951130 ] Giridharan Kesavan commented on ZOOKEEPER-1402: --- [~phunt] Some how I missed this jira. the moment we publish artifact to the Apache Nexus reop, and promoted to release, there is an an automatic sync which take care of pushing release artifacts from Apache Nexus to Maven Central. There is not much that we have to do, except following some pom guidelines. Here are some helpful links: https://maven.apache.org/guides/mini/guide-central-repository-upload.html https://docs.sonatype.org/display/Repository/Central+Sync+Requirements Upload Zookeeper package to Maven Central - Key: ZOOKEEPER-1402 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1402 Project: ZooKeeper Issue Type: Improvement Affects Versions: 3.3.4 Reporter: Igor Lazebny Assignee: Flavio Junqueira Priority: Minor Fix For: 3.4.7 It would be great to make Zookeeper package available in Maven Central as other Apache projects do (Camel, CXF, ActiveMQ, Karaf, etc). That would simplify usage of this package in maven builds. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (ZOOKEEPER-1797) PurgeTxnLog may delete data logs during roll
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-1797: Attachment: ZOOKEEPER-1797.patch PurgeTxnLog may delete data logs during roll Key: ZOOKEEPER-1797 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1797 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.4.5 Reporter: Derek Dagit Fix For: 3.5.0 Attachments: ZOOKEEPER-1797.patch org.apache.zookeeper.server.PurgeTxnLog deletes old data logs and snapshots, keeping the newest N snapshots and any data logs that have been written since the snapshot. It does this by listing the available snapshots logs and creates a blacklist of snapshots and logs that should not be deleted. Then, it searches for and deletes all logs and snapshots that are not in this list. It appears that if logs are rolling or a new snapshot is created during this process, then these newer files will be unintentionally deleted. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (ZOOKEEPER-1797) PurgeTxnLog may delete data logs during roll
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michi Mutsuzaki updated ZOOKEEPER-1797: --- Fix Version/s: 3.4.7 PurgeTxnLog may delete data logs during roll Key: ZOOKEEPER-1797 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1797 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.4.5 Reporter: Derek Dagit Assignee: Rakesh R Priority: Critical Fix For: 3.4.7, 3.5.0 Attachments: ZOOKEEPER-1797.patch, ZOOKEEPER-1797.patch org.apache.zookeeper.server.PurgeTxnLog deletes old data logs and snapshots, keeping the newest N snapshots and any data logs that have been written since the snapshot. It does this by listing the available snapshots logs and creates a blacklist of snapshots and logs that should not be deleted. Then, it searches for and deletes all logs and snapshots that are not in this list. It appears that if logs are rolling or a new snapshot is created during this process, then these newer files will be unintentionally deleted. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (ZOOKEEPER-1797) PurgeTxnLog may delete data logs during roll
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michi Mutsuzaki updated ZOOKEEPER-1797: --- Priority: Blocker (was: Critical) PurgeTxnLog may delete data logs during roll Key: ZOOKEEPER-1797 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1797 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.4.5 Reporter: Derek Dagit Assignee: Rakesh R Priority: Blocker Fix For: 3.4.7, 3.5.0 Attachments: ZOOKEEPER-1797.patch, ZOOKEEPER-1797.patch org.apache.zookeeper.server.PurgeTxnLog deletes old data logs and snapshots, keeping the newest N snapshots and any data logs that have been written since the snapshot. It does this by listing the available snapshots logs and creates a blacklist of snapshots and logs that should not be deleted. Then, it searches for and deletes all logs and snapshots that are not in this list. It appears that if logs are rolling or a new snapshot is created during this process, then these newer files will be unintentionally deleted. -- This message was sent by Atlassian JIRA (v6.2#6252)
Failed: ZOOKEEPER-1797 PreCommit Build #1993
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1797 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1993/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 294119 lines...] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12637457/ZOOKEEPER-1797.patch [exec] against trunk revision 1582572. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1993//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1993//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1993//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 78cc4ca8d8f0370489c432161bfeb9a715d053e3 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1674: exec returned: 1 Total time: 33 minutes 37 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-1797 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## 1 tests failed. FAILED: org.apache.zookeeper.server.quorum.StandaloneDisabledTest.startSingleServerTest Error Message: client could not connect to reestablished quorum: giving up after 30+ seconds. Stack Trace: junit.framework.AssertionFailedError: client could not connect to reestablished quorum: giving up after 30+ seconds. at org.apache.zookeeper.test.ReconfigTest.testNormalOperation(ReconfigTest.java:153) at org.apache.zookeeper.server.quorum.StandaloneDisabledTest.startSingleServerTest(StandaloneDisabledTest.java:75) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
[jira] [Commented] (ZOOKEEPER-1797) PurgeTxnLog may delete data logs during roll
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13951184#comment-13951184 ] Hadoop QA commented on ZOOKEEPER-1797: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12637457/ZOOKEEPER-1797.patch against trunk revision 1582572. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1993//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1993//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1993//console This message is automatically generated. PurgeTxnLog may delete data logs during roll Key: ZOOKEEPER-1797 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1797 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.4.5 Reporter: Derek Dagit Assignee: Rakesh R Priority: Blocker Fix For: 3.4.7, 3.5.0 Attachments: ZOOKEEPER-1797.patch, ZOOKEEPER-1797.patch org.apache.zookeeper.server.PurgeTxnLog deletes old data logs and snapshots, keeping the newest N snapshots and any data logs that have been written since the snapshot. It does this by listing the available snapshots logs and creates a blacklist of snapshots and logs that should not be deleted. Then, it searches for and deletes all logs and snapshots that are not in this list. It appears that if logs are rolling or a new snapshot is created during this process, then these newer files will be unintentionally deleted. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (ZOOKEEPER-1797) PurgeTxnLog may delete data logs during roll
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-1797: Priority: Critical (was: Major) PurgeTxnLog may delete data logs during roll Key: ZOOKEEPER-1797 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1797 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.4.5 Reporter: Derek Dagit Priority: Critical Fix For: 3.5.0 Attachments: ZOOKEEPER-1797.patch org.apache.zookeeper.server.PurgeTxnLog deletes old data logs and snapshots, keeping the newest N snapshots and any data logs that have been written since the snapshot. It does this by listing the available snapshots logs and creates a blacklist of snapshots and logs that should not be deleted. Then, it searches for and deletes all logs and snapshots that are not in this list. It appears that if logs are rolling or a new snapshot is created during this process, then these newer files will be unintentionally deleted. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1797) PurgeTxnLog may delete data logs during roll
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13950769#comment-13950769 ] Hadoop QA commented on ZOOKEEPER-1797: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12637398/ZOOKEEPER-1797.patch against trunk revision 1582572. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1991//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1991//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1991//console This message is automatically generated. PurgeTxnLog may delete data logs during roll Key: ZOOKEEPER-1797 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1797 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.4.5 Reporter: Derek Dagit Assignee: Rakesh R Priority: Critical Fix For: 3.5.0 Attachments: ZOOKEEPER-1797.patch org.apache.zookeeper.server.PurgeTxnLog deletes old data logs and snapshots, keeping the newest N snapshots and any data logs that have been written since the snapshot. It does this by listing the available snapshots logs and creates a blacklist of snapshots and logs that should not be deleted. Then, it searches for and deletes all logs and snapshots that are not in this list. It appears that if logs are rolling or a new snapshot is created during this process, then these newer files will be unintentionally deleted. -- This message was sent by Atlassian JIRA (v6.2#6252)
Review Request 19794: PurgeTxnLog may delete data logs during roll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19794/ --- Review request for zookeeper, fpj, michim, Raul Gutierrez Segales, and Camille Fournier. Bugs: ZOOKEEPER-1797 https://issues.apache.org/jira/browse/ZOOKEEPER-1797 Repository: zookeeper Description --- PurgeTxnLog may delete data logs if logs are rolling or a new snapshot is created during this process Diffs - ./src/java/main/org/apache/zookeeper/server/PurgeTxnLog.java 1581683 ./src/java/test/org/apache/zookeeper/test/PurgeTxnTest.java 1581683 Diff: https://reviews.apache.org/r/19794/diff/ Testing --- I've tried to add a tests Thanks, Rakesh R
[jira] [Commented] (ZOOKEEPER-1797) PurgeTxnLog may delete data logs during roll
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13951210#comment-13951210 ] Rakesh R commented on ZOOKEEPER-1797: - Please ignore the test failure, its same as ZOOKEEPER-1870 Review Request at https://reviews.apache.org/r/19794/ PurgeTxnLog may delete data logs during roll Key: ZOOKEEPER-1797 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1797 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.4.5 Reporter: Derek Dagit Assignee: Rakesh R Priority: Blocker Fix For: 3.4.7, 3.5.0 Attachments: ZOOKEEPER-1797.patch, ZOOKEEPER-1797.patch org.apache.zookeeper.server.PurgeTxnLog deletes old data logs and snapshots, keeping the newest N snapshots and any data logs that have been written since the snapshot. It does this by listing the available snapshots logs and creates a blacklist of snapshots and logs that should not be deleted. Then, it searches for and deletes all logs and snapshots that are not in this list. It appears that if logs are rolling or a new snapshot is created during this process, then these newer files will be unintentionally deleted. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1659) Add JMX support for dynamic reconfiguration
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13951238#comment-13951238 ] Alexander Shraer commented on ZOOKEEPER-1659: - Rakesh, the committed config is stored in QuorumPeer.quorumVerifier, and set in QuorumPeer.setQuorumVerifier(), so that may be a good place to start. A QuorumVerifier can currently be either a QurumMaj or QuorumHierarchical, see org.apache.zookeeper.server.quorum.flexible. If you have any questions about the reconfig implementation, feel free to ping me shra...@gmail.com Add JMX support for dynamic reconfiguration --- Key: ZOOKEEPER-1659 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1659 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.5.0 Reporter: Alexander Shraer Priority: Blocker Fix For: 3.5.0 We need to update JMX during reconfigurations. Currently, reconfiguration changes are not reflected in JConsole. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (ZOOKEEPER-1460) IPv6 literal address not supported for quorum members
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thawan Kooburat updated ZOOKEEPER-1460:
---
Assignee: Thawan Kooburat
IPv6 literal address not supported for quorum members
-
Key: ZOOKEEPER-1460
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1460
Project: ZooKeeper
Issue Type: Bug
Components: quorum
Affects Versions: 3.4.3
Reporter: Chris Dolan
Assignee: Thawan Kooburat
Via code inspection, I see that the server.nnn configuration key does not
support literal IPv6 addresses because the property value is split on :. In
v3.4.3, the problem is in QuorumPeerConfig:
{noformat}
String parts[] = value.split(:);
InetSocketAddress addr = new InetSocketAddress(parts[0],
Integer.parseInt(parts[1]));
{noformat}
In the current trunk
(http://svn.apache.org/viewvc/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java?view=markup)
this code has been refactored into QuorumPeer.QuorumServer, but the bug
remains:
{noformat}
String serverClientParts[] = addressStr.split(;);
String serverParts[] = serverClientParts[0].split(:);
addr = new InetSocketAddress(serverParts[0],
Integer.parseInt(serverParts[1]));
{noformat}
This bug probably affects very few users because most will naturally use a
hostname rather than a literal IP address. But given that IPv6 addresses are
supported for clients via ZOOKEEPER-667 it seems that server support should
be fixed too.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (ZOOKEEPER-297) centralize version numbering in the source/build
[ https://issues.apache.org/jira/browse/ZOOKEEPER-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13951606#comment-13951606 ] Michi Mutsuzaki commented on ZOOKEEPER-297: --- +1 The patch looks good to me. I'll wait for the pre-commit build to pass and check this in. Thanks Diego! centralize version numbering in the source/build Key: ZOOKEEPER-297 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-297 Project: ZooKeeper Issue Type: Improvement Components: build Affects Versions: 3.5.0 Reporter: Patrick Hunt Assignee: Diego de Oliveira Priority: Minor Labels: patch Fix For: 3.5.0 Attachments: build_version.patch, build_version.patch There are now three locations in the source repository that store the version number of the code: 1) build.xml 2) configure.ac 3) zookeeper_version.h these all have to be managed when releasing/branching/etc... would be better if there were just one place - at the very least the configure.ac should be used to generate the version for zookeeper_version.h. Can we do a better job (ie less) at this? -- This message was sent by Atlassian JIRA (v6.2#6252)
Failed: ZOOKEEPER-297 PreCommit Build #1994
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-297 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1994/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 76 lines...] [exec] Apply anyway? [n] [exec] Skipping patch. [exec] 1 out of 1 hunk ignored [exec] patching file b/src/c/configure.ac.in [exec] The next patch would delete the file a/src/c/include/zookeeper_version.h, [exec] which does not exist! Assume -R? [n] [exec] Apply anyway? [n] [exec] Skipping patch. [exec] 1 out of 1 hunk ignored [exec] patching file b/src/c/include/zookeeper_version.h.in [exec] PATCH APPLICATION FAILED [exec] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12637300/build_version.patch [exec] against trunk revision 1582572. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 4 new or modified tests. [exec] [exec] -1 patch. The patch command could not apply the patch. [exec] [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1994//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] dd539f89a6f761dde8e2a7822f0ae731b91d8f77 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1674: exec returned: 1 Total time: 44 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-297 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## No tests ran.
[jira] [Commented] (ZOOKEEPER-297) centralize version numbering in the source/build
[ https://issues.apache.org/jira/browse/ZOOKEEPER-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13951623#comment-13951623 ] Hadoop QA commented on ZOOKEEPER-297: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12637300/build_version.patch against trunk revision 1582572. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1994//console This message is automatically generated. centralize version numbering in the source/build Key: ZOOKEEPER-297 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-297 Project: ZooKeeper Issue Type: Improvement Components: build Affects Versions: 3.5.0 Reporter: Patrick Hunt Assignee: Diego de Oliveira Priority: Minor Labels: patch Fix For: 3.5.0 Attachments: build_version.patch, build_version.patch There are now three locations in the source repository that store the version number of the code: 1) build.xml 2) configure.ac 3) zookeeper_version.h these all have to be managed when releasing/branching/etc... would be better if there were just one place - at the very least the configure.ac should be used to generate the version for zookeeper_version.h. Can we do a better job (ie less) at this? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-297) centralize version numbering in the source/build
[ https://issues.apache.org/jira/browse/ZOOKEEPER-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13951629#comment-13951629 ] Michi Mutsuzaki commented on ZOOKEEPER-297: --- Hi Diego. Could you regenerate the patch using 'git diff --no-prefix'? Thanks! centralize version numbering in the source/build Key: ZOOKEEPER-297 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-297 Project: ZooKeeper Issue Type: Improvement Components: build Affects Versions: 3.5.0 Reporter: Patrick Hunt Assignee: Diego de Oliveira Priority: Minor Labels: patch Fix For: 3.5.0 Attachments: build_version.patch, build_version.patch There are now three locations in the source repository that store the version number of the code: 1) build.xml 2) configure.ac 3) zookeeper_version.h these all have to be managed when releasing/branching/etc... would be better if there were just one place - at the very least the configure.ac should be used to generate the version for zookeeper_version.h. Can we do a better job (ie less) at this? -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: Review Request 19794: PurgeTxnLog may delete data logs during roll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19794/#review38971 --- The patch looks great overall. I just had a few minor nitpicks. ./src/java/main/org/apache/zookeeper/server/PurgeTxnLog.java https://reviews.apache.org/r/19794/#comment71351 nit: trailing space ./src/java/main/org/apache/zookeeper/server/PurgeTxnLog.java https://reviews.apache.org/r/19794/#comment71356 We should probably define final strings for snapshot and log. ./src/java/test/org/apache/zookeeper/test/PurgeTxnTest.java https://reviews.apache.org/r/19794/#comment71352 nit: trailing space - michim On March 28, 2014, 6:42 p.m., Rakesh R wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19794/ --- (Updated March 28, 2014, 6:42 p.m.) Review request for zookeeper, fpj, michim, Raul Gutierrez Segales, and Camille Fournier. Bugs: ZOOKEEPER-1797 https://issues.apache.org/jira/browse/ZOOKEEPER-1797 Repository: zookeeper Description --- PurgeTxnLog may delete data logs if logs are rolling or a new snapshot is created during this process Diffs - ./src/java/main/org/apache/zookeeper/server/PurgeTxnLog.java 1581683 ./src/java/test/org/apache/zookeeper/test/PurgeTxnTest.java 1581683 Diff: https://reviews.apache.org/r/19794/diff/ Testing --- I've tried to add a tests Thanks, Rakesh R
[jira] [Commented] (ZOOKEEPER-1797) PurgeTxnLog may delete data logs during roll
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13951639#comment-13951639 ] Michi Mutsuzaki commented on ZOOKEEPER-1797: The patch looks good to me. I'd like to get +1 from another committer given the criticality of the bug. PurgeTxnLog may delete data logs during roll Key: ZOOKEEPER-1797 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1797 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.4.5 Reporter: Derek Dagit Assignee: Rakesh R Priority: Blocker Fix For: 3.4.7, 3.5.0 Attachments: ZOOKEEPER-1797.patch, ZOOKEEPER-1797.patch org.apache.zookeeper.server.PurgeTxnLog deletes old data logs and snapshots, keeping the newest N snapshots and any data logs that have been written since the snapshot. It does this by listing the available snapshots logs and creates a blacklist of snapshots and logs that should not be deleted. Then, it searches for and deletes all logs and snapshots that are not in this list. It appears that if logs are rolling or a new snapshot is created during this process, then these newer files will be unintentionally deleted. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michi Mutsuzaki updated ZOOKEEPER-1525: --- Assignee: Warren Turkal (was: Patrick Hunt) Plumb ZooKeeperServer object into auth plugins -- Key: ZOOKEEPER-1525 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1525 Project: ZooKeeper Issue Type: Improvement Reporter: Warren Turkal Assignee: Warren Turkal Fix For: 3.5.0 Attachments: ZOOKEEPER-1525.patch I want to plumb the ZooKeeperServer object into the auth plugins so that I can store authentication data in zookeeper itself. With access to the ZooKeeperServer object, I also have access to the ZKDatabase and can look up entries in the local copy of the zookeeper data. In order to implement this, I make sure that a ZooKeeperServer instance is passed in to the ProviderRegistry.initialize() method. Then initialize() will try to find a constructor for the AuthenticationProvider that takes a ZooKeeperServer instance. If the constructor is found, it will be used. Otherwise, initialize() will look for a constructor that takes no arguments and use that instead. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (ZOOKEEPER-297) centralize version numbering in the source/build
[ https://issues.apache.org/jira/browse/ZOOKEEPER-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Diego Oliveira updated ZOOKEEPER-297: - Attachment: build_version2.patch Fix path format with --no-prefix centralize version numbering in the source/build Key: ZOOKEEPER-297 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-297 Project: ZooKeeper Issue Type: Improvement Components: build Affects Versions: 3.5.0 Reporter: Patrick Hunt Assignee: Diego de Oliveira Priority: Minor Labels: patch Fix For: 3.5.0 Attachments: build_version.patch, build_version.patch, build_version2.patch There are now three locations in the source repository that store the version number of the code: 1) build.xml 2) configure.ac 3) zookeeper_version.h these all have to be managed when releasing/branching/etc... would be better if there were just one place - at the very least the configure.ac should be used to generate the version for zookeeper_version.h. Can we do a better job (ie less) at this? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13951652#comment-13951652
]
Michi Mutsuzaki commented on ZOOKEEPER-1525:
Hi Warren,
Sorry for super-slow response. I have 2 comments:
1. Could you fix these warnings?
{noformat}
compile:
[javac] Compiling 3 source files to
/home/michi/svndev/zookeeper/trunk/build/classes
[javac] warning: [options] bootstrap class path not set in conjunction with
-source 1.5
[javac]
/home/michi/svndev/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/auth/ProviderRegistry.java:57:
warning: [cast] redundant cast to AuthenticationProvider
[javac] ap =
(AuthenticationProvider)constructor.newInstance(zks);
[javac] ^
[javac]
/home/michi/svndev/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/auth/ProviderRegistry.java:60:
warning: [cast] redundant cast to AuthenticationProvider
[javac] ap =
(AuthenticationProvider)constructor.newInstance();
[javac] ^
[javac] 3 warnings
{noformat}
2. When does this throw NullPointerException? Isn't it supposed to throw
IllegalArgumentException if the arguments don't match?
{noformat}
+ConstructorAuthenticationProvider constructor =
c.getConstructor(ZooKeeperServer.class);
+try {
+ap =
(AuthenticationProvider)constructor.newInstance(zks);
+} catch (NullPointerException e) {
+constructor = c.getConstructor();
+ap =
(AuthenticationProvider)constructor.newInstance();
+}
{noformat}
Plumb ZooKeeperServer object into auth plugins
--
Key: ZOOKEEPER-1525
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1525
Project: ZooKeeper
Issue Type: Improvement
Reporter: Warren Turkal
Assignee: Warren Turkal
Fix For: 3.5.0
Attachments: ZOOKEEPER-1525.patch
I want to plumb the ZooKeeperServer object into the auth plugins so that I
can store authentication data in zookeeper itself. With access to the
ZooKeeperServer object, I also have access to the ZKDatabase and can look up
entries in the local copy of the zookeeper data.
In order to implement this, I make sure that a ZooKeeperServer instance is
passed in to the ProviderRegistry.initialize() method. Then initialize() will
try to find a constructor for the AuthenticationProvider that takes a
ZooKeeperServer instance. If the constructor is found, it will be used.
Otherwise, initialize() will look for a constructor that takes no arguments
and use that instead.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (ZOOKEEPER-297) centralize version numbering in the source/build
[ https://issues.apache.org/jira/browse/ZOOKEEPER-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Diego Oliveira updated ZOOKEEPER-297: - Attachment: build_version3.patch Michi, sorry, inverted revisions... rsrs. Now I think it's ok. centralize version numbering in the source/build Key: ZOOKEEPER-297 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-297 Project: ZooKeeper Issue Type: Improvement Components: build Affects Versions: 3.5.0 Reporter: Patrick Hunt Assignee: Diego de Oliveira Priority: Minor Labels: patch Fix For: 3.5.0 Attachments: build_version.patch, build_version.patch, build_version2.patch, build_version3.patch There are now three locations in the source repository that store the version number of the code: 1) build.xml 2) configure.ac 3) zookeeper_version.h these all have to be managed when releasing/branching/etc... would be better if there were just one place - at the very least the configure.ac should be used to generate the version for zookeeper_version.h. Can we do a better job (ie less) at this? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (ZOOKEEPER-1408) CLI: sort output of ls command
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michi Mutsuzaki updated ZOOKEEPER-1408: --- Attachment: ZOOKEEPER-1408.patch CLI: sort output of ls command -- Key: ZOOKEEPER-1408 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1408 Project: ZooKeeper Issue Type: Improvement Components: java client Reporter: Hartmut Lang Assignee: Hartmut Lang Priority: Minor Fix For: 3.5.0 Attachments: ZOOKEEPER-1408.patch, ZOOKEEPER-1408.patch, ZOOKEEPER-1408.patch, ZOOKEEPER-1408.patch Sort the output of the ls-command in the CLI. And remove the [] frame. Example: change output of ls / [test1, aa3, zkc1, aa2, aa1, zookeeper] to aa1, aa2, aa3, test1, zk1, zookeeper -- This message was sent by Atlassian JIRA (v6.2#6252)
Failed: ZOOKEEPER-1525 PreCommit Build #1995
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1525 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1995/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 386185 lines...] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12539665/ZOOKEEPER-1525.patch [exec] against trunk revision 1582572. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1995//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1995//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1995//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 9a8935d7377cd2c40400592aaa47eaac8db0cf04 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1674: exec returned: 2 Total time: 32 minutes 38 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-1525 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## 5 tests failed. REGRESSION: org.apache.zookeeper.test.SaslAuthDesignatedClientTest.testAuth Error Message: test failed :org.apache.zookeeper.KeeperException$InvalidACLException: KeeperErrorCode = InvalidACL for /path1 Stack Trace: junit.framework.AssertionFailedError: test failed :org.apache.zookeeper.KeeperException$InvalidACLException: KeeperErrorCode = InvalidACL for /path1 at org.apache.zookeeper.test.SaslAuthDesignatedClientTest.testAuth(SaslAuthDesignatedClientTest.java:80) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52) REGRESSION: org.apache.zookeeper.test.SaslAuthDesignatedClientTest.testReadAccessUser Error Message: Unable to create znode Stack Trace: junit.framework.AssertionFailedError: Unable to create znode at org.apache.zookeeper.test.SaslAuthDesignatedClientTest.testReadAccessUser(SaslAuthDesignatedClientTest.java:120) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52) REGRESSION: org.apache.zookeeper.test.SaslAuthDesignatedServerTest.testAuth Error Message: test failed :org.apache.zookeeper.KeeperException$InvalidACLException: KeeperErrorCode = InvalidACL for /path1 Stack Trace: junit.framework.AssertionFailedError: test failed :org.apache.zookeeper.KeeperException$InvalidACLException: KeeperErrorCode = InvalidACL for /path1 at
[jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13951673#comment-13951673 ] Hadoop QA commented on ZOOKEEPER-1525: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12539665/ZOOKEEPER-1525.patch against trunk revision 1582572. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1995//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1995//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1995//console This message is automatically generated. Plumb ZooKeeperServer object into auth plugins -- Key: ZOOKEEPER-1525 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1525 Project: ZooKeeper Issue Type: Improvement Reporter: Warren Turkal Assignee: Warren Turkal Fix For: 3.5.0 Attachments: ZOOKEEPER-1525.patch I want to plumb the ZooKeeperServer object into the auth plugins so that I can store authentication data in zookeeper itself. With access to the ZooKeeperServer object, I also have access to the ZKDatabase and can look up entries in the local copy of the zookeeper data. In order to implement this, I make sure that a ZooKeeperServer instance is passed in to the ProviderRegistry.initialize() method. Then initialize() will try to find a constructor for the AuthenticationProvider that takes a ZooKeeperServer instance. If the constructor is found, it will be used. Otherwise, initialize() will look for a constructor that takes no arguments and use that instead. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13951674#comment-13951674 ] Michi Mutsuzaki commented on ZOOKEEPER-1525: It looks like this patch breaks SASL tests. Plumb ZooKeeperServer object into auth plugins -- Key: ZOOKEEPER-1525 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1525 Project: ZooKeeper Issue Type: Improvement Reporter: Warren Turkal Assignee: Warren Turkal Fix For: 3.5.0 Attachments: ZOOKEEPER-1525.patch I want to plumb the ZooKeeperServer object into the auth plugins so that I can store authentication data in zookeeper itself. With access to the ZooKeeperServer object, I also have access to the ZKDatabase and can look up entries in the local copy of the zookeeper data. In order to implement this, I make sure that a ZooKeeperServer instance is passed in to the ProviderRegistry.initialize() method. Then initialize() will try to find a constructor for the AuthenticationProvider that takes a ZooKeeperServer instance. If the constructor is found, it will be used. Otherwise, initialize() will look for a constructor that takes no arguments and use that instead. -- This message was sent by Atlassian JIRA (v6.2#6252)
Failed: ZOOKEEPER-297 PreCommit Build #1996
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-297 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1996/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 302850 lines...] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12637588/build_version3.patch [exec] against trunk revision 1582572. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 4 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1996//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1996//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1996//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 0df146e4632a8c7b0e226bc4bae03510835e2c10 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1674: exec returned: 1 Total time: 33 minutes 4 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-297 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## 1 tests failed. REGRESSION: org.apache.zookeeper.server.quorum.StandaloneDisabledTest.startSingleServerTest Error Message: client could not connect to reestablished quorum: giving up after 30+ seconds. Stack Trace: junit.framework.AssertionFailedError: client could not connect to reestablished quorum: giving up after 30+ seconds. at org.apache.zookeeper.test.ReconfigTest.testNormalOperation(ReconfigTest.java:153) at org.apache.zookeeper.server.quorum.StandaloneDisabledTest.startSingleServerTest(StandaloneDisabledTest.java:75) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
[jira] [Commented] (ZOOKEEPER-297) centralize version numbering in the source/build
[ https://issues.apache.org/jira/browse/ZOOKEEPER-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13951701#comment-13951701 ] Hadoop QA commented on ZOOKEEPER-297: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12637588/build_version3.patch against trunk revision 1582572. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1996//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1996//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1996//console This message is automatically generated. centralize version numbering in the source/build Key: ZOOKEEPER-297 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-297 Project: ZooKeeper Issue Type: Improvement Components: build Affects Versions: 3.5.0 Reporter: Patrick Hunt Assignee: Diego de Oliveira Priority: Minor Labels: patch Fix For: 3.5.0 Attachments: build_version.patch, build_version.patch, build_version2.patch, build_version3.patch There are now three locations in the source repository that store the version number of the code: 1) build.xml 2) configure.ac 3) zookeeper_version.h these all have to be managed when releasing/branching/etc... would be better if there were just one place - at the very least the configure.ac should be used to generate the version for zookeeper_version.h. Can we do a better job (ie less) at this? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1408) CLI: sort output of ls command
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13951708#comment-13951708 ] Hadoop QA commented on ZOOKEEPER-1408: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12637595/ZOOKEEPER-1408.patch against trunk revision 1582572. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1997//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1997//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1997//console This message is automatically generated. CLI: sort output of ls command -- Key: ZOOKEEPER-1408 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1408 Project: ZooKeeper Issue Type: Improvement Components: java client Reporter: Hartmut Lang Assignee: Hartmut Lang Priority: Minor Fix For: 3.5.0 Attachments: ZOOKEEPER-1408.patch, ZOOKEEPER-1408.patch, ZOOKEEPER-1408.patch, ZOOKEEPER-1408.patch Sort the output of the ls-command in the CLI. And remove the [] frame. Example: change output of ls / [test1, aa3, zkc1, aa2, aa1, zookeeper] to aa1, aa2, aa3, test1, zk1, zookeeper -- This message was sent by Atlassian JIRA (v6.2#6252)
Failed: ZOOKEEPER-1408 PreCommit Build #1997
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1408 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1997/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 306968 lines...] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12637595/ZOOKEEPER-1408.patch [exec] against trunk revision 1582572. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 4 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1997//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1997//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1997//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 7a360e653cee01382a90447d71da985d1fed53f7 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1674: exec returned: 1 Total time: 34 minutes 20 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-1408 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## 1 tests failed. FAILED: org.apache.zookeeper.server.quorum.StandaloneDisabledTest.startSingleServerTest Error Message: client could not connect to reestablished quorum: giving up after 30+ seconds. Stack Trace: junit.framework.AssertionFailedError: client could not connect to reestablished quorum: giving up after 30+ seconds. at org.apache.zookeeper.test.ReconfigTest.testNormalOperation(ReconfigTest.java:153) at org.apache.zookeeper.server.quorum.StandaloneDisabledTest.startSingleServerTest(StandaloneDisabledTest.java:75) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
[jira] [Commented] (ZOOKEEPER-1408) CLI: sort output of ls command
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13951718#comment-13951718 ] Hadoop QA commented on ZOOKEEPER-1408: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12637595/ZOOKEEPER-1408.patch against trunk revision 1582572. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1998//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1998//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1998//console This message is automatically generated. CLI: sort output of ls command -- Key: ZOOKEEPER-1408 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1408 Project: ZooKeeper Issue Type: Improvement Components: java client Reporter: Hartmut Lang Assignee: Hartmut Lang Priority: Minor Fix For: 3.5.0 Attachments: ZOOKEEPER-1408.patch, ZOOKEEPER-1408.patch, ZOOKEEPER-1408.patch, ZOOKEEPER-1408.patch Sort the output of the ls-command in the CLI. And remove the [] frame. Example: change output of ls / [test1, aa3, zkc1, aa2, aa1, zookeeper] to aa1, aa2, aa3, test1, zk1, zookeeper -- This message was sent by Atlassian JIRA (v6.2#6252)
Success: ZOOKEEPER-1408 PreCommit Build #1998
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1408 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1998/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 298322 lines...] [exec] BUILD SUCCESSFUL [exec] Total time: 0 seconds [exec] [exec] [exec] [exec] [exec] +1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12637595/ZOOKEEPER-1408.patch [exec] against trunk revision 1582572. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 4 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1998//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1998//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1998//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 820d7e7fb44ef099fe88d7733b2175c7b57e5413 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD SUCCESSFUL Total time: 36 minutes 21 seconds Archiving artifacts Recording test results Description set: ZOOKEEPER-1408 Email was triggered for: Success Sending email for trigger: Success ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-1408) CLI: sort output of ls command
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13951728#comment-13951728 ] Michi Mutsuzaki commented on ZOOKEEPER-1408: +1 I'm checking this in. CLI: sort output of ls command -- Key: ZOOKEEPER-1408 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1408 Project: ZooKeeper Issue Type: Improvement Components: java client Reporter: Hartmut Lang Assignee: Hartmut Lang Priority: Minor Fix For: 3.5.0 Attachments: ZOOKEEPER-1408.patch, ZOOKEEPER-1408.patch, ZOOKEEPER-1408.patch, ZOOKEEPER-1408.patch Sort the output of the ls-command in the CLI. And remove the [] frame. Example: change output of ls / [test1, aa3, zkc1, aa2, aa1, zookeeper] to aa1, aa2, aa3, test1, zk1, zookeeper -- This message was sent by Atlassian JIRA (v6.2#6252)
ZooKeeper-trunk - Build # 2271 - Failure
See https://builds.apache.org/job/ZooKeeper-trunk/2271/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 54291 lines...] [junit] 2014-03-29 03:51:04,615 [myid:] - INFO [WorkerReceiver[myid=0]:FastLeaderElection$Messenger$WorkerReceiver@412] - WorkerReceiver is down [junit] 2014-03-29 03:51:04,611 [myid:] - INFO [WorkerSender[myid=0]:FastLeaderElection$Messenger$WorkerSender@445] - WorkerSender is down [junit] 2014-03-29 03:51:04,443 [myid:] - INFO [QuorumPeer[myid=0]/0:0:0:0:0:0:0:0:11261:Follower@194] - shutdown called [junit] java.lang.Exception: shutdown Follower [junit] at org.apache.zookeeper.server.quorum.Follower.shutdown(Follower.java:194) [junit] at org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:975) [junit] 2014-03-29 03:51:04,443 [myid:] - ERROR [LearnerHandler-/127.0.0.1:55370:LearnerHandler@571] - Unexpected exception causing shutdown while sock still open [junit] java.net.SocketTimeoutException: Read timed out [junit] at java.net.SocketInputStream.socketRead0(Native Method) [junit] at java.net.SocketInputStream.read(SocketInputStream.java:129) [junit] at java.io.BufferedInputStream.fill(BufferedInputStream.java:218) [junit] at java.io.BufferedInputStream.read(BufferedInputStream.java:237) [junit] at java.io.DataInputStream.readInt(DataInputStream.java:370) [junit] at org.apache.jute.BinaryInputArchive.readInt(BinaryInputArchive.java:63) [junit] at org.apache.zookeeper.server.quorum.QuorumPacket.deserialize(QuorumPacket.java:83) [junit] at org.apache.jute.BinaryInputArchive.readRecord(BinaryInputArchive.java:103) [junit] at org.apache.zookeeper.server.quorum.LearnerHandler.run(LearnerHandler.java:484) [junit] 2014-03-29 03:51:04,076 [myid:] - WARN [SendWorker:1:QuorumCnxManager$SendWorker@749] - Send worker leaving thread id 1 my id = 0 [junit] 2014-03-29 03:51:04,075 [myid:] - WARN [RecvWorker:1:QuorumCnxManager$RecvWorker@826] - Interrupting SendWorker [junit] 2014-03-29 03:51:24,771 [myid:] - WARN [LearnerHandler-/127.0.0.1:55370:LearnerHandler@584] - *** GOODBYE /127.0.0.1:55370 [junit] 2014-03-29 03:51:24,771 [myid:] - INFO [QuorumPeer[myid=0]/0:0:0:0:0:0:0:0:11261:LearnerZooKeeperServer@161] - Shutting down FATAL: channel is already closed [junit] 2014-03-29 03:51:24,770 [myid:] - WARN [LearnerHandler-/127.0.0.1:55375:LearnerHandler@584] - *** GOODBYE /127.0.0.1:55375 [junit] 2014-03-29 03:51:24,769 [myid:] - WARN [LearnerHandler-/127.0.0.1:55380:LearnerHandler@584] - *** GOODBYE /127.0.0.1:55380 [junit] 2014-03-29 03:51:24,768 [myid:] - WARN [SendWorker:0:QuorumCnxManager$SendWorker@740] - Interrupted while waiting for message on queue [junit] java.lang.InterruptedException [junit] at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.reportInterruptAfterWait(AbstractQueuedSynchronizer.java:1961) [junit] at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2038) [junit] at java.util.concurrent.ArrayBlockingQueue.poll(ArrayBlockingQueue.java:342) [junit] at org.apache.zookeeper.server.quorum.QuorumCnxManager.pollSendQueue(QuorumCnxManager.java:892) [junit] at org.apache.zookeeper.server.quorum.QuorumCnxManager.access$500(QuorumCnxManager.java:62) [junit] at org.apache.zookeeper.server.quorum.QuorumCnxManager$SendWorker.run(QuorumCnxManager.java:728) [junit] 2014-03-29 03:51:24,768 [myid:] - WARN [SendWorker:0:QuorumCnxManager$SendWorker@740] - Interrupted while waiting for message on queue [junit] java.lang.InterruptedException [junit] at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.reportInterruptAfterWait(AbstractQueuedSynchronizer.java:1961) hudson.remoting.ChannelClosedException: channel is already closed at hudson.remoting.Channel.send(Channel.java:524) at hudson.remoting.Request.call(Request.java:129) at hudson.remoting.Channel.call(Channel.java:722) at hudson.Launcher$RemoteLauncher.kill(Launcher.java:887) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:546) at hudson.model.Run.execute(Run.java:1688) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:88) at hudson.model.Executor.run(Executor.java:231) Caused by: java.io.IOException: Unexpected reader termination at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:76) Caused by: java.lang.OutOfMemoryError: GC overhead limit exceeded at
[jira] [Commented] (ZOOKEEPER-297) centralize version numbering in the source/build
[ https://issues.apache.org/jira/browse/ZOOKEEPER-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13951763#comment-13951763 ] Hudson commented on ZOOKEEPER-297: -- FAILURE: Integrated in ZooKeeper-trunk #2271 (See [https://builds.apache.org/job/ZooKeeper-trunk/2271/]) ZOOKEEPER-297. centralize version numbering in the source/build (Diego de Oliveira via michim) (michim: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1582941) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/build.xml * /zookeeper/trunk/src/c/configure.ac * /zookeeper/trunk/src/c/configure.ac.in * /zookeeper/trunk/src/c/include/zookeeper_version.h * /zookeeper/trunk/src/c/include/zookeeper_version.h.in centralize version numbering in the source/build Key: ZOOKEEPER-297 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-297 Project: ZooKeeper Issue Type: Improvement Components: build Affects Versions: 3.5.0 Reporter: Patrick Hunt Assignee: Diego de Oliveira Priority: Minor Labels: patch Fix For: 3.5.0 Attachments: build_version.patch, build_version.patch, build_version2.patch, build_version3.patch There are now three locations in the source repository that store the version number of the code: 1) build.xml 2) configure.ac 3) zookeeper_version.h these all have to be managed when releasing/branching/etc... would be better if there were just one place - at the very least the configure.ac should be used to generate the version for zookeeper_version.h. Can we do a better job (ie less) at this? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1725) Zookeeper Dynamic Conf writes out hostnames when IPs are supplied
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13951768#comment-13951768 ] Michi Mutsuzaki commented on ZOOKEEPER-1725: Actually I'd like to update the patch to use HostNameUtils. Zookeeper Dynamic Conf writes out hostnames when IPs are supplied - Key: ZOOKEEPER-1725 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1725 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.5.0 Reporter: Justin SB Assignee: Alexander Shraer Priority: Minor Fix For: 3.5.0 Attachments: ZOOKEEPER-1725-ver1.patch, ZOOKEEPER-1725.patch When writing the dynamic configuration out, Zookeeper writes out hostnames, even if an IP address is supplied. These may not correctly round-trip (e.g. 127.0.0.1 might be written as localhost which may then resolve to 127.0.0.1 and another IP address). This isn't actually causing problems for me right now, but seems very likely to cause hard-to-track-down problems in future. -- This message was sent by Atlassian JIRA (v6.2#6252)
