[developer] Re: [openzfs/openzfs] 9194 mechanism to override ashift at pool creation time (#570)

2018-05-01 Thread Prakash Surya 
Closed #570 via 08741101d36c336bfa41ea4a2b535f8608899f1a.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/570#event-1604096507
--
openzfs: openzfs-developer
Permalink: 
https://openzfs.topicbox.com/groups/developer/discussions/Te17b61abfaa32615-M10b16659048cc2d853bcb84c
Delivery options: https://openzfs.topicbox.com/groups

[developer] Re: [openzfs/openzfs] 9194 mechanism to override ashift at pool creation time (#570)

2018-03-09 Thread Richard Elling 
richardelling commented on this pull request.



> @@ -1431,6 +1433,7 @@ vdev_open(vdev_t *vd)
vd->vdev_asize = asize;
vd->vdev_max_asize = max_asize;
vd->vdev_ashift = MAX(ashift, vd->vdev_ashift);
+   vd->vdev_ashift = MAX(zfs_ashift_override, vd->vdev_ashift);

A better name is `zfs_ashift_min` which is a fine approach.

For the name `zfs_ashift_override` the expected code is something like:
`vd->vdev_ashift = zfs_ashift_override > 0 ? zfs_ashift_override : 
vd->vdev_ashift;`
which is also a fine approach.

Basically, I'd like to see it become less ambiguous and more consistent with 
other tunables.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/570#discussion_r173607794
--
openzfs: openzfs-developer
Permalink: 
https://openzfs.topicbox.com/groups/developer/discussions/Te17b61abfaa32615-Mb4537cdc078097099d823227
Delivery options: https://openzfs.topicbox.com/groups

[developer] Re: [openzfs/openzfs] 9194 mechanism to override ashift at pool creation time (#570)

2018-03-06 Thread brad-lewis 
brad-lewis commented on this pull request.



> @@ -1431,6 +1433,7 @@ vdev_open(vdev_t *vd)
vd->vdev_asize = asize;
vd->vdev_max_asize = max_asize;
vd->vdev_ashift = MAX(ashift, vd->vdev_ashift);
+   vd->vdev_ashift = MAX(zfs_ashift_override, vd->vdev_ashift);

Does it seem strange to you because the default also serves as the minimum(and 
you'd like a separate minimum field) or is it using the term override when it 
is subject to restrictions (and you prefer something more like 
zfs_ashift_hint)? 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/570#discussion_r172650085
--
openzfs: openzfs-developer
Permalink: 
https://openzfs.topicbox.com/groups/developer/discussions/Te17b61abfaa32615-M5c87dcb55592b93519ab3b1c
Delivery options: https://openzfs.topicbox.com/groups

[developer] Re: [openzfs/openzfs] 9194 mechanism to override ashift at pool creation time (#570)

2018-02-24 Thread Richard Elling 
richardelling commented on this pull request.



> @@ -1431,6 +1433,7 @@ vdev_open(vdev_t *vd)
vd->vdev_asize = asize;
vd->vdev_max_asize = max_asize;
vd->vdev_ashift = MAX(ashift, vd->vdev_ashift);
+   vd->vdev_ashift = MAX(zfs_ashift_override, vd->vdev_ashift);

it seems strange than an override really isn't an override, it is MAX() of the 
override and something else


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/570#pullrequestreview-99123563
--
openzfs-developer
Archives: 
https://openzfs.topicbox.com/groups/developer/discussions/Te17b61abfaa32615-M36177da9ac3fd11b67cb841d
Powered by Topicbox: https://topicbox.com

[developer] Re: [openzfs/openzfs] 9194 mechanism to override ashift at pool creation time (#570)

2018-02-24 Thread Igor K 
ikozhukhov approved this pull request.

thanks for update



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/570#pullrequestreview-99114330
--
openzfs-developer
Archives: 
https://openzfs.topicbox.com/groups/developer/discussions/Te17b61abfaa32615-M2db5fd2db8fc40b128515a06
Powered by Topicbox: https://topicbox.com

[developer] Re: [openzfs/openzfs] 9194 mechanism to override ashift at pool creation time (#570)

2018-02-23 Thread Allan Jude 
Would be nice to have this. On FreeBSD we currently use the global tunable 
zfs.min_auto_ashift to accomplish this.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/570#issuecomment-368177853
--
openzfs-developer
Archives: 
https://openzfs.topicbox.com/groups/developer/discussions/Te17b61abfaa32615-Mcfae213e0a33018d9a9bd599
Powered by Topicbox: https://topicbox.com