Re: Make clickable area of object links larger
> If I'm not mistaken, in NFA, you can create a custom subclass of > ModelAdmin that always sets list_display_links equal to list_display, > and have all of your models inherit from that. This is the most > flexible solution because people who don't want it to default to > clickable get their way, while you can have it your way too with > minimal effort. Win/win! ;) --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~--~~~~--~~--~--~---
Re: Make clickable area of object links larger
On Jul 13, 12:56 pm, David Danier <[EMAIL PROTECTED]> wrote: > So making the whole field () clickable should really be enough, the > row itself (everything inside ) does not need to be clickable by > default. If I'm not mistaken, in NFA, you can create a custom subclass of ModelAdmin that always sets list_display_links equal to list_display, and have all of your models inherit from that. This is the most flexible solution because people who don't want it to default to clickable get their way, while you can have it your way too with minimal effort. -Eric Florenzano --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~--~~~~--~~--~--~---
Re: Make clickable area of object links larger
> There is already a way to control which fields are links to the change > page: http://www.djangoproject.com/documentation/model-api/#list-display-links I know, thats what I meant. To make the whole row clickable you have to put all fields which are in list_display into list_display_links, too. So making the whole field () clickable should really be enough, the row itself (everything inside ) does not need to be clickable by default. Greetings, David Danier --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~--~~~~--~~--~--~---
Re: Make clickable area of object links larger
> Each row in a change list represents one object, usability suffers by > making only one potentially tiny (an integer primary key) field > clickable. What about supporting custom urls for some fields in the future? (e.g. linking to an foreign object for model.ForeignKey) I would make the whole field clickable, every other field can be made clickable by configuration, if someone wants. I don't like the idea of making the whole row clickable. Greetings, David Danier --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~--~~~~--~~--~--~---
Re: Make clickable area of object links larger
Ben et al; There is no reason to sit on this, especially while the sprint is going. I just wrote up a 2 line patch [1] that changes the display to block. It is a simple enough change. The next step is getting some review and committer time. This patch isn't critical for the 1.0 launch, so the later step might be hard, either way it is now in trac [2] and will get some attention sometime. [1] http://code.djangoproject.com/attachment/ticket/7733/7733-larger-admin-clickable-area.diff [2] http://code.djangoproject.com/ticket/7733 Thanks, Michael On Sat, Jul 12, 2008 at 9:34 AM, Ben Spaulding <[EMAIL PROTECTED]> wrote: > > I agree with Malcolm that making the whole row clickable is not a good > idea. However, that will effectively be the case for models that do > not have the list_display or filter options in their inner Admin class > (or the equivalent in newforms-admin) because the one link will be as > wide as the whole page. I do find this acceptable because those items > are generally not managed heavily with the admin. For example, > TaggedItems: > > - > http://junkdrawer.benspaulding.com/img/change_liist-no_list_display_or_filter.png > > I think I will wait another day or so before submitting a ticket. The > discussion has been constructive so far, and I think that more will be > valuable. > > Ben Spaulding > > > --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~--~~~~--~~--~--~---
Re: Make clickable area of object links larger
I agree with Malcolm that making the whole row clickable is not a good idea. However, that will effectively be the case for models that do not have the list_display or filter options in their inner Admin class (or the equivalent in newforms-admin) because the one link will be as wide as the whole page. I do find this acceptable because those items are generally not managed heavily with the admin. For example, TaggedItems: - http://junkdrawer.benspaulding.com/img/change_liist-no_list_display_or_filter.png I think I will wait another day or so before submitting a ticket. The discussion has been constructive so far, and I think that more will be valuable. Ben Spaulding --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~--~~~~--~~--~--~---
Re: Make clickable area of object links larger
On Sat, 2008-07-12 at 19:51 +0700, Mikhail Gusarov wrote: > Twas brillig at 22:43:11 12.07.2008 UTC+10 when [EMAIL PROTECTED] did gyre > and gimble: > > >> Even better, make the entire row the link (like trac). I don't see > >> why only the value of the first field should be the link. > > MT> That's a usability disaster. You accidentally click anywhere to > MT> give focus to the window > > Click-to-focus *IS* a usability disaster. > > P.S.: Fitt's law. Click to raise is not, however, and that's when this is applicable. Regards, Malcolm --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~--~~~~--~~--~--~---
Re: Make clickable area of object links larger
Twas brillig at 22:43:11 12.07.2008 UTC+10 when [EMAIL PROTECTED] did gyre and gimble: >> Even better, make the entire row the link (like trac). I don't see >> why only the value of the first field should be the link. MT> That's a usability disaster. You accidentally click anywhere to MT> give focus to the window Click-to-focus *IS* a usability disaster. P.S.: Fitt's law. -- pgplZ5QCkRdBD.pgp Description: PGP signature
Re: Make clickable area of object links larger
On Sat, 2008-07-12 at 05:26 -0700, Tai Lee wrote: > Even better, make the entire row the link (like trac). I don't see why > only the value of the first field should be the link. That's a usability disaster. You accidentally click anywhere to give focus to the window and it runs off to some random link. It's just one more thing that Trac gets completely wrong. Malcolm --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~--~~~~--~~--~--~---
Re: Make clickable area of object links larger
Even better, make the entire row the link (like trac). I don't see why only the value of the first field should be the link. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~--~~~~--~~--~--~---
Re: Make clickable area of object links larger
Hi Ben, Yes, it's worth it. Or alternatively you can blog this. On Sat, Jul 12, 2008 at 12:11 AM, Ben Spaulding <[EMAIL PROTECTED]> wrote: > > There are many cases where the clickable text of objects listed on a > change-list page is only a few characters. I propose making the entire > cell containing the link clickable. > > - http://junkdrawer.benspaulding.com/img/change_list-object_link-proposed.png > > This is easily achieved with a few minor CSS changes. I have already > written the patch which I use for myself. > > Is this worth submitting as a ticket/patch? > > > -- Best regards, Yuri V. Baburov, ICQ# 99934676, Skype: yuri.baburov, MSN: [EMAIL PROTECTED] --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~--~~~~--~~--~--~---
Re: Make clickable area of object links larger
On Sat, Jul 12, 2008 at 2:43 AM, J Meier <[EMAIL PROTECTED]> wrote: > > For me, yes it is. My users would appreciate it greatly. Even if it > doesn't go into Django, having a patch available on a ticket lets all > us others out here know about it. > > My CSS-fu is weak: How do you make the whole area clickable with just > style rules? I believe you can set the display of the anchor to block. That should fill the outer block. Regards Rajeev J Sebastian --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~--~~~~--~~--~--~---
Re: Make clickable area of object links larger
For me, yes it is. My users would appreciate it greatly. Even if it doesn't go into Django, having a patch available on a ticket lets all us others out here know about it. My CSS-fu is weak: How do you make the whole area clickable with just style rules? -Jim On Jul 11, 11:11 am, Ben Spaulding <[EMAIL PROTECTED]> wrote: > There are many cases where the clickable text of objects listed on a > change-list page is only a few characters. I propose making the entire > cell containing the link clickable. > > -http://junkdrawer.benspaulding.com/img/change_list-object_link-propos... > > This is easily achieved with a few minor CSS changes. I have already > written the patch which I use for myself. > > Is this worth submitting as a ticket/patch? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~--~~~~--~~--~--~---
Make clickable area of object links larger
There are many cases where the clickable text of objects listed on a change-list page is only a few characters. I propose making the entire cell containing the link clickable. - http://junkdrawer.benspaulding.com/img/change_list-object_link-proposed.png This is easily achieved with a few minor CSS changes. I have already written the patch which I use for myself. Is this worth submitting as a ticket/patch? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~--~~~~--~~--~--~---
