Re: RFC #2705 (Support for SELECT FOR UPDATE)

[Dan Fairs]

Thanks for following up on those.  I reviewed the Oracle tests shortly
before the 1.3 release and fixed all the real failures in the backend.
  The remaining failures as of then were due to the backend not
interacting well with the test suite as documented in ticket #15573,
plus a DB cache issue in #15580.



Thanks for that, Ian. It sounds like those Oracle failures aren't 
related to this patch, then.


Is there anything else that needs to be done before 2705 can be merged?

Cheers,
Dan
--
Dan Fairs | dan.fa...@gmail.com | www.fezconsulting.com

--
You received this message because you are subscribed to the Google Groups "Django 
developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: RFC #2705 (Support for SELECT FOR UPDATE)

[Ian Kelly]

On Wed, Apr 13, 2011 at 2:08 PM, Dan Fairs  wrote:
> However,
> it's worth mentioning that the Oracle tests seemed to be mostly broken in
> the first place, with dozens of errors.

Thanks for following up on those.  I reviewed the Oracle tests shortly
before the 1.3 release and fixed all the real failures in the backend.
 The remaining failures as of then were due to the backend not
interacting well with the test suite as documented in ticket #15573,
plus a DB cache issue in #15580.

Thanks,
Ian

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: RFC #2705 (Support for SELECT FOR UPDATE)

[Dan Fairs]

Hi,

Sorry to bump this one again.


Now 1.3's out the door, I'd like this to be looked at again, if possible.

http://code.djangoproject.com/ticket/2705



I'll re-apply Ramiro's patch locally and make sure everything still
checks out for me, and report back.


The latest version of the patch still applied cleanly for me and passed
tests when I tried it again late last week (r15043).



I've cleaned up the docs as per Jacob and Carl's points in their last 
review (thanks for those!). As mentioned in the ticket, I've also run 
the full suite against PostgreSQL, MySQL, SQLite and Oracle; there are 
no more breakages after the patch was applied than before it was 
applied. However, it's worth mentioning that the Oracle tests seemed to 
be mostly broken in the first place, with dozens of errors.


Aside from the docs issues that I've fixed, Jacob said he thought this 
was RFC - it'd be great to see that happen. As ever, let me know on the 
ticket if there's anything else that needs to be done.


Thanks,
Dan

--
Dan Fairs | dan.fa...@gmail.com | www.fezconsulting.com

--
You received this message because you are subscribed to the Google Groups "Django 
developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: RFC #2705 (Support for SELECT FOR UPDATE)

[Dan Fairs]

Hi,

Now 1.3's out the door, I'd like this to be looked at again, if possible.

  http://code.djangoproject.com/ticket/2705



I'll re-apply Ramiro's patch locally and make sure everything still checks out 
for me, and report back.


The latest version of the patch still applied cleanly for me and passed 
tests when I tried it again late last week (r15043).


I hope Jacob's comments about the tests has now been addressed - a 
mistake in transaction setup was masking an error. The tests should now 
be sane, and pass for me on MySQL, PostgreSQL, SQLite and Oracle.


I'd welcome review and feedback on improving the patch; I'd welcome 
seeing it merged even more. :)


Cheers,
Dan
--
Dan Fairs | dan.fa...@gmail.com | www.fezconsulting.com

--
You received this message because you are subscribed to the Google Groups "Django 
developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: RFC #2705 (Support for SELECT FOR UPDATE)

[Dan Fairs]

> 
> On Tue, Dec 21, 2010 at 10:31 AM, Dan Fairs  wrote:
>> I've mainly worked on the tests and docs, not the core content of the patch, 
>> but I'd welcome any comments on the implementation as well - I'd like to see 
>> this get in (be it in a 1.3 or 1.4 timeframe) so if any changes are needed 
>> for that, then that's fine. I'd also appreciate it if someone with access to 
>> Oracle could give the patch a try.
> 
> I'm on vacation now and don't have easy access to an Oracle setup, but
> I'll be happy to try it next week if nobody else has done it first.
> 

Thanks for the offer, Ian. Ramiro took the patch for a spin, and it worked OK 
(after some tweaks for Python < 2.6, and a missed empty __init__.py - thanks!). 

For the benefit of the archives, Ramiro's comment highlighted a wiki page on 
getting an Oracle setup going:

  http://code.djangoproject.com/wiki/OracleTestSetup

I'll re-apply Ramiro's patch locally and make sure everything still checks out 
for me, and report back.

Cheers,
Dan
--
Dan Fairs | dan.fa...@gmail.com | www.fezconsulting.com


-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-develop...@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: RFC #2705 (Support for SELECT FOR UPDATE)

[Ian Kelly]

On Tue, Dec 21, 2010 at 10:31 AM, Dan Fairs  wrote:
> I've mainly worked on the tests and docs, not the core content of the patch, 
> but I'd welcome any comments on the implementation as well - I'd like to see 
> this get in (be it in a 1.3 or 1.4 timeframe) so if any changes are needed 
> for that, then that's fine. I'd also appreciate it if someone with access to 
> Oracle could give the patch a try.

I'm on vacation now and don't have easy access to an Oracle setup, but
I'll be happy to try it next week if nobody else has done it first.

Cheers,
Ian

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-develop...@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.