Re: [edk2] [Network IO] About the SMB network share support

[Carsey, Jaben]

I think that no one has completed this task thus far.  I do not know of any 
currently ongoing effort to complete this task either.  Maybe you can use the 
FTP command in the interim to meet your needs?

I have some of the header files for SMB, but no working code.

-Jaben

> -Original Message-
> From: Blibbet [mailto:blib...@gmail.com]
> Sent: Monday, August 24, 2015 4:00 PM
> To: Mang Chia Ho 
> Cc: edk2-devel@lists.sourceforge.net
> Subject: Re: [edk2] [Network IO] About the SMB network share support
> 
> [replying on edk2-devel, not edk2-commits...]
> 
> On 08/24/2015 10:07 AM, Mang Chia Ho wrote:
> [...]
> >  (tianocore.sourceforge.net/wiki/Tasks#SMB_network_share_support)
> [...]
> > But this task item not release any information so far.
> > Does this task item is still ongoing? Or someone can share me the
> > information about this task item.
> 
> Last time I looked, there was no BSD SMB library/codebase for use. No
> BSD SMB library, no TianoCore library. There is at least one, maybe more
> closed-source commerical SMB/CIFS libs that may be usable, but not for
> TianoCore, only for IBVs/OEMs. UEFI has has TFTP and HTTP (but no
> HTTPS). UEFI 2.5 even has some HTTP helper APIs, though I haven't looked
> into them yet, maybe they can help. UEFI has TCP/UDP, so you can write
> your own non-SMB solution. IMO, probably easier to port another non-SMB
> protocol to UEFI than deal with MS specs/patents and TianoCore/GPL
> roadblocks.  Unless you have a BSD SMB library in C available.
> 
> 
> --
> ___
> edk2-devel mailing list
> edk2-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/edk2-devel

--
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [Patch] ShellPkg: Revert Persistent memory change to memmap that violates the Shell Spec

[Carsey, Jaben]

We will submit an request to UEFI to get the shell spec updated also.

From: Gao, Liming
Sent: Wednesday, July 15, 2015 6:27 PM
To: Carsey, Jaben; Phillips, Chris J (BCS CFE) (chr...@hp.com)
Cc: edk2-devel@lists.sourceforge.net
Subject: RE: [Patch] ShellPkg: Revert Persistent memory change to memmap that 
violates the Shell Spec
Importance: High

Jaben:
  Persistent memory is introduced in UEFI2.5. EDKII firmware code have added 
this support. So, I add it into Shell to show them.

  Could we update Shell spec to compliant with UEFI2.5?

Thanks
Liming
From: Carsey, Jaben
Sent: Thursday, July 16, 2015 5:41 AM
To: Gao, Liming; Phillips, Chris J (BCS CFE) 
(chr...@hp.com<mailto:chr...@hp.com>)
Cc: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>; 
Carsey, Jaben
Subject: [Patch] ShellPkg: Revert Persistent memory change to memmap that 
violates the Shell Spec

Liming or Chris,

Can you review this?

ShellPkg: Revert Persistent memory change to memmap that violates the Shell Spec

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey 
mailto:jaben.car...@intel.com>>
--
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [edk2-devel] 1 day until new edk2-devel email list transition

[Carsey, Jaben]

Can we get the old list to auto-respond with some info?

> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jordan Justen
> Sent: Wednesday, July 15, 2015 4:21 PM
> To: edk2-devel; edk2-de...@lists.01.org
> Subject: [edk2-devel] 1 day until new edk2-devel email list transition
> 
> There is about 1 day until the transition to the new edk2-devel list.
> 
> To update git send-email, run this command in your edk2 tree:
> 
> git config sendemail.to edk2-de...@lists.01.org
> 
> To configure Outlook for sending plain-text email to the list, I think
> this page might be helpful:
> 
> https://support.office.com/en-za/article/Change-the-message-format-to-
> HTML-Rich-Text-or-plain-text-d92bba10-7ed4-4413-a031-
> 7a1559112d90#__toc269980630
> 
> To sign up for the new list, visit:
> 
> https://lists.01.org/mailman/listinfo/edk2-devel
> 
> -Jordan
> 
> On 2015-07-14 15:25:01, Jordan Justen wrote:
> > Just to pick a transition time, let's change over ~2 days from now.
> >
> > In various time zones:
> >
> > $ TZ='UTC' date -d @1437087600
> > Thu Jul 16 23:00:00 UTC 2015
> >
> > $ TZ='America/Los_Angeles' date -d @1437087600
> > Thu Jul 16 16:00:00 PDT 2015
> >
> > $ TZ='Asia/Shanghai' date -d @1437087600
> > Fri Jul 17 07:00:00 CST 2015
> >
> > For your local time, try:
> > $ date -d @1437087600
> >
> > To subscribe to the new list:
> > https://lists.01.org/mailman/listinfo/edk2-devel
> >
> > Let's try to not use the new list until then to let people have one
> > last chance to subscribe. Shortly after the cut-off, we'll reject
> > email sent to the old list.
> >
> > -Jordan
> ___
> edk2-devel mailing list
> edk2-de...@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

--
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

[edk2] [Patch] ShellPkg: Revert Persistent memory change to memmap that violates the Shell Spec

[Carsey, Jaben]

Liming or Chris,

Can you review this?

ShellPkg: Revert Persistent memory change to memmap that violates the Shell Spec

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey 


REVERT_MemMap.c.patch
Description: REVERT_MemMap.c.patch
--
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [patch] NetworkPkg: Fix bios bootup hang issue when enable network.

[Carsey, Jaben]

Why add dynamic?  Doesn't DynamicEx meet the needs of Dynamic also?
 
> -Original Message-
> From: Zhang, Lubo
> Sent: Wednesday, July 15, 2015 8:50 AM
> To: Fu, Siyuan; Ye, Ting; edk2-devel@lists.sourceforge.net
> Subject: [patch] NetworkPkg: Fix bios bootup hang issue when enable
> network.
> 
> Add three PCD access method types for module to use the
> PcdDhcp6UidType value to fix the issue.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Zhang Lubo 
> Reviewed-by: Fu Siyuan 
> ---
>  NetworkPkg/NetworkPkg.dec | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/NetworkPkg/NetworkPkg.dec b/NetworkPkg/NetworkPkg.dec
> index 317cf41..52f9609 100644
> --- a/NetworkPkg/NetworkPkg.dec
> +++ b/NetworkPkg/NetworkPkg.dec
> @@ -67,11 +67,11 @@
> 
>## Private Key's size.
># @Prompt Private Key's size.
> 
> gEfiNetworkPkgTokenSpaceGuid.PcdIpsecUefiCertificateKeySize|0x3d5|UIN
> T32|0x0006
> 
> -[PcdsDynamicEx]
> +[PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
>## IPv6 DHCP Unique Identifier (DUID) Type configuration (From RFCs 3315
> and 6355).
># 01 = DUID Based on Link-layer Address Plus Time [DUID-LLT]
># 04 = UUID-Based DHCPv6 Unique Identifier (DUID-UUID)
># 02 = DUID Assigned by Vendor Based on Enterprise Number [DUID-EN]
> (not supported)
># 03 = DUID Based on Link-layer Address [DUID-LL] (not supported)
> --
> 1.9.5.msysgit.1
> 
> 
> 
> --
> Don't Limit Your Business. Reach for the Cloud.
> GigeNET's Cloud Solutions provide you with the tools and support that you
> need to offload your IT needs and focus on growing your business.
> Configured For All Businesses. Start Your Cloud Today.
> https://www.gigenetcloud.com/
> ___
> edk2-devel mailing list
> edk2-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/edk2-devel
> 
> --
> Don't Limit Your Business. Reach for the Cloud.
> GigeNET's Cloud Solutions provide you with the tools and support that
> you need to offload your IT needs and focus on growing your business.
> Configured For All Businesses. Start Your Cloud Today.
> https://www.gigenetcloud.com/
> ___
> edk2-devel mailing list
> edk2-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/edk2-devel

--
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [PATCH V2] ShellPkg: Add optional 'tftp' EFI Shell command.

[Carsey, Jaben]

Looks good to me.
Reviewed-by: Jaben Carsey 

> -Original Message-
> From: Olivier Martin [mailto:olivier.mar...@arm.com]
> Sent: Wednesday, July 15, 2015 8:12 AM
> To: Carsey, Jaben
> Cc: edk2-devel@lists.sourceforge.net; Ronald Cron; Ronald Cron
> Subject: [PATCH V2] ShellPkg: Add optional 'tftp' EFI Shell command.
> Importance: High
> 
> From: Ronald Cron 
> 
> This 'tftp' command allows to download a file from a TFTP server.
> A specific network interface can be chosen in case there are multiple
> interfaces.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ronald Cron 
> Reviewed-by: Olivier Martin 
> ---
>  ShellPkg/Include/Guid/ShellLibHiiGuid.h|   7 +
>  ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c| 880
> +
>  .../UefiShellTftpCommandLib.c  |  97 +++
>  .../UefiShellTftpCommandLib.h  |  63 ++
>  .../UefiShellTftpCommandLib.inf|  61 ++
>  .../UefiShellTftpCommandLib.uni| Bin 0 -> 8748 bytes
>  ShellPkg/ShellPkg.dec  |   1 +
>  ShellPkg/ShellPkg.dsc  |   3 +
>  8 files changed, 1112 insertions(+)
>  create mode 100644 ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
>  create mode 100644
> ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib.c
>  create mode 100644
> ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib.h
>  create mode 100644
> ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib.inf
>  create mode 100644
> ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib.uni
> 
> diff --git a/ShellPkg/Include/Guid/ShellLibHiiGuid.h
> b/ShellPkg/Include/Guid/ShellLibHiiGuid.h
> index dc694f2..62c2e72 100644
> --- a/ShellPkg/Include/Guid/ShellLibHiiGuid.h
> +++ b/ShellPkg/Include/Guid/ShellLibHiiGuid.h
> @@ -54,6 +54,12 @@
>{ \
>  0xf3d301bb, 0xf4a5, 0x45a8, { 0xb0, 0xb7, 0xfa, 0x99, 0x9c, 0x62, 0x37, 
> 0xae
> } \
>}
> +#define SHELL_TFTP_HII_GUID \
> +  { \
> +0x738a9314, 0x82c1, 0x4592, { 0x8f, 0xf7, 0xc1, 0xbd, 0xf1, 0xb2, 0x0e,
> 0xd4 } \
> +  }
> +
> +
>  #define SHELL_BCFG_HII_GUID \
>{ \
>  0x5f5f605d, 0x1583, 0x4a2d, {0xa6, 0xb2, 0xeb, 0x12, 0xda, 0xb4, 0xa2,
> 0xb6 } \
> @@ -67,6 +73,7 @@ extern EFI_GUID gShellLevel1HiiGuid;
>  extern EFI_GUID gShellLevel2HiiGuid;
>  extern EFI_GUID gShellLevel3HiiGuid;
>  extern EFI_GUID gShellNetwork1HiiGuid;
> +extern EFI_GUID gShellTftpHiiGuid;
>  extern EFI_GUID gShellBcfgHiiGuid;
> 
>  #endif
> diff --git a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
> b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
> new file mode 100644
> index 000..b872afd
> --- /dev/null
> +++ b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
> @@ -0,0 +1,880 @@
> +/** @file
> +  The implementation for the 'tftp' Shell command.
> +
> +  Copyright (c) 2015, ARM Ltd. All rights reserved.
> +
> +  This program and the accompanying materials
> +  are licensed and made available under the terms and conditions of the BSD
> License
> +  which accompanies this distribution.  The full text of the license may be
> found at
> +  http://opensource.org/licenses/bsd-license.php.
> +
> +  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"
> BASIS,
> +  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> EXPRESS OR IMPLIED.
> +**/
> +
> +#include "UefiShellTftpCommandLib.h"
> +
> +/*
> +   Constant strings and definitions related to the message indicating the
> amount of
> +   progress in the dowloading of a TFTP file.
> +*/
> +
> +// Frame for the progression slider
> +STATIC CONST CHAR16 mTftpProgressFrame[] = L"[   
>  ]";
> +
> +// Number of steps in the progression slider
> +#define TFTP_PROGRESS_SLIDER_STEPS  ((sizeof (mTftpProgressFrame) /
> sizeof (CHAR16)) - 3)
> +
> +// Size in number of characters plus one (final zero) of the message to
> +// indicate the progress of a TFTP download. The format is "[(progress
> slider:
> +// 40 characters)] (nb of KBytes downloaded so far: 7 characters) Kb". There
> +// are thus the number of characters in mTftpProgressFrame[] plus 11
> characters
> +// (2 // spaces, "Kb" and seven characters for the number of KBytes).
> +#define TFTP_PROGRESS_MESSAGE_SIZE  ((sizeof (mTftpProgressFrame) /
> sizeof (CHAR16)) + 12)
> +
> +// String to delete the TFTP progress message to be able to update it :
> +// (TFTP_PROGRESS_MESSAGE_SIZE-1) '\b'
> +STATIC CONST CHAR1

Re: [edk2] [PATCH] ShellPkg: Add optional 'tftp' EFI Shell command.

[Carsey, Jaben]

Reviewed-by: Jaben carsey 


>-Original Message-
>From: Olivier Martin [mailto:olivier.mar...@arm.com]
>Sent: Wednesday, July 15, 2015 2:32 AM
>To: Carsey, Jaben; Qiu, Shumin
>Cc: edk2-devel@lists.sourceforge.net; Ronald Cron; Ronald Cron
>Subject: RE: [PATCH] ShellPkg: Add optional 'tftp' EFI Shell command.
>Importance: High
>
>Thanks Jaben for the quick feedback. I replied in line.
>
>> -----Original Message-
>> From: Carsey, Jaben [mailto:jaben.car...@intel.com]
>> Sent: 15 July 2015 00:07
>> To: Olivier Martin; Qiu, Shumin
>> Cc: edk2-devel@lists.sourceforge.net; Ronald Cron; Ronald Cron; Carsey,
>> Jaben
>> Subject: RE: [PATCH] ShellPkg: Add optional 'tftp' EFI Shell command.
>>
>> Generally good.  2 questions below.
>>
>> > -Original Message-----
>> > From: Olivier Martin [mailto:olivier.mar...@arm.com]
>> > Sent: Tuesday, July 14, 2015 8:47 AM
>> > To: Carsey, Jaben; Qiu, Shumin
>> > Cc: edk2-devel@lists.sourceforge.net; Ronald Cron; Ronald Cron
>> > Subject: [PATCH] ShellPkg: Add optional 'tftp' EFI Shell command.
>> > Importance: High
>> >
>> > From: Ronald Cron 
>> >
>> > This 'tftp' command allows to download a file from a TFTP server.
>> > A specific network interface can be chosen in case there are multiple
>> > interfaces.
>> >
>> > Change-Id: I07887ac2c3eeb52b871f493582f7612c41398f09
>> > Contributed-under: TianoCore Contribution Agreement 1.0
>> > Signed-off-by: Ronald Cron 
>> > Reviewed-by: Olivier Martin 
>> > ---
>> >  ShellPkg/Include/Guid/ShellLibHiiGuid.h|   7 +
>> >  ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c| 875
>> > +
>> >  .../UefiShellTftpCommandLib.c  |  97 +++
>> >  .../UefiShellTftpCommandLib.h  |  63 ++
>> >  .../UefiShellTftpCommandLib.inf|  61 ++
>> >  .../UefiShellTftpCommandLib.uni| Bin 0 -> 8748 bytes
>> >  ShellPkg/ShellPkg.dec  |   1 +
>> >  ShellPkg/ShellPkg.dsc  |   3 +
>> >  8 files changed, 1107 insertions(+)
>> >  create mode 100644 ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
>> >  create mode 100644
>> > ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib.c
>> >  create mode 100644
>> > ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib.h
>> >  create mode 100644
>> > ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib.inf
>> >  create mode 100644
>> > ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib.uni
>> >
>> > diff --git a/ShellPkg/Include/Guid/ShellLibHiiGuid.h
>> > b/ShellPkg/Include/Guid/ShellLibHiiGuid.h
>> > index dc694f2..62c2e72 100644
>> > --- a/ShellPkg/Include/Guid/ShellLibHiiGuid.h
>> > +++ b/ShellPkg/Include/Guid/ShellLibHiiGuid.h
>> > @@ -54,6 +54,12 @@
>> >{ \
>> >  0xf3d301bb, 0xf4a5, 0x45a8, { 0xb0, 0xb7, 0xfa, 0x99, 0x9c, 0x62,
>> > 0x37, 0xae } \
>> >}
>> > +#define SHELL_TFTP_HII_GUID \
>> > +  { \
>> > +0x738a9314, 0x82c1, 0x4592, { 0x8f, 0xf7, 0xc1, 0xbd, 0xf1, 0xb2,
>> > +0x0e,
>> > 0xd4 } \
>> > +  }
>> > +
>> > +
>> >  #define SHELL_BCFG_HII_GUID \
>> >{ \
>> >  0x5f5f605d, 0x1583, 0x4a2d, {0xa6, 0xb2, 0xeb, 0x12, 0xda, 0xb4,
>> > 0xa2,
>> > 0xb6 } \
>> > @@ -67,6 +73,7 @@ extern EFI_GUID gShellLevel1HiiGuid;  extern
>> > EFI_GUID gShellLevel2HiiGuid;  extern EFI_GUID gShellLevel3HiiGuid;
>> > extern EFI_GUID gShellNetwork1HiiGuid;
>> > +extern EFI_GUID gShellTftpHiiGuid;
>> >  extern EFI_GUID gShellBcfgHiiGuid;
>> >
>> >  #endif
>> > diff --git a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
>> > b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
>> > new file mode 100644
>> > index 000..84401d8
>> > --- /dev/null
>> > +++ b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
>> > @@ -0,0 +1,875 @@
>> > +/** @file
>> > +  The implementation for the 'tftp' Shell command.
>> > +
>> > +  Copyright (c) 2015, ARM Ltd. All rights reserved.
>> > +
>> > +  This program and the accompanying materials  are licensed and made
>> > + available under the terms and conditions of the BSD
>> 

Re: [edk2] [Patch] MdeModulePkg: Correct PcdConOutColumn help string.

[Carsey, Jaben]

Question: if row or col is zero, does that set both values to maximum?

Reviewed-by: Jaben Carsey 

>-Original Message-
>From: Liming Gao [mailto:liming@intel.com]
>Sent: Tuesday, July 14, 2015 11:54 PM
>To: edk2-devel@lists.sourceforge.net
>Subject: [edk2] [Patch] MdeModulePkg: Correct PcdConOutColumn help string.
>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Liming Gao 
>---
> MdeModulePkg/MdeModulePkg.dec |   2 +-
> MdeModulePkg/MdeModulePkg.uni | Bin 166786 -> 166792 bytes
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
>index 623b07f..42f0435 100644
>--- a/MdeModulePkg/MdeModulePkg.dec
>+++ b/MdeModulePkg/MdeModulePkg.dec
>@@ -949,11 +949,11 @@
>   ## This PCD defines the Console output row. The default value is 25 
> according to UEFI spec.
>   #  This PCD could be set to 0 then console output would be at max column 
> and max row.
>   # @Prompt Console output row.
>   gEfiMdeModulePkgTokenSpaceGuid.PcdConOutRow|25|UINT32|0x4006
>
>-  ## This PCD defines the Console output row. The default value is 80 
>according to UEFI spec.
>+  ## This PCD defines the Console output column. The default value is 80 
>according to UEFI spec.
>   #  This PCD could be set to 0 then console output would be at max column 
> and max row.
>   # @Prompt Console output column.
>   gEfiMdeModulePkgTokenSpaceGuid.PcdConOutColumn|80|UINT32|0x4007
>
>   ## This PCD defines the video horizontal resolution.
>diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni
>index 
>b33060e79bf6ae54c18afb4feffdcf252583f5b5..e90e7d1e8fdeb0ead04bf689ddf83c1237aba855
> 100644
>GIT binary patch
>delta 34
>qcmZpg&ebuUt6>Y{j~(2}4EYQ>45bXY40+Sv>oDqX*V)M!b_oF7V+?Wt
>
>delta 22
>ecmeB}&eb%Xt6>Y{j~&w`wlSJ)H`>V
>--
>1.9.5.msysgit.0
>
>
>--
>Don't Limit Your Business. Reach for the Cloud.
>GigeNET's Cloud Solutions provide you with the tools and support that
>you need to offload your IT needs and focus on growing your business.
>Configured For All Businesses. Start Your Cloud Today.
>https://www.gigenetcloud.com/
>___
>edk2-devel mailing list
>edk2-devel@lists.sourceforge.net
>https://lists.sourceforge.net/lists/listinfo/edk2-devel

--
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [PATCH] ShellPkg: Add optional 'tftp' EFI Shell command.

[Carsey, Jaben]

Generally good.  2 questions below.

> -Original Message-
> From: Olivier Martin [mailto:olivier.mar...@arm.com]
> Sent: Tuesday, July 14, 2015 8:47 AM
> To: Carsey, Jaben; Qiu, Shumin
> Cc: edk2-devel@lists.sourceforge.net; Ronald Cron; Ronald Cron
> Subject: [PATCH] ShellPkg: Add optional 'tftp' EFI Shell command.
> Importance: High
> 
> From: Ronald Cron 
> 
> This 'tftp' command allows to download a file from
> a TFTP server.
> A specific network interface can be chosen in case
> there are multiple interfaces.
> 
> Change-Id: I07887ac2c3eeb52b871f493582f7612c41398f09
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ronald Cron 
> Reviewed-by: Olivier Martin 
> ---
>  ShellPkg/Include/Guid/ShellLibHiiGuid.h|   7 +
>  ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c| 875
> +
>  .../UefiShellTftpCommandLib.c  |  97 +++
>  .../UefiShellTftpCommandLib.h  |  63 ++
>  .../UefiShellTftpCommandLib.inf|  61 ++
>  .../UefiShellTftpCommandLib.uni| Bin 0 -> 8748 bytes
>  ShellPkg/ShellPkg.dec  |   1 +
>  ShellPkg/ShellPkg.dsc  |   3 +
>  8 files changed, 1107 insertions(+)
>  create mode 100644 ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
>  create mode 100644
> ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib.c
>  create mode 100644
> ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib.h
>  create mode 100644
> ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib.inf
>  create mode 100644
> ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib.uni
> 
> diff --git a/ShellPkg/Include/Guid/ShellLibHiiGuid.h
> b/ShellPkg/Include/Guid/ShellLibHiiGuid.h
> index dc694f2..62c2e72 100644
> --- a/ShellPkg/Include/Guid/ShellLibHiiGuid.h
> +++ b/ShellPkg/Include/Guid/ShellLibHiiGuid.h
> @@ -54,6 +54,12 @@
>{ \
>  0xf3d301bb, 0xf4a5, 0x45a8, { 0xb0, 0xb7, 0xfa, 0x99, 0x9c, 0x62, 0x37, 
> 0xae
> } \
>}
> +#define SHELL_TFTP_HII_GUID \
> +  { \
> +0x738a9314, 0x82c1, 0x4592, { 0x8f, 0xf7, 0xc1, 0xbd, 0xf1, 0xb2, 0x0e,
> 0xd4 } \
> +  }
> +
> +
>  #define SHELL_BCFG_HII_GUID \
>{ \
>  0x5f5f605d, 0x1583, 0x4a2d, {0xa6, 0xb2, 0xeb, 0x12, 0xda, 0xb4, 0xa2,
> 0xb6 } \
> @@ -67,6 +73,7 @@ extern EFI_GUID gShellLevel1HiiGuid;
>  extern EFI_GUID gShellLevel2HiiGuid;
>  extern EFI_GUID gShellLevel3HiiGuid;
>  extern EFI_GUID gShellNetwork1HiiGuid;
> +extern EFI_GUID gShellTftpHiiGuid;
>  extern EFI_GUID gShellBcfgHiiGuid;
> 
>  #endif
> diff --git a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
> b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
> new file mode 100644
> index 000..84401d8
> --- /dev/null
> +++ b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
> @@ -0,0 +1,875 @@
> +/** @file
> +  The implementation for the 'tftp' Shell command.
> +
> +  Copyright (c) 2015, ARM Ltd. All rights reserved.
> +
> +  This program and the accompanying materials
> +  are licensed and made available under the terms and conditions of the BSD
> License
> +  which accompanies this distribution.  The full text of the license may be
> found at
> +  http://opensource.org/licenses/bsd-license.php.
> +
> +  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"
> BASIS,
> +  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> EXPRESS OR IMPLIED.
> +**/
> +
> +#include "UefiShellTftpCommandLib.h"
> +
> +/*
> +   Constant strings and definitions related to the message indicating the
> amount of
> +   progress in the dowloading of a TFTP file.
> +*/
> +
> +// Frame for the progression slider
> +STATIC CONST CHAR16 mTftpProgressFrame[] = L"[   
>  ]";
> +
> +// Number of steps in the progression slider
> +#define TFTP_PROGRESS_SLIDER_STEPS  ((sizeof (mTftpProgressFrame) /
> sizeof (CHAR16)) - 3)
> +
> +// Size in number of characters plus one (final zero) of the message to
> +// indicate the progress of a TFTP download. The format is "[(progress
> slider:
> +// 40 characters)] (nb of KBytes downloaded so far: 7 characters) Kb". There
> +// are thus the number of characters in mTftpProgressFrame[] plus 11
> characters
> +// (2 // spaces, "Kb" and seven characters for the number of KBytes).
> +#define TFTP_PROGRESS_MESSAGE_SIZE  ((sizeof (mTftpProgressFrame) /
> sizeof (CHAR16)) + 12)
> +
> +// String to delete the TFTP progress message to be able to update it :
> +

Re: [edk2] [Patch] MdePkg: Correct comment typo from ECB to EBC in DebugLib.h

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

> -Original Message-
> From: Liming Gao [mailto:liming@intel.com]
> Sent: Tuesday, July 14, 2015 3:05 AM
> To: edk2-devel@lists.sourceforge.net
> Subject: [edk2] [Patch] MdePkg: Correct comment typo from ECB to EBC in
> DebugLib.h
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Liming Gao 
> ---
>  MdePkg/Include/Library/DebugLib.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Include/Library/DebugLib.h
> b/MdePkg/Include/Library/DebugLib.h
> index b38a847..219d147 100644
> --- a/MdePkg/Include/Library/DebugLib.h
> +++ b/MdePkg/Include/Library/DebugLib.h
> @@ -250,11 +250,11 @@ DebugPrintLevelEnabled (
>  /**
>Internal worker macro that calls DebugPrint().
> 
>This macro calls DebugPrint() passing in the debug error level, a format
>string, and a variable argument list.
> -  __VA_ARGS__ is not supported by ECB compiler, Microsoft Visual Studio
> .NET 2003
> +  __VA_ARGS__ is not supported by EBC compiler, Microsoft Visual Studio
> .NET 2003
>and Microsoft Windows Server 2003 Driver Development Kit (Microsoft
> WINDDK) version 3790.1830.
> 
>@param  Expression  Expression containing an error level, a format string,
>and a variable argument list based on the format 
> string.
> 
> --
> 1.9.5.msysgit.0
> 
> 
> --
> Don't Limit Your Business. Reach for the Cloud.
> GigeNET's Cloud Solutions provide you with the tools and support that
> you need to offload your IT needs and focus on growing your business.
> Configured For All Businesses. Start Your Cloud Today.
> https://www.gigenetcloud.com/
> ___
> edk2-devel mailing list
> edk2-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/edk2-devel

--
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] upload two drivers

[Carsey, Jaben]

From: Andrew Fish [mailto:af...@apple.com]
Sent: Tuesday, July 14, 2015 2:49 PM
To: Laszlo Ersek
Cc: S.Vieira; edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] upload two drivers


On Jul 14, 2015, at 2:21 PM, Laszlo Ersek 
mailto:ler...@redhat.com>> wrote:

On 07/14/15 20:31, S.Vieira wrote:

Hi everyone.

It's possible to do upload of two drives just in ONE .efi

I am wanting to do upload of the AtaAtapiPassThruDxe and AtaBusDxe only in
ONE file.

I think it should be possible to install any number of driver binding
protocol instances in a single driver module, on the image handle.
However, you'd have to merge the two drivers into one in C source code,
and then build the resultant driver.


You could also convert one of the drivers to a NULL library (change the INF 
file), and add that new NULL library to the DSC statement for the other driver.

Conceptually the build system could support this behavior, since the library 
constructors and entry point functions are auto-gem’ed code, but it currently 
does not.

It might work if you made the constructor what was the “main” and the 
destructor what was the driver unload and still get without a c code change 
required.

You’d also have to make sure that there are no variable collisions in the 
resultant image.  They might use the same name now…

-Jaben

Thanks,

Andrew Fish


Laszlo






Thx
S.Vieira


--
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel


--
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

--
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] ShellPkg: decode serial console attribute set failure status when used thru sermode command

[Carsey, Jaben]

17978

Reviewed-by: Jaben Carsey 

From: Shah, Tapan [mailto:tapands...@hp.com]
Sent: Monday, July 13, 2015 11:28 AM
To: Carsey, Jaben; edk2-devel@lists.sourceforge.net
Subject: ShellPkg: decode serial console attribute set failure status when used 
thru sermode command
Importance: High

Jaben,
   Can you review this change?

Thanks,
Tapan


ShellPkg: decode serial console attribute set failure status when used thru 
sermode command

Serial console driver may not support all databits / stopbits attribute values. 
But 'sermode' command only displays a general error indicating operation 
failure. Instead it should decode error status and report more accurate error 
message.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off by: Tapan Shah mailto:tapands...@hp.com>>


--
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [PATCH] ShellPkg: Increase PcdShellFileOperationSize

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

>-Original Message-
>From: Olivier Martin [mailto:olivier.mar...@arm.com]
>Sent: Tuesday, July 14, 2015 8:49 AM
>To: Leif Lindholm
>Cc: Brendan Jackman; edk2-devel@lists.sourceforge.net
>Subject: Re: [edk2] [PATCH] ShellPkg: Increase PcdShellFileOperationSize
>
>Ooops, I actually I have just realized I sent the patch to the wrong
>maintainer.
>
>
>On 14/07/15 15:39, Leif Lindholm wrote:
>> On Tue, Jul 14, 2015 at 02:59:00PM +0100, Olivier Martin wrote:
>>> From: Brendan Jackman 
>>>
>>> This improves performance for dumb filesystem drivers
>>> as block sizes tend to be more 4Kb size than 1000bit
>> OK, so serious nitpicking, but:
>>
>> 4KB and 1000 bytes.
>>
>> Change those, and
>> Reviewed-by: Leif Lindholm 
>>
>>> size.
>>>
>>> Contributed-under: TianoCore Contribution Agreement 1.0
>>> Signed-off-by: Brendan Jackman 
>>> Reviewed-by: Olivier Martin 
>>> ---
>>>   ShellPkg/ShellPkg.dec | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/ShellPkg/ShellPkg.dec b/ShellPkg/ShellPkg.dec
>>> index 32c0aff..b2f6326 100644
>>> --- a/ShellPkg/ShellPkg.dec
>>> +++ b/ShellPkg/ShellPkg.dec
>>> @@ -100,7 +100,7 @@
>>> gEfiShellPkgTokenSpaceGuid.PcdShellMapNameLength|50|UINT8|0x0009
>>>
>>> ## This determines how many bytes are read out of files at a time for 
>>> file operations (type, copy, etc...)
>>> -  
>>> gEfiShellPkgTokenSpaceGuid.PcdShellFileOperationSize|1000|UINT32|0x000A
>>> +  
>>> gEfiShellPkgTokenSpaceGuid.PcdShellFileOperationSize|0x1000|UINT32|0x000A
>>>
>>>   [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
>>> ## This flag is used to control the protocols produced by the shell
>>> --
>>> 2.1.1
>>>
>>>
>>> --
>>> Don't Limit Your Business. Reach for the Cloud.
>>> GigeNET's Cloud Solutions provide you with the tools and support that
>>> you need to offload your IT needs and focus on growing your business.
>>> Configured For All Businesses. Start Your Cloud Today.
>>> https://www.gigenetcloud.com/
>>> ___
>>> edk2-devel mailing list
>>> edk2-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/edk2-devel
>
>
>-- IMPORTANT NOTICE: The contents of this email and any attachments are 
>confidential and may also be privileged. If you are not the
>intended recipient, please notify the sender immediately and do not disclose 
>the contents to any other person, use it for any
>purpose, or store or copy the information in any medium.  Thank you.
>
>ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, 
>Registered in England & Wales, Company No:  2557590
>ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, 
>Registered in England & Wales, Company No:  2548782
>
>
>--
>Don't Limit Your Business. Reach for the Cloud.
>GigeNET's Cloud Solutions provide you with the tools and support that
>you need to offload your IT needs and focus on growing your business.
>Configured For All Businesses. Start Your Cloud Today.
>https://www.gigenetcloud.com/
>___
>edk2-devel mailing list
>edk2-devel@lists.sourceforge.net
>https://lists.sourceforge.net/lists/listinfo/edk2-devel

--
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [Patch] ShellPkg: Fix ping IPv6 stack usage mode failure issue

[Carsey, Jaben]

I guess that was more of a process question and should definitely not hold up 
your patch.

Reviewed-by: Jaben Carsey 

> -Original Message-
> From: Wu, Jiaxin
> Sent: Monday, July 13, 2015 5:45 PM
> To: Carsey, Jaben; edk2-devel@lists.sourceforge.net
> Subject: RE: [edk2] [Patch] ShellPkg: Fix ping IPv6 stack usage mode failure
> issue
> Importance: High
> 
> Hi Jaben,
> I have no idea about UNI file patch, I can attach corresponding patch and UIN
> file.
> 
> Maybe we need sent out UNI or any binary files as attached separately.
> 
> Thanks.
> Jiaxin
> 
> -Original Message-
> From: Carsey, Jaben
> Sent: Monday, July 13, 2015 11:11 PM
> To: Wu, Jiaxin; edk2-devel@lists.sourceforge.net
> Cc: Carsey, Jaben
> Subject: RE: [edk2] [Patch] ShellPkg: Fix ping IPv6 stack usage mode failure
> issue
> 
> Do we have a better way to allow inline commenting on the UNI file changes
> of patches like this?  It's pretty useless in the current email system...
> 
> The code change looks good, but needing to apply the patch just to see the
> UNI change seems unpleasant.
> 
> -Jaben
> 
> >-Original Message-
> >From: Jiaxin Wu [mailto:jiaxin...@intel.com]
> >Sent: Sunday, July 12, 2015 8:39 PM
> >To: edk2-devel@lists.sourceforge.net
> >Subject: [edk2] [Patch] ShellPkg: Fix ping IPv6 stack usage mode
> >failure issue
> >Importance: High
> >
> >Fix ping IPv6 stack usage mode failure issue and also update its the
> >help info.
> >Verified command:
> >*ping -?
> >*Ping -_ip6 -_s 2000:bbbnb::12 2000:::8
> >
> >Cc:Jaben Carsey  Cc:Shumin Qiu
> >
> >Contributed-under: TianoCore Contribution Agreement 1.0
> >Signed-off-by: Jiaxin Wu 
> >---
> > .../Library/UefiShellNetwork1CommandsLib/Ping.c |   7 +--
> > .../UefiShellNetwork1CommandsLib.uni| Bin 20078 -> 20910 
> > bytes
> > 2 files changed, 1 insertion(+), 6 deletions(-)
> >
> >diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> >b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> >index fda062d..643be23 100644
> >--- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> >+++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> >@@ -597,10 +597,11 @@ PingGenerateToken (
> >   // Assembly echo request packet.
> >   //
> >   Request->Type= (UINT8)(Private-
> >IpChoice==PING_IP_CHOICE_IP6?ICMP_V6_ECHO_REQUEST:ICMP_V4_EC
> HO_REQUEST);
> >   Request->Code= 0;
> >   Request->SequenceNum = SequenceNum;
> >+  Request->TimeStamp   = TimeStamp;
> >   Request->Identifier  = 0;
> >   Request->Checksum= 0;
> >
> >   //
> >   // Assembly token for transmit.
> >@@ -625,11 +626,10 @@ PingGenerateToken (
> > ((EFI_IP4_TRANSMIT_DATA*)TxData)->DestinationAddress.Addr[1]  =
> Private->DstAddress[1];
> > ((EFI_IP4_TRANSMIT_DATA*)TxData)->DestinationAddress.Addr[2]  =
> Private->DstAddress[2];
> > ((EFI_IP4_TRANSMIT_DATA*)TxData)->DestinationAddress.Addr[3]  =
> Private->DstAddress[3];
> >
> > HeadSum = NetChecksum ((UINT8 *) Request, Private->BufferSize);
> >-Request->TimeStamp   = TimeStamp;
> > TempChecksum = NetChecksum ((UINT8 *) &Request->TimeStamp,
> sizeof (UINT64));
> > Request->Checksum = (UINT16)(~NetAddChecksum (HeadSum,
> TempChecksum));
> >   }
> >
> >
> >@@ -802,15 +802,10 @@ Ping6OnTimerRoutine (
> >   ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_PING_TIMEOUT),
> >gShellNetwork1HiiHandle, TxInfo->SequenceNum);
> >
> >   RemoveEntryList (&TxInfo->Link);
> >   PingDestroyTxInfo (TxInfo, Private->IpChoice);
> >
> >-  //
> >-  // We dont need to wait for this some other time...
> >-  //
> >-  Private->RxCount++;
> >-
> >   if (IsListEmpty (&Private->TxList) && (Private->TxCount == Private-
> >SendNum)) {
> > //
> > // All the left icmp6 echo request in the list timeout.
> > //
> > Private->Status = EFI_TIMEOUT; diff --git
> >a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Co
> mman
> >dsLib.uni
> >b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Co
> mman
> >dsLib.uni index
> >1971ebc5f69c0e7de6ef2252de0428ac75bfaaaf..7cc7b7d672246a62ef97a8b00
> 2a78
> >0003d3da330 100644 GIT binary patch delta 466
> >zcmaDihjHCv#tj*Ug82+Z3 FQ)CCO5jsPj0Z|m@HuA
> >z#Gc7e08|^h+0*

Re: [edk2] [PATCH 1/2] MdePkg/BasePrintLib: make mStatusString array CONST

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Monday, July 13, 2015 12:49 PM
> To: Kinney, Michael D; Gao, Liming; Tian, Feng; edk2-
> de...@lists.sourceforge.net
> Subject: [edk2] [PATCH 1/2] MdePkg/BasePrintLib: make mStatusString array
> CONST
> 
> Change the type of mStatusString[] to reflect that it is a CONST
> array of pointers to CONST.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel 
> ---
>  MdePkg/Library/BasePrintLib/PrintLibInternal.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Library/BasePrintLib/PrintLibInternal.c
> b/MdePkg/Library/BasePrintLib/PrintLibInternal.c
> index a114bde13a9b..d73e1d65c4ea 100644
> --- a/MdePkg/Library/BasePrintLib/PrintLibInternal.c
> +++ b/MdePkg/Library/BasePrintLib/PrintLibInternal.c
> @@ -19,7 +19,7 @@
> 
>  GLOBAL_REMOVE_IF_UNREFERENCED CONST CHAR8 mHexStr[] =
> {'0','1','2','3','4','5','6','7','8','9','A','B','C','D','E','F'};
> 
> -GLOBAL_REMOVE_IF_UNREFERENCED CONST CHAR8 *mStatusString[] = {
> +GLOBAL_REMOVE_IF_UNREFERENCED CONST CHAR8 * CONST
> mStatusString[] = {
>"Success",  //  RETURN_SUCCESS= 0
>"Warning Unknown Glyph",//  RETURN_WARN_UNKNOWN_GLYPH =
> 1
>"Warning Delete Failure",   //  RETURN_WARN_DELETE_FAILURE= 2
> --
> 1.9.1
> 
> 
> --
> Don't Limit Your Business. Reach for the Cloud.
> GigeNET's Cloud Solutions provide you with the tools and support that
> you need to offload your IT needs and focus on growing your business.
> Configured For All Businesses. Start Your Cloud Today.
> https://www.gigenetcloud.com/
> ___
> edk2-devel mailing list
> edk2-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/edk2-devel

--
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [PATCH 2/2] MdeModulePkg/DxePrintLibPrint2Protocol: make mStatusString array CONST

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Monday, July 13, 2015 12:49 PM
> To: Kinney, Michael D; Gao, Liming; Tian, Feng; edk2-
> de...@lists.sourceforge.net
> Subject: [edk2] [PATCH 2/2] MdeModulePkg/DxePrintLibPrint2Protocol:
> make mStatusString array CONST
> 
> Change the type of mStatusString[] to reflect that it is a CONST
> array of pointers to CONST.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel 
> ---
>  MdeModulePkg/Library/DxePrintLibPrint2Protocol/PrintLib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/Library/DxePrintLibPrint2Protocol/PrintLib.c
> b/MdeModulePkg/Library/DxePrintLibPrint2Protocol/PrintLib.c
> index a41f228cc2c3..4acdcb871490 100644
> --- a/MdeModulePkg/Library/DxePrintLibPrint2Protocol/PrintLib.c
> +++ b/MdeModulePkg/Library/DxePrintLibPrint2Protocol/PrintLib.c
> @@ -1081,7 +1081,7 @@ InternalPrintLibSPrint (
>  #define WARNING_STATUS_NUMBER 5
>  #define ERROR_STATUS_NUMBER   33
> 
> -GLOBAL_REMOVE_IF_UNREFERENCED CONST CHAR8 *mStatusString[] = {
> +GLOBAL_REMOVE_IF_UNREFERENCED CONST CHAR8 * CONST
> mStatusString[] = {
>"Success",  //  RETURN_SUCCESS= 0
>"Warning Unknown Glyph",//  RETURN_WARN_UNKNOWN_GLYPH =
> 1
>"Warning Delete Failure",   //  RETURN_WARN_DELETE_FAILURE= 2
> --
> 1.9.1
> 
> 
> --
> Don't Limit Your Business. Reach for the Cloud.
> GigeNET's Cloud Solutions provide you with the tools and support that
> you need to offload your IT needs and focus on growing your business.
> Configured For All Businesses. Start Your Cloud Today.
> https://www.gigenetcloud.com/
> ___
> edk2-devel mailing list
> edk2-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/edk2-devel

--
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [Patch] ShellPkg: Fix ping IPv6 stack usage mode failure issue

[Carsey, Jaben]

Do we have a better way to allow inline commenting on the UNI file changes of 
patches like this?  It's pretty useless in the current email system...

The code change looks good, but needing to apply the patch just to see the UNI 
change seems unpleasant.

-Jaben

>-Original Message-
>From: Jiaxin Wu [mailto:jiaxin...@intel.com]
>Sent: Sunday, July 12, 2015 8:39 PM
>To: edk2-devel@lists.sourceforge.net
>Subject: [edk2] [Patch] ShellPkg: Fix ping IPv6 stack usage mode failure issue
>Importance: High
>
>Fix ping IPv6 stack usage mode failure issue and also
>update its the help info.
>Verified command:
>*ping -?
>*Ping -_ip6 -_s 2000:bbbnb::12 2000:::8
>
>Cc:Jaben Carsey 
>Cc:Shumin Qiu 
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Jiaxin Wu 
>---
> .../Library/UefiShellNetwork1CommandsLib/Ping.c |   7 +--
> .../UefiShellNetwork1CommandsLib.uni| Bin 20078 -> 20910 bytes
> 2 files changed, 1 insertion(+), 6 deletions(-)
>
>diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c 
>b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
>index fda062d..643be23 100644
>--- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
>+++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
>@@ -597,10 +597,11 @@ PingGenerateToken (
>   // Assembly echo request packet.
>   //
>   Request->Type= 
> (UINT8)(Private->IpChoice==PING_IP_CHOICE_IP6?ICMP_V6_ECHO_REQUEST:ICMP_V4_ECHO_REQUEST);
>   Request->Code= 0;
>   Request->SequenceNum = SequenceNum;
>+  Request->TimeStamp   = TimeStamp;
>   Request->Identifier  = 0;
>   Request->Checksum= 0;
>
>   //
>   // Assembly token for transmit.
>@@ -625,11 +626,10 @@ PingGenerateToken (
> ((EFI_IP4_TRANSMIT_DATA*)TxData)->DestinationAddress.Addr[1]  = 
> Private->DstAddress[1];
> ((EFI_IP4_TRANSMIT_DATA*)TxData)->DestinationAddress.Addr[2]  = 
> Private->DstAddress[2];
> ((EFI_IP4_TRANSMIT_DATA*)TxData)->DestinationAddress.Addr[3]  = 
> Private->DstAddress[3];
>
> HeadSum = NetChecksum ((UINT8 *) Request, Private->BufferSize);
>-Request->TimeStamp   = TimeStamp;
> TempChecksum = NetChecksum ((UINT8 *) &Request->TimeStamp, sizeof 
> (UINT64));
> Request->Checksum = (UINT16)(~NetAddChecksum (HeadSum, TempChecksum));
>   }
>
>
>@@ -802,15 +802,10 @@ Ping6OnTimerRoutine (
>   ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_PING_TIMEOUT), 
> gShellNetwork1HiiHandle, TxInfo->SequenceNum);
>
>   RemoveEntryList (&TxInfo->Link);
>   PingDestroyTxInfo (TxInfo, Private->IpChoice);
>
>-  //
>-  // We dont need to wait for this some other time...
>-  //
>-  Private->RxCount++;
>-
>   if (IsListEmpty (&Private->TxList) && (Private->TxCount == 
> Private->SendNum)) {
> //
> // All the left icmp6 echo request in the list timeout.
> //
> Private->Status = EFI_TIMEOUT;
>diff --git 
>a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.uni
>b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.uni
>index 
>1971ebc5f69c0e7de6ef2252de0428ac75bfaaaf..7cc7b7d672246a62ef97a8b002a780003d3da330
> 100644
>GIT binary patch
>delta 466
>zcmaDihjHCv#tj*Ug82+Z3z#Gc7e08|^h+0*DJBP*CQdA)zfOHyArj#KEs9J#`6KLsuLvcpU$@cb=lO0Ur(5#+ql8h$u(M@zGd%$Jnlpnh#CwyA&DA4(KR0t^nrvVsG}*zz
>zL9hVm$Yh|?(ikd%WFABMWIz2}1_h>qw!DKbR&bdWwVWP>cuK4GL=o1|tRoFtlPwfD+Y_njOLP?4J_?M0lc+t
>A0RR91
>
>delta 120
>zcmZ3tnDN~l#tj*Uli!(eO}=7pGI^V!8<>60U1;(FM~=w`MoycXj6N_<7BP*Pe9MY&
>za-V6?rnhW9}lVz~IW@%;3S`&k)ZL1Y`#=_%K9HerO@N
>Q`JcH16UfBP1vYk~0Ao%pA^-pY
>
>--
>1.9.5.msysgit.1
>
>
>--
>Don't Limit Your Business. Reach for the Cloud.
>GigeNET's Cloud Solutions provide you with the tools and support that
>you need to offload your IT needs and focus on growing your business.
>Configured For All Businesses. Start Your Cloud Today.
>https://www.gigenetcloud.com/
>___
>edk2-devel mailing list
>edk2-devel@lists.sourceforge.net
>https://lists.sourceforge.net/lists/listinfo/edk2-devel

--
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [Patch] ShellPkg: Update ShellPkg ping/ifconfig library

[Carsey, Jaben]

Jiaxin,  I think he meant to ask for the attachment .patch file.

>-Original Message-
>From: Wu, Jiaxin [mailto:jiaxin...@intel.com]
>Sent: Wednesday, July 01, 2015 5:42 PM
>To: Shah, Tapan; edk2-devel@lists.sourceforge.net
>Subject: Re: [edk2] [Patch] ShellPkg: Update ShellPkg ping/ifconfig library
>Importance: High
>
>Hi Tapan,
>I have already sent out the patch to edk2-devel.
>
>Thanks.
>Jiaxin
>
>-Original Message-
>From: Shah, Tapan [mailto:tapands...@hp.com]
>Sent: Thursday, July 2, 2015 1:00 AM
>To: Wu, Jiaxin; edk2-devel@lists.sourceforge.net
>Subject: RE: Re: [Patch] ShellPkg: Update ShellPkg ping/ifconfig library
>
>Jiaxin,
>   Can you send out an updated patch file for review?
>
>Thanks,
>Tapan
>
>-Original Message-
>From: Wu, Jiaxin [mailto:jiaxin...@intel.com]
>Sent: Wednesday, July 01, 2015 10:55 AM
>To: Shah, Tapan; edk2-devel@lists.sourceforge.net
>Subject: RE: Re: [Patch] ShellPkg: Update ShellPkg ping/ifconfig library
>
>Hi Tapan,
>Thank you for your comments, I have updated patch according below and other 
>reviewers comments.
>For the copyright, I have confirm that HP's copyright should be kept, I have 
>recovered it and just update Intel copyright year.
>
>Best Regards!
>Jiaxin
>
>-Original Message-
>From: edk2-devel-requ...@lists.sourceforge.net 
>[mailto:edk2-devel-requ...@lists.sourceforge.net]
>Sent: Wednesday, July 1, 2015 12:55 AM
>To: edk2-devel@lists.sourceforge.net
>Subject: edk2-devel Digest, Vol 66, Issue 424
>
>Send edk2-devel mailing list submissions to
>   edk2-devel@lists.sourceforge.net
>
>To subscribe or unsubscribe via the World Wide Web, visit
>   https://lists.sourceforge.net/lists/listinfo/edk2-devel
>or, via email, send a message with subject or body 'help' to
>   edk2-devel-requ...@lists.sourceforge.net
>
>You can reach the person managing the list at
>   edk2-devel-ow...@lists.sourceforge.net
>
>When replying, please edit your Subject line so it is more specific
>than "Re: Contents of edk2-devel digest..."
>
>
>Today's Topics:
>
>   1. Re: [Patch] ShellPkg: Update ShellPkg ping/ifconfig library.
>  (Shah, Tapan)
>
>
>--
>
>Message: 1
>Date: Tue, 30 Jun 2015 16:54:24 +
>From: "Shah, Tapan" 
>Subject: Re: [edk2] [Patch] ShellPkg: Update ShellPkg ping/ifconfig
>   library.
>To: "edk2-devel@lists.sourceforge.net"
>   
>Message-ID:
>   <62603b2d436bec49a53b627f6e01050634f16...@g1w3642.americas.hpqcorp.net>
>
>Content-Type: text/plain; charset="utf-8"
>
>Jiaxin,
>   I see that ifconfig is completely re-written and also removed HP's 
> copyright. I am not sure if it's acceptable to remove HP's copyright
>from the file. I am assuming that you have done adequate testing for this 
>major change, can you confirm what type of testing is
>performed to verify this change?
>
>Below comments for .uni file changes:
>
>1. No need to rename below three string tokens.
>STR_GEN_TOO_MANY -> STR_PING_ERR_TOO_MANY
>STR_GEN_TOO_FEW -> STR_PING_ERR_TOO_FEW
>STR_GEN_PARAM_INV -> STR_PING_ERR_PARAM_INV
>
>2.  All other STR_GEN_* string tokens are removed from .uni file. I suspect it 
>may break other command. They should remain as-is and
>no need to remove. We also keep it at the profile level .uni file to keep 
>track of same generic token name and strings across all
>commands.
>
>3. STR_IFCONFIG_HELP help output of new ifconfig is not following the help 
>output format. Need to fix it. Existing ifconfig help output
>is a good example as a reference.
>
>4. Below token shows message Ip4Config2->GetData which is not something we 
>customer friendly. Make it a customer friendly
>message.
>
>#string STR_IFCONFIG_ERR_IP4CFG_GETDATA   #language en-US
>"Ip4Config2->GetData return %hr\n"
>
>Thanks,
>Tapan
>
>-Original Message-
>From: Qiu, Shumin [mailto:shumin@intel.com]
>Sent: Monday, June 29, 2015 8:12 PM
>To: edk2-devel@lists.sourceforge.net
>Subject: Re: [edk2] [Patch] ShellPkg: Update ShellPkg ping/ifconfig library.
>
>Hi Jiaxin,
>Can I have the patch file?
>
>-Shumin
>
>-Original Message-
>From: jiaxinwu [mailto:jiaxin...@intel.com]
>Sent: Monday, June 29, 2015 10:50 PM
>To: edk2-devel@lists.sourceforge.net
>Subject: [edk2] [Patch] ShellPkg: Update ShellPkg ping/ifconfig library.
>
>Version2 include:
>Make the command options to be Shell2.1 compliant(For the unsupported option, 
>display ?not supported?);
>Safe string fix;
>Coding style change.
>
>This patch update ShellPkg ping/ifconfig library source code to consume 
>Ip4Config2 protocol.
>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: jiaxinwu 
>---
> .../UefiShellNetwork1CommandsLib/Ifconfig.c| 2462 
> .../Library/UefiShellNetwork1CommandsLib/Ping.c|   33 +-
> .../UefiShellNetwork1CommandsLib.c |4 +-
> .../UefiShellNetwork1CommandsLib.h |8 +-
> .../UefiShellNetwork1CommandsLib.i

Re: [edk2] [Patch] Update ShellPkg ping/ifconfig library.

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

> -Original Message-
> From: jiaxinwu [mailto:jiaxin...@intel.com]
> Sent: Wednesday, July 01, 2015 8:45 AM
> To: edk2-devel@lists.sourceforge.net
> Subject: [edk2] [Patch] Update ShellPkg ping/ifconfig library.
> Importance: High
> 
> Version3 update mainly include comments from reviewer:
> Recover renamed and removed string tokens in uni file.
> Update ifconfig help info by using the standard shell output message.
> Remove redundant string tokens for ifconfig compared to version2.
> Remove redundant parameter in private data structure(ImageHandle).
> Update IfConfigShowInterfaceInfo, IfConfigClearInterfaceInfo and
> IfConfigCleanup to use standard linked list functions.
> Remove –h option for ifconfig since it's not the standard shell behavior.
> Update return codes for some functions.
> Other coding style change.
> 
> This patch update ShellPkg ping/ifconfig library source code to consume
> Ip4Config2 protocol.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: jiaxinwu 
> ---
>  .../UefiShellNetwork1CommandsLib/Ifconfig.c| 2439 ---
> -
>  .../Library/UefiShellNetwork1CommandsLib/Ping.c|   19 +-
>  .../UefiShellNetwork1CommandsLib.c |2 +-
>  .../UefiShellNetwork1CommandsLib.h |8 +-
>  .../UefiShellNetwork1CommandsLib.inf   |6 +-
>  .../UefiShellNetwork1CommandsLib.uni   |  Bin 20112 -> 19664 
> bytes
>  6 files changed, 991 insertions(+), 1483 deletions(-)
> 
> diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c
> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c
> index fa00d6c..6977d6b 100644
> --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c
> +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c
> @@ -1,7 +1,7 @@
>  /** @file
> -  The implementation for ifcommand shell command.
> +  The implementation for Shell command ifconfig based on IP4Config2
> protocol.
> 
>(C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.
>Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.
> 
>This program and the accompanying materials
> @@ -9,1774 +9,1285 @@
>which accompanies this distribution.  The full text of the license may be
> found at
>http://opensource.org/licenses/bsd-license.php.
> 
>THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"
> BASIS,
>WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> EXPRESS OR IMPLIED.
> +
>  **/
> 
>  #include "UefiShellNetwork1CommandsLib.h"
> 
> -#define NIC_ITEM_CONFIG_SIZE   (sizeof (NIC_IP4_CONFIG_INFO) + sizeof
> (EFI_IP4_ROUTE_TABLE) * MAX_IP4_CONFIG_IN_VARIABLE)
> -#define EFI_IP4_TO_U32(EfiIpAddr)   (*(IP4_ADDR*)((EfiIpAddr).Addr))
> -
> -BOOLEAN mIp4ConfigExist= FALSE;
> -STATIC EFI_HII_CONFIG_ROUTING_PROTOCOL  *mHiiConfigRouting = NULL;
> +typedef enum {
> +  IfConfigOpList = 1,
> +  IfConfigOpSet  = 2,
> +  IfConfigOpClear= 3
> +} IFCONFIG_OPCODE;
> +
> +typedef enum {
> +  VarCheckReserved  = -1,
> +  VarCheckOk= 0,
> +  VarCheckDuplicate,
> +  VarCheckConflict,
> +  VarCheckUnknown,
> +  VarCheckLackValue,
> +  VarCheckOutOfMem
> +} VAR_CHECK_CODE;
> +
> +typedef enum {
> +  FlagTypeSingle = 0,
> +  FlagTypeNeedVar,
> +  FlagTypeNeedSet,
> +  FlagTypeSkipUnknown
> +} VAR_CHECK_FLAG_TYPE;
> +
> +#define MACADDRMAXSIZE32
> +
> +typedef struct _IFCONFIG_INTERFACE_CB {
> +  EFI_HANDLE  NicHandle;
> +  LIST_ENTRY  Link;
> +  EFI_IP4_CONFIG2_PROTOCOL*IfCfg;
> +  EFI_IP4_CONFIG2_INTERFACE_INFO  *IfInfo;
> +  EFI_IP4_CONFIG2_POLICY  Policy;
> +  UINT32  DnsCnt;
> +  EFI_IPv4_ADDRESSDnsAddr[1];
> +} IFCONFIG_INTERFACE_CB;
> +
> +typedef struct _ARG_LIST ARG_LIST;
> +
> +struct _ARG_LIST {
> +  ARG_LIST*Next;
> +  CHAR16  *Arg;
> +};
> +
> +typedef struct _IFCONFIG4_PRIVATE_DATA {
> +  LIST_ENTRY  IfList;
> +
> +  UINT32  OpCode;
> +  CHAR16  *IfName;
> +  ARG_LIST*VarArg;
> +} IFCONFIG_PRIVATE_DATA;
> +
> +typedef struct _VAR_CHECK_ITEM{
> +  CHAR16 *FlagStr;
> +  UINT32 FlagID;
> +  UINT32 ConflictMask;
> +  VAR_CHECK_FLAG_TYPEFlagType;
> +} VAR_CHECK_ITEM;
> +
> +SHELL_PARAM_ITEMmIfConfigCheckList[] = {
> +  {
> +L"-b",
> +TypeFlag
> +  },
> +  {
> +L"-l",
> +TypeValue
> +  },
> +  {
> +L"-r",
> +TypeValue
> +  },
> +  {
> +L"-c",
> +TypeValue
> +  },
> +  {
> +L"-s",
> +TypeMaxValue
> +  },
> +  {
> +NULL,
> +TypeMax
> +  },
> +};
> +
> +VAR_CHECK_ITEM  mSetCheckList[] = {
> +  {
> +   L"static",
> +0x0001,
> +0x0001,
> +FlagTypeSingle
> +  },
> +  {
> +L"dhcp",
> +0x0002,
> +0x

Re: [edk2] [PATCH] FatPkg EnhancedFatDxe: Use safe string functions

[Carsey, Jaben]

One question below.

Reviewed-by: Jaben Carsey 

> -Original Message-
> From: Hao Wu [mailto:hao.a...@intel.com]
> Sent: Wednesday, July 01, 2015 1:00 AM
> To: edk2-devel@lists.sourceforge.net
> Subject: [edk2] [PATCH] FatPkg EnhancedFatDxe: Use safe string functions
> 
> Unsafe string functions are replaced with safe ones.
> 
> Safe string functions will assert if DestMax is not greater than
> StrnLenS(Source, DestMax). Therefore, additional assert for checking the
> size of source and destination buffers can be removed.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Hao Wu 
> Reviewed-by: Ruiyu Ni 
> ---
>  EnhancedFatDxe/DirectoryManage.c | 18 +++---
>  EnhancedFatDxe/Fat.h |  5 +++--
>  EnhancedFatDxe/FileName.c| 14 +++---
>  EnhancedFatDxe/Hash.c|  9 ++---
>  4 files changed, 31 insertions(+), 15 deletions(-)
> 
> diff --git a/EnhancedFatDxe/DirectoryManage.c
> b/EnhancedFatDxe/DirectoryManage.c
> index 53e80f7..4b44ec3 100644
> --- a/EnhancedFatDxe/DirectoryManage.c
> +++ b/EnhancedFatDxe/DirectoryManage.c
> @@ -1,6 +1,6 @@
>  /*++
> 
> -Copyright (c) 2005 - 2013, Intel Corporation. All rights reserved.
> +Copyright (c) 2005 - 2015, Intel Corporation. All rights reserved.
>  This program and the accompanying materials  are licensed and made
> available under the terms and conditions of the Software  License
> Agreement which accompanies this distribution.
> @@ -112,7 +112,15 @@ Returns:
>  // Write LFN directory entry
>  //
>  SetMem (LfnBuffer, sizeof (CHAR16) * LFN_CHAR_TOTAL * EntryCount,
> 0xff);

Why do you set the whole buffer to 0xFF?  What's the value here?

> -StrCpy (LfnBuffer, DirEnt->FileString);
> +Status = StrCpyS (
> +   LfnBuffer,
> +   sizeof (LfnBuffer) / sizeof (LfnBuffer[0]),
> +   DirEnt->FileString
> +   );
> +if (EFI_ERROR (Status)) {
> +  return Status;
> +}
> +
>  LfnBufferPointer= LfnBuffer;
>  LfnEntry.Attributes = FAT_ATTRIBUTE_LFN;
>  LfnEntry.Type   = 0;
> @@ -345,7 +353,11 @@ Returns:
>  // Fail to get the long file name from long file name entry,
>  // get the file name from short name
>  //
> -FatGetFileNameViaCaseFlag (DirEnt, LfnBuffer);
> +FatGetFileNameViaCaseFlag (
> +  DirEnt,
> +  LfnBuffer,
> +  sizeof (LfnBuffer) / sizeof (LfnBuffer[0])
> +  );
>}
> 
>DirEnt->FileString = AllocateCopyPool (StrSize (LfnBuffer), LfnBuffer); 
> diff --
> git a/EnhancedFatDxe/Fat.h b/EnhancedFatDxe/Fat.h index
> 7a3cd06..27d7937 100644
> --- a/EnhancedFatDxe/Fat.h
> +++ b/EnhancedFatDxe/Fat.h
> @@ -1237,8 +1237,9 @@ FatSetCaseFlag (
> 
>  VOID
>  FatGetFileNameViaCaseFlag (
> -  IN  FAT_DIRENT*DirEnt,
> -  OUT CHAR16*FileString
> +  IN FAT_DIRENT *DirEnt,
> +  IN OUT CHAR16 *FileString,
> +  IN UINTN  FileStringMax
>);
> 
>  UINT8
> diff --git a/EnhancedFatDxe/FileName.c b/EnhancedFatDxe/FileName.c
> index 1ba2706..1f8aad2 100644
> --- a/EnhancedFatDxe/FileName.c
> +++ b/EnhancedFatDxe/FileName.c
> @@ -1,6 +1,6 @@
>  /*++
> 
> -Copyright (c) 2005 - 2007, Intel Corporation. All rights reserved.
> +Copyright (c) 2005 - 2015, Intel Corporation. All rights reserved.
>  This program and the accompanying materials  are licensed and made
> available under the terms and conditions of the Software  License
> Agreement which accompanies this distribution.
> @@ -298,7 +298,6 @@ Returns:
>CHAR16  Buffer[FAT_MAIN_NAME_LEN + 1 + FAT_EXTEND_NAME_LEN +
> 1];
>UINT8   OutCaseFlag;
> 
> -  ASSERT (StrSize (Str) <= sizeof (Buffer));
>//
>// Assume the case of input string is mixed
>//
> @@ -307,7 +306,7 @@ Returns:
>// Lower case a copy of the string, if it matches the
>// original then the string is lower case
>//
> -  StrCpy (Buffer, Str);
> +  StrCpyS (Buffer, sizeof (Buffer) / sizeof (Buffer[0]), Str);
>FatStrLwr (Buffer);
>if (StrCmp (Str, Buffer) == 0) {
>  OutCaseFlag = InCaseFlag;
> @@ -316,7 +315,7 @@ Returns:
>// Upper case a copy of the string, if it matches the
>// original then the string is upper case
>//
> -  StrCpy (Buffer, Str);
> +  StrCpyS (Buffer, sizeof (Buffer) / sizeof (Buffer[0]), Str);
>FatStrUpr (Buffer);
>if (StrCmp (Str, Buffer) == 0) {
>  OutCaseFlag = 0;
> @@ -388,8 +387,9 @@ Returns:
> 
>  VOID
>  FatGetFileNameViaCaseFlag (
> -  IN  FAT_DIRENT*DirEnt,
> -  OUT CHAR16*FileString
> +  IN FAT_DIRENT   *DirEnt,
> +  IN OUT CHAR16   *FileString,
> +  IN UINTNFileStringMax
>)
>  /*++
> 
> @@ -421,7 +421,7 @@ Returns:
>FatNameToStr (File8Dot3Name + FAT_MAIN_NAME_LEN,
> FAT_EXTEND_NAME_LEN, CaseFlag & FAT_CASE_EXT_LOWER,
> &TempExt[1]);
>if (TempExt[1] != 0) {
>  TempExt[0] = L'.';
> -StrCat (FileString, TempExt);
> +StrCatS (FileString, FileStringMax, TempExt);
>

Re: [edk2] [PATCH] ShellPkg: Refine the code logic of StrnCatGrow.

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

> -Original Message-
> From: Shah, Tapan [mailto:tapands...@hp.com]
> Sent: Wednesday, July 01, 2015 7:22 AM
> To: Qiu, Shumin; edk2-devel@lists.sourceforge.net
> Cc: Fan, Jeff; Carsey, Jaben
> Subject: RE: [PATCH] ShellPkg: Refine the code logic of StrnCatGrow.
> Importance: High
> 
> Reviewed-by: Tapan Shah <>
> 
> -Original Message-
> From: Qiu Shumin [mailto:shumin@intel.com]
> Sent: Tuesday, June 30, 2015 9:24 PM
> To: edk2-devel@lists.sourceforge.net
> Cc: jeff@intel.com; jaben.car...@intel.com; Shah, Tapan
> Subject: [PATCH] ShellPkg: Refine the code logic of StrnCatGrow.
> 
> In order to indicate the catena length use StrnCatS instead of StrCatS to
> generate Destination string, and update the DestMax of Destination string.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Qiu Shumin 
> ---
>  ShellPkg/Library/UefiShellLib/UefiShellLib.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c
> b/ShellPkg/Library/UefiShellLib/UefiShellLib.c
> index 5b4c6d3..3521515 100644
> --- a/ShellPkg/Library/UefiShellLib/UefiShellLib.c
> +++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.c
> @@ -3254,7 +3254,8 @@ StrnCatGrow (
>*CurrentSize = NewSize;
>  }
>} else {
> -*Destination = AllocateZeroPool((Count+1)*sizeof(CHAR16));
> +NewSize = (Count+1)*sizeof(CHAR16);
> +*Destination = AllocateZeroPool(NewSize);
>}
> 
>//
> @@ -3264,7 +3265,7 @@ StrnCatGrow (
>  return (NULL);
>}
> 
> -  StrCatS(*Destination, Count + 1, Source);
> +  StrnCatS(*Destination, NewSize/sizeof(CHAR16), Source, Count);
>return *Destination;
>  }
> 
> --
> 1.9.5.msysgit.1
> 
> 


--
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [Patch] ShellPkg: fix string to number conversion with "0 "

[Carsey, Jaben]

I ran some more tests and found that I wanted one more line of code in the 
patch.  Please check this one instead.

From: Carsey, Jaben
Sent: Tuesday, June 30, 2015 1:54 PM
To: Qiu, Shumin; Shah, Tapan (tapands...@hp.com)
Cc: edk2-devel@lists.sourceforge.net; El-Haj-Mahmoud, Samer 
(samer.el-haj-mahm...@hp.com); Carsey, Jaben
Subject: [Patch] ShellPkg: fix string to number conversion with "0 "

Shumin / Tapan,

Can you review this?

This makes stopping at spaces work with only zero as the value.  I also 
attached a NSH file that can be used to verify the results.  Before this the 
loops from 0 to 3 would only execute once as the zero was converted as 3.

ShellPkg: fix string to number conversion with "0 "

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey 



UefiShellLib.c.patch
Description: UefiShellLib.c.patch
--
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

[edk2] [Patch] ShellPkg: fix string to number conversion with "0 "

[Carsey, Jaben]

Shumin / Tapan,

Can you review this?

This makes stopping at spaces work with only zero as the value.  I also 
attached a NSH file that can be used to verify the results.  Before this the 
loops from 0 to 3 would only execute once as the zero was converted as 3.

ShellPkg: fix string to number conversion with "0 "

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey 



UefiShellLib.c.patch
Description: UefiShellLib.c.patch


test.nsh
Description: test.nsh
--
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] UEFI Shell Parameter Handling

[Carsey, Jaben]

In a script file? In a UEFI Application?

In a script file, not easily... there is %1 through %9 and you can iterate 
through the higher params one at a time.

In an UEFI Application, just look at Argc/Argv or LoadedImageProtocol has it.

-Jaben

From: lowell_den...@dell.com [mailto:lowell_den...@dell.com]
Sent: Tuesday, June 30, 2015 11:13 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] UEFI Shell Parameter Handling
Importance: High


Dell - Internal Use - Confidential
All,

Is there an equivalent in the UEFI shell to CMD.exe's %* which gives all of the 
command line parameters?
Ideally I would like something similar to 4DOS's %3& which gives all of the 
command line parameters from %3 and up.


-  Lowell

--
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [patch] SecurityPkg:Replace unsafe string functions.

[Carsey, Jaben]

When you have a difference of 1 between parameter 2 and parameter 4 on StrnCpyS 
or StrnCatS you can use the non-n version.  I noted the first one below, but 
there are more.  This just makes the code easier to read and simpler to 
maintain.

Reviewed-by: Jaben Carsey 

>-Original Message-
>From: Zhang Lubo [mailto:lubo.zh...@intel.com]
>Sent: Tuesday, June 30, 2015 1:26 AM
>To: edk2-devel@lists.sourceforge.net
>Subject: [edk2] [patch] SecurityPkg:Replace unsafe string functions.
>
>Replace unsafe string functions with new added safe string functions.
>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Zhang Lubo 
>---
> .../DxeTcgPhysicalPresenceLib.c| 90 +++---
> .../DxeTrEEPhysicalPresenceLib.c   | 18 ++---
> .../UserProfileManagerDxe/UserProfileModify.c  |  6 +-
> .../EsalVariableDxeSal/Variable.c  |  4 +-
> .../VariableAuthenticated/RuntimeDxe/VarCheck.c|  2 +-
> .../VariableAuthenticated/RuntimeDxe/Variable.c|  8 +-
> .../SecureBootConfigFileExplorer.c | 21 ++---
> .../SecureBootConfigDxe/SecureBootConfigMisc.c |  2 +-
> 8 files changed, 77 insertions(+), 74 deletions(-)
>
>diff --git 
>a/SecurityPkg/Library/DxeTcgPhysicalPresenceLib/DxeTcgPhysicalPresenceLib.c
>b/SecurityPkg/Library/DxeTcgPhysicalPresenceLib/DxeTcgPhysicalPresenceLib.c
>index 7fbeb0a..5660552 100644
>--- a/SecurityPkg/Library/DxeTcgPhysicalPresenceLib/DxeTcgPhysicalPresenceLib.c
>+++ b/SecurityPkg/Library/DxeTcgPhysicalPresenceLib/DxeTcgPhysicalPresenceLib.c
>@@ -542,11 +542,11 @@ UserConfirm (
>   TmpStr1 = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_HEAD_STR));
>   UnicodeSPrint (ConfirmText, BufSize, TmpStr1, TmpStr2);
>   FreePool (TmpStr1);
>
>   TmpStr1 = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_ACCEPT_KEY));
>-  StrnCat (ConfirmText, TmpStr1, (BufSize / sizeof (CHAR16)) - StrLen 
>(ConfirmText) - 1);
>+  StrnCatS (ConfirmText, (BufSize / sizeof (CHAR16)) - StrLen 
>(ConfirmText), TmpStr1, (BufSize / sizeof (CHAR16)) - StrLen
>(ConfirmText) - 1);

Switch to StrCatS for simplicity.

>   FreePool (TmpStr1);
>   break;
>
> case PHYSICAL_PRESENCE_DISABLE:
>   TmpStr2 = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_DISABLE));
>@@ -554,15 +554,15 @@ UserConfirm (
>   TmpStr1 = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_HEAD_STR));
>   UnicodeSPrint (ConfirmText, BufSize, TmpStr1, TmpStr2);
>   FreePool (TmpStr1);
>
>   TmpStr1 = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_WARNING));
>-  StrnCat (ConfirmText, TmpStr1, (BufSize / sizeof (CHAR16)) - StrLen 
>(ConfirmText) - 1);
>+  StrnCatS (ConfirmText, (BufSize / sizeof (CHAR16)) - StrLen 
>(ConfirmText), TmpStr1, (BufSize / sizeof (CHAR16)) - StrLen
>(ConfirmText) - 1);
>   FreePool (TmpStr1);
>
>   TmpStr1 = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_ACCEPT_KEY));
>-  StrnCat (ConfirmText, TmpStr1, (BufSize / sizeof (CHAR16)) - StrLen 
>(ConfirmText) - 1);
>+  StrnCatS (ConfirmText, (BufSize / sizeof (CHAR16)) - StrLen 
>(ConfirmText), TmpStr1, (BufSize / sizeof (CHAR16)) - StrLen
>(ConfirmText) - 1);
>   FreePool (TmpStr1);
>   break;
>
> case PHYSICAL_PRESENCE_ACTIVATE:
>   TmpStr2 = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_ACTIVATE));
>@@ -570,11 +570,11 @@ UserConfirm (
>   TmpStr1 = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_HEAD_STR));
>   UnicodeSPrint (ConfirmText, BufSize, TmpStr1, TmpStr2);
>   FreePool (TmpStr1);
>
>   TmpStr1 = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_ACCEPT_KEY));
>-  StrnCat (ConfirmText, TmpStr1, (BufSize / sizeof (CHAR16)) - StrLen 
>(ConfirmText) - 1);
>+  StrnCatS (ConfirmText, (BufSize / sizeof (CHAR16)) - StrLen 
>(ConfirmText), TmpStr1, (BufSize / sizeof (CHAR16)) - StrLen
>(ConfirmText) - 1);
>   FreePool (TmpStr1);
>   break;
>
> case PHYSICAL_PRESENCE_DEACTIVATE:
>   TmpStr2 = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_DEACTIVATE));
>@@ -582,15 +582,15 @@ UserConfirm (
>   TmpStr1 = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_HEAD_STR));
>   UnicodeSPrint (ConfirmText, BufSize, TmpStr1, TmpStr2);
>   FreePool (TmpStr1);
>
>   TmpStr1 = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_WARNING));
>-  StrnCat (ConfirmText, TmpStr1, (BufSize / sizeof (CHAR16)) - StrLen 
>(ConfirmText) - 1);
>+  StrnCatS (ConfirmText, (BufSize / sizeof (CHAR16)) - StrLen 
>(ConfirmText), TmpStr1, (BufSize / sizeof (CHAR16)) - StrLen
>(ConfirmText) - 1);
>   FreePool (TmpStr1);
>
>   TmpStr1 = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_ACCEPT_KEY));
>-  StrnCat (ConfirmText, TmpStr1, (BufSize / sizeof (CHAR16)) - StrLen 
>(ConfirmText) - 1);
>+  StrnCatS (ConfirmText, (BufSize / sizeof (CHAR16)) - StrLen 
>(ConfirmText), TmpStr1, (BufSize / sizeof (CHAR16)) - StrLen
>(ConfirmText) - 1);
>

Re: [edk2] [patch 2/2] NetworkPkg:Replace unsafe string functions.

[Carsey, Jaben]

You have the number 128 added in lots of places.  Where is this number from?  
Should you use a #define or a PCD or something?  If the string was made longer, 
this would be painful to update so many locations.

Inline comments also.

>-Original Message-
>From: Zhang Lubo [mailto:lubo.zh...@intel.com]
>Sent: Tuesday, June 30, 2015 1:26 AM
>To: edk2-devel@lists.sourceforge.net
>Subject: [edk2] [patch 2/2] NetworkPkg:Replace unsafe string functions.
>
>Replace unsafe string functions with new added safe string functions.
>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Zhang Lubo 
>---
> NetworkPkg/Application/IfConfig6/IfConfig6.c   |  6 ++--
> NetworkPkg/Application/IpsecConfig/Indexer.c   |  2 +-
> .../Application/IpsecConfig/PolicyEntryOperation.c |  4 +--
> NetworkPkg/IScsiDxe/IScsiConfig.c  |  2 +-
> NetworkPkg/IScsiDxe/IScsiDhcp.c|  2 +-
> NetworkPkg/IScsiDxe/IScsiDhcp6.c   |  2 +-
> NetworkPkg/IScsiDxe/IScsiExtScsiPassThru.c |  2 +-
> NetworkPkg/Mtftp6Dxe/Mtftp6Support.c   | 13 +
> NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.c   | 32 --
> NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c |  6 ++--
> NetworkPkg/UefiPxeBcDxe/PxeBcSupport.h |  6 ++--
> 11 files changed, 44 insertions(+), 33 deletions(-)
>
>diff --git a/NetworkPkg/Application/IfConfig6/IfConfig6.c 
>b/NetworkPkg/Application/IfConfig6/IfConfig6.c
>index 9e228ca..ded3df5 100644
>--- a/NetworkPkg/Application/IfConfig6/IfConfig6.c
>+++ b/NetworkPkg/Application/IfConfig6/IfConfig6.c
>@@ -134,11 +134,11 @@ SplitStrToList (
>   //
>   // Copy the CONST string to a local copy.
>   //
>   Str = (CHAR16 *) AllocateZeroPool (StrSize (String));
>   ASSERT (Str != NULL);
>-  Str = StrnCpy (Str, String, StrLen (String));
>+  Str = StrnCpyS (Str, StrSize (String) / sizeof (CHAR16), String, StrLen 
>(String));

Great place for AllocateCopyPool use.

>   ArgStr  = Str;
>
>   //
>   // init a node for the list head.
>   //
>@@ -1718,11 +1718,11 @@ IfConfig6Initialize (
> ValueStr = ShellCommandLineGetValue (ParamPackage, L"-l");
> if (ValueStr != NULL) {
>   Str = (CHAR16 *) AllocateZeroPool (StrSize (ValueStr));
>   ASSERT (Str != NULL);
>
>-  Str = StrnCpy (Str, ValueStr, StrLen (ValueStr));
>+  Str = StrnCpyS (Str, StrSize (ValueStr) / sizeof (CHAR16), 
>ValueStr, StrLen (ValueStr));

AllocateCopyPool

>   Private->IfName = Str;
> }
>   }
>   //
>   // To get interface name for the clear option.
>@@ -1732,11 +1732,11 @@ IfConfig6Initialize (
> ValueStr = ShellCommandLineGetValue (ParamPackage, L"-r");
> if (ValueStr != NULL) {
>   Str = (CHAR16 *) AllocateZeroPool (StrSize (ValueStr));
>   ASSERT (Str != NULL);
>
>-  Str = StrnCpy (Str, ValueStr, StrLen (ValueStr));
>+  Str = StrnCpyS (Str, StrSize (ValueStr) / sizeof (CHAR16), 
>ValueStr, StrLen (ValueStr));

AlocateCopyPool

>   Private->IfName = Str;
> }
>   }
>   //
>   // To get interface name and corresponding Args for the set option.
>diff --git a/NetworkPkg/Application/IpsecConfig/Indexer.c 
>b/NetworkPkg/Application/IpsecConfig/Indexer.c
>index 9e066b1..fbee27f 100644
>--- a/NetworkPkg/Application/IpsecConfig/Indexer.c
>+++ b/NetworkPkg/Application/IpsecConfig/Indexer.c
>@@ -233,11 +233,11 @@ ConstructPadIndexer (
> return EFI_INVALID_PARAMETER;
>   }
>
>   Indexer->PadId.PeerIdValid = TRUE;
>   ZeroMem (Indexer->PadId.Id.PeerId, MAX_PEERID_LEN);
>-  StrnCpy ((CHAR16 *) Indexer->PadId.Id.PeerId, ValueStr, ARRAY_SIZE 
>(Indexer->PadId.Id.PeerId) - 1);
>+  StrnCpyS ((CHAR16 *) Indexer->PadId.Id.PeerId, MAX_PEERID_LEN / 2, 
>ValueStr, ARRAY_SIZE (Indexer->PadId.Id.PeerId) - 1);
> }
>   }
>
>   return EFI_SUCCESS;
> }
>diff --git a/NetworkPkg/Application/IpsecConfig/PolicyEntryOperation.c
>b/NetworkPkg/Application/IpsecConfig/PolicyEntryOperation.c
>index 7e04573..433ab69 100644
>--- a/NetworkPkg/Application/IpsecConfig/PolicyEntryOperation.c
>+++ b/NetworkPkg/Application/IpsecConfig/PolicyEntryOperation.c
>@@ -1102,11 +1102,11 @@ CreatePadEntry (
>   }
>
>   ValueStr = ShellCommandLineGetValue (ParamPackage, L"--peer-id");
>   if (ValueStr != NULL) {
> (*PadId)->PeerIdValid = TRUE;
>-StrnCpy ((CHAR16 *) (*PadId)->Id.PeerId, ValueStr, ARRAY_SIZE 
>((*PadId)->Id.PeerId) - 1);
>+StrnCpyS ((CHAR16 *) (*PadId)->Id.PeerId, MAX_PEERID_LEN / 2, ValueStr, 
>ARRAY_SIZE ((*PadId)->Id.PeerId) - 1);
> *Mask |= PEER_ID;
>   }
>
>   ValueStr = ShellCommandLineGetValue (ParamPackage, L"--auth-data");
>   if (ValueStr != NULL) {
>@@ -1397,11 +1397,11 @@ CombineSpdEntry (
>   }
>   //
>   // Process Data
>   //
>   if ((Mask & NAME) != 0) {
>-AsciiStrCpy ((CHAR8 *) OldData->Name, (CHAR8 *) NewData->Name);
>+AsciiStrCpyS ((CHAR8 *) OldData->Name, MAX_PEERID_LE

Re: [edk2] [patch 1/2] MdeModulePkg: Replace unsafe string functions.

[Carsey, Jaben]

I had a few comments.  The NULL-terminator one is the only real risk.

Reviewed-by: Jaben Carsey 

>-Original Message-
>From: Zhang Lubo [mailto:lubo.zh...@intel.com]
>Sent: Tuesday, June 30, 2015 1:26 AM
>To: edk2-devel@lists.sourceforge.net
>Subject: [edk2] [patch 1/2] MdeModulePkg: Replace unsafe string functions.
>
>Replace unsafe string functions with new added safe string functions.
>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Zhang Lubo 
>---
> MdeModulePkg/Library/DxeNetLib/DxeNetLib.c  |  4 ++--
> MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfig.c   |  2 +-
> MdeModulePkg/Universal/Network/IScsiDxe/IScsiDhcp.c |  2 +-
> .../Universal/Network/IScsiDxe/IScsiExtScsiPassThru.c   |  2 +-
> MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.c |  2 +-
> .../Universal/Network/Ip4ConfigDxe/Ip4ConfigNv.c|  4 ++--
> .../Universal/Network/Mtftp4Dxe/Mtftp4Support.c | 13 -
> .../Universal/Network/UefiPxeBcDxe/PxeBcMtftp.c | 17 +
> .../Universal/Network/UefiPxeBcDxe/PxeBcSupport.c   | 12 +++-
> .../Universal/Network/UefiPxeBcDxe/PxeBcSupport.h   | 11 +++
> .../Universal/Network/VlanConfigDxe/VlanConfigImpl.c| 12 ++--
> 11 files changed, 45 insertions(+), 36 deletions(-)
>
>diff --git a/MdeModulePkg/Library/DxeNetLib/DxeNetLib.c 
>b/MdeModulePkg/Library/DxeNetLib/DxeNetLib.c
>index 467b822..cb5a8e6 100644
>--- a/MdeModulePkg/Library/DxeNetLib/DxeNetLib.c
>+++ b/MdeModulePkg/Library/DxeNetLib/DxeNetLib.c
>@@ -2625,11 +2625,11 @@ NetLibDefaultAddressIsStatic (
>   Len = StrLen (ConfigHdr);
>   ConfigResp = AllocateZeroPool ((Len + NIC_ITEM_CONFIG_SIZE * 2 + 100) * 
> sizeof (CHAR16));
>   if (ConfigResp == NULL) {
> goto ON_EXIT;
>   }
>-  StrCpy (ConfigResp, ConfigHdr);
>+  StrCpyS (ConfigResp, (Len + NIC_ITEM_CONFIG_SIZE * 2 + 100), ConfigHdr);

You could use AllocateCopyPool here and make it easier to read.

>
>   String = ConfigResp + Len;
>   UnicodeSPrint (
> String,
> (8 + 4 + 7 + 4 + 1) * sizeof (CHAR16),
>@@ -3385,11 +3385,11 @@ NetLibIp6ToStr (
>
>   if ((UINTN)Ptr - (UINTN)Buffer > StringSize) {
> return EFI_BUFFER_TOO_SMALL;
>   }
>
>-  StrCpy (String, Buffer);
>+  StrCpyS (String, StringSize / 2, Buffer);
>
>   return EFI_SUCCESS;
> }
>
> /**
>diff --git a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfig.c 
>b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfig.c
>index e263f0e..75fe12f 100644
>--- a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfig.c
>+++ b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfig.c
>@@ -776,11 +776,11 @@ IScsiFormCallback (
>   IScsiUnicodeStrToAsciiStr (IfrNvData->TargetName, IScsiName);
>   Status = IScsiNormalizeName (IScsiName, AsciiStrLen (IScsiName));
>   if (EFI_ERROR (Status)) {
> CreatePopUp (EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE, &Key, L"Invalid 
> iSCSI Name!", NULL);
>   } else {
>-AsciiStrCpy (Private->Current->SessionConfigData.TargetName, 
>IScsiName);
>+AsciiStrCpyS (Private->Current->SessionConfigData.TargetName, 
>ISCSI_NAME_MAX_SIZE, IScsiName);
>   }
>
>   break;
>
> case KEY_DHCP_ENABLE:
>diff --git a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiDhcp.c 
>b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiDhcp.c
>index 79e7093..10ef629 100644
>--- a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiDhcp.c
>+++ b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiDhcp.c
>@@ -156,11 +156,11 @@ IScsiDhcpExtractRootPath (
>   Status = IScsiNormalizeName (Field->Str, AsciiStrLen (Field->Str));
>   if (EFI_ERROR (Status)) {
> goto ON_EXIT;
>   }
>
>-  AsciiStrCpy (ConfigNvData->TargetName, Field->Str);
>+  AsciiStrCpyS (ConfigNvData->TargetName, ISCSI_NAME_MAX_SIZE, Field->Str);
>
> ON_EXIT:
>
>   FreePool (TmpStr);
>
>diff --git a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiExtScsiPassThru.c
>b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiExtScsiPassThru.c
>index da14105..e3576c1 100644
>--- a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiExtScsiPassThru.c
>+++ b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiExtScsiPassThru.c
>@@ -242,11 +242,11 @@ IScsiExtScsiPassThruBuildDevicePath (
> break;
>   }
>
>   CopyMem (&Node->Iscsi.Lun, ConfigNvData->BootLun, sizeof (UINT64));
>   Node->Iscsi.TargetPortalGroupTag = Session->TargetPortalGroupTag;
>-  AsciiStrCpy ((CHAR8 *) Node + sizeof (ISCSI_DEVICE_PATH), 
>ConfigNvData->TargetName);
>+  AsciiStrCpyS ((CHAR8 *) Node + sizeof (ISCSI_DEVICE_PATH), AsciiStrLen 
>(ConfigNvData->TargetName) + 1, ConfigNvData-
>>TargetName);
>
>   *DevicePath = (EFI_DEVICE_PATH_PROTOCOL *) Node;
>
>   return EFI_SUCCESS;
> }
>diff --git a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.c 
>b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.c
>index 1cb1fb8..85a23a2 100644
>--- a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.c
>+++ b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.c
>@@ -202,11 +202,11 @@ IScsiLunToUni

Re: [edk2] [PATCH 5/5] MdeModulePkg: enforce arch-specific alignment for split regions

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

>-Original Message-
>From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
>Sent: Tuesday, June 30, 2015 6:18 AM
>To: edk2-devel@lists.sourceforge.net; ler...@redhat.com; Yao, Jiewen
>Cc: Fleming, Matt
>Subject: [edk2] [PATCH 5/5] MdeModulePkg: enforce arch-specific alignment for 
>split regions
>
>The splitting of memory regions into code and data regions violates
>architecture specific alignment rules by using a fixed alignment
>of 4 KB. Replace it with EFI_ACPI_RUNTIME_PAGE_ALLOCATION_ALIGNMENT,
>which is defined appropriately on each architecture.
>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Ard Biesheuvel 
>---
> MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c | 7 ---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c 
>b/MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c
>index 0232a3ce7d93..01ecca64ab0a 100644
>--- a/MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c
>+++ b/MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c
>@@ -785,7 +785,7 @@ SetPropertiesTableSectionAlignment (
>   IN UINT32  SectionAlignment
>   )
> {
>-  if (((SectionAlignment & (SIZE_4KB - 1)) != 0) &&
>+  if (((SectionAlignment & (EFI_ACPI_RUNTIME_PAGE_ALLOCATION_ALIGNMENT - 1)) 
>!= 0) &&
>   ((mPropertiesTable.MemoryProtectionAttribute &
>EFI_PROPERTIES_RUNTIME_MEMORY_PROTECTION_NON_EXECUTABLE_PE_DATA) != 0)) {
> DEBUG ((EFI_D_VERBOSE, "SetPropertiesTableSectionAlignment - Clear\n"));
> mPropertiesTable.MemoryProtectionAttribute &=
>~EFI_PROPERTIES_RUNTIME_MEMORY_PROTECTION_NON_EXECUTABLE_PE_DATA;
>@@ -1119,8 +1119,9 @@ InsertImageRecord (
>   }
>
>   SetPropertiesTableSectionAlignment (SectionAlignment);
>-  if ((SectionAlignment & (SIZE_4KB - 1)) != 0) {
>-DEBUG ((EFI_D_ERROR, "  InsertImageRecord - Section 
>Alignment(0x%x) is not 4K  \n", SectionAlignment));
>+  if ((SectionAlignment & (EFI_ACPI_RUNTIME_PAGE_ALLOCATION_ALIGNMENT - 1)) 
>!= 0) {
>+DEBUG ((EFI_D_ERROR, "  InsertImageRecord - Section 
>Alignment(0x%x) is not %dK  \n",
>+  SectionAlignment, EFI_ACPI_RUNTIME_PAGE_ALLOCATION_ALIGNMENT >> 10));
> PdbPointer = PeCoffLoaderGetPdbPointer ((VOID*) (UINTN) ImageAddress);
> if (PdbPointer != NULL) {
>   DEBUG ((EFI_D_ERROR, "  Image - %a  \n", PdbPointer));
>--
>1.9.1
>
>
>--
>Don't Limit Your Business. Reach for the Cloud.
>GigeNET's Cloud Solutions provide you with the tools and support that
>you need to offload your IT needs and focus on growing your business.
>Configured For All Businesses. Start Your Cloud Today.
>https://www.gigenetcloud.com/
>___
>edk2-devel mailing list
>edk2-devel@lists.sourceforge.net
>https://lists.sourceforge.net/lists/listinfo/edk2-devel

--
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [PATCH 2/5] MdeModulePkg: make internal functions STATIC in Core/Dxe/Misc/PropertiesTable.c

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

>-Original Message-
>From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
>Sent: Tuesday, June 30, 2015 6:18 AM
>To: edk2-devel@lists.sourceforge.net; ler...@redhat.com; Yao, Jiewen
>Cc: Fleming, Matt
>Subject: [edk2] [PATCH 2/5] MdeModulePkg: make internal functions STATIC in 
>Core/Dxe/Misc/PropertiesTable.c
>
>Add STATIC to functions that are only used internally.
>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Ard Biesheuvel 
>---
> MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c | 21 
> 1 file changed, 21 insertions(+)
>
>diff --git a/MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c 
>b/MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c
>index 24240113659d..9459c6bda337 100644
>--- a/MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c
>+++ b/MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c
>@@ -94,6 +94,7 @@ EFI_LOCK   mPropertiesTableLock = 
>EFI_INITIALIZE_LOCK_VARIABLE (TPL_NOTI
>   @return  The number of bytes associated with the number of EFI_PAGEs 
> specified
>by Pages.
> **/
>+STATIC
> UINT64
> EfiPagesToSize (
>   IN UINT64 Pages
>@@ -113,6 +114,7 @@ EfiPagesToSize (
>by Size.
>
> **/
>+STATIC
> UINT64
> EfiSizeToPages (
>   IN UINT64 Size
>@@ -124,6 +126,7 @@ EfiSizeToPages (
> /**
>   Acquire memory lock on mPropertiesTableLock.
> **/
>+STATIC
> VOID
> CoreAcquirePropertiesTableLock (
>   VOID
>@@ -135,6 +138,7 @@ CoreAcquirePropertiesTableLock (
> /**
>   Release memory lock on mPropertiesTableLock.
> **/
>+STATIC
> VOID
> CoreReleasePropertiesTableLock (
>   VOID
>@@ -151,6 +155,7 @@ CoreReleasePropertiesTableLock (
>   @param  MemoryMapSize  Size, in bytes, of the MemoryMap buffer.
>   @param  DescriptorSize Size, in bytes, of an individual 
> EFI_MEMORY_DESCRIPTOR.
> **/
>+STATIC
> VOID
> SortMemoryMap (
>   IN OUT EFI_MEMORY_DESCRIPTOR  *MemoryMap,
>@@ -195,6 +200,7 @@ SortMemoryMap (
>  it is the size of new memory map after merge.
>   @param  DescriptorSize Size, in bytes, of an individual 
> EFI_MEMORY_DESCRIPTOR.
> **/
>+STATIC
> VOID
> MergeMemoryMap (
>   IN OUT EFI_MEMORY_DESCRIPTOR  *MemoryMap,
>@@ -242,6 +248,7 @@ MergeMemoryMap (
>   @param  MemoryMapSize  Size, in bytes, of the MemoryMap buffer.
>   @param  DescriptorSize Size, in bytes, of an individual 
> EFI_MEMORY_DESCRIPTOR.
> **/
>+STATIC
> VOID
> EnforceMemoryMapAttribute (
>   IN OUT EFI_MEMORY_DESCRIPTOR  *MemoryMap,
>@@ -283,6 +290,7 @@ EnforceMemoryMapAttribute (
>
>   @return first image record covered by [buffer, length]
> **/
>+STATIC
> IMAGE_PROPERTIES_RECORD *
> GetImageRecordByAddress (
>   IN EFI_PHYSICAL_ADDRESS  Buffer,
>@@ -327,6 +335,7 @@ GetImageRecordByAddress (
>   @param  OldRecord  A pointer to one old memory map entry.
>   @param  DescriptorSize Size, in bytes, of an individual 
> EFI_MEMORY_DESCRIPTOR.
> **/
>+STATIC
> UINTN
> SetNewRecord (
>   IN IMAGE_PROPERTIES_RECORD   *ImageRecord,
>@@ -422,6 +431,7 @@ SetNewRecord (
>   @retval  0 no entry need to be splitted.
>   @return  the max number of new splitted entries
> **/
>+STATIC
> UINTN
> GetMaxSplitRecordCount (
>   IN EFI_MEMORY_DESCRIPTOR *OldRecord
>@@ -467,6 +477,7 @@ GetMaxSplitRecordCount (
>   @retval  0 no entry is splitted.
>   @return  the real number of splitted record.
> **/
>+STATIC
> UINTN
> SplitRecord (
>   IN EFI_MEMORY_DESCRIPTOR *OldRecord,
>@@ -595,6 +606,7 @@ SplitRecord (
>  the current memory map.
>   @param  DescriptorSize Size, in bytes, of an individual 
> EFI_MEMORY_DESCRIPTOR.
> **/
>+STATIC
> VOID
> SplitTable (
>   IN OUT UINTN  *MemoryMapSize,
>@@ -705,6 +717,7 @@ SplitTable (
>   @retval EFI_INVALID_PARAMETER  One of the parameters has an invalid value.
>
> **/
>+STATIC
> EFI_STATUS
> EFIAPI
> CoreGetMemoryMapPropertiesTable (
>@@ -766,6 +779,7 @@ CoreGetMemoryMapPropertiesTable (
>
>   @param  SectionAlignmentPE/COFF section alignment
> **/
>+STATIC
> VOID
> SetPropertiesTableSectionAlignment (
>   IN UINT32  SectionAlignment
>@@ -787,6 +801,7 @@ SetPropertiesTableSectionAlignment (
>   @param  FirstImageRecordCodeSectionfirst code section in image record
>   @param  SecondImageRecordCodeSection   second code section in image record
> **/
>+STATIC
> VOID
> SwapImageRecordCodeSection (
>   IN IMAGE_PROPERTIES_RECORD_CODE_SECTION  *FirstImageRecordCodeSection,
>@@ -810,6 +825,7 @@ SwapImageRecordCodeSection (
>
>   @param  ImageRecordimage record to be sorted
> **/
>+STATIC
> VOID
> SortImageRecordCodeSection (
>   IN IMAGE_PROPERTIES_RECORD  *ImageRecord
>@@ -860,6 +876,7 @@ SortImageRecordCodeSection (
>   @retval TRUE  image record is valid
>   @retval FALSE image record is invalid
> **/
>+STATIC
> BOOLEAN
> IsImageRecordCodeSectionValid (
>   IN IMAGE_PROPERTIES_RECORD  *ImageRecord
>@@ -916,6 +933,7 @@ IsImageRecordCodeSe

Re: [edk2] [PATCH] ShellPkg: Refine code to avoid potential buffer overflow.

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

From: Qiu, Shumin
Sent: Tuesday, June 30, 2015 12:42 AM
To: edk2-devel@lists.sourceforge.net
Cc: Carsey, Jaben
Subject: [edk2] [PATCH] ShellPkg: Refine code to avoid potential buffer 
overflow.
Importance: High

This commit refine the catenae length to avoid potential buffer overflow.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin mailto:shumin@intel.com>>

Thanks,
Shumin

--
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] BUG in properties table feature implementation

[Carsey, Jaben]

>-Original Message-
>From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
>Sent: Monday, June 29, 2015 8:35 AM
>To: Yao, Jiewen
>Cc: Fleming, Matt; edk2-devel@lists.sourceforge.net
>Subject: Re: [edk2] BUG in properties table feature implementation
>
>On 29 June 2015 at 16:08, Yao, Jiewen  wrote:
>> Good to know. Thanks!
>>
>
>Another question from my side: is it guaranteed the the memory map
>returned by GetMemoryMap() is sorted?
>Otherwise, it becomes non-trivial for the OS to ensure that all
>Runtime regions are mapped adjacently.
>

I have seen lots of odd maps with the memmap  shell command. I think that the 
answer is no as a result, but I'd like to know if someone knows for sure.

>
>> -Original Message-
>> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
>> Sent: Monday, June 29, 2015 10:06 PM
>> To: Yao, Jiewen
>> Cc: edk2-devel@lists.sourceforge.net; Gao, Liming; Laszlo Ersek; Justen,
>Jordan L; Kinney, Michael D; Zeng, Star; Zimmer, Vincent; Fleming, Matt
>> Subject: Re: BUG in properties table feature implementation
>>
>> On 29 June 2015 at 15:58, Yao, Jiewen  wrote:
>>> Yes. It seems we need some special handling for AArch64.
>>> If 64KiB is minimal paging unit, I think we need check 64KiB PE section
>alignment for AArch64.
>>>
>>> I confess that I only validated IA32 and X64, and I did not take AArch64 
>>> into
>account.
>>>
>>> BTW: There is no 64KiB alignment requirement for AArch32, right? I cannot
>find the word. So I just want to double confirm.
>>>
>>
>> No there is not. Only 64-bit ARM can execute with 64 KB page size.
>>
>> --
>> Ard.
>>
>>
>>> -Original Message-
>>> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
>>> Sent: Monday, June 29, 2015 9:42 PM
>>> To: Yao, Jiewen
>>> Cc: edk2-devel@lists.sourceforge.net; Gao, Liming; Laszlo Ersek; Justen,
>Jordan L; Kinney, Michael D; Zeng, Star; Zimmer, Vincent; Fleming, Matt
>>> Subject: Re: BUG in properties table feature implementation
>>>
>>> On 29 June 2015 at 14:54, Yao, Jiewen  wrote:
 Thanks for the sharing. Yes. I agree with you that this breaks backward
>compatibility.
 Right, I do not think we can boot Win7 or old Win8 with this feature
>enabled.

 Both UEFI OS and Firmware need support this UEFI2.5 Properties Table
>feature. I believe it is known by UEFI forum, when it is added to UEFI spec,
>and it is published.

>>>
>>> Yes, but I don't think it is documented anywhere that the OS needs to map
>all runtime regions adjacently even if it does not actually care about the
>EFI_MEMORY_RO attributes. Essentially, the OS always need to map
>adjacently to be compatible with UEFI 2.5, and the current AArch64 Linux
>kernel crashes badly on any UEFI 2,5 implementation that has this feature
>enabled.
>>>
 UEFI 2.5 properties table is optional feature. It can be enabled or
>disabled.
 The benefit of this feature is that: a UEFI2.5 OS can do memory protection
>based on UEFI memory map.
 But the old UEFI OS cannot get any benefit.

 So a platform can made judgment based on its need, as well as the UEFI
>2.5 OS availability.

>>>
>>> Unfortunately, this makes it an opt-in setting, and system will ship with it
>disabled by default, in order to prevent boot failures on older OSes. That is
>not typically how you want to deploy a security feature.
>>>
>>> There is another issue I would like your opinion about:
>>> for AArch64, MdeModulePkg/Core/Dxe/Mem/Imem.h defines the
>following
>>>
>>> #define EFI_ACPI_RUNTIME_PAGE_ALLOCATION_ALIGNMENT
>(SIZE_64KB)
>>>
>>> and in CoreTerminateMemoryMap(), a final check is done that no Runtime
>regions are aligned incorrectly.
>>> Yet, with the Properties Table feature enabled, memory regions are split
>without taking this into account. Strangely enough,
>CoreTerminateMemoryMap () does not complain about this.
>>>
>>> This is documented in the UEFI spec 2.3.6:
>>> """
>>> All 4KiB memory pages allocated for use by runtime services (of types
>EfiRuntimeServicesCode, EfiRuntimeServicesData and
>>> EfiACPIMemoryNVS) must use identical ARM Memory Page Attributes (as
>described in Table 8) within the same physical 64KiB page. Mixed attribute
>mappings within a larger page are not allowed.
>>> """
>>>
>>> So I suppose the Properties table feature should use 64 KB not 4 KB when
>executing on AArch64. However, the documentation for the Properties Table
>feature mentions 4 KB explicitly, so that should go into the errata as well.
>>>
>>>
>>> Regards,
>>> Ard.
>>>
>>>
 That is why we do not enable this PE/COFF 4K alignment in BaseTool as
>standard configuration.
 So in other word, it is disabled by tool by default. A platform may also
>decide to not publish PropertiesTable by below PCD:
   ## Publish PropertiesTable or not.
   #
   # If this PCD is TRUE, DxeCore publishs PropertiesTable.
   # DxeCore evaluates if all runtime drivers has 4K aligned PE sections. 
 If all
   # PE sections in runtime driver

Re: [edk2] [PATCH 06/20] SecurityPkg VariableInfo: Delete it.

[Carsey, Jaben]

I think that is because all previous changes were backwards compatible.

>-Original Message-
>From: Zeng, Star [mailto:star.z...@intel.com]
>Sent: Thursday, June 25, 2015 6:05 PM
>To: edk2-devel@lists.sourceforge.net
>Subject: Re: [edk2] [PATCH 06/20] SecurityPkg VariableInfo: Delete it.
>Importance: High
>
>Good point, I am ok to update the package version. About package GUID, I
>never saw it has been changed since the package been created, I will leave it
>as is.
>
>-Original Message-
>From: Carsey, Jaben [mailto:jaben.car...@intel.com]
>Sent: Friday, June 26, 2015 1:48 AM
>To: edk2-devel@lists.sourceforge.net
>Subject: Re: [edk2] [PATCH 06/20] SecurityPkg VariableInfo: Delete it.
>
>Since removing a module is non-backwards compatible change to the
>package, shouldn't you change the package GUID (and the version)?
>
>-Jaben
>
>> -Original Message-
>> From: Star Zeng [mailto:star.z...@intel.com]
>> Sent: Thursday, June 25, 2015 2:46 AM
>> To: edk2-devel@lists.sourceforge.net
>> Subject: [edk2] [PATCH 06/20] SecurityPkg VariableInfo: Delete it.
>> Importance: High
>>
>> What to do:
>> 1. Delete VariableInfo in SecurityPkg after it merged to VariableInfo
>> in MdeModulePkg.
>>
>> Why to do:
>> 1. Remove code duplication and reduce maintenance effort.
>> The functionality of VariableInfo in SecurityPkg has covered
>> VariableInfo in MdeModulePkg.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Star Zeng 
>> Reviewed-by: Jiewen Yao 
>> Reviewed-by: Liming Gao 
>> ---
>>  .../Application/VariableInfo/VariableInfo.c| 265 
>> -
>>  .../Application/VariableInfo/VariableInfo.inf  |  63 -
>>  .../Application/VariableInfo/VariableInfo.uni  | Bin 2902 -> 0 bytes
>>  .../Application/VariableInfo/VariableInfoExtra.uni | Bin 1360 -> 0 bytes
>>  SecurityPkg/SecurityPkg.dsc|   1 -
>>  5 files changed, 329 deletions(-)
>>  delete mode 100644
>> SecurityPkg/Application/VariableInfo/VariableInfo.c
>>  delete mode 100644
>> SecurityPkg/Application/VariableInfo/VariableInfo.inf
>>  delete mode 100644
>> SecurityPkg/Application/VariableInfo/VariableInfo.uni
>>  delete mode 100644
>> SecurityPkg/Application/VariableInfo/VariableInfoExtra.uni
>>
>> diff --git a/SecurityPkg/Application/VariableInfo/VariableInfo.c
>> b/SecurityPkg/Application/VariableInfo/VariableInfo.c
>> deleted file mode 100644
>> index 0c1ee4b..000
>> --- a/SecurityPkg/Application/VariableInfo/VariableInfo.c
>> +++ /dev/null
>> @@ -1,265 +0,0 @@
>> -/** @file
>> -  If the Variable services have PcdVariableCollectStatistics set to
>> TRUE then
>> -  this utility will print out the statistics information. You can use
>> console
>> -  redirection to capture the data.
>> -
>> -Copyright (c) 2009 - 2011, Intel Corporation. All rights
>> reserved. -This program and the accompanying materials -are
>> licensed and made available under the terms and conditions of the BSD
>> License -which accompanies this distribution.  The full text of the
>> license may be found at
>> -http://opensource.org/licenses/bsd-license.php
>> -
>> -THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"
>> BASIS,
>> -WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
>EXPRESS OR
>> IMPLIED.
>> -
>> -**/
>> -
>> -#include 
>> -#include 
>> -#include 
>> -#include 
>> -
>> -#include 
>> -#include  -#include
>>  -#include 
>> -
>> -#include 
>> -#include 
>> -#include  -#include
>> 
>> -
>> -extern EFI_GUID gEfiVariableGuid;
>> -EFI_SMM_COMMUNICATION_PROTOCOL  *mSmmCommunication =
>NULL;
>> -
>> -/**
>> -
>> -  This function get the variable statistics data from SMM variable driver.
>> -
>> -  @param[in, out] SmmCommunicateHeader In input, a pointer to a
>> collection of data that will
>> -   be passed into an SMM environment. 
>> In output, a
>> pointer
>> -   to a collection of data that comes 
>> from an SMM
>> environment.
>> -  @param[in, out] SmmCommunicateSize   The size of the
>> SmmCommunicateHeader.
>> -
>> -  @retval EFI_SUCCESS   Get the statistics data information.
>> -  @retval EFI_NOT_FOUND Not found.
>> -  @retval EFI_BUFFER_TO_SMALL   DataSize is too small for 

Re: [edk2] [PATCH 06/20] SecurityPkg VariableInfo: Delete it.

[Carsey, Jaben]

Since removing a module is non-backwards compatible change to the package, 
shouldn't you change the package GUID (and the version)?

-Jaben

> -Original Message-
> From: Star Zeng [mailto:star.z...@intel.com]
> Sent: Thursday, June 25, 2015 2:46 AM
> To: edk2-devel@lists.sourceforge.net
> Subject: [edk2] [PATCH 06/20] SecurityPkg VariableInfo: Delete it.
> Importance: High
> 
> What to do:
> 1. Delete VariableInfo in SecurityPkg after it merged to VariableInfo in
> MdeModulePkg.
> 
> Why to do:
> 1. Remove code duplication and reduce maintenance effort.
> The functionality of VariableInfo in SecurityPkg has covered VariableInfo
> in MdeModulePkg.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Star Zeng 
> Reviewed-by: Jiewen Yao 
> Reviewed-by: Liming Gao 
> ---
>  .../Application/VariableInfo/VariableInfo.c| 265 
> -
>  .../Application/VariableInfo/VariableInfo.inf  |  63 -
>  .../Application/VariableInfo/VariableInfo.uni  | Bin 2902 -> 0 bytes
>  .../Application/VariableInfo/VariableInfoExtra.uni | Bin 1360 -> 0 bytes
>  SecurityPkg/SecurityPkg.dsc|   1 -
>  5 files changed, 329 deletions(-)
>  delete mode 100644 SecurityPkg/Application/VariableInfo/VariableInfo.c
>  delete mode 100644 SecurityPkg/Application/VariableInfo/VariableInfo.inf
>  delete mode 100644 SecurityPkg/Application/VariableInfo/VariableInfo.uni
>  delete mode 100644
> SecurityPkg/Application/VariableInfo/VariableInfoExtra.uni
> 
> diff --git a/SecurityPkg/Application/VariableInfo/VariableInfo.c
> b/SecurityPkg/Application/VariableInfo/VariableInfo.c
> deleted file mode 100644
> index 0c1ee4b..000
> --- a/SecurityPkg/Application/VariableInfo/VariableInfo.c
> +++ /dev/null
> @@ -1,265 +0,0 @@
> -/** @file
> -  If the Variable services have PcdVariableCollectStatistics set to TRUE then
> -  this utility will print out the statistics information. You can use console
> -  redirection to capture the data.
> -
> -Copyright (c) 2009 - 2011, Intel Corporation. All rights reserved.
> -This program and the accompanying materials
> -are licensed and made available under the terms and conditions of the BSD
> License
> -which accompanies this distribution.  The full text of the license may be
> found at
> -http://opensource.org/licenses/bsd-license.php
> -
> -THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"
> BASIS,
> -WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> EXPRESS OR IMPLIED.
> -
> -**/
> -
> -#include 
> -#include 
> -#include 
> -#include 
> -
> -#include 
> -#include 
> -#include 
> -#include 
> -
> -#include 
> -#include 
> -#include 
> -#include 
> -
> -extern EFI_GUID gEfiVariableGuid;
> -EFI_SMM_COMMUNICATION_PROTOCOL  *mSmmCommunication = NULL;
> -
> -/**
> -
> -  This function get the variable statistics data from SMM variable driver.
> -
> -  @param[in, out] SmmCommunicateHeader In input, a pointer to a
> collection of data that will
> -   be passed into an SMM environment. In 
> output, a
> pointer
> -   to a collection of data that comes 
> from an SMM
> environment.
> -  @param[in, out] SmmCommunicateSize   The size of the
> SmmCommunicateHeader.
> -
> -  @retval EFI_SUCCESS   Get the statistics data information.
> -  @retval EFI_NOT_FOUND Not found.
> -  @retval EFI_BUFFER_TO_SMALL   DataSize is too small for the result.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -GetVariableStatisticsData (
> -  IN OUT  EFI_SMM_COMMUNICATE_HEADER  *SmmCommunicateHeader,
> -  IN OUT  UINTN   *SmmCommunicateSize
> -  )
> -{
> -  EFI_STATUS  Status;
> -  SMM_VARIABLE_COMMUNICATE_HEADER
> *SmmVariableFunctionHeader;
> -
> -  CopyGuid (&SmmCommunicateHeader->HeaderGuid,
> &gEfiSmmVariableProtocolGuid);
> -  SmmCommunicateHeader->MessageLength = *SmmCommunicateSize -
> OFFSET_OF (EFI_SMM_COMMUNICATE_HEADER, Data);
> -
> -  SmmVariableFunctionHeader =
> (SMM_VARIABLE_COMMUNICATE_HEADER *) &SmmCommunicateHeader-
> >Data[0];
> -  SmmVariableFunctionHeader->Function =
> SMM_VARIABLE_FUNCTION_GET_STATISTICS;
> -
> -  Status = mSmmCommunication->Communicate (mSmmCommunication,
> SmmCommunicateHeader, SmmCommunicateSize);
> -  ASSERT_EFI_ERROR (Status);
> -
> -  Status = SmmVariableFunctionHeader->ReturnStatus;
> -  return Status;
> -}
> -
> -
> -/**
> -
> -  This function get and print the variable statistics data from SMM variable
> driver.
> -
> -  @retval EFI_SUCCESS   Print the statistics information 
> successfully.
> -  @retval EFI_NOT_FOUND Not found the statistics information.
> -
> -**/
> -EFI_STATUS
> -PrintInfoFromSmm (
> -  VOID
> -  )
> -{
> -  EFI_STATUS Status;
> -  VARIABLE_INFO_ENTRY*VariableInfo;
> -  EFI_SMM_COMMUNICATE_HEADER *CommBuffer;
> -  UINTN

Re: [edk2] [PATCH] MdePkg: Describe submission of a patch authored by someone else

[Carsey, Jaben]

> -Original Message-
> From: Roy Franz [mailto:roy.fr...@linaro.org]
> Sent: Wednesday, June 24, 2015 12:52 PM
> To: Kinney, Michael D
> Cc: edk2-devel@lists.sourceforge.net
> Subject: Re: [edk2] [PATCH] MdePkg: Describe submission of a patch
> authored by someone else
> 
> On Wed, Jun 24, 2015 at 11:46 AM, Kinney, Michael D
>  wrote:
> > Roy,
> >
> > I do not have any issues with adding this detailed description when multiple
> authors are involved in a single patch.
> >
> > In general, I think it would be good to avoid having multiple Signed-off-by
> in a single patch.  From one perspective, it could be possible for the patch 
> to
> be broken up into multiple patches with a different Signed-off-by in each
> patch.  But I can imagine cases, where that actually makes the code changes
> in patches difficult to review and understand.  So this is really just 
> providing
> details on how to merge patches from multiple authors into a single patch.  Is
> my understating correct?
> >
> > Thanks,
> >
> > Mike
> >
> 
> Hi Mike,
> 
> The main way this comes up is when someone posts a patch in response to
> a patch series or a question on how to do something.  What prompted my
> patch to Contributions.txt was I asked a question, and Laszlo very helpfully
> posted a patch to solve my problem.  His patch belongs as part of my series
> (implementing a new terminal type), so I will be submitting patches authored
> by me, as well as the one by Laszlo.  It gets very difficult to coordinate
> submissions if my patchset now becomes dependent on a patch that Laszlo
> would need to submit - interdependent patchsets developed by multiple
> people adds a lot of overhead, and is nice to avoid when possible.

In this case, wouldn't you have a patchset and one of the patches would be 
Signed-Off-By Lazlo and the rest by you?  How would this mean that there are 2 
Signed-Off-By in a single patch?

I would say that there are cases where more than one person work together to 
make a patch and then each person would be Signed-Off-By on the resulting patch.

> It will be a minority of patches that will have multiple signed-off-by lines, 
> but
> I wanted to document the proper handling of this.  I think that the practice 
> of
> providing patches in response to questions or patchsetset problems is a good
> one that we don't want do discourage.
> 
> Thanks,
> Roy
> 
> 
> > -Original Message-
> > From: Roy Franz [mailto:roy.fr...@linaro.org]
> > Sent: Wednesday, June 24, 2015 11:17 AM
> > To: edk2-devel@lists.sourceforge.net
> > Cc: ler...@redhat.com; Kinney, Michael D
> > Subject: Re: [edk2] [PATCH] MdePkg: Describe submission of a patch
> > authored by someone else
> >
> > On Wed, Jun 24, 2015 at 4:23 AM, Olivier Martin 
> wrote:
> >> I think your change should be integrated to a new top file
> 'Contributions.txt' and all the package 'Contributions.txt' should refer to 
> this
> file.
> >> Otherwise we will start to get some inconsistencies between
> 'Contributions.txt'.
> >
> > edk2$ find . -name Contributions.txt | wc -l
> > 38
> >
> > Ouch!  (At least they are all identical.)
> >
> > I found the MdePackage instance (google brought me there), and didn't
> > look to see if there were more
> >
> > These should definitely be replaced with a single top-level instance.
> > Any modules that require different content can add a specialized one,
> > but since they are all identical, that is a current requirement.
> >
> > Once the content of changes is agreed upon, I'll update my patch to do
> > this as well.
> >
> > Roy
> >
> >
> >>
> >> -Original Message-
> >> From: Roy Franz [mailto:roy.fr...@linaro.org]
> >> Sent: 23 June 2015 19:36
> >> To: edk2-devel@lists.sourceforge.net; ler...@redhat.com;
> >> michael.d.kin...@intel.com
> >> Subject: [edk2] [PATCH] MdePkg: Describe submission of a patch
> >> authored by someone else
> >>
> >> Add a description of how to describe the authorship of a patch that is
> submitted by someone other than the original author.
> >> Add mention of git format-patch --stat=120 option for generating more
> useful patch names in diffstat.
> >>
> >> Contributed-under: TianoCore Contribution Agreement 1.0
> >> Signed-off-by: Roy Franz 
> >> ---
> >>  MdePkg/Contributions.txt | 11 ++-
> >>  1 file changed, 10 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/MdePkg/Contributions.txt b/MdePkg/Contributions.txt
> >> index f87cbd7..98de958 100644
> >> --- a/MdePkg/Contributions.txt
> >> +++ b/MdePkg/Contributions.txt
> >> @@ -67,7 +67,16 @@ Patch content inline or attached
> >>  * The first line of commit message is taken from the email's subject
> >>line following [PATCH]. The remaining portion of the commit message
> >>is the email's content until the '---' line.
> >> -* git format-patch is one way to create this format
> >> +* git format-patch is one way to create this format. In order to get
> >> +  useful path names in the diffstat, the "--stat=120" option should
> 

Re: [edk2] [PATCH v2] SecurityPkg: Fix wrong calculation of ImageExeInfoEntrySize

[Carsey, Jaben]

>-Original Message-
>From: Liming Gao [mailto:liming@intel.com]
>Sent: Tuesday, June 23, 2015 3:03 AM
>To: edk2-devel@lists.sourceforge.net
>Subject: [edk2] [PATCH v2] SecurityPkg: Fix wrong calculation of
>ImageExeInfoEntrySize
>
>Per UEFI spec, EFI_IMAGE_EXECUTION_INFO structure is updated to
>comment
>Signature field. So, its structure doesn't include Signature field. But,
>ImageExeInfoEntrySize uses its structure size minor Signature size. It

I think you mean "minus" in this commit message, not "minor".

Reviewed-by: Jaben Carsey 

>will be corrected in this change.
>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Liming Gao 
>Reviewed-by: Chao Zhang 
>---
> SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c | 4
>++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git
>a/SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c
>b/SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c
>index d7e286b..3331b68 100644
>--- a/SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c
>+++
>b/SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c
>@@ -1,7 +1,7 @@
> /** @file
>-  Implement image verification services for secure boot service in UEFI2.3.1.
>+  Implement image verification services for secure boot service
>
>   Caution: This file requires additional review when modified.
>   This library will have external input - PE/COFF image.
>   This external input must be validated carefully to avoid security issue like
>   buffer overflow, integer overflow.
>@@ -767,11 +767,11 @@ AddImageExeInfo (
> //
> ImageExeInfoTableSize = sizeof (EFI_IMAGE_EXECUTION_INFO_TABLE);
>   }
>
>   DevicePathSize= GetDevicePathSize (DevicePath);
>-  NewImageExeInfoEntrySize  = sizeof (EFI_IMAGE_EXECUTION_INFO) -
>sizeof (EFI_SIGNATURE_LIST) + NameStringLen + DevicePathSize +
>SignatureSize;
>+  NewImageExeInfoEntrySize  = sizeof (EFI_IMAGE_EXECUTION_INFO) +
>NameStringLen + DevicePathSize + SignatureSize;
>   NewImageExeInfoTable  = (EFI_IMAGE_EXECUTION_INFO_TABLE *)
>AllocateRuntimePool (ImageExeInfoTableSize + NewImageExeInfoEntrySize);
>   if (NewImageExeInfoTable == NULL) {
> return ;
>   }
>
>--
>1.9.5.msysgit.0
>
>
>--
>Monitor 25 network devices or servers for free with OpManager!
>OpManager is web-based network management software that monitors
>network devices and physical & virtual servers, alerts via email & sms
>for fault. Monitor 25 devices for free with no restriction. Download now
>http://ad.doubleclick.net/ddm/clk/292181274;119417398;o
>___
>edk2-devel mailing list
>edk2-devel@lists.sourceforge.net
>https://lists.sourceforge.net/lists/listinfo/edk2-devel

--
Monitor 25 network devices or servers for free with OpManager!
OpManager is web-based network management software that monitors 
network devices and physical & virtual servers, alerts via email & sms 
for fault. Monitor 25 devices for free with no restriction. Download now
http://ad.doubleclick.net/ddm/clk/292181274;119417398;o
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] CHAR16 gets TRASH

[Carsey, Jaben]

You only allocated 1 character for each string with sizeof(CHAR16).  If you 
have any StrLen at all, you've got a problem overwriting memory I think...

-Jaben

>-Original Message-
>From: S.Vieira [mailto:jwvsan...@outlook.com]
>Sent: Tuesday, June 23, 2015 7:01 AM
>To: edk2-devel@lists.sourceforge.net
>Subject: [edk2] CHAR16 gets TRASH
>
>Hi everyone
>
>I'm having a problem with CHAR16.
>
>I have a function :
>
>VOID
>FileLogInfo(
>   EFI_HANDLE ImageHandle,
>   CHAR16 *SerialNumberFile,
>   CHAR16 * ModelNumber,
>   CHAR16 * FirRevision
>);
>
>
>
>
>When passing the parameters to function:
>
>
>CHAR16 *stringModel= NULL;
>CHAR16 *stringFw   = NULL;
>CHAR16 *stringRv   = NULL;
>
>UINT8  *Model;
>UINT8  *Fw;
>UINT8  *Rv;
>
>gBS->AllocatePool(EfiBootServicesData,
>sizeof(UINT8),
>(VOID **)&Model);
>
>gBS->AllocatePool(EfiBootServicesData,
>sizeof(UINT8),
>(VOID **)&Fw);
>
>gBS->AllocatePool(EfiBootServicesData,
>sizeof(UINT8),
>(VOID **)&Rv);
>
>gBS->AllocatePool(EfiBootServicesData,
>sizeof(CHAR16),
>(VOID **)&stringModel);
>
>gBS->AllocatePool(EfiBootServicesData,
>sizeof(CHAR16),
>(VOID **)&stringFw);
>
>gBS->AllocatePool(EfiBootServicesData,
>sizeof(CHAR16),
>(VOID **)&stringRv);
>
>
>AtaSmartShortTest(deviceCurrentArray[Option],
>deviceCurrentPortArray[Option],
>ATA_VALUE_PORT,
>Model,
>Fw,
>Rv);
>
>HexToStringBuffer(Model,stringModel);
>HexToStringBuffer(Fw,stringFw);
>HexToStringBuffer(Rv,stringRv);
>
>gBS->FreePool((VOID **)&Model);
>gBS->FreePool((VOID **)&Fw);
>gBS->FreePool((VOID **)&Rv);
>
>FileLogInfo(ImageHandle,stringFw,stringModel,stringRv);
>
>gBS->FreePool((VOID **)&stringModel);
>gBS->FreePool((VOID **)&stringRv);
>
>
>
>
>When I call Print() before FileLogInfo the CHAR16 strings are right, but
>when call Print inside FileLogInfo the  CHAR16 strings are wrong.
>
>For example, if the stringModel has StrLen equal 15, inside FileLogInfo i
>will have StrLen equal 22, sometimes gets trash and sometimes not .
>
>
>--
>Monitor 25 network devices or servers for free with OpManager!
>OpManager is web-based network management software that monitors
>network devices and physical & virtual servers, alerts via email & sms
>for fault. Monitor 25 devices for free with no restriction. Download now
>http://ad.doubleclick.net/ddm/clk/292181274;119417398;o
>___
>edk2-devel mailing list
>edk2-devel@lists.sourceforge.net
>https://lists.sourceforge.net/lists/listinfo/edk2-devel

--
Monitor 25 network devices or servers for free with OpManager!
OpManager is web-based network management software that monitors 
network devices and physical & virtual servers, alerts via email & sms 
for fault. Monitor 25 devices for free with no restriction. Download now
http://ad.doubleclick.net/ddm/clk/292181274;119417398;o
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [PATCH] MdePkg\Library\UefiFileHandleLib: Make FileHandleWriteLine support both ASCII and UNICODE file.

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

>-Original Message-
>From: Qiu, Shumin
>Sent: Monday, June 22, 2015 11:30 PM
>To: edk2-devel@lists.sourceforge.net
>Cc: Carsey, Jaben; Gao, Liming
>Subject: [PATCH] MdePkg\Library\UefiFileHandleLib: Make
>FileHandleWriteLine support both ASCII and UNICODE file.
>Importance: High
>
>When the file is a UNICODE file (with UNICODE file tag) write UNICODE text.
>When the file is an ASCII file write ASCII text.
>If the file size is zero (without the file tag at the beginning) write ASCII 
>text as
>default.
>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Qiu Shumin 
>---
> MdePkg/Include/Library/FileHandleLib.h | 10 ++-
> .../Library/UefiFileHandleLib/UefiFileHandleLib.c  | 97
>--
> 2 files changed, 97 insertions(+), 10 deletions(-)
>
>diff --git a/MdePkg/Include/Library/FileHandleLib.h
>b/MdePkg/Include/Library/FileHandleLib.h
>index bfcf8a4..b5ac19a 100644
>--- a/MdePkg/Include/Library/FileHandleLib.h
>+++ b/MdePkg/Include/Library/FileHandleLib.h
>@@ -433,7 +433,13 @@ FileHandleReturnLine(
>   );
>
> /**
>-  Function to write a line of unicode text to a file.
>+  Function to write a line of text to a file.
>+
>+  If the file is a Unicode file (with UNICODE file tag) then write the unicode
>+  text.
>+  If the file is an ASCII file then write the ASCII text.
>+  If the size of file is zero (without file tag at the beginning) then write
>+  ASCII text as default.
>
>   @param[in] Handle FileHandle to write to.
>   @param[in] Buffer Buffer to write, if NULL the function will
>@@ -442,6 +448,8 @@ FileHandleReturnLine(
>   @retval  EFI_SUCCESSThe data was written.
>   Buffer is NULL.
>   @retval  EFI_INVALID_PARAMETER  Handle is NULL.
>+  @retval  EFI_OUT_OF_RESOURCES   Unable to allocate temporary space for
>ASCII
>+  string due to out of resources.
>
>   @sa FileHandleWrite
> **/
>diff --git a/MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.c
>b/MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.c
>index 96f16ca..f6cbfad 100644
>--- a/MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.c
>+++ b/MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.c
>@@ -1027,7 +1027,13 @@ FileHandleReadLine(
> }
>
> /**
>-  Function to write a line of unicode text to a file.
>+  Function to write a line of text to a file.
>+
>+  If the file is a Unicode file (with UNICODE file tag) then write the unicode
>+  text.
>+  If the file is an ASCII file then write the ASCII text.
>+  If the size of file is zero (without file tag at the beginning) then write
>+  ASCII text as default.
>
>   @param[in] Handle FileHandle to write to.
>   @param[in] Buffer Buffer to write, if NULL the function will
>@@ -1036,6 +1042,8 @@ FileHandleReadLine(
>   @retval  EFI_SUCCESSThe data was written.
>   Buffer is NULL.
>   @retval  EFI_INVALID_PARAMETER  Handle is NULL.
>+  @retval  EFI_OUT_OF_RESOURCES   Unable to allocate temporary space for
>ASCII
>+  string due to out of resources.
>
>   @sa FileHandleWrite
> **/
>@@ -1046,8 +1054,14 @@ FileHandleWriteLine(
>   IN CHAR16  *Buffer
>   )
> {
>-  EFI_STATUS Status;
>-  UINTN  Size;
>+  EFI_STATUS  Status;
>+  CHAR16  CharBuffer;
>+  UINTN   Size;
>+  UINTN   CharSize;
>+  UINT64  FileSize;
>+  UINT64  OriginalFilePosition;
>+  BOOLEAN Ascii;
>+  CHAR8   *AsciiBuffer;
>
>   if (Buffer == NULL) {
> return (EFI_SUCCESS);
>@@ -1056,14 +1070,79 @@ FileHandleWriteLine(
>   if (Handle == NULL) {
> return (EFI_INVALID_PARAMETER);
>   }
>-
>-  Size = StrSize(Buffer) - sizeof(Buffer[0]);
>-  Status = FileHandleWrite(Handle, &Size, Buffer);
>+
>+  Ascii = FALSE;
>+  AsciiBuffer = NULL;
>+
>+  Status = FileHandleGetPosition(Handle, &OriginalFilePosition);
>   if (EFI_ERROR(Status)) {
>-return (Status);
>+return Status;
>+  }
>+
>+  Status = FileHandleSetPosition(Handle, 0);
>+  if (EFI_ERROR(Status)) {
>+return Status;
>   }
>-  Size = StrSize(L"\r\n") - sizeof(CHAR16);
>-  return FileHandleWrite(Handle, &Size, L"\r\n");
>+
>+  Status = FileHandleGetSize(Handle, &FileSize);
>+  if (EFI_ERROR(Status)) {
>+return Status;
>+  }
>+
>+  if (FileSize == 0) {
>+Ascii = TRUE;
>+  } else {
>+CharSize = sizeof (CHAR16);
>+Status = FileHandleRead (Handle, &CharSize, &CharBuffer);
>+ASSERT_EFI_ERROR (Status);
&

Re: [edk2] [PATCH] ShellPkg\Application\Shell: Refine the code style.

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

>-Original Message-
>From: Qiu, Shumin
>Sent: Friday, June 19, 2015 1:43 AM
>To: edk2-devel@lists.sourceforge.net
>Cc: Carsey, Jaben
>Subject: [PATCH] ShellPkg\Application\Shell: Refine the code style.
>Importance: High
>
>BOOLEAN variable should not use explicit comparisons to TRUE or FALSE. To
>follow EDKII code style.
>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Qiu Shumin 
>---
> ShellPkg/Application/Shell/ConsoleLogger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/ShellPkg/Application/Shell/ConsoleLogger.c
>b/ShellPkg/Application/Shell/ConsoleLogger.c
>index 22abf55..9b64303 100644
>--- a/ShellPkg/Application/Shell/ConsoleLogger.c
>+++ b/ShellPkg/Application/Shell/ConsoleLogger.c
>@@ -416,7 +416,7 @@ ConsoleLoggerReset (
>   //
>   if (!EFI_ERROR (Status)) {
> ConsoleLoggerResetBuffers(ConsoleInfo);
>-if (ExtendedVerification == TRUE) {
>+if (ExtendedVerification) {
>   ConsoleInfo->OriginalStartRow = 0;
>   ConsoleInfo->CurrentStartRow = 0;
> }
>--
>1.9.5.msysgit.1
>


--
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [Patch] BaseTools: Convert ".\\" to "" in FilePath

[Carsey, Jaben]

Dennis,  

I notice that after this ".\\", the code looks for "\\.\\" and "\\..\\".  I 
think that the order may be wrong wince if you remove all the ".\\", then none 
of the "\\.\\" and "\\..\\" will ever get found...  either that or we are doing 
extra checks that are unnecessary...

-Jaben


>-Original Message-
>From: Liu, Yingke D [mailto:yingke.d@intel.com]
>Sent: Thursday, June 18, 2015 10:33 PM
>To: edk2-devel@lists.sourceforge.net
>Subject: Re: [edk2] [Patch] BaseTools: Convert ".\\" to "" in FilePath
>
>Reviewed-by: Yingke Liu 
>
>Dennis
>
>-Original Message-
>From: Liming Gao [mailto:liming@intel.com]
>Sent: Friday, June 19, 2015 9:30
>To: edk2-devel@lists.sourceforge.net
>Subject: [edk2] [Patch] BaseTools: Convert ".\\" to "" in FilePath
>
>Convert ".\\" to "", because it doesn't work with
>WINDOWS_EXTENSION_PATH.
>WINDOWS_EXTENSION_PATH can support the file path larger than 260 length.
>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Liming Gao 
>---
> BaseTools/Source/C/Common/CommonLib.c | 10 +-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
>diff --git a/BaseTools/Source/C/Common/CommonLib.c
>b/BaseTools/Source/C/Common/CommonLib.c
>index aa89115..2d07dfc 100644
>--- a/BaseTools/Source/C/Common/CommonLib.c
>+++ b/BaseTools/Source/C/Common/CommonLib.c
>@@ -669,19 +669,27 @@ Returns:
> //
> if ((PathPointer = strstr (mCommonLibFullPath, ":")) != NULL) {
>   *(PathPointer + 2) = '\0';
>   strcat (mCommonLibFullPath, PathPointer + 3);
> }
>+
>+//
>+// Convert ".\\" to "", because it doesn't work with
>WINDOWS_EXTENSION_PATH.
>+//
>+while ((PathPointer = strstr (mCommonLibFullPath, ".\\")) != NULL) {
>+  *PathPointer = '\0';
>+  strcat (mCommonLibFullPath, PathPointer + 2);
>+}
>
> //
> // Convert "\\.\\" to "\\", because it doesn't work with
>WINDOWS_EXTENSION_PATH.
> //
> while ((PathPointer = strstr (mCommonLibFullPath, "\\.\\")) != NULL) {
>   *PathPointer = '\0';
>   strcat (mCommonLibFullPath, PathPointer + 2);
> }
>-
>+
> //
> // Convert "\\..\\" to last directory, because it doesn't work with
>WINDOWS_EXTENSION_PATH.
> //
> while ((PathPointer = strstr (mCommonLibFullPath, "\\..\\")) != NULL) {
>   NextPointer = PathPointer + 3;
>--
>1.9.5.msysgit.0
>
>
>--
>___
>edk2-devel mailing list
>edk2-devel@lists.sourceforge.net
>https://lists.sourceforge.net/lists/listinfo/edk2-devel
>
>--
>___
>edk2-devel mailing list
>edk2-devel@lists.sourceforge.net
>https://lists.sourceforge.net/lists/listinfo/edk2-devel

--
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [PATCH] MdePkg: Refine the comments for FileHandleIsDirectory.

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

> -Original Message-
> From: Qiu, Shumin
> Sent: Thursday, June 11, 2015 7:18 PM
> To: edk2-devel@lists.sourceforge.net
> Cc: Carsey, Jaben; Gao, Liming; Tian, Hot
> Subject: [PATCH] MdePkg: Refine the comments for FileHandleIsDirectory.
> Importance: High
> 
> Make the function comments of FileHandleIsDirectory in FileHandleLib
> consistent with instance implementation.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Qiu Shumin 
> ---
>  MdePkg/Include/Library/FileHandleLib.h   | 4 ++--
>  MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.c | 7 ---
>  2 files changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/MdePkg/Include/Library/FileHandleLib.h
> b/MdePkg/Include/Library/FileHandleLib.h
> index 123cc8c..9c2d056 100644
> --- a/MdePkg/Include/Library/FileHandleLib.h
> +++ b/MdePkg/Include/Library/FileHandleLib.h
> @@ -1,7 +1,7 @@
>  /** @file
>Provides interface to EFI_FILE_HANDLE functionality.
> 
> -  Copyright (c) 2009 - 2014, Intel Corporation. All rights reserved.
> +  Copyright (c) 2009 - 2015, Intel Corporation. All rights
> + reserved.
>This program and the accompanying materials
>are licensed and made available under the terms and conditions of the BSD
> License
>which accompanies this distribution.  The full text of the license may be
> found at @@ -242,7 +242,7 @@ FileHandleFlush (
>  /**
>Function to determine if a given handle is a directory handle.
> 
> -  If DirHandle is NULL, then ASSERT().
> +  If DirHandle is NULL then return EFI_INVALID_PARAMETER.
> 
>Open the file information on the DirHandle, and verify that the Attribute
>includes EFI_FILE_DIRECTORY bit set.
> diff --git a/MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.c
> b/MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.c
> index be66c57..089f610 100644
> --- a/MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.c
> +++ b/MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.c
> @@ -1,7 +1,7 @@
>  /** @file
>Provides interface to EFI_FILE_HANDLE functionality.
> 
> -  Copyright (c) 2006 - 2014, Intel Corporation. All rights reserved. 
> +  Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.
> + 
>This program and the accompanying materials
>are licensed and made available under the terms and conditions of the BSD
> License
>which accompanies this distribution.  The full text of the license may be
> found at @@ -385,7 +385,7 @@ FileHandleFlush (
>  /**
>function to determine if a given handle is a directory handle
> 
> -  if DirHandle is NULL then return error
> +  If DirHandle is NULL then return EFI_INVALID_PARAMETER
> 
>open the file information on the DirHandle and verify that the Attribute
>includes EFI_FILE_DIRECTORY bit set.
> @@ -393,7 +393,8 @@ FileHandleFlush (
>@param DirHandle  Handle to open file
> 
>@retval EFI_SUCCESS   DirHandle is a directory
> -  @retval EFI_INVALID_PARAMETER DirHandle did not have EFI_FILE_INFO
> available
> +  @retval EFI_INVALID_PARAMETER DirHandle is NULL or the file
> information
> +returns from FileHandleGetInfo is NULL
>@retval EFI_NOT_FOUND DirHandle is not a directory
>  **/
>  EFI_STATUS
> --
> 1.9.5.msysgit.1
> 


--
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [ShellPkg] I think there is an issue in ls.

[Carsey, Jaben]

Andrew,

I agree, that looks like an issue.  Can you submit a patch with this fixed?  I 
will put this on the list of issues.

-Jaben

>-Original Message-
>From: Andrew Fish [mailto:af...@apple.com]
>Sent: Wednesday, June 10, 2015 6:26 PM
>To: edk2-devel@lists.sourceforge.net
>Subject: [edk2] [ShellPkg] I think there is an issue in ls.
>Importance: High
>
>Dear ShellPkg maintainer,
>
>I think there is an issue with the ls command. It does not use the TImeZone,
>so it seems it is hard coded to assume that a filesystem stores time like FAT, 
>in
>local time. The FAT driver always returns EFI_UNSPECIFIED_TIMEZONE, which
>implies the values are local time. But what if a filesystem is storing time in 
>UTC
>(EFI_TIME.TimeZone == 0)? it seems the current path in the shell assumes
>EFI_UNSPECIFIED_TIMEZONE (thus all time is local time). I don’t think this
>follows the UEFI spec. I think the correct algorithm is:
>
>if FileSystemTime.TimeZone == EFI_UNSPECIFIED_TIMEZONE
>   // This is the current path in the code
>  Assume time is local time, and print it out
>else:
>  // This is the missing path.
>  Adjust the FileSystemTime.TimeZone for the System.TimeZone (and
>System.Daylight), thus display the time in local time.
>
>Thanks,
>
>Andrew Fish
>
>
>--
>___
>edk2-devel mailing list
>edk2-devel@lists.sourceforge.net
>https://lists.sourceforge.net/lists/listinfo/edk2-devel
--
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [PATCH 2/2] MdePkg/Library/UefiFileHandleLib: Do the validation for DirHandle before get file information.

[Carsey, Jaben]

Why do we need to check against the latest revision?  Can't we use the version 
of the protocol that we need the feature from?

I like the idea of the check.

-Jaben

> -Original Message-
> From: Qiu, Shumin
> Sent: Wednesday, June 10, 2015 1:22 AM
> To: edk2-devel@lists.sourceforge.net
> Cc: Gao, Liming; Carsey, Jaben
> Subject: [PATCH 2/2] MdePkg/Library/UefiFileHandleLib: Do the validation
> for DirHandle before get file information.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Qiu Shumin 
> ---
>  MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.c | 9 -
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.c
> b/MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.c
> index 7687ca3..25bb8fb 100644
> --- a/MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.c
> +++ b/MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.c
> @@ -407,7 +407,14 @@ FileHandleIsDirectory (
>if (DirHandle == NULL) {
>  return (EFI_INVALID_PARAMETER);
>}
> -
> +
> +  //
> +  // check whether the DirHandle is valid
> +  //
> +  if (DirHandle->Revision != EFI_FILE_PROTOCOL_LATEST_REVISION) {
> +return EFI_INVALID_PARAMETER;
> +  }
> +
>//
>// get the file information for DirHandle
>//
> --
> 1.9.5.msysgit.1
> 


--
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [PATCH] MdePkg: Make the implementation of UefiFileHandleLib instance consistent with comments in header file.

[Carsey, Jaben]

Can you say return "EFI_INVALID_PARAMETER" instead of "error"

Reviewed-by: Jaben Carsey 

>-Original Message-
>From: Qiu Shumin [mailto:shumin@intel.com]
>Sent: Tuesday, June 09, 2015 8:04 PM
>To: edk2-devel@lists.sourceforge.net
>Subject: [edk2] [PATCH] MdePkg: Make the implementation of
>UefiFileHandleLib instance consistent with comments in header file.
>
>The comment for FileHandleIsDirectory in FileHandleLib.h states that "If
>DirHandle is NULL, then ASSERT()." But the instance of UefiFileHandleLib
>returns EFI_INVALID_PARAMETER. The patch makes the comments and the
>implementation consistent.
>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Qiu Shumin 
>---
> MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.c
>b/MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.c
>index be66c57..724532a 100644
>--- a/MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.c
>+++ b/MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.c
>@@ -385,7 +385,7 @@ FileHandleFlush (
> /**
>   function to determine if a given handle is a directory handle
>
>-  if DirHandle is NULL then return error
>+  if DirHandle is NULL, then ASSERT().
>
>   open the file information on the DirHandle and verify that the Attribute
>   includes EFI_FILE_DIRECTORY bit set.
>@@ -404,9 +404,7 @@ FileHandleIsDirectory (
> {
>   EFI_FILE_INFO *DirInfo;
>
>-  if (DirHandle == NULL) {
>-return (EFI_INVALID_PARAMETER);
>-  }
>+  ASSERT (DirHandle != NULL);
>
>   //
>   // get the file information for DirHandle
>--
>1.9.5.msysgit.1
>
>
>
>--
>___
>edk2-devel mailing list
>edk2-devel@lists.sourceforge.net
>https://lists.sourceforge.net/lists/listinfo/edk2-devel

--
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [PATCH] ShellPkg\Application\Shell: Clean start row information after the console has been Reset or SetMode.

[Carsey, Jaben]

>-Original Message-
>From: Laszlo Ersek [mailto:ler...@redhat.com]
>Sent: Monday, June 08, 2015 2:24 PM
>To: Qiu, Shumin
>Cc: edk2-devel@lists.sourceforge.net; Jin, Eric
>Subject: Re: [edk2] [PATCH] ShellPkg\Application\Shell: Clean start row
>information after the console has been Reset or SetMode.
>Importance: High
>
>On 06/08/15 13:40, Qiu Shumin wrote:
>> OriginalStartRow and CurrentStartRow should be initialized after new mode
>is set.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Qiu Shumin 
>> Signed-off-by: Eric Jin 
>> ---
>>  ShellPkg/Application/Shell/ConsoleLogger.c | 13 ++---
>>  1 file changed, 10 insertions(+), 3 deletions(-)
>>
>> diff --git a/ShellPkg/Application/Shell/ConsoleLogger.c
>b/ShellPkg/Application/Shell/ConsoleLogger.c
>> index 75469d9..06f9686 100644
>> --- a/ShellPkg/Application/Shell/ConsoleLogger.c
>> +++ b/ShellPkg/Application/Shell/ConsoleLogger.c
>> @@ -2,7 +2,7 @@
>>Provides interface to shell console logger.
>>
>>(C) Copyright 2013 Hewlett-Packard Development Company, L.P.
>> -  Copyright (c) 2009 - 2014, Intel Corporation. All rights reserved.
>> +  Copyright (c) 2009 - 2015, Intel Corporation. All rights reserved.
>>This program and the accompanying materials
>>are licensed and made available under the terms and conditions of the BSD
>License
>>which accompanies this distribution.  The full text of the license may be
>found at
>> @@ -410,6 +410,10 @@ ConsoleLoggerReset (
>>//
>>if (!EFI_ERROR (Status)) {
>>  ConsoleLoggerResetBuffers(ConsoleInfo);
>> +if (ExtendedVerification == TRUE) {
>> +  ConsoleInfo->OriginalStartRow = 0;
>> +  ConsoleInfo->CurrentStartRow = 0;
>> +}
>>}
>>
>>return Status;
>> @@ -963,10 +967,13 @@ ConsoleLoggerSetMode (
>>// Check that the buffers are still correct for logging
>>//
>>if (!EFI_ERROR (Status)) {
>> -ConsoleInfo->OurConOut.Mode = gST->ConOut->Mode;
>> +ConsoleInfo->OurConOut.Mode = ConsoleInfo->OldConOut->Mode;
>>  ConsoleLoggerResetBuffers(ConsoleInfo);
>> +ConsoleInfo->OriginalStartRow = 0;
>> +ConsoleInfo->CurrentStartRow = 0;
>> +ConsoleInfo->OurConOut.ClearScreen (&ConsoleInfo->OurConOut);
>>}
>> -
>> +
>>return Status;
>>  }
>>
>>
>
>I'm intrigued if this will make the random ASSERT()s go away that I
>recurrently see when scrolling up (Shift + PageUp) in the UEFI shell.
>Unfortunately, I have no reliable reproducer.

Bad memory here.  Is Shift+PageUp different from PageUp (no shift)?


-Jaben

>
>Thanks
>Laszlo
>
>--
>___
>edk2-devel mailing list
>edk2-devel@lists.sourceforge.net
>https://lists.sourceforge.net/lists/listinfo/edk2-devel

--
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

[edk2] [PATCH] ShellPkg: update Console to clear screen when resetting

[Carsey, Jaben]

Samer and Tapan,

Can you review this?

ShellPkg: update Console to clear screen when resetting

This clears the screen when scrolling is ended by a non-scrolling key press.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey 



ConsoleLogger.c.patch
Description: ConsoleLogger.c.patch
--
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [PATCH] ShellPkg\Application\Shell: Clean start row information after the console has been Reset or SetMode.

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

> -Original Message-
> From: Qiu, Shumin
> Sent: Monday, June 08, 2015 4:41 AM
> To: edk2-devel@lists.sourceforge.net
> Cc: Jin, Eric; Carsey, Jaben
> Subject: [PATCH] ShellPkg\Application\Shell: Clean start row information
> after the console has been Reset or SetMode.
> Importance: High
> 
> OriginalStartRow and CurrentStartRow should be initialized after new mode
> is set.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Qiu Shumin 
> Signed-off-by: Eric Jin 
> ---
>  ShellPkg/Application/Shell/ConsoleLogger.c | 13 ++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
> 
> diff --git a/ShellPkg/Application/Shell/ConsoleLogger.c
> b/ShellPkg/Application/Shell/ConsoleLogger.c
> index 75469d9..06f9686 100644
> --- a/ShellPkg/Application/Shell/ConsoleLogger.c
> +++ b/ShellPkg/Application/Shell/ConsoleLogger.c
> @@ -2,7 +2,7 @@
>Provides interface to shell console logger.
> 
>(C) Copyright 2013 Hewlett-Packard Development Company, L.P.
> -  Copyright (c) 2009 - 2014, Intel Corporation. All rights reserved.
> +  Copyright (c) 2009 - 2015, Intel Corporation. All rights
> + reserved.
>This program and the accompanying materials
>are licensed and made available under the terms and conditions of the BSD
> License
>which accompanies this distribution.  The full text of the license may be
> found at @@ -410,6 +410,10 @@ ConsoleLoggerReset (
>//
>if (!EFI_ERROR (Status)) {
>  ConsoleLoggerResetBuffers(ConsoleInfo);
> +if (ExtendedVerification == TRUE) {
> +  ConsoleInfo->OriginalStartRow = 0;
> +  ConsoleInfo->CurrentStartRow = 0;
> +}
>}
> 
>return Status;
> @@ -963,10 +967,13 @@ ConsoleLoggerSetMode (
>// Check that the buffers are still correct for logging
>//
>if (!EFI_ERROR (Status)) {
> -ConsoleInfo->OurConOut.Mode = gST->ConOut->Mode;
> +ConsoleInfo->OurConOut.Mode = ConsoleInfo->OldConOut->Mode;
>  ConsoleLoggerResetBuffers(ConsoleInfo);
> +ConsoleInfo->OriginalStartRow = 0;
> +ConsoleInfo->CurrentStartRow = 0;
> +ConsoleInfo->OurConOut.ClearScreen (&ConsoleInfo->OurConOut);
>}
> -
> +
>return Status;
>  }
> 
> --
> 1.9.5.msysgit.1
> 


--
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [PATCH] ShellPkg: Fix the Non-ASCII char and do code refine.

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

> -Original Message-
> From: Qiu, Shumin
> Sent: Sunday, June 07, 2015 6:35 PM
> To: edk2-devel@lists.sourceforge.net
> Cc: Carsey, Jaben
> Subject: [PATCH] ShellPkg: Fix the Non-ASCII char and do code refine.
> Importance: High
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Qiu Shumin 
> ---
>  ShellPkg/Library/UefiShellLevel2CommandsLib/Parse.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Parse.c
> b/ShellPkg/Library/UefiShellLevel2CommandsLib/Parse.c
> index 687ced6..12fe877 100644
> --- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Parse.c
> +++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Parse.c
> @@ -190,7 +190,7 @@ ParseReturnStdInLine (
> 
>  /**
>Handle stings for SFO Output with escape character ^ in a string
> -  1. Quotation marks in the string must be escaped by using a ^ character 
> (i.e.
> ^�).
> +  1. Quotation marks in the string must be escaped by using a ^ character
> (i.e. ^").
>2. The ^ character may be inserted using ^^.
> 
>@param[in]  String  The Unicode NULL-terminated string.
> @@ -290,7 +290,7 @@ PerformParsing(
> TempLine = ShellFileHandleReturnLine (FileHandle, &Ascii);
>   }
> 
> -  if ((TempLine == NULL) || (*TempLine == CHAR_NULL &&
> StreamingUnicode == TRUE)) {
> +  if ((TempLine == NULL) || (*TempLine == CHAR_NULL &&
> StreamingUnicode)) {
>   break;
>}
> 
> --
> 1.9.5.msysgit.1
> 


--
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] ShellPkg: Add pipe support for parse command

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

Commit 17555

From: Shah, Tapan [mailto:tapands...@hp.com]
Sent: Wednesday, June 03, 2015 9:18 AM
To: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: ShellPkg: Add pipe support for parse command
Importance: High

Jaben,
   Can you review the attached diff file with following changes?

Thanks,
Tapan


ShellPkg: Add pipe support for parse command

* parse reads data from StdIn when pipe is used and does not require 
-sfo output stored in a file. (e.g.:  fs0:\> ls *.nsh -sfo | parse FileInfo 2)

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off by: Tapan Shah mailto:tapands...@hp.com>>

Thanks,
Tapan

--
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] ShellPkg: Handle escape characters properly for parse command

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

Commit 17556

From: Shah, Tapan [mailto:tapands...@hp.com]
Sent: Wednesday, June 03, 2015 9:18 AM
To: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: ShellPkg: Handle escape characters properly for parse command
Importance: High

Jaben,
   Can you review the attached diff file with following changes?

Thanks,
Tapan


ShellPkg: Handle escape characters properly for parse command

* parse command does not remove escape character ^ if used to pass 
special characters like ^ , " in a quoted -sfo output string.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off by: Tapan Shah mailto:tapands...@hp.com>>

Thanks,
Tapan


--
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [Patch] SourceLevelDebugPkg/DebugAgent: Check PcdDebugPortHandleBufferSize

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

-Original Message-
From: Jeff Fan [mailto:jeff@intel.com] 
Sent: Tuesday, June 02, 2015 12:01 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [Patch] SourceLevelDebugPkg/DebugAgent: Check 
PcdDebugPortHandleBufferSize

Check PcdDebugPortHandleBufferSize before allocate buffer.
PeriodicMode is BOOLEAN type, needn't to use == TRUE in if condition.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan 
CC: Ruiyu Ni 
---
 .../Library/DebugAgent/SecPeiDebugAgent/SecPeiDebugAgentLib.c   | 2 +-
 SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgent/SmmDebugAgentLib.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebugAgentLib.c 
b/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebugAgentLib.c
index fba41ee..20b6a37 100644
--- 
a/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebugAgentLib.c
+++ 
b/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebugAgentLib.c
@@ -657,7 +657,7 @@ InitializeDebugAgentPhase2 (
   MailboxLocation = GetLocationSavedMailboxPointerInIdtEntry ();
   Mailbox = (DEBUG_AGENT_MAILBOX *)(UINTN)(*MailboxLocation);
   BufferSize = PcdGet16(PcdDebugPortHandleBufferSize);
-  if (Phase2Context->InitFlag == DEBUG_AGENT_INIT_PEI) {
+  if (Phase2Context->InitFlag == DEBUG_AGENT_INIT_PEI && BufferSize != 0) {
 NewDebugPortHandle = (UINT64)(UINTN)AllocateCopyPool (BufferSize, 
DebugPortHandle);
   } else {
 NewDebugPortHandle = (UINT64)(UINTN)DebugPortHandle;
diff --git 
a/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgent/SmmDebugAgentLib.c 
b/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgent/SmmDebugAgentLib.c
index 72db534..4e4e1f5 100644
--- a/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgent/SmmDebugAgentLib.c
+++ b/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgent/SmmDebugAgentLib.c
@@ -282,7 +282,7 @@ InitializeDebugAgent (
 //
 GetApicTimerState (NULL, &PeriodicMode, NULL);
 TimerCycle = GetApicTimerInitCount ();
-if (PeriodicMode != TRUE || TimerCycle == 0) {
+if (!PeriodicMode || TimerCycle == 0) {
   InitializeDebugTimer (NULL, FALSE);
   DisableApicTimerInterrupt ();
 }
-- 
1.9.5.msysgit.0


--
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

--
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] how to get the file length

[Carsey, Jaben]

What's happening with your code?  That looks quite similar to what I would 
expect...

-Jaben

-Original Message-
From: KSilva [mailto:kaleb.si...@iatecam.org.br] 
Sent: Monday, June 01, 2015 6:32 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] how to get the file length

I am trying to get a file length, but I have not had success yet.

here is my code: 


Status = gBS->HandleProtocol(Device,
 
&gSimpleFileProtocol,

(VOID**)&fileSystemProtocol
 );

Print(L"Status HandleProtocol :%r\n", Status);

root = NULL;
AsciiStrToUnicodeStr("kdias", texto);

Status = fileSystemProtocol->OpenVolume(fileSystemProtocol,

&root);

Print(L"Status OpenVolume :%r\n", Status);


Status = root->Open(root,
&newHandle,
nameFile,

EFI_FILE_MODE_READ| EFI_FILE_MODE_WRITE | EFI_FILE_MODE_CREATE, 0);


Print(L"Status do Open : %r \n",Status);


Status = 
newHandle->GetInfo(newHandle,&gEfiFileInfoGuid,&BufferSize,(VOID
&fileInfo);
Print(L"Status GetInfo :%r \n",Status);



return EFI_SUCCESS;
}


--
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

--
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

[edk2] [PATCH] ShellPkg: Update help output for correct alphabetical rev 2

[Carsey, Jaben]

Tapan and Shumin,

Can you check this version?

I added function comment blocks.  Thanks Shumin for pointing this out.

-Jaben


From: Shah, Tapan [mailto:tapands...@hp.com]
Sent: Wednesday, May 27, 2015 8:33 AM
To: Carsey, Jaben; Qiu, Shumin; edk2-devel@lists.sourceforge.net
Subject: RE: [PATCH] ShellPkg: Update help output for correct alphabetical
Importance: High

Reviewed-by: Tapan Shah mailto:tapands...@hp.com>>

From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Wednesday, May 27, 2015 9:51 AM
To: Shah, Tapan; Qiu, Shumin; edk2-devel@lists.sourceforge.net
Cc: Carsey, Jaben
Subject: [PATCH] ShellPkg: Update help output for correct alphabetical

Tapan and Shumin,

Can you review this patch please?


ShellPkg: Update help output for correct alphabetical

This updates help output to put dynamic commands in correct alphabetical 
location mixed into the other commands.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey 
mailto:jaben.car...@intel.com>>


Help.c.patch
Description: Help.c.patch
--
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] Replacement EDK2 email list coming soon

[Carsey, Jaben]

> -Original Message-
> From: Andrew Fish [mailto:af...@apple.com]
> Sent: Wednesday, May 27, 2015 11:49 AM
> To: Justen, Jordan L
> Cc: Bruce Cran; edk2-devel@lists.sourceforge.net; Olivier Martin
> Subject: Re: [edk2] Replacement EDK2 email list coming soon
> 
> 
> > On May 27, 2015, at 11:21 AM, Jordan Justen 
> wrote:
> >
> > On 2015-05-27 10:20:09, Laszlo Ersek wrote:
> >> On 05/27/15 18:06, Andrew Fish wrote:
> >>>
>  On May 27, 2015, at 1:52 AM, Laszlo Ersek   > wrote:
> 
>  Access on the web looks like a step forward (eg. it provides syntax
>  highlighting), but it's actually a small step at a steep price. The
>  price is that a web browser (and a central server) are required.
> >>>
> >>> “Stone Knives and bearskins” aside, why is a web browser bad?
> >>
> >> Ultimately, I can only say that I've found web apps very limiting
> >> when engaging in technical discussion.
> >
> > See also: this thread right here.
> >
> > ... Actual discussion happening. Can you imagine trying to do the same
> > on a web forum?
> >
> > ... Little barrier to entry to the discussion. (An email account.)
> >
> 
> I did not think a web browser was a barrier to entry, hence “Stone Knives and
> bearskins” Star Trek quote.
> 
> In my proposal I tried to position the web browser as adding value (visual 
> diff
> for free, applies patch for free, auto builder for free), not being a required
> workflow.
> 
> > I happen to agree with Laszlo. We should retain the ability for people
> > to run git format-patch/send-email to contribute.
> >
> > If we adopt some web based system, we should note that we are going to
> > cut some people out of that loop.
> >
> > I've seen Gerrit a little, but I've not actually worked with it.
> > Regarding what I saw, I wasn't particularly impressed (nor concerned).
> > It didn't appear to bring all that much beyond email reviews.
> >
> 
> I’m not tied to Gerrit. If we add an auto builder, then the review becomes
> more than send a patch to the mailing list. I’d be fine if that was an
> automated mailing list that did the auto build, if that passes post to the 
> edk2
> mailing list and maybe have some quick way to do a graphical diff. Maybe
> that is not possible.

Graphical diff is frequently much more useful than the email.  Often I need 
more surrounding code than the email has.

> 
> I think what we are saying is a new way to review patches is not worth
> changing the current workflow. If we got an auto builder, or for me a quick
> way to look at patches with out having to apply them, then maybe changing
> the work flow is worth it. I’m fine with doing all the feedback on the mailing
> list.

Email based feedback works well so far as I can tell.

> 
> Thanks,
> 
> Andrew Fish
> 
> > -Jordan
> 
> 
> --
> ___
> edk2-devel mailing list
> edk2-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/edk2-devel
--
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [PATCH] MdeModulePkg/PciBusDxe: Removed unused variable assignment

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

> -Original Message-
> From: Olivier Martin [mailto:olivier.mar...@arm.com]
> Sent: Wednesday, May 27, 2015 8:35 AM
> To: Tian, Feng
> Cc: edk2-devel@lists.sourceforge.net
> Subject: [edk2] [PATCH] MdeModulePkg/PciBusDxe: Removed unused
> variable assignment
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Olivier Martin 
> ---
>  MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c
> b/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c
> index 2252235..9fa9c22 100644
> --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c
> +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c
> @@ -255,7 +255,7 @@ PciBusDriverBindingStart (
>  }
>}
> 
> -  Status = gBS->LocateProtocol (
> +  gBS->LocateProtocol (
>&gEfiIncompatiblePciDeviceSupportProtocolGuid,
>NULL,
>(VOID **) &gEfiIncompatiblePciDeviceSupport
> --
> 2.1.1
> 
> 
> --
> ___
> edk2-devel mailing list
> edk2-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/edk2-devel

--
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] shell questions

[Carsey, Jaben]

NShell is the "new" version of the EDK Shell.  That was not the first shell 
written for EFI usage.

> -Original Message-
> From: Olivier Martin [mailto:olivier.mar...@arm.com]
> Sent: Wednesday, May 27, 2015 4:22 AM
> To: edk2-devel@lists.sourceforge.net
> Subject: Re: [edk2] shell questions
> Importance: High
> 
> Yes I am guessing nshell means New Shell:
> 
> $ grep -i nshell EdkShellPkg/EdkShellPkg.dsc
>   $(EDK_SHELL_DIR)/newshell/nshell.inf
> 
> But I cannot help with the reason why it is new.
> 
> If you want a reason why there is no AArch64/ARM64 binaries in
> EdkShellBinPkg/Bin/. I can give you one.
> Because ARM architectures (AArch32 and AArch64 also sometimes named
> ARM32 and ARM64) are pretty new in the EDK(1|2) history I did not want to
> bother to fully support much EDK1 and EdkCompatiabilityPkg. My main
> blocker was UEFI SCT which was only working on EDK Shell. But since I
> upgraded UEFI SCT to also work on UEFI Shell, I had no reason to continue to
> support EDK Shell.
> In practical, I could have easily add EdkShellBinPkg/Bin/AArch64 because I can
> already build EdkShellBinPkg/FullShell/AArch64. And I am guessing
> EdkShellBinPkg/Bin/Arm/* binaries are really old...
> 
> If you want some fresh EDK Shell binaries for AArch32 and AArch64 I could
> update them.
> 
> -Original Message-
> From: Blibbet [mailto:blib...@gmail.com]
> Sent: 27 May 2015 01:18
> To: edk2-devel@lists.sourceforge.net
> Subject: [edk2] shell questions
> 
> 
> Hi,
> 
> I'm trying to write up a document on how to buid a UEFI 'boot disk', trying to
> target EFI 1.x as well as UEFI 2.x systems, for all architectures UEFI 
> supports.
> One goal is to use pre-built binaries, for sysadmins, so I don't want to 
> resort
> to telling user to compile their own binaries, if at all possible.
> 
> I don't see any docs as part of the UEFI Forum specs or RodsBooks web site.
> If I missed the proper docs, please give me an URL.
> 
> I have a few questions about which binaries to use, and some pre-EDK2
> historical usage, please.
> 
> Q0) If I want to use full (not minimal) pre-built TianoCore binaries for 
> shell, to
> use on EFI 1.x systems I need to use:
>  * edk2/trunk/edk2/EdkShellBinPkg/FullShell/Ia32/Shell_Full.efi
>  * edk2/trunk/edk2/EdkShellBinPkg/FullShell/X64/Shell_Full.efi
>  * edk2/trunk/edk2/EdkShellBinPkg/FullShell/Arm/Shell_Full.efi
>  * edk2/trunk/edk2/EdkShellBinPkg/FullShell/AArch64/Shell_Full.efi
>  * edk2/trunk/edk2/EdkShellBinPkg/FullShell/Ipf/Shell_Full.efi
> and for UEFI 2.x systems, I need to use:
>  * edk2/trunk/edk2/ShellBinPkg/UefiShell/Ia32/Shell.efi
>  * edk2/trunk/edk2/ShellBinPkg/UefiShell/X64/Shell.efi
>  * edk2/trunk/edk2/ShellBinPkg/UefiShell/Arm/Shell.efi
>  * edk2/trunk/edk2/ShellBinPkg/UefiShell/AArch64/Shell.efi
> Renamed to Shell.efi and put in it's proper ESP subdirectory. Correct?
> 
> Q1) Unlike oher archs, I don't see any
> edk2/trunk/edk2/ShellBinPkg/UfiShell built for Itanium. How does someone
> build a UEFI boot disk that works on Itanium, if there's no provided shell? 
> Did
> TianoCore codebase stop supporting Itanium binary releases, and is there an
> alternate source of Itanium binaries from Intel?
> 
> Q2) why is it called 'NShell', does N mean "New"? Newer than what, what
> was the old EFI shell called? Or is this New as in replacement for MS-DOS /
> OS/2 shell?
> 
> Q3) Why are the x86, x64, and IPF binaries for older EDK Contrib and EDK
> apparently mirrored? Both have
> Edk/Other/Maintained/Application/UefiShell, why use one tree -vs- the
> other?
> 
> edkcontrib/trunk/Edk/Other/Maintained/Application/UefiShell/bin/x64/Shel
> l_Full.efi
> edkcontrib/trunk/Edk/Other/Maintained/Application/UefiShell/bin/x64/Shel
> l.efi
> edkcontrib/trunk/Edk/Other/Maintained/Application/UefiShell/bin/ia32/She
> ll_Full.efi
> edkcontrib/trunk/Edk/Other/Maintained/Application/UefiShell/bin/ia32/She
> ll.efi
> edkcontrib/trunk/Edk/Other/Maintained/Application/UefiShell/bin/ipf/Shell
> _Full.efi
> edkcontrib/trunk/Edk/Other/Maintained/Application/UefiShell/bin/ipf/Shell
> .efi
> 
> efidevkit/trunk/Edk/Other/Maintained/Application/UefiShell/bin/x64/Shell_
> Full.efi
> efidevkit/trunk/Edk/Other/Maintained/Application/UefiShell/bin/x64/Shell.
> efi
> efidevkit/trunk/Edk/Other/Maintained/Application/UefiShell/bin/ia32/Shell
> _Full.efi
> efidevkit/trunk/Edk/Other/Maintained/Application/UefiShell/bin/ia32/Shell.
> efi
> efidevkit/trunk/Edk/Other/Maintained/Application/UefiShell/bin/ipf/Shell_
> Full.efi
> efidevkit/trunk/Edk/Other/Maintained/Application/UefiShell/bin/ipf/Shell.e
> fi
> 
> Q4) Why does some older releases (EDK, EDK Contrib, EFI Toolkit) -- and only
> ARM32 on new EDK2 releases -- have the shell called "NShell.efi"
> where later it is called "Shell.efi" (or other min/full variations)?
> Especially why only ARM32 on EDK2?
> 
> edk2/trunk/edk2/EdkShellBinPkg/Bin/Arm/NShell.efi
> 
> efi-toolkit/trunk/efi-toolkit/binaries/em64t/NShell.efi
> efi-toolkit/trunk/efi-toolkit/bin

[edk2] [PATCH] ShellPkg: Update help output for correct alphabetical

[Carsey, Jaben]

Tapan and Shumin,

Can you review this patch please?


ShellPkg: Update help output for correct alphabetical

This updates help output to put dynamic commands in correct alphabetical 
location mixed into the other commands.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey 


Help.c.patch
Description: Help.c.patch
--
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] UDK2014.IHV question

[Carsey, Jaben]

You can compile your driver in the .IHV release.  You cannot test it without a 
platform also.  You may want to get the full UDK2014 to get NT32 to test your 
driver.

-Jaben

From: tiger...@zhaoxin.com [mailto:tiger...@zhaoxin.com]
Sent: Thursday, April 02, 2015 3:10 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] UDK2014.IHV question

Hi, experts:
I have a question about UDK2014.IHV package.
I downloaded UDK2014.IHV package.

After unzip it, and using UEFI Driver wizard to produce a sample PCI driver:
MdeModulePkg\Universal\ChinaTest

Following UDK2014.IHV-ReleaseNotes.txt, it needs a PlatformPkg, such as Nt32.
So I copied a Nt32Pkg to UDK2014.IHV package.
Then I typed these cmd in cmd window:
edksetup –NT32
build -t VS2008x86 -m MdeModulePkg\Universal\ ChinaTest \ ChinaTest.inf

but many error occurred.
Because Nt32Pkg.dsc included many other package, such as : 
IntelFrameworkModulePkg.
But these other packages not exist in UDK2014.IHV.

So my question is:

1.   How to compile a single driver in UDK2014.IHV .

Best wishes,

本邮件仅针对指定的收件人发送并可能含有保密或专有内容。任何非指定收件人所为之查阅、转发或使用本信息是不被允许的。
如果您误收到本邮件，请立即告知发件人并删除本邮件及所有附件。谢谢！
The information transmitted in this e-mail is intended only for the addressee 
and may contain confidential and/or privileged material. Any review, 
retransmission, dissemination or other use of this information by persons or 
entities other than the intended recipient is prohibited. If you received this 
e-mail in error, please notify the sender immediately, and delete this e-mail 
and any attachments. Thank you.
--
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] Get DevicePath of the File Driver and do Loader

[Carsey, Jaben]

The file path is the final node in the device path, not the whole thing.  Does 
your filename have the full path or just the file path?  Where is FileName from?

-Jaben

> -Original Message-
> From: S.Vieira [mailto:jwvsan...@outlook.com]
> Sent: Friday, May 15, 2015 8:52 AM
> To: edk2-devel@lists.sourceforge.net
> Subject: [edk2] Get DevicePath of the File Driver and do Loader
> Importance: High
> 
> I need get the DevicePath of the File, then i pass the FileName (CHAR16) and
> i want get return as DevicePath to use with LoadImage...
> I can not to use Shell Protocol.
> 
> 
> VOID
> GetDevicePathFromText (IN CHAR16* FileName,IN EFI_HANDLE
> ImageHandle) {
>   EFI_GUID
>   DevicePathFromTextGUID =
> EFI_DEVICE_PATH_FROM_TEXT_PROTOCOL_GUID;
>   EFI_HANDLE
>   *handle;
>   EFI_DEVICE_PATH_FROM_TEXT_PROTOCOL
>   *DevicePathFromTextProtocol;
>   EFI_STATUS
>   Status;
>   UINTN
>   bufferSize;
>   int
>   index;
> 
>   EFI_DEVICE_PATH
>   *FilePath;
>   EFI_HANDLE
>   *LoadedDriverHandle;
> 
>   LoadedDriverHandle = NULL;
> 
>   Status = gBS->LocateHandleBuffer(ByProtocol,
> 
>   &DevicePathFromTextGUID,
>   NULL,
> 
>   &bufferSize,
> 
>   &handle
>   );
> 
>   if(!EFI_ERROR(Status))
>   {
>   Print(L"\nLocate: %r",Status);
>   for(index = 0 ;  index < bufferSize ; index++)
>   {
>   Status = gBS->OpenProtocol( handle[index],
> 
>   &DevicePathFromTextGUID,
> 
>   (void **)&DevicePathFromTextProtocol,
> 
>   ImageHandle,
> 
>   NULL,
> 
>   EFI_OPEN_PROTOCOL_BY_HANDLE_PROTOCOL
> 
>   );
>   if(EFI_ERROR(Status))
>   {
>   Print(L"\nERRO");
>   }else{
>   FilePath = DevicePathFromTextProtocol-
> >ConvertTextToDevicePath(FileName);
>   Status =
> gBS->LoadImage(FALSE,ImageHandle,FilePath,NULL,0,LoadedDriverHandle);
>   if(!EFI_ERROR(Status)){
>   Print(L"Loaded %r",Status);
> 
>   }else
>   {
>   Print(L"Loaded %r",Status);
>   }
>   }
> 
>   }
> 
>   }else
>   {
>   Print(L"\nLocate: %r",Status);
>   }
> }
> 
> 
> --
> One dashboard for servers and applications across Physical-Virtual-Cloud
> Widest out-of-the-box monitoring support with 50+ applications
> Performance metrics, stats and reports that give you Actionable Insights
> Deep dive visibility with transaction tracing using APM Insight.
> http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
> ___
> edk2-devel mailing list
> edk2-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/edk2-devel

--
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [Patch 2/2] SourceLevelDebugPkg/DebugAgentDxe: Move help info from DxeDebugAgent

[Carsey, Jaben]

Isn't having a library print information to console out a pretty significant 
violation of the principles of the UEFI spec?

-Jaben

> -Original Message-
> From: Jeff Fan [mailto:jeff@intel.com]
> Sent: Thursday, May 14, 2015 1:42 AM
> To: edk2-devel@lists.sourceforge.net
> Subject: [edk2] [Patch 2/2] SourceLevelDebugPkg/DebugAgentDxe: Move
> help info from DxeDebugAgent
> Importance: High
> 
> Now DxeDebugAgent Library instance will print help information on how to
> load DebugAgentDxe.efi in UEFI shell. But it is printed after Target connected
> to Host side. This fix is to move help info print to DebugAgentDxe module
> before Target tries to connect HOST. It could help developer to get useful
> information as early as possible.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jeff Fan 
> SourceLevelDebugPkg/DebugAgentDxe: Move help info from
> DxeDebugAgent
> 
> Now DxeDebugAgent Library instance will print help information on how to
> load DebugAgentDxe.efi in UEFI shell. But it is printed after Target connected
> to Host side. This fix is to move help info print to DebugAgentDxe module
> before Target tries to connect HOST. It could help developer to get useful
> information as early as possible.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jeff Fan 
> Cc: Ruiyu Ni 
> ---
>  SourceLevelDebugPkg/DebugAgentDxe/DebugAgentDxe.c  | 42
> +-
>  .../DebugAgent/DxeDebugAgent/DxeDebugAgentLib.c| 29 ---
>  2 files changed, 41 insertions(+), 30 deletions(-)
> 
> diff --git a/SourceLevelDebugPkg/DebugAgentDxe/DebugAgentDxe.c
> b/SourceLevelDebugPkg/DebugAgentDxe/DebugAgentDxe.c
> index a55c5eb..f5ae59f 100644
> --- a/SourceLevelDebugPkg/DebugAgentDxe/DebugAgentDxe.c
> +++ b/SourceLevelDebugPkg/DebugAgentDxe/DebugAgentDxe.c
> @@ -1,7 +1,7 @@
>  /** @file
>Initialize Debug Agent in DXE by invoking Debug Agent Library.
> 
> -Copyright (c) 2013 - 2014, Intel Corporation. All rights reserved.
> +Copyright (c) 2013 - 2015, Intel Corporation. All rights reserved.
>  This program and the accompanying materials
>  are licensed and made available under the terms and conditions of the BSD
> License
>  which accompanies this distribution.  The full text of the license may be
> found at
> @@ -16,6 +16,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY
> KIND, EITHER EXPRESS OR IMPLIED.
>  #include 
>  #include 
>  #include 
> +#include 
> 
>  EFI_EVENT   mExitBootServiceEvent;
> 
> @@ -58,11 +59,42 @@ DebugAgentDxeInitialize(  {
>EFI_STATUS  Status;
> 
> +  if (gST->ConOut != NULL) {
> +Print (L"If the Debug Port is serial port, please make sure this serial 
> port
> isn't connected by");
> +Print (L" ISA Serial driver\r\n");
> +Print (L"You could do the following steps to disconnect the serial
> port:\r\n");
> +Print (L"1: Shell> drivers\r\n");
> +Print (L"   ...\r\n");
> +Print (L"   V  VERSION  E G G #D #C DRIVER NAME 
> IMAGE
> NAME\r\n");
> +Print (L"   ==  = = = == ==
> ===
> ===\r\n");
> +Print (L"   8F 000A B - -  1 14 PCI Bus Driver  
> PciBusDxe\r\n");
> +Print (L"   91 0010 ? - -  -  - ATA Bus Driver  
> AtaBusDxe\r\n");
> +Print (L"   ...\r\n");
> +Print (L"   A7 000A B - -  1  1 ISA Serial Driver
> IsaSerialDxe\r\n");
> +Print (L"   ...\r\n");
> +Print (L"2: Shell> dh -d A7\r\n");
> +Print (L"   A7: Image(IsaSerialDxe) ImageDevPath (..9FB3-11D4-9A3A-
> 0090273FC14D))DriverBinding");
> +Print (L" ComponentName ComponentName2\r\n");
> +Print (L"Driver Name: ISA Serial Driver\r\n");
> +Print (L"Image Name : FvFile(93B80003-9FB3-11D4-9A3A-
> 0090273FC14D)\r\n");
> +Print (L"Driver Version : 000A\r\n");
> +Print (L"Driver Type: BUS\r\n");
> +Print (L"Configuration  : NO\r\n");
> +Print (L"Diagnostics: NO\r\n");
> +Print (L"Managing   :\r\n");
> +Print (L"  Ctrl[EA] : 
> PciRoot(0x0)/Pci(0x1F,0x0)/Serial(0x0)\r\n");
> +Print (L"Child[EB] :
> PciRoot(0x0)/Pci(0x1F,0x0)/Serial(0x0)/Uart(115200,8,N,1)\r\n");
> +Print (L"3: Shell> disconnect EA\r\n");
> +Print (L"4: Shell> load -nc DebugAgentDxe.efi\r\n\r\n");  }
>Status = EFI_UNSUPPORTED;
>InitializeDebugAgent (DEBUG_AGENT_INIT_DXE_LOAD, &Status, NULL);
>if (EFI_ERROR (Status)) {
>  return Status;
>}
> +  if (gST->ConOut != NULL) {
> +Print (L"Debug Agent: Initialized successfully!\r\n\r\n");  }
>//
>// Create event to disable Debug Timer interrupt when exit boot service.
>//
> @@ -98,6 +130,14 @@ DebugAgentDxeUnload (
> 
>Status = EFI_UNSUPPORTED;
>InitializeDebugAgent (DEBUG_AGENT_INIT_DXE_UNLOAD, &Status, NULL);
> +  switch (Status) {
> +  case EFI_ACCESS_DENIED:
> +Prin

Re: [edk2] [patch] ShellPkg: Add DiskInfo GUID matching to the Shell

[Carsey, Jaben]

Ok.  Committed. 17447

From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hp.com]
Sent: Thursday, May 14, 2015 9:02 AM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [patch] ShellPkg: Add DiskInfo GUID matching to the Shell
Importance: High

UNI file attached

From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Wednesday, May 13, 2015 6:00 PM
To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>
Subject: Re: [edk2] [patch] ShellPkg: Add DiskInfo GUID matching to the Shell

Looks good, but patch files don't work for the UNI file it seems.  Can you sent 
that file itself?

Reviewed-by: Jaben Carsey 
mailto:jaben.car...@intel.com>>

From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hp.com]
Sent: Wednesday, May 13, 2015 3:27 PM
To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>
Subject: [edk2] [patch] ShellPkg: Add DiskInfo GUID matching to the Shell
Importance: High

Hi Jaben,

Can you please review this patch. It adds "DiskInfo" GUID matching to the Shell 
UefiHandleParsingLib.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Samer El-Haj-Mahmoud mailto:el...@hp.com>>

Thanks,
--Samer



Samer El-Haj-Mahmoud
System Firmware Architect
HP Servers

el...@hp.com<mailto:el...@hp.com>
T +1.281.514.5973
C +1.512.659.1523
Hewlett-Packard Company
hp.com/go/proliant/uefi<http://hp.com/go/proliant/uefi>

[Description: Description: C:\Users\elhajmah\HpLogo.png]

--
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [patch] ShellPkg: Add DiskInfo GUID matching to the Shell

[Carsey, Jaben]

Looks good, but patch files don't work for the UNI file it seems.  Can you sent 
that file itself?

Reviewed-by: Jaben Carsey 

From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hp.com]
Sent: Wednesday, May 13, 2015 3:27 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [patch] ShellPkg: Add DiskInfo GUID matching to the Shell
Importance: High

Hi Jaben,

Can you please review this patch. It adds "DiskInfo" GUID matching to the Shell 
UefiHandleParsingLib.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Samer El-Haj-Mahmoud mailto:el...@hp.com>>

Thanks,
--Samer



Samer El-Haj-Mahmoud
System Firmware Architect
HP Servers

el...@hp.com
T +1.281.514.5973
C +1.512.659.1523
Hewlett-Packard Company
hp.com/go/proliant/uefi

[Description: Description: C:\Users\elhajmah\HpLogo.png]

--
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [PATCH] MdePkg: Fix PI Multi-processor PPI header file include issue

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

> -Original Message-
> From: Hao Wu [mailto:hao.a...@intel.com]
> Sent: Wednesday, May 13, 2015 5:20 AM
> To: edk2-devel@lists.sourceforge.net
> Subject: [edk2] [PATCH] MdePkg: Fix PI Multi-processor PPI header file
> include issue
> 
> Multi-processor PPI header file 'Ppi/Mpservices.h' uses a function prototype
> EFI_AP_PROCEDURE which is defined in 'Pi/PiDxeCis.h' (DXE header file).
> 
> This will cause a build fail when 'Ppi/Mpservices.h' is included in a PEI 
> module.
> 
> Since both phase support multi-processor service now, function prototype
> EFI_AP_PROCEDURE should be moved to 'Pi/PiMultiPhase.h'. The move is a
> compatible change and will not affect other codes.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Hao Wu 
> Reviewed-by: Jeff Fan 
> Reviewed-by: Liming Gao 
> ---
>  MdePkg/Include/Pi/PiDxeCis.h | 15 ---
>  MdePkg/Include/Pi/PiMultiPhase.h | 16 +++-
>  2 files changed, 15 insertions(+), 16 deletions(-)
> 
> diff --git a/MdePkg/Include/Pi/PiDxeCis.h b/MdePkg/Include/Pi/PiDxeCis.h
> index a2208df..3292809 100644
> --- a/MdePkg/Include/Pi/PiDxeCis.h
> +++ b/MdePkg/Include/Pi/PiDxeCis.h
> @@ -737,19 +737,4 @@ typedef struct {
> 
>  typedef DXE_SERVICES EFI_DXE_SERVICES;
> 
> -
> -/**
> -  The function prototype for invoking a function on an Application Processor.
> -
> -  This definition is used by the UEFI MP Serices Protocol, and the
> -  PI SMM System Table.
> -
> -  @param[in,out] Buffer  The pointer to private data buffer.
> -**/
> -typedef
> -VOID
> -(EFIAPI *EFI_AP_PROCEDURE)(
> -  IN OUT VOID  *Buffer
> -  );
> -
>  #endif
> diff --git a/MdePkg/Include/Pi/PiMultiPhase.h
> b/MdePkg/Include/Pi/PiMultiPhase.h
> index 2aa4c27..169258c 100644
> --- a/MdePkg/Include/Pi/PiMultiPhase.h
> +++ b/MdePkg/Include/Pi/PiMultiPhase.h
> @@ -1,7 +1,7 @@
>  /** @file
>Include file matches things in PI for multiple module types.
> 
> -Copyright (c) 2006 - 2013, Intel Corporation. All rights reserved.
> +Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.
>  This program and the accompanying materials are licensed and made
> available under  the terms and conditions of the BSD License that
> accompanies this distribution.
>  The full text of the license may be found at @@ -162,4 +162,18 @@ typedef
> struct {
>CHAR8 *PcdName;
>  } EFI_PCD_INFO;
> 
> +/**
> +  The function prototype for invoking a function on an Application Processor.
> +
> +  This definition is used by the UEFI MP Serices Protocol, and the  PI
> + SMM System Table.
> +
> +  @param[in,out] Buffer  The pointer to private data buffer.
> +**/
> +typedef
> +VOID
> +(EFIAPI *EFI_AP_PROCEDURE)(
> +  IN OUT VOID  *Buffer
> +  );
> +
>  #endif
> --
> 1.9.5.msysgit.0
> 
> 
> --
> One dashboard for servers and applications across Physical-Virtual-Cloud
> Widest out-of-the-box monitoring support with 50+ applications
> Performance metrics, stats and reports that give you Actionable Insights
> Deep dive visibility with transaction tracing using APM Insight.
> http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
> ___
> edk2-devel mailing list
> edk2-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/edk2-devel

--
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [PATCH] ShellPkg: Fix buffer overflow issue in 'map' command.

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

Was this found by an actual buffer overflow occurring or by an automated test?


> -Original Message-
> From: Qiu, Shumin
> Sent: Friday, May 08, 2015 6:03 AM
> To: edk2-devel@lists.sourceforge.net; Carsey, Jaben
> Cc: Yao, Jiewen
> Subject: RE: [edk2] [PATCH] ShellPkg: Fix buffer overflow issue in 'map'
> command.
> Importance: High
> 
> Hi Jiewen,
> You are right. Patch updated.
> 
> -Shumin
> 
> -Original Message-
> From: Yao, Jiewen [mailto:jiewen@intel.com]
> Sent: Friday, May 08, 2015 4:44 PM
> To: edk2-devel@lists.sourceforge.net; Carsey, Jaben
> Subject: Re: [edk2] [PATCH] ShellPkg: Fix buffer overflow issue in 'map'
> command.
> 
> Hello
> The 2nd parameter should be: The maximum number of Destination Unicode 
> char, including terminating null char.
> 
> Should we use "(StrSize(Specific) + sizeof(CHAR16))/sizeof(CHAR16)" 
> for 2nd parameter?
> 
> Thank you
> Yao Jiewen
> 
> 
> -Original Message-----
> From: Qiu Shumin [mailto:shumin@intel.com]
> Sent: Friday, May 08, 2015 4:27 PM
> To: edk2-devel@lists.sourceforge.net; Carsey, Jaben
> Subject: [edk2] [PATCH] ShellPkg: Fix buffer overflow issue in 'map'
> command.
> 
> This patch replace 'StrnCat' with 'StrnCatS' to avoid the buffer 
> overflow in 'map.c'.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Qiu Shumin 
> ---
>  ShellPkg/Library/UefiShellLevel2CommandsLib/Map.c | 24
> +++
>  1 file changed, 20 insertions(+), 4 deletions(-)
> 
> diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Map.c
> b/ShellPkg/Library/UefiShellLevel2CommandsLib/Map.c
> index 087daac..16345d3 100644
> --- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Map.c
> +++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Map.c
> @@ -2,7 +2,7 @@
>Main file for map shell level 2 command.
> 
>(C) Copyright 2013-2015 Hewlett-Packard Development Company, 
> L.P.
> -  Copyright (c) 2009 - 2014, Intel Corporation. All rights 
> reserved.
> +  Copyright (c) 2009 - 2015, Intel Corporation. All rights 
> + reserved.
>This program and the accompanying materials
>are licensed and made available under the terms and conditions of 
> the BSD License
>which accompanies this distribution.  The full text of the license 
> may be found at @@ -224,6 +224,8 @@ MappingListHasType(
>)
>  {
>CHAR16 *NewSpecific;
> +  RETURN_STATUS  Status;
> +
>//
>// specific has priority
>//
> @@ -233,7 +235,11 @@ MappingListHasType(
>return FALSE;
>  }
>  if (NewSpecific[StrLen(NewSpecific)-1] != L':') {
> -  StrnCat(NewSpecific, L":", 2);
> +  Status = StrnCatS(NewSpecific, StrSize(Specific) + 
> + sizeof(CHAR16), L":",
> StrLen(L":"));
> +  if (EFI_ERROR (Status)) {
> +FreePool(NewSpecific);
> +return FALSE;
> +  }
>  }
> 
>  if (SearchList(MapList, NewSpecific, NULL, TRUE, FALSE, L";")) { 
> @@ -
> 875,13 +881,18 @@ AddMappingFromMapping(
>CONST EFI_DEVICE_PATH_PROTOCOL  *DevPath;
>EFI_STATUS  Status;
>CHAR16  *NewSName;
> +  RETURN_STATUS   StrRetStatus;
> 
>NewSName = AllocateCopyPool(StrSize(SName) + sizeof(CHAR16), 
> SName);
>if (NewSName == NULL) {
>  return (SHELL_OUT_OF_RESOURCES);
>}
>if (NewSName[StrLen(NewSName)-1] != L':') {
> -StrnCat(NewSName, L":", 2);
> +StrRetStatus = StrnCatS(NewSName, StrSize(SName) + 
> + sizeof(CHAR16),
> L":", StrLen(L":"));
> +if (EFI_ERROR(StrRetStatus)) {
> +  FreePool(NewSName);
> +  return ((SHELL_STATUS) (StrRetStatus & (~MAX_BIT)));
> +}
>}
> 
>if (!IsNumberLetterOnly(NewSName, StrLen(NewSName)-1)) { @@ -927,13
> +938,18 @@ AddMappingFromHandle(
>EFI_DEVICE_PATH_PROTOCOL  *DevPath;
>EFI_STATUSStatus;
>CHAR16*NewSName;
> +  RETURN_STATUS StrRetStatus;
> 
>NewSName = AllocateCopyPool(StrSize(SName) + sizeof(CHAR16), 
> SName);
>if (NewSName == NULL) {
>  return (SHELL_OUT_OF_RESOURCES);
>}
>if (NewSName[StrLen(NewSName)-1] != L':') {
> -StrnCat(NewSName, L":", 2);
> +StrRetStatus = StrnCatS(NewSName, StrSize(SName) + 
> + sizeof(CHAR16),
> L":", StrLen(L":"));
> +if (EFI_ERROR(StrRetStatus)) {
> +  FreePool(NewSName

Re: [edk2] [Patch 3/4] ShellPkg: Update Shell MemMap command to show PersistentMemory range

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

-Original Message-
From: Liming Gao [mailto:liming@intel.com] 
Sent: Monday, April 27, 2015 3:58 AM
To: edk2-devel@lists.sourceforge.net
Cc: liminggaoliming@intel.com
Subject: [edk2] [Patch 3/4] ShellPkg: Update Shell MemMap command to show 
PersistentMemory range
Importance: High

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao liming@intel.com
Reviewed-by: Star Zeng 
Signed-off-by: Liming Gao 
---
 ShellPkg/Library/UefiShellDebug1CommandsLib/MemMap.c | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/MemMap.c 
b/ShellPkg/Library/UefiShellDebug1CommandsLib/MemMap.c
index 598c04a..4e35760 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/MemMap.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/MemMap.c
@@ -22,10 +22,11 @@ STATIC CONST CHAR16 NameEfiLoaderData[]  = 
L"LoaderData";
 STATIC CONST CHAR16 NameEfiBootServicesCode[]= L"BootServiceCode";
 STATIC CONST CHAR16 NameEfiBootServicesData[]= L"BootServiceData";
 STATIC CONST CHAR16 NameEfiRuntimeServicesCode[] = L"RuntimeCode";
 STATIC CONST CHAR16 NameEfiRuntimeServicesData[] = L"RuntimeData";
 STATIC CONST CHAR16 NameEfiConventionalMemory[]  = L"Available";
+STATIC CONST CHAR16 NameEfiPersistentMemory[]= L"Persistent";
 STATIC CONST CHAR16 NameEfiUnusableMemory[]  = L"UnusableMemory";
 STATIC CONST CHAR16 NameEfiACPIReclaimMemory[]   = L"ACPIReclaimMemory";
 STATIC CONST CHAR16 NameEfiACPIMemoryNVS[]   = L"ACPIMemoryNVS";
 STATIC CONST CHAR16 NameEfiMemoryMappedIO[]  = L"MemoryMappedIO";
 STATIC CONST CHAR16 NameEfiMemoryMappedIOPortSpace[] = 
L"MemoryMappedIOPortSpace";
@@ -205,10 +206,15 @@ ShellCommandRunMemMap (
 case EfiConventionalMemory:
   ShellPrintHiiEx(-1, -1, NULL, (EFI_STRING_ID)(!Sfo?STRING_TOKEN 
(STR_MEMMAP_LIST_ITEM):STRING_TOKEN (STR_MEMMAP_LIST_ITEM_SFO)), 
gShellDebug1HiiHandle, NameEfiConventionalMemory, 
((EFI_MEMORY_DESCRIPTOR*)Walker)->PhysicalStart, 
((EFI_MEMORY_DESCRIPTOR*)Walker)->PhysicalStart+MultU64x64(SIZE_4KB,((EFI_MEMORY_DESCRIPTOR*)Walker)->NumberOfPages)-1,
 ((EFI_MEMORY_DESCRIPTOR*)Walker)->NumberOfPages, 
((EFI_MEMORY_DESCRIPTOR*)Walker)->Attribute);
   AvailPages += ((EFI_MEMORY_DESCRIPTOR*)Walker)->NumberOfPages;
   TotalPages += ((EFI_MEMORY_DESCRIPTOR*)Walker)->NumberOfPages;
   break;
+case EfiPersistentMemory:
+  ShellPrintHiiEx(-1, -1, NULL, (EFI_STRING_ID)(!Sfo?STRING_TOKEN 
(STR_MEMMAP_LIST_ITEM):STRING_TOKEN (STR_MEMMAP_LIST_ITEM_SFO)), 
gShellDebug1HiiHandle, NameEfiPersistentMemory, 
((EFI_MEMORY_DESCRIPTOR*)Walker)->PhysicalStart, 
((EFI_MEMORY_DESCRIPTOR*)Walker)->PhysicalStart+MultU64x64(SIZE_4KB,((EFI_MEMORY_DESCRIPTOR*)Walker)->NumberOfPages)-1,
 ((EFI_MEMORY_DESCRIPTOR*)Walker)->NumberOfPages, 
((EFI_MEMORY_DESCRIPTOR*)Walker)->Attribute);
+  AvailPages += ((EFI_MEMORY_DESCRIPTOR*)Walker)->NumberOfPages;
+  TotalPages += ((EFI_MEMORY_DESCRIPTOR*)Walker)->NumberOfPages;
+  break;
 case EfiUnusableMemory:
   ShellPrintHiiEx(-1, -1, NULL, (EFI_STRING_ID)(!Sfo?STRING_TOKEN 
(STR_MEMMAP_LIST_ITEM):STRING_TOKEN (STR_MEMMAP_LIST_ITEM_SFO)), 
gShellDebug1HiiHandle, !Sfo?NameEfiUnusableMemoryShort:NameEfiUnusableMemory, 
((EFI_MEMORY_DESCRIPTOR*)Walker)->PhysicalStart, 
((EFI_MEMORY_DESCRIPTOR*)Walker)->PhysicalStart+MultU64x64(SIZE_4KB,((EFI_MEMORY_DESCRIPTOR*)Walker)->NumberOfPages)-1,
 ((EFI_MEMORY_DESCRIPTOR*)Walker)->NumberOfPages, 
((EFI_MEMORY_DESCRIPTOR*)Walker)->Attribute);
   UnusableMemoryPages += 
((EFI_MEMORY_DESCRIPTOR*)Walker)->NumberOfPages;
   break;
 case EfiACPIReclaimMemory:
-- 
1.9.5.msysgit.0


--
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

--
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/list

[edk2] [PATCH] ShellPkg: Remove memory leak when printing help and there are dynamic commands installed

[Carsey, Jaben]

Shumin,

Can you review this?

ShellPkg: Remove memory leak when printing help and there are dynamic commands 
installed

The list of handles needs to be freed.


Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey 
mailto:jaben.car...@intel.com>>



Help_memory leak.patch
Description: Help_memory leak.patch
--
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [MdePkg] UefiDevicePathLib enhancements. IsDevicePathEndIsDevicePathEndInstance

[Carsey, Jaben]

Agree.

That would look like a good change.

-Original Message-
From: Andrew Fish [mailto:af...@apple.com] 
Sent: Wednesday, April 22, 2015 6:09 PM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [MdePkg] UefiDevicePathLib enhancements. 
IsDevicePathEndIsDevicePathEndInstance
Importance: High


> On Apr 22, 2015, at 5:53 PM, Carsey, Jaben  wrote:
> 
> I was thinking that maybe we add both good error handling and a more robust 
> check.  I know that sometimes an ASSERT if you are using a debug mode is 
> faster to find, but in release mode we don’t want to just ignore it…
> 

You can do both. There is not much you can do in a released build for a 
function that returns a BOOLEAN.

BOOLEAN
EFIAPI
IsDevicePathEnd (
 IN CONST VOID  *Node
 )
{
 ASSERT (Node != NULL);
 if (DevicePathNodeLength (Node) < sizeof (EFI_DEVICE_PATH_PROTOCOL)) {
   ASSERT (FALSE);
   return TRUE;
 }
 return (BOOLEAN) (IsDevicePathEndType (Node) && DevicePathSubType(Node) == 
END_ENTIRE_DEVICE_PATH_SUBTYPE);
}

Thanks,

Andrew Fish

> 
> -Original Message-
> From: Andrew Fish [mailto:af...@apple.com] 
> Sent: Wednesday, April 22, 2015 5:49 PM
> To: edk2-devel@lists.sourceforge.net
> Subject: Re: [edk2] [MdePkg] UefiDevicePathLib enhancements. 
> IsDevicePathEndIsDevicePathEndInstance
> Importance: High
> 
> 
>> On Apr 22, 2015, at 5:35 PM, Carsey, Jaben  wrote:
>> 
>> Andrew,
>> 
>> Do you think these things happen more in debugging or product?  Would some 
>> ASSERT or DEBUG_CODE() help developers know that they've got something wrong 
>> happening?
>> 
> 
> I’m fine with adding an ASSERT, but I would rather error check on the release 
> builds. You can get hangs in the DXE Core, and in the BDS. I think this code 
> should be more robust as device paths are passed in or come from environment 
> variables. Some one could be debugging a driver on a released system for 
> example. Or an OS loader, or EFI tool could pass a malformed device path.  
> 
> Also defening against malformed data is good security practice. 
> 
> 
> Thanks,
> 
> Andrew Fish
> 
> PS My crash was a hang in the DXE Core as I was trying to install a device 
> path protocol that had not been initialized.
> 
>> 
>> -Jaben
>> 
>> -Original Message-
>> From: Andrew Fish [mailto:af...@apple.com] 
>> Sent: Wednesday, April 22, 2015 3:38 PM
>> To: edk2-devel@lists.sourceforge.net
>> Subject: [edk2] [MdePkg] UefiDevicePathLib enhancements. 
>> IsDevicePathEndIsDevicePathEndInstance
>> 
>> I’d like to propose that  IsDevicePathEnd(), IsDevicePathEndType(), and 
>> IsDevicePathEndInstance() get some additional error checking to improve 
>> robustness. These routines are often used in loops and a malformed device 
>> path can get stuck in one of these loops. If the device path node length is 
>> zero the code will get stuck retesting the same malformed device path node 
>> in an infinite loop. 
>> 
>> I’d like to propose that IsDevicePathEnd (and related functions) check the 
>> device path node length and return TRUE if the length is not a valid length. 
>> 
>> BOOLEAN
>> EFIAPI
>> IsDevicePathEnd (
>> IN CONST VOID  *Node
>> )
>> {
>> ASSERT (Node != NULL);
>> if (DevicePathNodeLength (Node) < sizeof (EFI_DEVICE_PATH_PROTOCOL)) {
>>   return TRUE;
>> }
>> return (BOOLEAN) (IsDevicePathEndType (Node) && DevicePathSubType(Node) == 
>> END_ENTIRE_DEVICE_PATH_SUBTYPE);
>> }
>> 
>> Thanks,
>> 
>> Andrew Fish
>> --
>> BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
>> Develop your own process in accordance with the BPMN 2 standard
>> Learn Process modeling best practices with Bonita BPM through live exercises
>> http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
>> source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
>> ___
>> edk2-devel mailing list
>> edk2-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/edk2-devel
>> --
>> BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
>> Develop your own process in accordance with the BPMN 2 standard
>> Learn Process modeling best practices with Bonita BPM through live exercises
>> http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
>> source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_S

Re: [edk2] [MdePkg] UefiDevicePathLib enhancements. IsDevicePathEndIsDevicePathEndInstance

[Carsey, Jaben]

I was thinking that maybe we add both good error handling and a more robust 
check.  I know that sometimes an ASSERT if you are using a debug mode is faster 
to find, but in release mode we don’t want to just ignore it...


-Original Message-
From: Andrew Fish [mailto:af...@apple.com] 
Sent: Wednesday, April 22, 2015 5:49 PM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [MdePkg] UefiDevicePathLib enhancements. 
IsDevicePathEndIsDevicePathEndInstance
Importance: High


> On Apr 22, 2015, at 5:35 PM, Carsey, Jaben  wrote:
> 
> Andrew,
> 
> Do you think these things happen more in debugging or product?  Would some 
> ASSERT or DEBUG_CODE() help developers know that they've got something wrong 
> happening?
> 

I’m fine with adding an ASSERT, but I would rather error check on the release 
builds. You can get hangs in the DXE Core, and in the BDS. I think this code 
should be more robust as device paths are passed in or come from environment 
variables. Some one could be debugging a driver on a released system for 
example. Or an OS loader, or EFI tool could pass a malformed device path.  

Also defening against malformed data is good security practice. 


Thanks,

Andrew Fish

PS My crash was a hang in the DXE Core as I was trying to install a device path 
protocol that had not been initialized.

> 
> -Jaben
> 
> -Original Message-
> From: Andrew Fish [mailto:af...@apple.com] 
> Sent: Wednesday, April 22, 2015 3:38 PM
> To: edk2-devel@lists.sourceforge.net
> Subject: [edk2] [MdePkg] UefiDevicePathLib enhancements. 
> IsDevicePathEndIsDevicePathEndInstance
> 
> I’d like to propose that  IsDevicePathEnd(), IsDevicePathEndType(), and 
> IsDevicePathEndInstance() get some additional error checking to improve 
> robustness. These routines are often used in loops and a malformed device 
> path can get stuck in one of these loops. If the device path node length is 
> zero the code will get stuck retesting the same malformed device path node in 
> an infinite loop. 
> 
> I’d like to propose that IsDevicePathEnd (and related functions) check the 
> device path node length and return TRUE if the length is not a valid length. 
> 
> BOOLEAN
> EFIAPI
> IsDevicePathEnd (
>  IN CONST VOID  *Node
>  )
> {
>  ASSERT (Node != NULL);
>  if (DevicePathNodeLength (Node) < sizeof (EFI_DEVICE_PATH_PROTOCOL)) {
>return TRUE;
>  }
>  return (BOOLEAN) (IsDevicePathEndType (Node) && DevicePathSubType(Node) == 
> END_ENTIRE_DEVICE_PATH_SUBTYPE);
> }
> 
> Thanks,
> 
> Andrew Fish
> --
> BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
> Develop your own process in accordance with the BPMN 2 standard
> Learn Process modeling best practices with Bonita BPM through live exercises
> http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
> source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
> ___
> edk2-devel mailing list
> edk2-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/edk2-devel
> --
> BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
> Develop your own process in accordance with the BPMN 2 standard
> Learn Process modeling best practices with Bonita BPM through live exercises
> http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
> source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
> ___
> edk2-devel mailing list
> edk2-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/edk2-devel


--
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
--
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [MdePkg] UefiDevicePathLib enhancements. IsDevicePathEndIsDevicePathEndInstance

[Carsey, Jaben]

Andrew,

Do you think these things happen more in debugging or product?  Would some 
ASSERT or DEBUG_CODE() help developers know that they've got something wrong 
happening?


-Jaben

-Original Message-
From: Andrew Fish [mailto:af...@apple.com] 
Sent: Wednesday, April 22, 2015 3:38 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [MdePkg] UefiDevicePathLib enhancements. 
IsDevicePathEndIsDevicePathEndInstance

I’d like to propose that  IsDevicePathEnd(), IsDevicePathEndType(), and 
IsDevicePathEndInstance() get some additional error checking to improve 
robustness. These routines are often used in loops and a malformed device path 
can get stuck in one of these loops. If the device path node length is zero the 
code will get stuck retesting the same malformed device path node in an 
infinite loop. 

I’d like to propose that IsDevicePathEnd (and related functions) check the 
device path node length and return TRUE if the length is not a valid length. 

BOOLEAN
EFIAPI
IsDevicePathEnd (
  IN CONST VOID  *Node
  )
{
  ASSERT (Node != NULL);
  if (DevicePathNodeLength (Node) < sizeof (EFI_DEVICE_PATH_PROTOCOL)) {
return TRUE;
  }
  return (BOOLEAN) (IsDevicePathEndType (Node) && DevicePathSubType(Node) == 
END_ENTIRE_DEVICE_PATH_SUBTYPE);
}

Thanks,

Andrew Fish
--
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
--
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [PATCH] ShellPkg: Remove "ProtocolGuid" from the string for protocol names

[Carsey, Jaben]

Tapan,

That makes sense.  See updated UNI.

What do you think about "EfiGlobalVariable" and "EFISystemPartition".  I didn't 
change these as they have been around for a while and I worry about eliminating 
someone's functionality.

-Jaben

From: Shah, Tapan [mailto:tapands...@hp.com]
Sent: Wednesday, April 22, 2015 10:53 AM
To: Carsey, Jaben
Cc: edk2-devel@lists.sourceforge.net
Subject: RE: [PATCH] ShellPkg: Remove "ProtocolGuid" from the string for 
protocol names
Importance: High

Jaben,
   Can you also remove "Efi" prefix for those tokens?

From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Wednesday, April 22, 2015 12:26 PM
To: Shah, Tapan
Cc: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>; 
Carsey, Jaben
Subject: [PATCH] ShellPkg: Remove "ProtocolGuid" from the string for protocol 
names

Tapan,

Can you review this?

Note: I attached the UNI without a patch since this is the only file changed 
and they don't "diff" properly.

ShellPkg: Remove "ProtocolGuid" from the string for protocol names

Some protocols still had this at the end of protocol name.  remove to 
standardize.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey 
mailto:jaben.car...@intel.com>>


UefiHandleParsingLib.uni
Description: UefiHandleParsingLib.uni
--
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

[edk2] [PATCH] ShellPkg: Remove "ProtocolGuid" from the string for protocol names

[Carsey, Jaben]

Tapan,

Can you review this?

Note: I attached the UNI without a patch since this is the only file changed 
and they don't "diff" properly.

ShellPkg: Remove "ProtocolGuid" from the string for protocol names

Some protocols still had this at the end of protocol name.  remove to 
standardize.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey 


UefiHandleParsingLib.uni
Description: UefiHandleParsingLib.uni
--
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] Disconnect a driver without to use Shell command

[Carsey, Jaben]

If you read the shell code for the "disconnect" command you can see how to 
disconnect only a single command based on it's EFI_HANDLE.

ShellPkg\Library\UefiShellDriver1CommandsLib\Disconnect.c

> -Original Message-
> From: KSilva [mailto:kaleb.si...@iatecam.org.br]
> Sent: Wednesday, April 22, 2015 8:34 AM
> To: edk2-devel@lists.sourceforge.net
> Subject: [edk2] Disconnect a driver without to use Shell command
> Importance: High
> 
> I am developing a UEFI application and I need to disconnect the driver (Sata
> Controller), without to use the Shell commands.
> 
> I can to disconnect all drivers using the function DisconnectController().
> 
> Thank's
> 
> 
> --
> BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop
> your own process in accordance with the BPMN 2 standard Learn Process
> modeling best practices with Bonita BPM through live exercises
> http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual-
> event?utm_
> source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_camp
> aign=VA_SF
> ___
> edk2-devel mailing list
> edk2-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/edk2-devel

--
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [PATCH] ShellPkg: add more info to function block.

[Carsey, Jaben]

I don’t mind making the changes to the commit message. 

Per your other thoughts: I think that if someone is expected to do something 
with an email, then CCing that person is insufficient.  A CC is for a Carbon 
Copy in old lingo.  I feel that this is equivalent to a FYI with no action 
required.  If I want someone to take action, then I want to make that clear.

-Jaben

> -Original Message-
> From: Justen, Jordan L
> Sent: Tuesday, April 21, 2015 3:36 PM
> To: Carsey, Jaben; Qiu, Shumin
> Cc: edk2-devel@lists.sourceforge.net
> Subject: Re: [edk2] [PATCH] ShellPkg: add more info to function block.
> Importance: High
> 
> On 2015-04-21 13:13:49, Carsey, Jaben wrote:
> >Shumin,
> >
> >Can you review this?
> 
> What do you think about my advise to Eric here?
> http://permalink.gmane.org/gmane.comp.bios.tianocore.devel/13854
> 
> (Regarding To, Cc and asking for a review in patch emails.)
> 
> >ShellPkg: add more info to function block.
> 
> I think this updates the comments for GetHandleListByProtocol and
> GetHandleListByProtocolList, right? Maybe the function names should be
> mentioned in the commit message?
> 
> What about something like?
> 
> ShellPkg/HandleParsingLib: Caller should free memory from 2 functions
> 
> Add a comment for GetHandleListByProtocol and
> GetHandleListByProtocolList to tell the caller they are responsible for 
> freeing
> the returned memory.
> 
> >Signed-off-by: Jaben Carsey 
> 
> Contributed-under is misssing.
> 
> -Jordan
--
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

[edk2] [PATCH] ShellPkg: add more info to function block.

[Carsey, Jaben]

Shumin,

Can you review this?

ShellPkg: add more info to function block.

Signed-off-by: Jaben Carsey 


HandleParsingLib_comment.patch
Description: HandleParsingLib_comment.patch
--
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] AutoLoad .EFI

[Carsey, Jaben]

Sorry, but there is no way to convert that without use of the shell spec.  you 
can use the Appendix to do standard based conversion and do the code yourself 
and not use the shell binary.

This seems like it would be a lot easier to just use the shell though...

> -Original Message-
> From: S.Vieira [mailto:jwvsan...@outlook.com]
> Sent: Monday, April 20, 2015 5:41 AM
> To: edk2-devel@lists.sourceforge.net
> Subject: Re: [edk2] AutoLoad .EFI
> Importance: High
> 
> Hi Carsey.
> So...
> 
> I saw the Load.c code (
> UDK2014.SP1/ShellPkg/Library/UefiSHellLevel2COmmandsLib/Load.c)
> 
> LoadDriver(
>   IN CONST CHAR16   *FileName,
>   IN CONST BOOLEAN  Connect
>   )
> {
> 
>
>
>
> 
>//Convert to DEVICE_PATH
> 
>FilePath = gEfiShellProtocol->GetDevicePathFromFilePath(FileName);
> 
>...
>...
>...
>   Status = gBS->LoadImage(
> FALSE,
> gImageHandle,
> FilePath,
> NULL,
> 0,
> &LoadedDriverHandle);
> 
> 
> }
> 
> 
> My question is:
> 
> How can i convert CHAR16 to DevicePath using Protocol of the UEFI Spec,
> without SHELL Spec ?
> 
> 
> I thought in to use any function of the DEVICE_PATH_PROTOCOL, but doesn't
> worked!
> 
> 
> Can you help me?
> 
> Att.
> Vieira
> 
> 
> --
> BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop
> your own process in accordance with the BPMN 2 standard Learn Process
> modeling best practices with Bonita BPM through live exercises
> http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual-
> event?utm_
> source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_camp
> aign=VA_SF
> ___
> edk2-devel mailing list
> edk2-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/edk2-devel

--
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] AutoLoad .EFI

[Carsey, Jaben]

gBS->LoadImage() then gBS->StartImage() in your application can load and start 
any image.  How will the application .EFI find the driver .EFI file?

-Jaben

> -Original Message-
> From: S.Vieira [mailto:jwvsan...@outlook.com]
> Sent: Friday, April 17, 2015 11:17 AM
> To: edk2-devel@lists.sourceforge.net
> Subject: [edk2] AutoLoad .EFI
> Importance: High
> 
> I am trying to load myDriver.efi automatically with other *.EFI
> 
> The objective is to do load whitout SHELL COMMAND.
> 
> In shell , i have which put the command:
> 
> Shell> load myDriver.efi
> 
> And i want do it with my Application.efi
> 
> Just
> 
> Shell > Application.efi
> 
> and the Application.efi will to load the file myDriver.efi
> 
> Att.
> 
> S.Vieira
> 
> 
> --
> BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop
> your own process in accordance with the BPMN 2 standard Learn Process
> modeling best practices with Bonita BPM through live exercises
> http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual-
> event?utm_
> source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_camp
> aign=VA_SF
> ___
> edk2-devel mailing list
> edk2-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/edk2-devel

--
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [PATCH] ShellPkg/UefiShellLevel2CommandsLib: Handle the returned value

[Carsey, Jaben]

Excellent change.  I really support removing ASSERT statements.

Reviewed-by: Jaben Carsey 

From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: Wednesday, April 15, 2015 10:41 AM
To: Carsey, Jaben
Cc: edk2-devel@lists.sourceforge.net
Subject: [PATCH] ShellPkg/UefiShellLevel2CommandsLib: Handle the returned value
Importance: High

Dear ShellPkg maintainer,

Please find the attached patch that fixes the following error:

If this function fails in release build then the error was
not handled and SourceHandle was not valid.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin 
mailto:olivier.mar...@arm.com>>
Regards,
Olivier

-- IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered 
in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, 
Registered in England & Wales, Company No: 2548782
--
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] EFI_SHELL_PROTOCOL installed on every App's imagehandle?

[Carsey, Jaben]

EFI_SHELL_PROTOCOL is installed onto the UEFI Shell’s handle, not your 
application.  If you have nested copies of the UEFI Shell you may have multiple 
copies of the protocol.

You can find a copy from like this also:
Status = gBS->LocateProtocol(
  &gEfiShellProtocolGuid,
  NULL,
  (VOID **)&
 );


-Jaben

From: Tim Lewis [mailto:tim.le...@insyde.com]
Sent: Thursday, April 09, 2015 9:10 AM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] EFI_SHELL_PROTOCOL installed on every App's imagehandle?
Importance: High

There is a single global instance of the EFI_SHELL_PROTOCOL. Use HandleProtocol.

Tim

From: tiger...@zhaoxin.com 
[mailto:tiger...@zhaoxin.com]
Sent: Wednesday, April 08, 2015 11:42 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] EFI_SHELL_PROTOCOL installed on every App's imagehandle?

Hi, experts:
I have a question about UEFI Shell App:

1.   UEFI App’s EntryPoint usually is as below:

UefiMain (

  IN EFI_HANDLEImageHandle,

  IN EFI_SYSTEM_TABLE  *SystemTable

  )



When launches App at Shell command prompt:

EFI_LOADED_IMAGE_PROTOCOL / EFI_SHELL_PARAMETERS_PROTOCOL will be installed on 
ImageHandle!



So:

How about EFI_SHELL_PROTOCOL?

Would it be also installed on ImageHandle?



I tried to :

  Status = gBS->OpenProtocol(

ImageHandle,

&gEfiShellProtocolGuid,

(VOID **)&pTstEfiShellProtocol,

ImageHandle,

NULL,

EFI_OPEN_PROTOCOL_GET_PROTOCOL

   );



But failed, and Status = EFI_UNSUPPORTED !

My Shell version is: (ver cmd in shell prompt)
UEFI Interactive Shell v2.1


Best wishes,


本邮件仅针对指定的收件人发送并可能含有保密或专有内容。任何非指定收件人所为之查阅、转发或使用本信息是不被允许的。
如果您误收到本邮件，请立即告知发件人并删除本邮件及所有附件。谢谢！
The information transmitted in this e-mail is intended only for the addressee 
and may contain confidential and/or privileged material. Any review, 
retransmission, dissemination or other use of this information by persons or 
entities other than the intended recipient is prohibited. If you received this 
e-mail in error, please notify the sender immediately, and delete this e-mail 
and any attachments. Thank you.
--
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] Downloading a file from the network before starting BDS - TPL issue

[Carsey, Jaben]

I think you're right that there is no ideal event for your purpose.

I don't know what the guaranteed behavior is for BDS and DRIVER variables.  
What about using BOOT variables to launch your app?  This would also mean 
you're running at TPL_APPLICATION.

From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: Tuesday, April 07, 2015 11:18 AM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] Downloading a file from the network before starting BDS - 
TPL issue

The network stack is guarantee to be loaded (but not started) before my ideal 
event (which is before the EFI OS Loader is started).
The EFI OS Loader is likely to be loaded from the EFI System partition that 
might not have any link with the network stack.

And ideally I would like this ideal event to be the same when my ACPI/FDT file 
is loaded from any other supported media (eg: a removable device).


From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: 07 April 2015 19:07
To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>
Subject: Re: [edk2] Downloading a file from the network before starting BDS - 
TPL issue

Is the network stack guaranteed to be installed before your ideal event or are 
you doing the install of it?

-Jaben

From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: Tuesday, April 07, 2015 10:31 AM
To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>
Subject: [edk2] Downloading a file from the network before starting BDS - TPL 
issue
Importance: High

Hello,
I am trying to solve a TPL issue...

Use Case: Download ACPI tables (actually it is the Device Tree but the 
principle is the same) from the network before BDS is started for enabling 
developers to work on his ACPI/FDT tables on his host machine. The path of the 
file is defined by a UEFI Device Path.

My current design was to make the ACPI/FDT Platform driver waiting for the PI 
signal EndOfDxe 
(https://github.com/tianocore/edk2/blob/master/EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatform.c#L124).
 And to download the file(s) when this event is signalled 
(https://github.com/tianocore/edk2/blob/master/EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatform.c#L204).

The issue with this design is the EndOfDxe event is called at TPL_CALLBACK. And 
the DHCP & TFTP stack cannot be initialized at TPL_CALLBACK 
(https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c#L824).

I can see few solutions to solve my issue but I do not like none of them :(:

-  Solution A: Encapsulate the use case in an EFI application/Driver 
that would be invoked by the user in BDS (either in the EFI Shell or as a 
Driver boot entry)
Drawback: it means the user has to do a specific action for this use case.



-  Solution B: Replace EnfOfDxe event to use a dummy EFI protocol that 
would be installed by the BDS

Drawback: it means the mechanism must be implemented in every BDS. While I am 
looking for a generic solution.



-  Solution C: Return an error saying the UEFI specification does not 
allow this use case.

Drawback: So what is the alternative? Changing the spec?



-  Solution D: Change my implementation to download a file from TFTP 
and make the implementation non-blocking/asynchronous when called at 
TPL_CALLBACK.

Drawback: it makes the implementation much more complicated to maintain. And I 
cannot guarantee the file is downloaded when the BDS is started.

Any comment/suggestion?

Thanks,
Olivier

-- IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered 
in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, 
Registered in England & Wales, Company No: 2548782

-- IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered 
in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, 
Registered in England & Wales, Company No: 2548782
--
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live ex

Re: [edk2] ShellPkg: fix mv and cp command related issues

[Carsey, Jaben]

17129

Reviewed-by: Jaben Carsey 

From: Shah, Tapan [mailto:tapands...@hp.com]
Sent: Tuesday, April 07, 2015 12:10 PM
To: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: ShellPkg: fix mv and cp command related issues
Importance: High

Jaben,
   Can you review the attached diff file with following changes?

Thanks,
Tapan


ShellPkg: fix mv and cp command related issues

1.   mv deletes file/directory when trying to move it to non-existing file 
system.

2.   mv causes RSOD in system when trying to move same file at the same 
location.

3.   Refactor mv and cp command with command name passed-in when copying a 
single file to destination location and remove redundant move status error 
message when file failed to move across file system.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off by: Tapan Shah mailto:tapands...@hp.com>>

--
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] Downloading a file from the network before starting BDS - TPL issue

[Carsey, Jaben]

Is the network stack guaranteed to be installed before your ideal event or are 
you doing the install of it?

-Jaben

From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: Tuesday, April 07, 2015 10:31 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] Downloading a file from the network before starting BDS - TPL 
issue
Importance: High

Hello,
I am trying to solve a TPL issue...

Use Case: Download ACPI tables (actually it is the Device Tree but the 
principle is the same) from the network before BDS is started for enabling 
developers to work on his ACPI/FDT tables on his host machine. The path of the 
file is defined by a UEFI Device Path.

My current design was to make the ACPI/FDT Platform driver waiting for the PI 
signal EndOfDxe 
(https://github.com/tianocore/edk2/blob/master/EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatform.c#L124).
 And to download the file(s) when this event is signalled 
(https://github.com/tianocore/edk2/blob/master/EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatform.c#L204).

The issue with this design is the EndOfDxe event is called at TPL_CALLBACK. And 
the DHCP & TFTP stack cannot be initialized at TPL_CALLBACK 
(https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c#L824).

I can see few solutions to solve my issue but I do not like none of them :(:

-  Solution A: Encapsulate the use case in an EFI application/Driver 
that would be invoked by the user in BDS (either in the EFI Shell or as a 
Driver boot entry)
Drawback: it means the user has to do a specific action for this use case.



-  Solution B: Replace EnfOfDxe event to use a dummy EFI protocol that 
would be installed by the BDS

Drawback: it means the mechanism must be implemented in every BDS. While I am 
looking for a generic solution.



-  Solution C: Return an error saying the UEFI specification does not 
allow this use case.

Drawback: So what is the alternative? Changing the spec?



-  Solution D: Change my implementation to download a file from TFTP 
and make the implementation non-blocking/asynchronous when called at 
TPL_CALLBACK.

Drawback: it makes the implementation much more complicated to maintain. And I 
cannot guarantee the file is downloaded when the BDS is started.

Any comment/suggestion?

Thanks,
Olivier

-- IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered 
in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, 
Registered in England & Wales, Company No: 2548782
--
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [PATCH] ShellPkg: Added newline at the end of source files

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: Wednesday, April 01, 2015 4:50 AM
To: Carsey, Jaben
Cc: edk2-devel@lists.sourceforge.net
Subject: [PATCH] ShellPkg: Added newline at the end of source files
Importance: High

Dear ShellPkg maintainer,

Some compilers (such as ARM toolchain) complain if there is
no new line at the end of a source file.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin 
mailto:olivier.mar...@arm.com>>

Regards,
Olivier

-- IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered 
in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, 
Registered in England & Wales, Company No: 2548782
--
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [Patch] ShellPkg: Remove extra quotes surrounding flag values.

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

From: Qiu, Shumin
Sent: Monday, March 30, 2015 6:32 PM
To: Carsey, Jaben
Cc: edk2-devel@lists.sourceforge.net
Subject: [edk2] [Patch] ShellPkg: Remove extra quotes surrounding flag values.
Importance: High

Hi Jaben ,
Could you help review the patch? It remove the redundant quotes from flag 
values.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin mailto:shumin@intel.com>>

Thanks,
Shumin


--
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [PATCH] ShellPkg: smbiosview update for SMBIOS 3.0

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

-Original Message-
From: Li, Elvin 
Sent: Sunday, March 15, 2015 7:52 PM
To: Carsey, Jaben
Cc: edk2-devel@lists.sourceforge.net; Li, Elvin
Subject: [edk2] [PATCH] ShellPkg: smbiosview update for SMBIOS 3.0
Importance: High

Hi Jaben,
   Could you help to review this update to UEFI shell smbiosview to dump  
64-bit entry point and table?

[Description]
    I added the additional function that smbiosview can dump 64-bit 
entry point and table as long as SMBIOS 3.0 table exists in system 
configuration table.
    
  I attached an example output on NT32 platform. 
1. The log includes both 32-bit and 64-bit tables.
2. To locate 64-bit entry point, search "_SM3_" in log file.
3. Error handling change:
When 32-bit table did not exist, 64-bit table existed, 
64-bit table data was dumped and correct. No error message was displayed.
When 64-bit table did not exist, 32-bit table existed, 
32-bit table data was dumped and correct. No error message was displayed.
When both tables did not exist, error message was 
showed "cannot get SMBIOS table".


[SVN commit log]
ShellPkg: update smbiosview for SMBIOS 3.0.

smbiosview can dump 64-bit entry point and table 
as long as SMBIOS 3.0 table exists in system configuration table.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Elvin Li 


Thanks
Elvin Li

--
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [Patch] ShellPkg: Fix typo 'caculate' in ShellPkg.

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

From: Qiu, Shumin
Sent: Friday, March 13, 2015 12:52 AM
To: Carsey, Jaben
Cc: edk2-devel@lists.sourceforge.net
Subject: [edk2] [Patch] ShellPkg: Fix typo 'caculate' in ShellPkg.
Importance: High

Hi Jaben,
Could you help review the patch? It fix the typo 'caculate' -> 'calculate'.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin mailto:shumin@intel.com>>

Thanks,
Shumin

--
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [Patch] ShellPkg: Add type cast to avoid build failure in VS2005.

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

From: Qiu, Shumin
Sent: Wednesday, March 11, 2015 6:46 PM
To: Carsey, Jaben
Cc: edk2-devel@lists.sourceforge.net
Subject: [edk2] [Patch] ShellPkg: Add type cast to avoid build failure in 
VS2005.
Importance: High

Hi Jaben,
Could you help review the patch? When building ShellPkg, VS2005 report the 
following error:
"
ShellPkg\Library\UefiShellLib\UefiShellLib.c(2104) : error C2220: warning 
treated as error - no 'object' file generated
ShellPkg\Library\UefiShellLib\UefiShellLib.c(2104) : warning C4244: 'function' 
: conversion from 'int' to 'const BOOLEAN', possible loss of data
"
The attached patch add type cast to fix this issue.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin mailto:shumin@intel.com>>

Thanks,
Shumin

--
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] Not able to locate EFI_TCP4_PROTOCOL protocol

[Carsey, Jaben]

After you load the driver do you run the connect command to connect it?  That’s 
the next step to getting the driver functioning…

From: Ritesh Tiwari [mailto:ritesh.tiw...@seagate.com]
Sent: Tuesday, March 10, 2015 10:16 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] Not able to locate EFI_TCP4_PROTOCOL protocol

Hi,

I am trying to write a TCP application. I am seeing 
bootservices->LocateProtocol() for EFI_TCP4_PROTOCOL failing. Although TCP4DXE 
driver is loaded as per drivers command. But when I load this TCP4DXE driver 
manually I don't see EFI_TCP4_PROTOCOL handle is getting installed. I am 
testing all this on NT32.

Just wanted to know which driver to load so that I can locate 
EFI_TCP4_PROTOCOL? I want to open a TCP socket so that I can communicate with a 
remote host.

Thanks.
--
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] ShellPkg: Help and Error Messages Update

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

Commit 17032

From: Shah, Tapan [mailto:tapands...@hp.com]
Sent: Wednesday, March 04, 2015 12:49 PM
To: Carsey, Jaben; edk2-devel@lists.sourceforge.net
Cc: El-Haj-Mahmoud, Samer; Carsey, Jaben
Subject: ShellPkg: Help and Error Messages Update
Importance: High

Jaben,
   Can you please review this change?

Thanks,
Tapan


ShellPkg: Help and Error Messages Update

* Updates to various profile commands help and error message output 
with better wordings.

* Fix few inconsistency issues found in error messages across various 
profile commands.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off by: Tapan Shah mailto:tapands...@hp.com>>



--
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] SAT with UEFI

[Carsey, Jaben]

It may be faster to look for the SimpleFileSystemProtocol and then examine the 
handle for other protocols.  I am not certain what you are trying to do to the 
HDD…

-Jaben

From: Wirlino [mailto:josiel.san...@iatecam.org.br]
Sent: Tuesday, March 03, 2015 9:54 AM
To: EDK2-DEVEL
Subject: [edk2] SAT with UEFI




Hi everyone

About UEFI 2.1 i don't have the ATA_PASS_THRU_PROTOCOL , OK? So i can't find 
the ATA HDD easily ..
But I have the SCSI_PASS_THRU_PROTOCOL and them have the SAT Spec, when i've 
ata command "translated" for scsi command.
Somebody know use it?



Thanks,

S. Vieira
--
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [PATCH] ShellPkg: Parse new SMBIOS 3.0 fields

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

From: Li, Elvin
Sent: Saturday, February 14, 2015 8:47 PM
To: Carsey, Jaben
Cc: edk2-devel@lists.sourceforge.net
Subject: [edk2] [PATCH] ShellPkg: Parse new SMBIOS 3.0 fields
Importance: High

Hi Jaben,
Could you help review the attached patch?

ShellPkg: Parse new SMBIOS 3.0 fields.

Parse new SMBIOS 3.0 fields in Type 4: Core Count 2, Core Enabled 2, Thread 
Count 2.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Elvin Li mailto:elvin...@intel.com>>

Thanks
Elvin Li
--
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [PATCH] ShellPkg/UefiShellLib: Fixed ARM compiler error

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: Tuesday, February 17, 2015 11:15 AM
To: Carsey, Jaben
Cc: edk2-devel@lists.sourceforge.net
Subject: [PATCH] ShellPkg/UefiShellLib: Fixed ARM compiler error
Importance: High

Dear ShellPkg maintainer,

Please find the attached patch that fixes ARM compiler error.
#191-D: type qualifier is meaningless on cast type

ARM Compiler version 5 raises the warning/error (warning treated as error):

The compiler team said the warning is valid because from the C90 standard,
section 6.5.3 it is specified that "The properties associated with
qualified types are meaningful only for expressions that are lvalues."

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin 
mailto:olivier.mar...@arm.com>>

Regards,
Olivier
--
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [DevicePath] Get NextNode

[Carsey, Jaben]

What are you wanting to do with the hard drive?

You could search for SimpleFileSystem and then open the device path on the same 
handle.  Note that there may be more than one hard drive too.

-Jaben

From: Josiel Santos [mailto:jwvsan...@outlook.com]
Sent: Friday, February 13, 2015 9:35 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [DevicePath] Get NextNode

Hi everyone :-D  again!!!

I'm trying get of the paths( I want to accesss the hard disk drive )

Source example:

   gBS->OpenProtocol(myDevice[indice],
 &devicePathGUID2,
   (void **) &deviceCurrent2,
   ImageHandle,
   NULL,
   EFI_OPEN_PROTOCOL_BY_HANDLE_PROTOCOL
   );
if( !EFI_ERROR( Status ))
{
Print(L"  \n OpenProtocol Ok! \n\n");
EFI_DEVICE_PATH *node = deviceCurrent2;
    for (; !IsDevicePathEnd(node); node = 
NextDevicePathNode(node)) {
 **
 **
 **
}
}else{
Print(L"  \n OpenProtocol fail! \n\n");
}
}

}else{
  Print(L"  \n LBH Fail! \n\n");
}
return EFI_SUCCESS;
}

**
in "for (; !IsDevicePathEnd(node); node = NextDevicePathNode(node))"


doesn't get nextDeviceNode ( got something but isn't nextNode )


( example ) access the path:  PciRoot(x)/Pci(x,x)/ACPI(x,x)/UART(x,x,x,x)

I think:
1- I have the Node Root PciRoot(x) with OpenProtocol ( located in
variable deviceCurrent2) .
2- Pass  deviceCurrent2 to NextDeviceNode() and i hope to receive the
PCI(x,x) as return, to after get next node of PCI(x,x) wich is ACPI(x,x).

I want "to walk"  in the tree of the node PciRoot ie.

Thanks

--
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] No linking EFI apps against stdlib?

[Carsey, Jaben]

Have you looked at the AppPkg?  There are apps there that are similar to what I 
think you’re looking to do.  There is a custom set of UEFI libraries that 
fulfill the features of the stdlib.

-Jaben

From: John Smith [mailto:johnrandomsmi...@gmail.com]
Sent: Tuesday, February 10, 2015 6:32 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] No linking EFI apps against stdlib?

So I wanted to make an EFI app that could malloc and realloc memory as 
necessary. I was able to get it compiling, but then it wouldn't link. So I 
googled around and found this page 
http://www.rodsbooks.com/efi-programming/hello.html saying that EFI apps 
shouldn't be linked against stdlib (should pass the -nostdlib, which I can see 
is being passed to my hello world which I had made from a template found 
elsewhere.)

So my basic question is, what's the proper way to do memory allocation and wide 
string allocations (like wcslen()) if I can't link against stdlib? (I can 
probably do allocation (but not like, realloc()) via boot services, but I'd 
still need string operations.)

And is the reason for not linking against stdlib because it won't be available 
to EFI applications when they're running? If so, is it not possible to 
statically link them?

V/R
JRS
--
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [PATCH] Shellpkg: Fix spelling errors in Shell.c/Shell.h comments

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

From: Peterson, Joe
Sent: Friday, February 06, 2015 1:46 PM
To: Carsey, Jaben
Cc: edk2-devel@lists.sourceforge.net
Subject: [PATCH] Shellpkg: Fix spelling errors in Shell.c/Shell.h comments
Importance: High

Jaben,

Please review this patch.



This patch fixes spelling errors in comments. No functional change.


Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Joe Peterson 
mailto:joe.peter...@intel.com>>


--
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] ShellPkg: command help with -? flag does not work

[Carsey, Jaben]

Tapan,

Can you review this alternate instead?  I think this is a simpler solution.

From: Shah, Tapan [mailto:tapands...@hp.com]
Sent: Friday, February 06, 2015 9:49 AM
To: Carsey, Jaben; edk2-devel@lists.sourceforge.net
Subject: ShellPkg: command help with -? flag does not work
Importance: High

Jaben,
   Can you review this change?

(example: "ls -?" is not working. This patch fixes the issue.)


ShellPkg: command help with -? flag is not working and it gives too many 
arguments error message.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off by: Tapan Shah mailto:tapands...@hp.com>>




Shell.c.patch
Description: Shell.c.patch
--
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] [Shell] Doubt using python

[Carsey, Jaben]

What happened?  Do you have a capture of the output?

-Original Message-
From: S.Vieira [mailto:jwvsan...@outlook.com] 
Sent: Thursday, February 05, 2015 5:48 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [Shell] Doubt using python

Hi all,


So... i am trying use the GUI build in python.

i invoke in Shell the python module and next the *.py which is my GUI but
don't worked! 

Somebody have any idea how to do?!

PS: I set the PYTHONPATH 


--
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

--
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] ShellPkg: Standardized HP Copyright Message String

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

Commit 16759

From: Shah, Tapan [mailto:tapands...@hp.com]
Sent: Wednesday, February 04, 2015 1:39 PM
To: Carsey, Jaben; edk2-devel@lists.sourceforge.net
Cc: El-Haj-Mahmoud, Samer
Subject: ShellPkg: Standardized HP Copyright Message String
Importance: High

Jaben,
   Can you please review this change?

As per HP legal guidelines, we need to use standardized HP Copyright Message 
string for all HP contributed files. Attached diff file includes for all 
changes in ShellPkg directory. I have also attached updated .uni files with new 
copyright format.

Format:

  (C) Copyright FIRST_YEAR-2015 Hewlett-Packard Development Company, L.P.



ShellPkg: Standardized HP Copyright Message String
   (C) Copyright FIRST_YEAR-2015 Hewlett-Packard Development 
Company, L.P.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off by: Tapan Shah mailto:tapands...@hp.com>>



--
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

[edk2] [PATCH] ShellPkg: cast return value to correct type based on what we passed in

[Carsey, Jaben]

Joe and Shumin,

Can you check this?

ShellPkg: cast return value to correct type based on what we passed in

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey 


Shell.c.patch
Description: Shell.c.patch
--
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] ShellPkg: Update Level3 profile commands with a better command response output

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

Commit 16732

From: Shah, Tapan [mailto:tapands...@hp.com]
Sent: Tuesday, February 03, 2015 10:09 AM
To: Carsey, Jaben; edk2-devel@lists.sourceforge.net
Cc: El-Haj-Mahmoud, Samer; Weidenhammer, Greg
Subject: ShellPkg: Update Level3 profile commands with a better command 
response output
Importance: High

Jaben,
   Can you please review attached UefiShellLevel3CommandsLib.uni file and 
associated diff file with following changes?

Thanks,
Tapan


ShellPkg: Update Level3 profile commands response output

* Updates to Level3 profile commands response output. Displaying 
"Error" as a prefix to all Level3 commands error is too strong and not customer 
friendly. So rewording messages in a more informative way as well as including 
command name as a prefix in error message.

* Updating Level3 profile commands source code to include command name 
as a prefix in error message.

Contributed-under: Tianocore Contribution Agreement 1.0
Signed-off by: Tapan Shah mailto:tapands...@hp.com>>

--
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] ShellPkg: Update Network1 profile commands with a better command response output

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

Commit 16731
From: Shah, Tapan [mailto:tapands...@hp.com]
Sent: Tuesday, February 03, 2015 10:09 AM
To: Carsey, Jaben; edk2-devel@lists.sourceforge.net
Cc: El-Haj-Mahmoud, Samer; Weidenhammer, Greg
Subject: ShellPkg: Update Network1 profile commands with a better command 
response output
Importance: High

Jaben,
   Can you please review attached UefiShellNetwork1CommandsLib.uni file and 
associated diff file with following changes?

Thanks,
Tapan


ShellPkg: Update Network1 profile commands response output

* Updates to Network1 profile commands response output. Displaying 
"Error" as a prefix to all Network1 commands error is too strong and not 
customer friendly. So rewording messages in a more informative way as well as 
including command name as a prefix in error message.

* Updating Network1 profile commands source code to include command 
name as a prefix in error message.

Contributed-under: Tianocore Contribution Agreement 1.0
Signed-off by: Tapan Shah mailto:tapands...@hp.com>>


--
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] ShellPkg: Update Level2 profile commands with a better command response output

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

Commit 16730

From: Shah, Tapan [mailto:tapands...@hp.com]
Sent: Tuesday, February 03, 2015 10:09 AM
To: Carsey, Jaben; edk2-devel@lists.sourceforge.net
Cc: El-Haj-Mahmoud, Samer; Weidenhammer, Greg
Subject: ShellPkg: Update Level2 profile commands with a better command 
response output
Importance: High

Jaben,
   Can you please review attached UefiShellLevel2CommandsLib.uni file and 
associated diff file with following changes?

Thanks,
Tapan


ShellPkg: Update Level2 profile commands response output

* Updates to Level2 profile commands response output. Displaying 
"Error" as a prefix to all Level2 commands error is too strong and not customer 
friendly. So rewording messages in a more informative way as well as including 
command name as a prefix in error message.

* Updating Level2 profile commands source code to include command name 
as a prefix in error message.

Contributed-under: Tianocore Contribution Agreement 1.0
Signed-off by: Tapan Shah mailto:tapands...@hp.com>>







--
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel