Re: [Ekiga-devel-list] Static source code analysis of ekiga
Hi, Le 14/04/2014 18:24, John Smith a écrit : Hi, Just for fun, I decided to run the llvm/clang static source code analyzer on ptlib, opal, and ekiga. The results can be found here: ptlib http://lbalbalba.url.ph/clang/ptlib/ opal http://lbalbalba.url.ph/clang/opal/ ekiga http://lbalbalba.url.ph/clang/ekiga/ I pushed a commit to fix those in ekiga... I'm actually quite surprised there was so little to complain about! Snark ___ ekiga-devel-list mailing list ekiga-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/ekiga-devel-list
Re: [Ekiga-devel-list] Static source code analysis of ekiga
On 14/04/14 20:27, Julien Puydt wrote: Hi, Le 14/04/2014 18:24, John Smith a écrit : Hi, Just for fun, I decided to run the llvm/clang static source code analyzer on ptlib, opal, and ekiga. The results can be found here: ptlib http://lbalbalba.url.ph/clang/ptlib/ opal http://lbalbalba.url.ph/clang/opal/ ekiga http://lbalbalba.url.ph/clang/ekiga/ I pushed a commit to fix those in ekiga... I'm actually quite surprised there was so little to complain about! ptlib and opal are too old to bother with those issues. We are working to use the newest ptlib/opal code... -- Eugen ___ ekiga-devel-list mailing list ekiga-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/ekiga-devel-list
Re: [Ekiga-devel-list] Static source code analysis of ekiga
On Mon, Apr 14, 2014 at 8:27 PM, Julien Puydt jpu...@free.fr wrote: I pushed a commit to fix those in ekiga... I'm actually quite surprised there was so little to complain about! Cool. 'cppcheck' hasnt got much more to complain about either: http://lbalbalba.url.ph/cppcheck/ekiga/ Regards, John Smith ___ ekiga-devel-list mailing list ekiga-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/ekiga-devel-list
Re: [Ekiga-devel-list] Static source code analysis of ekiga
On Mon, Apr 14, 2014 at 9:05 PM, Eugen Dedu eugen.d...@pu-pm.univ-fcomte.fr wrote: ptlib and opal are too old to bother with those issues. We are working to use the newest ptlib/opal code... I can checkout the latest revisions of ptlib/opal and run the analyzer on that. Regards, John Smith. ___ ekiga-devel-list mailing list ekiga-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/ekiga-devel-list
Re: [Ekiga-devel-list] Static source code analysis of ekiga
On 14/04/14 21:08, John Smith wrote: On Mon, Apr 14, 2014 at 9:05 PM, Eugen Dedu eugen.d...@pu-pm.univ-fcomte.fr wrote: ptlib and opal are too old to bother with those issues. We are working to use the newest ptlib/opal code... I can checkout the latest revisions of ptlib/opal and run the analyzer on that. Good, please try versions ptlib 2.14 and opal 3.14 (latest stable releases) and post the results not here, but on opalvoip-u...@lists.sourceforge.net mailing list. Thank you! -- Eugen ___ ekiga-devel-list mailing list ekiga-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/ekiga-devel-list
Re: [Ekiga-devel-list] Static source code analysis of ekiga
On Mon, Apr 14, 2014 at 9:23 PM, Craig Southeren cra...@postincrement.com wrote: On 4/14/14, 12:13 PM, Eugen Dedu wrote: On 14/04/14 21:08, John Smith wrote: On Mon, Apr 14, 2014 at 9:05 PM, Eugen Dedu eugen.d...@pu-pm.univ-fcomte.fr wrote: ptlib and opal are too old to bother with those issues. We are working to use the newest ptlib/opal code... I can checkout the latest revisions of ptlib/opal and run the analyzer on that. Good, please try versions ptlib 2.14 and opal 3.14 (latest stable releases) and post the results not here, but on opalvoip-u...@lists.sourceforge.net mailing list. Thank you! Yes please! I'll certainly look to fix anything that I can. Craig No problem. ill run the analyzer and upload the results to my website, and post about it on opalvoip-de...@lists.sourceforge.net Although im sure there will be a fair amount of false positives as well. ;) Regards, John Smith. ___ ekiga-devel-list mailing list ekiga-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/ekiga-devel-list
Re: [Ekiga-devel-list] Static source code analysis of ekiga
Le 14/04/2014 21:06, John Smith a écrit : On Mon, Apr 14, 2014 at 8:27 PM, Julien Puydt jpu...@free.fr wrote: I pushed a commit to fix those in ekiga... I'm actually quite surprised there was so little to complain about! Cool. 'cppcheck' hasnt got much more to complain about either: http://lbalbalba.url.ph/cppcheck/ekiga/ I fixed them too, but I'm quite unhappy: the default C++ constructors were adequately taking care of things, so those weren't worth it. In fact, to get more correct core, one should probably *remove* the lines I added, and then some more for good measure... It's disappointing that those tests found out so little to complain about... :-/ Snark ___ ekiga-devel-list mailing list ekiga-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/ekiga-devel-list
Re: [Ekiga-devel-list] Static source code analysis of ekiga
On Mon, Apr 14, 2014 at 9:48 PM, Julien Puydt jpu...@free.fr wrote: I fixed them too, but I'm quite unhappy: the default C++ constructors were adequately taking care of things, so those weren't worth it. In fact, to get more correct core, one should probably *remove* the lines I added, and then some more for good measure... Please dont make any modifications that you are unhappy about 'just' because some analyzer told you to do it. Humans are smarter than those programs, so always reason about if you want to make the modifications or not. It's disappointing that those tests found out so little to complain about... The majority of the issues seem to be in the libraries ekiga uses. Regards, John Smith. ___ ekiga-devel-list mailing list ekiga-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/ekiga-devel-list
