Re: [E-devel] about removing trailing whitespaces
@Mike: I ran indent and it didn't seem to screw up things, I told it I want
3 spaces indent and 2 spaces inside { } or something, I tried it on a few
elm_*.c files and it changed some stuff but not the indentation spacing as
far as I remember.
@Carsten: spaces in blank lines are the same as spaces at the end of a line,
it's just that the line ends at position 0. I see absolutely no difference
in that and emacs doesn't either. And I don't see your point about it being
'childish'.
p.s: seems Carsten replied off-list, so I'm resending this to the list.
On Sat, Oct 22, 2011 at 3:33 PM, Mike Blumenkrantz m...@zentific.comwrote:
On Sat, 22 Oct 2011 11:57:15 -0400
Youness Alaoui kakar...@kakaroto.homelinux.net wrote:
I never said GNU is the reference for high quality, and we're not here to
talk about whether or not we like GNU, the FSF or Stallman.
Your point is that it would be easier to debug of your own app, my point
is
that why do hell would you need to debug that? Set your arguments to what
style you prefer and move on, no debugging necessary.
On Sat, Oct 22, 2011 at 5:48 AM, David Seikel onef...@gmail.com wrote:
On Sat, 22 Oct 2011 01:38:35 -0400 Youness Alaoui
kakar...@kakaroto.homelinux.net wrote:
Also I believe using a tested and used GNU app is better than using a
custom made one that might have bugs,
Since when is GNU the be all and end all of high quality coding? I'd
trust something written by an EFL coder over something out of GNU or
FSF any day. It would certainly be a lot easier to debug one of our
own apps.
--
A big old stinking pile of genius that no one wants
coz there are too many silver coated monkeys in the world.
I don't think anyone has a problem using indent if it works. The problem
is,
IIRC, that it doesn't support EFL's indenting style. We indent an extra
space
for the width of a brace, and no indenter that I've come across can do that
natively. This is why I hacked up ecrustify.
--
Mike Blumenkrantz
Zentific: Doctor recommended, mother approved.
--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
http://p.sf.net/sfu/cisco-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] about removing trailing whitespaces
On Sun, 23 Oct 2011 04:24:14 -0400
Youness Alaoui kakar...@kakaroto.homelinux.net wrote:
@Mike: I ran indent and it didn't seem to screw up things, I told it I want
3 spaces indent and 2 spaces inside { } or something, I tried it on a few
elm_*.c files and it changed some stuff but not the indentation spacing as
far as I remember.
If that's what you used then it isn't accurate. The correct formatting is 2
space indent (except for switch), and always indent the width of a brace.
@Carsten: spaces in blank lines are the same as spaces at the end of a line,
it's just that the line ends at position 0. I see absolutely no difference
in that and emacs doesn't either. And I don't see your point about it being
'childish'.
p.s: seems Carsten replied off-list, so I'm resending this to the list.
On Sat, Oct 22, 2011 at 3:33 PM, Mike Blumenkrantz m...@zentific.comwrote:
On Sat, 22 Oct 2011 11:57:15 -0400
Youness Alaoui kakar...@kakaroto.homelinux.net wrote:
I never said GNU is the reference for high quality, and we're not here to
talk about whether or not we like GNU, the FSF or Stallman.
Your point is that it would be easier to debug of your own app, my point
is
that why do hell would you need to debug that? Set your arguments to what
style you prefer and move on, no debugging necessary.
On Sat, Oct 22, 2011 at 5:48 AM, David Seikel onef...@gmail.com wrote:
On Sat, 22 Oct 2011 01:38:35 -0400 Youness Alaoui
kakar...@kakaroto.homelinux.net wrote:
Also I believe using a tested and used GNU app is better than using a
custom made one that might have bugs,
Since when is GNU the be all and end all of high quality coding? I'd
trust something written by an EFL coder over something out of GNU or
FSF any day. It would certainly be a lot easier to debug one of our
own apps.
--
A big old stinking pile of genius that no one wants
coz there are too many silver coated monkeys in the world.
I don't think anyone has a problem using indent if it works. The problem
is,
IIRC, that it doesn't support EFL's indenting style. We indent an extra
space
for the width of a brace, and no indenter that I've come across can do that
natively. This is why I hacked up ecrustify.
--
Mike Blumenkrantz
Zentific: Doctor recommended, mother approved.
--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
http://p.sf.net/sfu/cisco-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Mike Blumenkrantz
Zentific: Doctor recommended, mother approved.
--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
http://p.sf.net/sfu/cisco-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] about removing trailing whitespaces
On Sat, 22 Oct 2011 01:38:35 -0400 Youness Alaoui kakar...@kakaroto.homelinux.net wrote: Also I believe using a tested and used GNU app is better than using a custom made one that might have bugs, Since when is GNU the be all and end all of high quality coding? I'd trust something written by an EFL coder over something out of GNU or FSF any day. It would certainly be a lot easier to debug one of our own apps. -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. signature.asc Description: PGP signature -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] about removing trailing whitespaces
I never said GNU is the reference for high quality, and we're not here to talk about whether or not we like GNU, the FSF or Stallman. Your point is that it would be easier to debug of your own app, my point is that why do hell would you need to debug that? Set your arguments to what style you prefer and move on, no debugging necessary. On Sat, Oct 22, 2011 at 5:48 AM, David Seikel onef...@gmail.com wrote: On Sat, 22 Oct 2011 01:38:35 -0400 Youness Alaoui kakar...@kakaroto.homelinux.net wrote: Also I believe using a tested and used GNU app is better than using a custom made one that might have bugs, Since when is GNU the be all and end all of high quality coding? I'd trust something written by an EFL coder over something out of GNU or FSF any day. It would certainly be a lot easier to debug one of our own apps. -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] about removing trailing whitespaces
On Sat, 22 Oct 2011 11:57:15 -0400 Youness Alaoui kakar...@kakaroto.homelinux.net wrote: I never said GNU is the reference for high quality, and we're not here to talk about whether or not we like GNU, the FSF or Stallman. Your point is that it would be easier to debug of your own app, my point is that why do hell would you need to debug that? Set your arguments to what style you prefer and move on, no debugging necessary. On Sat, Oct 22, 2011 at 5:48 AM, David Seikel onef...@gmail.com wrote: On Sat, 22 Oct 2011 01:38:35 -0400 Youness Alaoui kakar...@kakaroto.homelinux.net wrote: Also I believe using a tested and used GNU app is better than using a custom made one that might have bugs, Since when is GNU the be all and end all of high quality coding? I'd trust something written by an EFL coder over something out of GNU or FSF any day. It would certainly be a lot easier to debug one of our own apps. -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. I don't think anyone has a problem using indent if it works. The problem is, IIRC, that it doesn't support EFL's indenting style. We indent an extra space for the width of a brace, and no indenter that I've come across can do that natively. This is why I hacked up ecrustify. -- Mike Blumenkrantz Zentific: Doctor recommended, mother approved. -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] about removing trailing whitespaces
Ha! I was about to start a thread about this specific issue!
I don't know if you noticed but I added a 'efl-indent' script in FORMATTING
which uses GNU's indent. That works very good, and is used by GStreamer to
do their code formatting.
GStreamer uses git and when you try to commit something that doesn't match
the formatting code, it will not let you commit, and will show you how it
should have been.
Here is an example : http://pastie.org/2686190
I discussed this with SeoZ on #edevelop a couple of weeks ago. The script
might need some tweaking (the man page of indent is quite extensive) to fit
the exact coding style of the efl (I think it's close now) but I noticed a
lot of things aren't standardized, like struct { with the accolades on
the same line in some files and with it on separate lines in other files, or
the number of spaces between a variable type and its name in a declaration
(some align it, some don't), etc... all that stuff has to be defined and
respected across the board.
We can do a pre-commit hook in svn that would work just like its git
counterpart in GStreamer. But we'd need to reindent all the files for it to
work, it could be done in a single commit but might cause conflicts to devs,
or do it one file at a time, whenever it gets modified by someone, he'd
format it at the same time.
What do you think ?
KaKaRoTo
On Fri, Oct 21, 2011 at 12:29 AM, Vincent Torri vto...@univ-evry.fr wrote:
On Fri, 21 Oct 2011, Daniel Juyung Seo wrote:
I raise this issue again.
We need pre/post-commit hook for formatting, whitespaces, and whatever.
unfortunately, these hook will imply a lot of conflicts
Vincent
webkit already does this job.
Daniel Juyung Seo (SeoZ)
On Tue, Jun 21, 2011 at 10:00 PM, David Seikel onef...@gmail.com wrote:
On Tue, 21 Jun 2011 13:43:13 +0200 Thomas Gstädtner
tho...@gstaedtner.net wrote:
That is true, but the Don't do that, nasty programmer. SPANK SPANK
SPANK mail tells you that the hook triggered and also it hurts the
programmer who did produce the trailing whitespaces. People learn best
when it hurts :P
Automated emails might just go to spam, don't hurt that much. Unless
you intend to not accept the commit and make them do it over. That
will hurt enough.
--
A big old stinking pile of genius that no one wants
coz there are too many silver coated monkeys in the world.
--
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
http://p.sf.net/sfu/cisco-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
http://p.sf.net/sfu/cisco-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
http://p.sf.net/sfu/cisco-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] about removing trailing whitespaces
On Fri, 21 Oct 2011 14:44:31 -0400 Youness Alaoui
kakar...@kakaroto.homelinux.net said:
Ha! I was about to start a thread about this specific issue!
I don't know if you noticed but I added a 'efl-indent' script in FORMATTING
which uses GNU's indent. That works very good, and is used by GStreamer to
do their code formatting.
GStreamer uses git and when you try to commit something that doesn't match
the formatting code, it will not let you commit, and will show you how it
should have been.
Here is an example : http://pastie.org/2686190
I discussed this with SeoZ on #edevelop a couple of weeks ago. The script
might need some tweaking (the man page of indent is quite extensive) to fit
the exact coding style of the efl (I think it's close now) but I noticed a
lot of things aren't standardized, like struct { with the accolades on
the same line in some files and with it on separate lines in other files, or
the number of spaces between a variable type and its name in a declaration
(some align it, some don't), etc... all that stuff has to be defined and
respected across the board.
We can do a pre-commit hook in svn that would work just like its git
counterpart in GStreamer. But we'd need to reindent all the files for it to
work, it could be done in a single commit but might cause conflicts to devs,
or do it one file at a time, whenever it gets modified by someone, he'd
format it at the same time.
What do you think ?
umm that's why formatefl.sh is there. it actually gets very close to our current
style. it has 1 annoying bug at the moment though. it actually compiles and
installs a custom re-formatter that's a fork of uncrustify that does a lot more
than gnu indent does. the problem right now is in getting it to consistently
100% of the time format the right way. right now the bug it has in sticking
spaces before prototype functionames is annoying and going to lead to commit
hooks probably locking out commits permanently.
KaKaRoTo
On Fri, Oct 21, 2011 at 12:29 AM, Vincent Torri vto...@univ-evry.fr wrote:
On Fri, 21 Oct 2011, Daniel Juyung Seo wrote:
I raise this issue again.
We need pre/post-commit hook for formatting, whitespaces, and whatever.
unfortunately, these hook will imply a lot of conflicts
Vincent
webkit already does this job.
Daniel Juyung Seo (SeoZ)
On Tue, Jun 21, 2011 at 10:00 PM, David Seikel onef...@gmail.com wrote:
On Tue, 21 Jun 2011 13:43:13 +0200 Thomas Gstädtner
tho...@gstaedtner.net wrote:
That is true, but the Don't do that, nasty programmer. SPANK SPANK
SPANK mail tells you that the hook triggered and also it hurts the
programmer who did produce the trailing whitespaces. People learn best
when it hurts :P
Automated emails might just go to spam, don't hurt that much. Unless
you intend to not accept the commit and make them do it over. That
will hurt enough.
--
A big old stinking pile of genius that no one wants
coz there are too many silver coated monkeys in the world.
--
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
http://p.sf.net/sfu/cisco-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
http://p.sf.net/sfu/cisco-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a
Re: [E-devel] about removing trailing whitespaces
Yeah, I've seen ecrustify but I think when testing it, it didn't give good
results and from what I could perceive, other devs don't seem to trust it to
work reliably which is why I put efl-indent in there.
Also I believe using a tested and used GNU app is better than using a custom
made one that might have bugs, and being able to easily configure the output
using arguments to indent makes it better than looking through ecrustify to
figure out what causes it to format a line the wrong way.
As for the format, I configured efl-indent to match what the wiki says
(other than one bug I'm not sure how to change, need to read the man page),
but the current issues is with the fact that each file seem to use a
different coding style (or different styles within the same file) and I'm
not sure what to do with these as they are undocumented in the wiki.
p.s: for trailing spaces (which is this mail's original subject), I use a
sed line in efl-indent to take care of that, at least that could safely be
put into a svn hook while we figure out the coding style issue.
On Fri, Oct 21, 2011 at 10:14 PM, Carsten Haitzler ras...@rasterman.comwrote:
On Fri, 21 Oct 2011 14:44:31 -0400 Youness Alaoui
kakar...@kakaroto.homelinux.net said:
Ha! I was about to start a thread about this specific issue!
I don't know if you noticed but I added a 'efl-indent' script in
FORMATTING
which uses GNU's indent. That works very good, and is used by GStreamer
to
do their code formatting.
GStreamer uses git and when you try to commit something that doesn't
match
the formatting code, it will not let you commit, and will show you how it
should have been.
Here is an example : http://pastie.org/2686190
I discussed this with SeoZ on #edevelop a couple of weeks ago. The script
might need some tweaking (the man page of indent is quite extensive) to
fit
the exact coding style of the efl (I think it's close now) but I noticed
a
lot of things aren't standardized, like struct { with the accolades on
the same line in some files and with it on separate lines in other files,
or
the number of spaces between a variable type and its name in a
declaration
(some align it, some don't), etc... all that stuff has to be defined and
respected across the board.
We can do a pre-commit hook in svn that would work just like its git
counterpart in GStreamer. But we'd need to reindent all the files for it
to
work, it could be done in a single commit but might cause conflicts to
devs,
or do it one file at a time, whenever it gets modified by someone, he'd
format it at the same time.
What do you think ?
umm that's why formatefl.sh is there. it actually gets very close to our
current
style. it has 1 annoying bug at the moment though. it actually compiles and
installs a custom re-formatter that's a fork of uncrustify that does a lot
more
than gnu indent does. the problem right now is in getting it to
consistently
100% of the time format the right way. right now the bug it has in sticking
spaces before prototype functionames is annoying and going to lead to
commit
hooks probably locking out commits permanently.
KaKaRoTo
On Fri, Oct 21, 2011 at 12:29 AM, Vincent Torri vto...@univ-evry.fr
wrote:
On Fri, 21 Oct 2011, Daniel Juyung Seo wrote:
I raise this issue again.
We need pre/post-commit hook for formatting, whitespaces, and
whatever.
unfortunately, these hook will imply a lot of conflicts
Vincent
webkit already does this job.
Daniel Juyung Seo (SeoZ)
On Tue, Jun 21, 2011 at 10:00 PM, David Seikel onef...@gmail.com
wrote:
On Tue, 21 Jun 2011 13:43:13 +0200 Thomas Gstädtner
tho...@gstaedtner.net wrote:
That is true, but the Don't do that, nasty programmer. SPANK SPANK
SPANK mail tells you that the hook triggered and also it hurts the
programmer who did produce the trailing whitespaces. People learn
best
when it hurts :P
Automated emails might just go to spam, don't hurt that much. Unless
you intend to not accept the commit and make them do it over. That
will hurt enough.
--
A big old stinking pile of genius that no one wants
coz there are too many silver coated monkeys in the world.
--
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
The demand for IT networking professionals continues to grow, and the
demand
Re: [E-devel] about removing trailing whitespaces
On Sat, 22 Oct 2011 01:38:35 -0400 Youness Alaoui
kakar...@kakaroto.homelinux.net said:
Yeah, I've seen ecrustify but I think when testing it, it didn't give good
results and from what I could perceive, other devs don't seem to trust it to
work reliably which is why I put efl-indent in there.
Also I believe using a tested and used GNU app is better than using a custom
made one that might have bugs, and being able to easily configure the output
using arguments to indent makes it better than looking through ecrustify to
figure out what causes it to format a line the wrong way.
As for the format, I configured efl-indent to match what the wiki says
(other than one bug I'm not sure how to change, need to read the man page),
but the current issues is with the fact that each file seem to use a
different coding style (or different styles within the same file) and I'm
not sure what to do with these as they are undocumented in the wiki.
the wiki doesn't really cover the real formatting rules - so don't trust it.
trust actual code as examples of it. the only thing here that u can do is look
at the code and make sure it comes out looking right.
p.s: for trailing spaces (which is this mail's original subject), I use a
sed line in efl-indent to take care of that, at least that could safely be
put into a svn hook while we figure out the coding style issue.
its a totally stupid issue brought up by a bunch of vim users who have vim set
to please annoy me about spaces at the end of lines. the spacing does not
affect code quality nor readability. ESPECIALLY spaces at the start of blank
lines. i hit tab to indent and editors ADD the spaces in automatically. i'm not
going to manually go removing them each and every time to appease those that
wish to make their lives annoying. this is standard behavior on all editors.
On Fri, Oct 21, 2011 at 10:14 PM, Carsten Haitzler
ras...@rasterman.comwrote:
On Fri, 21 Oct 2011 14:44:31 -0400 Youness Alaoui
kakar...@kakaroto.homelinux.net said:
Ha! I was about to start a thread about this specific issue!
I don't know if you noticed but I added a 'efl-indent' script in
FORMATTING
which uses GNU's indent. That works very good, and is used by GStreamer
to
do their code formatting.
GStreamer uses git and when you try to commit something that doesn't
match
the formatting code, it will not let you commit, and will show you how it
should have been.
Here is an example : http://pastie.org/2686190
I discussed this with SeoZ on #edevelop a couple of weeks ago. The script
might need some tweaking (the man page of indent is quite extensive) to
fit
the exact coding style of the efl (I think it's close now) but I noticed
a
lot of things aren't standardized, like struct { with the accolades on
the same line in some files and with it on separate lines in other files,
or
the number of spaces between a variable type and its name in a
declaration
(some align it, some don't), etc... all that stuff has to be defined and
respected across the board.
We can do a pre-commit hook in svn that would work just like its git
counterpart in GStreamer. But we'd need to reindent all the files for it
to
work, it could be done in a single commit but might cause conflicts to
devs,
or do it one file at a time, whenever it gets modified by someone, he'd
format it at the same time.
What do you think ?
umm that's why formatefl.sh is there. it actually gets very close to our
current
style. it has 1 annoying bug at the moment though. it actually compiles and
installs a custom re-formatter that's a fork of uncrustify that does a lot
more
than gnu indent does. the problem right now is in getting it to
consistently
100% of the time format the right way. right now the bug it has in sticking
spaces before prototype functionames is annoying and going to lead to
commit
hooks probably locking out commits permanently.
KaKaRoTo
On Fri, Oct 21, 2011 at 12:29 AM, Vincent Torri vto...@univ-evry.fr
wrote:
On Fri, 21 Oct 2011, Daniel Juyung Seo wrote:
I raise this issue again.
We need pre/post-commit hook for formatting, whitespaces, and
whatever.
unfortunately, these hook will imply a lot of conflicts
Vincent
webkit already does this job.
Daniel Juyung Seo (SeoZ)
On Tue, Jun 21, 2011 at 10:00 PM, David Seikel onef...@gmail.com
wrote:
On Tue, 21 Jun 2011 13:43:13 +0200 Thomas Gstädtner
tho...@gstaedtner.net wrote:
That is true, but the Don't do that, nasty programmer. SPANK SPANK
SPANK mail tells you that the hook triggered and also it hurts the
programmer who did produce the trailing whitespaces. People learn
best
when it hurts :P
Automated emails might just go to spam, don't hurt that much. Unless
you intend to not accept the commit and make them do it over. That
Re: [E-devel] about removing trailing whitespaces
I raise this issue again. We need pre/post-commit hook for formatting, whitespaces, and whatever. webkit already does this job. Daniel Juyung Seo (SeoZ) On Tue, Jun 21, 2011 at 10:00 PM, David Seikel onef...@gmail.com wrote: On Tue, 21 Jun 2011 13:43:13 +0200 Thomas Gstädtner tho...@gstaedtner.net wrote: That is true, but the Don't do that, nasty programmer. SPANK SPANK SPANK mail tells you that the hook triggered and also it hurts the programmer who did produce the trailing whitespaces. People learn best when it hurts :P Automated emails might just go to spam, don't hurt that much. Unless you intend to not accept the commit and make them do it over. That will hurt enough. -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] about removing trailing whitespaces
On Fri, 21 Oct 2011 09:34:25 +0900 Daniel Juyung Seo seojuyu...@gmail.com said: I raise this issue again. We need pre/post-commit hook for formatting, whitespaces, and whatever. webkit already does this job. that assumes you have something that can either 1. enforce formatting rules properly everywhere (and then compare post-commit code as-is vs post-commit code with formatting enforced and reject code based on that - or commit updated formatted version). or 2. a script/tool that can detect all your formatting wants. we have neither right now. we are CLOSE to having 1. mike worked a lot on ecrustify (uncrustify with changes), but last i threw it at some code it made a dogs breakfast of some things. if you want to fix formatting like above - you need an automated formatter that works for everything we have. get that working and we can talk :) Daniel Juyung Seo (SeoZ) On Tue, Jun 21, 2011 at 10:00 PM, David Seikel onef...@gmail.com wrote: On Tue, 21 Jun 2011 13:43:13 +0200 Thomas Gstädtner tho...@gstaedtner.net wrote: That is true, but the Don't do that, nasty programmer. SPANK SPANK SPANK mail tells you that the hook triggered and also it hurts the programmer who did produce the trailing whitespaces. People learn best when it hurts :P Automated emails might just go to spam, don't hurt that much. Unless you intend to not accept the commit and make them do it over. That will hurt enough. -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] about removing trailing whitespaces
On Fri, 21 Oct 2011 11:58:33 +0900 Carsten Haitzler (The Rasterman) ras...@rasterman.com wrote: On Fri, 21 Oct 2011 09:34:25 +0900 Daniel Juyung Seo seojuyu...@gmail.com said: I raise this issue again. We need pre/post-commit hook for formatting, whitespaces, and whatever. webkit already does this job. that assumes you have something that can either 1. enforce formatting rules properly everywhere (and then compare post-commit code as-is vs post-commit code with formatting enforced and reject code based on that - or commit updated formatted version). or 2. a script/tool that can detect all your formatting wants. we have neither right now. we are CLOSE to having 1. mike worked a lot on ecrustify (uncrustify with changes), but last i threw it at some code it made a dogs breakfast of some things. ecrustify has issues with function pointers and some comments. I think it works perfectly aside from that, so if someone wants to try figuring that out then that's the place to start. if you want to fix formatting like above - you need an automated formatter that works for everything we have. get that working and we can talk :) Daniel Juyung Seo (SeoZ) On Tue, Jun 21, 2011 at 10:00 PM, David Seikel onef...@gmail.com wrote: On Tue, 21 Jun 2011 13:43:13 +0200 Thomas Gstädtner tho...@gstaedtner.net wrote: That is true, but the Don't do that, nasty programmer. SPANK SPANK SPANK mail tells you that the hook triggered and also it hurts the programmer who did produce the trailing whitespaces. People learn best when it hurts :P Automated emails might just go to spam, don't hurt that much. Unless you intend to not accept the commit and make them do it over. That will hurt enough. -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel IMO starting with just whitespace stripping would be good. -- Mike Blumenkrantz Zentific: Doctor recommended, mother approved. -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] about removing trailing whitespaces - and, er, CCs
No idea why I'm getting CCed this entire thread, but could people be a bit more careful with their email headers and make sure the CC to me is not propagated forever? I only need one copy, thanks. Oh, and I'm gonna say nasty words to the first person that replies to this email AND CC's ME DAMMIT! -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. signature.asc Description: PGP signature -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] about removing trailing whitespaces - and, er, CCs
On Fri, 21 Oct 2011 13:23:44 +1000 David Seikel onef...@gmail.com wrote: No idea why I'm getting CCed this entire thread, but could people be a bit more careful with their email headers and make sure the CC to me is not propagated forever? I only need one copy, thanks. Oh, and I'm gonna say nasty words to the first person that replies to this email AND CC's ME DAMMIT! pipe down and take it! -- Mike Blumenkrantz Zentific: Doctor recommended, mother approved. -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] about removing trailing whitespaces
On Thu, 20 Oct 2011 23:08:11 -0400 Mike Blumenkrantz m...@zentific.com said: On Fri, 21 Oct 2011 11:58:33 +0900 Carsten Haitzler (The Rasterman) ras...@rasterman.com wrote: On Fri, 21 Oct 2011 09:34:25 +0900 Daniel Juyung Seo seojuyu...@gmail.com said: I raise this issue again. We need pre/post-commit hook for formatting, whitespaces, and whatever. webkit already does this job. that assumes you have something that can either 1. enforce formatting rules properly everywhere (and then compare post-commit code as-is vs post-commit code with formatting enforced and reject code based on that - or commit updated formatted version). or 2. a script/tool that can detect all your formatting wants. we have neither right now. we are CLOSE to having 1. mike worked a lot on ecrustify (uncrustify with changes), but last i threw it at some code it made a dogs breakfast of some things. ecrustify has issues with function pointers and some comments. I think it works perfectly aside from that, so if someone wants to try figuring that out then that's the place to start. the ecore headers are botched because of an ecrustify run :( we may have to manually fix them. one problem is that ecrustify last i tried,m if u ran it once formatted to format A then if u ran it again on the result.. u got something different (format B). i need to poke at it again. but fn pointers inside function prototypes it definitely made a dogs breakfast of. if you want to fix formatting like above - you need an automated formatter that works for everything we have. get that working and we can talk :) Daniel Juyung Seo (SeoZ) On Tue, Jun 21, 2011 at 10:00 PM, David Seikel onef...@gmail.com wrote: On Tue, 21 Jun 2011 13:43:13 +0200 Thomas Gstädtner tho...@gstaedtner.net wrote: That is true, but the Don't do that, nasty programmer. SPANK SPANK SPANK mail tells you that the hook triggered and also it hurts the programmer who did produce the trailing whitespaces. People learn best when it hurts :P Automated emails might just go to spam, don't hurt that much. Unless you intend to not accept the commit and make them do it over. That will hurt enough. -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel IMO starting with just whitespace stripping would be good. -- Mike Blumenkrantz Zentific: Doctor recommended, mother approved. -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] about removing trailing whitespaces - and, er, CCs
On Thu, 20 Oct 2011 23:27:24 -0400 Mike Blumenkrantz m...@zentific.com wrote: On Fri, 21 Oct 2011 13:23:44 +1000 David Seikel onef...@gmail.com wrote: No idea why I'm getting CCed this entire thread, but could people be a bit more careful with their email headers and make sure the CC to me is not propagated forever? I only need one copy, thanks. Oh, and I'm gonna say nasty words to the first person that replies to this email AND CC's ME DAMMIT! pipe down and take it! Microsoft! Bill Gates! .NET! Nastiest words I can think of. -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. signature.asc Description: PGP signature -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] about removing trailing whitespaces - and, er, CCs
On Fri, 21 Oct 2011 13:52:44 +1000 David Seikel onef...@gmail.com wrote: On Thu, 20 Oct 2011 23:27:24 -0400 Mike Blumenkrantz m...@zentific.com wrote: On Fri, 21 Oct 2011 13:23:44 +1000 David Seikel onef...@gmail.com wrote: No idea why I'm getting CCed this entire thread, but could people be a bit more careful with their email headers and make sure the CC to me is not propagated forever? I only need one copy, thanks. Oh, and I'm gonna say nasty words to the first person that replies to this email AND CC's ME DAMMIT! pipe down and take it! Microsoft! Bill Gates! .NET! Nastiest words I can think of. AUGGH MY EYES!!! -- Mike Blumenkrantz Zentific: Doctor recommended, mother approved. -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] about removing trailing whitespaces
On Fri, 21 Oct 2011, Daniel Juyung Seo wrote: I raise this issue again. We need pre/post-commit hook for formatting, whitespaces, and whatever. unfortunately, these hook will imply a lot of conflicts Vincent webkit already does this job. Daniel Juyung Seo (SeoZ) On Tue, Jun 21, 2011 at 10:00 PM, David Seikel onef...@gmail.com wrote: On Tue, 21 Jun 2011 13:43:13 +0200 Thomas Gstädtner tho...@gstaedtner.net wrote: That is true, but the Don't do that, nasty programmer. SPANK SPANK SPANK mail tells you that the hook triggered and also it hurts the programmer who did produce the trailing whitespaces. People learn best when it hurts :P Automated emails might just go to spam, don't hurt that much. Unless you intend to not accept the commit and make them do it over. That will hurt enough. -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] about removing trailing whitespaces
On Sun, Jun 19, 2011 at 12:50, Albin Tonnerre albin.tonne...@gmail.com wrote: On Sun, 19 Jun 2011 12:38 +0200, Vincent Torri wrote : Hey another idea about trailing whitespaces : what about adding a rule in the toplevel Makefile.am, named for example remove-ws, that call find with a sed expression. I'll add it to Evil and test it a bit, and if nobody complains, i'll add it to the EFL + e. While it is nice to get rid of trailing whitespaces, I think that actively removing them periodically does more harm than good. In particular, it adds a lot of noise in the history and makes it harder to compare different revisions. If we indeed want to get rid of them, I'd be much happier if the SVN server simply rejected commits containing them (the same holds true for formatting - it's much better to ask people to submit properly formatted patches rather than going on a reformatting spree every now and then) Cheers, -- Albin Tonnerre I think putting this in a Makefile is a bad idea. Alternative: how about using a pre-commit hook in SVN that either removes whitespaces right away and sends a SPANK SPANK SPANK mail to the evil dev who did it, or just rejects the patch as Albin suggested. The first way is more proactive and should keep the commit/history clean. -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] about removing trailing whitespaces
On Tue, 21 Jun 2011, Thomas Gstädtner wrote: On Sun, Jun 19, 2011 at 12:50, Albin Tonnerre albin.tonne...@gmail.com wrote: On Sun, 19 Jun 2011 12:38 +0200, Vincent Torri wrote : Hey another idea about trailing whitespaces : what about adding a rule in the toplevel Makefile.am, named for example remove-ws, that call find with a sed expression. I'll add it to Evil and test it a bit, and if nobody complains, i'll add it to the EFL + e. While it is nice to get rid of trailing whitespaces, I think that actively removing them periodically does more harm than good. In particular, it adds a lot of noise in the history and makes it harder to compare different revisions. If we indeed want to get rid of them, I'd be much happier if the SVN server simply rejected commits containing them (the same holds true for formatting - it's much better to ask people to submit properly formatted patches rather than going on a reformatting spree every now and then) Cheers, -- Albin Tonnerre I think putting this in a Makefile is a bad idea. Alternative: how about using a pre-commit hook in SVN that either removes whitespaces right away and sends a SPANK SPANK SPANK mail to the evil dev who did it, or just rejects the patch as Albin suggested. The first way is more proactive and should keep the commit/history clean. then, you will have huge chances to have conflicts if you want to update a file that you changed in your repo and that has been modified in your back by that prehook, right ? Vincent Torri-- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] about removing trailing whitespaces
On Tue, Jun 21, 2011 at 11:56, Vincent Torri vto...@univ-evry.fr wrote: On Tue, 21 Jun 2011, Thomas Gstädtner wrote: On Sun, Jun 19, 2011 at 12:50, Albin Tonnerre albin.tonne...@gmail.com wrote: On Sun, 19 Jun 2011 12:38 +0200, Vincent Torri wrote : Hey another idea about trailing whitespaces : what about adding a rule in the toplevel Makefile.am, named for example remove-ws, that call find with a sed expression. I'll add it to Evil and test it a bit, and if nobody complains, i'll add it to the EFL + e. While it is nice to get rid of trailing whitespaces, I think that actively removing them periodically does more harm than good. In particular, it adds a lot of noise in the history and makes it harder to compare different revisions. If we indeed want to get rid of them, I'd be much happier if the SVN server simply rejected commits containing them (the same holds true for formatting - it's much better to ask people to submit properly formatted patches rather than going on a reformatting spree every now and then) Cheers, -- Albin Tonnerre I think putting this in a Makefile is a bad idea. Alternative: how about using a pre-commit hook in SVN that either removes whitespaces right away and sends a SPANK SPANK SPANK mail to the evil dev who did it, or just rejects the patch as Albin suggested. The first way is more proactive and should keep the commit/history clean. then, you will have huge chances to have conflicts if you want to update a file that you changed in your repo and that has been modified in your back by that prehook, right ? Vincent Torri That is true, but the Don't do that, nasty programmer. SPANK SPANK SPANK mail tells you that the hook triggered and also it hurts the programmer who did produce the trailing whitespaces. People learn best when it hurts :P It certainly is a rather harsh method to enforce this policy but it certainly would keep this out. (Of course pre-commit hooks always hurt, that's what they are for and that's why they should be used really sparsely). Also people having to clean their personal repos seems to be more desirable than having trivial commits to remove that stuff in the public history. -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] about removing trailing whitespaces
On Tue, 21 Jun 2011 13:43:13 +0200 Thomas Gstädtner tho...@gstaedtner.net wrote: That is true, but the Don't do that, nasty programmer. SPANK SPANK SPANK mail tells you that the hook triggered and also it hurts the programmer who did produce the trailing whitespaces. People learn best when it hurts :P Automated emails might just go to spam, don't hurt that much. Unless you intend to not accept the commit and make them do it over. That will hurt enough. -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. signature.asc Description: PGP signature -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] about removing trailing whitespaces
Hey another idea about trailing whitespaces : what about adding a rule in the toplevel Makefile.am, named for example remove-ws, that call find with a sed expression. I've found this: sed 's/[ \t]*$//' in that webpage : http://www.cyberciti.biz/tips/delete-leading-spaces-from-front-of-each-word.html I don't know if it's the best regexp, as i know almost nothing about them. So, we would just need to call from time to time that rule and commit just after if needed. At least, it would be done automatically on all files. I'll add it to Evil and test it a bit, and if nobody complains, i'll add it to the EFL + e. Vincent -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] about removing trailing whitespaces
On Sun, 19 Jun 2011 12:38 +0200, Vincent Torri wrote : Hey another idea about trailing whitespaces : what about adding a rule in the toplevel Makefile.am, named for example remove-ws, that call find with a sed expression. I'll add it to Evil and test it a bit, and if nobody complains, i'll add it to the EFL + e. While it is nice to get rid of trailing whitespaces, I think that actively removing them periodically does more harm than good. In particular, it adds a lot of noise in the history and makes it harder to compare different revisions. If we indeed want to get rid of them, I'd be much happier if the SVN server simply rejected commits containing them (the same holds true for formatting - it's much better to ask people to submit properly formatted patches rather than going on a reformatting spree every now and then) Cheers, -- Albin Tonnerre -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] about removing trailing whitespaces
On Sun, 19 Jun 2011, Albin Tonnerre wrote: On Sun, 19 Jun 2011 12:38 +0200, Vincent Torri wrote : Hey another idea about trailing whitespaces : what about adding a rule in the toplevel Makefile.am, named for example remove-ws, that call find with a sed expression. I'll add it to Evil and test it a bit, and if nobody complains, i'll add it to the EFL + e. While it is nice to get rid of trailing whitespaces, I think that actively removing them periodically does more harm than good. In particular, it adds a lot of noise in the history and makes it harder to compare different revisions. it would better than what we have today : some files that are committed when one think about those whitespaces, hence plenty of commits. At least, with that method, all the files of an EFL would be cleaned up in one call. Vincent If we indeed want to get rid of them, I'd be much happier if the SVN server simply rejected commits containing them (the same holds true for formatting - it's much better to ask people to submit properly formatted patches rather than going on a reformatting spree every now and then) Cheers, -- Albin Tonnerre -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
