[Bug 464430] Review Request: k12linux-quick-start-guide - Doc describing how to enable LTSP on Fedora Live LTSP.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=464430 --- Comment #43 from Warren Togami wtog...@redhat.com 2008-12-28 04:33:00 EDT --- One important correction to make. The text still says rpm -e of the old package name. I think we can release after the docs are reviewed one more time and corrected. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474787] Review Requrest: stxxl - C++ STL drop-in replacement for extremely large datasets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474787 --- Comment #4 from D Haley my...@yahoo.com 2008-12-28 06:09:26 EDT --- 3 week ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 472794] Review Request: onemind-commons-java - A common library used to support other onemind libraries
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=472794
D Haley my...@yahoo.com changed:
What|Removed |Added
CC||my...@yahoo.com
--- Comment #2 from D Haley my...@yahoo.com 2008-12-28 08:04:02 EDT ---
Please excuse any really dumb questions, I am somewhat new at this process
myself.
Not a formal review:
$RPM_BUILD_ROOT
Is there a preference for %{buildroot} for newer packages?
# This was obtained on 2008/11/24 using the following commands:
# cvs -d
:pserver:anonym...@onemind-commons.cvs.sourceforge.net:/cvsroot/onemind-commons
login
# cvs -d
:pserver:anonym...@onemind-commons.cvs.sourceforge.net:/cvsroot/onemind-commons
co commons-java/docs
Source1:%{name}-docs-20081124.tbz
Can you check out a particular CVS version, rather than HEAD -- that way the
md5sum can be verified as being consistent during review. I know the upstream
is dormant, so this is probably a bit picky.
BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XX)
I am unclear -- what is the reason for changing the BuildRoot? (Fix BuildRoot
to follow the latest guidelines) Can you point to a page (in your reply) for
the less up-to-date of us?
%description
This is a common library used to support other onemind libraries.
Is it possible to expand on this at all? Its identical to the summary --
doesn't really provide extra information to users. That said, I am not sure
what one would write here as an alternative.
%{_javadir}/*.jar
I think I would prefer %{name}.jar and {name}-%{version}.jar to be explicit.
This prevents any later inadvertant jar copying (another picky comment.)
Other than that, it seems OK to me. There are no jars, licence seems OK and GPL
header present in all java files.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 472792] Review Request: jempbox - A Java library that implements Adobe's XMP specification
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=472792 D Haley my...@yahoo.com changed: What|Removed |Added CC||my...@yahoo.com --- Comment #3 from D Haley my...@yahoo.com 2008-12-28 08:28:06 EDT --- XMP is adobe's new proprietary format that implements metadata in files, kinda like exif, but supposedly somehow better. It is a patented technology, however Adobe have provided a public patent licence http://www.adobe.com/devnet/xmp/pdfs/xmp_public_patent_license.pdf It seems OK to me, but IANAL -- are there any legal issues to consider? The clause A claim is necessarily infringed only when there is no reasonable way to avoid infringement of that claim when defining, creating or processing metadata. seems a bit nebulous. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 472794] Review Request: onemind-commons-java - A common library used to support other onemind libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=472794 --- Comment #3 from D Haley my...@yahoo.com 2008-12-28 08:32:48 EDT --- Oh, and you are missing the deps in the -javadoc package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478344] New: Review Request: f-spot 0.5.0.3 - Image manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: f-spot 0.5.0.3 - Image manager https://bugzilla.redhat.com/show_bug.cgi?id=478344 Summary: Review Request: f-spot 0.5.0.3 - Image manager Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: l...@foppiano.org QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://lfoppiano.fedorapeople.org/f-spot.spec SRPM URL: http://lfoppiano.fedorapeople.org/f-spot-0.5.0.3-1.fc10.src.rpm Description: I don't know if this package is already submutted, but I asked more time to update it, and I didn't receive any answer. I tried to extract a new spec file from the older one. The reason of my hurry is that the actual fedora 10 f-spot version is *not* usable and *not* stable. Thanks Luca -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478345] New: Review Request: mr - A multiple repository management tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: mr - A multiple repository management tool https://bugzilla.redhat.com/show_bug.cgi?id=478345 Summary: Review Request: mr - A multiple repository management tool Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: fab...@bernewireless.net QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://fab.fedorapeople.org/packages/SRPMS/mr.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/mr-0.35-1.fc9.src.rpm Project URL: http://kitenet.net/~joey/code/mr/ Description: The mr command can checkout, update, or perform other actions on a set of repositories as if they were one combined respository. It supports any combination of subversion, git, cvs, mecurial, bzr and darcs repositories, and support for other revision control systems can easily be added. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1023509 rpmlint output: [...@laptop024 noarch]$ rpmlint mr-0.35-1.fc9.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [...@laptop024 SRPMS]$ rpmlint mr-0.35-1.fc9.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456190] Review Request: dosemu - dos emulator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456190 --- Comment #17 from Jussi Lehtola jussi.leht...@iki.fi 2008-12-28 09:32:19 EDT --- ping, how's the package coming along? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478007] Review Request: vmware-requirements - Installs packages needed for VMware's virtualization programs to run
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478007 Jussi Lehtola jussi.leht...@iki.fi changed: What|Removed |Added CC||jussi.leht...@iki.fi --- Comment #7 from Jussi Lehtola jussi.leht...@iki.fi 2008-12-28 09:34:02 EDT --- I agree, we shouldn't include support metapackages for proprietary software in Fedora. If you want to do something for virtualization in Fedora, there's plenty of work to do e.g. with VirtualBox which is GPL. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456190] Review Request: dosemu - dos emulator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456190 --- Comment #18 from Justin Zygmont solarflo...@gmail.com 2008-12-28 10:07:10 EDT --- hi, just getting back to it now that I have my Fedora10 test system built, I definitely want to get this going -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477338] Review Request: php-pecl-imagick - Provides a wrapper to the ImageMagick library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=477338
Remi Collet fed...@famillecollet.com changed:
What|Removed |Added
CC||fed...@famillecollet.com
--- Comment #1 from Remi Collet fed...@famillecollet.com 2008-12-28 11:46:21
EDT ---
A few notes :
- License is PHP, not BSD (according to pecl.php.net)
- must use %setup -q -c (to not have package.xml outside the build tree)
- missing require for ABI check : php(zend-abi)
- should use %{pecl_install} and %{pecl_uninstall} when exists
- why PEAR in sumnary ?
- should add example directory in %doc (rather than each files)
Read : http://fedoraproject.org/wiki/Packaging/PHP
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477338] Review Request: php-pecl-imagick - Provides a wrapper to the ImageMagick library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=477338
--- Comment #2 from Remi Collet fed...@famillecollet.com 2008-12-28 11:53:53
EDT ---
Also
- use %{php_extdir} instead of %{_libdir}/php/modules
- use %{pecl_xmldir} instead of your %{xmldir}
As the package is available in my little testing repo, you can have a look to
http://rpms.famillecollet.com/SPEC/php-pecl-imagick.spec
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225852] Merge Review: gok
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225852
--- Comment #1 from Debarshi Ray debarshi@gmail.com 2008-12-28 12:05:45
EDT ---
MUST Items:
xx - rpmlint is unclean on RPM
+ [ri...@freebook devel]$ rpmlint gok
gok.x86_64: W: file-not-utf8 /usr/share/doc/gok-1.3.7/NEWS
gok.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/gok.schemas
gok.x86_64: W: non-standard-group Desktop/Accessibility
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
[ri...@freebook devel]$
+ rpmlint is unclean on SRPM
[ri...@freebook SPECS]$ rpmlint
/devel/rpmbuild/SRPMS/gok-2.25.2-1.fc9.src.rpm
gok.src:251: W: macro-in-%changelog _lib
gok.src: W: mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 19)
gok.src: W: non-standard-group Desktop/Accessibility
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
[ri...@freebook SPECS]$
OK - follows Naming Guidelines
OK - spec file is named as %{name}.spec
xx - package does not meet Packaging Guidelines
+ Please consider fixing the mixed use of tabs and spaces in the
BuildRequires and Requires tags.
+ Even though Fedora does not use the Group tag, please consider using one
from /usr/share/doc/rpm-4.4.2.3/GROUPS. User Interface/Desktops is a
probable choice. Orca also uses it.
+ 'Requires: htmlview' is needed because of Patch0.
+ Can gok-1.2.1-fixlogin.patch be removed from CVS?
+ Please convert /usr/share/doc/gok-1.3.7/NEWS from ISO-8859 to UTF-8. See:
https://fedoraproject.org/wiki/PackageMaintainers/Common_Rpmlint_Issues#file-not-utf8
+ According to
https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make you should
use 'make %{?_smp_mflags}' whenever possible. In this case since upstream
supports parallel builds you should use it.
+ To preserve timestamps you could consider using:
make install INSTALL=%{__install} -p DESTDIR=$RPM_BUILD_ROOT
+ 'rm -rf $RPM_BUILD_ROOT/var/scrollkeeper' is not needed on recent
distributions.
+ Replace %{_lib} with %%{_lib} in the %changelog.
OK - license meets Licensing Guidelines
OK - license field meets actual license
+ gok/keysym2ucs.c is in the public domain.
OK - upstream license file included in %doc
OK - spec file uses American English
OK - spec file is legible
OK - sources match upstream sources
xx - package does not build successfully
+ Fails to build due to missing BuildRequires:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1023579
OK - ExcludeArch not needed
xx - build dependencies incorrectly listed
+ 'BuildRequires: esound-devel' is missing.
+ 'BuildRequires: m4 perl(XML::Parser)' is redundant.
OK - locales handled properly
OK - no shared libraries
OK - package is not relocatable
xx - file and directory ownership
+ Since an icon has been installed under %{_datadir}/icons/hicolor there
should be a runtime dependency on hicolor-icon-theme. However, is this
icon really needed as there is no .desktop file?
+ The -devel sub-package should have 'Requires: gtk-doc' as it needs
/usr/share/gtk-doc.
OK - no duplicates in %file
OK - file permissions set properly
OK - %clean present
OK - macros used consistently
+ Both gok and %{name} used.
OK - contains code and permissable content
OK - -doc is not needed
OK - contents of %doc does not affect the runtime
OK - no header files
OK - no static libraries
OK - -devel has *.pc file and requires pkgconfig
OK - no library files
OK - -devel requires base package
OK - no libtool archives
OK - %{name}.desktop file not provided
+ Changelog contains rationale for excluding it.
OK - does not own files or directories owned by other packages
OK - buildroot correctly prepped
OK - all file names valid UTF-8
SHOULD Items:
OK - upstream provides license text
xx - no translations for description and summary
xx - package fails to build in mock
+ 'BuildRequires: esound-devel' is missing.
OK - package builds on all supported architectures
OK - package functions as expected
xx - scriptlets are not sane
+ There does not seem to be any .omf files provided by the package, yet
the scrollkeeper scriptlets are being used. Why? It looks like
gok-1.3.7-3.fc9.x86_64 had them.
OK - subpackages other than -devel are not needed
OK - pkgconfig files in -devel
OK - no file dependencies
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225808] Merge Review: gmime
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225808 Debarshi Ray debarshi@gmail.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|debarshi@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225865] Merge Review: gstreamer-plugins-base
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225865 Debarshi Ray debarshi@gmail.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|debarshi@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447738] Review Request: libzypp - ZYpp is a Linux software management engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=447738 Debarshi Ray debarshi@gmail.com changed: What|Removed |Added Flag||needinfo?(lvill...@binaryhe ||lix.net) --- Comment #14 from Debarshi Ray debarshi@gmail.com 2008-12-28 12:17:12 EDT --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 458402] Review Request: griffith - Media collection manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458402 Debarshi Ray debarshi@gmail.com changed: What|Removed |Added Flag||needinfo?(sunda...@redhat.c ||om) --- Comment #6 from Debarshi Ray debarshi@gmail.com 2008-12-28 12:17:43 EDT --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442714] Review Request: sat-solver - Satisfyability Solver library which can be used to compute inter-package dependencies.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=442714 Debarshi Ray debarshi@gmail.com changed: What|Removed |Added Flag||needinfo?(lvill...@binaryhe ||lix.net) --- Comment #38 from Debarshi Ray debarshi@gmail.com 2008-12-28 12:17:59 EDT --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478344] Review Request: f-spot 0.5.0.3 - Image manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478344 Jesse Keating jkeat...@redhat.com changed: What|Removed |Added Status|NEW |CLOSED CC||jkeat...@redhat.com Resolution||NOTABUG --- Comment #1 from Jesse Keating jkeat...@redhat.com 2008-12-28 12:30:38 EDT --- f-spot is already in Fedora. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447738] Review Request: libzypp - ZYpp is a Linux software management engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=447738 Christoph Wickert fed...@christoph-wickert.de changed: What|Removed |Added CC||fed...@christoph-wickert.de --- Comment #15 from Christoph Wickert fed...@christoph-wickert.de 2008-12-28 12:41:20 EDT --- BTW: Please remove the ZYpp is a from the summary tag, just Linux software management engine or A Linux software management engine is fine too. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478007] Review Request: vmware-requirements - Installs packages needed for VMware's virtualization programs to run
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478007 --- Comment #8 from Jason Tibbitts ti...@math.uh.edu 2008-12-28 13:07:13 EDT --- There are several issues here: It's a metapackage. We don't really want those in the distro. Yes, there are existing examples, but that doesn't make them good examples. The proper solution for this kind of thing would be to use a comps group instead. Of course, I'm sure that if you did commit a comps group for this, a line would form to revert it. Are there plans to do this for whatever other commercial software someone might install? Why not have -requirements metapackages for every other piece of software that nobody can bother to properly package for the distribution? We didn't even do this for flash (after having a similar discussion, mind you). Why would we do it for vmware? Honestly, it is the responsibility of the software vendor to do integration like this. I'm sure there are many in the community who would be willing to assist them in setting up a proper repository for Fedora users, with real packages that have proper dependencies. This half-way solution just doesn't do the job on many levels, and entangles the distribution with semi-official support for some random vendor's software. No, thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478318] Review Request: trac-privateticketsplugin - allow users to see only tickets they are involved with
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478318 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #4 from Kevin Fenzi ke...@tummy.com 2008-12-28 13:54:35 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478344] Review Request: f-spot 0.5.0.3 - Image manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478344 Tomasz Torcz zdzi...@irc.pl changed: What|Removed |Added CC||zdzi...@irc.pl --- Comment #2 from Tomasz Torcz zdzi...@irc.pl 2008-12-28 13:53:18 EDT --- Jesse f-spot is in Fedora, but old version. This review request is for update. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 466717] Review Request: python-cvxopt - A Python Package for Convex Optimization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466717 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #16 from Kevin Fenzi ke...@tummy.com 2008-12-28 14:06:33 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477839] Review Request: libxfce4menu - A freedesktop.org compliant menu implementation for Xfce
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477839 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #3 from Kevin Fenzi ke...@tummy.com 2008-12-28 14:03:21 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476936] Review Request: hello - Prints a Familiar, Friendly Greeting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476936 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #3 from Kevin Fenzi ke...@tummy.com 2008-12-28 14:02:31 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477990] Review Request: xfce4-settings - Settings Manager for Xfce
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477990 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #3 from Kevin Fenzi ke...@tummy.com 2008-12-28 14:05:27 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453839] Review Request: phatch - photo batch processor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453839 --- Comment #20 from Fedora Update System upda...@fedoraproject.org 2008-12-28 14:08:06 EDT --- phatch-0.1.6-3.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/phatch-0.1.6-3.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477866] Review Request: perl-Hardware-Verilog-Parser - Complete grammar for parsing Verilog code using perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477866 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #3 from Kevin Fenzi ke...@tummy.com 2008-12-28 14:08:24 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 471754] Review Request: virtaal - Localization and translation editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=471754 --- Comment #7 from Dwayne Bailey dwa...@translate.org.za 2008-12-28 14:10:43 EDT --- (In reply to comment #6) [FAIL]specfile is properly named, is cleanly written and uses macros consistently. The spec file should not have the version or at least not the revision number as part of its name, it should be virtaal.spec The name of the .spec file at the download link is just for tracking purposes, my local copy is named virtaal.spec. [FAIL]BuildRequires are proper. You should not have desktop-file-utils see: http://fedoraproject.org/wiki/NewMIMESystem Fixed [FAIL]rpmlint is silent. rpmlint virtaal-0.2-2.spec ../SRPMS/virtaal-0.2-2.fc10.src.rpm ../RPMS/noarch/virtaal-0.2-2.fc10.noarch.rpm virtaal.src: E: invalid-spec-name Rename Spec file See comment above virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/recent.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/about.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/support/__init__.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/widgets/label_expander.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/markup.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/document.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/formats.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/support/simplegeneric.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/tips.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/undo_buffer.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/unit_editor.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/store_grid.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/search_mode.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/unit_renderer.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/support/bijection.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/__init__.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/widgets/__init__.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/support/partial.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/support/openmailto.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/autocorrector.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/unit_layout.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/terminology.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/support/memoize.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/main_window.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/support/sorted_set.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/widgets/entry_dialog.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/pan_app.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/mode_selector.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/widgets/util.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/autocompletor.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/store_model.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/modes.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/support/set_enumerator.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/__version__.py 0644 virtaal.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtaal/rendering.py 0644 2 packages and 1 specfiles checked; 36 errors, 0 warnings. Should I fix these? These shouldn't be executable but they all have #! headers. [?]desktop files valid and installed properly. The version in the desktop file is 1.0 but 0.2 for the package is that correct? This is correct, it refers to the standard version, not the application
[Bug 477867] Review Request: perl-Perlilog - Verilog environment and IP core handling in Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477867 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #3 from Kevin Fenzi ke...@tummy.com 2008-12-28 14:09:24 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453839] Review Request: phatch - photo batch processor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453839 --- Comment #21 from Fedora Update System upda...@fedoraproject.org 2008-12-28 14:10:40 EDT --- phatch-0.1.6-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/phatch-0.1.6-3.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477871] Review Request: perl-ModelSim-List - Analyse the 'list' output of the ModelSim simulator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477871 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #3 from Kevin Fenzi ke...@tummy.com 2008-12-28 14:10:28 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477854] Review Request: yersinia - Network protocols tester and attacker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477854 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #5 from Kevin Fenzi ke...@tummy.com 2008-12-28 14:12:15 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476374] Review Request: python-oasa - python library for manipulation of chemical formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476374 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #18 from Kevin Fenzi ke...@tummy.com 2008-12-28 14:15:48 EDT --- cvs done. (without jkeating in initialcc) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455164] Review-Request: NaturalDocs - Documentation generator for multiple programming languages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=455164 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #4 from Kevin Fenzi ke...@tummy.com 2008-12-28 14:16:46 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478294] Review Request: fswebcam - Tiny and flexible webcam program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478294 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #4 from Kevin Fenzi ke...@tummy.com 2008-12-28 14:13:04 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478344] Review Request: f-spot 0.5.0.3 - Image manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478344 --- Comment #3 from Jesse Keating jkeat...@redhat.com 2008-12-28 14:17:09 EDT --- That's not how we do things. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474827] Review Request: xteddy - Tool to sit around silently, look cute, and make you smile
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474827 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #8 from Kevin Fenzi ke...@tummy.com 2008-12-28 14:17:59 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 438543] Review Request: Synopsis - Source-code introspection tool.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=438543 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #62 from Kevin Fenzi ke...@tummy.com 2008-12-28 14:20:41 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226715] Review Request: irsim - Switch-level simulator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226715 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #23 from Kevin Fenzi ke...@tummy.com 2008-12-28 14:23:13 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452413] Review Request: bkchem - Chemical drawing program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452413 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #44 from Kevin Fenzi ke...@tummy.com 2008-12-28 14:22:01 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226725] Review Request: netgen - LVS netlist comparison tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226725 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #52 from Kevin Fenzi ke...@tummy.com 2008-12-28 14:23:40 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 223591] Review Request: Magic - A very capable VLSI layout tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=223591 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #27 from Kevin Fenzi ke...@tummy.com 2008-12-28 14:24:11 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478344] Review Request: f-spot 0.5.0.3 - Image manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478344 --- Comment #4 from Luca Foppiano l...@foppiano.org 2008-12-28 14:40:43 EDT --- right. but... I opened bug asking to update on Dicember 14th (https://bugzilla.redhat.com/show_bug.cgi?id=476412). I also contact the mantainer directly via IRC, and I gave him my collaboration...but...no replies. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478344] Review Request: f-spot 0.5.0.3 - Image manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478344 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added CC|fedora-package-rev...@redha |nigjo...@redhat.com |t.com | Component|Package Review |f-spot AssignedTo|nob...@fedoraproject.org|nigjo...@redhat.com --- Comment #5 from Jason Tibbitts ti...@math.uh.edu 2008-12-28 16:00:47 EDT --- So just filing random bugs under the wrong component is supposed to help matters? Package reviews are for new packages entering the distribution. F-spot is already in the distribution, so it is not appropriate to file a package review ticket. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225613] Merge Review: beecrypt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225613 Robert Scheck red...@linuxnetz.de changed: What|Removed |Added Status|NEW |CLOSED Resolution||CURRENTRELEASE AssignedTo|nob...@fedoraproject.org|redhat-bugzi...@linuxnetz.d ||e Flag||fedora-review+ --- Comment #2 from Robert Scheck red...@linuxnetz.de 2008-12-28 16:04:37 EDT --- Package already got successfully reviewed with bug #438262 - closing hereby with the same state. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477854] Review Request: yersinia - Network protocols tester and attacker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477854 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2008-12-28 16:11:29 EDT --- yersinia-0.7.1-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/yersinia-0.7.1-2.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478318] Review Request: trac-privateticketsplugin - allow users to see only tickets they are involved with
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478318 --- Comment #5 from Fedora Update System upda...@fedoraproject.org 2008-12-28 16:09:27 EDT --- trac-privateticketsplugin-1.1.1-0.2.svn5068.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/trac-privateticketsplugin-1.1.1-0.2.svn5068.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225749] Merge Review: fetchmail
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225749 Robert Scheck redhat-bugzi...@linuxnetz.de changed: What|Removed |Added CC||vcrho...@redhat.com --- Comment #2 from Robert Scheck redhat-bugzi...@linuxnetz.de 2008-12-28 16:08:17 EDT --- The fetchmail initscript for daemon functionality needs to get installed that users can use it more easily in the future. Maybe the initscript itself needs some love before, possible (currently somewhere in contrib inside of tarball). Adding current fetchmail maintainer on Cc, that he gets aware about this bug report... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477854] Review Request: yersinia - Network protocols tester and attacker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477854 --- Comment #6 from Fabian Affolter fab...@bernewireless.net 2008-12-28 16:10:38 EDT --- Thank you guys for the review and the cvs. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477854] Review Request: yersinia - Network protocols tester and attacker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477854 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2008-12-28 16:11:32 EDT --- yersinia-0.7.1-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/yersinia-0.7.1-2.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478318] Review Request: trac-privateticketsplugin - allow users to see only tickets they are involved with
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478318 --- Comment #6 from Fedora Update System upda...@fedoraproject.org 2008-12-28 16:11:02 EDT --- trac-privateticketsplugin-1.1.1-0.2.svn5068.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/trac-privateticketsplugin-1.1.1-0.2.svn5068.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478294] Review Request: fswebcam - Tiny and flexible webcam program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478294 --- Comment #5 from Fabian Affolter fab...@bernewireless.net 2008-12-28 16:12:32 EDT --- Thanks guys for the cvs and the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478294] Review Request: fswebcam - Tiny and flexible webcam program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478294 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2008-12-28 16:14:11 EDT --- fswebcam-20070108-3.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/fswebcam-20070108-3.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478294] Review Request: fswebcam - Tiny and flexible webcam program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478294 --- Comment #6 from Fedora Update System upda...@fedoraproject.org 2008-12-28 16:14:08 EDT --- fswebcam-20070108-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/fswebcam-20070108-3.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226426] Merge Review: spamassassin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226426 Robert Scheck red...@linuxnetz.de changed: What|Removed |Added CC||fedora-perl-devel-l...@redh ||at.com Flag||needinfo?(fedora-perl-devel ||-l...@redhat.com) --- Comment #13 from Robert Scheck red...@linuxnetz.de 2008-12-28 16:20:40 EDT --- The guys from the Perl SIG or similar shall explain and decide whether it is needed here, adding hereby and requesting info regarding 444 vs. 644. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226482] Merge Review: tcp_wrappers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226482 Robert Scheck redhat-bugzi...@linuxnetz.de changed: What|Removed |Added CC||tjano...@redhat.com --- Comment #9 from Robert Scheck redhat-bugzi...@linuxnetz.de 2008-12-28 16:26:19 EDT --- Adding Tomas Janousek on Cc because of being the current maintainer. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457947] Review Request: oldstandard-sfd-fonts - Old Standard Fonts
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457947
--- Comment #24 from Martin-Gomez Pablo pablo.martin-go...@laposte.net
2008-12-28 16:22:16 EDT ---
* I don't understand the following code, eventually, it should be
stringserif/string, no ?
match target=pattern
test name=family
stringsans-serif/string
/test
/match
* Put the following codes in section %prep after %setup (and not in %build or
in %install):
for txt in OFL* ; do
sed 's/\r//' $txt $txt.new
touch -r $txt $txt.new
mv $txt.new $txt
done
install -m 644 -p %{SOURCE2} .
* Do the %post and the %postun are useful ? I just find them in some fonts and
no wiki page about it. Nicolas, an explanation ?
* Now, the change needed by the new guideline:
- Add the following in the right place :
BuildRequires: fontpackages-devel
Requires: fontpackages-filesystem
- Remove %define fontdir %{_datadir}/fonts/%{fontname} and replace all the
%{fontdir} by %{_fontdir} (it's now an official macro)
- Replace %config(noreplace) %{fontconfdir}/60-%{fontname}.conf and
%{fontdir}/*.ttf by %_font_pkg -f 60-%{fontname}.conf *.ttf
(- There is something else with templatedir macro, but i don't understand how
it work, i'll see)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455164] Review-Request: NaturalDocs - Documentation generator for multiple programming languages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=455164 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #5 from Lubomir Rintel lkund...@v3.sk 2008-12-28 16:42:16 EDT --- Imported and built. Thanks Kevin! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226380] Merge Review: rsync
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226380 Robert Scheck red...@linuxnetz.de changed: What|Removed |Added CC||sso...@redhat.com --- Comment #4 from Robert Scheck red...@linuxnetz.de 2008-12-28 16:51:10 EDT --- Looks like Simo Sorce sso...@redhat.com is the current rsync maintainer; adding hereby to Cc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226380] Merge Review: rsync
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226380 Robert Scheck red...@linuxnetz.de changed: What|Removed |Added Attachment #305156|0 |1 is obsolete|| --- Comment #5 from Robert Scheck red...@linuxnetz.de 2008-12-28 16:52:41 EDT --- Created an attachment (id=327903) -- (https://bugzilla.redhat.com/attachment.cgi?id=327903) Patch for rsync.spec to make rpmlint silent Simo, can you please apply this patch to rsync? It will solve the most review issues so that we maybe can finish this soon. One rpmlint issue seems to be left, that can be ignored, %config() is not worse in %changelog, it is not expanded anyway. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226380] Merge Review: rsync
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226380 Robert Scheck red...@linuxnetz.de changed: What|Removed |Added AssignedTo|e...@eh3.com |redhat-bugzi...@linuxnetz.d ||e Flag||needinfo?(sso...@redhat.com ||) --- Comment #6 from Robert Scheck red...@linuxnetz.de 2008-12-28 16:57:37 EDT --- As Ed made no review noise for nearly two years, I'm now and hereby silently overtaking the review. I think, the patch #327903 should bring us to the way of succeeding the review hopefully very soon. Simo, please take action... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226319] Merge Review: procps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226319 Robert Scheck red...@linuxnetz.de changed: What|Removed |Added Status|NEW |CLOSED Fixed In Version||3.2.7-22 Resolution||CURRENTRELEASE AssignedTo|nob...@fedoraproject.org|redhat-bugzi...@linuxnetz.d ||e Flag||fedora-review+ --- Comment #11 from Robert Scheck red...@linuxnetz.de 2008-12-28 17:09:09 EDT --- The MUST changes have been applied to CVS some time ago already. The license stuff has been clarified by Tom some time ago and is in CVS acceptable, too. Thanks to Michael, Jason, Tom and Tomas for their work: APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 426387] Merge reviews to be completed for F9
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=426387 Bug 426387 depends on bug 226319, which changed state. Bug 226319 Summary: Merge Review: procps https://bugzilla.redhat.com/show_bug.cgi?id=226319 What|Old Value |New Value Status|NEW |CLOSED Resolution||CURRENTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226542] Merge Review: words
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226542 Robert Scheck red...@linuxnetz.de changed: What|Removed |Added AssignedTo|red...@linuxnetz.de |redhat-bugzi...@linuxnetz.d ||e -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478359] New: Review Request: ethstatus - Console-based ethernet statistics monitor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: ethstatus - Console-based ethernet statistics monitor https://bugzilla.redhat.com/show_bug.cgi?id=478359 Summary: Review Request: ethstatus - Console-based ethernet statistics monitor Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: fab...@bernewireless.net QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://fab.fedorapeople.org/packages/SRPMS/ethstatus.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/ethstatus-0.4.3-1.fc9.src.rpm Description: EthStatus is a simple, easy to use program for displaying commonly needed / wanted statistics in real time about ingoing and outgoing traffic that is usually hard to find, with a simple, efficient interface. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1024042 rpmlint output: [...@laptop024 i386]$ rpmlint ethstatus* 2 packages and 0 specfiles checked; 0 errors, 0 warnings. [...@laptop024 SRPMS]$ rpmlint ethstatus-0.4.3-1.fc9.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474827] Review Request: xteddy - Tool to sit around silently, look cute, and make you smile
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474827 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #9 from Lubomir Rintel lkund...@v3.sk 2008-12-28 17:31:58 EDT --- Imported and built. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476536] Review Request: zapplet - Zenoss monitoring tray applet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476536 --- Comment #3 from Brian Pepple bdpep...@gmail.com 2008-12-28 17:36:50 EDT --- Couple of quick items: 1. The requires on python is unnecessary. The requires: python(abi) = 2.6 in the build log does this for you. 2. Likewise the BR on python-setuptools is also unnecessary. The -devel package will pull this in for you. 3. I haven't had a chance to look at the source closely yet, but I'm thinking the requires should be pygtk2, not gtk2. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476536] Review Request: zapplet - Zenoss monitoring tray applet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476536 --- Comment #4 from David Nalley da...@gnsa.us 2008-12-28 17:57:18 EDT --- Brian: I believe I have addressed all of the above items, and you are correct about pygtk2. New spec file: http://ke4qqq.fedorapeople.org/zapplet.spec New SRPM: http://ke4qqq.fedorapeople.org/zapplet-0.1-3.src.rpm [ke4...@nalleyt61 SPECS]$ rpmlint ../SRPMS/zapplet-0.1-3.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [ke4...@nalleyt61 SPECS]$ rpmlint ../RPMS/noarch/zapplet-0.1-3.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [ke4...@nalleyt61 SPECS]$ rpmlint ./zapplet.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings Thanks for taking the time to review this package! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478362] New: Review Request: fmirror - Mirror directories from ftp servers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: fmirror - Mirror directories from ftp servers https://bugzilla.redhat.com/show_bug.cgi?id=478362 Summary: Review Request: fmirror - Mirror directories from ftp servers Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: fab...@bernewireless.net QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://fab.fedorapeople.org/packages/SRPMS/fmirror.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/fmirror-0.8.4-1.fc9.src.rpm Description: fmirror is a C program to mirror a directory tree from a remote ftp server. It allows regexp (regular expression) pattern matching to help target files that are to be included and excluded. It uses a combination of timestamp, file size and file permissions to decide what files to transfer from the ftp server. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1024075 rpmlint output: [...@laptop024 i386]$ rpmlint fmirror* 2 packages and 0 specfiles checked; 0 errors, 0 warnings. [...@laptop024 SRPMS]$ rpmlint fmirror-0.8.4-1.fc9.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474535] Review Request: clamtk - Easy to use front-end for ClamAV
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474535 --- Comment #6 from Fabian Affolter fab...@bernewireless.net 2008-12-28 18:31:09 EDT --- ClamTk 4.08 released -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226511] Merge Review: unifdef
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226511 Robert Scheck red...@linuxnetz.de changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||CURRENTRELEASE --- Comment #6 from Robert Scheck red...@linuxnetz.de 2008-12-28 18:34:07 EDT --- David, if you don't care about this package, please orphan it according to the Fedora Guidelines. Anyway, the package already got reviewed when reading bug #190362 and bug #189937. Warren set the flag for this review request, too - closing now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 359941] Review Request: drupal-calendar - This module will display any Views date field in calendar formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=359941 Sven Lankes s...@lank.es changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|s...@lank.es --- Comment #8 from Sven Lankes s...@lank.es 2008-12-28 18:48:18 EDT --- I'm going to review this. As far as I can see the only hint as to under which license the code is seems to be the included copy of the GPLv2 - not enough to be sure IMO. I have opened a bug on the drupal-site requesting 'proper' license-information being added: http://drupal.org/node/351895 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476440] Review Request: latexdiff - Determine and mark up significant differences between latex files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476440 --- Comment #6 from Dan Kenigsberg dan...@cs.technion.ac.il 2008-12-28 18:58:03 EDT --- Ok, let's use version 0.5. I hope I got all your (*)s sorted. rpm passes rpmlint cleanly now. I did not see how the supplied Makefile could work. It relates to non-existing filenames and ignores the tarball directpry structure. avoiding seemed simpler than fixing it. using latexdiff is so simple that I don't think the example is really useful. I have never used latexdiff-wrap, and not anxious to try. http://www.cs.technion.ac.il/~danken/latexdiff-0.5-1.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 471754] Review Request: virtaal - Localization and translation editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=471754 Brennan Ashton bash...@brennanashton.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #8 from Brennan Ashton bash...@brennanashton.com 2008-12-28 19:18:58 EDT --- The non-executable is not and issue. Thanks for the pointer on the version number on the desktop file, I have not seen that variable used before. I did a test on it and is seems to work correctly. It is now: APPROVED. Apply for CVS. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478364] New: Review Request: perl-Verilog-Readmem - Verilog code generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-Verilog-Readmem - Verilog code generator https://bugzilla.redhat.com/show_bug.cgi?id=478364 Summary: Review Request: perl-Verilog-Readmem - Verilog code generator Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: cgoo...@yahoo.com.au QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://chitlesh.fedorapeople.org/RPMS/perl-Verilog-Readmem.spec SRPM URL: http://chitlesh.fedorapeople.org/RPMS/perl-Verilog-Readmem-0.02-1.fc10.src.rpm Description: Provides an object-oriented environment to generate Verilog code for modules and testbenches. The Verilog::CodeGen module provides two functions, one to create a code template and another to create a Perl module which contains the device library. This module , DeviceLibs::YourDesign, provides the class methods and contains the objects for every Verilog module; the objects are created based on a fixed template. The purpose of this module is to allow the generation of customized Verilog modules. A Verilog module can have a large number of parameters like input and output bus width, buffer depth, signal delay etc. The code generator allows to create an object that will generate the Verilog module code for arbitraty values of the parameters. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478365] New: Review Request: perl-Verilog-CodeGen - Verilog code generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-Verilog-CodeGen - Verilog code generator https://bugzilla.redhat.com/show_bug.cgi?id=478365 Summary: Review Request: perl-Verilog-CodeGen - Verilog code generator Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: cgoo...@yahoo.com.au QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://chitlesh.fedorapeople.org/RPMS/perl-Verilog-CodeGen.spec SRPM URL: http://chitlesh.fedorapeople.org/RPMS/perl-Verilog-CodeGen-0.9.4-1.fc10.src.rpm Description: Provides an object-oriented environment to generate Verilog code for modules and testbenches. The Verilog::CodeGen module provides two functions, one to create a code template and another to create a Perl module which contains the device library. This module , DeviceLibs::YourDesign, provides the class methods and contains the objects for every Verilog module; the objects are created based on a fixed template. The purpose of this module is to allow the generation of customized Verilog modules. A Verilog module can have a large number of parameters like input and output bus width, buffer depth, signal delay etc. The code generator allows to create an object that will generate the Verilog module code for arbitraty values of the parameters. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478364] Review Request: perl-Verilog-Readmem - Parse Verilog $readmemh or $readmemb text file
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478364 Chitlesh GOORAH cgoo...@yahoo.com.au changed: What|Removed |Added Summary|Review Request: |Review Request: |perl-Verilog-Readmem - |perl-Verilog-Readmem - |Verilog code generator |Parse Verilog $readmemh or ||$readmemb text file --- Comment #1 from Chitlesh GOORAH cgoo...@yahoo.com.au 2008-12-28 19:40:48 EDT --- sorry description is: %description The Verilog Hardware Description Language (HDL) provides a convenient way to load a memory during logic simulation. The $readmemh() and $readmemb() system tasks are used in the HDL source code to import the contents of a text file into a memory variable. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478345] Review Request: mr - A multiple repository management tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478345 Sven Lankes s...@lank.es changed: What|Removed |Added CC||s...@lank.es --- Comment #1 from Sven Lankes s...@lank.es 2008-12-28 19:42:56 EDT --- mr help doesn't work - it tries to call man -l which doesn't exist in the current fedora man-command. It's probably easiest to just patch out the output of use mr help for man page -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442714] Review Request: sat-solver - Satisfyability Solver library which can be used to compute inter-package dependencies.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=442714 Lorenzo Villani lvill...@binaryhelix.net changed: What|Removed |Added Flag|needinfo?(lvill...@binaryhe | |lix.net)| --- Comment #39 from Lorenzo Villani lvill...@binaryhelix.net 2008-12-28 19:50:15 EDT --- SPEC URL: http://fedorapeople.org/gitweb?p=arbiter/public_git/rpm.git;a=blob;f=libs/sat-solver/sat-solver.spec;hb=HEAD SRPM URL: http://fedorapeople.org/~arbiter/srpm/sat-solver-0.9.6-1.fc10.src.rpm * Sun Dec 28 2008 Lorenzo Villani lvill...@binaryhelix.net - 0.9.6-1 - 0.9.6 - sat-solver-perl - perl-sat-solver - sat-solver-python - python-sat-solver - fix weird .spec file permissions - fix mixed use of spaces and tabs - depend on rpm 4.6.0 (ie: build on Fedora 10 only) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447738] Review Request: libzypp - ZYpp is a Linux software management engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=447738 Lorenzo Villani lvill...@binaryhelix.net changed: What|Removed |Added Flag|needinfo?(lvill...@binaryhe | |lix.net)| --- Comment #16 from Lorenzo Villani lvill...@binaryhelix.net 2008-12-28 19:54:30 EDT --- (In reply to comment #13) Any response? They applied my patches to sat-solver (in SVN trunk/ - not in stable releases, yet) but still working on libzypp and zypper, we'll have to wait more... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476449] Review Request: perl-SystemC-Vregs - Utility routines used by vregs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476449 --- Comment #2 from Chitlesh GOORAH cgoo...@yahoo.com.au 2008-12-28 20:00:58 EDT --- Spec URL: http://chitlesh.fedorapeople.org/RPMS/perl-SystemC-Vregs.spec SRPM URL: http://chitlesh.fedorapeople.org/RPMS/perl-SystemC-Vregs-1.460-1.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447738] Review Request: libzypp - ZYpp is a Linux software management engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=447738 --- Comment #17 from Lorenzo Villani lvill...@binaryhelix.net 2008-12-28 20:10:59 EDT --- (In reply to comment #15) BTW: Please remove the ZYpp is a from the summary tag, just Linux software management engine or A Linux software management engine is fine too. SPEC URL: http://fedorapeople.org/gitweb?p=arbiter/public_git/rpm.git;a=blob;f=libs/libzypp/libzypp.spec;hb=HEAD SRPM URL: http://fedorapeople.org/~arbiter/srpm/libzypp-4.28.24.1-1.fc10.src.rpm * Mon Dec 29 2008 Lorenzo Villani lvill...@binaryhelix.net - 4.28.24.1-1 - 4.28.24.1 - trivial fix to Summary -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478368] New: Review Request: linsmith - a Smith Charting program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: linsmith - a Smith Charting program https://bugzilla.redhat.com/show_bug.cgi?id=478368 Summary: Review Request: linsmith - a Smith Charting program Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: cgoo...@yahoo.com.au QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://chitlesh.fedorapeople.org/RPMS/linsmith.spec SRPM URL: http://chitlesh.fedorapeople.org/RPMS/linsmith-0.99.11-1.fc10.src.rpm Description: linSmith is a Smith Charting program. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478368] Review Request: linsmith - a Smith Charting program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478368 --- Comment #1 from Chitlesh GOORAH cgoo...@yahoo.com.au 2008-12-28 20:37:03 EDT --- Scratch build https://koji.fedoraproject.org/koji/taskinfo?taskID=1024118 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478364] Review Request: perl-Verilog-Readmem - Parse Verilog $readmemh or $readmemb text file
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478364 Brennan Ashton bash...@brennanashton.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||bash...@brennanashton.com AssignedTo|nob...@fedoraproject.org|bash...@brennanashton.com Flag||fedora-review? --- Comment #2 from Brennan Ashton bash...@brennanashton.com 2008-12-28 21:06:48 EDT --- I have started the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478372] New: Review request: Mathgl - Scientific plotting library.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review request: Mathgl - Scientific plotting library. https://bugzilla.redhat.com/show_bug.cgi?id=478372 Summary: Review request: Mathgl - Scientific plotting library. Product: Fedora Version: 10 Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: my...@yahoo.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora SPEC URL: http://dhd.selfip.com/427e/mathgl.spec SRPM URL: http://dhd.selfip.com/427e/mathgl-1.8-1.fc10.src.rpm Description: Mathgl is a cross-platform library for making high-quality scientific graphics. It provides fast data plotting and handling of large data arrays, as well as window and console modes and for easy embedding into other programs. Mathgl integrates into fltk, wxWidgets, qt and opengl applications Rpmlint: Empty for spec file and SRPM. RPM returns one warning, notification has been sent upstream. mathgl.i386: W: shared-lib-calls-exit /usr/lib/libmgl-glut.so.5.0.0 e...@glibc_2.0 This library package calls exit() or _exit(), probably in a non-fork() context. Doing so from a library is strongly discouraged - when a library function calls exit(), it prevents the calling program from handling the error, reporting it to the user, closing files properly, and cleaning up any state that the program has. It is preferred for the library to return an actual error code and let the calling program decide how to handle the situation. koji scratch: All arches appear to build succesfully. URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=1024210 Project page: http://mathgl.sourceforge.net/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225852] Merge Review: gok
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225852
--- Comment #2 from Debarshi Ray debarshi@gmail.com 2008-12-28 22:22:32
EDT ---
(In reply to comment #1)
xx - file and directory ownership
+ Since an icon has been installed under %{_datadir}/icons/hicolor there
should be a runtime dependency on hicolor-icon-theme. However, is this
icon really needed as there is no .desktop file?
Ofcourse it is needed for the icons in the window titles. So please add the
dependency on hicolor-icon-theme.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478372] Review request: Mathgl - Scientific plotting library.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478372 --- Comment #1 from Rex Dieter rdie...@math.unl.edu 2008-12-28 22:48:59 EDT --- Just a few drive-by review recommendations: 1. drop hard-coded Requires: freeglut hdf5 fltk qt these should all get picked up automatically 2. use BuildRequires: qt4-devel (it's unambiguous which version of qt you're using) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478372] Review request: Mathgl - Scientific plotting library.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=478372
--- Comment #2 from Rex Dieter rdie...@math.unl.edu 2008-12-28 22:54:25 EDT
---
OK, a few other areas that NEEDSWORK:
3. static libs are preferably omitted. But if included at all (with
justification), must be packaged separately, into something like
%{name}-devel-static. .la files should go with the statics libs (omitted, or
packaged along with the static libs)
4. %_includedir/ltdl.h conflicts with system libtool-ltdl-devel. Omit from
packaging
5. replace
%{_includedir}/mgl/*.h
with (something like)
%{_includedir}/mgl/
so parent dir is owned too.
6. Why does -devel have a separate (and invalid)
License: GPL
?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460727] Review Request: gnujump - A jumping game which is a clone of xjump
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460727 Debarshi Ray debarshi@gmail.com changed: What|Removed |Added Flag||needinfo?(boni.vi...@gmail. ||com) --- Comment #6 from Debarshi Ray debarshi@gmail.com 2008-12-28 23:17:55 EDT --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478365] Review Request: perl-Verilog-CodeGen - Verilog code generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478365 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||panem...@gmail.com AssignedTo|nob...@fedoraproject.org|panem...@gmail.com Flag||fedora-review? --- Comment #1 from Parag AN(पराग) panem...@gmail.com 2008-12-29 00:09:17 EDT --- Review: + package builds in mock (rawhide i386). koji Build = http://koji.fedoraproject.org/koji/taskinfo?taskID=1024296 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 6f036f2906bd0993b02792cacb09f309 Verilog-CodeGen-0.9.4.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave ok 1 ok 2 ok 3 + Package perl-Verilog-CodeGen-0.9.4-1.fc11 = Provides: perl(DeviceLibs::DesignName) perl(Verilog::CodeGen) perl(Verilog::CodeGen::Gui) Requires: perl(Cwd) perl(DeviceLibs::DesignName) perl(Verilog::CodeGen) perl(lib) perl(sigtrap) perl(strict) perl(vars) As this package don't have any BR on perl-verilog and perl-Verilog-Readmem, I reviewed this package easily. But I prefer to wait to approve this till reviews 476386 and 476364 will get finished and built in rawhide at least. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478368] Review Request: linsmith - a Smith Charting program
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=478368
Parag AN(पराग) panem...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||panem...@gmail.com
AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
Flag||fedora-review?
--- Comment #2 from Parag AN(पराग) panem...@gmail.com 2008-12-29 00:41:00
EDT ---
33256af1c310309da6f03f2a2fe8a869 linsmith-0.99.11.tar.gz
http://koji.fedoraproject.org/koji/taskinfo?taskID=1024295
1) 'desktop-file-install --vendor=fedora \' is obsolete for new packages.
Check https://fedoraproject.org/wiki/TomCallaway/DesktopFileVendor
2) install command should be
%{__make} install DESTDIR=%{buildroot} INSTALL=install -p
3)gtk-update-icon-cache scriptlet not needed as no icons installed in
%{_datadir}/icons/hicolor
4) Also, I see its not needed to have update-desktop-database scriptlet. from
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database ==
Use this when a desktop entry has a 'MimeType key.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478359] Review Request: ethstatus - Console-based ethernet statistics monitor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478359 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||panem...@gmail.com AssignedTo|nob...@fedoraproject.org|panem...@gmail.com Flag||fedora-review+ --- Comment #1 from Parag AN(पराग) panem...@gmail.com 2008-12-29 00:52:23 EDT --- Review: + package builds in mock. Koji build = http://koji.fedoraproject.org/koji/taskinfo?taskID=1024302 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 088412ddff67f50e32bc9d45e56b2658 ethstatus_0.4.3.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478368] Review Request: linsmith - a Smith Charting program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478368 --- Comment #3 from Parag AN(पराग) panem...@gmail.com 2008-12-29 00:54:00 EDT --- Add some more description also in %description -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 471754] Review Request: virtaal - Localization and translation editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=471754 Dwayne Bailey dwa...@translate.org.za changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Dwayne Bailey dwa...@translate.org.za 2008-12-29 02:37:00 EDT --- New Package CVS Request === Package Name: virtaal Short Description: Localization and translation editor Owners: dwayne Branches: F-9 F-10 EL-4 EL-5 OLPC-2 OLPC-3 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478372] Review request: Mathgl - Scientific plotting library.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=478372
--- Comment #3 from D Haley my...@yahoo.com 2008-12-29 02:38:21 EDT ---
SPEC URL: http://dhd.selfip.com/427e/mathgl-2.spec
SRPM URL: http://dhd.selfip.com/427e/mathgl-1.8-2.fc10.src.rpm
rpmlint output (spec, SRPM and RPM):
mathgl.i386: W: shared-lib-calls-exit /usr/lib/libmgl-glut.so.5.0.0
e...@glibc_2.0
1. drop hard-coded
Requires: freeglut hdf5 fltk qt
these should all get picked up automatically
Done. Might be a stupid lack of understanding on my part, but I do not
understand how these can be picked up automatically if the only Requires is
gsl. Normally rpmlint warns if you have redundant requires. I.e if A depends
on C, and you Requires: A, C then rpmlint says that Requires: C is not
needed. Where is it obtaining the automatic Requires from?
2. use
BuildRequires: qt4-devel
(it's unambiguous which version of qt you're using)
Done.
3. static libs are preferably omitted. But if included at all (with
justification), must be packaged separately, into something like
%{name}-devel-static. .la files should go with the statics libs (omitted, or
packaged along with the static libs)
configure now has --disable-static --enable-shared passed as a flag.
4. %_includedir/ltdl.h conflicts with system libtool-ltdl-devel. Omit from
packaging
I would have found that out if i had tried to install the RPM, wouldn't I? I
will add this to my pre-request checks for next time around.
Building libtool-ltdl that accompanies this package has been disabled.
5. replace
%{_includedir}/mgl/*.h
with (something like)
%{_includedir}/mgl/
so parent dir is owned too.
Done.
6. Why does -devel have a separate (and invalid)
License: GPL
?
Because I stuffed up :). Removed.
Latest koji scratch:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1024362
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478381] New: Review Request: sugar-tamtam-common - Resources and python libraries for Sugar TamTam activities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: sugar-tamtam-common - Resources and python libraries for Sugar TamTam activities https://bugzilla.redhat.com/show_bug.cgi?id=478381 Summary: Review Request: sugar-tamtam-common - Resources and python libraries for Sugar TamTam activities Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: alsr...@member.fsf.org QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://people.sugarlabs.org/~alsroot/RPM/SPECS/sugar-tamtam-common.spec SRPM URL: http://people.sugarlabs.org/~alsroot/RPM/SRPMS/sugar-tamtam-common-52-1.20081229.fc10.src.rpm Description: TamTam is a suite of four music and sound related activities for theSugar. TamTam is written in python with some C functions for speed-critical services.The audio engine for TamTam is Csound. rpmlint claims for right group, but other sugar activities also use Sugar/Activities group COPYING.txt says GPLv3 but TamTam*.activity/activity/activity.info says GPLv2+, so I use GPLv2+ in spec package demands sugar* and olpcsound packages from updates-testing repo but current olpcsound has unmets, thus I built sugar*.src.rpm from updates-testing and used them from local repo -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
