[Bug 192413] libdhcp : IPv6 and IPv4 DHCP client and network configuration library API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: libdhcp : IPv6 and IPv4 DHCP client and network configuration library API https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192413 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Core |Fedora -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192413] libdhcp : IPv6 and IPv4 DHCP client and network configuration library API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: libdhcp : IPv6 and IPv4 DHCP client and network configuration library API https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192413 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||CURRENTRELEASE Fixed In Version||libdhcp-1.2 --- Additional Comments From [EMAIL PROTECTED] 2006-06-08 14:15 EST --- RE: dbus is way too heavy-weight for some of the really early boot places where you need to get a network. Perhaps so - I will ensure that the next ISC DHCP version that we ship, which will incorporate DHCPv6 support and D-BUS support natively, provides a sane, lightweight library interface for anaconda. Since libdhcp is now in Fedora Core, and is apparently being used by anaconda, this bug can now be closed as CURRENTRELEASE. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192413] libdhcp : IPv6 and IPv4 DHCP client and network configuration library API
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: libdhcp : IPv6 and IPv4 DHCP client and network configuration library
API
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192413
--- Additional Comments From [EMAIL PROTECTED] 2006-06-05 16:52 EST ---
(In reply to comment #32)
How small does loader2 have to be ? Have you tried using libdhcp and found
it to be too big ? What is the actual size limitation of loader2 ?
It's not really a hard limit, but rather a mindset. How much memory do we want
to require during installation is a better way to think about it.
libdhcp could also be MUCH smaller if loader2 could use shared libs -
why can't it ?
Because it's a PITA trying to work on a initrd.img when you have 17 thousand
things to copy in instead of just one binary. Ooops, forgot those 30 symlinks.
Ooops, forgot all of those things. And so on.
Originally the requirement for a static loader was to cram everything on to a
1.44MB boot image for diskettes. We don't make boot floppies anymore, but
having a static loader makes it WAY more easy to do development. The installer
environment is special.
there are certainly things in dhclient (and the one for IPv6) that just
don't matter for the installer.
Which things ?
Everything in dhclient and dhcpv6 is required, depending on configuration
settings.
I'm just thinking about things supported as command line switches. A
user-defined timeout, for example.
We need a minimal IPv4 and IPv6 library that can link in to loader2.
That is what libdhcp and libdhcp{4,6}client provide.
Either we use the ISC dhclient and DHCPv6 code for anaconda, giving users a
full featured and configurable DHCP client that they already know how to
configure, and allowing us to re-use the code from the FC clients, or we
write our own DHCPv4 and DHCPv6 clients for anaconda from scratch.
I can undertake to write DHCP and DHCPv4 clients from scratch if desired,
but it seems to me to be the wrong way to go when we already have tried and
tested DHCP client code that users are familiar with and know how to
configure.
Please at least give libdhcp a try - if we come across any obstacles, I can
resolve them.
I have moved anaconda's loader to using libdhcp and friends. I do have some
questions, concerns, *BUT* the end result is that I think this library is the
right direction to move for Fedora. libdhcp has my vote for inclusion in FC.
Now for the questions/concerns for down-the-road things:
1) The pump compatibility layer is great right now, but down the road we want to
remove that entirely. I know we asked for that, but just know that it's a
transition tool and we shouldn't be making other users aware of that API as
something they can rely on forever.
2) Are there plans to get the ISC client library patches integrated upstream?
3) Are there plans to merge the ISC client libraries in to one?
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192413] libdhcp : IPv6 and IPv4 DHCP client and network configuration library API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: libdhcp : IPv6 and IPv4 DHCP client and network configuration library API https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192413 --- Additional Comments From [EMAIL PROTECTED] 2006-06-05 17:49 EST --- Great news! I'm glad to hear loader2 will now be IPv6 capable with libdhcp usage. I've also just heard that libdhcp has been added to the dist-fc6 brew package list, and it is now building in brew - the packages should be in tomorrow's rawhide. RE: pump compatibility layer ... we shouldn't be making other users aware of that API as something they can rely on forever Actually, adding the pump.[ch] Doxygen documentation was something I hadn't got around to yet ... I guess I'll continue holding off on that. The pump API is entirely superfluous as is, and is just a wrapper around the underlying libdhcp API, which is fully Doxygen documented. Are there plans to get the ISC client library patches integrated upstream? Are there plans to merge the ISC client libraries in to one ? As for 'fully integrated', probably not, but ISC have already agreed to ship dhcdbd in the contrib/ directory of their source tarball, so would probably be amenable to shipping the libdhcp4client patch in contrib/ also. DHCPv6 is not an ISC product, but is a sourceforge project - I can attach the libdhcp6client patch in sourceforge, so that should not be a problem - I'll get going on this now. Bear in mind that libdhcp (and dhcdbd) are actually a stopgap until ISC release their super-duper integrated DHCP and DHCPv6 natively D-BUS based server and client, which is rumored to be in dhcp-4.0.x, to be released within the next year or so (I have not heard any hard dates yet) . Thanks! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192413] libdhcp : IPv6 and IPv4 DHCP client and network configuration library API
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: libdhcp : IPv6 and IPv4 DHCP client and network configuration library
API
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192413
--- Additional Comments From [EMAIL PROTECTED] 2006-05-30 13:46 EST ---
(In reply to comment #28)
RE:
Looking at /usr/include/dhcp4client/isc-dhcp/dhcp4client.h and then the one
for IPv6, I only see one function prototype and it looks like an entry point
for execing the client daemon to me.
Each libdhcp{4,6}client library provides only one entry point, which is the
client main() function renamed to dhcpv{4,6}_client . The main functions
have been modifed not to go into daemon mode, fork any processes etc., or
to create any files at all, if running under libdhcp, and also to clean up
after themselves - before returning, they free all memory used by the
client and reintialize all the global variables used by the client.
I've tested running both the clients 100 times in succession in the same
process under valgrind and valgrind reports no leaked files, memory or
memory access errors from client code.
OK, then this is probably why I thought it was execing the client. It's not
doing that, but rather it is the client code (minus some daemon housekeeping).
I'm all for code reuse, but the libdhcp{4,6}client + libdhcp solution is simply
too big for loader2. Loader2 is static and needs to fit in tight spaces.
I also have questions about these new client libraries for DHCP. It's just
duplicating the client code in the form of the library, right? Having two
copies of large programs, one as a client and one as a library, opens the door
to more maintenance issues...at least down the road. Are these libraries
something you want to send upstream to ISC and then patch the clients to use
them? This really has no bearing on its use in anaconda, but it's a concern I
have.
A drop-in replacement for pump now helps, but it pulls in libdhcp{4,6}client and
libdhcp, which doesn't help loader2.
Pump doesn't need to be a client, we just need the library. I think this is the
way to go for loader2 in anaconda. We need a minimal IPv4 and IPv6 library that
can link in to loader2. It only needs to be there for bringing up the network
interface so we can grab stage2 and make it go. It's hard to define minimal,
but there are certainly things in dhclient (and the one for IPv6) that just
don't matter for the installer.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192413] libdhcp : IPv6 and IPv4 DHCP client and network configuration library API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: libdhcp : IPv6 and IPv4 DHCP client and network configuration library API https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192413 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2006-05-24 15:27 EST --- Now that the review has been approved, please can someone add 'libdhcp' to the FC dist collection so I can build it. Latest version is libdhcp-1.2-1.beta and is checked in to CVS. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192413] libdhcp : IPv6 and IPv4 DHCP client and network configuration library API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: libdhcp : IPv6 and IPv4 DHCP client and network configuration library API https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192413 --- Additional Comments From [EMAIL PROTECTED] 2006-05-24 15:31 EST --- Techlead (Bill) has to approve, will this change anything for the installer team? Contact jeremy katz if so, what about comps? Will this need to be listed on its own, or will it be a Requires, or BuildRequires of something already in comps? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192413] libdhcp : IPv6 and IPv4 DHCP client and network configuration library API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: libdhcp : IPv6 and IPv4 DHCP client and network configuration library API https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192413 --- Additional Comments From [EMAIL PROTECTED] 2006-05-24 15:53 EST --- Oh, and there's dhcdbd which provides yet another slightly different code path. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192413] libdhcp : IPv6 and IPv4 DHCP client and network configuration library API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: libdhcp : IPv6 and IPv4 DHCP client and network configuration library API https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192413 --- Additional Comments From [EMAIL PROTECTED] 2006-05-24 16:18 EST --- My two cents... libdhcp is a step in the right direction, but what we really need for anaconda now is a drop-in replacement for pump so that we can add IPv6 support rather quickly. After reading the code and some of the patches to the ISC software, I would rate this software of alpha quality. It's clearly under heavy development still and it's not really something that I'd like to move anaconda to right now. The last part that concerns me (again, regarding anaconda) is that this library execs the actual DHCP clients. Is this necessary? Pump is able to do IPv4 DHCP in a handful of C files. Pump is great because we can link it right in to the loader and have no other external requirements. This is very important for bring up on new architectures and/or painful architectures (e.g., zSeries). I'm not sure that libdhcp is the best move for anaconda. If the drop-in replacement for pump existed, that would be good. A library that doesn't require the clients, that would be good. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192413] libdhcp : IPv6 and IPv4 DHCP client and network configuration library API
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: libdhcp : IPv6 and IPv4 DHCP client and network configuration library
API
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192413
--- Additional Comments From [EMAIL PROTECTED] 2006-05-24 16:28 EST ---
In reply to Comment #25 From David Cantrell ([EMAIL PROTECTED]) on 2006-05-24
16:18 EST:
libdhcp DOES NOT REQUIRE ANY DHCP CLIENTS OR EXEC ANY DHCP CLIENT PROCESS .
Please read the README file shipped in the distribution.
libdhcp RUNS the DHCP client code in same process as the invoking program,
from libraries linked into to the invoker.
That way, we do not have to develop and maintain DHCP and DHCPv6 client
protocol implementations from scratch - we can re-use the same code
used for the FC dhclient and dhcp6c programs, but run from within
one process.
The DHCP and DHCPv6 protocols are separate protocols, with separate ports,
message types and options.
A drop-in replacement for pump is now being tested and will be
submitted today.
In reply to Comment #23 and Comment #24 From Bill Nottingham
([EMAIL PROTECTED]) on 2006-05-24 15:53:
Hi Bill -
RE: architecture question :
Not quite .
libdhcp provides a callback mechanism whereby DHCP client code can be
invoked from user code in the same process, and user code can receive
and process the lease information; it also provides a 'Network Interface
Configuration' (NIC) library to configure network parameters from either
DHCP or static configurations, similar to and as an intended replacement
for the libpump library used by anaconda, using the libnl Netlink library.
Then libdhcp4client provides the ISC DHCPv4 client in a library,
and libdhcp6client provides the DHCPv6 client in a library, which
use the libdhcp interface to enable invocation from user programs
and processing of the lease information by user programs.
The libdhcp{4,6}client libraries contain all the objects that the
DHCP client programs are built from. They are in fact just the client
programs with a renamed 'main()' function, modified to free all
memory and reinitialize globals on return of the modified main().
libdhcp{4,6}client libraries link to no other shared libraries except
libc - they contain all the objects from the dh{p,pv6}-client build.
libdhcp, libdhcp4client and libdhcp6client all build both shared and
static versions of themselves. libdhcp requires only to be linked
to a shared or static libdhcp{4,6}client library, depending on the
functions used by the invoking program. For example, if only NIC
functions are used by a libdhcp using program, the linker will not
complain about omitting -ldhcp4client or -ldhcp6client from the
link command, and the program will run fine without linking to
the dhcpclient libraries.
IE. linking to the libdhcp{4,6}client libraries or including the
dhcp client headers is entirely optional depending on how libdhcp
is used by the program that links to it.
libdhcp contains objects which link to libdhcp4client, libdhcp6client,
and libnl - depending on which objects an invoking program uses, some
or all of these libraries may need to be linked in to the invoking program.
RE: dhcdbd issue -
dhcdbd is intended for a totally different purpose, to maintain a
lease database and distribute lease information to D-BUS listeners.
libdhcp is meant to be used by programs such as anaconda's loader2 that
require a library to do both static network configuration and to do dhcp
in the same process, without exec-ing other programs or depending on
external daemons running. The only library that can do this currently
is libpump, which is not DHCPv6 capable - hence the need for libdhcp.
However, it's quite possible a future version of dhcdbd could do away
with having to exec the clients and parse the options from environment
variable setting strings by using libdhcp.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192413] libdhcp : IPv6 and IPv4 DHCP client and network configuration library API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: libdhcp : IPv6 and IPv4 DHCP client and network configuration library API https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192413 --- Additional Comments From [EMAIL PROTECTED] 2006-05-22 16:53 EST --- This package still does not build. Same error: gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -fPIC -I. -Wall -Werror -I/usr/include/dhcp4client -I/usr/include/dhcp4client/isc_dhcp -c -o dhcp4_lease.o dhcp4_lease.c In file included from /usr/include/dhcp4client/isc_dhcp/minires/minires.h:30, from /usr/include/dhcp4client/isc_dhcp/dhcpd.h:61, from dhcp4_lease.c:29: /usr/include/dhcp4client/isc_dhcp/minires/res_update.h:33:27: error: isc-dhcp/list.h: No such file or directory -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192413] libdhcp : IPv6 and IPv4 DHCP client and network configuration library API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: libdhcp : IPv6 and IPv4 DHCP client and network configuration library API https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192413 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|186322 |188267 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192413] libdhcp : IPv6 and IPv4 DHCP client and network configuration library API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: libdhcp : IPv6 and IPv4 DHCP client and network configuration library API https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192413 --- Additional Comments From [EMAIL PROTECTED] 2006-05-19 11:53 EST --- Please also see: http://people.redhat.com/~jvdias/libdhcp/README (the readme file from the source tarball). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192413] libdhcp : IPv6 and IPv4 DHCP client and network configuration library API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: libdhcp : IPv6 and IPv4 DHCP client and network configuration library API https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192413 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||186322 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192413] libdhcp : IPv6 and IPv4 DHCP client and network configuration library API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: libdhcp : IPv6 and IPv4 DHCP client and network configuration library API https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192413 --- Additional Comments From [EMAIL PROTECTED] 2006-05-19 12:48 EST --- Bad: - rpmlint fails on the srpm: E: libdhcp hardcoded-library-path in $RPM_BUILD_ROOT/usr/lib/pkgconfig E: libdhcp hardcoded-library-path in /usr/lib/pkgconfig/libdhcp.pc - Package does not build in mock: /usr/include/dhcp4client/isc-dhcp/minires/res_update.h:33:27: error: isc-dhcp/list.h: No such file or directory plus many other build failures. NEEDSWORK -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192413] libdhcp : IPv6 and IPv4 DHCP client and network configuration library API
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: libdhcp : IPv6 and IPv4 DHCP client and network configuration library
API
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192413
--- Additional Comments From [EMAIL PROTECTED] 2006-05-19 13:29 EST ---
I'd say whatever tool you're using NEEDSWORK also -
1. There is no way currently of 'softcoding' the pkgconfig dir.
- To use
%{_libdir}/pkgconfig or %{prefix}/%{_lib}/pkgconfig would fail
on multi-lib arches (as I found out with avahi) -
/usr/lib64/pkgconfig is NOT a pkgconfig directory.
The pkgconfig dir is ALWAYS /usr/lib/pkgconfig -
until /usr/lib/rpm/macros gives us a nice %{_pkgconfig} variable.
MANY other packages use pkgconfig, and they all have to specify
/usr/lib/pkgconfig.
I can remove the libdhcp.pc if you wish, but that would be a shame
as it would prevent software being able to discover the Cflags, Libs,
and Libs.private it requires automatically, which leads on to the next
point.
2. Your tool is using the wrong include path, which it could have obtained
by using 'pkg-config --cflags', to obtain '-I/usr/lib/dhcp4client'
and '-I/usr/lib/dhcp4client/isc-dhcp', where the headers for the
dhcp4client reside.
If you could suggest a resolution, I'll implement it - what tool are you
using ? It sounds like it needs fixing.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192413] libdhcp : IPv6 and IPv4 DHCP client and network configuration library API
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: libdhcp : IPv6 and IPv4 DHCP client and network configuration library
API
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192413
--- Additional Comments From [EMAIL PROTECTED] 2006-05-19 13:53 EST ---
OK, I've checked the pkgcfgdir thing - it is %{_libdir} - patch applied:
--- libdhcp.spec.~1.5.~ 2006-05-19 09:24:17.0 -0400
+++ libdhcp.spec2006-05-19 13:53:02.0 -0400
@@ -47,0 +48,3 @@
+
+%define pkgcfgdir %{_libdir}/pkgconfig
+
@@ -49 +52 @@
-%makeinstall pkgcfgdir=$RPM_BUILD_ROOT/usr/lib/pkgconfig
+%makeinstall pkgcfgdir=%{pkgcfgdir}
New spec file with the above change checked into CVS and is on the website.
But the second issue - those headers aren't even shipped by the package - they
are shipped by its dependency, libdhcp4client-devel - libdhcp has this tag:
BuildRequires: libdhcp4client-devel, libdhcp6client-devel, libnl-devel,
pkgconfig
It gets the correct include path using pkgconfig, and builds fine when its
BuildRequires packages are installed.
How are you getting that error:
/usr/include/dhcp4client/isc-dhcp/minires/res_update.h:33:27: error:
isc-dhcp/list.h: No such file or directory
Any system that had libdhcp4client-devel installed would not generate that
error when building libdhcp.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192413] libdhcp : IPv6 and IPv4 DHCP client and network configuration library API
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: libdhcp : IPv6 and IPv4 DHCP client and network configuration library
API
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192413
--- Additional Comments From [EMAIL PROTECTED] 2006-05-19 14:02 EST ---
Revised patch applied:
--- libdhcp.spec.~1.5.~ 2006-05-19 09:24:17.0 -0400
+++ libdhcp.spec2006-05-19 14:07:43.0 -0400
@@ -47,0 +48,3 @@
+
+%define pkgcfgdir %{_libdir}/pkgconfig
+
@@ -49 +52 @@
-%makeinstall pkgcfgdir=$RPM_BUILD_ROOT/usr/lib/pkgconfig
+%makeinstall pkgcfgdir=${RPM_BUILD_ROOT}%{pkgcfgdir}
@@ -72 +75 @@
-/usr/lib/pkgconfig/libdhcp.pc
+%{pkgcfgdir}/libdhcp.pc
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192413] libdhcp : IPv6 and IPv4 DHCP client and network configuration library API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: libdhcp : IPv6 and IPv4 DHCP client and network configuration library API https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192413 --- Additional Comments From [EMAIL PROTECTED] 2006-05-19 14:35 EST --- The tool used is mock, which is what your package needs to be able to build in as part of the Package Guidelines. However as you state, it may be a problem in the deps of the BuildReqs that are brought in, this needs to be investigated. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192413] libdhcp : IPv6 and IPv4 DHCP client and network configuration library API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: libdhcp : IPv6 and IPv4 DHCP client and network configuration library API https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192413 --- Additional Comments From [EMAIL PROTECTED] 2006-05-19 16:29 EST --- Thanks - I see the problem - libdhcp4client and libdhcp6client both install their pkgconfig files in /usr/lib/pkgconfig :-( I'm now rebuilding them - I guess its OK to do a move-pkgs -d on them and then just rebuild the same version since they were both just built today and haven't gone out to anyone - rebuilding now. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192413] libdhcp : IPv6 and IPv4 DHCP client and network configuration library API
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: libdhcp : IPv6 and IPv4 DHCP client and network configuration library
API
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192413
--- Additional Comments From [EMAIL PROTECTED] 2006-05-19 17:15 EST ---
OK, fixed now - sorry about that - all pkgconfigs are now in correct locations
on multi-arch machines:
$ rpm -qplv
/mnt/redhat/dist/fc6/dhcp{,v6}/{0.10-24,3.0.4-6}/{x86_64,ppc64,s390x}/* | grep
pkgconfig
-rw-r--r--1 rootroot 184 May 19 16:53
/usr/lib64/pkgconfig/libdhcp4client.pc
-rw-r--r--1 rootroot 184 May 19 16:55
/usr/lib64/pkgconfig/libdhcp4client.pc
-rw-r--r--1 rootroot 184 May 19 16:54
/usr/lib64/pkgconfig/libdhcp4client.pc
-rw-r--r--1 rootroot 224 May 19 17:14
/usr/lib64/pkgconfig/libdhcp6client.pc
-rw-r--r--1 rootroot 224 May 19 17:14
/usr/lib64/pkgconfig/libdhcp6client.pc
-rw-r--r--1 rootroot 224 May 19 17:14
/usr/lib64/pkgconfig/libdhcp6client.pc
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192413] libdhcp : IPv6 and IPv4 DHCP client and network configuration library API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: libdhcp : IPv6 and IPv4 DHCP client and network configuration library API https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192413 --- Additional Comments From [EMAIL PROTECTED] 2006-05-19 17:48 EST --- Hrm, so I don't get the pkg-config errors, now I just get: + make -j2 gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -fPIC -I. -Wall -Werror -c -o libdhcp.o libdhcp.c gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -fPIC -I. -Wall -Werror -I/usr/include/dhcp4client -I/usr/include/dhcp 4client/isc-dhcp -c -o dhcp4_lease.o dhcp4_lease.c In file included from /usr/include/dhcp4client/isc-dhcp/minires/minires.h:30, from /usr/include/dhcp4client/isc-dhcp/dhcpd.h:61, from dhcp4_lease.c:29: /usr/include/dhcp4client/isc-dhcp/minires/res_update.h:33:27: error: isc-dhcp/list.h: No such file or directory In file included from /usr/include/dhcp4client/isc-dhcp/minires/minires.h:30, from /usr/include/dhcp4client/isc-dhcp/dhcpd.h:61, from dhcp4_lease.c:29: /usr/include/dhcp4client/isc-dhcp/minires/res_update.h:39: error: expected specifier-qualifier-list before 'ISC_LINK' /usr/include/dhcp4client/isc-dhcp/minires/res_update.h:55: error: function definition declared 'typedef' cc1: warnings being treated as errors -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192413] libdhcp : IPv6 and IPv4 DHCP client and network configuration library API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: libdhcp : IPv6 and IPv4 DHCP client and network configuration library API https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192413 --- Additional Comments From [EMAIL PROTECTED] 2006-05-19 19:37 EST --- Sounds like you're missing a BuildRequires. The beehive buildroots operate on an 'everything' install, so a missing buildreq won't be noticed. Mock however starts with a minimal clean buildroot and then relies upon BuildRequires (and subsequent Requires of those) to populate the buildroot for building. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192413] libdhcp : IPv6 and IPv4 DHCP client and network configuration library API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: libdhcp : IPv6 and IPv4 DHCP client and network configuration library API https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192413 --- Additional Comments From [EMAIL PROTECTED] 2006-05-19 19:53 EST --- Ah ha. I found that dhcp-devel needs to be in the build root. So now the question is, do one of the other -devel packages need to bring in dhcp-devel to satisfy their include statements? Just BuildReq'ing dhcp-devel may not be the answer here. Since the error comes from /usr/include/dhcp4client/isc-dhcp/minires/res_update.h, one would wager that dhcp4client-devel (and probably dhcp6client-devel) should have a Requires dhcp-devel. Shall I file a bug for that, or will you take care of that so this package will build? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192413] libdhcp : IPv6 and IPv4 DHCP client and network configuration library API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: libdhcp : IPv6 and IPv4 DHCP client and network configuration library API https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192413 --- Additional Comments From [EMAIL PROTECTED] 2006-05-19 19:58 EST --- rpmlint found a few things w/ the binary package: E: libdhcp explicit-lib-dependency libdhcp4client E: libdhcp explicit-lib-dependency libdhcp6client E: libdhcp explicit-lib-dependency libnl W: libdhcp incoherent-version-in-changelog 1.0-1 1.1-1.beta You should let rpmbuild figure out the Requires, instead of manually inserting them, unless rpm is getting it wrong. Is rpm getting it wrong? The -devel package doesn't have a dep on the main package. Is this ok? Does the -devel package need the main package? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192413] libdhcp : IPv6 and IPv4 DHCP client and network configuration library API
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: libdhcp : IPv6 and IPv4 DHCP client and network configuration library
API
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192413
--- Additional Comments From [EMAIL PROTECTED] 2006-05-19 21:49 EST ---
Firstly, the isc-dhcp issue - now dhcp-3.0.8's libdhcp4client-devel provides
isc_dhcp/*, not isc-dhcp/*, which is provided by dhcp-devel.
Yes, libdhcp requires the dhcp-devel headers in isc-dhcp/* to build -
dhcp-devel is now in the build requires.
There are only two .c files in libdhcp that require the ISC DHCP headers,
dhcp4_lease.c and dhcp4_nic.c, whose purpose it could be said is to avoid any
programs which use them ever having to require the DHCP headers.
Similarly for dhcpv6, ONLY libdhcp's dhcp6_lease.c and dhcp6_lease.nic need
to include the dhcp6 headers.
This is shown clearly in a log of the build without the extra RPM stuff:
$ CFLAGS='-g3 -gdwarf-2' make
cc -g3 -gdwarf-2 -fPIC -I. -Wall -Werror -c -o libdhcp.o libdhcp.c
cc -g3 -gdwarf-2 -fPIC -I. -Wall -Werror -I/usr/include/dhcp4client
-I/usr/include/dhcp4client/isc_dhcp -c -o dhcp4_lease.o dhcp4_lease.c
cc -g3 -gdwarf-2 -fPIC -I. -Wall -Werror -I/usr/include/dhcp4client
-I/usr/include/dhcp4client/isc_dhcp -c -o dhcp4_nic.o dhcp4_nic.c
cc -g3 -gdwarf-2 -fPIC -I. -Wall -Werror -I/usr/include/dhcp6client
-I/usr/include/dhcp6client/dhcpv6 -c -o dhcp6_lease.o dhcp6_lease.c
cc -g3 -gdwarf-2 -fPIC -I. -Wall -Werror -c -o dhcp6_nic.o dhcp6_nic.c
cc -g3 -gdwarf-2 -fPIC -I. -Wall -Werror -c -o nic.o nic.c
cc -g3 -gdwarf-2 -fPIC -I. -Wall -Werror -c -o dhcp_nic.o dhcp_nic.c
cc -shared -o libdhcp.so.1 -Wl,-soname,libdhcp.so.1 libdhcp.o dhcp4_lease.o
dhcp4_nic.o dhcp6_lease.o dhcp6_nic.o nic.o dhcp_nic.o -lnl -ldhcp6client
-ldhcp4client
/bin/ln -sf libdhcp.so.1 libdhcp.so
ar crus libdhcp.a libdhcp.o dhcp4_lease.o dhcp4_nic.o dhcp6_lease.o dhcp6_nic.o
nic.o dhcp_nic.o
About the explicit-lib-dependency - yes, libdhcp does require the
libdhcp4client and libdhcp6client libraries - it cannot be used at all
without them, so I thought they should be in its list of 'Requires:' -
rpm does not complain at all about them when I make the RPM - but I've
taken them out as you suggested.
About the devel package dep - in the current .spec file, it says:
%package devel
...
Requires: %{name}-%{version}-%{release}
Please ensure you're looking at the latest version of the .spec file , which
is now in elvis devel CVS .
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
