Re: [RTF] Jfor integration

2003-06-27 Thread Bertrand Delacretaz 
...Do you
mind if I rework that a bit so that the standard header is intact, and 
then
add the additional credits for the jfor team below?...
No problem - I didn't know that checkstyle cared for this as well.

-Bertrand

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]

Re: [PATCH] fop's resource.xml

2003-06-27 Thread Clay Leeds 
Victor,

On 6/27/2003 12:35 PM, Victor Mote wrote:
Double-check the WinCVS MacCVS page to see if they have a later version. I
am actually running a beta version of WinCVS, and seeing no known problems.
I'm using MacCvsX (which appears to be different from MacCVS ;( ). It 
took a bit to get it running (mainly permissions issues), but it's 
working. If it's all the same to you, I'll keep using MacCvsX... (That's 
not to say I won't try to get MacCVS working, though).

Try 'man diff'. CVS is largely "just" a wrapper around RCS and diff, so you
should *generally* be able to use the diff doc.
Ahhh... --unified It looks like I can do it from the command line, now 
that I know a bit more how it works...

If MacCVS works like WinCVS, there is a command-line console available that
has CVS built into it, even if the OS doesn't have natively.
I saw a command-line utility when I was first playing around with it. 
I'm having trouble finding it again... I'll keep looking.

;-0
--
Clay Leeds - [EMAIL PROTECTED]
Web Developer - Medata, Inc. - http://www.medata.com
PGP Public Key: https://mail.medata.com/pgp/cleeds.asc
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]

RE: [RTF] Jfor integration

2003-06-27 Thread Victor Mote 
Bertrand:

Checkstyle is complaining about the Apache license header in the jfor files,
because of the additional credits to the jfor team near the bottom. Do you
mind if I rework that a bit so that the standard header is intact, and then
add the additional credits for the jfor team below? That might also be safer
as we hope that the Apache license header will be greatly condensed at some
point in the future. Also, we could add an @author tag in each class that
would have appropriate credit information. What are your thoughts?

Victor Mote


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]

RE: [PATCH] fop's resource.xml

2003-06-27 Thread Victor Mote 
Clay Leeds wrote:

> I'm launching MacCvsX as we speak (I don't run WinCVS ;-p). I just
> checked and unfortunately, "Unified diff" is not an option. I thought I

Double-check the WinCVS MacCVS page to see if they have a later version. I
am actually running a beta version of WinCVS, and seeing no known problems.

> could run it from the command line if you give me the command to run,
> but nope, it won't work... I did a 'man cvs' and /Unified showed
> "Pattern not found". Any ideas? I think I'll just do my edits onesy,

Try 'man diff'. CVS is largely "just" a wrapper around RCS and diff, so you
should *generally* be able to use the diff doc.

If MacCVS works like WinCVS, there is a command-line console available that
has CVS built into it, even if the OS doesn't have natively.

Victor Mote


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]

cvs commit: xml-fop/src/java/org/apache/fop/rtf/rtflib/rtfdoc BorderAttributesConverter.java

2003-06-27 Thread vmote 
vmote   2003/06/27 12:28:17

  Modified:src/java/org/apache/fop/rtf/rtflib/rtfdoc
BorderAttributesConverter.java
  Log:
  style changes only
  
  Revision  ChangesPath
  1.2   +46 -41
xml-fop/src/java/org/apache/fop/rtf/rtflib/rtfdoc/BorderAttributesConverter.java
  
  Index: BorderAttributesConverter.java
  ===
  RCS file: 
/home/cvs/xml-fop/src/java/org/apache/fop/rtf/rtflib/rtfdoc/BorderAttributesConverter.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- BorderAttributesConverter.java20 Jun 2003 16:08:20 -  1.1
  +++ BorderAttributesConverter.java27 Jun 2003 19:28:17 -  1.2
  @@ -53,18 +53,19 @@
   
   package org.apache.fop.rtf.rtflib.rtfdoc;
   
  -/** Constants for RTF border attribute names, and a static method for converting fo 
attribute strings. */
  +/** Constants for RTF border attribute names, and a static method for converting
  + *  fo attribute strings. */
   
   public class BorderAttributesConverter {
  -
  +
   public static final String BORDER_SINGLE_THICKNESS = "brdrs";
   public static final String BORDER_DOUBLE_THICKNESS = "brdrth";
  -public static final String BORDER_SHADOWED ="brdrsh";
  -public static final String BORDER_DOUBLE ="brdrdb";
  -public static final String BORDER_DOTTED ="brdrdot";
  -public static final String BORDER_DASH ="brdrdash";
  -public static final String BORDER_HAIRLINE ="brdrhair";
  -public static final String BORDER_DASH_SMALL ="brdrdashsm";
  +public static final String BORDER_SHADOWED = "brdrsh";
  +public static final String BORDER_DOUBLE = "brdrdb";
  +public static final String BORDER_DOTTED = "brdrdot";
  +public static final String BORDER_DASH = "brdrdash";
  +public static final String BORDER_HAIRLINE = "brdrhair";
  +public static final String BORDER_DASH_SMALL = "brdrdashsm";
   public static final String BORDER_DOT_DASH = "brdrdashd";
   public static final String BORDER_DOT_DOT_DASH = "brdrdashdd";
   public static final String BORDER_TRIPLE = "brdrtriple";
  @@ -85,59 +86,63 @@
   public static final String BORDER_COLOR = "brdrcf";
   public static final String BORDER_SPACE = "brsp";
   public static final String BORDER_WIDTH = "brdrw";
  -
  +
   public static final String [] BORDERS = new String[] {
  -BORDER_SINGLE_THICKNESS, BORDER_DOUBLE_THICKNESS,   
 BORDER_SHADOWED,
  -BORDER_DOUBLE,   BORDER_DOTTED, 
 BORDER_DASH,
  -BORDER_HAIRLINE, BORDER_DASH_SMALL, 
 BORDER_DOT_DASH,
  -BORDER_DOT_DOT_DASH, BORDER_TRIPLE, 
 BORDER_THINK_THIN_SMALL,
  -BORDER_THIN_THICK_SMALL, BORDER_THIN_THICK_THIN_SMALL,   
BORDER_THINK_THIN_MEDIUM,
  -BORDER_THIN_THICK_MEDIUM,BORDER_THIN_THICK_THIN_MEDIUM,  
BORDER_THINK_THIN_LARGE,
  -BORDER_THIN_THICK_LARGE, BORDER_THIN_THICK_THIN_LARGE,   
BORDER_WAVY,
  -BORDER_WAVY_DOUBLE,  BORDER_STRIPED,
 BORDER_EMBOSS,
  -BORDER_ENGRAVE,  BORDER_COLOR,  
 BORDER_SPACE,
  +BORDER_SINGLE_THICKNESS,BORDER_DOUBLE_THICKNESS,
BORDER_SHADOWED,
  +BORDER_DOUBLE,  BORDER_DOTTED,  BORDER_DASH,
  +BORDER_HAIRLINE,BORDER_DASH_SMALL,  
BORDER_DOT_DASH,
  +BORDER_DOT_DOT_DASH,BORDER_TRIPLE,  
BORDER_THINK_THIN_SMALL,
  +BORDER_THIN_THICK_SMALL,BORDER_THIN_THICK_THIN_SMALL,   
BORDER_THINK_THIN_MEDIUM,
  +BORDER_THIN_THICK_MEDIUM,   BORDER_THIN_THICK_THIN_MEDIUM,  
BORDER_THINK_THIN_LARGE,
  +BORDER_THIN_THICK_LARGE,BORDER_THIN_THICK_THIN_LARGE,   BORDER_WAVY,
  +BORDER_WAVY_DOUBLE, BORDER_STRIPED, 
BORDER_EMBOSS,
  +BORDER_ENGRAVE, BORDER_COLOR,   
BORDER_SPACE,
   BORDER_WIDTH
   };
  -
  -/**BorderAttributesConverter: Static Method for converting FO strings
  - * to RTF control words*/
  +
  +/**
  +* BorderAttributesConverter: Static Method for converting FO strings
  +* to RTF control words
  +* @param value FO string
  +* @return RTF control word
  +*/
   public static String convertAttributetoRtf(String value) {
   // Added by Normand Masse
  -// "solid" is interpreted like "thin"
  - if(value.equals("thin") || value.equals("solid")){
  +// "solid" is interpreted like "thin"
  +if (value.equals("thin") || value.e

Re: [PATCH] fop's resource.xml

2003-06-27 Thread Clay Leeds 
On 6/27/2003 10:33 AM, Victor Mote wrote:
The only problem I saw with the DIFF file was that it was not in "unified"
format, which helps the patch programs find the context more easily. On the
one that you submitted, it didn't matter because it was easier to
cut-and-paste than to run patch anyway. If you are using WinCVS, I know that
the newer versions have a checkbox on the diff page for "Unified diff",
which you will want to select.
I'm launching MacCvsX as we speak (I don't run WinCVS ;-p). I just 
checked and unfortunately, "Unified diff" is not an option. I thought I 
could run it from the command line if you give me the command to run, 
but nope, it won't work... I did a 'man cvs' and /Unified showed 
"Pattern not found". Any ideas? I think I'll just do my edits onesy, 
twosy and send you each edit separately. I doubt there'll be many. Any 
that happen to be "large" we'll probably have a discussion about on 
fop-dev in advance anyway, so you'll know it's coming.

Enhancement is fine, unless there is a specific category for Doc.
"Doc" is not an option in the "Severity" menu, but it is under the 
"Component" menu. I'll choose "Enhancement" instead of "minor" for 
Severity if that's what you prefer...

;-p
--
Clay Leeds - [EMAIL PROTECTED]
Web Developer - Medata, Inc. - http://www.medata.com
PGP Public Key: https://mail.medata.com/pgp/cleeds.asc
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]

RE: [PATCH] fop's resource.xml

2003-06-27 Thread Victor Mote 
Clay Leeds wrote:

> Thanks. So essentially, I did everything correctly except I didn't open
> a new bugzilla item, and put '[PATCH]' at the beginning of the SUMMARY.
> I'll do that next time. I'll then attach the DIFF file (were there any
> problems with that DIFF file?). Since much of what I'll be doing will be

The only problem I saw with the DIFF file was that it was not in "unified"
format, which helps the patch programs find the context more easily. On the
one that you submitted, it didn't matter because it was easier to
cut-and-paste than to run patch anyway. If you are using WinCVS, I know that
the newer versions have a checkbox on the diff page for "Unified diff",
which you will want to select.

> (hopefully) improving the web site, Platform will be 'All'. As for
> Severity, would you prefer I indicate "Enhancement", or stick with my
> own assessment to severity (most would end up being 'minor' as
> 'nit-picking' is not an option ;-p).

Enhancement is fine, unless there is a specific category for Doc.

Victor Mote


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]

DO NOT REPLY [Bug 5674] - postscript generated by FOP is missing end commands

2003-06-27 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5674

postscript generated by FOP is missing end commands

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED



--- Additional Comments From [EMAIL PROTECTED]  2003-06-27 17:26 ---
To mark a bug use the radio buttons ("Mark bug as...") right above the commit 
button.

And yes, the bugfix will be in 0.20.5. I'm glad it worked and thanks for 
confirming.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]

RE: cvs commit: xml-fop checkstyle1.3.0-head

2003-06-27 Thread Victor Mote 
Peter B. West wrote:

> Definitely a w.i.p.  It throws up too many exceptions at the moment, and
> needs to be pruned back by those with a better grasp of the style
> requirements.

OK. I'll keep using the old-style version for now.

> Btw, are you using JBuilder with FOP?  If so, could you add some notes
> to the IDE Wiki when you get some "spare time"?

Yes, although I hope to revisit Eclipse in the near future. I just added a
brief comment at the bottom about setting up jbCheckstyle, which is the
checkstyle plugin for JBuilder. I haven't integrated JBuilder with CVS yet,
but I'll try to add some FOP-specific comments on setting up the libraries &
paths, etc. over the weekend.

Victor Mote


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]

Re: [PATCH] fop's resource.xml

2003-06-27 Thread Clay Leeds 
On 6/27/2003 8:17 AM, Victor Mote wrote:
Thanks for the patch. The instructions are here:
http://xml.apache.org/fop/dev/index.html#patches
Thanks. So essentially, I did everything correctly except I didn't open 
a new bugzilla item, and put '[PATCH]' at the beginning of the SUMMARY. 
I'll do that next time. I'll then attach the DIFF file (were there any 
problems with that DIFF file?). Since much of what I'll be doing will be 
(hopefully) improving the web site, Platform will be 'All'. As for 
Severity, would you prefer I indicate "Enhancement", or stick with my 
own assessment to severity (most would end up being 'minor' as 
'nit-picking' is not an option ;-p).
--
Clay Leeds - [EMAIL PROTECTED]
Web Developer - Medata, Inc. - http://www.medata.com
PGP Public Key: https://mail.medata.com/pgp/cleeds.asc

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]

RE: [PATCH] fop's resource.xml

2003-06-27 Thread Victor Mote 
Clay Leeds wrote:

> Forgive my newbie-ness here, but I'm having problems figuring out how
> to send this [patch] in. I'm sending it here... Please enlighten me
> (gently ;-p) so that next time I'm doing it as efficiently as possible.
> Thanks!

Thanks for the patch. The instructions are here:
http://xml.apache.org/fop/dev/index.html#patches

> PATCH INFO:
> The info for XPath is missing the fact that it's pretty much Windows IE
> 5+ only (requires MSXML 3.0). However, it's still a really useful tool!
> It'd be nice if it could be re-engineered to be cross-platform!

I modified (and applied) the patch to say something like "Requires Internet
Explorer 5+". IMO, comments like this are in a gray area -- if they do
change their product to be cross-platform, we're out-of-date. In spite of
the relative inconvenience to the user, it is almost better for them to find
this out by following the link.

Thanks for your continuing efforts to improve the doc.

Victor Mote


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]

cvs commit: xml-fop/src/documentation/content/xdocs resources.xml

2003-06-27 Thread vmote 
vmote   2003/06/27 08:07:17

  Modified:src/documentation/content/xdocs resources.xml
  Log:
  Add platform comment for XPath Visualizer. (Submitted by Clay Leeds).
  
  Revision  ChangesPath
  1.28  +4 -1  xml-fop/src/documentation/content/xdocs/resources.xml
  
  Index: resources.xml
  ===
  RCS file: /home/cvs/xml-fop/src/documentation/content/xdocs/resources.xml,v
  retrieving revision 1.27
  retrieving revision 1.28
  diff -u -r1.27 -r1.28
  --- resources.xml 28 May 2003 08:08:21 -  1.27
  +++ resources.xml 27 Jun 2003 15:07:17 -  1.28
  @@ -145,7 +145,10 @@
 [software] http://html2fo.sourceforge.net/";>html2fo is a converter from HTML to 
XSL-FO (GPL).
 [software] http://wh2fo.sourceforge.net/";>wh2fo is 
a converter from Word HTML to XSL-FO (MPL).
 [software] http://www.rtf2fo.com";>RTF2FO is a 
converter from RTF to XSL-FO by Novosoft (commercial).
  -  [software] http://www.vbxml.com/xpathvisualizer";>The 
XPath Visualizer. Web site says: "This is a full blown Visual XPath Interpreter 
for the evaluation of any XPath expression and visual presentation of the resulting 
nodeset or scalar value." (freeware)
  +   [software] http://www.vbxml.com/xpathvisualizer";>The 
XPath Visualizer.
  +Web site says: "This is a full blown Visual XPath Interpreter for the evaluation of 
any XPath expression and visual presentation of the resulting nodeset or scalar value."
  +Requires Internet Explorer 5+.
  +(freeware)
   
 
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 5674] - postscript generated by FOP is missing end commands

2003-06-27 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5674

postscript generated by FOP is missing end commands





--- Additional Comments From [EMAIL PROTECTED]  2003-06-27 15:01 ---
After getting the latest sources from anonymous cvs, updating to the maintenance
branch and updating PSRenderer.java a bit more (plus some file javac complained
about) I think I've managed to test your patch and it certainly seems to solve
the problem.

If I knew how you use verified and closed I'd probably mark this bug as one of
those, but I'll just leave that to you.

Thanks for your help!

PS. Am I correct in assuming this patch will be included in 0.20.5 when it's
done? DS.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]