cvs commit: xml-fop/src/java/org/apache/fop/layoutmgr AddLMVisitor.java TextLayoutManager.java

[gmazza]

gmazza  2004/03/01 15:50:26

  Modified:src/java/org/apache/fop/apps Driver.java
   src/java/org/apache/fop/fo FOText.java FOTreeBuilder.java
FObjMixed.java
   src/java/org/apache/fop/layoutmgr AddLMVisitor.java
TextLayoutManager.java
  Log:
  1.)  Modified TextLayoutManager to take an additional length
  parameter, indicating the maximum valid index of the passed-in
  character array.
  
  2.)  Removed from AddLMVisitor (which calls the above class), the
  re-fitting of the FOText character array to the size of the maximum
  valid index.
  
  3.)  Various small cleanup issues.
  
  Revision  ChangesPath
  1.53  +1 -2  xml-fop/src/java/org/apache/fop/apps/Driver.java
  
  Index: Driver.java
  ===
  RCS file: /home/cvs/xml-fop/src/java/org/apache/fop/apps/Driver.java,v
  retrieving revision 1.52
  retrieving revision 1.53
  diff -u -r1.52 -r1.53
  --- Driver.java   27 Feb 2004 17:39:05 -  1.52
  +++ Driver.java   1 Mar 2004 23:50:26 -   1.53
  @@ -540,8 +540,7 @@
   
   treeBuilder.setUserAgent(getUserAgent());
   treeBuilder.setFOInputHandler(foInputHandler);
  -treeBuilder.foTreeControl = currentDocument;
  -
  +treeBuilder.setFOTreeControl(currentDocument);
   
   return new ProxyContentHandler(treeBuilder) {
   
  
  
  
  1.15  +11 -2 xml-fop/src/java/org/apache/fop/fo/FOText.java
  
  Index: FOText.java
  ===
  RCS file: /home/cvs/xml-fop/src/java/org/apache/fop/fo/FOText.java,v
  retrieving revision 1.14
  retrieving revision 1.15
  diff -u -r1.14 -r1.15
  --- FOText.java   27 Feb 2004 17:57:40 -  1.14
  +++ FOText.java   1 Mar 2004 23:50:26 -   1.15
  @@ -44,7 +44,12 @@
   public char[] ca;
   
   /**
  - * the length of the character array containing the text
  + * The actual length of the text to be rendered within ca,
  + * starting from position 0 of the array.  
  + *
  + * This value is originally equal to ca.length, but becomes decremented
  + * during whitespace removal by the flow.Block class, via the 
  + * TextCharIterator.remove() method below.
*/
   public int length;
   
  @@ -87,7 +92,7 @@
   /**
*
* @param chars array of chars which contains the text in this object (may
  - * be a superset of the text in this object
  + * be a superset of the text in this object)
* @param start starting index into char[] for the text in this object
* @param end ending index into char[] for the text in this object
* @param ti TextInfo object for the text in this object
  @@ -163,6 +168,10 @@
   } else if (curIndex == length) {
   curIndex = --length;
   }
  +//  Temporary until leading space problem in 1.0 fixed
  +//  System.out.println("\n\nremove called: ca = \"" + 
  +//  new String(ca) + "\", length/node length: " + length 
  +//  + ", " + ca.length);
   }
   
   
  
  
  
  1.23  +9 -1  xml-fop/src/java/org/apache/fop/fo/FOTreeBuilder.java
  
  Index: FOTreeBuilder.java
  ===
  RCS file: /home/cvs/xml-fop/src/java/org/apache/fop/fo/FOTreeBuilder.java,v
  retrieving revision 1.22
  retrieving revision 1.23
  diff -u -r1.22 -r1.23
  --- FOTreeBuilder.java27 Feb 2004 17:57:40 -  1.22
  +++ FOTreeBuilder.java1 Mar 2004 23:50:26 -   1.23
  @@ -77,7 +77,7 @@
   private FOUserAgent userAgent;
   
   /** The FOTreeControl object managing the FO Tree that is being built */
  -public FOTreeControl foTreeControl;
  +private FOTreeControl foTreeControl;
   
   /** The SAX locator object maneging the line and column counters */
   private Locator locator; 
  @@ -103,6 +103,14 @@
   
   private FOUserAgent getUserAgent() {
   return userAgent;
  +}
  +
  +/**
  + * Sets the FO Tree Control for this object
  + * @param fotc FOTreeControl instance
  + */
  +public void setFOTreeControl(FOTreeControl fotc) {
  +this.foTreeControl = fotc;
   }
   
   /**
  
  
  
  1.21  +1 -1  xml-fop/src/java/org/apache/fop/fo/FObjMixed.java
  
  Index: FObjMixed.java
  ===
  RCS file: /home/cvs/xml-fop/src/java/org/apache/fop/fo/FObjMixed.java,v
  retrieving revision 1.20
  retrieving revision 1.21
  diff -u -r1.20 -r1.21
  --- FObjMixed.java27 Feb 2004 17:57:40 -  1.20
  +++ FObjMixed.java1 Mar 2004 23:50:26 -   1.21
  @@ -55,7 +55,7 @@
   ft.setName("text");
   
   /* characters() processing empty for FOTreeHandler, not empt

RE: [VOTE] Clay Leeds for Committer

[Andreas L. Delmelle]

> -Original Message-
> From: Clay Leeds [mailto:[EMAIL PROTECTED]
>

> Perhaps I might even pick up a Java book and figure out how to add
> command line parameters to FOP (I'm hoping I won't have to figure out
> the issue that Glen and Andreas raised[1] in February, though...:-p).
>

Why... that was going to be your first chore of course :-P

Nah, IAC well-earned, I think. You mentioned last Thursday that 'We must be
doing something right...', and if you ask me, having people like yourself on
our support-list could just be that little something.

Enjoy!

Cheers,

Andreas

Re: [VOTE] Clay Leeds for Committer

[J.Pietschmann]

Glen Mazza wrote:
[...]
+1
J.Pietschmann

cvs commit: xml-fop/src/documentation/content/xdocs compliance.xml

[cbowditch]

cbowditch2004/03/01 07:38:25

  Modified:src/documentation/content/xdocs compliance.xml
  Log:
  corrected compliance for baseline-shift and vertical-align properties
  
  Revision  ChangesPath
  1.25  +6 -2  xml-fop/src/documentation/content/xdocs/compliance.xml
  
  Index: compliance.xml
  ===
  RCS file: /home/cvs/xml-fop/src/documentation/content/xdocs/compliance.xml,v
  retrieving revision 1.24
  retrieving revision 1.25
  diff -u -r1.24 -r1.25
  --- compliance.xml12 Nov 2003 15:11:59 -  1.24
  +++ compliance.xml1 Mar 2004 15:38:25 -   1.25
  @@ -274,7 +274,9 @@
   
 
 
  -  
  +  
  +Only values "super" and "sub" have been implemented.
  +  
 
   Implemented only for table-cell and block-container.
   For table-cell, the "height" attribute must be set for the 
parent table-row; setting the height of the table or the table-cell results in 
vertical centering having no effect.
  @@ -502,7 +504,9 @@
   "inherit" not handled
 
 
  -  
  +  
  +Only works as a shorthand for baseline-shift 
property.
  +  
 
 
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] Clay Leeds for Committer

[Clay Leeds]

Wow! That's great! Better news than the Oscars even!

I guess it's not a shoo-in yet, but it certainly was a pleasant 
surprise logging in this morning with a 'popular' (read lots of 
replies...) message and a bunch of +1s attached!

Perhaps I might even pick up a Java book and figure out how to add 
command line parameters to FOP (I'm hoping I won't have to figure out 
the issue that Glen and Andreas raised[1] in February, though...:-p).

Thanks for the votes of confidence! I look forward to serving the FOP 
community in any way that I can (and right now, I guess that means as 
the Web Maestro!)...

Web Maestro Clay

[1]
http://marc.theaimsgroup.com/?l=fop-dev&m=107682075330763&w=2
On Feb 29, 2004, at 1:10 PM, Glen Mazza wrote:
Team,

Waxing chutzpaic, I'd like us to try again to make
Clay a committer on this project.  You may recall his
committership didn't pass last December (I can't
remember who blocked it, it might have been Jeremias
;-), but especially with the loss of Victor, I think
it's becoming increasingly evident our need for a 'Web
Maestro' to take care of our site.
He has been putting in a remarkably solid, loyal
effort for our project since Nov. 2002 [1], and also
has made himself known to Forrest-Dev on issues
regarding our site--most recently, in fixing the pesky
breadcrumb [2] problem for us.  He has also been a
leading evangelist on the commercial usage of FOP on
the FOP-user site [3], hence a welcome inspiration for
both us developers and our users.
The updates and issues he has brought up to us this
week, I'm sure he would be happy to take care of for
us, just as soon as we provide him write access.  I
also hope he develops a psychological "concept of
ownership" of our website over time, resulting in it
looking increasingly top-notch.
So let me start off the voting: +1.

Thanks,
Glen
[1]
http://marc.theaimsgroup.com/?a=10383297043&r=10&w=2
[2] Those are the unresolved
"skinconfig.trail.link3.name" links at the top of our
home page.
[3]
http://marc.theaimsgroup.com/?l=fop-user&m=107763815607390&w=2

Re: Preferences

[Peter B. West]

Peter B. West wrote:
...
We could address the JVM version issue by wrapping the java.util.prefs 
stuff in org.apache.fop.prefs or ...configuration classes which mimic 
.util.prefs by a thin wrapper around the latter classes, and providing 
for 1.3 compatible versions to be written.  The availability of 1.4 
could easily be tested at run-time, and the appropriate switch set for 
use in org.apache.fop.prefs, reducing the build complexity.
Don't mind me... The build complexity will be same as at present, 
requiring 1.3 and 1.4 components to be shifted in at build time.  The 
passing fantasy about a run-time switch afflicts me every now and then.

Peter
--
Peter B. West 

Re: Newbie Commiter Questions

[Peter B. West]

Chris,

I suspect that the problems with SSH2 might be to do with the way Putty 
represents SSH2 keys.  The format of the Putty file is different from 
the openssh format, even though they contain compatible data.  I think 
Putty has an option to import openssh format keys, and I seem to 
remember using this option to set up SSH2 keys that worked between Linux 
and Windows.

Peter

Chris Bowditch wrote:
Jeremias Maerki wrote:

I've had my problems with using SSH2. I finally tried SSH1 and it worked.
I suggest you create a SSH1 key pair and retry with this.


Thanks for the fast response Jeremias. I have managed to get SSH1 working.

There are two ways you can work with putty. Either you create a tunnel
for CVS which has the benefit that the connection is always there as
soon as you have connected to the server.


Yes I'm creating a tunnel with Putty and pointing WinCVS to localhost.

The other way is to use plink which has to build a connection everytime
you access CVS. Select SSH authentication in WinCVS and specify the full
path to plink.exe as SSH client. You need to have Putty Password agent
running for that.
Tell me if you need more info. Good luck!


I have managed to update the team page now. Thanks
--
Peter B. West 

Re: Wiki Migration and other issues

[Christian Geisert]

J.Pietschmann wrote:
Hi all,
now that the ASF has its new Wiki farm up and running,
they pester everyone with moving from UseModWiki
 http://nagoya.apache.org/wiki/apachewiki.cgi?HomePage
to the MoinMoinWiki:
 http://wiki.apache.org/general
Should we wait for the Apache XML reorganization to
complete or should we rush ahead and create out own
Wiki already?
+1 for the new wiki
It has a nicer look, supports XML export and we can have 'commit 
messages' to fop-cvs

Christian

cvs commit: xml-fop/src/documentation/content/xdocs team.xml

[cbowditch]

cbowditch2004/03/01 02:52:53

  Modified:src/documentation/content/xdocs team.xml
  Log:
  Testing my software setup by
  updating my description on Team page
  
  Revision  ChangesPath
  1.26  +3 -2  xml-fop/src/documentation/content/xdocs/team.xml
  
  Index: team.xml
  ===
  RCS file: /home/cvs/xml-fop/src/documentation/content/xdocs/team.xml,v
  retrieving revision 1.25
  retrieving revision 1.26
  diff -u -r1.25 -r1.26
  --- team.xml  19 Jan 2004 23:56:50 -  1.25
  +++ team.xml  1 Mar 2004 10:52:53 -   1.26
  @@ -13,7 +13,8 @@
 Active Committers
 
   mailto:[EMAIL PROTECTED]">Finn Bock (FB)
  -mailto:[EMAIL PROTECTED]">Chris Bowditch (CB)
  +mailto:[EMAIL PROTECTED]">Chris Bowditch (CB)
  +is a Java/VB Programmer from England.
   mailto:[EMAIL PROTECTED]">Andreas Delmelle (AD)
   mailto:[EMAIL PROTECTED]">Christian Geisert 
(CG)
   mailto:[EMAIL PROTECTED]">Peter Herweg (PH) is 
helping to 
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Newbie Commiter Questions

[Chris Bowditch]

Jeremias Maerki wrote:

I've had my problems with using SSH2. I finally tried SSH1 and it worked.
I suggest you create a SSH1 key pair and retry with this.
Thanks for the fast response Jeremias. I have managed to get SSH1 working.

There are two ways you can work with putty. Either you create a tunnel
for CVS which has the benefit that the connection is always there as
soon as you have connected to the server.
Yes I'm creating a tunnel with Putty and pointing WinCVS to localhost.

The other way is to use plink which has to build a connection everytime
you access CVS. Select SSH authentication in WinCVS and specify the full
path to plink.exe as SSH client. You need to have Putty Password agent
running for that.
Tell me if you need more info. Good luck!
I have managed to update the team page now. Thanks

Chris

Re: Newbie Commiter Questions

[Christian Geisert]

Chris Bowditch wrote:

[..]

Thinking that SSH is not strictly required for write access, I had a go 
Wrong!
You either need to make a frsh checkout with your commiiter id
or change your already checked out module as shown here: 
http://www.apache.org/dev/committers.html#general

Christian

Re: Newbie Commiter Questions

[Jeremias Maerki]

I've had my problems with using SSH2. I finally tried SSH1 and it worked.
I suggest you create a SSH1 key pair and retry with this.

There are two ways you can work with putty. Either you create a tunnel
for CVS which has the benefit that the connection is always there as
soon as you have connected to the server.

The other way is to use plink which has to build a connection everytime
you access CVS. Select SSH authentication in WinCVS and specify the full
path to plink.exe as SSH client. You need to have Putty Password agent
running for that.

Tell me if you need more info. Good luck!

On 01.03.2004 10:32:28 Chris Bowditch wrote:
> I know this subject has come up before, but I still cant quite get 
> things working after trawling through the archives.
> 
> I'm using WinCVS 1.3 and Putty to connect to the cvs.apache.org. My 
> understanding was that using SSH keys was optional but strongly 
> encouraged. So I had a go at creating the private/public key pairs, and 
> put the public key into .ssh directory on my apache home, and specified 
> the private key file to Putty, but when I click "open" in Putty and 
> enter userid/password I get a message saying
> 
> Trying public key authentication.
> Key is of wrong type (PuTTY SSH2 private key)
> 
> Any ideas, what this means? I specified SSH2 (RSA) when I generated my 
> keys. I noticed in the archives that some people have authorized_keys 
> and others have authorized_keys2 file, which do I need? I tried both, 
> but I still got the same message.
> 
> Thinking that SSH is not strictly required for write access, I had a go 
> at updating my description on the Team page, but WinCVS says:
> 
> cvs [server aborted]: "commit" requires write access to the repository


Jeremias Maerki

Newbie Commiter Questions

[Chris Bowditch]

I know this subject has come up before, but I still cant quite get 
things working after trawling through the archives.

I'm using WinCVS 1.3 and Putty to connect to the cvs.apache.org. My 
understanding was that using SSH keys was optional but strongly 
encouraged. So I had a go at creating the private/public key pairs, and 
put the public key into .ssh directory on my apache home, and specified 
the private key file to Putty, but when I click "open" in Putty and 
enter userid/password I get a message saying

Trying public key authentication.
Key is of wrong type (PuTTY SSH2 private key)
Any ideas, what this means? I specified SSH2 (RSA) when I generated my 
keys. I noticed in the archives that some people have authorized_keys 
and others have authorized_keys2 file, which do I need? I tried both, 
but I still got the same message.

Thinking that SSH is not strictly required for write access, I had a go 
at updating my description on the Team page, but WinCVS says:

cvs [server aborted]: "commit" requires write access to the repository

Any help would be appreciated.

Chris

Re: [VOTE] Clay Leeds for Committer

[Christian Geisert]

Glen Mazza wrote:
Team,

Waxing chutzpaic, I'd like us to try again to make
Clay a committer on this project.  You may recall his
+1

(in the hope that we finally get those breadcrumbs fixed and a whole 
site pdf ;-)

Christian

Re: [VOTE] Clay Leeds for Committer

[Chris Bowditch]

Glen Mazza wrote:



The updates and issues he has brought up to us this
week, I'm sure he would be happy to take care of for
us, just as soon as we provide him write access.  I
also hope he develops a psychological "concept of
ownership" of our website over time, resulting in it
looking increasingly top-notch.
So let me start off the voting: +1.
+1 from me too.

Chris

Re: [VOTE] Clay Leeds for Committer

[Oleg Tkachenko]

Glen Mazza wrote:

So let me start off the voting: +1.
+1

--
Oleg Tkachenko
http://blog.tkachenko.com
Multiconn Technologies, Israel