[Bug 53558] All but impossible to find the failing layout test in case of a regression

2012-07-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53558

--- Comment #5 from Mehdi Houshmand med1...@gmail.com ---
So I've been playing around with this this morning and with the junit-4.11
snapshot, it seems like all we need to do is change the @Parameters to
@Parameters(name = Test file = {0}). That seems to do the trick and
expresses the file name when a failure occurs.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53558] All but impossible to find the failing layout test in case of a regression

2012-07-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53558

--- Comment #6 from Mehdi Houshmand med1...@gmail.com ---
Ohh and I did some perusing and my sleuthing skills suggest we shouldn't have
to wait to long for the 4.11 release. Looking at the 4.x release dates, they
seem to be releasing annually (or there abouts) and 4.10 was released 10months
ago... Watch out Columbo, there's a new kid in town.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53573] New: Fop invalid position combining mark for Thai text (CTL)

2012-07-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53573

  Priority: P2
Bug ID: 53573
  Assignee: fop-dev@xmlgraphics.apache.org
   Summary: Fop invalid position combining mark for Thai text
(CTL)
  Severity: normal
Classification: Unclassified
  Reporter: na...@th.ibm.com
  Hardware: PC
Status: NEW
   Version: all
 Component: fonts
   Product: Fop

Created attachment 29082
  -- https://issues.apache.org/bugzilla/attachment.cgi?id=29082action=edit
The above text is original FOP output. The below text is CTL enbaled text

1. In order to make Thai glyph substitution work, the language tag must be
dflt instead of th. This is because many popular Thai font use dflt.
2. Using dflt language, both GSUB and GPOS are used. The problem is after it
used, all glyph are placed further to the right.

Notes:
1. Many Thai combining glyph have negative alignment. I suspect this is
involved in miss alignment calculation.
2. The ratio of displacement seem irrational. If it shifted to the left by the
same ratio, it is still invalid.

Question:
Should dflt being load by default ?

XML Data for testing:
?xml version=1.0 encoding=UTF-8?
dataกุญญูฐฐูฏฏูฎฎูบบ่บี่ปป่ปี่กำปำถํ้า/data

XSLT for testing:
?xml version=1.0 encoding=ISO-8859-1?

xsl:stylesheet version=1.0
xmlns:xsl=http://www.w3.org/1999/XSL/Transform;

xsl:template match=/
fo:root xmlns:fo=http://www.w3.org/1999/XSL/Format;
fo:layout-master-set
fo:simple-page-master master-name=A4
fo:region-body /
/fo:simple-page-master
/fo:layout-master-set

fo:page-sequence master-reference=A4
fo:flow flow-name=xsl-region-body
fo:block script=thai language=dflt font-size=32pt
font-family=AngsanaUPC
xsl:value-of select=data /
/fo:block
/fo:flow
/fo:page-sequence
/fo:root
/xsl:template

/xsl:stylesheet

The fop.xconf has added font into fonts section of applicaton/pdf renderer:
font embed-url=file:///c:/windows/fonts/angsau.ttf kerning=yes
  font-triplet name=AngsanaUPC style=normal weight=normal/
/font

The Java code used to reproduce:

FopFactory fopFac = FopFactory.newInstance(new File(fop.xconf));
OutputStream outputStream = new BufferedOutputStream(new
FileOutputStream(c:\\temp\\fopThai.pdf));

Fop fop = fopFac.newFop(MimeConstants.MIME_PDF, outputStream);

TransformerFactory transFac = TransformerFactory.newInstance();
Source xslData = new StreamSource(new File(data.xslt));
Transformer trans = transFac.newTransformer(xslData);
Result res = new SAXResult(fop.getDefaultHandler());

Source xmlData = new StreamSource(new File(thaidata.xml));
trans.transform(xmlData, res);

outputStream.close();

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 53569] SVG seems to be generally broken

2012-07-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53569

Pascal Sancho psancho@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME
 OS||All

--- Comment #3 from Pascal Sancho psancho@gmail.com ---
For me, the whole test case works as expected against *all* FOP versions,
including trunk.

Note that there is no build number in FOP release process, as you refer to the
build 20120718.
Perhaps that build is made by a third party, and perhaps there is something
wrong in it.

For further investigation, you should dive into, or give, more info:
 - platform (OS + JVM)
 - how did you get the FOP 1.1RC1 release
 - how do you run it
 - trace log
 - pdf output
 - etc.

Feel free to reopen if you have further info that allow somebody to reproduce
this issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53573] Fop invalid position combining mark for Thai text (CTL)

2012-07-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53573

Mehdi Houshmand med1...@gmail.com changed:

   What|Removed |Added

 OS||All

--- Comment #1 from Mehdi Houshmand med1...@gmail.com ---
This certainly seems like an interesting issue and you'll have to excuse my
ignorance on this matter, but are the GPOS and GSUB absolutely necessary for
ALL Thai script? I'm sure we have users working with Thai that used FOP prior
to the inclusion of the complex scripts feature (which takes GPOS/GSUB into
account.)

If I've just exposed my ignorance, my apologies, but my suggestion was going to
be to try using FOP-1.0 and see if it behaves as expected. You will however
have to change your Java slightly due to modifications to the API, but there
are plenty of examples and documentation on the website about how to do this.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53569] SVG seems to be generally broken

2012-07-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53569

nick.heywo...@altova.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |---

--- Comment #4 from nick.heywo...@altova.com ---
I downloaded the build from here:

http://ci.apache.org/projects/xmlgraphics/fop/snapshots/

With 20120718 build I was referring to the file I downloaded
(fop-20120718-bin.zip).

I just tested with fop-20120719-bin.zip, and using SVG still results in the
same problem: When opening the PDF file, Acrobat Reader displays An error
exists on this page. Acrobat Reader may not display the page correctly [...],
and the image is not present nithe PDF file.

My platform is Windows 7 Enterprise SP1; I run it as fop.bat -fo image.fo -pdf
out.pdf.

I will attach the resulting PDF file.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53569] SVG seems to be generally broken

2012-07-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53569

--- Comment #5 from nick.heywo...@altova.com ---
Created attachment 29083
  -- https://issues.apache.org/bugzilla/attachment.cgi?id=29083action=edit
The resulting PDF document

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53569] SVG seems to be generally broken

2012-07-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53569

Pascal Sancho psancho@gmail.com changed:

   What|Removed |Added

 Status|REOPENED|NEEDINFO

--- Comment #6 from Pascal Sancho psancho@gmail.com ---
always not reproducible for me.
What java version/vendor do you use?
Can you provide a trace log?

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53569] SVG seems to be generally broken

2012-07-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53569

--- Comment #7 from nick.heywo...@altova.com ---
- java -version gives

java version 1.6.0_31
Java(TM) SE Runtime Environment (build 1.6.0_31-b05)
Java HotSpot(TM) 64-Bit Server VM (build 20.6-b01, mixed mode)

- Calling fop.bat with -d gives the trace attached as trace.txt.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53569] SVG seems to be generally broken

2012-07-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53569

--- Comment #8 from nick.heywo...@altova.com ---
Created attachment 29084
  -- https://issues.apache.org/bugzilla/attachment.cgi?id=29084action=edit
Output from fop.bat -d

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53573] Fop invalid position combining mark for Thai text (CTL)

2012-07-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53573

--- Comment #2 from na...@th.ibm.com ---
Thanks for the promptly reply.
Yes, i have tested with FOP 1.0 and it product exactly the same as the first
line of the picture i attached.

There are few Thai fonts that aren't using GSUB and GPOS.
Those few deploy a default glyph position that will never collide with other
glyph. However, it gave a result with problem that call floating tone mark.
These few fonts also leave the glyph determination work to LayoutEngine.
It expects LayoutEngine to pick correct glyph by itself. In order to accomplish
this, it need State Machine. You can take a peek at ICU4C LayoutEngine. There
is a ThaiLayoutEngine there. However, ICU4J doesn't have one.

Note:
1. In order to avoid GSUB and GPOS it require the font to use Unicode PVA.
Adobe recommends to avoid it as it is non-standard. The best example of problem
is ICU4C uses different code point compare to Adobe that assign to Thai
glyph.ICU gives more correct result.
2. All known Thai fonts in MS.Windows use GSUB and GPOS except Arial Unicode.
3. All known True Type fonts in Linux use GSUB and GPOS.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53569] SVG seems to be generally broken

2012-07-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53569

nick.heywo...@altova.com changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53569] SVG seems to be generally broken

2012-07-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53569

Pascal Sancho psancho@gmail.com changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #9 from Pascal Sancho psancho@gmail.com ---
(In reply to comment #8)
 Created attachment 29084 [details]
 Output from fop.bat -d

I found something wrong in your trace:
target-resolution set to: 0.0dpi (px2mm=Infinity)
userconfig is null
userconfig is null

target-resolution defaults to 72.0dpi, so you have something wrong in your
config file, can you check that point?

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53569] SVG seems to be generally broken

2012-07-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53569

nick.heywo...@altova.com changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #10 from nick.heywo...@altova.com ---
Thanks, some progress made. I just realized that FOP 1.1 doesn't use a config
file by default. In my FOP 0.95 installation I had (long ago) added

-c %LOCAL_FOP_HOME%conf/fop.xconf

When I add this to my FOP 1.1 installation, Acrobat reader no longer displays
an error message. However, for the image to be rendered,
I need to take additional steps:

- In the FOP 0.95 config file, I had commented out base./base after
observing it prevented URLs being resolved relative to the FO file
  (our images are usually stored relative to the FO file). But doing the same
in the FOP 1.1 config file doesn't help. Has anything changed here?
  What configuration is required for an image URL to be resolved relative to
the FO file?

- Since I currently can't get relative URLs to work, I tried an absolute URL.
FOP 1.1 seems to be stricter about URL syntax than FOP 0.95.
  E.g. FOP 0.95 accepts url(C:\Temp\Boxes.svg), but with FOP 1.1 I need to
write url(file:///C:/Temp/Boxes.svg). Has anything changed here?

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53569] SVG seems to be generally broken

2012-07-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53569

Pascal Sancho psancho@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #11 from Pascal Sancho psancho@gmail.com ---
(In reply to comment #10)
 Thanks, some progress made. I just realized that FOP 1.1 doesn't use a
 config file by default. In my FOP 0.95 installation I had (long ago) added
 
 -c %LOCAL_FOP_HOME%conf/fop.xconf
 
 When I add this to my FOP 1.1 installation, Acrobat reader no longer
 displays an error message. However, for the image to be rendered,
 I need to take additional steps:
 
 - In the FOP 0.95 config file, I had commented out base./base after
 observing it prevented URLs being resolved relative to the FO file
   (our images are usually stored relative to the FO file). But doing the
 same in the FOP 1.1 config file doesn't help. Has anything changed here?
   What configuration is required for an image URL to be resolved relative to
 the FO file?
 
 - Since I currently can't get relative URLs to work, I tried an absolute
 URL. FOP 1.1 seems to be stricter about URL syntax than FOP 0.95.
   E.g. FOP 0.95 accepts url(C:\Temp\Boxes.svg), but with FOP 1.1 I need to
 write url(file:///C:/Temp/Boxes.svg). Has anything changed here?

Hmm,
the discussion becomes now off topic here, and should be continued on fop-user
list.
That said, C:\Temp\Boxes.svg is not a regular URL; FOP aims to be compliant
with all used standards, this ensure to be more consistant.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53573] Fop invalid position combining mark for Thai text (CTL)

2012-07-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53573

Glenn Adams gad...@apache.org changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #3 from Glenn Adams gad...@apache.org ---
Please provide the following:

* input FO file (not XSLT/XML files)
* output PDF file
* version of FOP you are using
* any console output from FOP

Also, note that you should not specify script=thai or language=dflt, as
doing so may prevent application of correct GSUB/GPOS tables (assuming you are
using FOP1.1rc1 or current trunk).

Also, note that [1] does not yet list thai as supported (by the recent complex
scripts addition). In fact, the GSUB/GPOS features of thai fonts will be
enabled if you do not specify script or specify script=auto and if you do not
specify language; however, line breaking does not yet take into account
legitimate thai break candidates, and I have not yet tested thai to my
satisfaction, so I did not list thai as supported yet.

http://xmlgraphics.apache.org/fop/1.1rc1/complexscripts.html#supported_scripts

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53577] New: explicit language may prevent gsub/gpos application

2012-07-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53577

  Priority: P2
Bug ID: 53577
  Assignee: fop-dev@xmlgraphics.apache.org
   Summary: explicit language may prevent gsub/gpos application
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: gad...@apache.org
  Hardware: All
Status: NEW
   Version: 1.1dev
 Component: page-master/layout
   Product: Fop

Need to ensure that if author specifies language='dflt' or language=''
where '' effectively maps to the default language, but font does not list
'', then gsub/gpos features will be used if applicable.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53578] New: explicit script may prevent gsub/gpos application

2012-07-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53578

  Priority: P2
Bug ID: 53578
  Assignee: fop-dev@xmlgraphics.apache.org
   Summary: explicit script may prevent gsub/gpos application
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: gad...@apache.org
  Hardware: All
Status: NEW
   Version: 1.1dev
 Component: page-master/layout
   Product: Fop

Need to ensure that if author specifies script='dflt' or script='' where
'' effectively maps to the default script, but font does not list '',
then gsub/gpos features will be used if applicable.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53577] explicit language may prevent gsub/gpos application

2012-07-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53577

Glenn Adams gad...@apache.org changed:

   What|Removed |Added

 Blocks||53573

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53573] Fop invalid position combining mark for Thai text (CTL)

2012-07-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53573

Glenn Adams gad...@apache.org changed:

   What|Removed |Added

 Depends on||53577, 53578

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53578] explicit script may prevent gsub/gpos application

2012-07-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53578

Glenn Adams gad...@apache.org changed:

   What|Removed |Added

 Blocks||53573

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53573] Fop invalid position combining mark for Thai text (CTL)

2012-07-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53573

--- Comment #4 from Glenn Adams gad...@apache.org ---
Created attachment 29090
  -- https://issues.apache.org/bugzilla/attachment.cgi?id=29090action=edit
test FO file showing gsub/gpos application

This FO shows the same data with Angsana UPC with various settings of language
and script. Note that with or without language='dflt' and with or without
script='thai' does not impact the results. However, specifying language='th'
does prevent gsub/gpos application.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53573] Fop invalid position combining mark for Thai text (CTL)

2012-07-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53573

--- Comment #5 from Glenn Adams gad...@apache.org ---
Created attachment 29091
  -- https://issues.apache.org/bugzilla/attachment.cgi?id=29091action=edit
test PDF file showing gsub/gpos application

This file shows the output using FOP1.1rc1 with the attachment 29090. Clearly
the gsub/gpos features *are* working given acceptable language/script settings.

-- 
You are receiving this mail because:
You are the assignee for the bug.


merge from ^/branches/fop-1_1 to ^/trunk

2012-07-20 Thread Glenn Adams
I have completed a reintegration merge from fop-1_1 into trunk followed by
a record-only merge on fop-1_1 to allow it to incur future reintegration.
Let me know if you notice anything amiss.