Re: [fossil-users] More timeline changes

2017-11-25 Thread bytevolcano 
On Sat, 25 Nov 2017 18:46:52 -0600
Zakero  wrote:

> To help make the ellipses more visible, you could put them in their
> own   and let the skin figure out what looks best.  Also,
> instead of using "...", what about "[+]"?

If it's going at the end of the text, how about ">>>"?
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] A-B comparison of proposed timeline changes

2017-11-25 Thread Andy Bradford 
Thus said Jacob MacDonald on Fri, 24 Nov 2017 18:52:41 +:

> Seems like I'm in the minority, but  I prefer the A version. I tend to
> like  compact  UIs  and  having all  the  relevant  information  close
> together and the commit hash prominently displayed is nice.

The  only reason  why I  said  that the  separate line  was cleaner  was
because it made it easier to find the commit hash. When it is all on one
line, I actually  prefer the commit hash  to be the very  first piece of
text on the  line. This makes everything justified nicely  and it's easy
to predict  where I  should place my  mouse if I  want to  copy/paste or
click on the hash. If it's in  some random place on the line because the
``details'' have  been moved to  the end  of a variable  length comment,
then  I would  rather have  the ``details''  on a  line by  itself which
preserves the ability to navigate commit hashes easily in the timeline.

Andy
-- 
TAI64 timestamp: 40005a1a458d


___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] A-B comparison of proposed timeline changes

2017-11-25 Thread Andy Bradford 
Thus said Richard Hipp on Fri, 24 Nov 2017 11:12:14 -0500:

> Now fixed.

Verified.

> Other  changes  on   https://www.fossil-scm.org/b/timeline  since  the
> original comparison request:
>
>   (1) The  "details" section  is shown  on a  separate line  below the
> check-in comment.

I just  looked and  I don't  see the ``details''  section on  a separate
line. Is that intentional?

>   (2) The "details" are in the same font-color as the comment-text but
> have a slightly reduced font size.

This seems to me to be an improvement.

Andy
-- 
TAI64 timestamp: 40005a1a4495


___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] More timeline changes

2017-11-25 Thread Jungle Boogie 
On Sat 25 Nov 2017  6:46 PM, Zakero wrote:
> To help make the ellipses more visible, you could put them in their own
>   and let the skin figure out what looks best.  Also, instead of
> using "...", what about "[+]"?
> 

Yes, I support this suggestion. Most sites I've seen that can expand/shrink
info usually wrap it with something like [+] [-] buttons.

> >
> > On Sat, Nov 25, 2017 at 5:51 PM, Marc Simpson  wrote:
> >
> >> One other (potential) problem: without the hash prefix, descriptions
> >> run together.
> >>
> >> Example: http://www.sqlite.org/src/timeline, 2017-11-24. The graph
> >> nodes are flushed to the left, so descriptions appear as:
> >>
> >>   Add the "^" syntax from fts3/4 to fts5. ...
> >>   Enhance the configure script to detect zLib. ...

Yes, this is a good point. Your eyes need to read all the way to the end
of the line with "fts5" and then to the beginning of the next line with
the timestamp to see these are two different check-ins.

> >>
> >>
> >> /M
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] More timeline changes

2017-11-25 Thread David Mason 
What you have seems to handle the ellipsis properly (by my definition of
properly).

But you really should use title/tooltip.

On 25 November 2017 at 21:45, Richard Hipp  wrote:

> On 11/25/17, Richard Hipp  wrote:
> > On 11/25/17, sky5w...@gmail.com  wrote:
> >> Ok, the current behavior is cool, but renders the ellipses superfluous.
> >> Clicking anywhere in a line expands/contracts the info.
> >> Any chance to drop the many many ⋯'s after all my comments?
> >>
> >
> > I think the following CSS will do that for you:
> >
> > .timelineEllipsis { display: 'none'; }
>
> No, that won't work, because the toggleEllipsis() JS function will get
> confused.
>
> How about making your ellipsis very small:
>
>.timelineEllipsis { font-size: 50%; }
>
> --
> D. Richard Hipp
> d...@sqlite.org
> ___
> fossil-users mailing list
> fossil-users@lists.fossil-scm.org
> http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
>
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] More timeline changes

2017-11-25 Thread sky5walk 
I will try smallest scaling of the ellipsis, if it really must remain...
And I can live with .timelineEllipsis { display: 'none'; }, since the
Advanced button will override if I want extra info.
Thanks for the options.



On Sat, Nov 25, 2017 at 9:52 PM, David Mason  wrote:

> 
>   function cancelProp(event){
>  if (event.stopPropagation) {event.stopPropagation()} //w3c
> else {event.cancelBubble = true } // ie
>   }
> 
> 
>   http://google.ca"; onclick="cancelProp(event)" title=" ">
> google
>   
>   blah blah
> 
>
> Suppressing the title on the link is tricky the above works on
> Chrome/Firefox but shows a space on IE/Safari - see:
> https://stackoverflow.com/questions/5881954/html-stop-child-elements-from-
> inheriting-parents-title-attribute but you might have a useful title to
> give it.
>
> ../Dave
>
> On 25 November 2017 at 20:47, Richard Hipp  wrote:
>
>> On 11/25/17, David Mason  wrote:
>> >
>> > When I did that, I made clicking on anywhere in that div expand it.
>> >
>>
>> I've done that in the latest.  Actually, I made it click-to-toggle.
>> That seems to work a lot better than trying to click on the ellipsis.
>>
>> But there is a subtle problem.  For timeline comments that contain a
>> hyperlink (ex: https://www.sqlite.org/srcx/timeline?c=b016c28f) if I
>> click on the hyperlink, it first toggles the detail on/off before it
>> takes the hyperlink.  Do you have suggestions on how I can disable the
>> "onclick" on the outer  when one clicks inside an inner ?
>> --
>> D. Richard Hipp
>> d...@sqlite.org
>>
>
>
> ___
> fossil-users mailing list
> fossil-users@lists.fossil-scm.org
> http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
>
>
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] More timeline changes

2017-11-25 Thread David Mason 

  function cancelProp(event){
 if (event.stopPropagation) {event.stopPropagation()} //w3c
else {event.cancelBubble = true } // ie
  }


  http://google.ca"; onclick="cancelProp(event)" title=" ">
google
  
  blah blah


Suppressing the title on the link is tricky the above works on
Chrome/Firefox but shows a space on IE/Safari - see:
https://stackoverflow.com/questions/5881954/html-stop-child-elements-from-inheriting-parents-title-attribute
but you might have a useful title to give it.

../Dave

On 25 November 2017 at 20:47, Richard Hipp  wrote:

> On 11/25/17, David Mason  wrote:
> >
> > When I did that, I made clicking on anywhere in that div expand it.
> >
>
> I've done that in the latest.  Actually, I made it click-to-toggle.
> That seems to work a lot better than trying to click on the ellipsis.
>
> But there is a subtle problem.  For timeline comments that contain a
> hyperlink (ex: https://www.sqlite.org/srcx/timeline?c=b016c28f) if I
> click on the hyperlink, it first toggles the detail on/off before it
> takes the hyperlink.  Do you have suggestions on how I can disable the
> "onclick" on the outer  when one clicks inside an inner ?
> --
> D. Richard Hipp
> d...@sqlite.org
>
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] More timeline changes

2017-11-25 Thread Richard Hipp 
On 11/25/17, Richard Hipp  wrote:
> On 11/25/17, sky5w...@gmail.com  wrote:
>> Ok, the current behavior is cool, but renders the ellipses superfluous.
>> Clicking anywhere in a line expands/contracts the info.
>> Any chance to drop the many many ⋯'s after all my comments?
>>
>
> I think the following CSS will do that for you:
>
> .timelineEllipsis { display: 'none'; }

No, that won't work, because the toggleEllipsis() JS function will get confused.

How about making your ellipsis very small:

   .timelineEllipsis { font-size: 50%; }

-- 
D. Richard Hipp
d...@sqlite.org
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] More timeline changes

2017-11-25 Thread Richard Hipp 
On 11/25/17, sky5w...@gmail.com  wrote:
> Ok, the current behavior is cool, but renders the ellipses superfluous.
> Clicking anywhere in a line expands/contracts the info.
> Any chance to drop the many many ⋯'s after all my comments?
>

I think the following CSS will do that for you:

.timelineEllipsis { display: 'none'; }
-- 
D. Richard Hipp
d...@sqlite.org
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] More timeline changes

2017-11-25 Thread sky5walk 
Ok, the current behavior is cool, but renders the ellipses superfluous.
Clicking anywhere in a line expands/contracts the info.
Any chance to drop the many many ⋯'s after all my comments?

On Sat, Nov 25, 2017 at 8:47 PM, Richard Hipp  wrote:

> On 11/25/17, David Mason  wrote:
> >
> > When I did that, I made clicking on anywhere in that div expand it.
> >
>
> I've done that in the latest.  Actually, I made it click-to-toggle.
> That seems to work a lot better than trying to click on the ellipsis.
>
> But there is a subtle problem.  For timeline comments that contain a
> hyperlink (ex: https://www.sqlite.org/srcx/timeline?c=b016c28f) if I
> click on the hyperlink, it first toggles the detail on/off before it
> takes the hyperlink.  Do you have suggestions on how I can disable the
> "onclick" on the outer  when one clicks inside an inner ?
> --
> D. Richard Hipp
> d...@sqlite.org
> ___
> fossil-users mailing list
> fossil-users@lists.fossil-scm.org
> http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
>
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] More timeline changes

2017-11-25 Thread Richard Hipp 
On 11/25/17, David Mason  wrote:
>
> When I did that, I made clicking on anywhere in that div expand it.
>

I've done that in the latest.  Actually, I made it click-to-toggle.
That seems to work a lot better than trying to click on the ellipsis.

But there is a subtle problem.  For timeline comments that contain a
hyperlink (ex: https://www.sqlite.org/srcx/timeline?c=b016c28f) if I
click on the hyperlink, it first toggles the detail on/off before it
takes the hyperlink.  Do you have suggestions on how I can disable the
"onclick" on the outer  when one clicks inside an inner ?
-- 
D. Richard Hipp
d...@sqlite.org
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] More timeline changes

2017-11-25 Thread Zakero 
To help make the ellipses more visible, you could put them in their own
  and let the skin figure out what looks best.  Also, instead of
using "...", what about "[+]"?

Something that I consider a functional inconsistency with the current
implementation is that after the "..." is clicked on, there is no way to
hide the now visible details.  A possible solution would be have a "[-]" to
re-hide the info.

Another issue that I noticed with timeline?commentformat=2 is the the hash
does not always appear at the end of the commit message.  Take this commit
line as an example: "Edit [a46b9e77]: Edit check-in comment. •••"


On Sat, Nov 25, 2017 at 5:31 PM,  wrote:

> Man, are those ellipses absolutely necessary?
> (So close with the previous uncluttered timeline.)
> Is it possible to make the 1st word/sentence of the checkin comment a
> hyperlink to the extra info?
>
> On Sat, Nov 25, 2017 at 5:51 PM, Marc Simpson  wrote:
>
>> One other (potential) problem: without the hash prefix, descriptions
>> run together.
>>
>> Example: http://www.sqlite.org/src/timeline, 2017-11-24. The graph
>> nodes are flushed to the left, so descriptions appear as:
>>
>>   Add the "^" syntax from fts3/4 to fts5. ...
>>   Enhance the configure script to detect zLib. ...
>>
>> It's not immediately clear that these are separate commits given the
>> amount of horizontal space; adding a bit more vertical padding or
>> boxing descriptions (perhaps with alternating colours) might help?
>>
>> Personally, I prefer seeing the short hash before each description
>> (perhaps this could be an option in the Advanced view?).
>>
>> /M
>>
>> On Sat, Nov 25, 2017 at 2:06 PM, Tony Papadimitriou 
>> wrote:
>> > The idea looks very good to me.  But the ellipses are indeed barely
>> visible.
>> > How about replacing ... with [*] as a generic (foot)note mark?
>> >
>> > -Original Message- From: Richard Hipp
>> > Timelines now come up in Basic mode, which means only the check-in
>> > comment shows.  There are ellipses at the end of each comment.  If you
>> > click on the ellipsis for one comment, it expands the (detail) section
>> > for that one timeline entry.
>> >
>> > The ellipses at the ends of comments in basic mode are barely visible.
>> >
>> > D. Richard Hipp
>> >
>> >
>> > ___
>> > fossil-users mailing list
>> > fossil-users@lists.fossil-scm.org
>> > http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
>> ___
>> fossil-users mailing list
>> fossil-users@lists.fossil-scm.org
>> http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
>>
>
>
> ___
> fossil-users mailing list
> fossil-users@lists.fossil-scm.org
> http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
>
>
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] More timeline changes

2017-11-25 Thread Richard Hipp 
On 11/25/17, Tony Papadimitriou  wrote:
> But the ellipses are indeed barely visible.

I replaced the "..." text with "•••".  I think it is
better now.  I'm still not 100% happy with it, though.

-- 
D. Richard Hipp
d...@sqlite.org
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] More timeline changes

2017-11-25 Thread David Mason 
Looks good.

When I did that, I made clicking on anywhere in that div expand it.

You should also add a title that says "Click to expand" so that they don't
have to know/infer that the ellipsis is an active link.

I also like being able to shrink it back... right now there isn't that much
extra detail, but you may add more.

I don't want to sound critical or look a gift-horse in the mouth, but I
looked at your page source and it's way more complicated than it needs to
be.  If you look at my message in the other thread, all the code is there
to make it work with a lot less generated HTML and be a lot cleaner.

../Dave

On 25 November 2017 at 16:40, Richard Hipp  wrote:

> The names of the of the buttons are now "Advanced" and "Basic".  And
> they work by setting .style.display using JS.
>
> Timelines now come up in Basic mode, which means only the check-in
> comment shows.  There are ellipses at the end of each comment.  If you
> click on the ellipsis for one comment, it expands the (detail) section
> for that one timeline entry.
>
> Try it out:
>
>  https://www.fossil-scm.org/fossil/timeline
>  https://sqlite.org/srcx/timeline
>
> Problems:  (please suggest solutions)
>
> The ellipses at the ends of comments in basic mode are barely visible.
> And they are not configurable using CSS (at least not by any CSS that
> I know).
>
> That's the only serious problem that springs immediately to mind, but
> perhaps you can find others for me.
> --
> D. Richard Hipp
> d...@sqlite.org
> ___
> fossil-users mailing list
> fossil-users@lists.fossil-scm.org
> http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
>
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] More timeline changes

2017-11-25 Thread sky5walk 
Man, are those ellipses absolutely necessary?
(So close with the previous uncluttered timeline.)
Is it possible to make the 1st word/sentence of the checkin comment a
hyperlink to the extra info?

On Sat, Nov 25, 2017 at 5:51 PM, Marc Simpson  wrote:

> One other (potential) problem: without the hash prefix, descriptions
> run together.
>
> Example: http://www.sqlite.org/src/timeline, 2017-11-24. The graph
> nodes are flushed to the left, so descriptions appear as:
>
>   Add the "^" syntax from fts3/4 to fts5. ...
>   Enhance the configure script to detect zLib. ...
>
> It's not immediately clear that these are separate commits given the
> amount of horizontal space; adding a bit more vertical padding or
> boxing descriptions (perhaps with alternating colours) might help?
>
> Personally, I prefer seeing the short hash before each description
> (perhaps this could be an option in the Advanced view?).
>
> /M
>
> On Sat, Nov 25, 2017 at 2:06 PM, Tony Papadimitriou  wrote:
> > The idea looks very good to me.  But the ellipses are indeed barely
> visible.
> > How about replacing ... with [*] as a generic (foot)note mark?
> >
> > -Original Message- From: Richard Hipp
> > Timelines now come up in Basic mode, which means only the check-in
> > comment shows.  There are ellipses at the end of each comment.  If you
> > click on the ellipsis for one comment, it expands the (detail) section
> > for that one timeline entry.
> >
> > The ellipses at the ends of comments in basic mode are barely visible.
> >
> > D. Richard Hipp
> >
> >
> > ___
> > fossil-users mailing list
> > fossil-users@lists.fossil-scm.org
> > http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
> ___
> fossil-users mailing list
> fossil-users@lists.fossil-scm.org
> http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
>
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] More timeline changes

2017-11-25 Thread Marc Simpson 
One other (potential) problem: without the hash prefix, descriptions
run together.

Example: http://www.sqlite.org/src/timeline, 2017-11-24. The graph
nodes are flushed to the left, so descriptions appear as:

  Add the "^" syntax from fts3/4 to fts5. ...
  Enhance the configure script to detect zLib. ...

It's not immediately clear that these are separate commits given the
amount of horizontal space; adding a bit more vertical padding or
boxing descriptions (perhaps with alternating colours) might help?

Personally, I prefer seeing the short hash before each description
(perhaps this could be an option in the Advanced view?).

/M

On Sat, Nov 25, 2017 at 2:06 PM, Tony Papadimitriou  wrote:
> The idea looks very good to me.  But the ellipses are indeed barely visible.
> How about replacing ... with [*] as a generic (foot)note mark?
>
> -Original Message- From: Richard Hipp
> Timelines now come up in Basic mode, which means only the check-in
> comment shows.  There are ellipses at the end of each comment.  If you
> click on the ellipsis for one comment, it expands the (detail) section
> for that one timeline entry.
>
> The ellipses at the ends of comments in basic mode are barely visible.
>
> D. Richard Hipp
>
>
> ___
> fossil-users mailing list
> fossil-users@lists.fossil-scm.org
> http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] More timeline changes

2017-11-25 Thread Tony Papadimitriou 

The idea looks very good to me.  But the ellipses are indeed barely visible.
How about replacing ... with [*] as a generic (foot)note mark?

-Original Message- 
From: Richard Hipp 


Timelines now come up in Basic mode, which means only the check-in
comment shows.  There are ellipses at the end of each comment.  If you
click on the ellipsis for one comment, it expands the (detail) section
for that one timeline entry.

The ellipses at the ends of comments in basic mode are barely visible.

D. Richard Hipp

___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] More timeline changes

2017-11-25 Thread Richard Hipp 
The names of the of the buttons are now "Advanced" and "Basic".  And
they work by setting .style.display using JS.

Timelines now come up in Basic mode, which means only the check-in
comment shows.  There are ellipses at the end of each comment.  If you
click on the ellipsis for one comment, it expands the (detail) section
for that one timeline entry.

Try it out:

 https://www.fossil-scm.org/fossil/timeline
 https://sqlite.org/srcx/timeline

Problems:  (please suggest solutions)

The ellipses at the ends of comments in basic mode are barely visible.
And they are not configurable using CSS (at least not by any CSS that
I know).

That's the only serious problem that springs immediately to mind, but
perhaps you can find others for me.
-- 
D. Richard Hipp
d...@sqlite.org
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] Trolling GitHub for ideas

2017-11-25 Thread Offray Vladimir Luna Cárdenas 


On 25/11/17 09:17, Richard Hipp wrote:
> The SQLite project is mirrored on GitHub (not by me).  This mirror
> provides a good opportunity to compare the interfaces of GitHub and
> Fossil using the same underlying data.
>
> https://sqlite.org/srcx/timeline?basic
> https://github.com/mackyle/sqlite/commits/master
>
> Your suggestions for useful features found in GitHub but missing from
> Fossil, or for pages in GitHub that work especially well and that you
> would like to see replicated in Fossil, are greatly appreciated.
>
The first think that jumps into attention are user avatars and checksums
in front of each commit. There ares some users with generic avatars and
others with custom ones. I think that some users would like to have some
small eye candy for their users inside fossil repositories, like
avatars. The checksums could be handy. Fossil seems more minimal (as we
know) and is really good to have the branches with code colors showed in
the time line.

Cheers,
Offray
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] More timeline changes

2017-11-25 Thread bch 
On Sat, Nov 25, 2017 at 7:26 AM  wrote:

> "​(2) Decluttered should be the default."
> I agree clutter should not be default?​
> I would drop that term altogether.
>

Simplified vs detailed would probably be more appropriate words. I do like
the “files” toggle in the “cluttered” mode, though.


-bch



> On Sat, Nov 25, 2017 at 8:47 AM, Richard Hipp  wrote:
>
>> In the latest code on https://www.fossil-scm.org/fossil/timeline and
>> at https://sqlite.org/srcx/timeline has a "Declutter" button on the
>> sub-menu bar to simplify the screen.  In the simplified timeline,
>> there is a "Details" button to get all the details back again.
>>
>> I'm not done with this interface improvement push.  Here are my
>> short-term plans:
>>
>> (1) Right now, pressing "Declutter" or "Details" is a server
>> round-trip.  I think it would better to handle this using javascript.
>>
>> (2) Decluttered should be the default.  Currently Details is the
>> default.  I spent a lot of time experimenting last night, and what I
>> found myself doing every time I encountered a timeline was immediately
>> pressing the "Declutter" button to get a high-level overview of the
>> graph, then clicking on "Details" if I wanted to see more.  From that
>> experience, I think coming up in Decluttered mode would be a much
>> better approach.
>>
>> (3) Details/Declutter for the entire graph is good and should be kept.
>> But it would be even better to be able to see the details of
>> individual timeline entries.  I'm thinking that timelines come up in
>> decluttered mode (showing only the check-in comment for each entry)
>> but with ellipses or some other small icon at the end of each comment
>> that you can click on to expand the details.
>>
>> You can help!  Send me your ideas of what you think timelines should
>> look like.  Even better:  send me mock-ups.  Static HTML pages that
>> you have hand-edited will be fine - just be sure to include the CSS,
>> or better, put all the CSS in-line on your hand-edited mockup.
>>
>> You can also keep experimenting with the code I have on-line and send
>> me your complaints and suggestions for improvement.
>>
>> Web developers - help me with this:  For item (3) above, how can I
>> make the ellipsis or icon to "show more detail" configurable using
>> CSS?  What's the best way to handle that so that people can customize
>> the look for various skins?
>>
>> --
>> D. Richard Hipp
>> d...@sqlite.org
>> ___
>> fossil-users mailing list
>> fossil-users@lists.fossil-scm.org
>> http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
>>
>
> ___
> fossil-users mailing list
> fossil-users@lists.fossil-scm.org
> http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
>
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] More timeline changes

2017-11-25 Thread sky5walk 
"​(2) Decluttered should be the default."
I agree clutter should not be default?​
I would drop that term altogether.

On Sat, Nov 25, 2017 at 8:47 AM, Richard Hipp  wrote:

> In the latest code on https://www.fossil-scm.org/fossil/timeline and
> at https://sqlite.org/srcx/timeline has a "Declutter" button on the
> sub-menu bar to simplify the screen.  In the simplified timeline,
> there is a "Details" button to get all the details back again.
>
> I'm not done with this interface improvement push.  Here are my
> short-term plans:
>
> (1) Right now, pressing "Declutter" or "Details" is a server
> round-trip.  I think it would better to handle this using javascript.
>
> (2) Decluttered should be the default.  Currently Details is the
> default.  I spent a lot of time experimenting last night, and what I
> found myself doing every time I encountered a timeline was immediately
> pressing the "Declutter" button to get a high-level overview of the
> graph, then clicking on "Details" if I wanted to see more.  From that
> experience, I think coming up in Decluttered mode would be a much
> better approach.
>
> (3) Details/Declutter for the entire graph is good and should be kept.
> But it would be even better to be able to see the details of
> individual timeline entries.  I'm thinking that timelines come up in
> decluttered mode (showing only the check-in comment for each entry)
> but with ellipses or some other small icon at the end of each comment
> that you can click on to expand the details.
>
> You can help!  Send me your ideas of what you think timelines should
> look like.  Even better:  send me mock-ups.  Static HTML pages that
> you have hand-edited will be fine - just be sure to include the CSS,
> or better, put all the CSS in-line on your hand-edited mockup.
>
> You can also keep experimenting with the code I have on-line and send
> me your complaints and suggestions for improvement.
>
> Web developers - help me with this:  For item (3) above, how can I
> make the ellipsis or icon to "show more detail" configurable using
> CSS?  What's the best way to handle that so that people can customize
> the look for various skins?
>
> --
> D. Richard Hipp
> d...@sqlite.org
> ___
> fossil-users mailing list
> fossil-users@lists.fossil-scm.org
> http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
>
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] Interface improvement ideas from GitHub

2017-11-25 Thread David Mason 
To extract the relevant bits:
HTML:
 
JS:
  function toggleExpand(node,shrink,expand) {
if (node.classList.contains(shrink)) {
node.classList.remove(shrink);
expand && node.classList.add(expand);
node.setAttribute('title','Click to '+shrink);
} else {
expand && node.classList.remove(expand);
node.classList.add(shrink);
node.setAttribute('title','Click to '+(expand || 'expand'));
}
}
CSS:
.shrink > :nth-child(n+1) {
display: none;
}
.shrink {
white-space: nowrap;
overflow:hidden;
text-overflow:ellipsis;
}

The optional expand parameter to toggleExpand is if you want to add a
different class when it's expanded. I use it elsewhere, but not here.

../Dave

On 25 November 2017 at 09:38, David Mason  wrote:

> 1) Add/remove a class to an enclosing DIV. You can see a very simple
> version that I wrote in action on https://programmingfortherestofus.com
> click on the bullets under Elevator Pitch.
>
> 2) Include all the content, just don't display it by default...
> dynamically downloading additional content is almost certainly not worth it.
>
> ../Dave
>
> On 25 November 2017 at 08:53, Richard Hipp  wrote:
>
>> I notice on diff pages of GitHub (ex:
>> https://github.com/mackyle/sqlite/commit/028307ebcc953ee944d
>> 389fe359d146ab4893d16)
>> that above and below each diff chunk there is a light-blue block on
>> the left with an icon in the middle.  If you hover over this area, you
>> get a pop-up hint that says "Expand".  If you click, it adds more
>> context to the diff.
>>
>> Questions:
>>
>> (1) What's the best way to add mouse-over pop-up hints, in raw CSS+JS,
>> without using a "framework"?
>>
>> (2) How do they implement this "expand the diff context" feature?
>> Surely this is something that needs to be added to Fossil, don't you
>> think?
>>
>> --
>> D. Richard Hipp
>> d...@sqlite.org
>> ___
>> fossil-users mailing list
>> fossil-users@lists.fossil-scm.org
>> http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
>>
>
>
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] Interface improvement ideas from GitHub

2017-11-25 Thread Olivier R. 

Le 25/11/2017 à 14:53, Richard Hipp a écrit :

I notice on diff pages of GitHub (ex:
https://github.com/mackyle/sqlite/commit/028307ebcc953ee944d389fe359d146ab4893d16)
that above and below each diff chunk there is a light-blue block on
the left with an icon in the middle.  If you hover over this area, you
get a pop-up hint that says "Expand".  If you click, it adds more
context to the diff.

Questions:

(1) What's the best way to add mouse-over pop-up hints, in raw CSS+JS,
without using a "framework"?


This label is not made with CCS+JS. It’s just basic HTML.
There is a property ‘title’ on the node: title="Expand"

If you want to display a more complex tooltip, you can have a look here 
how it is done:





(2) How do they implement this "expand the diff context" feature?
Surely this is something that needs to be added to Fossil, don't you
think?


This is probably an AJAX request made with XMLHttpRequest:


A basic example:


Basically, you sent a request to a server like if it was a normal GET 
request (except that you don’t tell to the browser to go to another 
page). The server send text as an answer (usually HTML, JSON, XML or 
plain text), and when you get the answer, you can process it or just 
display it in a node.


A simple way is to send a GET request, the server send an answer in HTML 
(not a full page, just what you need), then you set the HTML received in 
a empty node with the property innerHTML.


Maybe there is another way to do it. My knowledge in this area is not up 
to date.


But the better way, if the file is not too large, is probably to load 
the entire file and to hide what is not necessary.


Olivier
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] Interface improvement ideas from GitHub

2017-11-25 Thread David Mason 
1) Add/remove a class to an enclosing DIV. You can see a very simple
version that I wrote in action on https://programmingfortherestofus.com
click on the bullets under Elevator Pitch.

2) Include all the content, just don't display it by default... dynamically
downloading additional content is almost certainly not worth it.

../Dave

On 25 November 2017 at 08:53, Richard Hipp  wrote:

> I notice on diff pages of GitHub (ex:
> https://github.com/mackyle/sqlite/commit/028307ebcc953ee944d389fe359d14
> 6ab4893d16)
> that above and below each diff chunk there is a light-blue block on
> the left with an icon in the middle.  If you hover over this area, you
> get a pop-up hint that says "Expand".  If you click, it adds more
> context to the diff.
>
> Questions:
>
> (1) What's the best way to add mouse-over pop-up hints, in raw CSS+JS,
> without using a "framework"?
>
> (2) How do they implement this "expand the diff context" feature?
> Surely this is something that needs to be added to Fossil, don't you
> think?
>
> --
> D. Richard Hipp
> d...@sqlite.org
> ___
> fossil-users mailing list
> fossil-users@lists.fossil-scm.org
> http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
>
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

[fossil-users] Trolling GitHub for ideas

2017-11-25 Thread Richard Hipp 
The SQLite project is mirrored on GitHub (not by me).  This mirror
provides a good opportunity to compare the interfaces of GitHub and
Fossil using the same underlying data.

https://sqlite.org/srcx/timeline?basic
https://github.com/mackyle/sqlite/commits/master

Your suggestions for useful features found in GitHub but missing from
Fossil, or for pages in GitHub that work especially well and that you
would like to see replicated in Fossil, are greatly appreciated.

-- 
D. Richard Hipp
d...@sqlite.org
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

[fossil-users] Interface improvement ideas from GitHub

2017-11-25 Thread Richard Hipp 
I notice on diff pages of GitHub (ex:
https://github.com/mackyle/sqlite/commit/028307ebcc953ee944d389fe359d146ab4893d16)
that above and below each diff chunk there is a light-blue block on
the left with an icon in the middle.  If you hover over this area, you
get a pop-up hint that says "Expand".  If you click, it adds more
context to the diff.

Questions:

(1) What's the best way to add mouse-over pop-up hints, in raw CSS+JS,
without using a "framework"?

(2) How do they implement this "expand the diff context" feature?
Surely this is something that needs to be added to Fossil, don't you
think?

-- 
D. Richard Hipp
d...@sqlite.org
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

[fossil-users] More timeline changes

2017-11-25 Thread Richard Hipp 
In the latest code on https://www.fossil-scm.org/fossil/timeline and
at https://sqlite.org/srcx/timeline has a "Declutter" button on the
sub-menu bar to simplify the screen.  In the simplified timeline,
there is a "Details" button to get all the details back again.

I'm not done with this interface improvement push.  Here are my
short-term plans:

(1) Right now, pressing "Declutter" or "Details" is a server
round-trip.  I think it would better to handle this using javascript.

(2) Decluttered should be the default.  Currently Details is the
default.  I spent a lot of time experimenting last night, and what I
found myself doing every time I encountered a timeline was immediately
pressing the "Declutter" button to get a high-level overview of the
graph, then clicking on "Details" if I wanted to see more.  From that
experience, I think coming up in Decluttered mode would be a much
better approach.

(3) Details/Declutter for the entire graph is good and should be kept.
But it would be even better to be able to see the details of
individual timeline entries.  I'm thinking that timelines come up in
decluttered mode (showing only the check-in comment for each entry)
but with ellipses or some other small icon at the end of each comment
that you can click on to expand the details.

You can help!  Send me your ideas of what you think timelines should
look like.  Even better:  send me mock-ups.  Static HTML pages that
you have hand-edited will be fine - just be sure to include the CSS,
or better, put all the CSS in-line on your hand-edited mockup.

You can also keep experimenting with the code I have on-line and send
me your complaints and suggestions for improvement.

Web developers - help me with this:  For item (3) above, how can I
make the ellipsis or icon to "show more detail" configurable using
CSS?  What's the best way to handle that so that people can customize
the look for various skins?

-- 
D. Richard Hipp
d...@sqlite.org
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] [PATCH] Improve symlink following offile_wd_isdir()

2017-11-25 Thread bytevolcano 
Fixed a typo resulting in absolute cases not being picked up well.

Index: src/file.c
==
--- src/file.c
+++ src/file.c
@@ -327,24 +327,30 @@
 ** zFilename is a directory -OR- a symlink that points to a directory.
 ** Return 0 if zFilename does not exist.  Return 2 if zFilename exists
 ** but is something other than a directory.
 */
 int file_wd_isdir(const char *zFilename){
-  int rc;
+  int rc, nFN;
   char *zFN;


   zFN = mprintf("%s", zFilename);
-  file_simplify_name(zFN, -1, 0);
+  nFN = file_simplify_name(zFN, -1, 0);
   rc = getStat(zFN, 1);
   if( rc ){
 rc = 0; /* It does not exist at all. */
   }else if( S_ISDIR(fileStat.st_mode) ){
 rc = 1; /* It exists and is a real directory. */
   }else if( S_ISLNK(fileStat.st_mode) ){
 Blob content;
+char *zFullName;
 blob_read_link(&content, zFN); /* It exists and is a link. */
-rc = file_wd_isdir(blob_str(&content)); /* Points to directory? */
+if(*blob_str(&content) != '/') {
+  while( nFN>0 && zFN[nFN-1]!='/' ){ nFN--; }
+} else { nFN = 0; }
+zFullName = mprintf("%.*s%s", nFN, zFN, blob_str(&content));
+rc = file_wd_isdir(zFullName); /* Points to directory? */
+free(zFullName);
 blob_reset(&content);
   }else{
 rc = 2; /* It exists and is something else. */
   }
   free(zFN);
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] [PATCH] Improve symlink following of file_wd_isdir()

2017-11-25 Thread bytevolcano 
Fixed patch, an '{' had escaped the other patch somehow.

Index: src/file.c
==
--- src/file.c
+++ src/file.c
@@ -327,24 +327,30 @@
 ** zFilename is a directory -OR- a symlink that points to a directory.
 ** Return 0 if zFilename does not exist.  Return 2 if zFilename exists
 ** but is something other than a directory.
 */
 int file_wd_isdir(const char *zFilename){
-  int rc;
+  int rc, nFN;
   char *zFN;

   zFN = mprintf("%s", zFilename);
-  file_simplify_name(zFN, -1, 0);
+  nFN = file_simplify_name(zFN, -1, 0);
   rc = getStat(zFN, 1);
   if( rc ){
 rc = 0; /* It does not exist at all. */
   }else if( S_ISDIR(fileStat.st_mode) ){
 rc = 1; /* It exists and is a real directory. */
   }else if( S_ISLNK(fileStat.st_mode) ){
 Blob content;
+char *zFullName;
 blob_read_link(&content, zFN); /* It exists and is a link. */
-rc = file_wd_isdir(blob_str(&content)); /* Points to directory? */
+if(*blob_str(&content) != '/') {
+  while( nFN>0 && zFN[nFN-1]!='/' ){ nFN--; }
+} else { nFN == 0; }
+zFullName = mprintf("%.*s%s", nFN, zFN, blob_str(&content));
+rc = file_wd_isdir(zFullName); /* Points to directory? */
+free(zFullName);
 blob_reset(&content);
   }else{
 rc = 2; /* It exists and is something else. */
   }
   free(zFN);
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

[fossil-users] [PATCH] Improve symlink following of file_wd_isdir()

2017-11-25 Thread bytevolcano 
On OpenBSD 6.1, running "fossil uv edit" will result in the
following error:

 unable to create directory /var/tmp

Upon digging through this, I found Fossil was following the "/var/tmp"
symlink that recent OpenBSD versions create:

 lrwxrwx---  1 root  wheel  6 Apr  1  2017 /var/tmp -> ../tmp

Of course, Fossil was trying to find a folder called ../tmp", but
it doesn't exist, and so the code cascades into the above error.

This change allows the symlink to be followed correctly, and Fossil
will attempt to test "/var/../tmp" (ie. /tmp) in the above example.

This succeeds, and also has a check in case the symlink points to
an absolute path (beginning with '/').

Index: src/file.c
==
--- src/file.c
+++ src/file.c
@@ -327,24 +327,30 @@
 ** zFilename is a directory -OR- a symlink that points to a directory.
 ** Return 0 if zFilename does not exist.  Return 2 if zFilename exists
 ** but is something other than a directory.
 */
 int file_wd_isdir(const char *zFilename){
-  int rc;
+  int rc, nFN;
   char *zFN;

   zFN = mprintf("%s", zFilename);
-  file_simplify_name(zFN, -1, 0);
+  nFN = file_simplify_name(zFN, -1, 0);
   rc = getStat(zFN, 1);
   if( rc ){
 rc = 0; /* It does not exist at all. */
   }else if( S_ISDIR(fileStat.st_mode) ){
 rc = 1; /* It exists and is a real directory. */
   }else if( S_ISLNK(fileStat.st_mode) ){
 Blob content;
+char *zFullName;
 blob_read_link(&content, zFN); /* It exists and is a link. */
-rc = file_wd_isdir(blob_str(&content)); /* Points to directory? */
+if(*blob_str(&content) != '/')
+  while( nFN>0 && zFN[nFN-1]!='/' ){ nFN--; }
+} else { nFN == 0; }
+zFullName = mprintf("%.*s%s", nFN, zFN, blob_str(&content));
+rc = file_wd_isdir(zFullName); /* Points to directory? */
+free(zFullName);
 blob_reset(&content);
   }else{
 rc = 2; /* It exists and is something else. */
   }
   free(zFN);
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users