Re: [Freeciv-Dev] trunk lua mess
On Mon, 18 Jun 2007, William Allen Simpson wrote: Unfortunately, tolua++ doesn't seem to be widely available as an external package. It is in the Fedora 7 repository, at least. However, I checked my current favorite platforms (MacPorts, NetBSD pkgsrc, debian, Ubuntu), and all of them have lua 5.1.2 as packages. I'm thinking that maybe the way to go with lua is the same as gettext -- change to a build option, but allow an up-to-date external library for most folks. Isn't that the worst of both worlds? You get the hassle of updating your internal lua, *and* the problems reported of getting (the right version of) external lua to play ball on all kinds of distributions and setups? BTW, the sources need some changes to work with new lua and tolua versions, as you can see in r12995-9, and I am not sure if those changes are compatible with older lua versions. - Per ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] trunk lua mess
Per I. Mathisen wrote: BTW, the sources need some changes to work with new lua and tolua versions, as you can see in r12995-9, and I am not sure if those changes are compatible with older lua versions. Well, I expect to find out over the next couple of days :-) I'm putting the tolua++ in its own subdirectory, so it will compile and not interfere with the older tolua in my build tree. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39406) Is S2_1 clients compilation broken?
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39406 Egor Vyscrebentsov wrote: svn branches/S2_1 rev 13004. gui-xaw and gui-gtk-2.0 do not compiled on my machine with following error: freeciv-s2_1/client/packhand.c: In function ‘handle_ruleset_building’ freeciv-s2_1/client/packhand.c:2249: error: ‘advance’ undeclared (first use in this function) freeciv-s2_1/client/packhand.c:2249: error: (Each undeclared identifier is reported only once freeciv-s2_1/client/packhand.c:2249: error: for each function it appears in.) make[3]: *** [packhand.o] Error 1 What to do? (c) Line 2249 is in the middle of an #ifdef DEBUG section, so it never was compiled here. Looks like an 's' is missing on advances. svn ci -m (PR#39406) correct misspelling in DEBUG section Sendingclient/packhand.c Transmitting file data . Committed revision 13005. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39388) S2_1 trident missing t.ocean1
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39388 Daniel Markstedt wrote: On 6/10/07, William Allen Simpson [EMAIL PROTECTED] wrote: What tileset? Any. Using my improved error logging (most recently r13003 for S2_1), we discovered that this was not accurate. As I mentioned in the previous message, all the S2_1 tilesets have t.ocean1, except for trident. I've wasted far too many cycles trying to figure out what's wrong with amplio (the default). Sure enough, the new verbose output is: 3: Reading registry from /Users/daniel/freeciv-beta-gtk/share/freeciv/trident/units.spec 3: Reading registry from /Users/daniel/freeciv-beta-gtk/share/freeciv/trident/tiles.spec 0: Don't have graphics tags t.ocean1 or for base (blend) terrain Ocean. This is not a problem with any tileset, it's a problem with trident! That's no surprise, as trident doesn't have blending I've checked trident/tiles.spec back to 1.14, and there's never been any t.ocean1, so it appears an old logic error in the code. Looks like improved error logging actually found it! Unfortunately, it's rather obscure code. :-( It's been completely re-written in trunk. :-) If possible, I'll make it more like trunk. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39397) 2.1.0 Beta missing graphics for trident Ocean and tech Nichts
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39397 As I was looking for similar reports, I discovered that you've been reporting the same Ocean problem since beta 1 #16078: Beta1: civclient crash on game load http://bugs.freeciv.org/Ticket/Display.html?id=16078 SVN 2.1 22 MAR 2006 GTK2 Linux civclient crashes with a segmaentation fault on loading the attached save game (and HEAD does as well). civlient -d 3 says: [...] 3: Don't have graphics tags a.writing or - for tech_type Schrift 3: Don't have graphics tags t.ocean1 or for tile_type Ozean Speicherzugriffsfehler (core dumped) ... Starting civserver seperately avoids the crash. That's classic sign of an uninitialized pointer! (The location moves depending on the other applications loaded.) Also: (PR#16007) Beta1: civclient crash on game load http://bugs.freeciv.org/Ticket/Display.html?id=16007 (PR#16101) Beta1: civclient crash on game load http://bugs.freeciv.org/Ticket/Display.html?id=16101 (PR#16103) Beta1: civclient crash on game load http://bugs.freeciv.org/Ticket/Display.html?id=16103 Meanwhile, it was also diagnosed with another problem (nationgroups) that was fixed. Sometimes multiple problems mask each other. Now, my improved error logging catches the missing ocean graphic. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#39407) Bug in autogen.sh
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39407 I think I have found a bug in the autogen.sh shell script. I am working on a translation, and I downloaded the 2.0.9 branch and tried to run autogen.sh, but it failed. It complained that ALL_LINGUAS contained nb, but it couldn't find nb.po in the po directory. I edited configure.ac, and removed nb from the variable ALL_LINGUAS, and then autogen.sh ran smoothly. Later, I have found out that you can do make nb.po in the po directory and nb.po gets created (as a copy of no.po). But it's kind of a chicken and egg problem. You can't make nb.po because the Makefile hasn't been generated, and you can't generate the Makefile because autogen checks for nb.po. Cheers, Joan I think I have found a bug in the autogen.sh shell script. I am working on a translation, and I downloaded the 2.0.9 branch and tried to run autogen.sh, but it failed. It complained that ALL_LINGUAS contained nb, but it couldnt find nb.po in the po directory.I edited configure.ac, and removed nb from the variable ALL_LINGUAS, and then autogen.sh ran smoothly.Later, I have found out that you can do make nb.po in the po directory and nb.po gets created (as a copy of no.po). But its kind of a chicken and egg problem. You cant make nb.po because the Makefile hasnt been generated, and you cant generate the Makefile because autogen checks for nb.po.Cheers, Joan ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39388) S2_1 trident missing t.ocean1
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39388
The ancient bug had been fixed in trunk months ago.
Tested against all 5 tilesets.
Committed S2_1 revision 13006.
Index: client/tilespec.c
===
--- client/tilespec.c (revision 13005)
+++ client/tilespec.c (working copy)
@@ -2638,7 +2638,6 @@
/* Set up each layer of the drawing. */
for (l = 0; l draw-num_layers; l++) {
sprite_vector_init(draw-layer[l].base);
-sprite_vector_reserve(draw-layer[l].base, 1);
switch (draw-layer[l].cell_type) {
case CELL_SINGLE:
@@ -2673,7 +2672,6 @@
lookup_sprite_tag_alt(t, buffer, , TRUE, matched terrain,
pterrain-name_rule);
}
- draw-layer[l].base.p[0] = draw-layer[l].match[0];
break;
};
break;
@@ -2779,10 +2777,6 @@
};
}
}
- my_snprintf(buffer, sizeof(buffer), t.%s1, draw-name);
- draw-layer[l].base.p[0]
-= lookup_sprite_tag_alt(t, buffer, , TRUE, base (blend) terrain,
-pterrain-name_rule);
break;
};
}
@@ -2795,6 +2789,14 @@
};
enum direction4 dir;
+if (draw-layer[0].base.size 1) {
+ my_snprintf(buffer, sizeof(buffer), t.%s1, draw-name);
+ sprite_vector_reserve(draw-layer[0].base, 1);
+ draw-layer[0].base.p[0]
+ = lookup_sprite_tag_alt(t, buffer, , TRUE, base (blend) terrain,
+ pterrain-name_rule);
+}
+
for (dir = 0; dir 4; dir++) {
assert(sprite_vector_size(draw-layer[0].base) 0);
draw-blend[dir] = crop_sprite(draw-layer[0].base.p[0],
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#39408) Main gtk_notebook still allows page switching with pageup/down
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39408 Using ctrl+pgup or ctrl+pgdn you can switch pages in the main gtk_notebook (main menu, start game, scenario, load and map view pages) mouse scrolling is disabled in the code but these keybindings are not. This bug leads to access to the map view page when a game is not running which can have different consequences. (crash right now, different bug) Tested only on S2_1 so far. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39388) S2_1 trident missing t.ocean1
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39388 It's working now. Thanks for the effort! ~Daniel ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
