Re: [Freeciv-Dev] (PR#40314) lua error in error handling
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40314 2008/6/24 Jason Dorje Short: lua error: error in error handling This appears on my client console when playing a game (through ggz). There's patch in #40289. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#40313) Support for 7z savegames
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40313 2008/6/24 Daniel Markstedt: Idea: How about adding support for the 7z format[1] for archiving saved games? 7z is very effective (in my experience) when archiving similar files together, so it would be a great fit with Freeciv saves. The idea of course is to continuously append the last save to a single .7z for one full game. Slightly off-topic: My long TODO already has support for lzma compression for single files in it. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#40315) gtk client: unplayabe resizing of panel
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40315
Jason Dorje Short wrote:
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40315
Every time the text on the left panel (generally the terrain text)
changes the panel resizes itself. This leads to a redraw of the main
screen. The end effect is to basically make the game unplayable.
The left panel should never automatically shrink itself. It can
automatically enlarge itself if necessary. There should be a GTK option
for this.
This obnoxious hack fixes the problem. I have the very strong feeling
there is some simple gtk setting to control this but i have no idea what
it is. Regardless, with this patch the game is far far more playable.
-jason
Index: client/gui-gtk-2.0/gui_main.c
===
--- client/gui-gtk-2.0/gui_main.c (revision 14862)
+++ client/gui-gtk-2.0/gui_main.c (working copy)
@@ -1206,6 +1206,7 @@
unit_info_frame = gtk_frame_new();
gtk_box_pack_start(GTK_BOX(unit_info_box), unit_info_frame, FALSE, FALSE, 0);
+ gtk_widget_set_no_shrink(unit_info_frame);
unit_info_label = gtk_label_new(\n\n\n);
gtk_container_add(GTK_CONTAINER(unit_info_frame), unit_info_label);
Index: client/gui-gtk-2.0/gui_stuff.c
===
--- client/gui-gtk-2.0/gui_stuff.c (revision 14862)
+++ client/gui-gtk-2.0/gui_stuff.c (working copy)
@@ -996,3 +996,31 @@
}
}
+/**
+ Handle a size request and make sure the widget GROWS only, no shrinking.
+**/
+static void size_request_no_shrink(GtkWidget *widget,
+ GtkRequisition *req,
+ gpointer user_data)
+{
+ int width, height;
+
+ gtk_widget_get_size_request(widget, width, height);
+ gtk_widget_set_size_request(widget,
+ MAX(width, req-width), MAX(height, req-height));
+}
+
+/**
+ This function is a major hack and probably easily accomplished via some
+ simple GTK setting. The goal is to make sure a particular widget will
+ only grow; never shrink. For instance the unit info panel sometimes gets
+ test too big for it. This text makes the panel grow. When moving to the
+ next unit, the panel would typlically then shrink again causing the entire
+ mapview to resize itself obnoxiously. With this setting the unit info
+ panel will never shrink.
+**/
+void gtk_widget_set_no_shrink(GtkWidget *widget)
+{
+ g_signal_connect(widget, size-request,
+ G_CALLBACK(size_request_no_shrink), NULL);
+}
Index: client/gui-gtk-2.0/gui_stuff.h
===
--- client/gui-gtk-2.0/gui_stuff.h (revision 14862)
+++ client/gui-gtk-2.0/gui_stuff.h (working copy)
@@ -123,4 +123,6 @@
struct client_option;
void gui_update_font_from_option(struct client_option *o);
+void gtk_widget_set_no_shrink(GtkWidget *widget);
+
#endif /* FC__GUI_STUFF_H */
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#38354) Autoconnect can't handle password
URL: http://bugs.freeciv.org/Ticket/Display.html?id=38354 2008/6/24 Jason Short: Any idea if this is present on 2.1/2.2/trunk? How do I set up a server with authentication anyway? Install mysql, run scripts/setup_auth_server.sh, compile Freeciv with --enable-auth. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40318) [gui-sdl] crash when editing global worklists while observing
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40318 Steps to reproduce: 1)Observe an ongoing game 2)Bring up the Options panel 3)Click on 'Worklists' =civclient dies Tested on 2.1.5 Windows build. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#39358) vote in pregame
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39358 [jdorje - Tue Jun 24 03:30:07 2008]: This is actually a rather serious bug. The only solutions are to disable the vote code or to reset all votes when a player leaves. -jason We have fixed it differently in warserver. The votes are based on connection ids, and all their vote are canceled when the connection detach or leave. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40319) Removing a player causes client disonnection
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40319 When a player is removed, the client is disconnected the next time it tried to send a packet to the server (e.g. chat or pong). The error message prints: 1: cut connection server (connexion incomplète) due to huge send buffer (2) It's related to the recent team fix of PR#39745. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40320) 'make dist' on S2_2
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40320 Good daytime! With recent changes we have an error while 'make dist' on S2_2: make[4]: Entering directory `/home/evyscr/freeciv-svn/S2_2/dependencies/toluaxx/src/lib' make[4]: *** No rule to make target `../../../../dependencies/tolua/include/toluaxx.h', needed by `distdir'. Stop. make[4]: Leaving directory `/home/evyscr/freeciv-svn/S2_2/dependencies/toluaxx/src/lib' make[3]: *** [distdir] Error 1 -- Thanks, evyscr ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#40320) 'make dist' on S2_2
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40320 2008/6/24 Egor Vyscrebentsov: With recent changes we have an error while 'make dist' on S2_2: make[4]: Entering directory `/home/evyscr/freeciv-svn/S2_2/dependencies/toluaxx/src/lib' make[4]: *** No rule to make target `../../../../dependencies/tolua/include/toluaxx.h', needed by `distdir'. Stop. make[4]: Leaving directory `/home/evyscr/freeciv-svn/S2_2/dependencies/toluaxx/src/lib' make[3]: *** [distdir] Error 1 Fix for this particular problem. You also have to build toluaxx and generate api_gen.[ch] before you can 'make dist'. - ML diff -Nurd -X.diff_ignore freeciv/dependencies/toluaxx/src/lib/Makefile.am freeciv/dependencies/toluaxx/src/lib/Makefile.am --- freeciv/dependencies/toluaxx/src/lib/Makefile.am 2008-01-15 04:53:29.0 +0200 +++ freeciv/dependencies/toluaxx/src/lib/Makefile.am 2008-06-24 18:26:19.0 +0300 @@ -5,7 +5,6 @@ -I$(top_srcdir)/dependencies/lua-5.1/src libtolua_a_SOURCES = \ - $(top_srcdir)/dependencies/tolua/include/toluaxx.h \ tolua_event.c \ tolua_event.h \ tolua_is.c \ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#40319) Removing a player causes client disonnection
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40319 Pepeto _ wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=40319 When a player is removed, the client is disconnected the next time it tried to send a packet to the server (e.g. chat or pong). The error message prints: 1: cut connection server (connexion incomplète) due to huge send buffer (2) It's related to the recent team fix of PR#39745. I can't reproduce this and it makes no sense that it would be caused by PR#39745. Are you sure this is vanilla S2_0? How do I reproduce it? -jason ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40319) Removing a player causes client disonnection
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40319 [EMAIL PROTECTED] - Tue Jun 24 15:42:57 2008]: I can't reproduce this and it makes no sense that it would be caused by PR#39745. It didn't occur before, and it does now. I don't know why. I think there is a more serious hidden problem. Are you sure this is vanilla S2_0? Standard server and client from the S2_0 svn branch. How do I reproduce it? 1) Connect to a server. 2) Remove yourself via /remove. 3) send a chat line. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#40319) Removing a player causes client disonnection
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40319 Pepeto _ wrote: How do I reproduce it? 1) Connect to a server. 2) Remove yourself via /remove. 3) send a chat line. Nothing. And no errors reported by valgrind. Can anyone else reproduce any errors here? -jason ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#40319) Removing a player causes client disonnection
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40319 2008/6/24 Jason Dorje Short [EMAIL PROTECTED]: URL: http://bugs.freeciv.org/Ticket/Display.html?id=40319 Pepeto _ wrote: How do I reproduce it? 1) Connect to a server. 2) Remove yourself via /remove. 3) send a chat line. Nothing. And no errors reported by valgrind. Can anyone else reproduce any errors here? Yes. Valgrind shows no errors related to this. I also tested running server separately: 1) Start server 2) Start client and connect to server (as the only user) 3) /remove yourself - couple of seconds later connection is cut and client returns to main screen 5) Try to reconnect - client returns to main screen immediately 6) Restart client and reconnect to server - success So it looks like client side problem. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#40319) Removing a player causes client disonnection
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40319 Marko Lindqvist wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=40319 2008/6/24 Jason Dorje Short [EMAIL PROTECTED]: URL: http://bugs.freeciv.org/Ticket/Display.html?id=40319 Pepeto _ wrote: How do I reproduce it? 1) Connect to a server. 2) Remove yourself via /remove. 3) send a chat line. Nothing. And no errors reported by valgrind. Can anyone else reproduce any errors here? Yes. Valgrind shows no errors related to this. I also tested running server separately: 1) Start server 2) Start client and connect to server (as the only user) 3) /remove yourself - couple of seconds later connection is cut and client returns to main screen 5) Try to reconnect - client returns to main screen immediately 6) Restart client and reconnect to server - success So it looks like client side problem. 1. Start server. 2. Start client and connect (only user, jdorje). 3. /remove jdorje in the client. 4. /list : /list: List of players: /list: -- /list: no players /list: -- And waiting around I get no errors in the ping as pepeto is seeing. I'm using the GTK-2.0 client; perhaps the GUI is the issue? Marko - do you see this same error with an older S2_0 version, say, 14855? -jason ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40321) 2.1.5 crash report forwarded : client cursor moving units
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40321 -- Forwarded message -- From: Alex [EMAIL PROTECTED] Date: Tue, Jun 24, 2008 at 1:20 PM Subject: crash report To: [EMAIL PROTECTED] Playing 2.1.5 GTK on WinXP SP3, I was moving a catapult along a road when the client disappeared without even popping up an error. A civclient.rpt was generated. I've included it as an attachment as well as inline, because I am not wholly confident in yahoo getting the data there unmangled. C:\games\Freeciv-2.1.5-gtk2\civclient.exe caused an Unknown [0xC01E] Exception at location 014c66c4. Registers: eax=0022e626 ebx=0001 ecx=0a7164c0 edx=014c6730 esi=0a6c31b8 edi= eip=014c66c4 esp=0022e14c ebp=0022e178 iopl=0 nv up ei pl nz na pe nc cs=001b ss=0023 ds=0023 es=0023 fs=003b gs= efl=00010202 Call stack: 014C66C4 6B06D77E C:\games\Freeciv-2.1.5-gtk2\libgdk-win32-2.0-0.dll:6B06D77E gdk_event_get_graphics_expose 6B070984 C:\games\Freeciv-2.1.5-gtk2\libgdk-win32-2.0-0.dll:6B070984 gdk_event_get_graphics_expose 7E418734 C:\WINDOWS\system32\USER32.dll:7E418734 GetDC 7E418816 C:\WINDOWS\system32\USER32.dll:7E418816 GetDC 7E428EA0 C:\WINDOWS\system32\USER32.dll:7E428EA0 DefWindowProcW 7E42CE7C C:\WINDOWS\system32\USER32.dll:7E42CE7C SetLayeredWindowAttributes 7C90E453 C:\WINDOWS\system32\ntdll.dll:7C90E453 KiUserCallbackDispatcher 7E42E442 C:\WINDOWS\system32\USER32.dll:7E42E442 GetScrollInfo 7E42E4DC C:\WINDOWS\system32\USER32.dll:7E42E4DC CreateWindowExA 6B0894C9 C:\games\Freeciv-2.1.5-gtk2\libgdk-win32-2.0-0.dll:6B0894C9 gdk_window_set_cursor 60588E6C C:\games\Freeciv-2.1.5-gtk2\libgtk-win32-2.0-0.dll:60588E6C gtk_menu_item_toggle_size_allocate 62743995 C:\games\Freeciv-2.1.5-gtk2\libgobject-2.0-0.dll:62743995 g_closure_invoke 62756B92 C:\games\Freeciv-2.1.5-gtk2\libgobject-2.0-0.dll:62756B92 g_signal_has_handler_pending 62757F3E C:\games\Freeciv-2.1.5-gtk2\libgobject-2.0-0.dll:62757F3E g_signal_emit_valist 627581B6 C:\games\Freeciv-2.1.5-gtk2\libgobject-2.0-0.dll:627581B6 g_signal_emit 606A3290 C:\games\Freeciv-2.1.5-gtk2\libgtk-win32-2.0-0.dll:606A3290 gtk_widget_realize 606A3CE0 C:\games\Freeciv-2.1.5-gtk2\libgtk-win32-2.0-0.dll:606A3CE0 gtk_widget_set_parent 6057E391 C:\games\Freeciv-2.1.5-gtk2\libgtk-win32-2.0-0.dll:6057E391 gtk_menu_new 6058B741 C:\games\Freeciv-2.1.5-gtk2\libgtk-win32-2.0-0.dll:6058B741 gtk_menu_shell_append 004B1B83 C:\games\Freeciv-2.1.5-gtk2\civclient.exe:004B1B83 update_menus x:/Projekte/freeciv/src/build/freeciv-2.1.5-gtk2/client/gui-gtk-2.0/menu.c:1282 0041F9E1 C:\games\Freeciv-2.1.5-gtk2\civclient.exe:0041F9E1 handle_unit_packet_common x:/Projekte/freeciv/src/build/freeciv-2.1.5-gtk2/client/packhand.c:1332 0041FF40 C:\games\Freeciv-2.1.5-gtk2\civclient.exe:0041FF40 handle_unit_info x:/Projekte/freeciv/src/build/freeciv-2.1.5-gtk2/client/packhand.c:1012 0042386C C:\games\Freeciv-2.1.5-gtk2\civclient.exe:0042386C client_handle_packet x:/Projekte/freeciv/src/build/freeciv-2.1.5-gtk2/client/packhand_gen.c:141 00405B69 C:\games\Freeciv-2.1.5-gtk2\civclient.exe:00405B69 client_packet_input x:/Projekte/freeciv/src/build/freeciv-2.1.5-gtk2/client/civclient.c:445 00409F53 C:\games\Freeciv-2.1.5-gtk2\civclient.exe:00409F53 input_from_server x:/Projekte/freeciv/src/build/freeciv-2.1.5-gtk2/client/clinet.c:386 6B0464DB C:\games\Freeciv-2.1.5-gtk2\libgdk-win32-2.0-0.dll:6B0464DB gdk_get_show_events 672DE7E7 C:\games\Freeciv-2.1.5-gtk2\libglib-2.0-0.dll:672DE7E7 g_main_context_dispatch 672DFCCB C:\games\Freeciv-2.1.5-gtk2\libglib-2.0-0.dll:672DFCCB g_main_context_acquire 672DFEAA C:\games\Freeciv-2.1.5-gtk2\libglib-2.0-0.dll:672DFEAA g_main_loop_run 6057686E C:\games\Freeciv-2.1.5-gtk2\libgtk-win32-2.0-0.dll:6057686E gtk_main 004ADE3A C:\games\Freeciv-2.1.5-gtk2\civclient.exe:004ADE3A ui_main x:/Projekte/freeciv/src/build/freeciv-2.1.5-gtk2/client/gui-gtk-2.0/gui_main.c:1478 00406328 C:\games\Freeciv-2.1.5-gtk2\civclient.exe:00406328 SDL_main x:/Projekte/freeciv/src/build/freeciv-2.1.5-gtk2/client/civclient.c:407 004E1BDB C:\games\Freeciv-2.1.5-gtk2\civclient.exe:004E1BDB console_main /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:220 004E1DB9 C:\games\Freeciv-2.1.5-gtk2\civclient.exe:004E1DB9 WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:357 004E1638 C:\games\Freeciv-2.1.5-gtk2\civclient.exe:004E1638 units_have_activity_on_tile x:/Projekte/freeciv/src/build/freeciv-2.1.5-gtk2/common/unitlist.c:194 0040124B C:\games\Freeciv-2.1.5-gtk2\civclient.exe:0040124B 004012B8 C:\games\Freeciv-2.1.5-gtk2\civclient.exe:004012B8 7C817067 C:\WINDOWS\system32\kernel32.dll:7C817067 RegisterWaitForInputIdle civclient.RPT Description: Binary data ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#40319) Removing a player causes client disonnection
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40319 2008/6/24 Jason Dorje Short: Marko - do you see this same error with an older S2_0 version, say, 14855? Yes - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#40319) Removing a player causes client disonnection
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40319 Seems this IS bringing to light a major bug: game_renumber_players is being called and dropping the number of players below 0 in the client. This patch adds a very valid assert. It triggers when following the previous instructions. This means random pieces of memory are being overwritten (and were before the recent patch, though now it's more being overwritten) which will cause random bugs. It won't trigger a valgrind error as long as the memory is valid though (likely it's somewhere in the game structure up above game.players). -jason Index: common/game.c === --- common/game.c (revision 14869) +++ common/game.c (working copy) @@ -495,6 +495,7 @@ } game.nplayers--; + assert(game.nplayers = 0); /* Reset player structure. */ player_init(game.players[game.nplayers]); ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40319) Removing a player causes client disonnection
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40319
Indeed, the same bug was present before but the symptoms were not as
harsh. After the fix game.players[-1] gets entirely overwritten;
before only some of it did, when game.nplayers dropped to negative in
the client.
The error seems to be that game.nplayers was never being sent to the
client in the first place. No matter how many players connect in
pregame the number of players in the client always remains 0. This does
not appear to be an issue in 2.1 or later.
This quick fix should avoid the error. It might be desirable to track
down the root problem and have the nplayers be sent but I'm not going to
spend the time on it.
-jason
Index: common/game.c
===
--- common/game.c (revision 14869)
+++ common/game.c (working copy)
@@ -481,6 +481,12 @@
{
int i;
+ if (game.nplayers == 0) {
+/* This happens in pregame, it's a bug that the nplayers is not being
+ * sent to the client and so is always zero. */
+return;
+ }
+
for (i = plrno; i game.nplayers - 1; i++) {
game.players[i]=game.players[i+1];
game.players[i].player_no=i;
@@ -495,6 +501,7 @@
}
game.nplayers--;
+ assert(game.nplayers = 0);
/* Reset player structure. */
player_init(game.players[game.nplayers]);
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40139) Global observer does not work
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40139 [book - Mon Jun 23 21:37:36 2008]: Updated my patch that fixes the currently broken global observer in S2_2 and trunk. Committed to S2_2 (r14879) and trunk (r14880). -- 旨く出来ました！ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
