[Freeciv-Dev] (PR#12825) freeciv doesn't work on small-resolution displays

2008-12-15 Thread

URL: http://bugs.freeciv.org/Ticket/Display.html?id=12825 

 [book - Mo 10. Nov 2008, 01:16:10]:
 
  [guest - Sun Nov 09 12:02:10 2008]:
  
  This is still an issue. A lot of netbooks have a 1024x600
  resolution on which freeciv is unplayable. Please consider
  making the interface work on those screens.
 
 Could you be more specific about what makes it unplayable,
 for example what client you are using and what parts of the
 interface do not fit correctly.

I'm not the guest above, but i have the same problem:

If I want to start a new game there is a dialog where i can configure my
opponents and set game parameters. The dialog buttons are not reachable
with 600 pixels height.

On the other hand on my Nokia N800 with 800x480 px resolution there is a
good freeciv port...

Are there special configuration files or parameter i can use to solfe
this issue?

 Or is it just that the map view in the gtk client cannot be
 resized less than a certain height and width?

This I only would know if i start the game :)

Btw. how i can create an account for this bug tracker?

Ciao jukey (jukey -at- ju-key.de)

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] (PR#12825) freeciv doesn't work on small-resolution displays

2008-12-15 Thread Madeline Book

URL: http://bugs.freeciv.org/Ticket/Display.html?id=12825 

 [guest - Mon Dec 15 08:24:56 2008]:
 
  [book - Mo 10. Nov 2008, 01:16:10]:
  
   [guest - Sun Nov 09 12:02:10 2008]:
   
   This is still an issue. A lot of netbooks have a 1024x600
   resolution on which freeciv is unplayable. Please consider
   making the interface work on those screens.
  
  Could you be more specific about what makes it unplayable,
  for example what client you are using and what parts of the
  interface do not fit correctly.

 I'm not the guest above, but i have the same problem:

 If I want to start a new game there is a dialog where i
 can configure my opponents and set game parameters. The
 dialog buttons are not reachable with 600 pixels height.

 On the other hand on my Nokia N800 with 800x480 px
 resolution there is a good freeciv port...

 Are there special configuration files or parameter i can
 use to solfe this issue?

No, the basic widget layout is hard-coded in the program.

Alright, I will assume that this is a problem with the gtk
version, specifically that the way the widgets are packed
and/or set to minimum sizes prevents the entire window from
being resized down to fit on your display. I'll see about
reworking the gui layout code so that resizing is at least
possible.

In the meantime you could try the sdl gui and play with its
video options to see if you can make the game playable on
your display.


 Btw. how i can create an account for this bug tracker?

That's only really useful if you plan on handling bug reports
or submitting sizable contributions (and I do not have access
to grant you the priveleges anyway). Just use the bug report
email address or the guest account listed on bugs.freeciv.org.


---
ちょっと。大ハンマーを持ってくる。

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#12825) freeciv doesn't work on small-resolution displays

2008-12-15 Thread Daniel Markstedt

URL: http://bugs.freeciv.org/Ticket/Display.html?id=12825 

On Tue, 16 Dec 2008 06:27:48 +0900, Madeline Book  
madeline.b...@gmail.com wrote:


 URL: http://bugs.freeciv.org/Ticket/Display.html?id=12825 

 [guest - Mon Dec 15 08:24:56 2008]:

  [book - Mo 10. Nov 2008, 01:16:10]:
 
   [guest - Sun Nov 09 12:02:10 2008]:
  
   This is still an issue. A lot of netbooks have a 1024x600
   resolution on which freeciv is unplayable. Please consider
   making the interface work on those screens.
 
  Could you be more specific about what makes it unplayable,
  for example what client you are using and what parts of the
  interface do not fit correctly.

 I'm not the guest above, but i have the same problem:

 If I want to start a new game there is a dialog where i
 can configure my opponents and set game parameters. The
 dialog buttons are not reachable with 600 pixels height.

 On the other hand on my Nokia N800 with 800x480 px
 resolution there is a good freeciv port...

 Are there special configuration files or parameter i can
 use to solfe this issue?

 No, the basic widget layout is hard-coded in the program.

 Alright, I will assume that this is a problem with the gtk
 version, specifically that the way the widgets are packed
 and/or set to minimum sizes prevents the entire window from
 being resized down to fit on your display. I'll see about
 reworking the gui layout code so that resizing is at least
 possible.

 In the meantime you could try the sdl gui and play with its
 video options to see if you can make the game playable on
 your display.



The Nokia Maemo port is indeed a modified version of the GTK2 client.

Package and source available here if helpful:

http://syslog.movial.fi/archives/30-FreeCiv-port-for-Maemo-2.0-platform.html

Daniel

-- 
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] (PR#40603) Suggestions

2008-12-15 Thread David Nuttall

URL: http://bugs.freeciv.org/Ticket/Display.html?id=40603 

I would like to suggest to add to Freeciv (SDL version) that when loading an 
existing game, sort the list of saved games by the date they were written.  
This way you can determine which was the most recently saved game to continue 
your last game.  After playing a few games, it is difficult to see which is the 
game you want to continue.

 David Nuttall, Computer Specialist
Nuttall Computer Consulting
danutt...@rocketmail.com



  __
Instant Messaging, free SMS, sharing photos and more... Try the new Yahoo! 
Canada Messenger at http://ca.beta.messenger.yahoo.com/



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] (PR#40602) Bug Report for Freeciv 2.1.8 SDL

2008-12-15 Thread David Nuttall

URL: http://bugs.freeciv.org/Ticket/Display.html?id=40602 

Occasionally, when clicking on the Nations button, the Freeciv bombs out.

Attached please find the error report generated from the last two times it died 
while playing.  In both cases, I had used the Nations dialog several times 
before it crapped out.

 David Nuttall, Computer Specialist
Nuttall Computer Consulting
danutt...@rocketmail.com



  __
Yahoo! Canada Toolbar: Search from anywhere on the web, and bookmark your 
favourite sites. Download it now at
http://ca.toolbar.yahoo.com.


CIVCLIENT.RPT
Description: Binary data
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] (PR#40599) Total buy cost display update bug

2008-12-15 Thread Madeline Book

URL: http://bugs.freeciv.org/Ticket/Display.html?id=40599 

 [chrisk - Sun Dec 14 06:54:21 2008]:
 
 
 Trunk Revision: 15365 GTK
 
 When selecting a set of cities with items to buy in the
 city report, the total buy costs are shown in the bottom
 of the report window.

 Now, when I change the production for these cities, the
 amount is not updated.

Attached patch separates out the label update code and adds
a call to it in the required place.


---
ブロロロッーブロロ!
diff --git a/client/gui-gtk-2.0/cityrep.c b/client/gui-gtk-2.0/cityrep.c
index 0970394..f16e0a4 100644
--- a/client/gui-gtk-2.0/cityrep.c
+++ b/client/gui-gtk-2.0/cityrep.c
@@ -71,6 +71,7 @@ static void city_command_callback(struct gui_dialog *dlg, int response,
   gpointer data);
 
 static void city_selection_changed_callback(GtkTreeSelection *selection);
+static void update_total_buy_cost(void);
 
 static void create_select_menu(GtkWidget *item);
 static void create_change_menu(GtkWidget *item);
@@ -1207,8 +1208,8 @@ void city_report_dialog_update_city(struct city *pcity)
 /* update. */
 if (found) {
   update_row(TREE_ITER_PTR(it), pcity);
-
   select_menu_cached = FALSE;
+  update_total_buy_cost();
 } else {
   city_report_dialog_update();
 }
@@ -1578,59 +1579,74 @@ static void popup_select_menu(GtkMenuShell *menu, gpointer data)
   select_menu_cached = TRUE;
 }
 
-/
-...
-*/
-static void city_selection_changed_callback(GtkTreeSelection *selection)
+/***
+  Update the value displayed by the total buy cost label in the city
+  report, or make it blank if nothing can be bought.
+***/
+static void update_total_buy_cost(void)
 {
-  int n;
+  GtkWidget *label, *view;
+  GList *rows, *p;
+  GtkTreeModel *model;
+  GtkTreeSelection *sel;
+  GtkTreePath *path;
+  GtkTreeIter iter;
+  gpointer res;
+  struct city *pcity;
   int total = 0;
 
-  n = gtk_tree_selection_count_selected_rows(selection);
+  view = city_view;
+  label = city_total_buy_cost_label;
 
-  if (n == 0) {
-gtk_widget_set_sensitive(city_production_command, FALSE);
-gtk_widget_set_sensitive(city_center_command, FALSE);
-gtk_widget_set_sensitive(city_popup_command, FALSE);
-gtk_widget_set_sensitive(city_buy_command, FALSE);
-  } else {
-GList *rows, *p;
-GtkTreeModel *model;
-GtkTreePath *path;
-GtkTreeIter iter;
-gpointer res;
-struct city *pcity;
+  if (!view || !label) {
+return;
+  }
 
-gtk_widget_set_sensitive(city_production_command,
-			 can_client_issue_orders());
-gtk_widget_set_sensitive(city_center_command, TRUE);
-gtk_widget_set_sensitive(city_popup_command, TRUE);
-gtk_widget_set_sensitive(city_buy_command, can_client_issue_orders());
-
-rows = gtk_tree_selection_get_selected_rows(selection, model);
-for (p = rows; p != NULL; p = p-next) {
-  path = p-data;
-  if (gtk_tree_model_get_iter(model, iter, path)) {
-gtk_tree_model_get(model, iter, 0, res, -1);
-pcity = res;
-if (pcity != NULL) {
-  total += city_production_buy_gold_cost(pcity);
-}
+  sel = gtk_tree_view_get_selection(GTK_TREE_VIEW(view));
+  rows = gtk_tree_selection_get_selected_rows(sel, model);
+
+  for (p = rows; p != NULL; p = p-next) {
+path = p-data;
+if (gtk_tree_model_get_iter(model, iter, path)) {
+  gtk_tree_model_get(model, iter, 0, res, -1);
+  pcity = res;
+  if (pcity != NULL) {
+total += city_production_buy_gold_cost(pcity);
   }
-  gtk_tree_path_free(path);
 }
-g_list_free(rows);
+gtk_tree_path_free(path);
   }
+  g_list_free(rows);
 
   if (total  0) {
-char buf[64];
+char buf[128];
 my_snprintf(buf, sizeof(buf), _(Total Buy Cost: %d), total);
-gtk_label_set_text(GTK_LABEL(city_total_buy_cost_label), buf);
+gtk_label_set_text(GTK_LABEL(label), buf);
   } else {
-gtk_label_set_text(GTK_LABEL(city_total_buy_cost_label), NULL);
+gtk_label_set_text(GTK_LABEL(label), NULL);
   }
 }
 
+/***
+  Update city report button sensitivity and total buy cost label when the
+  user makes a change in the selection of cities.
+***/
+static void city_selection_changed_callback(GtkTreeSelection *selection)
+{
+  int n;
+
+  n = gtk_tree_selection_count_selected_rows(selection);
+
+  gtk_widget_set_sensitive(city_production_command,
+   n  0  can_client_issue_orders());
+  gtk_widget_set_sensitive(city_center_command, n  0);
+