[Freeciv-Dev] [patch #3928] Qt reports (units, economy and endgame)
Update of patch #3928 (project freeciv): Status: Ready For Test = Done Assigned to:None = mir3x Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3928 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3929] Updated documentation of civil_war_chance
URL: http://gna.org/patch/?3929 Summary: Updated documentation of civil_war_chance Project: Freeciv Submitted by: mss_8734 Submitted on: Thu May 30 13:05:44 2013 Category: docs Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: I happened to notice that server/plrhand.c:civil_war_triggered() handles its calculations in a manner not mentioned in doc/README.effects. ___ File Attachments: --- Date: Thu May 30 13:05:44 2013 Name: readme_civil_war.diff Size: 662B By: mss_8734 http://gna.org/patch/download.php?file_id=18030 ___ Reply to this item at: http://gna.org/patch/?3929 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3926] Make it easier for users to locally add a custom nation to the default set
Follow-up Comment #1, patch #3926 (project freeciv): Would it be a great deal of work to add something overriding existing definitions? Something like ‘*override_with my_local_nation.ruleset’ which one can add after including the default nation list. ___ Reply to this item at: http://gna.org/patch/?3926 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3926] Make it easier for users to locally add a custom nation to the default set
Follow-up Comment #2, patch #3926 (project freeciv): Would it be a great deal of work to add something overriding existing definitions? Something like ‘*override_with my_local_nation.ruleset’ which one can add after including the default nation list. Nothing prevents including addition nations to nations.ruleset after one has included default/nationlist.ruleset. Perhaps we could make this a bit easier with minimal efforts by having nationlist.ruleset *include extranations.ruleset, the supplied version of which would be blank except for some explanatory comments. How is creating local copy of extranations.ruleset fundamentally different from creating local copy of nations.ruleset? All the same search path issues would be present, I think. (You'd need to place it as ~/.freeciv/default/extranations.ruleset, or worse, separately for each ruleset ~/.freeciv/classic/extranations.ruleset, ~/.freeciv/experimental/extranations.ruleset... ) ___ Reply to this item at: http://gna.org/patch/?3926 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20855] ai/default/aiunit.c:look_for_charge()
URL: http://gna.org/bugs/?20855 Summary: ai/default/aiunit.c:look_for_charge() Project: Freeciv Submitted by: mss_8734 Submitted on: Thu May 30 14:14:25 2013 Category: ai Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: It strikes me as odd that no units with higher attack power are ever considered worthy of bodyguarding, regardless of circumstances. Not very good for capturable bombarder units with a 10:1 attack-to-defence ratio... I can cook something up later that takes these possibilities into account, but I have another couple of thousand occurences of the digit ‘3’ to browse first. ___ Reply to this item at: http://gna.org/bugs/?20855 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20856] aisettler.c:food_starvation() seems to assume hardcoded 2 food/citizen.
URL:
http://gna.org/bugs/?20856
Summary: aisettler.c:food_starvation() seems to assume
hardcoded 2 food/citizen.
Project: Freeciv
Submitted by: mss_8734
Submitted on: Thu May 30 14:29:47 2013
Category: ai
Severity: 3 - Normal
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release:
Discussion Lock: Any
Operating System: None
Planned Release:
___
Details:
static bool food_starvation(const struct cityresult *result)
{
/* Avoid starvation: We must have enough food to grow. */
return (result-city_center.tdc-food
+ (result-best_other.tdc ? result-best_other.tdc-food
: 0) 3);
}
Am I reading this function and its use completely wrong or ought that rely on
the ruleset defined food cost for citizen upkeep?
___
Reply to this item at:
http://gna.org/bugs/?20856
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3835] Negated requirements sanity checking improvements
Update of patch #3835 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3835 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20847] server/generator/mapgen.c:is_tiny_island()
Update of bug #20847 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?20847 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] [Freeciv-commits] r22920 - /branches/S2_5/common/terrain.c
On 30 May 2013 21:38, pepeto pepet...@gmail.com wrote: Allocate correct memory size for threads. ... branches/S2_5/common/terrain.c Seems like you got wrong patch applied there. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20778] Memory overwrite errors
Update of bug #20778 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?20778 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3930] Case-insensitive string comparisons with icu
URL: http://gna.org/patch/?3930 Summary: Case-insensitive string comparisons with icu Project: Freeciv Submitted by: cazfi Submitted on: Thu 30 May 2013 10:01:00 PM EEST Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Use icu for for case insensitive string comparisons. This is likely to fix some never noticed bugs in comparisons when there's different multibyte character in compared strings. ___ File Attachments: --- Date: Thu 30 May 2013 10:01:00 PM EEST Name: IcuCaseCmp.patch Size: 3kB By: cazfi http://gna.org/patch/download.php?file_id=18031 ___ Reply to this item at: http://gna.org/patch/?3930 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3921] Fix Deneb 5 - Deneb 7
Follow-up Comment #2, patch #3921 (project freeciv): ISTR seeing a mention of Planet somewhere too. cough I think it's ok as long as it's not used like name. There was one place where it begun the sentence, and thus had even capital letter. I changed that to This planet in attached version. Another occurrence changed to Deneb 7 and all the remaining were either of the form this planet or were clearly referring to Deneb 7 mentioned in earlier sentence. (file #18032) ___ Additional Item Attachment: File name: Deneb7-2.patch Size:2 KB ___ Reply to this item at: http://gna.org/patch/?3921 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3550] Merge update_rect_at_mouse_pos into move_mapcanvas (patch 11/60)
Update of patch #3550 (project freeciv): Status:None = Ready For Test Assigned to:None = cazfi Planned Release: 2.5.0 = 2.4.0, 2.5.0, 2.6.0 ___ Follow-up Comment #8: Ok, it seems that the helper function that both would call I wanted introduced actually exist already named update_selection_rectangle(), and your patch already uses it. ___ Reply to this item at: http://gna.org/patch/?3550 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3560] Use standard button interface (patch 21/60)
Follow-up Comment #7, patch #3560 (project freeciv): From patch #3889: One other thing regarding patch #3560: while there is gtk_button_set_always_show_image, it's only since 3.6 and IMHO title of the button is descriptive enough in the context anyway if one has a theme that turns off images on buttons. Could that be the thing to do in development version even though it cannot be solution for S2_4. Make gtk+-3.6 minimum requirement, and use gtk_button_set_always_show_image(). ___ Reply to this item at: http://gna.org/patch/?3560 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3560] Use standard button interface (patch 21/60)
Update of patch #3560 (project freeciv): Status:None = Ready For Test Planned Release: 2.5.0 = 2.6.0 ___ Follow-up Comment #8: Version that makes gtk+ 3.6 minimum requirement, and uses gtk_button_set_always_show_image(). Meant for TRUNK only. (file #18033) ___ Additional Item Attachment: File name: Gtk3StdButIface.patch Size:5 KB ___ Reply to this item at: http://gna.org/patch/?3560 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16383] Option to forbid RiverNative units moving diagonally / cross-continent
Update of bug #16383 (project freeciv): Assigned to: cazfi = None ___ Reply to this item at: http://gna.org/bugs/?16383 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20842] unit still in focus after put in sentry mode in batch
Follow-up Comment #3, bug #20842 (project freeciv): Your helpful answer, and further testing, led me to investigate again the issue which did not actually disappear after my first patch. As you rightfully indicated, the client should not expect the server to accept requests unilaterally, and thus should not update the state of an unit before receiving the server update. There seems to be one exception to that rule (see comments of function `handle_unit_packet_common` in client/packhand.c), but it doesn't concern the issue at hand. Basically, whenever a group of units is being awaken, the server will send a batch of packets to indicate that change to the client. In certain situations, the client will then put these units in the `client/control.c:urgent_focus_queue` list, so that these units get the player attention. However, when these units are put in sentry mode, they are not removed from that queue. Later, when the client looks for a unit to be put in focus, it will check `urgent_focus_queue` (see the `client/control.c:advance_unit_focus` function). My original patch was not far off it seems, and the new patch I hereby propose simply removes any unit put in sentry mode from the urgent queue. I provide also a minimal map to test the issue on the client before and after the patch. Let me restate the steps to reproduce the bug: - load up the map, - click on the sole unit stack there, - click on the 'ready all' button of the select dialog, - press 'shift-v' to select the whole unit stack, - press 's' to put them all in sentry again The above steps consistently produce the issue on my computer. Also, a small log of the packets exchanged between the client and the server is provided, with light annotations (and a few more debugging messages which I added to my own build) of the packet stream. It shows the packets which made units to be added to the urgent list (see packets '10' to '20', which correspond to the idle activity change notification from the server after pressing 'shift-v'), and the selection of the next focused unit (after packet '29'). (file #18034, file #18035) ___ Additional Item Attachment: File name: 0001-fix-focus-unit-list-when-unit-put-in-sentry.patch.gz Size:0 KB File name: test_case.tgz Size:10 KB ___ Reply to this item at: http://gna.org/bugs/?20842 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
