[Freeciv-Dev] [patch #4197] Move handicaps stuff under ai/

2013-09-18 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?4197

 Summary: Move handicaps stuff under ai/
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 18 Sep 2013 01:38:50 PM EEST
Category: ai
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Move handicaps stuff from common/player.[ch] to new ai/handicaps.[ch] module.



___

File Attachments:


---
Date: Wed 18 Sep 2013 01:38:51 PM EEST  Name: AiHandicaps.patch.bz2  Size:
11kB   By: cazfi

http://gna.org/patch/download.php?file_id=19040

___

Reply to this item at:

  http://gna.org/patch/?4197

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4197] Move handicaps stuff under ai/

2013-09-18 Thread Marko Lindqvist
Update of patch #4197 (project freeciv):

  Status:  Ready For Test = In Progress


___

Reply to this item at:

  http://gna.org/patch/?4197

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4191] Make the spy action incite city use the action enabler frame work

2013-09-18 Thread Sveinung Kvilhaugsvik
Update of patch #4191 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?4191

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4131] Oil Well

2013-09-18 Thread Marko Lindqvist
Update of patch #4131 (project freeciv):

  Status:  Ready For Test = In Progress


___

Reply to this item at:

  http://gna.org/patch/?4131

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4198] Clean up is_diplomat_action_available()

2013-09-18 Thread Sveinung Kvilhaugsvik
URL:
  http://gna.org/patch/?4198

 Summary: Clean up is_diplomat_action_available()
 Project: Freeciv
Submitted by: sveinung
Submitted on: Wed 18 Sep 2013 01:00:37 PM GMT
Category: None
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

The function is_diplomat_action_available() in common/unit.c is half way
between coding styles. Make it consistent for the sake of readability.



___

File Attachments:


---
Date: Wed 18 Sep 2013 01:00:37 PM GMT  Name:
clean_up_is_diplomat_action_available.patch  Size: 3kB   By: sveinung

http://gna.org/patch/download.php?file_id=19041

___

Reply to this item at:

  http://gna.org/patch/?4198

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4185] Mark uncertain actions in the Qt client

2013-09-18 Thread Sveinung Kvilhaugsvik
Follow-up Comment #1, patch #4185 (project freeciv):

- Update to current SVN trunk
- Add a tool tip: Starting to do this may currently be impossible.
- Keep the warning icon on the button

(file #19042)
___

Additional Item Attachment:

File name: qt_warn_uncertain_actions.patch Size:6 KB


___

Reply to this item at:

  http://gna.org/patch/?4185

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4199] Make trying an illegal action cost a bit movement

2013-09-18 Thread Sveinung Kvilhaugsvik
URL:
  http://gna.org/patch/?4199

 Summary: Make trying an illegal action cost a bit movement
 Project: Freeciv
Submitted by: sveinung
Submitted on: Wed 18 Sep 2013 03:01:47 PM GMT
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

This gives the extra information gained from knowing if it is enabled or not a
price.

See suggestions by Marko Lindqvist cazfi in bug #21105 and by Jacob Nevins
jtn in patch #4156



___

File Attachments:


---
Date: Wed 18 Sep 2013 03:01:47 PM GMT  Name: mistake_has_a_cost.patch  Size:
582B   By: sveinung

http://gna.org/patch/download.php?file_id=19043

___

Reply to this item at:

  http://gna.org/patch/?4199

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4200] Don't use meta knowledge in the client

2013-09-18 Thread Sveinung Kvilhaugsvik
URL:
  http://gna.org/patch/?4200

 Summary: Don't use meta knowledge in the client
 Project: Freeciv
Submitted by: sveinung
Submitted on: Wed 18 Sep 2013 03:04:49 PM GMT
Category: general
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

See discussion in patch #4156




___

Reply to this item at:

  http://gna.org/patch/?4200

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21148] map size selection buggy

2013-09-18 Thread anonymous
URL:
  http://gna.org/bugs/?21148

 Summary: map size selection buggy
 Project: Freeciv
Submitted by: None
Submitted on: Wed 18 Sep 2013 04:26:47 PM UTC
Category: general
Severity: 2 - Minor
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: jony.r...@gmail.com
 Open/Closed: Open
 Release: 2.4.0
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

the map selection options are weird and buggy.

the selection method by tiles per player still has the same 1000 limit
(126.000 tiles) as the previous release.

the total numbers of tiles has a smaller upper limit (2.048.000) then x*y
tiles which allows up to 32768 for each axis giving a total of 1.073.741.824
maximum (theoretical) tiles.

only the x*y tiles seem to work for maps above some (seemingly arbitrary
number of around 130-200 tiles, sometimes it's higher then other times) with
total # of tiles; it says

The server couldn't allocate starting positions.
Failed to create suitable map, retrying with another mapseed
The server couldn't allocate starting positions.
Cannot create suitable map with given settings.
Please report this message at http://gna.org/projects/freeciv/;

but at some point between 500*500 (25.000.000) and 700*700 the x*y map size
selection also gives the same problem.

Seems like options that don't work shouldn't be given as option to begin with,
otherwise users are at a loss at to what they can and can't do and leaves them
having to try out things.

having said this, given this problem arises at very big map games it is not
much important/priority but is a problem never the less.

Another problem is the isohex and hex option doesn't seem to work, it just
chooses the isometric instead AFAI can tell, but something seems to be
different, I didn't bother checking what that difference is.

P.S. this is 1st time I report a bug, let me know if I am doing something
wrong and how to do it right.

P.P.S I wanted to post this as a comment in bug
http://gna.org/bugs/index.php?21072 but there was no submit button (maybe I
had to log in, but I have no account, and when registering firefox said the
connection is not trusted, so too much hassle to post a comment)




___

Reply to this item at:

  http://gna.org/bugs/?21148

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4201] Add test for CasusBellig (reason to cancel) to DiplRel requirement type.

2013-09-18 Thread Sveinung Kvilhaugsvik
URL:
  http://gna.org/patch/?4201

 Summary: Add test for CasusBellig (reason to cancel) to
DiplRel requirement type.
 Project: Freeciv
Submitted by: sveinung
Submitted on: Wed 18 Sep 2013 05:56:34 PM GMT
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:





___

File Attachments:


---
Date: Wed 18 Sep 2013 05:56:34 PM GMT  Name: DiplRelCasusBelli.patch  Size:
2kB   By: sveinung

http://gna.org/patch/download.php?file_id=19044

___

Reply to this item at:

  http://gna.org/patch/?4201

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21148] map size selection buggy

2013-09-18 Thread Sveinung Kvilhaugsvik
Follow-up Comment #1, bug #21148 (project freeciv):

Thank you for you bug report. I'm not familiar with the code generator but I
hope I'll be able to help. (To the more experienced developers: please let us
know if I said anything wrong)

 this is 1st time I report a bug, let me know if I am doing something wrong
and how to do it right.
This is the first time I try to help someone that has filed a Freeciv bug
report. If I sound angry, insulting or otherwise got the tone wrong blame my
English and lack of experience in answering bug reports. Here is what I was
able to find:
* separate issues belong in separate bug reports. It may be hard to tell what
is a different issue. A rule of thumb: If you feel like saying Another
problem is you are probably dealing with another issue.
* step by step instructions on how to reproduce an issue is often needed. Try
to remember if you have saved settings and what they are. This leaves less
room for the developers to misunderstand you. Example: Set Map size
definition to With and height, Map with in tiles to 700 and Map height
in tiles to 700. Don't change anything else (like the number of players, the
rule set etc). Press start.
* Freeciv specific: If you set the game seed and map seed settings the
randomness goes away. If you can reproduce an issue after having set those
(and provide detailed instructions) it is a lot easier to reproduce the
issue.
* Freeciv specific: Look at the area where messages appear. Lines like 'set
mapsize XYSIZE' is your settings as text. That is easier to understand than
instructions on where to click etc.

 seemingly arbitrary number of around 130-200 tiles, sometimes it's higher
then other times
Some background: The map is generated from a setting called map seed. I assume
that map seed and game seed is set to 0 in your case. If that is true a
different number will be used as map seed each time. When the map is created
the generator will try to find a good place for each player to start. If it
can't it will try again and then fail. This is why it is arbitrary if you get
the message or not.

 Another problem is the isohex and hex option doesn't seem to work,
Do you mean that it don't change the graphics used to show it? As something
seems to be different I suspect that is the case.

___

Reply to this item at:

  http://gna.org/bugs/?21148

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4201] Add test for Casus Belli (reason to cancel) to the DiplRel requirement type.

2013-09-18 Thread Sveinung Kvilhaugsvik
Update of patch #4201 (project freeciv):

 Summary: Add test for CasusBellig (reason to cancel) to
DiplRel requirement type. = Add test for Casus Belli (reason to cancel) to
the DiplRel requirement type.


___

Reply to this item at:

  http://gna.org/patch/?4201

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21140] Tunnel flags defined twice

2013-09-18 Thread Marko Lindqvist
Update of bug #21140 (project freeciv):

  Status:  Ready For Test = Fixed  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?21140

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4183] SDL2 Welcome

2013-09-18 Thread Marko Lindqvist
Update of patch #4183 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?4183

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4197] Move handicaps stuff under ai/

2013-09-18 Thread Marko Lindqvist
Update of patch #4197 (project freeciv):

  Status: In Progress = Ready For Test 

___

Follow-up Comment #1:

Have been thinking quite hard if the handicaps module should go to ai/, or
under server/ (even server/advisors/) as the main server code uses it too. In
the end decided that it's ok for soemthing used by the main server to live in
ai -root (but obviously not in ai-type specific subdirs).

This patch resolves one of the three problems in fitting handicaps to correct
place in architecture; ai-handicaps are no longer in common code.
The remaining problems are that 1) while some handicaps are used by main
server code, most of them are specific to default ai - those should live in
default ai space, and 2) ai-type has no say in assigning handicaps (together
this means that default ai has no control over when default ai specific
handicaps are assigned)

___

Reply to this item at:

  http://gna.org/patch/?4197

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21141] Server crash when city has more trade routes than current max

2013-09-18 Thread Marko Lindqvist
Update of bug #21141 (project freeciv):

  Status:  Ready For Test = Fixed  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?21141

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4101] Ability for bases to hide units

2013-09-18 Thread Marko Lindqvist
Follow-up Comment #2, patch #4101 (project freeciv):

I think one could try to make first version of this already, with improvements
in later tickets.
- Nativity is now property of extras.
- Gfx tags are not property of extras, so changing the appearcanse of the
extra depending if it hides units or not, cannot be yet implemented

___

Reply to this item at:

  http://gna.org/patch/?4101

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev