[Freeciv-Dev] [bug #22392] 1: in is_native_to_class() [movement.c::301]: assertion '((void *)0) != punitclass-cache.native_tile_bases' failed.

2014-08-05 Thread Marko Lindqvist
Update of bug #22392 (project freeciv):

 Assigned to:None = cazfi  


___

Reply to this item at:

  http://gna.org/bugs/?22392

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22434] civ2civ3: Hoover Dam in city should make Solar Plant redundant

2014-08-05 Thread Jacob Nevins
Update of bug #22434 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?22434

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22438] civ2civ3: Triremes in coastal river cities miss out on Lighthouse move bonus

2014-08-05 Thread Jacob Nevins
Update of bug #22438 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 

___

Follow-up Comment #4:

(Committed to S2_5 as r25834
http://svn.gna.org/viewcvs/freeciv?revision=25834view=revision.)

___

Reply to this item at:

  http://gna.org/bugs/?22438

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5018] Rewrite description of action enablers in doc/README.actions

2014-08-05 Thread Sveinung Kvilhaugsvik
Update of patch #5018 (project freeciv):

  Status: In Progress = Ready For Test 


___

Reply to this item at:

  http://gna.org/patch/?5018

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22392] 1: in is_native_to_class() [movement.c::301]: assertion '((void *)0) != punitclass-cache.native_tile_bases' failed.

2014-08-05 Thread Marko Lindqvist
Follow-up Comment #2, bug #22392 (project freeciv):

 Noticed that with many cycles of attaching/detaching, the cache
 was allocated many times (but not free).

Do you mean there's that kind of separate bug? unit_classes_free() -
game_ruleset_free() not being called when client detaches?


___

Reply to this item at:

  http://gna.org/bugs/?22392

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22392] 1: in is_native_to_class() [movement.c::301]: assertion '((void *)0) != punitclass-cache.native_tile_bases' failed.

2014-08-05 Thread pepeto
Follow-up Comment #4, bug #22392 (project freeciv):

 Do you mean there's that kind of separate bug?
 unit_classes_free() - game_ruleset_free() not being called
 when client detaches?

This is not a separate bug. game_ruleset_free() is called only when the client
disconnect, not when the client state changes (see game_reset()).


___

Reply to this item at:

  http://gna.org/bugs/?22392

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22392] 1: in is_native_to_class() [movement.c::301]: assertion '((void *)0) != punitclass-cache.native_tile_bases' failed.

2014-08-05 Thread Marko Lindqvist
Follow-up Comment #5, bug #22392 (project freeciv):

 This is not a separate bug. game_ruleset_free() is called only
 when the client disconnect, not when the client state changes
 (see game_reset()).

That's how it should be, but why it was not called when your client detached,
and how the change to cache *allocation* (your patch) fixes this?

___

Reply to this item at:

  http://gna.org/bugs/?22392

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21932] nuke self destructs own city after tech loss

2014-08-05 Thread Jacob Nevins
Update of bug #21932 (project freeciv):

Operating System:None = Any

___

Follow-up Comment #9:

 This bug is no longer present in version 2.5.
I don't think it's fixed.

The behaviour you describe sounds like what happens in a turn _after_ the turn
you lose the tech, where the unit starts out with 0 move points.

The attached save files allow you to lose Rocketry by giving it to another civ
with whom you have contact (techlost_donor=100%), and then try moving the
existing Nuclear unit in the same turn (which should work). Behaviour:
* S2_4 r25827 (+ civ2civ3 2.4-6 10-Apr-2014) and S2_5 r25834
** arrow keys: move unit (OK)
** goto: forbidden cursor, Didn't find a route to the destination! (bad)
** explode: explodes without moving first (very bad)
* trunk r25834
** arrow keys: move unit (OK)
** goto: lets you set a route and hover text claims it will move this turn,
but when you click, it doesn't follow it this turn (unit stays put with G
icon, apparently waiting to move next turn) (bad)
** explode: unit moves and explodes at destination (OK)

On all branches, the behaviour the turn after losing the tech (where the unit
has 0 MP) is OK:
* arrow keys: do nothing (OK)
* goto: forbidden cursor, Didn't find a route to the destination! (OK)
* explode: Too far for this unit. (OK)

There have been various changes in pathfinding recently which I guess might
affect this. It does seem to be bugs in pathfinding assuming inability to
move, rather than actual inability to move.

(I also see Tileset amplio2 doesn't support long goto paths, such as -1.
Path not displayed as expected. in the client console when I'm playing with
this.)

(file #21667, file #21668)
___

Additional Item Attachment:

File name: 24c3_nuke.sav.bz2  Size:14 KB
File name: 25c3_nuke.sav.bz2  Size:19 KB


___

Reply to this item at:

  http://gna.org/bugs/?21932

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5023] Extra build_time

2014-08-05 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5023

 Summary: Extra build_time
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 06 Aug 2014 03:13:52 AM EEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Make build_time property of all extras, not just bases and roads.

As a result irrigation and mining extra building activities get the same
flexibility as roads and bases already had. For example it would be possible
to give Farmland building constant time while Irrigation building has terrain
specific time (like Road/Railroad already works)

If the same extra can be built with multiple activities (it has multiple
activity causes) all the activities use the same build_time, but if it's
zero, activity specific terrain time will be used.



___

File Attachments:


---
Date: Wed 06 Aug 2014 03:13:52 AM EEST  Name: ExtraBuildTime.patch.bz2  Size:
8kB   By: cazfi

http://gna.org/patch/download.php?file_id=21669

___

Reply to this item at:

  http://gna.org/patch/?5023

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22444] clean_pollution|fallout_time not documented

2014-08-05 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?22444

 Summary: clean_pollution|fallout_time not documented
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 06 Aug 2014 03:41:31 AM EEST
Category: docs
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.0, 2.4.3

___

Details:

Supplied terrain.rulesets do not have documenting comments
about clean_pollution_time and clean_fallout_time.

Targeting stable brances only, as in TRUNK extras work will take care of this.




___

Reply to this item at:

  http://gna.org/bugs/?22444

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5024] Extra removal time

2014-08-05 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5024

 Summary: Extra removal time
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 06 Aug 2014 03:59:34 AM EEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Add extra property removal_time, features consistent with build_time but
affecting extra removal activities CleanPollution and CleanFallout.
Pillaging time is still hardcoded to 1 turn, but ruleset changes in this patch
are already made like pillaging would be affected.



___

File Attachments:


---
Date: Wed 06 Aug 2014 03:59:34 AM EEST  Name: ExtraRemovalTime.patch.bz2 
Size: 4kB   By: cazfi

http://gna.org/patch/download.php?file_id=21670

___

Reply to this item at:

  http://gna.org/patch/?5024

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] Upcoming release: 2.4.3

2014-08-05 Thread Jacob Nevins
As mentioned previously, I plan to make a 2.4.3 release soon; possibly
as soon as the evening of 12 August (UK time).
This is because (a) it's about time, (b) we're trying to get it into the
next Debian/Ubuntu releases.

Draft release notes are here: http://www.freeciv.org/wiki/NEWS-2.4.3

So, S2_4 is now in string freeze for this release.
Files at http://www.cazfi.net/freeciv/translations/S2_4/ are fresh.
Current stats:

ca: 99.9%: 7200 translated, 1 fuzzy.
fr: 99.9%: 7200 translated, 1 fuzzy.
en_GB: 99.9%: 7200 translated, 1 fuzzy.
pl: 99.9%: 7194 translated, 3 fuzzy, 4 untranslated.
es: 99.6%: 7171 translated, 16 fuzzy, 14 untranslated.
ru: 98.1%: 7061 translated, 108 fuzzy, 32 untranslated.
fi: 97.3%: 7005 translated, 3 fuzzy, 193 untranslated.
de: 95%: 6814 translated, 19 fuzzy, 368 untranslated.
gd: 94%: 6770 translated, 253 fuzzy, 178 untranslated.
ja: 83%: 5958 translated, 796 fuzzy, 447 untranslated.
da: 78%: 5650 translated, 988 fuzzy, 563 untranslated.
uk: 68%: 4876 translated, 1258 fuzzy, 1067 untranslated.
nl: 67%: 4793 translated, 1441 fuzzy, 967 untranslated.
it: 61%: 4386 translated, 1833 fuzzy, 982 untranslated.
pt_BR: 58%: 4151 translated, 2069 fuzzy, 981 untranslated.
ga: 54%: 3862 translated, 66 fuzzy, 3273 untranslated.
id: 51%: 3659 translated, 184 fuzzy, 3358 untranslated.
sv: 50%: 3566 translated, 2067 fuzzy, 1568 untranslated.
tr: 40%: 2856 translated, 2551 fuzzy, 1794 untranslated.
et: 39%: 2831 translated, 2672 fuzzy, 1698 untranslated.
zh_TW: 39%: 2813 translated, 92 fuzzy, 4296 untranslated.
cs: 39%: 2805 translated, 2765 fuzzy, 1631 untranslated.
eo: 38%: 2731 translated, 2097 fuzzy, 2373 untranslated.
lt: 37%: 2639 translated, 2248 fuzzy, 2314 untranslated.
ro: 34%: 2457 translated, 2815 fuzzy, 1929 untranslated.
zh_CN: 34%: 2423 translated, 2929 fuzzy, 1849 untranslated.
ar: 33%: 2374 translated, 3186 fuzzy, 1641 untranslated.
no: 33%: 2366 translated, 3063 fuzzy, 1772 untranslated.
nb: 33%: 2366 translated, 3063 fuzzy, 1772 untranslated.
ko: 28%: 2052 translated, 1976 fuzzy, 3173 untranslated.
sr: 28%: 2042 translated, 1549 fuzzy, 3610 untranslated.
el: 28%: 1999 translated, 2416 fuzzy, 2786 untranslated.
bg: 27%: 1921 translated, 340 fuzzy, 4940 untranslated.
hu: 26%: 1840 translated, 3285 fuzzy, 2076 untranslated.
pt: 23%: 1674 translated, 3309 fuzzy, 2218 untranslated.
fa: 23%: 1639 translated, 2185 fuzzy, 3377 untranslated.
he: 23%: 1633 translated, 1958 fuzzy, 3610 untranslated.

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22445] Pillaging fortress may avoid incident

2014-08-05 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?22445

 Summary: Pillaging fortress may avoid incident
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 06 Aug 2014 04:10:08 AM EEST
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

Not confirmed, but noticed in source code:

ACTIVITY_PILLAGE removes the pillage target first, then handles diplomatic
incident with the tile owner. But if the extra pillaged was the
claim_territory base that was the only reason the other player owned the tile,
there's no tile owner any more - nobody to cause incident against.




___

Reply to this item at:

  http://gna.org/bugs/?22445

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5025] Extra/Terrain pillage_time

2014-08-05 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5025

 Summary: Extra/Terrain pillage_time
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 06 Aug 2014 04:32:05 AM EEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Make pillage activity to take ruleset configured time, consistent with other
extra removal activities, instead of being constant 1 turn.




___

File Attachments:


---
Date: Wed 06 Aug 2014 04:32:05 AM EEST  Name: PillageTime.patch.bz2  Size: 3kB
  By: cazfi

http://gna.org/patch/download.php?file_id=21671

___

Reply to this item at:

  http://gna.org/patch/?5025

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5026] Disallow activities based on terrain activity time settings

2014-08-05 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5026

 Summary: Disallow activities based on terrain activity time
settings
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 06 Aug 2014 04:40:44 AM EEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

For consistency with how ACTIVITY_GEN_ROAD is disallowed on terrains with
road_time = 0 and ACTIVITY_BASE on terrains with base_time = 0, disallow all
activities when the matching terrain activity time is 0.

Affects:
- ACTIVITY_IRRIGATE
- ACTIVITY_MINE
- ACTIVITY_POLLUTION
- ACTIVITY_FALLOUT
- ACTIVITY_PILLAGE



___

File Attachments:


---
Date: Wed 06 Aug 2014 04:40:44 AM EEST  Name: TerrainTimeDisable.patch  Size:
1kB   By: cazfi

http://gna.org/patch/download.php?file_id=21672

___

Reply to this item at:

  http://gna.org/patch/?5026

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22446] civ2civ3 illegal happyborders value

2014-08-05 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?22446

 Summary: civ2civ3 illegal happyborders value
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 06 Aug 2014 04:49:12 AM EEST
Category: rulesets
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.6.0

___

Details:

civ2civ3 ruleset still sets server setting to value DISABLED. Current
equivalent value is DISABLE

Quick fix attached (and meant to be committed), but in general having enum
setting value named DISABLE is likely to cause confusion when boolean
settings can take value DISABLED - might be a good idea to rename this one.



___

File Attachments:


---
Date: Wed 06 Aug 2014 04:49:12 AM EEST  Name:
Civ2civ3HappybordersDisable.patch  Size: 520B   By: cazfi

http://gna.org/bugs/download.php?file_id=21673

___

Reply to this item at:

  http://gna.org/bugs/?22446

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22445] Pillaging fortress may avoid incident

2014-08-05 Thread Marko Lindqvist
Update of bug #22445 (project freeciv):

  Status:None = Ready For Test 
 Planned Release: = 2.4.3, 2.5.0, 2.6.0

___

Follow-up Comment #1:

Fix

(file #21674, file #21675, file #21676)
___

Additional Item Attachment:

File name: PillageFortressIncident.patch  Size:0 KB
File name: PillageFortressIncident-S2_5.patch Size:0 KB
File name: PillageFortressIncident-S2_4.patch Size:0 KB


___

Reply to this item at:

  http://gna.org/bugs/?22445

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev