[Freeciv-Dev] [bug #16080] The Great Wall affects all units regardless of whether they're inside cities

[Jacob Nevins]

Update of bug #16080 (project freeciv):

 Open/Closed:Open => Closed 
Operating System:   Microsoft Windows => None   

___

Follow-up Comment #11:

This ticket remained open pending a decision about whether to backport to
S2_1. Since no-one's said anything, I think I'm not going to; users may be
sticking with 2.1.x rather than moving to 2.2.x because they're happy with
the gameplay, whether or not it's what was originally intended, or to finish
existing games; this seems like a big gameplay change to drop into a series
that's late in its maintenance cycle.

So I've closed this without fixing on S2_1. I've rescued kriss' original
documentation improvements in patch #1854.

kriss: if you want to go ahead with the Wall->Def rename, you probably want
to raise a new patch ticket for it. I don't know whether we have a policy on
such renames.
I think you'll need to work on the help; for F_IGDEF, "Ignores the effects of
defense bonus" could be misinterpreted as ignoring _all_ defence bonuses
(e.g., from terrain); you'll need to find a way to marry it up with the
EFT_DEFEND_BONUS and F_BADDEFATTACKER in user-visible terms in the
autogenerated help, or alternatively stop mentioning it at all and rely on
the ruleset-specific help to describe these effects in terms that make sense
for that ruleset. (Neither of the latter two are documented in autogenerated
help currently.)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16080] The Great Wall affects all units regardless of whether they're inside cities

[pepeto]

Follow-up Comment #10, bug #16080 (project freeciv):

Please, see also bug #16308.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16080] The Great Wall affects all units regardless of whether they're inside cities

[Christophe Vidal]

Follow-up Comment #9, bug #16080 (project freeciv):

Because IGWALL and BADWALLATTACKER could be thought has having something to
do with walls, when in fact they actually do not, and never did so because of
their influence on other buildings (eg. Coastal Fortress), we could give them
names closer to their semantic. This change could occur both in the code and
in the rulesets to limit confusion for both developers and modders.

Thus, I have attached a patch that renames each references of IGWALL or
BADWALLATTACKER to IGDEF or BADDEFATTACKER, respectively, as well as the
variables dealing with them. Comments have also been added/updated in the
code and in the rulesets to reflect the changes.

The patch is applicable only to the trunk, but please note that, whereas
bundled rulesets have been updated to use the new values for these flags
("IgDef" & "BadDefAttacker") to preserve compatibility with the new code, its
application could make current/alternative rulesets incompatible without minor
edits.

(file #9469)
___

Additional Item Attachment:

File name: trunk-defend-bonus-semantic.diff Size:14 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16080] The Great Wall affects all units regardless of whether they're inside cities

[Jacob Nevins]

Follow-up Comment #8, bug #16080 (project freeciv):

On trunk, the experimental ruleset also needed fixing.

What about S2_1? We don't have the CityTile effect there (it originally came
from RT#40207 , and a
different fix was used on S2_1). Will there ever be another 2.1.x release,
and if so, is this an appropriate thing to fix in it, given how long it's
been the way it is? If so I guess CityTile needs backporting.

>> EFT_DEFEND_BONUS is already pretty tightly tied to implementing
>> city walls or similar city defences 
> 
> Doesn't existence of this bug prove otherwise :-)

:) I mean that it's all tied up with things called IGWALL and BADWALLATTACKER
(apropos of which, there's some documentation changes in kriss' original patch
that I want to rescue). I suppose there's nothing stopping you implementing
something non-wall-like with those flags despite their names.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16080] The Great Wall affects all units regardless of whether they're inside cities

[Jacob Nevins]

Update of bug #16080 (project freeciv):

 Planned Release:   2.2.2 => 2.2.2,2.3.0


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16080] The Great Wall affects all units regardless of whether they're inside cities

[Jacob Nevins]

Update of bug #16080 (project freeciv):

Severity:  3 - Normal => 4 - Important  
  Status:None => Fixed  
 Planned Release: => 2.2.2  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16080] The Great Wall affects all units regardless of whether they're inside cities

[Jacob Nevins]

Update of bug #16080 (project freeciv):

 Assigned to:None => jtn


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16080] The Great Wall affects all units regardless of whether they're inside cities

[Christophe Vidal]

Follow-up Comment #5, bug #16080 (project freeciv):

I have to admit that jtn's fix is better. Indeed, I forgot about the
existence of the CityTile requirement type ;)

Following the same principle, I have included a fix for civ1 & civ2 rulesets,
which, besides the default ruleset, are both affected by the problem. The fix
is applicable to both the trunk and the S2_2 branch.

(file #9395)
___

Additional Item Attachment:

File name: greatwall-effect.diff  Size:1 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16080] The Great Wall affects all units regardless of whether they're inside cities

[Marko Lindqvist]

Follow-up Comment #4, bug #16080 (project freeciv):

I definitely prefer jtn's fix. We should not be adding hardcoded properties
to the effects, but making system more flexible.

> EFT_DEFEND_BONUS is already pretty tightly tied to implementing
> city walls or similar city defences

Doesn't existence of this bug prove otherwise :-)


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16080] The Great Wall affects all units regardless of whether they're inside cities

[Jacob Nevins]

Update of bug #16080 (project freeciv):

 Summary: The Great Wall affects all units which is staying
out of City => The Great Wall affects all units regardless of whether they're
inside cities


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev