[Freeciv-Dev] [bug #16465] Cannot build two bases on one tile

[pepeto]

Update of bug #16465 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16465] Cannot build two bases on one tile

[pepeto]

Update of bug #16465 (project freeciv):

  Status:   Fixed => Ready For Test 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16465] Cannot build two bases on one tile

[pepeto]

Update of bug #16465 (project freeciv):

  Status:   Need Info => Fixed  
 Assigned to:None => pepeto 

___

Follow-up Comment #11:

>> I don't understand why bases claiming territory should be in
>> conflict. Shouldn't the base with the highest degree of claiming
>> territory use its effect, ignoring the effect of others, but
>> keeping the other bases for the other features?
>
>
>Yes, it was meant to be only temporary solution that territory >claiming
bases automatically conflict with each other. To >implement it so that lesser
territory claiming bases are ignored >takes some work.

I raised a separated item for that (patch #1864).


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16465] Cannot build two bases on one tile

[Marko Lindqvist]

Follow-up Comment #10, bug #16465 (project freeciv):

> Since RT#40502: [Patch] Conflicting bases from ruleset, at
> revision 15242, default ruleset has the following conflicts:

 You mean that concept of conflicting bases was implemented back then. Ruins
and Buoys have not conflicted since then, as they we're not in game yet.

>* Fortress is in conflict with Airbase.
>* Fortress is in conflict with Buoy.
>* Fortress is in conflict with Ruins.
>* Buoy is in conflict with Ruins.

But Buoy is not conflicting with Airbase? Sounds like there is always
conflict added when iterating through them in order to set correct conflicts
and the other base has not yet been handled (Fortress is first one so no
other base is handled yet when it's conflicts are set up, and only Ruins is
after Buoy)

> I don't understand why bases claiming territory should be in
> conflict. Shouldn't the base with the highest degree of claiming
> territory use its effect, ignoring the effect of others, but
> keeping the other bases for the other features?

Yes, it was meant to be only temporary solution that territory claiming bases
automatically conflict with each other. To implement it so that lesser
territory claiming bases are ignored takes some work.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16465] Cannot build two bases on one tile

[pepeto]

Follow-up Comment #9, bug #16465 (project freeciv):

> Bases are not conflicting currently in 2.2.2? There is a patch
> to make them so? Why?

The one which *should* be in conflicts in the current behaviour are fortress
and buoys because they both claim territory (I would like to know if this is
not a bug). Other conflicts are a part of the bug I am sure about.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16465] Cannot build two bases on one tile

[pepeto]

Additional Item Attachment, bug #16465 (project freeciv):

File name: trunk_S2_2_ruleset_bases_invalid_read.diff Size:0 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16465] Cannot build two bases on one tile

[pepeto]

Update of bug #16465 (project freeciv):

  Status:None => Need Info  
 Planned Release: => 2.2.3, 2.3.0   

___

Follow-up Comment #8:

> It looks also like a bug that Airbase and Ruins are considered
> as territory claiming, whereas it's not defined like this in the
> default ruleset.

There was a mistake in reading non-initialized base::border_sq. The attached
patch fix that. I don't understand why valgrind didn't report error there.

Now, this fix the behaviour on current default ruleset, but I still not
understand why territory claiming bases should be in conflict, as mentioned
in RT#40502.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16465] Cannot build two bases on one tile

[HanduMan]

Follow-up Comment #7, bug #16465 (project freeciv):

Setting techlevel to 100 is the easiest way, but in  my opinion, a bit
brutal. :P

I use init_techs in a chosen nation's .ruleset:

init_techs="Construction","Radio"




Bases are not conflicting currently in 2.2.2? There is a patch to make them
so? Why? 

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16465] Cannot build two bases on one tile

[pepeto]

Follow-up Comment #6, bug #16465 (project freeciv):

It looks also like a bug that Airbase and Ruins are considered as territory
claiming, whereas it's not defined like this in the default ruleset.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16465] Cannot build two bases on one tile

[pepeto]

Follow-up Comment #5, bug #16465 (project freeciv):

Since RT#40502: [Patch] Conflicting bases from ruleset, at revision 15242,
default ruleset has the following conflicts:
* Fortress is in conflict with Airbase.
* Fortress is in conflict with Buoy.
* Fortress is in conflict with Ruins.
* Buoy is in conflict with Ruins.

I don't understand why bases claiming territory should be in conflict.
Shouldn't the base with the highest degree of claiming territory use its
effect, ignoring the effect of others, but keeping the other bases for the
other features?


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16465] Cannot build two bases on one tile

[pepeto]

Follow-up Comment #4, bug #16465 (project freeciv):

Then, start with:

/set techlevel 100



___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16465] Cannot build two bases on one tile

[Jacob Nevins]

Follow-up Comment #3, bug #16465 (project freeciv):

I mean, when you start the game, your units can build neither fortresses nor
airbases, so reproducing this from a fresh start requiring acquiring the
appropriate techs somehow. Getting to Radio without cheating with the editor
will take a while so I was hoping for a short cut.

I didn't mean to imply that fortresses and airbases are in any way mutually
exclusive.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16465] Cannot build two bases on one tile

[pepeto]

Follow-up Comment #2, bug #16465 (project freeciv):

Fortresses and airbases are not incompatibles in technology. One affects land
units, the other affects air units. I don't understand your comment.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16465] Cannot build two bases on one tile

[Jacob Nevins]

Follow-up Comment #1, bug #16465 (project freeciv):

How do you get to the point where you can build fortresses and airbases? Do
you play through normally, or use the editor to get the appropriate techs?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16465] Cannot build two bases on one tile

[HanduMan]

URL:
  

 Summary: Cannot build two bases on one tile
 Project: Freeciv
Submitted by: handuman
Submitted on: Tuesday 08/17/10 at 07:25
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.2.2
 Discussion Lock: Any
Operating System: Microsoft Windows
 Planned Release: 

___

Details:

This is related to bug #16188

If an airbase is built on a tile that already has a fortress, the fortress
disappears when the airbase is finished and vice versa. This goes only for
games that have not been saved and reloaded. After save-reload it becomes
possible to build both bases on one tile. Also bug #16188 remains unfixed in
a fresh game.

Discussed also in this topic 
on the freeciv forum.

Cannot attach a savegame because the bugs non't survive saving.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev