[Freeciv-Dev] [bug #19821] [metaticket] Numerous issues with wipe_unit() wiping transporter with cargo
Update of bug #19821 (project freeciv): Category:None = general Status:None = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed Planned Release: 2.3.3, 2.4.0, 2.5.0 = 2.3.4, 2.4.0, 2.5.0 ___ Reply to this item at: http://gna.org/bugs/?19821 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19821] [metaticket] Numerous issues with wipe_unit() wiping transporter with cargo
Follow-up Comment #8, bug #19821 (project freeciv): I don't see why a similar issue can't apply to S2_4 (unit_transport_load() vs unit_transport_load_send(), but I didn't notice it in testing. I checked TRUNK, and there client automatically updates also transporter when it receives unit_info for cargo with new transporter. This code should be identical in S2_4. ___ Reply to this item at: http://gna.org/bugs/?19821 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19821] [metaticket] Numerous issues with wipe_unit() wiping transporter with cargo
Follow-up Comment #9, bug #19821 (project freeciv): I checked TRUNK, and there client automatically updates also transporter when it receives unit_info for cargo with new transporter. That works for unit owner, but enemies do not receive unit info for unit hiding inside transporter. 1) Start two clients for two players 2) Place two ships (client A) to same tile, with one of them havign cargo and the other not. 3) Place enemy (client B) ship next to previous ones 4) Both clients see that there's one player A ship with cargo and one without 5) Disband ship with cargo 6) Client A correctly sees that cargo has moved to remaining ship. Client B still sees ship as empty. ___ Reply to this item at: http://gna.org/bugs/?19821 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19821] [metaticket] Numerous issues with wipe_unit() wiping transporter with cargo
Follow-up Comment #10, bug #19821 (project freeciv): #7 is in bug #20454 ___ Reply to this item at: http://gna.org/bugs/?19821 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19821] [metaticket] Numerous issues with wipe_unit() wiping transporter with cargo
Update of bug #19821 (project freeciv): Depends on: = bugs #20454 ___ Reply to this item at: http://gna.org/bugs/?19821 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19821] [metaticket] Numerous issues with wipe_unit() wiping transporter with cargo
Update of bug #19821 (project freeciv): Depends on: = bugs #20221 ___ Reply to this item at: http://gna.org/bugs/?19821 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19821] [metaticket] Numerous issues with wipe_unit() wiping transporter with cargo
Update of bug #19821 (project freeciv): Depends on: = bugs #20301 ___ Reply to this item at: http://gna.org/bugs/?19821 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19821] [metaticket] Numerous issues with wipe_unit() wiping transporter with cargo
Update of bug #19821 (project freeciv): Depends on: = bugs #20442 ___ Reply to this item at: http://gna.org/bugs/?19821 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19821] [metaticket] Numerous issues with wipe_unit() wiping transporter with cargo
Follow-up Comment #6, bug #19821 (project freeciv): It seems that #1 has been fixed a long time ago by bug #19822 ___ Reply to this item at: http://gna.org/bugs/?19821 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19821] [metaticket] Numerous issues with wipe_unit() wiping transporter with cargo
Follow-up Comment #7, bug #19821 (project freeciv): #2 is in bug #20442 ___ Reply to this item at: http://gna.org/bugs/?19821 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19821] [metaticket] Numerous issues with wipe_unit() wiping transporter with cargo
Follow-up Comment #4, bug #19821 (project freeciv): 4) is now bug #20301 concerning all cases where units_lost is not properly increased. ___ Reply to this item at: http://gna.org/bugs/?19821 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19821] [metaticket] Numerous issues with wipe_unit() wiping transporter with cargo
Follow-up Comment #2, bug #19821 (project freeciv): I believe issues 3, 4, 5, 6 apply on S2_3 as well. - 5 6 were handled in bug #19823 - 3 is potentially disasterous for custom modpack (e.g., victory condition going unnoticed) - 4 Nasty, but hard to fix. Is this regression relative to what version? (I assume it has been like this for as long as units killed counting has existed) ___ Reply to this item at: http://gna.org/bugs/?19821 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19821] [metaticket] Numerous issues with wipe_unit() wiping transporter with cargo
Follow-up Comment #3, bug #19821 (project freeciv): 3 is now bug #20221 concerning all cases where unit is lost without signal being emitted. ___ Reply to this item at: http://gna.org/bugs/?19821 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19821] [metaticket] Numerous issues with wipe_unit() wiping transporter with cargo
Update of bug #19821 (project freeciv): Summary: Numerous issues with wipe_unit() wiping transporter with cargo = [metaticket] Numerous issues with wipe_unit() wiping transporter with cargo ___ Reply to this item at: http://gna.org/bugs/?19821 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19821] [metaticket] Numerous issues with wipe_unit() wiping transporter with cargo
Follow-up Comment #1, bug #19821 (project freeciv): 7. On S2_3, wipe_unit() moving a unit to another transporter doesn't cause the client to be updated -- transporter still looks empty. I suspect that it's due to put_unit_onto_transporter() not doing send_unit_info() for the new transporter (unlike load_unit_onto_transporter()). (I suspect a similar issue applies to the other emergency loading, player_restore_units()' aircraft rescue.) I don't see why a similar issue can't apply to S2_4 (unit_transport_load() vs unit_transport_load_send(), but I didn't notice it in testing. ___ Reply to this item at: http://gna.org/bugs/?19821 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
