[Freeciv-Dev] [bug #20544] Sea units benefitting from City Walls

2013-03-10 Thread Marko Lindqvist
Update of bug #20544 (project freeciv):

  Status:  Ready For Test = Fixed  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?20544

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20544] Sea units benefitting from City Walls

2013-03-06 Thread Marko Lindqvist
Follow-up Comment #4, bug #20544 (project freeciv):

- Some comment typos fixed 

(file #17402)
___

Additional Item Attachment:

File name: NonNatDefPct-2.patch   Size:9 KB


___

Reply to this item at:

  http://gna.org/bugs/?20544

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20544] Sea units benefitting from City Walls

2013-03-01 Thread Marko Lindqvist
Update of bug #20544 (project freeciv):

Category:None = general
  Status:None = Ready For Test 
 Planned Release: = 2.5.0  

___

Follow-up Comment #3:

Attached patch adds unit class property non_native_def_pct, defaulting to
100%. Units defending on non-native terrain (ships in harbour in classic
rulesets) get only that percentage of their defense power applied.

(file #17381)
___

Additional Item Attachment:

File name: NonNatDefPct.patch Size:9 KB


___

Reply to this item at:

  http://gna.org/bugs/?20544

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20544] Sea units benefitting from City Walls

2013-02-20 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?20544

 Summary: Sea units benefitting from City Walls
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 20 Feb 2013 05:16:57 PM EET
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

Old bug (was discussed in RT age, but I found not ticket from gna). As only
one unit can be used as effect requirement, and that's attacking unit in case
of defense bonus effect, it doesn't matter what unit is the defending one.
This means that ships in harbour get benefit from city walls when land unit
attacks. This might be bug in our default rulesets (civ2 ruleset), but the
worst part is that you cannot create ruleset where this is not true. With the
defense values and hitpoints of the sea units, they are often the best city
defenders available despite BadCityDefender (Pearl Harbor) flag when they get
the same City Walls bonus land unit defenders get.




___

Reply to this item at:

  http://gna.org/bugs/?20544

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20544] Sea units benefitting from City Walls

2013-02-20 Thread David Lowe
Follow-up Comment #1, bug #20544 (project freeciv):

I haven't actually surveyed layouts of real life cities for this, but it seems
reasonable that in many cases the wall might well be built right to the
water's edge.  So if a ship in a harbor gets attacked by infantry, it could
well be behind a wall.

Surely the routine that finds a city's defender takes BadCityDefender into
account [i'm not finding it right now]?  Perhaps BadCityDefender should modify
the Defense value and/or Hitpoints alongside the Attack value.  When a unit is
not in their natural element [a ship in dock or a plane on the ground] they
should be considered essentially defenseless and automatically eliminated,
IMHO.

Anyway, to me that was the lesson of Pearl Harbor.

___

Reply to this item at:

  http://gna.org/bugs/?20544

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20544] Sea units benefitting from City Walls

2013-02-20 Thread Marko Lindqvist
Follow-up Comment #2, bug #20544 (project freeciv):

 When a unit is not in their natural element [a ship in dock or a
 plane on the ground] they should be considered essentially
 defenseless and automatically eliminated, IMHO.

Yes, from realism point of view it doesn't make sense that ship in the harbour
manages to defend entire city against attack from inland. Maybe it's the crew
acting as infantry up in the mountains?

BadCityDefender turned out to be much less severe modification than I had
thought. It just reduces defender firepower to 1 (that has no effect until
ships are so powerful that they have greater firepower to begin with) and
doubles attacker firepower.

___

Reply to this item at:

  http://gna.org/bugs/?20544

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev