[Freeciv-Dev] [bug #17441] Upgrading unit level will eliminate their production

[HanduMan]

Follow-up Comment #1, bug #17441 (project freeciv):

This should be classified higher on severity since it makes the game almost
unplayable on multiplayer.

This seems to happen when player has aquired a new tech which makes a unit
obsolete, and there are those now obsolete units being built in cities in such
state that they will be finished on the nex turn change. On new turn, the game
upgrades the production but looses the unit totally.

In the example below, player had just researched Exposives and there were
Workers being built in city of Jammu. The player bought the production to be
ready for next turn. The next item in Jammu production list was Barracks,
which also was already obsoleted by Gunpowder. On turn change the produtcion
of Workers was upgraded to Engineers but also discarded without any
explanation. The city just moved on in the production list and started the
Barracks, upgraded it to Barracks II and is now building that. There's no sign
of a Worker nor Engineer in Jammu.


[10:50:56] You bought Workers in Jammu.
[11:00:18] Production of Workers is upgraded to Engineers in Jammu.
[11:00:18] Production of Barracks(O) is upgraded to Barracks II in Jammu.
[11:00:18] Jammu is building Barracks II from the worklist.


There is something wrong in the turn andvance mechanics at least in relation
to upgrading/finishing production. It should be fixed. But a simple way to fix
this bug would be to make aquiring a new techonolgy trigger the upgrading
process for all units that were made obsolete by that tech. 
 
There is a workaround for this, of course. Just upgrade the production
yourself before klicking on Turn Done. But you need to remember to check if
you need to do so. And there's no '(o)' displayed in obsolete unit names as
there is for buildings.

Also refer to bug #14473.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18736] building unit is skipped when replaced in same round

[HanduMan]

Follow-up Comment #3, bug #18736 (project freeciv):

OK, this one seems more active than the other (bug #17441) I searched with
'upgrade'...

Verified this as explained with bug #17441.

To fix, trigger production upgrade when new tech is received. Thus, player
cannot buy obsolete units. Or if fixing the mechanics itself, production
should continue from the amount of shields that were achieved prior to
upgrade, bought or otherwise.


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19160] in player_load_units_transporter() [savegame.c::2285]: assertion 'id_trans == -1 || ptrans != ((void *)0)' failed

[Matthias Pfafferodt]

Follow-up Comment #1, bug #19160 (project freeciv):

svn r20638 blongs to bug #18975. I will look into this!

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19160] in player_load_units_transporter() [savegame.c::2285]: assertion 'id_trans == -1 || ptrans != ((void *)0)' failed

[Jacob Nevins]

Follow-up Comment #2, bug #19160 (project freeciv):

I didn't mean to imply that r20638 is the first version that behaves like
this -- it just happens to be what I have checked out.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [task #7334] Make copy of gtk2-client as base for gtk3-client development

[Jacob Nevins]

Follow-up Comment #11, task #7334 (project freeciv):

The Gtk3 client is still classified as "In-development [...] not yet ready
for general use" by configure. However, patch #3042 made it selectable by
default. Do we want to change its labelling for 2.4.0?

I still haven't built it myself, but the main remaining issue I noticed from
tickets going by is the lack of a theme (cf patch #3050).

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19009] gtk3-client does not show what city is building

[Jacob Nevins]

Update of bug #19009 (project freeciv):

 Planned Release: => 2.4.0,2.5.0

___

Follow-up Comment #3:

Since the Gtk3 client is selectable by configure on S2_4, I assume we want to
try to fix this.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18196] gtk2-client -> gtk3-client settings migration

[Jacob Nevins]

Update of bug #18196 (project freeciv):

 Planned Release: => 2.4.0,2.5.0


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [task #7334] Make copy of gtk2-client as base for gtk3-client development

[Jacob Nevins]

Follow-up Comment #12, task #7334 (project freeciv):

We also need to decide which Gtk our official Windows packages will use... I
guess that's partly up to cproc.
Making it Gtk3 will get that version lots of testing :)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19166] README.fcdb needs work

[Jacob Nevins]

URL:
  

 Summary: README.fcdb needs work
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat Dec 10 22:36:39 2011
Category: docs
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.4.0,2.5.0

___

Details:

> the database backend is activated with the command line option 
> '--Database FILE', where FILE is a lua script containing the 
> needed functions
In fact the file supplied to --Database is a secfile containing details of
the database to use. The format of this needs documenting here. (As far as I
can tell, the Lua file referred to is hardcoded to be "database.lua" somewhere
in the path.)

For reference, here's the file I use, having reverse-engineered the format
from the source (carefully crafted to work with S2_3 and S2_4):


# for S2_3/S2_2
[auth]
host="localhost"
port="3306"
database="freeciv"
user="freecivadmin"
password="XXX"
table="auth"
login_table="loginlog"

# for trunk (2.4.x)
[fcdb]
host="localhost"
port="3306"
database="freeciv"
user="freecivadmin"
password="XXX"
table_user="auth"
table_log="loginlog"


It would be nice to document the S2_3 format too (on that branch), but S2_4
is the future, of course.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19167] Corrections to freeciv-server man page

[Jacob Nevins]

URL:
  

 Summary: Corrections to freeciv-server man page
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat Dec 10 22:39:38 2011
Category: docs
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.3.2,2.4.0,2.5.0

___

Details:

The man page had drifted out of date in various regards.

Other changes:
* mention "--scenarios" option in server's "--help"
* (trunk/S2_4) add README.fcdb to distribution

Note that the trunk/S2_4 man page makes promises that are not yet kept:
README.fcdb doesn't yet tell you what to put in the --Database file. Bug
#19166. (S2_3 is silent on what you're supposed to put in the --auth file,
which is similar but not documented on that branch.)




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19167] Corrections to freeciv-server man page

[Jacob Nevins]

Update of bug #19167 (project freeciv):

  Status: In Progress => Ready For Test 

___

Additional Item Attachment:

File name: trunk-S2_4-server-manpage.diff Size:9 KB
File name: S2_3-server-manpage.diff   Size:7 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19167] Corrections to freeciv-server man page

[Marko Lindqvist]

Update of bug #19167 (project freeciv):

  Status:  Ready For Test => In Progress

___

Follow-up Comment #1:

> S2_3 is silent on what you're supposed to put in the --auth
> file, which is similar but not documented on that branch.

Typical user should setup it automatically with setup_auth_server.sh -script,
so this is not a critical omission.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19167] Corrections to freeciv-server man page

[Jacob Nevins]

Follow-up Comment #2, bug #19167 (project freeciv):

> Typical user should setup it automatically with 
> setup_auth_server.sh -script, so this is not a critical 
> omission.
Oh, you're kidding me... the existence of that script has somehow eluded me
until now. I was even looking in the scripts/ directory earlier today. Derp!

OK, new task needed: update that script for the fcdb world. I'll morph the
other bug to include that.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19166] README.fcdb and setup_auth_server.sh need work

[Jacob Nevins]

Update of bug #19166 (project freeciv):

 Summary:  README.fcdb needs work => README.fcdb and
setup_auth_server.sh need work

___

Follow-up Comment #1:

Marko just pointed out setup_auth_server.sh, which I'd somehow missed up
until now.

Historically that has lessened the need for documentation, but it's out of
date now -- it still creates an [auth] section rather than an [fcdb] section.

It's not clear how far this script can go:
* It's MySQL-specific, and goes as far as connecting to the database server.
We now have three database backends. Should it support all of them?
** Our current database.lua only supports MySQL, mind.
* The desired shape of the table in principle depends on database.lua -- I
guess that can be hacked by server operators to e.g. add extra columns. I
suppose anyone doing this can be assumed to know what they're doing.

At a minimum, the script should continue to deliver what it presumably always
has -- a working setup with a MySQL server and the default configuration
(standard database.lua).

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19167] Corrections to freeciv-server man page

[Jacob Nevins]

Additional Item Attachment, bug #19167 (project freeciv):

File name: trunk-S2_4-server-manpage-bis.diff Size:12 KB
File name: S2_3-server-manpage-bis.diff   Size:11 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19167] Corrections to freeciv-server man page

[Jacob Nevins]

Update of bug #19167 (project freeciv):

  Status: In Progress => Ready For Test 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3065] Option to use system luasql?

[Jacob Nevins]

URL:
  

 Summary: Option to use system luasql?
 Project: Freeciv
Submitted by: jtn
Submitted on: Sun Dec 11 00:53:58 2011
Category: None
Priority: 3 - Low
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

We already have an option to use the system Lua rather than the in-tree one,
as of patch #2747. See that ticket for discussion of the pros and cons.

Should we do the same for luasql?

Some downstream distributions, such as Debian, like to avoid embedded code
copies for reasons such as propagating security updates (policy
). So
they'll probably implement this anyway even if we don't (assuming they enable
auth at all).




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19168] mapimg automatic save dumps images in current directory

[Jacob Nevins]

URL:
  

 Summary: mapimg automatic save dumps images in current
directory
 Project: Freeciv
Submitted by: jtn
Submitted on: Sun Dec 11 00:58:26 2011
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.4.0,2.5.0

___

Details:

Follow-on from patch #1391 comment 24
:

The images saved automatically after using the "mapimg" server command are
currently saved in the working directory.

We could make the image directory seperately configurable, but personally I
think saving to the same location as autosave files would be entirely
sufficient, and should be easy enough.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19169] Adjacent/CAdjacent range erroneously permitted for various universal

[Jacob Nevins]

URL:
  

 Summary: Adjacent/CAdjacent range erroneously permitted for
various universal
 Project: Freeciv
Submitted by: jtn
Submitted on: Sun Dec 11 01:15:14 2011
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.4.0,2.5.0

___

Details:

Bug #18551 implemented the Adjacent/CAdjacent range for the CityTile
universal; however, in req_from_str(), this was added at the end of a bunch of
case fallthroughs, and the other universals still don't support these ranges.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19169] Adjacent/CAdjacent range erroneously permitted for various universals

[Jacob Nevins]

Update of bug #19169 (project freeciv):

  Status: In Progress => Ready For Test 
 Summary: Adjacent/CAdjacent range erroneously permitted for
various universal => Adjacent/CAdjacent range erroneously permitted for
various universals

___

Follow-up Comment #1:

Untested patch attached.

(file #14687)
___

Additional Item Attachment:

File name: trunk-S2_4-adjacent-vs-universals.diff Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19170] multiplayer/default.lua is identical to default/default.lua

[Jacob Nevins]

URL:
  

 Summary: multiplayer/default.lua is identical to
default/default.lua
 Project: Freeciv
Submitted by: jtn
Submitted on: Sun Dec 11 02:14:31 2011
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: 2.3.1
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.3.2,2.4.0,2.5.0

___

Details:

...and the later says not to fork it unless necessary. So I propose to delete
multiplayer/default.lua.

(On trunk/S2_4, the two have diverged needlessly due to patch #2955, where
barbarians-in-huts were changed to take account of the "barbarians" server
setting.)




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19171] If barbarians disabled, popping a hut can do absolutely nothing

[Jacob Nevins]

URL:
  

 Summary: If barbarians disabled, popping a hut can do
absolutely nothing
 Project: Freeciv
Submitted by: jtn
Submitted on: Sun Dec 11 02:14:40 2011
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.4.0,2.5.0

___

Details:

No message, just nothing. This came in in patch #2955

Attached script patch changes it to "An abandoned village is here", as when
close to a city or using a gameloss unit.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19170] multiplayer/default.lua is identical to default/default.lua

[Jacob Nevins]

Update of bug #19170 (project freeciv):

  Status: In Progress => Ready For Test 

___

Additional Item Attachment:

File name: trunk-S2_4-rm-multiplayer-default-lua.diff Size:6 KB
File name: S2_3-rm-multiplayer-default-lua.diff Size:6 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19171] If barbarians disabled, popping a hut can do absolutely nothing

[Jacob Nevins]

Update of bug #19171 (project freeciv):

  Status: In Progress => Ready For Test 

___

Additional Item Attachment:

File name: trunk-S2_4-hut-no-barbarians-msg.diff Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev