Re: [Freeipa-devel] [python-pytest-multihost]-Ticket-6 run_command produces exit code 1 on windows

[Petr Viktorin]

On 04/23/2016 02:21 AM, Niranjan wrote:
> Petr Viktorin wrote:
>> On 04/21/2016 03:04 PM, Niranjan wrote:
>>> Petr Viktorin wrote:
 On 04/21/2016 07:25 AM, Niranjan wrote:
> Petr Viktorin wrote:
>> On 04/20/2016 06:11 AM, Niranjan wrote:
>>> Petr Viktorin wrote:
 On 04/18/2016 12:39 PM, Niranjan wrote:
> Niranjan wrote:
>> Niranjan wrote:
>>> Petr Viktorin wrote:
 On 04/06/2016 10:55 AM, Niranjan wrote:
> Greetings,
>
> For https://fedorahosted.org/python-pytest-multihost/ticket/6 , i 
> have proposed
> a patch, I think this patch is more of a workaround , than a 
> solution. I would
> like to get more inputs on how to use pytest-multihost to execute 
> commands 
> on Windows. The method i am using requires cygwin with 
> openssh/bash to be
> installed. 

>> [...]

 If this works for you, I'll commit it and release.
>>>
>>> With this latest patch it worked after removing the line "transport_class =
>>> transport.SSHTransport" from QeBaseHost class. 
>>>
>>> Please go ahead and commit it.
>>
>> I've commited it and released version 1.1. Packages for Fedora Rawhide
>> are being built; if you need this for older Fedoras let me know so I
>> don't forget to build there too.
> No for fedora it's fine, but mostly we are using this in RHEL7, so if you
> can build it for epel7 it would be great, else it's fine, i will build
> this for RHEL7, i intend to use this for sssd functional testing.

I'll leave the RHEL version to you.

> Also i tried to pull the latest from python-pytest-multihost.git from
> git.fedoraproject.org, i could not see it merged. 

My mistake. It should be fixed now.



-- 
Petr Viktorin

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [PATCH 0100-0101] ipa-nis-manage: fix nits in manual page

[Petr Spacek]

Hello,

ipa-nis-manage: mention return code 3 in man page

ipa-nis-manage: Replace text references to compat plugin with NIS

-- 
Petr^2 Spacek
From 289d96e11925c42338c897889ad39c0d2f68f109 Mon Sep 17 00:00:00 2001
From: Petr Spacek 
Date: Mon, 25 Apr 2016 16:33:42 +0200
Subject: [PATCH] ipa-nis-manage: Replace text references to compat plugin with
 NIS

---
 install/tools/man/ipa-nis-manage.1 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/install/tools/man/ipa-nis-manage.1 b/install/tools/man/ipa-nis-manage.1
index fa02cfc76fa6bd076ebddde702036fa0b36f1413..bd29fee103e31a41307f6a4ef6b0ceb1b137a170 100644
--- a/install/tools/man/ipa-nis-manage.1
+++ b/install/tools/man/ipa-nis-manage.1
@@ -16,15 +16,15 @@
 .\"
 .\" Author: Rob Crittenden 
 .\"
-.TH "ipa-nis-manage" "1" "May 6 2009" "FreeIPA" "FreeIPA Manual Pages"
+.TH "ipa-nis-manage" "1" "April 25 2016" "FreeIPA" "FreeIPA Manual Pages"
 .SH "NAME"
 ipa\-nis\-manage \- Enables or disables the NIS listener plugin
 .SH "SYNOPSIS"
 ipa\-nis\-manage [options] 
 .SH "DESCRIPTION"
 Run the command with the \fBenable\fR option to enable the NIS plugin.
 
-Run the command with the \fBdisable\fR option to disable the compat plugin.
+Run the command with the \fBdisable\fR option to disable the NIS plugin.
 
 In both cases the user will be prompted to provide the Directory Manager's password unless option \fB\-y\fR is used.
 
-- 
2.5.5

From 34291d00f5ceb7e61f98daacf9958aeef0ec41e9 Mon Sep 17 00:00:00 2001
From: Petr Spacek 
Date: Mon, 25 Apr 2016 16:52:48 +0200
Subject: [PATCH] ipa-nis-manage: mention return code 3 in man page

---
 install/tools/man/ipa-nis-manage.1 | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/install/tools/man/ipa-nis-manage.1 b/install/tools/man/ipa-nis-manage.1
index bd29fee103e31a41307f6a4ef6b0ceb1b137a170..d60fda788fb7b97d6fa97544f63f346eb13e956a 100644
--- a/install/tools/man/ipa-nis-manage.1
+++ b/install/tools/man/ipa-nis-manage.1
@@ -43,3 +43,5 @@ File containing the Directory Manager password
 1 if an error occurred
 
 2 if the plugin is already in the required status (enabled or disabled)
+
+3 if RPC services cannot be enabled.
-- 
2.5.5

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [PATCH 0099] ipa-nis-manage: add status option

[Petr Spacek]

Hello,

ipa-nis-manage: add status option

https://bugzilla.redhat.com/show_bug.cgi?id=1329275

-- 
Petr^2 Spacek
From abbc34feb5b360694c9afc94fd75a9b0dbb5ab7f Mon Sep 17 00:00:00 2001
From: Petr Spacek 
Date: Mon, 25 Apr 2016 16:56:08 +0200
Subject: [PATCH] ipa-nis-manage: add status option

https://bugzilla.redhat.com/show_bug.cgi?id=1329275
---
 install/tools/ipa-nis-manage   | 20 +---
 install/tools/man/ipa-nis-manage.1 |  8 ++--
 2 files changed, 23 insertions(+), 5 deletions(-)

diff --git a/install/tools/ipa-nis-manage b/install/tools/ipa-nis-manage
index 3aa1507b205eaa679edebda2a3705b494369abc3..ac21e65df8b7c7e064315c2944869ff9ee8ab3bc 100755
--- a/install/tools/ipa-nis-manage
+++ b/install/tools/ipa-nis-manage
@@ -47,7 +47,7 @@ nis_config_dn = DN(('cn', 'NIS Server'), ('cn', 'plugins'), ('cn', 'config'))
 compat_dn = DN(('cn', 'Schema Compatibility'), ('cn', 'plugins'), ('cn', 'config'))
 
 def parse_options():
-usage = "%prog [options] \n"
+usage = "%prog [options] \n"
 usage += "%prog [options]\n"
 parser = OptionParser(usage=usage, formatter=config.IPAFormatter())
 
@@ -97,7 +97,7 @@ def main():
 
 if len(args) != 1:
 sys.exit("You must specify one action, either enable or disable")
-elif args[0] != "enable" and args[0] != "disable":
+elif args[0] != "enable" and args[0] != "disable" and args[0] != "status":
 sys.exit("Unrecognized action [" + args[0] + "]")
 
 standard_logging_setup(None, debug=options.debug)
@@ -187,11 +187,25 @@ def main():
 print(lde)
 retval = 1
 
+elif args[0] == "status":
+nis_entry = get_entry(nis_config_dn, conn)
+enabled = (nis_entry and
+   nis_entry.get(
+   'nsslapd-pluginenabled', '')[0].lower() == "on")
+if enabled:
+print("Plugin is enabled")
+retval = 0
+else:
+print("Plugin is not enabled")
+retval = 4
+
 else:
 retval = 1
 
 if retval == 0:
-print("This setting will not take effect until you restart Directory Server.")
+if args[0] in {"enable", "disable"}:
+print("This setting will not take effect until you restart "
+  "Directory Server.")
 
 if args[0] == "enable":
 print("The %s service may need to be started." % servicemsg)
diff --git a/install/tools/man/ipa-nis-manage.1 b/install/tools/man/ipa-nis-manage.1
index d60fda788fb7b97d6fa97544f63f346eb13e956a..93278487c1adb50f4ae49804d0214841e2bef30c 100644
--- a/install/tools/man/ipa-nis-manage.1
+++ b/install/tools/man/ipa-nis-manage.1
@@ -20,13 +20,15 @@
 .SH "NAME"
 ipa\-nis\-manage \- Enables or disables the NIS listener plugin
 .SH "SYNOPSIS"
-ipa\-nis\-manage [options] 
+ipa\-nis\-manage [options] 
 .SH "DESCRIPTION"
 Run the command with the \fBenable\fR option to enable the NIS plugin.
 
 Run the command with the \fBdisable\fR option to disable the NIS plugin.
 
-In both cases the user will be prompted to provide the Directory Manager's password unless option \fB\-y\fR is used.
+Run the command with the \fBstatus\fR option to read status of the NIS plugin. Return code 0 indicates enabled plugin, return code 4 indicates disabled plugin.
+
+In all cases the user will be prompted to provide the Directory Manager's password unless option \fB\-y\fR is used.
 
 Directory Server will need to be restarted after the NIS listener plugin has been enabled.
 
@@ -45,3 +47,5 @@ File containing the Directory Manager password
 2 if the plugin is already in the required status (enabled or disabled)
 
 3 if RPC services cannot be enabled.
+
+4 if status command detected plugin in disabled state.
-- 
2.5.5

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] Possble FreeIPA Trac Malicious Link

[Gabe Alford]

Hey all,

This is something we may need to watch for. I noticed that a possible
malicious link was added to the FreeIPA Trac start page. You can view it
here: https://fedorahosted.org/freeipa/wiki/WikiStart?action=diff=22.
I changed it back to the original text before the change. I know that the
389 Trac webpage had issues earlier this year with spam. Just an FYI.

Gabe
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] URI in HBAC

[Lukáš Hellebrandt]

http://www.freeipa.org/page/V4/URI-based_HBAC

I have made some important changes to the design document of this
proposed feature. The difference is mainly changing regular expression
interpretation of URI to longest-prefix matching.

This change was done mainly because of upstream's reactions. I value any
further comments and particularly discussion about the two topics
mentioned at the end of the design page:

* For backwards compatibility, lack of URI in request means any URI is
matched (as described in the design document). Is it a good idea? Any
other solution?

* How about multiple URI's in one HBAC rule? Is it a good idea? How to
interpret combinations of host+scheme+port (one field) and URI paths
(another field) in that case?

-- 
Lukas Hellebrandt
Associate Quality Engineer
lhell...@redhat.com

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [patch 0037] spec: Add python-sssdconfig dependency for python-ipatests package

[Martin Babinsky]

On 04/25/2016 09:59 AM, Milan Kubík wrote:

On 04/25/2016 09:36 AM, Martin Babinsky wrote:

On 04/23/2016 12:13 AM, Milan Kubík wrote:

https://fedorahosted.org/freeipa/ticket/5843

Applies to ipa-4-3, master

--
Milan Kubik





Hi Milan,

the dependency on python-sssdconfig was introduced by my fix to
https://fedorahosted.org/freeipa/ticket/5625 (I know, shame) which
also landed in ipa-4-2, so you'll need to send a patch also for this
branch (the current one obviously does not apply).

Also in ipa-4-3 and master patch you should require python3-sssdconfig
for python3-ipatests.


Good catch, thanks.
Fixed in new patches.

--
Milan Kubik


Thanks, ACK.

--
Martin^3 Babinsky

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [DESIGN REVIEW] V4/Manage_replication_topology_4_4

[Martin Babinsky]

Hi list,

this is my review of the 
http://www.freeipa.org/page/V4/Manage_replication_topology_4_4 design 
page authored by Petr Vobornik.


Overall the page needs some more polishing, there is a number of TODOs 
and typos which need to be expanded/fixed.


Here are some more specific points:

1.) there is a lengthy discussion about the interface and behavior of 
server-del API command on this list.[1] The server_del description 
should be updated to reflect the conclusion reached by this discussion.


2.) we should also put more thought into actions which should be 
performed by `server-del` regarding cleanup of leftover references to 
replica's ldap/ and HTTP/ principals and DNS records.


The thing is that the original code assumes that the cleanup is 
performed under admin/Directory Manager credentials, while we should 
assume that most of these tasks should be doable by host itself (see 
server uninstall use-case). I shall make some more research into this.


3.) I would rewrite Topology graph section in Feature management because 
the current text is not very readable. Also is there a plan to show 
roles of an IPA master when clicking on it on the graph or is it a 
stretch for 4.4?


[1] https://www.redhat.com/archives/freeipa-devel/2016-April/msg00101.html

--
Martin^3 Babinsky

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [PATCH] Added warning to user for Internet Explorer

[Abhijeet Kasurde]

Hi All,

Please review the attached patch.

Thanks,
Abhijeet Kasurde
From 86eac1c78f1f754f6e31f8d794e89ac5b50d64d3 Mon Sep 17 00:00:00 2001
From: Abhijeet Kasurde 
Date: Mon, 25 Apr 2016 16:23:33 +0530
Subject: [PATCH] Added warning to user for Internet Explorer

As Internet Explorer is not supported browser, browser Kerberos
configuration page shows warning to user about the same.

Fixes : https://fedorahosted.org/freeipa/ticket/5656

Signed-off-by: Abhijeet Kasurde 
---
 install/html/ssbrowser.html | 1 +
 1 file changed, 1 insertion(+)

diff --git a/install/html/ssbrowser.html b/install/html/ssbrowser.html
index 325c2d393067c52fade653494c1917a9af51394f..cdd61d0b492f68f47b6e70c2252ad61297febb79 100644
--- a/install/html/ssbrowser.html
+++ b/install/html/ssbrowser.html
@@ -122,6 +122,7 @@
 
 
 Internet Explorer
+WARNING: Internet Explorer is no longer supported browser.
 
 Once you are able to log into the workstation with your kerberos key you are now able to use that ticket in Internet Explorer.
 
-- 
2.4.11

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0024] ipa-replica-manage: added --suffix option for certain commands

[Stanislav Laznicka]

On 04/22/2016 05:15 PM, Stanislav Laznicka wrote:

On 04/22/2016 01:13 PM, Martin Basti wrote:



On 15.04.2016 14:30, Stanislav Laznicka wrote:

On 04/13/2016 01:40 PM, Martin Basti wrote:



On 06.04.2016 14:04, Stanislav Laznicka wrote:

On 03/30/2016 04:52 PM, Martin Basti wrote:

On 24.03.2016 19:10, Stanislav Laznicka wrote:

On 03/23/2016 08:13 PM, Martin Basti wrote:

[...]
Can you please update design
http://www.freeipa.org/page/V4/Manage_replication_topology_4_4 
(mainly
the --suffix option)? Also there are missing clean-ruv and 
list-ruv

commands in design, and fix usage at the bottom.

1)
I don't understand this expression
+if dirman_passwd is None or (
+   not dirman_passwd and args[0] in 
cs_enabled_commands):


You already tested if subcommand belongs to cs_enabled_commands 
few
lines above, IMO the 'dirman_password is None' expression is 
enough.
If I understand it well, when empty password is entered, the 
program continues and uses Kerberos credentials for some 
operations. E.g. for list-ruv, if empty password is entered, the 
command would only display RUVs for domain tree but not for the 
CA tree no matter if CA is set up or not (in the current state 
of the patch, after get_ruv refactoring). This here is one 
possible way around this, although the check for non-empty 
password might probably just as well be in get_ruv_both_suffixes.


ok

2)
+# tuple of commands that work with ca tree and need Directory 
Manager

password
+cs_enabled_commands = ("list-ruv", "clean-ruv", 
"abort-clean-ruv")


this variable is used only toi detect if dirman passwd is 
needed, I
suggest to rename it to commands_req_dirman_passwd, or 
something better.


3)
Q: Do we need is_cs_set() function?
A: Yes!

I wanted to give you ultimate NACK, but then I checked how 
get_ruv code

works and I changed my mind.

Please write a comment where is_cs_set function is used, why we 
need
extra function instead of catching an exception, possibly you 
can open a

refactoring ticket.
After the refactoring changes, is_cs_set should not be needed 
anymore, removed it.


Shame:
1)
+if not test_connection(realm, host, options.nolookup) or\
Please use parentheses instead of backslash

2)
+   args[0] in cs_enabled_commands:

+   not dirman_passwd and args[0] in 
cs_enabled_commands):


Indentation is not multiplication of 4

Shame on me indeed, fixed it.


Nitpicks (I don't insist on fixing these):
1)
+if servers.get('ca', None):

None is default

2)
+for (netloc, rid) in servers['ca']:
parentheses are not needed

3)
+ print("\t%s: %s" % (netloc, rid))
Would be nice to use .format() instead of %

Martin^2



I changed my mind, ultimate NACK.
Please fix get_ruv function, is_cs_set will not help. In case 
there are no RUVs but CA is installed, sys.exit there prevents 
us from removing RUVs (or any else operation) on domain suffix, 
and vice versa.
I propose to move ticket to 4.4 milestone because I would like 
to avoid breaking something in 4.3, as this will hit many 
places in ipa-replica-manage.


Please provide the refactoring of get_ruv as separate patch a 
put these patches on top of it.


Martin2
Did the refactoring. There also seemed to be duplicit code in 
abort_clean_ruv for some reason, removed it (I hope it does not 
break anything, but it seemed rather useless). Also had to 
change the numbers of the patches so that they would apply.


NACK

* ipa-replica-manage refactoring *

1)
Instead of:
-print("Failed to connect to server %s: %s" % (host, e))
-sys.exit(1)
+root_logger.debug("Failed to connect to server {host}: 
{err}"

+  .format(host=host, err=e))
+raise RuntimeError(e)

I expected

-print("Failed to connect to server %s: %s" % (host, e))
-sys.exit(1)
+root_logger.debug(traceback.format_exc())
+raise RuntimeError("Failed to connect to server {host}: 
{err}"

+ .format(host=host, err=e)))

Should be fixed now.


2)
-print("No RUV records found.")
-sys.exit(0)

Here is exit state 0, so we should not raise error.

I think that we should create new nonfatal exception.
Made a new nonfatal error exception, then. This step was a bit 
controversial when it comes to get_ruv_both_suffixes because it 
needs to catch both this new exception and a RuntimeError 
exception for both trees. As the main idea here was not to stop if 
either tree is missing (resulting in RuntimeError in get_ruv) or 
contains no records (NonFatalError), it is only printed that 
something bad may have happened (or it's debug-logged in case of 
nonfatal errors). In the end, only NonFatalError exception is 
raised if no records were found for whatever reason resulting in 
the script always returning 0.


3)
-print("unable to decode: %s" % ruv)
+root_logger.debug("unable to decode: %s" % ruv)
This may break tests, because the logger logs to stderr, leave it 

Re: [Freeipa-devel] [PATCH 0097-0098] Makefile: replace perl with sed

[Lukas Slebodnik]

On (25/04/16 09:59), Jan Cholasta wrote:
>On 25.4.2016 09:34, Petr Spacek wrote:
>> On 25.4.2016 09:29, Lukas Slebodnik wrote:
>> > On (25/04/16 07:23), Jan Cholasta wrote:
>> > > Hi,
>> > > 
>> > > On 22.4.2016 13:29, Petr Spacek wrote:
>> > > > Hello,
>> > > > 
>> > > > Makefile: add sed to BuildRequires
>> > > > 
>> > > > It was requried since forever but we did not explicitly mention it.
>> > > 
>> > > IIRC sed is part of the minimum build environemnt and as such should not 
>> > > be
>> > > explicitly required in the spec file. I personally don't care, but this 
>> > > is
>> > > the likely reason why it wan't there from the beginning.
>> > > 
>> > +1
>> > 
>> > It is part of group "@buildsys-build".
>> > and fedora packaging guidelines does not recommend to list
>> > packages from this group in BuildRequires.
>> 
>> I consider this piece of Fedora guidelines brain-dead as "explicit is better
>> than implicit". Anyway, feel free to NACK it so the status of the patch is
>> clear and this thread can die. I do not insist on it.
>
>I can't find it in the guidelines anymore, so LGTM.
>
It seems that it was changed since I read it last time.

There is vague description of which packages should be there.
http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_2
   It is important that your package list all necessary build dependencies
   using the BuildRequires?:
   tag. You may assume that enough of an environment exists for RPM to function
   and execute basic shell scripts, but you should not assume any other packages
   are present as RPM dependencies and anything brought into the buildroot
   by the build system may change over time.

But utility fedora-review still complains if you list packages from group
"@buildsys-build"

LS

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [patch 0037] spec: Add python-sssdconfig dependency for python-ipatests package

[Milan Kubík]

On 04/25/2016 09:36 AM, Martin Babinsky wrote:

On 04/23/2016 12:13 AM, Milan Kubík wrote:

https://fedorahosted.org/freeipa/ticket/5843

Applies to ipa-4-3, master

--
Milan Kubik





Hi Milan,

the dependency on python-sssdconfig was introduced by my fix to 
https://fedorahosted.org/freeipa/ticket/5625 (I know, shame) which 
also landed in ipa-4-2, so you'll need to send a patch also for this 
branch (the current one obviously does not apply).


Also in ipa-4-3 and master patch you should require python3-sssdconfig 
for python3-ipatests.



Good catch, thanks.
Fixed in new patches.

--
Milan Kubik

From a93217ae0b4db941622ac28875b10d7a37cfc520 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Milan=20Kub=C3=ADk?= 
Date: Fri, 22 Apr 2016 23:43:47 +0200
Subject: [PATCH] spec: Add python-sssdconfig dependency for python-ipatests
 package

https://fedorahosted.org/freeipa/ticket/5843
---
 freeipa.spec.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/freeipa.spec.in b/freeipa.spec.in
index aaa40cc9a2246ed1d244e160edf935da216c75c5..03ebe29b56dff2f874a33f190cce5598a3b2b430 100644
--- a/freeipa.spec.in
+++ b/freeipa.spec.in
@@ -603,6 +603,7 @@ Requires: python2-polib
 Requires: python-pytest-multihost >= 0.5
 Requires: python-pytest-sourceorder
 Requires: ldns-utils
+Requires: python-sssdconfig
 
 Provides: %{alt_name}-tests = %{version}
 Conflicts: %{alt_name}-tests
@@ -634,6 +635,7 @@ Requires: python3-polib
 Requires: python3-pytest-multihost >= 0.5
 Requires: python3-pytest-sourceorder
 Requires: ldns-utils
+Requires: python3-sssdconfig
 
 %description -n python3-ipatests
 IPA is an integrated solution to provide centrally managed Identity (users,
-- 
2.8.0

From 3d34ca333ec17967b2ccc70726767400beb613bb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Milan=20Kub=C3=ADk?= 
Date: Mon, 25 Apr 2016 09:52:00 +0200
Subject: [PATCH] spec: Add python-sssdconfig dependency for freeipa-tests
 package

https://fedorahosted.org/freeipa/ticket/5843
---
 freeipa.spec.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/freeipa.spec.in b/freeipa.spec.in
index 78eedb86d21fb86c0d63381f89c6f694c40da7b6..52c127ed030d3b902aea2a52f699d41a9b9bafdc 100644
--- a/freeipa.spec.in
+++ b/freeipa.spec.in
@@ -351,6 +351,7 @@ Requires: python-coverage
 Requires: python-polib
 Requires: python-pytest-multihost >= 0.5
 Requires: python-pytest-sourceorder
+Requires: python-sssdconfig
 
 Conflicts: %{alt_name}-tests
 Obsoletes: %{alt_name}-tests < %{version}
-- 
2.8.0

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0097-0098] Makefile: replace perl with sed

[Jan Cholasta]

On 25.4.2016 09:34, Petr Spacek wrote:

On 25.4.2016 09:29, Lukas Slebodnik wrote:

On (25/04/16 07:23), Jan Cholasta wrote:

Hi,

On 22.4.2016 13:29, Petr Spacek wrote:

Hello,

Makefile: add sed to BuildRequires

It was requried since forever but we did not explicitly mention it.


IIRC sed is part of the minimum build environemnt and as such should not be
explicitly required in the spec file. I personally don't care, but this is
the likely reason why it wan't there from the beginning.


+1

It is part of group "@buildsys-build".
and fedora packaging guidelines does not recommend to list
packages from this group in BuildRequires.


I consider this piece of Fedora guidelines brain-dead as "explicit is better
than implicit". Anyway, feel free to NACK it so the status of the patch is
clear and this thread can die. I do not insist on it.


I can't find it in the guidelines anymore, so LGTM.

--
Jan Cholasta

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0097-0098] Makefile: replace perl with sed

[Lukas Slebodnik]

On (22/04/16 13:29), Petr Spacek wrote:
>Hello,
>
>Makefile: add sed to BuildRequires
>
>It was requried since forever but we did not explicitly mention it.
>
>Makefile: replace perl with sed
>
>Perl was missing in BuildRequires anyway and it is used only on one place,
>all other places are using sed.
>
>-- 
>Petr^2 Spacek

>From 3c7a3c87d62358407d856119e384c70040acec1e Mon Sep 17 00:00:00 2001
>From: Petr Spacek 
>Date: Fri, 22 Apr 2016 10:40:11 +0200
>Subject: [PATCH] Makefile: replace perl with sed
>
>Perl was missing in BuildRequires anyway and it is used only on one place,
>all other places are using sed.
>---
> Makefile | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
ACK

>From 2deaef91ab71c0e78b2142c2102cfe65f0e4ed96 Mon Sep 17 00:00:00 2001
>From: Petr Spacek 
>Date: Fri, 22 Apr 2016 10:40:37 +0200
>Subject: [PATCH] Makefile: add sed to BuildRequires
>
>It was requried since forever but we did not explicitly mention it.
>---
> freeipa.spec.in | 1 +
> 1 file changed, 1 insertion(+)
>
NACK

As it was mentioned elsewhere in thread this patch is not needed.

LS

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [patch 0037] spec: Add python-sssdconfig dependency for python-ipatests package

[Martin Babinsky]

On 04/23/2016 12:13 AM, Milan Kubík wrote:

https://fedorahosted.org/freeipa/ticket/5843

Applies to ipa-4-3, master

--
Milan Kubik





Hi Milan,

the dependency on python-sssdconfig was introduced by my fix to 
https://fedorahosted.org/freeipa/ticket/5625 (I know, shame) which also 
landed in ipa-4-2, so you'll need to send a patch also for this branch 
(the current one obviously does not apply).


Also in ipa-4-3 and master patch you should require python3-sssdconfig 
for python3-ipatests.


--
Martin^3 Babinsky

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0097-0098] Makefile: replace perl with sed

[Petr Spacek]

On 25.4.2016 09:29, Lukas Slebodnik wrote:
> On (25/04/16 07:23), Jan Cholasta wrote:
>> Hi,
>>
>> On 22.4.2016 13:29, Petr Spacek wrote:
>>> Hello,
>>>
>>> Makefile: add sed to BuildRequires
>>>
>>> It was requried since forever but we did not explicitly mention it.
>>
>> IIRC sed is part of the minimum build environemnt and as such should not be
>> explicitly required in the spec file. I personally don't care, but this is
>> the likely reason why it wan't there from the beginning.
>>
> +1
> 
> It is part of group "@buildsys-build".
> and fedora packaging guidelines does not recommend to list
> packages from this group in BuildRequires.

I consider this piece of Fedora guidelines brain-dead as "explicit is better
than implicit". Anyway, feel free to NACK it so the status of the patch is
clear and this thread can die. I do not insist on it.

-- 
Petr^2 Spacek

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0097-0098] Makefile: replace perl with sed

[Lukas Slebodnik]

On (25/04/16 07:23), Jan Cholasta wrote:
>Hi,
>
>On 22.4.2016 13:29, Petr Spacek wrote:
>> Hello,
>> 
>> Makefile: add sed to BuildRequires
>> 
>> It was requried since forever but we did not explicitly mention it.
>
>IIRC sed is part of the minimum build environemnt and as such should not be
>explicitly required in the spec file. I personally don't care, but this is
>the likely reason why it wan't there from the beginning.
>
+1

It is part of group "@buildsys-build".
and fedora packaging guidelines does not recommend to list
packages from this group in BuildRequires.

LS

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code