[gem5-dev] Review Request 2527: config: ruby: Get rid of an eval and an exec operating on generated code.
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2527/ --- Review request for Default. Repository: gem5 Description --- Changeset 10564:b90448378de5 --- config: ruby: Get rid of an eval and an exec operating on generated code. We can get the same result using importlib. Diffs - configs/ruby/Ruby.py 6317351a288c0349c5855c7431bc1eeade61605c Diff: http://reviews.gem5.org/r/2527/diff/ Testing --- Thanks, Gabe Black ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 2527: config: ruby: Get rid of an eval and an exec operating on generated code.
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2527/#review5521 --- Ship it! Ship It! - Nilay Vaish On Nov. 23, 2014, 11:03 a.m., Gabe Black wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2527/ --- (Updated Nov. 23, 2014, 11:03 a.m.) Review request for Default. Repository: gem5 Description --- Changeset 10564:b90448378de5 --- config: ruby: Get rid of an eval and an exec operating on generated code. We can get the same result using importlib. Diffs - configs/ruby/Ruby.py 6317351a288c0349c5855c7431bc1eeade61605c Diff: http://reviews.gem5.org/r/2527/diff/ Testing --- Thanks, Gabe Black ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 2527: config: ruby: Get rid of an eval and an exec operating on generated code.
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2527/#review5529 --- Looks like importlib is only available in 2.7 (https://docs.python.org/2/library/importlib.html), and according to http://gem5.org/Dependencies we still support 2.5 and 2.6 as well. Is that accurate? In isolation, this seems reasonable, but it doesn't seem like enough of an advantage to justify bumping our minimum supported version. - Steve Reinhardt On Nov. 23, 2014, 3:03 a.m., Gabe Black wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2527/ --- (Updated Nov. 23, 2014, 3:03 a.m.) Review request for Default. Repository: gem5 Description --- Changeset 10564:b90448378de5 --- config: ruby: Get rid of an eval and an exec operating on generated code. We can get the same result using importlib. Diffs - configs/ruby/Ruby.py 6317351a288c0349c5855c7431bc1eeade61605c Diff: http://reviews.gem5.org/r/2527/diff/ Testing --- Thanks, Gabe Black ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 2527: config: ruby: Get rid of an eval and an exec operating on generated code.
Hi all, I strongly suggest to not go beyond 2.6 at the moment. All Ubuntu 12.04 machines and RHE6 machines have 2.6 as their default, and that matches with our previous assumptions also regarding gcc etc. I agree with Steve that we can consider a move to 2.7, but it should be for stronger reasons that saving a few lines of code. I suggest we revert the change for now. Andreas From: gem5-dev [gem5-dev-boun...@gem5.org] On Behalf Of Steve Reinhardt via gem5-dev [gem5-dev@gem5.org] Sent: Sunday, November 23, 2014 7:37 PM To: Steve Reinhardt; Default; Gabe Black Subject: Re: [gem5-dev] Review Request 2527: config: ruby: Get rid of an eval and an exec operating on generated code. --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2527/#review5529 --- Looks like importlib is only available in 2.7 (https://docs.python.org/2/library/importlib.html), and according to http://gem5.org/Dependencies we still support 2.5 and 2.6 as well. Is that accurate? In isolation, this seems reasonable, but it doesn't seem like enough of an advantage to justify bumping our minimum supported version. - Steve Reinhardt On Nov. 23, 2014, 3:03 a.m., Gabe Black wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2527/ --- (Updated Nov. 23, 2014, 3:03 a.m.) Review request for Default. Repository: gem5 Description --- Changeset 10564:b90448378de5 --- config: ruby: Get rid of an eval and an exec operating on generated code. We can get the same result using importlib. Diffs - configs/ruby/Ruby.py 6317351a288c0349c5855c7431bc1eeade61605c Diff: http://reviews.gem5.org/r/2527/diff/ Testing --- Thanks, Gabe Black ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England Wales, Company No: 2557590 ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England Wales, Company No: 2548782 ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 2527: config: ruby: Get rid of an eval and an exec operating on generated code.
On Nov. 23, 2014, 7:37 p.m., Steve Reinhardt wrote: Looks like importlib is only available in 2.7 (https://docs.python.org/2/library/importlib.html), and according to http://gem5.org/Dependencies we still support 2.5 and 2.6 as well. Is that accurate? In isolation, this seems reasonable, but it doesn't seem like enough of an advantage to justify bumping our minimum supported version. Yes, that seems to be right. I hadn't considered python versions. Today isn't a gem5 day for me (1 workday day a week, weekends if I'm so inclined), so please feel free to revert if it's urgent. - Gabe --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2527/#review5529 --- On Nov. 23, 2014, 11:03 a.m., Gabe Black wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2527/ --- (Updated Nov. 23, 2014, 11:03 a.m.) Review request for Default. Repository: gem5 Description --- Changeset 10564:b90448378de5 --- config: ruby: Get rid of an eval and an exec operating on generated code. We can get the same result using importlib. Diffs - configs/ruby/Ruby.py 6317351a288c0349c5855c7431bc1eeade61605c Diff: http://reviews.gem5.org/r/2527/diff/ Testing --- Thanks, Gabe Black ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 2527: config: ruby: Get rid of an eval and an exec operating on generated code.
On Sun, 23 Nov 2014, Andreas Hansson via gem5-dev wrote: Hi all, I strongly suggest to not go beyond 2.6 at the moment. All Ubuntu 12.04 machines and RHE6 machines have 2.6 as their default, and that matches with our previous assumptions also regarding gcc etc. I agree with Steve that we can consider a move to 2.7, but it should be for stronger reasons that saving a few lines of code. I suggest we revert the change for now. I want to keep the changeset for a little while and see if users complain about it. The versions of Linux you mention are going to be around for a significant amount of time, so I do not want to base my decision on their lifetime. If any organization is internally using those Linux and it is hard for the users to move to python 2.7, then we should revert the changeset immediately. Otherwise, I prefer waiting for the first user complaint. -- Nilay ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 2527: config: ruby: Get rid of an eval and an exec operating on generated code.
On Sun, Nov 23, 2014 at 5:28 PM, Nilay Vaish via gem5-dev gem5-dev@gem5.org wrote: I want to keep the changeset for a little while and see if users complain about it. The versions of Linux you mention are going to be around for a significant amount of time, so I do not want to base my decision on their lifetime. If any organization is internally using those Linux and it is hard for the users to move to python 2.7, then we should revert the changeset immediately. Otherwise, I prefer waiting for the first user complaint. Hi Nilay, I disagree. If we're going to advance the required version of python, I'd like to do it as the result of a thorough discussion, not as the side effect of an unintentional commit. If we want to get input from users, we could ask on the gem5-users list, and give them a chance to speak up before we slip in a stealth compatibility test. I'm curious what other features of 2.7 people are interested in taking advantage of that aren't in 2.6. The importlib thing is nice, but as I said before, not totally compelling. Steve ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
