Re: [gentoo-portage-dev] [PATCH] Repoman SVN support

2006-11-25 Thread Alec Warner

Fabian Groffen wrote:

Hi all,

Please find attached the patch of the prefix repoman sources against the
current trunk.  I hope I removed all hunks that have prefix-only
changes.


You realize I wrote generic SCM support into repoman over the summer 
right? :P It was never merged (afaik I slacked on it, but also because 
it uses Popen and you pesky OSX folks are stuck on python2.3, so I need 
to convert to portage.spawn).


However the support was generic, so for pretty much any system that 'is 
kinda like cvs/svn' should work fine with a few tweaks to the exec 
mapping.  biasThis of course excludes GIT, since it's a huge 
non-standard piece of crap./bias


I may work on fixing that code up and putting it into HEAD before I retire.

-Alec Warner
[EMAIL PROTECTED]
--
gentoo-portage-dev@gentoo.org mailing list



Re: [gentoo-portage-dev] [PATCH] Repoman SVN support

2006-11-25 Thread Fabian Groffen
On 24-11-2006 23:29:53 -0800, Zac Medico wrote:
 -BEGIN PGP SIGNED MESSAGE-
 Hash: SHA1
 
 Fabian Groffen wrote:
  Please find attached the patch of the prefix repoman sources against the
  current trunk.
 
 I like the idea of having svn support, but I think it will be much
 nicer if we separate the cvs and svn support into plugins.  That
 way, it should make the code cleaner and we'll more easily be able
 to add support for additional revision control systems if we want.

I would prefer that, as I'm an OO-freak, but like I said I only revamped
this patch into a working one.  Besides that, I'm not a Python guru,
so more than a few if-s is getting a challenge already.

All in all, if there is an interface somewhere, then the code parts can
be copied in there for sure, quite easily.

-- 
Fabian Groffen
Gentoo on a different level
-- 
gentoo-portage-dev@gentoo.org mailing list



Re: [gentoo-portage-dev] [PATCH] Repoman SVN support

2006-11-25 Thread Fabian Groffen
On 25-11-2006 03:00:10 -0500, Alec Warner wrote:
 Fabian Groffen wrote:
 Hi all,
 
 Please find attached the patch of the prefix repoman sources against the
 current trunk.  I hope I removed all hunks that have prefix-only
 changes.
 
 You realize I wrote generic SCM support into repoman over the summer 
 right? :P It was never merged (afaik I slacked on it, but also because 

E no... probably because at that time I wasn't making my hands dirty
on portage code.

 it uses Popen and you pesky OSX folks are stuck on python2.3, so I need 
 to convert to portage.spawn).

You can drop that, as I already require python 2.4, since portage needs
at least 2.3.1 currently and I don't feel like checking with an older
version to see if it breaks more.  During bootstrapping I first install
python 2.4.  On a slightly related side note: you can also drop all your
bash-2 code, as we end up running bash-3 too.  Would only be nice if the
basic functionally would work with bash-2, otherwise I need to bootstrap
bash too.  (Worth the time if it simplifies portage.)

 However the support was generic, so for pretty much any system that 'is 
 kinda like cvs/svn' should work fine with a few tweaks to the exec 
 mapping.  biasThis of course excludes GIT, since it's a huge 
 non-standard piece of crap./bias

Great!  I feel that SVN won't be the only thing folks use, so I'm
looking forward to your interface from a (hopefully) functional view
point.

 I may work on fixing that code up and putting it into HEAD before I retire.

E... what?  The first is nice, the latter for sure isn't.


-- 
Fabian Groffen
Gentoo on a different level
-- 
gentoo-portage-dev@gentoo.org mailing list



Re: [gentoo-portage-dev] [PATCH] Repoman SVN support

2006-11-25 Thread Alec Warner

Fabian Groffen wrote:

On 25-11-2006 03:00:10 -0500, Alec Warner wrote:

Fabian Groffen wrote:

Hi all,

Please find attached the patch of the prefix repoman sources against the
current trunk.  I hope I removed all hunks that have prefix-only
changes.
You realize I wrote generic SCM support into repoman over the summer 
right? :P It was never merged (afaik I slacked on it, but also because 


E no... probably because at that time I wasn't making my hands dirty
on portage code.

it uses Popen and you pesky OSX folks are stuck on python2.3, so I need 
to convert to portage.spawn).


You can drop that, as I already require python 2.4, since portage needs
at least 2.3.1 currently and I don't feel like checking with an older
version to see if it breaks more.  During bootstrapping I first install
python 2.4.  On a slightly related side note: you can also drop all your
bash-2 code, as we end up running bash-3 too.  Would only be nice if the
basic functionally would work with bash-2, otherwise I need to bootstrap
bash too.  (Worth the time if it simplifies portage.)



ZOMG, I love you long time.  *shudders at python 2.3*

However the support was generic, so for pretty much any system that 'is 
kinda like cvs/svn' should work fine with a few tweaks to the exec 
mapping.  biasThis of course excludes GIT, since it's a huge 
non-standard piece of crap./bias


Great!  I feel that SVN won't be the only thing folks use, so I'm
looking forward to your interface from a (hopefully) functional view
point.



I haven't actually tried the others, but the support should be trivial 
assuming they have similar commands and output (yay regex...oh wait, not 
quite yay :) )



I may work on fixing that code up and putting it into HEAD before I retire.


E... what?  The first is nice, the latter for sure isn't.


We will see; I may stay on and do both, but I don't have a ton of time 
to work on stuff and it makes me feel guilty, hence trying to clean up 
loose ends around here.


--
gentoo-portage-dev@gentoo.org mailing list



Re: [gentoo-portage-dev] [PATCH] Repoman SVN support

2006-11-24 Thread Zac Medico
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Fabian Groffen wrote:
 Please find attached the patch of the prefix repoman sources against the
 current trunk.

I like the idea of having svn support, but I think it will be much
nicer if we separate the cvs and svn support into plugins.  That
way, it should make the code cleaner and we'll more easily be able
to add support for additional revision control systems if we want.

Zac
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQFFZ/Dw/ejvha5XGaMRAkgmAKDQDtOJRiE+ytgtlReGl4UEhECnfQCgsj7G
oA2wXDQXNjxw21BnK4t+59s=
=pwuX
-END PGP SIGNATURE-
-- 
gentoo-portage-dev@gentoo.org mailing list