Change in libosmocore[master]: GSUP: add inter-MSC handover related msgs and IEs

2019-02-10 Thread Neels Hofmeyr 
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12860 )

Change subject: GSUP: add inter-MSC handover related msgs and IEs
..


Patch Set 2:

(24 comments)

In general, I would like to keep this patch unmerged before I have osmo-msc's 
inter-MSC HO pretty much complete and working. Likely more insights and needs 
about the protocol will arise from chiseling out the details. But it would be 
nice to continue the review process nevertheless; just not merge it yet (so we 
don't need to worry about api compat later).

https://gerrit.osmocom.org/#/c/12860/2/include/osmocom/gsm/gsup.h
File include/osmocom/gsm/gsup.h:

https://gerrit.osmocom.org/#/c/12860/2/include/osmocom/gsm/gsup.h@191
PS2, Line 191:  OSMO_GSUP_MSGT_E_PROCESS_ACCESS_SIGNALLING_ERROR= 
0b0110,
the Process Access Signalling and Forward Access Signalling will never return 
an Error.
I know there was some obscure reason, but can't we get around having to define 
them?


https://gerrit.osmocom.org/#/c/12860/2/include/osmocom/gsm/gsup.h@196
PS2, Line 196: OSMO_GSUP_MSGT_E_CLOSE
> As far as I can see, this comes from TCAP. […]
actually, I did model an "abort" message in my 
osmo-msc/doc/interMSC_HO_GSUP_msgs.txt, and ...


https://gerrit.osmocom.org/#/c/12860/2/include/osmocom/gsm/gsup.h@197
PS2, Line 197:  OSMO_GSUP_MSGT_E_ABORT  = 
0b01001011,
... and here is an Abort message. @vadim, what do you mean?


https://gerrit.osmocom.org/#/c/12860/2/include/osmocom/gsm/gsup.h@338
PS2, Line 338: an_apdu
> I would use a pointer here. The osmo_gsup_message is already quite big...
size is IMHO not a good reason. Is there another one? Otherwise, no need to 
extract two ints and a pointer.


https://gerrit.osmocom.org/#/c/12860/2/include/osmocom/gsm/gsup.h@341
PS2, Line 341: cause_sm
> Does SM mean "Short Message"? If yes, we already have "sm_rp_cause".
apparently means "Session Management" :(
gsm48_gsm_cause in gsm_04_08_gprs.h says: "definition in 3GPP TS 24.008 
10.5.6.6 / Table 10.5.157"
I was going to call it cause_rr or something, but the spec does have this as a 
name.


https://gerrit.osmocom.org/#/c/12860/2/include/osmocom/gsm/gsup_handover.h
File include/osmocom/gsm/gsup_handover.h:

https://gerrit.osmocom.org/#/c/12860/2/include/osmocom/gsm/gsup_handover.h@19
PS2, Line 19: uint8_t
> const?
agree


https://gerrit.osmocom.org/#/c/12860/2/include/osmocom/gsm/gsup_handover.h@20
PS2, Line 20:
if this is all there is to this API, then let's just place these in the common 
gsup.[hc]?


https://gerrit.osmocom.org/#/c/12860/2/src/gsm/gsup.c
File src/gsm/gsup.c:

https://gerrit.osmocom.org/#/c/12860/2/src/gsm/gsup.c@786
PS2, Line 786:  if ((u8 = gsup_msg->cause_rr))
RR cause also have a zero value, see vadim's remark below


https://gerrit.osmocom.org/#/c/12860/2/src/gsm/gsup.c@789
PS2, Line 789: u8 = gsup_msg->cause_bssap
> One wouldn't be able to encode GSM0808_CAUSE_RADIO_INTERFACE_MESSAGE_FAILURE 
> == 0x00 this way. […]
I'm not remembering the details right now ... if it is all on the stack, and if 
you agree with vadim, then it could be ok to use pointers. But if each cause 
value would need a dynamically allocated pointer, then rather use bool presence 
flags.

The size of the struct is of no concern, straight forward simplicity to allow 
encoding zero cause values is the goal. You choose...


https://gerrit.osmocom.org/#/c/12860/2/src/gsm/gsup_handover.c
File src/gsm/gsup_handover.c:

https://gerrit.osmocom.org/#/c/12860/2/src/gsm/gsup_handover.c@37
PS2, Line 37:  *  Handover extensions for Osmocom GSUP.
Take a look at 
https://osmocom.org/projects/cellular-infrastructure/wiki/Guidelines_for_API_documentation#Files-and-Groups


https://gerrit.osmocom.org/#/c/12860/2/src/gsm/gsup_handover.c@43
PS2, Line 43:  * \returns 0 in case of success, negative in case of error
(please get in the habit of ending everything with a dot)


https://gerrit.osmocom.org/#/c/12860/2/src/gsm/gsup_handover.c@47
PS2, Line 47:   const struct osmo_gsup_an_apdu an_apdu = gsup_msg->an_apdu;
(this is actually copying the struct. It's not much, but doesn't seem 
intentional.)


https://gerrit.osmocom.org/#/c/12860/2/src/gsm/gsup_handover.c@61
PS2, Line 61:   uint8_t* buf = msgb_put(msg, an_apdu.data_len);
( "uint8_t *buf" )


https://gerrit.osmocom.org/#/c/12860/2/src/gsm/libosmogsm.map
File src/gsm/libosmogsm.map:

https://gerrit.osmocom.org/#/c/12860/2/src/gsm/libosmogsm.map@552
PS2, Line 552: osmo_gsup_handover_decode_an_apdu;
(why not put it after the end of gsup_sms? thinking alphabetically?)


https://gerrit.osmocom.org/#/c/12860/2/tests/gsup/gsup_test.c
File tests/gsup/gsup_test.c:

https://gerrit.osmocom.org/#/c/12860/2/tests/gsup/gsup_test.c@327
PS2, Line 327:  TEST_MSISDN_IE,
no msisdn in this msg. The response sends the handover_number back, but the 
request doesn't include any.
It is always MSC-B or MSC-B' sending a

Change in libosmocore[master]: GSUP: add inter-MSC handover related msgs and IEs

2019-02-10 Thread Neels Hofmeyr 
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12860 )

Change subject: GSUP: add inter-MSC handover related msgs and IEs
..


Patch Set 2: Code-Review-1


--
To view, visit https://gerrit.osmocom.org/12860
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic00b0601eacff6d72927cea51767801142ee75db
Gerrit-Change-Number: 12860
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Mon, 11 Feb 2019 02:25:58 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-dev[master]: run.sh: more userfriendly "stale configs" message

2019-02-10 Thread Neels Hofmeyr 
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12733 )

Change subject: run.sh: more userfriendly "stale configs" message
..


Patch Set 3: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/12733/2/net/tmpl_std/run.sh
File net/tmpl_std/run.sh:

https://gerrit.osmocom.org/#/c/12733/2/net/tmpl_std/run.sh@7
PS2, Line 7:echo " * Hit ^C and run 'make regen' to regenerate your configs"
> Even with the Makefile in place? The idea was, that the user only needs to 
> remember "make regen" for […]
i see it so that the Makefile is just a shim for if you can't remember what is 
really happening...
UI wise it's slightly bad to offer two ways to achieve the same.
But since this is just some message in a tool with three users...



--
To view, visit https://gerrit.osmocom.org/12733
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If225e094619a07a228e0e2f337153ee18cdb420c
Gerrit-Change-Number: 12733
Gerrit-PatchSet: 3
Gerrit-Owner: osmith 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Mon, 11 Feb 2019 01:06:34 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in libosmo-netif[master]: Add stream client/server test

2019-02-10 Thread Max 
Max has posted comments on this change. ( https://gerrit.osmocom.org/12837 )

Change subject: Add stream client/server test
..


Patch Set 18: Code-Review+2

> I don't really understand why you need the -no-install flag, but then it's 
> just to compile a test, so...

In theory autogenerated libtool wrapper script should be equivalent. Not sure 
why it made a difference in my case, but using static binary instead of srapper 
script (effect of -no-install flag) seems like a safe bet anyway.


--
To view, visit https://gerrit.osmocom.org/12837
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I336f79970982ed8e1d73b73d54fa4c27ba8bce8e
Gerrit-Change-Number: 12837
Gerrit-PatchSet: 18
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Sun, 10 Feb 2019 22:30:01 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmo-netif[master]: Add stream client/server test

2019-02-10 Thread Max 
Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12837 )

Change subject: Add stream client/server test
..

Add stream client/server test

Previously stream client and server code were only used in examples
which means regressions could be easily introduced unnoticed until they
trigger bugs in external code which relies on osmo_stream_*()

Fix this by adding basic client-server interaction tests with and
without reconnection.

Change-Id: I336f79970982ed8e1d73b73d54fa4c27ba8bce8e
---
M .gitignore
M tests/Makefile.am
A tests/stream/stream_test.c
A tests/stream/stream_test.err
A tests/stream/stream_test.ok
M tests/testsuite.at
6 files changed, 418 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  osmith: Looks good to me, but someone else must approve
  daniel: Looks good to me, but someone else must approve
  Max: Looks good to me, approved



diff --git a/.gitignore b/.gitignore
index 672708d..e2f2fb9 100644
--- a/.gitignore
+++ b/.gitignore
@@ -56,3 +56,4 @@
 jibuf_test
 jibuf_tool
 osmux_test2
+stream_test
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 03a7a3c..c3628ac 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -1,7 +1,7 @@
 AM_CFLAGS = -Wall -I$(top_srcdir)/include $(LIBOSMOCORE_CFLAGS) -g
 AM_LDFLAGS = $(LIBOSMOCORE_LDFLAGS)

-check_PROGRAMS = osmux/osmux_test osmux/osmux_test2 jibuf/jibuf_test
+check_PROGRAMS = osmux/osmux_test osmux/osmux_test2 stream/stream_test 
jibuf/jibuf_test
 check_HEADERS =

 osmux_osmux_test_SOURCES = osmux/osmux_test.c
@@ -10,6 +10,10 @@
 osmux_osmux_test2_SOURCES = osmux/osmux_test2.c
 osmux_osmux_test2_LDADD = $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS) 
$(top_builddir)/src/libosmonetif.la

+stream_stream_test_SOURCES = stream/stream_test.c
+stream_stream_test_LDADD = $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS) 
$(top_builddir)/src/libosmonetif.la
+stream_stream_test_LDFLAGS = -no-install
+
 jibuf_jibuf_test_SOURCES = jibuf/jibuf_test.c
 jibuf_jibuf_test_LDADD = $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS) 
$(top_builddir)/src/libosmonetif.la

@@ -57,6 +61,8 @@
 EXTRA_DIST = testsuite.at $(srcdir)/package.m4 $(TESTSUITE)\
 osmux/osmux_test.ok \
 osmux/osmux_test2.ok \
+stream/stream_test.ok \
+stream/stream_test.err \
 jibuf/jibuf_test.ok

 DISTCLEANFILES = atconfig
diff --git a/tests/stream/stream_test.c b/tests/stream/stream_test.c
new file mode 100644
index 000..1a0c555
--- /dev/null
+++ b/tests/stream/stream_test.c
@@ -0,0 +1,309 @@
+/*
+ * (C) 2019 by sysmocom - s.f.m.c. GmbH.
+ * Author: Max Suraev
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+
+#define DSTREAMTEST 0
+struct log_info_cat osmo_stream_test_cat[] = {
+   [DSTREAMTEST] = {
+   .name = "DSTREAMTEST",
+   .description = "STREAM test",
+   .enabled = 1, .loglevel = LOGL_INFO,
+   },
+};
+
+const struct log_info osmo_stream_test_log_info = {
+   .filter_fn = NULL,
+   .cat = osmo_stream_test_cat,
+   .num_cat = ARRAY_SIZE(osmo_stream_test_cat),
+};
+
+static struct msgb *make_msgb(const char *m)
+{
+   struct msgb *msg = msgb_alloc(512, "STREAM test");
+   if (!msg) {
+   printf("Unable to allocate message\n");
+   return NULL;
+   }
+
+   if (m)
+   msgb_printf(msg, "%s", m);
+
+   return msg;
+}
+
+#define ASTR(rec) ((rec) ? "autoreconnecting" : "non-reconnecting")
+
+/* client defs */
+#define LOGCLI(cli, fmt, args...) \
+   printf("[%s] Client's %s(): " fmt, osmo_stream_cli_get_data(cli) ? "OK" 
: "NA", __func__, ##args)
+
+#define CLI_SND(cli, m) do {   \
+   struct msgb *msg = make_msgb(m);\
+   LOGCLI(cli, "sent %d bytes message: %s\n",  \
+  msg->len, msgb_hexdump(msg));\
+   osmo_stream_cli_send(cli, msg); \
+   } while(0)
+
+/* client callbacks */
+static int connect_cb_cli(struct osmo_stream_cli *cli)
+{
+   void *recon = osmo_stream_cli_get_data(cli);
+   LOGCLI(cli, "callback triggered <%s>\n", recon ? "reconnected" : 
"initial");
+   if (recon) {
+   LOGCLI(cli, "closing connection\n");
+   osmo_stream_cli_close(cli);
+   } else
+   CLI_SND(cli, "Hi! from connect callback :-P");
+
+   return 0;
+}
+
+static int read_cb_cli(struct osmo_stream_cli *cli)
+{
+   int bytes;
+   void *cli_data =

Change in osmo-bts[master]: OML: Properly reject short messages and truncate over-long messages

2019-02-10 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12873 )

Change subject: OML: Properly reject short messages and truncate over-long 
messages
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12873/1/src/common/oml.c
File src/common/oml.c:

https://gerrit.osmocom.org/#/c/12873/1/src/common/oml.c@1453
PS1, Line 1453: msgb_l3trim(msg, oh->length);
> That's weird imho, I'd drop it with oml_tx_failure_event_rep(), since 
> attempting decoding potentiall […]
To me it's quite clear: The OML protocol states there's 10 bytes of payload 
(IEs), and that's what we have to parse.  Extra data at the end of the message 
should not concern us.  In Ethernet, small frames get a trailer at the end.  In 
LLC, there's a CRC at the end. I think this is generally customary that you use 
the length value from the protocol/header you currently work on and ignore any 
extra data at the end.



--
To view, visit https://gerrit.osmocom.org/12873
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib98f0d7c2cff9172714ed18667c02564540d65d7
Gerrit-Change-Number: 12873
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 10 Feb 2019 22:23:59 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-bts[master]: OML: Return attributes in ACK/NACK messages

2019-02-10 Thread Harald Welte 
Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12863 )

Change subject: OML: Return attributes in ACK/NACK messages
..

OML: Return attributes in ACK/NACK messages

As per 3GPP TS 12.21 Section 8.2 "ACK messages shall return all the
attributes in the original message". OsmoBTS fails to do so but simply
sends no attributes at all in the ACK.

TS 12.21 is a bit vague whether or not the attributes shall also be
achoed in the NACK.  Let's do it and append the CAUSE in this case.

Closes: OS#3788
Change-Id: Ifb305fe75f8305bb04872f26492b8b1bb8c27f49
---
M src/common/oml.c
1 file changed, 8 insertions(+), 11 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/src/common/oml.c b/src/common/oml.c
index ce59865..6952d75 100644
--- a/src/common/oml.c
+++ b/src/common/oml.c
@@ -425,26 +425,19 @@
  * contained in 'msg'. ACK is sent if cause == 0; NACK otherwise */
 int oml_fom_ack_nack(struct msgb *old_msg, uint8_t cause)
 {
-   struct abis_om_hdr *old_oh = msgb_l2(old_msg);
-   struct abis_om_fom_hdr *old_foh = msgb_l3(old_msg);
struct msgb *msg;
struct abis_om_fom_hdr *foh;
-   int is_manuf = 0;

-   msg = oml_msgb_alloc();
+   msg = msgb_copy(old_msg, "OML_fom_ack_nack");
if (!msg)
return -ENOMEM;

-   /* make sure to respond with MANUF if request was MANUF */
-   if (old_oh->mdisc == ABIS_OM_MDISC_MANUF)
-   is_manuf = 1;
+   /* remove any l2/l1 that may be present in copy */
+   msgb_pull_to_l2(msg);

msg->trx = old_msg->trx;

-   /* copy over old FOM-Header and later only change the msg_type */
-   msg->l3h = msgb_push(msg, sizeof(*foh));
foh = (struct abis_om_fom_hdr *) msg->l3h;
-   memcpy(foh, old_foh, sizeof(*foh));

/* alter message type */
if (cause) {
@@ -453,12 +446,16 @@
foh->msg_type += 2; /* nack */
/* add cause */
msgb_tv_put(msg, NM_ATT_NACK_CAUSES, cause);
+   /* update the length as we just made the message larger */
+   struct abis_om_hdr *omh = (struct abis_om_hdr *) msgb_l2(msg);
+   omh->length = msgb_l3len(msg);
} else {
LOGP(DOML, LOGL_DEBUG, "Sending FOM ACK.\n");
foh->msg_type++; /* ack */
}

-   return oml_send_msg(msg, is_manuf);
+   /* we cannot use oml_send_msg() as we already have the OML header */
+   return abis_oml_sendmsg(msg);
 }

 /*

--
To view, visit https://gerrit.osmocom.org/12863
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb305fe75f8305bb04872f26492b8b1bb8c27f49
Gerrit-Change-Number: 12863
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-bts[master]: OML: Don't overwrite MO instance before oml_tx_failure_event_rep()

2019-02-10 Thread Harald Welte 
Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12865 )

Change subject: OML: Don't overwrite MO instance before 
oml_tx_failure_event_rep()
..

OML: Don't overwrite MO instance before oml_tx_failure_event_rep()

In Change-Id Ic163bcfb6361a8ebd39e0bc0f238ef51e2cb214e we introduced
several additional calls to oml_tx_failure_event_rep() during OML
messaeg processing.  However, for some reason, we *overwrite* the
bts_nt/trx_nr/ts_nr of the TRX MO.  This is clearly wrong.  The
"address" of a managed object doesn't change at runtime!

Change-Id: Idfb80ccd6dd485d52dc006867fae3dde3fb005f3
---
M src/common/oml.c
1 file changed, 1 insertion(+), 11 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/src/common/oml.c b/src/common/oml.c
index 6952d75..6d8bc4b 100644
--- a/src/common/oml.c
+++ b/src/common/oml.c
@@ -1078,12 +1078,8 @@

foh->msg_type));
LOGPC(DOML, LOGL_ERROR, "\n");
trx = gsm_bts_trx_num(bts, foh->obj_inst.trx_nr);
-   if (trx) {
-   trx->mo.obj_inst.bts_nr = 0;
-   trx->mo.obj_inst.trx_nr = foh->obj_inst.trx_nr;
-   trx->mo.obj_inst.ts_nr = 0xff;
+   if (trx)
mo = >mo;
-   }
oml_tx_failure_event_rep(mo, OSMO_EVT_MAJ_UKWN_MSG, form, 
foh->obj_inst.bts_nr,
 
get_value_string(abis_nm_msgtype_names, foh->msg_type));

@@ -1103,9 +1099,6 @@
LOGP(DOML, LOGL_NOTICE, "Formatted O message too short\n");
trx = gsm_bts_trx_num(bts, foh->obj_inst.trx_nr);
if (trx) {
-   trx->mo.obj_inst.bts_nr = 0;
-   trx->mo.obj_inst.trx_nr = foh->obj_inst.trx_nr;
-   trx->mo.obj_inst.ts_nr = 0xff;
oml_tx_failure_event_rep(>mo, 
OSMO_EVT_MAJ_UKWN_MSG,
 "Formatted O message too 
short");
}
@@ -1150,9 +1143,6 @@
foh->msg_type);
trx = gsm_bts_trx_num(bts, foh->obj_inst.trx_nr);
if (trx) {
-   trx->mo.obj_inst.bts_nr = 0;
-   trx->mo.obj_inst.trx_nr = foh->obj_inst.trx_nr;
-   trx->mo.obj_inst.ts_nr = 0xff;
oml_tx_failure_event_rep(>mo, 
OSMO_EVT_MAJ_UKWN_MSG,
 "unknown Formatted O "
 "msg_type 0x%02x",

--
To view, visit https://gerrit.osmocom.org/12865
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idfb80ccd6dd485d52dc006867fae3dde3fb005f3
Gerrit-Change-Number: 12865
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-bts[master]: OML: Ensure MOs are initialized with valid "Administrative State'

2019-02-10 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12864 )

Change subject: OML: Ensure MOs are initialized with valid "Administrative 
State'
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/12864
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03f8a4b08b266cd40036076c76f9dc7e8bf08da2
Gerrit-Change-Number: 12864
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 10 Feb 2019 20:05:46 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-bts[master]: OML: remove double-logging on oml_tx_failure_event_rep()

2019-02-10 Thread Harald Welte 
Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12866 )

Change subject: OML: remove double-logging on oml_tx_failure_event_rep()
..

OML: remove double-logging on oml_tx_failure_event_rep()

When we send an OML failure event report using
oml_tx_failure_event_rep(), the function itself will not only send
the report to the BSC but also log it.  So there's no need to both
have an explicit LOGP() and a call to oml_tx_failure_event_rep().

Change-Id: Ib3fd06b3266d896aebeed4ebe42ac71ff173bb5c
---
M src/common/oml.c
1 file changed, 0 insertions(+), 6 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/src/common/oml.c b/src/common/oml.c
index 6d8bc4b..82d12c7 100644
--- a/src/common/oml.c
+++ b/src/common/oml.c
@@ -558,7 +558,6 @@
}

if (!TLVP_PRES_LEN(, NM_ATT_LIST_REQ_ATTR, 1)) {
-   LOGP(DOML, LOGL_ERROR, "O Get Attributes message without 
Attribute List?!\n");
oml_tx_failure_event_rep(>mo, OSMO_EVT_MAJ_UNSUP_ATTR, 
"Get Attribute without Attribute List");
return oml_fom_ack_nack(msg, NM_NACK_INCORR_STRUCT);
}
@@ -1074,9 +1073,6 @@
"Unexpected BTS %d in manufacturer O %s (exp. 0 or 0xFF)";

if (foh->obj_inst.bts_nr != 0 && foh->obj_inst.bts_nr != 0xff) {
-   LOGP(DOML, LOGL_ERROR, form, foh->obj_inst.bts_nr, 
get_value_string(abis_nm_msgtype_names,
-   
foh->msg_type));
-   LOGPC(DOML, LOGL_ERROR, "\n");
trx = gsm_bts_trx_num(bts, foh->obj_inst.trx_nr);
if (trx)
mo = >mo;
@@ -1139,8 +1135,6 @@
ret = oml_rx_get_attr(bts, msg);
break;
default:
-   LOGP(DOML, LOGL_INFO, "unknown Formatted O msg_type 0x%02x\n",
-   foh->msg_type);
trx = gsm_bts_trx_num(bts, foh->obj_inst.trx_nr);
if (trx) {
oml_tx_failure_event_rep(>mo, 
OSMO_EVT_MAJ_UKWN_MSG,

--
To view, visit https://gerrit.osmocom.org/12866
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3fd06b3266d896aebeed4ebe42ac71ff173bb5c
Gerrit-Change-Number: 12866
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-bts[master]: OML: Ensure MOs are initialized with valid "Administrative State'

2019-02-10 Thread Harald Welte 
Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12864 )

Change subject: OML: Ensure MOs are initialized with valid "Administrative 
State'
..

OML: Ensure MOs are initialized with valid "Administrative State'

When osmo-bts connects to the BSC, it sends a ton of "State Change Event
Report" messages indicating the Operational State (NULL), Availability
status (power off) and [as an osmocom extension] also the Administrative
State. However, the value of the administrative state is "0", which is
not defined in TS 12.21 Section 9.4.4

Change-Id: I03f8a4b08b266cd40036076c76f9dc7e8bf08da2
Closes: OS#3785
---
M src/common/gsm_data_shared.c
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/src/common/gsm_data_shared.c b/src/common/gsm_data_shared.c
index 2d9af78..58b2503 100644
--- a/src/common/gsm_data_shared.c
+++ b/src/common/gsm_data_shared.c
@@ -38,6 +38,7 @@
 {
mo->nm_state.operational = NM_OPSTATE_NULL;
mo->nm_state.availability = NM_AVSTATE_POWER_OFF;
+   mo->nm_state.administrative = NM_STATE_LOCKED;
 }

 static void gsm_mo_init(struct gsm_abis_mo *mo, struct gsm_bts *bts,
@@ -222,10 +223,12 @@

trx->bts = bts;
trx->nr = bts->num_trx++;
-   trx->mo.nm_state.administrative = NM_STATE_UNLOCKED;

gsm_mo_init(>mo, bts, NM_OC_RADIO_CARRIER,
bts->nr, trx->nr, 0xff);
+   /* FIXME: Why would the TRX come up unlocked? */
+   trx->mo.nm_state.administrative = NM_STATE_UNLOCKED;
+
gsm_mo_init(>bb_transc.mo, bts, NM_OC_BASEB_TRANSC,
bts->nr, trx->nr, 0xff);


--
To view, visit https://gerrit.osmocom.org/12864
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I03f8a4b08b266cd40036076c76f9dc7e8bf08da2
Gerrit-Change-Number: 12864
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-bts[master]: OML: Return attributes in ACK/NACK messages

2019-02-10 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12863 )

Change subject: OML: Return attributes in ACK/NACK messages
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12863
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb305fe75f8305bb04872f26492b8b1bb8c27f49
Gerrit-Change-Number: 12863
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 10 Feb 2019 20:05:21 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: OML: remove double-logging on oml_tx_failure_event_rep()

2019-02-10 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12866 )

Change subject: OML: remove double-logging on oml_tx_failure_event_rep()
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12866
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3fd06b3266d896aebeed4ebe42ac71ff173bb5c
Gerrit-Change-Number: 12866
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 10 Feb 2019 20:05:36 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: OML: Don't overwrite MO instance before oml_tx_failure_event_rep()

2019-02-10 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12865 )

Change subject: OML: Don't overwrite MO instance before 
oml_tx_failure_event_rep()
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12865
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfb80ccd6dd485d52dc006867fae3dde3fb005f3
Gerrit-Change-Number: 12865
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 10 Feb 2019 20:05:31 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: OML: Ensure minimum required attributes are set before accepting OPSTART

2019-02-10 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12874 )

Change subject: OML: Ensure minimum required attributes are set before 
accepting OPSTART
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12874/1/src/common/oml.c
File src/common/oml.c:

https://gerrit.osmocom.org/#/c/12874/1/src/common/oml.c@1009
PS1, Line 1009: return sizeof(bts_mand_attr);
picky: due  to being a  list of uint8_t, sizeof() is same as num of elements, 
but it'd be more correct semantically to use OSMO_ARRAY_SIZE() or alike, 
specially if somebody decides later on to use another int data type for this 
list in the future.



--
To view, visit https://gerrit.osmocom.org/12874
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a818f8eceb6abef1b20d2b3892a749dbc9e4b05
Gerrit-Change-Number: 12874
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 10 Feb 2019 17:10:49 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-bts[master]: OML: Properly reject short messages and truncate over-long messages

2019-02-10 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12873 )

Change subject: OML: Properly reject short messages and truncate over-long 
messages
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12873/1/src/common/oml.c
File src/common/oml.c:

https://gerrit.osmocom.org/#/c/12873/1/src/common/oml.c@1453
PS1, Line 1453: msgb_l3trim(msg, oh->length);
That's weird imho, I'd drop it with oml_tx_failure_event_rep(), since 
attempting decoding potentially corrupted message could end up in tragedy.



--
To view, visit https://gerrit.osmocom.org/12873
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib98f0d7c2cff9172714ed18667c02564540d65d7
Gerrit-Change-Number: 12873
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 10 Feb 2019 17:06:05 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-bts[master]: OML: Send Failure Event Report on short OML messages

2019-02-10 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12872 )

Change subject: OML: Send Failure Event Report on short OML messages
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12872
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b64aa35fa7051d9eb190f3f6f5ea0b28bab8f
Gerrit-Change-Number: 12872
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 10 Feb 2019 16:59:35 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: OML: Reject segmented OML messages

2019-02-10 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12871 )

Change subject: OML: Reject segmented OML messages
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12871
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd42cf4edc1bf9ab366853bd9b0f7afd9c060910
Gerrit-Change-Number: 12871
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 10 Feb 2019 16:58:45 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: OML: Use 'const struct abis_oml_mo *' whenever users only read

2019-02-10 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12870 )

Change subject: OML: Use 'const struct abis_oml_mo *' whenever users only read
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12870
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a61e6d1b4e5e083bb24017166186dc87d035cd0
Gerrit-Change-Number: 12870
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 10 Feb 2019 16:56:01 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: OML: Report short messages even for invalid TRX numbers in down_fom()

2019-02-10 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12869 )

Change subject: OML: Report short messages even for invalid TRX numbers in 
down_fom()
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12869
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65b57d3fc714814db3ae3fd34398f307413fece8
Gerrit-Change-Number: 12869
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 10 Feb 2019 16:55:15 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: OML: Reduce code duplication in down_mom/down_fom

2019-02-10 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12868 )

Change subject: OML: Reduce code duplication in down_mom/down_fom
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12868
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe6c79e95405b13d041047549d2ffa39aa355eb2
Gerrit-Change-Number: 12868
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 10 Feb 2019 16:54:15 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: WIP: send proper OML alert in case of errors

2019-02-10 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12867 )

Change subject: WIP: send proper OML alert in case of errors
..


Patch Set 1:

Why is this one marked as WIP?


--
To view, visit https://gerrit.osmocom.org/12867
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b19b82a4874617c7c584cf3eac55eb9c756710a
Gerrit-Change-Number: 12867
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 10 Feb 2019 16:53:31 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-bts[master]: OML: Don't overwrite MO instance before oml_tx_failure_event_rep()

2019-02-10 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12865 )

Change subject: OML: Don't overwrite MO instance before 
oml_tx_failure_event_rep()
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12865
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfb80ccd6dd485d52dc006867fae3dde3fb005f3
Gerrit-Change-Number: 12865
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 10 Feb 2019 16:45:41 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: OML: remove double-logging on oml_tx_failure_event_rep()

2019-02-10 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12866 )

Change subject: OML: remove double-logging on oml_tx_failure_event_rep()
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12866
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3fd06b3266d896aebeed4ebe42ac71ff173bb5c
Gerrit-Change-Number: 12866
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 10 Feb 2019 16:46:52 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: OML: Return attributes in ACK/NACK messages

2019-02-10 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12863 )

Change subject: OML: Return attributes in ACK/NACK messages
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12863
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb305fe75f8305bb04872f26492b8b1bb8c27f49
Gerrit-Change-Number: 12863
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 10 Feb 2019 16:42:13 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,a4=default,osmocom-master-debian9 #397

2019-02-10 Thread jenkins 
See 


--
[...truncated 3.94 KB...]
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for style of include used by make... GNU
checking for gcc... gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... 
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for /usr/bin/ld option to reload object files... -r
checking for BSD-compatible nm... /usr/bin/nm -B
checking whether ln -s works... yes
checking how to recognise dependent libraries... pass_all
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking dlfcn.h usability... yes
checking dlfcn.h presence... yes
checking for dlfcn.h... yes
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking how to run the C++ preprocessor... g++ -E
checking for g77... no
checking for f77... no
checking for xlf... no
checking for frt... no
checking for pgf77... no
checking for cf77... no
checking for fort77... no
checking for fl32... no
checking for af77... no
checking for f90... no
checking for xlf90... no
checking for pgf90... no
checking for pghpf... no
checking for epcf90... no
checking for gfortran... no
checking for g95... no
checking for f95... no
checking for fort... no
checking for xlf95... no
checking for ifort... no
checking for ifc... no
checking for efc... no
checking for pgf95... no
checking for lf95... no
checking for ftn... no
checking whether we are using the GNU Fortran 77 compiler... no
checking whether  accepts -g... no
checking the maximum length of command line arguments... 32768
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for objdir... .libs
checking for ar... ar
checking for ranlib... ranlib
checking for strip... strip
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC
checking if gcc PIC flag -fPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
configure: creating libtool
appending configuration tag "CXX" to libtool
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking for g++ option to produce PIC... -fPIC
checking if g++ PIC flag -fPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
appending configuration tag "F77" to libtool
checking for autoconf... /usr/bin/autoconf
checking for autoheader... /usr/bin/autoheader
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking dependency style of gcc... (cached) gcc3
checking how to run the C preprocessor... gcc -E
checking for a BSD-compatible install... /usr/bin/install -c
checking whether ln -s works... yes
checking whether make sets $(MAKE)...

Change in osmo-msc[master]: libmsc/gsm_04_80.c: add msc_send_ussd_release_complete_cause()

2019-02-10 Thread Vadim Yanitskiy 
Hello daniel, Max, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12843

to look at the new patch set (#3).

Change subject: libmsc/gsm_04_80.c: add msc_send_ussd_release_complete_cause()
..

libmsc/gsm_04_80.c: add msc_send_ussd_release_complete_cause()

According to GSM 04.80, section 2.5.1, Release complete message
may have an optional Cause IE. Let's add a new function, that
allows to specify cause location and value.

This function will be used by the upcoming changes.

Change-Id: I3b9e8e4f473d113d5b9e9e5d33f7914202077203
Depends Change-Id: (libosmocore) Ie3ac85fcef90a5e532334ba3482804d5305c88d7
---
M include/osmocom/msc/gsm_04_80.h
M src/libmsc/gsm_04_80.c
2 files changed, 31 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/43/12843/3
--
To view, visit https://gerrit.osmocom.org/12843
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3b9e8e4f473d113d5b9e9e5d33f7914202077203
Gerrit-Change-Number: 12843
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel

Change in osmo-msc[master]: libmsc/gsm_04_80.c: use gsm0480_create_release_complete()

2019-02-10 Thread Vadim Yanitskiy 
Hello daniel, Max, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12840

to look at the new patch set (#3).

Change subject: libmsc/gsm_04_80.c: use gsm0480_create_release_complete()
..

libmsc/gsm_04_80.c: use gsm0480_create_release_complete()

The previous implementation of msc_send_ussd_release_complete() was
based on gsm0480_create_ussd_release_complete(), that doesn't
allow to specify GSM 04.07 transaction identifier.

The ability to specify particular transaction identifier
is required for handling multiple SS/USSD transactions.

Change-Id: Id2975c3383f18e83124ba38927c03980d67ddadb
Depends Change-Id: (libosmocore) Ie3ac85fcef90a5e532334ba3482804d5305c88d7
---
M include/osmocom/msc/gsm_04_80.h
M src/libmsc/gsm_04_80.c
M src/libmsc/msc_vty.c
3 files changed, 8 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/40/12840/3
--
To view, visit https://gerrit.osmocom.org/12840
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id2975c3383f18e83124ba38927c03980d67ddadb
Gerrit-Change-Number: 12840
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: daniel

Change in osmo-msc[master]: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions

2019-02-10 Thread Vadim Yanitskiy 
Hello daniel, Max, Neels Hofmeyr, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11992

to look at the new patch set (#11).

Change subject: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions
..

libmsc/gsm_09_11.c: implement guard timer for NCSS sessions

It may happen that either the MS or an EUSE would become
unresponsive during a call independent SS session, e.g.
due to a bug, or a dropped message. In such cases, the
corresponding transaction would remain unfreed forever.

This change introduces a guard timer, that prevents keeping
'stalled' NCSS sessions forever. As soon as it expires, both
sides (i.e. MS and EUSE) are getting notified, and the
transaction is being released.

By default, the timer expires after 30 seconds. As soon as
either the MS, or an EUSE initiates any activity,
the watchdog timer is rescheduled.

The timeout value can be configured from the VTY:

  msc
   ...
   ! Use 0 to disable this timer
   ncss guard-timeout 30

This change makes TC_lu_and_ss_session_timeout pass.

Change-Id: Icf4d87c45e90324764073e8230e0fb9cb96dd9cb
Related Change-Id: (TTCN) I3e1791773d56617172ae27a46889a1ae4d400e2f
Related: OS#3655
---
M include/osmocom/msc/gsm_data.h
M include/osmocom/msc/transaction.h
M src/libmsc/gsm_09_11.c
M src/libmsc/msc_vty.c
M src/libmsc/osmo_msc.c
M tests/test_nodes.vty
6 files changed, 86 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/92/11992/11
--
To view, visit https://gerrit.osmocom.org/11992
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icf4d87c45e90324764073e8230e0fb9cb96dd9cb
Gerrit-Change-Number: 11992
Gerrit-PatchSet: 11
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: daniel 
Gerrit-CC: Stefan Sperling

Change in osmo-msc[master]: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions

2019-02-10 Thread Vadim Yanitskiy 
Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11992 )

Change subject: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions
..


Patch Set 10:

(4 comments)

https://gerrit.osmocom.org/#/c/11992/10//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11992/10//COMMIT_MSG@9
PS10, Line 9: ESME
> EUSE?
Ahh, sure. Thanks!


https://gerrit.osmocom.org/#/c/11992/10/include/osmocom/msc/transaction.h
File include/osmocom/msc/transaction.h:

https://gerrit.osmocom.org/#/c/11992/10/include/osmocom/msc/transaction.h@89
PS10, Line 89: watchdog;
> in the CC sub-struct above we call it "timer_guard". […]
Done.


https://gerrit.osmocom.org/#/c/11992/10/src/libmsc/gsm_09_11.c
File src/libmsc/gsm_09_11.c:

https://gerrit.osmocom.org/#/c/11992/10/src/libmsc/gsm_09_11.c@153
PS10, Line 153: if (conn->network->ncss_guard_timeout > 0) {
> This seems like possible race condition if you disable the ncss_guard_timeout 
> from VTY while USSD se […]
Hmm, I am not sure if we really need to care about changing the configuration 
at run-time...


https://gerrit.osmocom.org/#/c/11992/10/src/libmsc/gsm_09_11.c@156
PS10, Line 156: }
> else if (osmo_timer_pending(>ss.watchdog)) { […]
This solution wouldn't help if the timer is disabled from the VTY, but there is 
no any activity on a given session. A proper solution would be to reschedule 
all NCSS timers from the VTY command handler...



--
To view, visit https://gerrit.osmocom.org/11992
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf4d87c45e90324764073e8230e0fb9cb96dd9cb
Gerrit-Change-Number: 11992
Gerrit-PatchSet: 10
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: daniel 
Gerrit-CC: Stefan Sperling 
Gerrit-Comment-Date: Sun, 10 Feb 2019 13:07:18 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No