Change in pysim[master]: Implement Generic SIM Access interface as per 3GPP TS 27.007
herlesupreeth has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18159 ) Change subject: Implement Generic SIM Access interface as per 3GPP TS 27.007 .. Patch Set 6: > Patch Set 6: Code-Review+2 wow!! cool feature. I was planning to implement the similar SIM carding reading on the Android Device itself using UICC Carrier Privileges. This could be a nice start for me :) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/18159 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I20bc00315e2c7c298f46283852865c1416047bc6 Gerrit-Change-Number: 18159 Gerrit-PatchSet: 6 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: fixeria Gerrit-Reviewer: herlesupreeth Gerrit-Reviewer: laforge Gerrit-CC: gui...@gmail.com Gerrit-Comment-Date: Wed, 03 Jun 2020 05:54:08 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in pysim[master]: Implement Generic SIM Access interface as per 3GPP TS 27.007
herlesupreeth has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18159 ) Change subject: Implement Generic SIM Access interface as per 3GPP TS 27.007 .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/18159 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I20bc00315e2c7c298f46283852865c1416047bc6 Gerrit-Change-Number: 18159 Gerrit-PatchSet: 6 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: fixeria Gerrit-Reviewer: herlesupreeth Gerrit-Reviewer: laforge Gerrit-CC: gui...@gmail.com Gerrit-Comment-Date: Wed, 03 Jun 2020 05:52:29 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Build failure of network:osmocom:latest/libusrp in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libusrp/Debian_Unstable/x86_64 Package network:osmocom:latest/libusrp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libusrp Last lines of build log: [ 440s] touch libfx2.lib [ 440s] for obj in delay.rel fx2utils.rel i2c.rel isr.rel timer.rel usb_common.rel; do basename $obj .rel >> libfx2.lib ; done [ 440s] make[4]: Leaving directory '/usr/src/packages/BUILD/firmware/lib' [ 440s] Making all in src [ 440s] make[4]: Entering directory '/usr/src/packages/BUILD/firmware/src' [ 440s] Making all in common [ 440s] make[5]: Entering directory '/usr/src/packages/BUILD/firmware/src/common' [ 440s] srcdir=. ./edit-gpif ./gpif.c usrp_gpif.c usrp_gpif_inline.h [ 440s] /usr/bin/env: 'python': No such file or directory [ 440s] make[5]: *** [Makefile:523: usrp_gpif.c] Error 127 [ 440s] make[5]: Leaving directory '/usr/src/packages/BUILD/firmware/src/common' [ 440s] make[4]: *** [Makefile:405: all-recursive] Error 1 [ 440s] make[4]: Leaving directory '/usr/src/packages/BUILD/firmware/src' [ 440s] make[3]: *** [Makefile:405: all-recursive] Error 1 [ 440s] make[3]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 440s] make[2]: *** [Makefile:626: all-recursive] Error 1 [ 440s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 440s] make[1]: *** [Makefile:547: all] Error 2 [ 440s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 440s] dh_auto_build: error: make -j1 returned exit code 2 [ 440s] make: *** [debian/rules:13: build] Error 25 [ 440s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 440s] ### VM INTERACTION START ### [ 443s] [ 377.020591] sysrq: SysRq : Power Off [ 443s] [ 377.037914] reboot: Power down [ 443s] ### VM INTERACTION END ### [ 443s] [ 443s] cloud119 failed "build libusrp_3.4.4.dsc" at Wed Jun 3 04:29:28 UTC 2020. [ 443s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libusrp in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libusrp/Debian_Unstable/x86_64 Package network:osmocom:nightly/libusrp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libusrp Last lines of build log: [ 158s] touch libfx2.lib [ 158s] for obj in delay.rel fx2utils.rel i2c.rel isr.rel timer.rel usb_common.rel; do basename $obj .rel >> libfx2.lib ; done [ 158s] make[4]: Leaving directory '/usr/src/packages/BUILD/firmware/lib' [ 158s] Making all in src [ 158s] make[4]: Entering directory '/usr/src/packages/BUILD/firmware/src' [ 158s] Making all in common [ 158s] make[5]: Entering directory '/usr/src/packages/BUILD/firmware/src/common' [ 158s] srcdir=. ./edit-gpif ./gpif.c usrp_gpif.c usrp_gpif_inline.h [ 158s] /usr/bin/env: 'python': No such file or directory [ 158s] make[5]: *** [Makefile:523: usrp_gpif.c] Error 127 [ 158s] make[5]: Leaving directory '/usr/src/packages/BUILD/firmware/src/common' [ 158s] make[4]: *** [Makefile:405: all-recursive] Error 1 [ 158s] make[4]: Leaving directory '/usr/src/packages/BUILD/firmware/src' [ 158s] make[3]: *** [Makefile:405: all-recursive] Error 1 [ 158s] make[3]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 158s] make[2]: *** [Makefile:635: all-recursive] Error 1 [ 158s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 158s] make[1]: *** [Makefile:554: all] Error 2 [ 158s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 158s] dh_auto_build: error: make -j1 returned exit code 2 [ 158s] make: *** [debian/rules:13: build] Error 25 [ 158s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 158s] ### VM INTERACTION START ### [ 161s] [ 150.075364] sysrq: SysRq : Power Off [ 161s] [ 150.079813] reboot: Power down [ 161s] ### VM INTERACTION END ### [ 161s] [ 161s] sheep86 failed "build libusrp_3.4.4.7.50ce.dsc" at Wed Jun 3 01:36:54 UTC 2020. [ 161s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Change in osmo-gsm-tester[master]: enb_srs: add extra head room for max rate with 6 PRB in MIMO mode
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18636 ) Change subject: enb_srs: add extra head room for max rate with 6 PRB in MIMO mode .. Patch Set 1: Code-Review+2 Don't you need to add the same for amarisoft_enb? -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18636 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I63888435553bba4f7be88cc745e24472921a7fb4 Gerrit-Change-Number: 18636 Gerrit-PatchSet: 1 Gerrit-Owner: srs_andre Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 21:23:54 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: enb: use 11.52e6 as base_srate for 25 PRB
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18637 ) Change subject: enb: use 11.52e6 as base_srate for 25 PRB .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18637 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I53678587b2c5e0e5dccb1b55a328ad2f1a97fc4c Gerrit-Change-Number: 18637 Gerrit-PatchSet: 1 Gerrit-Owner: srs_andre Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 02 Jun 2020 21:21:29 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-msc[master]: vlr_subscr_rx_id_resp(): dont assert on received MI type
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/18635 ) Change subject: vlr_subscr_rx_id_resp(): dont assert on received MI type .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/18635/1/src/libvlr/vlr.c File src/libvlr/vlr.c: https://gerrit.osmocom.org/c/osmo-msc/+/18635/1/src/libvlr/vlr.c@1175 PS1, Line 1175: return -EINVAL; AFAIU since you return above in this caase, you can drop the default case altogether here. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/18635 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I2b2e25ef8e878e91a165018ba49f1609cfb5cbd0 Gerrit-Change-Number: 18635 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 21:20:35 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: library/RSL_Emulation: cosmetic: improve logging messages
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18638 ) Change subject: library/RSL_Emulation: cosmetic: improve logging messages .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18638 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iefb6bc96e57822e216f8d8480337e6b4afc4d892 Gerrit-Change-Number: 18638 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 21:18:09 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: BTS_Tests: fix f_init_rsl(): expect all 4 transceivers to connect
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18633 ) Change subject: BTS_Tests: fix f_init_rsl(): expect all 4 transceivers to connect .. Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18633/3/bts/BTS_Tests.ttcn File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18633/3/bts/BTS_Tests.ttcn@216 PS3, Line 216: } Can't it happen that you still receive a RF_RES_IND after this and makes test fail later? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18633 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I32bb6d37929cde420a547e18eeb2f940e833316b Gerrit-Change-Number: 18633 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 21:13:25 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: library/RSL_Emulation: cosmetic: improve logging messages
Vadim Yanitskiy has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18638 )
Change subject: library/RSL_Emulation: cosmetic: improve logging messages
..
library/RSL_Emulation: cosmetic: improve logging messages
Change-Id: Iefb6bc96e57822e216f8d8480337e6b4afc4d892
---
M library/RSL_Emulation.ttcn
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/38/18638/1
diff --git a/library/RSL_Emulation.ttcn b/library/RSL_Emulation.ttcn
index eeb5ed5..9a07417 100644
--- a/library/RSL_Emulation.ttcn
+++ b/library/RSL_Emulation.ttcn
@@ -183,7 +183,7 @@
return i;
}
}
- log("No Dchan handler for ", comp_ref);
+ log("No Dchan handler for comp_ref=", comp_ref);
return -1;
}
@@ -196,7 +196,7 @@
return i;
}
}
- log("No Dchan handler for ", trx_nr, chan_nr);
+ log("No Dchan handler for trx_nr=", trx_nr, " and chan_nr=", chan_nr);
return -1;
}
@@ -209,7 +209,7 @@
return i;
}
}
- log("No Dchan handler for ", ra, fn);
+ log("No Dchan handler for ra=", ra, " and fn=", fn);
return -1;
}
@@ -226,7 +226,7 @@
}
}
}
- log("No Dchan handler for ", ra, fn);
+ log("No Dchan handler for ra=", ra, " and fn=", fn);
return -1;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18638
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iefb6bc96e57822e216f8d8480337e6b4afc4d892
Gerrit-Change-Number: 18638
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy
Gerrit-MessageType: newchange
Change in libosmo-netif[master]: src/stream: Work around more Linux kernel ABI breakage
laforge has submitted this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/18628 )
Change subject: src/stream: Work around more Linux kernel ABI breakage
..
src/stream: Work around more Linux kernel ABI breakage
Back in Change-Id Ia95dd1f9ffed9f743c049e05797b1a6f1f9f8c69 we tried
to work-around kernel ABI breakage introduced in kernel >= v5.5, but it
seems that there have already been similar ABI breakages in v4.11 and v4.12.
See
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/include/uapi/linux/sctp.h?id=b6e6b5f1da7e8d092f86a4351802c27c0170c5a5
and https://marc.info/?l=linux-sctp=158729301516157=2 for the most
recent incarnation.
See https://osmocom.org/issues/4573#note-6 for all known cases
of SCTP_EVENTS ABI breakage.
Closes: OS#4573
Change-Id: Icc49f347cdc0bb77a5c0e230597d662ac35b4acc
---
M src/stream.c
1 file changed, 93 insertions(+), 20 deletions(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/stream.c b/src/stream.c
index 6e4c461..44ac1b4 100644
--- a/src/stream.c
+++ b/src/stream.c
@@ -73,6 +73,97 @@
#define MSG_NOSIGNAL 0
#endif
+/* is any of the bytes from offset .. u8_size in 'u8' non-zero? return offset
or -1 if all zero */
+static int byte_nonzero(const uint8_t *u8, unsigned int offset, unsigned int
u8_size)
+{
+ int j;
+
+ for (j = offset; j < u8_size; j++) {
+ if (u8[j] != 0)
+ return j;
+ }
+
+ return -1;
+}
+
+static int sctp_sockopt_event_subscribe_size = 0;
+
+static int determine_sctp_sockopt_event_subscribe_size(void)
+{
+ uint8_t buf[256];
+ socklen_t buf_len = sizeof(buf);
+ int sd, rc;
+
+ /* only do this once */
+ if (sctp_sockopt_event_subscribe_size != 0)
+ return 0;
+
+ sd = socket(AF_INET, SOCK_STREAM, IPPROTO_SCTP);
+ if (sd < 0)
+ return sd;
+
+ rc = getsockopt(sd, IPPROTO_SCTP, SCTP_EVENTS, buf, _len);
+ if (rc < 0)
+ return rc;
+
+ sctp_sockopt_event_subscribe_size = buf_len;
+
+ LOGP(DLINP, LOGL_INFO, "sizes of 'struct sctp_event_subscribe':
compile-time %zu, kernel: %u\n",
+ sizeof(struct sctp_event_subscribe),
sctp_sockopt_event_subscribe_size);
+ return 0;
+}
+
+/* Attempt to work around Linux kernel ABI breakage
+ *
+ * The Linux kernel ABI for the SCTP_EVENTS socket option has been broken
repeatedly.
+ * - until commit 35ea82d611da59f8bea44a37996b3b11bb1d3fd7 ( kernel < 4.11),
the size is 10 bytes
+ * - in 4.11 it is 11 bytes
+ * - in 4.12 .. 5.4 it is 13 bytes
+ * - in kernels >= 5.5 it is 14 bytes
+ *
+ * This wouldn't be a problem if the kernel didn't have a "stupid" assumption
that the structure
+ * size passed by userspace will match 1:1 the length of the structure at
kernel compile time. In
+ * an ideal world, it would just use the known first bytes and assume the
remainder is all zero.
+ * But as it doesn't do that, let's try to work around this */
+static int sctp_setsockopt_events_linux_workaround(int fd, const struct
sctp_event_subscribe *event)
+{
+
+ const unsigned int compiletime_size = sizeof(*event);
+ int rc;
+
+ if (determine_sctp_sockopt_event_subscribe_size() < 0) {
+ LOGP(DLINP, LOGL_ERROR, "Cannot determine SCTP_EVENTS socket
option size\n");
+ return -1;
+ }
+
+ if (compiletime_size == sctp_sockopt_event_subscribe_size) {
+ /* no kernel workaround needed */
+ return setsockopt(fd, IPPROTO_SCTP, SCTP_EVENTS, event,
compiletime_size);
+ } else if (compiletime_size < sctp_sockopt_event_subscribe_size) {
+ /* we are using an older userspace with a more modern kernel
and hence need
+* to pad the data */
+ uint8_t buf[sctp_sockopt_event_subscribe_size];
+
+ memcpy(buf, event, compiletime_size);
+ memset(buf + sizeof(*event), 0,
sctp_sockopt_event_subscribe_size - compiletime_size);
+ return setsockopt(fd, IPPROTO_SCTP, SCTP_EVENTS, buf,
sctp_sockopt_event_subscribe_size);
+ } else /* if (compiletime_size > sctp_sockopt_event_subscribe_size) */ {
+ /* we are using a newer userspace with an older kernel and
hence need to truncate
+* the data - but only if the caller didn't try to enable any
of the events of the
+* truncated portion */
+ rc = byte_nonzero((const uint8_t *)event,
sctp_sockopt_event_subscribe_size,
+ compiletime_size);
+ if (rc >= 0) {
+ LOGP(DLINP, LOGL_ERROR, "Kernel only supports
sctp_event_subscribe of %u bytes, "
+ "but caller tried to enable more modern event
at offset %u\n",
+
Change in libosmo-netif[master]: src/stream: Work around more Linux kernel ABI breakage
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/18628 ) Change subject: src/stream: Work around more Linux kernel ABI breakage .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/18628 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Icc49f347cdc0bb77a5c0e230597d662ac35b4acc Gerrit-Change-Number: 18628 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 20:54:02 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: enb: use 11.52e6 as base_srate for 25 PRB
srs_andre has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18637 ) Change subject: enb: use 11.52e6 as base_srate for 25 PRB .. enb: use 11.52e6 as base_srate for 25 PRB With 25 PRB we've been using 5.76e6 as base sample rate which seems to create some issue during the tests like: [zmq] Error: tx time is 0.178 ms in the past (7833600 < 7835648) [zmq] Error: tx time is 0.011 ms in the past (7835520 < 7835648) Using a higher sample rate seems to work better Change-Id: I53678587b2c5e0e5dccb1b55a328ad2f1a97fc4c --- M src/osmo_gsm_tester/obj/enb.py 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/37/18637/1 diff --git a/src/osmo_gsm_tester/obj/enb.py b/src/osmo_gsm_tester/obj/enb.py index 699b66f..6753700 100644 --- a/src/osmo_gsm_tester/obj/enb.py +++ b/src/osmo_gsm_tester/obj/enb.py @@ -146,8 +146,6 @@ return 128 if num_prb <= 15: return 256 -if num_prb <= 25: -return 384 if num_prb <= 50: return 768 if num_prb <= 75: -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18637 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I53678587b2c5e0e5dccb1b55a328ad2f1a97fc4c Gerrit-Change-Number: 18637 Gerrit-PatchSet: 1 Gerrit-Owner: srs_andre Gerrit-MessageType: newchange
Change in osmo-gsm-tester[master]: 4g_suite: add MT and MO test cases
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18539 to look at the new patch set (#4). Change subject: 4g_suite: add MT and MO test cases .. 4g_suite: add MT and MO test cases add two new test cases to test paging (MT) and MO traffic Change-Id: I5c7639f2c6953964a5b6979bc35f59464dbda43f --- A sysmocom/suites/4g/rrc_idle_mo_ping.py A sysmocom/suites/4g/rrc_idle_mt_ping.py 2 files changed, 83 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/39/18539/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18539 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I5c7639f2c6953964a5b6979bc35f59464dbda43f Gerrit-Change-Number: 18539 Gerrit-PatchSet: 4 Gerrit-Owner: srs_andre Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Reviewer: srs_andre Gerrit-MessageType: newpatchset
Change in osmo-gsm-tester[master]: enb_srs: add extra head room for max rate with 6 PRB in MIMO mode
srs_andre has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18636 ) Change subject: enb_srs: add extra head room for max rate with 6 PRB in MIMO mode .. enb_srs: add extra head room for max rate with 6 PRB in MIMO mode the overhead with 6 PRB and MIMO is a bit higher when compared to other PRBs resulting in lower achievable throughput Change-Id: I63888435553bba4f7be88cc745e24472921a7fb4 --- M src/osmo_gsm_tester/obj/enb_srs.py 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/36/18636/1 diff --git a/src/osmo_gsm_tester/obj/enb_srs.py b/src/osmo_gsm_tester/obj/enb_srs.py index 33ee16b..2a05930 100644 --- a/src/osmo_gsm_tester/obj/enb_srs.py +++ b/src/osmo_gsm_tester/obj/enb_srs.py @@ -254,6 +254,9 @@ # MIMO only supported for Downlink if downlink and self._txmode > 2: max_rate *= 2 +# For 6 PRBs the max throughput is significantly lower +if self.num_prb() == 6: +max_rate *= 0.85 return max_rate -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18636 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I63888435553bba4f7be88cc745e24472921a7fb4 Gerrit-Change-Number: 18636 Gerrit-PatchSet: 1 Gerrit-Owner: srs_andre Gerrit-MessageType: newchange
Change in osmo-gsm-tester[master]: ms_srs: refactor UE state getter functions
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18535 to look at the new patch set (#4). Change subject: ms_srs: refactor UE state getter functions .. ms_srs: refactor UE state getter functions rename UE helper functions to query RRC connected/idle state and adapt tests accordingly also add helper to retrieve assinged IP address Change-Id: I6cd057e34b4df6a1a73695355dd6406d7e039546 --- M src/osmo_gsm_tester/obj/ms.py M src/osmo_gsm_tester/obj/ms_ofono.py M src/osmo_gsm_tester/obj/ms_srs.py M sysmocom/suites/4g/handover.py M sysmocom/suites/4g/iperf3_dl.py M sysmocom/suites/4g/iperf3_ul.py M sysmocom/suites/4g/ping.py 7 files changed, 40 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/35/18535/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18535 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I6cd057e34b4df6a1a73695355dd6406d7e039546 Gerrit-Change-Number: 18535 Gerrit-PatchSet: 4 Gerrit-Owner: srs_andre Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Reviewer: srs_andre Gerrit-MessageType: newpatchset
Change in osmo-ttcn3-hacks[master]: BTS_Tests: fix f_init_rsl(): expect all 4 transceivers to connect
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18633 ) Change subject: BTS_Tests: fix f_init_rsl(): expect all 4 transceivers to connect .. Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18633 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I32bb6d37929cde420a547e18eeb2f940e833316b Gerrit-Change-Number: 18633 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 20:41:46 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmo-netif[master]: src/stream: Work around more Linux kernel ABI breakage
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/18628 to look at the new patch set (#2). Change subject: src/stream: Work around more Linux kernel ABI breakage .. src/stream: Work around more Linux kernel ABI breakage Back in Change-Id Ia95dd1f9ffed9f743c049e05797b1a6f1f9f8c69 we tried to work-around kernel ABI breakage introduced in kernel >= v5.5, but it seems that there have already been similar ABI breakages in v4.11 and v4.12. See https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/include/uapi/linux/sctp.h?id=b6e6b5f1da7e8d092f86a4351802c27c0170c5a5 and https://marc.info/?l=linux-sctp=158729301516157=2 for the most recent incarnation. See https://osmocom.org/issues/4573#note-6 for all known cases of SCTP_EVENTS ABI breakage. Closes: OS#4573 Change-Id: Icc49f347cdc0bb77a5c0e230597d662ac35b4acc --- M src/stream.c 1 file changed, 93 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/28/18628/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/18628 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Icc49f347cdc0bb77a5c0e230597d662ac35b4acc Gerrit-Change-Number: 18628 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in osmo-msc[master]: vlr_subscr_rx_id_resp(): dont assert on received MI type
neels has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-msc/+/18635 )
Change subject: vlr_subscr_rx_id_resp(): dont assert on received MI type
..
vlr_subscr_rx_id_resp(): dont assert on received MI type
The Mobile Identity type is received on the wire, we asserting on its type
constitutes a DoS vector.
Change-Id: I2b2e25ef8e878e91a165018ba49f1609cfb5cbd0
---
M src/libvlr/vlr.c
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/35/18635/1
diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c
index 887ceb8..019e657 100644
--- a/src/libvlr/vlr.c
+++ b/src/libvlr/vlr.c
@@ -1146,6 +1146,8 @@
case GSM_MI_TYPE_IMEISV:
vlr_subscr_set_imeisv(vsub, mi_string);
break;
+ default:
+ return -EINVAL;
}
if (vsub->auth_fsm) {
@@ -1170,8 +1172,7 @@
event = VLR_ULA_E_ID_IMEISV;
break;
default:
- OSMO_ASSERT(0);
- break;
+ return -EINVAL;
}
osmo_fsm_inst_dispatch(vsub->lu_fsm, event, mi_string);
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/18635
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I2b2e25ef8e878e91a165018ba49f1609cfb5cbd0
Gerrit-Change-Number: 18635
Gerrit-PatchSet: 1
Gerrit-Owner: neels
Gerrit-MessageType: newchange
Change in osmo-msc[master]: manual: link to new common cs7-config.adoc, remove some dup of that
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/17580 ) Change subject: manual: link to new common cs7-config.adoc, remove some dup of that .. Patch Set 2: ping -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/17580 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie88dd2c7f7318a31ae04fbd6930346d92141fde5 Gerrit-Change-Number: 17580 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 20:06:26 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-msc[master]: manual: Multiple Instances: tweak MNCC, add missing SGs doc
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/18493 ) Change subject: manual: Multiple Instances: tweak MNCC, add missing SGs doc .. manual: Multiple Instances: tweak MNCC, add missing SGs doc Change-Id: Ice610e3db132dc50b7ddc3f3e324e8ad1bba5864 --- M doc/manuals/chapters/running.adoc 1 file changed, 19 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve neels: Looks good to me, approved diff --git a/doc/manuals/chapters/running.adoc b/doc/manuals/chapters/running.adoc index 4bd3913..e8320a7 100644 --- a/doc/manuals/chapters/running.adoc +++ b/doc/manuals/chapters/running.adoc @@ -74,9 +74,25 @@ More on SMPP configuration in <>. -The external MNCC handler is configured by the `--mncc-sock` commandline -argument. Choose a different such socket path for each OsmoMSC instance running -on the same file system. See more in <>. +The external MNCC handler is a UNIX domain socket that is created when external MNCC handling is configured. A separate +path must be used per osmo-msc instance: + + +msc + mncc external /tmp/mncc_socket + + +More on MNCC in <>. + +The SGs interface by default listens on 0.0.0.0:29118. Configure a different IP and/or port for each osmo-msc instance. +You may also want to configure different VLR names: + + +sgs + local-ip 127.0.0.1 + local-port 29118 + vlr-name vlr.example.net + For the following links, OsmoMSC acts as a client and does not listen/bind to a specific interface, and will hence not encounter conflicts for multiple instances -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/18493 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ice610e3db132dc50b7ddc3f3e324e8ad1bba5864 Gerrit-Change-Number: 18493 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-msc[master]: manual: Multiple Instances: tweak MNCC, add missing SGs doc
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/18493 ) Change subject: manual: Multiple Instances: tweak MNCC, add missing SGs doc .. Patch Set 1: Code-Review+2 relative triviality +2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/18493 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ice610e3db132dc50b7ddc3f3e324e8ad1bba5864 Gerrit-Change-Number: 18493 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 20:05:28 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-manuals[master]: trx_if: Clarify {SET; ADJ}POWER TRXC commands
Hoernchen has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/18556 )
Change subject: trx_if: Clarify {SET;ADJ}POWER TRXC commands
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/18556
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I4f1986a1ace3fc9cbef10fc0508407a3d608670b
Gerrit-Change-Number: 18556
Gerrit-PatchSet: 3
Gerrit-Owner: pespin
Gerrit-Reviewer: Hoernchen
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels
Gerrit-Reviewer: pespin
Gerrit-Reviewer: tnt
Gerrit-CC: laforge
Gerrit-Comment-Date: Tue, 02 Jun 2020 19:56:14 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in libosmo-netif[master]: src/stream: Work around more Linux kernel ABI breakage
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/18628 ) Change subject: src/stream: Work around more Linux kernel ABI breakage .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/libosmo-netif/+/18628/1/src/stream.c File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/18628/1/src/stream.c@100 PS1, Line 100: * But as it doesn't do that, let's try to work around this */ > In general, I think it is worth finding out the requried size only once and > storing it in a static s […] interesting idea. I just expanded on it by using getsockopt() to detect the actual expected size, this way we can avoid a lot of the trial-and-error. Will submit an updated patch later. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/18628 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Icc49f347cdc0bb77a5c0e230597d662ac35b4acc Gerrit-Change-Number: 18628 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 18:29:27 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in osmo-bts[master]: bts-trx: Use TRXC cmd NOMTXPOWER to retrieve nominal tx power from os...
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18589 ) Change subject: bts-trx: Use TRXC cmd NOMTXPOWER to retrieve nominal tx power from osmo-trx .. Patch Set 3: > Patch Set 3: > > > Patch Set 2: > > > As discussed previously, the idea is that for now we hardcode a set of > > values per device type after doing some measurements. We can later on add > > VTY configs as needed. > > Well, the user should always be able to override the compile-time defaults, > so if you don't add the vty command here, it should be introduced in a > follow-up patch. For sure it's not here since this is a osmo-bts-trx patch. I can add that later in osmo-trx, but let's first have this working with Roh providing some values, to see which kind of data we need to provide in the VTY (be it a table, or one factor, or whatever). -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I682211f3d664c21f923ca4a530e0464ca383b6d9 Gerrit-Change-Number: 18589 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: Hoernchen Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 02 Jun 2020 18:27:26 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-bts[master]: Do not mix public and private BTS features, use libosmocore's API
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18591 ) Change subject: Do not mix public and private BTS features, use libosmocore's API .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icf792d02323bb73e3b8d46384c7890cb1eb4731e Gerrit-Change-Number: 18591 Gerrit-PatchSet: 6 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 18:18:18 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: osmo-bts-omldummy: print a brief usage statement if argc < 3
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18631 ) Change subject: osmo-bts-omldummy: print a brief usage statement if argc < 3 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18631 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iff2e3c47ed12f02f75589e7bd0cccb5dab32d040 Gerrit-Change-Number: 18631 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 18:17:02 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: osmo-bts-omldummy: print a brief usage statement if argc < 3
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/18631 )
Change subject: osmo-bts-omldummy: print a brief usage statement if argc < 3
..
osmo-bts-omldummy: print a brief usage statement if argc < 3
Change-Id: Iff2e3c47ed12f02f75589e7bd0cccb5dab32d040
---
M src/osmo-bts-omldummy/main.c
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/src/osmo-bts-omldummy/main.c b/src/osmo-bts-omldummy/main.c
index 3f1d58c..8933860 100644
--- a/src/osmo-bts-omldummy/main.c
+++ b/src/osmo-bts-omldummy/main.c
@@ -14,6 +14,11 @@
struct e1inp_line *line;
int i;
+ if (argc < 3) {
+ fprintf(stderr, "Usage: %s dst_host site_id\n", argv[0]);
+ return 1;
+ }
+
char *dst_host = argv[1];
int site_id = atoi(argv[2]);
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18631
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iff2e3c47ed12f02f75589e7bd0cccb5dab32d040
Gerrit-Change-Number: 18631
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-bts[master]: osmo-bts-omldummy: make number of transceivers configurable
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/18632 )
Change subject: osmo-bts-omldummy: make number of transceivers configurable
..
osmo-bts-omldummy: make number of transceivers configurable
Change-Id: I712988a289c446c76dc4d9de0189fe448ae08e4d
Related: OS#4570
---
M src/osmo-bts-omldummy/main.c
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/src/osmo-bts-omldummy/main.c b/src/osmo-bts-omldummy/main.c
index 8933860..22d8758 100644
--- a/src/osmo-bts-omldummy/main.c
+++ b/src/osmo-bts-omldummy/main.c
@@ -15,12 +15,13 @@
int i;
if (argc < 3) {
- fprintf(stderr, "Usage: %s dst_host site_id\n", argv[0]);
+ fprintf(stderr, "Usage: %s dst_host site_id [trx_num]\n",
argv[0]);
return 1;
}
char *dst_host = argv[1];
int site_id = atoi(argv[2]);
+ int trx_num = argc > 3 ? atoi(argv[3]) : 8;
tall_bts_ctx = talloc_named_const(NULL, 1, "OsmoBTS context");
msgb_talloc_ctx_init(tall_bts_ctx, 10*1024);
@@ -34,7 +35,7 @@
bts->ip_access.bts_id = 0;
/* Additional TRXs */
- for (i = 1; i < 8; i++) {
+ for (i = 1; i < trx_num; i++) {
trx = gsm_bts_trx_alloc(bts);
if (!trx)
exit(1);
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18632
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I712988a289c446c76dc4d9de0189fe448ae08e4d
Gerrit-Change-Number: 18632
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-bts[master]: osmo-bts-omldummy: make number of transceivers configurable
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18632 ) Change subject: osmo-bts-omldummy: make number of transceivers configurable .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18632 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I712988a289c446c76dc4d9de0189fe448ae08e4d Gerrit-Change-Number: 18632 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 18:16:47 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: bts-trx: Use TRXC cmd NOMTXPOWER to retrieve nominal tx power from os...
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18589 ) Change subject: bts-trx: Use TRXC cmd NOMTXPOWER to retrieve nominal tx power from osmo-trx .. Patch Set 3: > Patch Set 2: > As discussed previously, the idea is that for now we hardcode a set of values > per device type after doing some measurements. We can later on add VTY > configs as needed. Well, the user should always be able to override the compile-time defaults, so if you don't add the vty command here, it should be introduced in a follow-up patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I682211f3d664c21f923ca4a530e0464ca383b6d9 Gerrit-Change-Number: 18589 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: Hoernchen Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 02 Jun 2020 17:59:30 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-bts[master]: bts-trx: Introduce helper func l1if_trx_set_nominal_power
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18588 ) Change subject: bts-trx: Introduce helper func l1if_trx_set_nominal_power .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18588 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I929fc50d544a88900d2e22317ec5ced10f15e51c Gerrit-Change-Number: 18588 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 02 Jun 2020 17:58:11 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: bts-trx: vty: Add 'nominal-tx-power' cmd
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18579 ) Change subject: bts-trx: vty: Add 'nominal-tx-power' cmd .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18579 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib1b6f80d3b54afc42db9d358a79582cc619c6ce4 Gerrit-Change-Number: 18579 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 17:57:04 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: bts-trx: Implement power ramping during BTS bring up
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18488 ) Change subject: bts-trx: Implement power ramping during BTS bring up .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18488 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia7c353e4c199e0fc3bcab55c45a4abda2c66d2c1 Gerrit-Change-Number: 18488 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-Comment-Date: Tue, 02 Jun 2020 17:57:56 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: tlv.h: add msgb_tvl_put() to add a TvLV without the value part
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18634 ) Change subject: tlv.h: add msgb_tvl_put() to add a TvLV without the value part .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18634 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I02cca5182fe42e40b63680a2fd470f03bcc11076 Gerrit-Change-Number: 18634 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 17:55:31 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gsm23236: add TMSI and NRI utility functions for MSC pooling
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18506 ) Change subject: gsm23236: add TMSI and NRI utility functions for MSC pooling .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18506 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icb57a2dd9323c7ea11b34003eccc7e68a0247bf5 Gerrit-Change-Number: 18506 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: Vadim Yanitskiy Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 17:53:59 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: BTS_Tests: fix f_init_rsl(): expect all 4 transceivers to connect
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18633 ) Change subject: BTS_Tests: fix f_init_rsl(): expect all 4 transceivers to connect .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18633 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I32bb6d37929cde420a547e18eeb2f940e833316b Gerrit-Change-Number: 18633 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 17:53:06 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: BTS_Tests: fix f_init_rsl(): expect all 4 transceivers to connect
pespin has uploaded a new patch set (#2) to the change originally created by Vadim Yanitskiy. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18633 ) Change subject: BTS_Tests: fix f_init_rsl(): expect all 4 transceivers to connect .. BTS_Tests: fix f_init_rsl(): expect all 4 transceivers to connect Change-Id: I32bb6d37929cde420a547e18eeb2f940e833316b Related: OS#4546 --- M bts/BTS_Tests.ttcn 1 file changed, 14 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/33/18633/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18633 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I32bb6d37929cde420a547e18eeb2f940e833316b Gerrit-Change-Number: 18633 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in libosmocore[master]: tlv.h: add msgb_tvl_put() to add a TvLV without the value part
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18634 ) Change subject: tlv.h: add msgb_tvl_put() to add a TvLV without the value part .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18634 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I02cca5182fe42e40b63680a2fd470f03bcc11076 Gerrit-Change-Number: 18634 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 17:17:17 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: tlv.h: add msgb_tvl_put() to add a TvLV without the value part
neels has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/18634 )
Change subject: tlv.h: add msgb_tvl_put() to add a TvLV without the value part
..
tlv.h: add msgb_tvl_put() to add a TvLV without the value part
So far, we have msgb_tl_put(), which allows putting the TL header of a TLV,
without the value part. Add the same for a variable-size length TvLV: put a TvL
header of a TvLV without the value part.
In a subsequent patch, osmo_mobile_identity will be introduced, which will
allow writing the encoded MI directly to the end of a msgb. For BSSGP_IE_IMSI,
which is a TvLV, it would hence be simplest to write only the TvL first.
Change-Id: I02cca5182fe42e40b63680a2fd470f03bcc11076
---
M include/osmocom/gsm/tlv.h
1 file changed, 45 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/34/18634/1
diff --git a/include/osmocom/gsm/tlv.h b/include/osmocom/gsm/tlv.h
index bb0e8fc..254c21b 100644
--- a/include/osmocom/gsm/tlv.h
+++ b/include/osmocom/gsm/tlv.h
@@ -111,6 +111,14 @@
return buf + len;
}
+/*! put (append) a TL field (a TLV field but omitting the value part). */
+static inline uint8_t *tl_put(uint8_t *buf, uint8_t tag, uint8_t len)
+{
+ *buf++ = tag;
+ *buf++ = len;
+ return buf;
+}
+
/*! put (append) a TLV16 field */
static inline uint8_t *tlv16_put(uint8_t *buf, uint8_t tag, uint8_t len,
const uint16_t *val)
@@ -132,6 +140,15 @@
return buf + len*2;
}
+/*! put (append) a TL16 field. */
+static inline uint8_t *tl16_put(uint8_t *buf, uint8_t tag, uint16_t len)
+{
+ *buf++ = tag;
+ *buf++ = len >> 8;
+ *buf++ = len & 0xff;
+ return buf;
+}
+
/*! put (append) a TL16V field */
static inline uint8_t *t16lv_put(uint8_t *buf, uint16_t tag, uint8_t len,
const uint8_t *val)
@@ -158,6 +175,23 @@
return ret;
}
+/*! put (append) a TvL field (a TvLV with variable-size length, where the
value part's length is already known, but will
+ * be put() later).
+ * \returns pointer to the value's start position.
+ */
+static inline uint8_t *tvl_put(uint8_t *buf, uint8_t tag, uint16_t len)
+{
+ uint8_t *ret;
+
+ if (len <= TVLV_MAX_ONEBYTE) {
+ ret = tl_put(buf, tag, len);
+ buf[1] |= 0x80;
+ } else
+ ret = tl16_put(buf, tag, len);
+
+ return ret;
+}
+
/*! put (append) a variable-length tag or variable-length length * */
static inline uint8_t *vt_gan_put(uint8_t *buf, uint16_t tag)
{
@@ -215,6 +249,17 @@
return t16lv_put(buf, tag, len, val);
}
+/*! put (append) a TvL field to \ref msgb, i.e. a TvLV with variable-size
length, where the value's length is already
+ * known, but will be put() later. The value section is not yet reserved, only
tag and variable-length are put in the
+ * msgb.
+ * \returns pointer to the value's start position and end of the msgb.
+ */
+static inline uint8_t *msgb_tvl_put(struct msgb *msg, uint8_t tag, uint16_t
len)
+{
+ uint8_t *buf = msgb_put(msg, TVLV_GROSS_LEN(len));
+ return tvl_put(buf, tag, len);
+}
+
/*! put (append) a TvLV field to \ref msgb */
static inline uint8_t *msgb_tvlv_put(struct msgb *msg, uint8_t tag, uint16_t
len,
const uint8_t *val)
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18634
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I02cca5182fe42e40b63680a2fd470f03bcc11076
Gerrit-Change-Number: 18634
Gerrit-PatchSet: 1
Gerrit-Owner: neels
Gerrit-MessageType: newchange
Change in libosmocore[master]: gsm23236: add TMSI and NRI utility functions for MSC pooling
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/18506 to look at the new patch set (#3). Change subject: gsm23236: add TMSI and NRI utility functions for MSC pooling .. gsm23236: add TMSI and NRI utility functions for MSC pooling These utilities will be used by osmo-bsc to determine the Network Resource Indicator seen in the TMSI, and by osmo-msc to compose a TMSI with a specific NRI, for osmo-bsc's load balancing between several MSCs. Related: OS#3682 Change-Id: Icb57a2dd9323c7ea11b34003eccc7e68a0247bf5 --- M include/Makefile.am A include/osmocom/gsm/gsm23236.h M src/gsm/Makefile.am A src/gsm/gsm23236.c M src/gsm/libosmogsm.map M tests/Makefile.am A tests/gsm23236/gsm23236_test.c A tests/gsm23236/gsm23236_test.ok M tests/testsuite.at 9 files changed, 394 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/06/18506/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18506 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icb57a2dd9323c7ea11b34003eccc7e68a0247bf5 Gerrit-Change-Number: 18506 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: Vadim Yanitskiy Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in osmo-ttcn3-hacks[master]: BTS_Tests: fix f_init_rsl(): expect all 4 transceivers to connect
Vadim Yanitskiy has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18633 )
Change subject: BTS_Tests: fix f_init_rsl(): expect all 4 transceivers to
connect
..
BTS_Tests: fix f_init_rsl(): expect all 4 transceivers to connect
Change-Id: I32bb6d37929cde420a547e18eeb2f940e833316b
Related: OS#4546
---
M bts/BTS_Tests.ttcn
1 file changed, 8 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/33/18633/1
diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 80804ec..ef67646 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -194,11 +194,15 @@
vc_RSL.start(RSL_Emulation.main(false));
T.start;
- alt {
- /* TODO: handle connection events from multiple transceivers */
- [] RSL_CCHAN.receive(tr_RSLEm_EV(RSLEM_EV_TRX_UP));
+ interleave {
+ /* We expect all 4 transceivers to connect here (separate IPA/RSL
connections).
+* See
https://gerrit.osmocom.org/q/Ib5ad31388ae25399ad09739aac3fdcb0b3a1f78b. */
+ [] RSL_CCHAN.receive(tr_RSLEm_EV(RSLEM_EV_TRX_UP, sid :=
IPAC_PROTO_RSL_TRX0));
+ [] RSL_CCHAN.receive(tr_RSLEm_EV(RSLEM_EV_TRX_UP, sid :=
IPAC_PROTO_RSL_TRX1));
+ [] RSL_CCHAN.receive(tr_RSLEm_EV(RSLEM_EV_TRX_UP, sid :=
IPAC_PROTO_RSL_TRX2));
+ [] RSL_CCHAN.receive(tr_RSLEm_EV(RSLEM_EV_TRX_UP, sid :=
IPAC_PROTO_RSL_TRX3));
[] T.timeout {
- Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout
waiting for ASP_IPA_EVENT_UP");
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout
waiting for RSLEM_EV_TRX_UP");
}
}
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18633
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I32bb6d37929cde420a547e18eeb2f940e833316b
Gerrit-Change-Number: 18633
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy
Gerrit-MessageType: newchange
Change in osmo-bts[master]: osmo-bts-omldummy: make number of transceivers configurable
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18632 ) Change subject: osmo-bts-omldummy: make number of transceivers configurable .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18632 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I712988a289c446c76dc4d9de0189fe448ae08e4d Gerrit-Change-Number: 18632 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 16:49:07 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: osmo-bts-omldummy: print a brief usage statement if argc < 3
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18631 ) Change subject: osmo-bts-omldummy: print a brief usage statement if argc < 3 .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18631 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iff2e3c47ed12f02f75589e7bd0cccb5dab32d040 Gerrit-Change-Number: 18631 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 16:48:35 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gsm23236: add TMSI and NRI utility functions for MSC pooling
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18506 ) Change subject: gsm23236: add TMSI and NRI utility functions for MSC pooling .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/18506/2/src/gsm/gsm23236.c File src/gsm/gsm23236.c: https://gerrit.osmocom.org/c/libosmocore/+/18506/2/src/gsm/gsm23236.c@36 PS2, Line 36: int16_t The function itself returns an error code: > \return 0 on success, negative on error (i.e. if nri_bitlen is not in the > valid range). and this is fine. Let's either make it return NRI, so it can be negative in case of an error, or change pointer type to 'uint16_t *'. The current function signature is confusing. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18506 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icb57a2dd9323c7ea11b34003eccc7e68a0247bf5 Gerrit-Change-Number: 18506 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: Vadim Yanitskiy Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 15:49:58 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Vadim Yanitskiy Comment-In-Reply-To: neels Gerrit-MessageType: comment
Change in osmo-bts[master]: osmo-bts-omldummy: print a brief usage statement if argc < 3
Vadim Yanitskiy has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bts/+/18631 )
Change subject: osmo-bts-omldummy: print a brief usage statement if argc < 3
..
osmo-bts-omldummy: print a brief usage statement if argc < 3
Change-Id: Iff2e3c47ed12f02f75589e7bd0cccb5dab32d040
---
M src/osmo-bts-omldummy/main.c
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/31/18631/1
diff --git a/src/osmo-bts-omldummy/main.c b/src/osmo-bts-omldummy/main.c
index 3f1d58c..8933860 100644
--- a/src/osmo-bts-omldummy/main.c
+++ b/src/osmo-bts-omldummy/main.c
@@ -14,6 +14,11 @@
struct e1inp_line *line;
int i;
+ if (argc < 3) {
+ fprintf(stderr, "Usage: %s dst_host site_id\n", argv[0]);
+ return 1;
+ }
+
char *dst_host = argv[1];
int site_id = atoi(argv[2]);
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18631
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iff2e3c47ed12f02f75589e7bd0cccb5dab32d040
Gerrit-Change-Number: 18631
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy
Gerrit-MessageType: newchange
Change in osmo-bts[master]: osmo-bts-omldummy: make number of transceivers configurable
Vadim Yanitskiy has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bts/+/18632 )
Change subject: osmo-bts-omldummy: make number of transceivers configurable
..
osmo-bts-omldummy: make number of transceivers configurable
Change-Id: I712988a289c446c76dc4d9de0189fe448ae08e4d
Related: OS#4570
---
M src/osmo-bts-omldummy/main.c
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/32/18632/1
diff --git a/src/osmo-bts-omldummy/main.c b/src/osmo-bts-omldummy/main.c
index 8933860..22d8758 100644
--- a/src/osmo-bts-omldummy/main.c
+++ b/src/osmo-bts-omldummy/main.c
@@ -15,12 +15,13 @@
int i;
if (argc < 3) {
- fprintf(stderr, "Usage: %s dst_host site_id\n", argv[0]);
+ fprintf(stderr, "Usage: %s dst_host site_id [trx_num]\n",
argv[0]);
return 1;
}
char *dst_host = argv[1];
int site_id = atoi(argv[2]);
+ int trx_num = argc > 3 ? atoi(argv[3]) : 8;
tall_bts_ctx = talloc_named_const(NULL, 1, "OsmoBTS context");
msgb_talloc_ctx_init(tall_bts_ctx, 10*1024);
@@ -34,7 +35,7 @@
bts->ip_access.bts_id = 0;
/* Additional TRXs */
- for (i = 1; i < 8; i++) {
+ for (i = 1; i < trx_num; i++) {
trx = gsm_bts_trx_alloc(bts);
if (!trx)
exit(1);
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18632
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I712988a289c446c76dc4d9de0189fe448ae08e4d
Gerrit-Change-Number: 18632
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy
Gerrit-MessageType: newchange
Change in libosmocore[master]: gsm23236: add TMSI and NRI utility functions for MSC pooling
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18506 ) Change subject: gsm23236: add TMSI and NRI utility functions for MSC pooling .. Patch Set 2: (1 comment) This change is ready for review. https://gerrit.osmocom.org/c/libosmocore/+/18506/2/src/gsm/gsm23236.c File src/gsm/gsm23236.c: https://gerrit.osmocom.org/c/libosmocore/+/18506/2/src/gsm/gsm23236.c@36 PS2, Line 36: int16_t > Why is it signed? Can the NRI be negative? In the end, no real reason, just "why not". The NRI is normally <= 10 bit wide, as per 3GPP TS 23.236. (I'm going to allow up to 15 bits, because there is no hard limit up to 24 bits, but 15 is also far above what anyone would likely ever use.) I want to use negative NRI to indicate invalid or that none has been set. Come to think of it, I think I'm not actually using that anywhere now that these functions return an error code instead of an NRI, but it seems a good idea to keep some room in the definition from the start, since we are getting it for free. The easiest is to take <0 meaning invalid, given the ample unused number space. We could also use 'int', actually. Just thought the int16_t might be more specific on how little of the int will really be used. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18506 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icb57a2dd9323c7ea11b34003eccc7e68a0247bf5 Gerrit-Change-Number: 18506 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: Vadim Yanitskiy Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 15:23:22 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Vadim Yanitskiy Gerrit-MessageType: comment
Change in pysim[master]: Implement Generic SIM Access interface as per 3GPP TS 27.007
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18159 ) Change subject: Implement Generic SIM Access interface as per 3GPP TS 27.007 .. Patch Set 6: Verified+1 Setting it on your behalf then ;) Thanks for testing. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/18159 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I20bc00315e2c7c298f46283852865c1416047bc6 Gerrit-Change-Number: 18159 Gerrit-PatchSet: 6 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: gui...@gmail.com Gerrit-Comment-Date: Tue, 02 Jun 2020 15:03:39 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in pysim[master]: Implement Generic SIM Access interface as per 3GPP TS 27.007
gui...@gmail.com has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18159 ) Change subject: Implement Generic SIM Access interface as per 3GPP TS 27.007 .. Patch Set 6: > Patch Set 6: > > Should be fixed now. Please let me know (set Verified+1) if it works for you. > Thanks! It does work for me know, both python2 and python3 - but cannot set it to verified, no permissions! -- To view, visit https://gerrit.osmocom.org/c/pysim/+/18159 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I20bc00315e2c7c298f46283852865c1416047bc6 Gerrit-Change-Number: 18159 Gerrit-PatchSet: 6 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: gui...@gmail.com Gerrit-Comment-Date: Tue, 02 Jun 2020 15:00:24 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in pysim[master]: Implement Generic SIM Access interface as per 3GPP TS 27.007
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18159 ) Change subject: Implement Generic SIM Access interface as per 3GPP TS 27.007 .. Patch Set 6: Should be fixed now. Please let me know (set Verified+1) if it works for you. Thanks! -- To view, visit https://gerrit.osmocom.org/c/pysim/+/18159 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I20bc00315e2c7c298f46283852865c1416047bc6 Gerrit-Change-Number: 18159 Gerrit-PatchSet: 6 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: gui...@gmail.com Gerrit-Comment-Date: Tue, 02 Jun 2020 14:52:30 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in pysim[master]: Implement Generic SIM Access interface as per 3GPP TS 27.007
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18159 ) Change subject: Implement Generic SIM Access interface as per 3GPP TS 27.007 .. Patch Set 5: > yes, I was running it with python 2, I thought it was not upgraded to 3. The > header of pySim-read still uses python2 :-) I fixed most of the problems like print without parentheses, so pySim works fine with Python 3 ;) Unfortunately, yes, we still have Python 2 in headers. The reason is that our test setup is based on old Debian image that ships ancient Python 3.5 from 2017 and old pyscard. Somehow this combination breaks our lazy 'match every line' unit tests. See https://gerrit.osmocom.org/c/pysim/+/15504/. > Still, if cmd is not a str, you will not initialise bcmd, so probably need to > add something in the else? Ah, I got what you mean now. Will try to fix soon. Thanks! -- To view, visit https://gerrit.osmocom.org/c/pysim/+/18159 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I20bc00315e2c7c298f46283852865c1416047bc6 Gerrit-Change-Number: 18159 Gerrit-PatchSet: 5 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-CC: gui...@gmail.com Gerrit-Comment-Date: Tue, 02 Jun 2020 14:08:56 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-mgw[master]: osmo-mgw: refactor endpoint and trunk handling
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/18372 )
Change subject: osmo-mgw: refactor endpoint and trunk handling
..
Patch Set 7: Code-Review-1
(21 comments)
Nice, a lot of excellent cleanup work!
I hope you see the large number of comments as appreciation of the patch.
May seem ironic from me as Mr. Code Bomb himself, but this patch would be
fairly easy to split into smaller parts. I'm thinking the deprecation of the
sdp audio name vty commands, some renames, and ideally moving old code to new
files first without changing them so that code review can easily see the
changes made to the code?
The -1 vote is for the DEFUN_DEPRECATED, and missing items in the commit log
(or alternatively splitting up the patch), and the talloc_free of
trunk->endpoints.
Anyway, cool to see osmo-mgw being streamlined :)
https://gerrit.osmocom.org/c/osmo-mgw/+/18372/7//COMMIT_MSG
Commit Message:
https://gerrit.osmocom.org/c/osmo-mgw/+/18372/7//COMMIT_MSG@21
PS7, Line 21:symbol name "tcfg" to "trunk" in order to better match the
reality.
(maybe do renames in a separate patch)
https://gerrit.osmocom.org/c/osmo-mgw/+/18372/7//COMMIT_MSG@28
PS7, Line 28:longer allocate them per trunk. Allocate them globally instead.
I'm wondering whether anyone would miss per-trunk counters in the future. I
don't know of anyone using more than one trunk, but if we have multiple trunks
supported in the code, maybe per-trunk counters would be nicer to keep than to
remove?
https://gerrit.osmocom.org/c/osmo-mgw/+/18372/7/include/osmocom/mgcp/mgcp.h
File include/osmocom/mgcp/mgcp.h:
https://gerrit.osmocom.org/c/osmo-mgw/+/18372/7/include/osmocom/mgcp/mgcp.h@a189
PS7, Line 189: char *audio_name;
: int audio_payload;
these are no longer present in struct mgcp_trunk, maybe explain why in the
commit log?
https://gerrit.osmocom.org/c/osmo-mgw/+/18372/7/include/osmocom/mgcp/mgcp_trunk.h
File include/osmocom/mgcp/mgcp_trunk.h:
https://gerrit.osmocom.org/c/osmo-mgw/+/18372/7/include/osmocom/mgcp/mgcp_trunk.h@38
PS7, Line 38: struct mgcp_endpoint **endpoints;
changing this from 'struct mgcp_endpoint*' to 'struct mgcp_endpoint**'.
What is the reason? If I see this right, we are anyway just allocating a fixed
number of endpoints at trunk creation time, and it seems unnecessary to add to
this the individual dynamic allocation for every contained endpoint?
https://gerrit.osmocom.org/c/osmo-mgw/+/18372/7/src/libosmo-mgcp/mgcp_codec.c
File src/libosmo-mgcp/mgcp_codec.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/18372/7/src/libosmo-mgcp/mgcp_codec.c@a289
PS7, Line 289:
this removal is not mentioned in the commit log. I guess it should be a
separate patch from the refactoring.
https://gerrit.osmocom.org/c/osmo-mgw/+/18372/7/src/libosmo-mgcp/mgcp_conn.c
File src/libosmo-mgcp/mgcp_conn.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/18372/7/src/libosmo-mgcp/mgcp_conn.c@259
PS7, Line 259: aggregate_rtp_conn_stats(struct mgcp_endpoint *endp, struct
mgcp_conn_rtp *conn_rtp)
This function does not access the individual endp, but accesses the single
global struct mgcp_ratectr. It would make more sense to pass a struct
mgcp_ratectr as argument, to reflect the fact that now there is only one global
set of counters (besides the per-conn counters).
https://gerrit.osmocom.org/c/osmo-mgw/+/18372/7/src/libosmo-mgcp/mgcp_endp.c
File src/libosmo-mgcp/mgcp_endp.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/18372/7/src/libosmo-mgcp/mgcp_endp.c@90
PS7, Line 90: /* Check if the endpoint name contains the prefix, and chop it
off, if it
(would be nice to include an example string for a prefix to make it easier to
understand for uninformed readers)
https://gerrit.osmocom.org/c/osmo-mgw/+/18372/7/src/libosmo-mgcp/mgcp_endp.c@140
PS7, Line 140: * \param[out] cause, pointer to store cause code, can be NULL.
(I think doxygen wants no comma after 'cause'?)
https://gerrit.osmocom.org/c/osmo-mgw/+/18372/7/src/libosmo-mgcp/mgcp_endp.c@141
PS7, Line 141: * \param[in] epname endpoint name to lookup (may lack trunk
prefix and domain name).
wildcard should be explained
https://gerrit.osmocom.org/c/osmo-mgw/+/18372/7/src/libosmo-mgcp/mgcp_endp.c@164
PS7, Line 164: if (strncmp(epname_ch, "*", epname_ch_len) == 0) {
If I get this right, with a full name, this function finds an existing (used?)
endpoint.
In this condition here, if the endpoint name is exactly "*", this finds the
first unused endpoint.
It feels to me like these should be two separate functions, one takes an epname
to look up, the other takes no epname and finds an unused one.
EDIT: I see now that this function was just moved to a different file...
https://gerrit.osmocom.org/c/osmo-mgw/+/18372/7/src/libosmo-mgcp/mgcp_endp.c@184
PS7, Line 184: /* Find an enspoint by its name (if wildcarded request is not
("enspoint")
Change in pysim[master]: Implement Generic SIM Access interface as per 3GPP TS 27.007
gui...@gmail.com has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18159 ) Change subject: Implement Generic SIM Access interface as per 3GPP TS 27.007 .. Patch Set 5: > Patch Set 5: > > (1 comment) yes, I was running it with python 2, I thought it was not upgraded to 3. The header of pySim-read still uses python2 :-) I was getting a unicode object, and that was exposing the problem. When running send_pdu, it was requesting extra data with this part, not sure why pdu_gr was type unicode if (sw is not None) and ((sw[0:2] == '9f') or (sw[0:2] == '61')): pdu_gr = pdu[0:2] + 'c0' + sw[2:4] data, sw = self.send_apdu_raw(pdu_gr) Still, if cmd is not a str, you will not initialise bcmd, so probably need to add something in the else? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/18159 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I20bc00315e2c7c298f46283852865c1416047bc6 Gerrit-Change-Number: 18159 Gerrit-PatchSet: 5 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-CC: gui...@gmail.com Gerrit-Comment-Date: Tue, 02 Jun 2020 13:52:06 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in pysim[master]: Implement Generic SIM Access interface as per 3GPP TS 27.007
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18159 ) Change subject: Implement Generic SIM Access interface as per 3GPP TS 27.007 .. Patch Set 5: (1 comment) https://gerrit.osmocom.org/c/pysim/+/18159/5/pySim/transport/modem_atcmd.py File pySim/transport/modem_atcmd.py: https://gerrit.osmocom.org/c/pysim/+/18159/5/pySim/transport/modem_atcmd.py@50 PS5, Line 50: if type(cmd) is str: > there is a problem here if cmd is not a string, as it's not initiliased. I am not getting what you mean here, sorry. If it's not a string, it should be bytes. > I thought the purpouse of this was to turn the string into bytes? Yes, as written in the comment above. Either it's a string, so we convert it to bytes, or it's already bytes, so we use it as-is. I guess you're still using Python 2? AFAIR, unlike Python 3, type(b'\xff') in Python 2 would be 'str', not 'bytes' as expected. If so, I am not going to fix / work around this. > bcmd = cmd.encode() This does not work with Python 3 :/ AttributeError: 'bytes' object has no attribute 'encode' -- To view, visit https://gerrit.osmocom.org/c/pysim/+/18159 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I20bc00315e2c7c298f46283852865c1416047bc6 Gerrit-Change-Number: 18159 Gerrit-PatchSet: 5 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-CC: gui...@gmail.com Gerrit-Comment-Date: Tue, 02 Jun 2020 13:22:23 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: gui...@gmail.com Gerrit-MessageType: comment
Change in pysim[master]: Implement Generic SIM Access interface as per 3GPP TS 27.007
gui...@gmail.com has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18159 ) Change subject: Implement Generic SIM Access interface as per 3GPP TS 27.007 .. Patch Set 5: (1 comment) > Patch Set 5: Verified+1 > > Build Successful > > https://jenkins.osmocom.org/jenkins/job/gerrit-pysim/540/ : SUCCESS' > --verified 1 --code-review 0 I can test this in other Quectel modules, have quite a few :-) At the moment, using a BG96, which is where having the ability to read the SIM files is definitely useful for debugging https://gerrit.osmocom.org/c/pysim/+/18159/5/pySim/transport/modem_atcmd.py File pySim/transport/modem_atcmd.py: https://gerrit.osmocom.org/c/pysim/+/18159/5/pySim/transport/modem_atcmd.py@50 PS5, Line 50: if type(cmd) is str: there is a problem here if cmd is not a string, as it's not initiliased. I solved by doing by adding to this if else: bcmd = cmd.encode() Not sure if it's the right way to do it, though. Don't fully get why you used str.encode instead of cmd, I thought the purpouse of this was to turn the string into bytes? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/18159 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I20bc00315e2c7c298f46283852865c1416047bc6 Gerrit-Change-Number: 18159 Gerrit-PatchSet: 5 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-CC: gui...@gmail.com Gerrit-Comment-Date: Tue, 02 Jun 2020 12:55:13 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-gsm-manuals[master]: trx_if: Clarify {SET; ADJ}POWER TRXC commands
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/18556 )
Change subject: trx_if: Clarify {SET;ADJ}POWER TRXC commands
..
Patch Set 3:
> Patch Set 3: Code-Review+1
>
> haven't checked about whether the commands work when the trx isn't running,
> but looks good to me
I have been working on all this and it makes sense to have it working, so you
can basically set any power before poweron. Mostly one would like to set power
attenuation to NOMTXPOWER.
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/18556
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I4f1986a1ace3fc9cbef10fc0508407a3d608670b
Gerrit-Change-Number: 18556
Gerrit-PatchSet: 3
Gerrit-Owner: pespin
Gerrit-Reviewer: Hoernchen
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels
Gerrit-Reviewer: pespin
Gerrit-Reviewer: tnt
Gerrit-CC: laforge
Gerrit-Comment-Date: Tue, 02 Jun 2020 12:49:05 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in osmo-gsm-manuals[master]: trx_if: Clarify {SET; ADJ}POWER TRXC commands
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/18556 )
Change subject: trx_if: Clarify {SET;ADJ}POWER TRXC commands
..
Patch Set 3: Code-Review+1
haven't checked about whether the commands work when the trx isn't running, but
looks good to me
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/18556
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I4f1986a1ace3fc9cbef10fc0508407a3d608670b
Gerrit-Change-Number: 18556
Gerrit-PatchSet: 3
Gerrit-Owner: pespin
Gerrit-Reviewer: Hoernchen
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels
Gerrit-Reviewer: pespin
Gerrit-Reviewer: tnt
Gerrit-CC: laforge
Gerrit-Comment-Date: Tue, 02 Jun 2020 12:44:55 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in osmo-gsm-manuals[master]: trx_if.adoc: Document cmd NOMTXPOWER
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/18630 ) Change subject: trx_if.adoc: Document cmd NOMTXPOWER .. Patch Set 1: Code-Review+2 nom nom -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/18630 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Idb5bb56fc039c7393922243c761f3395a094a55b Gerrit-Change-Number: 18630 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Comment-Date: Tue, 02 Jun 2020 12:42:13 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: Do not mix public and private BTS features, use libosmocore's API
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/18591 )
Change subject: Do not mix public and private BTS features, use libosmocore's
API
..
Patch Set 6: Code-Review+1
(5 comments)
only cosmetics...
mostly about the term choice of "implementation".
Did you mean "internal"? "BTS-model" / "BTS-type"?
https://gerrit.osmocom.org/c/osmo-bts/+/18591/6/include/osmo-bts/gsm_data_shared.h
File include/osmo-bts/gsm_data_shared.h:
https://gerrit.osmocom.org/c/osmo-bts/+/18591/6/include/osmo-bts/gsm_data_shared.h@461
PS6, Line 461: /* BTS implementation flags (internal use, not exposed via OML)
*/
(so maybe reflect "internal" in the naming? bts_internal_flag_get(),
bts_internal_flag_set()?)
https://gerrit.osmocom.org/c/osmo-bts/+/18591/6/include/osmo-bts/gsm_data_shared.h@465
PS6, Line 465: (bts->flags |= (typeof(bts->flags)) flag)
(braces around this are slightly weird)
https://gerrit.osmocom.org/c/osmo-bts/+/18591/6/include/osmo-bts/gsm_data_shared.h@468
PS6, Line 468: #define BTS_IMPL_FLAG_MS_PWR_CTRL_DSP(1 << 0)
( s/IMPL/INTERNAL/ ?)
https://gerrit.osmocom.org/c/osmo-bts/+/18591/6/src/common/vty.c
File src/common/vty.c:
https://gerrit.osmocom.org/c/osmo-bts/+/18591/6/src/common/vty.c@832
PS6, Line 832: for (i = 0, no_features = true; i < _NUM_BTS_FEAT; i++) {
(I'd rather leave the 'no_features = true' at the start of the function, above.
This looks like no_features is used as a loop condition; it does not affect the
loop, only what happens around the loop. So it doesn't qualify as a start
condition, really.)
https://gerrit.osmocom.org/c/osmo-bts/+/18591/6/src/common/vty.c@843
PS6, Line 843: vty_out(vty, " Implementation flags:%s", VTY_NEWLINE);
"Implementation" is a very general term, basically all code is implementation.
In the comments you used "internal flags", which I find easier to understand...
or "BTS model specific flags"?
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18591
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Icf792d02323bb73e3b8d46384c7890cb1eb4731e
Gerrit-Change-Number: 18591
Gerrit-PatchSet: 6
Gerrit-Owner: Vadim Yanitskiy
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy
Gerrit-Reviewer: laforge
Gerrit-Reviewer: neels
Gerrit-Reviewer: pespin
Gerrit-Comment-Date: Tue, 02 Jun 2020 12:40:58 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in libosmo-netif[master]: amr: fix off-by-one in osmo_amr_bwe_to_oa()
dexter has submitted this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/18451 )
Change subject: amr: fix off-by-one in osmo_amr_bwe_to_oa()
..
amr: fix off-by-one in osmo_amr_bwe_to_oa()
The for loop in osmo_amr_bwe_to_oa, that converts the body part of the
AMR payload runs one byte too far. This may cause that some of the
padding bits in the end are not set to zero. The loop is designed to
convert n-1 bytes and the nth byte is done separately at the end.
Change-Id: I91e755b83aaac722079879c026d913cc446812d1
---
M src/amr.c
M tests/amr/amr_test.c
M tests/amr/amr_test.ok
3 files changed, 10 insertions(+), 10 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/src/amr.c b/src/amr.c
index 980d6ad..2706432 100644
--- a/src/amr.c
+++ b/src/amr.c
@@ -198,7 +198,7 @@
return -1;
oa_payload_len = 2 + osmo_amr_bytes(oa_hdr->ft);
- for (i = 0; i < oa_payload_len - 2; i++) {
+ for (i = 0; i < oa_payload_len - 3; i++) {
buf[i + 2] = payload[i + 1] << 2;
buf[i + 2] |= payload[i + 2] >> 6;
}
diff --git a/tests/amr/amr_test.c b/tests/amr/amr_test.c
index 2f41fe9..fabf948 100644
--- a/tests/amr/amr_test.c
+++ b/tests/amr/amr_test.c
@@ -46,7 +46,7 @@
"100c1fb967f7f1fdf547bf2e61c060",
"0004f89d67f1160935bde1996840",
"0004633cc7f0630439ffe000",
- "0004eb81fc0758973b9edc782552",
+ "0004eb81fc0758973b9edc782550",
"a078ff00ff00ff00ff00ff00ff00ff00ff00ff00ff00ff00ff00ff00ff00ff00fc",
/* sample with invalid FT */
"END",
};
diff --git a/tests/amr/amr_test.ok b/tests/amr/amr_test.ok
index af1be82..eea513b 100644
--- a/tests/amr/amr_test.ok
+++ b/tests/amr/amr_test.ok
@@ -143,10 +143,10 @@
rc: 14
Sample No.: 20
- octet aligned: 0004eb81fc0758973b9edc782552
-
0100111010111001110001110101100010010111001110111000110111000010010101010010
- bw-efficient: 007ae07f01d625cee7b71e095480
-
001011100111000111010110001001011100111011100011011100001001010101001000
+ octet aligned: 0004eb81fc0758973b9edc782550
+
010011101011100111000111010110001001011100111011100011011100001001010101
+ bw-efficient: 007ae07f01d625cee7b71e095400
+
00101110011100011101011000100101110011101110001101110000100101010100
rc: 14
Sample No.: 21
@@ -162,15 +162,15 @@
Sample No.: 0
bw-efficient: f4495c7cda8f80
0100010010010101110001001101101010001000
- octet aligned: f0442571f36a3e
- 010001100101011100010011011010100010
+ octet aligned: f0442571f36a3c
+ 010001100101011100010011011010100000
rc: 7
Sample No.: 1
bw-efficient: f44aaa6c969780
01000100101010101010011011001001011010010000
- octet aligned: f0442aa9b25a5e
- 0100011010101010100110110010010110100100
+ octet aligned: f0442aa9b25a5c
+ 01000110101010101001101100100101101001011100
rc: 7
Sample No.: 2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/18451
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I91e755b83aaac722079879c026d913cc446812d1
Gerrit-Change-Number: 18451
Gerrit-PatchSet: 2
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in libosmo-netif[master]: amr: fix off-by-one in osmo_amr_bwe_to_oa()
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/18451 ) Change subject: amr: fix off-by-one in osmo_amr_bwe_to_oa() .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/18451 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I91e755b83aaac722079879c026d913cc446812d1 Gerrit-Change-Number: 18451 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 12:31:33 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-manuals[master]: trx_if.adoc: Document cmd NOMTXPOWER
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/18630 ) Change subject: trx_if.adoc: Document cmd NOMTXPOWER .. trx_if.adoc: Document cmd NOMTXPOWER TRXC message is implemented in: osmo-bts.git I682211f3d664c21f923ca4a530e0464ca383b6d9 osmo-trx.git I1d7efe56e008d8d60e23f9a85aa40809f7f84d9c Change-Id: Idb5bb56fc039c7393922243c761f3395a094a55b --- M common/chapters/trx_if.adoc 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/30/18630/1 diff --git a/common/chapters/trx_if.adoc b/common/chapters/trx_if.adoc index fc42eed..95c00c7 100644 --- a/common/chapters/trx_if.adoc +++ b/common/chapters/trx_if.adoc @@ -75,6 +75,14 @@ RSP POWERON +`NOMTXPOWER` is used by the BTS to retrieve the nominal output transmit power of +the transceiver. `SETPOWER/ADJPOWER` attenuations (dB) are expected to be +applied based on this value (dBm). + +CMD NOMTXPOWER +RSP NOMTXPOWER + + `SETPOWER` sets transmit power attenuation wrt the nominal transmit power of the transceiver, in dB. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/18630 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Idb5bb56fc039c7393922243c761f3395a094a55b Gerrit-Change-Number: 18630 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange
Change in osmo-gsm-manuals[master]: trx_if: Clarify {SET; ADJ}POWER TRXC commands
Hello tnt, neels, Jenkins Builder, Hoernchen,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/18556
to look at the new patch set (#3).
Change subject: trx_if: Clarify {SET;ADJ}POWER TRXC commands
..
trx_if: Clarify {SET;ADJ}POWER TRXC commands
Change-Id: I4f1986a1ace3fc9cbef10fc0508407a3d608670b
---
M common/chapters/trx_if.adoc
1 file changed, 11 insertions(+), 10 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals
refs/changes/56/18556/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/18556
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I4f1986a1ace3fc9cbef10fc0508407a3d608670b
Gerrit-Change-Number: 18556
Gerrit-PatchSet: 3
Gerrit-Owner: pespin
Gerrit-Reviewer: Hoernchen
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels
Gerrit-Reviewer: pespin
Gerrit-Reviewer: tnt
Gerrit-CC: laforge
Gerrit-MessageType: newpatchset
Change in osmo-gsm-manuals[master]: trx_if: Clarify {SET; ADJ}POWER TRXC commands
Hello tnt, neels, Jenkins Builder, Hoernchen,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/18556
to look at the new patch set (#2).
Change subject: trx_if: Clarify {SET;ADJ}POWER TRXC commands
..
trx_if: Clarify {SET;ADJ}POWER TRXC commands
Change-Id: I4f1986a1ace3fc9cbef10fc0508407a3d608670b
---
M common/chapters/trx_if.adoc
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals
refs/changes/56/18556/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/18556
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I4f1986a1ace3fc9cbef10fc0508407a3d608670b
Gerrit-Change-Number: 18556
Gerrit-PatchSet: 2
Gerrit-Owner: pespin
Gerrit-Reviewer: Hoernchen
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels
Gerrit-Reviewer: pespin
Gerrit-Reviewer: tnt
Gerrit-CC: laforge
Gerrit-MessageType: newpatchset
Change in osmo-ttcn3-hacks[master]: MGCP_Test: fix test vector in TC_amr_oa_bwe_rtp_conversion
dexter has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18450 )
Change subject: MGCP_Test: fix test vector in TC_amr_oa_bwe_rtp_conversion
..
MGCP_Test: fix test vector in TC_amr_oa_bwe_rtp_conversion
The rtp payload test vector in TC_amr_oa_bwe_rtp_conversion is wrong, it
lacks the last byte which should be 0x00. Also the testvector is not
very well chossen since it after BWE conversion the actual payload does
not shrink (even if it looks like if it would because of the 0x00 byte
at the end). Lets pick a better payload from a real world trace that
actually shrinks by one byte when it is converted to BWE and use that
one.
Change-Id: Id4256049bbca49ad5c2eb0579128838ebae062f8
---
M mgw/MGCP_Test.ttcn
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn
index 0de5308..be4e634 100644
--- a/mgw/MGCP_Test.ttcn
+++ b/mgw/MGCP_Test.ttcn
@@ -2082,8 +2082,12 @@
setverdict(pass);
}
+ /* Note: The hexstrings used with the f_TC_amr_x_x_rtp_conversion test
+* functions are real world AMR RTP payloads including AMR header. The
+* payloads were extracted from a trace with known good payloads. */
+
testcase TC_amr_oa_bwe_rtp_conversion() runs on dummy_CT {
-f_TC_amr_x_x_rtp_conversion('100c4e9ba850e30d5d53d04de41e7c'O,
'10d3a6ea1438c35754f41379079f'O, "octet-align=1", "octet-align=0");
+
f_TC_amr_x_x_rtp_conversion('2014e959f35fdfe5e9667ffbc088818088'O,
'217a567cd7f7f97a599ffef022206022'O, "octet-align=1", "octet-align=0");
}
testcase TC_amr_oa_oa_rtp_conversion() runs on dummy_CT {
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18450
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id4256049bbca49ad5c2eb0579128838ebae062f8
Gerrit-Change-Number: 18450
Gerrit-PatchSet: 2
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-ttcn3-hacks[master]: MGCP_Test: fix test vector in TC_amr_oa_bwe_rtp_conversion
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18450 ) Change subject: MGCP_Test: fix test vector in TC_amr_oa_bwe_rtp_conversion .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18450 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id4256049bbca49ad5c2eb0579128838ebae062f8 Gerrit-Change-Number: 18450 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 12:20:09 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-mgw[master]: mgcp_vty: fix indentation
dexter has submitted this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/18594 )
Change subject: mgcp_vty: fix indentation
..
mgcp_vty: fix indentation
Some DEFUN macros are not correctly indented
Change-Id: I613f2ebcb06a01744d957e87e8b1215a141b43c4
---
M src/libosmo-mgcp/mgcp_vty.c
1 file changed, 6 insertions(+), 6 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
Vadim Yanitskiy: Looks good to me, approved
diff --git a/src/libosmo-mgcp/mgcp_vty.c b/src/libosmo-mgcp/mgcp_vty.c
index bdcb55c..856c971 100644
--- a/src/libosmo-mgcp/mgcp_vty.c
+++ b/src/libosmo-mgcp/mgcp_vty.c
@@ -535,7 +535,7 @@
RTP_STR
"Apply IP_TOS to the audio stream\n" "The DSCP value\n")
#define FORCE_PTIME_STR "Force a fixed ptime for packets sent"
-DEFUN(cfg_mgcp_rtp_force_ptime,
+DEFUN(cfg_mgcp_rtp_force_ptime,
cfg_mgcp_rtp_force_ptime_cmd,
"rtp force-ptime (10|20|40)",
RTP_STR FORCE_PTIME_STR
@@ -601,7 +601,7 @@
"sdp audio payload number <0-255>",
SDP_STR AUDIO_STR AUDIO_STR "Number\n" "Payload number\n")
-DEFUN(cfg_mgcp_sdp_payload_name,
+DEFUN(cfg_mgcp_sdp_payload_name,
cfg_mgcp_sdp_payload_name_cmd,
"sdp audio-payload name NAME",
SDP_STR AUDIO_STR "Name\n" "Payload name\n")
@@ -614,7 +614,7 @@
"sdp audio payload name NAME",
SDP_STR AUDIO_STR AUDIO_STR "Name\n" "Payload name\n")
-DEFUN(cfg_mgcp_sdp_payload_send_ptime,
+DEFUN(cfg_mgcp_sdp_payload_send_ptime,
cfg_mgcp_sdp_payload_send_ptime_cmd,
"sdp audio-payload send-ptime",
SDP_STR AUDIO_STR "Send SDP ptime (packet duration) attribute\n")
@@ -804,7 +804,7 @@
CALL_AGENT_STR CALL_AGENT_STR IP_STR
"IPv4 Address of the callagent\n")
-DEFUN(cfg_mgcp_trunk, cfg_mgcp_trunk_cmd,
+DEFUN(cfg_mgcp_trunk, cfg_mgcp_trunk_cmd,
"trunk <1-64>", "Configure a SS7 trunk\n" "Trunk Nr\n")
{
struct mgcp_trunk_config *trunk;
@@ -911,7 +911,7 @@
"sdp audio payload number <0-255>",
SDP_STR AUDIO_STR AUDIO_STR "Number\n" "Payload Number\n")
-DEFUN(cfg_trunk_payload_name,
+DEFUN(cfg_trunk_payload_name,
cfg_trunk_payload_name_cmd,
"sdp audio-payload name NAME",
SDP_STR AUDIO_STR "Payload\n" "Payload Name\n")
@@ -926,7 +926,7 @@
"sdp audio payload name NAME",
SDP_STR AUDIO_STR AUDIO_STR "Payload\n" "Payload Name\n")
-DEFUN(cfg_trunk_loop,
+DEFUN(cfg_trunk_loop,
cfg_trunk_loop_cmd,
"loop (0|1)",
"Loop audio for all endpoints on this trunk\n" "Don't Loop\n" "Loop\n")
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18594
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I613f2ebcb06a01744d957e87e8b1215a141b43c4
Gerrit-Change-Number: 18594
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy
Gerrit-Reviewer: dexter
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-ttcn3-hacks[master]: MGCP_Test: fix test vector in TC_amr_oa_bwe_rtp_conversion
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18450 to look at the new patch set (#2). Change subject: MGCP_Test: fix test vector in TC_amr_oa_bwe_rtp_conversion .. MGCP_Test: fix test vector in TC_amr_oa_bwe_rtp_conversion The rtp payload test vector in TC_amr_oa_bwe_rtp_conversion is wrong, it lacks the last byte which should be 0x00. Also the testvector is not very well chossen since it after BWE conversion the actual payload does not shrink (even if it looks like if it would because of the 0x00 byte at the end). Lets pick a better payload from a real world trace that actually shrinks by one byte when it is converted to BWE and use that one. Change-Id: Id4256049bbca49ad5c2eb0579128838ebae062f8 --- M mgw/MGCP_Test.ttcn 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/50/18450/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18450 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id4256049bbca49ad5c2eb0579128838ebae062f8 Gerrit-Change-Number: 18450 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-bts[master]: bts-trx: vty: Add 'nominal-tx-power' cmd
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/18579 to look at the new patch set (#3). Change subject: bts-trx: vty: Add 'nominal-tx-power' cmd .. bts-trx: vty: Add 'nominal-tx-power' cmd This value will be soon acquired automatically by osmo-bts-trx by asking over TRXC to new versions of osmo-trx which is the nominal tx power for a given trx. However, to still be able to work correctly against older versions of osmo-trx or other TRX implementation (older or current) not supporting this new TRX comamnd, let's allow the user to force a given value through VTY for Tx power to work correctly. Change-Id: Ib1b6f80d3b54afc42db9d358a79582cc619c6ce4 --- M src/osmo-bts-trx/l1_if.h M src/osmo-bts-trx/main.c M src/osmo-bts-trx/trx_vty.c 3 files changed, 45 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/79/18579/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18579 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib1b6f80d3b54afc42db9d358a79582cc619c6ce4 Gerrit-Change-Number: 18579 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-MessageType: newpatchset
Change in osmo-bts[master]: bts-trx: Implement power ramping during BTS bring up
Hello tnt, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/18488 to look at the new patch set (#5). Change subject: bts-trx: Implement power ramping during BTS bring up .. bts-trx: Implement power ramping during BTS bring up The nominal transmit power is still only configurable manually from osmo-bts-trx VTY interface. Support to retrieve the nominal power from osmo-trx will come later. Change-Id: Ia7c353e4c199e0fc3bcab55c45a4abda2c66d2c1 --- M include/osmo-bts/tx_power.h M src/osmo-bts-trx/l1_if.c M src/osmo-bts-trx/l1_if.h M src/osmo-bts-trx/main.c M src/osmo-bts-trx/trx_if.c M src/osmo-bts-trx/trx_if.h M src/osmo-bts-trx/trx_vty.c 7 files changed, 73 insertions(+), 73 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/88/18488/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18488 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia7c353e4c199e0fc3bcab55c45a4abda2c66d2c1 Gerrit-Change-Number: 18488 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-MessageType: newpatchset
Change in osmo-bts[master]: bts-trx: Introduce helper func l1if_trx_set_nominal_power
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/18588 to look at the new patch set (#3). Change subject: bts-trx: Introduce helper func l1if_trx_set_nominal_power .. bts-trx: Introduce helper func l1if_trx_set_nominal_power This way we wrap same logic in one place, which will be used more in next commit. Change-Id: I929fc50d544a88900d2e22317ec5ced10f15e51c --- M src/osmo-bts-trx/l1_if.c M src/osmo-bts-trx/l1_if.h M src/osmo-bts-trx/main.c M src/osmo-bts-trx/trx_vty.c 4 files changed, 10 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/88/18588/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18588 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I929fc50d544a88900d2e22317ec5ced10f15e51c Gerrit-Change-Number: 18588 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset
Change in docker-playground[master]: ttcn3-msc-test: fix osmo-msc.cfg: make it work with latest
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18629 ) Change subject: ttcn3-msc-test: fix osmo-msc.cfg: make it work with latest .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18629 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iaeb6f1ffee9286394654bc3cf9d985ace7829110 Gerrit-Change-Number: 18629 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 12:04:40 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in docker-playground[master]: ttcn3-msc-test: fix osmo-msc.cfg: make it work with latest
Vadim Yanitskiy has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18629 ) Change subject: ttcn3-msc-test: fix osmo-msc.cfg: make it work with latest .. ttcn3-msc-test: fix osmo-msc.cfg: make it work with latest Unfortunately, we have to revert a part of change [1], because it broke ttcn3-msc-test-latest. The reason is that the latest release of osmo-msc does not support 'timer vlr T3212 30'. Change-Id: Iaeb6f1ffee9286394654bc3cf9d985ace7829110 --- M ttcn3-msc-test/osmo-msc.cfg 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve Vadim Yanitskiy: Looks good to me, approved; Verified diff --git a/ttcn3-msc-test/osmo-msc.cfg b/ttcn3-msc-test/osmo-msc.cfg index fe7b4cb..a713786 100644 --- a/ttcn3-msc-test/osmo-msc.cfg +++ b/ttcn3-msc-test/osmo-msc.cfg @@ -71,6 +71,7 @@ authentication optional rrlp mode none mm info 0 + periodic location update 30 msc assign-tmsi cs7-instance-a 0 @@ -78,7 +79,6 @@ mgw remote-ip 172.18.1.103 emergency-call route-to-msisdn 112 mncc external /data/unix/mncc - timer vlr T3212 30 mncc-int default-codec tch-f fr default-codec tch-h hr -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18629 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iaeb6f1ffee9286394654bc3cf9d985ace7829110 Gerrit-Change-Number: 18629 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-bts[master]: Do not mix public and private BTS features, use libosmocore's API
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/18591 to look at the new patch set (#6). Change subject: Do not mix public and private BTS features, use libosmocore's API .. Do not mix public and private BTS features, use libosmocore's API It was a very bad idea to mix "public" BTS features, that are reported to the BSC via OML, and those features, that are used locally (and exclusively) in osmo-bts. Why? At least because we already have the BTS feature manipulation API in libosmocore, that is used by osmo-bsc, but for some reason not by osmo-bts. New features added to libosmocore would clash with the existing "internal" ones like BTS_FEAT_MS_PWR_CTRL_DSP. So what this change does can be described as follows: - remove duplicate definition of the "public" features, - use libosmocore's API for the "public" features, - separate both "internal" and "public" features: - the "public" features continue to live in bitvec, - the "internal" features become flags, - s/BTS_FEAT/BTS_IMPL_FLAG/g. As a bonus, let's allocate the feature vector using libosmocore's bitvec API instead of doing this manually in gsm_bts_alloc(). Change-Id: Icf792d02323bb73e3b8d46384c7890cb1eb4731e --- M include/osmo-bts/gsm_data_shared.h M src/common/bts.c M src/common/gsm_data_shared.c M src/common/l1sap.c M src/common/oml.c M src/common/vty.c M src/osmo-bts-litecell15/main.c M src/osmo-bts-oc2g/main.c M src/osmo-bts-octphy/l1_if.c M src/osmo-bts-sysmo/main.c M src/osmo-bts-trx/main.c M src/osmo-bts-virtual/main.c M tests/misc/misc_test.c 13 files changed, 115 insertions(+), 136 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/91/18591/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icf792d02323bb73e3b8d46384c7890cb1eb4731e Gerrit-Change-Number: 18591 Gerrit-PatchSet: 6 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-bts[master]: Do not mix public and private BTS features, use libosmocore's API
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18591 ) Change subject: Do not mix public and private BTS features, use libosmocore's API .. Patch Set 5: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/18591/4/include/osmo-bts/gsm_data_shared.h File include/osmo-bts/gsm_data_shared.h: https://gerrit.osmocom.org/c/osmo-bts/+/18591/4/include/osmo-bts/gsm_data_shared.h@463 PS4, Line 463: ((bts->flags & (uint16_t) flag) != 0) > "typeof(bts->flags)" sounds safer here (in the event we needs more flags in > the future. ACK. > !!(bts->flags & (typeof(bts->flags)) flag) NACK, it's harder to read. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icf792d02323bb73e3b8d46384c7890cb1eb4731e Gerrit-Change-Number: 18591 Gerrit-PatchSet: 5 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 11:36:37 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in osmo-bts[master]: Do not mix public and private BTS features, use libosmocore's API
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18591 ) Change subject: Do not mix public and private BTS features, use libosmocore's API .. Patch Set 5: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/18591/4/include/osmo-bts/gsm_data_shared.h File include/osmo-bts/gsm_data_shared.h: https://gerrit.osmocom.org/c/osmo-bts/+/18591/4/include/osmo-bts/gsm_data_shared.h@463 PS4, Line 463: ((bts->flags & (uint16_t) flag) != 0) "typeof(bts->flags)" sounds safer here (in the event we needs more flags in the future. Btw you can do !! instead of !=0. !!(bts->flags & (typeof(bts->flags)) flag) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icf792d02323bb73e3b8d46384c7890cb1eb4731e Gerrit-Change-Number: 18591 Gerrit-PatchSet: 5 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 11:31:47 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: Do not mix public and private BTS features, use libosmocore's API
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/18591 to look at the new patch set (#5). Change subject: Do not mix public and private BTS features, use libosmocore's API .. Do not mix public and private BTS features, use libosmocore's API It was a very bad idea to mix "public" BTS features, that are reported to the BSC via OML, and those features, that are used locally (and exclusively) in osmo-bts. Why? At least because we already have the BTS feature manipulation API in libosmocore, that is used by osmo-bsc, but for some reason not by osmo-bts. New features added to libosmocore would clash with the existing "internal" ones like BTS_FEAT_MS_PWR_CTRL_DSP. So what this change does can be described as follows: - remove duplicate definition of the "public" features, - use libosmocore's API for the "public" features, - separate both "internal" and "public" features: - the "public" features continue to live in bitvec, - the "internal" features become flags, - s/BTS_FEAT/BTS_IMPL_FLAG/g. As a bonus, let's allocate the feature vector using libosmocore's bitvec API instead of doing this manually in gsm_bts_alloc(). Change-Id: Icf792d02323bb73e3b8d46384c7890cb1eb4731e --- M include/osmo-bts/gsm_data_shared.h M src/common/bts.c M src/common/gsm_data_shared.c M src/common/l1sap.c M src/common/oml.c M src/common/vty.c M src/osmo-bts-litecell15/main.c M src/osmo-bts-oc2g/main.c M src/osmo-bts-octphy/l1_if.c M src/osmo-bts-sysmo/main.c M src/osmo-bts-trx/main.c M src/osmo-bts-virtual/main.c M tests/misc/misc_test.c 13 files changed, 115 insertions(+), 136 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/91/18591/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icf792d02323bb73e3b8d46384c7890cb1eb4731e Gerrit-Change-Number: 18591 Gerrit-PatchSet: 5 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-bts[master]: Do not mix public and private BTS features, use libosmocore's API
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18591 ) Change subject: Do not mix public and private BTS features, use libosmocore's API .. Patch Set 4: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icf792d02323bb73e3b8d46384c7890cb1eb4731e Gerrit-Change-Number: 18591 Gerrit-PatchSet: 4 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 11:26:37 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-bts[master]: bts-trx: Use TRXC cmd NOMTXPOWER to retrieve nominal tx power from os...
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18589 ) Change subject: bts-trx: Use TRXC cmd NOMTXPOWER to retrieve nominal tx power from osmo-trx .. Patch Set 2: > Patch Set 2: > > The spec says: "The range over which the BSS shall be capable of reducing its > RF output power from its maximum level shall be nominally 30 dB, in 15 steps > of nominally 2 dB." > The power level field has 5 bits of which 4 may be used to set the level, one > is fixed to zero. > The b2xx series has a max rx gain of 76 dB and 89.8 dB max tx gain. > > So there is nothing to retrieve, the nominal power needs to configured in the > osmo-trx config for one specific device and frequency configuration that is > being used, an the relative power reduction always has to be relative to the > configured value. As discussed previously, the idea is that for now we hardcode a set of values per device type after doing some measurements. We can later on add VTY configs as needed. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I682211f3d664c21f923ca4a530e0464ca383b6d9 Gerrit-Change-Number: 18589 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: Hoernchen Gerrit-Comment-Date: Tue, 02 Jun 2020 11:19:28 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-mgw[master]: osmo-mgw: refactor endpoint and trunk handling
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18372 ) Change subject: osmo-mgw: refactor endpoint and trunk handling .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ice8aaf03faa2fd99074f8665eea3a696d30c5eb3 Gerrit-Change-Number: 18372 Gerrit-PatchSet: 7 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 02 Jun 2020 10:51:16 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-mgw[master]: osmo-mgw: refactor endpoint and trunk handling
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18372 ) Change subject: osmo-mgw: refactor endpoint and trunk handling .. Patch Set 7: (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/18372/6//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-mgw/+/18372/6//COMMIT_MSG@27 PS6, Line 27: efactor rate counters, put them into a separate module and do no :longer allocate them per trunk. Allocate them globally instead. > I'm not sure if this is a good idea. […] I think some of them were clearly meant at being global, so I think it's fine (I'm not saying all of them should be global). In any case I think it makes sense to have some of them global and we can later add it per trunk as needed after this clean up being done now. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ice8aaf03faa2fd99074f8665eea3a696d30c5eb3 Gerrit-Change-Number: 18372 Gerrit-PatchSet: 7 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 02 Jun 2020 10:50:11 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment
Change in osmo-mgw[master]: mgcp_vty: fix indentation in VTY config write
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18593 ) Change subject: mgcp_vty: fix indentation in VTY config write .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18593 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I2aefeaf3d7ad4a98b7bfcdc7cbc1ce6ebcbe0537 Gerrit-Change-Number: 18593 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 10:47:37 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: bts_features: fix: properly check the result of bitvec_get_bit_pos()
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18619 ) Change subject: bts_features: fix: properly check the result of bitvec_get_bit_pos() .. Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/18619/2/include/osmocom/gsm/bts_features.h File include/osmocom/gsm/bts_features.h: https://gerrit.osmocom.org/c/libosmocore/+/18619/2/include/osmocom/gsm/bts_features.h@43 PS2, Line 43: return bitvec_get_bit_pos(features, feature) == ONE; > We could print a warning instead ;) ah ok, I was considering the "feature" param is sanitized before calling this function, like checking feature < _NUM_BTS_FEAT. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18619 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id1ad92e7654a806bb920ae9507c88a122e8d09f0 Gerrit-Change-Number: 18619 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 10:44:27 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Vadim Yanitskiy Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in docker-playground[master]: ttcn3-msc-test: fix osmo-msc.cfg: make it work with latest
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18629 ) Change subject: ttcn3-msc-test: fix osmo-msc.cfg: make it work with latest .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18629 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iaeb6f1ffee9286394654bc3cf9d985ace7829110 Gerrit-Change-Number: 18629 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 10:44:56 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmo-netif[master]: src/stream: Work around more Linux kernel ABI breakage
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/18628 )
Change subject: src/stream: Work around more Linux kernel ABI breakage
..
Patch Set 1:
(5 comments)
https://gerrit.osmocom.org/c/libosmo-netif/+/18628/1//COMMIT_MSG
Commit Message:
https://gerrit.osmocom.org/c/libosmo-netif/+/18628/1//COMMIT_MSG@14
PS1, Line 14: and https://marc.info/?l=linux-sctp=158729301516157=2 for the
ost
typo: most
https://gerrit.osmocom.org/c/libosmo-netif/+/18628/1/src/stream.c
File src/stream.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/18628/1/src/stream.c@100
PS1, Line 100: * But as it doesn't do that, let's try to work around this */
In general, I think it is worth finding out the requried size only once and
storing it in a static size_t sctp_setsockopt_size once it's found to work, and
then simply call setsokopt directly if that static var is != 0.
https://gerrit.osmocom.org/c/libosmo-netif/+/18628/1/src/stream.c@121
PS1, Line 121: continue;
AFAIU this probably deserves logging and error and if you end up here you can
already return.
So that means for instance size=11 and we failed, so we try with
try_sizes[i]=10. If we want to set even in 11th byte, we won't be able and we
don't need to continue since we'll never be able to set it. That's also why an
error log is required.
https://gerrit.osmocom.org/c/libosmo-netif/+/18628/1/src/stream.c@131
PS1, Line 131: memcpy(buf, event, size);
memcpy(buf, event, size);
memset(buf+size, 0, sizeof(buf) - size);
https://gerrit.osmocom.org/c/libosmo-netif/+/18628/1/src/stream.c@140
PS1, Line 140: }
Probably worth logging in else {} here for new-to-come kernels.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/18628
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Icc49f347cdc0bb77a5c0e230597d662ac35b4acc
Gerrit-Change-Number: 18628
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin
Gerrit-Comment-Date: Tue, 02 Jun 2020 10:42:53 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in osmo-bts[master]: Do not mix public and private BTS features, use libosmocore's API
Vadim Yanitskiy has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/18591 )
Change subject: Do not mix public and private BTS features, use libosmocore's
API
..
Patch Set 3:
(3 comments)
https://gerrit.osmocom.org/c/osmo-bts/+/18591/3/src/common/bts.c
File src/common/bts.c:
https://gerrit.osmocom.org/c/osmo-bts/+/18591/3/src/common/bts.c@261
PS3, Line 261: if (~trx->bts->flags & BTS_IMPL_FLAG_MS_PWR_CTRL_DSP)
> I would really welcome a function helper for this, in order to: […]
You're definitely trying to turn Osmocom into Helpercom ;) In any case, I will
introduce a function to check if a flag is set. Setting a flag (bts->flags |=
BTS_IMPL_FLAG_FOO) is super easy and clear, so it needs no API IMHO.
https://gerrit.osmocom.org/c/osmo-bts/+/18591/3/src/common/oml.c
File src/common/oml.c:
https://gerrit.osmocom.org/c/osmo-bts/+/18591/3/src/common/oml.c@176
PS3, Line 176: msgb_tl16v_put(msg, NM_ATT_MANUF_ID, _NUM_BTS_FEAT/8 + 1,
bts->features->data);
> isn't there an API to get the data pointer?
API for 'foo->data'? Is it really something that requires API?
https://gerrit.osmocom.org/c/osmo-bts/+/18591/3/src/common/vty.c
File src/common/vty.c:
https://gerrit.osmocom.org/c/osmo-bts/+/18591/3/src/common/vty.c@845
PS3, Line 845: for (i = 0, no_features = true; i < sizeof(bts->flags) * 8;
i++) {
> features = false, then setting it to true and checking if (!features) is
> easier to understand :)
This is unrelated. I am (re)using the existing variable with its original name.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18591
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Icf792d02323bb73e3b8d46384c7890cb1eb4731e
Gerrit-Change-Number: 18591
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-Comment-Date: Tue, 02 Jun 2020 10:41:27 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
Gerrit-MessageType: comment
Change in osmo-pcu[master]: bts: refactor handling and parsing of RACH.ind
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18386 ) Change subject: bts: refactor handling and parsing of RACH.ind .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5fe7e0f51bf5c9eac073935cc4f4edd667c67c6e Gerrit-Change-Number: 18386 Gerrit-PatchSet: 6 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 10:30:21 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: BTS::parse_rach_ind(): properly handle EGPRS Packet Channel Request
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18387 ) Change subject: BTS::parse_rach_ind(): properly handle EGPRS Packet Channel Request .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia15761c33c8048d35c7f7bc93dbea781dd0894b7 Gerrit-Change-Number: 18387 Gerrit-PatchSet: 7 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 10:26:57 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in docker-playground[master]: ttcn3-msc-test: fix osmo-msc.cfg: make it work with latest
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/18629 ) Change subject: ttcn3-msc-test: fix osmo-msc.cfg: make it work with latest .. ttcn3-msc-test: fix osmo-msc.cfg: make it work with latest Unfortunately, we have to revert a part of change [1], because it broke ttcn3-msc-test-latest. The reason is that the latest release of osmo-msc does not support 'timer vlr T3212 30'. Change-Id: Iaeb6f1ffee9286394654bc3cf9d985ace7829110 --- M ttcn3-msc-test/osmo-msc.cfg 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/29/18629/1 diff --git a/ttcn3-msc-test/osmo-msc.cfg b/ttcn3-msc-test/osmo-msc.cfg index fe7b4cb..a713786 100644 --- a/ttcn3-msc-test/osmo-msc.cfg +++ b/ttcn3-msc-test/osmo-msc.cfg @@ -71,6 +71,7 @@ authentication optional rrlp mode none mm info 0 + periodic location update 30 msc assign-tmsi cs7-instance-a 0 @@ -78,7 +79,6 @@ mgw remote-ip 172.18.1.103 emergency-call route-to-msisdn 112 mncc external /data/unix/mncc - timer vlr T3212 30 mncc-int default-codec tch-f fr default-codec tch-h hr -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18629 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iaeb6f1ffee9286394654bc3cf9d985ace7829110 Gerrit-Change-Number: 18629 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-MessageType: newchange
Change in osmo-bts[master]: Do not mix public and private BTS features, use libosmocore's API
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/18591 )
Change subject: Do not mix public and private BTS features, use libosmocore's
API
..
Patch Set 3:
(3 comments)
Please add bts_model_get/unset/set_flag() or alike APIs.
https://gerrit.osmocom.org/c/osmo-bts/+/18591/3/src/common/bts.c
File src/common/bts.c:
https://gerrit.osmocom.org/c/osmo-bts/+/18591/3/src/common/bts.c@261
PS3, Line 261: if (~trx->bts->flags & BTS_IMPL_FLAG_MS_PWR_CTRL_DSP)
I would really welcome a function helper for this, in order to:
* Avoid boolean math in lots of places (and hence having to pay attention to it)
* Easily finding where internal features are checked/used/set.
Also because it's something all bts_model are using, so it makes sense to have
some sort of abstraction to make it easier when adding a new model.
https://gerrit.osmocom.org/c/osmo-bts/+/18591/3/src/common/oml.c
File src/common/oml.c:
https://gerrit.osmocom.org/c/osmo-bts/+/18591/3/src/common/oml.c@176
PS3, Line 176: msgb_tl16v_put(msg, NM_ATT_MANUF_ID, _NUM_BTS_FEAT/8 + 1,
bts->features->data);
isn't there an API to get the data pointer?
https://gerrit.osmocom.org/c/osmo-bts/+/18591/3/src/common/vty.c
File src/common/vty.c:
https://gerrit.osmocom.org/c/osmo-bts/+/18591/3/src/common/vty.c@845
PS3, Line 845: for (i = 0, no_features = true; i < sizeof(bts->flags) * 8;
i++) {
features = false, then setting it to true and checking if (!features) is easier
to understand :)
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18591
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Icf792d02323bb73e3b8d46384c7890cb1eb4731e
Gerrit-Change-Number: 18591
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-Comment-Date: Tue, 02 Jun 2020 10:21:47 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in libosmocore[master]: bts_features: fix: properly check the result of bitvec_get_bit_pos()
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18619 ) Change subject: bts_features: fix: properly check the result of bitvec_get_bit_pos() .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/18619/2/include/osmocom/gsm/bts_features.h File include/osmocom/gsm/bts_features.h: https://gerrit.osmocom.org/c/libosmocore/+/18619/2/include/osmocom/gsm/bts_features.h@43 PS2, Line 43: return bitvec_get_bit_pos(features, feature) == ONE; > I don't think so. […] We could print a warning instead ;) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18619 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id1ad92e7654a806bb920ae9507c88a122e8d09f0 Gerrit-Change-Number: 18619 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 10:18:23 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Vadim Yanitskiy Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in libosmocore[master]: bts_features: fix: properly check the result of bitvec_get_bit_pos()
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18619 ) Change subject: bts_features: fix: properly check the result of bitvec_get_bit_pos() .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/18619/2/include/osmocom/gsm/bts_features.h File include/osmocom/gsm/bts_features.h: https://gerrit.osmocom.org/c/libosmocore/+/18619/2/include/osmocom/gsm/bts_features.h@43 PS2, Line 43: return bitvec_get_bit_pos(features, feature) == ONE; > shouldn't we better assert() in this case? I don't think so. Imagine you're running an old version of osmo-bsc and the recent version of osmo-bts that has some new features (and thus sends a longer feature vector). We don't want to crash the whole BSC just because of that, right? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18619 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id1ad92e7654a806bb920ae9507c88a122e8d09f0 Gerrit-Change-Number: 18619 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 10:17:32 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in libosmocore[master]: bts_features: fix: properly check the result of bitvec_get_bit_pos()
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18619 ) Change subject: bts_features: fix: properly check the result of bitvec_get_bit_pos() .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/18619/2/include/osmocom/gsm/bts_features.h File include/osmocom/gsm/bts_features.h: https://gerrit.osmocom.org/c/libosmocore/+/18619/2/include/osmocom/gsm/bts_features.h@43 PS2, Line 43: return bitvec_get_bit_pos(features, feature) == ONE; shouldn't we better assert() in this case? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18619 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id1ad92e7654a806bb920ae9507c88a122e8d09f0 Gerrit-Change-Number: 18619 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 10:12:41 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-bsc[master]: Split GSM_BTS_TYPE_OSMOBTS to individual BTS types
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18616 ) Change subject: Split GSM_BTS_TYPE_OSMOBTS to individual BTS types .. Patch Set 1: Code-Review-1 Agree with laforge: * Fine moving sysmobts->osmo-bts (and keep support for sysmobts for backward compatibility) * Handle differences between osmo-bts implementations by means of features. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18616 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I00a815cfa6daab126742d27843e700c07c1db183 Gerrit-Change-Number: 18616 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 10:10:07 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-msc[master]: add full SDP codec information to the MNCC socket
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/15953 )
Change subject: add full SDP codec information to the MNCC socket
..
Patch Set 6:
(7 comments)
https://gerrit.osmocom.org/c/osmo-msc/+/15953/6/src/libmsc/cc_sdp.c
File src/libmsc/cc_sdp.c:
https://gerrit.osmocom.org/c/osmo-msc/+/15953/6/src/libmsc/cc_sdp.c@10
PS6, Line 10: /* In order of preference. TODO: make configurable */
Are we adding regression here? Wasn't it already configurable before?
https://gerrit.osmocom.org/c/osmo-msc/+/15953/6/src/libmsc/cc_sdp.c@11
PS6, Line 11: static const enum gsm48_bcap_speech_ver mobile_codecs[] = {
Not sure if it really makes sense having this static here.
https://gerrit.osmocom.org/c/osmo-msc/+/15953/6/src/libmsc/cc_sdp.c@107
PS6, Line 107: for (a->payload_type = 96;
a->payload_type <= 127; a->payload_type++) {
would be great having defines for this numbers (96,127).
https://gerrit.osmocom.org/c/osmo-msc/+/15953/6/src/libmsc/codec_sdp_cc_t9n.c
File src/libmsc/codec_sdp_cc_t9n.c:
https://gerrit.osmocom.org/c/osmo-msc/+/15953/6/src/libmsc/codec_sdp_cc_t9n.c@170
PS6, Line 170: const struct codec_mapping
*codec_mapping_by_gsm0808_speech_codec_type(enum gsm0808_speech_codec_type sct,
uint16_t cfg)
either fix the TODO or mark cfg as unused for the compiler.
https://gerrit.osmocom.org/c/osmo-msc/+/15953/6/src/libmsc/gsm_04_08_cc.c
File src/libmsc/gsm_04_08_cc.c:
https://gerrit.osmocom.org/c/osmo-msc/+/15953/6/src/libmsc/gsm_04_08_cc.c@1261
PS6, Line 1261: GSM48_PDISC_CC |
(trans->transaction_id << 4),
wrong indentation.
https://gerrit.osmocom.org/c/osmo-msc/+/15953/6/src/libmsc/sdp_msg.c
File src/libmsc/sdp_msg.c:
https://gerrit.osmocom.org/c/osmo-msc/+/15953/6/src/libmsc/sdp_msg.c@558
PS6, Line 558: if (codec->rate != 8000)
Next time, please split this kind of stuff into separate commits for easier
review.
https://gerrit.osmocom.org/c/osmo-msc/+/15953/6/tests/msc_vlr/msc_vlr_test_call.err
File tests/msc_vlr/msc_vlr_test_call.err:
https://gerrit.osmocom.org/c/osmo-msc/+/15953/6/tests/msc_vlr/msc_vlr_test_call.err@429
PS6, Line 429:
This empty line in stderr (libosmocore log) looks suspìcious.As if you are
adding an extra \n somewhere.
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15953
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I8c3b2de53ffae4ec3a66b9dabf308c290a2c999f
Gerrit-Change-Number: 15953
Gerrit-PatchSet: 6
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: neels
Gerrit-Reviewer: pespin
Gerrit-Comment-Date: Tue, 02 Jun 2020 10:06:43 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in openbsc[master]: fix typo in osmo_bts_variant_names: s/omso/osmo/
Vadim Yanitskiy has submitted this change. (
https://gerrit.osmocom.org/c/openbsc/+/18627 )
Change subject: fix typo in osmo_bts_variant_names: s/omso/osmo/
..
fix typo in osmo_bts_variant_names: s/omso/osmo/
Change-Id: I4645da18fde48165c846ba714cd03e604aef5ad6
---
M openbsc/src/libcommon/gsm_data_shared.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/openbsc/src/libcommon/gsm_data_shared.c
b/openbsc/src/libcommon/gsm_data_shared.c
index 75fe0b0..a97a2b9 100644
--- a/openbsc/src/libcommon/gsm_data_shared.c
+++ b/openbsc/src/libcommon/gsm_data_shared.c
@@ -87,7 +87,7 @@
{ BTS_OSMO_LITECELL15, "osmo-bts-lc15" },
{ BTS_OSMO_OCTPHY, "osmo-bts-octphy" },
{ BTS_OSMO_SYSMO, "osmo-bts-sysmo" },
- { BTS_OSMO_TRX, "omso-bts-trx" },
+ { BTS_OSMO_TRX, "osmo-bts-trx" },
{ 0, NULL }
};
--
To view, visit https://gerrit.osmocom.org/c/openbsc/+/18627
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Change-Id: I4645da18fde48165c846ba714cd03e604aef5ad6
Gerrit-Change-Number: 18627
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-gsm-tester[master]: ms_srs: add PRACH, reestablishment and paging counter
srs_andre has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18538 )
Change subject: ms_srs: add PRACH, reestablishment and paging counter
..
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18538/1/src/osmo_gsm_tester/obj/ms_srs.py
File src/osmo_gsm_tester/obj/ms_srs.py:
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18538/1/src/osmo_gsm_tester/obj/ms_srs.py@358
PS1, Line 358: return self._get_counter_stdout('HO successful')
> Beign all these a one line, it makes sense to drop the functions and use the
> one-lines in get_counte […]
Ack
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18538
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I592ace7c38d98bfbbec5001a3cdfffe21733ef9f
Gerrit-Change-Number: 18538
Gerrit-PatchSet: 3
Gerrit-Owner: srs_andre
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-Reviewer: srs_andre
Gerrit-Comment-Date: Tue, 02 Jun 2020 08:53:36 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: ms_srs: refactor UE state getter functions
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18535 ) Change subject: ms_srs: refactor UE state getter functions .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18535/2/src/osmo_gsm_tester/obj/ms_srs.py File src/osmo_gsm_tester/obj/ms_srs.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18535/2/src/osmo_gsm_tester/obj/ms_srs.py@309 PS2, Line 309: def is_rrc_idle(self): > The proposed approach didn't work, not sure if it has something to do with > the wait() function. […] ah indeed. You need to use lambda function. See for instance: sysmocom/suites/debug/interactive.py 150:wait(lambda: not ms.is_attached()) -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18535 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I6cd057e34b4df6a1a73695355dd6406d7e039546 Gerrit-Change-Number: 18535 Gerrit-PatchSet: 3 Gerrit-Owner: srs_andre Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Reviewer: srs_andre Gerrit-Comment-Date: Tue, 02 Jun 2020 08:34:32 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: srs_andre Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in openbsc[master]: fix typo in osmo_bts_variant_names: s/omso/osmo/
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/openbsc/+/18627 ) Change subject: fix typo in osmo_bts_variant_names: s/omso/osmo/ .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/18627 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: I4645da18fde48165c846ba714cd03e604aef5ad6 Gerrit-Change-Number: 18627 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jun 2020 08:33:00 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
