[S] Change in libosmocore[master]: gmstap_util: Fix sending out gsmtap messages
Attention is currently required from: daniel, jolly. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35055?usp=email ) Change subject: gmstap_util: Fix sending out gsmtap messages .. Patch Set 2: (1 comment) File src/core/gsmtap_util.c: https://gerrit.osmocom.org/c/libosmocore/+/35055/comment/d50ad5b0_74213e31 PS1, Line 499: osmo_iofd_register > What if registration fails? Can you handle it? My bad, fixed it. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35055?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I88ba8984518d2d0327cfacd0d2cdf33c7e1d091b Gerrit-Change-Number: 35055 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: jolly Gerrit-Attention: jolly Gerrit-Attention: daniel Gerrit-Comment-Date: Fri, 17 Nov 2023 17:55:11 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly Gerrit-MessageType: comment
[S] Change in libosmocore[master]: gmstap_util: Fix sending out gsmtap messages
Attention is currently required from: arehbein, daniel. Hello Jenkins Builder, daniel, jolly, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35055?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: gmstap_util: Fix sending out gsmtap messages .. gmstap_util: Fix sending out gsmtap messages Previously undetected, because the vty command 'gsmtap log ...' never used write queue mode Change-Id: I88ba8984518d2d0327cfacd0d2cdf33c7e1d091b --- M src/core/gsmtap_util.c 1 file changed, 21 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/55/35055/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35055?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I88ba8984518d2d0327cfacd0d2cdf33c7e1d091b Gerrit-Change-Number: 35055 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: jolly Gerrit-Attention: arehbein Gerrit-Attention: daniel Gerrit-MessageType: newpatchset
[S] Change in libosmocore[master]: gmstap_util: Fix sending out gsmtap messages
Attention is currently required from: arehbein, daniel. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35055?usp=email ) Change subject: gmstap_util: Fix sending out gsmtap messages .. Patch Set 1: (1 comment) File src/core/gsmtap_util.c: https://gerrit.osmocom.org/c/libosmocore/+/35055/comment/0e0fb043_0e017169 PS1, Line 499: osmo_iofd_register What if registration fails? Can you handle it? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35055?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I88ba8984518d2d0327cfacd0d2cdf33c7e1d091b Gerrit-Change-Number: 35055 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: jolly Gerrit-Attention: arehbein Gerrit-Attention: daniel Gerrit-Comment-Date: Fri, 17 Nov 2023 17:30:50 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[L] Change in libosmocore[master]: core: Add software UART implementation
Attention is currently required from: fixeria, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email ) Change subject: core: Add software UART implementation .. Patch Set 3: (1 comment) File src/core/soft_uart.c: https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/b08f4bd0_2bbe7a2e PS3, Line 203: /* FIXME: Tx */ > Ah, I actually wanted to clarify the idea behind this function first. […] enabling/disabling the receiver are completely orthogonal functions to modem status lines (they also are completely independent in any hardware UART). modem status lines tell you information like the state of the *attached* equipment. Example: Is the data terminal ready (DTR)? Does the modem have a carrier? (DCD). See V.110 and the table in https://osmocom.org/projects/retronetworking/wiki/RS232_vs_ITU_V24_Signal_Names giving "normal" names for those numeric circuit numbers in V.110 So basically all this function here would do is to set some state whcih then ends up in the S/X-bits, and which is used by the remote end to replicate those status lines. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2ca95963fd5852ddb89bdd35b86b31489127fe84 Gerrit-Change-Number: 30763 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly Gerrit-CC: fixeria Gerrit-Attention: jolly Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 17 Nov 2023 16:42:22 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
[M] Change in libosmocore[master]: [WIP] soft_uart: implement OSMO_SUART_RX_MODE_N_FRAMES
Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35045?usp=email ) Change subject: [WIP] soft_uart: implement OSMO_SUART_RX_MODE_N_FRAMES .. Patch Set 2: (1 comment) File include/osmocom/core/soft_uart.h: https://gerrit.osmocom.org/c/libosmocore/+/35045/comment/c08fbed8_b11faf25 PS2, Line 78: number of received UART frames for OSMO_SUART_RX_MODE_N_FRAMES; UART :* will flush receive buffer via the receive call-back after indicated number :* of UART frames had been received. * > how is this different from the existing behavior if you'd simply make the rx > buffer size == rx_n_uar […] I wanted to add an option, eliminating the need for a timer. This is not fully implemented, but the idea was to count not only UART frames containing N bits of data, but also the stop bits (likely applying a lower weight or even separately). So the "takes too long to fill up" problem can be solved by counting stop bits. It was just an idea and I wanted to see how it develops. I will better postpone this for now. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35045?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib3249a06c84f3ddb2723d0787db51873c4707d81 Gerrit-Change-Number: 35045 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Attention: laforge Gerrit-Comment-Date: Fri, 17 Nov 2023 16:39:55 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment
[M] Change in libosmocore[master]: soft_uart: implement the transmitter
Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35044?usp=email ) Change subject: soft_uart: implement the transmitter .. Patch Set 2: (1 comment) File src/core/soft_uart.c: https://gerrit.osmocom.org/c/libosmocore/+/35044/comment/e0a3ed30_c7f70872 PS2, Line 209: size_t osmo_soft_uart_tx(struct osmo_soft_uart *suart, > how does this reject any buffer overflows? It is difficult to manage > transmission with a buffer, IM […] For the record, we further discussed this proposal in the IRC and decided to go for it. Regarding the buffer overflow protection, note the `OSMO_MIN` in this function. The caller is currently expected to check the returned value, which can be equal to or less than the `data_len`. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35044?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibcd9643227e5616efd8bbd7a1430feda6fcef45c Gerrit-Change-Number: 35044 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: laforge Gerrit-Comment-Date: Fri, 17 Nov 2023 16:29:39 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment
[L] Change in libosmocore[master]: core: Add software UART implementation
Attention is currently required from: jolly, laforge.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email )
Change subject: core: Add software UART implementation
..
Patch Set 3:
(5 comments)
Patchset:
PS3:
> I think something like a soft-uart is an ideal candidate for some unit tests
> for decoding valid char […]
See https://gerrit.osmocom.org/c/libosmocore/+/35046.
So far I am testing both Rx/Tx and parity errors, but not under-/over-flows yet
- this is TBD.
File src/core/soft_uart.c:
https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/6085dfec_34753526
PS3, Line 132: TODO: verify parity
> not critical to get it merged: But do you still have on your agenda to
> implement this?
Implemented in https://gerrit.osmocom.org/c/libosmocore/+/35023.
https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/ffb3c23a_3b79f155
PS3, Line 138: fprintf(stderr, "framing e
> this was ok for a hack in my private branch, but we shouldn't merge code to
> master that prints direc […]
This one is going be removed by a follow-up patch (see
https://gerrit.osmocom.org/c/libosmocore/+/35022). We may actually want to keep
logging, but use LOGP instead?
https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/5d84d58b_3296868c
PS3, Line 181: if (!suart->tx.running)
> the transmit is not implemented at all? Please squash your additions/fixes
> into this patch so we don […]
The transmitter is implemented in a follow up patch
https://gerrit.osmocom.org/c/libosmocore/+/35044. As was discussed in the IRC,
I will for now focus on addressing code review and improving the overall
architecture. Once we have settled everything down, we can think of
squashing/merging.
https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/1b473b54_ff783cb2
PS3, Line 203: /* FIXME: Tx */
> likewise here. the function is a NOP. Please squash your implementation into
> the patch, thanks.
Ah, I actually wanted to clarify the idea behind this function first.
My guess is that this is needed for implementing the "hardware" flow control?
But then, wouldn't calling `osmo_soft_uart_set_{rx,tx}()` be enough?
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2ca95963fd5852ddb89bdd35b86b31489127fe84
Gerrit-Change-Number: 30763
Gerrit-PatchSet: 3
Gerrit-Owner: laforge
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly
Gerrit-CC: fixeria
Gerrit-Attention: jolly
Gerrit-Attention: laforge
Gerrit-Comment-Date: Fri, 17 Nov 2023 16:23:11 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
Gerrit-MessageType: comment
[S] Change in libosmocore[master]: gmstap_util: Fix sending out gsmtap messages
arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35055?usp=email ) Change subject: gmstap_util: Fix sending out gsmtap messages .. gmstap_util: Fix sending out gsmtap messages Previously undetected, because the vty command 'gsmtap log ...' never used write queue mode Change-Id: I88ba8984518d2d0327cfacd0d2cdf33c7e1d091b --- M src/core/gsmtap_util.c 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/55/35055/1 diff --git a/src/core/gsmtap_util.c b/src/core/gsmtap_util.c index d817885..6bcfa1f 100644 --- a/src/core/gsmtap_util.c +++ b/src/core/gsmtap_util.c @@ -496,6 +496,7 @@ close(fd); return NULL; } + osmo_iofd_register(gti->out, gti->wq.bfd.fd); /* osmo write queue previously used was set up with value of 64 */ osmo_iofd_set_txqueue_max_length(gti->out, 64); } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35055?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I88ba8984518d2d0327cfacd0d2cdf33c7e1d091b Gerrit-Change-Number: 35055 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein Gerrit-MessageType: newchange
[S] Change in osmo-ttcn3-hacks[master]: hlr: add imsi unknown cause test case
Attention is currently required from: fixeria, lynxis lazus, neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569?usp=email ) Change subject: hlr: add imsi unknown cause test case .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I87c3a2d7304b81cfc11a364d933567e1a080b99a Gerrit-Change-Number: 27569 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Attention: neels Gerrit-Attention: fixeria Gerrit-Attention: lynxis lazus Gerrit-Comment-Date: Fri, 17 Nov 2023 14:21:54 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in libosmocore[master]: LAPD: Indicate sequence error after indicating received data
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35048?usp=email ) Change subject: LAPD: Indicate sequence error after indicating received data .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35048?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I535c18018bf0df4124a5e9618238028fa31be289 Gerrit-Change-Number: 35048 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: jolly Gerrit-Comment-Date: Fri, 17 Nov 2023 14:21:26 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in libosmocore[master]: LAPDm: Add a flag to enable suppression of subsequent REJ frame
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35015?usp=email ) Change subject: LAPDm: Add a flag to enable suppression of subsequent REJ frame .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35015?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I93994dbbd1fc2c9edb8f3015c6b18ecd0fce0565 Gerrit-Change-Number: 35015 Gerrit-PatchSet: 2 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Attention: jolly Gerrit-Comment-Date: Fri, 17 Nov 2023 14:20:38 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in libosmocore[master]: LAPDm: Add an extra queue for UI frames
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34987?usp=email ) Change subject: LAPDm: Add an extra queue for UI frames .. Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34987?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I00c8ee73be8b7c564a4dee3fca3e893484f567da Gerrit-Change-Number: 34987 Gerrit-PatchSet: 10 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: jolly Gerrit-Comment-Date: Fri, 17 Nov 2023 14:20:09 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in libosmocore[master]: LAPDm: Add support for RTS based polling
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34986?usp=email ) Change subject: LAPDm: Add support for RTS based polling .. Patch Set 10: Code-Review+1 (2 comments) File src/gsm/lapdm.c: https://gerrit.osmocom.org/c/libosmocore/+/34986/comment/e268b0e3_44823ce9 PS10, Line 1619: i array should be "const uint32_t *" as it's just read and never modified. https://gerrit.osmocom.org/c/libosmocore/+/34986/comment/7ee541e2_3f9052f1 PS10, Line 1631: void lapdm_channel_set_t200_fn(struct lapdm_channel *lc, uint32_t *t200_fn_dcch, uint32_t *t200_fn_acch) arrays should be "const uint32_t *" as it's just read and never modified. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34986?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6ebe83f829d7751ea9de1d90eb478c7a628db64c Gerrit-Change-Number: 34986 Gerrit-PatchSet: 10 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: jolly Gerrit-Comment-Date: Fri, 17 Nov 2023 14:19:06 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in libosmocore[master]: LAPD: Add support for RTS based polling and T200
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34985?usp=email ) Change subject: LAPD: Add support for RTS based polling and T200 .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34985?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib961b5a44911b99b0487641533301749c0286995 Gerrit-Change-Number: 34985 Gerrit-PatchSet: 7 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: jolly Gerrit-Comment-Date: Fri, 17 Nov 2023 14:16:04 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-msc[master]: add sdp_audio_codec_to_speech_codec_list()
Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35050?usp=email ) Change subject: add sdp_audio_codec_to_speech_codec_list() .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35050?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6ac23c54bc26939e048ff2df06eb987421cfb1c5 Gerrit-Change-Number: 35050 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Attention: neels Gerrit-Comment-Date: Fri, 17 Nov 2023 14:12:50 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-msc[master]: fix codec mapping for GSM-HR
Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35049?usp=email ) Change subject: fix codec mapping for GSM-HR .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35049?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I19cff847a0f618ad000d12c1df54c55ef2f79699 Gerrit-Change-Number: 35049 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Attention: neels Gerrit-Comment-Date: Fri, 17 Nov 2023 14:12:21 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests_LAPDm.TC_nr_seq_error: Fix test
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35047?usp=email ) Change subject: BTS_Tests_LAPDm.TC_nr_seq_error: Fix test .. Patch Set 1: (1 comment) Patchset: PS1: I think this needs a more elaborate explanation. Why do we need to involve the (simulated) BSC here? Shouldn't the LAPDm instaince in the BTS itself disconnect LAPDm and send a REL_IND to the BTS? Note it's been ages since I last looked at any of this, but definitely we need some explanation in the commit log other than "fix ..." -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35047?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4cdff6ab607e158d4956a1bd87f74e9e75579cff Gerrit-Change-Number: 35047 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: laforge Gerrit-Attention: jolly Gerrit-Comment-Date: Fri, 17 Nov 2023 14:10:07 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests_LAPDm.TC_sabm_retransmit_bts: Fix time to wait
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35054?usp=email ) Change subject: BTS_Tests_LAPDm.TC_sabm_retransmit_bts: Fix time to wait .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35054?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I593008420f58cc1d5e4778874f9071914d24f82e Gerrit-Change-Number: 35054 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Attention: jolly Gerrit-Comment-Date: Fri, 17 Nov 2023 14:06:14 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests_LAPDm.TC_sabm_retransmit_bts: Fix time to wait
Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35054?usp=email ) Change subject: BTS_Tests_LAPDm.TC_sabm_retransmit_bts: Fix time to wait .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35054?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I593008420f58cc1d5e4778874f9071914d24f82e Gerrit-Change-Number: 35054 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Attention: jolly Gerrit-Comment-Date: Fri, 17 Nov 2023 13:08:45 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests_LAPDm.TC_nr_seq_error: Fix test
Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35047?usp=email ) Change subject: BTS_Tests_LAPDm.TC_nr_seq_error: Fix test .. Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35047/comment/dd3e3eba_c297ad25 PS1, Line 9: OS: `OS#` -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35047?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4cdff6ab607e158d4956a1bd87f74e9e75579cff Gerrit-Change-Number: 35047 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Attention: jolly Gerrit-Comment-Date: Fri, 17 Nov 2023 13:08:18 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: msc: test re-assignment to match codec with MT
Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053?usp=email ) Change subject: msc: test re-assignment to match codec with MT .. Patch Set 2: (1 comment) File msc/BSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053/comment/d3cd5aa7_9ca696c0 PS2, Line 1723: cpars.re_ass_compl_chosen_codec Now that this argument is part of the `cpars`, is there still a need to pass it separately, given that we do pass the whole `cpars`? I mean, this function can now access `re_ass_compl_chosen_codec` via the given `cpars`... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I402ed0523a2a87b83f29c5577b2c828102005d53 Gerrit-Change-Number: 35053 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-Attention: neels Gerrit-Comment-Date: Fri, 17 Nov 2023 12:18:50 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: msc: split off f_mo_call_establish__handle_assignment_request()
Attention is currently required from: neels.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35052?usp=email )
Change subject: msc: split off f_mo_call_establish__handle_assignment_request()
..
Patch Set 2:
(3 comments)
File msc/BSC_ConnectionHandler.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35052/comment/f2ba93a0_1dafca72
PS2, Line 1557: f_mo_call_establish__handle_assignment_request
Hmm, I find the double low-dash a bit weird, but guessing you did it
intentionally?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35052/comment/d0db350a_0c788961
PS2, Line 1573: not
match(ass_req.pdu.bssmap.assignmentRequest.aoIPTransportLayer, tla_ass1
btw, this matching statement can be simplified a bit to:
```
if (not match(ass_req.pdu.bssmap.assignmentRequest.aoIPTransportLayer,
(tla_ass1, tla_ass2))
```
not strictly related to this patch, just an idea
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35052/comment/75febbd8_3e1d39f0
PS2, Line 1690: valueof(ts_CodecFR
Hmm, so now you're explicitly passing `ts_CodecFR`, but the new function may
overwrite it to `ts_CodecCSData`. I find this confusing. Passing the right
codec template here _conditionally_ would be cleaner, IMO:
```
if (cpars.csd) {
f_mo_call_establish__handle_assignment_request(cpars, bssap,
valueof(ts_CodecCSData));
} else {
f_mo_call_establish__handle_assignment_request(cpars, bssap,
valueof(ts_CodecFR));
}
```
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35052?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I98c6171a592dfe1573e15136c4ecf4ff234048d7
Gerrit-Change-Number: 35052
Gerrit-PatchSet: 2
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria
Gerrit-Attention: neels
Gerrit-Comment-Date: Fri, 17 Nov 2023 12:14:19 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests_LAPDm.TC_sabm_retransmit_bts: Fix time to wait
jolly has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35054?usp=email )
Change subject: BTS_Tests_LAPDm.TC_sabm_retransmit_bts: Fix time to wait
..
BTS_Tests_LAPDm.TC_sabm_retransmit_bts: Fix time to wait
Wait 20 seconds, because T200 on SDCCH, SAPI 3 lasts about 2 seconds.
Relates: OS#5970
Change-Id: I593008420f58cc1d5e4778874f9071914d24f82e
---
M bts/BTS_Tests_LAPDm.ttcn
1 file changed, 14 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/54/35054/1
diff --git a/bts/BTS_Tests_LAPDm.ttcn b/bts/BTS_Tests_LAPDm.ttcn
index 2e984d1..7dda8b8 100644
--- a/bts/BTS_Tests_LAPDm.ttcn
+++ b/bts/BTS_Tests_LAPDm.ttcn
@@ -287,7 +287,7 @@
LAPDM.clear;
RSL.send(ts_RSL_EST_REQ(g_chan_nr, ts_RslLinkID_DCCH(sapi)));
- timer T := 8.0;
+ timer T := 20.0;
var integer sabm_received := 0;
T.start;
alt {
@@ -311,6 +311,7 @@
}
testcase TC_sabm_retransmit_bts() runs on test_CT {
var ConnHdlrPars pars := valueof(t_Pars(t_RslChanNr_Bm(1),
ts_RSL_ChanMode_SIGN));
+ pars.t_guard := 30.0;
f_testmatrix_each_chan(pars, refers(f_TC_sabm_retransmit_bts));
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35054?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I593008420f58cc1d5e4778874f9071914d24f82e
Gerrit-Change-Number: 35054
Gerrit-PatchSet: 1
Gerrit-Owner: jolly
Gerrit-MessageType: newchange
[S] Change in osmo-msc[master]: add sdp_audio_codec_to_speech_codec_list()
Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35050?usp=email ) Change subject: add sdp_audio_codec_to_speech_codec_list() .. Patch Set 1: Code-Review+1 (1 comment) File src/libmsc/codec_mapping.c: https://gerrit.osmocom.org/c/osmo-msc/+/35050/comment/9f6fa8d4_c948ee2a PS1, Line 427: scl->len >= ARRAY_SIZE(scl->codec IMO, it would be more logical to perform this check first before the two other checks, but not critical. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35050?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6ac23c54bc26939e048ff2df06eb987421cfb1c5 Gerrit-Change-Number: 35050 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Attention: neels Gerrit-Comment-Date: Fri, 17 Nov 2023 11:43:10 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-msc[master]: fix codec mapping for GSM-HR
Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35049?usp=email ) Change subject: fix codec mapping for GSM-HR .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35049?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I19cff847a0f618ad000d12c1df54c55ef2f79699 Gerrit-Change-Number: 35049 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Attention: neels Gerrit-Comment-Date: Fri, 17 Nov 2023 11:36:27 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: hlr: add imsi unknown cause test case
Attention is currently required from: fixeria, laforge, lynxis lazus, neels. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569?usp=email ) Change subject: hlr: add imsi unknown cause test case .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I87c3a2d7304b81cfc11a364d933567e1a080b99a Gerrit-Change-Number: 27569 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-CC: laforge Gerrit-Attention: neels Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-Attention: lynxis lazus Gerrit-Comment-Date: Fri, 17 Nov 2023 11:03:49 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
