Re: Problem with launch GWT
koko schrieb: In my laptop I can't launch GWT host mode, Any one can help me please? I can give you my address and you send the laptop. With that I can surely help you ;-) Also I found if I disable my wireless connection it works fine?? What's worng ? Any one know ? Many Thanks!! [...] (111) Connection refused The remote host or network may be down. Please try the request again. What is localhost resolving to? Try 127.0.0.1 instead of localhost as first test. If that works with your wireless connection active, your name-server resolves localhost in an interesting way. Regards, Lothar --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Re: Event driven communication between independent GWT modules
Hello, I've been doing exactly what JEA asks using GWTx (http:// code.google.com/p/gwtx/)... it extends GWT to use java.beans.PropertyChange* which implement all that's needed for the Observer and clientside MVC patterns. As an example for JEA's request you could implement a user model that sends a userLogged PropertyChange event; all registered views (the apps, in his case) to this event would then update accordingly. To manage which apps can/can't be displayed an idea would be to use a static singleton registry-like class... A very good source of information for propertyChange support and best programming practices, and my bible for GWT, is the book GWT in practice by Cooper/Collins on Manning. Hope this helps, Francesco P.S. It woud be great if GWT implemented natively the java.beans package On Nov 5, 2:36 pm, walden [EMAIL PROTECTED] wrote: Joe, Aha! moment: GWT is not Java. Walden On Nov 5, 2:00 am, JEA [EMAIL PROTECTED] wrote: Thanks to everyone who contributed their comments on this problem. It has been tremendously educational for me. This is my first crack at using GWT. To clarify, I am trying to send event messages between separately compiled GWT mini-apps on one page, not just separate modules. As was suggested in this thread, I've found it an intractable problem without resorting to pure javascript plumbing and it sounds like I may not be doing myself any good anyway as far as speed and size are concerned, at least until I am talking about quite a few different mini-apps. Maybe be the time I reach that point, the runAsync feature will be available and solve that problem, too. As much as anything, it just felt *wrong* to be carrying around from page to page a bunch of app code that would be used on only one or two of the pages, but maybe I just need to get over that and get on with the project. Joe --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Only digits in TextBox: differences between Firefox and IE
I use a KeyboardListener to check the typed character. I've seen this
example in the book GWT in Action:
public void onKeyUp(Widget sender, char keyCode, int modifiers) {
if (!Character.isDigit(keyCode)) {
((TextBox)sender).cancelKey();
return;
}
}
In IE it works but in FF the Listeners is listen to the control-,
delete- and backspace- key too. I can't delete an character because
these keys are no digits.
How can I check if the keys are a control, delete or the backspace?
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post to this group, send email to Google-Web-Toolkit@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/Google-Web-Toolkit?hl=en
-~--~~~~--~~--~--~---
Re: Only digits in TextBox: differences between Firefox and IE
Hi try this
if(keyCode!= KeyboardListener.KEY_BACKSPACE || keyCode!=
KeyboardListener.KEY_DELETE){
if (!Character.isDigit(keyCode)) {
((TextBox)sender).cancelKey();
return;
}
}
HTH :)
On Nov 6, 11:05 am, Schimki86 [EMAIL PROTECTED] wrote:
I use a KeyboardListener to check the typed character. I've seen this
example in the book GWT in Action:
public void onKeyUp(Widget sender, char keyCode, int modifiers) {
if (!Character.isDigit(keyCode)) {
((TextBox)sender).cancelKey();
return;
}
}
In IE it works but in FF the Listeners is listen to the control-,
delete- and backspace- key too. I can't delete an character because
these keys are no digits.
How can I check if the keys are a control, delete or the backspace?
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post to this group, send email to Google-Web-Toolkit@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/Google-Web-Toolkit?hl=en
-~--~~~~--~~--~--~---
Re: Only digits in TextBox: differences between Firefox and IE
Schimki86 schrieb:
I use a KeyboardListener to check the typed character. I've seen this
example in the book GWT in Action:
public void onKeyUp(Widget sender, char keyCode, int modifiers) {
if (!Character.isDigit(keyCode)) {
((TextBox)sender).cancelKey();
return;
}
}
In IE it works but in FF the Listeners is listen to the control-,
delete- and backspace- key too. I can't delete an character because
these keys are no digits.
This is my implementation after finding out the same:
/**
* KeyboardListener allowing only digits to be entered
*/
public static KeyboardListenerAdapter OnlyDigitListener = new
KeyboardListenerAdapter() {
public void onKeyPress(final Widget sender, final char keyCode, final
int modifiers) {
switch(keyCode){
case KEY_LEFT:
case KEY_DOWN:
case KEY_RIGHT:
case KEY_UP:
case KEY_BACKSPACE:
case KEY_DELETE:
return;
}
if (!Character.isDigit(keyCode)) {
((TextBoxBase) sender).cancelKey();
}
}
};
Works here. The class is a static inner class, so I can use
it in all components that need a digit-only textbox. As
well you can create new anonymous classes that way, to change
the behavior:
textBox.addKeyboardListener(new OnlyDigitListener(){
public void onKeyPress(final Widget sender, final char keyCode, final int
modifiers) {
if (keyCode == '.' || keyCode == '-'){
return;
}
super.onKeyPress(sender, keyCode, modifiers);
}
}
Regards, Lothar
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post to this group, send email to Google-Web-Toolkit@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/Google-Web-Toolkit?hl=en
-~--~~~~--~~--~--~---
Re: Only digits in TextBox: differences between Firefox and IE
Wow, that was quickly ^^
It works very well. Thank you (both) very much!
2008/11/6 Lothar Kimmeringer [EMAIL PROTECTED]
Schimki86 schrieb:
I use a KeyboardListener to check the typed character. I've seen this
example in the book GWT in Action:
public void onKeyUp(Widget sender, char keyCode, int modifiers) {
if (!Character.isDigit(keyCode)) {
((TextBox)sender).cancelKey();
return;
}
}
In IE it works but in FF the Listeners is listen to the control-,
delete- and backspace- key too. I can't delete an character because
these keys are no digits.
This is my implementation after finding out the same:
/**
* KeyboardListener allowing only digits to be entered
*/
public static KeyboardListenerAdapter OnlyDigitListener = new
KeyboardListenerAdapter() {
public void onKeyPress(final Widget sender, final char keyCode,
final int modifiers) {
switch(keyCode){
case KEY_LEFT:
case KEY_DOWN:
case KEY_RIGHT:
case KEY_UP:
case KEY_BACKSPACE:
case KEY_DELETE:
return;
}
if (!Character.isDigit(keyCode)) {
((TextBoxBase) sender).cancelKey();
}
}
};
Works here. The class is a static inner class, so I can use
it in all components that need a digit-only textbox. As
well you can create new anonymous classes that way, to change
the behavior:
textBox.addKeyboardListener(new OnlyDigitListener(){
public void onKeyPress(final Widget sender, final char keyCode, final
int modifiers) {
if (keyCode == '.' || keyCode == '-'){
return;
}
super.onKeyPress(sender, keyCode, modifiers);
}
}
Regards, Lothar
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post to this group, send email to Google-Web-Toolkit@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/Google-Web-Toolkit?hl=en
-~--~~~~--~~--~--~---
adobe air browser not support gmail.
I am planning to create web browser to display gwt project. The browser is created by using adobe air. I tested it by using this browser http://www.softpedia.com/get/Internet/Browsers/SmartFox.shtml . When i view the gmail. It contain the following text. For a better Gmail experience, use a fully supported browser. Learn more I know air is using webkit(http://help.adobe.com/en_US/AIR/1.1/ devappsflex/WS5b3ccc516d4fbf351e63e3d118666ade46-7e7b.html). As i know, google browser is using webkit and safari too but it work fine. I afraid that the air browser is not compatible with the lasted gwt code. Any idea for me? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Re: Single application .. multiple RPC services
Hi Muhannad, Usually in GWT applications, you have one HTML page and the UI rendering is done dynamically using javascript. You can create different panels for different pages and add these panels to the RootPanel when a user clicks on hyperlinks (in ur case). And while rendering these panels when you require some data from the server, you can make RPC calls. May be first you should go through some simple GWT tutorial before begining your project. Regards, Litty Preeth On Thu, Nov 6, 2008 at 1:05 PM, Muhannad [EMAIL PROTECTED] wrote: Hi Walden, I'm not sure that I got your idea, but I always had a concern about that so I'll share it with you: 1. Does the GWT application have just one html page (module-name.html) that all the content should be rendered there? What I mean is that Litty wrote if the URL ends with /about then the AboutService will be called. Well but what if that AboutService does not extends or consists of any UI element? What is gonna to be displayed on the browser? 2. What I've received from your idea above is, each service should have its own (index.html)??!! If that was the case, each time I click on a menu item then a whole new page is going to be rendered and the browser will send an HTTP request and page will be rebuilt and displayed, which is not the case here: http://extjs.com/ Please try to click any menu item and notice that only a portion of the page is rendered (the section under the menu) and not the whole page. Actually, this is exactly what I need to do but I think I was not clear enough. 3. Suppose that I want to pass parameters in the URL in some customized format; not using the regular way http://domain/service?param1=value1param2=value2. For example, something like that: http://domain/service/param1/value1/param2/value2. Where should I write my own code that should take care of this customized URL encoding?? I mean, is there any place in GWT application where I could capture the URL and manipulate it before redirect it to some place depending on some parameters passed?? I guess there is something in .NET called HTTP Handler or Generic Handler to deal with that. I think this is an issue that the Web Server should deal with it not the GWT application???!!! Thank you very much. On Nov 5, 5:56 pm, walden [EMAIL PROTECTED] wrote: Muhannad, There's a problem with your assumptions. When a user clicks on your about menu link, she's not going to get a Panel, she's going to get a whole new page fromhttp://domain/about/index.html. That page can be a GWT host file if you like, but this is regular HTML pages, not a rich GWT client showing and hiding content based on menu navigation. I think you'd better get your head around that first, and then tackle the RPC URL binding question next, if it's even an issue at all. Walden On Nov 5, 5:12 am,Muhannad[EMAIL PROTECTED] wrote: Hi, I want to build a website with (Home, about, products, ...) menu. I need to build multiple forms (panels), each panel corresponds to one menu item, e.g. aboutPanel for about menu item, productsPanel for products... Moreover, I would like to implement that panel in terms of RPC services; I need to correspond each panel to a single RPC service that communicates with the server to get its data, build the whole form, and return the result as a panel to be displayed somewhere in the home page (for example). Of course, GWT allows us to define multiple services and add multiple servlet path=/service ... to the module XML file. My problem is how to know which service should I instantiate depending on the URL mapping, i.e. suppose that the menu is defined as follow: div id=menu a href=index.htmlHome/a a href=/aboutAbout us/a a href=/productsProducts/a ... /div So when someone clicks the About us link, the URL would be http:// domain/about. So I should instantiate the about service and create an aboutPanel to display it. The same thing when s/he clicks the Products link, then the URL is http://domain/products; and, in this case, I should build the product panel... So, is there somewhere in GWT application that I could parse the URL and depending on the mapping portion of it /about or /products could I decide which service to instantiate? Or is there another better way to do that? Thank you very much in advance. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Re: state of hibernate + GWT 1.5
Hi David, We have been working GWT and Hibernate in most web apps we do. In the past we have simply wrote our own DTO to Persistent copying code (Your option 3) but a lot of people have recommended hibernate4GWT to take the pain out of doing this. This was complicated at the time and we had to write some complex graph walking algorithms and aim to avoid any 'cicular references' so that our code didn't get stuck in a loop initialising objects. Also we began GWT and Hibernate development before GWT introduced version 1.5 so we didn't have the option of using Java Generics and strongly typed sets etc which meant we had to use Persistent objects and GWT serializable client side objects. (We do our mapping using Hibernate Annotations) I'm wondering now whether the simplest option would be to include your persistent objects on the client side (GWT has the clause that any client side code must be under the package contains 'client') and make them serializable then you can reference them from both the server and client side as you mention in option 2. You have to make sure that any queries you run initialise all the objects you're going to need for example: from myPersistentObject as pojo left join fetch pojo.collectionOfOtherObjects as coll where coll.someValue = :whatever In the previous example I left joing fetch my collection of other objects because I know I'm going to use them in the client side code. We have found you need to do this otherwise you hit LazyInitialization exceptions further on. As we've not started a new project (and haven't upgraded our legacy projects ) to GWT 1.5 I can't share any experience on simply making the persistent objects Serializable but I can't see it being to big an issue? Please anyone correct me of course?! Thats my initial thoughts anyway... On Nov 5, 9:44 pm, David Durham, Jr. [EMAIL PROTECTED] wrote: Hi all, What's the state of things with Hibernate and GWT 1.5. I've done some quick googling and I see reference to the following: 1 - hibernate4gwt 2 - Making hibernate persistent collections GWT serializable 3 - Just writing your pojo copy utility perhaps using beanlib I'm wondering if there is one route that is the preferred/recommended way to go with this issue. Thanks in advance, Dave --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Re: adobe air browser not support gmail.
On 6 nov, 10:49, jimmy6 [EMAIL PROTECTED] wrote: I am planning to create web browser to display gwt project. The browser is created by using adobe air. I tested it by using this browserhttp://www.softpedia.com/get/Internet/Browsers/SmartFox.shtml . When i view the gmail. It contain the following text. For a better Gmail experience, use a fully supported browser. Learn more I know air is using webkit(http://help.adobe.com/en_US/AIR/1.1/ devappsflex/WS5b3ccc516d4fbf351e63e3d118666ade46-7e7b.html). As i know, google browser is using webkit and safari too but it work fine. I afraid that the air browser is not compatible with the lasted gwt code. Any idea for me? AFAICT, GWT produces AIR-compatible code since 1.5RC2 [1] [2]. Try it with the Google Code Document Reader for instance: http://code.google.com/docreader/ ...but GMail is just *not* built with GWT! [1] http://code.google.com/p/google-web-toolkit/issues/detail?id=2550 [2] http://code.google.com/p/gwt-in-the-air/ --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Re: Introducing GWT Beans Binding
Hello,
There's another data binding library that's being worked on here:
http://code.google.com/p/gwt-data-binding/
Data binding was discussed in some length on GWTC here:
http://groups.google.com/group/Google-Web-Toolkit-Contributors/browse_thread/thread/9242295c5e2cb5c5/609ae3692db0f3e9.
It culminated in Ian Petersens creating the project above (which he
has used internally).
Regards,
--
Arthur Kalmenson
On Tue, Nov 4, 2008 at 10:12 AM, [EMAIL PROTECTED]
[EMAIL PROTECTED] wrote:
Hi,
I started porting Beans Binding (JSR 295) (https://
beansbinding.dev.java.net/) to GWT.
http://code.google.com/p/gwt-beans-binding/
Still not implemented is the EL library ELProperty, but BeanProperty
works like expected.
For reflection I use a GWTx based generator that will create the
BeanInfo of all classes that implement BeanAdaptor:
import java.beans.PropertyChangeListener;
public interface BeanAdapter {
void addPropertyChangeListener(PropertyChangeListener listener);
void removePropertyChangeListener(PropertyChangeListener listener);
void addPropertyChangeListener(String property,
PropertyChangeListener listener);
void removePropertyChangeListener(String property,
PropertyChangeListener listener);
}
by only adding:
static {
try {
GWT.create(BeanAdapter.class);
} catch (Throwable t) {
// GWT.log(t.getMessage(), t);
}
}
to the module class.
Additional adapters for use by the BeanProperty can be registered
with:
BeanAdapterFactory.addProvider(new TextBoxAdapterProvider());
See demo code at:
http://code.google.com/p/gwt-beans-binding/source/browse/trunk/src/org/gwt/beansbinding/client/Main.java
Kind Regards,
George.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post to this group, send email to Google-Web-Toolkit@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/Google-Web-Toolkit?hl=en
-~--~~~~--~~--~--~---
Re: state of hibernate + GWT 1.5
Hello Dave, We use a common domain object between the client and server side. The domain objects are JPA annotated beans, and they travel between the client and server. The only think you have to watch out for is PersistentSets and other Hibernate specific collections. Regards, -- Arthur Kalmenson On Wed, Nov 5, 2008 at 4:44 PM, David Durham, Jr. [EMAIL PROTECTED] wrote: Hi all, What's the state of things with Hibernate and GWT 1.5. I've done some quick googling and I see reference to the following: 1 - hibernate4gwt 2 - Making hibernate persistent collections GWT serializable 3 - Just writing your pojo copy utility perhaps using beanlib I'm wondering if there is one route that is the preferred/recommended way to go with this issue. Thanks in advance, Dave --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Re: state of hibernate + GWT 1.5
Of course the old persistent set problem! I remember that now and why we had to do DTO's. Good point Arthur! So did you have common domain objects for each persistent class? And had to convert the objects copying the properties over using something like BeanUtils or another way? On Nov 6, 1:49 pm, Arthur Kalmenson [EMAIL PROTECTED] wrote: Hello Dave, We use a common domain object between the client and server side. The domain objects are JPA annotated beans, and they travel between the client and server. The only think you have to watch out for is PersistentSets and other Hibernate specific collections. Regards, -- Arthur Kalmenson On Wed, Nov 5, 2008 at 4:44 PM, David Durham, Jr. [EMAIL PROTECTED] wrote: Hi all, What's the state of things with Hibernate and GWT 1.5. I've done some quick googling and I see reference to the following: 1 - hibernate4gwt 2 - Making hibernate persistent collections GWT serializable 3 - Just writing your pojo copy utility perhaps using beanlib I'm wondering if there is one route that is the preferred/recommended way to go with this issue. Thanks in advance, Dave --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Re: hot code replacement in external module
any clues at all? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Re: GWT-ext or ext-GWT?
This is a common theme, and as I said above, I highly recommend keeping far away from ext gwt or gwt ext. You can get the same shininess with some nice CSS. -- Arthur Kalmenson On Wed, Nov 5, 2008 at 3:08 AM, zebulon303 [EMAIL PROTECTED] wrote: I am trying to use ext-gwt for a few days, and I get crazy because of the really poor documentation available, you only have the code to understand what you are doing, and not enough general guidelines. I don't know how it is for GWT ext, but I will definitely have a look. I am really new with GWT in general, maybe that's why I need more documentation. I was trying to figure out how to add a delete button to the EditorGrid, or just access the current selected item of the grid. I find it really difficult to get to this simple information. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Re: Single application .. multiple RPC services
Well, thank you Litty but I think there is still something missing to deal with. So I wrote a sample application and I'll send it to you at you gmail account (Sorry, I don't know how to attach a file here). Please review it .. and to be more clear again: this is what I don't know how to do. You will find that I have two divs on the home page (RPCServics.html): (1) menu div and (2) content div. In onModuleLoad() method I create two links a href='home'Home/a and a href='about'About Us/a. What I need exactly is when the user clicks Home link, then the content div will hold the HomePanel (it's a class you could find in com.ePediaSy.client.panels package), and when he clicks About Us link the content panel should hold the AboutPanel. C'est tout! et merci beaucoup. I'm looking forward to hear from you. P.S. Please put the sample here in the thread if you know how to; I could not do it. On Nov 6, 11:57 am, Litty Preeth [EMAIL PROTECTED] wrote: Hi Muhannad, Usually in GWT applications, you have one HTML page and the UI rendering is done dynamically using javascript. You can create different panels for different pages and add these panels to the RootPanel when a user clicks on hyperlinks (in ur case). And while rendering these panels when you require some data from the server, you can make RPC calls. May be first you should go through some simple GWT tutorial before begining your project. Regards, Litty Preeth On Thu, Nov 6, 2008 at 1:05 PM, Muhannad [EMAIL PROTECTED] wrote: Hi Walden, I'm not sure that I got your idea, but I always had a concern about that so I'll share it with you: 1. Does the GWT application have just one html page (module-name.html) that all the content should be rendered there? What I mean is that Litty wrote if the URL ends with /about then the AboutService will be called. Well but what if that AboutService does not extends or consists of any UI element? What is gonna to be displayed on the browser? 2. What I've received from your idea above is, each service should have its own (index.html)??!! If that was the case, each time I click on a menu item then a whole new page is going to be rendered and the browser will send an HTTP request and page will be rebuilt and displayed, which is not the case here:http://extjs.com/Please try to click any menu item and notice that only a portion of the page is rendered (the section under the menu) and not the whole page. Actually, this is exactly what I need to do but I think I was not clear enough. 3. Suppose that I want to pass parameters in the URL in some customized format; not using the regular way http://domain/service?param1=value1param2=value2. For example, something like that: http://domain/service/param1/value1/param2/value2. Where should I write my own code that should take care of this customized URL encoding?? I mean, is there any place in GWT application where I could capture the URL and manipulate it before redirect it to some place depending on some parameters passed?? I guess there is something in .NET called HTTP Handler or Generic Handler to deal with that. I think this is an issue that the Web Server should deal with it not the GWT application???!!! Thank you very much. On Nov 5, 5:56 pm, walden [EMAIL PROTECTED] wrote: Muhannad, There's a problem with your assumptions. When a user clicks on your about menu link, she's not going to get a Panel, she's going to get a whole new page fromhttp://domain/about/index.html. That page can be a GWT host file if you like, but this is regular HTML pages, not a rich GWT client showing and hiding content based on menu navigation. I think you'd better get your head around that first, and then tackle the RPC URL binding question next, if it's even an issue at all. Walden On Nov 5, 5:12 am,Muhannad[EMAIL PROTECTED] wrote: Hi, I want to build a website with (Home, about, products, ...) menu. I need to build multiple forms (panels), each panel corresponds to one menu item, e.g. aboutPanel for about menu item, productsPanel for products... Moreover, I would like to implement that panel in terms of RPC services; I need to correspond each panel to a single RPC service that communicates with the server to get its data, build the whole form, and return the result as a panel to be displayed somewhere in the home page (for example). Of course, GWT allows us to define multiple services and add multiple servlet path=/service ... to the module XML file. My problem is how to know which service should I instantiate depending on the URL mapping, i.e. suppose that the menu is defined as follow: div id=menu a href=index.htmlHome/a a href=/aboutAbout us/a a href=/productsProducts/a ... /div So when someone clicks the About us link, the URL would be http:// domain/about. So I should
Re: Only digits in TextBox: differences between Firefox and IE
On 6 nov, 10:27, Lothar Kimmeringer [EMAIL PROTECTED] wrote:
public static KeyboardListenerAdapter OnlyDigitListener = new
KeyboardListenerAdapter() {
public void onKeyPress(final Widget sender, final char keyCode, final
int modifiers) {
switch(keyCode){
case KEY_LEFT:
case KEY_DOWN:
case KEY_RIGHT:
case KEY_UP:
case KEY_BACKSPACE:
case KEY_DELETE:
return;
FWIW, we're also allowing KEY_HOME, KEY_END, KEY_TAB and KEY_ENTER in
our own code.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post to this group, send email to Google-Web-Toolkit@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/Google-Web-Toolkit?hl=en
-~--~~~~--~~--~--~---
Re: Bean Serialization Problem: com.google.gwt.user.client.rpc.SerializationException: Type 'com.dg.common.client.beans.DGUser' was not assignable to 'com.google.gwt.user.client.rpc.IsSerializable'
I fixed it by implementing GWT's IsSerializable interface instead of Java's Serializable... Can't figure out why it works on Winows env. JM On Nov 5, 4:01 pm, JM [EMAIL PROTECTED] wrote: ping2ravi I'm glad you came back to tell it's now working for you! But think of all those people with the same problem you had... like me. Any idea? My classes are implementing Serializable. It's working fine on my development environment (Windows). But now that I try an integration (Linux), I get the same exception. Thanks, JM On 23 oct, 11:10, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Hi May we know what was causing the difference in file-names? I am having a similar exception G. On Sep 22, 1:06 pm, ping2ravi [EMAIL PROTECTED] wrote: i found the problem why file names were different. Thanks On Sep 22, 11:18 am, ping2ravi [EMAIL PROTECTED] wrote: Hi All, My application was working good till now and now i deployed it to other machine and it start giving me following exception. My DGUser class is implementing serializable interface. SEVERE: Exception while dispatching incoming RPC call com.google.gwt.user.client.rpc.SerializationException: Type 'com.dg.common.client.beans.DGUser' was not assignable to 'com.google.gwt.user.client.rpc.IsSerializable' and did not have a custom field serializer. For security purposes, this type will not be serialized. at com.google.gwt.user.server.rpc.impl.LegacySerializationPolicy.validateSerialize(LegacySerializationPolicy.java: 140) at com.google.gwt.user.server.rpc.impl.ServerSerializationStreamWriter.serialize(ServerSerializationStreamWriter.java: 585) at com.google.gwt.user.client.rpc.impl.AbstractSerializationStreamWriter.writeObject(AbstractSerializationStreamWriter.java: 129) at com.google.gwt.user.server.rpc.impl.ServerSerializationStreamWriter $ValueWriter$8.write(ServerSerializationStreamWriter.java:146) at com.google.gwt.user.server.rpc.impl.ServerSerializationStreamWriter.serializeValue(ServerSerializationStreamWriter.java: 520) at com.google.gwt.user.server.rpc.RPC.encodeResponse(RPC.java:573) at com.google.gwt.user.server.rpc.RPC.encodeResponseForSuccess(RPC.java: 441) at com.google.gwt.user.server.rpc.RPC.invokeAndEncodeResponse(RPC.java: 529) at com.google.gwt.user.server.rpc.RemoteServiceServlet.processCall(RemoteServiceServlet.java: 163) at com.google.gwt.user.server.rpc.RemoteServiceServlet.doPost(RemoteServiceServlet.java: 85) at javax.servlet.http.HttpServlet.service(HttpServlet.java:710) at javax.servlet.http.HttpServlet.service(HttpServlet.java:803) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java: 290) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java: 206) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java: 233) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java: 175) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java: 128) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java: 102) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java: 109) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java: 263) at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java: 844) at org.apache.coyote.http11.Http11Protocol $Http11ConnectionHandler.process(Http11Protocol.java:584) at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java: 447) at java.lang.Thread.run(Thread.java:619) And also its giving following error in the log file, So i am guessing its because of this .gwt.rpc missing file, INFO: ERROR: The serialization policy file '/ D96C005D9FEF0E3183DC3057D9F48727.gwt.rpc' was not found; did you forget to include it in this deployment? INFO: WARNING: Failed to get the SerializationPolicy 'D96C005D9FEF0E3183DC3057D9F48727' for module 'http://localhost:8090/ AdminMenu/'; a legacy, 1.3.3 compatible, serialization policy will be used. You may experience SerializationExceptions as a result. I checked my deployed application directory there is only one .gwt.rpc file which is E8B2AED1667057CBC391B7AC2BFAA4E9.gwt.rpc but not D96C005D9FEF0E3183DC3057D9F48727.gwt.rpc. I don't know how GWT is generating this file name and why its generating different names when its being actual generating the file and when its using it. And the file which
Re: How to create layout?
On 5 nov, 12:06, DevUnion [EMAIL PROTECTED] wrote: Hello All, I've started GWT studying few days ago. And I have a lot of questions. For example, I need to create next layout: +-- -- + | Logo Image Here | Empty space | Help | +-- -- + I've tried next approach: DockPanel header = new DockPanel(); header.add(clientImageBundle.firstmileLogo().createImage(), DockPanel.WEST); header.add(helpLink, DockPanel.EAST); But it doesn't work. Can anyone help me? For this same kind of layout, I'm currently using a FlowPanel and a float:right CSS rule. But you can do it more easily (if you don't know HTML and/or CSS well) with a Grid or HorizontalPanel (I have a preference for Grid, but it's a personal choice): Grid header = new Grid(1, 2); header.setHTML(0, 0, clientImageBundle.firstmileLogo().getHTML()); header.setWidget(0, 1, helpLink); // and now align the helpLink to the right header.getCellFormatter().setHorizontalAlignment(0, 1, HasHorizontalAlignment.ALIGN_RIGHT); --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Re: Single application .. multiple RPC services
Hi Muhannad, You will find that I have two divs on the home page (RPCServics.html): (1) menu div and (2) content div. In onModuleLoad() method I create two links a href='home'Home/a and a href='about'About Us/a. What I need exactly is when the user clicks Home link, then the content div will hold the HomePanel (it's a class you could find in com.ePediaSy.client.panels package), and when he clicks About Us link the content panel should hold the AboutPanel. Why are you doing this? I think you are maybe making life necessarily difficult for yourself. As Litty has commented a GWT application is normally built around a single HTML page that has little or no content apart from a single div to house the GWT javascript application that is normally automatically generated for you by the project creator or your IDE. A more typical approach to your scenario would be to use, for example, a DockPanel. You might construct a navigation widget and place it in DockPanel.NORTH. This might include a MenuBar, Buttons, Hyperlinks, whatever, but they are all GWT widgets. You could implement your content using a Composite based around, for example, DeckPanel or TabPanel and place this in DockPanel.CENTER. That is a more GWT way to do things. regards gregor On Nov 6, 11:57 am, Litty Preeth [EMAIL PROTECTED] wrote: Hi Muhannad, Usually in GWT applications, you have one HTML page and the UI rendering is done dynamically using javascript. You can create different panels for different pages and add these panels to the RootPanel when a user clicks on hyperlinks (in ur case). And while rendering these panels when you require some data from the server, you can make RPC calls. May be first you should go through some simple GWT tutorial before begining your project. Regards, Litty Preeth On Thu, Nov 6, 2008 at 1:05 PM, Muhannad [EMAIL PROTECTED] wrote: Hi Walden, I'm not sure that I got your idea, but I always had a concern about that so I'll share it with you: 1. Does the GWT application have just one html page (module-name.html) that all the content should be rendered there? What I mean is that Litty wrote if the URL ends with /about then the AboutService will be called. Well but what if that AboutService does not extends or consists of any UI element? What is gonna to be displayed on the browser? 2. What I've received from your idea above is, each service should have its own (index.html)??!! If that was the case, each time I click on a menu item then a whole new page is going to be rendered and the browser will send an HTTP request and page will be rebuilt and displayed, which is not the case here:http://extjs.com/Pleasetry to click any menu item and notice that only a portion of the page is rendered (the section under the menu) and not the whole page. Actually, this is exactly what I need to do but I think I was not clear enough. 3. Suppose that I want to pass parameters in the URL in some customized format; not using the regular way http://domain/service?param1=value1param2=value2. For example, something like that: http://domain/service/param1/value1/param2/value2. Where should I write my own code that should take care of this customized URL encoding?? I mean, is there any place in GWT application where I could capture the URL and manipulate it before redirect it to some place depending on some parameters passed?? I guess there is something in .NET called HTTP Handler or Generic Handler to deal with that. I think this is an issue that the Web Server should deal with it not the GWT application???!!! Thank you very much. On Nov 5, 5:56 pm, walden [EMAIL PROTECTED] wrote: Muhannad, There's a problem with your assumptions. When a user clicks on your about menu link, she's not going to get a Panel, she's going to get a whole new page fromhttp://domain/about/index.html. That page can be a GWT host file if you like, but this is regular HTML pages, not a rich GWT client showing and hiding content based on menu navigation. I think you'd better get your head around that first, and then tackle the RPC URL binding question next, if it's even an issue at all. Walden On Nov 5, 5:12 am,Muhannad[EMAIL PROTECTED] wrote: Hi, I want to build a website with (Home, about, products, ...) menu. I need to build multiple forms (panels), each panel corresponds to one menu item, e.g. aboutPanel for about menu item, productsPanel for products... Moreover, I would like to implement that panel in terms of RPC services; I need to correspond each panel to a single RPC service that communicates with the server to get its data, build the whole form, and return the result as a panel to be displayed somewhere in the home page (for example). Of course, GWT allows us to define multiple services and add multiple
problem in display of grid FloatFieldDef column
i declared the columnconfig of a EditorGridPanel as showed below
when i tried to display nubmer without fraction value its not
displaying fraction value
eg: i need the value to be displayed as 12.00 but its displaying as
12
after i place the focus its diaplaying as i desired but i want it to
be displayed in default..
can any one give me the solution plz
private final RecordDef recordDef = new RecordDef(new FieldDef[]{
new StringFieldDef(code),
new StringFieldDef(lbl),
new FloatFieldDef(zairoyuKanrihiHiritu),
new FloatFieldDef(ippanKanriHanbaihiHiritu),
new FloatFieldDef(riekiritu),
new FloatFieldDef(kakouJikanKanriHiritu),
new FloatFieldDef(kakouHirituKanriHiritu),
new StringFieldDef(bikou)
});
Store store = new Store(recordDef);
/**
*
*/
private ColumnModel columnModel = new ColumnModel(new
ColumnConfig[]
{
new ColumnConfig() {
{
setHeader(Code); // The title of the header.
setDataIndex(code); // The RecordDef data type.
setSortable(false);
setWidth(100);
setHidden(true);
}
},
new ColumnConfig() {
{
setHeader(); // The title of the header.
setDataIndex(lbl); // The RecordDef data type.
setCss({background-color: #EDEDED});
setSortable(false);
setWidth(100);
}
},
new ColumnConfig() {
{
setHeader(appConstants.zairoyuKanrihiHiritu()); // The
title of
the header.
setDataIndex(zairoyuKanrihiHiritu); // The RecordDef data
type.
setAlign(TextAlign.RIGHT);
NumberField NF = new NumberField();
NF.setSelectOnFocus(true);
setEditor(new GridEditor(NF));
setSortable(false);
setWidth(125);
}
},
new ColumnConfig() {
{
setHeader(appConstants.ippanKanriHanbaihiHiritu());
setDataIndex(ippanKanriHanbaihiHiritu);
setAlign(TextAlign.RIGHT);
NumberField NF = new NumberField();
NF.setAllowDecimals(true);
setEditor(new GridEditor(NF));
setSortable(false);
setWidth(130);
}
},
new ColumnConfig() {
{
setHeader(appConstants.riekiritu()); // The title of the
header.
setDataIndex(riekiritu); // The RecordDef data type.
setAlign(TextAlign.RIGHT);
NumberField NF = new NumberField();
NF.setSelectOnFocus(true);
setEditor(new GridEditor(NF));
setSortable(false);
setWidth(100);
}
},
new ColumnConfig() {
{
setHeader(appConstants.kakouJikanKanriHiritu()); // The
title of
the header.
setDataIndex(kakouJikanKanriHiritu); // The RecordDef data
type.
setAlign(TextAlign.RIGHT);
NumberField NF = new NumberField();
NF.setSelectOnFocus(true);
setEditor(new GridEditor(NF));
setSortable(false);
setWidth(125);
}
},
new ColumnConfig() {
{
setHeader(appConstants.kakouHirituKanriHiritu()); // The
title
of the header.
setDataIndex(kakouHirituKanriHiritu); // The RecordDef
data
type.
setAlign(TextAlign.RIGHT);
NumberField NF = new NumberField();
NF.setSelectOnFocus(true);
setEditor(new GridEditor(NF));
setSortable(false);
setWidth(125);
}
},
new ColumnConfig() {
{
setHeader(appConstants.bikou()); // The title of
the header.
setDataIndex(bikou); // The RecordDef data type.
TextField NF = new TextField();
setEditor(new
Re: Sleep() or wait() inside valueChanged Listener
On Thu, Nov 6, 2008 at 9:29 AM, Anurag Tripathi [EMAIL PROTECTED] wrote: Can we call Sleep( ) or wait( ) method for some busy waiting inside valueChangedListener without any threads? Nope. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Re: clicking outside the TreeItem firing onTreeItemSelected event
It all depends on your expectations ;-).
Actually, I do see the logic of selecting the node by clicking a spot
in the tree whose vertical location is unambiguously associated with
that node. My real question to you now is this: what is your
particular use case? What is it you cannot do because of this
feature?
Also, I suggest you look at the code in the Tree widget where ONCLICK
is handled (onBrowserEvent). You will see that the Tree
implementation traps click events at the top level and goes to quite a
bit of trouble to resolve them to a tree item. If you need to change
this, it may not be easy.
Walden
On Nov 5, 1:26 pm, Litty Preeth [EMAIL PROTECTED] wrote:
Walden,
But then a user will expect to select a tree node by clicking on the node
only rite? I dont feel that the node getting selected when you click else
where is an expected behavior.
- Litty
On Wed, Nov 5, 2008 at 10:51 PM, walden [EMAIL PROTECTED] wrote:
Litty,
Yeah, I see it now. It looks as if this is by design. If you need an
area to the right of the Tree (outside the Tree but inside the
ScrollPanel) where you can click without selecting a TreeItem (why?),
then you can probably achieve that by setting the Tree's width so it
does not fill the width of the ScrollPanel. What effect are you
trying to achieve?
Walden
On Nov 5, 8:21 am, Litty Preeth [EMAIL PROTECTED] wrote:
Hi Walden,
I tried using gwt-1.5.2 and gwt-1.5.
If gwt-1.5.2 is used on IE6 it happens only for the child node. Root
level
nodes are working fine. But on IE7 and Firefox it is reproducible for all
the nodes.
If gwt-1.5 is used on IE6 everything works fine. But on Firefox it is
reproducible for all the nodes.
You can use this code below to reproduce the issue.
TreeTest.java
package com.test.client;
import com.google.gwt.core.client.EntryPoint;
import com.google.gwt.user.client.Window;
import com.google.gwt.user.client.ui.RootPanel;
import com.google.gwt.user.client.ui.Tree;
import com.google.gwt.user.client.ui.TreeItem;
import com.google.gwt.user.client.ui.TreeListener;
/**
* Entry point classes define codeonModuleLoad()/code.
*/
public class TreeTest implements EntryPoint {
Tree myTree;
/**
* This is the entry point method.
*/
public void onModuleLoad() {
myTree = new Tree();
for (int i = 0; i 10; i++) {
TreeItem prItm = new TreeItem(Parent_ + i);
TreeItem chItm = new TreeItem(Child_ + i);
prItm.addItem(chItm);
myTree.addItem(prItm);
}
myTree.addTreeListener(treeListener);
RootPanel.get().add(myTree);
}
TreeListener treeListener = new TreeListener() {
public void onTreeItemSelected(TreeItem item) {
Window.alert(item.getText() + selected);
}
public void onTreeItemStateChanged(TreeItem item) {
// TODO Auto-generated method stub
}
};
}
TreeTest.css
.gwt-Tree {
border: 1px solid blue;
margin-left: 30px;
}
.gwt-Tree .gwt-TreeItem {
border: 1px solid red;
}
- Litty
On Wed, Nov 5, 2008 at 2:27 AM, walden [EMAIL PROTECTED]
wrote:
What version of GWT are you using? I'm trying the same thing in the
GWT showcase and not getting the result you are.
On Nov 4, 10:51 am, Litty Preeth [EMAIL PROTECTED] wrote:
Hi Walden,
I put a border to the TreeItem and also a border to the tree itself.
So
if I
click outside the border of the TreeItem, but inside the border of
the
tree;
the item in the vertical level where I click gets selected.
- Litty
On Tue, Nov 4, 2008 at 9:10 PM, walden [EMAIL PROTECTED]
wrote:
Litty,
How can you be sure you are actually clicking outside the TreeItem?
Walden
On Nov 4, 12:27 am, Litty Preeth [EMAIL PROTECTED] wrote:
Hi All,
I have a Tree on my page which I have added into a ScrollPanel.
My
problem is that if I click even outside the TreeItem (but within
the
scrollpanel) the item is getting selected (onTreeItemSelected of
the
TreeListener gets fired). Please help me on this issue.
Thanks in advance,
Litty- Hide quoted text -
- Show quoted text -- Hide quoted text -
- Show quoted text -- Hide quoted text -
- Show quoted text -
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post to this group, send email to Google-Web-Toolkit@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/Google-Web-Toolkit?hl=en
-~--~~~~--~~--~--~---
Support of web services
Hello! I would like to know how requests to web services are handled with GWT. Indeed, I have a java code that sends a request (based on axis2 java) to a web service when the user clicks on a button. Thank you by advance sihem --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Re: Sleep() or wait() inside valueChanged Listener
Can we call Sleep( ) or wait( ) method for some busy waiting inside valueChangedListener without any threads? Nope. But you can use com.google.gwt.user.client.Timer --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Sleep() or wait() inside valueChanged Listener
Hi, Can we call Sleep( ) or wait( ) method for some busy waiting inside valueChangedListener without any threads? Please let me know if anybody has idea on this. Thanks _Anurag --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
HorizontalSplitPanel and splitbar element
Hi ! I have a problem with HorizontalSplitPanel! I need to catch the moving of SplitBar elementit's possible? I want to stop resizing the SplitBAr when the left widget width is 670px Please help me! Matteo. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Re: Single application .. multiple RPC services
Muhannad, I agree with Litty and Gregor. Probably the best thing to bring clarity to you at this point would be for you to develop the canonical GWT single-page rich client application and use a single GWT RPC Service for all data needs. Get comfortable with that model (you can do a lot with it!) before you try to hybridize with standard page-load- page web application style. In particular, drop the idea of Service- per-URL. Yagni. Walden On Nov 6, 2:35 am, Muhannad [EMAIL PROTECTED] wrote: Hi Walden, I'm not sure that I got your idea, but I always had a concern about that so I'll share it with you: 1. Does the GWT application have just one html page (module-name.html) that all the content should be rendered there? What I mean is that Litty wrote if the URL ends with /about then the AboutService will be called. Well but what if that AboutService does not extends or consists of any UI element? What is gonna to be displayed on the browser? 2. What I've received from your idea above is, each service should have its own (index.html)??!! If that was the case, each time I click on a menu item then a whole new page is going to be rendered and the browser will send an HTTP request and page will be rebuilt and displayed, which is not the case here:http://extjs.com/Please try to click any menu item and notice that only a portion of the page is rendered (the section under the menu) and not the whole page. Actually, this is exactly what I need to do but I think I was not clear enough. 3. Suppose that I want to pass parameters in the URL in some customized format; not using the regular wayhttp://domain/service?param1=value1¶m2=value2. For example, something like that: http://domain/service/param1/value1/param2/value2. Where should I write my own code that should take care of this customized URL encoding?? I mean, is there any place in GWT application where I could capture the URL and manipulate it before redirect it to some place depending on some parameters passed?? I guess there is something in .NET called HTTP Handler or Generic Handler to deal with that. I think this is an issue that the Web Server should deal with it not the GWT application???!!! Thank you very much. On Nov 5, 5:56 pm, walden [EMAIL PROTECTED] wrote: Muhannad, There's a problem with your assumptions. When a user clicks on your about menu link, she's not going to get a Panel, she's going to get a whole new page fromhttp://domain/about/index.html. That page can be a GWT host file if you like, but this is regular HTML pages, not a rich GWT client showing and hiding content based on menu navigation. I think you'd better get your head around that first, and then tackle the RPC URL binding question next, if it's even an issue at all. Walden On Nov 5, 5:12 am,Muhannad[EMAIL PROTECTED] wrote: Hi, I want to build a website with (Home, about, products, ...) menu. I need to build multiple forms (panels), each panel corresponds to one menu item, e.g. aboutPanel for about menu item, productsPanel for products... Moreover, I would like to implement that panel in terms of RPC services; I need to correspond each panel to a single RPC service that communicates with the server to get its data, build the whole form, and return the result as a panel to be displayed somewhere in the home page (for example). Of course, GWT allows us to define multiple services and add multiple servlet path=/service ... to the module XML file. My problem is how to know which service should I instantiate depending on the URL mapping, i.e. suppose that the menu is defined as follow: div id=menu a href=index.htmlHome/a a href=/aboutAbout us/a a href=/productsProducts/a ... /div So when someone clicks the About us link, the URL would be http:// domain/about. So I should instantiate the about service and create an aboutPanel to display it. The same thing when s/he clicks the Products link, then the URL is http://domain/products; and, in this case, I should build the product panel... So, is there somewhere in GWT application that I could parse the URL and depending on the mapping portion of it /about or /products could I decide which service to instantiate? Or is there another better way to do that? Thank you very much in advance.- Hide quoted text - - Show quoted text - --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Re: clicking outside the TreeItem firing onTreeItemSelected event
Okk.. Actually in my tree, I have a popup menu for each item on the
onTreeItemSelected event. The menu comes just below the selected item. Now
if a user is clicking some where outside the tree item, he will see a popup
menu appearing below the item gettng selected. This he wont feel as a normal
behavior.
Hope you understood my point.
- Litty
On Thu, Nov 6, 2008 at 9:23 PM, walden [EMAIL PROTECTED] wrote:
It all depends on your expectations ;-).
Actually, I do see the logic of selecting the node by clicking a spot
in the tree whose vertical location is unambiguously associated with
that node. My real question to you now is this: what is your
particular use case? What is it you cannot do because of this
feature?
Also, I suggest you look at the code in the Tree widget where ONCLICK
is handled (onBrowserEvent). You will see that the Tree
implementation traps click events at the top level and goes to quite a
bit of trouble to resolve them to a tree item. If you need to change
this, it may not be easy.
Walden
On Nov 5, 1:26 pm, Litty Preeth [EMAIL PROTECTED] wrote:
Walden,
But then a user will expect to select a tree node by clicking on the node
only rite? I dont feel that the node getting selected when you click else
where is an expected behavior.
- Litty
On Wed, Nov 5, 2008 at 10:51 PM, walden [EMAIL PROTECTED]
wrote:
Litty,
Yeah, I see it now. It looks as if this is by design. If you need an
area to the right of the Tree (outside the Tree but inside the
ScrollPanel) where you can click without selecting a TreeItem (why?),
then you can probably achieve that by setting the Tree's width so it
does not fill the width of the ScrollPanel. What effect are you
trying to achieve?
Walden
On Nov 5, 8:21 am, Litty Preeth [EMAIL PROTECTED] wrote:
Hi Walden,
I tried using gwt-1.5.2 and gwt-1.5.
If gwt-1.5.2 is used on IE6 it happens only for the child node. Root
level
nodes are working fine. But on IE7 and Firefox it is reproducible for
all
the nodes.
If gwt-1.5 is used on IE6 everything works fine. But on Firefox it is
reproducible for all the nodes.
You can use this code below to reproduce the issue.
TreeTest.java
package com.test.client;
import com.google.gwt.core.client.EntryPoint;
import com.google.gwt.user.client.Window;
import com.google.gwt.user.client.ui.RootPanel;
import com.google.gwt.user.client.ui.Tree;
import com.google.gwt.user.client.ui.TreeItem;
import com.google.gwt.user.client.ui.TreeListener;
/**
* Entry point classes define codeonModuleLoad()/code.
*/
public class TreeTest implements EntryPoint {
Tree myTree;
/**
* This is the entry point method.
*/
public void onModuleLoad() {
myTree = new Tree();
for (int i = 0; i 10; i++) {
TreeItem prItm = new TreeItem(Parent_ + i);
TreeItem chItm = new TreeItem(Child_ + i);
prItm.addItem(chItm);
myTree.addItem(prItm);
}
myTree.addTreeListener(treeListener);
RootPanel.get().add(myTree);
}
TreeListener treeListener = new TreeListener() {
public void onTreeItemSelected(TreeItem item) {
Window.alert(item.getText() + selected);
}
public void onTreeItemStateChanged(TreeItem item) {
// TODO Auto-generated method stub
}
};
}
TreeTest.css
.gwt-Tree {
border: 1px solid blue;
margin-left: 30px;
}
.gwt-Tree .gwt-TreeItem {
border: 1px solid red;
}
- Litty
On Wed, Nov 5, 2008 at 2:27 AM, walden [EMAIL PROTECTED]
wrote:
What version of GWT are you using? I'm trying the same thing in
the
GWT showcase and not getting the result you are.
On Nov 4, 10:51 am, Litty Preeth [EMAIL PROTECTED] wrote:
Hi Walden,
I put a border to the TreeItem and also a border to the tree
itself.
So
if I
click outside the border of the TreeItem, but inside the border
of
the
tree;
the item in the vertical level where I click gets selected.
- Litty
On Tue, Nov 4, 2008 at 9:10 PM, walden
[EMAIL PROTECTED]
wrote:
Litty,
How can you be sure you are actually clicking outside the
TreeItem?
Walden
On Nov 4, 12:27 am, Litty Preeth [EMAIL PROTECTED]
wrote:
Hi All,
I have a Tree on my page which I have added into a
ScrollPanel.
My
problem is that if I click even outside the TreeItem (but
within
the
scrollpanel) the item is getting selected (onTreeItemSelected
of
the
TreeListener gets fired). Please help me on this issue.
Thanks in advance,
Litty- Hide quoted text -
- Show quoted
Re: layout problem, panel size ignores setCellHeight(50%) ?
Thanks Ian. I'll work on it a bit first and then try to restate it. On Nov 5, 7:12 pm, Ian Bambury [EMAIL PROTECTED] wrote: Hi John, Could you restate your problem as it is now. Ian http://examples.roughian.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Re: state of hibernate + GWT 1.5
On Thu, Nov 6, 2008 at 7:49 AM, Arthur Kalmenson [EMAIL PROTECTED] wrote: Hello Dave, We use a common domain object between the client and server side. The domain objects are JPA annotated beans, and they travel between the client and server. The only think you have to watch out for is PersistentSets and other Hibernate specific collections. How are you dealing with PersistentSets et al? I see some reference to a hibernate gwt module and source includes. -Dave --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Re: History.newItem not firing onHistoryChanged under IE :-/
*smacks forhead* doh! Cheers :) On Nov 3, 10:25 am, Thomas Broyer [EMAIL PROTECTED] wrote: On 2 nov, 15:49, darkflame [EMAIL PROTECTED] wrote: I searched this group, and could only seem to find the opposite problem...people wanting newItem not to fire onHistoryChange, but it does. In my case its firing on all browsers, but for some reason it isn't working on IE (at least, IE6). Anyone got any ideas what could cause this? Your history iframe is named gwt_historyFrame instead of __gwt_historyFrame (missing the two leading underscores) --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Re: History.newItem not firing onHistoryChanged under IE :-/
nope, darnit, still dosnt work. On Nov 3, 10:25 am, Thomas Broyer [EMAIL PROTECTED] wrote: On 2 nov, 15:49, darkflame [EMAIL PROTECTED] wrote: I searched this group, and could only seem to find the opposite problem...people wanting newItem not to fire onHistoryChange, but it does. In my case its firing on all browsers, but for some reason it isn't working on IE (at least, IE6). Anyone got any ideas what could cause this? Your history iframe is named gwt_historyFrame instead of __gwt_historyFrame (missing the two leading underscores) --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Calling GWT-RPC-Services from something other than GWT
Hi there, Since i managed it to convince my company to use GWT in our new project, there were some questions open, which i couldn't reply and hope some of you can. We are a company which is experienced in Web Development with Java (JSP / JSF ) and some offline programs with .NET. Since there is a huge amount of code and sites we already have, we will not going to GWT on 100%(for now ;) ). Since GWT talks to the server via Remote Procedure Call and their is a huge interest in our company to switch to a Service Orientated Architecture, this was the argument that convinced them. But are there possibilities to access them via other Java Apps or .NET- Apps on Object-level? I googled a lot but couldn't find anything about this but to implement them as XML-services, which id as far as i think, contradictory to the idea of gwt to reduce the traffic sent over the net. A way to call them via Java should be easy since the know the Java- classes (java.lang String; java.util.Vector etc.) but what about .NET? thanks in advance for answers that will bring me further on this issue --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
How to get browser-configured link color?
I want to set the color of a GWT widget to the color the user has configured for un-visited links in the browser. I don't want to just hard-code blue because I want the GWT app to honor the user's color settings. I cannot figure out how to find the browser's link color... I tried using getElement().getStyle().getProperty(a:link) but that just returns null. Any ideas? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Re: HorizontalSplitPanel and splitbar element
Hi Byteo, HSP has a protected method: Element getSplitElement(). So you can extend HSP and make use of this. Element has getAbsoluteLeft() method so you can tell where the splitter is. HSP does not broadcast any events when the splitter is moved however, so I think you may have to override onBrowserEvent(Event event) to catch mouse down, mouse move, mouse up events etc being careful not to sink them and pass them on to super. I haven't tried this, but thinking about it you may be able to fool the underlying HSP that the mouse is stationary by sinking any mouse move events outside your chosen parameters. Maybe then the cursor will continue to move but the splitter itself won't. You can then pass on the mouse up event when it arrives and the HSP might resize where you wanted it to. regards gregor On Nov 6, 4:02 pm, Byteo [EMAIL PROTECTED] wrote: Hi ! I have a problem with HorizontalSplitPanel! I need to catch the moving of SplitBar elementit's possible? I want to stop resizing the SplitBAr when the left widget width is 670px Please help me! Matteo. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Re: Sleep() or wait() inside valueChanged Listener
Timer timer = new Timer(){
public void run(){
//execute your task here
}
};
timer.schedule(1);//sleep 1 second
or use DeferredCommand and IncrementCommand. check it on gwt document.
Sammi
http://code.google.com/p/openorg
On Thu, Nov 6, 2008 at 6:29 AM, Anurag Tripathi [EMAIL PROTECTED] wrote:
Hi,
Can we call Sleep( ) or wait( ) method for some busy waiting inside
valueChangedListener without any threads?
Please let me know if anybody has idea on this.
Thanks
_Anurag
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post to this group, send email to Google-Web-Toolkit@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/Google-Web-Toolkit?hl=en
-~--~~~~--~~--~--~---
Problem displaying a ComboBox displayField inside a EditorGridPanel
Hello,
I have a problem displaying a ComboBox displayField inside a
EditorGridPanel.
When I choose a ComboBox option it appears the setValueField
associated key.
Anyone knows about how I can fix this problem?
I put an ID and a name in the combobox because when I selected this
combobox there is a filter to change the another combobox in the same
grid.
Thank you.
my code.
Object[][] names = Object[][] types = new Object[][] {
new Object[] { ID1, name1 },
new Object[] { ID2, name2 },
new Object[] { ID3, name3 } };
SimpleStore nameStore = new SimpleStore(new String[] { ID,
name }, names );
nameStore.load();
ComboBox cb = new ComboBox();
cb.setStore(nameStore);
cb.setDisplayField(name);
cb.setValueField(ID);
ColumnConfig nameCol = new ColumnConfig(Column Name,
columnname, 100);
nameCol.setEditor(new GridEditor(cb));
BaseColumnConfig[] columnConfigs = new
BaseColumnConfig[] {nameCol, ...}
ColumnModel columnModel = new
ColumnModel(columnConfigs);
...
final EditorGridPanel grid = new EditorGridPanel();
grid.setStore(store);
grid.setSelectionModel(cbSelectionModel);
grid.setColumnModel(columnModel);
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post to this group, send email to Google-Web-Toolkit@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/Google-Web-Toolkit?hl=en
-~--~~~~--~~--~--~---
Re: Calling GWT-RPC-Services from something other than GWT
You might want to look at RESTlet. I haven't used it myself, but it seems like a useful alternative to RPC that gives you multi-client functionality for free. Creating a non-GWT client that speaks GWT RPC is probably a huge time sink with little return on investment. If you search this forum's history you'll find that others have asked similar questions before. Ian --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Re: GWT -ext
On Wed, Nov 5, 2008 at 10:21 PM, ajay jetti [EMAIL PROTECTED] wrote: I hear that because gwt-ext is created from wrapping native gwt widgets they are a bit slow to work out, is it true? does it really effect the page loading or other things I suggest trying them out and determining for yourself. Anecdotally, they appear about the same to me, but I have not done true benchmarking. -Dave --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Creating a main site *and* an admin site
I want to create a web site together with a separate administration site. Clearly the two sites will share a lot of code. I create them in the same dir with the following two commands $ applicationCreator com.mycompany.mysite.mainsite.client.MainSite $ applicationCreator com.mycompany.mysite.adminsite.client.AdminSite Would you also do it this way? And would you create one or two eclipse projects? (If you would create two projects there is a problem with the .project file - as both projects would need such a file) Thanks in advance! --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Close button in DialogBox title bar - Why so hard?
It seems that GWT 1.5 has made it very difficult to add custom widgets to the title area of a DialogBox. In prior releases the DialogBox was built from other base widgets (DockPanel, etc), but now it is built on the DecoratorPanel and the title bar is created by inserting elements into the DOM. I have found a dozen questions here and elsewhere on how to simply add a close button and there seems to be no clean answer. Does anyone have a good technique for this simple and common problem? E.g. let me add Widgets to the title area, use normal event handling on them, and not resort to JSNI... Thanks for any ideas. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
A variant of HorizontalSplitPanel?
Hello! I'd like to implement in my application a panel like a one in Google Doc Reader: when you click on splitter the left side become hidden, and when you click again -- appears back. I tried to use HorizontalSplitPanel but I found that it is declared as 'final' so I can not even override onBrowserEvent() method. Is there standard way to implement this approach or I should modify HorizontalSplitPannel class and add event processor to them? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Integrating GWT with Rational Application Developer 7.0
Just now completed GWT tutorial on eclipse. Now I need some instructions on how to integrate GWT with my J2EE project in Rational Application Developer. Can you suggest any tutorial or instructions? Thanks Shyam --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Re: Response from Server is very slow
Filipe Sousa schrieb: It is most likely the serialization and de-serialization that is taking the most time. There really isn't anything you can do about this because it's the way XML-RPC works. It converts all your objects into a really big string (xml) sends it over to the clients which then re-instantiates the objects on the javascript side. You need to limit the complexity and size of your objects when using XML-RPC. At least, I think I am correct. :) I didn't know that GWT-RPC was using XML There isn't but you have the same topics when it comes to the transfer of data-objects from client to server and vice versa. Regards, Lothar --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
SOAP Generator in GWT
Hi All, Around a year ago we had a requirement to link GWT directly to an ASP.NET web service using SOAP. Its been working well in our production application for some time now, however probably in need a some tweaks and added elegance. There is a code generator that works by analysing the WSDL from a URL and building objects based on that. I'm wondering if there is any need in the community for this and if there is any use in submitting it in order to be expanded and improved. If anyone is interested please just give me a shout. Regards, Danny --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Re: HorizontalSplitPanel and splitbar element
Hi Byteo, I'm really sorry but I'm talking nonsense. HSP is still declared final so you can't extend it. For some reason I thought it had been changed. I think the only way you can do what you want to do is to copy the code into your own class and hack it. However that might be a bad idea especially as I think a new event system is coming in with 1.6 so it is possible HSP and its super class SplitPanel will change somewhat leaving you with a problem for the future. Sorry to mislead you. regards gregor On Nov 6, 5:57 pm, gregor [EMAIL PROTECTED] wrote: Hi Byteo, HSP has a protected method: Element getSplitElement(). So you can extend HSP and make use of this. Element has getAbsoluteLeft() method so you can tell where the splitter is. HSP does not broadcast any events when the splitter is moved however, so I think you may have to override onBrowserEvent(Event event) to catch mouse down, mouse move, mouse up events etc being careful not to sink them and pass them on to super. I haven't tried this, but thinking about it you may be able to fool the underlying HSP that the mouse is stationary by sinking any mouse move events outside your chosen parameters. Maybe then the cursor will continue to move but the splitter itself won't. You can then pass on the mouse up event when it arrives and the HSP might resize where you wanted it to. regards gregor On Nov 6, 4:02 pm, Byteo [EMAIL PROTECTED] wrote: Hi ! I have a problem with HorizontalSplitPanel! I need to catch the moving of SplitBar elementit's possible? I want to stop resizing the SplitBAr when the left widget width is 670px Please help me! Matteo. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Re: Close button in DialogBox title bar - Why so hard?
Hi, Look the WindowPanel Popup in the gwt-mosaic demo - http://code.google.com/p/gwt-mosaic/ Regards, On Thu, Nov 6, 2008 at 7:28 PM, sibiquin [EMAIL PROTECTED] wrote: It seems that GWT 1.5 has made it very difficult to add custom widgets to the title area of a DialogBox. In prior releases the DialogBox was built from other base widgets (DockPanel, etc), but now it is built on the DecoratorPanel and the title bar is created by inserting elements into the DOM. I have found a dozen questions here and elsewhere on how to simply add a close button and there seems to be no clean answer. Does anyone have a good technique for this simple and common problem? E.g. let me add Widgets to the title area, use normal event handling on them, and not resort to JSNI... Thanks for any ideas. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
GWT 1.5.2
I'm using Mac OS 10.5.5 Eclipse 3.3.2 and I migrated my project from
GWT 1.4.61 to 1.5.2 and getting following error. Please help me.
INFO] [gwt:compile {execution: default}]
Exception in thread main java.lang.NoSuchMethodError:
org.eclipse.jdt.internal.compiler.Compiler.init(Lorg/eclipse/jdt/
internal/compiler/env/INameEnvironment;Lorg/eclipse/jdt/internal/
compiler/IErrorHandlingPolicy;Lorg/eclipse/jdt/internal/compiler/impl/
CompilerOptions;Lorg/eclipse/jdt/internal/compiler/
ICompilerRequestor;Lorg/eclipse/jdt/internal/compiler/
IProblemFactory;)V
at com.google.gwt.dev.javac.JdtCompiler
$CompilerImpl.init(JdtCompiler.java:93)
at com.google.gwt.dev.javac.JdtCompiler.init(JdtCompiler.java:231)
at com.google.gwt.dev.javac.JdtCompiler.compile(JdtCompiler.java:193)
at
com.google.gwt.dev.javac.CompilationState.compile(CompilationState.java:
115)
at com.google.gwt.dev.GWTCompiler.distill(GWTCompiler.java:327)
at com.google.gwt.dev.GWTCompiler.run(GWTCompiler.java:564)
at com.google.gwt.dev.GWTCompiler.run(GWTCompiler.java:554)
at com.google.gwt.dev.GWTCompiler.main(GWTCompiler.java:214)
Exception in thread main java.lang.NoSuchMethodError:
org.eclipse.jdt.internal.compiler.Compiler.init(Lorg/eclipse/jdt/
internal/compiler/env/INameEnvironment;Lorg/eclipse/jdt/internal/
compiler/IErrorHandlingPolicy;Lorg/eclipse/jdt/internal/compiler/impl/
CompilerOptions;Lorg/eclipse/jdt/internal/compiler/
ICompilerRequestor;Lorg/eclipse/jdt/internal/compiler/
IProblemFactory;)V
at com.google.gwt.dev.javac.JdtCompiler
$CompilerImpl.init(JdtCompiler.java:93)
at com.google.gwt.dev.javac.JdtCompiler.init(JdtCompiler.java:231)
at com.google.gwt.dev.javac.JdtCompiler.compile(JdtCompiler.java:193)
at
com.google.gwt.dev.javac.CompilationState.compile(CompilationState.java:
115)
at com.google.gwt.dev.GWTCompiler.distill(GWTCompiler.java:327)
at com.google.gwt.dev.GWTCompiler.run(GWTCompiler.java:564)
at com.google.gwt.dev.GWTCompiler.run(GWTCompiler.java:554)
at com.google.gwt.dev.GWTCompiler.main(GWTCompiler.java:214)
Exception in thread main java.lang.NoSuchMethodError:
org.eclipse.jdt.internal.compiler.Compiler.init(Lorg/eclipse/jdt/
internal/compiler/env/INameEnvironment;Lorg/eclipse/jdt/internal/
compiler/IErrorHandlingPolicy;Lorg/eclipse/jdt/internal/compiler/impl/
CompilerOptions;Lorg/eclipse/jdt/internal/compiler/
ICompilerRequestor;Lorg/eclipse/jdt/internal/compiler/
IProblemFactory;)V
at com.google.gwt.dev.javac.JdtCompiler
$CompilerImpl.init(JdtCompiler.java:93)
at com.google.gwt.dev.javac.JdtCompiler.init(JdtCompiler.java:231)
at com.google.gwt.dev.javac.JdtCompiler.compile(JdtCompiler.java:193)
at
com.google.gwt.dev.javac.CompilationState.compile(CompilationState.java:
115)
at com.google.gwt.dev.GWTCompiler.distill(GWTCompiler.java:327)
at com.google.gwt.dev.GWTCompiler.run(GWTCompiler.java:564)
at com.google.gwt.dev.GWTCompiler.run(GWTCompiler.java:554)
at com.google.gwt.dev.GWTCompiler.main(GWTCompiler.java:214)
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post to this group, send email to Google-Web-Toolkit@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/Google-Web-Toolkit?hl=en
-~--~~~~--~~--~--~---
Re: adobe air browser not support gmail.
The docreader work well. I just know google provide such document for public but i dont know where can i register and create my document for my jimmy6 Framework http://code.google.com/p/jimmy6/ On Nov 6, 6:29 pm, Thomas Broyer [EMAIL PROTECTED] wrote: On 6 nov, 10:49,jimmy6[EMAIL PROTECTED] wrote: I am planning to create web browser to display gwt project. The browser is created by using adobe air. I tested it by using this browserhttp://www.softpedia.com/get/Internet/Browsers/SmartFox.shtml . When i view the gmail. It contain the following text. For a better Gmail experience, use a fully supported browser. Learn more I know air is using webkit(http://help.adobe.com/en_US/AIR/1.1/ devappsflex/WS5b3ccc516d4fbf351e63e3d118666ade46-7e7b.html). As i know, google browser is using webkit and safari too but it work fine. I afraid that the air browser is not compatible with the lasted gwt code. Any idea for me? AFAICT, GWT produces AIR-compatible code since 1.5RC2 [1] [2]. Try it with the Google Code Document Reader for instance:http://code.google.com/docreader/ ...but GMail is just *not* built with GWT! [1]http://code.google.com/p/google-web-toolkit/issues/detail?id=2550 [2]http://code.google.com/p/gwt-in-the-air/ --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Re: GWT 1.5.2
I had this same problem last month when I moved to GWT 1.5.2 also.
It turned out to be a conflict between GWT's dev library and the Jasper
2 JSP engine which apparently uses the Eclipse JDT Java compiler. The
jasper-compiler-jdt.jar had conflicting versions of the
org.eclipse.jdt.internal.compiler.Compiler class. Check your GWT
project build path for that jar file and remove it.
Hope this helps...
Tom
Deep wrote:
I'm using Mac OS 10.5.5 Eclipse 3.3.2 and I migrated my project from
GWT 1.4.61 to 1.5.2 and getting following error. Please help me.
INFO] [gwt:compile {execution: default}]
Exception in thread main java.lang.NoSuchMethodError:
org.eclipse.jdt.internal.compiler.Compiler.init(Lorg/eclipse/jdt/
internal/compiler/env/INameEnvironment;Lorg/eclipse/jdt/internal/
compiler/IErrorHandlingPolicy;Lorg/eclipse/jdt/internal/compiler/impl/
CompilerOptions;Lorg/eclipse/jdt/internal/compiler/
ICompilerRequestor;Lorg/eclipse/jdt/internal/compiler/
IProblemFactory;)V
at com.google.gwt.dev.javac.JdtCompiler
$CompilerImpl.init(JdtCompiler.java:93)
at com.google.gwt.dev.javac.JdtCompiler.init(JdtCompiler.java:231)
at com.google.gwt.dev.javac.JdtCompiler.compile(JdtCompiler.java:193)
at
com.google.gwt.dev.javac.CompilationState.compile(CompilationState.java:
115)
at com.google.gwt.dev.GWTCompiler.distill(GWTCompiler.java:327)
at com.google.gwt.dev.GWTCompiler.run(GWTCompiler.java:564)
at com.google.gwt.dev.GWTCompiler.run(GWTCompiler.java:554)
at com.google.gwt.dev.GWTCompiler.main(GWTCompiler.java:214)
Exception in thread main java.lang.NoSuchMethodError:
org.eclipse.jdt.internal.compiler.Compiler.init(Lorg/eclipse/jdt/
internal/compiler/env/INameEnvironment;Lorg/eclipse/jdt/internal/
compiler/IErrorHandlingPolicy;Lorg/eclipse/jdt/internal/compiler/impl/
CompilerOptions;Lorg/eclipse/jdt/internal/compiler/
ICompilerRequestor;Lorg/eclipse/jdt/internal/compiler/
IProblemFactory;)V
at com.google.gwt.dev.javac.JdtCompiler
$CompilerImpl.init(JdtCompiler.java:93)
at com.google.gwt.dev.javac.JdtCompiler.init(JdtCompiler.java:231)
at com.google.gwt.dev.javac.JdtCompiler.compile(JdtCompiler.java:193)
at
com.google.gwt.dev.javac.CompilationState.compile(CompilationState.java:
115)
at com.google.gwt.dev.GWTCompiler.distill(GWTCompiler.java:327)
at com.google.gwt.dev.GWTCompiler.run(GWTCompiler.java:564)
at com.google.gwt.dev.GWTCompiler.run(GWTCompiler.java:554)
at com.google.gwt.dev.GWTCompiler.main(GWTCompiler.java:214)
Exception in thread main java.lang.NoSuchMethodError:
org.eclipse.jdt.internal.compiler.Compiler.init(Lorg/eclipse/jdt/
internal/compiler/env/INameEnvironment;Lorg/eclipse/jdt/internal/
compiler/IErrorHandlingPolicy;Lorg/eclipse/jdt/internal/compiler/impl/
CompilerOptions;Lorg/eclipse/jdt/internal/compiler/
ICompilerRequestor;Lorg/eclipse/jdt/internal/compiler/
IProblemFactory;)V
at com.google.gwt.dev.javac.JdtCompiler
$CompilerImpl.init(JdtCompiler.java:93)
at com.google.gwt.dev.javac.JdtCompiler.init(JdtCompiler.java:231)
at com.google.gwt.dev.javac.JdtCompiler.compile(JdtCompiler.java:193)
at
com.google.gwt.dev.javac.CompilationState.compile(CompilationState.java:
115)
at com.google.gwt.dev.GWTCompiler.distill(GWTCompiler.java:327)
at com.google.gwt.dev.GWTCompiler.run(GWTCompiler.java:564)
at com.google.gwt.dev.GWTCompiler.run(GWTCompiler.java:554)
at com.google.gwt.dev.GWTCompiler.main(GWTCompiler.java:214)
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post to this group, send email to Google-Web-Toolkit@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/Google-Web-Toolkit?hl=en
-~--~~~~--~~--~--~---
ImageBundle combines my images
I'm using the following code to set up an ImageBundle. I show the code
after that I use to add the image. It all compiles fine, but when I
access the images most of them come up as a combination of several of
the images that I've added to the ImageBundle. Has anyone else had
this problem? Is there anything I need to consider about the images
themselves?
===
public interface MyImageBundle extends ImageBundle {
@Resource(com/ljlowry/sharoncsteel/public/images/border_bottom.gif)
public AbstractImagePrototype border_bottom();
@Resource(com/ljlowry/sharoncsteel/public/images/border_right.gif)
public AbstractImagePrototype border_right();
@Resource(com/ljlowry/sharoncsteel/public/images/menu_contact.gif)
public AbstractImagePrototype menu_contact();
@Resource(com/ljlowry/sharoncsteel/public/images/border_top.gif)
public AbstractImagePrototype border_top();
@Resource(com/ljlowry/sharoncsteel/public/images/copyright.gif)
public AbstractImagePrototype copyright();
@Resource(com/ljlowry/sharoncsteel/public/images/corner_flowers.gif)
public AbstractImagePrototype corner_flowers();
}
===
//Testing the Image Bundle
MyImageBundle images_test = GWT.create(MyImageBundle.class);
AbstractImagePrototype testImagePrototype =
images_test.border_right();
AbstractImagePrototype test1 = images_test.border_top();
AbstractImagePrototype test2 = images_test.copyright();
AbstractImagePrototype test3 = images_test.corner_flowers();
//End testing
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post to this group, send email to Google-Web-Toolkit@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/Google-Web-Toolkit?hl=en
-~--~~~~--~~--~--~---
Serialization Error
Dear all, I encounter this problem: Caused by: com.google.gwt.user.client.rpc.SerializationException: Type 'lab.gwt. client.LatitudeLongitude' was not included in the set of types which can be seri alized by this SerializationPolicy or its Class object could not be loaded. For security purposes, this type will not be serialized. When passing an object with GWT RPC. This class is already implementing Serializable. But why does such problem still occur? Does anyone know how to fix this? Thank you in advance. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Re: ImageBundle combines my images
Hi
Are you using GWT 1.5?
Have you tried putting the images in the same level as the
MyImageBundle.java class?
so it would look like
@Resource(images/border_bottom.gif) (--or wherever your
MyImageBundle.java is)
public AbstractImagePrototype border_bottom();
i'm using 1.4 and it looks like this(just a snippet)
public interface Images extends ImageBundle {
/**
* @gwt.resource gogo.png
*/
AbstractImagePrototype gogo();
}
Other class that uses the Images class
public class Test{
Images images;//ImageBundle implementation.
Image gogoImage=null; //Normal GWT image object
public void createImages(){
images = (Images) GWT.create(Images.class);
gogoImage=images.gogo().createImage();
)
}
This might not help if you're using 1.5. I haven't tried using
ImageBundle in 1.5
HTH a little, :)
On Nov 7, 8:19 am, Lucas86 [EMAIL PROTECTED] wrote:
I'm using the following code to set up an ImageBundle. I show the code
after that I use to add the image. It all compiles fine, but when I
access the images most of them come up as a combination of several of
the images that I've added to the ImageBundle. Has anyone else had
this problem? Is there anything I need to consider about the images
themselves?
===
public interface MyImageBundle extends ImageBundle {
@Resource(com/ljlowry/sharoncsteel/public/images/border_bottom.gif)
public AbstractImagePrototype border_bottom();
@Resource(com/ljlowry/sharoncsteel/public/images/border_right.gif)
public AbstractImagePrototype border_right();
@Resource(com/ljlowry/sharoncsteel/public/images/menu_contact.gif)
public AbstractImagePrototype menu_contact();
@Resource(com/ljlowry/sharoncsteel/public/images/border_top.gif)
public AbstractImagePrototype border_top();
@Resource(com/ljlowry/sharoncsteel/public/images/copyright.gif)
public AbstractImagePrototype copyright();
@Resource(com/ljlowry/sharoncsteel/public/images/corner_flowers.gif)
public AbstractImagePrototype corner_flowers();}
===
//Testing the Image Bundle
MyImageBundle images_test = GWT.create(MyImageBundle.class);
AbstractImagePrototype testImagePrototype =
images_test.border_right();
AbstractImagePrototype test1 = images_test.border_top();
AbstractImagePrototype test2 = images_test.copyright();
AbstractImagePrototype test3 = images_test.corner_flowers();
//End testing
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post to this group, send email to Google-Web-Toolkit@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/Google-Web-Toolkit?hl=en
-~--~~~~--~~--~--~---
HTMLPanel and upgrade to GWT 1.5
In a project we started with GWT 1.4 we made large use of HTMLPanels whose contents are loaded from a remote service and transferred to the client upon panel construction. The widgets are being added in the client code and the HTML contents are full of cell tags similar to this td colspan=2 id='checkRegistered'/ All is going very well ... as soon as we stay with GWT 1.4. We are struggling to switch to 1.5, but we are encountering a strange problem: all TextBox widgets are being placed into the first cell (!?) Does anyone have some suggestion? Thank you in advance Vincenzo Caselli --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Re: clicking outside the TreeItem firing onTreeItemSelected event
Actually I wanted a popup menu when user clicks on the TreeItem. I couldnt
find any ClickListener for TreeItem so I used onSelect.
- Litty
On Fri, Nov 7, 2008 at 4:26 AM, walden [EMAIL PROTECTED] wrote:
I'm not sure he will see popping up a menu on item selection as normal
behavior to begin with. Maybe you should implement context menu
listeners on your tree item widgets instead.
On Nov 6, 11:15 am, Litty Preeth [EMAIL PROTECTED] wrote:
Okk.. Actually in my tree, I have a popup menu for each item on the
onTreeItemSelected event. The menu comes just below the selected item.
Now
if a user is clicking some where outside the tree item, he will see a
popup
menu appearing below the item gettng selected. This he wont feel as a
normal
behavior.
Hope you understood my point.
- Litty
On Thu, Nov 6, 2008 at 9:23 PM, walden [EMAIL PROTECTED]
wrote:
It all depends on your expectations ;-).
Actually, I do see the logic of selecting the node by clicking a spot
in the tree whose vertical location is unambiguously associated with
that node. My real question to you now is this: what is your
particular use case? What is it you cannot do because of this
feature?
Also, I suggest you look at the code in the Tree widget where ONCLICK
is handled (onBrowserEvent). You will see that the Tree
implementation traps click events at the top level and goes to quite a
bit of trouble to resolve them to a tree item. If you need to change
this, it may not be easy.
Walden
On Nov 5, 1:26 pm, Litty Preeth [EMAIL PROTECTED] wrote:
Walden,
But then a user will expect to select a tree node by clicking on the
node
only rite? I dont feel that the node getting selected when you click
else
where is an expected behavior.
- Litty
On Wed, Nov 5, 2008 at 10:51 PM, walden [EMAIL PROTECTED]
wrote:
Litty,
Yeah, I see it now. It looks as if this is by design. If you need
an
area to the right of the Tree (outside the Tree but inside the
ScrollPanel) where you can click without selecting a TreeItem
(why?),
then you can probably achieve that by setting the Tree's width so
it
does not fill the width of the ScrollPanel. What effect are you
trying to achieve?
Walden
On Nov 5, 8:21 am, Litty Preeth [EMAIL PROTECTED] wrote:
Hi Walden,
I tried using gwt-1.5.2 and gwt-1.5.
If gwt-1.5.2 is used on IE6 it happens only for the child node.
Root
level
nodes are working fine. But on IE7 and Firefox it is reproducible
for
all
the nodes.
If gwt-1.5 is used on IE6 everything works fine. But on Firefox
it is
reproducible for all the nodes.
You can use this code below to reproduce the issue.
TreeTest.java
package com.test.client;
import com.google.gwt.core.client.EntryPoint;
import com.google.gwt.user.client.Window;
import com.google.gwt.user.client.ui.RootPanel;
import com.google.gwt.user.client.ui.Tree;
import com.google.gwt.user.client.ui.TreeItem;
import com.google.gwt.user.client.ui.TreeListener;
/**
* Entry point classes define codeonModuleLoad()/code.
*/
public class TreeTest implements EntryPoint {
Tree myTree;
/**
* This is the entry point method.
*/
public void onModuleLoad() {
myTree = new Tree();
for (int i = 0; i 10; i++) {
TreeItem prItm = new TreeItem(Parent_ + i);
TreeItem chItm = new TreeItem(Child_ + i);
prItm.addItem(chItm);
myTree.addItem(prItm);
}
myTree.addTreeListener(treeListener);
RootPanel.get().add(myTree);
}
TreeListener treeListener = new TreeListener() {
public void onTreeItemSelected(TreeItem item) {
Window.alert(item.getText() + selected);
}
public void onTreeItemStateChanged(TreeItem item) {
// TODO Auto-generated method stub
}
};
}
TreeTest.css
.gwt-Tree {
border: 1px solid blue;
margin-left: 30px;
}
.gwt-Tree .gwt-TreeItem {
border: 1px solid red;
}
- Litty
On Wed, Nov 5, 2008 at 2:27 AM, walden
[EMAIL PROTECTED]
wrote:
What version of GWT are you using? I'm trying the same thing
in
the
GWT showcase and not getting the result you are.
On Nov 4, 10:51 am, Litty Preeth [EMAIL PROTECTED]
wrote:
Hi Walden,
I put a border to the TreeItem and also a border to the tree
itself.
So
if I
click outside the border of the TreeItem, but inside the
border
of
the
tree;
the item in the vertical level where I click gets
DOM.eventPreventDefault(event) is not work IE6 and IE7
Sorry I can't write english well...
see below source code...
F1 key input = showHelp popupPanel..
public class TrackerEntryPoint implements EntryPoint {
private EventPreview keyBoardShorcuts;
private HorizontalPanel hPanel;
public void onModuleLoad() {
hPanel = new HorizontalPanel();
keyBoardShortCut();
RootPanel.get().add(hPanel);
}
public void keyBoardShortCut() {
hPanel.sinkEvents(Event.ONKEYDOWN);
keyBoardShorcuts = new EventPreview() {
public boolean onEventPreview(Event event) {
boolean propagate = true;
int type = DOM.eventGetType(event);
if (type == Event.ONKEYDOWN ) {
int keyCode =
DOM.eventGetKeyCode(event);
switch(keyCode) {
case TrackerKeyCode.CODE_F1:
showHelp();
propagate = false;
break;
}
}
if ( !propagate) {
DOM.eventPreventDefault(event);
}
return propagate;
}
};
DOM.addEventPreview(keyBoardShorcuts);
}
private void showHelp() {
WindowPanel help = new WindowPanel(keyBoardShortCut);
VerticalPanel vPanel = new VerticalPanel();
HTML j = new HTML(J : );
vPanel.add( j);
help.setWidget(vPanel);
help.center();
help.show();
}
}
///
chrome, FF : F1 input : showHelp() method work.. brower F1 event not
work..
but IE 6, IE7 : showHelp() method work.. then brower F1 event
work.
so I change source code
case TrackerKeyCode.CODE_F1:
showHelp();
DOM.eventCancelBubble(event,
true); -insert..
propagate = false;
break;
}
but brower F1 evnent work..
I don't know how to...
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post to this group, send email to Google-Web-Toolkit@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/Google-Web-Toolkit?hl=en
-~--~~~~--~~--~--~---
Re: newbie question:Scroll textArea
It automatically appears when your input is too wide. Isn't that enough? On 6 Nov., 21:52, Clerton Filho [EMAIL PROTECTED] wrote: Hi everyone, I'm newbie on this stuff, and I want to find a way to solve this thing: I have a textArea that shows messages to users and I want to put the scroll to the bottom. How can I do this? Thanks! -- Clerton Ribeiro de Araujo Filho Graduando em Ciência da Computação Integrante do PET - Programa de Educação Tutorial Integrante do LIA - Laboratório de Inteligência Artificial Universidade Federal de Campina Grande - UFCG --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
Re: DOM.eventPreventDefault(event) is not work IE6 and IE7
I Test below source code
case TrackerKeyCode.CODE_F1:
showHelp();
DOM.eventPreventDefault(event);
DOM.eventCancelBubble(event, true);
propagate = false;
break;
}
/ brower F1 evnet
work..
case TrackerKeyCode.CODE_F1:
showHelp();
eventPreventDefault(evt);
propagate = false;
break;
}
public native void eventPreventDefault(Event evt) /*-{
if (evt.preventDefault)
evt.preventDefault();
else
evt.returnValue = false;
}-*/;
/ brower F1 evnet
work..
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post to this group, send email to Google-Web-Toolkit@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/Google-Web-Toolkit?hl=en
-~--~~~~--~~--~--~---
Disable text copy paste GWT
Hi,
I want to disable copy/paste from the HTML panel. I have used
onBrowserEvent method, by using this i am able to disable all mouse
events like selecting and right click on HTML panel. But when i do
'Ctrl A' it selects all the content of the panel. To resolve this
issue i have used one javascript native function to disable text
selection.
function disableSelection(element){
if (typeof element.onselectstart!=undefined){
element.unselectable = on;
element.onselectstart=function(){return false}
}else if (typeof element.style.MozUserSelect!=undefined)
element.style.MozUserSelect = none;
else
element.style.cursor = default;
element.onmousedown=function(){return false;}
}
This works fine in mozilla but not working in IE. Infect when i do
Ctrl A in mozilla it does not selects text but when i do Ctrl C it
copy all the content of the page.
But in IE Ctrl A itself is not disabling.
Thanks in advance please help me.
Thanks,
Pawan
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post to this group, send email to Google-Web-Toolkit@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/Google-Web-Toolkit?hl=en
-~--~~~~--~~--~--~---
Re: GWT Conference?
Hello everyone, The GWT Voices That Matter 2007 conference and Google I/O links posted above are excellent resources for GWT and other Google developer product related material. You can find more of the GWT VTM 2007 conference and other presentations posted on YouTube by doing a quick search for gwt. Hope that helps, -Sumit Chandel On Tue, Nov 4, 2008 at 2:56 AM, francescoNemesi [EMAIL PROTECTED] wrote: Thanks for this link, very useful! On Nov 3, 5:36 pm, Isaac Truett [EMAIL PROTECTED] wrote: There were several excellent sessions on GWT at Google I/O back in May. Video and slides from sessions are available on the Google I/O web site below. http://sites.google.com/site/io/ On Mon, Nov 3, 2008 at 10:28 AM, gcivil [EMAIL PROTECTED] wrote: I am looking to attend GWT conference. Any suggestions? Thank You Gennadiy Civil http://www.clarity-design.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Google-Web-Toolkit?hl=en -~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit] EmilyCrutcher commented on branch /branches/1_6_clean_events.
[google-web-toolkit] EmilyCrutcher commented on branch
/branches/1_6_clean_events.
Details are at
http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083branch=%2Fbranches%2F1_6_clean_events
Score: Neutral
General Comment:
Response to RawJsMapImpl comments.
Line-by-line comments:
File:
/branches/1_6_clean_events/user/src/com/google/gwt/core/client/impl/RawJsMapImpl.java
(r3958)
===
Line 28: *
---
Yep, I like your way of phrasing it.
Line 32:
---
It is RawJsMapImpl rather then JsMapImpl because I did not want users to
find it searching for quot;JsMapquot;. If the name is jarring though, we
can rename it.
Yep, we did decide to favor single letters. This is a combined code
review/cleanup pass, as the code has not gone through one. Therefore
expect to find long generic names in places which were not touched since
that decision. To the best of my knowledge all such places should now use
the short form, as we have no tremendously complicated generic structures.
In terms of why we are supporting people running in raw Java, the prime use
case is for users who are testing widget logical state using junit. As the
current listeners can be added in pure Java, I believe we would also break
the testing rigs of some folks if we did not support this use case. Another
somewhat less important use case is so people can share ui logic between
systems such as GWT and Android.
Line 34:
---
But that name is already taken :-). More seriously, yes we should be able
to figure out a better name.
Line 37: }
---
Actually, it is not a real cast because the compiler translates it away.
However, I have no problems with the .cast() method, and, being a fan of
consistent coding practices, saying we always use .cast() when casting
JavaScriptObject instances has a nice appeal.
Line 73: if (GWT.isScript()) {
---
It is very unfortunate that on IE adding a single quot;+quot; to a key
makes a difference in performance. We use the unsafe version in our dom
firing mapping, were performance is critical.
Line 111: }
---
I believe it might be marginally faster to do it this way. However, without
benchmarks to back me, I'm happy to switch it back for consistency's sake.
Respond to these comments at
http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083branch=%2Fbranches%2F1_6_clean_events
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit] EmilyCrutcher commented on branch /branches/1_6_clean_events.
[google-web-toolkit] EmilyCrutcher commented on branch
/branches/1_6_clean_events.
Details are at
http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083branch=%2Fbranches%2F1_6_clean_events
Score: Neutral
General Comment:
The rest of the specific dom comments.
Line-by-line comments:
File:
/branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/HasAllMouseHandlers.java
(r3942)
===
Line 24: * wish to handle all mouse events in GWT, new mouse event
handlers will be
---
Hmm... You are probably correct so I will remove it.
File:
/branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/HasClickHandlers.java
(r3948)
===
Line 22: * [EMAIL PROTECTED] ClickEvent} events.
---
Sounds good.
File:
/branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/HasKeyCodes.java
(r3942)
===
Line 27: public interface HasKeyCodes {
---
We can certainly remove the publics, the reason for the suppress warning
however is because it will complain about an interface with no methods in
it, saying you should use an enum type instead.
I'll investigate whether we can turn off the checkstyle warning though, as
we do have control over that one.
File:
/branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/HasScrollHandlers.java
(r3948)
===
Line 22: * [EMAIL PROTECTED] ScrollEvent} events.
---
You can't say I wasn't consistent :-).
File:
/branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyCodeEvent.java
(r3942)
===
Line 62: return (48 = keycode keycode = 57) || (65 = keycode
keycode = 90);
---
Very good point, will be removed.
File:
/branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyEvent.java
(r3942)
===
Line 68: return getKeyModifiers(this.getNativeEvent());
---
As long as we leave in the element based one for people currently using
bit-masks, I think we can.
File:
/branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/MouseEvent.java
(r3942)
===
Line 35: /**
---
Yep, and while I like enums better overall, we can't afford all the key
code enums, so we shouldn't have them here either.
File:
/branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/MouseWheelEvent.java
(r3961)
===
Line 30:
---
Yep,we can make this one use the same structure.
Respond to these comments at
http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083branch=%2Fbranches%2F1_6_clean_events
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] event code review, part 1.
Thanks a million for an awesome review! There are a few points that need discussion, I've logged them under http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083branch=/branches/1_6_clean_events reviews. --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit] EmilyCrutcher commented on branch /branches/1_6_clean_events.
[google-web-toolkit] EmilyCrutcher commented on branch
/branches/1_6_clean_events.
Details are at
http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083branch=%2Fbranches%2F1_6_clean_events
Score: Neutral
General Comment:
Response to Alex's comments on the user package.
Line-by-line comments:
File: /branches/1_6_clean_events/user/src/com/google/gwt/user/client/L.java
(r3940)
===
Line 33: *
---
Do you think internal team members will find it confusing? This is a
package protected class, so the javadoc is just for us.
File:
/branches/1_6_clean_events/user/src/com/google/gwt/user/client/Window.java
(r3937)
===
Line 62: * page.
---
Seems like a nicer way to put it.
Line 313: */
---
Because we have another scroll handler, it actually seems slightly more
readable to use the full name to me.
Line 795: }
---
I think it was part of the support-mocking push we did a few months ago.
File:
/branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/CheckBox.java
(r3937)
===
Line 231: DOM.sinkEvents(inputElem, eventBitsToAdd |
DOM.getEventsSunk(inputElem));
---
Yep, we can add a comment here.
File:
/branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/HasValue.java
(r3941)
===
Line 4: * Licensed under the Apache License, Version 2.0 (the License);
you may not
---
Yep.
File:
/branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/SuggestBox.java
(r3940)
===
Line 91: * box itself }/li li.gwt-SuggestBoxPopup { the suggestion
popup }/li li
---
Yep, it needs to be compared and reverted against trunk.
File:
/branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/Widget.java
(r3961)
===
Line 76:*
---
Yep, we can add some more comments here.
Line 290: return eventsToSink == -1;
---
It still gets set to -1. I'll add some more comments on how it works.
Respond to these comments at
http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083branch=%2Fbranches%2F1_6_clean_events
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] Re: FYI: code reviews done through our googlecode project will CC this list.
I'm guessing the answer is no but I'll throw this out there... Is it possible to have the code review comment mails contain the comment history for each line of code that is commented on? Right now the comments in the emails are out of context. When each email has comments for several different lines, and each comment responds to a previous comment on that line, it's hard to follow the thread of conversation. When this was all done directly via email, the comments were easy to follow as everybody commented inline in the body of the previous email. An alternative approach might be to have each comment in the email contain a link to the comment thread in the full review page. On Wed, Nov 5, 2008 at 2:19 PM, Kelly Norton [EMAIL PROTECTED] wrote: I just wanted people to be aware of this. I've changed the settings in our project to always CC the code review comments to this list. /kel -- If you received this communication by mistake, you are entitled to one free ice cream cone on me. Simply print out this email including all relevant SMTP headers and present them at my desk to claim your creamy treat. We'll have a laugh at my emailing incompetence, and play a game of ping pong. (offer may not be valid in all States). --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit] [EMAIL PROTECTED] commented on branch /branches/1_6_clean_events.
[google-web-toolkit] [EMAIL PROTECTED] commented on branch
/branches/1_6_clean_events.
Details are at
http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083branch=%2Fbranches%2F1_6_clean_events
Line-by-line comments:
File:
/branches/1_6_clean_events/user/src/com/google/gwt/core/client/impl/RawJsMapImpl.java
(r3958)
===
Line 31: public class RawJsMapImplValueType {
---
How about PrivateMap? That would allow the inner class to be JsImp.
Re: pure Java
Do we have examples of these type of tests? I don't have a good
understanding of what kind of Widget tests you would be able to do. It
seems like a sizable enough burden to maintain that we should make sure we
address these use cases before we commit to it. Scott also pointed out on
the walk to the bookstore that we may have to depend more on this pattern
for OOPHM since it's considerably slower. If that's the case, we really
should get good test coverage on these so that we can say with confidence
that they won't introduce landmines for hosted mode.
Line 35: public static RawJsMapImpl.KeyMap create() {
---
This should be:
public static lt;Tgt; RawJsMapImpl.KeyMaplt;Tgt; create()
There is no reason to return a raw type.
Line 72: public final ValueType get(String key) {
---
I think it makes sense to avoid the concat when we know it's safe. Maybe we
should have PrivateMap and PrivateSafeMap.
Line 110: return get(key + :);
---
I wouldn't be surprised if suffix was faster. I'm sure that IE doesn't have
a good hash function. If it is faster, I'd rather go with the faster
version and make a todo item to update our other native maps.
Respond to these comments at
http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083branch=%2Fbranches%2F1_6_clean_events
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] Re: FYI: code reviews done through our googlecode project will CC this list.
On Thu, Nov 6, 2008 at 12:12 PM, Isaac Truett [EMAIL PROTECTED] wrote: Is it possible to have the code review comment mails contain the comment history for each line of code that is commented on? Right now the comments in the emails are out of context. When each email has comments for several different lines, and each comment responds to a previous comment on that line, it's hard to follow the thread of conversation. When this was all done directly via email, the comments were easy to follow as everybody commented inline in the body of the previous email. I agree -- the current email that is sent is nearly worthless for trying to follow if you aren't actually involved in the review. I think it would actually be better to just get email saying review comments have been made and a link to where you can read them (ie, just the top part of the current email, so I am not tempted to waste time reading them). The real problem is that even once you get to the web site, the comments are not arranged usefully, as they are still broken down by who made the comment rather than files with comments. -- John A. Tamplin Software Engineer (GWT), Google --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: FYI: code reviews done through our googlecode project will CC this list.
The most useful information I found was buried a few layers under the email: Details are at http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083branch=%2Fbranches%2F1_6_clean_events 1. Follow this link at the top of the email. Comment by [EMAIL PROTECTED], Today (10 minutes ago) 4 line-by-line comments 2. Expand this section at the bottom of the page. /branches/1_6_clean_events/user/src/com/google/gwt/core/client/impl/RawJsMapImpl.java r3958 line 31: 3. Follow this link to the source file with comments in line. I agree with John that the contents of the page at step #1 aren't very useful (to me, at least). I would instead include in the email all of the links into the code itself, as in step #3 -- that's where I need to be understand things. Now, I haven't actually participated in this as a reviewer, so maybe that first link makes more sense for someone in that role. On Thu, Nov 6, 2008 at 11:22 AM, John Tamplin [EMAIL PROTECTED] wrote: On Thu, Nov 6, 2008 at 12:12 PM, Isaac Truett [EMAIL PROTECTED] wrote: Is it possible to have the code review comment mails contain the comment history for each line of code that is commented on? Right now the comments in the emails are out of context. When each email has comments for several different lines, and each comment responds to a previous comment on that line, it's hard to follow the thread of conversation. When this was all done directly via email, the comments were easy to follow as everybody commented inline in the body of the previous email. I agree -- the current email that is sent is nearly worthless for trying to follow if you aren't actually involved in the review. I think it would actually be better to just get email saying review comments have been made and a link to where you can read them (ie, just the top part of the current email, so I am not tempted to waste time reading them). The real problem is that even once you get to the web site, the comments are not arranged usefully, as they are still broken down by who made the comment rather than files with comments. -- John A. Tamplin Software Engineer (GWT), Google --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: runAsync fragment loading bug in IE
+spoon
On Thu, Nov 6, 2008 at 4:47 AM, Cameron Braid [EMAIL PROTECTED] wrote:
in trunk IFrameLinker.getModulePrefix
out.print(function __gwtStartLoadingFragment(frag) {);
out.newlineOpt();
out.indentIn();
out.print( var script = *$doc*.createElement('script'););
out.newlineOpt();
out.print( script.src = ' + strongName + -' + frag + ' +
FRAGMENT_EXTENSION + ';);
out.print( *document*
.getElementsByTagName('head').item(0).appendChild(script););
The generated javascript runs fine in firefox and safari, however in IE it
errors due to an invalid argument.
The reason is that the script element is created in a different document
(window.parent.document) to the document it is being added to
(window.document)
I presume that the __gwtStartLoadingFragment needs to load the fragment
into the same document as the function resides, therefore the
$doc.createElement should probably be changed to document.createElement
Cheers,
Cameron
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] Re: Error when trying to build
Thanks Freeland, you give me the right way.
For newbies like me on Linux, not simple to get trough it ;) path and
java_home wasn't good.
For others who have the same trouble, here the manip :
- First, you need to setup global config in /etc/profile file for all
users:
# vi /etc/profile
- Next setup PATH / JAVA_PATH variables as follows:
# export JAVA_HOME=/usr/lib/jvm/java-1.5.0-sun
# export PATH=$PATH:/usr/lib/jvm/java-1.5.0-sun/bin
Be sure Java is at the right place ;)
Alex
On 6 nov, 16:12, Freeland Abbott [EMAIL PROTECTED] wrote:
We should be finding com.sun.tools.javadoc.Main from, in our
build-tools/doctool/build.xml:6, ${java.home}/../lib/tools.jar... that is,
from your jdk's root's lib/tools.jar. It looks like things should fail if
that jar file doesn't exist, so I'd check (a) that it's there and contains
the needed classes (if not, you have a deficient JDK) and (b) that it's
actually getting onto the classpath of the gwt.javac macro called in the
compile target of build-tools/doctool/build.xml.
On Thu, Nov 6, 2008 at 8:48 AM, Alex Gorisse [pleyo]
[EMAIL PROTECTED]wrote:
Hello,
I do not succeed to build with ant. I've tried a lot revision
(released) and i always got the same errors :
compile:
[gwt.javac] Compiling 6 source files to /home/***/Alex/GWT/trunk/build/
out/build-tools/doctool/bin
[gwt.javac] --
[gwt.javac] 1. ERROR in /home/***/Alex/GWT/trunk/build-tools/doctool/
src/com/google/doctool/Booklet.java (at line 63)
[gwt.javac] com.sun.tools.javadoc.Main.execute(args);
[gwt.javac] ^
[gwt.javac] com.sun.tools.javadoc cannot be resolved
[gwt.javac] --
[gwt.javac] 2. ERROR in /home/***/Alex/GWT/trunk/build-tools/doctool/
src/com/google/doctool/Booklet.java (at line 476)
[gwt.javac] if (tag.holder() instanceof PackageDoc) {
[gwt.javac] ^^
[gwt.javac] The method holder() is undefined for the type Tag
I use Linux Ubuntu, java v1.5, ant 1.7.0
Do you know what could be the trouble ?
Thanks !
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] Re: runAsync fragment loading bug in IE
On Thu, Nov 6, 2008 at 4:47 AM, Cameron Braid [EMAIL PROTECTED] wrote: I presume that the __gwtStartLoadingFragment needs to load the fragment into the same document as the function resides, therefore the $doc.createElement should probably be changed to document.createElement That sounds logical to me. Can you verify that this change fixes things for you? -Lex --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit commit] r3965 - branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client
Author: [EMAIL PROTECTED]
Date: Thu Nov 6 11:01:17 2008
New Revision: 3965
Modified:
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/ClickEvent.java
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/HasClickHandlers.java
Log:
Upgrading javadoc for click event.
Modified:
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/ClickEvent.java
==
---
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/ClickEvent.java
(original)
+++
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/ClickEvent.java
Thu Nov 6 11:01:17 2008
@@ -30,10 +30,9 @@
Event.ONCLICK, click, new ClickEvent());
/**
- * Ensures the existence of the handler TYPE, so the system knows to
start
- * firing events and then returns it.
+ * Gets the event type associated with click events.
*
- * @return the handler TYPE
+ * @return the handler type
*/
public static TypeClickHandler getType() {
return TYPE;
Modified:
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/HasClickHandlers.java
==
---
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/HasClickHandlers.java
(original)
+++
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/HasClickHandlers.java
Thu Nov 6 11:01:17 2008
@@ -18,8 +18,7 @@
import com.google.gwt.event.shared.HandlerRegistration;
/**
- * A widget that implements this interface is a public source of
- * [EMAIL PROTECTED] ClickEvent} events.
+ * A widget that implements this interface provides registration for
[EMAIL PROTECTED] ClickHandler} instances.
*/
public interface HasClickHandlers {
/**
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit] [EMAIL PROTECTED] commented on branch /branches/1_6_clean_events.
[google-web-toolkit] [EMAIL PROTECTED] commented on branch
/branches/1_6_clean_events.
Details are at
http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083branch=%2Fbranches%2F1_6_clean_events
Score: Neutral
General Comment:
Some more comments on the branch -- this time for the things on the list
after the quot;user/clientquot; package. I'm kind of confused about why
some of these changes were on this branch.
Line-by-line comments:
File:
/branches/1_6_clean_events/user/super/com/google/gwt/emul/java/lang/StringBuilder.java
(r3963)
===
Line 33: public class StringBuilder implements CharSequence, Appendable {
---
While it's cool that we want to support Java 6 features, why was Appendable
added to this branch?
File:
/branches/1_6_clean_events/user/super/com/google/gwt/emul/java/util/TreeSet.java
(r3963)
===
Line 27: public class TreeSetE extends AbstractSetE implements
SortedSetE, Serializable {
---
Did we need TreeSet to be Serializable for the new events? Why is this
change in this branch? ...
File:
/branches/1_6_clean_events/user/test/com/google/gwt/dev/jjs/test/HostedTest.java
(r3936)
===
Line 600:
---
Why was this taken out? Do we get the same test coverage somewhere else?
File:
/branches/1_6_clean_events/user/test/com/google/gwt/i18n/client/TestAnnotatedMessages.java
(r3963)
===
Line 29: //
@GenerateKeys(com.google.gwt.i18n.rebind.keygen.MD5KeyGenerator)
---
Should probably take out commented line.
Line 61: String optionalArgument(@Optional
---
This style looks kine of weird -- do we always want a newline after
annotations? Does autoformat do this?
Line 84: String pluralWidgetsOther(@PluralCount
---
Likewise here. I think the style would look better as:
String pluralWidgetsOther(@PluralCount int count);
... all on one line.
File:
/branches/1_6_clean_events/user/test/com/google/gwt/i18n/client/TestConstants.java
(r3963)
===
Line 24: public interface TestConstants extends
com.google.gwt.i18n.client.Constants {
---
This file also seems weird in this branch.
File:
/branches/1_6_clean_events/user/test/com/google/gwt/i18n/client/gen/Shapes.java
(r3963)
===
Line 22: public interface Shapes extends
com.google.gwt.i18n.client.Constants {
---
This file too -- why is this in the events branch?
File:
/branches/1_6_clean_events/user/test/com/google/gwt/user/server/rpc/CollectionsTestServiceImpl.java
(r3963)
===
Line 46: * TODO: document me.
---
+1 for this TODO.
Looking at this out of context, it's really not clear what it's doing.
Respond to these comments at
http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083branch=%2Fbranches%2F1_6_clean_events
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] Re: event code review, part 1.
Ray, it's pretty clear that we're going to land with the ability to instantiate and dispatch events in pure Java in tact, but Emily and I will need to document just why and how it's necessary, and beef up testing around the two paths. Offline I've already promised Kelly a couple of write ups on GWT and unit testing, mocking, DI... rjrjr On Thu, Nov 6, 2008 at 11:22 AM, Ray Cromwell [EMAIL PROTECTED] wrote: Emily, The issue of sharing the event handlers in non-GWT code is a virtual showstopper for me. One of the initial reasons I was drawn to GWT was the ability to share code between client and server, and now I've taken that to Flash and Android as well. Two things: 1) I run both GWT unit tests and regular unit tests. Smoke tests and shared functionality or non-JSNI code is typically JUnit tested. There are a couple of reasons for this, such as inability to run GWT tests under Maven, JUnit tests running much faster and not requiring XWindows to be running on our build box, differences between hosted mode on Linux/Windows/IE that make it hard to test logic without swapping implementations using deferred binding. Our build process allows us to do fast JUnit tests while developing, and then the continuous integration server launches GWT tests on 3 separate machines in the background. 2) The core logic of my GWT code is shared in my Android version, as well as my Servlet/Applet version. The current design allows me to create something like a 'zoom event' and map it to different dispatchers on Android, Browser, or Servlet (e.g. the servlet can fall back to non-Javascript old-style MapQuest-like interface) If you are going to remove the HashMap version in favor of a pure JS registry, might I suggest using a module property to do this so that I can override it and get back the original HashMap implementation? Otherwise, I'd be forced to fork or override GWT which would be a huge PITA, and could add to code bloat for me if I am forced to duplicate functionality. Overall, I don't see any reason for not using HashMap except performance, and while I could see a speedup in the event dispatching, and better memory efficiency, I'm not sure event dispatching is a hot-spot in current application code. -Ray On Thu, Nov 6, 2008 at 7:45 AM, Emily Crutcher [EMAIL PROTECTED] wrote: Thanks a million for an awesome review! There are a few points that need discussion, I've logged them under http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083branch=/branches/1_6_clean_eventsreviews. --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: event code review, part 1.
Overall, I don't see any reason for not using HashMap except performance, and while I could see a speedup in the event dispatching, and better memory efficiency, I'm not sure event dispatching is a hot-spot in current application code. Actually the dispatch is already optimized for the JS case, the argument here is whether we need to continue to support the raw Java case as well. Cheers, Emily -Ray On Thu, Nov 6, 2008 at 7:45 AM, Emily Crutcher [EMAIL PROTECTED] wrote: Thanks a million for an awesome review! There are a few points that need discussion, I've logged them under http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083branch=/branches/1_6_clean_eventsreviews. -- There are only 10 types of people in the world: Those who understand binary, and those who don't --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit commit] r3967 - branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client
Author: [EMAIL PROTECTED] Date: Thu Nov 6 12:20:35 2008 New Revision: 3967 Modified: branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/ClickEvent.java Log: Must add that final modifier in the RIGHT order. Modified: branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/ClickEvent.java == --- branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/ClickEvent.java (original) +++ branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/ClickEvent.java Thu Nov 6 12:20:35 2008 @@ -26,7 +26,7 @@ * Event type for click events. Represents the meta-data associated with this * event. */ - private final static TypeClickHandler TYPE = new TypeClickHandler( + private static final TypeClickHandler TYPE = new TypeClickHandler( Event.ONCLICK, click, new ClickEvent()); /** --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: event code review, part 1.
Ray C., No worries. We are planning to land a pure java code path through event dispatch code. My real objection in the review, which Emily and Ray forced out of me, is that we have never enumerated goals and use cases around sharing GWT-java code with other Java contexts. I want to make sure we have a good sense of what we want to accomplish with these because it is very easy to continue to slip in a change here and a change there to the point where you have no idea what part of the library can run in what context. So the plan is to land the implementation as is, but officially, the fact that there is a java code path through the event dispatch is really just happenstance. Meaning that we're not committing to support it quite yet. Ray Ryan is going to assemble a bit more vision around testability and mockability of GWT apps and libraries so that going forward we'll have a lot more guidance when we face these decisions. /kel On Thu, Nov 6, 2008 at 2:22 PM, Ray Cromwell [EMAIL PROTECTED] wrote: Emily, The issue of sharing the event handlers in non-GWT code is a virtual showstopper for me. One of the initial reasons I was drawn to GWT was the ability to share code between client and server, and now I've taken that to Flash and Android as well. Two things: 1) I run both GWT unit tests and regular unit tests. Smoke tests and shared functionality or non-JSNI code is typically JUnit tested. There are a couple of reasons for this, such as inability to run GWT tests under Maven, JUnit tests running much faster and not requiring XWindows to be running on our build box, differences between hosted mode on Linux/Windows/IE that make it hard to test logic without swapping implementations using deferred binding. Our build process allows us to do fast JUnit tests while developing, and then the continuous integration server launches GWT tests on 3 separate machines in the background. 2) The core logic of my GWT code is shared in my Android version, as well as my Servlet/Applet version. The current design allows me to create something like a 'zoom event' and map it to different dispatchers on Android, Browser, or Servlet (e.g. the servlet can fall back to non-Javascript old-style MapQuest-like interface) If you are going to remove the HashMap version in favor of a pure JS registry, might I suggest using a module property to do this so that I can override it and get back the original HashMap implementation? Otherwise, I'd be forced to fork or override GWT which would be a huge PITA, and could add to code bloat for me if I am forced to duplicate functionality. Overall, I don't see any reason for not using HashMap except performance, and while I could see a speedup in the event dispatching, and better memory efficiency, I'm not sure event dispatching is a hot-spot in current application code. -Ray On Thu, Nov 6, 2008 at 7:45 AM, Emily Crutcher [EMAIL PROTECTED] wrote: Thanks a million for an awesome review! There are a few points that need discussion, I've logged them under http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083branch=/branches/1_6_clean_events reviews. -- If you received this communication by mistake, you are entitled to one free ice cream cone on me. Simply print out this email including all relevant SMTP headers and present them at my desk to claim your creamy treat. We'll have a laugh at my emailing incompetence, and play a game of ping pong. (offer may not be valid in all States). --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit commit] r3968 - in branches/1_6_clean_events: reference/code-museum/src/com/google/gwt/museum user/src/co...
Author: [EMAIL PROTECTED]
Date: Thu Nov 6 12:41:58 2008
New Revision: 3968
Added:
branches/1_6_clean_events/user/src/com/google/gwt/core/client/impl/PrivateMap.java
- copied, changed from r3963,
/branches/1_6_clean_events/user/src/com/google/gwt/core/client/impl/RawJsMapImpl.java
Removed:
branches/1_6_clean_events/user/src/com/google/gwt/core/client/impl/RawJsMapImpl.java
Modified:
branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/SingleIssue.gwt.xml
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/DomEvent.java
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/RootPanel.java
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/TabBar.java
Log:
Renamed RawJsMapImpl to PrivateMap and renamed get/put to
unsafeGet/unsafePut
Added TabBar onClick etc. in and a new TabWrapper interface + a TabWrapper
getTabWrapper(int i) method.
Modified:
branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/SingleIssue.gwt.xml
==
---
branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/SingleIssue.gwt.xml
(original)
+++
branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/SingleIssue.gwt.xml
Thu Nov 6 12:41:58 2008
@@ -6,7 +6,7 @@
!-- Specify the app entry point class. --
entry-point
-
class='com.google.gwt.museum.client.defaultmuseum.VisualsForCheckBoxAndRadioButtonEvents'
/
+
class='com.google.gwt.museum.client.defaultmuseum.VisualsForTreeEvents'
/
source path=client/common /
source path=client/defaultmuseum /
source path=client/viewer /
Copied:
branches/1_6_clean_events/user/src/com/google/gwt/core/client/impl/PrivateMap.java
(from r3963,
/branches/1_6_clean_events/user/src/com/google/gwt/core/client/impl/RawJsMapImpl.java)
==
---
/branches/1_6_clean_events/user/src/com/google/gwt/core/client/impl/RawJsMapImpl.java
(original)
+++
branches/1_6_clean_events/user/src/com/google/gwt/core/client/impl/PrivateMap.java
Thu Nov 6 12:41:58 2008
@@ -26,92 +26,92 @@
* versions for our internal code, the API is completely unsafe with no
fewer
* then three versions of put and get, so do not use!
*
- * @param ValueType value type
+ * @param V value type
*/
-public class RawJsMapImplValueType {
+public class PrivateMapV {
- private static class KeyMapValueType extends JavaScriptObject {
+ private static class JsMapV extends JavaScriptObject {
-public static RawJsMapImpl.KeyMap create() {
- return (RawJsMapImpl.KeyMap) JavaScriptObject.createObject();
+public static PrivateMap.JsMap? create() {
+ return JavaScriptObject.createObject().cast();
}
-protected KeyMap() {
+protected JsMap() {
}
-public final native ValueType get(String key) /*-{
- return this[key];
+public final native void put(int key, V value) /*-{
+ this[key] = value;
}-*/;
-public final native ValueType get(int key) /*-{
- return this[key];
+public final native void put(String key, V value) /*-{
+ this[key] = value;
}-*/;
-public final native void put(String key, ValueType value) /*-{
- this[key] = value;
+public final native V unsafeGet(int key) /*-{
+ return this[key];
}-*/;
-public final native void put(int key, ValueType value) /*-{
- this[key] = value;
+public final native V unsafeGet(String key) /*-{
+ return this[key];
}-*/;
}
- private RawJsMapImpl.KeyMapValueType map;
- private HashMapString, ValueType javaMap;
+ private PrivateMap.JsMapV map;
+ private HashMapString, V javaMap;
- public RawJsMapImpl() {
+ public PrivateMap() {
if (GWT.isScript()) {
- map = KeyMap.create();
+ map = JsMap.create().cast();
} else {
- javaMap = new HashMapString, ValueType();
+ javaMap = new HashMapString, V();
}
}
- // Raw get, only use for values that are known not to conflict with the
- // browser's reserved keywords.
- public final ValueType get(String key) {
+ // Raw put, only use with int get.
+ public final void put(int key, V value) {
if (GWT.isScript()) {
- return map.get(key);
+ map.put(key, value);
} else {
- return javaMap.get(key);
+ javaMap.put(key + , value);
}
}
- // int get only use with int get.
- public final ValueType get(int key) {
+ // ONLY use this for values put with safePut.
+ public final V safeGet(String key) {
+return unsafeGet(: + key);
+ }
+
+ // ONLY use this for values that will be accessed with saveGet.
+ public final void safePut(String key, V value) {
+unsafePut(: + key, value);
+ }
+
+ // int unsafeGet only use
[gwt-contrib] [google-web-toolkit] kellegous commented on branch /branches/1_6_clean_events.
[google-web-toolkit] kellegous commented on branch
/branches/1_6_clean_events.
Details are at
http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083branch=%2Fbranches%2F1_6_clean_events
Line-by-line comments:
File:
/branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/AllFocusHandlers.java
(r3942)
===
Line 32: public static EventHandlerType extends BlurHandler
FocusHandler void addHandlers(
---
I definitely see the naming issue. It's hard to name without confusing
handler instances with handler types. This doesn't fix that issue, but it
does seem slightly more consistent:
// I present both of these in terms of their call site.
AllFocusHandlers.addTo(source, handler);
public class MyHandler extends AllFocusHandlers {
... {
addAllFocusHandlersTo(handler);
}
}
Respond to these comments at
http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083branch=%2Fbranches%2F1_6_clean_events
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit] kellegous commented on branch /branches/1_6_clean_events.
[google-web-toolkit] kellegous commented on branch
/branches/1_6_clean_events.
Details are at
http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083branch=%2Fbranches%2F1_6_clean_events
Line-by-line comments:
File:
/branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/BlurEvent.java
(r3942)
===
Line 47: protected BlurEvent() {
---
After our lunchtime conversation, I'm comfortable with the ability to
subclass these.
Respond to these comments at
http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083branch=%2Fbranches%2F1_6_clean_events
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit commit] r3969 - in branches/1_6_clean_events: reference/code-museum/src/com/google/gwt/museum/client/comm...
Author: [EMAIL PROTECTED]
Date: Thu Nov 6 12:57:38 2008
New Revision: 3969
Added:
branches/1_6_clean_events/user/src/com/google/gwt/event/shared/GwtEvent.java
(contents, props changed)
- copied, changed from r3963,
/branches/1_6_clean_events/user/src/com/google/gwt/event/shared/AbstractEvent.java
Removed:
branches/1_6_clean_events/user/src/com/google/gwt/event/shared/AbstractEvent.java
Modified:
branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/client/common/EventReporter.java
branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForDisclosurePanelEvents.java
branches/1_6_clean_events/user/src/com/google/gwt/core/client/impl/PrivateMap.java
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/BlurEvent.java
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/DomEvent.java
branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/BeforeSelectionEvent.java
branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/CloseEvent.java
branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/OpenEvent.java
branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/ResizeEvent.java
branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/SelectionEvent.java
branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/ValueChangeEvent.java
branches/1_6_clean_events/user/src/com/google/gwt/event/shared/HandlerManager.java
branches/1_6_clean_events/user/src/com/google/gwt/event/shared/HandlerRegistration.java
branches/1_6_clean_events/user/src/com/google/gwt/event/shared/JavaHandlerRegistry.java
branches/1_6_clean_events/user/src/com/google/gwt/event/shared/JsHandlerRegistry.java
branches/1_6_clean_events/user/src/com/google/gwt/user/client/L.java
branches/1_6_clean_events/user/src/com/google/gwt/user/client/Window.java
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/DialogBox.java
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/FormPanel.java
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/L.java
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/Widget.java
branches/1_6_clean_events/user/test/com/google/gwt/event/logical/shared/LogicalEventsTest.java
Log:
Renaming AbstractEvent to GwtEvent.
Finishing polishing PrivateMap.
Modified:
branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/client/common/EventReporter.java
==
---
branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/client/common/EventReporter.java
(original)
+++
branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/client/common/EventReporter.java
Thu Nov 6 12:57:38 2008
@@ -34,7 +34,7 @@
import com.google.gwt.event.logical.shared.SelectionHandler;
import com.google.gwt.event.logical.shared.ValueChangeEvent;
import com.google.gwt.event.logical.shared.ValueChangeHandler;
-import com.google.gwt.event.shared.AbstractEvent;
+import com.google.gwt.event.shared.GwtEvent;
import com.google.gwt.event.shared.HandlerRegistration;
import com.google.gwt.user.client.ui.ChangeListener;
import com.google.gwt.user.client.ui.CheckBox;
@@ -202,7 +202,7 @@
}
}
- private void report(AbstractEvent? event) {
+ private void report(GwtEvent? event) {
report(getInfo(event.getSource()) + fired + event.toDebugString());
}
Modified:
branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForDisclosurePanelEvents.java
==
---
branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForDisclosurePanelEvents.java
(original)
+++
branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForDisclosurePanelEvents.java
Thu Nov 6 12:57:38 2008
@@ -20,7 +20,7 @@
import com.google.gwt.event.logical.shared.CloseHandler;
import com.google.gwt.event.logical.shared.OpenEvent;
import com.google.gwt.event.logical.shared.OpenHandler;
-import com.google.gwt.event.shared.AbstractEvent;
+import com.google.gwt.event.shared.GwtEvent;
import com.google.gwt.museum.client.common.AbstractIssue;
import com.google.gwt.user.client.ui.CheckBox;
import com.google.gwt.user.client.ui.DisclosureEvent;
@@ -97,7 +97,7 @@
return widget;
}
- private void report(AbstractEvent? event) {
+ private void report(GwtEvent? event) {
String title = ((UIObject) event.getSource()).getTitle();
report(title + fired + event.toDebugString());
}
Modified:
[gwt-contrib] [google-web-toolkit] [EMAIL PROTECTED] commented on branch /branches/1_6_clean_events.
[google-web-toolkit] [EMAIL PROTECTED] commented on branch /branches/1_6_clean_events. Details are at http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083branch=%2Fbranches%2F1_6_clean_events Line-by-line comments: File: /branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/AllFocusHandlers.java (r3942) === Line 32: public static EventHandlerType extends BlurHandler FocusHandler void addHandlers( --- I actually find that even more confusing, Kelly. How about if we call things like this AllFocusEventsHandler? Respond to these comments at http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083branch=%2Fbranches%2F1_6_clean_events -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: event code review, part 1.
+1 to Kelly's sentiment @Ray C: Since you're probably doing more of this highly cross-compilable code than anyone else, we're keen to get your participation in helping formalize a set of design rules related to the portability/testability issue. We definitely don't want to break the rockin' cool stuff you're doing; we just want to make it all very intentional. On Thu, Nov 6, 2008 at 3:41 PM, Kelly Norton [EMAIL PROTECTED] wrote: Ray C., No worries. We are planning to land a pure java code path through event dispatch code. My real objection in the review, which Emily and Ray forced out of me, is that we have never enumerated goals and use cases around sharing GWT-java code with other Java contexts. I want to make sure we have a good sense of what we want to accomplish with these because it is very easy to continue to slip in a change here and a change there to the point where you have no idea what part of the library can run in what context. So the plan is to land the implementation as is, but officially, the fact that there is a java code path through the event dispatch is really just happenstance. Meaning that we're not committing to support it quite yet. Ray Ryan is going to assemble a bit more vision around testability and mockability of GWT apps and libraries so that going forward we'll have a lot more guidance when we face these decisions. /kel On Thu, Nov 6, 2008 at 2:22 PM, Ray Cromwell [EMAIL PROTECTED] wrote: Emily, The issue of sharing the event handlers in non-GWT code is a virtual showstopper for me. One of the initial reasons I was drawn to GWT was the ability to share code between client and server, and now I've taken that to Flash and Android as well. Two things: 1) I run both GWT unit tests and regular unit tests. Smoke tests and shared functionality or non-JSNI code is typically JUnit tested. There are a couple of reasons for this, such as inability to run GWT tests under Maven, JUnit tests running much faster and not requiring XWindows to be running on our build box, differences between hosted mode on Linux/Windows/IE that make it hard to test logic without swapping implementations using deferred binding. Our build process allows us to do fast JUnit tests while developing, and then the continuous integration server launches GWT tests on 3 separate machines in the background. 2) The core logic of my GWT code is shared in my Android version, as well as my Servlet/Applet version. The current design allows me to create something like a 'zoom event' and map it to different dispatchers on Android, Browser, or Servlet (e.g. the servlet can fall back to non-Javascript old-style MapQuest-like interface) If you are going to remove the HashMap version in favor of a pure JS registry, might I suggest using a module property to do this so that I can override it and get back the original HashMap implementation? Otherwise, I'd be forced to fork or override GWT which would be a huge PITA, and could add to code bloat for me if I am forced to duplicate functionality. Overall, I don't see any reason for not using HashMap except performance, and while I could see a speedup in the event dispatching, and better memory efficiency, I'm not sure event dispatching is a hot-spot in current application code. -Ray On Thu, Nov 6, 2008 at 7:45 AM, Emily Crutcher [EMAIL PROTECTED] wrote: Thanks a million for an awesome review! There are a few points that need discussion, I've logged them under http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083branch=/branches/1_6_clean_eventsreviews. -- If you received this communication by mistake, you are entitled to one free ice cream cone on me. Simply print out this email including all relevant SMTP headers and present them at my desk to claim your creamy treat. We'll have a laugh at my emailing incompetence, and play a game of ping pong. (offer may not be valid in all States). --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit] kellegous commented on branch /branches/1_6_clean_events.
[google-web-toolkit] kellegous commented on branch
/branches/1_6_clean_events.
Details are at
http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083branch=%2Fbranches%2F1_6_clean_events
General Comment:
DomEvent responses.
Line-by-line comments:
File:
/branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/DomEvent.java
(r3961)
===
Line 33: public abstract class DomEventH extends EventHandler extends
AbstractEventH {
---
At lunch, we talked about introducing a GwtEvent here instead of an
AbstractEvent. My primary objection is that AbstractX tends to suggest that
you are using the inheritance chain to pull in shared implementation. The
inheritance chain should really be used for decisions about assignability
only, not code sharing. We've had many nightmares of inflexible classes and
subclasses having to implement bogus methods in the past because of this.
In this case, I think AbstractEvent really is a common class for
assignment, we just needed a better name. Are you still ok with that?
Line 82: DomEventHandlerType cached) {
---
Should we work out that registration while this thing is in the 1.6 branch
so that we don't have to release and then deprecate the constructor?
Line 195: this.nativeEvent = nativeEvent;
---
Ah, that makes sense.
Line 207: protected abstract DomEvent.TypeH getAssociatedType();
---
This class is abstract and getAssociatedType is abstract. This class
doesn't do anything but redeclare that getAssociatedType is abstract. That
was already given by the fact that it subclasses AbstractEvent. If I'm not
misreading anything, removing this declaration will not produce an error or
change anything at all.
Respond to these comments at
http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083branch=%2Fbranches%2F1_6_clean_events
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit] [EMAIL PROTECTED] commented on branch /branches/1_6_clean_events.
[google-web-toolkit] [EMAIL PROTECTED] commented on branch /branches/1_6_clean_events. Details are at http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083branch=%2Fbranches%2F1_6_clean_events Score: Neutral General Comment: Oh. Pardon, there are more. Now looking at the quot;visualquot; museum changes. Respond to these comments at http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083branch=%2Fbranches%2F1_6_clean_events -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit commit] r3970 - branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client
Author: [EMAIL PROTECTED]
Date: Thu Nov 6 13:26:13 2008
New Revision: 3970
Modified:
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/DomEvent.java
Log:
Revised DomEvent.
Modified:
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/DomEvent.java
==
---
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/DomEvent.java
(original)
+++
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/DomEvent.java
Thu Nov 6 13:26:13 2008
@@ -16,8 +16,8 @@
package com.google.gwt.event.dom.client;
import com.google.gwt.core.client.impl.PrivateMap;
-import com.google.gwt.event.shared.GwtEvent;
import com.google.gwt.event.shared.EventHandler;
+import com.google.gwt.event.shared.GwtEvent;
import com.google.gwt.event.shared.HandlerManager;
import com.google.gwt.user.client.Event;
@@ -32,54 +32,55 @@
*/
public abstract class DomEventH extends EventHandler extends GwtEventH
{
/**
- * Type class used by dom event subclasses.
+ * Type class used by dom event subclasses. Type is specialized for dom
in
+ * order to carry information about the native event.
*
- * @param HandlerType handler type
+ * @param H handler type
*/
- public static class TypeHandlerType extends EventHandler extends
- GwtEvent.TypeHandlerType {
-private final int nativeEventTypeInt;
-private DomEventHandlerType cached;
+ public static class TypeH extends EventHandler extends
GwtEvent.TypeH {
+private final int eventToSink;
+private DomEventH flyweight;
/**
* Constructor.
*
- * @param nativeEventTypeInt the native event type
+ * @param eventToSink the native event type to sink
+ *
*/
-public Type(int nativeEventTypeInt) {
- this.nativeEventTypeInt = nativeEventTypeInt;
+public Type(int eventToSink) {
+ this.eventToSink = eventToSink;
}
/**
- * This is a highly dangerous method that allows dom event types to be
- * triggered by the [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,
HandlerManager)}
- * method. It should only be used by implementors supporting new dom
events.
+ * This constructor allows dom event types to be triggered by the
+ * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event, HandlerManager)}
method. It
should
+ * only be used by implementors supporting new dom events.
* p
* Any such dom event type must act as a flyweight around a native
event
* object.
* /p
*
*
- * @param nativeEventTypeInt the integer value used by sink events to
set up
- * event handling for this dom type
- * @param eventName the raw js event name
- * @param cached the cached object instance that will be used as a
flyweight
+ * @param eventToSink the integer value used by sink events to set up
event
+ * handling for this dom type
+ * @param eventName the raw native event name
+ * @param flyweight the instance that will be used as a flyweight
* to wrap a native event
*/
-protected Type(int nativeEventTypeInt, String eventName,
-DomEventHandlerType cached) {
- this.cached = cached;
- // All clinit activity should take place here for DomEvent.
- this.nativeEventTypeInt = nativeEventTypeInt;
+protected Type(int eventToSink, String eventName, DomEventH
flyweight) {
+ this.flyweight = flyweight;
+ this.eventToSink = eventToSink;
+
+ // Until we have eager clinits implemented, we are manually
initializing
+ // DomEvent here.
if (registered == null) {
init();
}
registered.unsafePut(eventName, this);
- reverseRegistered.unsafePut(nativeEventTypeInt + , this);
+ reverseRegistered.put(eventToSink, this);
}
-Type(int nativeEventTypeInt, String[] eventNames,
-DomEventHandlerType cached) {
+Type(int nativeEventTypeInt, String[] eventNames, DomEventH cached) {
this(nativeEventTypeInt, eventNames[0], cached);
for (int i = 1; i eventNames.length; i++) {
registered.unsafePut(eventNames[i], this);
@@ -87,13 +88,15 @@
}
/**
- * Gets the native [EMAIL PROTECTED] Event} type integer corresponding to
the
native
- * event.
+ * Gets the integer defined by the native [EMAIL PROTECTED] Event} type
needed to
hook
+ * up event handling when the user calls
+ * [EMAIL PROTECTED]
com.google.gwt.user.client.DOM#sinkEvents(com.google.gwt.user.client.Element,
int)}
+ * .
*
* @return the native event type
*/
-public int getNativeEventTypeInt() {
- return nativeEventTypeInt;
+public int getEventToSink() {
+ return eventToSink;
}
}
@@ -102,22 +105,20 @@
private static PrivateMapType? reverseRegistered;
[gwt-contrib] [google-web-toolkit] [EMAIL PROTECTED] commented on branch /branches/1_6_clean_events.
[google-web-toolkit] [EMAIL PROTECTED] commented on branch /branches/1_6_clean_events. Details are at http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083branch=%2Fbranches%2F1_6_clean_events Line-by-line comments: File: /branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/AllFocusHandlers.java (r3942) === Line 32: public static EventHandlerType extends BlurHandler FocusHandler void addHandlers( --- The downside of that one is that there is no such thing as a FocusEventHandler. The downside of addFocusHandlersTo is that it also adds BlurHandlers. The convention is add[HandlerTypeName](handler) so now that I think about it, even my proposal should've been AllFocusEventHandlers.add(source, handler) and this.addAllFocusHandlers(handler). Anyway, I can't think of a good name. Anyone else want to take a stab? If not, I'll try to circle around and think of one. Respond to these comments at http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083branch=%2Fbranches%2F1_6_clean_events -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit] [EMAIL PROTECTED] commented on branch /branches/1_6_clean_events.
[google-web-toolkit] [EMAIL PROTECTED] commented on branch
/branches/1_6_clean_events.
Details are at
http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083branch=%2Fbranches%2F1_6_clean_events
Score: Neutral
General Comment:
Looked at the quot;visualquot; museum tests. In general, I think museum
tests should list out which events we expect to see.
Line-by-line comments:
File:
/branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForDisclosurePanelEvents.java
(r3969)
===
Line 56: return Click on disclosure panel, see the expected events
firing;
---
Maybe put in a note about which ones are expected?
File:
/branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForEventsFiring.java
(r3943)
===
Line 113: {
---
Sort of an odd style with these extra blocks. Any particular reason here,
other than grouping chunks of code?
If it's just for chunking, maybe they could be methods,
quot;setupMouseAndClickEvents()quot; and so on.
File:
/branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForPopupEvents.java
(r3943)
===
Line 64: + (autoHide ? auto hide : persistant);
---
Don't mean to be a spelling jerk. quot;persistentquot; is standard.
File:
/branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForTableEvents.java
(r3943)
===
Line 32: * A simple tree used to quickly exercise tree behavior.
---
Javadoc should be updated!
File:
/branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForTreeEvents.java
(r3950)
===
Line 75: return Open each node, ensure you see the right events in the
window title;
---
Same here -- listing out what the right events are would be helpful.
Respond to these comments at
http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083branch=%2Fbranches%2F1_6_clean_events
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit commit] r3973 - branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui
Author: [EMAIL PROTECTED]
Date: Thu Nov 6 14:20:26 2008
New Revision: 3973
Modified:
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/Widget.java
Log:
Straggler commit for renaming getIntEventType
Modified:
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/Widget.java
==
---
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/Widget.java
(original)
+++
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/Widget.java
Thu Nov 6 14:20:26 2008
@@ -124,7 +124,7 @@
final H handler, DomEvent.TypeH type) {
if (type != null) {
// Manual inline sinkEvents.
- int eventBitsToAdd = type.getNativeEventTypeInt();
+ int eventBitsToAdd = type.getEventToSink();
if (isOrWasAttached()) {
super.sinkEvents(eventBitsToAdd);
} else {
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit commit] r3975 - in branches/1_6_clean_events: reference/code-museum/src/com/google/gwt/museum/client/defa...
Author: [EMAIL PROTECTED]
Date: Thu Nov 6 14:28:17 2008
New Revision: 3975
Modified:
branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForDialogBox.java
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/DialogBox.java
Log:
Adding support for DialogBox.getCaptionWrapper.
Modified:
branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForDialogBox.java
==
---
branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForDialogBox.java
(original)
+++
branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForDialogBox.java
Thu Nov 6 14:28:17 2008
@@ -17,6 +17,8 @@
import com.google.gwt.dom.client.Document;
import com.google.gwt.dom.client.Element;
+import com.google.gwt.event.dom.client.MouseDownEvent;
+import com.google.gwt.event.dom.client.MouseDownHandler;
import com.google.gwt.museum.client.common.AbstractIssue;
import com.google.gwt.user.client.Event;
import com.google.gwt.user.client.ui.DialogBox;
@@ -33,7 +35,7 @@
public class VisualsForDialogBox extends AbstractIssue {
enum VisibleEvents {
-mouseDown, mouseEnter, mouseLeave, mouseMove, mouseUp
+mouseDown, mouseEnter, mouseLeave, mouseMove, mouseUp,captionMouseDown
}
private final class VisibleDialogBox extends DialogBox {
@@ -128,6 +130,11 @@
super.onMouseUp(sender, x, y);
}
+public void pass(VisibleEvents event) {
+ eventToElement.get(event).setInnerHTML(
+ span style='color:green'pass/span);
+}
+
private Element addResultRow(String eventName) {
int row = layout.getRowCount();
layout.setHTML(row, 0, eventName);
@@ -140,11 +147,6 @@
return Document.get().getElementById(vis-closebox).isOrHasChild(
event.getTarget());
}
-
-private void pass(VisibleEvents event) {
- eventToElement.get(event).setInnerHTML(
- span style='color:green'pass/span);
-}
}
@Override
@@ -180,8 +182,13 @@
private VisibleDialogBox showVisibleDialog() {
final VisibleDialogBox dialog = new VisibleDialogBox();
dialog.setModal(false);
-
dialog.center();
+dialog.getCaptionWrapper().addMouseDownHandler(new MouseDownHandler(){
+
+ public void onMouseDown(MouseDownEvent event) {
+dialog.pass(VisibleEvents.captionMouseDown);
+ }
+});
return dialog;
}
Modified:
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/DialogBox.java
==
---
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/DialogBox.java
(original)
+++
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/DialogBox.java
Thu Nov 6 14:28:17 2008
@@ -73,6 +73,17 @@
@SuppressWarnings(deprecation)
public class DialogBox extends DecoratedPopupPanel implements HasHTML,
HasText,
MouseListener {
+ /**
+ * Set of characteristic interfaces supported by the [EMAIL PROTECTED]
DialogBox}
caption wrappers.
+ *
+ * Note that this set might expand over time, so implement this
interface at
+ * your own risk.
+ */
+ public interface CaptionWrapper extends HasAllMouseHandlers {
+ }
+
+ private class CaptionWrapperImpl extends HTML implements CaptionWrapper {
+ }
private class MouseHandler implements MouseDownHandler, MouseUpHandler,
MouseOutHandler, MouseOverHandler, MouseMoveHandler {
@@ -102,8 +113,8 @@
* The default style name.
*/
private static final String DEFAULT_STYLENAME = gwt-DialogBox;
-
- private HTML caption = new HTML();
+
+ private CaptionWrapperImpl caption = new CaptionWrapperImpl();
private boolean dragging;
private int dragStartX, dragStartY;
private int windowWidth;
@@ -172,7 +183,7 @@
*
* @return the Caption widget wrapper
*/
- public C extends Widget HasAllMouseHandlers Widget
getCaptionWrapper() {
+ public CaptionWrapper getCaptionWrapper() {
return caption;
}
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit] [EMAIL PROTECTED] commented on branch /branches/1_6_clean_events.
[google-web-toolkit] [EMAIL PROTECTED] commented on branch
/branches/1_6_clean_events.
Details are at
http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083branch=%2Fbranches%2F1_6_clean_events
Line-by-line comments:
File:
/branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/AllFocusHandlers.java
(r3942)
===
Line 32: public static EventHandlerType extends BlurHandler
FocusHandler void addHandlers(
---
AllFocusRelatedEventsHandler
AllMouseRelatedEventsHandler
AllKeyboardRelatedEventsHandler
Verbose, but clear.
File: /branches/1_6_clean_events/user/src/com/google/gwt/user/client/L.java
(r3940)
===
Line 33: *
---
Fixed it anyway, 'cause us ♥ JavaDoc. Here and in user.client.ui.L
File:
/branches/1_6_clean_events/user/src/com/google/gwt/user/client/Window.java
(r3937)
===
Line 61: * The message to display to the user in an attempt to keep
them on the
---
fixed
Line 795: }
---
Yes, that's correct. You can't mock a class if it blows up at class init
time.
File:
/branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/CheckBox.java
(r3937)
===
Line 230: if (eventsToSink == -1) {
---
Changed to use isOrWasAttached. No more magic -1
File:
/branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/HasValue.java
(r3941)
===
Line 3: *
---
fixed
File:
/branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/SuggestBox.java
(r3940)
===
Line 90: * h3CSS Style Rules/h3 ul class='css' li.gwt-SuggestBox {
the suggest
---
fixed. (Down with auto format!!)
File:
/branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/Widget.java
(r3961)
===
Line 76:*
---
done
Line 290: return eventsToSink == -1;
---
punched up the docs
Respond to these comments at
http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083branch=%2Fbranches%2F1_6_clean_events
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit commit] r3979 - in branches/1_6_clean_events: reference/code-museum/src/com/google/gwt/museum/client/comm...
Author: [EMAIL PROTECTED]
Date: Thu Nov 6 21:05:56 2008
New Revision: 3979
Modified:
branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/client/common/EventReporter.java
branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForSuggestBoxEvents.java
branches/1_6_clean_events/user/src/com/google/gwt/user/client/L.java
branches/1_6_clean_events/user/src/com/google/gwt/user/client/Window.java
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/CheckBox.java
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/HasValue.java
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/L.java
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/SuggestBox.java
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/Widget.java
Log:
Various doc tweaks. Fix HandlerManager#isEventHandled. Nicer
Composite#onAttach. Widget#isOrWasAttached is now protected. Fix
SuggestionBox VisualTest
Modified:
branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/client/common/EventReporter.java
==
---
branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/client/common/EventReporter.java
(original)
+++
branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/client/common/EventReporter.java
Thu Nov 6 21:05:56 2008
@@ -35,7 +35,6 @@
import com.google.gwt.event.logical.shared.ValueChangeEvent;
import com.google.gwt.event.logical.shared.ValueChangeHandler;
import com.google.gwt.event.shared.GwtEvent;
-import com.google.gwt.event.shared.HandlerRegistration;
import com.google.gwt.user.client.ui.ChangeListener;
import com.google.gwt.user.client.ui.CheckBox;
import com.google.gwt.user.client.ui.ClickListener;
@@ -72,7 +71,6 @@
*/
public abstract class CheckBoxEvent extends CheckBox implements
ValueChangeHandlerBoolean {
-protected HandlerRegistration reg;
String name;
public CheckBoxEvent(String name, Panel p) {
@@ -80,7 +78,7 @@
this.setText(name);
p.add(this);
this.addValueChangeHandler(this);
- this.setChecked(true);
+ this.setValue(true, true);
}
public abstract void addHandler();
Modified:
branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForSuggestBoxEvents.java
==
---
branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForSuggestBoxEvents.java
(original)
+++
branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForSuggestBoxEvents.java
Thu Nov 6 21:05:56 2008
@@ -18,6 +18,7 @@
import com.google.gwt.event.logical.shared.ValueChangeEvent;
import com.google.gwt.event.logical.shared.ValueChangeHandler;
+import com.google.gwt.event.shared.HandlerRegistration;
import com.google.gwt.museum.client.common.AbstractIssue;
import com.google.gwt.museum.client.common.EventReporter;
import com.google.gwt.user.client.ui.CheckBox;
@@ -92,7 +93,7 @@
report);
handler.new CheckBoxEvent(KeyDown, p) {
-
+ HandlerRegistration reg;
@Override
public void addHandler() {
reg = b.addKeyDownHandler(handler);
@@ -101,6 +102,7 @@
@Override
public void removeHandler() {
reg.removeHandler();
+reg = null;
}
};
Modified:
branches/1_6_clean_events/user/src/com/google/gwt/user/client/L.java
==
--- branches/1_6_clean_events/user/src/com/google/gwt/user/client/L.java
(original)
+++ branches/1_6_clean_events/user/src/com/google/gwt/user/client/L.java
Thu Nov 6 21:05:56 2008
@@ -29,8 +29,11 @@
import java.util.EventListener;
/**
- * Root of legacy listener support hierarchy.
+ * Legacy listener support hierarchy for
codecom.google.gwt.user.client/code.
+ * Gathers the bulk of the legacy glue code in one place, for easy
deletion when
+ * Listener methods are deleted.
*
+ * @see com.google.gwt.user.L
* @param T listener type
*/
@Deprecated
Modified:
branches/1_6_clean_events/user/src/com/google/gwt/user/client/Window.java
==
---
branches/1_6_clean_events/user/src/com/google/gwt/user/client/Window.java
(original)
+++
branches/1_6_clean_events/user/src/com/google/gwt/user/client/Window.java
Thu Nov 6 21:05:56 2008
@@ -24,8 +24,8 @@
import com.google.gwt.event.logical.shared.HasResizeHandlers;
import com.google.gwt.event.logical.shared.ResizeEvent;
import
