Re: Fast implementation of Design displays with GWT?
Wild idea: make some open source converter that is able to fill this developer/design cap: It will parse the received html/css design, and convert it to useful GWT code. Through annotations/config you can fine tune the conversion html/css. Bu...come to think of it: this sounds like the UIBinder ;)... So basically you could ask the web designer to deliver UIBinder templates and make them useful through gwt code (retrieve elements to make it more flexible, being able to modify/change elements) Ideas? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Best practices for inlining build (revision) number into GWT App?
I have a XML file that stores various information about my build and is updated by a Linker which increments build number each build I make. And I have a generator that returns an interface that I can use in GWT app which includes the build number, revision, build date etc. Regards Honza On Tuesday, June 11, 2013 7:17:42 PM UTC+2, Joseph Lust wrote: For various reasons you need to know the revision of the GWT app code. For example to verify that the server API is not newer than the JS code (i.e. if you deploy GWT JS to a CDN). Some common approaches which I find to be rather hackish: - Use Maven replacer to replace a sequence in a *source* file at the validation stage and have that inlined into your GWT file at compile (hackish) - Use Maven replacer or Maven war plugin filters to add the build number to the index.html page, or a backend service (JS code still not independently versioned, more API calls) - Hardcode it (don't hardcode things) After two years, the best method I've see is to create a *code generator* to allow deferred binding of the build number. This however has always stuck me as massively overkill to add a number to a build artifact. So, I was curious how others here have dealt with this common issue. Hopefully there is a simpler way. Sincerely, Joseph -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Code splittingmysteries
Ed, did you ever get this sorted? As I commented on the linked issue I'm
running into what seems to be a similar problem.
On Wednesday, April 10, 2013 8:13:07 AM UTC+1, Ed wrote:
I just downgraded to GWT 2.4 and my left over fragment disappeared :(...
(initial load was almost the same)
Strange - or 2.4. had a code splitting involved bug or 2.5. has one...
On Mon, Mar 25, 2013 at 4:03 PM, Ed Bras post2...@gmail.com javascript:
wrote:
BTW: a corresponding issue in the issue tracker:
https://code.google.com/p/google-web-toolkit/issues/detail?id=7874
Let's hope more people are experiencing the same problem (and vote the
issue) such that the dev team put it on their priority list.
On Wed, Mar 20, 2013 at 3:22 PM, Ashton Thomas
ash...@acrinta.comjavascript:
wrote:
I would also be interested in any updates to this as I am currently
working on the async aspect or my app. (I wouldn't even know how to
identify anomalies due to a lack of experience here)
I also remembrer having the same questions with soyc
-at
On Wednesday, March 20, 2013 7:53:11 AM UTC-4, Ed wrote:
After upgrading from 2.5.0 to 2.5.1 all of a sudden my code splitting
result is different:
+ Code fragments are bundles together which weren't before.
+ I have a left over fragment, which was 0 (see attachment).
What changed concerning code splitting? Can't find any in the release
notes.
A few observations:
1) All my components have a singleton facade that contains a method to
create the package protected controller implementation that is called
through split point (GWT.runAsync()).
In this way I have a LoginControllerDefault that is present in the left
over, but this package protected controller ONLY appears in the
LoginFacade.
In the same way I have SubscribeControllerControllerD**efault that
appears only in SubscribeControllerFacade...
What suprised me is that they appear both in the same code split,
namely #30 (see screenshot attachment).
No idea why.
I moved the creation of LoginControllerDefault from the Facade
directly (see below for code snippets) in to the runAsync, but that had
no effect.
I also removed the LoginControllerDefault completely which had little
effect on the left-over
When I read the soyc report (automatically build during maven nightly
build), It doesn't really help me. This page is hard to understand, like
this page:
soycReport/compile-report/**leftoverStatus-0.html
Even worse, from this page you can go deeper to see why a class is
in a certain split point but that results in a page not found (404).
That is, the following page isn't present. BTW: the page also resulted
in a 404 in previous GWT releases.
soycReport/compile-report/**
methodDependencies-total-0.**html
Why?
I played with the nr of fragmentCount, but that has little effect,
see the attached screenshots:
+ fragmentCount = 6: screenshot with 4 splits points.
+ fragmentCount = 8: screenshot with 6 splits points.
+ fragmentCount = 10: screenshot with 7 splits points.
Below a code snippet that shows how I create the controllers in split
point #30 (see screenshot). It concerns the creation of the
LoginControllerDefault and SubscribeInfoControllerDefault**.
Note: I don't find it the most elegant code solution, but before I
passed in a Creator interface that was used in GWT.runAsync(), but that
didn't work (big left over). I posted that in the forum and it was
mentioned that it could be that it is because the code removal is run
after
the split point code, and that is probably why it doesn't work and that
Ray
still have a look in to code split code that need to be optimized.
How to solve/analyze these issues?
What are your experiences?
Any suggestions are more then welcome as I am out of ideas and find it
hard to solve this, but it frustrates me ;)
Loading and creating the the Login and SubscribeInfo controller:
-
The code snippet that is called by the LoginControllerBuilder to load
the Login controller:
public void create(final AsyncCallbackLoginController callback) {
getLazyLoader().**createInCodeSplitGeneral30(**LoginController.class,
callback);
}
The controller loading code (in other class):
public T void createInCodeSplitGeneral30(**final ClassT type,
final AsyncCallbackT callback, final SimpleMediator mediator) {
GWT.runAsync(new RunAsyncCallback() {
public void onSuccess() {
callback.onSuccess(**createCodeSplitGeneral30(type, mediator));
}
public void onFailure(final Throwable reason) {
callback.onFailure(reason);
}
});
}
@SuppressWarnings(unchecked)
private T T createCodeSplitGeneral30(final ClassT type, final
SimpleMediator mediator) {
if (isType(type, LoginController.class)) {
return (T) LoginFacade.getInstance().**createController();
}
else if (isType(type, SubscribeController.class)) {
return (T) SubscribeFacade.getInstance().**createController();
Re: GWT Toolkits
On 10/06/2013 17:40, Donald Hook wrote: I am looking at developing an application that will have some objects on a canvas or page. These objects (almost like placecards, square with information displayed within it) will display project information and users will have the ability to connect multiple objects. In addition, these objects will have information as to how much time they will take to complete the task. On the page, there will be several objects, the user can have the ability to connect these objects and I want to be able to change the color or format of the connecting lines based on what items are in the critical path. I have not yet seen any tools that will support this capability and was wondering if others know of anything that may be close to what we need. Maybe the jsPlumb http://jsplumbtoolkit.com/jquery/demo.html plugin for jQuery is close of your need. Would need a GWT wrapper, though... -- Philippe Lhoste -- (near) Paris -- France -- http://Phi.Lho.free.fr -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: GWT Toolkits
On 12/06/2013 12:32, Philippe Lhoste wrote: Maybe the jsPlumb http://jsplumbtoolkit.com/jquery/demo.html plugin for jQuery is close of your need. Would need a GWT wrapper, though... http://code.google.com/p/gwt-jsplumb/ -- Philippe Lhoste -- (near) Paris -- France -- http://Phi.Lho.free.fr -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Code splittingmysteries
Ed, did you ever get this sorted? As I commented on the linked issue I'm running into what seems to be a similar problem. Not. It's hard to track the exact cause. It tired, but had to give up (a lot of time, and not knowing exactly what happens. But it's good to see that more people are experiencing the same kind of problems such that I am not alone ;) Ray same to be the code splitting guru. Let's hope he has has some time to look at this ;) If you can isolate the problem in a small program that reproduces this behavior, please do upload it in the issue. I tried, but failed :( -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Code splittingmysteries
Ed, did you ever get this sorted? As I commented on the linked issue I'm running into what seems to be a similar problem. No. It's hard to track the exact cause. It tried, but had to give up (a lot of time, and not knowing exactly what happens. But it's good to see that more people are experiencing the same kind of problems such that I am not alone ;) Ray seem to be the code splitting guru. Let's hope he has has some time to look at this ;) If you can isolate the problem in a small program that reproduces this behavior, please do upload it in the issue. I tried, but failed :( This will help the gwt dev team a lot to solve the problem (and the issue will get a higher priority and solved sooner). -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
About the EditTextCell widget
Right now I'm using this widget aiming to fire an update request to the back-end whenever the user updates its value. It happens that this widget fires an update event even if the value was not modified. I had to implement a simple logic to ensure the update event firing only when the value actually changes. Should I submit a new issue and/or a pull request? -- D. Reinert -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Code splittingmysteries
Yeah. I've tried reproducing the issue with a sample app but thus far haven't been able to; not sure that the sample webapp captures enough of the complexity of the actual webapp we're having the problem with. As I mentioned before can confirm that changing none of the webapp code but switching between 2.5 and 2.5.1 causes everything to end up in the leftover. From the compiler report it's not at all obvious why these classes are in the leftover fragment as they look isolated from what I can tell. On 12 June 2013 13:13, Ed post2edb...@gmail.com wrote: Ed, did you ever get this sorted? As I commented on the linked issue I'm running into what seems to be a similar problem. No. It's hard to track the exact cause. It tried, but had to give up (a lot of time, and not knowing exactly what happens. But it's good to see that more people are experiencing the same kind of problems such that I am not alone ;) Ray seem to be the code splitting guru. Let's hope he has has some time to look at this ;) If you can isolate the problem in a small program that reproduces this behavior, please do upload it in the issue. I tried, but failed :( This will help the gwt dev team a lot to solve the problem (and the issue will get a higher priority and solved sooner). -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Code splittingmysteries
Quite frustrating as I don't feel like I'm making much progress and am just going to have to go back to 2.5.0 but don't really want to lose out on the bugfixes from 2.5.1 :( On 12 June 2013 15:45, James Horsley james.hors...@gmail.com wrote: Yeah. I've tried reproducing the issue with a sample app but thus far haven't been able to; not sure that the sample webapp captures enough of the complexity of the actual webapp we're having the problem with. As I mentioned before can confirm that changing none of the webapp code but switching between 2.5 and 2.5.1 causes everything to end up in the leftover. From the compiler report it's not at all obvious why these classes are in the leftover fragment as they look isolated from what I can tell. On 12 June 2013 13:13, Ed post2edb...@gmail.com wrote: Ed, did you ever get this sorted? As I commented on the linked issue I'm running into what seems to be a similar problem. No. It's hard to track the exact cause. It tried, but had to give up (a lot of time, and not knowing exactly what happens. But it's good to see that more people are experiencing the same kind of problems such that I am not alone ;) Ray seem to be the code splitting guru. Let's hope he has has some time to look at this ;) If you can isolate the problem in a small program that reproduces this behavior, please do upload it in the issue. I tried, but failed :( This will help the gwt dev team a lot to solve the problem (and the issue will get a higher priority and solved sooner). -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Code splittingmysteries
Yes, I understand what you mean, I experienced the same... It's hard to hand over a test case that fails, to the dev team, such that they can use that to work on :( Yes it would be nice to have better facilities such that we can try to track done the cause our self. Currently the SOYC report isn't helping a lot. To my experience the SOYC report is buggy, as some pages result in a 404 :(.. (I experienced that several times the last years with a correctly created soyc, it's also in some issue if I remember correctly). On Wed, Jun 12, 2013 at 4:45 PM, James Horsley james.hors...@gmail.comwrote: Yeah. I've tried reproducing the issue with a sample app but thus far haven't been able to; not sure that the sample webapp captures enough of the complexity of the actual webapp we're having the problem with. As I mentioned before can confirm that changing none of the webapp code but switching between 2.5 and 2.5.1 causes everything to end up in the leftover. From the compiler report it's not at all obvious why these classes are in the leftover fragment as they look isolated from what I can tell. On 12 June 2013 13:13, Ed post2edb...@gmail.com wrote: Ed, did you ever get this sorted? As I commented on the linked issue I'm running into what seems to be a similar problem. No. It's hard to track the exact cause. It tried, but had to give up (a lot of time, and not knowing exactly what happens. But it's good to see that more people are experiencing the same kind of problems such that I am not alone ;) Ray seem to be the code splitting guru. Let's hope he has has some time to look at this ;) If you can isolate the problem in a small program that reproduces this behavior, please do upload it in the issue. I tried, but failed :( This will help the gwt dev team a lot to solve the problem (and the issue will get a higher priority and solved sooner). -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to a topic in the Google Groups Google Web Toolkit group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-web-toolkit/_8CdVbBb488/unsubscribe?hl=en . To unsubscribe from this group and all its topics, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Code splittingmysteries
Yep, tried to go back to 2.5, but then I see some other bugs that are solved in 2.5.1 ;)... So for me this was no option... On Wed, Jun 12, 2013 at 5:17 PM, Ed Bras post2edb...@gmail.com wrote: Yes, I understand what you mean, I experienced the same... It's hard to hand over a test case that fails, to the dev team, such that they can use that to work on :( Yes it would be nice to have better facilities such that we can try to track done the cause our self. Currently the SOYC report isn't helping a lot. To my experience the SOYC report is buggy, as some pages result in a 404 :(.. (I experienced that several times the last years with a correctly created soyc, it's also in some issue if I remember correctly). On Wed, Jun 12, 2013 at 4:45 PM, James Horsley james.hors...@gmail.comwrote: Yeah. I've tried reproducing the issue with a sample app but thus far haven't been able to; not sure that the sample webapp captures enough of the complexity of the actual webapp we're having the problem with. As I mentioned before can confirm that changing none of the webapp code but switching between 2.5 and 2.5.1 causes everything to end up in the leftover. From the compiler report it's not at all obvious why these classes are in the leftover fragment as they look isolated from what I can tell. On 12 June 2013 13:13, Ed post2edb...@gmail.com wrote: Ed, did you ever get this sorted? As I commented on the linked issue I'm running into what seems to be a similar problem. No. It's hard to track the exact cause. It tried, but had to give up (a lot of time, and not knowing exactly what happens. But it's good to see that more people are experiencing the same kind of problems such that I am not alone ;) Ray seem to be the code splitting guru. Let's hope he has has some time to look at this ;) If you can isolate the problem in a small program that reproduces this behavior, please do upload it in the issue. I tried, but failed :( This will help the gwt dev team a lot to solve the problem (and the issue will get a higher priority and solved sooner). -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com . Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to a topic in the Google Groups Google Web Toolkit group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-web-toolkit/_8CdVbBb488/unsubscribe?hl=en . To unsubscribe from this group and all its topics, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Out of Memory during GWT compile
Thanks for the reply.. Is there any other option other than increasing -XX:MaxPermSize.? Is there a compiler option that can do the memory optimization? ~Ranjith On Tuesday, June 11, 2013 11:05:44 PM UTC+5:30, Ranjith Chungath wrote: While analyzing with Eclipse Memory Analyzer(MAT), it was found that around 860MB of memory is taken by HashMap.Entry and HashMap.Entry[]. There are 1.3 million instances of HashMap.Entry objects created. See image below. https://lh4.googleusercontent.com/-01hS32-3jco/UbdeLrLCNmI/ABo/O5V7ZTHj6-k/s1600/1.png These HashMap Entries typically have keys as (com.google.gwt.dev.jjs.ast.JMethod, com.google.gwt.dev.jjs.ast.JField, com.google.gwt.dev.jjs.ast.JParameter etc.) and the value is typically an instance of java.lang.Object. https://lh4.googleusercontent.com/-AHAWKJmod2s/UbdeQ8YZ8gI/ABw/saqozlgWQm8/s1600/2.png These maps are referenced from the PermutationWorker Thread. https://lh6.googleusercontent.com/-293uEuYJK70/UbdeZDyyiUI/AB4/o86kVs5XPC4/s1600/3.png Why are so many instances on HashMap Entries created ? Is this a an existing bug or do we need to specify any flag during the GWT compile to get around this problem?https://lh6.googleusercontent.com/-293uEuYJK70/UbdeZDyyiUI/AB4/o86kVs5XPC4/s1600/3.png Thanks,https://lh6.googleusercontent.com/-293uEuYJK70/UbdeZDyyiUI/AB4/o86kVs5XPC4/s1600/3.png Ranjithhttps://lh6.googleusercontent.com/-293uEuYJK70/UbdeZDyyiUI/AB4/o86kVs5XPC4/s1600/3.png https://lh6.googleusercontent.com/-293uEuYJK70/UbdeZDyyiUI/AB4/o86kVs5XPC4/s1600/3.png https://lh6.googleusercontent.com/-293uEuYJK70/UbdeZDyyiUI/AB4/o86kVs5XPC4/s1600/3.png https://lh6.googleusercontent.com/-293uEuYJK70/UbdeZDyyiUI/AB4/o86kVs5XPC4/s1600/3.png https://lh6.googleusercontent.com/-293uEuYJK70/UbdeZDyyiUI/AB4/o86kVs5XPC4/s1600/3.png https://lh6.googleusercontent.com/-293uEuYJK70/UbdeZDyyiUI/AB4/o86kVs5XPC4/s1600/3.png https://lh6.googleusercontent.com/-293uEuYJK70/UbdeZDyyiUI/AB4/o86kVs5XPC4/s1600/3.png https://lh6.googleusercontent.com/-293uEuYJK70/UbdeZDyyiUI/AB4/o86kVs5XPC4/s1600/3.png https://lh6.googleusercontent.com/-293uEuYJK70/UbdeZDyyiUI/AB4/o86kVs5XPC4/s1600/3.png https://lh6.googleusercontent.com/-293uEuYJK70/UbdeZDyyiUI/AB4/o86kVs5XPC4/s1600/3.png https://lh6.googleusercontent.com/-293uEuYJK70/UbdeZDyyiUI/AB4/o86kVs5XPC4/s1600/3.png https://lh6.googleusercontent.com/-293uEuYJK70/UbdeZDyyiUI/AB4/o86kVs5XPC4/s1600/3.png -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Code splittingmysteries
Yeah. the SOYC report in this case hasn't helped me much either because I'm not reading it right or it's just not surfacing the right info. The only 404 I get is regarding the compiler metrics link. On 12 June 2013 16:18, Ed Bras post2edb...@gmail.com wrote: Yep, tried to go back to 2.5, but then I see some other bugs that are solved in 2.5.1 ;)... So for me this was no option... On Wed, Jun 12, 2013 at 5:17 PM, Ed Bras post2edb...@gmail.com wrote: Yes, I understand what you mean, I experienced the same... It's hard to hand over a test case that fails, to the dev team, such that they can use that to work on :( Yes it would be nice to have better facilities such that we can try to track done the cause our self. Currently the SOYC report isn't helping a lot. To my experience the SOYC report is buggy, as some pages result in a 404 :(.. (I experienced that several times the last years with a correctly created soyc, it's also in some issue if I remember correctly). On Wed, Jun 12, 2013 at 4:45 PM, James Horsley james.hors...@gmail.comwrote: Yeah. I've tried reproducing the issue with a sample app but thus far haven't been able to; not sure that the sample webapp captures enough of the complexity of the actual webapp we're having the problem with. As I mentioned before can confirm that changing none of the webapp code but switching between 2.5 and 2.5.1 causes everything to end up in the leftover. From the compiler report it's not at all obvious why these classes are in the leftover fragment as they look isolated from what I can tell. On 12 June 2013 13:13, Ed post2edb...@gmail.com wrote: Ed, did you ever get this sorted? As I commented on the linked issue I'm running into what seems to be a similar problem. No. It's hard to track the exact cause. It tried, but had to give up (a lot of time, and not knowing exactly what happens. But it's good to see that more people are experiencing the same kind of problems such that I am not alone ;) Ray seem to be the code splitting guru. Let's hope he has has some time to look at this ;) If you can isolate the problem in a small program that reproduces this behavior, please do upload it in the issue. I tried, but failed :( This will help the gwt dev team a lot to solve the problem (and the issue will get a higher priority and solved sooner). -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to a topic in the Google Groups Google Web Toolkit group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-web-toolkit/_8CdVbBb488/unsubscribe?hl=en . To unsubscribe from this group and all its topics, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com . Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Code splittingmysteries
Ed, out of interest, are you using Gin? On 12 June 2013 16:29, James Horsley james.hors...@gmail.com wrote: Yeah. the SOYC report in this case hasn't helped me much either because I'm not reading it right or it's just not surfacing the right info. The only 404 I get is regarding the compiler metrics link. On 12 June 2013 16:18, Ed Bras post2edb...@gmail.com wrote: Yep, tried to go back to 2.5, but then I see some other bugs that are solved in 2.5.1 ;)... So for me this was no option... On Wed, Jun 12, 2013 at 5:17 PM, Ed Bras post2edb...@gmail.com wrote: Yes, I understand what you mean, I experienced the same... It's hard to hand over a test case that fails, to the dev team, such that they can use that to work on :( Yes it would be nice to have better facilities such that we can try to track done the cause our self. Currently the SOYC report isn't helping a lot. To my experience the SOYC report is buggy, as some pages result in a 404 :(.. (I experienced that several times the last years with a correctly created soyc, it's also in some issue if I remember correctly). On Wed, Jun 12, 2013 at 4:45 PM, James Horsley james.hors...@gmail.comwrote: Yeah. I've tried reproducing the issue with a sample app but thus far haven't been able to; not sure that the sample webapp captures enough of the complexity of the actual webapp we're having the problem with. As I mentioned before can confirm that changing none of the webapp code but switching between 2.5 and 2.5.1 causes everything to end up in the leftover. From the compiler report it's not at all obvious why these classes are in the leftover fragment as they look isolated from what I can tell. On 12 June 2013 13:13, Ed post2edb...@gmail.com wrote: Ed, did you ever get this sorted? As I commented on the linked issue I'm running into what seems to be a similar problem. No. It's hard to track the exact cause. It tried, but had to give up (a lot of time, and not knowing exactly what happens. But it's good to see that more people are experiencing the same kind of problems such that I am not alone ;) Ray seem to be the code splitting guru. Let's hope he has has some time to look at this ;) If you can isolate the problem in a small program that reproduces this behavior, please do upload it in the issue. I tried, but failed :( This will help the gwt dev team a lot to solve the problem (and the issue will get a higher priority and solved sooner). -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to a topic in the Google Groups Google Web Toolkit group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-web-toolkit/_8CdVbBb488/unsubscribe?hl=en . To unsubscribe from this group and all its topics, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Out of Memory during GWT compile
Can a distributed compilation get rid of this issue? Does somebody use a distributed compilation for development? http://code.google.com/p/google-web-toolkit/wiki/DistributedBuilds http://code.google.com/p/gwt-distcc/ https://github.com/markovuksanovic/gwt-distributed-compiler David On Wednesday, June 12, 2013 11:22:12 AM UTC-4, Ranjith Chungath wrote: Thanks for the reply.. Is there any other option other than increasing -XX:MaxPermSize.? Is there a compiler option that can do the memory optimization? ~Ranjith On Tuesday, June 11, 2013 11:05:44 PM UTC+5:30, Ranjith Chungath wrote: While analyzing with Eclipse Memory Analyzer(MAT), it was found that around 860MB of memory is taken by HashMap.Entry and HashMap.Entry[]. There are 1.3 million instances of HashMap.Entry objects created. See image below. https://lh4.googleusercontent.com/-01hS32-3jco/UbdeLrLCNmI/ABo/O5V7ZTHj6-k/s1600/1.png These HashMap Entries typically have keys as (com.google.gwt.dev.jjs.ast.JMethod, com.google.gwt.dev.jjs.ast.JField, com.google.gwt.dev.jjs.ast.JParameter etc.) and the value is typically an instance of java.lang.Object. https://lh4.googleusercontent.com/-AHAWKJmod2s/UbdeQ8YZ8gI/ABw/saqozlgWQm8/s1600/2.png These maps are referenced from the PermutationWorker Thread. https://lh6.googleusercontent.com/-293uEuYJK70/UbdeZDyyiUI/AB4/o86kVs5XPC4/s1600/3.png Why are so many instances on HashMap Entries created ? Is this a an existing bug or do we need to specify any flag during the GWT compile to get around this problem?https://lh6.googleusercontent.com/-293uEuYJK70/UbdeZDyyiUI/AB4/o86kVs5XPC4/s1600/3.png Thanks,https://lh6.googleusercontent.com/-293uEuYJK70/UbdeZDyyiUI/AB4/o86kVs5XPC4/s1600/3.png Ranjithhttps://lh6.googleusercontent.com/-293uEuYJK70/UbdeZDyyiUI/AB4/o86kVs5XPC4/s1600/3.png https://lh6.googleusercontent.com/-293uEuYJK70/UbdeZDyyiUI/AB4/o86kVs5XPC4/s1600/3.png https://lh6.googleusercontent.com/-293uEuYJK70/UbdeZDyyiUI/AB4/o86kVs5XPC4/s1600/3.png https://lh6.googleusercontent.com/-293uEuYJK70/UbdeZDyyiUI/AB4/o86kVs5XPC4/s1600/3.png https://lh6.googleusercontent.com/-293uEuYJK70/UbdeZDyyiUI/AB4/o86kVs5XPC4/s1600/3.png https://lh6.googleusercontent.com/-293uEuYJK70/UbdeZDyyiUI/AB4/o86kVs5XPC4/s1600/3.png https://lh6.googleusercontent.com/-293uEuYJK70/UbdeZDyyiUI/AB4/o86kVs5XPC4/s1600/3.png https://lh6.googleusercontent.com/-293uEuYJK70/UbdeZDyyiUI/AB4/o86kVs5XPC4/s1600/3.png https://lh6.googleusercontent.com/-293uEuYJK70/UbdeZDyyiUI/AB4/o86kVs5XPC4/s1600/3.png https://lh6.googleusercontent.com/-293uEuYJK70/UbdeZDyyiUI/AB4/o86kVs5XPC4/s1600/3.png https://lh6.googleusercontent.com/-293uEuYJK70/UbdeZDyyiUI/AB4/o86kVs5XPC4/s1600/3.png https://lh6.googleusercontent.com/-293uEuYJK70/UbdeZDyyiUI/AB4/o86kVs5XPC4/s1600/3.png -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Out of Memory during GWT compile
Note that distribution of the compilation is likely not going to cut down in memory much. The parallelization occurs at the permutation code generation phase, however the construction of the AST must take place first at the precompile phase. That phase is not distributed. I've not tested this, but it likely isn't the magic bullet you're after. Memory is cheap, get all that you can. :) Sincerely, Joseph -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Code splittingmysteries
No, it's not you, understanding the details of the SOYC report is hard. I thought it was easy from seeing the Google IO session some years ago, butt... ... It's definitely a step in the right direction but the soyc report still need some optimization steps to be well usable for bigger projects (then Hello world) On Wed, Jun 12, 2013 at 5:29 PM, James Horsley james.hors...@gmail.comwrote: Yeah. the SOYC report in this case hasn't helped me much either because I'm not reading it right or it's just not surfacing the right info. The only 404 I get is regarding the compiler metrics link. On 12 June 2013 16:18, Ed Bras post2edb...@gmail.com wrote: Yep, tried to go back to 2.5, but then I see some other bugs that are solved in 2.5.1 ;)... So for me this was no option... On Wed, Jun 12, 2013 at 5:17 PM, Ed Bras post2edb...@gmail.com wrote: Yes, I understand what you mean, I experienced the same... It's hard to hand over a test case that fails, to the dev team, such that they can use that to work on :( Yes it would be nice to have better facilities such that we can try to track done the cause our self. Currently the SOYC report isn't helping a lot. To my experience the SOYC report is buggy, as some pages result in a 404 :(.. (I experienced that several times the last years with a correctly created soyc, it's also in some issue if I remember correctly). On Wed, Jun 12, 2013 at 4:45 PM, James Horsley james.hors...@gmail.comwrote: Yeah. I've tried reproducing the issue with a sample app but thus far haven't been able to; not sure that the sample webapp captures enough of the complexity of the actual webapp we're having the problem with. As I mentioned before can confirm that changing none of the webapp code but switching between 2.5 and 2.5.1 causes everything to end up in the leftover. From the compiler report it's not at all obvious why these classes are in the leftover fragment as they look isolated from what I can tell. On 12 June 2013 13:13, Ed post2edb...@gmail.com wrote: Ed, did you ever get this sorted? As I commented on the linked issue I'm running into what seems to be a similar problem. No. It's hard to track the exact cause. It tried, but had to give up (a lot of time, and not knowing exactly what happens. But it's good to see that more people are experiencing the same kind of problems such that I am not alone ;) Ray seem to be the code splitting guru. Let's hope he has has some time to look at this ;) If you can isolate the problem in a small program that reproduces this behavior, please do upload it in the issue. I tried, but failed :( This will help the gwt dev team a lot to solve the problem (and the issue will get a higher priority and solved sooner). -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to a topic in the Google Groups Google Web Toolkit group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-web-toolkit/_8CdVbBb488/unsubscribe?hl=en . To unsubscribe from this group and all its topics, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to a topic in the Google Groups Google Web Toolkit group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-web-toolkit/_8CdVbBb488/unsubscribe?hl=en . To unsubscribe from this group and all its topics, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe
Re: Code splittingmysteries
Ed, out of interest, are you using Gin? No, but probably would use it if I would start blank. When I started with GWT (about 7 years ago), there was no GIN, so I had to make my own thinks like factories, which I use nowadays . This all resulted in having build my own rich gwt framework/lib, which I am happy about thought, works well.. But in general I am careful using external gwt lib's there are many out there being not maintained anymore, which can result in gwt upgrade problems.. I started out with mygwt, contributed some things... but then It became gxt and became half commercial :( -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: drag and drop group
based on html5 spec, the way to disallow a drop is to return true inside
dragover
function dragOver(ev) {
return true;
}
but in GWT, the dragover hander has a void return type. there is no way to
return anything.
panel1.addBitlessDomHandler(new DragOverHandler() {
@Override
public void onDragOver(DragOverEvent event) {
// can not return anything.
}
}, DragOverEvent.getType());
It is quite possible, GWT implementation simply messed this one up.
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fix for 8188 (http://code.google.com/p/google-web-toolkit/is...
Thomas Broyer has posted comments on this change. Change subject: Fix for 8188 (http://code.google.com/p/google-web-toolkit/issues/detail?id=8188) .. Patch Set 1: Code-Review+1 (3 comments) Commit Message Line 7: Fix for 8188 Please describe what the change is about. E.g. Log excluded resources in DirectoryClassPathEntry the same way as ZipFileClassPathEntry (we should add something to the makinggwtbetter page) Line 8: (http://code.google.com/p/google-web-toolkit/issues/detail?id=8188) If you use issue 8188, Gerrit will linkify it. Even better, if you use: Bug: issue 8188 as a footer line (next to Change-Id, no blank line between them, but blank line before the footer) the review will be searchable with tr:8188 in Gerrit. File dev/core/src/com/google/gwt/dev/resource/impl/DirectoryClassPathEntry.java Line 39: Trailing space; strange that it passed checkstyle… -- To view, visit https://gwt-review.googlesource.com/3380 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c25c0e486e02a3b5ed1a8804d5276cebc0877c6 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Denis Anisimov de...@vaadin.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fix for 8188 (http://code.google.com/p/google-web-toolkit/is...
Daniel Kurka has posted comments on this change. Change subject: Fix for 8188 (http://code.google.com/p/google-web-toolkit/issues/detail?id=8188) .. Patch Set 1: Code-Review+1 LGTM to me, but please address Thomas comments. -- To view, visit https://gwt-review.googlesource.com/3380 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c25c0e486e02a3b5ed1a8804d5276cebc0877c6 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Denis Anisimov de...@vaadin.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Use correct return types for createFooInputBuilder() methods...
Thomas Broyer has posted comments on this change. Change subject: Use correct return types for createFooInputBuilder() methods in HtmlBuilderFactory. Also adjust the return types of affected methods in HtmlBuilderImpl. .. Patch Set 2: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/3331 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c8d711a04021deeb83ea8672203c2a36239ccbc Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Tom Wieczorek t...@bibbu.net Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fixes a NPE in RF when returning a null entity while the cli...
Thomas Broyer has submitted this change and it was merged.
Change subject: Fixes a NPE in RF when returning a null entity while the
client used .with().
..
Fixes a NPE in RF when returning a null entity while the client
used .with().
Fixes issue 8104
Change-Id: I07c4b6d94fd063d76f205070047fd5f9e32c190b
---
M user/src/com/google/web/bindery/requestfactory/server/Resolver.java
M
user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java
2 files changed, 7 insertions(+), 3 deletions(-)
Approvals:
Manuel Carrasco Moñino: Looks good to me, but someone else must approve
Matthew Dempsky: Verified
Roberto Lublinerman: Looks good to me, approved
Leeroy Jenkins: Verified
diff --git
a/user/src/com/google/web/bindery/requestfactory/server/Resolver.java
b/user/src/com/google/web/bindery/requestfactory/server/Resolver.java
index 4658066..764ccc5 100644
--- a/user/src/com/google/web/bindery/requestfactory/server/Resolver.java
+++ b/user/src/com/google/web/bindery/requestfactory/server/Resolver.java
@@ -586,7 +586,7 @@
*/
private Resolution resolveClientValue(Object domainValue, Type
clientType) {
if (domainValue == null) {
- return new Resolution(null);
+ return null;
}
boolean anyType = clientType == null;
@@ -634,7 +634,8 @@
Type elementType =
TypeUtils.getSingleParameterization(Collection.class, clientType);
for (Object o : (Collection?) domainValue) {
-accumulator.add(resolveClientValue(o,
elementType).getClientObject());
+Resolution resolution = resolveClientValue(o, elementType);
+accumulator.add(resolution == null ? null :
resolution.getClientObject());
}
return makeResolution(accumulator);
}
diff --git
a/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java
b/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java
index caf6670..daec56e 100644
---
a/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java
+++
b/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java
@@ -1272,10 +1272,13 @@
/**
* Ensures that a service method can respond with a null value.
+ * p
+ * Also tests that using a with() works as expected; see
+ * https://code.google.com/p/google-web-toolkit/issues/detail?id=8104
*/
public void testNullEntityProxyResult() {
delayTestFinish(DELAY_TEST_FINISH);
-simpleFooRequest().returnNullSimpleFoo().fire(new NullReceiver());
+simpleFooRequest().returnNullSimpleFoo().with(fooField).fire(new
NullReceiver());
}
public void testNullEntityFieldResult() {
--
To view, visit https://gwt-review.googlesource.com/2570
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I07c4b6d94fd063d76f205070047fd5f9e32c190b
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer t.bro...@gmail.com
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org
Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add interfaces for widgets.
Thomas Broyer has posted comments on this change.
Change subject: Add interfaces for widgets.
..
Patch Set 6:
(4 comments)
I've only looked at a few files.
File user/src/com/google/gwt/user/client/ui/IndexedPanel.java
Line 34:* Extends this interface with convenience methods to handle
{@link IsWidget}.
IsWidget2 ?
File user/src/com/google/gwt/user/client/ui/IsImage.java
Line 34: void setUrl(String url);
Do we really want to expose those unsafe methods? Shouldn't we try to make
people use SafeUri instead?
File user/src/com/google/gwt/user/client/ui/IsUIObject.java
Line 27: IsElement getIsElement();
Given that Element implements IsElement, and we already have getElement(),
couldn't we just declare
IsElement getElement();
here and take advantage of covariant return types in UIObject?
File user/src/com/google/gwt/user/client/ui/Panel.java
Line 118: return new IsWidgetIteratorAdaptor(iterator());
Given that Widget implements IsWidget2 could we just take advantage of type
erasure and do an unchecked cast?
return (IteratorIsWidget2) ((Iterator) iterator());
--
To view, visit https://gwt-review.googlesource.com/3231
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd17162d37e367720829bcdaf9a350e446c833b9
Gerrit-PatchSet: 6
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.
Thomas Broyer has submitted this change and it was merged.
Change subject: Removes api-checker reference JARs from the source tree.
..
Removes api-checker reference JARs from the source tree.
Now expects them in GWT_TOOLS.
Bug: issue 8031
Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879
---
M build.xml
D tools/api-checker/reference/README
D tools/api-checker/reference/createApiCheckerReferenceJars.sh
D tools/api-checker/reference/gwt-dev-modified.jar
D tools/api-checker/reference/gwt-user-modified.jar
5 files changed, 3 insertions(+), 46 deletions(-)
Approvals:
Matthew Dempsky: Looks good to me, approved
Leeroy Jenkins: Verified
diff --git a/build.xml b/build.xml
index c783631..0726332 100755
--- a/build.xml
+++ b/build.xml
@@ -32,6 +32,8 @@
property name=gwt.apicheck.config
location=tools/api-checker/config/gwt25_26userApi.conf/
+ property name=gwt.apicheck.referencelibs
+
value=${gwt.tools}/api-checker-reference/2.5.1/gwt-dev-modified.jar:${gwt.tools}/api-checker-reference/2.5.1/gwt-user-modified.jar/
target name=buildonly
description=[action] Minimal one-platform devel build, without
distro packaging
@@ -206,7 +208,7 @@
pathelement location=${gwt.tools.lib}/apache/ant-1.6.5.jar /
/classpath
arg value=-refJar/
- arg
path=${gwt.root}/tools/api-checker/reference/gwt-dev-modified.jar:${gwt.root}/tools/api-checker/reference/gwt-user-modified.jar/
+ arg path=${gwt.apicheck.referencelibs}/
arg value=-configFile/
arg file=${gwt.apicheck.config}/
arg value=-logLevel/
diff --git a/tools/api-checker/reference/README
b/tools/api-checker/reference/README
deleted file mode 100644
index ebf6477..000
--- a/tools/api-checker/reference/README
+++ /dev/null
@@ -1,10 +0,0 @@
-gwt-dev.jar and gwt-user.jar were extracted from
http://google-web-toolkit.googlecode.com/files/gwt-2.5.1-rc1.zip
-
-Steps:
-1. Unzip the GWT zip file
-2. Copy gwt-dev.jar and gwt-user.jar into this directory
-3. Delete gwt-dev-modified.jar and gwt-user-modified.jar from this
directory
-4. run ./createApiCheckerReferenceJars.sh
- - Ignore the benign error about finding com/google/web. The directory
only exists in gwt-user.
-5. Delete gwt-dev.jar and gwt-user.jar from this directory
-6. Commit the new gwt-dev-modified.jar and gwt-user-modified.jar
diff --git a/tools/api-checker/reference/createApiCheckerReferenceJars.sh
b/tools/api-checker/reference/createApiCheckerReferenceJars.sh
deleted file mode 100755
index eb38787..000
--- a/tools/api-checker/reference/createApiCheckerReferenceJars.sh
+++ /dev/null
@@ -1,35 +0,0 @@
-#!/bin/bash
-
-showhelp() {
- echo 2 usage: ./createModifiedJars.sh
- echo 2 (1) checks for the existence of gwt-dev.jar and gwt-user.jar
- echo 2 (2) creates gwt-dev-modified.jar and gwt-user-modified.jar (to
be used by api-checker) by only including .java files in com/google/gwt
- exit 1
-}
-
-for file in gwt-dev.jar gwt-user.jar
-do
- if [ ! -f $file ]
- then
-echo [$file] not found - Aborting
-showhelp
- fi
-done
-
-# unpack files in a temporary dir, create a new jar file with only .java
files in com/google/gwt
-for file in gwt-dev.jar gwt-user.jar
-do
- TEMP_DIR=tmp
- rm -rf ${TEMP_DIR}
- mkdir ${TEMP_DIR}
- cd ${TEMP_DIR}
- jar -xf ../${file}
- MODIFIED_FILE=gwt-user-modified.jar
- if [ $file != gwt-user.jar ]
- then
-MODIFIED_FILE=gwt-dev-modified.jar
- fi
- jar -cf ../${MODIFIED_FILE} `find com/google/gwt -name *.java` `find
com/google/web -name *.java`
- cd ..
- rm -rf ${TEMP_DIR}
-done
diff --git a/tools/api-checker/reference/gwt-dev-modified.jar
b/tools/api-checker/reference/gwt-dev-modified.jar
deleted file mode 100644
index 18ab2bb..000
--- a/tools/api-checker/reference/gwt-dev-modified.jar
+++ /dev/null
Binary files differ
diff --git a/tools/api-checker/reference/gwt-user-modified.jar
b/tools/api-checker/reference/gwt-user-modified.jar
deleted file mode 100644
index 5a4a5c8..000
--- a/tools/api-checker/reference/gwt-user-modified.jar
+++ /dev/null
Binary files differ
--
To view, visit https://gwt-review.googlesource.com/2500
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer t.bro...@gmail.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed
[gwt-contrib] Change in gwt[master]: Make sure JUnit's host page run in UTF-8.
Thomas Broyer has submitted this change and it was merged.
Change subject: Make sure JUnit's host page run in UTF-8.
..
Make sure JUnit's host page run in UTF-8.
Bug: issue 8171
Change-Id: Iede26ae4928600473f56e11387e433565486e4e0
---
M user/src/com/google/gwt/junit/public/junit-standards.html
M user/src/com/google/gwt/junit/public/junit.html
M user/test/com/google/gwt/core/client/ScriptInjectorTest.java
A user/test/com/google/gwt/core/public/script_injector_test_utf8.js
M user/test/com/google/gwt/module/ModuleSuite.java
A user/test/com/google/gwt/module/ScriptInjectionEncodingTest.gwt.xml
A user/test/com/google/gwt/module/client/ScriptInjectionEncodingTest.java
A
user/test/com/google/gwt/module/public/script-encoding/ScriptInjectionEncodingTest.js
8 files changed, 106 insertions(+), 0 deletions(-)
Approvals:
Leeroy Jenkins: Verified
Goktug Gokdogan: Looks good to me, approved
diff --git a/user/src/com/google/gwt/junit/public/junit-standards.html
b/user/src/com/google/gwt/junit/public/junit-standards.html
index 3a7f301..406447f 100644
--- a/user/src/com/google/gwt/junit/public/junit-standards.html
+++ b/user/src/com/google/gwt/junit/public/junit-standards.html
@@ -16,6 +16,7 @@
--
html
head
+meta http-equiv='Content-Type' content='text/html;charset=utf-8'
meta name='gwt:onLoadErrorFn' content='junitOnLoadErrorFn'
meta name='gwt:onPropertyErrorFn' content='junitOnPropertyErrorFn'
meta http-equiv=X-UA-Compatible content=IE=9;
diff --git a/user/src/com/google/gwt/junit/public/junit.html
b/user/src/com/google/gwt/junit/public/junit.html
index 77e0b75..155ce90 100644
--- a/user/src/com/google/gwt/junit/public/junit.html
+++ b/user/src/com/google/gwt/junit/public/junit.html
@@ -15,6 +15,7 @@
--
html
head
+meta http-equiv='Content-Type' content='text/html;charset=utf-8'
meta name='gwt:onLoadErrorFn' content='junitOnLoadErrorFn'
meta name='gwt:onPropertyErrorFn' content='junitOnPropertyErrorFn'
/head
diff --git a/user/test/com/google/gwt/core/client/ScriptInjectorTest.java
b/user/test/com/google/gwt/core/client/ScriptInjectorTest.java
index f245a1c..f25347c 100644
--- a/user/test/com/google/gwt/core/client/ScriptInjectorTest.java
+++ b/user/test/com/google/gwt/core/client/ScriptInjectorTest.java
@@ -336,6 +336,39 @@
assertNotNull(injectedElement);
}
+ /**
+ * Tests encoding of the injected script (UTF-8)
+ */
+ public void testInjectUrlUtf8() {
+delayTestFinish(TEST_DELAY);
+final String scriptUrl = script_injector_test_utf8.js;
+assertEquals(, nativeGetTestUtf8Var());
+JavaScriptObject injectedElement =
ScriptInjector.fromUrl(scriptUrl).setRemoveTag(false)
+.setWindow(ScriptInjector.TOP_WINDOW).setCallback(
+new CallbackVoid, Exception() {
+
+ @Override
+ public void onFailure(Exception reason) {
+assertNotNull(reason);
+fail(Injection failed: + reason.toString());
+ }
+
+ @Override
+ public void onSuccess(Void result) {
+String testVar = nativeGetTestUtf8Var();
+JavaScriptObject scriptElement =
findScriptUrlInTopWindow(scriptUrl);
+if (!isIE()) {
+ cleanupTopWindow(__ti_utf8_var__, scriptElement);
+ assertEquals(cleanup failed, ,
nativeGetTestUtf8Var());
+}
+assertEquals(__ti_utf8_var not set in top window, Ã ,
testVar);
+assertNotNull(script element not found, scriptElement);
+finishTest();
+ }
+}).inject();
+assertNotNull(injectedElement);
+ }
+
private void cleanupThisWindow(String property, JavaScriptObject
scriptElement) {
cleanupWindow(nativeThisWindow(), property, scriptElement);
}
@@ -427,6 +460,10 @@
return !!$wnd[__ti7_var__] $wnd[__ti7_var__] == 7;
}-*/;
+ private native String nativeGetTestUtf8Var() /*-{
+return $wnd[__ti_utf8_var__] || ;
+ }-*/;
+
private native JavaScriptObject nativeThisWindow() /*-{
return window;
}-*/;
diff --git
a/user/test/com/google/gwt/core/public/script_injector_test_utf8.js
b/user/test/com/google/gwt/core/public/script_injector_test_utf8.js
new file mode 100644
index 000..028b4eb
--- /dev/null
+++ b/user/test/com/google/gwt/core/public/script_injector_test_utf8.js
@@ -0,0 +1 @@
+__ti_utf8_var__ = Ã ;
\ No newline at end of file
diff --git a/user/test/com/google/gwt/module/ModuleSuite.java
b/user/test/com/google/gwt/module/ModuleSuite.java
index ab4852b..b88a8ad 100644
--- a/user/test/com/google/gwt/module/ModuleSuite.java
+++ b/user/test/com/google/gwt/module/ModuleSuite.java
@@ -19,6 +19,7 @@
import com.google.gwt.module.client.ConfigurationPropertiesTest;
import com.google.gwt.module.client.DoubleScriptInjectionTest;
import com.google.gwt.module.client.NoDeployTest;
+import
[gwt-contrib] Change in gwt[master]: Cut circular dependency between c.g.g.core.linker and c.g.g....
Thomas Broyer has posted comments on this change. Change subject: Cut circular dependency between c.g.g.core.linker and c.g.g.dev.js .. Patch Set 1: (1 comment) File dev/core/src/com/google/gwt/util/tools/shared/StringUtils.java Line 81: escape = 'n'; This code emits a JS string literal, not JS code: a \n in the Java string has to be output as a \\n in the JS string literal. -- To view, visit https://gwt-review.googlesource.com/1031 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id33cdf94725981c9c5779553444c1ac64659892c Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Use correct return types for createFooInputBuilder() methods...
Thomas Broyer has submitted this change and it was merged.
Change subject: Use correct return types for createFooInputBuilder()
methods in HtmlBuilderFactory. Also adjust the return types of affected
methods in HtmlBuilderImpl.
..
Use correct return types for createFooInputBuilder() methods in
HtmlBuilderFactory.
Also adjust the return types of affected methods in HtmlBuilderImpl.
Bug: Issue 8070
Change-Id: I9c8d711a04021deeb83ea8672203c2a36239ccbc
---
M tools/api-checker/config/gwt25_26userApi.conf
M user/src/com/google/gwt/dom/builder/shared/HtmlBuilderFactory.java
M user/src/com/google/gwt/dom/builder/shared/HtmlBuilderImpl.java
3 files changed, 33 insertions(+), 21 deletions(-)
Approvals:
Leeroy Jenkins: Verified
Thomas Broyer: Looks good to me, approved
diff --git a/tools/api-checker/config/gwt25_26userApi.conf
b/tools/api-checker/config/gwt25_26userApi.conf
index 82d5a92..1071419 100644
--- a/tools/api-checker/config/gwt25_26userApi.conf
+++ b/tools/api-checker/config/gwt25_26userApi.conf
@@ -172,3 +172,15 @@
com.google.gwt.dom.client.ObjectElement::setData(Ljava/lang/String;)
OVERLOADED_METHOD_CALL
com.google.gwt.dom.client.QuoteElement::setCite(Ljava/lang/String;)
OVERLOADED_METHOD_CALL
com.google.gwt.user.client.ui.Anchor::setHref(Ljava/lang/String;)
OVERLOADED_METHOD_CALL
+
+# Let HtmlBuilderFactory return HtmlInputBuilders instead of just
InputBuilders
+com.google.gwt.dom.builder.shared.HtmlBuilderFactory::createButtonInputBuilder()
OVERRIDABLE_METHOD_RETURN_TYPE_CHANGE
+com.google.gwt.dom.builder.shared.HtmlBuilderFactory::createCheckboxInputBuilder()
OVERRIDABLE_METHOD_RETURN_TYPE_CHANGE
+com.google.gwt.dom.builder.shared.HtmlBuilderFactory::createFileInputBuilder()
OVERRIDABLE_METHOD_RETURN_TYPE_CHANGE
+com.google.gwt.dom.builder.shared.HtmlBuilderFactory::createHiddenInputBuilder()
OVERRIDABLE_METHOD_RETURN_TYPE_CHANGE
+com.google.gwt.dom.builder.shared.HtmlBuilderFactory::createImageInputBuilder()
OVERRIDABLE_METHOD_RETURN_TYPE_CHANGE
+com.google.gwt.dom.builder.shared.HtmlBuilderFactory::createPasswordInputBuilder()
OVERRIDABLE_METHOD_RETURN_TYPE_CHANGE
+com.google.gwt.dom.builder.shared.HtmlBuilderFactory::createRadioInputBuilder(Ljava/lang/String;)
OVERRIDABLE_METHOD_RETURN_TYPE_CHANGE
+com.google.gwt.dom.builder.shared.HtmlBuilderFactory::createResetInputBuilder()
OVERRIDABLE_METHOD_RETURN_TYPE_CHANGE
+com.google.gwt.dom.builder.shared.HtmlBuilderFactory::createSubmitInputBuilder()
OVERRIDABLE_METHOD_RETURN_TYPE_CHANGE
+com.google.gwt.dom.builder.shared.HtmlBuilderFactory::createTextInputBuilder()
OVERRIDABLE_METHOD_RETURN_TYPE_CHANGE
diff --git
a/user/src/com/google/gwt/dom/builder/shared/HtmlBuilderFactory.java
b/user/src/com/google/gwt/dom/builder/shared/HtmlBuilderFactory.java
index 6a74146..9605032 100644
--- a/user/src/com/google/gwt/dom/builder/shared/HtmlBuilderFactory.java
+++ b/user/src/com/google/gwt/dom/builder/shared/HtmlBuilderFactory.java
@@ -85,7 +85,7 @@
}
@Override
- public InputBuilder createButtonInputBuilder() {
+ public HtmlInputBuilder createButtonInputBuilder() {
return impl().startButtonInput();
}
@@ -95,7 +95,7 @@
}
@Override
- public InputBuilder createCheckboxInputBuilder() {
+ public HtmlInputBuilder createCheckboxInputBuilder() {
return impl().startCheckboxInput();
}
@@ -125,7 +125,7 @@
}
@Override
- public InputBuilder createFileInputBuilder() {
+ public HtmlInputBuilder createFileInputBuilder() {
return impl().startFileInput();
}
@@ -180,7 +180,7 @@
}
@Override
- public InputBuilder createHiddenInputBuilder() {
+ public HtmlInputBuilder createHiddenInputBuilder() {
return impl().startHiddenInput();
}
@@ -200,7 +200,7 @@
}
@Override
- public InputBuilder createImageInputBuilder() {
+ public HtmlInputBuilder createImageInputBuilder() {
return impl().startImageInput();
}
@@ -260,7 +260,7 @@
}
@Override
- public InputBuilder createPasswordInputBuilder() {
+ public HtmlInputBuilder createPasswordInputBuilder() {
return impl().startPasswordInput();
}
@@ -280,7 +280,7 @@
}
@Override
- public InputBuilder createRadioInputBuilder(String name) {
+ public HtmlInputBuilder createRadioInputBuilder(String name) {
return impl().startRadioInput(name);
}
@@ -290,7 +290,7 @@
}
@Override
- public InputBuilder createResetInputBuilder() {
+ public HtmlInputBuilder createResetInputBuilder() {
return impl().startResetInput();
}
@@ -325,7 +325,7 @@
}
@Override
- public InputBuilder createSubmitInputBuilder() {
+ public HtmlInputBuilder createSubmitInputBuilder() {
return impl().startSubmitInput();
}
@@ -355,7 +355,7 @@
}
@Override
- public InputBuilder createTextInputBuilder() {
+ public HtmlInputBuilder createTextInputBuilder() {
return impl().startTextInput();
}
diff --git
[gwt-contrib] Change in gwt[master]: Cut circular dependency between c.g.g.core.linker and c.g.g....
Hello Manuel Carrasco Moñino, Matthew Dempsky, Roberto Lublinerman, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/1031 to look at the new patch set (#2). Change subject: Cut circular dependency between c.g.g.core.linker and c.g.g.dev.js .. Cut circular dependency between c.g.g.core.linker and c.g.g.dev.js Change-Id: Id33cdf94725981c9c5779553444c1ac64659892c --- M dev/core/src/com/google/gwt/core/linker/CrossSiteIframeLinker.java M dev/core/src/com/google/gwt/core/linker/XSLinker.java M dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java M dev/core/src/com/google/gwt/util/tools/shared/StringUtils.java R dev/core/test/com/google/gwt/util/tools/shared/JavaScriptStringTest.java 5 files changed, 144 insertions(+), 149 deletions(-) -- To view, visit https://gwt-review.googlesource.com/1031 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id33cdf94725981c9c5779553444c1ac64659892c Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Cut circular dependency between c.g.g.core.linker and c.g.g....
Thomas Broyer has posted comments on this change. Change subject: Cut circular dependency between c.g.g.core.linker and c.g.g.dev.js .. Patch Set 2: Code-Review+2 Roberto gave a +2 on patchset 1, and patchset 2 is a simple rebase (no conflict resolution) -- To view, visit https://gwt-review.googlesource.com/1031 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id33cdf94725981c9c5779553444c1ac64659892c Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Cut circular dependency between c.g.g.core.linker and c.g.g....
Thomas Broyer has submitted this change and it was merged.
Change subject: Cut circular dependency between c.g.g.core.linker and
c.g.g.dev.js
..
Cut circular dependency between c.g.g.core.linker and c.g.g.dev.js
Change-Id: Id33cdf94725981c9c5779553444c1ac64659892c
---
M dev/core/src/com/google/gwt/core/linker/CrossSiteIframeLinker.java
M dev/core/src/com/google/gwt/core/linker/XSLinker.java
M dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java
M dev/core/src/com/google/gwt/util/tools/shared/StringUtils.java
R dev/core/test/com/google/gwt/util/tools/shared/JavaScriptStringTest.java
5 files changed, 144 insertions(+), 149 deletions(-)
Approvals:
Leeroy Jenkins: Verified
Thomas Broyer: Looks good to me, approved
diff --git
a/dev/core/src/com/google/gwt/core/linker/CrossSiteIframeLinker.java
b/dev/core/src/com/google/gwt/core/linker/CrossSiteIframeLinker.java
index c7f0128..3253174 100644
--- a/dev/core/src/com/google/gwt/core/linker/CrossSiteIframeLinker.java
+++ b/dev/core/src/com/google/gwt/core/linker/CrossSiteIframeLinker.java
@@ -33,12 +33,12 @@
import com.google.gwt.core.ext.linker.impl.ResourceInjectionUtil;
import com.google.gwt.core.ext.linker.impl.SelectionScriptLinker;
import com.google.gwt.dev.About;
-import com.google.gwt.dev.js.JsToStringGenerationVisitor;
import com.google.gwt.dev.util.DefaultTextOutput;
import com.google.gwt.dev.util.TextOutput;
import com.google.gwt.thirdparty.guava.common.base.Joiner;
import com.google.gwt.thirdparty.guava.common.base.Splitter;
import com.google.gwt.util.tools.Utility;
+import com.google.gwt.util.tools.shared.StringUtils;
import java.io.IOException;
import java.util.ArrayList;
@@ -584,7 +584,7 @@
return String.format($wnd.%s.runAsyncCallback%d(%s)\n,
context.getModuleFunctionName(),
fragment,
-JsToStringGenerationVisitor.javaScriptString(js));
+StringUtils.javaScriptString(js));
}
@Override
@@ -608,7 +608,7 @@
IterableString chunks =
Splitter.on(getScriptChunkSeparator(logger, context)).split(script);
ListString newChunks = new ArrayListString();
for (String chunk : chunks) {
-newChunks.add(JsToStringGenerationVisitor.javaScriptString(chunk));
+newChunks.add(StringUtils.javaScriptString(chunk));
}
out.append(Joiner.on(,\n).join(newChunks));
out.append(]);\n);
diff --git a/dev/core/src/com/google/gwt/core/linker/XSLinker.java
b/dev/core/src/com/google/gwt/core/linker/XSLinker.java
index b6b2641..d379794 100644
--- a/dev/core/src/com/google/gwt/core/linker/XSLinker.java
+++ b/dev/core/src/com/google/gwt/core/linker/XSLinker.java
@@ -23,8 +23,8 @@
import com.google.gwt.core.ext.linker.Shardable;
import com.google.gwt.core.ext.linker.impl.SelectionScriptLinker;
import com.google.gwt.dev.About;
-import com.google.gwt.dev.js.JsToStringGenerationVisitor;
import com.google.gwt.dev.util.DefaultTextOutput;
+import com.google.gwt.util.tools.shared.StringUtils;
/**
* Generates a cross-site compatible bootstrap sequence.
@@ -88,7 +88,7 @@
return String.format(%s.runAsyncCallback%d(%s)\n,
context.getModuleFunctionName(),
fragment,
-JsToStringGenerationVisitor.javaScriptString(js));
+StringUtils.javaScriptString(js));
}
private String getModulePrefix(LinkerContext context, String strongName,
diff --git
a/dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java
b/dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java
index 55fab01..26c1bb8 100644
--- a/dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java
+++ b/dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java
@@ -73,6 +73,7 @@
import com.google.gwt.dev.js.ast.JsWhile;
import com.google.gwt.dev.util.TextOutput;
import com.google.gwt.dev.util.collect.HashSet;
+import com.google.gwt.util.tools.shared.StringUtils;
import java.util.ArrayList;
import java.util.Iterator;
@@ -109,10 +110,6 @@
private static final char[] CHARS_TRY = try.toCharArray();
private static final char[] CHARS_VAR = var.toCharArray();
private static final char[] CHARS_WHILE = while.toCharArray();
- private static final char[] HEX_DIGITS = {
- '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'A', 'B', 'C', 'D',
- 'E', 'F'};
-
/**
* How many lines of code to print inside of a JsBlock when printing
terse.
*/
@@ -125,135 +122,6 @@
* surround those names with quotes in property initializers to be safe.
*/
private static final Pattern VALID_NAME_PATTERN =
Pattern.compile([a-zA-Z_$][\\w$]*);
-
- /**
- * Generate JavaScript code that evaluates to the supplied string.
Adapted
- * from {@link
com.google.gwt.dev.js.rhino.ScriptRuntime#escapeString(String)}
- * . The difference is that we quote with either quot; or apos;
depending on
- * which one is used less
[gwt-contrib] Change in gwt[master]: Bug: issue 8188 Log excluded resources in DirectoryClassPath...
Thomas Broyer has posted comments on this change. Change subject: Bug: issue 8188 Log excluded resources in DirectoryClassPathEntry the same way as ZipFileClassPathEntry .. Patch Set 2: (2 comments) Sorry for being nit-picky but it really makes for a more readable Git history. Commit Message Line 7: Bug: issue 8188 Could you move that line just next to the Change-Id one? (with no blank line between them, but with a blank line before them) Log excluded resources in DirectoryClassPathEntry the same way as ZipFileClassPathEntry Bug: issue 8188 Change-Id: I7c25c0e486e02a3b5ed1a8804d5276cebc0877c6 File dev/core/src/com/google/gwt/dev/resource/impl/DirectoryClassPathEntry.java Line 39: Trailing space. -- To view, visit https://gwt-review.googlesource.com/3380 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c25c0e486e02a3b5ed1a8804d5276cebc0877c6 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Denis Anisimov de...@vaadin.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add show relative to Element in PopupPanel
Hello Leeroy Jenkins, Thomas Broyer, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3340 to look at the new patch set (#2). Change subject: Add show relative to Element in PopupPanel .. Add show relative to Element in PopupPanel fixes issue 6006 Change-Id: I8991b1cb1c3ec4ecabd299ee4c5bf4e5992e4b5e --- M tools/api-checker/config/gwt25_26userApi.conf M user/src/com/google/gwt/user/client/ui/PopupPanel.java 2 files changed, 20 insertions(+), 3 deletions(-) -- To view, visit https://gwt-review.googlesource.com/3340 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8991b1cb1c3ec4ecabd299ee4c5bf4e5992e4b5e Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka danku...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Log excluded resources in DirectoryClassPathEntry the same w...
Thomas Broyer has posted comments on this change. Change subject: Log excluded resources in DirectoryClassPathEntry the same way as ZipFileClassPathEntry .. Patch Set 3: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/3380 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c25c0e486e02a3b5ed1a8804d5276cebc0877c6 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Denis Anisimov de...@vaadin.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Log excluded resources in DirectoryClassPathEntry the same w...
Thomas Broyer has submitted this change and it was merged.
Change subject: Log excluded resources in DirectoryClassPathEntry the same
way as ZipFileClassPathEntry
..
Log excluded resources in DirectoryClassPathEntry the same way as
ZipFileClassPathEntry
Bug: issue 8188
Change-Id: I7c25c0e486e02a3b5ed1a8804d5276cebc0877c6
---
M dev/core/src/com/google/gwt/dev/resource/impl/DirectoryClassPathEntry.java
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Leeroy Jenkins: Verified
Thomas Broyer: Looks good to me, approved
diff --git
a/dev/core/src/com/google/gwt/dev/resource/impl/DirectoryClassPathEntry.java
b/dev/core/src/com/google/gwt/dev/resource/impl/DirectoryClassPathEntry.java
index 315fcd9..ec0b668 100644
---
a/dev/core/src/com/google/gwt/dev/resource/impl/DirectoryClassPathEntry.java
+++
b/dev/core/src/com/google/gwt/dev/resource/impl/DirectoryClassPathEntry.java
@@ -36,6 +36,9 @@
static final Message1String INCLUDING_FILE = new Message1String(
TreeLogger.DEBUG, Including file: $0);
+
+static final Message1String EXCLUDING_FILE = new Message1String(
+TreeLogger.DEBUG, Excluding file: $0);
}
/**
@@ -119,6 +122,9 @@
FileResource r = new FileResource(this, childPath, child);
results.get(i).put(r, prefix);
}
+ else {
+Messages.EXCLUDING_FILE.log(logger, childPath, null);
+ }
}
}
}
--
To view, visit https://gwt-review.googlesource.com/3380
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7c25c0e486e02a3b5ed1a8804d5276cebc0877c6
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Denis Anisimov de...@vaadin.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Log excluded resources in DirectoryClassPathEntry the same w...
Thomas Broyer has posted comments on this change. Change subject: Log excluded resources in DirectoryClassPathEntry the same way as ZipFileClassPathEntry .. Patch Set 4: Thanks! -- To view, visit https://gwt-review.googlesource.com/3380 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c25c0e486e02a3b5ed1a8804d5276cebc0877c6 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Denis Anisimov de...@vaadin.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Real branched logger is passed to the ResourceOracleImpl.ref...
Thomas Broyer has posted comments on this change. Change subject: Real branched logger is passed to the ResourceOracleImpl.refresh() method instead of TreeLogger.NULL .. Patch Set 2: (4 comments) An alternative would be to reintroduce a TreeLogger argument to the refresh() method (it was removed when the lazyResourceOracle was introduced), store it along with the needsRefresh flag, and later use it in doRefresh. And maybe also add a TreeLogger argument to getResourcesOracle. That way, the log is in the branch for the code that called refresh(), rather than repeatedly appended to the branch for the code that created the ModuleDef. File dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java Line 408: lazyResourcesOracle = new ResourceOracleImpl(TreeLogger.NULL, resources); Any reason that one is still NULL? (I have no single idea what it is used for) Line 419: logger.branch(Type.DEBUG, Computing available + resources for resource oracle); No need for the concatenation (I suspect auto-format played with your code; auto-format is evil) Line 592: TreeLogger refreshLogger = TreeLogger.NULL; Could you factor this into a getRefreshLogger method? File dev/core/src/com/google/gwt/dev/cfg/ModuleDefLoader.java Line 152: Event moduleDefLoadFromClassPathEvent = Please avoid reformats that are independent from the issue being fixed. (either disable auto-format or use an interactive git add) -- To view, visit https://gwt-review.googlesource.com/3381 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c0417882b002d12eb1c5e98ce865607a78a682a Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Denis Anisimov de...@vaadin.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds Timer#isRunning().
Daniel Kurka has posted comments on this change. Change subject: Adds Timer#isRunning(). .. Patch Set 2: (3 comments) File user/src/com/google/gwt/user/client/Timer.java Line 110: throw new IllegalArgumentException(must be non-negative); can we unify the IllegalArgumentExceptions in schedule and scheduleRepeating as well? 0 vs. =0 Line 151: Shouldn't timer.isRunning be true if the timer code is executing. How about we defer update until after run has been called? Maybe even add a test for this File user/test/com/google/gwt/user/client/TimerTest.java Line 86: // Issue https://code.google.com/p/google-web-toolkit/issues/detail?id=8101 I am not sure if this sufficiently tests fur bug 8101. To me this reads like IE must have added the timer to the event loop already, so I think we actually need a busy wait here to test for that -- To view, visit https://gwt-review.googlesource.com/3321 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0133c64de75d5d95cff863c5ab950d474dda0c56 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects
Thomas Broyer has posted comments on this change. Change subject: Emulate java.util.Objects .. Patch Set 9: Tests are failing: http://build.gwtproject.org/job/gwt/261/testReport/ @Andrey: can you provide a patch quickly, or should someone else investigate? (or revert your change). @Ray (and others): how would you prefer to deal with this situation? fix the breakage or revert first, then reapplied a fixed change? ObjectTest#testEquals fails in both devmode (test.dev.htmlunit) and prodmode (test.draft.htmlunit). The other one is an error: [junit] Exception in thread pool-1-thread-1 java.lang.IndexOutOfBoundsException [junit] at java.io.ObjectOutputStream.write(ObjectOutputStream.java:703) [junit] at com.google.gwt.dev.util.DiskCache.transferToStream(DiskCache.java:196) [junit] at com.google.gwt.dev.util.DiskCacheToken.writeObject(DiskCacheToken.java:73) Actually a bug in DiskCache. I'll file an issue for that one. -- To view, visit https://gwt-review.googlesource.com/3184 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599 Gerrit-PatchSet: 9 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@gmail.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects
Thomas Broyer has posted comments on this change. Change subject: Emulate java.util.Objects .. Patch Set 9: Filed issue 8191. I think we need someone with a deep understanding of the compiler internals; Ray maybe? -- To view, visit https://gwt-review.googlesource.com/3184 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599 Gerrit-PatchSet: 9 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@gmail.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...
Daniel Kurka has posted comments on this change. Change subject: adding compare for several number types -Byte.compare -Short.compare -Integer.compare -Long.compare -Float.compare (Double already exists) fixes issue 7998 .. Patch Set 11: Changing the order in Float/Double compare will lead to an unreachable code compiler warning. This must be the reason why Double was implemented the way it was. -- To view, visit https://gwt-review.googlesource.com/3180 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246 Gerrit-PatchSet: 11 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka danku...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Change DOM access in HTMLTable for IE
Daniel Kurka has posted comments on this change. Change subject: Change DOM access in HTMLTable for IE .. Patch Set 2: Going forward this would be the right approach. Not sure though how we make those permutation dependent. I would not like to introduce calling children for other browsers, since I don't really know which other nodes might be included outside of IE. I would suggest waiting for the new widget concept for GWT 3.0 and then go through the widgets and update them (and not putting that much more effort into them right now). -- To view, visit https://gwt-review.googlesource.com/3212 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5789589a307f457a1295b9ed72111ad4c040fa97 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka danku...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Change DOM access in HTMLTable for IE
Thomas Broyer has posted comments on this change. Change subject: Change DOM access in HTMLTable for IE .. Patch Set 2: We do have com.google.gwt.dom.client.DOMImpl already for permutation-dependent implementations. -- To view, visit https://gwt-review.googlesource.com/3212 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5789589a307f457a1295b9ed72111ad4c040fa97 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka danku...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add methods to HasTreeItems
Daniel Kurka has posted comments on this change. Change subject: Add methods to HasTreeItems .. Patch Set 2: I am very much in favor of deprecation, but I think we need some time to get there. We can include these changes in the mean time. I am wondering if we are going to see internal breakage due to the new methods. -- To view, visit https://gwt-review.googlesource.com/2520 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a1a20be6dba36f3978d08178b92269b2736f157 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka danku...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...
John A. Tamplin has posted comments on this change. Change subject: adding compare for several number types -Byte.compare -Short.compare -Integer.compare -Long.compare -Float.compare (Double already exists) fixes issue 7998 .. Patch Set 11: That was because you left else return 0 before the NaN checks. You would have to move that branch to the end, below the NaN checks to re-order them. BTW, since GWT treats floats and doubles the same, should we just have Float.compareTo delegate to Double.compareTo? Less code to be different, and it should get completely inlined. -- To view, visit https://gwt-review.googlesource.com/3180 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246 Gerrit-PatchSet: 11 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka danku...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fix module unloading with multiple modules on a page
Matthew Dempsky has submitted this change and it was merged.
Change subject: Fix module unloading with multiple modules on a page
..
Fix module unloading with multiple modules on a page
Currently, the GWT compiler in production compiles will optimize away
the instanceof checks in isMyListener() because it assumes
getEventListener() is actually returning an EventListener object.
However, if there are multiple modules loaded on a page, the
__listener property might be for an EventListener from a different
module.
One way to workaround this (the approach taken by this patch) is to
call isMyListener() before getEventListener() returns, so the compiler
can't optimize away the instanceof checks.
Change-Id: I25d9471c1e14756196a11223eadb765ed303a3b4
---
M user/src/com/google/gwt/user/client/impl/DOMImpl.java
1 file changed, 5 insertions(+), 6 deletions(-)
Approvals:
Ray Cromwell: Looks good to me, approved
Leeroy Jenkins: Verified
Thomas Broyer: Looks good to me, but someone else must approve
diff --git a/user/src/com/google/gwt/user/client/impl/DOMImpl.java
b/user/src/com/google/gwt/user/client/impl/DOMImpl.java
index c5b8187..eafd332 100644
--- a/user/src/com/google/gwt/user/client/impl/DOMImpl.java
+++ b/user/src/com/google/gwt/user/client/impl/DOMImpl.java
@@ -50,12 +50,9 @@
for (int i = 0; i allElements.getLength(); i++) {
com.google.gwt.dom.client.Element elem = allElements.getItem(i);
Element userElem = (Element) elem;
- if (dom.getEventsSunk(userElem) != 0) {
-dom.sinkEvents(userElem, 0);
- }
EventListener listener = dom.getEventListener(userElem);
- // nulls out event listener if and only if it was assigned from our
module
- if (GWT.isScript() listener != null isMyListener(listener)) {
+ if (GWT.isScript() listener != null) {
+dom.sinkEvents(userElem, 0);
dom.setEventListener(userElem, null);
}
// cleans up DOM-style addEventListener registered handlers
@@ -154,7 +151,9 @@
public abstract int getChildIndex(Element parent, Element child);
public native EventListener getEventListener(Element elem) /*-{
-return elem.__listener;
+// Return elem.__listener if and only if it was assigned from our
module
+var maybeListener = elem.__listener;
+return
@com.google.gwt.user.client.impl.DOMImpl::isMyListener(Ljava/lang/Object;)(maybeListener) ?
maybeListener : null;
}-*/;
public native int getEventsSunk(Element elem) /*-{
--
To view, visit https://gwt-review.googlesource.com/2941
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I25d9471c1e14756196a11223eadb765ed303a3b4
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add show relative to Element in PopupPanel
Matthew Dempsky has posted comments on this change. Change subject: Add show relative to Element in PopupPanel .. Patch Set 2: (2 comments) File tools/api-checker/config/gwt25_26userApi.conf Line 176: #adding method to PopupPanel to show relative to an Element Space between # and adding. Line 177: com.google.gwt.user.client.ui.PopupPanel::showRelativeTo(Lcom/google/gwt/dom/client/Element;) OVERLOADED_METHOD_CALL Should list the UIObject method, not the Element one. -- To view, visit https://gwt-review.googlesource.com/3340 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8991b1cb1c3ec4ecabd299ee4c5bf4e5992e4b5e Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka danku...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add interfaces for widgets.
Colin Alworth has posted comments on this change. Change subject: Add interfaces for widgets. .. Patch Set 6: (4 comments) File user/src/com/google/gwt/dom/client/HasStyle.java Line 29: void setStyleName(String styleName); Might be worth adding hasStyleName, as this was recently added to Element - Goktug indicated in that review that a toggleStyleName is on the way as well. https://gwt-review.googlesource.com/#/c/3070/ File user/src/com/google/gwt/dom/client/IsElement.java Line 61: void appendChild(IsElement element); This method seems out of place - it is the closest we get to dom manipulation - no removeChild(IsElement) nor IsElement getParentElement() or any getChild (which may not be). Is there a reason you picked this and removeFromParent, but not other dom methods? Variance issues almost explain it, but then I noticed that you needed to add new methods just to support this in Element itself. And since you already are needing to add new methods in Element to deal with IsElement vs Node, would it make sense then to add new methods for these? File user/src/com/google/gwt/user/client/ui/IsUIObject.java Line 27: IsElement getIsElement(); My concern there would be that we'd no longer have a way to get access to the element as a jso in the code that needs it. If I wanted the element so I could treat it as a InputElement, the JSO.cast() is no longer available to me, only the regular Java cast. Not a huge loss, but it definitely is a breaking change. Simple/ugly way around that might be to rename IsElement.asElement to IsElement.cast, with the JSO.cast generics. Returns null for stubs, and with a real element lets you cast as usual. File user/src/com/google/gwt/user/client/ui/IsWidget2.java Line 28: public interface IsWidget2 extends IsWidget, IsUIObject, EventListener, HasHandlers, (Sorry if I missed this discussion elsewhere, but) What is the philosophical thinking on IsWidget vs IsWidget2? This is for mocking Widget, while IsWidget is for Composite-free composition? If that is the idea, what about another name than IsWidget2, which seems to suggest 'better isWidget' rather than 'mockable iswidget'. -- To view, visit https://gwt-review.googlesource.com/3231 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd17162d37e367720829bcdaf9a350e446c833b9 Gerrit-PatchSet: 6 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Colin Alworth niloc...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Ensure clinits get called for JSO instance methods.
Colin Alworth has uploaded a new change for review.
https://gwt-review.googlesource.com/3361
Change subject: Ensure clinits get called for JSO instance methods.
..
Ensure clinits get called for JSO instance methods.
In following Java semantics, any static initialization code in a class
(collectively a clinit) should be run before any part of that class is
used. To
achieve this, GWT ensures that this clinit was invoked before any (actually)
static method, and as part of any constructor. This way, instance methods
are
sure to have already run the clinit, so it doesn't need to be run again.
However, JSO constructors don't exist, so instance methods are not
guaranteed to
have had the clinit already run. This is the bug that this patch is trying
to
fix.
Two locations are changed, both with the effect of ensuring that a clinit is
emitted for JSOs. First, the MethodInliner must not skip adding a call to
the
clinit when the jso body is inlined and the method invocation (and ref to
the
class) is dropped, and second, GenerateJavaScriptAST must likewise write out
explicit clinits for any static method or jso instance method.
Bug: issue 3192
Change-Id: If09885382bcf2d6c149cd8e48bfdd3ae527d67cb
---
M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
M dev/core/src/com/google/gwt/dev/jjs/impl/MethodInliner.java
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git
a/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
b/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
index 240f6a0..1c7944a 100644
--- a/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
+++ b/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
@@ -2189,10 +2189,10 @@
if (!crossClassTargets.contains(x)) {
return null;
}
- if (x.canBePolymorphic() || program.isStaticImpl(x)) {
+ JDeclaredType enclosingType = x.getEnclosingType();
+ if (x.canBePolymorphic() || (program.isStaticImpl(x)
!program.isJavaScriptObject(enclosingType))) {
return null;
}
- JDeclaredType enclosingType = x.getEnclosingType();
if (enclosingType == null || !enclosingType.hasClinit()) {
return null;
}
diff --git a/dev/core/src/com/google/gwt/dev/jjs/impl/MethodInliner.java
b/dev/core/src/com/google/gwt/dev/jjs/impl/MethodInliner.java
index d2b05ae..6acbb49 100644
--- a/dev/core/src/com/google/gwt/dev/jjs/impl/MethodInliner.java
+++ b/dev/core/src/com/google/gwt/dev/jjs/impl/MethodInliner.java
@@ -169,8 +169,8 @@
// Access from this class to the target class won't trigger a
clinit
return null;
}
- if (program.isStaticImpl(x.getTarget())) {
-// No clinit needed; target is really an instance method.
+ if (program.isStaticImpl(x.getTarget())
!program.isJavaScriptObject(x.getTarget().getEnclosingType())) {
+// No clinit needed; target is really a non-jso instance method.
return null;
}
if (JProgram.isClinit(x.getTarget())) {
--
To view, visit https://gwt-review.googlesource.com/3361
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If09885382bcf2d6c149cd8e48bfdd3ae527d67cb
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Colin Alworth niloc...@gmail.com
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Ensure clinits get called for JSO instance methods.
John A. Tamplin has posted comments on this change. Change subject: Ensure clinits get called for JSO instance methods. .. Patch Set 1: This seems a lot less than what you showed me at the Meet-up -- what did you change? Also needs tests. -- To view, visit https://gwt-review.googlesource.com/3361 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: If09885382bcf2d6c149cd8e48bfdd3ae527d67cb Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Colin Alworth niloc...@gmail.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Ensure clinits get called for JSO instance methods.
Colin Alworth has posted comments on this change. Change subject: Ensure clinits get called for JSO instance methods. .. Patch Set 1: Afraid not, this is the exact same patch we looked at - only difference was that I pulled the sys.out.println I was using to debug the circumstances for this fix. W.r.t. test cases, would those be best in the form of a test JSO that demonstrates the issue, or something that actually builds a sample ast and verifies that JsInvocations or JMethodCalls are created for the clinit? I have the test sample from the original bug report that could be made into a GwtTestCase, but that seems a little more testing the effect than the bug. That said, I'm not seeing (or perhaps not looking in the right place for) a lot of test cases that make sure the generated JS is sane. One last thought - while moving this from SVN to Git, it occurred to me that this same fix could potentially be achieved in another way: In the same way that MakeCallsStatic ties newly static calls to their original instance version via JProgram.putStaticImpl, it appears that JsoDevirtualizer could do the same. This would make these methods show up as needing a clinit when the `program.isStaticImpl(x.getTarget())` check is made (as in MethodInliner.createClinitCall. From your general gwtc point of view, does that seem to be a reasonable (as well as clearer) fix? -- To view, visit https://gwt-review.googlesource.com/3361 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: If09885382bcf2d6c149cd8e48bfdd3ae527d67cb Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Colin Alworth niloc...@gmail.com Gerrit-Reviewer: Colin Alworth niloc...@gmail.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds Timer#isRunning().
Goktug Gokdogan has posted comments on this change. Change subject: Adds Timer#isRunning(). .. Patch Set 2: (3 comments) File user/src/com/google/gwt/user/client/Timer.java Line 110: throw new IllegalArgumentException(must be non-negative); it makes sense to do schedule(0) (i.e. do asap after this event loop) and there is already a lot of code using that. On the other hand, a '0' interval is probably a bad idea but might be still a valid value; I'm not sure. If you feel strongly about it, please create a bug so that we can discuss/evaluate accepting 0 in setInterval there. Line 151: This was intended and semantically correct; timer is fired out and not running any more. Also in practice, if we don't do that user cannot schedule the timer again from the timer callback, which is pretty common. File user/test/com/google/gwt/user/client/TimerTest.java Line 86: // Issue https://code.google.com/p/google-web-toolkit/issues/detail?id=8101 Actually, previous code was not reproducing the problem. I removed the counter and the tests were still passing; just busy waiting doesn't seem like forcing them to be fired in the same event loop however if there are scheduled to be fired exactly at the same time, the problem gets reproduced. That is the reason that I re-implemented the test case. (I have searched about it, and examples I've seen were using a similar approach to reproduce the issue.) -- To view, visit https://gwt-review.googlesource.com/3321 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0133c64de75d5d95cff863c5ab950d474dda0c56 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add support for 'ImageResource' to @url substitution in css....
Goktug Gokdogan has posted comments on this change. Change subject: Add support for 'ImageResource' to @url substitution in css. Only 'DataResource' used to be supported. .. Patch Set 1: (1 comment) File user/test/com/google/gwt/resources/client/test.css Line 21: @url BACKGROUNDIAMGE spriteMethod; typo throughout the file: IAMGE - IMAGE -- To view, visit https://gwt-review.googlesource.com/3290 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6ae9fe0ace59eb682a77a761fe252bf46cafa9f Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Emmanuel Pellereau emmanu...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add methods to HasTreeItems
Goktug Gokdogan has posted comments on this change. Change subject: Add methods to HasTreeItems .. Patch Set 2: Sorry, I didn't understand why we need some time to deprecate the older methods in favor of new ones? (About internal breakage, I checked it the first time you send the patch, and didn't find any problems.) -- To view, visit https://gwt-review.googlesource.com/2520 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a1a20be6dba36f3978d08178b92269b2736f157 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka danku...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects
Andrey Korzhevskiy has posted comments on this change. Change subject: Emulate java.util.Objects .. Patch Set 9: @Thomas: I'll submit fixes for failing tests asap -- To view, visit https://gwt-review.googlesource.com/3184 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599 Gerrit-PatchSet: 9 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@gmail.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...
Goktug Gokdogan has posted comments on this change. Change subject: adding compare for several number types -Byte.compare -Short.compare -Integer.compare -Long.compare -Float.compare (Double already exists) fixes issue 7998 .. Patch Set 11: Like John said, it was compilation error because you kept the 'else' statement as is. Just follow my code snippet or delegate to Double like John suggested and I can send a patch for Double later. -- To view, visit https://gwt-review.googlesource.com/3180 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246 Gerrit-PatchSet: 11 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka danku...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Ensure clinits get called for JSO instance methods.
John A. Tamplin has posted comments on this change. Change subject: Ensure clinits get called for JSO instance methods. .. Patch Set 1: I think simply having a JSO with static initializers that don't work without this patch would be sufficient. I think your current fix is clearer than making it appear to be a static impl. -- To view, visit https://gwt-review.googlesource.com/3361 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: If09885382bcf2d6c149cd8e48bfdd3ae527d67cb Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Colin Alworth niloc...@gmail.com Gerrit-Reviewer: Colin Alworth niloc...@gmail.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add interfaces for widgets.
Stephen Haberman has posted comments on this change. Change subject: Add interfaces for widgets. .. Patch Set 6: (1 comment) Hey guys, thanks for the comments. I'm out of town for a few days, but so far they all make sense--I'll address them/respond further when I get back. File user/src/com/google/gwt/user/client/ui/IsUIObject.java Line 27: IsElement getIsElement(); Oh, right; I had to do that when these were my own interfaces, but that should work now...I'll try that. Thanks! -- To view, visit https://gwt-review.googlesource.com/3231 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd17162d37e367720829bcdaf9a350e446c833b9 Gerrit-PatchSet: 6 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Colin Alworth niloc...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Failing tests for java.util.Objects
Andrey Korzhevskiy has uploaded a new change for review.
https://gwt-review.googlesource.com/3400
Change subject: Failing tests for java.util.Objects
..
Failing tests for java.util.Objects
Fixes issue 8193
Change-Id: I394c80559ce4e872826f832f0aca24fcd0e156ba
---
M user/super/com/google/gwt/emul/java/util/Objects.java
M user/test/com/google/gwt/emultest/java/util/ObjectsTest.java
2 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/user/super/com/google/gwt/emul/java/util/Objects.java
b/user/super/com/google/gwt/emul/java/util/Objects.java
index ca0f5e1..ec5e9a4 100644
--- a/user/super/com/google/gwt/emul/java/util/Objects.java
+++ b/user/super/com/google/gwt/emul/java/util/Objects.java
@@ -29,7 +29,13 @@
}
public static boolean deepEquals(Object a, Object b) {
-if (equals(a, b)) {
+if (a == b) {
+ return true;
+}
+if (a == null || b == null) {
+ return false;
+}
+if (a.equals(b)) {
return true;
}
diff --git a/user/test/com/google/gwt/emultest/java/util/ObjectsTest.java
b/user/test/com/google/gwt/emultest/java/util/ObjectsTest.java
index 96cd788..f6416e2 100644
--- a/user/test/com/google/gwt/emultest/java/util/ObjectsTest.java
+++ b/user/test/com/google/gwt/emultest/java/util/ObjectsTest.java
@@ -82,14 +82,6 @@
Object obj = new Object();
assertTrue(Objects.equals(obj, obj));
-
-assertFalse(Objects.equals(new Object() {
- @Override
- public boolean equals(Object other) {
-fail(Shouldn't call equals if second argument is null);
-return false;
- }
-}, null));
}
public void testHashCode() {
--
To view, visit https://gwt-review.googlesource.com/3400
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I394c80559ce4e872826f832f0aca24fcd0e156ba
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects
Andrey Korzhevskiy has posted comments on this change. Change subject: Emulate java.util.Objects .. Patch Set 9: Filed https://code.google.com/p/google-web-toolkit/issues/detail?can=2start=0num=100q=colspec=ID%20Type%20Status%20Owner%20Milestone%20Summary%20Starsgroupby=sort=id=8193 and patch https://gwt-review.googlesource.com/3400 -- To view, visit https://gwt-review.googlesource.com/3184 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599 Gerrit-PatchSet: 9 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@gmail.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Set display to none for table columns that should not be vis...
Goktug Gokdogan has posted comments on this change.
Change subject: Set display to none for table columns that should not be
visible.
..
Patch Set 1:
(3 comments)
File user/src/com/google/gwt/user/cellview/client/CellTable.java
Line 905:
ensureTableColElement(i).getStyle().setDisplay(Display.NONE);
I think this has the same issue as before isn't it?
If I correctly understood the previous issue, if the column display is set
to none, the width was not propagating.
That will still be true for columns that was not visible before (hence
display is set to none) and become just visible. Their width will be set in
super.refreshColumnWidth when the display is still 'none'.
Line 909: }
Let's do 2 loops and avoid the unnecessary if checks:
for (int i = 0; i lastColumn; i++) {
ensureTableColElement(i).getStyle().clearDisplay();
}
for (int i = lastColumn; i colCount; i++) {
doSetColumnWidth(i, 0px);
ensureTableColElement(i).getStyle().setDisplay(Display.NONE);
}
File user/test/com/google/gwt/user/cellview/client/CellTableTest.java
Line 301: assertEquals(Display.NONE.toString().toLowerCase(),
you can just change this to none if you like.
--
To view, visit https://gwt-review.googlesource.com/3390
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5eabeda8a3ef2f7b851d540c3776026984654c3
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Aliseya Wright alis...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Issue 8083, needs some input from GWT team
Lazy parsing can be a performance win, but it also complicates the API in the case of a parse error. Have you thought about how to report errors when they happen later? It might less confusing to solve this using a separate LazyBigDecimal class. People can declare fields of this type in their data transfer objects when they're concerned about performance. On Tue, Jun 11, 2013 at 1:56 AM, stuckagain david.no...@gmail.com wrote: Hi, I am working on a fix for this issue: https://code.google.com/p/google-web-toolkit/issues/detail?id=8083 I am avoiding converting from string to the internal format of BigInteger because it has a big performance impact on IE8 when sending it over RPC. It performs much better in IE9 and other browsers, but still I want to optimize this since this is having a major impact in an application I am working on (And I saw some other people in the banking industry having similar issues with BigDecimal). In many cases this data is never modified in the client, so I am delaying the actual parsing of the String to the internal format of BigInteger. Is it feasible to have custom field serializers depending on running in the client or server ? The question I am asking is because I don't want to break the BigInteger(String) constructor that will throw exceptions when you feed it a non parseable string. so my solution would be to use a static method or custom constructor for BigInteger when deserializing on the client. But this method is not available in the real java.math.BigInteger class. So is it possible to have different client and server serializers/deserializer code for RPC ? David -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Issue 8083, needs some input from GWT team
Have we evaluated why it is so slow on ie8? It might be easier to fix that. The one thing it does is heavy use of StringBuffers so that could be where the issue is. On Jun 12, 2013 8:09 PM, Brian Slesinsky skybr...@google.com wrote: Lazy parsing can be a performance win, but it also complicates the API in the case of a parse error. Have you thought about how to report errors when they happen later? It might less confusing to solve this using a separate LazyBigDecimal class. People can declare fields of this type in their data transfer objects when they're concerned about performance. On Tue, Jun 11, 2013 at 1:56 AM, stuckagain david.no...@gmail.com wrote: Hi, I am working on a fix for this issue: https://code.google.com/p/google-web-toolkit/issues/detail?id=8083 I am avoiding converting from string to the internal format of BigInteger because it has a big performance impact on IE8 when sending it over RPC. It performs much better in IE9 and other browsers, but still I want to optimize this since this is having a major impact in an application I am working on (And I saw some other people in the banking industry having similar issues with BigDecimal). In many cases this data is never modified in the client, so I am delaying the actual parsing of the String to the internal format of BigInteger. Is it feasible to have custom field serializers depending on running in the client or server ? The question I am asking is because I don't want to break the BigInteger(String) constructor that will throw exceptions when you feed it a non parseable string. so my solution would be to use a static method or custom constructor for BigInteger when deserializing on the client. But this method is not available in the real java.math.BigInteger class. So is it possible to have different client and server serializers/deserializer code for RPC ? David -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Failing tests for java.util.Objects
Matthew Dempsky has posted comments on this change. Change subject: Failing tests for java.util.Objects .. Patch Set 1: (1 comment) File user/test/com/google/gwt/emultest/java/util/ObjectsTest.java Line 86 Why are you removing this test? -- To view, visit https://gwt-review.googlesource.com/3400 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I394c80559ce4e872826f832f0aca24fcd0e156ba Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add interfaces for widgets.
Goktug Gokdogan has posted comments on this change.
Change subject: Add interfaces for widgets.
..
Patch Set 6:
(1 comment)
1. It is very important to use consistent naming convention throughout the
SDKs. IsXXX previously used to provide asXXX methods (IsWidget, IsEditor,
IsTreeItem), except 2 cases (IsRenderable, IsCollabsible) which were more
recently added and I think they are both named badly.
2. Looking at the size of this change and thinking of its implications, we
need a very good justification for it. There has been some discussion in
the thread and the reasons for adding these interfaces end up being solely
for testing purposes. More specifically for mocking purposes for specific
style of MVP pattern. I was actually interested in these interfaces for
functional capabilities and we decided to defer that part.
Let's first see a demonstration why mocking options out there
(GWTMockUtilities, gwtmockito, gwt-test-utils, etc...) doesn't fit into our
needs and see if we can fix the problem without this mess. We can use
gathered information from there to document the decision.
File user/src/com/google/gwt/dom/client/Style.java
Line 31: public class Style extends JavaScriptObject implements IsStyle {
If you put IsStyle here, no one else can implement this interface - this is
a restriction due to JSOs.
--
To view, visit https://gwt-review.googlesource.com/3231
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd17162d37e367720829bcdaf9a350e446c833b9
Gerrit-PatchSet: 6
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com
Gerrit-Reviewer: Colin Alworth niloc...@gmail.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects
Matthew Dempsky has posted comments on this change. Change subject: Emulate java.util.Objects .. Patch Set 9: @Thomas: I think it depends on how quickly we can resolve the issue and how confident we are there won't still be more breakage after the fix is submitted. In this case, the issue seems simple enough and Andrey already has a fix prepared, so I'm fine with rolling forward. If it was something more complicated, we'd probably prefer to roll back and try again. That's at least the rule Google follows internally. -- To view, visit https://gwt-review.googlesource.com/3184 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599 Gerrit-PatchSet: 9 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@gmail.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects
Goktug Gokdogan has posted comments on this change. Change subject: Emulate java.util.Objects .. Patch Set 9: A good rule of thumb is; if you can't fix it in 5 min, you should revert. More time the trunk is left broken, more people are likely to get a bad copy on the sync; which is bad. The cool thing is, Gerrit has a revert functionality; you just need to click a few buttons from the browser =) -- To view, visit https://gwt-review.googlesource.com/3184 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599 Gerrit-PatchSet: 9 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@gmail.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
