[gwt-contrib] Re: Make ExternalTextResource use Jsonp (issue1214801)
Implementation LGTM, just expand the test a bit and commit.
http://gwt-code-reviews.appspot.com/1214801/diff/20001/21004
File user/src/com/google/gwt/resources/Resources.gwt.xml (right):
http://gwt-code-reviews.appspot.com/1214801/diff/20001/21004#newcode83
user/src/com/google/gwt/resources/Resources.gwt.xml:83: !-- This can be
used to make ExternalTextResource use JSONP rather than XHR --
... by setting the value to true
http://gwt-code-reviews.appspot.com/1214801/diff/20001/21005
File
user/src/com/google/gwt/resources/client/impl/ExternalTextResourcePrototype.java
(right):
http://gwt-code-reviews.appspot.com/1214801/diff/20001/21005#newcode138
user/src/com/google/gwt/resources/client/impl/ExternalTextResourcePrototype.java:138:
TextResource[] cache, int index, String md5Hash, boolean useJsonp) {
The presence of md5Hash implies useJsonp. It would be better to add the
jsonp variant as a separate constructor.
http://gwt-code-reviews.appspot.com/1214801/diff/20001/21006
File
user/src/com/google/gwt/resources/rg/ExternalTextResourceGenerator.java
(right):
http://gwt-code-reviews.appspot.com/1214801/diff/20001/21006#newcode79
user/src/com/google/gwt/resources/rg/ExternalTextResourceGenerator.java:79:
sw.println(\ + getMd5HashOfData() + \, );
FYI only. Since ETRG was written, the SourceWriter.println() method now
has a printf-style overload.
http://gwt-code-reviews.appspot.com/1214801/diff/20001/21007
File user/test/com/google/gwt/jsonp/client/JsonpRequestTest.java
(right):
http://gwt-code-reviews.appspot.com/1214801/diff/20001/21007#newcode239
user/test/com/google/gwt/jsonp/client/JsonpRequestTest.java:239: public
void testPredeterminedIds() {
Sort order. It's not enforced by the checkstyle rules in test code.
http://gwt-code-reviews.appspot.com/1214801/diff/20001/21009
File user/test/com/google/gwt/resources/ResourcesSuite.java (right):
http://gwt-code-reviews.appspot.com/1214801/diff/20001/21009#newcode62
user/test/com/google/gwt/resources/ResourcesSuite.java:62:
suite.addTestSuite(UnknownAtRuleTest.class);
The order of these tests doesn't matter, can you sort the addTestSuite()
while you're in the area?
http://gwt-code-reviews.appspot.com/1214801/diff/20001/21011
File
user/test/com/google/gwt/resources/client/ExternalTextResourceTest.java
(right):
http://gwt-code-reviews.appspot.com/1214801/diff/20001/21011#newcode26
user/test/com/google/gwt/resources/client/ExternalTextResourceTest.java:26:
static interface Resources extends ClientBundleWithLookup {
Redundant modifier, interfaces are implicitly static.
To make sure the bundling is working correctly, there should be more
than one ExternalTextResource in the ClientBundle. Also, make sure that
the JSON escaping is working correctly by adding a file containing
characters that must be escaped. A sequence like
dobule-quotesingle-quotebackslash should be sufficient.
http://gwt-code-reviews.appspot.com/1214801/diff/20001/21011#newcode59
user/test/com/google/gwt/resources/client/ExternalTextResourceTest.java:59:
Extra blank line.
http://gwt-code-reviews.appspot.com/1214801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Refactors TypeOracleMediator to avoid CompiledClass references. This way, we will be able to th... (issue1217801)
Do we want to hide this change initially behind a flag (e.g. -DXuseByteCodeToBuildTypeOracle)? http://gwt-code-reviews.appspot.com/1217801/diff/1/3 File dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java (right): http://gwt-code-reviews.appspot.com/1217801/diff/1/3#newcode256 dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java:256: I'm not sure why this declaration is transient. Is TypeOracleMediator ever serialized? Also (and this might just be a stylistic point), I think it might be cleaner to have the context passed down to the methods that need it, rather than having it be an instance variable. It might be more of an issue later if we try to make this multi-threaded (e.g. if multiple AddNewTypes happen simultaneously). Of course, this would not be the only thing that would need refactoring for thread-safety... http://gwt-code-reviews.appspot.com/1217801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Refactors TypeOracleMediator to avoid CompiledClass references. This way, we will be able to th... (issue1217801)
Regarding the command line flag: At this point we aren't ready for it, this change doesn't change the logic of building the TypeOracle at all - we've been using byte code generated from JDT for a couple of years now. This change just reorganizes TypeOracleMediator so I can feed it byte code directly without using CompilationState, mainly for testing. http://gwt-code-reviews.appspot.com/1217801/diff/1/3 File dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java (right): http://gwt-code-reviews.appspot.com/1217801/diff/1/3#newcode256 dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java:256: On 2010/12/15 13:13:08, jbrosenberg wrote: I'm not sure why this declaration is transient. Is TypeOracleMediator ever serialized? I'm not sure either, although I did try to serialize TypeOracle once. I migrated the three transient variables into one context so I kept the transient qualifier. Also (and this might just be a stylistic point), I think it might be cleaner to have the context passed down to the methods that need it, rather than having it be an instance variable. It might be more of an issue later if we try to make this multi-threaded (e.g. if multiple AddNewTypes happen simultaneously). Of course, this would not be the only thing that would need refactoring for thread-safety... What I did I consider a compromise. Before there were 3 variables that were initialized for a single pass of addNewUnits() and then cleared at the end. I tried this before and it was pretty disruptive, but I think I'll give it another shot. http://gwt-code-reviews.appspot.com/1217801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Refactors TypeOracleMediator to avoid CompiledClass references. This way, we will be able to th... (issue1217801)
Added TODO(), renamed unit test to end in string 'Test' so it will be picked up in Ant. http://gwt-code-reviews.appspot.com/1217801/diff/1/3 File dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java (right): http://gwt-code-reviews.appspot.com/1217801/diff/1/3#newcode256 dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java:256: ... I tried this before and it was pretty disruptive, but I think I'll give it another shot. I did it again and the diff is 485 lines. I'll add a TODO() and propose it as a followon patch. http://gwt-code-reviews.appspot.com/1217801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Refactors TypeOracleMediator to avoid CompiledClass references. This way, we will be able to th... (issue1217801)
http://gwt-code-reviews.appspot.com/1217801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Refactors TypeOracleMediator to avoid CompiledClass references. This way, we will be able to th... (issue1217801)
http://gwt-code-reviews.appspot.com/1217801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Isolates the portion of TypeOracleMediator that (issue1188802)
This review is dead. See http://gwt-code-reviews.appspot.com/1217801/show http://gwt-code-reviews.appspot.com/1188802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Refactors TypeOracleMediator to avoid CompiledClass references. This way, we will be able to th... (issue1217801)
LGTM http://gwt-code-reviews.appspot.com/1217801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Refactors TypeOracleMediator to avoid CompiledClass references. This way, we will be able to th... (issue1217801)
LGTM http://gwt-code-reviews.appspot.com/1217801/diff/1/3 File dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java (right): http://gwt-code-reviews.appspot.com/1217801/diff/1/3#newcode256 dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java:256: I see now that you were simplifying what was there before (transient and all). I like that you've grouped those 3 variables into a context, which makes it easier to pass it around, etc... http://gwt-code-reviews.appspot.com/1217801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9427 committed - Stub documentation of GWT Validation
Revision: 9427 Author: ncha...@google.com Date: Wed Dec 15 10:48:50 2010 Log: Stub documentation of GWT Validation http://code.google.com/p/google-web-toolkit/source/detail?r=9427 Added: /wiki/BeanValidation.wiki === --- /dev/null +++ /wiki/BeanValidation.wiki Wed Dec 15 10:48:50 2010 @@ -0,0 +1,6 @@ +#summary JSR 303 Bean Validation for GWT +#labels jsr303,beanvalidation + += Introduction = + +GWT supports a subset of JSR 303 Bean Validation. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9428 committed - Edited wiki page BeanValidation through web user interface.
Revision: 9428 Author: ncha...@google.com Date: Wed Dec 15 10:52:21 2010 Log: Edited wiki page BeanValidation through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=9428 Modified: /wiki/BeanValidation.wiki === --- /wiki/BeanValidation.wiki Wed Dec 15 10:48:50 2010 +++ /wiki/BeanValidation.wiki Wed Dec 15 10:52:21 2010 @@ -1,6 +1,9 @@ #summary JSR 303 Bean Validation for GWT #labels jsr303,beanvalidation +*WARNING* +GWT validaiton is still half baked. API will change. MANY things still just done work. + = Introduction = GWT supports a subset of JSR 303 Bean Validation. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9430 committed - Edited wiki page BeanValidation through web user interface.
Revision: 9430 Author: ncha...@google.com Date: Wed Dec 15 11:14:41 2010 Log: Edited wiki page BeanValidation through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=9430 Modified: /wiki/BeanValidation.wiki === --- /wiki/BeanValidation.wiki Wed Dec 15 10:58:48 2010 +++ /wiki/BeanValidation.wiki Wed Dec 15 11:14:41 2010 @@ -7,3 +7,17 @@ = Introduction = GWT supports a subset of JSR 303 Bean Validation. + +== What is not supported == + * XML configuration + * Validating non GWT compatible classes like Calendar + +== Known Issues == + +=== Critical Bugs === + * Calling the correct !ConstraintValidotor based on bean type (class). + +=== Other Issues === + * Many errors that would happen at runtime are failing the compile + * !ReportAsSingleViolation has no effect. + * Message Localization [http://code.google.com/p/google-web-toolkit/issues/detail?id=5763 Issue 5763] -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Copying the DOMImplIE6 setOpacity implementation into DOMImplIE8 because IE8 does not support th... (issue1211801)
@pdr ping http://gwt-code-reviews.appspot.com/1211801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Make ExternalTextResource use Jsonp (issue1214801)
http://gwt-code-reviews.appspot.com/1214801/diff/20001/21004
File user/src/com/google/gwt/resources/Resources.gwt.xml (right):
http://gwt-code-reviews.appspot.com/1214801/diff/20001/21004#newcode83
user/src/com/google/gwt/resources/Resources.gwt.xml:83: !-- This can be
used to make ExternalTextResource use JSONP rather than XHR --
On 2010/12/15 12:51:57, bobv wrote:
... by setting the value to true
Done.
http://gwt-code-reviews.appspot.com/1214801/diff/20001/21005
File
user/src/com/google/gwt/resources/client/impl/ExternalTextResourcePrototype.java
(right):
http://gwt-code-reviews.appspot.com/1214801/diff/20001/21005#newcode138
user/src/com/google/gwt/resources/client/impl/ExternalTextResourcePrototype.java:138:
TextResource[] cache, int index, String md5Hash, boolean useJsonp) {
On 2010/12/15 12:51:57, bobv wrote:
The presence of md5Hash implies useJsonp. It would be better to add
the jsonp
variant as a separate constructor.
Done.
http://gwt-code-reviews.appspot.com/1214801/diff/20001/21007
File user/test/com/google/gwt/jsonp/client/JsonpRequestTest.java
(right):
http://gwt-code-reviews.appspot.com/1214801/diff/20001/21007#newcode239
user/test/com/google/gwt/jsonp/client/JsonpRequestTest.java:239: public
void testPredeterminedIds() {
On 2010/12/15 12:51:57, bobv wrote:
Sort order. It's not enforced by the checkstyle rules in test code.
Done.
http://gwt-code-reviews.appspot.com/1214801/diff/20001/21009
File user/test/com/google/gwt/resources/ResourcesSuite.java (right):
http://gwt-code-reviews.appspot.com/1214801/diff/20001/21009#newcode62
user/test/com/google/gwt/resources/ResourcesSuite.java:62:
suite.addTestSuite(UnknownAtRuleTest.class);
On 2010/12/15 12:51:57, bobv wrote:
The order of these tests doesn't matter, can you sort the
addTestSuite() while
you're in the area?
Done.
http://gwt-code-reviews.appspot.com/1214801/diff/20001/21011
File
user/test/com/google/gwt/resources/client/ExternalTextResourceTest.java
(right):
http://gwt-code-reviews.appspot.com/1214801/diff/20001/21011#newcode26
user/test/com/google/gwt/resources/client/ExternalTextResourceTest.java:26:
static interface Resources extends ClientBundleWithLookup {
On 2010/12/15 12:51:57, bobv wrote:
Redundant modifier, interfaces are implicitly static.
To make sure the bundling is working correctly, there should be more
than one
ExternalTextResource in the ClientBundle. Also, make sure that the
JSON
escaping is working correctly by adding a file containing characters
that must
be escaped. A sequence like dobule-quotesingle-quotebackslash
should be
sufficient.
Done.
http://gwt-code-reviews.appspot.com/1214801/diff/20001/21011#newcode59
user/test/com/google/gwt/resources/client/ExternalTextResourceTest.java:59:
On 2010/12/15 12:51:57, bobv wrote:
Extra blank line.
Done.
http://gwt-code-reviews.appspot.com/1214801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Copying the DOMImplIE6 setOpacity implementation into DOMImplIE8 because IE8 does not support th... (issue1211801)
On 2010/12/15 19:34:14, jlabanca wrote: @pdr ping LGTM http://gwt-code-reviews.appspot.com/1211801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Refactors TypeOracleMediator to get rid of the 'context' as an instance variable. (issue1220801)
Reviewers: tobyr, jbrosenberg, scottb, Description: Refactors TypeOracleMediator to get rid of the 'context' as an instance variable. Please review this at http://gwt-code-reviews.appspot.com/1220801/show Affected files: M dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Refactors TypeOracleMediator to get rid of the 'context' as an instance variable. (issue1220801)
http://gwt-code-reviews.appspot.com/1220801/diff/1/2 File dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java (right): http://gwt-code-reviews.appspot.com/1220801/diff/1/2#newcode439 dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java:439: return new TypeOracleMediatorResolver(new TypeOracleBuildContext(new MethodArgNamesLookup())); this change makes me a bit queasy, but its only called from a Unit Test. http://gwt-code-reviews.appspot.com/1220801/diff/1/2#newcode853 dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java:853: return resolveClass(logger, (JRealClassType)type, context); fixed adding a space locally. http://gwt-code-reviews.appspot.com/1220801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Refactors TypeOracleMediator to get rid of the 'context' as an instance variable. (issue1220801)
LGTM http://gwt-code-reviews.appspot.com/1220801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Refactors TypeOracleMediator to get rid of the 'context' as an instance variable. (issue1220801)
LGTM with nits. http://gwt-code-reviews.appspot.com/1220801/diff/1/2 File dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java (right): http://gwt-code-reviews.appspot.com/1220801/diff/1/2#newcode439 dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java:439: return new TypeOracleMediatorResolver(new TypeOracleBuildContext(new MethodArgNamesLookup())); Can we make it package-protected then and doc it as such? http://gwt-code-reviews.appspot.com/1220801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Refactors TypeOracleMediator to get rid of the 'context' as an instance variable. (issue1220801)
http://gwt-code-reviews.appspot.com/1220801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Refactors TypeOracleMediator to get rid of the 'context' as an instance variable. (issue1220801)
LGTM http://gwt-code-reviews.appspot.com/1220801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Refactors TypeOracleMediator to get rid of the 'context' as an instance variable. (issue1220801)
http://gwt-code-reviews.appspot.com/1220801/diff/1/2 File dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java (right): http://gwt-code-reviews.appspot.com/1220801/diff/1/2#newcode439 dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java:439: return new TypeOracleMediatorResolver(new TypeOracleBuildContext(new MethodArgNamesLookup())); On 2010/12/15 20:09:44, scottb wrote: Can we make it package-protected then and doc it as such? I couldn't package protect because the test is in another package, but I did rename the method and document it to protect the innocent. http://gwt-code-reviews.appspot.com/1220801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9433 committed - Adding the 2.1.1 tag.
Revision: 9433 Author: p...@google.com Date: Wed Dec 15 12:47:22 2010 Log: Adding the 2.1.1 tag. http://code.google.com/p/google-web-toolkit/source/detail?r=9433 Added: /tags/2.1.1 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9434 committed - Copying the DOMImplIE6 setOpacity implementation into DOMImplIE8 becau...
Revision: 9434
Author: jlaba...@google.com
Date: Wed Dec 15 10:08:15 2010
Log: Copying the DOMImplIE6 setOpacity implementation into DOMImplIE8
because IE8 does not support the opacity style attribute. I added a runtime
check to differentiate IE8, which only supports the alpha filter, from IE9,
which supports opacity.
Review at http://gwt-code-reviews.appspot.com/1211801
Review by: p...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9434
Modified:
/trunk/user/src/com/google/gwt/dom/client/DOMImplIE8.java
===
--- /trunk/user/src/com/google/gwt/dom/client/DOMImplIE8.java Wed Oct 28
09:10:53 2009
+++ /trunk/user/src/com/google/gwt/dom/client/DOMImplIE8.java Wed Dec 15
10:08:15 2010
@@ -17,6 +17,41 @@
class DOMImplIE8 extends DOMImplTrident {
+ private static boolean isIE8;
+ private static boolean isIE8Detected;
+
+ /**
+ * Check if the browser is IE8 or IE9.
+ *
+ * @return codetrue/code if the browser is IE8, codefalse/code
if IE9
+ * or any other browser
+ */
+ static boolean isIE8() {
+if (!isIE8Detected) {
+ isIE8 = isIE8Impl();
+ isIE8Detected = true;
+}
+return isIE8;
+ }
+
+ // Stolen and modified from UserAgent.gwt.xml.
+ private static native boolean isIE8Impl() /*-{
+var ua = navigator.userAgent.toLowerCase();
+if (ua.indexOf(msie) != -1 $doc.documentMode == 8) {
+ return true;
+}
+return false;
+ }-*/;
+
+ @Override
+ public void cssSetOpacity(Style style, double value) {
+if (isIE8()) {
+ cssSetOpacityImpl(style, value);
+} else {
+ super.cssSetOpacity(style, value);
+}
+ }
+
@Override
public int getAbsoluteLeft(Element elem) {
Document doc = elem.getOwnerDocument();
@@ -46,4 +81,8 @@
}
super.setScrollLeft(elem, left);
}
-}
+
+ private native void cssSetOpacityImpl(Style style, double value) /*-{
+style.filter = 'alpha(opacity=' + (value * 100) + ')';
+ }-*/;
+}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Initial version of HTML5 Audio and Video (issue1195801)
It would be nice to have wrap the exceptions so that when things blow
up, the user gets a nicer error messages.
http://gwt-code-reviews.appspot.com/1195801/diff/1/10
File user/src/com/google/gwt/media/dom/client/MediaElement.java (right):
http://gwt-code-reviews.appspot.com/1195801/diff/1/10#newcode452
user/src/com/google/gwt/media/dom/client/MediaElement.java:452: *
On 2010/12/10 16:07:07, rice wrote:
Where do you see this restriction in the spec?
On 2010/12/09 17:01:09, pdr wrote:
Note that is should be a positive integer between 0.0 and 1.0. (Or,
is
negative
allowed?)
It doesn't appear in the spec and I shouldn't have added that note.
http://gwt-code-reviews.appspot.com/1195801/diff/3001/4007
File user/src/com/google/gwt/media/client/Audio.java (right):
http://gwt-code-reviews.appspot.com/1195801/diff/3001/4007#newcode43
user/src/com/google/gwt/media/client/Audio.java:43: return
!!$doc.createElement('audio').getContext;
This doesn't work. Replace with:
return !!$doc.createElement('audio').canPlayType;
http://gwt-code-reviews.appspot.com/1195801/diff/3001/4008
File user/src/com/google/gwt/media/client/Video.java (right):
http://gwt-code-reviews.appspot.com/1195801/diff/3001/4008#newcode43
user/src/com/google/gwt/media/client/Video.java:43: return
!!$doc.createElement('video').getContext;
This doesn't work. Replace with:
return !!$doc.createElement('video').canPlayType;
http://gwt-code-reviews.appspot.com/1195801/diff/3001/4008#newcode50
user/src/com/google/gwt/media/client/Video.java:50:
setElement(Document.get().createVideoElement());
Forgot to include your changes in Document.java in this review
(createVideoElement() and createAudioElement()).
http://gwt-code-reviews.appspot.com/1195801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Replace most user/developer visible references to hosted/web mode with Development/Production Mode (issue1221801)
Reviewers: zundel, Description: Replace most user/developer visible references to hosted/web mode with Development/Production Mode Please review this at http://gwt-code-reviews.appspot.com/1221801/show Affected files: M dev/core/src/com/google/gwt/core/ext/linker/impl/HostedModeTemplate.js M dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java M dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js M dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html M dev/core/src/com/google/gwt/dev/jdt/AbstractCompiler.java M dev/core/src/com/google/gwt/dev/shell/HostedModeException.java M dev/core/src/com/google/gwt/dev/shell/ModuleSpacePropertyOracle.java M dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerDisableAggressiveOptimization.java M dev/core/super/com/google/gwt/core/client/GWTBridge.java M dev/core/super/com/google/gwt/core/client/GwtScriptOnly.java M dev/core/super/com/google/gwt/lang/LongLibBase.java M dev/core/test/com/google/gwt/dev/javac/JsniCheckerTest.java M user/src/com/google/gwt/benchmarks/client/impl/BenchmarkResults.java M user/src/com/google/gwt/canvas/dom/client/Context2d.java M user/src/com/google/gwt/canvas/dom/client/CssColor.java M user/src/com/google/gwt/core/client/Duration.java M user/src/com/google/gwt/core/client/GWT.java M user/src/com/google/gwt/core/client/JavaScriptException.java M user/src/com/google/gwt/core/client/JavaScriptObject.java M user/src/com/google/gwt/core/client/JsArrayBoolean.java M user/src/com/google/gwt/core/client/JsArrayInteger.java M user/src/com/google/gwt/core/client/JsArrayNumber.java M user/src/com/google/gwt/core/client/impl/Impl.java M user/src/com/google/gwt/core/client/impl/SchedulerImpl.java M user/src/com/google/gwt/core/client/impl/StackTraceCreator.java M user/src/com/google/gwt/core/client/impl/WeakMapping.java M user/src/com/google/gwt/core/client/prefetch/Prefetcher.java M user/src/com/google/gwt/junit/RunStyle.java M user/src/com/google/gwt/junit/RunStyleExternalBrowser.java M user/src/com/google/gwt/junit/RunStyleManual.java M user/src/com/google/gwt/junit/RunStyleRemoteWeb.java M user/src/com/google/gwt/junit/client/GWTTestCase.java M user/src/com/google/gwt/rpc/client/impl/ClientWriterFactory.java M user/src/com/google/gwt/rpc/client/impl/SimplePayloadSink.java M user/src/com/google/gwt/rpc/server/HostedModeClientOracle.java M user/src/com/google/gwt/rpc/server/RpcServlet.java M user/src/com/google/gwt/rpc/server/SimplePayloadDecoder.java M user/src/com/google/gwt/safehtml/shared/SafeHtmlBuilder.java M user/src/com/google/gwt/safehtml/shared/SafeHtmlHostedModeUtils.java M user/src/com/google/gwt/safehtml/shared/SafeHtmlUtils.java M user/src/com/google/gwt/user/client/Event.java M user/src/com/google/gwt/user/client/impl/DOMImpl.java M user/src/com/google/gwt/user/client/rpc/impl/SerializerBase.java M user/src/com/google/gwt/user/rebind/rpc/SerializationUtils.java M user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java M user/src/com/google/gwt/user/server/rpc/impl/SerializabilityUtil.java M user/test/com/google/gwt/benchmarks/client/BenchmarkTest.java M user/test/com/google/gwt/core/client/JavaScriptExceptionTest.java M user/test/com/google/gwt/core/client/JsArrayTest.java M user/test/com/google/gwt/core/client/impl/StackTraceCreatorTest.java M user/test/com/google/gwt/core/ext/linker/impl/SelectionScriptLinkerUnitTest.java M user/test/com/google/gwt/dev/jjs/scriptonly/ScriptOnlyClass.java M user/test/com/google/gwt/dev/jjs/scriptonly/ScriptOnlyTest.java M user/test/com/google/gwt/dev/jjs/test/ClassObjectTest.java M user/test/com/google/gwt/dev/jjs/test/CompilerTest.java M user/test/com/google/gwt/dev/jjs/test/HostedTest.java M user/test/com/google/gwt/dev/jjs/test/JStaticEvalTest.java M user/test/com/google/gwt/dev/jjs/test/JsStaticEvalTest.java M user/test/com/google/gwt/dev/jjs/test/RunAsyncMetricsIntegrationTest.java M user/test/com/google/gwt/dom/client/StyleTest.java M user/test/com/google/gwt/emultest/benchmarks/java/util/ArraySortBenchmark.java M user/test/com/google/gwt/emultest/java/lang/CompilerConstantStringTest.java M user/test/com/google/gwt/emultest/java/lang/StringTest.java M user/test/com/google/gwt/emultest/java/math/BigDecimalCompareTest.java M user/test/com/google/gwt/emultest/java/util/IdentityHashMapTest.java M user/test/com/google/gwt/emultest/java/util/LinkedHashMapTest.java M user/test/com/google/gwt/emultest/java/util/TreeMapTest.java M user/test/com/google/gwt/emultest/java/util/TreeSetTest.java M user/test/com/google/gwt/event/shared/HandlerManagerTest.java M user/test/com/google/gwt/json/client/JSONTest.java M user/test/com/google/gwt/regexp/shared/RegExpTest.java M user/test/com/google/gwt/resources/client/TextResourceTest.java M user/test/com/google/gwt/user/client/AsyncProxyTest.java M
[gwt-contrib] Make InstanceRequest usable with value objects by changing the (issue1222801)
Reviewers: rjrjr, Description: Make InstanceRequest usable with value objects by changing the parameterization to BaseProxy. Add test for above. Fix bug in RequestFactoryInterfaceValidator where validateProxy() wouldn't actually validate. Issue 5678. Patch by: bobv Review by: rjrjr Please review this at http://gwt-code-reviews.appspot.com/1222801/show Affected files: M user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryEditorDelegate.java M user/src/com/google/gwt/requestfactory/rebind/RequestFactoryEditorDriverGenerator.java M user/src/com/google/gwt/requestfactory/server/RequestFactoryInterfaceValidator.java M user/src/com/google/gwt/requestfactory/shared/InstanceRequest.java M user/src/com/google/gwt/requestfactory/shared/impl/AbstractRequest.java M user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java M user/test/com/google/gwt/requestfactory/shared/SimpleRequestFactory.java A user/test/com/google/gwt/requestfactory/shared/SimpleValueContext.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Make InstanceRequest usable with value objects by changing the (issue1222801)
LGTM http://gwt-code-reviews.appspot.com/1222801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Replace most user/developer visible references to hosted/web mode with Development/Production Mode (issue1221801)
preliminary comment : I see a lot of references to hosted mode not yet changed. Is that intentional? http://gwt-code-reviews.appspot.com/1221801/diff/1/2 File dev/core/src/com/google/gwt/core/ext/linker/impl/HostedModeTemplate.js (right): http://gwt-code-reviews.appspot.com/1221801/diff/1/2#newcode49 dev/core/src/com/google/gwt/core/ext/linker/impl/HostedModeTemplate.js:49: // Only fire the event if really hosted mode; in Production Mode the compiled change 'hosted mode' to 'development mode'?j http://gwt-code-reviews.appspot.com/1221801/diff/1/3 File dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java (right): http://gwt-code-reviews.appspot.com/1221801/diff/1/3#newcode166 dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java:166: * Last modified is important to keep hosted mode refreses from clobbering s/hosted/Development http://gwt-code-reviews.appspot.com/1221801/diff/1/3#newcode167 dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java:167: * Production Mode compiles. We set the timestamp on the hosted mode s/hosted/Development http://gwt-code-reviews.appspot.com/1221801/diff/1/7 File dev/core/src/com/google/gwt/dev/shell/HostedModeException.java (right): http://gwt-code-reviews.appspot.com/1221801/diff/1/7#newcode19 dev/core/src/com/google/gwt/dev/shell/HostedModeException.java:19: * An exception that can only occur in hosted mode, but may indicate potential s/hosted/Development http://gwt-code-reviews.appspot.com/1221801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Replace most user/developer visible references to hosted/web mode with Development/Production Mode (issue1221801)
I left some of the hosted mode references, particularly around the internal bits of GWT, which most developers will never look at. There's still some stuff there which legitimately, I think, references hosted mode, so I stayed clear of those changes (for now). Happy to add any you think we should change as well, or do a follow up patch with that stuff. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Replace most user/developer visible references to hosted/web mode with Development/Production Mode (issue1221801)
http://gwt-code-reviews.appspot.com/1221801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Replace most user/developer visible references to hosted/web mode with Development/Production Mode (issue1221801)
Sorry. You're right. Apparently I missed some instances in files I did modify. That was not intentional. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9435 committed - Refactors TypeOracleMediator to get rid of the 'context' as an instanc...
Revision: 9435
Author: zun...@google.com
Date: Wed Dec 15 10:43:58 2010
Log: Refactors TypeOracleMediator to get rid of the 'context' as an
instance variable.
Review at http://gwt-code-reviews.appspot.com/1220801
http://code.google.com/p/google-web-toolkit/source/detail?r=9435
Modified:
/trunk/dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java
/trunk/dev/core/test/com/google/gwt/dev/javac/asm/ResolveGenericsTest.java
===
--- /trunk/dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java
Wed Dec 15 07:54:33 2010
+++ /trunk/dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java
Wed Dec 15 10:43:58 2010
@@ -133,7 +133,7 @@
* {...@link TypeOracleMediator#addNewTypes(TreeLogger, Collection,
MethodArgNamesLookup)}
* .
*/
- private static class TypeOracleBuildContext {
+ private class TypeOracleBuildContext {
private final MethodArgNamesLookup allMethodArgs;
// map of internal names to class visitors.
@@ -141,10 +141,82 @@
// map of JRealType instances to lookup class visitors.
private final HashMapJRealClassType, CollectClassData classMapType =
new HashMapJRealClassType, CollectClassData();
+private final Resolver resolver = new TypeOracleMediatorResolver(this);
+
private TypeOracleBuildContext(MethodArgNamesLookup allMethodArgs) {
this.allMethodArgs = allMethodArgs;
}
- }
+ };
+
+ private class TypeOracleMediatorResolver implements Resolver {
+private final TypeOracleBuildContext context;
+public TypeOracleMediatorResolver(TypeOracleBuildContext context) {
+ this.context = context;
+}
+public void addImplementedInterface(JRealClassType type, JClassType
intf) {
+ TypeOracleMediator.this.addImplementedInterface(type, intf);
+}
+
+public void addThrows(JAbstractMethod method, JClassType exception) {
+ TypeOracleMediator.this.addThrows(method, exception);
+}
+
+public MapString, JRealClassType getBinaryMapper() {
+ return TypeOracleMediator.this.binaryMapper;
+}
+
+public TypeOracle getTypeOracle() {
+ return TypeOracleMediator.this.typeOracle;
+}
+
+public JMethod newMethod(JClassType type, String name,
+MapClass? extends Annotation, Annotation declaredAnnotations,
+JTypeParameter[] typeParams) {
+ return TypeOracleMediator.this.newMethod(type, name,
+ declaredAnnotations, typeParams);
+}
+
+public void newParameter(JAbstractMethod method, JType argType,
+String argName,
+MapClass? extends Annotation, Annotation declaredAnnotations,
+boolean argNamesAreReal) {
+ TypeOracleMediator.this.newParameter(method, argType, argName,
+ declaredAnnotations, argNamesAreReal);
+}
+
+public JRealClassType newRealClassType(JPackage pkg,
+String enclosingTypeName, boolean isLocalType, String className,
+boolean isIntf) {
+ return TypeOracleMediator.this.newRealClassType(pkg,
enclosingTypeName,
+ className, isIntf);
+}
+
+public boolean resolveAnnotation(TreeLogger logger,
+CollectAnnotationData annotVisitor,
+MapClass? extends Annotation, Annotation declaredAnnotations) {
+ return TypeOracleMediator.this.resolveAnnotation(logger,
annotVisitor,
+ declaredAnnotations);
+}
+
+public boolean resolveAnnotations(TreeLogger logger,
+ListCollectAnnotationData annotations,
+MapClass? extends Annotation, Annotation declaredAnnotations) {
+ return TypeOracleMediator.this.resolveAnnotations(logger,
annotations,
+ declaredAnnotations);
+}
+
+public boolean resolveClass(TreeLogger logger, JRealClassType type) {
+ return TypeOracleMediator.this.resolveClass(logger, type, context);
+}
+
+public void setReturnType(JAbstractMethod method, JType returnType) {
+ TypeOracleMediator.this.setReturnType(method, returnType);
+}
+
+public void setSuperClass(JRealClassType type, JClassType superType) {
+ TypeOracleMediator.this.setSuperClass(type, superType);
+}
+}
/**
* Pairs of bits to convert from ASM Opcodes.* to Shared.* bitfields.
@@ -253,89 +325,12 @@
}
return type;
}
-
- // transient since it is not retained across calls to {...@link
#addNewTypes()}
- // TODO(zundel): This doesn't need to be an instance variable. Refactor
to pass as method argument.
- protected transient TypeOracleBuildContext context = null;
// map of internal names to classes
final MapString, JRealClassType binaryMapper = new HashMapString,
JRealClassType();
private final SetJRealClassType resolved = new
HashSetJRealClassType();
- private Resolver resolver;
-
- /**
- * Construct a TypeOracleMediator.
- */
- public TypeOracleMediator() {
-resolver = new Resolver() {
- public void addImplementedInterface(JRealClassType type, JClassType
intf) {
-
[gwt-contrib] [google-web-toolkit] r9436 committed - Make InstanceRequest usable with value objects by changing the...
Revision: 9436
Author: b...@google.com
Date: Wed Dec 15 12:13:06 2010
Log: Make InstanceRequest usable with value objects by changing the
parameterization to BaseProxy.
Add test for above.
Fix bug in RequestFactoryInterfaceValidator where validateProxy() wouldn't
actually validate.
Issue 5678.
Patch by: bobv
Review by: rjrjr
Review at http://gwt-code-reviews.appspot.com/1222801
http://code.google.com/p/google-web-toolkit/source/detail?r=9436
Added:
/trunk/user/test/com/google/gwt/requestfactory/shared/SimpleValueContext.java
Modified:
/trunk/user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryEditorDelegate.java
/trunk/user/src/com/google/gwt/requestfactory/rebind/RequestFactoryEditorDriverGenerator.java
/trunk/user/src/com/google/gwt/requestfactory/server/RequestFactoryInterfaceValidator.java
/trunk/user/src/com/google/gwt/requestfactory/shared/InstanceRequest.java
/trunk/user/src/com/google/gwt/requestfactory/shared/impl/AbstractRequest.java
/trunk/user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java
/trunk/user/test/com/google/gwt/requestfactory/shared/SimpleRequestFactory.java
===
--- /dev/null
+++
/trunk/user/test/com/google/gwt/requestfactory/shared/SimpleValueContext.java
Wed Dec 15 12:13:06 2010
@@ -0,0 +1,26 @@
+/*
+ * Copyright 2010 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License); you may
not
+ * use this file except in compliance with the License. You may obtain a
copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package com.google.gwt.requestfactory.shared;
+
+import com.google.gwt.requestfactory.server.SimpleValue;
+
+/**
+ * Tests instance method invocations on value objects.
+ */
+...@service(SimpleValue.class)
+public interface SimpleValueContext extends RequestContext {
+ InstanceRequestSimpleValueProxy, String getString();
+}
===
---
/trunk/user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryEditorDelegate.java
Sun Oct 3 19:15:33 2010
+++
/trunk/user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryEditorDelegate.java
Wed Dec 15 12:13:06 2010
@@ -20,6 +20,7 @@
import com.google.gwt.editor.client.impl.DelegateMap;
import com.google.gwt.event.shared.EventBus;
import com.google.gwt.event.shared.HandlerRegistration;
+import com.google.gwt.requestfactory.shared.BaseProxy;
import com.google.gwt.requestfactory.shared.EntityProxy;
import com.google.gwt.requestfactory.shared.EntityProxyChange;
import com.google.gwt.requestfactory.shared.EntityProxyId;
@@ -117,9 +118,9 @@
// Read-only mode
return object;
}
-if (object instanceof EntityProxy) {
+if (object instanceof BaseProxy) {
@SuppressWarnings(unchecked)
- T toReturn = (T) request.edit((EntityProxy) object);
+ T toReturn = (T) request.edit((BaseProxy) object);
return toReturn;
}
return object;
===
---
/trunk/user/src/com/google/gwt/requestfactory/rebind/RequestFactoryEditorDriverGenerator.java
Thu Dec 9 12:12:52 2010
+++
/trunk/user/src/com/google/gwt/requestfactory/rebind/RequestFactoryEditorDriverGenerator.java
Wed Dec 15 12:13:06 2010
@@ -25,7 +25,7 @@
import com.google.gwt.requestfactory.client.RequestFactoryEditorDriver;
import
com.google.gwt.requestfactory.client.impl.AbstractRequestFactoryEditorDriver;
import
com.google.gwt.requestfactory.client.impl.RequestFactoryEditorDelegate;
-import com.google.gwt.requestfactory.shared.EntityProxy;
+import com.google.gwt.requestfactory.shared.BaseProxy;
import com.google.gwt.user.rebind.SourceWriter;
import java.util.List;
@@ -37,13 +37,13 @@
public class RequestFactoryEditorDriverGenerator extends
AbstractEditorDriverGenerator {
- private JClassType entityProxyType;
+ private JClassType baseProxyType;
@Override
public String generate(TreeLogger logger, GeneratorContext context,
String typeName) throws UnableToCompleteException {
-entityProxyType = context.getTypeOracle().findType(
-EntityProxy.class.getCanonicalName());
+baseProxyType = context.getTypeOracle().findType(
+BaseProxy.class.getCanonicalName());
return super.generate(logger, context, typeName);
}
@@ -65,7 +65,7 @@
@Override
protected String mutableObjectExpression(EditorData data,
String sourceObjectExpression) {
-if (entityProxyType.isAssignableFrom(data.getPropertyOwnerType())) {
+if (baseProxyType.isAssignableFrom(data.getPropertyOwnerType())) {
return
[gwt-contrib] [google-web-toolkit] r9437 committed - Integrate r9436 to GWT 2.1 branch....
Revision: 9437
Author: gwt.mirror...@gmail.com
Date: Wed Dec 15 12:33:26 2010
Log: Integrate r9436 to GWT 2.1 branch.
Make InstanceRequest usable with value objects.
http://code.google.com/p/google-web-toolkit/source/detail?r=9437
Added:
/releases/2.1/user/test/com/google/gwt/requestfactory/shared/SimpleValueContext.java
Modified:
/releases/2.1/user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryEditorDelegate.java
/releases/2.1/user/src/com/google/gwt/requestfactory/rebind/RequestFactoryEditorDriverGenerator.java
/releases/2.1/user/src/com/google/gwt/requestfactory/server/RequestFactoryInterfaceValidator.java
/releases/2.1/user/src/com/google/gwt/requestfactory/shared/InstanceRequest.java
/releases/2.1/user/src/com/google/gwt/requestfactory/shared/impl/AbstractRequest.java
/releases/2.1/user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java
/releases/2.1/user/test/com/google/gwt/requestfactory/shared/SimpleRequestFactory.java
===
--- /dev/null
+++
/releases/2.1/user/test/com/google/gwt/requestfactory/shared/SimpleValueContext.java
Wed Dec 15 12:33:26 2010
@@ -0,0 +1,26 @@
+/*
+ * Copyright 2010 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License); you may
not
+ * use this file except in compliance with the License. You may obtain a
copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package com.google.gwt.requestfactory.shared;
+
+import com.google.gwt.requestfactory.server.SimpleValue;
+
+/**
+ * Tests instance method invocations on value objects.
+ */
+...@service(SimpleValue.class)
+public interface SimpleValueContext extends RequestContext {
+ InstanceRequestSimpleValueProxy, String getString();
+}
===
---
/releases/2.1/user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryEditorDelegate.java
Sun Oct 3 19:15:33 2010
+++
/releases/2.1/user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryEditorDelegate.java
Wed Dec 15 12:33:26 2010
@@ -20,6 +20,7 @@
import com.google.gwt.editor.client.impl.DelegateMap;
import com.google.gwt.event.shared.EventBus;
import com.google.gwt.event.shared.HandlerRegistration;
+import com.google.gwt.requestfactory.shared.BaseProxy;
import com.google.gwt.requestfactory.shared.EntityProxy;
import com.google.gwt.requestfactory.shared.EntityProxyChange;
import com.google.gwt.requestfactory.shared.EntityProxyId;
@@ -117,9 +118,9 @@
// Read-only mode
return object;
}
-if (object instanceof EntityProxy) {
+if (object instanceof BaseProxy) {
@SuppressWarnings(unchecked)
- T toReturn = (T) request.edit((EntityProxy) object);
+ T toReturn = (T) request.edit((BaseProxy) object);
return toReturn;
}
return object;
===
---
/releases/2.1/user/src/com/google/gwt/requestfactory/rebind/RequestFactoryEditorDriverGenerator.java
Fri Dec 10 06:38:12 2010
+++
/releases/2.1/user/src/com/google/gwt/requestfactory/rebind/RequestFactoryEditorDriverGenerator.java
Wed Dec 15 12:33:26 2010
@@ -25,7 +25,7 @@
import com.google.gwt.requestfactory.client.RequestFactoryEditorDriver;
import
com.google.gwt.requestfactory.client.impl.AbstractRequestFactoryEditorDriver;
import
com.google.gwt.requestfactory.client.impl.RequestFactoryEditorDelegate;
-import com.google.gwt.requestfactory.shared.EntityProxy;
+import com.google.gwt.requestfactory.shared.BaseProxy;
import com.google.gwt.user.rebind.SourceWriter;
import java.util.List;
@@ -37,13 +37,13 @@
public class RequestFactoryEditorDriverGenerator extends
AbstractEditorDriverGenerator {
- private JClassType entityProxyType;
+ private JClassType baseProxyType;
@Override
public String generate(TreeLogger logger, GeneratorContext context,
String typeName) throws UnableToCompleteException {
-entityProxyType = context.getTypeOracle().findType(
-EntityProxy.class.getCanonicalName());
+baseProxyType = context.getTypeOracle().findType(
+BaseProxy.class.getCanonicalName());
return super.generate(logger, context, typeName);
}
@@ -65,7 +65,7 @@
@Override
protected String mutableObjectExpression(EditorData data,
String sourceObjectExpression) {
-if (entityProxyType.isAssignableFrom(data.getPropertyOwnerType())) {
+if (baseProxyType.isAssignableFrom(data.getPropertyOwnerType())) {
return String.format(((%s) request.edit((%s))),
data.getPropertyOwnerType().getQualifiedSourceName(),
[gwt-contrib] Re: Replace most user/developer visible references to hosted/web mode with Development/Production Mode (issue1221801)
Changes LG.
found a few places where more changes could be made and some comments
that seem to indicate some tests we could turn back on now.
http://gwt-code-reviews.appspot.com/1221801/diff/1/35
File user/src/com/google/gwt/rpc/client/impl/SimplePayloadSink.java
(right):
http://gwt-code-reviews.appspot.com/1221801/diff/1/35#newcode195
user/src/com/google/gwt/rpc/client/impl/SimplePayloadSink.java:195: * In
hosted-mode, the field's declaring class is written to the stream to
s/hosted-mode/Development Mode
http://gwt-code-reviews.appspot.com/1221801/diff/1/40
File
user/src/com/google/gwt/safehtml/shared/SafeHtmlHostedModeUtils.java
(right):
http://gwt-code-reviews.appspot.com/1221801/diff/1/40#newcode25
user/src/com/google/gwt/safehtml/shared/SafeHtmlHostedModeUtils.java:25:
* SafeHtml utilities whose implementation differs between hosted and
Production
s/hosted/Development
http://gwt-code-reviews.appspot.com/1221801/diff/1/40#newcode29
user/src/com/google/gwt/safehtml/shared/SafeHtmlHostedModeUtils.java:29:
* This class has a super-source peer that provides the web-mode
implementation.
s/web-mode/Production Mode
http://gwt-code-reviews.appspot.com/1221801/diff/1/41
File user/src/com/google/gwt/safehtml/shared/SafeHtmlUtils.java (right):
http://gwt-code-reviews.appspot.com/1221801/diff/1/41#newcode71
user/src/com/google/gwt/safehtml/shared/SafeHtmlUtils.java:71: *
details). For performance reasons, this check is not performed in prod
mode
s/prod/Production Mode ?
http://gwt-code-reviews.appspot.com/1221801/diff/1/41#newcode76
user/src/com/google/gwt/safehtml/shared/SafeHtmlUtils.java:76: * @throws
IllegalArgumentException if not running in prod mode and {...@code
s/prod/Production Mode ?
http://gwt-code-reviews.appspot.com/1221801/diff/1/52
File
user/test/com/google/gwt/core/ext/linker/impl/SelectionScriptLinkerUnitTest.java
(right):
http://gwt-code-reviews.appspot.com/1221801/diff/1/52#newcode207
user/test/com/google/gwt/core/ext/linker/impl/SelectionScriptLinkerUnitTest.java:207:
// hosted
Development Mode... although this isn't a javadoc comment
http://gwt-code-reviews.appspot.com/1221801/diff/1/54
File user/test/com/google/gwt/dev/jjs/scriptonly/ScriptOnlyTest.java
(right):
http://gwt-code-reviews.appspot.com/1221801/diff/1/54#newcode60
user/test/com/google/gwt/dev/jjs/scriptonly/ScriptOnlyTest.java:60: //
Try something you can't do in web-mode (JRE code)
s/web-mode/Production Mode
http://gwt-code-reviews.appspot.com/1221801/diff/1/54#newcode63
user/test/com/google/gwt/dev/jjs/scriptonly/ScriptOnlyTest.java:63: //
Try something you can't do in web-mode (server code)
s/web-mode/Production Mode
http://gwt-code-reviews.appspot.com/1221801/diff/1/59
File user/test/com/google/gwt/dev/jjs/test/JsStaticEvalTest.java
(right):
http://gwt-code-reviews.appspot.com/1221801/diff/1/59#newcode24
user/test/com/google/gwt/dev/jjs/test/JsStaticEvalTest.java:24: *
Development Mode due to browser inconsistencies; however it should run
in web
s/web/Production
http://gwt-code-reviews.appspot.com/1221801/diff/1/61
File user/test/com/google/gwt/dom/client/StyleTest.java (right):
http://gwt-code-reviews.appspot.com/1221801/diff/1/61#newcode110
user/test/com/google/gwt/dom/client/StyleTest.java:110: // TODO:
re-enable these cases when we finally drop linux Development Mode.
Hey, we can probably re-enable these now!
http://gwt-code-reviews.appspot.com/1221801/diff/1/76
File user/test/com/google/gwt/xml/client/XMLTest.java (right):
http://gwt-code-reviews.appspot.com/1221801/diff/1/76#newcode328
user/test/com/google/gwt/xml/client/XMLTest.java:328: */
umm, maybe time to re-enable this test too?
http://gwt-code-reviews.appspot.com/1221801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9438 committed - Edited wiki page BeanValidation through web user interface.
Revision: 9438 Author: ncha...@google.com Date: Wed Dec 15 16:41:34 2010 Log: Edited wiki page BeanValidation through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=9438 Modified: /wiki/BeanValidation.wiki === --- /wiki/BeanValidation.wiki Wed Dec 15 11:21:17 2010 +++ /wiki/BeanValidation.wiki Wed Dec 15 16:41:34 2010 @@ -18,6 +18,7 @@ * Calling the correct !ConstraintValidotor based on bean type (class). === Other Issues === - * Many errors that would happen at runtime instead fail to compile + * Many errors that would happen at runtime instead fail to compile. + * Composite Constraints don't work. * !ReportAsSingleViolation has no effect. * Message Localization [http://code.google.com/p/google-web-toolkit/issues/detail?id=5763 Issue 5763] -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9439 committed - Edited wiki page BeanValidation through web user interface.
Revision: 9439
Author: ncha...@google.com
Date: Wed Dec 15 17:27:19 2010
Log: Edited wiki page BeanValidation through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=9439
Modified:
/wiki/BeanValidation.wiki
===
--- /wiki/BeanValidation.wiki Wed Dec 15 16:41:34 2010
+++ /wiki/BeanValidation.wiki Wed Dec 15 17:27:19 2010
@@ -7,17 +7,37 @@
= Introduction =
GWT supports a subset of JSR 303 Bean Validation.
+At compile time GWT validation uses the same Validation Provider you use
on the server to create Validator for all your objects
+
+= Quick Start =
+
+Annotate you beans with contstrants
+(see
[http://code.google.com/p/google-web-toolkit/source/browse/trunk/samples/validation/src/com/google/gwt/sample/validation/shared/Person.java
Person.java])
+
+{{{
+public class Person implements IsSerializable {
+ @Size(min = 4)
+ private String name;
+}}}
+
+Use the standard validation bootstrap to get a Validator on the client and
validate your object
+(see
[http://code.google.com/p/google-web-toolkit/source/browse/trunk/samples/validation/src/com/google/gwt/sample/validation/client/ValidationView.javaValidationView.java])
+{{{
+Validator validator =
Validation.buildDefaultValidatorFactory().getValidator();
+SetConstraintViolationPerson violations = validator.validate(person);
+}}}
+
== What is not supported ==
* XML configuration
* Validating non GWT compatible classes like Calendar
-== Known Issues ==
-
-=== Critical Bugs ===
+= Known Issues =
+
+== Critical Bugs ==
* Calling the correct !ConstraintValidotor based on bean type (class).
-=== Other Issues ===
+== Other Issues ==
* Many errors that would happen at runtime instead fail to compile.
* Composite Constraints don't work.
* !ReportAsSingleViolation has no effect.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9440 committed - Fixed link
Revision: 9440
Author: ncha...@google.com
Date: Wed Dec 15 17:27:55 2010
Log: Fixed link
http://code.google.com/p/google-web-toolkit/source/detail?r=9440
Modified:
/wiki/BeanValidation.wiki
===
--- /wiki/BeanValidation.wiki Wed Dec 15 17:27:19 2010
+++ /wiki/BeanValidation.wiki Wed Dec 15 17:27:55 2010
@@ -21,7 +21,7 @@
}}}
Use the standard validation bootstrap to get a Validator on the client and
validate your object
-(see
[http://code.google.com/p/google-web-toolkit/source/browse/trunk/samples/validation/src/com/google/gwt/sample/validation/client/ValidationView.javaValidationView.java])
+(see
[http://code.google.com/p/google-web-toolkit/source/browse/trunk/samples/validation/src/com/google/gwt/sample/validation/client/ValidationView.java
ValidationView.java])
{{{
Validator validator =
Validation.buildDefaultValidatorFactory().getValidator();
SetConstraintViolationPerson violations = validator.validate(person);
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9441 committed - Show the SampleValidator
Revision: 9441
Author: ncha...@google.com
Date: Wed Dec 15 17:32:29 2010
Log: Show the SampleValidator
http://code.google.com/p/google-web-toolkit/source/detail?r=9441
Modified:
/wiki/BeanValidation.wiki
===
--- /wiki/BeanValidation.wiki Wed Dec 15 17:27:55 2010
+++ /wiki/BeanValidation.wiki Wed Dec 15 17:32:29 2010
@@ -26,6 +26,29 @@
Validator validator =
Validation.buildDefaultValidatorFactory().getValidator();
SetConstraintViolationPerson violations = validator.validate(person);
}}}
+
+
+Follow this pattern to create a Validator for the object you want to
validate at runtime. (see
[http://code.google.com/p/google-web-toolkit/source/browse/trunk/samples/validation/src/com/google/gwt/sample/validation/client/SampleValidator.java
SampleValidator.java])
+
+{{{
+public class SampleValidator extends AbstractValidator {
+
+ /**
+ * Validator marker for the Validation Sample project. Only the classes
listed
+ * in the {...@link GwtValidation} annotation can be validated.
+ */
+ @GwtValidation(value = Person.class)
+ public interface GwtValidator extends Validator {
+ }
+
+ public SampleValidator() {
+super((Validator) GWT.create(SampleValidator.GwtValidator.class));
+ }
+}
+}}}
+
+
+Add replace with tag in your gwt.xml file to tell GWT which validator to
use
== What is not supported ==
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9442 committed - Show what to put in your gwt.xml file.
Revision: 9442
Author: ncha...@google.com
Date: Wed Dec 15 17:35:14 2010
Log: Show what to put in your gwt.xml file.
http://code.google.com/p/google-web-toolkit/source/detail?r=9442
Modified:
/wiki/BeanValidation.wiki
===
--- /wiki/BeanValidation.wiki Wed Dec 15 17:32:29 2010
+++ /wiki/BeanValidation.wiki Wed Dec 15 17:35:14 2010
@@ -48,8 +48,15 @@
}}}
-Add replace with tag in your gwt.xml file to tell GWT which validator to
use
-
+Add _replace-with_ tag in your gwt modle file telling GWT to use the
Validator you just defined
+(see
[http://code.google.com/p/google-web-toolkit/source/browse/trunk/samples/validation/src/com/google/gwt/sample/validation/Validation.gwt.xml
Validation.gwt.xml])
+
+{{{
+replace-with
+class=com.google.gwt.sample.validation.client.SampleValidator
+when-type-is class=javax.validation.Validator /
+/replace-with
+}}}
== What is not supported ==
* XML configuration
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Initial version of HTML5 Audio and Video (issue1195801)
LGTM
Don't forget test cases.
You guys are doing an awesome job with the HTML5 stuff! I can't wait to
see this stuff in action.
http://gwt-code-reviews.appspot.com/1195801/diff/3001/4004
File user/src/com/google/gwt/dom/client/MediaElement.java (right):
http://gwt-code-reviews.appspot.com/1195801/diff/3001/4004#newcode178
user/src/com/google/gwt/dom/client/MediaElement.java:178: return
this.error;
What does this return if there is no error? Is it null or undefined?
Might be better to do return this.error || null just in case.
http://gwt-code-reviews.appspot.com/1195801/diff/3001/4004#newcode309
user/src/com/google/gwt/dom/client/MediaElement.java:309: * controls
(e.g., for controlling play./pause, seek position, and volume),
replace e.g with such as. We avoid abbreviations because some
international users don't recognize them.
Also, play./pause should be play/pause.
http://gwt-code-reviews.appspot.com/1195801/diff/3001/4004#newcode410
user/src/com/google/gwt/dom/client/MediaElement.java:410: * Causes
playback of the resource to be (re)started.
Does it restart or resume if it is already started? How about Causes
playback of the resource to be started or resumed.
http://gwt-code-reviews.appspot.com/1195801/diff/3001/4004#newcode516
user/src/com/google/gwt/dom/client/MediaElement.java:516: public final
native void setSrc(String url) /*-{
instead of setAttribute(), can we use this.src = url
http://gwt-code-reviews.appspot.com/1195801/diff/3001/4007
File user/src/com/google/gwt/media/client/Audio.java (right):
http://gwt-code-reviews.appspot.com/1195801/diff/3001/4007#newcode68
user/src/com/google/gwt/media/client/Audio.java:68: public AudioElement
getAudioElement() {
Can we just override the return value of getElement()?
http://gwt-code-reviews.appspot.com/1195801/diff/3001/4008
File user/src/com/google/gwt/media/client/Video.java (right):
http://gwt-code-reviews.appspot.com/1195801/diff/3001/4008#newcode68
user/src/com/google/gwt/media/client/Video.java:68: public VideoElement
getVideoElement() {
I suggest overriding the return value of getElement() instead of
creating a new method.
http://gwt-code-reviews.appspot.com/1195801/diff/3001/4010
File user/src/com/google/gwt/media/dom/DOM.gwt.xml (right):
http://gwt-code-reviews.appspot.com/1195801/diff/3001/4010#newcode18
user/src/com/google/gwt/media/dom/DOM.gwt.xml:18: inherits
name=com.google.gwt.media.dom.DOM/
Should inherit com.google.gwt.dom.DOM, not com.google.gwt.media.dom.DOM
http://gwt-code-reviews.appspot.com/1195801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9443 committed - Add some best practices.
Revision: 9443 Author: ncha...@google.com Date: Wed Dec 15 17:44:56 2010 Log: Add some best practices. http://code.google.com/p/google-web-toolkit/source/detail?r=9443 Modified: /wiki/BeanValidation.wiki === --- /wiki/BeanValidation.wiki Wed Dec 15 17:35:14 2010 +++ /wiki/BeanValidation.wiki Wed Dec 15 17:44:56 2010 @@ -58,7 +58,12 @@ /replace-with }}} -== What is not supported == + += Best Practices = + * Use Groups to specify what constraints to run on the client + * Super source Validator that are not GWT compatible using NotGwtCompatibleValidator (see [http://code.google.com/p/google-web-toolkit/source/browse/trunk/user/src/org/hibernate/validator/super/org/hibernate/validator/constraints/impl/FutureValidatorForCalendar.java FutureValidatorForCalendar.java]) + * += What is not supported = * XML configuration * Validating non GWT compatible classes like Calendar -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9444 committed - Edited wiki page BeanValidation through web user interface.
Revision: 9444
Author: ncha...@google.com
Date: Wed Dec 15 17:53:36 2010
Log: Edited wiki page BeanValidation through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=9444
Modified:
/wiki/BeanValidation.wiki
===
--- /wiki/BeanValidation.wiki Wed Dec 15 17:44:56 2010
+++ /wiki/BeanValidation.wiki Wed Dec 15 17:53:36 2010
@@ -28,7 +28,7 @@
}}}
-Follow this pattern to create a Validator for the object you want to
validate at runtime. (see
[http://code.google.com/p/google-web-toolkit/source/browse/trunk/samples/validation/src/com/google/gwt/sample/validation/client/SampleValidator.java
SampleValidator.java])
+Follow this pattern to create a Validator for the objects you want to
validate on the client. (see
[http://code.google.com/p/google-web-toolkit/source/browse/trunk/samples/validation/src/com/google/gwt/sample/validation/client/SampleValidator.java
SampleValidator.java])
{{{
public class SampleValidator extends AbstractValidator {
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9445 committed - Removing the 2.1.1 tag.
Revision: 9445 Author: p...@google.com Date: Wed Dec 15 18:08:36 2010 Log: Removing the 2.1.1 tag. http://code.google.com/p/google-web-toolkit/source/detail?r=9445 Deleted: /tags/2.1.1 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9446 committed - Adding the 2.1.1 tag.
Revision: 9446 Author: p...@google.com Date: Wed Dec 15 18:09:08 2010 Log: Adding the 2.1.1 tag. http://code.google.com/p/google-web-toolkit/source/detail?r=9446 Added: /tags/2.1.1 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9447 committed - Edited wiki page BeanValidation through web user interface.
Revision: 9447
Author: ncha...@google.com
Date: Wed Dec 15 21:26:44 2010
Log: Edited wiki page BeanValidation through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=9447
Modified:
/wiki/BeanValidation.wiki
===
--- /wiki/BeanValidation.wiki Wed Dec 15 17:53:36 2010
+++ /wiki/BeanValidation.wiki Wed Dec 15 21:26:44 2010
@@ -15,7 +15,7 @@
(see
[http://code.google.com/p/google-web-toolkit/source/browse/trunk/samples/validation/src/com/google/gwt/sample/validation/shared/Person.java
Person.java])
{{{
-public class Person implements IsSerializable {
+public class Person {
@Size(min = 4)
private String name;
}}}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9448 committed - Edited wiki page BeanValidation through web user interface.
Revision: 9448
Author: ncha...@google.com
Date: Wed Dec 15 22:17:01 2010
Log: Edited wiki page BeanValidation through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=9448
Modified:
/wiki/BeanValidation.wiki
===
--- /wiki/BeanValidation.wiki Wed Dec 15 21:26:44 2010
+++ /wiki/BeanValidation.wiki Wed Dec 15 22:17:01 2010
@@ -47,11 +47,12 @@
}
}}}
-
+Include the module for your Validation Provider.
Add _replace-with_ tag in your gwt modle file telling GWT to use the
Validator you just defined
(see
[http://code.google.com/p/google-web-toolkit/source/browse/trunk/samples/validation/src/com/google/gwt/sample/validation/Validation.gwt.xml
Validation.gwt.xml])
{{{
+inherits name=org.hibernate.validator.HibernateValidator /
replace-with
class=com.google.gwt.sample.validation.client.SampleValidator
when-type-is class=javax.validation.Validator /
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
