[gwt-contrib] Support runAsync with the cross-site linker. (issue243802)
Reviewers: cromwellian, Description: Support runAsync with the cross-site linker. Review at http://gwt-code-reviews.appspot.com/213801 Please review this at http://gwt-code-reviews.appspot.com/243802/show Affected files: M dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java M dev/core/src/com/google/gwt/core/linker/IFrameLinker.java M dev/core/src/com/google/gwt/core/linker/XSLinker.java M dev/core/src/com/google/gwt/core/linker/XSTemplate.js M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java M dev/core/src/com/google/gwt/dev/jjs/impl/FragmentLoaderCreator.java A dev/core/src/com/google/gwt/dev/jjs/impl/HandleCrossFragmentReferences.java M dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java M dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java A dev/core/test/com/google/gwt/dev/js/JavaScriptStringTest.java M user/src/com/google/gwt/core/CompilerParameters.gwt.xml M user/src/com/google/gwt/core/Core.gwt.xml A user/src/com/google/gwt/core/XSLinker.gwt.xml M user/src/com/google/gwt/core/client/impl/AsyncFragmentLoader.java A user/src/com/google/gwt/core/client/impl/CrossSiteLoadingStrategy.java M user/src/com/google/gwt/core/client/impl/XhrLoadingStrategy.java M user/test/com/google/gwt/core/client/impl/AsyncFragmentLoaderTest.java M user/test/com/google/gwt/core/client/impl/XhrLoadingStrategyTest.java A user/test/com/google/gwt/dev/jjs/CompilerSuiteCrossSite.gwt.xml A user/test/com/google/gwt/dev/jjs/CrossSiteRunAsyncFailure.gwt.xml A user/test/com/google/gwt/dev/jjs/CrossSiteRunAsyncMetrics.gwt.xml A user/test/com/google/gwt/dev/jjs/CrossSiteRunAsyncSuite.java M user/test/com/google/gwt/dev/jjs/RunAsyncFailure.gwt.xml M user/test/com/google/gwt/dev/jjs/RunAsyncMetricsIntegrationTest.gwt.xml A user/test/com/google/gwt/dev/jjs/public/empty-gwt-stats.js A user/test/com/google/gwt/dev/jjs/test/CrossSiteRunAsyncFailureTest.java A user/test/com/google/gwt/dev/jjs/test/CrossSiteRunAsyncMetricsTest.java A user/test/com/google/gwt/dev/jjs/test/CrossSiteRunAsyncTest.java M user/test/com/google/gwt/dev/jjs/test/RunAsyncFailureTest.java A user/test/com/google/gwt/user/client/runasync/CrossSiteLoadingStrategyForRunAsyncFailureTest.java M user/test/com/google/gwt/user/server/runasync/RunAsyncFailureServlet.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors To unsubscribe from this group, send email to google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with the words REMOVE ME as the subject.
Re: [gwt-contrib] Support runAsync with the cross-site linker.
On Mon, Mar 15, 2010 at 8:34 PM, Joel Webber j...@google.com wrote: That's great news, and will really help with efforts to make our linkers more sane. Out of curiosity, what's the strategy for loading fragments into the enclosing namespace (and yes, that's the sound of me being too lazy to dig into the patch)? No, it should be documented separately from the patch. Here you go: http://code.google.com/p/google-web-toolkit/wiki/CrossSiteRunAsync http://code.google.com/p/google-web-toolkit/wiki/CrossSiteRunAsync-Lex -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Support runAsync with the cross-site linker.
Something is screwy with riedvelt, and I can't leave a comment on XSTemplate.js My comment isn't really about your patch in particular, but the patterns we are using in the linker templates. I wish that stanzas of code common to many linkers, like the calling of __gwtStatsEvent() could be extracted and put into the template with variable substitution. For example, adding the sessionId field to the event works fine here, but there are several linkers outside of GWT that will need to be updated to get the same fix. -Eric. On Mon, Mar 15, 2010 at 6:17 PM, sp...@google.com wrote: Reviewers: cromwellian, Description: Support runAsync with the cross-site linker. Please review this at http://gwt-code-reviews.appspot.com/213801 Affected files: M dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java M dev/core/src/com/google/gwt/core/linker/IFrameLinker.java M dev/core/src/com/google/gwt/core/linker/XSLinker.java M dev/core/src/com/google/gwt/core/linker/XSTemplate.js M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java M dev/core/src/com/google/gwt/dev/jjs/impl/FragmentLoaderCreator.java A dev/core/src/com/google/gwt/dev/jjs/impl/HandleCrossIslandReferences.java M dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java M dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java A dev/core/test/com/google/gwt/dev/js/JavaScriptStringTest.java M user/src/com/google/gwt/core/CompilerParameters.gwt.xml M user/src/com/google/gwt/core/Core.gwt.xml A user/src/com/google/gwt/core/XSLinker.gwt.xml user/src/com/google/gwt/core/client/impl/AsyncFragmentLoader.java A user/src/com/google/gwt/core/client/impl/CrossSiteLoadingStrategy.java M user/src/com/google/gwt/core/client/impl/XhrLoadingStrategy.java M user/test/com/google/gwt/core/client/impl/AsyncFragmentLoaderTest.java M user/test/com/google/gwt/core/client/impl/XhrLoadingStrategyTest.java A user/test/com/google/gwt/dev/jjs/CompilerSuiteCrossSite.gwt.xml A user/test/com/google/gwt/dev/jjs/CrossSiteRunAsyncFailure.gwt.xml A user/test/com/google/gwt/dev/jjs/CrossSiteRunAsyncMetrics.gwt.xml A user/test/com/google/gwt/dev/jjs/CrossSiteRunAsyncSuite.java M user/test/com/google/gwt/dev/jjs/RunAsyncFailure.gwt.xml M user/test/com/google/gwt/dev/jjs/RunAsyncMetricsIntegrationTest.gwt.xml user/test/com/google/gwt/dev/jjs/public/empty-gwt-stats.js A user/test/com/google/gwt/dev/jjs/test/CrossSiteRunAsyncFailureTest.java A user/test/com/google/gwt/dev/jjs/test/CrossSiteRunAsyncMetricsTest.java A user/test/com/google/gwt/dev/jjs/test/CrossSiteRunAsyncTest.java M user/test/com/google/gwt/dev/jjs/test/RunAsyncFailureTest.java A user/test/com/google/gwt/user/client/runasync/CrossSiteLoadingStrategyForRunAsyncFailureTest.java D user/test/com/google/gwt/user/server/runasync/RunAsyncFailureIFrameLinker.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- Eric Z. Ayers Google Web Toolkit, Atlanta, GA USA Sign up now for Google I/O 2010: May 19-20, http://code.google.com/io -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Support runAsync with the cross-site linker.
On Tue, Mar 16, 2010 at 11:54 AM, Eric Ayers zun...@google.com wrote: Something is screwy with riedvelt, and I can't leave a comment on XSTemplate.js My comment isn't really about your patch in particular, but the patterns we are using in the linker templates. I wish that stanzas of code common to many linkers, like the calling of __gwtStatsEvent() could be extracted and put into the template with variable substitution. For example, adding the sessionId field to the event works fine here, but there are several linkers outside of GWT that will need to be updated to get the same fix. Yes. Indeed, this fix originally went into the iframe linker and it was overlooked for the cross-site linker. Using more templating should help us not have to duplicate code so much. I was thinking in the short term to pull out computeScriptBase and processMetas into their own file. Code that wants to pull it in could insert COMPUTE_SCRIPT_BASE or PROCESS_METAS at the place it should go. As well, the code can then be tested more conveniently. Perhaps, though, we may as well define a general INCLUDE(processMetas.js) ? Lex -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Support runAsync with the cross-site linker.
On Tue, Mar 16, 2010 at 1:47 PM, Lex Spoon sp...@google.com wrote: Yes. Indeed, this fix originally went into the iframe linker and it was overlooked for the cross-site linker. Using more templating should help us not have to duplicate code so much. I was thinking in the short term to pull out computeScriptBase and processMetas into their own file. Code that wants to pull it in could insert COMPUTE_SCRIPT_BASE or PROCESS_METAS at the place it should go. As well, the code can then be tested more conveniently. Perhaps, though, we may as well define a general INCLUDE(processMetas.js) ? I think everyone agrees that we need some sort of approach to reduce code duplication here (and I think a similar problem exists in property providers -- right now if I want to slightly extend a property provider I have to cut and paste it). I think there are differences on exactly how far we should go, and since everybody has more than enough to do already nobody has grabbed the horns. -- John A. Tamplin Software Engineer (GWT), Google -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Support runAsync with the cross-site linker.
Reviewers: cromwellian, Description: Support runAsync with the cross-site linker. Please review this at http://gwt-code-reviews.appspot.com/213801 Affected files: M dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java M dev/core/src/com/google/gwt/core/linker/IFrameLinker.java M dev/core/src/com/google/gwt/core/linker/XSLinker.java M dev/core/src/com/google/gwt/core/linker/XSTemplate.js M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java M dev/core/src/com/google/gwt/dev/jjs/impl/FragmentLoaderCreator.java A dev/core/src/com/google/gwt/dev/jjs/impl/HandleCrossIslandReferences.java M dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java M dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java A dev/core/test/com/google/gwt/dev/js/JavaScriptStringTest.java M user/src/com/google/gwt/core/CompilerParameters.gwt.xml M user/src/com/google/gwt/core/Core.gwt.xml A user/src/com/google/gwt/core/XSLinker.gwt.xml user/src/com/google/gwt/core/client/impl/AsyncFragmentLoader.java A user/src/com/google/gwt/core/client/impl/CrossSiteLoadingStrategy.java M user/src/com/google/gwt/core/client/impl/XhrLoadingStrategy.java M user/test/com/google/gwt/core/client/impl/AsyncFragmentLoaderTest.java M user/test/com/google/gwt/core/client/impl/XhrLoadingStrategyTest.java A user/test/com/google/gwt/dev/jjs/CompilerSuiteCrossSite.gwt.xml A user/test/com/google/gwt/dev/jjs/CrossSiteRunAsyncFailure.gwt.xml A user/test/com/google/gwt/dev/jjs/CrossSiteRunAsyncMetrics.gwt.xml A user/test/com/google/gwt/dev/jjs/CrossSiteRunAsyncSuite.java M user/test/com/google/gwt/dev/jjs/RunAsyncFailure.gwt.xml M user/test/com/google/gwt/dev/jjs/RunAsyncMetricsIntegrationTest.gwt.xml user/test/com/google/gwt/dev/jjs/public/empty-gwt-stats.js A user/test/com/google/gwt/dev/jjs/test/CrossSiteRunAsyncFailureTest.java A user/test/com/google/gwt/dev/jjs/test/CrossSiteRunAsyncMetricsTest.java A user/test/com/google/gwt/dev/jjs/test/CrossSiteRunAsyncTest.java M user/test/com/google/gwt/dev/jjs/test/RunAsyncFailureTest.java A user/test/com/google/gwt/user/client/runasync/CrossSiteLoadingStrategyForRunAsyncFailureTest.java D user/test/com/google/gwt/user/server/runasync/RunAsyncFailureIFrameLinker.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Support runAsync with the cross-site linker.
That's great news, and will really help with efforts to make our linkers more sane. Out of curiosity, what's the strategy for loading fragments into the enclosing namespace (and yes, that's the sound of me being too lazy to dig into the patch)? On Mon, Mar 15, 2010 at 6:17 PM, sp...@google.com wrote: Reviewers: cromwellian, Description: Support runAsync with the cross-site linker. Please review this at http://gwt-code-reviews.appspot.com/213801 Affected files: M dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java M dev/core/src/com/google/gwt/core/linker/IFrameLinker.java M dev/core/src/com/google/gwt/core/linker/XSLinker.java M dev/core/src/com/google/gwt/core/linker/XSTemplate.js M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java M dev/core/src/com/google/gwt/dev/jjs/impl/FragmentLoaderCreator.java A dev/core/src/com/google/gwt/dev/jjs/impl/HandleCrossIslandReferences.java M dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java M dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java A dev/core/test/com/google/gwt/dev/js/JavaScriptStringTest.java M user/src/com/google/gwt/core/CompilerParameters.gwt.xml M user/src/com/google/gwt/core/Core.gwt.xml A user/src/com/google/gwt/core/XSLinker.gwt.xml user/src/com/google/gwt/core/client/impl/AsyncFragmentLoader.java A user/src/com/google/gwt/core/client/impl/CrossSiteLoadingStrategy.java M user/src/com/google/gwt/core/client/impl/XhrLoadingStrategy.java M user/test/com/google/gwt/core/client/impl/AsyncFragmentLoaderTest.java M user/test/com/google/gwt/core/client/impl/XhrLoadingStrategyTest.java A user/test/com/google/gwt/dev/jjs/CompilerSuiteCrossSite.gwt.xml A user/test/com/google/gwt/dev/jjs/CrossSiteRunAsyncFailure.gwt.xml A user/test/com/google/gwt/dev/jjs/CrossSiteRunAsyncMetrics.gwt.xml A user/test/com/google/gwt/dev/jjs/CrossSiteRunAsyncSuite.java M user/test/com/google/gwt/dev/jjs/RunAsyncFailure.gwt.xml M user/test/com/google/gwt/dev/jjs/RunAsyncMetricsIntegrationTest.gwt.xml user/test/com/google/gwt/dev/jjs/public/empty-gwt-stats.js A user/test/com/google/gwt/dev/jjs/test/CrossSiteRunAsyncFailureTest.java A user/test/com/google/gwt/dev/jjs/test/CrossSiteRunAsyncMetricsTest.java A user/test/com/google/gwt/dev/jjs/test/CrossSiteRunAsyncTest.java M user/test/com/google/gwt/dev/jjs/test/RunAsyncFailureTest.java A user/test/com/google/gwt/user/client/runasync/CrossSiteLoadingStrategyForRunAsyncFailureTest.java D user/test/com/google/gwt/user/server/runasync/RunAsyncFailureIFrameLinker.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
