Re: [PATCH] Improved `scm_from_locale_symbol ()' + `scm_take_locale_symbol ()'
Hello, Ken Raeburn [EMAIL PROTECTED] writes: As for the politics, you may have noticed that GNU is a somewhat politically motivated project... :-) But I have no idea if the choice of arch is official, or just what some volunteers were willing to support; ask RMS if you want to know the official position. The GNU Project contains two RCS: RCS and Arch. Arch is distributed, RCS is not. I don't think these are really politics: it's about building a consistent system, the GNU system. If Arch was technically so bad that it would impede development of the GNU system, it would obviously be a bad choice for the GNU Project (e.g., CVS was used because it could do more things than RCS); but that is clearly not the case, quite the contrary. :-) Thanks, Ludovic. ___ Guile-devel mailing list Guile-devel@gnu.org http://lists.gnu.org/mailman/listinfo/guile-devel
Re: [PATCH] Improved `scm_from_locale_symbol ()' + `scm_take_locale_symbol ()'
In article [EMAIL PROTECTED], Ludovic Courtès [EMAIL PROTECTED] wrote: Hi, The patch below does two things: 1. It introduces `scm_take_locale_symbol ()'. 2. It modifies `scm_from_locale_symbol ()' so that it doesn't create a Scheme string to do the job. This second modification has a nice effect: it can significantly reduce the number of objects created at load-time. Unfortunately, Guile's built-in reader always produces Scheme strings (in `scm_read_token ()') so it cannot benefit from this optimization. Why isn't it possible to write a take_symbol_from_string() which takes the C-string inside the SCM string, and sets the data of the SCM string to NULL? Or am I missing wrt to shared strings? ___ Guile-devel mailing list Guile-devel@gnu.org http://lists.gnu.org/mailman/listinfo/guile-devel
Re: [PATCH] Improved `scm_from_locale_symbol ()' + `scm_take_locale_symbol ()'
Hi, [EMAIL PROTECTED] (Han-Wen Nienhuys) writes: I think it looks OK. If noone steps forward, I will integrate it. Thanks! Have you considered asking Marius for CVS write access? One might arguably consider it inadequate. Beside, as long as patches are reviewed in a reasonable amount of time, I don't mind---but to be honest, I consider that more than one month is not so reasonable for patches like this one. ;-) In fact, I think we'd greatly benefit from using a distributed revision control system like GNU Arch: it really makes it easier to collaborate, both for the occasional contributors and for the maintainer(s). Thanks to it, I found myself contributing to projects where I wouldn't even have tried to do so if they were using a centralized RCS like CVS or Subversion. I just tried to apply it, however, whenever I save the file, I get spurious linebreaks. Can you put up a gzipped or uucoded version of the patch somewhere? Here it is: http://www.laas.fr/~lcourtes/software/from-locale-symbol.diff.gz . Thanks, Ludovic. ___ Guile-devel mailing list Guile-devel@gnu.org http://lists.gnu.org/mailman/listinfo/guile-devel
Re: [PATCH] Improved `scm_from_locale_symbol ()' + `scm_take_locale_symbol ()'
[EMAIL PROTECTED] (Han-Wen Nienhuys) writes: In article [EMAIL PROTECTED], Ludovic Courtès [EMAIL PROTECTED] wrote: [...] This second modification has a nice effect: it can significantly reduce the number of objects created at load-time. Unfortunately, Guile's built-in reader always produces Scheme strings (in `scm_read_token ()') so it cannot benefit from this optimization. Why isn't it possible to write a take_symbol_from_string() which takes the C-string inside the SCM string, and sets the data of the SCM string to NULL? Or am I missing wrt to shared strings? I'd say because the underlying `stringbuf' cannot be shared between a symbol and a string. Theoretically, it should be doable but we'd have to generalize things like `scm_i_string_writable_chars ()' so that it works also for symbols. Thanks, Ludovic. ___ Guile-devel mailing list Guile-devel@gnu.org http://lists.gnu.org/mailman/listinfo/guile-devel
Re: [PATCH] Improved `scm_from_locale_symbol ()' + `scm_take_locale_symbol ()'
In article [EMAIL PROTECTED], Ludovic Courtès [EMAIL PROTECTED] wrote: In fact, I think we'd greatly benefit from using a distributed revision control system like GNU Arch: it really makes it easier to collaborate, Yes, -- FWIW, I warmly recommend darcs, which is much easier to use. I just tried to apply it, however, whenever I save the file, I get spurious linebreaks. Can you put up a gzipped or uucoded version of the patch somewhere? Here it is: http://www.laas.fr/~lcourtes/software/from-locale-symbol.diff.gz . Nitpicks: I'm missing a ChangeLog. Arguably, you should also add your name to the contributors list in THANKS. Can you send a patch for that as well? ___ Guile-devel mailing list Guile-devel@gnu.org http://lists.gnu.org/mailman/listinfo/guile-devel
Re: [PATCH] Improved `scm_from_locale_symbol ()' + `scm_take_locale_symbol ()'
In article [EMAIL PROTECTED], Ludovic Courtès [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] (Han-Wen Nienhuys) writes: Yes, -- FWIW, I warmly recommend darcs, which is much easier to use. I don't think there's such a huge difference, especially when looking at [0]. Additionally, most of the commands shown there now have easy-looking counterparts taken from Bazaar, e.g., `branch', `switch', etc. Both Arch and Darcs are easy to administrate and deploy. Anyway, if we were to choose a DRCS for Guile, I think it'd make sense to favor the GNU implementation. This is offtopic, but I think that this is kind of politically motivated reasoning is not in GUILE's best interests. The changelog entries were in the email that started this thread: [EMAIL PROTECTED] . :-) Thanks, applied to CVS now. ___ Guile-devel mailing list Guile-devel@gnu.org http://lists.gnu.org/mailman/listinfo/guile-devel
Re: [PATCH] Improved `scm_from_locale_symbol ()' + `scm_take_locale_symbol ()'
[EMAIL PROTECTED] (Han-Wen Nienhuys) writes: Yes, -- FWIW, I warmly recommend darcs, which is much easier to use. I don't think there's such a huge difference, especially when looking at [0]. Additionally, most of the commands shown there now have easy-looking counterparts taken from Bazaar, e.g., `branch', `switch', etc. Both Arch and Darcs are easy to administrate and deploy. Anyway, if we were to choose a DRCS for Guile, I think it'd make sense to favor the GNU implementation. Nitpicks: I'm missing a ChangeLog. The changelog entries were in the email that started this thread: [EMAIL PROTECTED] . :-) Arguably, you should also add your name to the contributors list in THANKS. Can you send a patch for that as well? It occurred to me that I'm already listed there, not in the `contributors' section though---do you want me to move to this category? Thanks, Ludovic. [0] http://darcs.net/manual/node2.html#SECTION0023 ___ Guile-devel mailing list Guile-devel@gnu.org http://lists.gnu.org/mailman/listinfo/guile-devel
Re: [PATCH] Improved `scm_from_locale_symbol ()' + `scm_take_locale_symbol ()'
On Jan 24, 2006, at 16:06, Han-Wen Nienhuys wrote: In article [EMAIL PROTECTED], Ludovic Courtès [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] (Han-Wen Nienhuys) writes: Yes, -- FWIW, I warmly recommend darcs, which is much easier to use. I don't think there's such a huge difference, especially when looking at [0]. Additionally, most of the commands shown there now have easy-looking counterparts taken from Bazaar, e.g., `branch', `switch', etc. Both Arch and Darcs are easy to administrate and deploy. Anyway, if we were to choose a DRCS for Guile, I think it'd make sense to favor the GNU implementation. This is offtopic, but I think that this is kind of politically motivated reasoning is not in GUILE's best interests. The FSF is now running an arch server at savannah, see http:// arch.sv.gnu.org for info. As for the politics, you may have noticed that GNU is a somewhat politically motivated project... :-) But I have no idea if the choice of arch is official, or just what some volunteers were willing to support; ask RMS if you want to know the official position. (Personally, my preference would be svn, which I'm using at work, and svk for associated distributed work, but whatever) Ken ___ Guile-devel mailing list Guile-devel@gnu.org http://lists.gnu.org/mailman/listinfo/guile-devel
