[jira] [Commented] (HDFS-8217) During block recovery for truncate Log new Block Id in case of copy-on-truncate is true.
[ https://issues.apache.org/jira/browse/HDFS-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511071#comment-14511071 ] Hudson commented on HDFS-8217: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #2123 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2123/]) HDFS-8217. During block recovery for truncate Log new Block Id in case of copy-on-truncate is true. (Contributed by Vinayakumar B) (vinayakumarb: rev 262c1bc3398ce2ede03f9d86fc97c35ca7a8e9db) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > During block recovery for truncate Log new Block Id in case of > copy-on-truncate is true. > > > Key: HDFS-8217 > URL: https://issues.apache.org/jira/browse/HDFS-8217 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Reporter: Vinayakumar B >Assignee: Vinayakumar B > Fix For: 2.8.0 > > Attachments: HDFS-8217-01.patch > > > During the block recovery for the truncate, include the newblock Id in case > copy-on-truncate set to true. > Current log message is just as below. > {noformat}NameNode at /127.0.0.1:55036 calls > recoverBlock(BP-409377067-xx.xx.xx.253-1429679063755:blk_1073741825_1001, > targets=[DatanodeInfoWithStorage[127.0.0.1:55045,null,null]], > newGenerationStamp=1002){noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8217) During block recovery for truncate Log new Block Id in case of copy-on-truncate is true.
[ https://issues.apache.org/jira/browse/HDFS-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511032#comment-14511032 ] Hudson commented on HDFS-8217: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #174 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/174/]) HDFS-8217. During block recovery for truncate Log new Block Id in case of copy-on-truncate is true. (Contributed by Vinayakumar B) (vinayakumarb: rev 262c1bc3398ce2ede03f9d86fc97c35ca7a8e9db) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > During block recovery for truncate Log new Block Id in case of > copy-on-truncate is true. > > > Key: HDFS-8217 > URL: https://issues.apache.org/jira/browse/HDFS-8217 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Reporter: Vinayakumar B >Assignee: Vinayakumar B > Fix For: 2.8.0 > > Attachments: HDFS-8217-01.patch > > > During the block recovery for the truncate, include the newblock Id in case > copy-on-truncate set to true. > Current log message is just as below. > {noformat}NameNode at /127.0.0.1:55036 calls > recoverBlock(BP-409377067-xx.xx.xx.253-1429679063755:blk_1073741825_1001, > targets=[DatanodeInfoWithStorage[127.0.0.1:55045,null,null]], > newGenerationStamp=1002){noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8217) During block recovery for truncate Log new Block Id in case of copy-on-truncate is true.
[ https://issues.apache.org/jira/browse/HDFS-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510929#comment-14510929 ] Hudson commented on HDFS-8217: -- SUCCESS: Integrated in Hadoop-Yarn-trunk #907 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/907/]) HDFS-8217. During block recovery for truncate Log new Block Id in case of copy-on-truncate is true. (Contributed by Vinayakumar B) (vinayakumarb: rev 262c1bc3398ce2ede03f9d86fc97c35ca7a8e9db) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > During block recovery for truncate Log new Block Id in case of > copy-on-truncate is true. > > > Key: HDFS-8217 > URL: https://issues.apache.org/jira/browse/HDFS-8217 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Reporter: Vinayakumar B >Assignee: Vinayakumar B > Fix For: 2.8.0 > > Attachments: HDFS-8217-01.patch > > > During the block recovery for the truncate, include the newblock Id in case > copy-on-truncate set to true. > Current log message is just as below. > {noformat}NameNode at /127.0.0.1:55036 calls > recoverBlock(BP-409377067-xx.xx.xx.253-1429679063755:blk_1073741825_1001, > targets=[DatanodeInfoWithStorage[127.0.0.1:55045,null,null]], > newGenerationStamp=1002){noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8217) During block recovery for truncate Log new Block Id in case of copy-on-truncate is true.
[ https://issues.apache.org/jira/browse/HDFS-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510890#comment-14510890 ] Hudson commented on HDFS-8217: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #173 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/173/]) HDFS-8217. During block recovery for truncate Log new Block Id in case of copy-on-truncate is true. (Contributed by Vinayakumar B) (vinayakumarb: rev 262c1bc3398ce2ede03f9d86fc97c35ca7a8e9db) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java > During block recovery for truncate Log new Block Id in case of > copy-on-truncate is true. > > > Key: HDFS-8217 > URL: https://issues.apache.org/jira/browse/HDFS-8217 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Reporter: Vinayakumar B >Assignee: Vinayakumar B > Fix For: 2.8.0 > > Attachments: HDFS-8217-01.patch > > > During the block recovery for the truncate, include the newblock Id in case > copy-on-truncate set to true. > Current log message is just as below. > {noformat}NameNode at /127.0.0.1:55036 calls > recoverBlock(BP-409377067-xx.xx.xx.253-1429679063755:blk_1073741825_1001, > targets=[DatanodeInfoWithStorage[127.0.0.1:55045,null,null]], > newGenerationStamp=1002){noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8217) During block recovery for truncate Log new Block Id in case of copy-on-truncate is true.
[ https://issues.apache.org/jira/browse/HDFS-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510871#comment-14510871 ] Hudson commented on HDFS-8217: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #164 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/164/]) HDFS-8217. During block recovery for truncate Log new Block Id in case of copy-on-truncate is true. (Contributed by Vinayakumar B) (vinayakumarb: rev 262c1bc3398ce2ede03f9d86fc97c35ca7a8e9db) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java > During block recovery for truncate Log new Block Id in case of > copy-on-truncate is true. > > > Key: HDFS-8217 > URL: https://issues.apache.org/jira/browse/HDFS-8217 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Reporter: Vinayakumar B >Assignee: Vinayakumar B > Fix For: 2.8.0 > > Attachments: HDFS-8217-01.patch > > > During the block recovery for the truncate, include the newblock Id in case > copy-on-truncate set to true. > Current log message is just as below. > {noformat}NameNode at /127.0.0.1:55036 calls > recoverBlock(BP-409377067-xx.xx.xx.253-1429679063755:blk_1073741825_1001, > targets=[DatanodeInfoWithStorage[127.0.0.1:55045,null,null]], > newGenerationStamp=1002){noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8217) During block recovery for truncate Log new Block Id in case of copy-on-truncate is true.
[ https://issues.apache.org/jira/browse/HDFS-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510854#comment-14510854 ] Hudson commented on HDFS-8217: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2105 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2105/]) HDFS-8217. During block recovery for truncate Log new Block Id in case of copy-on-truncate is true. (Contributed by Vinayakumar B) (vinayakumarb: rev 262c1bc3398ce2ede03f9d86fc97c35ca7a8e9db) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > During block recovery for truncate Log new Block Id in case of > copy-on-truncate is true. > > > Key: HDFS-8217 > URL: https://issues.apache.org/jira/browse/HDFS-8217 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Reporter: Vinayakumar B >Assignee: Vinayakumar B > Fix For: 2.8.0 > > Attachments: HDFS-8217-01.patch > > > During the block recovery for the truncate, include the newblock Id in case > copy-on-truncate set to true. > Current log message is just as below. > {noformat}NameNode at /127.0.0.1:55036 calls > recoverBlock(BP-409377067-xx.xx.xx.253-1429679063755:blk_1073741825_1001, > targets=[DatanodeInfoWithStorage[127.0.0.1:55045,null,null]], > newGenerationStamp=1002){noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8217) During block recovery for truncate Log new Block Id in case of copy-on-truncate is true.
[ https://issues.apache.org/jira/browse/HDFS-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510569#comment-14510569 ] Hudson commented on HDFS-8217: -- FAILURE: Integrated in Hadoop-trunk-Commit #7660 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/7660/]) HDFS-8217. During block recovery for truncate Log new Block Id in case of copy-on-truncate is true. (Contributed by Vinayakumar B) (vinayakumarb: rev 262c1bc3398ce2ede03f9d86fc97c35ca7a8e9db) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > During block recovery for truncate Log new Block Id in case of > copy-on-truncate is true. > > > Key: HDFS-8217 > URL: https://issues.apache.org/jira/browse/HDFS-8217 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Reporter: Vinayakumar B >Assignee: Vinayakumar B > Fix For: 2.8.0 > > Attachments: HDFS-8217-01.patch > > > During the block recovery for the truncate, include the newblock Id in case > copy-on-truncate set to true. > Current log message is just as below. > {noformat}NameNode at /127.0.0.1:55036 calls > recoverBlock(BP-409377067-xx.xx.xx.253-1429679063755:blk_1073741825_1001, > targets=[DatanodeInfoWithStorage[127.0.0.1:55045,null,null]], > newGenerationStamp=1002){noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8217) During block recovery for truncate Log new Block Id in case of copy-on-truncate is true.
[ https://issues.apache.org/jira/browse/HDFS-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510549#comment-14510549 ] Vinayakumar B commented on HDFS-8217: - Removed the .02 patch to not to confuse further > During block recovery for truncate Log new Block Id in case of > copy-on-truncate is true. > > > Key: HDFS-8217 > URL: https://issues.apache.org/jira/browse/HDFS-8217 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Reporter: Vinayakumar B >Assignee: Vinayakumar B > Attachments: HDFS-8217-01.patch > > > During the block recovery for the truncate, include the newblock Id in case > copy-on-truncate set to true. > Current log message is just as below. > {noformat}NameNode at /127.0.0.1:55036 calls > recoverBlock(BP-409377067-xx.xx.xx.253-1429679063755:blk_1073741825_1001, > targets=[DatanodeInfoWithStorage[127.0.0.1:55045,null,null]], > newGenerationStamp=1002){noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8217) During block recovery for truncate Log new Block Id in case of copy-on-truncate is true.
[ https://issues.apache.org/jira/browse/HDFS-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510547#comment-14510547 ] Vinayakumar B commented on HDFS-8217: - Thanks [~shv] and [~zero45] I will commit the first version. > During block recovery for truncate Log new Block Id in case of > copy-on-truncate is true. > > > Key: HDFS-8217 > URL: https://issues.apache.org/jira/browse/HDFS-8217 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Reporter: Vinayakumar B >Assignee: Vinayakumar B > Attachments: HDFS-8217-01.patch, HDFS-8217-02.patch > > > During the block recovery for the truncate, include the newblock Id in case > copy-on-truncate set to true. > Current log message is just as below. > {noformat}NameNode at /127.0.0.1:55036 calls > recoverBlock(BP-409377067-xx.xx.xx.253-1429679063755:blk_1073741825_1001, > targets=[DatanodeInfoWithStorage[127.0.0.1:55045,null,null]], > newGenerationStamp=1002){noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8217) During block recovery for truncate Log new Block Id in case of copy-on-truncate is true.
[ https://issues.apache.org/jira/browse/HDFS-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510219#comment-14510219 ] Konstantin Shvachko commented on HDFS-8217: --- I think it is fine to ignore AvoidInlineConditionalsCheck. Automation tools should help improve code, but this one just forces you to write bunch of code for a simple LOG message. +1 on your first version. > During block recovery for truncate Log new Block Id in case of > copy-on-truncate is true. > > > Key: HDFS-8217 > URL: https://issues.apache.org/jira/browse/HDFS-8217 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Reporter: Vinayakumar B >Assignee: Vinayakumar B > Attachments: HDFS-8217-01.patch, HDFS-8217-02.patch > > > During the block recovery for the truncate, include the newblock Id in case > copy-on-truncate set to true. > Current log message is just as below. > {noformat}NameNode at /127.0.0.1:55036 calls > recoverBlock(BP-409377067-xx.xx.xx.253-1429679063755:blk_1073741825_1001, > targets=[DatanodeInfoWithStorage[127.0.0.1:55045,null,null]], > newGenerationStamp=1002){noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8217) During block recovery for truncate Log new Block Id in case of copy-on-truncate is true.
[ https://issues.apache.org/jira/browse/HDFS-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14508512#comment-14508512 ] Vinayakumar B commented on HDFS-8217: - Thanks [~zero45] for taking a look at the patch. bq. My only nit, I see you are changing the style of the LOG.info from String concat to StringBuilder. Yes I agree that style is changed. But It depends on how you use while building big messages and *conditional* messages. In the first patch (.01.patch) if you see, I followed the earlier approach, but since I used inline conditional statements I got checkstyle comment from [~hadoopqa]. And I thought StringBuilder would be better. > During block recovery for truncate Log new Block Id in case of > copy-on-truncate is true. > > > Key: HDFS-8217 > URL: https://issues.apache.org/jira/browse/HDFS-8217 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Reporter: Vinayakumar B >Assignee: Vinayakumar B > Attachments: HDFS-8217-01.patch, HDFS-8217-02.patch > > > During the block recovery for the truncate, include the newblock Id in case > copy-on-truncate set to true. > Current log message is just as below. > {noformat}NameNode at /127.0.0.1:55036 calls > recoverBlock(BP-409377067-xx.xx.xx.253-1429679063755:blk_1073741825_1001, > targets=[DatanodeInfoWithStorage[127.0.0.1:55045,null,null]], > newGenerationStamp=1002){noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8217) During block recovery for truncate Log new Block Id in case of copy-on-truncate is true.
[ https://issues.apache.org/jira/browse/HDFS-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507983#comment-14507983 ] Plamen Jeliazkov commented on HDFS-8217: Hi [~vinayrpet], Just looked over the work. My only nit, I see you are changing the style of the LOG.info from String concat to StringBuilder. It does change the overall style of other LOG.info statements and the two are equivalent after compilation so long as the String concat is not within a loop. Other than that, looks good! Thanks! > During block recovery for truncate Log new Block Id in case of > copy-on-truncate is true. > > > Key: HDFS-8217 > URL: https://issues.apache.org/jira/browse/HDFS-8217 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Reporter: Vinayakumar B >Assignee: Vinayakumar B > Attachments: HDFS-8217-01.patch, HDFS-8217-02.patch > > > During the block recovery for the truncate, include the newblock Id in case > copy-on-truncate set to true. > Current log message is just as below. > {noformat}NameNode at /127.0.0.1:55036 calls > recoverBlock(BP-409377067-xx.xx.xx.253-1429679063755:blk_1073741825_1001, > targets=[DatanodeInfoWithStorage[127.0.0.1:55045,null,null]], > newGenerationStamp=1002){noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8217) During block recovery for truncate Log new Block Id in case of copy-on-truncate is true.
[ https://issues.apache.org/jira/browse/HDFS-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506703#comment-14506703 ] Hadoop QA commented on HDFS-8217: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 14m 29s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | | {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | javac | 7m 26s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 31s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 22s | The applied patch does not increase the total number of release audit warnings. | | {color:red}-1{color} | checkstyle | 7m 34s | The applied patch generated 2 additional checkstyle issues. | | {color:green}+1{color} | install | 1m 32s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 35s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 3m 5s | The patch does not introduce any new Findbugs (version 2.0.3) warnings. | | {color:green}+1{color} | native | 3m 13s | Pre-build of native portion | | {color:green}+1{color} | hdfs tests | 166m 3s | Tests passed in hadoop-hdfs. | | | | 213m 54s | | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12727131/HDFS-8217-01.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 6f8003d | | checkstyle | https://builds.apache.org/job/PreCommit-HDFS-Build/10341/artifact/patchprocess/checkstyle-result-diff.txt | | hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/10341/artifact/patchprocess/testrun_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/10341/testReport/ | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/10341//console | This message was automatically generated. > During block recovery for truncate Log new Block Id in case of > copy-on-truncate is true. > > > Key: HDFS-8217 > URL: https://issues.apache.org/jira/browse/HDFS-8217 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Reporter: Vinayakumar B >Assignee: Vinayakumar B > Attachments: HDFS-8217-01.patch > > > During the block recovery for the truncate, include the newblock Id in case > copy-on-truncate set to true. > Current log message is just as below. > {noformat}NameNode at /127.0.0.1:55036 calls > recoverBlock(BP-409377067-xx.xx.xx.253-1429679063755:blk_1073741825_1001, > targets=[DatanodeInfoWithStorage[127.0.0.1:55045,null,null]], > newGenerationStamp=1002){noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)