[jira] [Commented] (CB-11985) Cordova hits internet unnecessarily when getting cached platform or plugin
[
https://issues.apache.org/jira/browse/CB-11985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15557352#comment-15557352
]
ASF GitHub Bot commented on CB-11985:
-
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/498
## [Current
coverage](https://codecov.io/gh/apache/cordova-lib/pull/498?src=pr) is 80.57%
(diff: 100%)
> Merging [#498](https://codecov.io/gh/apache/cordova-lib/pull/498?src=pr)
into [master](https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr)
will increase coverage by **0.17%**
```diff
@@ master #498 diff @@
==
Files67 67
Lines 5189 5205+16
Methods 836840 +4
Messages 0 0
Branches 1005 1007 +2
==
+ Hits 4172 4194+22
+ Misses 1017 1011 -6
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update
[4ca3b4c...83540e7](https://codecov.io/gh/apache/cordova-lib/compare/4ca3b4ca12a01ded923734e4d92d7f9325d540dc...83540e74027fa44769ff8b3e80bf35b3cba152dc?src=pr)
> Cordova hits internet unnecessarily when getting cached platform or plugin
> --
>
> Key: CB-11985
> URL: https://issues.apache.org/jira/browse/CB-11985
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CordovaLib
>Affects Versions: 6.3.1
>Reporter: Tim Barham
>Assignee: Tim Barham
>
> In you are disconnected from the internet and try to add a platform or plugin
> that has previously been cached, Cordova eventually successfully installs the
> platform/plugin, but only after a very long wait.
> We could check for the existence of the cached platform/plugin before calling
> {{npm cache add}}. This would mean an instant return when not connected to
> the internet.
> Note that this will only help if we are adding a specific version - when a
> version range is specified, we need to hit the internet anyway to find the
> matching version.
> Background: First time build failures in Cordova tools in Visual Studio are
> primarily due to {{npm}} failures. Therefore we are working to avoid any
> requirement for {{npm}}} to hit the internet in simple build scenarios. This
> includes pre-installing cached versions of certain platforms and plugins. But
> we only get the full benefit if Cordova uses these cached versions if it
> finds them, without calling {{npm cache add}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11985) Cordova hits internet unnecessarily when getting cached platform or plugin
[
https://issues.apache.org/jira/browse/CB-11985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15557058#comment-15557058
]
ASF GitHub Bot commented on CB-11985:
-
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-lib/pull/498
CB-11985 Check if cached platform/plugin exists before 'npm cache'
### What does this PR do?
Before calling `npm cache add` when installing a platform or plugin, look
for an existing `package.tgz` file in the cache directory. This avoids
unnecessary `npm` call with long timeout if not connected to the internet.
Background: First time build failures in Cordova tools in Visual Studio are
primarily due to `npm` failures. Therefore we are working to avoid any
requirement for `npm` to hit the internet in simple build scenarios. This
includes pre-installing cached versions of certain platforms and plugins. But
we only get the full benefit if Cordova uses these cached versions if it finds
them, without calling npm cache add.
A couple of things to note:
* This change uses shared code for platforms and plugins, and means plugins
will also be cached to the `.cordova` directory rather than the global npm
cache directory. Is that a concern?
* It is likely this change will be meaningless with the proposed changes to
installing platforms and plugins in Cordova 7.x. We'll cross the bridge when we
come to it 😄.
### What testing has been done on this change?
Local testing.
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB- is the JIRA ID & "android" is the platform
affected.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TimBarham/cordova-lib use-cached-platform
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/498.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #498
commit 667e774d46399cf97a9481c3890fa7a862871d46
Author: TimBarham
Date: 2016-10-07T22:58:35Z
CB-11985 Check if cached platform/plugin exists before 'npm cache'
This avoids unnecessary npm call with long timeout if not connected to the
internet.
> Cordova hits internet unnecessarily when getting cached platform or plugin
> --
>
> Key: CB-11985
> URL: https://issues.apache.org/jira/browse/CB-11985
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CordovaLib
>Affects Versions: 6.3.1
>Reporter: Tim Barham
>Assignee: Tim Barham
>
> In you are disconnected from the internet and try to add a platform or plugin
> that has previously been cached, Cordova eventually successfully installs the
> platform/plugin, but only after a very long wait.
> We could check for the existence of the cached platform/plugin before calling
> {{npm cache add}}. This would mean an instant return when not connected to
> the internet.
> Note that this will only help if we are adding a specific version - when a
> version range is specified, we need to hit the internet anyway to find the
> matching version.
> Background: First time build failures in Cordova tools in Visual Studio are
> primarily due to {{npm}} failures. Therefore we are working to avoid any
> requirement for {{npm}}} to hit the internet in simple build scenarios. This
> includes pre-installing cached versions of certain platforms and plugins. But
> we only get the full benefit if Cordova uses these cached versions if it
> finds them, without calling {{npm cache add}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11952) Should be able to pass flags to xcodebuild
[ https://issues.apache.org/jira/browse/CB-11952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15557040#comment-15557040 ] ASF GitHub Bot commented on CB-11952: - Github user adzellman commented on the issue: https://github.com/apache/cordova-ios/pull/265 I'm not sure why Travis would fail to run `n stable`. I just tried it locally and it installed v6.6.0 just fine. Can we re-trigger Travis? > Should be able to pass flags to xcodebuild > -- > > Key: CB-11952 > URL: https://issues.apache.org/jira/browse/CB-11952 > Project: Apache Cordova > Issue Type: Improvement > Components: iOS >Reporter: Andrew Zellman >Assignee: Shazron Abdullah > Labels: features > Fix For: cordova-ios@4.4.0 > > > Cordova developers should be able to pass additional flags to xcodebuild when > compiling their projects. This can be done by adding a --buildFlag option in > cordova-ios that allows multiples declarations. There will need to be > additional attention to conflicts that may happen with xcodebuild arguments > injected by Cordova. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11985) Cordova hits internet unnecessarily when getting cached platform or plugin
Tim Barham created CB-11985:
---
Summary: Cordova hits internet unnecessarily when getting cached
platform or plugin
Key: CB-11985
URL: https://issues.apache.org/jira/browse/CB-11985
Project: Apache Cordova
Issue Type: Improvement
Components: CordovaLib
Affects Versions: 6.3.1
Reporter: Tim Barham
Assignee: Tim Barham
In you are disconnected from the internet and try to add a platform or plugin
that has previously been cached, Cordova eventually successfully installs the
platform/plugin, but only after a very long wait.
We could check for the existence of the cached platform/plugin before calling
{{npm cache add}}. This would mean an instant return when not connected to the
internet.
Note that this will only help if we are adding a specific version - when a
version range is specified, we need to hit the internet anyway to find the
matching version.
Background: First time build failures in Cordova tools in Visual Studio are
primarily due to {{npm}} failures. Therefore we are working to avoid any
requirement for {{npm}}} to hit the internet in simple build scenarios. This
includes pre-installing cached versions of certain platforms and plugins. But
we only get the full benefit if Cordova uses these cached versions if it finds
them, without calling {{npm cache add}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11964) Gradle build failure after any plugin installation
[
https://issues.apache.org/jira/browse/CB-11964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556853#comment-15556853
]
ASF subversion and git services commented on CB-11964:
--
Commit 7d26c51da6c99d735a8462364e896c8cf35112de in cordova-android's branch
refs/heads/master from [~bowserj]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=7d26c51 ]
CB-11964: Do a clean when installing a plugin to et around the bug
> Gradle build failure after any plugin installation
> --
>
> Key: CB-11964
> URL: https://issues.apache.org/jira/browse/CB-11964
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
>Affects Versions: Master
> Environment: node 4.4.3
> cordova 6.3.0
>Reporter: Alexander Sorokin
> Labels: found-by-ci, triaged
>
> {noformat}
> cordova create foo
> cd foo
> cordova platform add android@https://github.com/apache/cordova-android
> cordova build
> cordova plugin add cordova-plugin-device
> cordova build
> {noformat}
> Results in the following error:
> {noformat}
> BUILD FAILED
> Total time: 2.439 secs
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException:
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> > (Access is denied)
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or
> --debug option to get more log output.
> Error: cmd: Command failed with exit code 1 Error output:
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException:
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> > (Access is denied)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11964) Gradle build failure after any plugin installation
[
https://issues.apache.org/jira/browse/CB-11964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556856#comment-15556856
]
ASF GitHub Bot commented on CB-11964:
-
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/339
> Gradle build failure after any plugin installation
> --
>
> Key: CB-11964
> URL: https://issues.apache.org/jira/browse/CB-11964
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
>Affects Versions: Master
> Environment: node 4.4.3
> cordova 6.3.0
>Reporter: Alexander Sorokin
> Labels: found-by-ci, triaged
>
> {noformat}
> cordova create foo
> cd foo
> cordova platform add android@https://github.com/apache/cordova-android
> cordova build
> cordova plugin add cordova-plugin-device
> cordova build
> {noformat}
> Results in the following error:
> {noformat}
> BUILD FAILED
> Total time: 2.439 secs
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException:
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> > (Access is denied)
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or
> --debug option to get more log output.
> Error: cmd: Command failed with exit code 1 Error output:
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException:
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> > (Access is denied)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11964) Gradle build failure after any plugin installation
[
https://issues.apache.org/jira/browse/CB-11964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556854#comment-15556854
]
ASF subversion and git services commented on CB-11964:
--
Commit 5db2de95f586eec1713656051e47c0d0bdc73a10 in cordova-android's branch
refs/heads/master from [~alsorokin]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=5db2de9 ]
CB-11964 Call clean after plugin install and mock it in tests
> Gradle build failure after any plugin installation
> --
>
> Key: CB-11964
> URL: https://issues.apache.org/jira/browse/CB-11964
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
>Affects Versions: Master
> Environment: node 4.4.3
> cordova 6.3.0
>Reporter: Alexander Sorokin
> Labels: found-by-ci, triaged
>
> {noformat}
> cordova create foo
> cd foo
> cordova platform add android@https://github.com/apache/cordova-android
> cordova build
> cordova plugin add cordova-plugin-device
> cordova build
> {noformat}
> Results in the following error:
> {noformat}
> BUILD FAILED
> Total time: 2.439 secs
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException:
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> > (Access is denied)
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or
> --debug option to get more log output.
> Error: cmd: Command failed with exit code 1 Error output:
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException:
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> > (Access is denied)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11952) Should be able to pass flags to xcodebuild
[
https://issues.apache.org/jira/browse/CB-11952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556849#comment-15556849
]
ASF GitHub Bot commented on CB-11952:
-
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/265#discussion_r82491705
--- Diff: bin/templates/scripts/cordova/lib/build.js ---
@@ -199,33 +219,52 @@ module.exports.findXCodeProjectIn =
findXCodeProjectIn;
* @param {Boolean} isDevice Flag that specify target for package
(device/emulator)
* @return {Array} Array of arguments that could be passed
directly to spawn method
*/
-function getXcodeBuildArgs(projectName, projectPath, configuration,
isDevice) {
+function getXcodeBuildArgs(projectName, projectPath, configuration,
isDevice, buildFlags) {
var xcodebuildArgs;
+var options;
+var buildActions = [ 'build' ];
+var settings;
+var customArgs = {};
+customArgs.otherFlags = [];
+
+if (buildFlags) {
+if (typeof buildFlags === 'string' || buildFlags instanceof
String) {
+parseBuildFlag(buildFlags, customArgs);
+} else { // buildFlags is an Array of strings
+buildFlags.forEach( function(flag) {
+parseBuildFlag(flag, customArgs);
+});
+}
+}
+
if (isDevice) {
-xcodebuildArgs = [
-'-xcconfig', path.join(__dirname, '..', 'build-' +
configuration.toLowerCase() + '.xcconfig'),
-'-workspace', projectName + '.xcworkspace',
-'-scheme', projectName,
-'-configuration', configuration,
-'-destination', 'generic/platform=iOS',
-'-archivePath', projectName + '.xcarchive',
-'archive',
--- End diff --
The automated tests do run the build command on Travis CI `npm run
e2e-tests`
There is no check whether the archive artifact was created though since we
can't really build for device on Travis
> Should be able to pass flags to xcodebuild
> --
>
> Key: CB-11952
> URL: https://issues.apache.org/jira/browse/CB-11952
> Project: Apache Cordova
> Issue Type: Improvement
> Components: iOS
>Reporter: Andrew Zellman
>Assignee: Shazron Abdullah
> Labels: features
> Fix For: cordova-ios@4.4.0
>
>
> Cordova developers should be able to pass additional flags to xcodebuild when
> compiling their projects. This can be done by adding a --buildFlag option in
> cordova-ios that allows multiples declarations. There will need to be
> additional attention to conflicts that may happen with xcodebuild arguments
> injected by Cordova.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11952) Should be able to pass flags to xcodebuild
[
https://issues.apache.org/jira/browse/CB-11952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556834#comment-15556834
]
ASF GitHub Bot commented on CB-11952:
-
Github user adzellman commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/265#discussion_r82491459
--- Diff: bin/templates/scripts/cordova/lib/build.js ---
@@ -199,33 +219,52 @@ module.exports.findXCodeProjectIn =
findXCodeProjectIn;
* @param {Boolean} isDevice Flag that specify target for package
(device/emulator)
* @return {Array} Array of arguments that could be passed
directly to spawn method
*/
-function getXcodeBuildArgs(projectName, projectPath, configuration,
isDevice) {
+function getXcodeBuildArgs(projectName, projectPath, configuration,
isDevice, buildFlags) {
var xcodebuildArgs;
+var options;
+var buildActions = [ 'build' ];
+var settings;
+var customArgs = {};
+customArgs.otherFlags = [];
+
+if (buildFlags) {
+if (typeof buildFlags === 'string' || buildFlags instanceof
String) {
+parseBuildFlag(buildFlags, customArgs);
+} else { // buildFlags is an Array of strings
+buildFlags.forEach( function(flag) {
+parseBuildFlag(flag, customArgs);
+});
+}
+}
+
if (isDevice) {
-xcodebuildArgs = [
-'-xcconfig', path.join(__dirname, '..', 'build-' +
configuration.toLowerCase() + '.xcconfig'),
-'-workspace', projectName + '.xcworkspace',
-'-scheme', projectName,
-'-configuration', configuration,
-'-destination', 'generic/platform=iOS',
-'-archivePath', projectName + '.xcarchive',
-'archive',
--- End diff --
Oh, it actually changed from the build command to the archive command.
That's interesting.
This was allowed in just a couple days ago with no automated tests. It'll
take me a little bit to make sure I didn't break anything.
> Should be able to pass flags to xcodebuild
> --
>
> Key: CB-11952
> URL: https://issues.apache.org/jira/browse/CB-11952
> Project: Apache Cordova
> Issue Type: Improvement
> Components: iOS
>Reporter: Andrew Zellman
>Assignee: Shazron Abdullah
> Labels: features
> Fix For: cordova-ios@4.4.0
>
>
> Cordova developers should be able to pass additional flags to xcodebuild when
> compiling their projects. This can be done by adding a --buildFlag option in
> cordova-ios that allows multiples declarations. There will need to be
> additional attention to conflicts that may happen with xcodebuild arguments
> injected by Cordova.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7969) plugin add ... makes it install for all platform when plugin.xml only supports 1 platform
[ https://issues.apache.org/jira/browse/CB-7969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556830#comment-15556830 ] Steve Gill commented on CB-7969: But what if the plugin is a js only plugin? No native files. Not a common case though > plugin add ... makes it install for all platform when plugin.xml only > supports 1 platform > - > > Key: CB-7969 > URL: https://issues.apache.org/jira/browse/CB-7969 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 3.6.0, 6.0.0 >Reporter: Darryl L. Miles > > plugin add ... makes it installed for all platform when plugin.xml only > supports 1 platform > $ cordova platform add blackberry10 > $ cordova platform add browser --usegit > $ cordova plugin add com.blackberry.notification > $ cordova build browser -d > See the output include the plugin when build 'browser'. > Now examine plugins\browser.json and the "installed_plugins" section, you > will see it got added there. > Now examine plugins\com.blackberry.notification\plugin.xml and see that the > element plugin.platform[name]="blackberry10" exists, but no other platform is > supported and not default platform config is provided. > So why was it installed for the "browser" platform ? > I think it is expected it only gets installed into the "blackberry10" > platform. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11952) Should be able to pass flags to xcodebuild
[
https://issues.apache.org/jira/browse/CB-11952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556813#comment-15556813
]
ASF GitHub Bot commented on CB-11952:
-
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/265#discussion_r82490970
--- Diff: bin/templates/scripts/cordova/lib/build.js ---
@@ -199,33 +219,52 @@ module.exports.findXCodeProjectIn =
findXCodeProjectIn;
* @param {Boolean} isDevice Flag that specify target for package
(device/emulator)
* @return {Array} Array of arguments that could be passed
directly to spawn method
*/
-function getXcodeBuildArgs(projectName, projectPath, configuration,
isDevice) {
+function getXcodeBuildArgs(projectName, projectPath, configuration,
isDevice, buildFlags) {
var xcodebuildArgs;
+var options;
+var buildActions = [ 'build' ];
+var settings;
+var customArgs = {};
+customArgs.otherFlags = [];
+
+if (buildFlags) {
+if (typeof buildFlags === 'string' || buildFlags instanceof
String) {
+parseBuildFlag(buildFlags, customArgs);
+} else { // buildFlags is an Array of strings
+buildFlags.forEach( function(flag) {
+parseBuildFlag(flag, customArgs);
+});
+}
+}
+
if (isDevice) {
-xcodebuildArgs = [
-'-xcconfig', path.join(__dirname, '..', 'build-' +
configuration.toLowerCase() + '.xcconfig'),
-'-workspace', projectName + '.xcworkspace',
-'-scheme', projectName,
-'-configuration', configuration,
-'-destination', 'generic/platform=iOS',
-'-archivePath', projectName + '.xcarchive',
-'archive',
--- End diff --
I think these are missing `-archivePath` and `archive`. See this PR:
https://github.com/apache/cordova-ios/pull/257
> Should be able to pass flags to xcodebuild
> --
>
> Key: CB-11952
> URL: https://issues.apache.org/jira/browse/CB-11952
> Project: Apache Cordova
> Issue Type: Improvement
> Components: iOS
>Reporter: Andrew Zellman
>Assignee: Shazron Abdullah
> Labels: features
> Fix For: cordova-ios@4.4.0
>
>
> Cordova developers should be able to pass additional flags to xcodebuild when
> compiling their projects. This can be done by adding a --buildFlag option in
> cordova-ios that allows multiples declarations. There will need to be
> additional attention to conflicts that may happen with xcodebuild arguments
> injected by Cordova.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11964) Gradle build failure after any plugin installation
[
https://issues.apache.org/jira/browse/CB-11964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556810#comment-15556810
]
ASF GitHub Bot commented on CB-11964:
-
Github user alsorokin commented on the issue:
https://github.com/apache/cordova-android/pull/339
Tested it on Windows, it works! LGTM
> Gradle build failure after any plugin installation
> --
>
> Key: CB-11964
> URL: https://issues.apache.org/jira/browse/CB-11964
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
>Affects Versions: Master
> Environment: node 4.4.3
> cordova 6.3.0
>Reporter: Alexander Sorokin
> Labels: found-by-ci, triaged
>
> {noformat}
> cordova create foo
> cd foo
> cordova platform add android@https://github.com/apache/cordova-android
> cordova build
> cordova plugin add cordova-plugin-device
> cordova build
> {noformat}
> Results in the following error:
> {noformat}
> BUILD FAILED
> Total time: 2.439 secs
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException:
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> > (Access is denied)
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or
> --debug option to get more log output.
> Error: cmd: Command failed with exit code 1 Error output:
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException:
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> > (Access is denied)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11970) Support CocoaPod pod specification other than version
[ https://issues.apache.org/jira/browse/CB-11970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556801#comment-15556801 ] ASF subversion and git services commented on CB-11970: -- Commit a527d1a08ee3e3a35ee0f1087c8e19f0946840c7 in cordova-ios's branch refs/heads/master from [~shazron] [ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=a527d1a ] CB-11970 - Support CocoaPod pod specification other than version This closes #267 > Support CocoaPod pod specification other than version > - > > Key: CB-11970 > URL: https://issues.apache.org/jira/browse/CB-11970 > Project: Apache Cordova > Issue Type: Improvement > Components: iOS >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > https://github.com/apache/cordova-ios/blob/636113f047ee2c7dae742dff2beafae2121ceb62/bin/templates/scripts/cordova/lib/Podfile.js#L149 > Podfile spec: > https://guides.cocoapods.org/syntax/podfile.html#pod > If the spec begins with a colon ":", don't quote it when writing to the > Podfile. > Make sure this function works as well, after: > https://github.com/apache/cordova-ios/blob/636113f047ee2c7dae742dff2beafae2121ceb62/bin/templates/scripts/cordova/lib/Podfile.js#L61 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11970) Support CocoaPod pod specification other than version
[ https://issues.apache.org/jira/browse/CB-11970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556803#comment-15556803 ] ASF GitHub Bot commented on CB-11970: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/267 > Support CocoaPod pod specification other than version > - > > Key: CB-11970 > URL: https://issues.apache.org/jira/browse/CB-11970 > Project: Apache Cordova > Issue Type: Improvement > Components: iOS >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > https://github.com/apache/cordova-ios/blob/636113f047ee2c7dae742dff2beafae2121ceb62/bin/templates/scripts/cordova/lib/Podfile.js#L149 > Podfile spec: > https://guides.cocoapods.org/syntax/podfile.html#pod > If the spec begins with a colon ":", don't quote it when writing to the > Podfile. > Make sure this function works as well, after: > https://github.com/apache/cordova-ios/blob/636113f047ee2c7dae742dff2beafae2121ceb62/bin/templates/scripts/cordova/lib/Podfile.js#L61 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11970) Support CocoaPod pod specification other than version
[ https://issues.apache.org/jira/browse/CB-11970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556797#comment-15556797 ] ASF GitHub Bot commented on CB-11970: - Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/267 ## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/267?src=pr) is 56.60% (diff: 87.50%) > Merging [#267](https://codecov.io/gh/apache/cordova-ios/pull/267?src=pr) into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) will increase coverage by **0.10%** ```diff @@ master #267 diff @@ == Files12 12 Lines 1230 1233 +3 Methods 198198 Messages 0 0 Branches193193 == + Hits695698 +3 Misses 535535 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last update [a956c93...06dbae8](https://codecov.io/gh/apache/cordova-ios/compare/a956c93e2cf9f5f23b1880fdd0d43a9f0d113521...06dbae8dcf38ea32993519c974795fb2935910b8?src=pr) > Support CocoaPod pod specification other than version > - > > Key: CB-11970 > URL: https://issues.apache.org/jira/browse/CB-11970 > Project: Apache Cordova > Issue Type: Improvement > Components: iOS >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > https://github.com/apache/cordova-ios/blob/636113f047ee2c7dae742dff2beafae2121ceb62/bin/templates/scripts/cordova/lib/Podfile.js#L149 > Podfile spec: > https://guides.cocoapods.org/syntax/podfile.html#pod > If the spec begins with a colon ":", don't quote it when writing to the > Podfile. > Make sure this function works as well, after: > https://github.com/apache/cordova-ios/blob/636113f047ee2c7dae742dff2beafae2121ceb62/bin/templates/scripts/cordova/lib/Podfile.js#L61 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11976) Add deprecated node version warning for 0.x
[ https://issues.apache.org/jira/browse/CB-11976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556786#comment-15556786 ] ASF GitHub Bot commented on CB-11976: - Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/497 Making a change so it is shown on every command, not just `prepare` > Add deprecated node version warning for 0.x > --- > > Key: CB-11976 > URL: https://issues.apache.org/jira/browse/CB-11976 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Labels: cordova-7.0.0 > > Put in the promise chain of prepare: > https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/prepare.js > Model it after this: > https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/platform.js#L144-L150 > Check "process.version" for v0.x.x or v0.x, if they exist, print the warning. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-11729) template file MainViewController.m has deprecated override shouldAutorotateToInterfaceOrientation
[ https://issues.apache.org/jira/browse/CB-11729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah resolved CB-11729. --- Resolution: Fixed > template file MainViewController.m has deprecated override > shouldAutorotateToInterfaceOrientation > - > > Key: CB-11729 > URL: https://issues.apache.org/jira/browse/CB-11729 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > shouldAutorotateToInterfaceOrientation has been deprecated since iOS 6, and > is never called anymore. > The new function is should be shouldAutoRotate. Use any of the three here as > overrides: > https://github.com/apache/cordova-ios/blob/f75bf67438257132e739238ed579d73271b3a716/CordovaLib/Classes/Public/CDVScreenOrientationDelegate.h -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11729) template file MainViewController.m has deprecated override shouldAutorotateToInterfaceOrientation
[ https://issues.apache.org/jira/browse/CB-11729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556737#comment-15556737 ] ASF subversion and git services commented on CB-11729: -- Commit a956c93e2cf9f5f23b1880fdd0d43a9f0d113521 in cordova-ios's branch refs/heads/master from [~shazron] [ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=a956c93 ] CB-11729 - template file MainViewController.m has deprecated override shouldAutorotateToInterfaceOrientation This closes #266 > template file MainViewController.m has deprecated override > shouldAutorotateToInterfaceOrientation > - > > Key: CB-11729 > URL: https://issues.apache.org/jira/browse/CB-11729 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > shouldAutorotateToInterfaceOrientation has been deprecated since iOS 6, and > is never called anymore. > The new function is should be shouldAutoRotate. Use any of the three here as > overrides: > https://github.com/apache/cordova-ios/blob/f75bf67438257132e739238ed579d73271b3a716/CordovaLib/Classes/Public/CDVScreenOrientationDelegate.h -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11729) template file MainViewController.m has deprecated override shouldAutorotateToInterfaceOrientation
[ https://issues.apache.org/jira/browse/CB-11729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556738#comment-15556738 ] ASF GitHub Bot commented on CB-11729: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/266 > template file MainViewController.m has deprecated override > shouldAutorotateToInterfaceOrientation > - > > Key: CB-11729 > URL: https://issues.apache.org/jira/browse/CB-11729 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > shouldAutorotateToInterfaceOrientation has been deprecated since iOS 6, and > is never called anymore. > The new function is should be shouldAutoRotate. Use any of the three here as > overrides: > https://github.com/apache/cordova-ios/blob/f75bf67438257132e739238ed579d73271b3a716/CordovaLib/Classes/Public/CDVScreenOrientationDelegate.h -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11970) Support CocoaPod pod specification other than version
[ https://issues.apache.org/jira/browse/CB-11970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556730#comment-15556730 ] ASF GitHub Bot commented on CB-11970: - GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/267 CB-11970 - Support CocoaPod pod specification other than version ### Platforms affected iOS ### What does this PR do? Add support for CocoaPod specs that are not just versions, but other specifications. i.e. ``` ``` ### What testing has been done on this change? npm run unit-tests ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-ios CB-11970 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/267.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #267 commit a24a69d725cbc468feafd0d0a29b643541e320fd Author: Shazron Abdullah Date: 2016-10-08T00:19:16Z CB-11970 - Support CocoaPod pod specification other than version > Support CocoaPod pod specification other than version > - > > Key: CB-11970 > URL: https://issues.apache.org/jira/browse/CB-11970 > Project: Apache Cordova > Issue Type: Improvement > Components: iOS >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > https://github.com/apache/cordova-ios/blob/636113f047ee2c7dae742dff2beafae2121ceb62/bin/templates/scripts/cordova/lib/Podfile.js#L149 > Podfile spec: > https://guides.cocoapods.org/syntax/podfile.html#pod > If the spec begins with a colon ":", don't quote it when writing to the > Podfile. > Make sure this function works as well, after: > https://github.com/apache/cordova-ios/blob/636113f047ee2c7dae742dff2beafae2121ceb62/bin/templates/scripts/cordova/lib/Podfile.js#L61 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11729) template file MainViewController.m has deprecated override shouldAutorotateToInterfaceOrientation
[ https://issues.apache.org/jira/browse/CB-11729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556623#comment-15556623 ] ASF GitHub Bot commented on CB-11729: - Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/266 ## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/266?src=pr) is 56.50% (diff: 100%) > Merging [#266](https://codecov.io/gh/apache/cordova-ios/pull/266?src=pr) into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) will not change coverage ```diff @@ master #266 diff @@ == Files12 12 Lines 1230 1230 Methods 198198 Messages 0 0 Branches193193 == Hits695695 Misses 535535 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last update [636113f...d71cb97](https://codecov.io/gh/apache/cordova-ios/compare/636113f047ee2c7dae742dff2beafae2121ceb62...d71cb97fa31c8e59df10dffa3fc6cb927e2deb42?src=pr) > template file MainViewController.m has deprecated override > shouldAutorotateToInterfaceOrientation > - > > Key: CB-11729 > URL: https://issues.apache.org/jira/browse/CB-11729 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > shouldAutorotateToInterfaceOrientation has been deprecated since iOS 6, and > is never called anymore. > The new function is should be shouldAutoRotate. Use any of the three here as > overrides: > https://github.com/apache/cordova-ios/blob/f75bf67438257132e739238ed579d73271b3a716/CordovaLib/Classes/Public/CDVScreenOrientationDelegate.h -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11729) template file MainViewController.m has deprecated override shouldAutorotateToInterfaceOrientation
[ https://issues.apache.org/jira/browse/CB-11729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556595#comment-15556595 ] ASF GitHub Bot commented on CB-11729: - GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/266 CB-11729 - template file MainViewController.m has deprecated override shouldAutorotateToInterfaceOrientation ### Platforms affected iOS ### What does this PR do? Remove unused selector in MainViewController subclass, add in comments the new overrides available. ### What testing has been done on this change? Local build ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-ios CB-11729 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/266.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #266 commit d71cb97fa31c8e59df10dffa3fc6cb927e2deb42 Author: Shazron Abdullah Date: 2016-10-07T23:26:36Z CB-11729 - template file MainViewController.m has deprecated override shouldAutorotateToInterfaceOrientation > template file MainViewController.m has deprecated override > shouldAutorotateToInterfaceOrientation > - > > Key: CB-11729 > URL: https://issues.apache.org/jira/browse/CB-11729 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > shouldAutorotateToInterfaceOrientation has been deprecated since iOS 6, and > is never called anymore. > The new function is should be shouldAutoRotate. Use any of the three here as > overrides: > https://github.com/apache/cordova-ios/blob/f75bf67438257132e739238ed579d73271b3a716/CordovaLib/Classes/Public/CDVScreenOrientationDelegate.h -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11984) Weinre resources inspector bug in FF 49.0.1
[
https://issues.apache.org/jira/browse/CB-11984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Pazos updated CB-11984:
-
Description:
When a developer tries to analyze the resoures of an app, the inspector fails
to open the resources tree as in the image example:
!http://imgur.com/PjlMj8R!
[http://imgur.com/PjlMj8R]
The error message is the following:
??ReferenceError: event is not defined??
On the return statement of isEventWithinDisclosureTriangle in ResourcesPanel.js
(line 833, col 9):
{code:title=ResourcesPanel.js |borderStyle=solid}
isEventWithinDisclosureTriangle: function()
{
// Override it since we use margin-left in place of treeoutline's
text-indent.
// Hence we need to take padding into consideration. This all is needed
for leading
// icons in the tree.
var paddingLeft = 14;
var left = this.listItemElement.totalOffsetLeft + paddingLeft;
return event.pageX >= left && event.pageX <= left +
this.arrowToggleWidth && this.hasChildren;
}
{code}
To fix this I just added event as an argument for that function. So now, the
code is the following:
{code:title=ResourcesPanel.js |borderStyle=solid}
isEventWithinDisclosureTriangle: function(event)
{
// Override it since we use margin-left in place of treeoutline's
text-indent.
// Hence we need to take padding into consideration. This all is needed
for leading
// icons in the tree.
var paddingLeft = 14;
var left = this.listItemElement.totalOffsetLeft + paddingLeft;
return event.pageX >= left && event.pageX <= left +
this.arrowToggleWidth && this.hasChildren;
}
{code}
And now it works!
!http://imgur.com/0DHS0OK!
[http://imgur.com/0DHS0OK]
was:
When a developer tries to analyze the resoures of an app, the inspector fails
to open the resources tree as in the image example:
!http://imgur.com/PjlMj8R!
The error message is the following:
??ReferenceError: event is not defined??
On the return statement of isEventWithinDisclosureTriangle in ResourcesPanel.js
(line 833, col 9):
{code:title=ResourcesPanel.js |borderStyle=solid}
isEventWithinDisclosureTriangle: function()
{
// Override it since we use margin-left in place of treeoutline's
text-indent.
// Hence we need to take padding into consideration. This all is needed
for leading
// icons in the tree.
var paddingLeft = 14;
var left = this.listItemElement.totalOffsetLeft + paddingLeft;
return event.pageX >= left && event.pageX <= left +
this.arrowToggleWidth && this.hasChildren;
}
{code}
To fix this I just added event as an argument for that function. So now, the
code is the following:
{code:title=ResourcesPanel.js |borderStyle=solid}
isEventWithinDisclosureTriangle: function(event)
{
// Override it since we use margin-left in place of treeoutline's
text-indent.
// Hence we need to take padding into consideration. This all is needed
for leading
// icons in the tree.
var paddingLeft = 14;
var left = this.listItemElement.totalOffsetLeft + paddingLeft;
return event.pageX >= left && event.pageX <= left +
this.arrowToggleWidth && this.hasChildren;
}
{code}
And now it works!
!http://imgur.com/0DHS0OK!
> Weinre resources inspector bug in FF 49.0.1
> ---
>
> Key: CB-11984
> URL: https://issues.apache.org/jira/browse/CB-11984
> Project: Apache Cordova
> Issue Type: Bug
> Components: weinre
>Reporter: Bruno Pazos
>Assignee: Patrick Mueller
>Priority: Minor
> Labels: easyfix
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> When a developer tries to analyze the resoures of an app, the inspector fails
> to open the resources tree as in the image example:
> !http://imgur.com/PjlMj8R!
> [http://imgur.com/PjlMj8R]
> The error message is the following:
> ??ReferenceError: event is not defined??
> On the return statement of isEventWithinDisclosureTriangle in
> ResourcesPanel.js (line 833, col 9):
> {code:title=ResourcesPanel.js |borderStyle=solid}
> isEventWithinDisclosureTriangle: function()
> {
> // Override it since we use margin-left in place of treeoutline's
> text-indent.
> // Hence we need to take padding into consideration. This all is
> needed for leading
> // icons in the tree.
> var paddingLeft = 14;
> var left = this.listItemElement.totalOffsetLeft + paddingLeft;
> return event.pageX >= left && event.pageX <= left +
> this.arrowToggleWidth && this.hasChildren;
> }
> {code}
> To fix this I just added event as an argument for that function. So now, the
> code is the following:
> {code:title=ResourcesPanel.js |borderStyle=solid}
> isEventWithinDisclosureTriangle: function(even
[jira] [Created] (CB-11984) Weinre resources inspector bug in FF 49.0.1
Bruno Pazos created CB-11984:
Summary: Weinre resources inspector bug in FF 49.0.1
Key: CB-11984
URL: https://issues.apache.org/jira/browse/CB-11984
Project: Apache Cordova
Issue Type: Bug
Components: weinre
Reporter: Bruno Pazos
Assignee: Patrick Mueller
Priority: Minor
When a developer tries to analyze the resoures of an app, the inspector fails
to open the resources tree as in the image example:
!http://imgur.com/PjlMj8R!
The error message is the following:
??ReferenceError: event is not defined??
On the return statement of isEventWithinDisclosureTriangle in ResourcesPanel.js
(line 833, col 9):
{code:title=ResourcesPanel.js |borderStyle=solid}
isEventWithinDisclosureTriangle: function()
{
// Override it since we use margin-left in place of treeoutline's
text-indent.
// Hence we need to take padding into consideration. This all is needed
for leading
// icons in the tree.
var paddingLeft = 14;
var left = this.listItemElement.totalOffsetLeft + paddingLeft;
return event.pageX >= left && event.pageX <= left +
this.arrowToggleWidth && this.hasChildren;
}
{code}
To fix this I just added event as an argument for that function. So now, the
code is the following:
{code:title=ResourcesPanel.js |borderStyle=solid}
isEventWithinDisclosureTriangle: function(event)
{
// Override it since we use margin-left in place of treeoutline's
text-indent.
// Hence we need to take padding into consideration. This all is needed
for leading
// icons in the tree.
var paddingLeft = 14;
var left = this.listItemElement.totalOffsetLeft + paddingLeft;
return event.pageX >= left && event.pageX <= left +
this.arrowToggleWidth && this.hasChildren;
}
{code}
And now it works!
!http://imgur.com/0DHS0OK!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11803) Plugin features don't get written to iOS-specific config.xml
[
https://issues.apache.org/jira/browse/CB-11803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556558#comment-15556558
]
Shazron Abdullah commented on CB-11803:
---
We will re-verify this issue when cordova-cli@6.4.0 is released
> Plugin features don't get written to iOS-specific config.xml
>
>
> Key: CB-11803
> URL: https://issues.apache.org/jira/browse/CB-11803
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI, iOS, Plugins
>Affects Versions: 6.3.1
>Reporter: Matus Koprda
>Priority: Critical
>
> When running `cordova prepare` or `cordova platform add ios` after adding
> plugins, the platform-specific config.xml file for iOS
> (`platforms/ios/NAME/config.xml`) doesn't have `` tags, which
> effectively prevents any installed plugin from working.
> The tags *do* get added when installing plugins *after* the iOS platform was
> created.
> How to reproduce - this creates a working config.xml:
> {code}
> cordova create test
> cd test
> cordova platform add ios
> cordova plugin add cordova-plugin-device --save
> {code}
> This creates a broken config.xml (resulting in `Plugin 'Device' not found, or
> is not a CDVPlugin.` error when running on a an iPhone):
> {code}
> cordova create test
> cd test
> cordova plugin add cordova-plugin-device --save
> cordova platform add ios
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11803) Plugin features don't get written to iOS-specific config.xml
[
https://issues.apache.org/jira/browse/CB-11803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556551#comment-15556551
]
Darryl Pogue commented on CB-11803:
---
Ugh, this is one of the reasons that I want to separate prepare and restore,
because there are all these cases that aren't captured in tests or
documentation anywhere and trying to fix anything results in breaking
expectations.
However, I thought this particular case was already fixed by CB-11698?
> Plugin features don't get written to iOS-specific config.xml
>
>
> Key: CB-11803
> URL: https://issues.apache.org/jira/browse/CB-11803
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI, iOS, Plugins
>Affects Versions: 6.3.1
>Reporter: Matus Koprda
>Priority: Critical
>
> When running `cordova prepare` or `cordova platform add ios` after adding
> plugins, the platform-specific config.xml file for iOS
> (`platforms/ios/NAME/config.xml`) doesn't have `` tags, which
> effectively prevents any installed plugin from working.
> The tags *do* get added when installing plugins *after* the iOS platform was
> created.
> How to reproduce - this creates a working config.xml:
> {code}
> cordova create test
> cd test
> cordova platform add ios
> cordova plugin add cordova-plugin-device --save
> {code}
> This creates a broken config.xml (resulting in `Plugin 'Device' not found, or
> is not a CDVPlugin.` error when running on a an iPhone):
> {code}
> cordova create test
> cd test
> cordova plugin add cordova-plugin-device --save
> cordova platform add ios
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11803) Plugin features don't get written to iOS-specific config.xml
[
https://issues.apache.org/jira/browse/CB-11803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556541#comment-15556541
]
Shazron Abdullah commented on CB-11803:
---
[~dpogue] any insight on this?
> Plugin features don't get written to iOS-specific config.xml
>
>
> Key: CB-11803
> URL: https://issues.apache.org/jira/browse/CB-11803
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI, iOS, Plugins
>Affects Versions: 6.3.1
>Reporter: Matus Koprda
>Priority: Critical
>
> When running `cordova prepare` or `cordova platform add ios` after adding
> plugins, the platform-specific config.xml file for iOS
> (`platforms/ios/NAME/config.xml`) doesn't have `` tags, which
> effectively prevents any installed plugin from working.
> The tags *do* get added when installing plugins *after* the iOS platform was
> created.
> How to reproduce - this creates a working config.xml:
> {code}
> cordova create test
> cd test
> cordova platform add ios
> cordova plugin add cordova-plugin-device --save
> {code}
> This creates a broken config.xml (resulting in `Plugin 'Device' not found, or
> is not a CDVPlugin.` error when running on a an iPhone):
> {code}
> cordova create test
> cd test
> cordova plugin add cordova-plugin-device --save
> cordova platform add ios
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11976) Add deprecated node version warning for 0.x
[ https://issues.apache.org/jira/browse/CB-11976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556530#comment-15556530 ] ASF GitHub Bot commented on CB-11976: - Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/497 ## [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/497?src=pr) is 80.41% (diff: 100%) > Merging [#497](https://codecov.io/gh/apache/cordova-lib/pull/497?src=pr) into [master](https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr) will increase coverage by **0.01%** ```diff @@ master #497 diff @@ == Files67 67 Lines 5189 5192 +3 Methods 836836 Messages 0 0 Branches 1005 1006 +1 == + Hits 4172 4175 +3 Misses 1017 1017 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last update [4ca3b4c...65181b5](https://codecov.io/gh/apache/cordova-lib/compare/4ca3b4ca12a01ded923734e4d92d7f9325d540dc...65181b5b16f9cae3335e169bd8296e44a45aa4e7?src=pr) > Add deprecated node version warning for 0.x > --- > > Key: CB-11976 > URL: https://issues.apache.org/jira/browse/CB-11976 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Labels: cordova-7.0.0 > > Put in the promise chain of prepare: > https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/prepare.js > Model it after this: > https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/platform.js#L144-L150 > Check "process.version" for v0.x.x or v0.x, if they exist, print the warning. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11964) Gradle build failure after any plugin installation
[
https://issues.apache.org/jira/browse/CB-11964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556444#comment-15556444
]
ASF GitHub Bot commented on CB-11964:
-
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/339
@alsorokin I'm going to keep the commits exploded and as is on this PR. If
this looks good to you, I'll merge this in tonight.
> Gradle build failure after any plugin installation
> --
>
> Key: CB-11964
> URL: https://issues.apache.org/jira/browse/CB-11964
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
>Affects Versions: Master
> Environment: node 4.4.3
> cordova 6.3.0
>Reporter: Alexander Sorokin
> Labels: found-by-ci, triaged
>
> {noformat}
> cordova create foo
> cd foo
> cordova platform add android@https://github.com/apache/cordova-android
> cordova build
> cordova plugin add cordova-plugin-device
> cordova build
> {noformat}
> Results in the following error:
> {noformat}
> BUILD FAILED
> Total time: 2.439 secs
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException:
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> > (Access is denied)
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or
> --debug option to get more log output.
> Error: cmd: Command failed with exit code 1 Error output:
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException:
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> > (Access is denied)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11983) The back button hides the window but does not destroy
[
https://issues.apache.org/jira/browse/CB-11983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ricardo Rufino updated CB-11983:
Attachment: Selection_674.png
> The back button hides the window but does not destroy
> -
>
> Key: CB-11983
> URL: https://issues.apache.org/jira/browse/CB-11983
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin InAppBrowser
>Affects Versions: 1.5.0
> Environment: Android
>Reporter: Ricardo Rufino
>Priority: Trivial
> Attachments: Selection_674.png
>
>
> The back button "close" the window but do not destroy ! See atached image.
> I have a local index that opens external pages. When I click back and click
> on other links, the windows accumulate, appearing "about: blank".
> I tried to implement the code to reuse the same window, but still does not
> work.
> {code}
> if(w_ref == null)
> w_ref = cordova.InAppBrowser.open( url, '_blank', 'location=no'); // _self
> else {
> w_ref.executeScript({
> code: "window.location = '"+url+"';"
> }, function () {
> w_ref.show();
> });
> }
> {code}
> Why this is needed (load about:blank) ?
> https://github.com/apache/cordova-plugin-inappbrowser/blob/master/src/android/InAppBrowser.java#L418
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11983) The back button hides the window but does not destroy
[
https://issues.apache.org/jira/browse/CB-11983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ricardo Rufino updated CB-11983:
Description:
The back button "close" the window but do not destroy ! See atached image.
I have a local index that opens external pages. When I click back and click on
other links, the windows accumulate, appearing "about: blank".
I tried to implement the code to reuse the same window, but still does not work
(The app crash).
{code}
if(w_ref == null)
w_ref = cordova.InAppBrowser.open( url, '_blank', 'location=no'); // _self
else {
w_ref.executeScript({
code: "window.location = '"+url+"';"
}, function () {
w_ref.show();
});
}
{code}
Why this is needed (load about:blank) ?
https://github.com/apache/cordova-plugin-inappbrowser/blob/master/src/android/InAppBrowser.java#L418
was:
The back button "close" the window but do not destroy ! See atached image.
I have a local index that opens external pages. When I click back and click on
other links, the windows accumulate, appearing "about: blank".
I tried to implement the code to reuse the same window, but still does not work.
{code}
if(w_ref == null)
w_ref = cordova.InAppBrowser.open( url, '_blank', 'location=no'); // _self
else {
w_ref.executeScript({
code: "window.location = '"+url+"';"
}, function () {
w_ref.show();
});
}
{code}
Why this is needed (load about:blank) ?
https://github.com/apache/cordova-plugin-inappbrowser/blob/master/src/android/InAppBrowser.java#L418
> The back button hides the window but does not destroy
> -
>
> Key: CB-11983
> URL: https://issues.apache.org/jira/browse/CB-11983
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin InAppBrowser
>Affects Versions: 1.5.0
> Environment: Android
>Reporter: Ricardo Rufino
>Priority: Trivial
> Attachments: Selection_674.png
>
>
> The back button "close" the window but do not destroy ! See atached image.
> I have a local index that opens external pages. When I click back and click
> on other links, the windows accumulate, appearing "about: blank".
> I tried to implement the code to reuse the same window, but still does not
> work (The app crash).
> {code}
> if(w_ref == null)
> w_ref = cordova.InAppBrowser.open( url, '_blank', 'location=no'); // _self
> else {
> w_ref.executeScript({
> code: "window.location = '"+url+"';"
> }, function () {
> w_ref.show();
> });
> }
> {code}
> Why this is needed (load about:blank) ?
> https://github.com/apache/cordova-plugin-inappbrowser/blob/master/src/android/InAppBrowser.java#L418
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11983) The back button hides the window but does not destroy
[
https://issues.apache.org/jira/browse/CB-11983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ricardo Rufino updated CB-11983:
Description:
The back button "close" the window but do not destroy ! See atached image.
I have a local index that opens external pages. When I click back and click on
other links, the windows accumulate, appearing "about: blank".
I tried to implement the code to reuse the same window, but still does not work.
{code}
if(w_ref == null)
w_ref = cordova.InAppBrowser.open( url, '_blank', 'location=no'); // _self
else {
w_ref.executeScript({
code: "window.location = '"+url+"';"
}, function () {
w_ref.show();
});
}
{code}
Why this is needed (load about:blank) ?
https://github.com/apache/cordova-plugin-inappbrowser/blob/master/src/android/InAppBrowser.java#L418
was:
The back button "close" the window but do not destroy ! See atached image.
I have a local index that opens external pages. When I click back and click on
other links, the windows accumulate, appearing "about: blank".
I tried to implement the code to reuse the same window, but still does not work.
{code}
if(w_ref == null)
w_ref = cordova.InAppBrowser.open( url, '_blank', 'location=no'); // _self
else {
w_ref.executeScript({
code: "window.location = '"+url+"';"
}, function () {
w_ref.show();
});
}
{code}
> The back button hides the window but does not destroy
> -
>
> Key: CB-11983
> URL: https://issues.apache.org/jira/browse/CB-11983
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin InAppBrowser
>Affects Versions: 1.5.0
> Environment: Android
>Reporter: Ricardo Rufino
>Priority: Trivial
>
> The back button "close" the window but do not destroy ! See atached image.
> I have a local index that opens external pages. When I click back and click
> on other links, the windows accumulate, appearing "about: blank".
> I tried to implement the code to reuse the same window, but still does not
> work.
> {code}
> if(w_ref == null)
> w_ref = cordova.InAppBrowser.open( url, '_blank', 'location=no'); // _self
> else {
> w_ref.executeScript({
> code: "window.location = '"+url+"';"
> }, function () {
> w_ref.show();
> });
> }
> {code}
> Why this is needed (load about:blank) ?
> https://github.com/apache/cordova-plugin-inappbrowser/blob/master/src/android/InAppBrowser.java#L418
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11983) The back button hides the window but does not destroy
[
https://issues.apache.org/jira/browse/CB-11983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ricardo Rufino updated CB-11983:
Description:
The back button "close" the window but do not destroy ! See atached image.
I have a local index that opens external pages. When I click back and click on
other links, the windows accumulate, appearing "about: blank".
I tried to implement the code to reuse the same window, but still does not work.
{code}
if(w_ref == null)
w_ref = cordova.InAppBrowser.open( url, '_blank', 'location=no'); // _self
else {
w_ref.executeScript({
code: "window.location = '"+url+"';"
}, function () {
w_ref.show();
});
}
{code}
was:
The back button "close" the window but do not destroy ! See atached image.
I have a local index that opens external pages. When I click back and click on
other links, the windows accumulate, appearing "about: blank".
I tried to implement the code to reuse the same window, but still does not work.
{code}
if(w_ref == null)
w_ref = cordova.InAppBrowser.open( url, '_blank', 'location=no'); // _self
else {
w_ref.executeScript({
code: "window.location = '"+url+"';"
}, function () {
w_ref.show();
});
}
{/code}
> The back button hides the window but does not destroy
> -
>
> Key: CB-11983
> URL: https://issues.apache.org/jira/browse/CB-11983
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin InAppBrowser
>Affects Versions: 1.5.0
> Environment: Android
>Reporter: Ricardo Rufino
>Priority: Trivial
>
> The back button "close" the window but do not destroy ! See atached image.
> I have a local index that opens external pages. When I click back and click
> on other links, the windows accumulate, appearing "about: blank".
> I tried to implement the code to reuse the same window, but still does not
> work.
> {code}
> if(w_ref == null)
> w_ref = cordova.InAppBrowser.open( url, '_blank', 'location=no'); // _self
> else {
> w_ref.executeScript({
> code: "window.location = '"+url+"';"
> }, function () {
> w_ref.show();
> });
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11983) The back button hides the window but does not destroy
Ricardo Rufino created CB-11983:
---
Summary: The back button hides the window but does not destroy
Key: CB-11983
URL: https://issues.apache.org/jira/browse/CB-11983
Project: Apache Cordova
Issue Type: Bug
Components: Plugin InAppBrowser
Affects Versions: 1.5.0
Environment: Android
Reporter: Ricardo Rufino
Priority: Trivial
The back button "close" the window but do not destroy ! See atached image.
I have a local index that opens external pages. When I click back and click on
other links, the windows accumulate, appearing "about: blank".
I tried to implement the code to reuse the same window, but still does not work.
{code}
if(w_ref == null)
w_ref = cordova.InAppBrowser.open( url, '_blank', 'location=no'); // _self
else {
w_ref.executeScript({
code: "window.location = '"+url+"';"
}, function () {
w_ref.show();
});
}
{/code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11976) Add deprecated node version warning for 0.x
[ https://issues.apache.org/jira/browse/CB-11976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556339#comment-15556339 ] ASF GitHub Bot commented on CB-11976: - GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/497 CB-11976 - Add deprecated node version warning for 0.x ### Platforms affected All ### What does this PR do? Prints out a warning on `prepare` that you are using a deprecated node version, if you are using any node version 0.x ### What testing has been done on this change? Tested locally. ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-lib CB-11976 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/497.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #497 commit 19031e645c1a885728c81650b55189cc311d1e13 Author: Shazron Abdullah Date: 2016-10-07T21:46:01Z CB-11976 - Add deprecated node version warning for 0.x > Add deprecated node version warning for 0.x > --- > > Key: CB-11976 > URL: https://issues.apache.org/jira/browse/CB-11976 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Labels: cordova-7.0.0 > > Put in the promise chain of prepare: > https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/prepare.js > Model it after this: > https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/platform.js#L144-L150 > Check "process.version" for v0.x.x or v0.x, if they exist, print the warning. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11976) Add deprecated node version warning for 0.x
[ https://issues.apache.org/jira/browse/CB-11976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-11976: -- Description: Put in the promise chain of prepare: https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/prepare.js Model it after this: https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/platform.js#L144-L150 Check "process.version" for v0.x.x or v0.x, if they exist, print the warning. was: Put in the promise chain of prepare: https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/prepare.js Model it after this: https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/platform.js#L144-L150 Check "process.version" for v0.10.x and v0.12.x, if they exist, print the warning. > Add deprecated node version warning for 0.x > --- > > Key: CB-11976 > URL: https://issues.apache.org/jira/browse/CB-11976 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Labels: cordova-7.0.0 > > Put in the promise chain of prepare: > https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/prepare.js > Model it after this: > https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/platform.js#L144-L150 > Check "process.version" for v0.x.x or v0.x, if they exist, print the warning. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11982) create new cordova config command
Steve Gill created CB-11982: --- Summary: create new cordova config command Key: CB-11982 URL: https://issues.apache.org/jira/browse/CB-11982 Project: Apache Cordova Issue Type: Improvement Reporter: Steve Gill Model it after npm config command. https://docs.npmjs.com/cli/config This issue could use a cordova-discuss PR before implementing. Might want to migrate telemetry and update-notifier config into this. Currently, telemetry and update-notifier use https://github.com/yeoman/configstore under the hood. Stores configs in ~/.config/configstore/ -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11981) remove restore from prepare. Break into its own command
Steve Gill created CB-11981: --- Summary: remove restore from prepare. Break into its own command Key: CB-11981 URL: https://issues.apache.org/jira/browse/CB-11981 Project: Apache Cordova Issue Type: Improvement Components: CordovaLib Reporter: Steve Gill Fix For: 7.0.0 Proposal at https://github.com/cordova/cordova-discuss/pull/54. New command: `cordova install` -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11980) breakout modules in cordova-lib into their own repos
Steve Gill created CB-11980: --- Summary: breakout modules in cordova-lib into their own repos Key: CB-11980 URL: https://issues.apache.org/jira/browse/CB-11980 Project: Apache Cordova Issue Type: Improvement Components: cordova-fetch, CordovaCommon, CordovaLib, CordovaServe Reporter: Steve Gill This issue needs a cordova-discuss PR still. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11979) add deprecation notice for using subdirectory syntax when fetching plugins
[ https://issues.apache.org/jira/browse/CB-11979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill updated CB-11979: Issue Type: Bug (was: Improvement) > add deprecation notice for using subdirectory syntax when fetching plugins > -- > > Key: CB-11979 > URL: https://issues.apache.org/jira/browse/CB-11979 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Affects Versions: 6.3.1 >Reporter: Steve Gill > Labels: cordova-7.0.0 > Fix For: 6.4.0 > > > We plan to remove subdirectory syntax in cordova@7 since `--fetch` can't > support it. > Need to add a deprecation to the next cordova@6.x release to start warning > folks it is going away. > You can see the subdirectory syntax at > http://cordova.apache.org/docs/en/latest/reference/cordova-cli/index.html#plugin-spec. > I think it is plugin specific, but need to double check it is not supported > for fetching platforms too. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11979) add deprecation notice for using subdirectory syntax when fetching plugins
Steve Gill created CB-11979: --- Summary: add deprecation notice for using subdirectory syntax when fetching plugins Key: CB-11979 URL: https://issues.apache.org/jira/browse/CB-11979 Project: Apache Cordova Issue Type: Improvement Components: CordovaLib Affects Versions: 6.3.1 Reporter: Steve Gill Fix For: 6.4.0 We plan to remove subdirectory syntax in cordova@7 since `--fetch` can't support it. Need to add a deprecation to the next cordova@6.x release to start warning folks it is going away. You can see the subdirectory syntax at http://cordova.apache.org/docs/en/latest/reference/cordova-cli/index.html#plugin-spec. I think it is plugin specific, but need to double check it is not supported for fetching platforms too. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11978) [--fetch] adding platforms/plugins via localpath should go through cordova-fetch
Steve Gill created CB-11978: --- Summary: [--fetch] adding platforms/plugins via localpath should go through cordova-fetch Key: CB-11978 URL: https://issues.apache.org/jira/browse/CB-11978 Project: Apache Cordova Issue Type: Improvement Components: cordova-fetch, CordovaLib Affects Versions: 6.3.0 Reporter: Steve Gill cordova plugin add localPath --save --fetch * currently, doesn’t add this to `package.json` * in config.xml, adds `` * `npm install localpath —save` adds `"cordova-plugin-geolocation": "file:///Users/steveng/repo/cordova/cordova-plugin-geolocation”` in `package.json` Need to make local paths go through fetch so they get saved in package.json too. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11977) Remove support for node 0.x
[ https://issues.apache.org/jira/browse/CB-11977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill updated CB-11977: Description: Don't do this until January 2017 according to node deprecation timeline. https://github.com/cordova/cordova-discuss/blob/master/proposals/NodeJsDeprecation.md Use engines key in package.json https://docs.npmjs.com/files/package.json#engines was: Don't do this until January 2017. Use engines key in package.json https://docs.npmjs.com/files/package.json#engines > Remove support for node 0.x > --- > > Key: CB-11977 > URL: https://issues.apache.org/jira/browse/CB-11977 > Project: Apache Cordova > Issue Type: Improvement > Components: CLI, CordovaLib >Reporter: Steve Gill > Labels: cordova-7.0.0 > Fix For: 7.0.0 > > > Don't do this until January 2017 according to node deprecation timeline. > https://github.com/cordova/cordova-discuss/blob/master/proposals/NodeJsDeprecation.md > Use engines key in package.json > https://docs.npmjs.com/files/package.json#engines -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11977) Remove support for node 0.x
[ https://issues.apache.org/jira/browse/CB-11977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556209#comment-15556209 ] Steve Gill commented on CB-11977: - will want to update all of our CIs as well. > Remove support for node 0.x > --- > > Key: CB-11977 > URL: https://issues.apache.org/jira/browse/CB-11977 > Project: Apache Cordova > Issue Type: Improvement > Components: CLI, CordovaLib >Reporter: Steve Gill > Labels: cordova-7.0.0 > Fix For: 7.0.0 > > > Don't do this until January 2017. > Use engines key in package.json > https://docs.npmjs.com/files/package.json#engines -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11977) Remove support for node 0.x
Steve Gill created CB-11977: --- Summary: Remove support for node 0.x Key: CB-11977 URL: https://issues.apache.org/jira/browse/CB-11977 Project: Apache Cordova Issue Type: Improvement Components: CLI, CordovaLib Reporter: Steve Gill Fix For: 7.0.0 Don't do this until January 2017. Use engines key in package.json https://docs.npmjs.com/files/package.json#engines -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11976) Add deprecated node version warning for 0.x
[ https://issues.apache.org/jira/browse/CB-11976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556154#comment-15556154 ] Shazron Abdullah commented on CB-11976: --- Only 0.10 and 0.12 users. I was thinking about that, do we want a flag? like "--no-warn-0.x-deprecation"? > Add deprecated node version warning for 0.x > --- > > Key: CB-11976 > URL: https://issues.apache.org/jira/browse/CB-11976 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Labels: cordova-7.0.0 > > Put in the promise chain of prepare: > https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/prepare.js > Model it after this: > https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/platform.js#L144-L150 > Check "process.version" for v0.10.x and v0.12.x, if they exist, print the > warning. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11976) Add deprecated node version warning for 0.x
[ https://issues.apache.org/jira/browse/CB-11976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556148#comment-15556148 ] Steve Gill commented on CB-11976: - are we okay bugging users on every prepare? Anyway to turn off the message? > Add deprecated node version warning for 0.x > --- > > Key: CB-11976 > URL: https://issues.apache.org/jira/browse/CB-11976 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Labels: cordova-7.0.0 > > Put in the promise chain of prepare: > https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/prepare.js > Model it after this: > https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/platform.js#L144-L150 > Check "process.version" for v0.10.x and v0.12.x, if they exist, print the > warning. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11964) Gradle build failure after any plugin installation
[
https://issues.apache.org/jira/browse/CB-11964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556125#comment-15556125
]
ASF GitHub Bot commented on CB-11964:
-
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/339
I'm not getting the same errors locally when I run the same tests, could
this be a weird travis timeout issue?
> Gradle build failure after any plugin installation
> --
>
> Key: CB-11964
> URL: https://issues.apache.org/jira/browse/CB-11964
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
>Affects Versions: Master
> Environment: node 4.4.3
> cordova 6.3.0
>Reporter: Alexander Sorokin
> Labels: found-by-ci, triaged
>
> {noformat}
> cordova create foo
> cd foo
> cordova platform add android@https://github.com/apache/cordova-android
> cordova build
> cordova plugin add cordova-plugin-device
> cordova build
> {noformat}
> Results in the following error:
> {noformat}
> BUILD FAILED
> Total time: 2.439 secs
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException:
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> > (Access is denied)
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or
> --debug option to get more log output.
> Error: cmd: Command failed with exit code 1 Error output:
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException:
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> > (Access is denied)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11964) Gradle build failure after any plugin installation
[
https://issues.apache.org/jira/browse/CB-11964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556123#comment-15556123
]
ASF GitHub Bot commented on CB-11964:
-
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/339
OK, there's something wrong with how we're cleaning in the chain. I think
we need to do it later in the promise chain.
> Gradle build failure after any plugin installation
> --
>
> Key: CB-11964
> URL: https://issues.apache.org/jira/browse/CB-11964
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
>Affects Versions: Master
> Environment: node 4.4.3
> cordova 6.3.0
>Reporter: Alexander Sorokin
> Labels: found-by-ci, triaged
>
> {noformat}
> cordova create foo
> cd foo
> cordova platform add android@https://github.com/apache/cordova-android
> cordova build
> cordova plugin add cordova-plugin-device
> cordova build
> {noformat}
> Results in the following error:
> {noformat}
> BUILD FAILED
> Total time: 2.439 secs
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException:
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> > (Access is denied)
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or
> --debug option to get more log output.
> Error: cmd: Command failed with exit code 1 Error output:
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException:
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> > (Access is denied)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11976) Add deprecated node version warning for 0.x
[ https://issues.apache.org/jira/browse/CB-11976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill updated CB-11976: Labels: cordova-7.0.0 (was: ) > Add deprecated node version warning for 0.x > --- > > Key: CB-11976 > URL: https://issues.apache.org/jira/browse/CB-11976 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Labels: cordova-7.0.0 > > Put in the promise chain of prepare: > https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/prepare.js > Model it after this: > https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/platform.js#L144-L150 > Check "process.version" for v0.10.x and v0.12.x, if they exist, print the > warning. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11976) Add deprecated node version warning for 0.x
[ https://issues.apache.org/jira/browse/CB-11976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-11976: -- Description: Put in the promise chain of prepare: https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/prepare.js Model it after this: https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/platform.js#L144-L150 Check "process.version" for 0.10.x and 0.12.x, if they exist, print the warning. was: Put in the promise chain of prepare: https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/prepare.js Model it after this: https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/platform.js#L144-L150 > Add deprecated node version warning for 0.x > --- > > Key: CB-11976 > URL: https://issues.apache.org/jira/browse/CB-11976 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > Put in the promise chain of prepare: > https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/prepare.js > Model it after this: > https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/platform.js#L144-L150 > Check "process.version" for 0.10.x and 0.12.x, if they exist, print the > warning. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11976) Add deprecated node version warning for 0.x
[ https://issues.apache.org/jira/browse/CB-11976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-11976: -- Description: Put in the promise chain of prepare: https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/prepare.js Model it after this: https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/platform.js#L144-L150 Check "process.version" for v0.10.x and v0.12.x, if they exist, print the warning. was: Put in the promise chain of prepare: https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/prepare.js Model it after this: https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/platform.js#L144-L150 Check "process.version" for 0.10.x and 0.12.x, if they exist, print the warning. > Add deprecated node version warning for 0.x > --- > > Key: CB-11976 > URL: https://issues.apache.org/jira/browse/CB-11976 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > Put in the promise chain of prepare: > https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/prepare.js > Model it after this: > https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/platform.js#L144-L150 > Check "process.version" for v0.10.x and v0.12.x, if they exist, print the > warning. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11976) Add deprecated node version warning for 0.x
Shazron Abdullah created CB-11976: - Summary: Add deprecated node version warning for 0.x Key: CB-11976 URL: https://issues.apache.org/jira/browse/CB-11976 Project: Apache Cordova Issue Type: Bug Components: CordovaLib Reporter: Shazron Abdullah Assignee: Shazron Abdullah Put in the promise chain of prepare: https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/prepare.js Model it after this: https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/platform.js#L144-L150 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7969) plugin add ... makes it install for all platform when plugin.xml only supports 1 platform
[ https://issues.apache.org/jira/browse/CB-7969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1936#comment-1936 ] Trevor Brindle commented on CB-7969: I actually found https://issues.apache.org/jira/browse/CB-6118 first, and then this issue. I believe this should be revisited. This may actually be relatively easy to fix - rather than iterating on all available platforms while installing the plugin, iterate on all platforms declared in the plugin.xml. > plugin add ... makes it install for all platform when plugin.xml only > supports 1 platform > - > > Key: CB-7969 > URL: https://issues.apache.org/jira/browse/CB-7969 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 3.6.0, 6.0.0 >Reporter: Darryl L. Miles > > plugin add ... makes it installed for all platform when plugin.xml only > supports 1 platform > $ cordova platform add blackberry10 > $ cordova platform add browser --usegit > $ cordova plugin add com.blackberry.notification > $ cordova build browser -d > See the output include the plugin when build 'browser'. > Now examine plugins\browser.json and the "installed_plugins" section, you > will see it got added there. > Now examine plugins\com.blackberry.notification\plugin.xml and see that the > element plugin.platform[name]="blackberry10" exists, but no other platform is > supported and not default platform config is provided. > So why was it installed for the "browser" platform ? > I think it is expected it only gets installed into the "blackberry10" > platform. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-6118) CLI should support installing a plugin on a per-platform basis
[
https://issues.apache.org/jira/browse/CB-6118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1928#comment-1928
]
Trevor Brindle commented on CB-6118:
Can this issue be revisited?
This is important in the case of a plugin only meant for one platform - for
example the iOS keychain plugin. It is strange to change something in the
android project, and in the CLI to see this plugin `installed on Android`.
> CLI should support installing a plugin on a per-platform basis
> --
>
> Key: CB-6118
> URL: https://issues.apache.org/jira/browse/CB-6118
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CLI
>Reporter: Andrew Grieve
>Assignee: Mark Koudritsky
>
> There are several reasons why you would want to do this:
> * You want splashscreen on iOS, but not Android
> * You want a Play Services-based geolocation plugin on Android, and regular
> Geolocation for iOS
> * You want InAppBrowser for iOS, but want to just use intents on Android
> * You many want an older version of File plugin on Android, but the latest on
> on iOS
> Desired syntax:
> {code}
> cordova plugin add org.apache.cordova.file@0.3.0 --platform=ios
> cordova plugin rm org.apache.cordova.file --platform=ios --platform=android
> {code}
> Change to `cordova plugin ls`:
> {code}
> $ cordova plugin ls
> Plugins installed on Android:
> org.apache.cordova.file@1.0.0
> org.apache.cordova.file-transfer@1.2.3
> Plugins installed on iOS:
> org.apache.cordova.file@0.1.0
> org.apache.cordova.file-transfer@1.1.3
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11974) wkwebview LocalStorage Persistence For Existing Users
[ https://issues.apache.org/jira/browse/CB-11974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-11974: -- Component/s: Plugin WKWebViewEngine > wkwebview LocalStorage Persistence For Existing Users > - > > Key: CB-11974 > URL: https://issues.apache.org/jira/browse/CB-11974 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin WKWebViewEngine >Reporter: Charles Vanderhoff > Labels: wkwebview-known-issues > > There are a number of apps out there that rely on localstorage to store > session / user data. We really need a way to transfer this data to the > wkwebview-engine so existing users are not left out in the cold. > Crosswalk handles this process automatically by migrating that data to the > new browser when the plugin is installed and first run on an existing user's > device. It would be really, really awesome if this plugin handled this issue > the same way. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11964) Gradle build failure after any plugin installation
[
https://issues.apache.org/jira/browse/CB-11964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1745#comment-1745
]
ASF GitHub Bot commented on CB-11964:
-
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/339
Moving the example into core, tested it locally, everything appears to
check out on MacOS. Hopefully there's no weird Windows issues.
> Gradle build failure after any plugin installation
> --
>
> Key: CB-11964
> URL: https://issues.apache.org/jira/browse/CB-11964
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
>Affects Versions: Master
> Environment: node 4.4.3
> cordova 6.3.0
>Reporter: Alexander Sorokin
> Labels: found-by-ci, triaged
>
> {noformat}
> cordova create foo
> cd foo
> cordova platform add android@https://github.com/apache/cordova-android
> cordova build
> cordova plugin add cordova-plugin-device
> cordova build
> {noformat}
> Results in the following error:
> {noformat}
> BUILD FAILED
> Total time: 2.439 secs
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException:
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> > (Access is denied)
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or
> --debug option to get more log output.
> Error: cmd: Command failed with exit code 1 Error output:
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException:
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> > (Access is denied)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11952) Should be able to pass flags to xcodebuild
[ https://issues.apache.org/jira/browse/CB-11952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1664#comment-1664 ] ASF GitHub Bot commented on CB-11952: - Github user adzellman commented on the issue: https://github.com/apache/cordova-ios/pull/265 @shazron Review comments addressed. Please re-review. > Should be able to pass flags to xcodebuild > -- > > Key: CB-11952 > URL: https://issues.apache.org/jira/browse/CB-11952 > Project: Apache Cordova > Issue Type: Improvement > Components: iOS >Reporter: Andrew Zellman >Assignee: Shazron Abdullah > Labels: features > Fix For: cordova-ios@4.4.0 > > > Cordova developers should be able to pass additional flags to xcodebuild when > compiling their projects. This can be done by adding a --buildFlag option in > cordova-ios that allows multiples declarations. There will need to be > additional attention to conflicts that may happen with xcodebuild arguments > injected by Cordova. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11975) Search on Contacts ‘id’ field with JavaScript number type crashes in iOS
[
https://issues.apache.org/jira/browse/CB-11975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Forrest updated CB-11975:
Description:
I was trying to retrieve a specific contact by id in my Ionic/Cordova app, so
used the following code:
{code:javascript}
return Contacts.find(
['id'],
{filter: contactId, multiple: true})
{code}
However, this crashes the iOS app at runtime with:
{noformat}
2016-10-07 17:33:12.331 MyApp[10998:1880417] -[__NSCFNumber isEqualToString:]:
unrecognized selector sent to instance 0xb053
2016-10-07 17:33:12.337 MyApp[10998:1880417] *** Terminating app due to
uncaught exception 'NSInvalidArgumentException', reason: '-[__NSCFNumber
isEqualToString:]: unrecognized selector sent to instance 0xb053'
*** First throw call stack:
(
0 CoreFoundation 0x00010b0f334b
__exceptionPreprocess + 171
1 libobjc.A.dylib 0x00010ab2b21e
objc_exception_throw + 48
2 CoreFoundation 0x00010b162f34
-[NSObject(NSObject) doesNotRecognizeSelector:] + 132
3 CoreFoundation 0x00010b078c15
___forwarding___ + 1013
4 CoreFoundation 0x00010b078798
_CF_forwarding_prep_0 + 120
5 MyApp 0x0001097217b7
__22-[CDVContacts search:]_block_invoke_2 + 983
6 MyApp 0x000109723760
__42-[CDVAddressBookHelper createAddressBook:]_block_invoke_2 + 368
7 libdispatch.dylib 0x00010e4450cd
_dispatch_client_callout + 8
8 libdispatch.dylib 0x00010e4275e5
_dispatch_barrier_sync_f_slow_invoke + 617
9 libdispatch.dylib 0x00010e4450cd
_dispatch_client_callout + 8
10 libdispatch.dylib 0x00010e4258d6
_dispatch_main_queue_callback_4CF + 406
11 CoreFoundation 0x00010b0b74f9
__CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 9
12 CoreFoundation 0x00010b07cf8d
__CFRunLoopRun + 2205
13 CoreFoundation 0x00010b07c494
CFRunLoopRunSpecific + 420
14 GraphicsServices0x0001107aea6f
GSEventRunModal + 161
15 UIKit 0x00010be0df34
UIApplicationMain + 159
16 MyApp 0x00010962e531 main + 65
17 libdyld.dylib 0x00010e49168d start + 1
)
libc++abi.dylib: terminating with uncaught exception of type NSException
(lldb)
{noformat}
Seems to only fail when {{contactId}} is a JavaScript number. Converting it to
a string before searching ({{contactId+""}}) works fine.
Fault originally occurred because Contact {{id}} field in iOS is an integer…
and it looks like I’m getting a JavaScript number value out of the Contacts
API. Was storing this integer in SQLite (which preserves the data type),
getting an integer back out, and passing it back into the {{Contacts.find()}}
API.
Suggest:
* Contacts {{id}} field is supposed to return a string, so it should return a
string on iOS
* {{Contacts.find()}} should coerce its arguments to correct types before
calling native code.
was:
I was trying to retrieve a specific contact by id in my Ionic/Cordova app, so
used the following code:
{code:javascript}
return Contacts.find(
['id'],
{filter: contactId, multiple: true})
{code}
However, this crashes the iOS app at runtime with:
{noformat}
2016-10-07 17:33:12.331 MyApp[10998:1880417] -[__NSCFNumber isEqualToString:]:
unrecognized selector sent to instance 0xb053
2016-10-07 17:33:12.337 MyApp[10998:1880417] *** Terminating app due to
uncaught exception 'NSInvalidArgumentException', reason: '-[__NSCFNumber
isEqualToString:]: unrecognized selector sent to instance 0xb053'
*** First throw call stack:
(
0 CoreFoundation 0x00010b0f334b
__exceptionPreprocess + 171
1 libobjc.A.dylib 0x00010ab2b21e
objc_exception_throw + 48
2 CoreFoundation 0x00010b162f34
-[NSObject(NSObject) doesNotRecognizeSelector:] + 132
3 CoreFoundation 0x00010b078c15
___forwarding___ + 1013
4 CoreFoundation 0x00010b078798
_CF_forwarding_prep_0 + 120
5 MyApp 0x0001097217b7 __22-[CDVContacts
search:]_block_invoke_2 + 983
6 MyApp 0x000109723760
__42-[CDVAddressBookHelper createAddressBook:]_block_invoke_2 + 368
7 libdispatch.dylib 0x00010e4450cd
_dispatch_client_callout + 8
8 libdispatch.dylib 0x
[jira] [Created] (CB-11975) Search on Contacts ‘id’ field with JavaScript number type crashes in iOS
Andrew Forrest created CB-11975:
---
Summary: Search on Contacts ‘id’ field with JavaScript number type
crashes in iOS
Key: CB-11975
URL: https://issues.apache.org/jira/browse/CB-11975
Project: Apache Cordova
Issue Type: Bug
Reporter: Andrew Forrest
I was trying to retrieve a specific contact by id in my Ionic/Cordova app, so
used the following code:
{code:javascript}
return Contacts.find(
['id'],
{filter: contactId, multiple: true})
{code}
However, this crashes the iOS app at runtime with:
{noformat}
2016-10-07 17:33:12.331 MyApp[10998:1880417] -[__NSCFNumber isEqualToString:]:
unrecognized selector sent to instance 0xb053
2016-10-07 17:33:12.337 MyApp[10998:1880417] *** Terminating app due to
uncaught exception 'NSInvalidArgumentException', reason: '-[__NSCFNumber
isEqualToString:]: unrecognized selector sent to instance 0xb053'
*** First throw call stack:
(
0 CoreFoundation 0x00010b0f334b
__exceptionPreprocess + 171
1 libobjc.A.dylib 0x00010ab2b21e
objc_exception_throw + 48
2 CoreFoundation 0x00010b162f34
-[NSObject(NSObject) doesNotRecognizeSelector:] + 132
3 CoreFoundation 0x00010b078c15
___forwarding___ + 1013
4 CoreFoundation 0x00010b078798
_CF_forwarding_prep_0 + 120
5 MyApp 0x0001097217b7 __22-[CDVContacts
search:]_block_invoke_2 + 983
6 MyApp 0x000109723760
__42-[CDVAddressBookHelper createAddressBook:]_block_invoke_2 + 368
7 libdispatch.dylib 0x00010e4450cd
_dispatch_client_callout + 8
8 libdispatch.dylib 0x00010e4275e5
_dispatch_barrier_sync_f_slow_invoke + 617
9 libdispatch.dylib 0x00010e4450cd
_dispatch_client_callout + 8
10 libdispatch.dylib 0x00010e4258d6
_dispatch_main_queue_callback_4CF + 406
11 CoreFoundation 0x00010b0b74f9
__CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 9
12 CoreFoundation 0x00010b07cf8d
__CFRunLoopRun + 2205
13 CoreFoundation 0x00010b07c494
CFRunLoopRunSpecific + 420
14 GraphicsServices0x0001107aea6f
GSEventRunModal + 161
15 UIKit 0x00010be0df34
UIApplicationMain + 159
16 MyApp 0x00010962e531 main + 65
17 libdyld.dylib 0x00010e49168d start + 1
)
libc++abi.dylib: terminating with uncaught exception of type NSException
(lldb)
{noformat}
Seems to only fail when {{contactId}} is a JavaScript number. Converting it to
a string before searching ({{contactId+""}}) works fine.
Fault originally occurred because Contact {{id}} field in iOS is an integer…
and it looks like I’m getting a JavaScript number value out of the Contacts
API. Was storing this integer in SQLite (which preserves the data type),
getting an integer back out, and passing it back into the {{Contacts.find()}}
API.
Suggest:
* Contacts {{id}} field is supposed to return a string, so it should return a
string on iOS
* {{Contacts.find()}} should coerce its arguments to correct types before
calling native code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11974) wkwebview LocalStorage Persistence For Existing Users
[ https://issues.apache.org/jira/browse/CB-11974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charles Vanderhoff updated CB-11974: Labels: wkwebview-known-issues (was: ) > wkwebview LocalStorage Persistence For Existing Users > - > > Key: CB-11974 > URL: https://issues.apache.org/jira/browse/CB-11974 > Project: Apache Cordova > Issue Type: Bug >Reporter: Charles Vanderhoff > Labels: wkwebview-known-issues > > There are a number of apps out there that rely on localstorage to store > session / user data. We really need a way to transfer this data to the > wkwebview-engine so existing users are not left out in the cold. > Crosswalk handles this process automatically by migrating that data to the > new browser when the plugin is installed and first run on an existing user's > device. It would be really, really awesome if this plugin handled this issue > the same way. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11974) wkwebview LocalStorage Persistence For Existing Users
Charles Vanderhoff created CB-11974: --- Summary: wkwebview LocalStorage Persistence For Existing Users Key: CB-11974 URL: https://issues.apache.org/jira/browse/CB-11974 Project: Apache Cordova Issue Type: Bug Reporter: Charles Vanderhoff There are a number of apps out there that rely on localstorage to store session / user data. We really need a way to transfer this data to the wkwebview-engine so existing users are not left out in the cold. Crosswalk handles this process automatically by migrating that data to the new browser when the plugin is installed and first run on an existing user's device. It would be really, really awesome if this plugin handled this issue the same way. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11973) Wezka Camera Issue in Android 6.0.1
Vishwa Deepak created CB-11973: -- Summary: Wezka Camera Issue in Android 6.0.1 Key: CB-11973 URL: https://issues.apache.org/jira/browse/CB-11973 Project: Apache Cordova Issue Type: Bug Components: Android, CordovaLib, Plugin Camera Environment: Android 6.0.1 Reporter: Vishwa Deepak Priority: Critical Hi Team, While capturing the image , the image is not displaying in the VIEW, I have the following Logcat Please refer and let me know for more information. 10-07 07:04:42.010 5918 5918 W ExifInterface: Invalid image. 10-07 07:04:42.010 5918 5918 W ExifInterface: java.io.EOFException 10-07 07:04:42.010 5918 5918 W ExifInterface: at java.io.DataInputStream.readByte(DataInputStream.java:77) 10-07 07:04:42.010 5918 5918 W ExifInterface: at android.media.ExifInterface.getJpegAttributes(ExifInterface.java:1599) 10-07 07:04:42.010 5918 5918 W ExifInterface: at android.media.ExifInterface.loadAttributes(ExifInterface.java:1339) 10-07 07:04:42.010 5918 5918 W ExifInterface: at android.media.ExifInterface.(ExifInterface.java:1057) 10-07 07:04:42.010 5918 5918 W ExifInterface: at com.wezka.nativecamera.ExifHelper.createOutFile(ExifHelper.java:83) 10-07 07:04:42.010 5918 5918 W ExifInterface: at com.wezka.nativecamera.NativeCameraLauncher.onActivityResult(NativeCameraLauncher.java:435) 10-07 07:04:42.010 5918 5918 W ExifInterface: at org.apache.cordova.CordovaInterfaceImpl.onActivityResult(CordovaInterfaceImpl.java:120) 10-07 07:04:42.010 5918 5918 W ExifInterface: at org.apache.cordova.CordovaActivity.onActivityResult(CordovaActivity.java:320) 10-07 07:04:42.010 5918 5918 W ExifInterface: at android.app.Activity.dispatchActivityResult(Activity.java:7137) 10-07 07:04:42.010 5918 5918 W ExifInterface: at android.app.ActivityThread.deliverResults(ActivityThread.java:4916) 10-07 07:04:42.010 5918 5918 W ExifInterface: at android.app.ActivityThread.handleSendResult(ActivityThread.java:4963) 10-07 07:04:42.010 5918 5918 W ExifInterface: at android.app.ActivityThread.access$1600(ActivityThread.java:221) 10-07 07:04:42.010 5918 5918 W ExifInterface: at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1848) 10-07 07:04:42.010 5918 5918 W ExifInterface: at android.os.Handler.dispatchMessage(Handler.java:102) 10-07 07:04:42.010 5918 5918 W ExifInterface: at android.os.Looper.loop(Looper.java:158) 10-07 07:04:42.010 5918 5918 W ExifInterface: at android.app.ActivityThread.main(ActivityThread.java:7224) 10-07 07:04:42.010 5918 5918 W ExifInterface: at java.lang.reflect.Method.invoke(Native Method) 10-07 07:04:42.010 5918 5918 W ExifInterface: at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1230) 10-07 07:04:42.010 5918 5918 W ExifInterface: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1120) 10-07 07:04:42.010 5918 5918 I NativeCameraLauncher: Bitmap not compressed 10-07 07:04:42.010 5918 5918 W System.err: java.io.EOFException 10-07 07:04:42.010 5918 5918 W System.err: at java.io.DataInputStream.readByte(DataInputStream.java:77) 10-07 07:04:42.010 5918 5918 W System.err: at android.media.ExifInterface.saveJpegAttributes(ExifInterface.java:1730) 10-07 07:04:42.010 5918 5918 W System.err: at android.media.ExifInterface.saveAttributes(ExifInterface.java:1388) 10-07 07:04:42.010 5918 5918 W System.err: at com.wezka.nativecamera.ExifHelper.writeExifData(ExifHelper.java:180) 10-07 07:04:42.010 5918 5918 W System.err: at com.wezka.nativecamera.NativeCameraLauncher.onActivityResult(NativeCameraLauncher.java:436) 10-07 07:04:42.010 5918 5918 W System.err: at org.apache.cordova.CordovaInterfaceImpl.onActivityResult(CordovaInterfaceImpl.java:120) 10-07 07:04:42.010 5918 5918 W System.err: at org.apache.cordova.CordovaActivity.onActivityResult(CordovaActivity.java:320) 10-07 07:04:42.010 5918 5918 W System.err: at android.app.Activity.dispatchActivityResult(Activity.java:7137) 10-07 07:04:42.010 5918 5918 W System.err: at android.app.ActivityThread.deliverResults(ActivityThread.java:4916) 10-07 07:04:42.010 5918 5918 W System.err: at android.app.ActivityThread.handleSendResult(ActivityThread.java:4963) 10-07 07:04:42.010 5918 5918 W System.err: at android.app.ActivityThread.access$1600(ActivityThread.java:221) 10-07 07:04:42.010 5918 5918 W System.err: at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1848) 10-07 07:04:42.010 5918 5918 W System.err: at android.os.Handler.dispatchMessage(Handler.java:102) 10-07 07:04:42.010 5918 5918 W System.err: at android.os.Looper.loop(Looper.java:158) 10-07 07:04:42.010 5918 5918 W System.err: at android.app.ActivityThread.main(ActivityThread.java:7224) 10-07 07:04:42.010 5918 5918 W System.err: at java.lang.reflect.Method.invoke(Native Method) 10-07 07:04:42.010 5918 5918 W System.err: at com.android.internal.
[jira] [Closed] (CB-11959) filetrasnfer.spec.21 fails on iOS and Windows Store
[ https://issues.apache.org/jira/browse/CB-11959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Sorokin closed CB-11959. -- Resolution: Fixed > filetrasnfer.spec.21 fails on iOS and Windows Store > --- > > Key: CB-11959 > URL: https://issues.apache.org/jira/browse/CB-11959 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File Transfer >Affects Versions: Master >Reporter: Alexander Sorokin >Assignee: Alexander Sorokin > Labels: found-by-ci, triaged > > http://cordova-ci.cloudapp.net:8080/view/Toolset%20testing/job/cordova-plugin-file-transfer-toolset/ -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11964) Gradle build failure after any plugin installation
[
https://issues.apache.org/jira/browse/CB-11964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1241#comment-1241
]
ASF GitHub Bot commented on CB-11964:
-
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/339#discussion_r82400883
--- Diff: bin/templates/cordova/Api.js ---
@@ -349,13 +354,24 @@ Api.prototype.run = function(runOptions) {
*/
Api.prototype.clean = function(cleanOptions) {
var self = this;
+try {
--- End diff --
I think instead of doing this `try catch` in product code we could just
mock `Api.prototype.clean()` in tests. Please see my attempt at doing so:
https://github.com/alsorokin/cordova-android/commit/008f46a1f3e807ee0ec1b576cd1a5d84e779d838
> Gradle build failure after any plugin installation
> --
>
> Key: CB-11964
> URL: https://issues.apache.org/jira/browse/CB-11964
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
>Affects Versions: Master
> Environment: node 4.4.3
> cordova 6.3.0
>Reporter: Alexander Sorokin
> Labels: found-by-ci, triaged
>
> {noformat}
> cordova create foo
> cd foo
> cordova platform add android@https://github.com/apache/cordova-android
> cordova build
> cordova plugin add cordova-plugin-device
> cordova build
> {noformat}
> Results in the following error:
> {noformat}
> BUILD FAILED
> Total time: 2.439 secs
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException:
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> > (Access is denied)
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or
> --debug option to get more log output.
> Error: cmd: Command failed with exit code 1 Error output:
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException:
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> > (Access is denied)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11964) Gradle build failure after any plugin installation
[
https://issues.apache.org/jira/browse/CB-11964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1242#comment-1242
]
ASF GitHub Bot commented on CB-11964:
-
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/339#discussion_r82400488
--- Diff: bin/templates/cordova/Api.js ---
@@ -212,6 +212,11 @@ Api.prototype.addPlugin = function (plugin,
installOptions) {
installOptions.android_studio = true;
}
+//CB-11964: Do a clean when installing the plugin code to get around
+//the Gradle bug introduced by the Android Gradle Plugin Version 2.2
+//TODO: Delete when the next version of Android Gradle plugin comes out
+
+this.clean();
--- End diff --
Is it out of promise chain intentionally? I think that `this.clean()`
returns a promise.
I've tried to merge it to the promise chain, but got the following
exception upon `cordova platform add`:
```
Error: ENOENT: no such file or directory, open
'C:\Cordova\foo\platforms\android\assets\www\cordova_plugins.js'
at Error (native)
at Object.fs.openSync (fs.js:549:18)
at Object.fs.writeFileSync (fs.js:1156:15)
at
C:\Cordova\foo\platforms\android\cordova\node_modules\cordova-common\src\PluginManager.js:137:12
at _fulfilled
(C:\Cordova\foo\platforms\android\cordova\node_modules\q\q.js:834:54)
at self.promiseDispatch.done
(C:\Cordova\foo\platforms\android\cordova\node_modules\q\q.js:863:30)
at Promise.promise.promiseDispatch
(C:\Cordova\foo\platforms\android\cordova\node_modules\q\q.js:796:13)
at C:\Cordova\foo\platforms\android\cordova\node_modules\q\q.js:857:14
at runSingle
(C:\Cordova\foo\platforms\android\cordova\node_modules\q\q.js:137:13)
at flush
(C:\Cordova\foo\platforms\android\cordova\node_modules\q\q.js:125:13)
```
I wonder why it works the way you put it and if it is dangerous to leave it
like this.
> Gradle build failure after any plugin installation
> --
>
> Key: CB-11964
> URL: https://issues.apache.org/jira/browse/CB-11964
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
>Affects Versions: Master
> Environment: node 4.4.3
> cordova 6.3.0
>Reporter: Alexander Sorokin
> Labels: found-by-ci, triaged
>
> {noformat}
> cordova create foo
> cd foo
> cordova platform add android@https://github.com/apache/cordova-android
> cordova build
> cordova plugin add cordova-plugin-device
> cordova build
> {noformat}
> Results in the following error:
> {noformat}
> BUILD FAILED
> Total time: 2.439 secs
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException:
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> > (Access is denied)
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or
> --debug option to get more log output.
> Error: cmd: Command failed with exit code 1 Error output:
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException:
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> > (Access is denied)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11966) Make durationHint parameter for requestAudioContext configurable
[ https://issues.apache.org/jira/browse/CB-11966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15554968#comment-15554968 ] Jörn Zaefferer commented on CB-11966: - I managed to fix my specific problem with a fork that always sets AUDIOFOCUS_GAIN_TRANSIENT. It also abandons audio focus when all players are released: https://github.com/ilovept/cordova-plugin-media/commit/7e77477ff98be206780f03b3a82f1ee12c9db4e9 Since I have no idea how to expose the durationHint, there's little point in sending a pull request for this commit. With some guidance on the API design, I might be able to put something together. Otherwise I hope my commit can be a starting point for whoever ends up having to solve the same issue. > Make durationHint parameter for requestAudioContext configurable > > > Key: CB-11966 > URL: https://issues.apache.org/jira/browse/CB-11966 > Project: Apache Cordova > Issue Type: New Feature > Components: Plugin Media >Reporter: Jörn Zaefferer > Labels: android > > Android supports playback of so-called transient audio, like instructions > from navigation software or a beep from a timer or messenger, via the > AudioManager#requestAudioFocus method's `durationHint` parameter. Currently > this is hardcoded to AUDIOFOCUS_GAIN: > https://github.com/apache/cordova-plugin-media/blob/0a5a72df42ddd91c50f2a36d0c58408c3b43a9fd/src/android/AudioHandler.java#L445 > That causes all other audio, like music or a podcast, to be stopped. Setting > it instead to AUDIOFOCUS_GAIN_TRANSIENT would only pause other audio while > the sound is playing. AUDIOFOCUS_GAIN_TRANSIENT_MAY_DUCK allows other audio > to only lower volume, without pausing. There's also > AUDIOFOCUS_GAIN_TRANSIENT_EXCLUSIVE, but I don't understand what that does. > For more background, see > https://developer.android.com/training/managing-audio/audio-focus.html > I suggest adding a (Android specific) option to override the default to one > of the transient values. > Since the caller is itself called by `startPlayingAudio()` ( > https://github.com/apache/cordova-plugin-media/blob/0a5a72df42ddd91c50f2a36d0c58408c3b43a9fd/src/android/AudioHandler.java#L318 > ), it might make sense to make this a parameter of the `media.play()` > method. I'm not sure what a good format would be. Passing an `int` is kinda > bad. Apparently none of the existing methods have any configuration. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11699) FileReader.READ_CHUNK_SIZE is not working with Base64 conversion
[ https://issues.apache.org/jira/browse/CB-11699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15554923#comment-15554923 ] ASF GitHub Bot commented on CB-11699: - Github user beatgrabe commented on the issue: https://github.com/apache/cordova-plugin-file/pull/191 @vladimir-kotikov Thank you a lot, your PR fixed exactly an issue I was facing today! > FileReader.READ_CHUNK_SIZE is not working with Base64 conversion > > > Key: CB-11699 > URL: https://issues.apache.org/jira/browse/CB-11699 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Affects Versions: 4.2.0 > Environment: Bug in JavaScript so all platforms will be affected >Reporter: Tony Leung >Assignee: Vladimir Kotikov > Labels: reproduced, triaged > > CB-7862 - the fix for reading files in chunks defined the chunk size as > follow: > FileReader.READ_CHUNK_SIZE = 256*1024; > I found a bug on iOS that readAsDataURL in CDVFile.m, converting it to Base64 > will not work because the chunk size 262144 is not dividable by 3. > The quick fix will be FileReader.READ_CHUNK_SIZE = (256*1024) - 1 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-11972) File transfer not working for windows phone more then 2MB file size
[ https://issues.apache.org/jira/browse/CB-11972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Shakhnazarov closed CB-11972. Resolution: Duplicate > File transfer not working for windows phone more then 2MB file size > --- > > Key: CB-11972 > URL: https://issues.apache.org/jira/browse/CB-11972 > Project: Apache Cordova > Issue Type: Bug > Components: WP8 (deprecated) >Affects Versions: 3.5.0 > Environment: Windows phone >Reporter: Naitik Patel >Priority: Minor > Labels: windows > Original Estimate: 96h > Remaining Estimate: 96h > > File transfer not working for windows phone more then 2MB file size when it's > working with Android and IOS -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11972) File transfer not working for windows phone more then 2MB file size
Naitik Patel created CB-11972: - Summary: File transfer not working for windows phone more then 2MB file size Key: CB-11972 URL: https://issues.apache.org/jira/browse/CB-11972 Project: Apache Cordova Issue Type: Bug Components: WP8 (deprecated) Affects Versions: 3.5.0 Environment: Windows phone Reporter: Naitik Patel Priority: Minor File transfer not working for windows phone more then 2MB file size when it's working with Android and IOS -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11971) File transfer not working for windows phone more then 2MB file size
Naitik Patel created CB-11971: - Summary: File transfer not working for windows phone more then 2MB file size Key: CB-11971 URL: https://issues.apache.org/jira/browse/CB-11971 Project: Apache Cordova Issue Type: Bug Components: WP8 (deprecated) Affects Versions: 3.5.0 Environment: Windows phone Reporter: Naitik Patel Priority: Minor File transfer not working for windows phone more then 2MB file size when it's working with Android and IOS -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-11816) EventEmitter leaks in tests
[ https://issues.apache.org/jira/browse/CB-11816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah resolved CB-11816. --- Resolution: Cannot Reproduce I don't see the warnings anymore > EventEmitter leaks in tests > --- > > Key: CB-11816 > URL: https://issues.apache.org/jira/browse/CB-11816 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Shazron Abdullah > > Run 'npm test' and see this warning: > (node:81096) Warning: Possible EventEmitter memory leak detected. 11 error > listeners added. Use emitter.setMaxListeners() to increase limit -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-11433) Permission dialog display cordova package path instead of plain text message
[
https://issues.apache.org/jira/browse/CB-11433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Kotikov closed CB-11433.
-
Resolution: Not A Bug
> Permission dialog display cordova package path instead of plain text message
>
>
> Key: CB-11433
> URL: https://issues.apache.org/jira/browse/CB-11433
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Geolocation
>Affects Versions: 2.2.0
> Environment: ios 9.3.x
>Reporter: Philipp Kursawe
> Labels: triaged, wfc
>
> When having this react component
> {code}
> import React from "react"
> import { connect } from "react-redux"
> import { update } from "../geolocationActions"
> class GeoLocation extends React.Component {
> constructor(props) {
> super(props)
> this.updatePosition = position => props.update(position)
> this.onError = () => props.update(null)
> }
> componentWillMount() {
> this.watchId = navigator.geolocation.watchPosition(this.updatePosition,
> this.onError)
> }
> componentWillUnmount() {
> navigator.geolocation.clearWatch(this.watchId)
> }
> render() {
> return null
> }
> }
> GeoLocation.propTypes = {
> update: React.PropTypes.func.isRequired,
> }
> export default connect(null, { update })(GeoLocation)
> {code}
> Sometimes the phone displays the correct permission question:
> https://1drv.ms/i/s!AjrwWLsSkwcs1YlgMrdeK9AvkCwe7g
> but sometimes (even right after the first dialog) another dialog is displayed
> and the app hangs after it has been closed.
> https://1drv.ms/i/s!AjrwWLsSkwcs1YlfkCT9F6OKUK9iRQ
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11433) Permission dialog display cordova package path instead of plain text message
[
https://issues.apache.org/jira/browse/CB-11433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15554726#comment-15554726
]
Vladimir Kotikov commented on CB-11433:
---
Ah yes, I remember you mentioned that in Slack. Okay, closing this.
> Permission dialog display cordova package path instead of plain text message
>
>
> Key: CB-11433
> URL: https://issues.apache.org/jira/browse/CB-11433
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Geolocation
>Affects Versions: 2.2.0
> Environment: ios 9.3.x
>Reporter: Philipp Kursawe
> Labels: triaged, wfc
>
> When having this react component
> {code}
> import React from "react"
> import { connect } from "react-redux"
> import { update } from "../geolocationActions"
> class GeoLocation extends React.Component {
> constructor(props) {
> super(props)
> this.updatePosition = position => props.update(position)
> this.onError = () => props.update(null)
> }
> componentWillMount() {
> this.watchId = navigator.geolocation.watchPosition(this.updatePosition,
> this.onError)
> }
> componentWillUnmount() {
> navigator.geolocation.clearWatch(this.watchId)
> }
> render() {
> return null
> }
> }
> GeoLocation.propTypes = {
> update: React.PropTypes.func.isRequired,
> }
> export default connect(null, { update })(GeoLocation)
> {code}
> Sometimes the phone displays the correct permission question:
> https://1drv.ms/i/s!AjrwWLsSkwcs1YlgMrdeK9AvkCwe7g
> but sometimes (even right after the first dialog) another dialog is displayed
> and the app hangs after it has been closed.
> https://1drv.ms/i/s!AjrwWLsSkwcs1YlfkCT9F6OKUK9iRQ
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-11071) Cordova 4 removed the shouldRotateToOrientation call which breaks the screen orientation plugins
[ https://issues.apache.org/jira/browse/CB-11071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah resolved CB-11071. --- Resolution: Fixed The referred to plugin has been rolled into cordova as a core plugin and should work with cordova-ios-4: https://github.com/apache/cordova-plugin-screen-orientation > Cordova 4 removed the shouldRotateToOrientation call which breaks the screen > orientation plugins > > > Key: CB-11071 > URL: https://issues.apache.org/jira/browse/CB-11071 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 4.0.0 > Environment: Ionic 2, iOS, Android, Mac, Cordova 4.0 >Reporter: Adrian Leung > Labels: triaged > > Cordova 4 removed the shouldRotateToOrientation call which breaks the screen > orientation plugins that everyone else is using! > If you are installing a fresh install of cordova you will likely get cordova > iOS v4.0.x, there are a number of issues related to this already e.g #84. You > could try an install cordova iOS from the 3 branch and you may have more > luck. At this stage I have not had time to find a solution after cordova 4 > removed the shouldRotateToOrientation call. > https://github.com/gbenvenuti/cordova-plugin-screen-orientation/issues/98 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-11946) Blog post for Node 0.x and 4.x deprecation timelines
[ https://issues.apache.org/jira/browse/CB-11946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah resolved CB-11946. --- Resolution: Fixed > Blog post for Node 0.x and 4.x deprecation timelines > > > Key: CB-11946 > URL: https://issues.apache.org/jira/browse/CB-11946 > Project: Apache Cordova > Issue Type: Task > Components: Docs >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > Proposal was here: https://github.com/cordova/cordova-discuss/pull/52 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11389) Prevent Cordova from creating launch images
[ https://issues.apache.org/jira/browse/CB-11389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-11389: -- Assignee: (was: Shazron Abdullah) > Prevent Cordova from creating launch images > --- > > Key: CB-11389 > URL: https://issues.apache.org/jira/browse/CB-11389 > Project: Apache Cordova > Issue Type: Improvement > Components: iOS >Affects Versions: 6.0.0, 6.1.1 > Environment: Normal Cordova project. >Reporter: Andrea Tino >Priority: Minor > Fix For: 6.0.0, 6.1.1 > > > When creating a project, I do not want default launch images to be created as > a storyboard will be used instead. > However, if no launch images are specified in the config file, then Cordova > will create default launch screens. How to prevent them from being created, > and how to remove the ASSETCATALOG_COMPILER_LAUNCHIMAGE_NAME setting as well? -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11245) Swift plugins need additional build settings
[
https://issues.apache.org/jira/browse/CB-11245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shazron Abdullah updated CB-11245:
--
Fix Version/s: cordova-ios@4.4.0
> Swift plugins need additional build settings
>
>
> Key: CB-11245
> URL: https://issues.apache.org/jira/browse/CB-11245
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
>Reporter: Darryl Pogue
>Assignee: Shazron Abdullah
>Priority: Minor
> Labels: cordova-ios-5.0.x, triaged
> Fix For: cordova-ios@4.4.0
>
>
> Plugins written in Swift require some additional build settings in order to
> work properly (and not crash the app immediately).
> In particular, {{EMBEDDED_CONTENT_CONTAINS_SWIFT = "YES"}} and
> {{LD_RUNPATH_SEARCH_PATHS = "@executable_path/Frameworks"}} are required.
> This could be handled in a general way by allowing plugins to add their own
> options to .xcconfig (but could result in duplication), or for this specific
> case it is probably enough to set these if any plugins contain .swift files.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11700) Footer or whitespace appears at bottom after calling getPicture
[ https://issues.apache.org/jira/browse/CB-11700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-11700: -- Environment: iOS Component/s: (was: iOS) > Footer or whitespace appears at bottom after calling getPicture > --- > > Key: CB-11700 > URL: https://issues.apache.org/jira/browse/CB-11700 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Camera > Environment: iOS >Reporter: Brandon > > The issue does not appear in a new project until getPicture is called and the > application returns from the camera. The size in pixels of the issue area at > the bottom of the screen corresponds to the size of the status bar. Once the > issue is triggered for the first time, the issue exists for any other device > opening the application for the first time without calling getPicture. Even > clearing cache or restarting device or server does not get rid of the > whitespace once caused. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11893) Provide a way to add use_frameworks! on the Podfile
[ https://issues.apache.org/jira/browse/CB-11893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15554681#comment-15554681 ] jcesarmobile commented on CB-11893: --- Another idea is to use the config-file tag to write into the Podfile, but it might require a lot of changes as the Podfile is not xml based > Provide a way to add use_frameworks! on the Podfile > --- > > Key: CB-11893 > URL: https://issues.apache.org/jira/browse/CB-11893 > Project: Apache Cordova > Issue Type: New Feature > Components: iOS >Reporter: jcesarmobile > Fix For: cordova-ios@4.4.0 > > > If the library you want to use on the plugin uses Swift or you want to use > dynamic frameworks you have to add use_frameworks! on the Podfile > I don't think there is a way of adding it right now. > We should provide a way of adding it -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11433) Permission dialog display cordova package path instead of plain text message
[
https://issues.apache.org/jira/browse/CB-11433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15554679#comment-15554679
]
Philipp Kursawe commented on CB-11433:
--
Sorry, no the issue has gone. It was related to how I load my and the cordova
scripts. I used and the iOS webkit can't handle that properly
it seems. It created all kind of weird issues.
And the one here was one of them.
> Permission dialog display cordova package path instead of plain text message
>
>
> Key: CB-11433
> URL: https://issues.apache.org/jira/browse/CB-11433
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Geolocation
>Affects Versions: 2.2.0
> Environment: ios 9.3.x
>Reporter: Philipp Kursawe
> Labels: triaged, wfc
>
> When having this react component
> {code}
> import React from "react"
> import { connect } from "react-redux"
> import { update } from "../geolocationActions"
> class GeoLocation extends React.Component {
> constructor(props) {
> super(props)
> this.updatePosition = position => props.update(position)
> this.onError = () => props.update(null)
> }
> componentWillMount() {
> this.watchId = navigator.geolocation.watchPosition(this.updatePosition,
> this.onError)
> }
> componentWillUnmount() {
> navigator.geolocation.clearWatch(this.watchId)
> }
> render() {
> return null
> }
> }
> GeoLocation.propTypes = {
> update: React.PropTypes.func.isRequired,
> }
> export default connect(null, { update })(GeoLocation)
> {code}
> Sometimes the phone displays the correct permission question:
> https://1drv.ms/i/s!AjrwWLsSkwcs1YlgMrdeK9AvkCwe7g
> but sometimes (even right after the first dialog) another dialog is displayed
> and the app hangs after it has been closed.
> https://1drv.ms/i/s!AjrwWLsSkwcs1YlfkCT9F6OKUK9iRQ
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-11936) Support four new App Transport Security (ATS) keys
[ https://issues.apache.org/jira/browse/CB-11936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah resolved CB-11936. --- Resolution: Fixed > Support four new App Transport Security (ATS) keys > -- > > Key: CB-11936 > URL: https://issues.apache.org/jira/browse/CB-11936 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaCommon, Docs, iOS >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > https://forums.developer.apple.com/thread/6767 > NSAllowsArbitraryLoadsInWebContent (defaults to NO) > NSRequiresCertificateTransparency (defaults to NO) > NSAllowsLocalNetworking (defaults to NO) > NSAllowsArbitraryLoadsInMedia (defaults to NO) > NSRequiresCertificateTransparency is not top level, but is under > NSExceptionDomains > 1. Add this feature to the iOS platform > 2. Add new attribute parsing to ConfigParser in CordovaCommon > 3. Add docs for new attributes -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11895) openURL deprecated in iOS 10 (new selector replaces it)
[ https://issues.apache.org/jira/browse/CB-11895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-11895: -- Fix Version/s: cordova-ios@4.3.1 > openURL deprecated in iOS 10 (new selector replaces it) > --- > > Key: CB-11895 > URL: https://issues.apache.org/jira/browse/CB-11895 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Reporter: Shazron Abdullah > Labels: easyfix > Fix For: cordova-ios@4.3.1 > > > Article: > http://useyourloaf.com/blog/openurl-deprecated-in-ios10 > Our usage: > https://github.com/apache/cordova-ios/blob/3bda0ef487f204e60def4ff1ecf844862460313e/CordovaLib/Classes/Private/Plugins/CDVIntentAndNavigationFilter/CDVIntentAndNavigationFilter.m#L121 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11952) Should be able to pass flags to xcodebuild
[ https://issues.apache.org/jira/browse/CB-11952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-11952: -- Fix Version/s: cordova-ios@4.3.1 > Should be able to pass flags to xcodebuild > -- > > Key: CB-11952 > URL: https://issues.apache.org/jira/browse/CB-11952 > Project: Apache Cordova > Issue Type: Improvement > Components: iOS >Reporter: Andrew Zellman >Assignee: Shazron Abdullah > Labels: features > Fix For: cordova-ios@4.3.1 > > > Cordova developers should be able to pass additional flags to xcodebuild when > compiling their projects. This can be done by adding a --buildFlag option in > cordova-ios that allows multiples declarations. There will need to be > additional attention to conflicts that may happen with xcodebuild arguments > injected by Cordova. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11893) Provide a way to add use_frameworks! on the Podfile
[ https://issues.apache.org/jira/browse/CB-11893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-11893: -- Fix Version/s: cordova-ios@4.3.1 > Provide a way to add use_frameworks! on the Podfile > --- > > Key: CB-11893 > URL: https://issues.apache.org/jira/browse/CB-11893 > Project: Apache Cordova > Issue Type: New Feature > Components: iOS >Reporter: jcesarmobile > Fix For: cordova-ios@4.3.1 > > > If the library you want to use on the plugin uses Swift or you want to use > dynamic frameworks you have to add use_frameworks! on the Podfile > I don't think there is a way of adding it right now. > We should provide a way of adding it -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11893) Provide a way to add use_frameworks! on the Podfile
[ https://issues.apache.org/jira/browse/CB-11893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15554659#comment-15554659 ] Shazron Abdullah commented on CB-11893: --- This would have to be in a future release since having use_frameworks! enabled may be problematic in a mixed environment of static libs / dynamic frameworks: https://github.com/CocoaPods/CocoaPods/issues/4605 An idea is for it to be an attribute on the tag. It will have to be generic, and support other Podfile flags: https://guides.cocoapods.org/syntax/podfile.html > Provide a way to add use_frameworks! on the Podfile > --- > > Key: CB-11893 > URL: https://issues.apache.org/jira/browse/CB-11893 > Project: Apache Cordova > Issue Type: New Feature > Components: iOS >Reporter: jcesarmobile > > If the library you want to use on the plugin uses Swift or you want to use > dynamic frameworks you have to add use_frameworks! on the Podfile > I don't think there is a way of adding it right now. > We should provide a way of adding it -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11970) Support CocoaPod pod specification other than version
[ https://issues.apache.org/jira/browse/CB-11970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-11970: -- Description: https://github.com/apache/cordova-ios/blob/636113f047ee2c7dae742dff2beafae2121ceb62/bin/templates/scripts/cordova/lib/Podfile.js#L149 Podfile spec: https://guides.cocoapods.org/syntax/podfile.html#pod If the spec begins with a colon ":", don't quote it when writing to the Podfile. Make sure this function works as well, after: https://github.com/apache/cordova-ios/blob/636113f047ee2c7dae742dff2beafae2121ceb62/bin/templates/scripts/cordova/lib/Podfile.js#L61 was: https://github.com/apache/cordova-ios/blob/636113f047ee2c7dae742dff2beafae2121ceb62/bin/templates/scripts/cordova/lib/Podfile.js#L149 Podfile spec: https://guides.cocoapods.org/syntax/podfile.html#pod If the spec begins with a colon ":", don't quote it when writing to the Podfile. > Support CocoaPod pod specification other than version > - > > Key: CB-11970 > URL: https://issues.apache.org/jira/browse/CB-11970 > Project: Apache Cordova > Issue Type: Improvement > Components: iOS >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > https://github.com/apache/cordova-ios/blob/636113f047ee2c7dae742dff2beafae2121ceb62/bin/templates/scripts/cordova/lib/Podfile.js#L149 > Podfile spec: > https://guides.cocoapods.org/syntax/podfile.html#pod > If the spec begins with a colon ":", don't quote it when writing to the > Podfile. > Make sure this function works as well, after: > https://github.com/apache/cordova-ios/blob/636113f047ee2c7dae742dff2beafae2121ceb62/bin/templates/scripts/cordova/lib/Podfile.js#L61 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11970) Support CocoaPod pod specification other than version
Shazron Abdullah created CB-11970: - Summary: Support CocoaPod pod specification other than version Key: CB-11970 URL: https://issues.apache.org/jira/browse/CB-11970 Project: Apache Cordova Issue Type: Improvement Components: iOS Reporter: Shazron Abdullah Assignee: Shazron Abdullah https://github.com/apache/cordova-ios/blob/636113f047ee2c7dae742dff2beafae2121ceb62/bin/templates/scripts/cordova/lib/Podfile.js#L149 Podfile spec: https://guides.cocoapods.org/syntax/podfile.html#pod If the spec begins with a colon ":", don't quote it when writing to the Podfile. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11893) Provide a way to add use_frameworks! on the Podfile
[ https://issues.apache.org/jira/browse/CB-11893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-11893: -- Component/s: iOS > Provide a way to add use_frameworks! on the Podfile > --- > > Key: CB-11893 > URL: https://issues.apache.org/jira/browse/CB-11893 > Project: Apache Cordova > Issue Type: New Feature > Components: iOS >Reporter: jcesarmobile > > If the library you want to use on the plugin uses Swift or you want to use > dynamic frameworks you have to add use_frameworks! on the Podfile > I don't think there is a way of adding it right now. > We should provide a way of adding it -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11803) Plugin features don't get written to iOS-specific config.xml
[
https://issues.apache.org/jira/browse/CB-11803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shazron Abdullah updated CB-11803:
--
Description:
When running `cordova prepare` or `cordova platform add ios` after adding
plugins, the platform-specific config.xml file for iOS
(`platforms/ios/NAME/config.xml`) doesn't have `` tags, which
effectively prevents any installed plugin from working.
The tags *do* get added when installing plugins *after* the iOS platform was
created.
How to reproduce - this creates a working config.xml:
{code}
cordova create test
cd test
cordova platform add ios
cordova plugin add cordova-plugin-device --save
{code}
This creates a broken config.xml (resulting in `Plugin 'Device' not found, or
is not a CDVPlugin.` error when running on a an iPhone):
{code}
cordova create test
cd test
cordova plugin add cordova-plugin-device --save
cordova platform add ios
{code}
was:
When running `cordova prepare` or `cordova platform add ios` after adding
plugins, the platform-specific config.xml file for iOS
(`platforms/ios/NAME/config.xml`) doesn't have `` tags, which
effectively prevents any installed plugin from working.
The tags *do* get added when installing plugins *after* the iOS platform was
created.
How to reproduce - this creates a working config.xml:
cordova create test
cd test
cordova platform add ios
cordova plugin add cordova-plugin-device --save
This creates a broken config.xml (resulting in `Plugin 'Device' not found, or
is not a CDVPlugin.` error when running on a an iPhone):
cordova create test
cd test
cordova plugin add cordova-plugin-device --save
cordova platform add ios
> Plugin features don't get written to iOS-specific config.xml
>
>
> Key: CB-11803
> URL: https://issues.apache.org/jira/browse/CB-11803
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI, iOS, Plugins
>Affects Versions: 6.3.1
>Reporter: Matus Koprda
>Priority: Critical
>
> When running `cordova prepare` or `cordova platform add ios` after adding
> plugins, the platform-specific config.xml file for iOS
> (`platforms/ios/NAME/config.xml`) doesn't have `` tags, which
> effectively prevents any installed plugin from working.
> The tags *do* get added when installing plugins *after* the iOS platform was
> created.
> How to reproduce - this creates a working config.xml:
> {code}
> cordova create test
> cd test
> cordova platform add ios
> cordova plugin add cordova-plugin-device --save
> {code}
> This creates a broken config.xml (resulting in `Plugin 'Device' not found, or
> is not a CDVPlugin.` error when running on a an iPhone):
> {code}
> cordova create test
> cd test
> cordova plugin add cordova-plugin-device --save
> cordova platform add ios
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11803) Plugin features don't get written to iOS-specific config.xml
[ https://issues.apache.org/jira/browse/CB-11803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15554535#comment-15554535 ] Shazron Abdullah commented on CB-11803: --- This may be the culprit: https://github.com/apache/cordova-lib/blob/4ca3b4ca12a01ded923734e4d92d7f9325d540dc/cordova-lib/src/cordova/platform.js#L206 ... which is a fix for https://issues.apache.org/jira/browse/CB-11589 > Plugin features don't get written to iOS-specific config.xml > > > Key: CB-11803 > URL: https://issues.apache.org/jira/browse/CB-11803 > Project: Apache Cordova > Issue Type: Bug > Components: CLI, iOS, Plugins >Affects Versions: 6.3.1 >Reporter: Matus Koprda >Priority: Critical > > When running `cordova prepare` or `cordova platform add ios` after adding > plugins, the platform-specific config.xml file for iOS > (`platforms/ios/NAME/config.xml`) doesn't have `` tags, which > effectively prevents any installed plugin from working. > The tags *do* get added when installing plugins *after* the iOS platform was > created. > How to reproduce - this creates a working config.xml: > cordova create test > cd test > cordova platform add ios > cordova plugin add cordova-plugin-device --save > This creates a broken config.xml (resulting in `Plugin 'Device' not found, or > is not a CDVPlugin.` error when running on a an iPhone): > cordova create test > cd test > cordova plugin add cordova-plugin-device --save > cordova platform add ios -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-11433) Permission dialog display cordova package path instead of plain text message
[
https://issues.apache.org/jira/browse/CB-11433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15554489#comment-15554489
]
Vladimir Kotikov edited comment on CB-11433 at 10/7/16 8:11 AM:
Hey, [~pke], is this still valid? Are you still seeing the problem?
was (Author: vladimir.kotikov):
Hey, [~pke], is this still valid? Are you still seeing the problem?
> Permission dialog display cordova package path instead of plain text message
>
>
> Key: CB-11433
> URL: https://issues.apache.org/jira/browse/CB-11433
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Geolocation
>Affects Versions: 2.2.0
> Environment: ios 9.3.x
>Reporter: Philipp Kursawe
> Labels: triaged, wfc
>
> When having this react component
> {code}
> import React from "react"
> import { connect } from "react-redux"
> import { update } from "../geolocationActions"
> class GeoLocation extends React.Component {
> constructor(props) {
> super(props)
> this.updatePosition = position => props.update(position)
> this.onError = () => props.update(null)
> }
> componentWillMount() {
> this.watchId = navigator.geolocation.watchPosition(this.updatePosition,
> this.onError)
> }
> componentWillUnmount() {
> navigator.geolocation.clearWatch(this.watchId)
> }
> render() {
> return null
> }
> }
> GeoLocation.propTypes = {
> update: React.PropTypes.func.isRequired,
> }
> export default connect(null, { update })(GeoLocation)
> {code}
> Sometimes the phone displays the correct permission question:
> https://1drv.ms/i/s!AjrwWLsSkwcs1YlgMrdeK9AvkCwe7g
> but sometimes (even right after the first dialog) another dialog is displayed
> and the app hangs after it has been closed.
> https://1drv.ms/i/s!AjrwWLsSkwcs1YlfkCT9F6OKUK9iRQ
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11433) Permission dialog display cordova package path instead of plain text message
[
https://issues.apache.org/jira/browse/CB-11433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15554489#comment-15554489
]
Vladimir Kotikov commented on CB-11433:
---
Hey, [~pke], is this still valid? Are you still seeing the problem?
> Permission dialog display cordova package path instead of plain text message
>
>
> Key: CB-11433
> URL: https://issues.apache.org/jira/browse/CB-11433
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Geolocation
>Affects Versions: 2.2.0
> Environment: ios 9.3.x
>Reporter: Philipp Kursawe
> Labels: triaged, wfc
>
> When having this react component
> {code}
> import React from "react"
> import { connect } from "react-redux"
> import { update } from "../geolocationActions"
> class GeoLocation extends React.Component {
> constructor(props) {
> super(props)
> this.updatePosition = position => props.update(position)
> this.onError = () => props.update(null)
> }
> componentWillMount() {
> this.watchId = navigator.geolocation.watchPosition(this.updatePosition,
> this.onError)
> }
> componentWillUnmount() {
> navigator.geolocation.clearWatch(this.watchId)
> }
> render() {
> return null
> }
> }
> GeoLocation.propTypes = {
> update: React.PropTypes.func.isRequired,
> }
> export default connect(null, { update })(GeoLocation)
> {code}
> Sometimes the phone displays the correct permission question:
> https://1drv.ms/i/s!AjrwWLsSkwcs1YlgMrdeK9AvkCwe7g
> but sometimes (even right after the first dialog) another dialog is displayed
> and the app hangs after it has been closed.
> https://1drv.ms/i/s!AjrwWLsSkwcs1YlfkCT9F6OKUK9iRQ
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11952) Should be able to pass flags to xcodebuild
[
https://issues.apache.org/jira/browse/CB-11952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15554473#comment-15554473
]
ASF GitHub Bot commented on CB-11952:
-
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/265#discussion_r82344533
--- Diff: tests/spec/unit/build.spec.js ---
@@ -0,0 +1,255 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+ */
+
+var path = require('path');
+var rewire = require('rewire');
+var build = rewire('../../../bin/templates/scripts/cordova/lib/build');
+
+describe('build', function () {
+var testProjectPath = path.join('/test', 'project', 'path');
+
+describe('getXcodeBuildArgs method', function() {
+
+var getXcodeBuildArgs = build.__get__('getXcodeBuildArgs');
+build.__set__('__dirname', path.join('/test', 'dir'));
+
+it('should generate appropriate args if a single buildFlag is
passed in', function(done) {
+var isDevice = true;
+var buildFlags = '-xcconfig TestXcconfigFlag';
+
+var args = getXcodeBuildArgs('TestProjectName',
testProjectPath, 'TestConfiguration', isDevice, buildFlags);
+expect(args[0]).toEqual('-xcconfig');
+expect(args[1]).toEqual('TestXcconfigFlag');
+expect(args[2]).toEqual('-project');
+expect(args[3]).toEqual('TestProjectName.xcodeproj');
+expect(args[4]).toEqual('ARCHS=armv7 arm64');
+expect(args[5]).toEqual('-target');
+expect(args[6]).toEqual('TestProjectName');
+expect(args[7]).toEqual('-configuration');
+expect(args[8]).toEqual('TestConfiguration');
+expect(args[9]).toEqual('-sdk');
+expect(args[10]).toEqual('iphoneos');
+expect(args[11]).toEqual('build');
+expect(args[12]).toEqual('VALID_ARCHS=armv7 arm64');
+expect(args[13]).toEqual('CONFIGURATION_BUILD_DIR=' +
path.join(testProjectPath, 'build', 'device'));
+expect(args[14]).toEqual('SHARED_PRECOMPS_DIR=' +
path.join(testProjectPath, 'build', 'sharedpch'));
+expect(args.length).toEqual(15);
+done();
+});
--- End diff --
Tests need to be updated once the missing flags are put back.
> Should be able to pass flags to xcodebuild
> --
>
> Key: CB-11952
> URL: https://issues.apache.org/jira/browse/CB-11952
> Project: Apache Cordova
> Issue Type: Improvement
> Components: iOS
>Reporter: Andrew Zellman
>Assignee: Shazron Abdullah
> Labels: features
>
> Cordova developers should be able to pass additional flags to xcodebuild when
> compiling their projects. This can be done by adding a --buildFlag option in
> cordova-ios that allows multiples declarations. There will need to be
> additional attention to conflicts that may happen with xcodebuild arguments
> injected by Cordova.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11952) Should be able to pass flags to xcodebuild
[
https://issues.apache.org/jira/browse/CB-11952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15554472#comment-15554472
]
ASF GitHub Bot commented on CB-11952:
-
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/265#discussion_r82344341
--- Diff: bin/templates/scripts/cordova/lib/build.js ---
@@ -199,33 +220,54 @@ module.exports.findXCodeProjectIn =
findXCodeProjectIn;
* @param {Boolean} isDevice Flag that specify target for package
(device/emulator)
* @return {Array} Array of arguments that could be passed
directly to spawn method
*/
-function getXcodeBuildArgs(projectName, projectPath, configuration,
isDevice) {
+function getXcodeBuildArgs(projectName, projectPath, configuration,
isDevice, buildFlags) {
var xcodebuildArgs;
+var options;
+var buildActions = [ 'build' ];
+var settings;
+var customArgs = {};
+customArgs.otherFlags = [];
+
+if (buildFlags) {
+if (typeof buildFlags === 'string' || buildFlags instanceof
String) {
+parseBuildFlag(buildFlags, customArgs);
+} else { // buildFlags is an Array of strings
+buildFlags.forEach( function(flag) {
+parseBuildFlag(flag, customArgs);
+});
+}
+}
+
if (isDevice) {
-xcodebuildArgs = [
-'-xcconfig', path.join(__dirname, '..', 'build-' +
configuration.toLowerCase() + '.xcconfig'),
-'-workspace', projectName + '.xcworkspace',
-'-scheme', projectName,
-'-configuration', configuration,
-'-destination', 'generic/platform=iOS',
-'-archivePath', projectName + '.xcarchive',
-'archive',
-'CONFIGURATION_BUILD_DIR=' + path.join(projectPath, 'build',
'device'),
-'SHARED_PRECOMPS_DIR=' + path.join(projectPath, 'build',
'sharedpch')
+options = [
+'-xcconfig', customArgs.xcconfig || path.join(__dirname, '..',
'build-' + configuration.toLowerCase() + '.xcconfig'),
+'-project', customArgs.project || projectName + '.xcodeproj',
+customArgs.archs || 'ARCHS=armv7 arm64',
+'-target', customArgs.target || projectName,
+'-configuration', customArgs.configuration || configuration,
+'-sdk', customArgs.sdk || 'iphoneos'
+];
+settings = [
+customArgs.valid_archs || 'VALID_ARCHS=armv7 arm64',
+customArgs.configuration_build_dir ||
'CONFIGURATION_BUILD_DIR=' + path.join(projectPath, 'build', 'device'),
+customArgs.shared_precomps_dir || 'SHARED_PRECOMPS_DIR=' +
path.join(projectPath, 'build', 'sharedpch')
--- End diff --
A lot of essential flags are missing here.
- workspace and scheme are essential for Cocoapods support (we don't use
the project directly anymore)
- archiving is essential for moving off the deprecated packaging in xcrun
- destination is needed as well
> Should be able to pass flags to xcodebuild
> --
>
> Key: CB-11952
> URL: https://issues.apache.org/jira/browse/CB-11952
> Project: Apache Cordova
> Issue Type: Improvement
> Components: iOS
>Reporter: Andrew Zellman
>Assignee: Shazron Abdullah
> Labels: features
>
> Cordova developers should be able to pass additional flags to xcodebuild when
> compiling their projects. This can be done by adding a --buildFlag option in
> cordova-ios that allows multiples declarations. There will need to be
> additional attention to conflicts that may happen with xcodebuild arguments
> injected by Cordova.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11952) Should be able to pass flags to xcodebuild
[
https://issues.apache.org/jira/browse/CB-11952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15554471#comment-15554471
]
ASF GitHub Bot commented on CB-11952:
-
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/265#discussion_r82344457
--- Diff: bin/templates/scripts/cordova/lib/build.js ---
@@ -199,33 +220,54 @@ module.exports.findXCodeProjectIn =
findXCodeProjectIn;
* @param {Boolean} isDevice Flag that specify target for package
(device/emulator)
* @return {Array} Array of arguments that could be passed
directly to spawn method
*/
-function getXcodeBuildArgs(projectName, projectPath, configuration,
isDevice) {
+function getXcodeBuildArgs(projectName, projectPath, configuration,
isDevice, buildFlags) {
var xcodebuildArgs;
+var options;
+var buildActions = [ 'build' ];
+var settings;
+var customArgs = {};
+customArgs.otherFlags = [];
+
+if (buildFlags) {
+if (typeof buildFlags === 'string' || buildFlags instanceof
String) {
+parseBuildFlag(buildFlags, customArgs);
+} else { // buildFlags is an Array of strings
+buildFlags.forEach( function(flag) {
+parseBuildFlag(flag, customArgs);
+});
+}
+}
+
if (isDevice) {
-xcodebuildArgs = [
-'-xcconfig', path.join(__dirname, '..', 'build-' +
configuration.toLowerCase() + '.xcconfig'),
-'-workspace', projectName + '.xcworkspace',
-'-scheme', projectName,
-'-configuration', configuration,
-'-destination', 'generic/platform=iOS',
-'-archivePath', projectName + '.xcarchive',
-'archive',
-'CONFIGURATION_BUILD_DIR=' + path.join(projectPath, 'build',
'device'),
-'SHARED_PRECOMPS_DIR=' + path.join(projectPath, 'build',
'sharedpch')
+options = [
+'-xcconfig', customArgs.xcconfig || path.join(__dirname, '..',
'build-' + configuration.toLowerCase() + '.xcconfig'),
+'-project', customArgs.project || projectName + '.xcodeproj',
+customArgs.archs || 'ARCHS=armv7 arm64',
+'-target', customArgs.target || projectName,
+'-configuration', customArgs.configuration || configuration,
+'-sdk', customArgs.sdk || 'iphoneos'
+];
+settings = [
+customArgs.valid_archs || 'VALID_ARCHS=armv7 arm64',
+customArgs.configuration_build_dir ||
'CONFIGURATION_BUILD_DIR=' + path.join(projectPath, 'build', 'device'),
+customArgs.shared_precomps_dir || 'SHARED_PRECOMPS_DIR=' +
path.join(projectPath, 'build', 'sharedpch')
];
} else { // emulator
-xcodebuildArgs = [
-'-xcconfig', path.join(__dirname, '..', 'build-' +
configuration.toLowerCase() + '.xcconfig'),
-'-workspace', projectName + '.xcworkspace',
-'-scheme', projectName ,
-'-configuration', configuration,
-'-sdk', 'iphonesimulator',
-'-destination', 'platform=iOS Simulator,name=iPhone 5s',
-'build',
-'CONFIGURATION_BUILD_DIR=' + path.join(projectPath, 'build',
'emulator'),
-'SHARED_PRECOMPS_DIR=' + path.join(projectPath, 'build',
'sharedpch')
+options = [
+'-xcconfig', customArgs.xcconfig || path.join(__dirname, '..',
'build-' + configuration.toLowerCase() + '.xcconfig'),
+'-project', customArgs.project || projectName + '.xcodeproj',
+customArgs.archs || 'ARCHS=x86_64 i386',
+'-target', customArgs.target || projectName,
+'-configuration', customArgs.configuration || configuration,
+'-sdk', customArgs.sdk || 'iphonesimulator'
+];
+settings = [
--- End diff --
Same as above. All missing flags are essential.
> Should be able to pass flags to xcodebuild
> --
>
> Key: CB-11952
> URL: https://issues.apache.org/jira/browse/CB-11952
> Project: Apache Cordova
> Issue Type: Improvement
> Components: iOS
>Reporter: Andrew Zellman
>Assignee: Shazron Abdullah
> Labels: features
>
> Cordova developers should be able to pass additional flags to xcodebuild when
> compiling their projects. This can be done by adding a --buildFlag option in
> cordova-ios that allows multiples declarations. There will need to be
> additional attention to conflicts that may happen with xcodeb
