subject:"\[jira\] \[Commented\] \(CB\-11244\) Update Android Project Structure to be more compatible with Android Studio"

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2018-03-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412812#comment-16412812
 ] 

ASF GitHub Bot commented on CB-11244:
-

piotr-cz commented on issue #389: CB-11244: Studio Project Compatibility: Now 
with merge commit
URL: https://github.com/apache/cordova-android/pull/389#issuecomment-375928396
 
 
   [Docs for 
7.x](https://cordova.apache.org/docs/en/latest/guide/platforms/android/#extending-buildgradle)
 should change to reflect new location for `build-extras.gradle` and 
`gradle.properties` as these are now included only when in `/app` subfolder or 
include path in `app/build.gradle` should traverse one folder up.
   
   See https://github.com/apache/cordova-docs/pull/810


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>Priority: Blocker
>  Labels: CordovaAndroidSix, android-next
> Fix For: cordova-android-7.0.0
>
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-11-29 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271237#comment-16271237
 ] 

ASF subversion and git services commented on CB-11244:
--

Commit 59018ab632e99b3e45a0bf9657c70282aeeac7bf in cordova-android's branch 
refs/heads/master from [~bowserj]
[ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=59018ab ]

Merge pull request #389 from infil00p/StudioProjectCompat

CB-11244: Studio Project Compatibility: Now with merge commit

> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>Priority: Blocker
>  Labels: CordovaAndroidSix, android-next
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-11-29 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271231#comment-16271231
 ] 

ASF GitHub Bot commented on CB-11244:
-

infil00p closed pull request #389: CB-11244: Studio Project Compatibility: Now 
with merge commit
URL: https://github.com/apache/cordova-android/pull/389
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/bin/lib/create.js b/bin/lib/create.js
index 40df36658..c96ea6cf9 100755
--- a/bin/lib/create.js
+++ b/bin/lib/create.js
@@ -26,9 +26,10 @@ var fs = require('fs');
 var check_reqs = require('./../templates/cordova/lib/check_reqs');
 var ROOT = path.join(__dirname, '..', '..');
 
-var MIN_SDK_VERSION = 16;
+var MIN_SDK_VERSION = 19;
 
 var CordovaError = require('cordova-common').CordovaError;
+var AndroidStudio = require('../templates/cordova/lib/AndroidStudio');
 var AndroidManifest = require('../templates/cordova/lib/AndroidManifest');
 
 // Export all helper functions, and make sure internally within this module, we
@@ -54,10 +55,16 @@ function getFrameworkDir (projectPath, shared) {
 return shared ? path.join(ROOT, 'framework') : path.join(projectPath, 
'CordovaLib');
 }
 
-function copyJsAndLibrary (projectPath, shared, projectName) {
+function copyJsAndLibrary (projectPath, shared, projectName, isLegacy) {
 var nestedCordovaLibPath = getFrameworkDir(projectPath, false);
 var srcCordovaJsPath = path.join(ROOT, 'bin', 'templates', 'project', 
'assets', 'www', 'cordova.js');
-shell.cp('-f', srcCordovaJsPath, path.join(projectPath, 'assets', 'www', 
'cordova.js'));
+var app_path = path.join(projectPath, 'app', 'src', 'main');
+
+if (isLegacy) {
+app_path = projectPath;
+}
+
+shell.cp('-f', srcCordovaJsPath, path.join(app_path, 'assets', 'www', 
'cordova.js'));
 
 // Copy the cordova.js file to platforms//platform_www/
 // The www dir is nuked on each prepare so we keep cordova.js in 
platform_www
@@ -70,7 +77,7 @@ function copyJsAndLibrary (projectPath, shared, projectName) {
 
 // Don't fail if there are no old jars.
 exports.setShellFatal(false, function () {
-shell.ls(path.join(projectPath, 'libs', 
'cordova-*.jar')).forEach(function (oldJar) {
+shell.ls(path.join(app_path, 'libs', 
'cordova-*.jar')).forEach(function (oldJar) {
 console.log('Deleting ' + oldJar);
 shell.rm('-f', oldJar);
 });
@@ -136,16 +143,24 @@ function writeProjectProperties (projectPath, target_api) 
{
 fs.writeFileSync(dstPath, data);
 }
 
-function prepBuildFiles (projectPath) {
+// This makes no sense, what if you're building with a different build system?
+function prepBuildFiles (projectPath, builder) {
 var buildModule = require(path.resolve(projectPath, 
'cordova/lib/builders/builders'));
-buildModule.getBuilder('gradle').prepBuildFiles();
+buildModule.getBuilder(builder).prepBuildFiles();
 }
 
-function copyBuildRules (projectPath) {
+function copyBuildRules (projectPath, isLegacy) {
 var srcDir = path.join(ROOT, 'bin', 'templates', 'project');
 
-shell.cp('-f', path.join(srcDir, 'build.gradle'), projectPath);
-shell.cp('-f', path.join(srcDir, 'wrapper.gradle'), projectPath);
+if (isLegacy) {
+// The project's build.gradle is identical to the earlier 
build.gradle, so it should still work
+shell.cp('-f', path.join(srcDir, 'legacy', 'build.gradle'), 
projectPath);
+shell.cp('-f', path.join(srcDir, 'wrapper.gradle'), projectPath);
+} else {
+shell.cp('-f', path.join(srcDir, 'build.gradle'), projectPath);
+shell.cp('-f', path.join(srcDir, 'app', 'build.gradle'), 
path.join(projectPath, 'app'));
+shell.cp('-f', path.join(srcDir, 'wrapper.gradle'), projectPath);
+}
 }
 
 function copyScripts (projectPath) {
@@ -271,25 +286,37 @@ exports.create = function (project_path, config, options, 
events) {
 
 exports.setShellFatal(true, function () {
 var project_template_dir = options.customTemplate || 
path.join(ROOT, 'bin', 'templates', 'project');
+var app_path = path.join(project_path, 'app', 'src', 'main');
+
 // copy project template
-shell.cp('-r', path.join(project_template_dir, 'assets'), 
project_path);
-shell.cp('-r', path.join(project_template_dir, 'res'), 
project_path);
+shell.mkdir('-p', app_path);
+shell.cp('-r', path.join(project_template_dir, 'assets'), 
app_path);
+shell.cp('-r', path.join(project_template_dir, 'res'), 
app_path);
 shell.cp(path.join(project_template_dir, 'gitignore'), 
path.join(project_path,

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-11-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269737#comment-16269737
 ] 

ASF GitHub Bot commented on CB-11244:
-

infil00p commented on issue #389: CB-11244: Studio Project Compatibility: Now 
with merge commit
URL: https://github.com/apache/cordova-android/pull/389#issuecomment-347703326
 
 
   1. The package.json's version is meaningless since this is a PR and not 
released code.  It should read 6.5.0-dev
   2. The APKs are where they appear by default in an Android project.  Given 
that this is a normal Gradle project, you can just edit the top-level Gradle as 
you would in a regular Android project:
   
https://stackoverflow.com/questions/23008485/change-gradle-build-directory-in-android-studio
   3. I think this would be the correct answer for the generated project's 
build path, but I'm not certain. 
https://stackoverflow.com/questions/23008485/change-gradle-build-directory-in-android-studio
   
   I think at this point, we should probably merge it so that these can get 
done on the repo before we go into a vote.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>Priority: Blocker
>  Labels: CordovaAndroidSix, android-next
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-11-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269710#comment-16269710
 ] 

ASF GitHub Bot commented on CB-11244:
-

janpio commented on issue #389: CB-11244: Studio Project Compatibility: Now 
with merge commit
URL: https://github.com/apache/cordova-android/pull/389#issuecomment-347699944
 
 
   - When installed package.json is still ` "version": "6.5.0-dev",` - bug or 
feature? (Couldn't find the file in the PR)
   - Is it necessary to change the output paths for APKs? I imagine lots of 
automation is hardcoded on the old paths (Example from my own code: 
https://github.com/ionic-zone/fastlane-plugin-ionic/blob/master/lib/fastlane/plugin/ionic/actions/ionic_action.rb#L118)
   - `.gitignore` for `/build` does not work for the new build output paths 
(and should probably get more/better paths for other stuff as well, but I am 
not sure on the "standard" here)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>Priority: Blocker
>  Labels: CordovaAndroidSix, android-next
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-11-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269708#comment-16269708
 ] 

ASF GitHub Bot commented on CB-11244:
-

janpio commented on issue #389: CB-11244: Studio Project Compatibility: Now 
with merge commit
URL: https://github.com/apache/cordova-android/pull/389#issuecomment-347699944
 
 
   - When installed package.json is still ` "version": "6.5.0-dev",` - bug or 
feature?
   - Is it necessary to change the output paths for APKs? I imagine lots of 
automation is hardcoded on the old paths (Example from my own code: 
https://github.com/ionic-zone/fastlane-plugin-ionic/blob/master/lib/fastlane/plugin/ionic/actions/ionic_action.rb#L118)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>Priority: Blocker
>  Labels: CordovaAndroidSix, android-next
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-11-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269690#comment-16269690
 ] 

ASF GitHub Bot commented on CB-11244:
-

codecov-io commented on issue #389: CB-11244: Studio Project Compatibility: Now 
with merge commit
URL: https://github.com/apache/cordova-android/pull/389#issuecomment-316205218
 
 
   # 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=h1) 
Report
   > Merging 
[#389](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-android/commit/3ad1ed7dbc3e6b864c2e3a5921e2be372469cf85?src=pr=desc)
 will **decrease** coverage by `0.35%`.
   > The diff coverage is `37.62%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-android/pull/389/graphs/tree.svg?token=q14nMf6C5a=650=150=pr)](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #389  +/-   ##
   ==
   - Coverage   43.77%   43.42%   -0.36% 
   ==
 Files  17   17  
 Lines1688 1734  +46 
 Branches  306  320  +14 
   ==
   + Hits  739  753  +14 
   - Misses949  981  +32
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[bin/templates/cordova/lib/builders/builders.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9idWlsZGVycy5qcw==)
 | `37.5% <ø> (ø)` | :arrow_up: |
   | 
[...n/templates/cordova/lib/builders/GenericBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HZW5lcmljQnVpbGRlci5qcw==)
 | `25.86% <ø> (-1.64%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=)
 | `22.44% <0%> (ø)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==)
 | `13.04% <0%> (-0.39%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==)
 | `48.44% <0%> (-0.58%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/AndroidStudio.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkU3R1ZGlvLmpz)
 | `94.73% <100%> (ø)` | :arrow_up: |
   | 
[...in/templates/cordova/lib/builders/GradleBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HcmFkbGVCdWlsZGVyLmpz)
 | `20.25% <15.78%> (-0.47%)` | :arrow_down: |
   | 
[bin/templates/cordova/Api.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL0FwaS5qcw==)
 | `41.88% <16.66%> (-2.57%)` | :arrow_down: |
   | 
[bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL2xpYi9jcmVhdGUuanM=)
 | `49.26% <45.45%> (-1.57%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/pluginHandlers.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wbHVnaW5IYW5kbGVycy5qcw==)
 | `86.47% <84.61%> (-0.41%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=footer).
 Last update 
[3ad1ed7...c6cfeb1](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project:

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-11-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269603#comment-16269603
 ] 

ASF GitHub Bot commented on CB-11244:
-

codecov-io commented on issue #389: CB-11244: Studio Project Compatibility: Now 
with merge commit
URL: https://github.com/apache/cordova-android/pull/389#issuecomment-316205218
 
 
   # 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=h1) 
Report
   > Merging 
[#389](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-android/commit/3ad1ed7dbc3e6b864c2e3a5921e2be372469cf85?src=pr=desc)
 will **decrease** coverage by `0.35%`.
   > The diff coverage is `37.62%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-android/pull/389/graphs/tree.svg?width=650=150=pr=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #389  +/-   ##
   ==
   - Coverage   43.77%   43.42%   -0.36% 
   ==
 Files  17   17  
 Lines1688 1734  +46 
 Branches  306  320  +14 
   ==
   + Hits  739  753  +14 
   - Misses949  981  +32
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...n/templates/cordova/lib/builders/GenericBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HZW5lcmljQnVpbGRlci5qcw==)
 | `25.86% <ø> (-1.64%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/builders/builders.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9idWlsZGVycy5qcw==)
 | `37.5% <ø> (ø)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==)
 | `13.04% <0%> (-0.39%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==)
 | `48.44% <0%> (-0.58%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=)
 | `22.44% <0%> (ø)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/AndroidStudio.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkU3R1ZGlvLmpz)
 | `94.73% <100%> (ø)` | :arrow_up: |
   | 
[...in/templates/cordova/lib/builders/GradleBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HcmFkbGVCdWlsZGVyLmpz)
 | `20.25% <15.78%> (-0.47%)` | :arrow_down: |
   | 
[bin/templates/cordova/Api.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL0FwaS5qcw==)
 | `41.88% <16.66%> (-2.57%)` | :arrow_down: |
   | 
[bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL2xpYi9jcmVhdGUuanM=)
 | `49.26% <45.45%> (-1.57%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/pluginHandlers.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wbHVnaW5IYW5kbGVycy5qcw==)
 | `86.47% <84.61%> (-0.41%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=footer).
 Last update 
[3ad1ed7...adc7dab](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project:

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-11-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269570#comment-16269570
 ] 

ASF GitHub Bot commented on CB-11244:
-

janpio commented on a change in pull request #389: CB-11244: Studio Project 
Compatibility: Now with merge commit
URL: https://github.com/apache/cordova-android/pull/389#discussion_r153638927
 
 

 ##
 File path: bin/templates/project/app/build.gradle
 ##
 @@ -0,0 +1,323 @@
+/*
+   Licensed to the Apache Software Foundation (ASF) under one
+   or more contributor license agreements.  See the NOTICE file
+   distributed with this work for additional information
+   regarding copyright ownership.  The ASF licenses this file
+   to you under the Apache License, Version 2.0 (the
+   "License"); you may not use this file except in compliance
+   with the License.  You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing,
+   software distributed under the License is distributed on an
+   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+   KIND, either express or implied.  See the License for the
+   specific language governing permissions and limitations
+   under the License.
+*/
+
+apply plugin: 'com.android.application'
+
+buildscript {
+repositories {
+mavenCentral()
+jcenter()
+maven {
+url "https://maven.google.com;
+}
+}
+
+dependencies {
+classpath 'com.android.tools.build:gradle:3.0.0'
+}
+}
+
+// Allow plugins to declare Maven dependencies via build-extras.gradle.
+allprojects {
+repositories {
+mavenCentral();
+jcenter()
+}
+}
+
+task wrapper(type: Wrapper) {
+gradleVersion = '4.1.0'
+}
+
+// Configuration properties. Set these via environment variables, 
build-extras.gradle, or gradle.properties.
+// Refer to: 
http://www.gradle.org/docs/current/userguide/tutorial_this_and_that.html
+ext {
+apply from: '../CordovaLib/cordova.gradle'
+// The value for android.compileSdkVersion.
+if (!project.hasProperty('cdvCompileSdkVersion')) {
+cdvCompileSdkVersion = null;
+}
+// The value for android.buildToolsVersion.
+if (!project.hasProperty('cdvBuildToolsVersion')) {
+cdvBuildToolsVersion = null;
+}
+// Sets the versionCode to the given value.
+if (!project.hasProperty('cdvVersionCode')) {
+cdvVersionCode = null
+}
+// Sets the minSdkVersion to the given value.
+if (!project.hasProperty('cdvMinSdkVersion')) {
+cdvMinSdkVersion = null
+}
+// Whether to build architecture-specific APKs.
+if (!project.hasProperty('cdvBuildMultipleApks')) {
+cdvBuildMultipleApks = null
+}
+// Whether to append a 0 "abi digit" to versionCode when only a single APK 
is build 
+if (!project.hasProperty('cdvVersionCodeForceAbiDigit')) {
+cdvVersionCodeForceAbiDigit = null
+}
+// .properties files to use for release signing.
+if (!project.hasProperty('cdvReleaseSigningPropertiesFile')) {
+cdvReleaseSigningPropertiesFile = null
+}
+// .properties files to use for debug signing.
+if (!project.hasProperty('cdvDebugSigningPropertiesFile')) {
+cdvDebugSigningPropertiesFile = null
+}
+// Set by build.js script.
+if (!project.hasProperty('cdvBuildArch')) {
+cdvBuildArch = null
+}
+
+// Plugin gradle extensions can append to this to have code run at the end.
+cdvPluginPostBuildExtras = []
+}
+
+// PLUGIN GRADLE EXTENSIONS START
+// PLUGIN GRADLE EXTENSIONS END
+
+def hasBuildExtras = file('build-extras.gradle').exists()
+if (hasBuildExtras) {
+apply from: 'build-extras.gradle'
+}
+
+// Set property defaults after extension .gradle files.
+if (ext.cdvCompileSdkVersion == null) {
+ext.cdvCompileSdkVersion = privateHelpers.getProjectTarget()
+//ext.cdvCompileSdkVersion = project.ext.defaultCompileSdkVersion
+}
+if (ext.cdvBuildToolsVersion == null) {
+ext.cdvBuildToolsVersion = privateHelpers.findLatestInstalledBuildTools()
+//ext.cdvBuildToolsVersion = project.ext.defaultBuildToolsVersion
+}
+if (ext.cdvDebugSigningPropertiesFile == null && 
file('debug-signing.properties').exists()) {
+ext.cdvDebugSigningPropertiesFile = 'debug-signing.properties'
+}
+if (ext.cdvReleaseSigningPropertiesFile == null && 
file('release-signing.properties').exists()) {
+ext.cdvReleaseSigningPropertiesFile = 'release-signing.properties'
+}
+
+// Cast to appropriate types.
+ext.cdvBuildMultipleApks = cdvBuildMultipleApks == null ? false : 
cdvBuildMultipleApks.toBoolean();
+ext.cdvVersionCodeForceAbiDigit = cdvVersionCodeForceAbiDigit == null ? false 
: cdvVersionCodeForceAbiDigit.toBoolean();
+ext.cdvMinSdkVersion = cdvMinSdkVersion == null ? null :

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-11-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269563#comment-16269563
 ] 

ASF GitHub Bot commented on CB-11244:
-

codecov-io commented on issue #389: CB-11244: Studio Project Compatibility: Now 
with merge commit
URL: https://github.com/apache/cordova-android/pull/389#issuecomment-316205218
 
 
   # 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=h1) 
Report
   > Merging 
[#389](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-android/commit/3ad1ed7dbc3e6b864c2e3a5921e2be372469cf85?src=pr=desc)
 will **decrease** coverage by `0.35%`.
   > The diff coverage is `37.62%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-android/pull/389/graphs/tree.svg?src=pr=q14nMf6C5a=150=650)](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #389  +/-   ##
   ==
   - Coverage   43.77%   43.42%   -0.36% 
   ==
 Files  17   17  
 Lines1688 1734  +46 
 Branches  306  320  +14 
   ==
   + Hits  739  753  +14 
   - Misses949  981  +32
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[bin/templates/cordova/lib/builders/builders.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9idWlsZGVycy5qcw==)
 | `37.5% <ø> (ø)` | :arrow_up: |
   | 
[...n/templates/cordova/lib/builders/GenericBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HZW5lcmljQnVpbGRlci5qcw==)
 | `25.86% <ø> (-1.64%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==)
 | `48.44% <0%> (-0.58%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=)
 | `22.44% <0%> (ø)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==)
 | `13.04% <0%> (-0.39%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/AndroidStudio.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkU3R1ZGlvLmpz)
 | `94.73% <100%> (ø)` | :arrow_up: |
   | 
[...in/templates/cordova/lib/builders/GradleBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HcmFkbGVCdWlsZGVyLmpz)
 | `20.25% <15.78%> (-0.47%)` | :arrow_down: |
   | 
[bin/templates/cordova/Api.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL0FwaS5qcw==)
 | `41.88% <16.66%> (-2.57%)` | :arrow_down: |
   | 
[bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL2xpYi9jcmVhdGUuanM=)
 | `49.26% <45.45%> (-1.57%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/pluginHandlers.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wbHVnaW5IYW5kbGVycy5qcw==)
 | `86.47% <84.61%> (-0.41%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=footer).
 Last update 
[3ad1ed7...adc7dab](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project:

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-11-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269317#comment-16269317
 ] 

ASF GitHub Bot commented on CB-11244:
-

codecov-io commented on issue #389: CB-11244: Studio Project Compatibility: Now 
with merge commit
URL: https://github.com/apache/cordova-android/pull/389#issuecomment-316205218
 
 
   # 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=h1) 
Report
   > Merging 
[#389](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-android/commit/3ad1ed7dbc3e6b864c2e3a5921e2be372469cf85?src=pr=desc)
 will **decrease** coverage by `0.36%`.
   > The diff coverage is `36.45%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-android/pull/389/graphs/tree.svg?width=650=150=pr=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #389  +/-   ##
   ==
   - Coverage   43.77%   43.41%   -0.37% 
   ==
 Files  17   17  
 Lines1688 1730  +42 
 Branches  306  317  +11 
   ==
   + Hits  739  751  +12 
   - Misses949  979  +30
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...n/templates/cordova/lib/builders/GenericBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HZW5lcmljQnVpbGRlci5qcw==)
 | `25.86% <ø> (-1.64%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/builders/builders.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9idWlsZGVycy5qcw==)
 | `37.5% <ø> (ø)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==)
 | `13.04% <0%> (-0.39%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==)
 | `48.44% <0%> (-0.58%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=)
 | `22.44% <0%> (ø)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/pluginHandlers.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wbHVnaW5IYW5kbGVycy5qcw==)
 | `87.34% <100%> (+0.47%)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/AndroidStudio.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkU3R1ZGlvLmpz)
 | `94.73% <100%> (ø)` | :arrow_up: |
   | 
[...in/templates/cordova/lib/builders/GradleBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HcmFkbGVCdWlsZGVyLmpz)
 | `20.25% <15.78%> (-0.47%)` | :arrow_down: |
   | 
[bin/templates/cordova/Api.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL0FwaS5qcw==)
 | `41.88% <16.66%> (-2.57%)` | :arrow_down: |
   | 
[bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL2xpYi9jcmVhdGUuanM=)
 | `49.26% <45.45%> (-1.57%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=footer).
 Last update 
[3ad1ed7...4863320](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project:

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-11-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267709#comment-16267709
 ] 

ASF GitHub Bot commented on CB-11244:
-

codecov-io commented on issue #389: CB-11244: Studio Project Compatibility: Now 
with merge commit
URL: https://github.com/apache/cordova-android/pull/389#issuecomment-316205218
 
 
   # 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=h1) 
Report
   > Merging 
[#389](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-android/commit/a972d1ef624c1c961686d177af4bbecd794319db?src=pr=desc)
 will **decrease** coverage by `0.36%`.
   > The diff coverage is `36.45%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-android/pull/389/graphs/tree.svg?src=pr=q14nMf6C5a=650=150)](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #389  +/-   ##
   ==
   - Coverage   43.77%   43.41%   -0.37% 
   ==
 Files  17   17  
 Lines1688 1730  +42 
 Branches  306  317  +11 
   ==
   + Hits  739  751  +12 
   - Misses949  979  +30
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...n/templates/cordova/lib/builders/GenericBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HZW5lcmljQnVpbGRlci5qcw==)
 | `25.86% <ø> (-1.64%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/builders/builders.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9idWlsZGVycy5qcw==)
 | `37.5% <ø> (ø)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=)
 | `22.44% <0%> (ø)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==)
 | `13.04% <0%> (-0.39%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==)
 | `48.44% <0%> (-0.58%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/AndroidStudio.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkU3R1ZGlvLmpz)
 | `94.73% <100%> (ø)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/pluginHandlers.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wbHVnaW5IYW5kbGVycy5qcw==)
 | `87.34% <100%> (+0.47%)` | :arrow_up: |
   | 
[...in/templates/cordova/lib/builders/GradleBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HcmFkbGVCdWlsZGVyLmpz)
 | `20.25% <15.78%> (-0.47%)` | :arrow_down: |
   | 
[bin/templates/cordova/Api.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL0FwaS5qcw==)
 | `41.88% <16.66%> (-2.57%)` | :arrow_down: |
   | 
[bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL2xpYi9jcmVhdGUuanM=)
 | `49.26% <45.45%> (-1.57%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=footer).
 Last update 
[a972d1e...2b20802](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project:

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-11-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267420#comment-16267420
 ] 

ASF GitHub Bot commented on CB-11244:
-

codecov-io commented on issue #389: CB-11244: Studio Project Compatibility: Now 
with merge commit
URL: https://github.com/apache/cordova-android/pull/389#issuecomment-316205218
 
 
   # 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=h1) 
Report
   > Merging 
[#389](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-android/commit/6f58d4c47456706f40e45f26ddff5706d87a6643?src=pr=desc)
 will **decrease** coverage by `0.36%`.
   > The diff coverage is `36.45%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-android/pull/389/graphs/tree.svg?src=pr=q14nMf6C5a=650=150)](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #389  +/-   ##
   ==
   - Coverage   43.77%   43.41%   -0.37% 
   ==
 Files  17   17  
 Lines1688 1730  +42 
 Branches  306  317  +11 
   ==
   + Hits  739  751  +12 
   - Misses949  979  +30
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[bin/templates/cordova/lib/builders/builders.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9idWlsZGVycy5qcw==)
 | `37.5% <ø> (ø)` | :arrow_up: |
   | 
[...n/templates/cordova/lib/builders/GenericBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HZW5lcmljQnVpbGRlci5qcw==)
 | `25.86% <ø> (-1.64%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==)
 | `13.04% <0%> (-0.39%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=)
 | `22.44% <0%> (ø)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==)
 | `48.44% <0%> (-0.58%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/pluginHandlers.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wbHVnaW5IYW5kbGVycy5qcw==)
 | `87.34% <100%> (+0.47%)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/AndroidStudio.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkU3R1ZGlvLmpz)
 | `94.73% <100%> (ø)` | :arrow_up: |
   | 
[...in/templates/cordova/lib/builders/GradleBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HcmFkbGVCdWlsZGVyLmpz)
 | `20.25% <15.78%> (-0.47%)` | :arrow_down: |
   | 
[bin/templates/cordova/Api.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL0FwaS5qcw==)
 | `41.88% <16.66%> (-2.57%)` | :arrow_down: |
   | 
[bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL2xpYi9jcmVhdGUuanM=)
 | `49.26% <45.45%> (-1.57%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=footer).
 Last update 
[6f58d4c...30c3713](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project:

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-11-22 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263396#comment-16263396
 ] 

ASF GitHub Bot commented on CB-11244:
-

codecov-io commented on issue #389: CB-11244: Studio Project Compatibility: Now 
with merge commit
URL: https://github.com/apache/cordova-android/pull/389#issuecomment-316205218
 
 
   # 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=h1) 
Report
   > Merging 
[#389](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-android/commit/64047801867946fb000ed1b52d9182da5d42abbc?src=pr=desc)
 will **decrease** coverage by `0.36%`.
   > The diff coverage is `36.45%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-android/pull/389/graphs/tree.svg?src=pr=q14nMf6C5a=650=150)](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #389  +/-   ##
   ==
   - Coverage   43.77%   43.41%   -0.37% 
   ==
 Files  17   17  
 Lines1688 1730  +42 
 Branches  306  317  +11 
   ==
   + Hits  739  751  +12 
   - Misses949  979  +30
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...n/templates/cordova/lib/builders/GenericBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HZW5lcmljQnVpbGRlci5qcw==)
 | `25.86% <ø> (-1.64%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/builders/builders.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9idWlsZGVycy5qcw==)
 | `37.5% <ø> (ø)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=)
 | `22.44% <0%> (ø)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==)
 | `13.04% <0%> (-0.39%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==)
 | `48.44% <0%> (-0.58%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/AndroidStudio.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkU3R1ZGlvLmpz)
 | `94.73% <100%> (ø)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/pluginHandlers.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wbHVnaW5IYW5kbGVycy5qcw==)
 | `87.34% <100%> (+0.47%)` | :arrow_up: |
   | 
[...in/templates/cordova/lib/builders/GradleBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HcmFkbGVCdWlsZGVyLmpz)
 | `20.25% <15.78%> (-0.47%)` | :arrow_down: |
   | 
[bin/templates/cordova/Api.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL0FwaS5qcw==)
 | `41.88% <16.66%> (-2.57%)` | :arrow_down: |
   | 
[bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL2xpYi9jcmVhdGUuanM=)
 | `49.26% <45.45%> (-1.57%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=footer).
 Last update 
[6404780...9d9bac3](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project:

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-11-22 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263290#comment-16263290
 ] 

ASF GitHub Bot commented on CB-11244:
-

codecov-io commented on issue #389: CB-11244: Studio Project Compatibility: Now 
with merge commit
URL: https://github.com/apache/cordova-android/pull/389#issuecomment-316205218
 
 
   # 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=h1) 
Report
   > Merging 
[#389](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-android/commit/64047801867946fb000ed1b52d9182da5d42abbc?src=pr=desc)
 will **decrease** coverage by `0.36%`.
   > The diff coverage is `36.45%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-android/pull/389/graphs/tree.svg?width=650=150=pr=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #389  +/-   ##
   ==
   - Coverage   43.77%   43.41%   -0.37% 
   ==
 Files  17   17  
 Lines1688 1730  +42 
 Branches  306  317  +11 
   ==
   + Hits  739  751  +12 
   - Misses949  979  +30
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...n/templates/cordova/lib/builders/GenericBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HZW5lcmljQnVpbGRlci5qcw==)
 | `25.86% <ø> (-1.64%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/builders/builders.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9idWlsZGVycy5qcw==)
 | `37.5% <ø> (ø)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==)
 | `13.04% <0%> (-0.39%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==)
 | `48.44% <0%> (-0.58%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=)
 | `22.44% <0%> (ø)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/AndroidStudio.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkU3R1ZGlvLmpz)
 | `94.73% <100%> (ø)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/pluginHandlers.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wbHVnaW5IYW5kbGVycy5qcw==)
 | `87.34% <100%> (+0.47%)` | :arrow_up: |
   | 
[...in/templates/cordova/lib/builders/GradleBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HcmFkbGVCdWlsZGVyLmpz)
 | `20.25% <15.78%> (-0.47%)` | :arrow_down: |
   | 
[bin/templates/cordova/Api.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL0FwaS5qcw==)
 | `41.88% <16.66%> (-2.57%)` | :arrow_down: |
   | 
[bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL2xpYi9jcmVhdGUuanM=)
 | `49.26% <45.45%> (-1.57%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=footer).
 Last update 
[6404780...d8f10c3](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project:

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-11-20 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260189#comment-16260189
 ] 

ASF GitHub Bot commented on CB-11244:
-

codecov-io commented on issue #389: CB-11244: Studio Project Compatibility: Now 
with merge commit
URL: https://github.com/apache/cordova-android/pull/389#issuecomment-316205218
 
 
   # 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=h1) 
Report
   > Merging 
[#389](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-android/commit/64047801867946fb000ed1b52d9182da5d42abbc?src=pr=desc)
 will **decrease** coverage by `0.29%`.
   > The diff coverage is `38.46%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-android/pull/389/graphs/tree.svg?width=650=150=q14nMf6C5a=pr)](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master #389 +/-   ##
   =
   - Coverage   43.77%   43.48%   -0.3% 
   =
 Files  17   17 
 Lines1688 1727 +39 
 Branches  306  316 +10 
   =
   + Hits  739  751 +12 
   - Misses949  976 +27
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...n/templates/cordova/lib/builders/GenericBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HZW5lcmljQnVpbGRlci5qcw==)
 | `25.86% <ø> (-1.64%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/builders/builders.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9idWlsZGVycy5qcw==)
 | `37.5% <ø> (ø)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=)
 | `22.44% <0%> (ø)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==)
 | `13.04% <0%> (-0.39%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/pluginHandlers.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wbHVnaW5IYW5kbGVycy5qcw==)
 | `87.34% <100%> (+0.47%)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/AndroidStudio.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkU3R1ZGlvLmpz)
 | `94.73% <100%> (ø)` | :arrow_up: |
   | 
[...in/templates/cordova/lib/builders/GradleBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HcmFkbGVCdWlsZGVyLmpz)
 | `20.25% <15.78%> (-0.47%)` | :arrow_down: |
   | 
[bin/templates/cordova/Api.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL0FwaS5qcw==)
 | `41.88% <16.66%> (-2.57%)` | :arrow_down: |
   | 
[bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL2xpYi9jcmVhdGUuanM=)
 | `49.26% <45.45%> (-1.57%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=footer).
 Last update 
[6404780...43956c1](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>Priority: Blocker
>  Labels:

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-11-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254075#comment-16254075
 ] 

ASF GitHub Bot commented on CB-11244:
-

codecov-io commented on issue #389: CB-11244: Studio Project Compatibility: Now 
with merge commit
URL: https://github.com/apache/cordova-android/pull/389#issuecomment-316205218
 
 
   # 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=h1) 
Report
   > Merging 
[#389](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-android/commit/83601dca2fa468a76bcb2c687b5baebfcb69588b?src=pr=desc)
 will **decrease** coverage by `0.3%`.
   > The diff coverage is `38.46%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-android/pull/389/graphs/tree.svg?src=pr=q14nMf6C5a=650=150)](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #389  +/-   ##
   ==
   - Coverage   44.01%   43.71%   -0.31% 
   ==
 Files  17   17  
 Lines1679 1718  +39 
 Branches  304  314  +10 
   ==
   + Hits  739  751  +12 
   - Misses940  967  +27
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...n/templates/cordova/lib/builders/GenericBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HZW5lcmljQnVpbGRlci5qcw==)
 | `30.61% <ø> (-0.38%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/builders/builders.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9idWlsZGVycy5qcw==)
 | `37.5% <ø> (ø)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=)
 | `22.44% <0%> (ø)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==)
 | `13.04% <0%> (-0.39%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/AndroidStudio.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkU3R1ZGlvLmpz)
 | `94.73% <100%> (ø)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/pluginHandlers.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wbHVnaW5IYW5kbGVycy5qcw==)
 | `87.34% <100%> (+0.47%)` | :arrow_up: |
   | 
[...in/templates/cordova/lib/builders/GradleBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HcmFkbGVCdWlsZGVyLmpz)
 | `20.25% <15.78%> (-0.47%)` | :arrow_down: |
   | 
[bin/templates/cordova/Api.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL0FwaS5qcw==)
 | `41.88% <16.66%> (-2.57%)` | :arrow_down: |
   | 
[bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL2xpYi9jcmVhdGUuanM=)
 | `49.26% <45.45%> (-1.57%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=footer).
 Last update 
[83601dc...3acba59](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>Priority: Blocker
>  Labels:

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-11-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242658#comment-16242658
 ] 

ASF GitHub Bot commented on CB-11244:
-

codecov-io commented on issue #389: CB-11244: Studio Project Compatibility: Now 
with merge commit
URL: https://github.com/apache/cordova-android/pull/389#issuecomment-316205218
 
 
   # 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=h1) 
Report
   > Merging 
[#389](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-android/commit/83601dca2fa468a76bcb2c687b5baebfcb69588b?src=pr=desc)
 will **decrease** coverage by `0.3%`.
   > The diff coverage is `38.46%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-android/pull/389/graphs/tree.svg?src=pr=q14nMf6C5a=650=150)](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #389  +/-   ##
   ==
   - Coverage   44.01%   43.71%   -0.31% 
   ==
 Files  17   17  
 Lines1679 1718  +39 
 Branches  304  314  +10 
   ==
   + Hits  739  751  +12 
   - Misses940  967  +27
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...n/templates/cordova/lib/builders/GenericBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HZW5lcmljQnVpbGRlci5qcw==)
 | `30.61% <ø> (-0.38%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/builders/builders.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9idWlsZGVycy5qcw==)
 | `37.5% <ø> (ø)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=)
 | `22.44% <0%> (ø)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==)
 | `13.04% <0%> (-0.39%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/AndroidStudio.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkU3R1ZGlvLmpz)
 | `94.73% <100%> (ø)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/pluginHandlers.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wbHVnaW5IYW5kbGVycy5qcw==)
 | `87.34% <100%> (+0.47%)` | :arrow_up: |
   | 
[...in/templates/cordova/lib/builders/GradleBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HcmFkbGVCdWlsZGVyLmpz)
 | `20.25% <15.78%> (-0.47%)` | :arrow_down: |
   | 
[bin/templates/cordova/Api.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL0FwaS5qcw==)
 | `41.88% <16.66%> (-2.57%)` | :arrow_down: |
   | 
[bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL2xpYi9jcmVhdGUuanM=)
 | `49.26% <45.45%> (-1.57%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=footer).
 Last update 
[83601dc...b77febc](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>Priority: Blocker
>  Labels:

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-11-01 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235022#comment-16235022
 ] 

ASF GitHub Bot commented on CB-11244:
-

codecov-io commented on issue #389: CB-11244: Studio Project Compatibility: Now 
with merge commit
URL: https://github.com/apache/cordova-android/pull/389#issuecomment-316205218
 
 
   # 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=h1) 
Report
   > Merging 
[#389](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-android/commit/39e6765e643085261dc3c19e7d252d3698686511?src=pr=desc)
 will **decrease** coverage by `0.3%`.
   > The diff coverage is `38.46%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-android/pull/389/graphs/tree.svg?width=650=150=pr=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #389  +/-   ##
   ==
   - Coverage   44.01%   43.71%   -0.31% 
   ==
 Files  17   17  
 Lines1679 1718  +39 
 Branches  304  314  +10 
   ==
   + Hits  739  751  +12 
   - Misses940  967  +27
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...n/templates/cordova/lib/builders/GenericBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HZW5lcmljQnVpbGRlci5qcw==)
 | `30.61% <ø> (-0.38%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/builders/builders.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9idWlsZGVycy5qcw==)
 | `37.5% <ø> (ø)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==)
 | `13.04% <0%> (-0.39%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=)
 | `22.44% <0%> (ø)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/pluginHandlers.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wbHVnaW5IYW5kbGVycy5qcw==)
 | `87.34% <100%> (+0.47%)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/AndroidStudio.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkU3R1ZGlvLmpz)
 | `94.73% <100%> (ø)` | :arrow_up: |
   | 
[...in/templates/cordova/lib/builders/GradleBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HcmFkbGVCdWlsZGVyLmpz)
 | `20.25% <15.78%> (-0.47%)` | :arrow_down: |
   | 
[bin/templates/cordova/Api.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL0FwaS5qcw==)
 | `41.88% <16.66%> (-2.57%)` | :arrow_down: |
   | 
[bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL2xpYi9jcmVhdGUuanM=)
 | `49.26% <45.45%> (-1.57%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=footer).
 Last update 
[39e6765...f54336e](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>Priority: Blocker
>  Labels:

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-10-30 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16225765#comment-16225765
 ] 

ASF GitHub Bot commented on CB-11244:
-

macdonst commented on issue #389: CB-11244: Studio Project Compatibility: Now 
with merge commit
URL: https://github.com/apache/cordova-android/pull/389#issuecomment-340590032
 
 
   @infil00p okay, got it. Once I do that step I get a bit farther but then I 
run into other problems. The plugin doesn't compile because it is missing all 
of the frameworks it depends on. For instance the push plugin includes:
   
   ```
   
   
   
   
   ```
   
   None of those things seem to get included in `build.gradle`. Previously I'd 
see:
   
   ```
   // PLUGIN GRADLE EXTENSIONS START
   apply from: "phonegap-plugin-push/app-push.gradle"
   // PLUGIN GRADLE EXTENSIONS END
   
   dependencies {
   compile fileTree(dir: 'libs', include: '*.jar')
   // SUB-PROJECT DEPENDENCIES START
   debugCompile(project(path: "CordovaLib", configuration: "debug"))
   releaseCompile(project(path: "CordovaLib", configuration: "release"))
   compile "com.android.support:support-v13:26.+"
   compile "me.leolin:ShortcutBadger:1.1.17@aar"
   compile "com.google.firebase:firebase-messaging:11.0.1"
   // SUB-PROJECT DEPENDENCIES END
   }
   ```
   
   But with this change I only see:
   
   ```
   dependencies {
   compile fileTree(dir: 'libs', include: '*.jar')
   // SUB-PROJECT DEPENDENCIES START
   debugCompile(project(path: ":CordovaLib", configuration: "debug"))
   releaseCompile(project(path: ":CordovaLib", configuration: "release"))
   // SUB-PROJECT DEPENDENCIES END
   }
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>Priority: Blocker
>  Labels: CordovaAndroidSix, android-next
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-10-30 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16225715#comment-16225715
 ] 

ASF GitHub Bot commented on CB-11244:
-

infil00p commented on issue #389: CB-11244: Studio Project Compatibility: Now 
with merge commit
URL: https://github.com/apache/cordova-android/pull/389#issuecomment-340582879
 
 
   @macdonst Read @stevegill's note about changing package.json when testing 
locally.  If you don't do this, you will definitely get this error. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>Priority: Blocker
>  Labels: CordovaAndroidSix, android-next
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-10-30 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224860#comment-16224860
 ] 

ASF GitHub Bot commented on CB-11244:
-

macdonst commented on issue #389: CB-11244: Studio Project Compatibility: Now 
with merge commit
URL: https://github.com/apache/cordova-android/pull/389#issuecomment-340433367
 
 
   @infil00p I've run the following commands:
   
   ```
   cordova create androidTest
   cd ./androidTest
   cordova platform add 
git://github.com/infil00p/cordova-android.git#StudioProjectCompat
   cordova plugin add phonegap-plugin-push@2.0.0
   ```
   
   which resulted in the following error:
   
   ```
   Installing "phonegap-plugin-push" for android
   Android Studio project detected
   Failed to install 'phonegap-plugin-push': Error: Unable to graft xml at 
selector "/manifest" from 
"/Users/smacdona/code/androidTest/platforms/android/app/src/main/res/xml/config.xml"
 during config install
   at ConfigFile_graft_child [as graft_child] 
(/Users/smacdona/code/androidTest/platforms/android/cordova/node_modules/cordova-common/src/ConfigChanges/ConfigFile.js:122:19)
   at PlatformMunger_apply_file_munge [as apply_file_munge] 
(/Users/smacdona/code/androidTest/platforms/android/cordova/node_modules/cordova-common/src/ConfigChanges/ConfigChanges.js:81:34)
   at munge_helper 
(/Users/smacdona/code/androidTest/platforms/android/cordova/node_modules/cordova-common/src/ConfigChanges/ConfigChanges.js:236:14)
   at PlatformMunger.add_plugin_changes 
(/Users/smacdona/code/androidTest/platforms/android/cordova/node_modules/cordova-common/src/ConfigChanges/ConfigChanges.js:157:12)
   at 
/Users/smacdona/code/androidTest/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:123:29
   at _fulfilled 
(/Users/smacdona/code/androidTest/platforms/android/cordova/node_modules/q/q.js:854:54)
   at self.promiseDispatch.done 
(/Users/smacdona/code/androidTest/platforms/android/cordova/node_modules/q/q.js:883:30)
   at Promise.promise.promiseDispatch 
(/Users/smacdona/code/androidTest/platforms/android/cordova/node_modules/q/q.js:816:13)
   at 
/Users/smacdona/code/androidTest/platforms/android/cordova/node_modules/q/q.js:877:14
   at runSingle 
(/Users/smacdona/code/androidTest/platforms/android/cordova/node_modules/q/q.js:137:13)
   Error: Unable to graft xml at selector "/manifest" from 
"/Users/smacdona/code/androidTest/platforms/android/app/src/main/res/xml/config.xml"
 during config install
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>Priority: Blocker
>  Labels: CordovaAndroidSix, android-next
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-10-17 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208599#comment-16208599
 ] 

ASF subversion and git services commented on CB-11244:
--

Commit cd46bd5ee889c8e870fd709458748b3b68ecc72e in cordova-common's branch 
refs/heads/master from [~auso]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-common.git;h=cd46bd5 ]

CB-11244 : added unit tests for ConfigFile

 This closes #8


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>Priority: Blocker
>  Labels: CordovaAndroidSix, android-next
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-10-17 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208559#comment-16208559
 ] 

ASF subversion and git services commented on CB-11244:
--

Commit 8b6430960e8aa6f1ef51e3ad218b11b773f89b1a in cordova-common's branch 
refs/heads/master from [~bowserj]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-common.git;h=8b64309 ]

CB-11244: Spot fix for cordova-android PR #389


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>Priority: Blocker
>  Labels: CordovaAndroidSix, android-next
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-10-17 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208560#comment-16208560
 ] 

ASF subversion and git services commented on CB-11244:
--

Commit 0e71312d55ddcae2eaf6ecb40b2c3ffb653b8fc6 in cordova-common's branch 
refs/heads/master from [~bowserj]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-common.git;h=0e71312 ]

CB-11244: eslint errors for spaces

 This closes #7


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>Priority: Blocker
>  Labels: CordovaAndroidSix, android-next
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103971#comment-16103971
 ] 

ASF GitHub Bot commented on CB-11244:
-

Github user filmaj commented on the issue:

https://github.com/apache/cordova-android/pull/389
  
Hey @infil00p, latest master has a tiny tweak to the appveyor build file 
that works around some troubles appveyor is experiencing with one of their VM 
images. I think if you rebase this, you'll find that'll clear up the appveyor 
failures.


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>  Labels: CordovaAndroidSix, android-next
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-07-18 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092230#comment-16092230
 ] 

ASF GitHub Bot commented on CB-11244:
-

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-android/pull/389
  
# 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=h1) 
Report
> Merging 
[#389](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-android/commit/893356abcd1b005a13bb09e7467f227b52de3ae5?src=pr=desc)
 will **decrease** coverage by `0.37%`.
> The diff coverage is `34.17%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-android/pull/389/graphs/tree.svg?height=150=650=q14nMf6C5a=pr)](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree)

```diff
@@Coverage Diff @@
##   master #389  +/-   ##
==
- Coverage   42.55%   42.17%   -0.38% 
==
  Files  17   17  
  Lines1678 1707  +29 
  Branches  304  310   +6 
==
+ Hits  714  720   +6 
- Misses964  987  +23
```


| [Impacted 
Files](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree) | 
Coverage Δ | |
|---|---|---|
| 
[...n/templates/cordova/lib/builders/GenericBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HZW5lcmljQnVpbGRlci5qcw==)
 | `30.61% <ø> (-0.38%)` | :arrow_down: |
| 
[bin/templates/cordova/lib/builders/builders.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9idWlsZGVycy5qcw==)
 | `37.5% <ø> (ø)` | :arrow_up: |
| 
[bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==)
 | `13.04% <0%> (-0.39%)` | :arrow_down: |
| 
[bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=)
 | `22.44% <0%> (ø)` | :arrow_up: |
| 
[bin/templates/cordova/lib/AndroidStudio.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkU3R1ZGlvLmpz)
 | `94.73% <100%> (ø)` | :arrow_up: |
| 
[...in/templates/cordova/lib/builders/GradleBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HcmFkbGVCdWlsZGVyLmpz)
 | `20% <15.78%> (-0.43%)` | :arrow_down: |
| 
[bin/templates/cordova/Api.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL0FwaS5qcw==)
 | `43.36% <25%> (-1.09%)` | :arrow_down: |
| 
[bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL2xpYi9jcmVhdGUuanM=)
 | `49.26% <45.45%> (-1.57%)` | :arrow_down: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=footer).
 Last update 
[893356a...d0dab4b](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>  Labels: CordovaAndroidSix, android-next
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-07-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084350#comment-16084350
 ] 

ASF GitHub Bot commented on CB-11244:
-

Github user filmaj commented on the issue:

https://github.com/apache/cordova-android/pull/389
  
Yes, seriously, because the code interpolates activity name / package name 
/ etc. into hard-coded paths!


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>  Labels: CordovaAndroidSix
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-07-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084303#comment-16084303
 ] 

ASF GitHub Bot commented on CB-11244:
-

Github user infil00p commented on the issue:

https://github.com/apache/cordova-android/pull/389
  
@filmaj Hard copied paths? SRSLY? 


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>  Labels: CordovaAndroidSix
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-07-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16082945#comment-16082945
 ] 

ASF GitHub Bot commented on CB-11244:
-

Github user infil00p commented on the issue:

https://github.com/apache/cordova-android/pull/389
  
The merge commit that I did was e456175a


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>  Labels: CordovaAndroidSix
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-07-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16082921#comment-16082921
 ] 

ASF GitHub Bot commented on CB-11244:
-

Github user infil00p commented on the issue:

https://github.com/apache/cordova-android/pull/389
  
@filmaj Github says otherwise.


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>  Labels: CordovaAndroidSix
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-07-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16082962#comment-16082962
 ] 

ASF GitHub Bot commented on CB-11244:
-

Github user infil00p commented on the issue:

https://github.com/apache/cordova-android/pull/389
  
@filmaj Given how old this branch is, those are the same tests that master 
was running until three commits ago.


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>  Labels: CordovaAndroidSix
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-07-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16082956#comment-16082956
 ] 

ASF GitHub Bot commented on CB-11244:
-

Github user filmaj commented on the issue:

https://github.com/apache/cordova-android/pull/389
  
Maybe? I don't know. Just beware that you have very few tests running in 
this PR (basically just the JS unit tests, no JS e2e nor Java native unit 
tests) so the green checkmark next to your PR is a bit of a false positive.


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>  Labels: CordovaAndroidSix
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-07-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16082950#comment-16082950
 ] 

ASF GitHub Bot commented on CB-11244:
-

Github user filmaj commented on the issue:

https://github.com/apache/cordova-android/pull/389
  
Right and that is now 3 commits behind master's `HEAD` :P

Just saying latest master stuff will get you better testing / feedback via 
CI in this PR!


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>  Labels: CordovaAndroidSix
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-07-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16082952#comment-16082952
 ] 

ASF GitHub Bot commented on CB-11244:
-

Github user infil00p commented on the issue:

https://github.com/apache/cordova-android/pull/389
  
@filmaj So, I should do another merge commit just to get more tests?


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>  Labels: CordovaAndroidSix
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-07-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16082930#comment-16082930
 ] 

ASF GitHub Bot commented on CB-11244:
-

Github user filmaj commented on the issue:

https://github.com/apache/cordova-android/pull/389
  
Just based on the last travis/appveyor run in the commits in this PR, the 
unit tests, end to end tests and the native unit tests are not running.

I don't see master HEAD in the commit list for this branch, either:

```
* a7304b9a - (HEAD -> StudioProjectCompat, infil00p/StudioProjectCompat) 
Finishing the linting (2 weeks ago) 
*   e456175a - Merge branch 'master' into StudioProjectCompat (2 weeks ago) 

|\
| * 55d7cf38 - CB-12895 : updated .eslintrc file in spec dir and set 
jasmine true and removed root is true (3 weeks ago) 
| * ac4ac935 - CB-12895 : added .eslintrc files to set up jasmine 
environment (3 weeks ago) 
| * d83d49d8 - CB-12895 : fixed eslint errors (3 weeks ago) 
| * e36158a0 - CB-12895 : added eslint and removed jshint (3 weeks ago) 

| * 5cc14b80 - CB-12605 In Windows get Android studio path from the 
registry (3 weeks ago) 
* | b20028c4 - (infil00p/StudioProjectCleanup, StudioProjectCleanup) The 
prepare step was broken, which breaks the CLI workflow.  This was caused by 
hardcoding the Java directory, which is a very bad idea. (3 weeks ago) 
* | 1cda7a9d - CB-11244: Found bug in Api.js where xml/strings.xml is used 
instead of values/strings.xml (3 weeks ago) 
* | 49b76f5c - Fixing mangled commits that crept into this branch (4 weeks 
ago) 
* | c0474e81 - Bump for travis test (4 weeks ago) 
* | 40c97094 - OK, Going back to the old build.gradle for legacy projects 
(4 weeks ago) 
* | b67e9905 - This is probably a bad idea, but we need to split the gradle 
files into legacy and new style (4 weeks ago) 
* | c74192d5 - Adding conditional code into Gradle, this is a bit dirty 
since we can't explicitly test it but we'll just have to rely on jasmine (4 
weeks ago) 
* | 33feb00e - Adding the if statement to see if we can support both 
structures with minimal editing, TODO: actually write tests for this somehow (4 
weeks ago) 
* | 8f16df4c - Adding logic to upgrade both Classic and Android Studio 
style project structures (4 weeks ago) 
* | fb6cb51e - Fixing lint errors (4 weeks ago) 
* | 28ebbb8f - CB-11244: Setup Api.js to support multiple builders based on 
project structure (4 weeks ago) 
* | bd4ddcde - Updated AndroidStudio to only look for the app directory to 
determine studio status (4 weeks ago) 
* | e621edfb - Fixing the Android Studio detection and making it 
automatically pick the right builder, good for upgrading Cordova (4 weeks ago) 

* | 304a8991 - Fixed the specification of the builders in the run command 
by getting build to check what was being passed from run (4 weeks ago) 
* | 8391af2e - JsHint Fixes, deleting unused methods (4 weeks ago) 
* | 69ab6a0e - Changing the project to add the app directory as a 
dependency (4 weeks ago) 
* | a216f0db - CB-11244: Changing directory creation, will most likely hide 
this behind a flag for the next release of Cordova-Android, and then make it 
default in the next major pending feedback (4 weeks ago) 
* | 69260fb9 - Fix the overwriting of Fil's fix, blargh (4 weeks ago) 
* | db87e0ae - Made changes so cordova/build builds with the new project.  
Need to work on plugin installation. (4 weeks ago) 
* | 8ead919f - Managed to get the project to mostly compile, still need to 
re-work the build command to add the app project (4 weeks ago) 
* | b73c04f3 - Updating gradle version in the build file (4 weeks ago) 
* | f790aeb8 - Setting up the create command so we actually have all the 
directories in the right place, and define default variables in the top level 
build.gradle (4 weeks ago) 
* | 7b17abc5 - Fixing linting issues (4 weeks ago) 
* | ffadf5dd - Changing this so we pass lint (4 weeks ago) 
* | 23d8d999 - Moving Android Manifest finding to the Gradle and Studio 
builders. (4 weeks ago) 
* | d88df59c - Adding the Studio Builder to build a project based on 
Android Studio, and deleting Ant, since Google does not support Ant Builds 
anymore. Sorry guys! (4 weeks ago) 
|/
* 3a6e898b - CB-12762 : pointed package.json repo items to github mirrors 
instead of apache repos site (5 weeks ago) 
```


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-07-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081310#comment-16081310
 ] 

ASF GitHub Bot commented on CB-11244:
-

Github user filmaj commented on the issue:

https://github.com/apache/cordova-android/pull/389
  
Heh, with me merging in #391, you might need to rebase  

At least you'll get wider test feedback on Windows with it.


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>  Labels: CordovaAndroidSix
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-06-26 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063475#comment-16063475
 ] 

ASF GitHub Bot commented on CB-11244:
-

Github user infil00p commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/384#discussion_r124071629
  
--- Diff: bin/lib/create.js ---
@@ -259,41 +273,53 @@ exports.create = function(project_path, config, 
options, events) {
 
 setShellFatal(true, function() {
 var project_template_dir = options.customTemplate || 
path.join(ROOT, 'bin', 'templates', 'project');
+var app_path = path.join(project_path, 'app', 'src', 'main');
--- End diff --

The plan is to support managing the old and existing structures while only 
being able to create new structures for the time being.  Of course, there's a 
debate on how update works, and we may just toss the structure altogether.  Who 
knows?


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>  Labels: CordovaAndroidSix
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-06-26 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063472#comment-16063472
 ] 

ASF GitHub Bot commented on CB-11244:
-

Github user infil00p closed the pull request at:

https://github.com/apache/cordova-android/pull/384


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>  Labels: CordovaAndroidSix
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-06-26 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063471#comment-16063471
 ] 

ASF GitHub Bot commented on CB-11244:
-

Github user infil00p commented on the issue:

https://github.com/apache/cordova-android/pull/384
  
We're going to keep working on #389, closing this old branch.


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>  Labels: CordovaAndroidSix
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-06-26 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063469#comment-16063469
 ] 

ASF GitHub Bot commented on CB-11244:
-

GitHub user infil00p opened a pull request:

https://github.com/apache/cordova-android/pull/389

CB-11244: Studio Project Compatibility: Now with merge commit



### Platforms affected
Android

### What does this PR do?
This PR is the new current working PR for the Studio Project work

### What testing has been done on this change?
Tested against the CI tests, more tests need to be added.

### Checklist
- [x ] [Reported an 
issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/infil00p/cordova-android StudioProjectCompat

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/389.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #389


commit d88df59c32ae7d1a55729477f5a22d9e7b4df111
Author: Joe Bowser 
Date:   2017-03-30T19:41:44Z

Adding the Studio Builder to build a project based on Android Studio,
and deleting Ant, since Google does not support Ant Builds anymore.
Sorry guys!

commit 23d8d999257f9cf1331d81489c96f00fa134b3b5
Author: Joe Bowser 
Date:   2017-03-30T20:38:18Z

Moving Android Manifest finding to the Gradle and Studio builders.

commit ffadf5dd51767c2f2697ad9e1ba34cf44d652145
Author: Joe Bowser 
Date:   2017-04-03T22:21:48Z

Changing this so we pass lint

commit 7b17abc5553ca14f69081a2175f787d4a0550f0f
Author: Joe Bowser 
Date:   2017-04-04T20:38:40Z

Fixing linting issues

commit f790aeb8f677eb047ce6e82fceaeb814cfc9d4fc
Author: Joe Bowser 
Date:   2017-04-04T22:18:46Z

Setting up the create command so we actually have all the directories in 
the right place, and define default variables in the top level build.gradle

commit b73c04f3c8424e6db57c3bb98c550cd4d976f473
Author: Joe Bowser 
Date:   2017-04-04T22:34:42Z

Updating gradle version in the build file

commit 8ead919faea814e86e8f665e9122a35bcd82d869
Author: Joe Bowser 
Date:   2017-04-04T22:42:58Z

Managed to get the project to mostly compile, still need to re-work the 
build command to add the app project

commit db87e0ae6a25d8a337d10b41cb46574e2cb987b0
Author: Joe Bowser 
Date:   2017-04-11T20:47:40Z

Made changes so cordova/build builds with the new project.  Need to work on 
plugin installation.

commit a216f0db751778953224067f25b8e0077bb7e760
Author: Joe Bowser 
Date:   2017-01-04T19:48:18Z

CB-11244: Changing directory creation, will most likely hide this behind a 
flag for the next release of Cordova-Android, and then make it default in the 
next major pending feedback

commit 69260fb96a8d606549caa8880abc5e7b444c4621
Author: Joe Bowser 
Date:   2017-04-11T21:41:27Z

Fix the overwriting of Fil's fix, blargh

commit 69ab6a0e0d70e56c6fe0fe7529a211c51df09ab7
Author: Joe Bowser 
Date:   2017-04-18T21:29:02Z

Changing the project to add the app directory as a dependency

commit 8391af2e8f6d9bdab102f28c58f257b8b53d0c0f
Author: Joe Bowser 
Date:   2017-04-18T21:48:56Z

JsHint Fixes, deleting unused methods

commit 304a8991140f3f1ed76a9816b1a4d701537f89ea
Author: Joe Bowser 
Date:   2017-04-19T18:50:55Z

Fixed the specification of the builders in the run command by getting build 
to check what was being passed from run

commit e621edfba755d31915da29a6113b0be2db56735f
Author: Joe Bowser 
Date:   2017-04-21T23:27:26Z

Fixing the Android Studio detection and making it automatically pick the 
right builder, good for upgrading Cordova

commit bd4ddcdeddf7a5b232023c4f53b60d2ab20e7a48
Author: Joe Bowser 
Date:   2017-04-22T00:02:27Z

Updated AndroidStudio to only look for the app directory to determine 
studio status

commit 28ebbb8f024f31a627af6b26ba23e41e7ce22f65
Author: Joe Bowser 
Date:   2017-05-31T17:23:35Z

CB-11244: Setup Api.js to support multiple builders based on project 
structure

commit fb6cb51e64a2ea05ba65195023b702fb00b378c2
Author: Joe Bowser 
Date:   2017-05-31T17:37:47Z

Fixing lint errors

commit

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-06-23 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061548#comment-16061548
 ] 

ASF GitHub Bot commented on CB-11244:
-

Github user imhotep commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/384#discussion_r123851340
  
--- Diff: bin/lib/create.js ---
@@ -259,41 +273,53 @@ exports.create = function(project_path, config, 
options, events) {
 
 setShellFatal(true, function() {
 var project_template_dir = options.customTemplate || 
path.join(ROOT, 'bin', 'templates', 'project');
+var app_path = path.join(project_path, 'app', 'src', 'main');
--- End diff --

Is this default? do you plan on having a way to create old project 
structure still? or is the plan to just support managing the old 
structures while only being able to create the new (Android Studio) structure?


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>  Labels: CordovaAndroidSix
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-06-23 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061536#comment-16061536
 ] 

ASF GitHub Bot commented on CB-11244:
-

Github user imhotep commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/384#discussion_r123850564
  
--- Diff: bin/templates/cordova/Api.js ---
@@ -343,6 +349,8 @@ Api.prototype.removePlugin = function (plugin, 
uninstallOptions) {
  */
 Api.prototype.build = function (buildOptions) {
 var self = this;
+if(this.android_studio)
+  buildOptions.studio = true;
--- End diff --

I think it makes to have abstracted somewhere else as well


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>  Labels: CordovaAndroidSix
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-06-23 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061534#comment-16061534
 ] 

ASF GitHub Bot commented on CB-11244:
-

Github user imhotep commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/384#discussion_r123850098
  
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -148,6 +152,7 @@ module.exports.runClean = function(options) {
  */
 module.exports.run = function(options, optResolvedTarget) {
 var opts = parseOpts(options, optResolvedTarget, this.root);
+console.log(opts.buildMethod);
--- End diff --

another one :)


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>  Labels: CordovaAndroidSix
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-06-23 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061530#comment-16061530
 ] 

ASF GitHub Bot commented on CB-11244:
-

Github user imhotep commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/384#discussion_r123849628
  
--- Diff: bin/templates/cordova/lib/builders/GenericBuilder.js ---
@@ -53,43 +48,13 @@ GenericBuilder.prototype.findOutputApks = 
function(build_type, arch) {
 var self = this;
 return Object.keys(this.binDirs)
 .reduce(function (result, builderName) {
+console.log('builderName:'+ builderName);
--- End diff --

don't forget this in there ;-)


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>  Labels: CordovaAndroidSix
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-06-23 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061499#comment-16061499
 ] 

ASF GitHub Bot commented on CB-11244:
-

Github user infil00p commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/384#discussion_r123844605
  
--- Diff: bin/lib/create.js ---
@@ -125,16 +131,24 @@ function writeProjectProperties(projectPath, 
target_api) {
 fs.writeFileSync(dstPath, data);
 }
 
-function prepBuildFiles(projectPath) {
+// This makes no sense, what if you're building with a different build 
system?
--- End diff --

We're already doing that in the next two lines? 


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>  Labels: CordovaAndroidSix
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-06-23 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061458#comment-16061458
 ] 

ASF GitHub Bot commented on CB-11244:
-

Github user filmaj commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/384#discussion_r123835148
  
--- Diff: bin/templates/cordova/Api.js ---
@@ -81,10 +83,13 @@ function Api(platform, platformRootDir, events) {
 // XXX Override some locations for Android Studio projects
 if(AndroidStudio.isAndroidStudioProject(self.root) === true) {
   selfEvents.emit('log', 'Android Studio project detected');
+  this.builder='studio';
   this.android_studio = true;
   this.locations.configXml = path.join(self.root, 
'app/src/main/res/xml/config.xml');
-  this.locations.strings = path.join(self.root, 
'app/src/main/res/xml/strings.xml');
+  this.locations.strings = path.join(self.root, 
'app/src/main/res/values/strings.xml');
   this.locations.manifest = path.join(self.root, 
'app/src/main/AndroidManifest.xml');
+  //We could have Java Source, we could have other languages
+  this.locations.javaSrc = path.join(self.root, 'app/src/main/java/');
--- End diff --

Same sort of deal, we could push the responsibility for figuring out the 
locations to the builders, rather than have the Api function worry about each 
possible implementation of a project structure.


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>  Labels: CordovaAndroidSix
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-06-23 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061443#comment-16061443
 ] 

ASF GitHub Bot commented on CB-11244:
-

Github user filmaj commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/384#discussion_r123834608
  
--- Diff: bin/lib/create.js ---
@@ -314,7 +340,18 @@ exports.update = function(projectPath, options, 
events) {
 return Q()
 .then(function() {
 
-var manifest = new AndroidManifest(path.join(projectPath, 
'AndroidManifest.xml'));
+var isAndroidStudio = 
AndroidStudio.isAndroidStudioProject(projectPath);
+var isLegacy = !isAndroidStudio;
+var manifest = null;
+var builder = 'gradle';
+
+if(isAndroidStudio) {
+  manifest = new AndroidManifest(path.join(projectPath, 'app', 
'main', 'AndroidManifest.xml'));
+  builder = 'studio';
+} else {
+  manifest = new AndroidManifest(path.join(projectPath, 
'AndroidManifest.xml'));
+  builder = 'gradle';
+}
--- End diff --

Same thing here, this may be better folded up into the Builders?


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>  Labels: CordovaAndroidSix
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-06-23 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061441#comment-16061441
 ] 

ASF GitHub Bot commented on CB-11244:
-

Github user filmaj commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/384#discussion_r123834356
  
--- Diff: bin/lib/create.js ---
@@ -125,16 +131,24 @@ function writeProjectProperties(projectPath, 
target_api) {
 fs.writeFileSync(dstPath, data);
 }
 
-function prepBuildFiles(projectPath) {
+// This makes no sense, what if you're building with a different build 
system?
--- End diff --

Would folding this functionality up into the Builder abstraction make sense 
here? Would different project structures require different building different 
things at create time as well? Put otherwise: do the Builders have to do 
specific things at create-time as well?


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>  Labels: CordovaAndroidSix
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-06-14 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16049513#comment-16049513
 ] 

ASF GitHub Bot commented on CB-11244:
-

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-android/pull/384
  
# 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/384?src=pr=h1) 
Report
> Merging 
[#384](https://codecov.io/gh/apache/cordova-android/pull/384?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-android/commit/3a6e898b12eac31dfc16a4c526dfba8fab158723?src=pr=desc)
 will **decrease** coverage by `0.29%`.
> The diff coverage is `20.58%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-android/pull/384/graphs/tree.svg?token=q14nMf6C5a=pr=650=150)](https://codecov.io/gh/apache/cordova-android/pull/384?src=pr=tree)

```diff
@@Coverage Diff@@
##   master #384 +/-   ##
=
- Coverage   39.52%   39.22%   -0.3% 
=
  Files  16   16 
  Lines1551 1555  +4 
  Branches  277  279  +2 
=
- Hits  613  610  -3 
- Misses938  945  +7
```


| [Impacted 
Files](https://codecov.io/gh/apache/cordova-android/pull/384?src=pr=tree) | 
Coverage Δ | |
|---|---|---|
| 
[bin/templates/cordova/lib/builders/builders.js](https://codecov.io/gh/apache/cordova-android/pull/384?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9idWlsZGVycy5qcw==)
 | `33.33% <ø> (ø)` | :arrow_up: |
| 
[...n/templates/cordova/lib/builders/GenericBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/384?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HZW5lcmljQnVpbGRlci5qcw==)
 | `28.84% <0%> (-1.3%)` | :arrow_down: |
| 
[bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/384?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==)
 | `10.13% <0%> (-0.21%)` | :arrow_down: |
| 
[bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/384?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=)
 | `18.18% <0%> (ø)` | :arrow_up: |
| 
[bin/templates/cordova/lib/AndroidStudio.js](https://codecov.io/gh/apache/cordova-android/pull/384?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkU3R1ZGlvLmpz)
 | `94.73% <100%> (ø)` | :arrow_up: |
| 
[...in/templates/cordova/lib/builders/GradleBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/384?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HcmFkbGVCdWlsZGVyLmpz)
 | `19.62% <15.78%> (-0.38%)` | :arrow_down: |
| 
[bin/templates/cordova/Api.js](https://codecov.io/gh/apache/cordova-android/pull/384?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL0FwaS5qcw==)
 | `42.37% <33.33%> (-0.61%)` | :arrow_down: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-android/pull/384?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/384?src=pr=footer).
 Last update 
[3a6e898...49b76f5](https://codecov.io/gh/apache/cordova-android/pull/384?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>  Labels: CordovaAndroidSix
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-06-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045130#comment-16045130
 ] 

ASF GitHub Bot commented on CB-11244:
-

GitHub user infil00p opened a pull request:

https://github.com/apache/cordova-android/pull/384

CB-11244: Studio project cleanup



### Platforms affected
Android

### What does this PR do?
Modernizes Android and makes it so we can do Modern Android Development

### What testing has been done on this change?
* Manual Testing with Plugman
* Dev against e2e tests (upgrade still fails, help plz)
* Talked to Fil regarding JUnit Test running 

### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/infil00p/cordova-android StudioProjectCleanup

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/384.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #384


commit 6167130bac0630f8a8359ed491381caa7da45871
Author: Joe Bowser 
Date:   2017-03-30T19:41:44Z

Adding the Studio Builder to build a project based on Android Studio,
and deleting Ant, since Google does not support Ant Builds anymore.
Sorry guys!

commit 2ef15bd2172f265c44b8447a8e2f119d1590fda3
Author: Joe Bowser 
Date:   2017-03-30T20:38:18Z

Moving Android Manifest finding to the Gradle and Studio builders.

commit 09a4ed45ec2c959a5424c85d1e3df04f344eb664
Author: Joe Bowser 
Date:   2017-04-03T22:21:48Z

Changing this so we pass lint

commit 5a40dcd86ed8bd21ca611a66ee13170bed099739
Author: Joe Bowser 
Date:   2017-04-04T20:38:40Z

Fixing linting issues

commit 3795b65bced7c8634cade5f00bfe2d42349250c9
Author: Joe Bowser 
Date:   2017-04-04T22:18:46Z

Setting up the create command so we actually have all the directories in 
the right place, and define default variables in the top level build.gradle

commit f2396de53e250cd0ad9b8bb2020ce11eaef16ffe
Author: Joe Bowser 
Date:   2017-04-04T22:34:42Z

Updating gradle version in the build file

commit 02c07de746b39a587613b531e3fbdcb833d442e9
Author: Joe Bowser 
Date:   2017-04-04T22:42:58Z

Managed to get the project to mostly compile, still need to re-work the 
build command to add the app project

commit c8f328fe2a9b6d05ad543b32989182bb612e9d0a
Author: Joe Bowser 
Date:   2017-04-11T20:47:40Z

Made changes so cordova/build builds with the new project.  Need to work on 
plugin installation.

commit 7db18f8b361369d10237f5159154dbae3f0c3f4d
Author: Joe Bowser 
Date:   2017-04-11T21:41:27Z

Fix the overwriting of Fil's fix, blargh

commit cc2d1fd9ae59e5aca10ff5271ef637b6b6897eee
Author: Joe Bowser 
Date:   2017-01-04T19:48:18Z

CB-11244: Changing directory creation, will most likely hide this behind a 
flag for the next release of Cordova-Android, and then make it default in the 
next major pending feedback

commit 844dc7f3df7f830cf562535ef9f5f5fc15471ca1
Author: Joe Bowser 
Date:   2017-04-18T21:29:02Z

Changing the project to add the app directory as a dependency

commit 2df146df4f918067eb325ca1d50639045f5003ed
Author: Joe Bowser 
Date:   2017-04-18T21:48:56Z

JsHint Fixes, deleting unused methods

commit c1ea8ec88576586a7385dd06d5d62897f9142b4e
Author: Joe Bowser 
Date:   2017-04-19T18:50:55Z

Fixed the specification of the builders in the run command by getting build 
to check what was being passed from run

commit 17416dfd1df16da9b4c0715ec6280961c7b9d91b
Author: Joe Bowser 
Date:   2017-04-21T23:27:26Z

Fixing the Android Studio detection and making it automatically pick the 
right builder, good for upgrading Cordova

commit e30968e15a8aadbc6cc20d4b483f27f1c580ac15
Author: Joe Bowser 
Date:   2017-04-22T00:02:27Z

Updated AndroidStudio to only look for the app directory to determine 
studio status

commit a17a5b891f98417d149bacbf8307412fa8c03a34
Author: Joe Bowser 
Date:   2017-05-31T17:23:35Z

CB-11244: Setup Api.js to support multiple builders based on project 
structure

commit a5ca7089eaa2e8825dca9f7c2140c2f62b5d618c
Author: Joe Bowser 
Date:

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2016-10-14 Thread Joe Bowser (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15576684#comment-15576684
 ] 

Joe Bowser commented on CB-11244:
-

[~stickbyatlas] That's probably never going to entirely go away, and it's a 
consequence of us not releasing as fast as Google releases Android Studio.  We 
did sync our versions and remove that error for 2.1, but it came back for 2.2 
and the next major version will have that fix.  We try to keep up, but our 
ability to release as fast as possible is hindered by factors beyond my control 
alone.

> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>  Labels: CordovaAndroidSix
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2016-05-18 Thread Ari Najarian (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290081#comment-15290081
 ] 

Ari Najarian commented on CB-11244:
---

I'm currently working on an initiative that will encourage novice coders to 
build mobile apps using Cordova, and I'm trying to minimize the amount of 
friction it will take to get their workflow going. At some point, they're going 
to have to clone a project template, build it and then run it. I'm hoping to 
have them simply type `cordova prepare android` to initialize a project, then 
import it into Android Studio to run in an emulator, etc.

Right now, when I try to follow this workflow, I get a jarring notification 
from Android Studio on import: 'The project is using an old version of the 
Android Gradle plugin.' It tells me to upgrade to 2.1.0 to take adantage of 
Instant Run, etc. When I click the 'Update' button, it updates 
`platforms/android/cordovalib/build.gradle' to 2.1.0, then drops me into the 
project with the same error reported twice (for 
`android/cordovalib/build.gradle` and `android/build.gradle` : "Gradle version 
2.10 is required. Current version is 2.2.1"... Clicking on the hyperlinked 'Fix 
Gradle wrapper and re-import project' causes a cryptic IDE error.

This is really messy, and I can't imagine a beginner not feeling overwhelmed 
and discouraged when they try to build and run a simple project. I suspect that 
once [~bowserj]'s proposed changes are implemented, all of this will go away, 
as it seems like this is all a symptom of Cordova autogenerating incompatible 
files.

In the meantime, could somebody recommend an easy way to successfully import a 
Cordova project into the latest version of Android Studio?

> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>  Labels: CordovaAndroidSix
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

53 matches

Mail list logo