[jira] [Commented] (CB-12543) Lock Orientation on iOS doesn't work correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981690#comment-15981690
 ] 

ASF GitHub Bot commented on CB-12543:
-

Github user bjomi commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/11
  
great! thanks for quick response @purplecabbage


> Lock Orientation on iOS doesn't work correctly
> --
>
> Key: CB-12543
> URL: https://issues.apache.org/jira/browse/CB-12543
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Screen Orientation
>Affects Versions: Master
> Environment: iOS 10
> iPhone 6+
>Reporter: Pascal
>Priority: Critical
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When I haven't locked the orientation so far and held my iPhone in portrait 
> mode and then lock it to landscape, it appears that the webview is rotated 
> but not the "screen" 
> => only half of the webview is still visible since it isn't resized to the 
> new orientation
> - Already made a PR on 
> https://github.com/apache/cordova-plugin-screen-orientation/pulls



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12543) Lock Orientation on iOS doesn't work correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981660#comment-15981660
 ] 

ASF GitHub Bot commented on CB-12543:
-

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/11
  
cleaned up a few merge issues, this is now in master, thanks @cnspaha 
Next the plugin will need to go thru the typical Apache vote process before 
being pushed to npm.

In the meantime, you should still be able to install it by using the github 
repo url : 

```cordova plugin add 
https://github.com/apache/cordova-plugin-screen-orientation```

or in build, add this to your config.xml 

```
 https://github.com/apache/cordova-plugin-screen-orientation; />
```





> Lock Orientation on iOS doesn't work correctly
> --
>
> Key: CB-12543
> URL: https://issues.apache.org/jira/browse/CB-12543
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Screen Orientation
>Affects Versions: Master
> Environment: iOS 10
> iPhone 6+
>Reporter: Pascal
>Priority: Critical
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When I haven't locked the orientation so far and held my iPhone in portrait 
> mode and then lock it to landscape, it appears that the webview is rotated 
> but not the "screen" 
> => only half of the webview is still visible since it isn't resized to the 
> new orientation
> - Already made a PR on 
> https://github.com/apache/cordova-plugin-screen-orientation/pulls



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12543) Lock Orientation on iOS doesn't work correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981640#comment-15981640
 ] 

ASF GitHub Bot commented on CB-12543:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-screen-orientation/pull/11


> Lock Orientation on iOS doesn't work correctly
> --
>
> Key: CB-12543
> URL: https://issues.apache.org/jira/browse/CB-12543
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Screen Orientation
>Affects Versions: Master
> Environment: iOS 10
> iPhone 6+
>Reporter: Pascal
>Priority: Critical
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When I haven't locked the orientation so far and held my iPhone in portrait 
> mode and then lock it to landscape, it appears that the webview is rotated 
> but not the "screen" 
> => only half of the webview is still visible since it isn't resized to the 
> new orientation
> - Already made a PR on 
> https://github.com/apache/cordova-plugin-screen-orientation/pulls



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12543) Lock Orientation on iOS doesn't work correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981596#comment-15981596
 ] 

ASF GitHub Bot commented on CB-12543:
-

Github user bjomi commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/11
  
@purplecabbage great!


> Lock Orientation on iOS doesn't work correctly
> --
>
> Key: CB-12543
> URL: https://issues.apache.org/jira/browse/CB-12543
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Screen Orientation
>Affects Versions: Master
> Environment: iOS 10
> iPhone 6+
>Reporter: Pascal
>Priority: Critical
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When I haven't locked the orientation so far and held my iPhone in portrait 
> mode and then lock it to landscape, it appears that the webview is rotated 
> but not the "screen" 
> => only half of the webview is still visible since it isn't resized to the 
> new orientation
> - Already made a PR on 
> https://github.com/apache/cordova-plugin-screen-orientation/pulls



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12543) Lock Orientation on iOS doesn't work correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981593#comment-15981593
 ] 

ASF GitHub Bot commented on CB-12543:
-

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/11
  
there is nothing more that @ego7repo can do.
I am reviewing this now.


> Lock Orientation on iOS doesn't work correctly
> --
>
> Key: CB-12543
> URL: https://issues.apache.org/jira/browse/CB-12543
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Screen Orientation
>Affects Versions: Master
> Environment: iOS 10
> iPhone 6+
>Reporter: Pascal
>Priority: Critical
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When I haven't locked the orientation so far and held my iPhone in portrait 
> mode and then lock it to landscape, it appears that the webview is rotated 
> but not the "screen" 
> => only half of the webview is still visible since it isn't resized to the 
> new orientation
> - Already made a PR on 
> https://github.com/apache/cordova-plugin-screen-orientation/pulls



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12543) Lock Orientation on iOS doesn't work correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981587#comment-15981587
 ] 

ASF GitHub Bot commented on CB-12543:
-

Github user bjomi commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/11
  
@ego7repo +1. Please get this fix out now so that the plugin becomes usable 
on iOS. Right now it isn't unfortunately.


> Lock Orientation on iOS doesn't work correctly
> --
>
> Key: CB-12543
> URL: https://issues.apache.org/jira/browse/CB-12543
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Screen Orientation
>Affects Versions: Master
> Environment: iOS 10
> iPhone 6+
>Reporter: Pascal
>Priority: Critical
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When I haven't locked the orientation so far and held my iPhone in portrait 
> mode and then lock it to landscape, it appears that the webview is rotated 
> but not the "screen" 
> => only half of the webview is still visible since it isn't resized to the 
> new orientation
> - Already made a PR on 
> https://github.com/apache/cordova-plugin-screen-orientation/pulls



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12543) Lock Orientation on iOS doesn't work correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981538#comment-15981538
 ] 

ASF GitHub Bot commented on CB-12543:
-

Github user ego7repo commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/11
  
Please push to NPM


> Lock Orientation on iOS doesn't work correctly
> --
>
> Key: CB-12543
> URL: https://issues.apache.org/jira/browse/CB-12543
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Screen Orientation
>Affects Versions: Master
> Environment: iOS 10
> iPhone 6+
>Reporter: Pascal
>Priority: Critical
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When I haven't locked the orientation so far and held my iPhone in portrait 
> mode and then lock it to landscape, it appears that the webview is rotated 
> but not the "screen" 
> => only half of the webview is still visible since it isn't resized to the 
> new orientation
> - Already made a PR on 
> https://github.com/apache/cordova-plugin-screen-orientation/pulls



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12543) Lock Orientation on iOS doesn't work correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956490#comment-15956490
 ] 

ASF GitHub Bot commented on CB-12543:
-

Github user Tawsif commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/11
  
Latest commits are not reflected in main repository code. Please do the 
needful


> Lock Orientation on iOS doesn't work correctly
> --
>
> Key: CB-12543
> URL: https://issues.apache.org/jira/browse/CB-12543
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Screen Orientation
>Affects Versions: Master
> Environment: iOS 10
> iPhone 6+
>Reporter: Pascal
>Priority: Critical
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When I haven't locked the orientation so far and held my iPhone in portrait 
> mode and then lock it to landscape, it appears that the webview is rotated 
> but not the "screen" 
> => only half of the webview is still visible since it isn't resized to the 
> new orientation
> - Already made a PR on 
> https://github.com/apache/cordova-plugin-screen-orientation/pulls



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12543) Lock Orientation on iOS doesn't work correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956382#comment-15956382
 ] 

ASF GitHub Bot commented on CB-12543:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/11
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-screen-orientation/pull/11/commits/d2931b173c22a33c14de4bdbdca3818f447e0eb4)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/24/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/24//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/24//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/24//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/24//PLATFORM=windows-10-store/artifact/)
 |
| [iOS 9.3]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/24//PLATFORM=ios-9.3/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/24//PLATFORM=ios-9.3/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/24//PLATFORM=ios-9.3/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/24//PLATFORM=ios-9.3/artifact/)
 |
| [iOS 10.0]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/24//PLATFORM=ios-10.0/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/24//PLATFORM=ios-10.0/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/24//PLATFORM=ios-10.0/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/24//PLATFORM=ios-10.0/artifact/)
 |
| [Android 4.4]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/24//PLATFORM=android-4.4/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/24//PLATFORM=android-4.4/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/24//PLATFORM=android-4.4/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/24//PLATFORM=android-4.4/artifact/)
 |
| [Android 5.1]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/24//PLATFORM=android-5.1/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/24//PLATFORM=android-5.1/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/24//PLATFORM=android-5.1/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/24//PLATFORM=android-5.1/artifact/)
 |
 



> Lock Orientation on iOS doesn't work correctly
> --
>
> Key: CB-12543
> URL: https://issues.apache.org/jira/browse/CB-12543
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Screen Orientation
>Affects Versions: Master
> Environment: iOS 10
> iPhone 6+
>Reporter: Pascal
>Priority: Critical
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When I haven't locked the orientation so far and held my iPhone in portrait 
> mode and then lock it to landscape, it appears that the webview is rotated 
> but not the "screen" 
> => only half of the webview is still visible since it isn't resized to the 
> new orientation
> - Already made a PR on 
> https://github.com/apache/cordova-plugin-screen-orientation/pulls



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12543) Lock Orientation on iOS doesn't work correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956359#comment-15956359
 ] 

ASF GitHub Bot commented on CB-12543:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/11
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-screen-orientation/pull/11/commits/1acc8684a9824bf42c42ef15498c772ffdc9f6ae)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/23/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/23//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/23//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/23//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/23//PLATFORM=windows-10-store/artifact/)
 |
| [iOS 9.3]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/23//PLATFORM=ios-9.3/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/23//PLATFORM=ios-9.3/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/23//PLATFORM=ios-9.3/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/23//PLATFORM=ios-9.3/artifact/)
 |
| [iOS 10.0]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/23//PLATFORM=ios-10.0/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/23//PLATFORM=ios-10.0/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/23//PLATFORM=ios-10.0/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/23//PLATFORM=ios-10.0/artifact/)
 |
| [Android 4.4]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/23//PLATFORM=android-4.4/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/23//PLATFORM=android-4.4/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/23//PLATFORM=android-4.4/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/23//PLATFORM=android-4.4/artifact/)
 |
| [Android 5.1]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/23//PLATFORM=android-5.1/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/23//PLATFORM=android-5.1/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/23//PLATFORM=android-5.1/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/23//PLATFORM=android-5.1/artifact/)
 |
 



> Lock Orientation on iOS doesn't work correctly
> --
>
> Key: CB-12543
> URL: https://issues.apache.org/jira/browse/CB-12543
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Screen Orientation
>Affects Versions: Master
> Environment: iOS 10
> iPhone 6+
>Reporter: Pascal
>Priority: Critical
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When I haven't locked the orientation so far and held my iPhone in portrait 
> mode and then lock it to landscape, it appears that the webview is rotated 
> but not the "screen" 
> => only half of the webview is still visible since it isn't resized to the 
> new orientation
> - Already made a PR on 
> https://github.com/apache/cordova-plugin-screen-orientation/pulls



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12543) Lock Orientation on iOS doesn't work correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956347#comment-15956347
 ] 

ASF GitHub Bot commented on CB-12543:
-

Github user cnspaha commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/11
  
I don't know why it don't work on phonegap build, since I don't use it, I 
can't reproduce.


> Lock Orientation on iOS doesn't work correctly
> --
>
> Key: CB-12543
> URL: https://issues.apache.org/jira/browse/CB-12543
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Screen Orientation
>Affects Versions: Master
> Environment: iOS 10
> iPhone 6+
>Reporter: Pascal
>Priority: Critical
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When I haven't locked the orientation so far and held my iPhone in portrait 
> mode and then lock it to landscape, it appears that the webview is rotated 
> but not the "screen" 
> => only half of the webview is still visible since it isn't resized to the 
> new orientation
> - Already made a PR on 
> https://github.com/apache/cordova-plugin-screen-orientation/pulls



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12543) Lock Orientation on iOS doesn't work correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956342#comment-15956342
 ] 

ASF GitHub Bot commented on CB-12543:
-

Github user Tawsif commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/11
  
Please resolve this ASAP. As the changes are not reflected on phonegap 
build. So I am not able to test it


> Lock Orientation on iOS doesn't work correctly
> --
>
> Key: CB-12543
> URL: https://issues.apache.org/jira/browse/CB-12543
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Screen Orientation
>Affects Versions: Master
> Environment: iOS 10
> iPhone 6+
>Reporter: Pascal
>Priority: Critical
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When I haven't locked the orientation so far and held my iPhone in portrait 
> mode and then lock it to landscape, it appears that the webview is rotated 
> but not the "screen" 
> => only half of the webview is still visible since it isn't resized to the 
> new orientation
> - Already made a PR on 
> https://github.com/apache/cordova-plugin-screen-orientation/pulls



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12543) Lock Orientation on iOS doesn't work correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15952360#comment-15952360
 ] 

ASF GitHub Bot commented on CB-12543:
-

Github user nowitz commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/11
  
I have same problem with dependencies: 
"@ionic-native/screen-orientation": "^3.4.4" 
and plugin:
"name": "cordova-plugin-screen-orientation",
"version": "2.0.0",

Your system information:

Cordova CLI: 6.5.0 
Ionic Framework Version: 2.3.0
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
Ionic App Scripts Version: 1.1.4
ios-deploy version: Not installed
ios-sim version: Not installed
OS: macOS Sierra
Node Version: v7.5.0
Xcode version: Xcode 8.3 Build version 8E162


> Lock Orientation on iOS doesn't work correctly
> --
>
> Key: CB-12543
> URL: https://issues.apache.org/jira/browse/CB-12543
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Screen Orientation
>Affects Versions: Master
> Environment: iOS 10
> iPhone 6+
>Reporter: Pascal
>Priority: Critical
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When I haven't locked the orientation so far and held my iPhone in portrait 
> mode and then lock it to landscape, it appears that the webview is rotated 
> but not the "screen" 
> => only half of the webview is still visible since it isn't resized to the 
> new orientation
> - Already made a PR on 
> https://github.com/apache/cordova-plugin-screen-orientation/pulls



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12543) Lock Orientation on iOS doesn't work correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942870#comment-15942870
 ] 

ASF GitHub Bot commented on CB-12543:
-

Github user iamehiz commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/11
  
This do not work, after uploading to phonegap build, don't know why? 


> Lock Orientation on iOS doesn't work correctly
> --
>
> Key: CB-12543
> URL: https://issues.apache.org/jira/browse/CB-12543
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Screen Orientation
>Affects Versions: Master
> Environment: iOS 10
> iPhone 6+
>Reporter: Pascal
>Priority: Critical
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When I haven't locked the orientation so far and held my iPhone in portrait 
> mode and then lock it to landscape, it appears that the webview is rotated 
> but not the "screen" 
> => only half of the webview is still visible since it isn't resized to the 
> new orientation
> - Already made a PR on 
> https://github.com/apache/cordova-plugin-screen-orientation/pulls



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12543) Lock Orientation on iOS doesn't work correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940034#comment-15940034
 ] 

ASF GitHub Bot commented on CB-12543:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/11
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-screen-orientation/pull/11/commits/d2931b173c22a33c14de4bdbdca3818f447e0eb4)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=windows-10-store/artifact/)
 |
| [iOS 9.3]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=ios-9.3/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=ios-9.3/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=ios-9.3/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=ios-9.3/artifact/)
 |
| [iOS 10.0]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=ios-10.0/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=ios-10.0/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=ios-10.0/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=ios-10.0/artifact/)
 |
| [Android 4.4]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=android-4.4/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=android-4.4/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=android-4.4/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=android-4.4/artifact/)
 |
| [Android 5.1]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=android-5.1/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=android-5.1/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=android-5.1/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=android-5.1/artifact/)
 |
 



> Lock Orientation on iOS doesn't work correctly
> --
>
> Key: CB-12543
> URL: https://issues.apache.org/jira/browse/CB-12543
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Screen Orientation
>Affects Versions: Master
> Environment: iOS 10
> iPhone 6+
>Reporter: Pascal
>Priority: Critical
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When I haven't locked the orientation so far and held my iPhone in portrait 
> mode and then lock it to landscape, it appears that the webview is rotated 
> but not the "screen" 
> => only half of the webview is still visible since it isn't resized to the 
> new orientation
> - Already made a PR on 
> https://github.com/apache/cordova-plugin-screen-orientation/pulls



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12543) Lock Orientation on iOS doesn't work correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940027#comment-15940027
 ] 

ASF GitHub Bot commented on CB-12543:
-

Github user Sh1d0w commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/11
  
@cnspaha Can you advise on the issue above, please?


> Lock Orientation on iOS doesn't work correctly
> --
>
> Key: CB-12543
> URL: https://issues.apache.org/jira/browse/CB-12543
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Screen Orientation
>Affects Versions: Master
> Environment: iOS 10
> iPhone 6+
>Reporter: Pascal
>Priority: Critical
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When I haven't locked the orientation so far and held my iPhone in portrait 
> mode and then lock it to landscape, it appears that the webview is rotated 
> but not the "screen" 
> => only half of the webview is still visible since it isn't resized to the 
> new orientation
> - Already made a PR on 
> https://github.com/apache/cordova-plugin-screen-orientation/pulls



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12543) Lock Orientation on iOS doesn't work correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940020#comment-15940020
 ] 

ASF GitHub Bot commented on CB-12543:
-

Github user cnspaha commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/11
  
@purplecabbage 
applied your proposed changes


> Lock Orientation on iOS doesn't work correctly
> --
>
> Key: CB-12543
> URL: https://issues.apache.org/jira/browse/CB-12543
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Screen Orientation
>Affects Versions: Master
> Environment: iOS 10
> iPhone 6+
>Reporter: Pascal
>Priority: Critical
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When I haven't locked the orientation so far and held my iPhone in portrait 
> mode and then lock it to landscape, it appears that the webview is rotated 
> but not the "screen" 
> => only half of the webview is still visible since it isn't resized to the 
> new orientation
> - Already made a PR on 
> https://github.com/apache/cordova-plugin-screen-orientation/pulls



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12543) Lock Orientation on iOS doesn't work correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940018#comment-15940018
 ] 

ASF GitHub Bot commented on CB-12543:
-

Github user Sh1d0w commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/11
  
The proposed fix works ok (reverted `screenObject.nativeLock !== null` back 
to `screenObject.nativeLock != null`), expect that it does not force rotate the 
screen if you are already holding the phone in that orientation. What I mean:

Lock the screen to landscape while holding the phone vertically. It will 
work ok.
Rotate the phone horizontal, then rotate it again vertically.

Now lock the phone to portrait, the web view will remain in landscape mode 
until you shake it.


> Lock Orientation on iOS doesn't work correctly
> --
>
> Key: CB-12543
> URL: https://issues.apache.org/jira/browse/CB-12543
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Screen Orientation
>Affects Versions: Master
> Environment: iOS 10
> iPhone 6+
>Reporter: Pascal
>Priority: Critical
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When I haven't locked the orientation so far and held my iPhone in portrait 
> mode and then lock it to landscape, it appears that the webview is rotated 
> but not the "screen" 
> => only half of the webview is still visible since it isn't resized to the 
> new orientation
> - Already made a PR on 
> https://github.com/apache/cordova-plugin-screen-orientation/pulls



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12543) Lock Orientation on iOS doesn't work correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15933857#comment-15933857
 ] 

ASF GitHub Bot commented on CB-12543:
-

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/11
  
If this is still valid, please rebase. Otherwise it will be closed.


> Lock Orientation on iOS doesn't work correctly
> --
>
> Key: CB-12543
> URL: https://issues.apache.org/jira/browse/CB-12543
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Screen Orientation
>Affects Versions: Master
> Environment: iOS 10
> iPhone 6+
>Reporter: Pascal
>Priority: Critical
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When I haven't locked the orientation so far and held my iPhone in portrait 
> mode and then lock it to landscape, it appears that the webview is rotated 
> but not the "screen" 
> => only half of the webview is still visible since it isn't resized to the 
> new orientation
> - Already made a PR on 
> https://github.com/apache/cordova-plugin-screen-orientation/pulls



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12543) Lock Orientation on iOS doesn't work correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903909#comment-15903909
 ] 

ASF GitHub Bot commented on CB-12543:
-

Github user purplecabbage commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-screen-orientation/pull/11#discussion_r105280210
  
--- Diff: www/screenorientation.js ---
@@ -54,7 +54,7 @@
 screenObject.lock = function(orientation) {
 var promiseLock;
 var p = new Promise(function(resolve, reject) {
-if (screenObject.nativeLock != null) {
+if (screenObject.nativeLock !== null) {
--- End diff --

if you are gonna be strict, then you would have to test for undefined also


> Lock Orientation on iOS doesn't work correctly
> --
>
> Key: CB-12543
> URL: https://issues.apache.org/jira/browse/CB-12543
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Screen Orientation
>Affects Versions: Master
> Environment: iOS 10
> iPhone 6+
>Reporter: Pascal
>Priority: Critical
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When I haven't locked the orientation so far and held my iPhone in portrait 
> mode and then lock it to landscape, it appears that the webview is rotated 
> but not the "screen" 
> => only half of the webview is still visible since it isn't resized to the 
> new orientation
> - Already made a PR on 
> https://github.com/apache/cordova-plugin-screen-orientation/pulls



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12543) Lock Orientation on iOS doesn't work correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897186#comment-15897186
 ] 

ASF GitHub Bot commented on CB-12543:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/11
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-screen-orientation/pull/11/commits/2ee910ecbcd2311d150e32dcdca0aa5d3482ca5f)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/17/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/17//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/17//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/17//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/17//PLATFORM=windows-10-store/artifact/)
 |
| [iOS 9.3]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/17//PLATFORM=ios-9.3/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/17//PLATFORM=ios-9.3/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/17//PLATFORM=ios-9.3/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/17//PLATFORM=ios-9.3/artifact/)
 |
| [iOS 10.0]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/17//PLATFORM=ios-10.0/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/17//PLATFORM=ios-10.0/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/17//PLATFORM=ios-10.0/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/17//PLATFORM=ios-10.0/artifact/)
 |
| [Android 4.4]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/17//PLATFORM=android-4.4/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/17//PLATFORM=android-4.4/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/17//PLATFORM=android-4.4/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/17//PLATFORM=android-4.4/artifact/)
 |
| [Android 5.1]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/17//PLATFORM=android-5.1/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/17//PLATFORM=android-5.1/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/17//PLATFORM=android-5.1/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/17//PLATFORM=android-5.1/artifact/)
 |
 



> Lock Orientation on iOS doesn't work correctly
> --
>
> Key: CB-12543
> URL: https://issues.apache.org/jira/browse/CB-12543
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Screen Orientation
>Affects Versions: Master
> Environment: iOS 10
> iPhone 6+
>Reporter: Pascal
>Priority: Critical
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When I haven't locked the orientation so far and held my iPhone in portrait 
> mode and then lock it to landscape, it appears that the webview is rotated 
> but not the "screen" 
> => only half of the webview is still visible since it isn't resized to the 
> new orientation
> - Already made a PR on 
> https://github.com/apache/cordova-plugin-screen-orientation/pulls



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12543) Lock Orientation on iOS doesn't work correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897154#comment-15897154
 ] 

ASF GitHub Bot commented on CB-12543:
-

Github user alsorokin commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/11
  
Let there be tests


> Lock Orientation on iOS doesn't work correctly
> --
>
> Key: CB-12543
> URL: https://issues.apache.org/jira/browse/CB-12543
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Screen Orientation
>Affects Versions: Master
> Environment: iOS 10
> iPhone 6+
>Reporter: Pascal
>Priority: Critical
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When I haven't locked the orientation so far and held my iPhone in portrait 
> mode and then lock it to landscape, it appears that the webview is rotated 
> but not the "screen" 
> => only half of the webview is still visible since it isn't resized to the 
> new orientation
> - Already made a PR on 
> https://github.com/apache/cordova-plugin-screen-orientation/pulls



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12543) Lock Orientation on iOS doesn't work correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896892#comment-15896892
 ] 

ASF GitHub Bot commented on CB-12543:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/11
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-screen-orientation/pull/11/commits/2ee910ecbcd2311d150e32dcdca0aa5d3482ca5f)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/16/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/16//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/16//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/16//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/16//PLATFORM=windows-10-store/artifact/)
 |
| [iOS 9.3]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/16//PLATFORM=ios-9.3/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/16//PLATFORM=ios-9.3/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/16//PLATFORM=ios-9.3/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/16//PLATFORM=ios-9.3/artifact/)
 |
| [iOS 10.0]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/16//PLATFORM=ios-10.0/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/16//PLATFORM=ios-10.0/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/16//PLATFORM=ios-10.0/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/16//PLATFORM=ios-10.0/artifact/)
 |
| [Android 4.4]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/16//PLATFORM=android-4.4/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/16//PLATFORM=android-4.4/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/16//PLATFORM=android-4.4/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/16//PLATFORM=android-4.4/artifact/)
 |
| [Android 5.1]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/16//PLATFORM=android-5.1/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/16//PLATFORM=android-5.1/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/16//PLATFORM=android-5.1/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/16//PLATFORM=android-5.1/artifact/)
 |
 



> Lock Orientation on iOS doesn't work correctly
> --
>
> Key: CB-12543
> URL: https://issues.apache.org/jira/browse/CB-12543
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Screen Orientation
>Affects Versions: Master
> Environment: iOS 10
> iPhone 6+
>Reporter: Pascal
>Priority: Critical
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When I haven't locked the orientation so far and held my iPhone in portrait 
> mode and then lock it to landscape, it appears that the webview is rotated 
> but not the "screen" 
> => only half of the webview is still visible since it isn't resized to the 
> new orientation
> - Already made a PR on 
> https://github.com/apache/cordova-plugin-screen-orientation/pulls



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12543) Lock Orientation on iOS doesn't work correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896800#comment-15896800
 ] 

ASF GitHub Bot commented on CB-12543:
-

GitHub user cnspaha opened a pull request:

https://github.com/apache/cordova-plugin-screen-orientation/pull/11

CB-12543 (iOS) Set orientation on when locking the device

### Platforms affected
iOS

### What does this PR do?
Instead of just locking the orientation, it also rotates to it. Mandatory 
for iOS.

### What testing has been done on this change?
Manual testing on iOS 10, iPhone 6+.
Run: "npm test"

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cadenasgmbh/cordova-plugin-screen-orientation 
setOrientationOnLock

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-screen-orientation/pull/11.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #11


commit 7185add951fff8d405338af5ef812cb34c476315
Author: Pascal Häusler 
Date:   2017-03-03T14:03:09Z

Rotate to specified orientation when locked

commit 141dea7e6b28f3900e530dd7e2def21f762e807d
Author: Pascal Häusler 
Date:   2017-03-06T06:19:56Z

Refactor

commit fbe1c98d8c9389dabaef23b5c0b31b015ff87c3b
Author: Pascal Häusler 
Date:   2017-03-06T06:26:54Z

Update screenorientation.js to prevent jshint to fail test

commit 2ee910ecbcd2311d150e32dcdca0aa5d3482ca5f
Author: Pascal Häusler 
Date:   2017-03-06T06:27:34Z

Update CDVOrientationproxy.js to prevent jshint to fail test




> Lock Orientation on iOS doesn't work correctly
> --
>
> Key: CB-12543
> URL: https://issues.apache.org/jira/browse/CB-12543
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Screen Orientation
>Affects Versions: Master
> Environment: iOS 10
> iPhone 6+
>Reporter: Pascal
>Priority: Critical
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When I haven't locked the orientation so far and held my iPhone in portrait 
> mode and then lock it to landscape, it appears that the webview is rotated 
> but not the "screen" 
> => only half of the webview is still visible since it isn't resized to the 
> new orientation



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org