[jira] [Commented] (CB-13424) [cordova-osx] Not adding plugins to the osx platform

2018-07-02 Thread Tobias Bocanegra (JIRA) 


[ 
https://issues.apache.org/jira/browse/CB-13424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529445#comment-16529445
 ] 

Tobias Bocanegra commented on CB-13424:
---

bq. As a side question, do you happen to know why the PR says closed instead of 
merged?

I uses coho to prepare the PR. coho adds a {{This closes #32}} to the commit 
message:
https://github.com/apache/cordova-common/commit/7bf9627f0135c6b3518292660b6e07e6f5815926



> [cordova-osx] Not adding plugins to the osx platform
> 
>
> Key: CB-13424
> URL: https://issues.apache.org/jira/browse/CB-13424
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-osx
>Reporter: José Expósito
>Assignee: Tobias Bocanegra
>Priority: Blocker
>
> cordova plugin add does not work on macOS.
> It is necessary to open "platforms/osx/HelloCordova.xcodeproj" and manually 
> add the plugin to "platforms/osx/HelloCordova/config.xml":
> {code}
> 
>  xmlns="http://www.w3.org/ns/widgets; 
> xmlns:cdv="http://cordova.apache.org/ns/1.0;>
> [...]
> 
> 
> 
> [...]
> 
> {code}
> I noticed this happens with Cordova core plugins with official macOS support 
> like cordova-plugin-device or cordova-plugin-file.
> Also experimented while migrating cordova-plugin-camera:
> https://github.com/apache/cordova-plugin-camera/pull/290



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13424) [cordova-osx] Not adding plugins to the osx platform

2018-07-01 Thread Bryan Ellis (JIRA) 


[ 
https://issues.apache.org/jira/browse/CB-13424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529385#comment-16529385
 ] 

Bryan Ellis commented on CB-13424:
--

[~tripod], 

I believe this issue is the same as 
[CB-14099|https://issues.apache.org/jira/browse/CB-14099].

We have already merged into cordova-common master the fixing 
[PR|https://github.com/apache/cordova-common/pull/32]. Even though the PR says 
closed and not merged, the changes are committed to master 
[here|https://github.com/apache/cordova-common/commit/7bf9627f0135c6b3518292660b6e07e6f5815926].

As a side question, do you happen to know why the PR says closed instead of 
merged?

I think we can resolve this ticket.

> [cordova-osx] Not adding plugins to the osx platform
> 
>
> Key: CB-13424
> URL: https://issues.apache.org/jira/browse/CB-13424
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-osx
>Reporter: José Expósito
>Assignee: Tobias Bocanegra
>Priority: Blocker
>
> cordova plugin add does not work on macOS.
> It is necessary to open "platforms/osx/HelloCordova.xcodeproj" and manually 
> add the plugin to "platforms/osx/HelloCordova/config.xml":
> {code}
> 
>  xmlns="http://www.w3.org/ns/widgets; 
> xmlns:cdv="http://cordova.apache.org/ns/1.0;>
> [...]
> 
> 
> 
> [...]
> 
> {code}
> I noticed this happens with Cordova core plugins with official macOS support 
> like cordova-plugin-device or cordova-plugin-file.
> Also experimented while migrating cordova-plugin-camera:
> https://github.com/apache/cordova-plugin-camera/pull/290



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13424) [cordova-osx] Not adding plugins to the osx platform

2017-11-03 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238789#comment-16238789
 ] 

ASF GitHub Bot commented on CB-13424:
-

stevengill commented on issue #43: CB-13424: "cordova plugin add/remove" writes 
changes in config.xml
URL: https://github.com/apache/cordova-osx/pull/43#issuecomment-341873284
 
 
   I merged this in, but testing with 
https://github.com/apache/cordova-plugin-camera/pull/290, but it still doesn't 
add the feature tag to config.xml. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [cordova-osx] Not adding plugins to the osx platform
> 
>
> Key: CB-13424
> URL: https://issues.apache.org/jira/browse/CB-13424
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-osx
>Reporter: José Expósito
>Assignee: Tobias Bocanegra
>Priority: Blocker
>
> cordova plugin add does not work on macOS.
> It is necessary to open "platforms/osx/HelloCordova.xcodeproj" and manually 
> add the plugin to "platforms/osx/HelloCordova/config.xml":
> {code}
> 
>  xmlns="http://www.w3.org/ns/widgets; 
> xmlns:cdv="http://cordova.apache.org/ns/1.0;>
> [...]
> 
> 
> 
> [...]
> 
> {code}
> I noticed this happens with Cordova core plugins with official macOS support 
> like cordova-plugin-device or cordova-plugin-file.
> Also experimented while migrating cordova-plugin-camera:
> https://github.com/apache/cordova-plugin-camera/pull/290



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13424) [cordova-osx] Not adding plugins to the osx platform

2017-11-03 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238679#comment-16238679
 ] 

ASF subversion and git services commented on CB-13424:
--

Commit f7db769af2f5d75243ea852faac4abd1c6d50c97 in cordova-osx's branch 
refs/heads/master from [~stevegill]
[ https://gitbox.apache.org/repos/asf?p=cordova-osx.git;h=f7db769 ]

Merge pull request #43 from JoseExposito/master

CB-13424: "cordova plugin add/remove" writes changes in config.xml

> [cordova-osx] Not adding plugins to the osx platform
> 
>
> Key: CB-13424
> URL: https://issues.apache.org/jira/browse/CB-13424
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-osx
>Reporter: José Expósito
>Assignee: Tobias Bocanegra
>Priority: Blocker
>
> cordova plugin add does not work on macOS.
> It is necessary to open "platforms/osx/HelloCordova.xcodeproj" and manually 
> add the plugin to "platforms/osx/HelloCordova/config.xml":
> {code}
> 
>  xmlns="http://www.w3.org/ns/widgets; 
> xmlns:cdv="http://cordova.apache.org/ns/1.0;>
> [...]
> 
> 
> 
> [...]
> 
> {code}
> I noticed this happens with Cordova core plugins with official macOS support 
> like cordova-plugin-device or cordova-plugin-file.
> Also experimented while migrating cordova-plugin-camera:
> https://github.com/apache/cordova-plugin-camera/pull/290



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13424) [cordova-osx] Not adding plugins to the osx platform

2017-11-03 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238678#comment-16238678
 ] 

ASF subversion and git services commented on CB-13424:
--

Commit e6f4c6225d2e97347350018bd189b8b1039e76b7 in cordova-osx's branch 
refs/heads/master from [~JoseExposito]
[ https://gitbox.apache.org/repos/asf?p=cordova-osx.git;h=e6f4c62 ]

CB-13424: Replaces undefined "self" with "this"

> [cordova-osx] Not adding plugins to the osx platform
> 
>
> Key: CB-13424
> URL: https://issues.apache.org/jira/browse/CB-13424
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-osx
>Reporter: José Expósito
>Assignee: Tobias Bocanegra
>Priority: Blocker
>
> cordova plugin add does not work on macOS.
> It is necessary to open "platforms/osx/HelloCordova.xcodeproj" and manually 
> add the plugin to "platforms/osx/HelloCordova/config.xml":
> {code}
> 
>  xmlns="http://www.w3.org/ns/widgets; 
> xmlns:cdv="http://cordova.apache.org/ns/1.0;>
> [...]
> 
> 
> 
> [...]
> 
> {code}
> I noticed this happens with Cordova core plugins with official macOS support 
> like cordova-plugin-device or cordova-plugin-file.
> Also experimented while migrating cordova-plugin-camera:
> https://github.com/apache/cordova-plugin-camera/pull/290



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13424) [cordova-osx] Not adding plugins to the osx platform

2017-11-03 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238677#comment-16238677
 ] 

ASF GitHub Bot commented on CB-13424:
-

stevengill closed pull request #43: CB-13424: "cordova plugin add/remove" 
writes changes in config.xml
URL: https://github.com/apache/cordova-osx/pull/43
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/bin/templates/scripts/cordova/Api.js 
b/bin/templates/scripts/cordova/Api.js
index 8867e38..0cc666d 100644
--- a/bin/templates/scripts/cordova/Api.js
+++ b/bin/templates/scripts/cordova/Api.js
@@ -20,7 +20,9 @@
 var fs = require('fs');
 var path = require('path');
 
-var CordovaError = require('cordova-common').CordovaError;
+var PluginManager = require('cordova-common').PluginManager;
+var projectFile   = require('./lib/projectFile');
+var CordovaError  = require('cordova-common').CordovaError;
 var ConsoleLogger = require('./lib/ConsoleLogger');
 
 /**
@@ -181,8 +183,8 @@ Api.prototype.prepare = function (cordovaProject) {
  *   CordovaError instance.
  */
 Api.prototype.addPlugin = function (plugin, installOptions) {
-var Plugman = require('./lib/plugman/Plugman');
-return Plugman.get(this.locations, this.events).addPlugin(plugin, 
installOptions);
+var xcodeproj = projectFile.parse(this.locations);
+return PluginManager.get(this.platform, this.locations, 
xcodeproj).addPlugin(plugin, installOptions);
 };
 
 /**
@@ -199,8 +201,8 @@ Api.prototype.addPlugin = function (plugin, installOptions) 
{
  *   CordovaError instance.
  */
 Api.prototype.removePlugin = function (plugin, uninstallOptions) {
-var Plugman = require('./lib/plugman/Plugman');
-return Plugman.get(this.locations, this.events).removePlugin(plugin, 
uninstallOptions);
+var xcodeproj = projectFile.parse(this.locations);
+return PluginManager.get(this.platform, this.locations, 
xcodeproj).removePlugin(plugin, uninstallOptions)
 };
 
 /**
diff --git a/bin/templates/scripts/cordova/lib/projectFile.js 
b/bin/templates/scripts/cordova/lib/projectFile.js
index 0d0057b..b373464 100644
--- a/bin/templates/scripts/cordova/lib/projectFile.js
+++ b/bin/templates/scripts/cordova/lib/projectFile.js
@@ -26,6 +26,7 @@ var path = require('path');
 var fs = require('fs');
 var shell = require('shelljs');
 
+var pluginHandlers = require('./plugman/pluginHandlers');
 var CordovaError = require('cordova-common').CordovaError;
 
 var cachedProjectFiles = {};
@@ -81,6 +82,12 @@ function parseProjectFile (locations) {
 getPackageName: function () {
 return plist.parse(fs.readFileSync(plist_file, 
'utf8')).CFBundleIdentifier;
 },
+getInstaller: function (name) {
+return pluginHandlers.getInstaller(name);
+},
+getUninstaller: function (name) {
+return pluginHandlers.getUninstaller(name);
+},
 frameworks: frameworks
 };
 return cachedProjectFiles[project_dir];
diff --git a/package.json b/package.json
index dcac015..0e2dd06 100644
--- a/package.json
+++ b/package.json
@@ -24,7 +24,7 @@
   "author": "Apache Software Foundation",
   "license": "Apache Version 2.0",
   "dependencies": {
-"cordova-common": "^1.0.0",
+"cordova-common": "2.1.0",
 "nopt": "^3.0.6",
 "q": "^1.4.1",
 "shelljs": "^0.5.3",


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [cordova-osx] Not adding plugins to the osx platform
> 
>
> Key: CB-13424
> URL: https://issues.apache.org/jira/browse/CB-13424
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-osx
>Reporter: José Expósito
>Assignee: Tobias Bocanegra
>Priority: Blocker
>
> cordova plugin add does not work on macOS.
> It is necessary to open "platforms/osx/HelloCordova.xcodeproj" and manually 
> add the plugin to "platforms/osx/HelloCordova/config.xml":
> {code}
> 
>  xmlns="http://www.w3.org/ns/widgets; 
> xmlns:cdv="http://cordova.apache.org/ns/1.0;>
> [...]
> 
> 
> 
> [...]
> 
> {code}
> I noticed this happens with Cordova core plugins with official macOS support 
> like cordova-plugin-device or cordova-plugin-file.
> Also experimented while migrating cordova-plugin-camera:
> https://github.com/apache/cordova-plugin-camera/pull/290



--
This message was sent by Atlassian

[jira] [Commented] (CB-13424) [cordova-osx] Not adding plugins to the osx platform

2017-10-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207506#comment-16207506
 ] 

ASF GitHub Bot commented on CB-13424:
-

Github user JoseExposito commented on the issue:

https://github.com/apache/cordova-osx/pull/43
  
Thanks for reviewing @giuseppelt, changed


> [cordova-osx] Not adding plugins to the osx platform
> 
>
> Key: CB-13424
> URL: https://issues.apache.org/jira/browse/CB-13424
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-osx
>Reporter: José Expósito
>Assignee: Tobias Bocanegra
>Priority: Blocker
>
> cordova plugin add does not work on macOS.
> It is necessary to open "platforms/osx/HelloCordova.xcodeproj" and manually 
> add the plugin to "platforms/osx/HelloCordova/config.xml":
> {code}
> 
>  xmlns="http://www.w3.org/ns/widgets; 
> xmlns:cdv="http://cordova.apache.org/ns/1.0;>
> [...]
> 
> 
> 
> [...]
> 
> {code}
> I noticed this happens with Cordova core plugins with official macOS support 
> like cordova-plugin-device or cordova-plugin-file.
> Also experimented while migrating cordova-plugin-camera:
> https://github.com/apache/cordova-plugin-camera/pull/290



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13424) [cordova-osx] Not adding plugins to the osx platform

2017-10-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207501#comment-16207501
 ] 

ASF GitHub Bot commented on CB-13424:
-

Github user giuseppelt commented on a diff in the pull request:

https://github.com/apache/cordova-osx/pull/43#discussion_r145098266
  
--- Diff: bin/templates/scripts/cordova/Api.js ---
@@ -199,8 +201,8 @@ Api.prototype.addPlugin = function (plugin, 
installOptions) {
  *   CordovaError instance.
  */
 Api.prototype.removePlugin = function (plugin, uninstallOptions) {
-var Plugman = require('./lib/plugman/Plugman');
-return Plugman.get(this.locations, this.events).removePlugin(plugin, 
uninstallOptions);
+var xcodeproj = projectFile.parse(this.locations);
+return PluginManager.get(self.platform, self.locations, 
xcodeproj).removePlugin(plugin, uninstallOptions)
--- End diff --

`self` is undefined here
replace with `this`



> [cordova-osx] Not adding plugins to the osx platform
> 
>
> Key: CB-13424
> URL: https://issues.apache.org/jira/browse/CB-13424
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-osx
>Reporter: José Expósito
>Assignee: Tobias Bocanegra
>Priority: Blocker
>
> cordova plugin add does not work on macOS.
> It is necessary to open "platforms/osx/HelloCordova.xcodeproj" and manually 
> add the plugin to "platforms/osx/HelloCordova/config.xml":
> {code}
> 
>  xmlns="http://www.w3.org/ns/widgets; 
> xmlns:cdv="http://cordova.apache.org/ns/1.0;>
> [...]
> 
> 
> 
> [...]
> 
> {code}
> I noticed this happens with Cordova core plugins with official macOS support 
> like cordova-plugin-device or cordova-plugin-file.
> Also experimented while migrating cordova-plugin-camera:
> https://github.com/apache/cordova-plugin-camera/pull/290



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13424) [cordova-osx] Not adding plugins to the osx platform

2017-10-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200792#comment-16200792
 ] 

ASF GitHub Bot commented on CB-13424:
-

Github user JoseExposito commented on the issue:

https://github.com/apache/cordova-osx/pull/43
  
Indeed, the logic comes from iOS/Android.

Basically, I updated the cordova-common library to match the iOS version 
and used it in the plugin add/remove hooks like other platforms are doing.

In my opinion the macOS platform will need more updates to match the 
structure other platforms are using... But for the moment this fixes the issue. 
Once I see if the team is open to community PRs you can expect more changes :)


> [cordova-osx] Not adding plugins to the osx platform
> 
>
> Key: CB-13424
> URL: https://issues.apache.org/jira/browse/CB-13424
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-osx
>Reporter: José Expósito
>Assignee: Tobias Bocanegra
>Priority: Blocker
>
> cordova plugin add does not work on macOS.
> It is necessary to open "platforms/osx/HelloCordova.xcodeproj" and manually 
> add the plugin to "platforms/osx/HelloCordova/config.xml":
> {code}
> 
>  xmlns="http://www.w3.org/ns/widgets; 
> xmlns:cdv="http://cordova.apache.org/ns/1.0;>
> [...]
> 
> 
> 
> [...]
> 
> {code}
> I noticed this happens with Cordova core plugins with official macOS support 
> like cordova-plugin-device or cordova-plugin-file.
> Also experimented while migrating cordova-plugin-camera:
> https://github.com/apache/cordova-plugin-camera/pull/290



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13424) [cordova-osx] Not adding plugins to the osx platform

2017-10-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200780#comment-16200780
 ] 

ASF GitHub Bot commented on CB-13424:
-

Github user janpio commented on the issue:

https://github.com/apache/cordova-osx/pull/43
  
Yay, that was quick. Can you talk me (and everybody reading) through the 
changes? Where does the logic come from? ios?


> [cordova-osx] Not adding plugins to the osx platform
> 
>
> Key: CB-13424
> URL: https://issues.apache.org/jira/browse/CB-13424
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-osx
>Reporter: José Expósito
>Assignee: Tobias Bocanegra
>Priority: Blocker
>
> cordova plugin add does not work on macOS.
> It is necessary to open "platforms/osx/HelloCordova.xcodeproj" and manually 
> add the plugin to "platforms/osx/HelloCordova/config.xml":
> {code}
> 
>  xmlns="http://www.w3.org/ns/widgets; 
> xmlns:cdv="http://cordova.apache.org/ns/1.0;>
> [...]
> 
> 
> 
> [...]
> 
> {code}
> I noticed this happens with Cordova core plugins with official macOS support 
> like cordova-plugin-device or cordova-plugin-file.
> Also experimented while migrating cordova-plugin-camera:
> https://github.com/apache/cordova-plugin-camera/pull/290



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13424) [cordova-osx] Not adding plugins to the osx platform

2017-10-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200748#comment-16200748
 ] 

ASF GitHub Bot commented on CB-13424:
-

GitHub user JoseExposito opened a pull request:

https://github.com/apache/cordova-osx/pull/43

CB-13424: "cordova plugin add/remove" writes changes in config.xml

See https://issues.apache.org/jira/browse/CB-13424 and 
https://github.com/apache/cordova-plugin-camera/pull/290 for a description of 
the issue.

This PR allows to add/remove plugins to the config.xml.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/JoseExposito/cordova-osx master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-osx/pull/43.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #43


commit c4b44ee1de415479a5d4a0da97988da18e786acd
Author: José Expósito 
Date:   2017-10-11T18:40:55Z

CB-13424: When running "cordova plugin add/remove" plugins are added and 
removed properly to the osx platform config.xml file




> [cordova-osx] Not adding plugins to the osx platform
> 
>
> Key: CB-13424
> URL: https://issues.apache.org/jira/browse/CB-13424
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-osx
>Reporter: José Expósito
>Assignee: Tobias Bocanegra
>Priority: Blocker
>
> cordova plugin add does not work on macOS.
> It is necessary to open "platforms/osx/HelloCordova.xcodeproj" and manually 
> add the plugin to "platforms/osx/HelloCordova/config.xml":
> {code}
> 
>  xmlns="http://www.w3.org/ns/widgets; 
> xmlns:cdv="http://cordova.apache.org/ns/1.0;>
> [...]
> 
> 
> 
> [...]
> 
> {code}
> I noticed this happens with Cordova core plugins with official macOS support 
> like cordova-plugin-device or cordova-plugin-file.
> Also experimented while migrating cordova-plugin-camera:
> https://github.com/apache/cordova-plugin-camera/pull/290



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13424) [cordova-osx] Not adding plugins to the osx platform

2017-10-11 Thread Jan Piotrowski (Sujan) (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200598#comment-16200598
 ] 

Jan Piotrowski (Sujan) commented on CB-13424:
-

Pure guess: The logic that normally copied that over in the build process is 
missing/broken for macOS/OS X. As it is quite elaborate and mainly undocumented 
/ documented in code, this can very much happen. A good research path would be 
to find out how iOS does it and see if there is similar code for osx.

> [cordova-osx] Not adding plugins to the osx platform
> 
>
> Key: CB-13424
> URL: https://issues.apache.org/jira/browse/CB-13424
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-osx
>Reporter: José Expósito
>Assignee: Tobias Bocanegra
>Priority: Blocker
>
> cordova plugin add does not work on macOS.
> It is necessary to open "platforms/osx/HelloCordova.xcodeproj" and manually 
> add the plugin to "platforms/osx/HelloCordova/config.xml":
> {code}
> 
>  xmlns="http://www.w3.org/ns/widgets; 
> xmlns:cdv="http://cordova.apache.org/ns/1.0;>
> [...]
> 
> 
> 
> [...]
> 
> {code}
> I noticed this happens with Cordova core plugins with official macOS support 
> like cordova-plugin-device or cordova-plugin-file.
> Also experimented while migrating cordova-plugin-camera:
> https://github.com/apache/cordova-plugin-camera/pull/290



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org