[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14270388#comment-14270388 ] ASF subversion and git services commented on CB-7375: - Commit 58f8ac0645e30546f0eebe8c7a5a56600e64963b in cordova-plugin-file's branch refs/heads/master from [~agrieve] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=58f8ac0 ] CB-7375 Never create new FileSystem instances (except on windows since they don't implement requestAllFileSystems()) Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14130236#comment-14130236 ] Edna Morales commented on CB-7375: -- [~iclelland] was 0ffb969 commit ever reverted? Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14130311#comment-14130311 ] Ian Clelland commented on CB-7375: -- [~eymorale], it doesn't look like it was -- I'm just testing it on iOS, and I'll commit that once I've confirmed that it's all passing. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14130330#comment-14130330 ] Ian Clelland commented on CB-7375: -- I'm still seeing errors on specs 57 and 60, so I'm holding off for a little bit while I investigate. Could be user-error, but I'm looking into it. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14130348#comment-14130348 ] Martin Gonzalez commented on CB-7375: - I think [~eymorale], investigated those failures, and made a PR to fix it. https://github.com/apache/cordova-plugin-file/pull/78 https://issues.apache.org/jira/browse/CB-7423 Can you take a look at it? Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14130351#comment-14130351 ] Edna Morales commented on CB-7375: -- [~martin.c.glez.glez] you beat me to the punch of bringing that up. Yes I did make a PR for those fixes, if you don't mind taking a look [~iclelland] thanks. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14130378#comment-14130378 ] Ian Clelland commented on CB-7375: -- Chalking that one up to user error -- The tests are still fragile (it failed because a previously-failed test run left the destination files in place; completely removing the app from the device and reinstalling solved it), but that's a problem for another day. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14130382#comment-14130382 ] ASF subversion and git services commented on CB-7375: - Commit 9a456100ee202452bd5ae043aed4a5a6389a49d3 in cordova-plugin-file's branch refs/heads/master from [~iclelland] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=9a45610 ] CB-7375: Fix the filesystem name in resolveLocalFileSystemUri Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14130409#comment-14130409 ] Edna Morales commented on CB-7375: -- Awesome thanks [~iclelland] Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14130578#comment-14130578 ] Ian Clelland commented on CB-7375: -- Can we close this, then? Everything is looking good to me on Android and iOS. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14130590#comment-14130590 ] Edna Morales commented on CB-7375: -- Looks good to me Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14130591#comment-14130591 ] Marcel Kinard commented on CB-7375: --- [~naika]: how is file plugin looking for you? Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14115220#comment-14115220 ] Edna Morales commented on CB-7375: -- I'm still seeing 12 new failures on iOS with the latest changes: spec 82, 85-94, 106 with the same errors I mentioned above (error code 1) Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[
https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14115357#comment-14115357
]
Ian Clelland commented on CB-7375:
--
I think that the failures may be related to the 0ffb969 commit: I want to
reinstate the line in {{resolveLocalFileSystemURI.js}} that should read:
{code}
var fsName = entry.filesystemName || (entry.filesystem
entry.filesystem.name) || (entry.filesystem == window.PERSISTENT ? 'persistent'
: 'temporary');
{code}
That solves almost all of the iOS errors for me. There is still something very
strange going on around test 109 or 110, that I'm trying to track down, but I
think that the above change is necessary for iOS.
Investigate breaking changes at file plugin
---
Key: CB-7375
URL: https://issues.apache.org/jira/browse/CB-7375
Project: Apache Cordova
Issue Type: Bug
Components: Plugin File
Affects Versions: 3.5.0
Reporter: Martin Gonzalez
Labels: file
Fix For: 3.6.0
Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt
Some of the changes made lately to file plugin with this commit:
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c
Are breaking changes to this plugin, affecting other platforms as android.
Running mobile spec after that specific commit, 4 file tests are failing
(test 125 -128).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14115362#comment-14115362 ] Edna Morales commented on CB-7375: -- Yeah adding that line in fixes the failures for me. I was trying to figure out what the issue with it was but that's definitely what is causing the new failures. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14115363#comment-14115363 ] Edna Morales commented on CB-7375: -- When I was trying to figure out the issue I noticed that for one of the tests (I think spec 82), it would grab temporary for fsName with the breaking change. But if I changed that line back to what it was, it would grab persistent for fsName. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14115367#comment-14115367 ] Edna Morales commented on CB-7375: -- For the issue around test 109, I updated jasmine and wasn't seeing the issue anymore so I'm not sure what is going on with that one. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14115388#comment-14115388 ] Martin Gonzalez commented on CB-7375: - that line Ian it makes perfect sense. on Resolve operation, the native side always has to provide the filesystem information on resolveLocalFileSystemURI operation. which of those properties is iOS providing? entry.filesystemName || (entry.filesystem entry.filesystem.name) All of them or it depends of the kind request? Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14115402#comment-14115402 ] Ian Clelland commented on CB-7375: -- CB-7431 for the test 109 issue. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[
https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14115403#comment-14115403
]
Ian Clelland commented on CB-7375:
--
[~martin.c.glez.glez], iOS is just providing {{filesystemName}}. Android does
the same. I think that WP8 provides {{filesystem.name}}, and I'm not sure about
other platforms.
Investigate breaking changes at file plugin
---
Key: CB-7375
URL: https://issues.apache.org/jira/browse/CB-7375
Project: Apache Cordova
Issue Type: Bug
Components: Plugin File
Affects Versions: 3.5.0
Reporter: Martin Gonzalez
Labels: file
Fix For: 3.6.0
Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt
Some of the changes made lately to file plugin with this commit:
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c
Are breaking changes to this plugin, affecting other platforms as android.
Running mobile spec after that specific commit, 4 file tests are failing
(test 125 -128).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[
https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113729#comment-14113729
]
Ian Clelland commented on CB-7375:
--
Okay, this is the smallest change that I can make that gets Android/iOS working
again.
Unfortunately, WP8 is completely opaque to me at the moment, so I need someone
with WP experience to take on the rest of this issue.
It might be as small as switching the order of the two terms:
{{entry.filesystemName}} and {{(entry.filesystem entry.filesystem.name)}} in
the conditions, but I don't want to continue dumping more code blindly into the
repository to test it.
Investigate breaking changes at file plugin
---
Key: CB-7375
URL: https://issues.apache.org/jira/browse/CB-7375
Project: Apache Cordova
Issue Type: Bug
Components: Plugin File
Affects Versions: 3.5.0
Reporter: Martin Gonzalez
Labels: file
Fix For: 3.6.0
Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt
Some of the changes made lately to file plugin with this commit:
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c
Are breaking changes to this plugin, affecting other platforms as android.
Running mobile spec after that specific commit, 4 file tests are failing
(test 125 -128).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113792#comment-14113792 ] Martin Gonzalez commented on CB-7375: - hey Ian, I'll work on this. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[
https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113896#comment-14113896
]
Martin Gonzalez commented on CB-7375:
-
The problem is that WP always starts with a leading '/', and the line 43 on
resolveLocalFileSystemURI, it sets the path as invalid, throwing a ENCODING_ERR:
{quote}
if(!uri || uri.split(:).length 2 || uri.indexOf('/') == 0) {
{quote}
Removing this statement, it would work without any problem:
{quote} uri.indexOf('/') == 0 {quote}
Investigate breaking changes at file plugin
---
Key: CB-7375
URL: https://issues.apache.org/jira/browse/CB-7375
Project: Apache Cordova
Issue Type: Bug
Components: Plugin File
Affects Versions: 3.5.0
Reporter: Martin Gonzalez
Labels: file
Fix For: 3.6.0
Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt
Some of the changes made lately to file plugin with this commit:
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c
Are breaking changes to this plugin, affecting other platforms as android.
Running mobile spec after that specific commit, 4 file tests are failing
(test 125 -128).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113920#comment-14113920 ] Martin Gonzalez commented on CB-7375: - Validated over Android, everything looks good. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113931#comment-14113931 ] ASF GitHub Bot commented on CB-7375: GitHub user martincgg opened a pull request: https://github.com/apache/cordova-plugin-file/pull/75 [CB-7375] Remove leading slash statement from condition Windows Phone file paths starts with a leading slash, if the path is an invalid one, the native side it will report a error callback with the respective error code. You can merge this pull request into a Git repository by running: $ git pull https://github.com/martincgg/cordova-plugin-file CB-7375 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/75.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #75 commit 36134d48c1864278eb99add9db5a7ca8a4445f74 Author: Martin Gonzalez martin.c.glez.g...@gmail.com Date: 2014-08-28T16:26:24Z [CB-7375] Remove leading slash statement from condition Windows Phone file paths starts with a leading slash, if the path is an invalid one, the native side it will report a error callback with the respective error code. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113980#comment-14113980 ] Ian Clelland commented on CB-7375: -- That was the change that was in 0ffb969, which was why I asked you if it was failing on that commit as well. I do see why that line is causing the failures now; I just don't know how WP8 was passing on commit 0ffb969 or 3086907. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113996#comment-14113996 ] ASF GitHub Bot commented on CB-7375: Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/75 Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113995#comment-14113995 ] ASF subversion and git services commented on CB-7375: - Commit 36134d48c1864278eb99add9db5a7ca8a4445f74 in cordova-plugin-file's branch refs/heads/master from [~martin.c.glez.glez] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=36134d4 ] [CB-7375] Remove leading slash statement from condition Windows Phone file paths starts with a leading slash, if the path is an invalid one, the native side it will report a error callback with the respective error code. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114016#comment-14114016 ] Martin Gonzalez commented on CB-7375: - Yeah and still does using 0ffb969, I have started over, double checking and it doesn't reach to that condition it's extremely weird and erratic Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114023#comment-14114023 ] Martin Gonzalez commented on CB-7375: - I'll debug again using that specific commit get the entries and compare the properties. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114091#comment-14114091 ] Edna Morales commented on CB-7375: -- It looks like this change is breaking 12 file plugin tests on iOS (on the first run, 55 fail if I do the run again). Everything works fine up to this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=dd51229d9bd1978e8e327396fb449a88b0f1b064 Changes after that commit begin to break things on iOS. The original 12 breakages are: spec 82 - error removing file specs 85 - 94 - error creating file spec 106 - error creating file all of the above with error code 1 Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114121#comment-14114121 ] Martin Gonzalez commented on CB-7375: - Starting on a new Windows 8 enviroment, I've got 8 failures over Windows Phone using 0ffb969 Specs: 9, 9.5, 15, 82, 110, 122, 123, 124. Some of the entries are getting leading slashes on fullPath properties, and at others no. I'm getting timeouts on the callbacks, I'll investigate on the native side. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[
https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114135#comment-14114135
]
Martin Gonzalez commented on CB-7375:
-
If moveTo copyTo are going to transfer a file to a parent path location, if
the entry it doesn't retrieve or provide a filesytem, it would be logically
assign the parent.filesystem information to that entry. that property it must
be on the parent object, because always gonna be a DirectoryEntry.
var fs = (entry.filesystem entry.filesystem.name) ? new
FileSystem(entry.filesystem.name, { name: , fullPath: / }) :
parent.filesystem;
Investigate breaking changes at file plugin
---
Key: CB-7375
URL: https://issues.apache.org/jira/browse/CB-7375
Project: Apache Cordova
Issue Type: Bug
Components: Plugin File
Affects Versions: 3.5.0
Reporter: Martin Gonzalez
Labels: file
Fix For: 3.6.0
Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt
Some of the changes made lately to file plugin with this commit:
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c
Are breaking changes to this plugin, affecting other platforms as android.
Running mobile spec after that specific commit, 4 file tests are failing
(test 125 -128).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114442#comment-14114442 ] ASF GitHub Bot commented on CB-7375: GitHub user martincgg opened a pull request: https://github.com/apache/cordova-plugin-file/pull/76 [CB-7375][Entry] set proper filesystem in Entry, when moveTo or copyTo When the native side it doesn't return any kind of value related directly related with the fileSystem, it has to be recreated after a copy, however, it makes perfect sense, that when the entry for the copied or moved file if there's no value in entry.fileSystem, it takes the filesystem property from the parent directory that it has been moved to or copied to. So instead of return a null object or take the previous filesystem(origin) from wherever location it was copied or moved from. It would be better take the parent filesystem name and recreate it. You can merge this pull request into a Git repository by running: $ git pull https://github.com/martincgg/cordova-plugin-file CB-7375 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/76.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #76 commit 84ea94a94e68c2f4ef5c28ec91338b5932f44610 Author: Martin Gonzalez martin.c.glez.g...@gmail.com Date: 2014-08-28T21:53:10Z [CB-7375][Entry] get proper filesystem in Entry When the native side it doesn't return any kind of value related directly with the fileSystem, it has to be recreated after a copy, however, it makes perfect sense that, when the entry for the copied or moved file if there's no value in entry.fileSystem, it takes the filesystem property from the parent directory that it has been moved to or copied to. So instead of return a null object or take the previous filesystem(origin) from whatever location it was copied from. It would be better take the parent filesystem name and recreate it. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114518#comment-14114518 ] ASF GitHub Bot commented on CB-7375: Github user martincgg commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/76#issuecomment-53815245 I've tested this over Android and WP8, it looks great. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114704#comment-14114704 ] ASF GitHub Bot commented on CB-7375: Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/76 Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114702#comment-14114702 ] ASF subversion and git services commented on CB-7375: - Commit 84ea94a94e68c2f4ef5c28ec91338b5932f44610 in cordova-plugin-file's branch refs/heads/master from [~martin.c.glez.glez] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=84ea94a ] [CB-7375][Entry] get proper filesystem in Entry When the native side it doesn't return any kind of value related directly with the fileSystem, it has to be recreated after a copy, however, it makes perfect sense that, when the entry for the copied or moved file if there's no value in entry.fileSystem, it takes the filesystem property from the parent directory that it has been moved to or copied to. So instead of return a null object or take the previous filesystem(origin) from whatever location it was copied from. It would be better take the parent filesystem name and recreate it. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114703#comment-14114703 ] ASF subversion and git services commented on CB-7375: - Commit 0f200a5d9ee529df116b92575351a1447c62970f in cordova-plugin-file's branch refs/heads/master from [~purplecabbage] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=0f200a5 ] Merge branch 'CB-7375' of https://github.com/martincgg/cordova-plugin-file Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14112233#comment-14112233 ] Martin Gonzalez commented on CB-7375: - On Android it looks good, however running the tests over Windows Phone, it adds 13 new fails. Specs failing: 9, 9.5, 10, 11, 15, 24, 82, 110, 116, 121, 122, 123, 124. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Assignee: Ian Clelland Labels: file Fix For: 3.6.0 Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[
https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14112252#comment-14112252
]
Ian Clelland commented on CB-7375:
--
Okay, the lesson here is that the code is fragile, and the conditions for it to
work are not well defined.
We can do one of two things here:
1. Add some more tests, to test the return from the exec call itself, to
validate that it is well-formed for the rest of the JavaScript code in Entry.js
2. Move some of the WP8 implementation into a separate file,
{{www/wp/Entry.js}} so that it can do what it needs to.
I feel like #1 is wrong -- that it's the wrong level to test things at, but I
suppose that the exec return value *is* an API surface in this case, since
there are multiple clients that need to work with it in an interoperable
fashion. #2 is also not very DRY, unless we can factor out just the call exec
and get something back part.
Investigate breaking changes at file plugin
---
Key: CB-7375
URL: https://issues.apache.org/jira/browse/CB-7375
Project: Apache Cordova
Issue Type: Bug
Components: Plugin File
Affects Versions: 3.5.0
Reporter: Martin Gonzalez
Assignee: Ian Clelland
Labels: file
Fix For: 3.6.0
Some of the changes made lately to file plugin with this commit:
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c
Are breaking changes to this plugin, affecting other platforms as android.
Running mobile spec after that specific commit, 4 file tests are failing
(test 125 -128).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[
https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14112278#comment-14112278
]
Ian Clelland commented on CB-7375:
--
The only change I made in resolveLocalFileSystemURL was to the filesystem name
detection code. Before Vladimir's changes, it was:
{code}
var fsName = entry.filesystemName || (entry.filesystem == window.PERSISTENT ?
'persistent' : 'temporary');
{code}
Vladimir changed it to
{code}
var fsName = (entry.filesystem entry.filesystem.name) || (entry.filesystem
== window.PERSISTENT ? 'persistent' : 'temporary');
{code}
For consistency with the code in Entry, I combined the two, and changed it to:
{code}
var fsName = entry.filesystemName || (entry.filesystem
entry.filesystem.name) || (entry.filesystem == window.PERSISTENT ? 'persistent'
: 'temporary');
{code}
The only way that I can see this breaking WP8 (or changing anything at all,
actually,) is if the {{filesystemName}} property is being set to something by
the {{resolveLocalFileSystemURI}} {{exec()}} call. It isn't (the string
filesystemName) doesn't seem to appear at all in the C# code, so I'm not sure
what's going on that's causing these failures. I suspect that
{{resolveLocalFileSystemURI}} is always failing now (the tests which expect
failure are generally passing) but I'd need to see the CI output to know for
sure.
Investigate breaking changes at file plugin
---
Key: CB-7375
URL: https://issues.apache.org/jira/browse/CB-7375
Project: Apache Cordova
Issue Type: Bug
Components: Plugin File
Affects Versions: 3.5.0
Reporter: Martin Gonzalez
Assignee: Ian Clelland
Labels: file
Fix For: 3.6.0
Some of the changes made lately to file plugin with this commit:
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c
Are breaking changes to this plugin, affecting other platforms as android.
Running mobile spec after that specific commit, 4 file tests are failing
(test 125 -128).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14112582#comment-14112582 ] Martin Gonzalez commented on CB-7375: - Yes, the attached jasmine report it's result of testing with dd51229, and yes, I have tested with 308690, and with that one those specs are not failing. I have to point out that I have tested with previous to 0ffb9698, I got 100% passed with android, and the same results on WP8 than using 308690. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Assignee: Ian Clelland Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14112610#comment-14112610 ] Ian Clelland commented on CB-7375: -- In that case, something else is causing the Entry's toURL() method to return something starting with // when it wasn't before. I'll keep looking. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Assignee: Ian Clelland Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14112637#comment-14112637 ] ASF subversion and git services commented on CB-7375: - Commit 99ade6161ba6d14aa6ea625c0d08b615614b3163 in cordova-plugin-file's branch refs/heads/master from [~iclelland] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=99ade61 ] CB-7375: Partial revert to resolve WP8 failures Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Assignee: Ian Clelland Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[
https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14112645#comment-14112645
]
Ian Clelland commented on CB-7375:
--
[~martin.c.glez.glez] -- can you test again with the latest master (99ade61)?
I've reverted the change to {{resolveLocalFileSystemURL}}, which doesn't cause
Android to fail, and may resolve the WP8 failures.
(I *think* that this might be reinstating a bug on Android and iOS, but even if
so, it's a but that we don't have tests for, so I'll try to write some tests
later to see if it's true.)
Investigate breaking changes at file plugin
---
Key: CB-7375
URL: https://issues.apache.org/jira/browse/CB-7375
Project: Apache Cordova
Issue Type: Bug
Components: Plugin File
Affects Versions: 3.5.0
Reporter: Martin Gonzalez
Assignee: Ian Clelland
Labels: file
Fix For: 3.6.0
Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt
Some of the changes made lately to file plugin with this commit:
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c
Are breaking changes to this plugin, affecting other platforms as android.
Running mobile spec after that specific commit, 4 file tests are failing
(test 125 -128).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14112728#comment-14112728 ] Martin Gonzalez commented on CB-7375: - Ok, I'll test it out, should I test it over android or you have already done it? Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Assignee: Ian Clelland Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14112761#comment-14112761 ] Ian Clelland commented on CB-7375: -- I've tested that all tests are passing on Android. Of course, if you want to double-check that, I won't stop you ;) Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Assignee: Ian Clelland Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14112781#comment-14112781 ] Martin Gonzalez commented on CB-7375: - I've got the same number, + 13 failed tests with the latest commit on WP8. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Assignee: Ian Clelland Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[
https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14110697#comment-14110697
]
Ian Clelland commented on CB-7375:
--
To make this work for both Android/iOS *and* WP8, we can do this:
When JavaScript code is expecting an Entry structure to be returned from an
exec() call, the structure returned should include these fields:
{code}
isFile: Boolean
isDirectory: Boolean
name: String name of the file
fullPath: String path to this file, relative to the filesystem root
nativeURL: [Optional] String URL to this file that can be used natively by
the webview (Important for video src attributes on Android)
filesystemName: [Optional] String name of filesystem, eg persistent,
temporary, cache
filesystem: [Optional] Actual FileSystem object in which this file can be
found
{code}
Only one of {{filesystemName}} or {{filesystem}} should be provided. If
{{filesystemName}} is provided, then the JavaScript should construct an
appropriate {{FileSystem}} object. If no {{filesystemName}} is provided, but
{{filesystem}} is, then {{filesystem}} should be used as the {{FileSystem}}
object for the new {{Entry}}.
I suggest that filesystemName, if provided, should take precedence, since it is
not part of the standard, and that makes it more difficult to include it
accidentally in the exec response.
Then to build a filesystem object for an Entry object, the code would look like
this:
{code}
// Set a default
var filesystem = some default filesystem to use;
// Find an explicit name, if one was provided
var newFSName = entry.filesystemName || (entry.filesystem
entry.filesystem.name);
// Use the name *or* the provided FS *or* the default fs
var fs = (newFSName new FileSystem(newFSName, { name: , fullPath: / }))
|| entry.filesystem || filesystem;
{code}
Investigate breaking changes at file plugin
---
Key: CB-7375
URL: https://issues.apache.org/jira/browse/CB-7375
Project: Apache Cordova
Issue Type: Bug
Components: Plugin File
Affects Versions: 3.5.0
Reporter: Martin Gonzalez
Assignee: Ian Clelland
Labels: file
Fix For: 3.6.0
Some of the changes made lately to file plugin with this commit:
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c
Are breaking changes to this plugin, affecting other platforms as android.
Running mobile spec after that specific commit, 4 file tests are failing
(test 125 -128).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14110801#comment-14110801 ] ASF subversion and git services commented on CB-7375: - Commit dd51229d9bd1978e8e327396fb449a88b0f1b064 in cordova-plugin-file's branch refs/heads/master from [~iclelland] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=dd51229 ] CB-7375: CB-6148: Ensure that return values from copy and move operations reference the correct filesystem Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Assignee: Ian Clelland Labels: file Fix For: 3.6.0 Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14109995#comment-14109995 ] Martin Gonzalez commented on CB-7375: - The reason of this fails are the references to the filesystem on the entry object: 125 Expected -- FileSystem: persistent ; Returned :temporary 126 Expected -- FileSystem: temporary ; Returned :persistent 127 Expected -- FileSystem: persistent ; Returned :temporary 128 Expected -- FileSystem: temporary ; Returned :persistent This applies to android platform. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14110045#comment-14110045 ] Ian Clelland commented on CB-7375: -- The File spec actually defines a circular reference in some of its data structures, which is the reason for the Android code being the way it is: A FileEntry or DirectoryEntry object contains a .filesystem property, which is a FileSystem. A FileSystem contains a .root property, which is a DirectoryEntry. That then contains a FileSystem again, so it all gets circular very quickly. Since we can't serialize that into JSON to return it from the native side of the bridge, instead we return a FileEntry structure with a file system name, rather than an actual object. Then, on the JavaScript side, we reconstruct the FileSystem object based on its name, and attach that to the Entry object. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Assignee: Ian Clelland Labels: file Fix For: 3.6.0 Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
