[jira] [Commented] (CB-13507) git+https or git+ssh fails when trying to install

2018-02-13 Thread Hector (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362034#comment-16362034
 ] 

Hector commented on CB-13507:
-

Solved for me after updating to cordova@8.0.0

> git+https or git+ssh fails when trying to install
> -
>
> Key: CB-13507
> URL: https://issues.apache.org/jira/browse/CB-13507
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: AllPlatforms
>Affects Versions: 7.0.2
> Environment: I am selecting 7.0.2 since it's the closest but I am 
> running cordova 7.1.0
> OS: Mac OS X Sierra.
> Although I don't think it has anything to do with cordova-ios and 
> cordova-android, my platform versions are: 
> - android 6.3.0
> - ios 4.5.2
>Reporter: Pablo Caselas
>Priority: Major
> Fix For: 7.0.2
>
>
> I start with adding plugin dependencies with https://.. on package.json 
> (no plugin references on config.xml) and no platforms or plugins installed 
> then I run "cordova platform ios".
> It installs the plugins without any problem, but changes config.xml and 
> package.json plugin references from https to git+https, and ssh to git+ssh.
> Failed to restore plugin "cordova-plugin-document-viewer" from config.xml. 
> You might need to try adding it again. Error: Failed to fetch plugin 
> git+https://github.com/kas84/cordova-plugin-document-viewer.git via registry



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12193) cordova.js crashes windows app if there is no CoreWindow

2018-02-13 Thread Christian Campo (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362175#comment-16362175
 ] 

Christian Campo commented on CB-12193:
--

I recently tried to run Cordova embedded in a XAML-WebView on Windows 10. The 
check that was introduced by this Jira ticket CB-12193

"Windows.UI.ViewManagement.ApplicationView.getForCurrentView();"

does work and set the isCoreWindowAvailable to true; (I believe it is supposed 
to run in an Exception when run as Embedded WebView)

HOWEVER the next call 

Windows.UI.WebUI.WebUIApplication.addEventListener("resuming", resumingHandler, 
false);

is failing with missing permissions.

What is right procedure ? Reopen this ticket or open a new ticket since this is 
a regression ?

> cordova.js crashes windows app if there is no CoreWindow
> 
>
> Key: CB-12193
> URL: https://issues.apache.org/jira/browse/CB-12193
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
> Environment: Windows 10
>Reporter: venkata guddanti
>Priority: Critical
>  Labels: reproduced, triaged, windows
> Attachments: CordovaTest.zip
>
>
> The back button support in cordova.js crashes windows app. In particular the 
> following line crashes:
> var navigationManager = 
> Windows.UI.Core.SystemNavigationManager.getForCurrentView();
> Putting try catch around it does not help. It crashes deep in the bowels of 
> native code. So I believe there should a fix similar to the following code in 
> WinJS base.js:
> // If getForCurrentView fails, it is an indication that we are running in 
> a WebView without
> // a CoreWindow where some WinRT APIs are not available. In this case, we 
> just treat it as
> // if no WinRT APIs are available.
> var isCoreWindowAvailable = false;
> try{
>   _Global.Windows.UI.ViewManagement.InputPane.getForCurrentView();
>   isCoreWindowAvailable = true;
> }
> catch (e){
> }
> You can then skip setting up the back button handler if there is no 
> CoreWindow:
> if (isCoreWindowAvailable)
>   {
> var navigationManager = 
> Windows.UI.Core.SystemNavigationManager.getForCurrentView();
> ...
> }
> I am aware that Cordova Windows 10 is not supported in a WebView (i.e. there 
> is no CoreWindow). But WinJS and majority of Windows APIs work. Cordova 4.0.0 
> used to work as well, since there was no back button support in it. Plugins 
> that need CoreWindow (i.e. plugins that show native UI) like Camera etc have 
> issues without it. We have a framework where we proxy these plugins through 
> the main application Window (similar to iOS and Android).
> Please do consider this and incorporate a fix in cordova for Windows 10



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12193) cordova.js crashes windows app if there is no CoreWindow

2018-02-13 Thread Jan Piotrowski (Sujan) (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362287#comment-16362287
 ] 

Jan Piotrowski (Sujan) commented on CB-12193:
-

Has this functionality already be released with thea release of 
cordova-windows? 
(The second to last comment indicates so)
Then definitely a new issue, but link to this one and the PR that added the 
code so it is easy to follow where this is coming from.

> cordova.js crashes windows app if there is no CoreWindow
> 
>
> Key: CB-12193
> URL: https://issues.apache.org/jira/browse/CB-12193
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
> Environment: Windows 10
>Reporter: venkata guddanti
>Priority: Critical
>  Labels: reproduced, triaged, windows
> Attachments: CordovaTest.zip
>
>
> The back button support in cordova.js crashes windows app. In particular the 
> following line crashes:
> var navigationManager = 
> Windows.UI.Core.SystemNavigationManager.getForCurrentView();
> Putting try catch around it does not help. It crashes deep in the bowels of 
> native code. So I believe there should a fix similar to the following code in 
> WinJS base.js:
> // If getForCurrentView fails, it is an indication that we are running in 
> a WebView without
> // a CoreWindow where some WinRT APIs are not available. In this case, we 
> just treat it as
> // if no WinRT APIs are available.
> var isCoreWindowAvailable = false;
> try{
>   _Global.Windows.UI.ViewManagement.InputPane.getForCurrentView();
>   isCoreWindowAvailable = true;
> }
> catch (e){
> }
> You can then skip setting up the back button handler if there is no 
> CoreWindow:
> if (isCoreWindowAvailable)
>   {
> var navigationManager = 
> Windows.UI.Core.SystemNavigationManager.getForCurrentView();
> ...
> }
> I am aware that Cordova Windows 10 is not supported in a WebView (i.e. there 
> is no CoreWindow). But WinJS and majority of Windows APIs work. Cordova 4.0.0 
> used to work as well, since there was no back button support in it. Plugins 
> that need CoreWindow (i.e. plugins that show native UI) like Camera etc have 
> issues without it. We have a framework where we proxy these plugins through 
> the main application Window (similar to iOS and Android).
> Please do consider this and incorporate a fix in cordova for Windows 10



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12074) Cookies are ignored on first application execution

2018-02-13 Thread Mayank Kumar (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362355#comment-16362355
 ] 

Mayank Kumar commented on CB-12074:
---

We are also not able to use WKWebView in our app due to this issue. Really a 
showstopper :(

> Cookies are ignored on first application execution
> --
>
> Key: CB-12074
> URL: https://issues.apache.org/jira/browse/CB-12074
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-wkwebview-engine
> Environment: Cordova 5.4.0, iOS 9.3.5
>Reporter: Maxim
>Assignee: Shazron Abdullah
>Priority: Major
>  Labels: wkwebview-known-issues
>
> Our application authenticates to the server. The server sets a 'JSESSIONID' 
> cookie. The cookie is used by the server for session management. 
> The issue is WKWebView does not send this cookie back to the server on 
> subsequent requests. However, this only happens on first execution of the 
> application, after its installation. Once the application closed and 
> re-opened, the cookies are properly sent and authentication completes 
> successfully. 
> The problematic behavior is consistent, and was observed on several devices. 
> On the other hand, there are no such issues with UIWebView. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12808) 'Error: AppPackages doesn't exists` when building for windows@5.0.0

2018-02-13 Thread Jan Piotrowski (Sujan) (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362417#comment-16362417
 ] 

Jan Piotrowski (Sujan) commented on CB-12808:
-

And now I know how to fix it:
https://forum.ionicframework.com/t/building-windows-10-app/92416/9
The important bit is to set the `VSINSTALLDIR` ENV var to the path with 
`Community`. This helps cordova-windows 5.0.0 find the correct MSBuild to build 
your app. 
(Running the `build` command with `--verbose` can also show which one it uses - 
if the folder contains `BuildTools` it is using the wrong one)

Can someone confirm please?

> 'Error: AppPackages doesn't exists` when building for windows@5.0.0
> ---
>
> Key: CB-12808
> URL: https://issues.apache.org/jira/browse/CB-12808
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
> Environment: See VisualStudioCommunity-Specs attachment.
> Windows 10 Home (see Windows10Home-About attachment)
> Microsoft Visual Studio Community 2017 Version 15.2 (26430.4) Release
> Windows 10 SDK 10.0.15063.137
> cordova@6.5.0 and cordova@7.0.0
>Reporter: Shazron Abdullah
>Priority: Major
> Attachments: VisualStudioCommunity-Specs.txt, Windows10Home-About.PNG
>
>
> See Environment field.
> 1. Install Windows 10 Home with latest updates as of May 12 2017
> 2. Install Visual Studio Community Edition with latest updates as of May 12 
> 2017
> 3. Install Windows 10 SDK 10.0.15063.137
> 4. Add to your environment variables 'VSINSTALLDIR` value: {{C:\Program Files 
> (x86)\Microsoft Visual Studio\2017\Community\}}
> Repro:
> {code}
> $ cordova create foo
> $ cd foo
> # edit config.xml to add these two tags below (without the hashes):
> # 
> # 
> $ cordova platform add windows
> Adding windows project...
> Creating Cordova Windows Project:
> Path: platforms\windows
> Namespace: io.cordova.hellocordova
> Name: HelloCordova
> Windows project created with cordova-windows@5.0.0
> Installing "cordova-plugin-whitelist" for windows
> $ cordova build windows
> Building project: 
> C:\Users\shazron\Desktop\foo\platforms\windows\CordovaApp.Windows10.jsproj
> Configuration : debug
> Platform  : anycpu
>   Patching 10 in prebuild event...
>   Injected base.js reference to the /www/index.html
>   Removing /( 
> *)(
>   \s*<\/script>)(\s*)/ from /www/index.html
>   Removing /( 
> *)(\s*<\/script>)(\s*)/ from /www/index.html
> Error: AppPackages doesn't exists
> {code}
> The error originates in the platform code, here:
> https://github.com/apache/cordova-windows/blob/7fe4c21229815d216a985b114a4db5f01b5e5169/template/cordova/lib/package.js#L32-L36



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-13873) AppVeyor CI exists twice: ApacheSoftwareFoundation vs. Humbedooh

2018-02-13 Thread Jan Piotrowski (Sujan) (JIRA)
Jan Piotrowski (Sujan) created CB-13873:
---

 Summary: AppVeyor CI exists twice: ApacheSoftwareFoundation vs. 
Humbedooh
 Key: CB-13873
 URL: https://issues.apache.org/jira/browse/CB-13873
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-windows
Reporter: Jan Piotrowski (Sujan)
Assignee: Jesse MacFadyen


https://ci.appveyor.com/project/ApacheSoftwareFoundation/cordova-windows/history
vs.
https://ci.appveyor.com/project/Humbedooh/cordova-windows/history

This might be responsible for the long "Queued" state as Appveyor maybe only 
runs one build per repository at the same time.

Who do these accounts belong to?
How are these builds triggered?
What is configured in the Github repo?
What should be done?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12581) Windows Platform Guide Needs Updating

2018-02-13 Thread Jan Piotrowski (Sujan) (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362443#comment-16362443
 ] 

Jan Piotrowski (Sujan) commented on CB-12581:
-

The mentions of Visual Studio 2015 should indeed be updated to include "Update 
3".

> Windows Platform Guide Needs Updating
> -
>
> Key: CB-12581
> URL: https://issues.apache.org/jira/browse/CB-12581
> Project: Apache Cordova
>  Issue Type: Task
>  Components: cordova-docs, cordova-windows
>Reporter: grat bodkin
>Priority: Major
>  Labels: backlog, windows
>
> The windows platform guide in the cordova documentation fails to mention 
> anything about the requirements for Visual Studio. 
> After installing cordova via npm, as well as Visual Studio 2015 Express from 
> Microsoft's website, cordova windows applications will not build due to 
> project compatibility errors.
> There is little to no documentation online about how to get around this 
> problem.
> Note, the solution is to make SURE that Visual Studio 2015 Update 3 is 
> installed.  However, there are known issues with installing update 3 to an 
> existing installation (see: 
> https://msdn.microsoft.com/en-us/vs-knownissues/vs2015-update3).  Ultimately, 
> if users are developing with Visual Studio 2015, the easiest work around is 
> to install VS2015 using the full product installer called  "Visual Studio 
> 2015 with Update 3".
> There should probably be something in the windows platform guide about this 
> so that people can actually follow the rest of the platform guide, and build 
> their projects successfully.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11965) Remove WinJS dependency

2018-02-13 Thread Jan Piotrowski (Sujan) (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362450#comment-16362450
 ] 

Jan Piotrowski (Sujan) commented on CB-11965:
-

Hi Philipp, thanks for that suggestion - "reduce package deploy size and 
runtime overhead" and "get rid of the (discontinued) ... library" sounds very 
good.

Searching for "WinJS" in the code base I get quite a lot of hits, so this is 
definitely a change that would have to be properly tested.

Would this apply to both Win8.1 and Win10 (UWP) projects?
Would you be up for tackling this and maybe creating a PR with the necessary 
changes?

> Remove WinJS dependency
> ---
>
> Key: CB-11965
> URL: https://issues.apache.org/jira/browse/CB-11965
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-windows
>Reporter: Philipp Kursawe
>Priority: Minor
>
> As far as I can see cordova uses WinJS only for managing life-cycle events, 
> which can be easily handled without WinJS using native WinRT.
> I propose to get rid of the (discontinued) WinJS library dependency to reduce 
> package deploy size and runtime overhead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11681) APPX1901 warning when building empty windows project from VS

2018-02-13 Thread Jan Piotrowski (Sujan) (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362454#comment-16362454
 ] 

Jan Piotrowski (Sujan) commented on CB-11681:
-

Oh I saw this as well.

Do you have any idea how to fix it?

> APPX1901 warning when building empty windows project from VS
> 
>
> Key: CB-11681
> URL: https://issues.apache.org/jira/browse/CB-11681
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 4.4.2
>Reporter: Vladimir Kotikov
>Priority: Minor
>  Labels: triaged, warning, windows
> Fix For: 4.4.3
>
>
> The following warning is generated:
> {noformat}
> 1>-- Build started: Project: CordovaApp.Windows10, Configuration: Debug 
> ARM --
> 1>C:\Program Files 
> (x86)\MSBuild\Microsoft\VisualStudio\v14.0\AppxPackage\Microsoft.AppXPackage.Targets(4519,5):
>  warning APPX1901: The DefaultLanguage property is either missing from the 
> project file or does not have a value. The fallback language is set to the 
> Visual Studio language: en-US.
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11606) Cordova.js not including the WinJS Base.js file correctly

2018-02-13 Thread Jan Piotrowski (Sujan) (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362461#comment-16362461
 ] 

Jan Piotrowski (Sujan) commented on CB-11606:
-

Thanks [~jnmoore]. Is this something that should be changed in the codebase for 
all users to make this more stable?
Would you be up to creating a PR on Github with the changes in the necessary 
places?

> Cordova.js not including the WinJS Base.js file correctly
> -
>
> Key: CB-11606
> URL: https://issues.apache.org/jira/browse/CB-11606
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-js, cordova-windows
>Reporter: linda zhong
>Priority: Minor
>
> If I remote debug to x64 the app side loads through the debugger. I can click 
> around, do everything, no problem.
> BUT once I disconnect the debug process, and then start the app on the 
> surface, it flashes open, then closes... the error from that closing seems to 
> be related to Windows not being defined( i assume from the base) and then 
> creating DB connections off of that.
> I thought maybe it was a change in the debugging setup, so I went through the 
> whole process of side loading it, and the same thing happens. 
> I traced it down to Cordova not including the Base.js file correctly, there 
> seem to be pathing issues, but only when i run it on the surface, without the 
> debugger... so I'm confused.
> Of course, since i side loaded it onto the x64 surface, I thought, I could 
> sideload the app onto the Surface RT, which i did, and guess what, it works 
> fine there. 
> So why would the same app, side loaded on RT work, but not on x64.
> Is there something different in the Base file its trying to use, maybe it 
> exists for one but not the other?
> If I run the index.html in chrome, i can see more errors, so debugging with 
> that I see a few more things.
> Here is the code in the cordova.js file thats messing up the include (line 
> 1449 in the cordova js i have)
> {noformat}
> if (!window.WinJS) {
>     var scriptElem = document.createElement("script");
>     if (navigator.appVersion.indexOf('MSAppHost/3.0') !== -1) {
>     // Windows 10 UWP
>     scriptElem.src = '/www/WinJS/js/base.js';
>     } else if (navigator.appVersion.indexOf("Windows Phone 8.1;") !== 
> -1) {
>     // windows phone 8.1 + Mobile IE 11
>     scriptElem.src = "//Microsoft.Phone.WinJS.2.1/js/base.js";
>     } else if (navigator.appVersion.indexOf("MSAppHost/2.0;") !== -1) 
> {
>     // windows 8.1 + IE 11
>     scriptElem.src = "//Microsoft.WinJS.2.0/js/base.js";
>     } else {
>     // windows 8.0 + IE 10
>     scriptElem.src = "//Microsoft.WinJS.1.0/js/base.js";
>     }
>     scriptElem.addEventListener("load", onWinJSReady);
>     document.head.appendChild(scriptElem);
>     }
> {noformat}
> The x64 is firing this include - the else
>   scriptElem.src = "//Microsoft.WinJS.1.0/js/base.js";
> When I inspect it loading locally on my machine, its using
> 
> If i hard code a script tag to the WinJS/js/base.js that error goes away from 
> the console, but then i am still seeing the error for Windows. is not defined.
> Now, with the base.js fixed, its not showing errors in the windows events 
> log, but its still crashing on start up.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-10725) Cordova windows target emulator deployment error

2018-02-13 Thread Jan Piotrowski (Sujan) (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Piotrowski (Sujan) updated CB-10725:

Component/s: (was: cordova-windows)
 cordova-win8

> Cordova windows target emulator deployment error
> 
>
> Key: CB-10725
> URL: https://issues.apache.org/jira/browse/CB-10725
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-win8
>Reporter: Manojoy Ganguly
>Priority: Major
>
> I created a default Cordova app for windows following this page
> https://cordova.apache.org/docs/en/latest/guide/platforms/win8/index.html
> While I deploy the app using command "cordova run windows -- --phone", it 
> works fine and opens in default emulator.
> But when I try to deploy this targeting a particular emulator using command 
> "cordova run windows -target="Emulator 8.1 1080P 6 inch" - --phone" it fails 
> and  gives me an error saying "specified device not found".
> Although when I list my devices using command "cordova run windows --list", 
> it shows the emulator device.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-9994) Do not create .appxupload packages for Windows builds

2018-02-13 Thread Jan Piotrowski (Sujan) (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-9994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362464#comment-16362464
 ] 

Jan Piotrowski (Sujan) commented on CB-9994:


[~pke] Adding an additional CLI task is not practical here. Normally this is 
done by differentiating between a "debug" and a "release" build in Cordova. 
Could this also be a solution for this problem?

> Do not create .appxupload packages for Windows builds
> -
>
> Key: CB-9994
> URL: https://issues.apache.org/jira/browse/CB-9994
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-windows
> Environment: Windows Store Apps
>Reporter: Philipp Kursawe
>Assignee: Jesse MacFadyen
>Priority: Major
>  Labels: build, features, windows
>
> The CLI currently generates Windows Store Apps in a different way than 
> VisualStudio would do it.
> In Visual Studio no appx/appxupload packages are built in the normal build. 
> Instead VS copies/compiles all the files to a bld folder and deploys the app 
> from that folder. No signing cert required, dev cert is enough for that. It's 
> also a much faster build that way. If you only change one js files, the build 
> is basically instant, as well as the deployment because Windows does a binary 
> diff package update in the system. This is much faster than the current way 
> CLI builds Windows targets.
> There should be a CLI task "publish" to create the .appxupload package, they 
> should not be created on every build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-8982) Adding tag support to config.xml for Windows 8

2018-02-13 Thread Jan Piotrowski (Sujan) (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-8982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Piotrowski (Sujan) updated CB-8982:
---
Component/s: (was: cordova-windows)
 cordova-win8

> Adding  tag support to config.xml for Windows 8
> --
>
> Key: CB-8982
> URL: https://issues.apache.org/jira/browse/CB-8982
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-cli, cordova-lib, cordova-win8
>Affects Versions: Master
> Environment: Windows 8
>Reporter: Karen Tran
>Assignee: Karen Tran
>Priority: Major
>
> Based on the parent task, create a new image element tag to copy the image 
> from src to the correct directory with the given name.
> 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-7932) Windows 8 Misc Test Load a page with iframes, also with query param

2018-02-13 Thread Jan Piotrowski (Sujan) (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Piotrowski (Sujan) updated CB-7932:
---
Component/s: (was: cordova-windows)
 cordova-win8 (DEPRECATED)

> Windows 8 Misc Test Load a page with iframes, also with query param
> ---
>
> Key: CB-7932
> URL: https://issues.apache.org/jira/browse/CB-7932
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-mobile-spec, cordova-win8 (DEPRECATED)
>Affects Versions: 3.6.3
> Environment: Windows 8 (Visual Studio and RT device)
>Reporter: Angela Fowler
>Assignee: Jesse MacFadyen
>Priority: Minor
> Attachments: manifest.png
>
>
> The iframes are empty. 
> The back button does not work.
> APPHOST9625: Unable to navigate to: 'http://apache.org/'. An iframe attempted 
> to navigate to a URI that is not included in the ApplicationContentUriRules 
> for this app. Use a x-ms-webview element to view the URI instead, or add the 
> URI to the ApplicationContentUriRules section of the package manifest so that 
> the iframe can navigate to it. (In Visual Studio, add this URI to the Content 
> URIs tab of the Manifest Designer.)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-7878) Windows 8 Mobile Spec Plugin Results Misleading Pass Rates

2018-02-13 Thread Jan Piotrowski (Sujan) (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Piotrowski (Sujan) updated CB-7878:
---
Component/s: (was: cordova-windows)
 cordova-win8 (DEPRECATED)

> Windows 8 Mobile Spec Plugin Results Misleading Pass Rates
> --
>
> Key: CB-7878
> URL: https://issues.apache.org/jira/browse/CB-7878
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-mobile-spec, cordova-win8 (DEPRECATED)
>Affects Versions: 3.6.3
> Environment: Windows 8
>Reporter: Angela Fowler
>Assignee: Jesse MacFadyen
>Priority: Minor
> Attachments: Windows8CommandProxyMap.png
>
>
> A number of tests pass even though a plugin is not supported or only 
> partially supported.
> For battery-status 11 of 11 tests pass but battery-status is not supported.
> For vibration 2 of 2 pass.
> For globalization 14 of 44 pass.
> For contacts 19 of 26 pass but save is not supported



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13871) cordova requirements should be automatically tested (on all platforms)

2018-02-13 Thread Jan Piotrowski (Sujan) (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Piotrowski (Sujan) updated CB-13871:

Component/s: (was: cordova-windows, cordova-ios, cordova-android)
 cordova-windows
 cordova-ios
 cordova-android

> cordova requirements should be automatically tested (on all platforms)
> --
>
> Key: CB-13871
> URL: https://issues.apache.org/jira/browse/CB-13871
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android, cordova-ios, cordova-windows
>Reporter: Chris Brody
>Priority: Major
>
> Help avoid issues such as CB-13870 ({{cordova requirements}} broken on 
> cordova-windows since cordova-windows@5.0.0)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Assigned] (CB-13870) `cordova requirements` is broken since change to default=UAP and with modern tooling

2018-02-13 Thread Jan Piotrowski (Sujan) (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Piotrowski (Sujan) reassigned CB-13870:
---

Assignee: Jan Piotrowski (Sujan)  (was: Jesse MacFadyen)

> `cordova requirements` is broken since change to default=UAP and with modern 
> tooling
> 
>
> Key: CB-13870
> URL: https://issues.apache.org/jira/browse/CB-13870
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Blocker
>
> check_reqs.js 
> 1. doesn't know about "UAP", only "10.0"
> 2. doesn't know about VS2017 (so error messages are wrong)
> 3. doesn't know about current MSBuild tooling (so doesn't recognize it at all)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0

2018-02-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362472#comment-16362472
 ] 

ASF GitHub Bot commented on CB-13861:
-

janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365297666
 
 
   The error message you posted contains `VisualStudio\v14.0` which is Visual 
Studio 2015. https://issues.apache.org/jira/browse/CB-13861 specifically 
mentions Visual Studio 2017. What is the connection here?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update TargetPlatformVersion to 10.0.10586.0
> 
>
> Key: CB-13861
> URL: https://issues.apache.org/jira/browse/CB-13861
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: Jesse MacFadyen
>Assignee: Jesse MacFadyen
>Priority: Major
>
> For VS2017 Windows 10 projects we need to update TargetPlatformVersion to 
> 10.0.10586.0
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0

2018-02-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362474#comment-16362474
 ] 

ASF GitHub Bot commented on CB-13861:
-

janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365297666
 
 
   The error message you posted contains `VisualStudio\v14.0` which is Visual 
Studio 2015. https://issues.apache.org/jira/browse/CB-13861 specifically 
mentions Visual Studio 2017. What is the connection here? Do you also have the 
same problem on a machine with VS17?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update TargetPlatformVersion to 10.0.10586.0
> 
>
> Key: CB-13861
> URL: https://issues.apache.org/jira/browse/CB-13861
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: Jesse MacFadyen
>Assignee: Jesse MacFadyen
>Priority: Major
>
> For VS2017 Windows 10 projects we need to update TargetPlatformVersion to 
> 10.0.10586.0
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13203) Windows UWP shared Local Folder being removed on app update

2018-02-13 Thread Jan Piotrowski (Sujan) (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Piotrowski (Sujan) updated CB-13203:

Summary: Windows UWP shared Local Folder being removed on app update  (was: 
Windows UWP shared Local Folder being removed)

> Windows UWP shared Local Folder being removed on app update
> ---
>
> Key: CB-13203
> URL: https://issues.apache.org/jira/browse/CB-13203
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 7.0.1
> Environment: When running on the Windows 10 platform
>Reporter: Jon Hoffman
>Assignee: Jesse MacFadyen
>Priority: Critical
>  Labels: cordova-7.0.1, data-corruption, data-integrity, 
> data-loss, windows-universal
>
> We are writing an application using Ionic 2 for Windows 10. The application 
> will need to share data between different users on the same machine therefore 
> we are using the shared local folder to save the data to as described in the 
> "Using Shared Local" section of this page: 
> https://blogs.windows.com/buildingapps/2016/05/24/sharing-your-local-app-data
> This method works great and we are able to write information to the shared 
> local folder however when the application updates, all of the files in the 
> shared local folder are removed.  I tested this by updating the 
> Cordova-Sqlite-Storage plugin to use the shared local folder and also with a 
> proof of concept app 
> (https://github.com/hoffmanjon/Cordova_Windows_UWP_Shared_Local_Folder3 , 
> https://github.com/hoffmanjon/Cordova_Windows_UWP_Shared_Local_Folder_plugin).
>   I did create a native c# application to see if we had the same behavior 
> when we updated a native application. When we updated the native app the 
> shared local folder was not removed therefore this is an issue specific to 
> the hybrid application.
> I put my proof of concept application that simply writes a text file to the 
> shared local folder and the application local folder that can be used to see 
> how the shared local folder is removed when we update the app. The repository 
> is located here: 
> https://github.com/hoffmanjon/Cordova_Windows_UWP_Shared_Local_Folder and 
> includes a windows plugin to write to the shared local folder. 
> You will need to set a group policy to get the shared local folders working. 
> In the in the "Using Shared Local" section of this page: 
> https://blogs.windows.com/buildingapps/2016/05/24/sharing-your-local-app-data 
> it describes how to change the policy and which one to change.
> I have updated to Cordova 7.0.1 and built the proof of concept app to see if 
> we have the same issue as describe with version 6.5 
> (https://issues.apache.org/jira/browse/CB-12928).  After updating the 
> application the shared local folder is removed therefore the same issue 
> exists with Cordova 7.0.1.
> --Edited to add a new repository for the proof of concept app.  The 
> repository also has detailed instructions on how the app was built and how to 
> reproduce the issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13203) Windows UWP shared Local Folder being removed on app update

2018-02-13 Thread Jan Piotrowski (Sujan) (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Piotrowski (Sujan) updated CB-13203:

Description: 
We are writing an application using Ionic 2 for Windows 10. The application 
will need to share data between different users on the same machine therefore 
we are using the shared local folder to save the data to as described in the 
"Using Shared Local" section of this page: 
https://blogs.windows.com/buildingapps/2016/05/24/sharing-your-local-app-data 
This method works great and we are able to write information to the shared 
local folder however when the application updates, all of the files in the 
shared local folder are removed. 

I tested this by updating the Cordova-Sqlite-Storage plugin to use the shared 
local folder and also with a proof of concept app 
(https://github.com/hoffmanjon/Cordova_Windows_UWP_Shared_Local_Folder3 , 
https://github.com/hoffmanjon/Cordova_Windows_UWP_Shared_Local_Folder_plugin). 

I did create a native c# application to see if we had the same behavior when we 
updated a native application. When we updated the native app the shared local 
folder was not removed therefore this is an issue specific to the hybrid 
application.

I put my proof of concept application that simply writes a text file to the 
shared local folder and the application local folder that can be used to see 
how the shared local folder is removed when we update the app. The repository 
is located here: 
https://github.com/hoffmanjon/Cordova_Windows_UWP_Shared_Local_Folder and 
includes a windows plugin to write to the shared local folder. 

You will need to set a group policy to get the shared local folders working. In 
the "Using Shared Local" section of this page: 
https://blogs.windows.com/buildingapps/2016/05/24/sharing-your-local-app-data 
it describes how to change the policy and which one to change.

I have updated to Cordova 7.0.1 and built the proof of concept app to see if we 
have the same issue as describe with version 6.5 
(https://issues.apache.org/jira/browse/CB-12928).  After updating the 
application the shared local folder is removed therefore the same issue exists 
with Cordova 7.0.1.

  was:
We are writing an application using Ionic 2 for Windows 10. The application 
will need to share data between different users on the same machine therefore 
we are using the shared local folder to save the data to as described in the 
"Using Shared Local" section of this page: 
https://blogs.windows.com/buildingapps/2016/05/24/sharing-your-local-app-data

This method works great and we are able to write information to the shared 
local folder however when the application updates, all of the files in the 
shared local folder are removed.  I tested this by updating the 
Cordova-Sqlite-Storage plugin to use the shared local folder and also with a 
proof of concept app 
(https://github.com/hoffmanjon/Cordova_Windows_UWP_Shared_Local_Folder3 , 
https://github.com/hoffmanjon/Cordova_Windows_UWP_Shared_Local_Folder_plugin).  
I did create a native c# application to see if we had the same behavior when we 
updated a native application. When we updated the native app the shared local 
folder was not removed therefore this is an issue specific to the hybrid 
application.

I put my proof of concept application that simply writes a text file to the 
shared local folder and the application local folder that can be used to see 
how the shared local folder is removed when we update the app. The repository 
is located here: 
https://github.com/hoffmanjon/Cordova_Windows_UWP_Shared_Local_Folder and 
includes a windows plugin to write to the shared local folder. 

You will need to set a group policy to get the shared local folders working. In 
the in the "Using Shared Local" section of this page: 
https://blogs.windows.com/buildingapps/2016/05/24/sharing-your-local-app-data 
it describes how to change the policy and which one to change.
I have updated to Cordova 7.0.1 and built the proof of concept app to see if we 
have the same issue as describe with version 6.5 
(https://issues.apache.org/jira/browse/CB-12928).  After updating the 
application the shared local folder is removed therefore the same issue exists 
with Cordova 7.0.1.

--Edited to add a new repository for the proof of concept app.  The repository 
also has detailed instructions on how the app was built and how to reproduce 
the issue.



> Windows UWP shared Local Folder being removed on app update
> ---
>
> Key: CB-13203
> URL: https://issues.apache.org/jira/browse/CB-13203
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 5.0.0
> Environment: When running on the Windows 10 platform
>Reporter: Jon Hoffman
>Assignee: Jesse MacFadyen

[jira] [Updated] (CB-13203) Windows UWP shared Local Folder being removed on app update

2018-02-13 Thread Jan Piotrowski (Sujan) (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Piotrowski (Sujan) updated CB-13203:

Affects Version/s: (was: 7.0.1)
   5.0.0

> Windows UWP shared Local Folder being removed on app update
> ---
>
> Key: CB-13203
> URL: https://issues.apache.org/jira/browse/CB-13203
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 5.0.0
> Environment: When running on the Windows 10 platform
>Reporter: Jon Hoffman
>Assignee: Jesse MacFadyen
>Priority: Critical
>  Labels: cordova-7.0.1, data-corruption, data-integrity, 
> data-loss, windows-universal
>
> We are writing an application using Ionic 2 for Windows 10. The application 
> will need to share data between different users on the same machine therefore 
> we are using the shared local folder to save the data to as described in the 
> "Using Shared Local" section of this page: 
> https://blogs.windows.com/buildingapps/2016/05/24/sharing-your-local-app-data 
> This method works great and we are able to write information to the shared 
> local folder however when the application updates, all of the files in the 
> shared local folder are removed. 
> I tested this by updating the Cordova-Sqlite-Storage plugin to use the shared 
> local folder and also with a proof of concept app 
> (https://github.com/hoffmanjon/Cordova_Windows_UWP_Shared_Local_Folder3 , 
> https://github.com/hoffmanjon/Cordova_Windows_UWP_Shared_Local_Folder_plugin).
>  
> I did create a native c# application to see if we had the same behavior when 
> we updated a native application. When we updated the native app the shared 
> local folder was not removed therefore this is an issue specific to the 
> hybrid application.
> I put my proof of concept application that simply writes a text file to the 
> shared local folder and the application local folder that can be used to see 
> how the shared local folder is removed when we update the app. The repository 
> is located here: 
> https://github.com/hoffmanjon/Cordova_Windows_UWP_Shared_Local_Folder and 
> includes a windows plugin to write to the shared local folder. 
> You will need to set a group policy to get the shared local folders working. 
> In the "Using Shared Local" section of this page: 
> https://blogs.windows.com/buildingapps/2016/05/24/sharing-your-local-app-data 
> it describes how to change the policy and which one to change.
> I have updated to Cordova 7.0.1 and built the proof of concept app to see if 
> we have the same issue as describe with version 6.5 
> (https://issues.apache.org/jira/browse/CB-12928).  After updating the 
> application the shared local folder is removed therefore the same issue 
> exists with Cordova 7.0.1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13203) Windows UWP shared Local Folder being removed on app update

2018-02-13 Thread Jan Piotrowski (Sujan) (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362478#comment-16362478
 ] 

Jan Piotrowski (Sujan) commented on CB-13203:
-

Hey [~hoffmanjon], is this issue still relevant for you? Did I assume correctly 
that you were testing this with `cordova-windows` version 5.0.0?

> Windows UWP shared Local Folder being removed on app update
> ---
>
> Key: CB-13203
> URL: https://issues.apache.org/jira/browse/CB-13203
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 5.0.0
> Environment: When running on the Windows 10 platform
>Reporter: Jon Hoffman
>Assignee: Jesse MacFadyen
>Priority: Critical
>  Labels: cordova-7.0.1, data-corruption, data-integrity, 
> data-loss, windows-universal
>
> We are writing an application using Ionic 2 for Windows 10. The application 
> will need to share data between different users on the same machine therefore 
> we are using the shared local folder to save the data to as described in the 
> "Using Shared Local" section of this page: 
> https://blogs.windows.com/buildingapps/2016/05/24/sharing-your-local-app-data 
> This method works great and we are able to write information to the shared 
> local folder however when the application updates, all of the files in the 
> shared local folder are removed. 
> I tested this by updating the Cordova-Sqlite-Storage plugin to use the shared 
> local folder and also with a proof of concept app 
> (https://github.com/hoffmanjon/Cordova_Windows_UWP_Shared_Local_Folder3 , 
> https://github.com/hoffmanjon/Cordova_Windows_UWP_Shared_Local_Folder_plugin).
>  
> I did create a native c# application to see if we had the same behavior when 
> we updated a native application. When we updated the native app the shared 
> local folder was not removed therefore this is an issue specific to the 
> hybrid application.
> I put my proof of concept application that simply writes a text file to the 
> shared local folder and the application local folder that can be used to see 
> how the shared local folder is removed when we update the app. The repository 
> is located here: 
> https://github.com/hoffmanjon/Cordova_Windows_UWP_Shared_Local_Folder and 
> includes a windows plugin to write to the shared local folder. 
> You will need to set a group policy to get the shared local folders working. 
> In the "Using Shared Local" section of this page: 
> https://blogs.windows.com/buildingapps/2016/05/24/sharing-your-local-app-data 
> it describes how to change the policy and which one to change.
> I have updated to Cordova 7.0.1 and built the proof of concept app to see if 
> we have the same issue as describe with version 6.5 
> (https://issues.apache.org/jira/browse/CB-12928).  After updating the 
> application the shared local folder is removed therefore the same issue 
> exists with Cordova 7.0.1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13870) `cordova requirements` is broken since change to default=UAP and with modern tooling

2018-02-13 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362503#comment-16362503
 ] 

ASF subversion and git services commented on CB-13870:
--

Commit f7a5450e235ebe0888bd417abb612f6d27c9ce95 in cordova-windows's branch 
refs/heads/janpio-CB-13870_2 from [~Sujan12]
[ https://gitbox.apache.org/repos/asf?p=cordova-windows.git;h=f7a5450 ]

CB-13870 change default from UAP to 10.0 which means the same but works for 
check_reqs as well


> `cordova requirements` is broken since change to default=UAP and with modern 
> tooling
> 
>
> Key: CB-13870
> URL: https://issues.apache.org/jira/browse/CB-13870
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Blocker
>
> check_reqs.js 
> 1. doesn't know about "UAP", only "10.0"
> 2. doesn't know about VS2017 (so error messages are wrong)
> 3. doesn't know about current MSBuild tooling (so doesn't recognize it at all)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13870) `cordova requirements` is broken since change to default=UAP and with modern tooling

2018-02-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362504#comment-16362504
 ] 

ASF GitHub Bot commented on CB-13870:
-

janpio opened a new pull request #253: CB-13870 change default from UAP to 10.0 
URL: https://github.com/apache/cordova-windows/pull/253
 
 
   ### What does this PR do?
   
   ... which means the same but works for check_reqs as well.
   
   This is an "update" to https://github.com/apache/cordova-windows/pull/241
   
   ### What testing has been done on this change?
   
   - Manual installation as platform and ran `cordova requirements` successfully
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
   - [ ] Added automated test coverage as appropriate for this change.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> `cordova requirements` is broken since change to default=UAP and with modern 
> tooling
> 
>
> Key: CB-13870
> URL: https://issues.apache.org/jira/browse/CB-13870
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Blocker
>
> check_reqs.js 
> 1. doesn't know about "UAP", only "10.0"
> 2. doesn't know about VS2017 (so error messages are wrong)
> 3. doesn't know about current MSBuild tooling (so doesn't recognize it at all)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13817) UWP is the new UAP

2018-02-13 Thread Jan Piotrowski (Sujan) (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Piotrowski (Sujan) updated CB-13817:

Component/s: cordova-docs

> UWP is the new UAP
> --
>
> Key: CB-13817
> URL: https://issues.apache.org/jira/browse/CB-13817
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-docs, cordova-windows
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> Historically cordova-windows uses UAP to refer to the (now so called) 
> Universal Windows Platform. Now that everybody calls it UWP, it would make 
> sense to change the params and settings of cordova-windows to call it UWP as 
> well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13817) UWP is the new UAP

2018-02-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362557#comment-16362557
 ] 

ASF GitHub Bot commented on CB-13817:
-

janpio commented on issue #251: CB-13817 Add new alias `uwp` for `--appx` param 
including tests
URL: https://github.com/apache/cordova-windows/pull/251#issuecomment-365313201
 
 
   Test failures are identical to current `master`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> UWP is the new UAP
> --
>
> Key: CB-13817
> URL: https://issues.apache.org/jira/browse/CB-13817
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-docs, cordova-windows
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> Historically cordova-windows uses UAP to refer to the (now so called) 
> Universal Windows Platform. Now that everybody calls it UWP, it would make 
> sense to change the params and settings of cordova-windows to call it UWP as 
> well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0

2018-02-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362725#comment-16362725
 ] 

ASF GitHub Bot commented on CB-13861:
-

janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365344461
 
 
   I can now confirm this error message with (only) Visual Studio 2017 
installed:
   
   ```
   C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\MSBuild\Microsoft\VisualStudio\v15.0\JavaScript\Microsoft.VisualStudio.JavaScript.UAP.targets(84,3):
 error : "10.0.10240.0" is not a supported value for TargetPlatformVersion. 
Please change it on the Project Property page. 
[C:\Projects\Cordova\cordova-windows\testcreate ??\CordovaApp.Windows10.jsproj]
   ```
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update TargetPlatformVersion to 10.0.10586.0
> 
>
> Key: CB-13861
> URL: https://issues.apache.org/jira/browse/CB-13861
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: Jesse MacFadyen
>Assignee: Jesse MacFadyen
>Priority: Major
>
> For VS2017 Windows 10 projects we need to update TargetPlatformVersion to 
> 10.0.10586.0
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0

2018-02-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362727#comment-16362727
 ] 

ASF GitHub Bot commented on CB-13861:
-

janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365345308
 
 
   Unfortunately I can not confirm that changing the value to `...10586...` 
fixes the issue:
   
   ```
   C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\MSBuild\Microsoft\VisualStudio\v15.0\JavaScript\Microsoft.VisualStudio.JavaScript.UAP.targets(84,3):
 error : "10.0.10586.0" is not a supported value for TargetPlatformVersion. 
Please change it on the Project Property page. 
[C:\Projects\Cordova\cordova-windows\testcreate ??\CordovaApp.Windows10.jsproj]
   ```
   
   Is this maybe related to the actually installed local versions of Windows 
SDK?
   Could you both please check which ones you have installed?
   
   (When creating an actual project, this value is replaced by the highest 
available I think, so this might really only be an issue with `npm test`/`npm 
run test-e2e` but not in actual usage.) 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update TargetPlatformVersion to 10.0.10586.0
> 
>
> Key: CB-13861
> URL: https://issues.apache.org/jira/browse/CB-13861
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: Jesse MacFadyen
>Assignee: Jesse MacFadyen
>Priority: Major
>
> For VS2017 Windows 10 projects we need to update TargetPlatformVersion to 
> 10.0.10586.0
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0

2018-02-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362729#comment-16362729
 ] 

ASF GitHub Bot commented on CB-13861:
-

brodybits commented on issue #250: [CB-13861] Update TargetPlatformVersion
URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365345897
 
 
   > Is this maybe related to the actually installed local versions of Windows 
SDK?
   
   I would think so
   
   > Could you both please check which ones you have installed?
   
   I will check sometime later


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update TargetPlatformVersion to 10.0.10586.0
> 
>
> Key: CB-13861
> URL: https://issues.apache.org/jira/browse/CB-13861
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: Jesse MacFadyen
>Assignee: Jesse MacFadyen
>Priority: Major
>
> For VS2017 Windows 10 projects we need to update TargetPlatformVersion to 
> 10.0.10586.0
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0

2018-02-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362736#comment-16362736
 ] 

ASF GitHub Bot commented on CB-13861:
-

janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365348748
 
 
   Can confirm, I currently only have `10.0.16299.0` (newest) installed. These 
tests only succeed if I change it to that version.
   
   Let me confirm that I can actually build an app without updating this value 
when I install the branch I am currently working on.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update TargetPlatformVersion to 10.0.10586.0
> 
>
> Key: CB-13861
> URL: https://issues.apache.org/jira/browse/CB-13861
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: Jesse MacFadyen
>Assignee: Jesse MacFadyen
>Priority: Major
>
> For VS2017 Windows 10 projects we need to update TargetPlatformVersion to 
> 10.0.10586.0
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0

2018-02-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362827#comment-16362827
 ] 

ASF GitHub Bot commented on CB-13861:
-

janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365357575
 
 
   So I installed my branch which is giving me errors on running the test. 
   
   On `cordova platform add ...` it creates a `CordovaApp.Windows10.jsproj` 
file with:
   ```
   
   UAP
   10.0.16299.0
   10.0.10240.0
   14.0
   100
   
   ```
   
   So it updates the `TargetPlatformVersion` to the current version somewhere.
   
   Yes, there is some code for that in `prepare.js` and this is actually 
executed during `cordova platform add ...`.
   
   Which means that the tests should probably/maybe do something similar 
instead of this PR here, right? This PR is only making it possible to run the 
tests with a very specific setup.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update TargetPlatformVersion to 10.0.10586.0
> 
>
> Key: CB-13861
> URL: https://issues.apache.org/jira/browse/CB-13861
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: Jesse MacFadyen
>Assignee: Jesse MacFadyen
>Priority: Major
>
> For VS2017 Windows 10 projects we need to update TargetPlatformVersion to 
> 10.0.10586.0
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13730) cordova-plugin-network-information return wrong connection status on Android

2018-02-13 Thread L Hobbs (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362856#comment-16362856
 ] 

L Hobbs commented on CB-13730:
--

This issue seems to be related to the "Doze" mode added to Android in version 
6.0, but has gotten much worse with Android 7.0 and 8.0. Reference 
https://issues.apache.org/jira/browse/CB-12325 for a way to reproduce the 
steps. I have been able to build a very, very simple project 
([https://github.com/tciwebdev/cordova-bug] ) in PhoneGap Build, which uses 
cli-6.5.0 (4.3.1 / 6.1.2 / 4.4.3), and cordova-plugin-network-information 
version 2.01. The only way I've seen to get the test app I built to report that 
the network is online is to either kill the app and relaunch it, or to disable 
data/force the phone in to airplane mode and back out while the app is running. 
 The only other option is to go into the phone settings and disable battery 
optimization for the app but that's something the user has to do on their 
device. 

 

 

> cordova-plugin-network-information return wrong connection status on Android
> 
>
> Key: CB-13730
> URL: https://issues.apache.org/jira/browse/CB-13730
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-network-information
>Affects Versions: cordova@7.1.0
> Environment: Windows 10, cordova-cli@7.1.0, cordova-android@6.4.0
>Reporter: Cristian Iossi
>Priority: Major
>  Labels: test
>
> There is a problem with cordova-plugin-network-information on Android. Even 
> if there is internet connection, after the app is opened for a while, when I 
> resume the app from the background and I check connection with 
> navigator.connection.type, it returns connection.type = NONE: I tried to do 
> an ajax request to verify the connection, and it works, so there is 
> connection. If I close and re-open the app it returns connection.type = 4G. I 
> use cordova@7.1.0 and cordova-android@6.4.0.
> My code to check the connection status is: 
> {code:java}
> function isOnline() {
> var networkState = navigator.connection.type;
> if (networkState !== Connection.NONE) {
> return true
> } else {
> return false
> }
> }
> {code}
> Thanks
> Cristian



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12035) [cordova-plugin-network-information] connection info is not reliable on Android 6

2018-02-13 Thread L Hobbs (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362857#comment-16362857
 ] 

L Hobbs commented on CB-12035:
--

This issue seems to be related to the "Doze" mode added to Android in version 
6.0, but has gotten much worse with Android 7.0 and 8.0. Reference 
https://issues.apache.org/jira/browse/CB-12325 for a way to reproduce the 
steps. I have been able to build a very, very simple project 
([https://github.com/tciwebdev/cordova-bug] ) in PhoneGap Build, which uses 
cli-6.5.0 (4.3.1 / 6.1.2 / 4.4.3), and cordova-plugin-network-information 
version 2.01. The only way I've seen to get the test app I built to report that 
the network is online is to either kill the app and relaunch it, or to disable 
data/force the phone in to airplane mode and back out while the app is running. 
 The only other option is to go into the phone settings and disable battery 
optimization for the app but that's something the user has to do on their 
device.

> [cordova-plugin-network-information] connection info is not reliable on 
> Android 6
> -
>
> Key: CB-12035
> URL: https://issues.apache.org/jira/browse/CB-12035
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-network-information
>Affects Versions: 1.3.0
> Environment: Samsung Galaxy Edge S6 / Android 6
> useragent: "Mozilla/5.0 (Linux; Android 6.0.1; SM-G925F Build/MMB29K; wv) 
> AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/53.0.2785.124 
> Mobile Safari/537.36"
> reproduced with:
> cordova-plugin-network-information@1.3.0 (latest)
> cordova-plugin-network-information@1.2.0
>Reporter: jakub-g
>Priority: Major
>  Labels: android
>
> I've noticed that information exposed by the plugin is not reliable. It 
> happens often that I'm connected to the internet via WiFi, and the plugin 
> says that there's no connection.
> It's not easy to reproduce it on-demand, but I reproduced it many times 
> recently. It happens most often when in the morning, I open the Cordova app 
> that was running in background throughout the night.
> Then, when I connect to Chrome Dev Tools, I can do a repl session like this:
> {code}
> > navigator.connection.type
> "none"
> > window.fetch('http://www.example.org').then(function(res) 
> > {console.log(res.status)})
> Promise {[[PromiseStatus]]: "pending", [[PromiseValue]]: undefined}
> 200
> Fetch complete: GET "http://www.example.org/";.(anonymous function)
> > navigator.connection.type
> "none"
> {code}
> So, the plugin thinks I'm offline, yet any HTTP calls done within the app 
> without checking if I'm offline or online, are successful (either from the 
> app or devtools).
> When I disable WiFi and reenable it, after a few seconds the plugin updates 
> its state and then it tells that connection type is "wifi".
> There are several possibilities here:
> - either system (or device driver) gives us incorrect information, or
> - cordova plugin is caching data and/or not listening properly to all the 
> events and/or incorrectly processing it
> and most probably the issue manifests itself when the device is asleep for 
> many hours (but I'm not sure about this).
> Note that I also noticed another issue, that sometimes the Chrome network 
> stack thinks I'm offline (when I do an HTTP call, it fails immediately and I 
> see network errors in devtools console) - and then I restart the Cordova app, 
> and everything's fine, all HTTP calls are ok - but this is unrelated to this 
> ticket, and perhaps a bug in Chrome.
> This ticket seems to be most likely a bug in the plugin, because as I said 
> before, doing HTTP call succeeds despite the plugin telling me that I'm 
> offline.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-12035) [cordova-plugin-network-information] connection info is not reliable on Android 6

2018-02-13 Thread L Hobbs (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362857#comment-16362857
 ] 

L Hobbs edited comment on CB-12035 at 2/13/18 6:51 PM:
---

This issue seems to be related to the "Doze" mode added to Android in version 
6.0, but has gotten much worse with Android 7.0 and 8.0. Reference 
https://issues.apache.org/jira/browse/CB-12325 for a way to reproduce the 
steps. I have been able to build a very, very simple project 
([https://github.com/tciwebdev/cordova-bug] ) in PhoneGap Build, which uses 
cli-6.5.0 (4.3.1 / 6.1.2 / 4.4.3), and cordova-plugin-network-information 
version 2.01. The only way I've seen to get the test app I built to report that 
the network is online is to either kill the app and relaunch it, or to disable 
data/force the phone in to airplane mode and back out while the app is running. 
 The only other option is to go into the phone settings and disable battery 
optimization for the app but that's something the user has to do on their 
device.

 

I have been able to reproduce the with the 2.01 
cordova-plugin-network-information plugin on Android 7.0 and 8.0, on a Google 
Pixel, Samsung Note 8, and LG Stylo 2.


was (Author: tciwebdev):
This issue seems to be related to the "Doze" mode added to Android in version 
6.0, but has gotten much worse with Android 7.0 and 8.0. Reference 
https://issues.apache.org/jira/browse/CB-12325 for a way to reproduce the 
steps. I have been able to build a very, very simple project 
([https://github.com/tciwebdev/cordova-bug] ) in PhoneGap Build, which uses 
cli-6.5.0 (4.3.1 / 6.1.2 / 4.4.3), and cordova-plugin-network-information 
version 2.01. The only way I've seen to get the test app I built to report that 
the network is online is to either kill the app and relaunch it, or to disable 
data/force the phone in to airplane mode and back out while the app is running. 
 The only other option is to go into the phone settings and disable battery 
optimization for the app but that's something the user has to do on their 
device.

> [cordova-plugin-network-information] connection info is not reliable on 
> Android 6
> -
>
> Key: CB-12035
> URL: https://issues.apache.org/jira/browse/CB-12035
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-network-information
>Affects Versions: 1.3.0
> Environment: Samsung Galaxy Edge S6 / Android 6
> useragent: "Mozilla/5.0 (Linux; Android 6.0.1; SM-G925F Build/MMB29K; wv) 
> AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/53.0.2785.124 
> Mobile Safari/537.36"
> reproduced with:
> cordova-plugin-network-information@1.3.0 (latest)
> cordova-plugin-network-information@1.2.0
>Reporter: jakub-g
>Priority: Major
>  Labels: android
>
> I've noticed that information exposed by the plugin is not reliable. It 
> happens often that I'm connected to the internet via WiFi, and the plugin 
> says that there's no connection.
> It's not easy to reproduce it on-demand, but I reproduced it many times 
> recently. It happens most often when in the morning, I open the Cordova app 
> that was running in background throughout the night.
> Then, when I connect to Chrome Dev Tools, I can do a repl session like this:
> {code}
> > navigator.connection.type
> "none"
> > window.fetch('http://www.example.org').then(function(res) 
> > {console.log(res.status)})
> Promise {[[PromiseStatus]]: "pending", [[PromiseValue]]: undefined}
> 200
> Fetch complete: GET "http://www.example.org/";.(anonymous function)
> > navigator.connection.type
> "none"
> {code}
> So, the plugin thinks I'm offline, yet any HTTP calls done within the app 
> without checking if I'm offline or online, are successful (either from the 
> app or devtools).
> When I disable WiFi and reenable it, after a few seconds the plugin updates 
> its state and then it tells that connection type is "wifi".
> There are several possibilities here:
> - either system (or device driver) gives us incorrect information, or
> - cordova plugin is caching data and/or not listening properly to all the 
> events and/or incorrectly processing it
> and most probably the issue manifests itself when the device is asleep for 
> many hours (but I'm not sure about this).
> Note that I also noticed another issue, that sometimes the Chrome network 
> stack thinks I'm offline (when I do an HTTP call, it fails immediately and I 
> see network errors in devtools console) - and then I restart the Cordova app, 
> and everything's fine, all HTTP calls are ok - but this is unrelated to this 
> ticket, and perhaps a bug in Chrome.
> This ticket seems to be most likely a bug in the plugin, because as I said 
> before, doing HTTP call succeeds despite the plugin te

[jira] [Comment Edited] (CB-12035) [cordova-plugin-network-information] connection info is not reliable on Android 6

2018-02-13 Thread L Hobbs (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362857#comment-16362857
 ] 

L Hobbs edited comment on CB-12035 at 2/13/18 6:51 PM:
---

This issue seems to be related to the "Doze" mode added to Android in version 
6.0, but has gotten much worse with Android 7.0 and 8.0. Reference 
https://issues.apache.org/jira/browse/CB-12325 for a way to reproduce the 
steps. I have been able to build a very, very simple project 
([https://github.com/tciwebdev/cordova-bug] ) in PhoneGap Build, which uses 
cli-6.5.0 (4.3.1 / 6.1.2 / 4.4.3), and cordova-plugin-network-information 
version 2.01. The only way I've seen to get the test app I built to report that 
the network is online is to either kill the app and relaunch it, or to disable 
data/force the phone in to airplane mode and back out while the app is running. 
 The only other option is to go into the phone settings and disable battery 
optimization for the app but that's something the user has to do on their 
device.

 

I have been able to reproduce the issue with the 2.01 
cordova-plugin-network-information plugin on Android 7.0 and 8.0, on a Google 
Pixel, Samsung Note 8, and LG Stylo 2.


was (Author: tciwebdev):
This issue seems to be related to the "Doze" mode added to Android in version 
6.0, but has gotten much worse with Android 7.0 and 8.0. Reference 
https://issues.apache.org/jira/browse/CB-12325 for a way to reproduce the 
steps. I have been able to build a very, very simple project 
([https://github.com/tciwebdev/cordova-bug] ) in PhoneGap Build, which uses 
cli-6.5.0 (4.3.1 / 6.1.2 / 4.4.3), and cordova-plugin-network-information 
version 2.01. The only way I've seen to get the test app I built to report that 
the network is online is to either kill the app and relaunch it, or to disable 
data/force the phone in to airplane mode and back out while the app is running. 
 The only other option is to go into the phone settings and disable battery 
optimization for the app but that's something the user has to do on their 
device.

 

I have been able to reproduce the with the 2.01 
cordova-plugin-network-information plugin on Android 7.0 and 8.0, on a Google 
Pixel, Samsung Note 8, and LG Stylo 2.

> [cordova-plugin-network-information] connection info is not reliable on 
> Android 6
> -
>
> Key: CB-12035
> URL: https://issues.apache.org/jira/browse/CB-12035
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-network-information
>Affects Versions: 1.3.0
> Environment: Samsung Galaxy Edge S6 / Android 6
> useragent: "Mozilla/5.0 (Linux; Android 6.0.1; SM-G925F Build/MMB29K; wv) 
> AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/53.0.2785.124 
> Mobile Safari/537.36"
> reproduced with:
> cordova-plugin-network-information@1.3.0 (latest)
> cordova-plugin-network-information@1.2.0
>Reporter: jakub-g
>Priority: Major
>  Labels: android
>
> I've noticed that information exposed by the plugin is not reliable. It 
> happens often that I'm connected to the internet via WiFi, and the plugin 
> says that there's no connection.
> It's not easy to reproduce it on-demand, but I reproduced it many times 
> recently. It happens most often when in the morning, I open the Cordova app 
> that was running in background throughout the night.
> Then, when I connect to Chrome Dev Tools, I can do a repl session like this:
> {code}
> > navigator.connection.type
> "none"
> > window.fetch('http://www.example.org').then(function(res) 
> > {console.log(res.status)})
> Promise {[[PromiseStatus]]: "pending", [[PromiseValue]]: undefined}
> 200
> Fetch complete: GET "http://www.example.org/";.(anonymous function)
> > navigator.connection.type
> "none"
> {code}
> So, the plugin thinks I'm offline, yet any HTTP calls done within the app 
> without checking if I'm offline or online, are successful (either from the 
> app or devtools).
> When I disable WiFi and reenable it, after a few seconds the plugin updates 
> its state and then it tells that connection type is "wifi".
> There are several possibilities here:
> - either system (or device driver) gives us incorrect information, or
> - cordova plugin is caching data and/or not listening properly to all the 
> events and/or incorrectly processing it
> and most probably the issue manifests itself when the device is asleep for 
> many hours (but I'm not sure about this).
> Note that I also noticed another issue, that sometimes the Chrome network 
> stack thinks I'm offline (when I do an HTTP call, it fails immediately and I 
> see network errors in devtools console) - and then I restart the Cordova app, 
> and everything's fine, all HTTP calls are ok - but this is unrelated to th

[jira] [Created] (CB-13874) Windows 8.1 builds don't work with Visual Studio 2018

2018-02-13 Thread Jan Piotrowski (Sujan) (JIRA)
Jan Piotrowski (Sujan) created CB-13874:
---

 Summary: Windows 8.1 builds don't work with Visual Studio 2018
 Key: CB-13874
 URL: https://issues.apache.org/jira/browse/CB-13874
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-windows
Reporter: Jan Piotrowski (Sujan)
Assignee: Jesse MacFadyen


Building Windows Phone 8.1 is not possible at all because there is no Emulator 
for VS2017, 
building for Windows 8.1 is not possible because WinJS is missing which is 
probably also part of something that is not there any more.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0

2018-02-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362940#comment-16362940
 ] 

ASF GitHub Bot commented on CB-13861:
-

purplecabbage commented on issue #250: [CB-13861] Update TargetPlatformVersion
URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365382091
 
 
   Yeah, I believe prepare is the right place for this to happen.
   Consider this pr dead.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update TargetPlatformVersion to 10.0.10586.0
> 
>
> Key: CB-13861
> URL: https://issues.apache.org/jira/browse/CB-13861
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: Jesse MacFadyen
>Assignee: Jesse MacFadyen
>Priority: Major
>
> For VS2017 Windows 10 projects we need to update TargetPlatformVersion to 
> 10.0.10586.0
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13870) `cordova requirements` is broken since change to default=UAP and with modern tooling

2018-02-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362943#comment-16362943
 ] 

ASF GitHub Bot commented on CB-13870:
-

janpio commented on issue #253: CB-13870 change default from UAP to 10.0 
URL: https://github.com/apache/cordova-windows/pull/253#issuecomment-365382904
 
 
   Yes, this is actually required for `cordova requirements` not to explode 
(which happened after the change to `UAP`).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> `cordova requirements` is broken since change to default=UAP and with modern 
> tooling
> 
>
> Key: CB-13870
> URL: https://issues.apache.org/jira/browse/CB-13870
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Blocker
>
> check_reqs.js 
> 1. doesn't know about "UAP", only "10.0"
> 2. doesn't know about VS2017 (so error messages are wrong)
> 3. doesn't know about current MSBuild tooling (so doesn't recognize it at all)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0

2018-02-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362944#comment-16362944
 ] 

ASF GitHub Bot commented on CB-13861:
-

janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365383160
 
 
   Problem is that `prepare` is not available on the command line... so I had 
to implement that. 
   Will open an issue and PR later.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update TargetPlatformVersion to 10.0.10586.0
> 
>
> Key: CB-13861
> URL: https://issues.apache.org/jira/browse/CB-13861
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: Jesse MacFadyen
>Assignee: Jesse MacFadyen
>Priority: Major
>
> For VS2017 Windows 10 projects we need to update TargetPlatformVersion to 
> 10.0.10586.0
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-13875) `npm run test-e2e` is highly platform dependent as `prepare` step is not run

2018-02-13 Thread Jan Piotrowski (Sujan) (JIRA)
Jan Piotrowski (Sujan) created CB-13875:
---

 Summary: `npm run test-e2e` is highly platform dependent as 
`prepare` step is not run
 Key: CB-13875
 URL: https://issues.apache.org/jira/browse/CB-13875
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-windows
Reporter: Jan Piotrowski (Sujan)
Assignee: Jan Piotrowski (Sujan)


When running `npm run test-e2e` you have to have the Windows SDK with the exact 
version that is mentioned in `TargetPlatformVersion` (which oldest one in the 
template) installed for it to succeed.

For actual projects, this is updated with the newest/available one on project 
creation.

For this to properly work in tests, `prepare` has also to be executed in the 
e2e tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13875) `npm run test-e2e` is highly platform dependent as `prepare` step is not run

2018-02-13 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362965#comment-16362965
 ] 

ASF subversion and git services commented on CB-13875:
--

Commit 910072309ff06266797f6ea9a4ee8e28feb9685c in cordova-windows's branch 
refs/heads/janpio-prepare_script_in_e2e from [~Sujan12]
[ https://gitbox.apache.org/repos/asf?p=cordova-windows.git;h=9100723 ]

CB-13875 add `prepare` script that can be called in e2e tests to prepare 
project files
(based on `clean` and some terrible code to build a `project` object)
also adds default `config.xml`


> `npm run test-e2e` is highly platform dependent as `prepare` step is not run
> 
>
> Key: CB-13875
> URL: https://issues.apache.org/jira/browse/CB-13875
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> When running `npm run test-e2e` you have to have the Windows SDK with the 
> exact version that is mentioned in `TargetPlatformVersion` (which oldest one 
> in the template) installed for it to succeed.
> For actual projects, this is updated with the newest/available one on project 
> creation.
> For this to properly work in tests, `prepare` has also to be executed in the 
> e2e tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13875) `npm run test-e2e` is highly platform dependent as `prepare` step is not run

2018-02-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362967#comment-16362967
 ] 

ASF GitHub Bot commented on CB-13875:
-

janpio opened a new pull request #254: [WIP] CB-13875 add `prepare` script that 
can be called in e2e tests
URL: https://github.com/apache/cordova-windows/pull/254
 
 
   … to prepare project files
   
   (based on `clean` and some terrible code to build a `project` object)
   also adds default `config.xml` as in other projects
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
   - [ ] Added automated test coverage as appropriate for this change.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> `npm run test-e2e` is highly platform dependent as `prepare` step is not run
> 
>
> Key: CB-13875
> URL: https://issues.apache.org/jira/browse/CB-13875
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> When running `npm run test-e2e` you have to have the Windows SDK with the 
> exact version that is mentioned in `TargetPlatformVersion` (which oldest one 
> in the template) installed for it to succeed.
> For actual projects, this is updated with the newest/available one on project 
> creation.
> For this to properly work in tests, `prepare` has also to be executed in the 
> e2e tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13875) `npm run test-e2e` is highly platform dependent as `prepare` step is not run

2018-02-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362973#comment-16362973
 ] 

ASF GitHub Bot commented on CB-13875:
-

janpio commented on a change in pull request #254: [WIP] CB-13875 add `prepare` 
script that can be called in e2e tests
URL: https://github.com/apache/cordova-windows/pull/254#discussion_r167985739
 
 

 ##
 File path: template/cordova/prepare
 ##
 @@ -0,0 +1,61 @@
+#!/usr/bin/env node
+
+/*
+   Licensed to the Apache Software Foundation (ASF) under one
+   or more contributor license agreements.  See the NOTICE file
+   distributed with this work for additional information
+   regarding copyright ownership.  The ASF licenses this file
+   to you under the Apache License, Version 2.0 (the
+   "License"); you may not use this file except in compliance
+   with the License.  You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing,
+   software distributed under the License is distributed on an
+   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+   KIND, either express or implied.  See the License for the
+   specific language governing permissions and limitations
+   under the License.
+*/
+
+var Api = require('./Api');
+var nopt = require('nopt');
+var path = require('path');
+var ConfigParser = require('cordova-common').ConfigParser;
+
+// Support basic help commands
+if(['--help', '/?', '-h', 'help', '-help', '/help'].indexOf(process.argv[2]) 
>= 0) {
+console.log('Usage: \nprepare\n');
+process.exit(0);
+}
+
+// Do some basic argument parsing
+var opts = nopt({
+'verbose' : Boolean,
+'silent' : Boolean
+}, { 'd' : '--verbose' });
+
+// Make buildOptions compatible with PlatformApi clean method spec
+opts.argv = opts.argv.original;
+
+// Skip cleaning prepared files when not invoking via cordova CLI.
+opts.noPrepare = true;
+
+require('./lib/loggingHelper').adjustLoggerLevel(opts);
+
+var projectRoot = path.join(__dirname, '..');
+var project = {
 
 Review comment:
   this is pretty ugly here, but `prepare` is the only one of the "main" 
commands that takes a `project` as a param so I had to improvise.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> `npm run test-e2e` is highly platform dependent as `prepare` step is not run
> 
>
> Key: CB-13875
> URL: https://issues.apache.org/jira/browse/CB-13875
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> When running `npm run test-e2e` you have to have the Windows SDK with the 
> exact version that is mentioned in `TargetPlatformVersion` (which oldest one 
> in the template) installed for it to succeed.
> For actual projects, this is updated with the newest/available one on project 
> creation.
> For this to properly work in tests, `prepare` has also to be executed in the 
> e2e tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0

2018-02-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362975#comment-16362975
 ] 

ASF GitHub Bot commented on CB-13861:
-

janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365388649
 
 
   See https://github.com/apache/cordova-windows/pull/254 as a replacement. 
Would be nice if you could check that out and run it locally to see if the 
tests succeed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update TargetPlatformVersion to 10.0.10586.0
> 
>
> Key: CB-13861
> URL: https://issues.apache.org/jira/browse/CB-13861
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: Jesse MacFadyen
>Assignee: Jesse MacFadyen
>Priority: Major
>
> For VS2017 Windows 10 projects we need to update TargetPlatformVersion to 
> 10.0.10586.0
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13875) `npm run test-e2e` is highly platform dependent as `prepare` step is not run

2018-02-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362978#comment-16362978
 ] 

ASF GitHub Bot commented on CB-13875:
-

janpio commented on a change in pull request #254: [WIP] CB-13875 add `prepare` 
script that can be called in e2e tests
URL: https://github.com/apache/cordova-windows/pull/254#discussion_r167985739
 
 

 ##
 File path: template/cordova/prepare
 ##
 @@ -0,0 +1,61 @@
+#!/usr/bin/env node
+
+/*
+   Licensed to the Apache Software Foundation (ASF) under one
+   or more contributor license agreements.  See the NOTICE file
+   distributed with this work for additional information
+   regarding copyright ownership.  The ASF licenses this file
+   to you under the Apache License, Version 2.0 (the
+   "License"); you may not use this file except in compliance
+   with the License.  You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing,
+   software distributed under the License is distributed on an
+   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+   KIND, either express or implied.  See the License for the
+   specific language governing permissions and limitations
+   under the License.
+*/
+
+var Api = require('./Api');
+var nopt = require('nopt');
+var path = require('path');
+var ConfigParser = require('cordova-common').ConfigParser;
+
+// Support basic help commands
+if(['--help', '/?', '-h', 'help', '-help', '/help'].indexOf(process.argv[2]) 
>= 0) {
+console.log('Usage: \nprepare\n');
+process.exit(0);
+}
+
+// Do some basic argument parsing
+var opts = nopt({
+'verbose' : Boolean,
+'silent' : Boolean
+}, { 'd' : '--verbose' });
+
+// Make buildOptions compatible with PlatformApi clean method spec
+opts.argv = opts.argv.original;
+
+// Skip cleaning prepared files when not invoking via cordova CLI.
+opts.noPrepare = true;
+
+require('./lib/loggingHelper').adjustLoggerLevel(opts);
+
+var projectRoot = path.join(__dirname, '..');
+var project = {
 
 Review comment:
   this is pretty ugly here, but `prepare` is the only one of the "main" 
commands that takes a `project` as a param so I had to improvise. think the end 
result isn't that bad.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> `npm run test-e2e` is highly platform dependent as `prepare` step is not run
> 
>
> Key: CB-13875
> URL: https://issues.apache.org/jira/browse/CB-13875
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> When running `npm run test-e2e` you have to have the Windows SDK with the 
> exact version that is mentioned in `TargetPlatformVersion` (which oldest one 
> in the template) installed for it to succeed.
> For actual projects, this is updated with the newest/available one on project 
> creation.
> For this to properly work in tests, `prepare` has also to be executed in the 
> e2e tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13875) `npm run test-e2e` is highly platform dependent as `prepare` step is not run

2018-02-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362984#comment-16362984
 ] 

ASF GitHub Bot commented on CB-13875:
-

janpio commented on issue #254: [WIP] CB-13875 add `prepare` script that can be 
called in e2e tests
URL: https://github.com/apache/cordova-windows/pull/254#issuecomment-365390984
 
 
   The missing `index.html` in the test project is causing issues now:
   
   ```
   EXEC : warning : Start page is missing on the disk. The build must go on but 
note that this will cause WACK failures. 
[C:\projects\cordova-windows\testcreate ??\CordovaApp.Phone.jsproj]
   MakeAppx : error : Manifest validation error: Line 26, Column 47, Reason: 
The file name "www\index.html" declared for element 
"m:Applications/m:Application" doesn't exist in the package. 
[C:\projects\cordova-windows\testcreate ??\CordovaApp.Phone.jsproj]
   MakeAppx : error : Package creation failed. 
[C:\projects\cordova-windows\testcreate ??\CordovaApp.Phone.jsproj]
   MakeAppx : error : 0x80080204 - The specified package format is not valid: 
The package manifest is not valid. 
   ```
   
   Locally I only get the first line, but on CI the MSBuildTools version seems 
to do some additional validation.
   
   Working on a fix.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> `npm run test-e2e` is highly platform dependent as `prepare` step is not run
> 
>
> Key: CB-13875
> URL: https://issues.apache.org/jira/browse/CB-13875
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> When running `npm run test-e2e` you have to have the Windows SDK with the 
> exact version that is mentioned in `TargetPlatformVersion` (which oldest one 
> in the template) installed for it to succeed.
> For actual projects, this is updated with the newest/available one on project 
> creation.
> For this to properly work in tests, `prepare` has also to be executed in the 
> e2e tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-13876) How can I measure code coverage of auto tests?

2018-02-13 Thread Adriano Di Giovanni (JIRA)
Adriano Di Giovanni created CB-13876:


 Summary: How can I measure code coverage of auto tests?
 Key: CB-13876
 URL: https://issues.apache.org/jira/browse/CB-13876
 Project: Apache Cordova
  Issue Type: Wish
  Components: cordova-plugin-test-framework
Reporter: Adriano Di Giovanni






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11965) Remove WinJS dependency

2018-02-13 Thread Philipp Kursawe (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363089#comment-16363089
 ] 

Philipp Kursawe commented on CB-11965:
--

Honestly, since MS abandoned Windows Phone/Mobile I do no longer care about 
this issue.

The effort that would have to be put into this is not worth my time, anyone's 
times I guess.

So feel free to close the issue.

> Remove WinJS dependency
> ---
>
> Key: CB-11965
> URL: https://issues.apache.org/jira/browse/CB-11965
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-windows
>Reporter: Philipp Kursawe
>Priority: Minor
>
> As far as I can see cordova uses WinJS only for managing life-cycle events, 
> which can be easily handled without WinJS using native WinRT.
> I propose to get rid of the (discontinued) WinJS library dependency to reduce 
> package deploy size and runtime overhead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Closed] (CB-11965) Remove WinJS dependency

2018-02-13 Thread Jan Piotrowski (Sujan) (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-11965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Piotrowski (Sujan) closed CB-11965.
---
Resolution: Won't Fix

Shame.

Do you know of you head if this would also have applied to the Win10 project?

> Remove WinJS dependency
> ---
>
> Key: CB-11965
> URL: https://issues.apache.org/jira/browse/CB-11965
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-windows
>Reporter: Philipp Kursawe
>Priority: Minor
>
> As far as I can see cordova uses WinJS only for managing life-cycle events, 
> which can be easily handled without WinJS using native WinRT.
> I propose to get rid of the (discontinued) WinJS library dependency to reduce 
> package deploy size and runtime overhead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13834) Fix tests failure with VS17 on AppVeyor caused by CB-12499

2018-02-13 Thread Jan Piotrowski (Sujan) (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363103#comment-16363103
 ] 

Jan Piotrowski (Sujan) commented on CB-13834:
-

I also posted the same question at StackOverflow and got a response from an 
engineer at AppVeyor:
https://stackoverflow.com/a/48775630/252627

This points to it using the wrong MSBuild version, 14 instead of 15. So our 
selection code is probably wonky.

> Fix tests failure with VS17 on AppVeyor caused by CB-12499
> --
>
> Key: CB-13834
> URL: https://issues.apache.org/jira/browse/CB-13834
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: Jan Piotrowski (Sujan)
>Priority: Major
>
> The file `Default.rd.xml` introduced by CB-12499 is unfortunately causing 
> test failures on AppVeyor when Visual Studio 2017 is used to build with 
> params `--release --bundle --archs="x64 x86 arm"`. 
>  
> {code:java}
> Started
> Creating Cordova Windows Project:
>   Path: testcreate 応用
>   Namespace: com.test.app
>   Name: 応用
> Windows project created with cordova-windows@5.1.0-dev
> Building project: C:\projects\cordova-windows\testcreate 
> 応用\CordovaApp.Windows10.jsproj
>   Configuration : release
>   Platform  : x64
>   Patching 10 in prebuild event...
>   Injected base.js reference to the www/index.html
>   Removing /( 
> *)(\s*<\/script>)(\s*)/
>  from www/index.html
>   Removing /( 
> *)(\s*<\/script>)(\s*)/
>  from www/index.html
>   CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate 
> ??\build\windows\release\x64\win10\CordovaApp.Windows10_1.0.0.0_x64.appx
>   CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate 
> ??\build\windows\release\x64\win10\Upload\CordovaApp.Windows10_1.0.0.0_x64.appx
>   CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate 
> ??\AppPackages\CordovaApp.Windows10_1.0.0.0_Test\CordovaApp.Windows10_1.0.0.0_x64.appxbundle
>   CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate 
> ??\AppPackages\CordovaApp.Windows10_1.0.0.0\CordovaApp.Windows10_1.0.0.0_x64.appxbundle
>   CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate 
> ??\AppPackages\CordovaApp.Windows10_1.0.0.0_x64_bundle.appxupload
>   Your package has been successfully created.
> Building project: C:\projects\cordova-windows\testcreate 
> 応用\CordovaApp.Windows10.jsproj
>   Configuration : release
>   Platform  : x86
>   Patching 10 in prebuild event...
> C:\Program Files 
> (x86)\MSBuild\Microsoft\VisualStudio\v14.0\AppxPackage\Microsoft.AppXPackage.Targets(2975,5):
>  error MSB3231: Unable to remove directory 
> "build\windows\bld\PackageUploadLayout\". The process cannot access the file 
> 'Default.rd.xml' because it is being used by another process. 
> [C:\projects\cordova-windows\testcreate ??\CordovaApp.Windows10.jsproj]
> C:\projects\cordova-windows\testcreate 応用\cordova\node_modules\q\q.js:155
> throw e;
> ^
> Error: C:\Program Files (x86)\MSBuild\14.0\bin\msbuild.exe: Command failed 
> with exit code 1
> at ChildProcess.whenDone (C:\projects\cordova-windows\testcreate 
> 応用\cordova\node_modules\cordova-common\src\superspawn.js:169:23)
> at emitTwo (events.js:106:13)
> at ChildProcess.emit (events.js:191:7)
> at maybeClose (internal/child_process.js:920:16)
> at Process.ChildProcess._handle.onexit 
> (internal/child_process.js:230:5){code}
> Afaik this is the only test that is "touching" that file (--release and 
> Windows 10), so this might be a general problem.
> Note: The test `6a` that is failing because of this has been moved to the end 
> of the test file so the other tests can run before it crashed - move back up 
> to its normal location when this is fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13875) `npm run test-e2e` is highly platform dependent as `prepare` step is not run

2018-02-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363246#comment-16363246
 ] 

ASF GitHub Bot commented on CB-13875:
-

janpio commented on issue #254: [WIP] CB-13875 add `prepare` script that can be 
called in e2e tests
URL: https://github.com/apache/cordova-windows/pull/254#issuecomment-365446432
 
 
   Fixed by making sure the `index.html` is present (by copying from a folder 
where it exists).
   
   This is now as good as `master` but works with any Windows 10 SDK installed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> `npm run test-e2e` is highly platform dependent as `prepare` step is not run
> 
>
> Key: CB-13875
> URL: https://issues.apache.org/jira/browse/CB-13875
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> When running `npm run test-e2e` you have to have the Windows SDK with the 
> exact version that is mentioned in `TargetPlatformVersion` (which oldest one 
> in the template) installed for it to succeed.
> For actual projects, this is updated with the newest/available one on project 
> creation.
> For this to properly work in tests, `prepare` has also to be executed in the 
> e2e tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0

2018-02-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363249#comment-16363249
 ] 

ASF GitHub Bot commented on CB-13861:
-

janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365446627
 
 
   #254 is now in a state to be tested and reviewed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update TargetPlatformVersion to 10.0.10586.0
> 
>
> Key: CB-13861
> URL: https://issues.apache.org/jira/browse/CB-13861
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: Jesse MacFadyen
>Assignee: Jesse MacFadyen
>Priority: Major
>
> For VS2017 Windows 10 projects we need to update TargetPlatformVersion to 
> 10.0.10586.0
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0

2018-02-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363266#comment-16363266
 ] 

ASF GitHub Bot commented on CB-13861:
-

janpio closed pull request #250: [CB-13861] Update TargetPlatformVersion
URL: https://github.com/apache/cordova-windows/pull/250
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update TargetPlatformVersion to 10.0.10586.0
> 
>
> Key: CB-13861
> URL: https://issues.apache.org/jira/browse/CB-13861
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: Jesse MacFadyen
>Assignee: Jesse MacFadyen
>Priority: Major
>
> For VS2017 Windows 10 projects we need to update TargetPlatformVersion to 
> 10.0.10586.0
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Closed] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0

2018-02-13 Thread Jan Piotrowski (Sujan) (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Piotrowski (Sujan) closed CB-13861.
---
Resolution: Invalid

> Update TargetPlatformVersion to 10.0.10586.0
> 
>
> Key: CB-13861
> URL: https://issues.apache.org/jira/browse/CB-13861
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: Jesse MacFadyen
>Assignee: Jesse MacFadyen
>Priority: Major
>
> For VS2017 Windows 10 projects we need to update TargetPlatformVersion to 
> 10.0.10586.0
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13870) `cordova requirements` is broken since change to default=UAP and with modern tooling

2018-02-13 Thread Jan Piotrowski (Sujan) (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363336#comment-16363336
 ] 

Jan Piotrowski (Sujan) commented on CB-13870:
-

Re 3: This is getting trickier and trickier. The version numbers are actually 
equal `15.5`, but the MSBuild Tools live in a folder called `15.0`. That means 
the logic in MSBuildTools.js is actually working to get the right stuff, but 
then fails when constructing the folder name.
It also can not handle multiple versions of the same MSBuildTools being 
installed, and _really_ doesn't know how to handle MSBuildTools that don't have 
all necessary packages installed.

> `cordova requirements` is broken since change to default=UAP and with modern 
> tooling
> 
>
> Key: CB-13870
> URL: https://issues.apache.org/jira/browse/CB-13870
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Blocker
>
> check_reqs.js 
> 1. doesn't know about "UAP", only "10.0"
> 2. doesn't know about VS2017 (so error messages are wrong)
> 3. doesn't know about current MSBuild tooling (so doesn't recognize it at all)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org