[jira] [Commented] (CB-13230) Remove service worker from cordova-browser
[ https://issues.apache.org/jira/browse/CB-13230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636556#comment-16636556 ] sandeep k gadhiya commented on CB-13230: hello , I want raised issue in Apache Cordova project But when i crate issue i dont get Apache Cordova as issue subject How i can create issue in Apache Cordova ?? > Remove service worker from cordova-browser > -- > > Key: CB-13230 > URL: https://issues.apache.org/jira/browse/CB-13230 > Project: Apache Cordova > Issue Type: Bug >Affects Versions: 5.0.0 >Reporter: Steve Gill >Assignee: Jesse MacFadyen >Priority: Major > Labels: browser-next > Fix For: 5.1.0 > > > It doesn't make sense to include service workers by default in > cordova-browser. We are better off documenting how to add service workers so > our users can do that. I think we need to delete > https://github.com/apache/cordova-browser/blob/master/bin/template/www/cordova-sw.js > and remove any references to cordova-sw.js > https://github.com/apache/cordova-browser/search?utf8=%E2%9C%93&q=cordova-sw.js&type= -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8659) iOS Plugins: Cordova-iOS 4.0.0 compatibility
[ https://issues.apache.org/jira/browse/CB-8659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636625#comment-16636625 ] sandeep k gadhiya commented on CB-8659: --- Hello , I want to raise issue on Apache cordova project but i dont get any project As Apache cordova while creating it How do i do I have raised issue in (AAR) as follows > iOS Plugins: Cordova-iOS 4.0.0 compatibility > > > Key: CB-8659 > URL: https://issues.apache.org/jira/browse/CB-8659 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios, cordova-plugin-battery-status, > cordova-plugin-camera, cordova-plugin-contacts (DEPRECATED), > cordova-plugin-device-orientation (DEPRECATED), cordova-plugin-dialogs, > cordova-plugin-file, cordova-plugin-geolocation, cordova-plugin-globalization > (DEPRECATED), cordova-plugin-inappbrowser, cordova-plugin-media, > cordova-plugin-media-capture >Affects Versions: 4.0.0 >Reporter: Ian Clelland >Assignee: Ian Clelland >Priority: Major > Labels: cordova-ios-4.0.x > > iOS Plugins need to stop using initWithWebView: > They also depend on several deprecated categories: > - NSArray+Comparisons.h > - NSDictionary+Extensions.h > These need to be fixed in a backwards-compatible way before 4.0.0 is released. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8659) iOS Plugins: Cordova-iOS 4.0.0 compatibility
[ https://issues.apache.org/jira/browse/CB-8659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636760#comment-16636760 ] Jan Piotrowski (Sujan) commented on CB-8659: See the list of repositories here: [https://github.com/apache/cordova] Use GitHub issues to report your problem. Please close your issue over at AAR - they have nothing to do with Cordova. > iOS Plugins: Cordova-iOS 4.0.0 compatibility > > > Key: CB-8659 > URL: https://issues.apache.org/jira/browse/CB-8659 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios, cordova-plugin-battery-status, > cordova-plugin-camera, cordova-plugin-contacts (DEPRECATED), > cordova-plugin-device-orientation (DEPRECATED), cordova-plugin-dialogs, > cordova-plugin-file, cordova-plugin-geolocation, cordova-plugin-globalization > (DEPRECATED), cordova-plugin-inappbrowser, cordova-plugin-media, > cordova-plugin-media-capture >Affects Versions: 4.0.0 >Reporter: Ian Clelland >Assignee: Ian Clelland >Priority: Major > Labels: cordova-ios-4.0.x > > iOS Plugins need to stop using initWithWebView: > They also depend on several deprecated categories: > - NSArray+Comparisons.h > - NSDictionary+Extensions.h > These need to be fixed in a backwards-compatible way before 4.0.0 is released. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13230) Remove service worker from cordova-browser
[ https://issues.apache.org/jira/browse/CB-13230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636757#comment-16636757 ] Jan Piotrowski (Sujan) commented on CB-13230: - See the list of repositories here: [https://github.com/apache/cordova] Use GitHub issues to report your problem. > Remove service worker from cordova-browser > -- > > Key: CB-13230 > URL: https://issues.apache.org/jira/browse/CB-13230 > Project: Apache Cordova > Issue Type: Bug >Affects Versions: 5.0.0 >Reporter: Steve Gill >Assignee: Jesse MacFadyen >Priority: Major > Labels: browser-next > Fix For: 5.1.0 > > > It doesn't make sense to include service workers by default in > cordova-browser. We are better off documenting how to add service workers so > our users can do that. I think we need to delete > https://github.com/apache/cordova-browser/blob/master/bin/template/www/cordova-sw.js > and remove any references to cordova-sw.js > https://github.com/apache/cordova-browser/search?utf8=%E2%9C%93&q=cordova-sw.js&type= -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637059#comment-16637059 ] ASF GitHub Bot commented on CB-7179: janpio commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-426670960 Ok, I found out _any_ commit will trigger a merge and thus use the updated test configuration from `master` - so I did a commit on this branch and am now waiting for test results ;) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637072#comment-16637072 ] ASF GitHub Bot commented on CB-7179: dpa99c commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-426675930 > Ok, I found out _any_ commit will trigger a merge and thus use the updated test configuration from `master` - so I did a commit on this branch and am now waiting for test results ;) Thanks Jan - sorry been flat out at work so not had time to look into this This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637075#comment-16637075 ] ASF GitHub Bot commented on CB-7179: janpio commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-426676178 Don't worry - that way I can "abuse" your PR to fix all this stuff ;) You updated the test configuration from `xcode7.3` to `xcode8.3` - is this fully required for this PR? Will people not be able to build with Xcode 7.3 any more? (Is Xcode 7.3 related in any way any more?) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637087#comment-16637087 ] ASF GitHub Bot commented on CB-7179: dpa99c commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-426681782 > Don't worry - that way I can "abuse" your PR to fix all this stuff ;) > > You updated the test configuration from `xcode7.3` to `xcode8.3` - is this fully required for this PR? Will people not be able to build with Xcode 7.3 any more? (Is Xcode 7.3 related in any way any more?) Yes, Xcode 8.3 is required for the iOS 10 SDK as some properties/class used by this PR don't exist in the iOS 9 SDK, e.g. [WKWebViewConfiguration.ignoresViewportScaleLimits](https://developer.apple.com/documentation/webkit/wkwebviewconfiguration/2274633-ignoresviewportscalelimits?language=objc) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637088#comment-16637088 ] ASF GitHub Bot commented on CB-7179: dpa99c edited a comment on issue #271: CB-7179 (iOS): Add WKWebView support for iOS URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-426681782 > Don't worry - that way I can "abuse" your PR to fix all this stuff ;) > > You updated the test configuration from `xcode7.3` to `xcode8.3` - is this fully required for this PR? Will people not be able to build with Xcode 7.3 any more? (Is Xcode 7.3 related in any way any more?) Yes, Xcode 8.3 is required for the iOS 10 SDK as some properties/class used by this PR don't exist in the iOS 9 SDK, e.g. [WKWebViewConfiguration.mediaTypesRequiringUserActionForPlayback](https://developer.apple.com/documentation/webkit/wkwebviewconfiguration/1851524-mediatypesrequiringuseractionfor?language=objc) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637119#comment-16637119 ] ASF GitHub Bot commented on CB-7179: janpio commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-426693917 Ok thanks, so the iOS 9.3 test I readded should probably fail. But currently both are failing: ``` ... cordova-paramedic: waiting for test results appium: Error: [execute(null,[])] getaddrinfo ENOTFOUND ondemand.saucelabs.com ondemand.saucelabs.com:80 cordova-paramedic: Tests failed to complete; ending appium session. The error is: Error: waitForTests: Seems like device not connected to local server in 540 secs at null._onTimeout (/private/tmp/paramedic/lib/paramedic.js:467:24) at Timer.listOnTimeout (timers.js:92:15) ... ``` *sigh (Investigating) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14182) Cordova 7 and 8 cannot add plugin from our bitbucket
[
https://issues.apache.org/jira/browse/CB-14182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637121#comment-16637121
]
silvia Muñoz Atienza commented on CB-14182:
---
I have the same problem. any ideas?
> Cordova 7 and 8 cannot add plugin from our bitbucket
>
>
> Key: CB-14182
> URL: https://issues.apache.org/jira/browse/CB-14182
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-cli
>Affects Versions: cordova@7.0.0, cordova@8.0.0
>Reporter: Marcos
>Priority: Blocker
>
> Hi, im trying to install a custom cordova plugin we made, that is located in
> our corporative Bitbucket server:
> [https://cis.ieci-servicios.com/bitbucket/scm/omnia/nativepluginomnia.git]
> and it worked and installed fine with cordova 6.5 and bellow, but since
> cordova 7, it just refuses to install with the following error:
> Command: $ cordova plugin add
> [https://cis.ieci-servicios.com/bitbucket/scm/omnia/nativepluginomnia.git]
> {code:java}
> (node:27674) UnhandledPromiseRejectionWarning: CordovaError: Failed to fetch
> plugin
> https://cis.ieci-servicios.com/bitbucket/scm/omnia/nativepluginomnia.git via
> registry. Probably this is either a connection problem, or plugin spec is
> incorrect. Check your connection and plugin name/version/URL. Error: npm:
> Command failed with exit code 1 Error output: npm ERR! code E501 npm ERR! 501
> Not Implemented:
> https://cis.ieci-servicios.com/bitbucket/scm/omnia/nativepluginomnia.git npm
> ERR! A complete log of this run can be found in: npm ERR!
> /Users/a67303198/.npm/_logs/2018-06-29T10_34_27_047Z-debug.log at
> /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/fetch.js:173:37
> at _rejected
> (/usr/local/lib/node_modules/cordova/node_modules/q/q.js:864:24) at
> /usr/local/lib/node_modules/cordova/node_modules/q/q.js:890:30 at
> Promise.when
> (/usr/local/lib/node_modules/cordova/node_modules/q/q.js:1142:31) at
> Promise.promise.promiseDispatch
> (/usr/local/lib/node_modules/cordova/node_modules/q/q.js:808:41) at
> /usr/local/lib/node_modules/cordova/node_modules/q/q.js:624:44 at runSingle
> (/usr/local/lib/node_modules/cordova/node_modules/q/q.js:137:13) at flush
> (/usr/local/lib/node_modules/cordova/node_modules/q/q.js:125:13) at
> process._tickCallback (internal/process/next_tick.js:61:11) (node:27674)
> UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error
> originated either by throwing inside of an async function without a catch
> block, or by rejecting a promise which was not handled with .catch().
> (rejection id: 1) (node:27674) [DEP0018] DeprecationWarning: Unhandled
> promise rejections are deprecated. In the future, promise rejections that are
> not handled will terminate the Node.js process with a non-zero exit code.
> {code}
> The plugin is up to date, it has a package.json, it has everything i can
> think of that can cause a problem...
> Can someone help me?
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14024) Doesn't have into account statusbar height when toolbar is enabled
[
https://issues.apache.org/jira/browse/CB-14024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637127#comment-16637127
]
ASF GitHub Bot commented on CB-14024:
-
janpio commented on issue #265: CB-14024 Take into account statusbar height
when toolbar is enabled
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/265#issuecomment-426697967
Closing to retrigger CI.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Doesn't have into account statusbar height when toolbar is enabled
> --
>
> Key: CB-14024
> URL: https://issues.apache.org/jira/browse/CB-14024
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
>Affects Versions: cordova-ios 4.5.0
>Reporter: Humberto Alfonso Díaz
>Priority: Major
> Labels: inappbrowser, ios
>
> When using the following configuration:
> {code:java}
> this.browser.create(element.url, '_blank',"toolbar=yes,toolbarposition=top");
> {code}
> the plugin doesn't takes into account he statusbar height causing the webpage
> to not show properly on the header.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14024) Doesn't have into account statusbar height when toolbar is enabled
[
https://issues.apache.org/jira/browse/CB-14024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637130#comment-16637130
]
ASF GitHub Bot commented on CB-14024:
-
humbertuning opened a new pull request #265: CB-14024 Take into account
statusbar height when toolbar is enabled
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/265
### Platforms affected
ios
### What does this PR do?
Solves the problem with the webs that are not shown properly when toolbar is
enabled on top:
`this.browser.create(element.url,
'_blank',"toolbar=yes,toolbarposition=top");`
### What testing has been done on this change?
It was tested on ios devices using the above configuration
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB- is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Doesn't have into account statusbar height when toolbar is enabled
> --
>
> Key: CB-14024
> URL: https://issues.apache.org/jira/browse/CB-14024
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
>Affects Versions: cordova-ios 4.5.0
>Reporter: Humberto Alfonso Díaz
>Priority: Major
> Labels: inappbrowser, ios
>
> When using the following configuration:
> {code:java}
> this.browser.create(element.url, '_blank',"toolbar=yes,toolbarposition=top");
> {code}
> the plugin doesn't takes into account he statusbar height causing the webpage
> to not show properly on the header.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14024) Doesn't have into account statusbar height when toolbar is enabled
[
https://issues.apache.org/jira/browse/CB-14024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637128#comment-16637128
]
ASF GitHub Bot commented on CB-14024:
-
janpio closed pull request #265: CB-14024 Take into account statusbar height
when toolbar is enabled
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/265
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/ios/CDVInAppBrowser.m b/src/ios/CDVInAppBrowser.m
index a581472dd..e79b08922 100644
--- a/src/ios/CDVInAppBrowser.m
+++ b/src/ios/CDVInAppBrowser.m
@@ -885,8 +885,8 @@ - (float) getStatusBarOffset {
}
- (void) rePositionViews {
-if ([_browserOptions.toolbarposition
isEqualToString:kInAppBrowserToolbarBarPositionTop]) {
-[self.webView setFrame:CGRectMake(self.webView.frame.origin.x,
TOOLBAR_HEIGHT, self.webView.frame.size.width, self.webView.frame.size.height)];
+if ((_browserOptions.toolbar) && ([_browserOptions.toolbarposition
isEqualToString:kInAppBrowserToolbarBarPositionTop])) {
+[self.webView setFrame:CGRectMake(self.webView.frame.origin.x,
TOOLBAR_HEIGHT + [self getStatusBarOffset], self.webView.frame.size.width,
self.webView.frame.size.height)];
[self.toolbar setFrame:CGRectMake(self.toolbar.frame.origin.x, [self
getStatusBarOffset], self.toolbar.frame.size.width,
self.toolbar.frame.size.height)];
}
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Doesn't have into account statusbar height when toolbar is enabled
> --
>
> Key: CB-14024
> URL: https://issues.apache.org/jira/browse/CB-14024
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
>Affects Versions: cordova-ios 4.5.0
>Reporter: Humberto Alfonso Díaz
>Priority: Major
> Labels: inappbrowser, ios
>
> When using the following configuration:
> {code:java}
> this.browser.create(element.url, '_blank',"toolbar=yes,toolbarposition=top");
> {code}
> the plugin doesn't takes into account he statusbar height causing the webpage
> to not show properly on the header.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14024) Doesn't have into account statusbar height when toolbar is enabled
[
https://issues.apache.org/jira/browse/CB-14024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637208#comment-16637208
]
ASF GitHub Bot commented on CB-14024:
-
janpio edited a comment on issue #265: CB-14024 Take into account statusbar
height when toolbar is enabled
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/265#issuecomment-425913163
Hey, I just fixed the problem that caused Android tests to fail in `master`.
~~Could you rebase this PR please? This should get rid of the Android failures
and possibly fix all test failures for this PR.~~
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Doesn't have into account statusbar height when toolbar is enabled
> --
>
> Key: CB-14024
> URL: https://issues.apache.org/jira/browse/CB-14024
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
>Affects Versions: cordova-ios 4.5.0
>Reporter: Humberto Alfonso Díaz
>Priority: Major
> Labels: inappbrowser, ios
>
> When using the following configuration:
> {code:java}
> this.browser.create(element.url, '_blank',"toolbar=yes,toolbarposition=top");
> {code}
> the plugin doesn't takes into account he statusbar height causing the webpage
> to not show properly on the header.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12468) cordova-inappbrowser-plugin setDefaultOptions method
[ https://issues.apache.org/jira/browse/CB-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637220#comment-16637220 ] ASF GitHub Bot commented on CB-12468: - IvanProdaiko94 opened a new pull request #213: CB-12468 added ability to set|get default options; URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/213 While using plugin I must set popup features only when calling window.open method. But a lot of libraries (firebase, openFB) use window.open inside their own code where I can't directly menage the features of window to be opened, and on IOS, where we do not a have a 'back' button we could have a problem. For example window, opened with 'toolbar=no' will make app to stack with no ability to close the window. Another thing to be mentioned is when on IOS you use attribute, after opening a new window without setting 'allowInlineMediaPlayback=yes' all inline attributes will stop working properly and video will start to open in a fullscreen mode. So, my proposal is to provide an ability to setDefaultOptions method that will help to prevent external libraries to manage the options of of window to be opened directly. If pass a '(required)' in option like that 'location=no(required)' than any option provided in window.open method will not affect on the default settings. I tested it in my projects (IOS|Android), and everything works fine; This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova-inappbrowser-plugin setDefaultOptions method > > > Key: CB-12468 > URL: https://issues.apache.org/jira/browse/CB-12468 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-lib >Affects Versions: 3.5.0 > Environment: IOS/Android >Reporter: Ivan Prodaiko >Priority: Major > Labels: features > Fix For: Master > > > While using cordova-inappbrowser-plugin I must set popup features only when > calling window.open method. But a lot of libraries (firebase, openFB) use > window.open inside their own code where I can't directly menage the features > of window to be opened, and on IOS, where we do not a have a 'back' button we > could have a problem. For example window, opened with 'toolbar=no' will make > app to stack with no ability to close the window. Another thing to be > mentioned is when on IOS you use attribute, after opening a > new window without setting 'allowInlineMediaPlayback=yes' all inline > attributes will stop working properly and video will start to open in a > fullscreen mode. > So, my proposal is to provide an ability to setDefaultOptions method that > will help to prevent external libraries to manage the options of of window to > be opened directly. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12468) cordova-inappbrowser-plugin setDefaultOptions method
[ https://issues.apache.org/jira/browse/CB-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637218#comment-16637218 ] ASF GitHub Bot commented on CB-12468: - janpio commented on issue #213: CB-12468 added ability to set|get default options; URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/213#issuecomment-426718606 Closing and re-opening to trigger a new CI/test run with new PR merge. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova-inappbrowser-plugin setDefaultOptions method > > > Key: CB-12468 > URL: https://issues.apache.org/jira/browse/CB-12468 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-lib >Affects Versions: 3.5.0 > Environment: IOS/Android >Reporter: Ivan Prodaiko >Priority: Major > Labels: features > Fix For: Master > > > While using cordova-inappbrowser-plugin I must set popup features only when > calling window.open method. But a lot of libraries (firebase, openFB) use > window.open inside their own code where I can't directly menage the features > of window to be opened, and on IOS, where we do not a have a 'back' button we > could have a problem. For example window, opened with 'toolbar=no' will make > app to stack with no ability to close the window. Another thing to be > mentioned is when on IOS you use attribute, after opening a > new window without setting 'allowInlineMediaPlayback=yes' all inline > attributes will stop working properly and video will start to open in a > fullscreen mode. > So, my proposal is to provide an ability to setDefaultOptions method that > will help to prevent external libraries to manage the options of of window to > be opened directly. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12468) cordova-inappbrowser-plugin setDefaultOptions method
[
https://issues.apache.org/jira/browse/CB-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637219#comment-16637219
]
ASF GitHub Bot commented on CB-12468:
-
janpio closed pull request #213: CB-12468 added ability to set|get default
options;
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/213
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.gitignore b/.gitignore
index f63dbbf71..ebfceb4b9 100644
--- a/.gitignore
+++ b/.gitignore
@@ -14,7 +14,7 @@ Thumbs.db
*.idea
node_modules
-
+.idea/
diff --git a/README.md b/README.md
index eade58a37..00140e627 100644
--- a/README.md
+++ b/README.md
@@ -81,12 +81,12 @@ Report issues with this plugin on the [Apache Cordova issue
tracker](https://iss
If you want all page loads in your app to go through the InAppBrowser, you can
simply hook `window.open` during initialization. For example:
-
+```javascript
document.addEventListener("deviceready", onDeviceReady, false);
function onDeviceReady() {
window.open = cordova.InAppBrowser.open;
}
-
+```
## cordova.InAppBrowser.open
Opens a URL in a new `InAppBrowser` instance, the current browser
@@ -203,6 +203,27 @@ The object returned from a call to
`cordova.InAppBrowser.open` when the target i
- executeScript
- insertCSS
+## cordova.InAppBrowser.setDefaultOptions
+
+> Set default options for all instances of InAppBrowser;
+
+cordova.InAppBrowser.setDefaultOptions(options);
+
+## Example
+All options that have required attrinbute will be used even if another options
will be provided in window.open.
+In other cases new and default will merge together
+
+```javascript
+
cordova.InAppBrowser.setDefaultOptions('location=no(required),toolbar=yes(required),closebuttoncaption=Close');
+```
+
+## cordova.InAppBrowser.setDefaultOptions
+
+> Get default options for all instances of InAppBrowser;
+
+cordova.InAppBrowser.getDefaultOptions();
+
+
## InAppBrowser.addEventListener
> Adds a listener for an event from the `InAppBrowser`. (Only available when
> the target is set to `'_blank'`)
diff --git a/plugin.xml b/plugin.xml
index 4a820ddc4..bdde94a83 100644
--- a/plugin.xml
+++ b/plugin.xml
@@ -30,15 +30,21 @@
https://issues.apache.org/jira/browse/CB/component/12320641
-
+
+
+
+
+
+
+
@@ -70,9 +76,15 @@
+
+
+
+
+
+
@@ -80,9 +92,9 @@
-
+
-
+
@@ -107,6 +119,13 @@
+
+
+
+
+
+
+
@@ -116,9 +135,15 @@
+
+
+
+
+
+
diff --git a/types/index.d.ts b/types/index.d.ts
index 3bac6707b..ea428a0dc 100644
--- a/types/index.d.ts
+++ b/types/index.d.ts
@@ -25,6 +25,11 @@ interface Window {
* NOTE: The InAppBrowser window behaves like a standard web browser, and
can't access Cordova APIs.
*/
interface InAppBrowser extends Window {
+
+options: string;
+setDefaultOptions(opts: string): void;
+getDefaultOptions(): string;
+
onloadstart(type: Event): void;
onloadstop(type: InAppBrowserEvent): void;
onloaderror(type: InAppBrowserEvent): void;
diff --git a/www/inappbrowser.js b/www/inappbrowser.js
index 3619f173f..512e03242 100644
--- a/www/inappbrowser.js
+++ b/www/inappbrowser.js
@@ -28,8 +28,6 @@
var exec = require('cordova/exec');
var channel = require('cordova/channel');
-var modulemapper = require('cordova/modulemapper');
-var urlutil = require('cordova/urlutil');
function InAppBrowser () {
this.channels = {
@@ -41,6 +39,16 @@
};
}
+InAppBrowser.options = '';
+
+InAppBrowser.setDefaultOptions = function (str) {
+InAppBrowser.options = str || '';
+};
+
+InAppBrowser.getDefaultOptions = function () {
+return InAppBrowser.options || '';
+};
+
InAppBrowser.prototype = {
_eventHandler: function (event) {
if (event && (event.type in this.channels)) {
@@ -88,28 +96,7 @@
}
};
-module.exports = function (strUrl, strWindowName, strWindowFeatures,
callbacks) {
-// Don
[jira] [Commented] (CB-13502) Android - add support for "setRate" method already available on iOS
[
https://issues.apache.org/jira/browse/CB-13502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637223#comment-16637223
]
ASF GitHub Bot commented on CB-13502:
-
janpio closed pull request #152: CB-13502: (android) Implementation of setRate
method for Android Marshmallow and later
URL: https://github.com/apache/cordova-plugin-media/pull/152
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.travis.yml b/.travis.yml
index 59a576db..dcad4ad5 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -4,7 +4,7 @@ addons:
secure:
M4uBGUMbanDtCBrNktJhEwNSLL0UsOV3IoINqW3GRupX7Mr13MBZzsORm4HVbdbPxQ6Bf2LhyJ/fabQRsOoJrCokgWwfKkigztQcMFeLNao9liBRA6kuQOh5/rdfoULpu96GvlYzB4ddgSBSSGQW3DesaKC/BpTXnvQ4OnXo5e4=
env:
global:
- - SAUCE_USERNAME=snay
+ - SAUCE_USERNAME=jh3141
- TRAVIS_NODE_VERSION="4.2"
matrix:
include:
diff --git a/README.md b/README.md
index 577cd388..41b894cb 100644
--- a/README.md
+++ b/README.md
@@ -23,36 +23,25 @@ description: Record and play audio on the device.
|AppVeyor|Travis CI|
|:-:|:-:|
-|[](https://ci.appveyor.com/project/ApacheSoftwareFoundation/cordova-plugin-media)|[](https://travis-ci.org/apache/cordova-plugin-media)|
+|[](https://ci.appveyor.com/project/ApacheSoftwareFoundation/cordova-plugin-media)|[](https://travis-ci.org/jh3141/cordova-plugin-media)|
# cordova-plugin-media
-This plugin provides the ability to record and play back audio files on a
device.
+This is a forked version of the cordova-plugin-media plugin, which provides
the ability to record
+and play back audio files on a device. This fork adds the following changes:
-__NOTE__: The current implementation does not adhere to a W3C
-specification for media capture, and is provided for convenience only.
-A future implementation will adhere to the latest W3C specification
-and may deprecate the current APIs.
-
-This plugin defines a global `Media` Constructor.
-
-Although in the global scope, it is not available until after the
`deviceready` event.
-
-```js
-document.addEventListener("deviceready", onDeviceReady, false);
-function onDeviceReady() {
-console.log(Media);
-}
-```
-
-Report issues with this plugin on the [Apache Cordova issue
tracker](https://issues.apache.org/jira/issues/?jql=project%20%3D%20CB%20AND%20status%20in%20(Open%2C%20%22In%20Progress%22%2C%20Reopened)%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20%22cordova-plugin-media%22%20ORDER%20BY%20priority%20DESC%2C%20summary%20ASC%2C%20updatedDate%20DESC)
+* Support the `setRate` API under Android
+* Fix broken tests
+Additional updates are planned for better handling of background playing, and
supporting background
+application use. If they aren't available here yet, there may be development
versions in branches
+that haven't been merged yet; have a look at those if you're interested.
## Installation
```bash
-cordova plugin add cordova-plugin-media
+cordova plugin add https://github.com/jh3141/cordova-plugin-media
```
## Supported Platforms
@@ -322,9 +311,13 @@ function recordAudio() {
Starts or resumes playing an audio file.
```js
-media.play();
+media.play(options);
```
+* Options specifies optional settings for player behaviour, and may be omitted
if
+ the defaults are to be used. See the platform-specific descriptions below
for
+ available options.
+
### Quick Example
```js
diff --git a/src/android/AudioHandler.java b/src/android/AudioHandler.java
index 9e734c44..f3ad938d 100644
--- a/src/android/AudioHandler.java
+++ b/src/android/AudioHandler.java
@@ -129,13 +129,20 @@ else if (action.equals("resumeRecordingAudio")) {
else if (action.equals("startPlayingAudio")) {
String target = args.getString(1);
String fileUriStr;
+boolean ignoreFocusLost;
try {
Uri targetUri = resourceApi.remapUri(Uri.parse(target));
fileUriStr = targetUri.toString();
} catch (IllegalArgumentException e) {
fileUriStr = target;
}
-this.startPlayingAudio(args.getString(0),
FileHelper.stripFileProtocol(fileUriStr));
+try {
+ignoreFocusLost =
args.getJSONObject(2).getBoolean("ignoreFocusLost");
+} catch (JSONException ign
[jira] [Commented] (CB-13502) Android - add support for "setRate" method already available on iOS
[ https://issues.apache.org/jira/browse/CB-13502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637222#comment-16637222 ] ASF GitHub Bot commented on CB-13502: - janpio commented on issue #152: CB-13502: (android) Implementation of setRate method for Android Marshmallow and later URL: https://github.com/apache/cordova-plugin-media/pull/152#issuecomment-426719104 Closing and re-opening to trigger a new CI/test run with new PR merge. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Android - add support for "setRate" method already available on iOS > --- > > Key: CB-13502 > URL: https://issues.apache.org/jira/browse/CB-13502 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-media >Reporter: Julian Hall >Priority: Minor > > The iOS media plugin supports a method "setRate" which changes the playback > rate. Android has support for this feature in the MediaPlayer class used by > the media plugin since API version 23 (Marshmallow), therefore supporting > this method there is very easy. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13502) Android - add support for "setRate" method already available on iOS
[ https://issues.apache.org/jira/browse/CB-13502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637224#comment-16637224 ] ASF GitHub Bot commented on CB-13502: - jh3141 opened a new pull request #152: CB-13502: (android) Implementation of setRate method for Android Marshmallow and later URL: https://github.com/apache/cordova-plugin-media/pull/152 ### Platforms affected Android ### What does this PR do? Support the "setRate" method already supported on iOS for Android Marshmallow devices (API 23) or later. ### What testing has been done on this change? Tested manually on two devices running different vendor versions of Android 6.0. No automated test provided, as I can't see how to restrict the test environment such that the test only runs on Android versions that support the feature. I imagine somebody more familiar than myself can easily update media.spec.24 to reflect the change. ### Checklist - [X ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Android - add support for "setRate" method already available on iOS > --- > > Key: CB-13502 > URL: https://issues.apache.org/jira/browse/CB-13502 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-media >Reporter: Julian Hall >Priority: Minor > > The iOS media plugin supports a method "setRate" which changes the playback > rate. Android has support for this feature in the MediaPlayer class used by > the media plugin since API version 23 (Marshmallow), therefore supporting > this method there is very easy. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13852) cordova-plugin-media getPosition audio failed
[ https://issues.apache.org/jira/browse/CB-13852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637225#comment-16637225 ] ASF GitHub Bot commented on CB-13852: - janpio commented on issue #165: CB-13852: (iOS) Fix bug prevent error on getPosition URL: https://github.com/apache/cordova-plugin-media/pull/165#issuecomment-426719900 Closing and re-opening to trigger a new CI/test run with new PR merge. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova-plugin-media getPosition audio failed > - > > Key: CB-13852 > URL: https://issues.apache.org/jira/browse/CB-13852 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-media >Affects Versions: cordova-ios 4.5.0 > Environment: iOS all versions >Reporter: Juan Sebastian Dussan Cubides >Priority: Minor > > (iOS) > When I try to get the position of an audio that had an error while loading, > the crash appose exponentially because it can not cast the time = none -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13852) cordova-plugin-media getPosition audio failed
[
https://issues.apache.org/jira/browse/CB-13852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637226#comment-16637226
]
ASF GitHub Bot commented on CB-13852:
-
janpio closed pull request #165: CB-13852: (iOS) Fix bug prevent error on
getPosition
URL: https://github.com/apache/cordova-plugin-media/pull/165
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/package.json b/package.json
index b7b2eb1f..8bf0e69d 100644
--- a/package.json
+++ b/package.json
@@ -1,5 +1,6 @@
{
"name": "cordova-plugin-media",
+
"version": "5.0.3-dev",
"description": "Cordova Media Plugin",
"types": "./types/index.d.ts",
diff --git a/src/ios/CDVSound.m b/src/ios/CDVSound.m
index 7a00eadf..075d3504 100644
--- a/src/ios/CDVSound.m
+++ b/src/ios/CDVSound.m
@@ -643,6 +643,10 @@ -
(void)getCurrentPositionAudio:(CDVInvokedUrlCommand*)command
position = CMTimeGetSeconds(time);
}
+if (isnan(position)){
+position = -1;
+}
+
CDVPluginResult* result = [CDVPluginResult
resultWithStatus:CDVCommandStatus_OK messageAsDouble:position];
[self onStatus:MEDIA_POSITION mediaId:mediaId param:@(position)];
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> cordova-plugin-media getPosition audio failed
> -
>
> Key: CB-13852
> URL: https://issues.apache.org/jira/browse/CB-13852
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-plugin-media
>Affects Versions: cordova-ios 4.5.0
> Environment: iOS all versions
>Reporter: Juan Sebastian Dussan Cubides
>Priority: Minor
>
> (iOS)
> When I try to get the position of an audio that had an error while loading,
> the crash appose exponentially because it can not cast the time = none
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13852) cordova-plugin-media getPosition audio failed
[ https://issues.apache.org/jira/browse/CB-13852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637229#comment-16637229 ] ASF GitHub Bot commented on CB-13852: - jsdussanc opened a new pull request #165: CB-13852: (iOS) Fix bug prevent error on getPosition URL: https://github.com/apache/cordova-plugin-media/pull/165 When I try to get the position of an audio that had an error while loading, the crash appose exponentially because it can not cast the time = none ### Platforms affected iOS xx ### What does this PR do? if the time is none, return the value of position at default = -1 ### What testing has been done on this change? It does not affect much, I tested it in my personal project ### Checklist - [ x ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ x ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. (I don`t know) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova-plugin-media getPosition audio failed > - > > Key: CB-13852 > URL: https://issues.apache.org/jira/browse/CB-13852 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-media >Affects Versions: cordova-ios 4.5.0 > Environment: iOS all versions >Reporter: Juan Sebastian Dussan Cubides >Priority: Minor > > (iOS) > When I try to get the position of an audio that had an error while loading, > the crash appose exponentially because it can not cast the time = none -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13243) Don't reset default audio session category when release
[ https://issues.apache.org/jira/browse/CB-13243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637233#comment-16637233 ] ASF GitHub Bot commented on CB-13243: - hannut91 opened a new pull request #147: CB-13243: (iOS) Reset default audio session category when release URL: https://github.com/apache/cordova-plugin-media/pull/147 ### Platforms affected iOS ### What does this PR do? Fix plugin ### What testing has been done on this change? After recording and releasing, can play other audio source output. ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Don't reset default audio session category when release > --- > > Key: CB-13243 > URL: https://issues.apache.org/jira/browse/CB-13243 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-media >Reporter: Yunseok Han >Priority: Major > Labels: ios > > When recording is released, don't set category. > all audio output in app is not working. > So have to set basic category of avsession to > AVAudioSessionCategorySoloAmbient -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13243) Don't reset default audio session category when release
[
https://issues.apache.org/jira/browse/CB-13243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637232#comment-16637232
]
ASF GitHub Bot commented on CB-13243:
-
janpio closed pull request #147: CB-13243: (iOS) Reset default audio session
category when release
URL: https://github.com/apache/cordova-plugin-media/pull/147
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/ios/CDVSound.m b/src/ios/CDVSound.m
index e1542871..1c2cd7b3 100644
--- a/src/ios/CDVSound.m
+++ b/src/ios/CDVSound.m
@@ -601,6 +601,7 @@ - (void)release:(CDVInvokedUrlCommand*)command
avPlayer = nil;
}
if (self.avSession) {
+[self.avSession setCategory:AVAudioSessionCategorySoloAmbient
error:nil];
[self.avSession setActive:NO error:nil];
self.avSession = nil;
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Don't reset default audio session category when release
> ---
>
> Key: CB-13243
> URL: https://issues.apache.org/jira/browse/CB-13243
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-media
>Reporter: Yunseok Han
>Priority: Major
> Labels: ios
>
> When recording is released, don't set category.
> all audio output in app is not working.
> So have to set basic category of avsession to
> AVAudioSessionCategorySoloAmbient
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13774) cordova-plugin-media broken recording and playback functionality
[
https://issues.apache.org/jira/browse/CB-13774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637228#comment-16637228
]
ASF GitHub Bot commented on CB-13774:
-
janpio closed pull request #164: CB-13774: repair broken recording and playback
functionality on Android
URL: https://github.com/apache/cordova-plugin-media/pull/164
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/android/AudioPlayer.java b/src/android/AudioPlayer.java
index 861421e7..40b12378 100644
--- a/src/android/AudioPlayer.java
+++ b/src/android/AudioPlayer.java
@@ -151,8 +151,8 @@ public void startRecording(String file) {
this.audioFile = file;
this.recorder = new MediaRecorder();
this.recorder.setAudioSource(MediaRecorder.AudioSource.MIC);
-
this.recorder.setOutputFormat(MediaRecorder.OutputFormat.AAC_ADTS); // RAW_AMR);
-this.recorder.setAudioEncoder(MediaRecorder.AudioEncoder.AAC);
//AMR_NB);
+this.recorder.setOutputFormat(MediaRecorder.OutputFormat.DEFAULT);
+this.recorder.setAudioEncoder(MediaRecorder.AudioEncoder.DEFAULT);
this.tempFile = generateTempFile();
this.recorder.setOutputFile(this.tempFile);
try {
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> cordova-plugin-media broken recording and playback functionality
> -
>
> Key: CB-13774
> URL: https://issues.apache.org/jira/browse/CB-13774
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-media
> Environment: Android
>Reporter: Mark Mitchell
>Priority: Blocker
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The problem seems to be that somehow the encoder and decoder are set to
> different encoding types and are not compatible. Additionally its assuming an
> encoder is available on the platform and since the interface to the this
> object does not allow a way to specifying encoding I feel like the default
> may have been more appropriate.
> Currently the code is as follows
> {code:java}
> this.recorder.setOutputFormat(MediaRecorder.OutputFormat.AAC_ADTS); //
> RAW_AMR);
> this.recorder.setAudioEncoder(MediaRecorder.AudioEncoder.AAC); //AMR_NB);
> {code}
> But trying to play back the recorded audio fails with a decoder error
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13774) cordova-plugin-media broken recording and playback functionality
[
https://issues.apache.org/jira/browse/CB-13774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637230#comment-16637230
]
ASF GitHub Bot commented on CB-13774:
-
carcus88 opened a new pull request #164: CB-13774: repair broken recording and
playback functionality on Android
URL: https://github.com/apache/cordova-plugin-media/pull/164
Revert back to plugins original use of DEFAULT as the audio encode and
decoder.
### Platforms affected
Android
### What does this PR do?
Puts the media encoder/decoder back to DEFAULT
### What testing has been done on this change?
I created a repo that shows the current media plugin failing. Applying the
code in this pull request will show it passing.
https://github.com/medsurvey/cordova-media-bug
The problem seems to be that somehow the encoder and decoder are set to
different encoding types and are not compatible. Additionally its assuming an
encoder is available on the platform and since the interface to the this object
does not allow a way to specifying encoding I feel like the default may have
been more appropriate.
### Checklist
*Could not complete these as I don't have access*
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB- is the JIRA ID & "android" is the platform
affected.
- [] Added automated test coverage as appropriate for this change.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> cordova-plugin-media broken recording and playback functionality
> -
>
> Key: CB-13774
> URL: https://issues.apache.org/jira/browse/CB-13774
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-media
> Environment: Android
>Reporter: Mark Mitchell
>Priority: Blocker
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The problem seems to be that somehow the encoder and decoder are set to
> different encoding types and are not compatible. Additionally its assuming an
> encoder is available on the platform and since the interface to the this
> object does not allow a way to specifying encoding I feel like the default
> may have been more appropriate.
> Currently the code is as follows
> {code:java}
> this.recorder.setOutputFormat(MediaRecorder.OutputFormat.AAC_ADTS); //
> RAW_AMR);
> this.recorder.setAudioEncoder(MediaRecorder.AudioEncoder.AAC); //AMR_NB);
> {code}
> But trying to play back the recorded audio fails with a decoder error
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13774) cordova-plugin-media broken recording and playback functionality
[
https://issues.apache.org/jira/browse/CB-13774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637227#comment-16637227
]
ASF GitHub Bot commented on CB-13774:
-
janpio commented on issue #164: CB-13774: repair broken recording and playback
functionality on Android
URL:
https://github.com/apache/cordova-plugin-media/pull/164#issuecomment-426719933
Closing and re-opening to trigger a new CI/test run with new PR merge.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> cordova-plugin-media broken recording and playback functionality
> -
>
> Key: CB-13774
> URL: https://issues.apache.org/jira/browse/CB-13774
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-media
> Environment: Android
>Reporter: Mark Mitchell
>Priority: Blocker
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The problem seems to be that somehow the encoder and decoder are set to
> different encoding types and are not compatible. Additionally its assuming an
> encoder is available on the platform and since the interface to the this
> object does not allow a way to specifying encoding I feel like the default
> may have been more appropriate.
> Currently the code is as follows
> {code:java}
> this.recorder.setOutputFormat(MediaRecorder.OutputFormat.AAC_ADTS); //
> RAW_AMR);
> this.recorder.setAudioEncoder(MediaRecorder.AudioEncoder.AAC); //AMR_NB);
> {code}
> But trying to play back the recorded audio fails with a decoder error
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13243) Don't reset default audio session category when release
[ https://issues.apache.org/jira/browse/CB-13243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637231#comment-16637231 ] ASF GitHub Bot commented on CB-13243: - janpio commented on issue #147: CB-13243: (iOS) Reset default audio session category when release URL: https://github.com/apache/cordova-plugin-media/pull/147#issuecomment-426719994 Closing and re-opening to trigger a new CI/test run with new PR merge. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Don't reset default audio session category when release > --- > > Key: CB-13243 > URL: https://issues.apache.org/jira/browse/CB-13243 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-media >Reporter: Yunseok Han >Priority: Major > Labels: ios > > When recording is released, don't set category. > all audio output in app is not working. > So have to set basic category of avsession to > AVAudioSessionCategorySoloAmbient -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11714) Camera plugin for windows does not properly set content-type when selecting JPG->PNG
[ https://issues.apache.org/jira/browse/CB-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637234#comment-16637234 ] ASF GitHub Bot commented on CB-11714: - janpio commented on issue #242: CB-11714: (windows) added check for encoding in savePhoto() without height/width URL: https://github.com/apache/cordova-plugin-camera/pull/242#issuecomment-426720800 Closing and re-opening to trigger a new CI/test run with new PR merge. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Camera plugin for windows does not properly set content-type when selecting > JPG->PNG > > > Key: CB-11714 > URL: https://issues.apache.org/jira/browse/CB-11714 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Affects Versions: Master > Environment: Windows 10 >Reporter: Tyler Pham >Priority: Major > Labels: easyfix, triaged, windows > > When selecting a JPG with encodingType = Camera.EncodingType.PNG, the > resizeImage() will not modify the target content type when converting > canvas.toDataURL(...) -- the content-type will still be image/jpeg but with a > .png extension which will cause the browser to not render to image and issue > an error. > Possibly related to: CB-8618 > I have created a small fix at: > https://github.com/DisruptiveMind/cordova-plugin-camera/tree/fix-windows-content-type -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11714) Camera plugin for windows does not properly set content-type when selecting JPG->PNG
[ https://issues.apache.org/jira/browse/CB-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637236#comment-16637236 ] ASF GitHub Bot commented on CB-11714: - DisruptiveMind opened a new pull request #242: CB-11714: (windows) added check for encoding in savePhoto() without height/width URL: https://github.com/apache/cordova-plugin-camera/pull/242 ### Platforms affected Windows 10 ### What does this PR do? Adds extra content-type check when capturing photos without specifying targetWidth and/or targetHeight in options to preserve JPEG file extension. ### What testing has been done on this change? ditto ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Camera plugin for windows does not properly set content-type when selecting > JPG->PNG > > > Key: CB-11714 > URL: https://issues.apache.org/jira/browse/CB-11714 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Affects Versions: Master > Environment: Windows 10 >Reporter: Tyler Pham >Priority: Major > Labels: easyfix, triaged, windows > > When selecting a JPG with encodingType = Camera.EncodingType.PNG, the > resizeImage() will not modify the target content type when converting > canvas.toDataURL(...) -- the content-type will still be image/jpeg but with a > .png extension which will cause the browser to not render to image and issue > an error. > Possibly related to: CB-8618 > I have created a small fix at: > https://github.com/DisruptiveMind/cordova-plugin-camera/tree/fix-windows-content-type -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11714) Camera plugin for windows does not properly set content-type when selecting JPG->PNG
[
https://issues.apache.org/jira/browse/CB-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637235#comment-16637235
]
ASF GitHub Bot commented on CB-11714:
-
janpio closed pull request #242: CB-11714: (windows) added check for encoding
in savePhoto() without height/width
URL: https://github.com/apache/cordova-plugin-camera/pull/242
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/windows/CameraProxy.js b/src/windows/CameraProxy.js
index eb10cd2a..9362be5a 100644
--- a/src/windows/CameraProxy.js
+++ b/src/windows/CameraProxy.js
@@ -800,9 +800,14 @@ function savePhoto(picture, options, successCallback,
errorCallback) {
if (options.targetHeight > 0 && options.targetWidth > 0) {
resizeImage(successCallback, errorCallback, picture,
options.targetWidth, options.targetHeight, options.encodingType);
} else {
+// CB-11714: check if target content-type is PNG to just
rename as *.jpg since camera is captured as JPEG
+if (options.encodingType === Camera.EncodingType.PNG) {
+picture.name = picture.name.replace(/\.png$/, ".jpg");
+}
+
picture.copyAsync(getAppData().localFolder, picture.name,
OptUnique).done(function (copiedFile) {
-successCallback("ms-appdata:///local/" + copiedFile.name);
-},errorCallback);
+successCallback('ms-appdata:///local/' + copiedFile.name);
+}, errorCallback);
}
} else {
if (options.targetHeight > 0 && options.targetWidth > 0) {
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Camera plugin for windows does not properly set content-type when selecting
> JPG->PNG
>
>
> Key: CB-11714
> URL: https://issues.apache.org/jira/browse/CB-11714
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-camera
>Affects Versions: Master
> Environment: Windows 10
>Reporter: Tyler Pham
>Priority: Major
> Labels: easyfix, triaged, windows
>
> When selecting a JPG with encodingType = Camera.EncodingType.PNG, the
> resizeImage() will not modify the target content type when converting
> canvas.toDataURL(...) -- the content-type will still be image/jpeg but with a
> .png extension which will cause the browser to not render to image and issue
> an error.
> Possibly related to: CB-8618
> I have created a small fix at:
> https://github.com/DisruptiveMind/cordova-plugin-camera/tree/fix-windows-content-type
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13316) Update documentation regarding browser quirks
[
https://issues.apache.org/jira/browse/CB-13316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637238#comment-16637238
]
ASF GitHub Bot commented on CB-13316:
-
janpio commented on issue #287: CB-13316: (browser) Updated readme browser
quirks
URL:
https://github.com/apache/cordova-plugin-camera/pull/287#issuecomment-426722244
Closing and re-opening to trigger a new CI/test run with new PR merge.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update documentation regarding browser quirks
> -
>
> Key: CB-13316
> URL: https://issues.apache.org/jira/browse/CB-13316
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-camera
>Affects Versions: Master, 2.4.1
> Environment: CLI 6.5.0@browser 4.1.0
> Using [cordova-simulate|https://github.com/Microsoft/cordova-simulate] in
> Chrome
>Reporter: Andres Zsogon
>Priority: Major
> Labels: browser, readme
>
> According to the README, the only *Browser Quirk* is:
> {quote}Can only return photos as Base64-encoded image.{quote}
> However this is not the case from my testing. Instead, I get this result:
> {noformat}
> blob:http://localhost:8000/259e6e9e-bb2f-47d0-939d-51461bd7d47c
> {noformat}
> Also, the image is not resized, it's returned in its natural size.
> This is the {{options}} object used:
> {code:javascript}
> var options = {
> quality: 100,
> destinationType: Camera.DestinationType.FILE_URI,
> sourceType: Camera.PictureSourceType.SAVEDPHOTOALBUM,
> encodingType: Camera.EncodingType.JPEG,
> mediaType: Camera.MediaType.PICTURE,
> allowEdit: true,
> correctOrientation: true,
> targetHeight: 240,
> targetWidth: 240
> }
> {code}
> Using {{Camera.DestinationType.DATA_URI}} does return a base64 encoded image
> but it *does not resize it* either, it returns in its original size.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13316) Update documentation regarding browser quirks
[
https://issues.apache.org/jira/browse/CB-13316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637239#comment-16637239
]
ASF GitHub Bot commented on CB-13316:
-
janpio closed pull request #287: CB-13316: (browser) Updated readme browser
quirks
URL: https://github.com/apache/cordova-plugin-camera/pull/287
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update documentation regarding browser quirks
> -
>
> Key: CB-13316
> URL: https://issues.apache.org/jira/browse/CB-13316
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-camera
>Affects Versions: Master, 2.4.1
> Environment: CLI 6.5.0@browser 4.1.0
> Using [cordova-simulate|https://github.com/Microsoft/cordova-simulate] in
> Chrome
>Reporter: Andres Zsogon
>Priority: Major
> Labels: browser, readme
>
> According to the README, the only *Browser Quirk* is:
> {quote}Can only return photos as Base64-encoded image.{quote}
> However this is not the case from my testing. Instead, I get this result:
> {noformat}
> blob:http://localhost:8000/259e6e9e-bb2f-47d0-939d-51461bd7d47c
> {noformat}
> Also, the image is not resized, it's returned in its natural size.
> This is the {{options}} object used:
> {code:javascript}
> var options = {
> quality: 100,
> destinationType: Camera.DestinationType.FILE_URI,
> sourceType: Camera.PictureSourceType.SAVEDPHOTOALBUM,
> encodingType: Camera.EncodingType.JPEG,
> mediaType: Camera.MediaType.PICTURE,
> allowEdit: true,
> correctOrientation: true,
> targetHeight: 240,
> targetWidth: 240
> }
> {code}
> Using {{Camera.DestinationType.DATA_URI}} does return a base64 encoded image
> but it *does not resize it* either, it returns in its original size.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13836) Windows phone correct filename
[ https://issues.apache.org/jira/browse/CB-13836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637246#comment-16637246 ] ASF GitHub Bot commented on CB-13836: - markdegrootnl opened a new pull request #311: CB-13836 Windows phone correct filename URL: https://github.com/apache/cordova-plugin-camera/pull/311 Windows: Change the filename to match Android behaviour. ### Platforms affected Windows ### What does this PR do? All photos are stored as 'photo.jpg' of 'photo.png'. Change the filename to match Android behaviour. ### What testing has been done on this change? Device tested ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Windows phone correct filename > -- > > Key: CB-13836 > URL: https://issues.apache.org/jira/browse/CB-13836 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-camera >Reporter: Mark de Groot >Priority: Minor > > All photos are stored as 'photo.jpg' of 'photo.png'. Change the filename to > match Android behaviour. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13316) Update documentation regarding browser quirks
[
https://issues.apache.org/jira/browse/CB-13316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637242#comment-16637242
]
ASF GitHub Bot commented on CB-13316:
-
janpio commented on issue #287: CB-13316: (browser) Updated readme browser
quirks
URL:
https://github.com/apache/cordova-plugin-camera/pull/287#issuecomment-426722739
Or not reopening as the source repo was deleted :(
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update documentation regarding browser quirks
> -
>
> Key: CB-13316
> URL: https://issues.apache.org/jira/browse/CB-13316
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-camera
>Affects Versions: Master, 2.4.1
> Environment: CLI 6.5.0@browser 4.1.0
> Using [cordova-simulate|https://github.com/Microsoft/cordova-simulate] in
> Chrome
>Reporter: Andres Zsogon
>Priority: Major
> Labels: browser, readme
>
> According to the README, the only *Browser Quirk* is:
> {quote}Can only return photos as Base64-encoded image.{quote}
> However this is not the case from my testing. Instead, I get this result:
> {noformat}
> blob:http://localhost:8000/259e6e9e-bb2f-47d0-939d-51461bd7d47c
> {noformat}
> Also, the image is not resized, it's returned in its natural size.
> This is the {{options}} object used:
> {code:javascript}
> var options = {
> quality: 100,
> destinationType: Camera.DestinationType.FILE_URI,
> sourceType: Camera.PictureSourceType.SAVEDPHOTOALBUM,
> encodingType: Camera.EncodingType.JPEG,
> mediaType: Camera.MediaType.PICTURE,
> allowEdit: true,
> correctOrientation: true,
> targetHeight: 240,
> targetWidth: 240
> }
> {code}
> Using {{Camera.DestinationType.DATA_URI}} does return a base64 encoded image
> but it *does not resize it* either, it returns in its original size.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13836) Windows phone correct filename
[
https://issues.apache.org/jira/browse/CB-13836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637245#comment-16637245
]
ASF GitHub Bot commented on CB-13836:
-
janpio closed pull request #311: CB-13836 Windows phone correct filename
URL: https://github.com/apache/cordova-plugin-camera/pull/311
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/windows/CameraProxy.js b/src/windows/CameraProxy.js
index e20d28d6..4325b800 100644
--- a/src/windows/CameraProxy.js
+++ b/src/windows/CameraProxy.js
@@ -833,12 +833,16 @@ function savePhoto (picture, options, successCallback,
errorCallback) {
};
savePicker.suggestedStartLocation = pickerLocId.picturesLibrary;
+var date = new Date();
+var isoDate = new Date(date.getTime() - (date.getTimezoneOffset() *
6)).toISOString();
+var fileName = 'IMG_' + isoDate.replace(/T/g, '_').replace(/[^\d^_]/g,
'');
+
if (options.encodingType === Camera.EncodingType.PNG) {
savePicker.fileTypeChoices.insert('PNG', ['.png']);
-savePicker.suggestedFileName = 'photo.png';
+savePicker.suggestedFileName = fileName + '.png';
} else {
savePicker.fileTypeChoices.insert('JPEG', ['.jpg']);
-savePicker.suggestedFileName = 'photo.jpg';
+savePicker.suggestedFileName = fileName + '.jpg';
}
// If Windows Phone 8.1 use pickSaveFileAndContinue()
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Windows phone correct filename
> --
>
> Key: CB-13836
> URL: https://issues.apache.org/jira/browse/CB-13836
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-plugin-camera
>Reporter: Mark de Groot
>Priority: Minor
>
> All photos are stored as 'photo.jpg' of 'photo.png'. Change the filename to
> match Android behaviour.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13836) Windows phone correct filename
[ https://issues.apache.org/jira/browse/CB-13836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637244#comment-16637244 ] ASF GitHub Bot commented on CB-13836: - janpio commented on issue #311: CB-13836 Windows phone correct filename URL: https://github.com/apache/cordova-plugin-camera/pull/311#issuecomment-426723004 Closing and re-opening to trigger a new CI/test run with new PR merge. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Windows phone correct filename > -- > > Key: CB-13836 > URL: https://issues.apache.org/jira/browse/CB-13836 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-camera >Reporter: Mark de Groot >Priority: Minor > > All photos are stored as 'photo.jpg' of 'photo.png'. Change the filename to > match Android behaviour. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14190) Double click `` element causes app to exit.
[ https://issues.apache.org/jira/browse/CB-14190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637249#comment-16637249 ] ASF GitHub Bot commented on CB-14190: - janpio commented on issue #275: CB-14190: (windows) Fix bug where double clicking `` exits app URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/275#issuecomment-426723440 Closing and re-opening to trigger a new CI/test run with new PR merge. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Double click `` element causes app to exit. > --- > > Key: CB-14190 > URL: https://issues.apache.org/jira/browse/CB-14190 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser, cordova-windows >Affects Versions: 3.0.0 >Reporter: Iain Connor >Assignee: Jesse MacFadyen >Priority: Minor > > In Windows, create an inappbrowser and browse somewhere with target not > `_system` or `_self` or empty. > Find a `` element and double click it. > Expected behaviour: > First click expands `` dropdown by showing ``s. > Second click is ignored or chooses `` under cursor, if there is one. > Actual behaviour: > Second click exits the inappbrowser. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14190) Double click `` element causes app to exit.
[ https://issues.apache.org/jira/browse/CB-14190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637251#comment-16637251 ] ASF GitHub Bot commented on CB-14190: - iainconnor opened a new pull request #275: CB-14190: (windows) Fix bug where double clicking `` exits app URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/275 Double clicking on `` elements will no longer exit the application. ### Platforms affected * Windows. ### What does this PR do? Previously, there was code which I assume was meant to detect a click outside the webview (and on the browser wrapper), and close the webview if such a click occurs. This makes sense if the webview is treated like a popup, but the code did not check if the target of the click was the webview itself. For whatever reason, double clicking a `` element triggered this behaviour, incorrectly closing the webview when the user is trying to interact with it. ### What testing has been done on this change? * Tested that double clicking a `` element no longer triggers the exit event. * Tested that a non-fullscreen inappbrowser still triggers the exit event if clicked outside of. ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Double click `` element causes app to exit. > --- > > Key: CB-14190 > URL: https://issues.apache.org/jira/browse/CB-14190 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser, cordova-windows >Affects Versions: 3.0.0 >Reporter: Iain Connor >Assignee: Jesse MacFadyen >Priority: Minor > > In Windows, create an inappbrowser and browse somewhere with target not > `_system` or `_self` or empty. > Find a `` element and double click it. > Expected behaviour: > First click expands `` dropdown by showing ``s. > Second click is ignored or chooses `` under cursor, if there is one. > Actual behaviour: > Second click exits the inappbrowser. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14190) Double click `` element causes app to exit.
[
https://issues.apache.org/jira/browse/CB-14190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637250#comment-16637250
]
ASF GitHub Bot commented on CB-14190:
-
janpio closed pull request #275: CB-14190: (windows) Fix bug where double
clicking `` exits app
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/275
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/windows/InAppBrowserProxy.js b/src/windows/InAppBrowserProxy.js
index 9e544c5d0..1af6b95f8 100644
--- a/src/windows/InAppBrowserProxy.js
+++ b/src/windows/InAppBrowserProxy.js
@@ -159,10 +159,12 @@ var IAB = {
// Save body overflow style to be able to reset it back
later
bodyOverflowStyle = document.body.style.msOverflowStyle;
-browserWrap.onclick = function () {
-setTimeout(function () {
-IAB.close(navigationEventsCallback);
-}, 0);
+browserWrap.onclick = function (e) {
+if (e.target !== popup) {
+setTimeout(function () {
+IAB.close(navigationEventsCallback);
+}, 0);
+}
};
document.body.appendChild(browserWrap);
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Double click `` element causes app to exit.
> ---
>
> Key: CB-14190
> URL: https://issues.apache.org/jira/browse/CB-14190
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser, cordova-windows
>Affects Versions: 3.0.0
>Reporter: Iain Connor
>Assignee: Jesse MacFadyen
>Priority: Minor
>
> In Windows, create an inappbrowser and browse somewhere with target not
> `_system` or `_self` or empty.
> Find a `` element and double click it.
> Expected behaviour:
> First click expands `` dropdown by showing ``s.
> Second click is ignored or chooses `` under cursor, if there is one.
> Actual behaviour:
> Second click exits the inappbrowser.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637262#comment-16637262 ] ASF GitHub Bot commented on CB-7179: janpio commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-426726557 And as it came it's gone - now the tests are just failing because they don't get their results from Saucelabs :/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12035) [cordova-plugin-network-information] connection info is not reliable on Android 6
[
https://issues.apache.org/jira/browse/CB-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637396#comment-16637396
]
ASF GitHub Bot commented on CB-12035:
-
PieterVanPoyer commented on issue #74: CB-12035 (android) Fix bug
[cordova-plugin-network-information] connection info is not reliable on Android
6
URL:
https://github.com/apache/cordova-plugin-network-information/pull/74#issuecomment-426763686
@janpio Hey Jan, should I do anything more for this pull request (request a
review, merge, ...)? Or do I leave it like it is.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [cordova-plugin-network-information] connection info is not reliable on
> Android 6
> -
>
> Key: CB-12035
> URL: https://issues.apache.org/jira/browse/CB-12035
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-network-information
>Affects Versions: 1.3.0
> Environment: Samsung Galaxy Edge S6 / Android 6
> useragent: "Mozilla/5.0 (Linux; Android 6.0.1; SM-G925F Build/MMB29K; wv)
> AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/53.0.2785.124
> Mobile Safari/537.36"
> reproduced with:
> cordova-plugin-network-information@1.3.0 (latest)
> cordova-plugin-network-information@1.2.0
>Reporter: jakub-g
>Priority: Major
> Labels: android
>
> I've noticed that information exposed by the plugin is not reliable. It
> happens often that I'm connected to the internet via WiFi, and the plugin
> says that there's no connection.
> It's not easy to reproduce it on-demand, but I reproduced it many times
> recently. It happens most often when in the morning, I open the Cordova app
> that was running in background throughout the night.
> Then, when I connect to Chrome Dev Tools, I can do a repl session like this:
> {code}
> > navigator.connection.type
> "none"
> > window.fetch('http://www.example.org').then(function(res)
> > {console.log(res.status)})
> Promise {[[PromiseStatus]]: "pending", [[PromiseValue]]: undefined}
> 200
> Fetch complete: GET "http://www.example.org/";.(anonymous function)
> > navigator.connection.type
> "none"
> {code}
> So, the plugin thinks I'm offline, yet any HTTP calls done within the app
> without checking if I'm offline or online, are successful (either from the
> app or devtools).
> When I disable WiFi and reenable it, after a few seconds the plugin updates
> its state and then it tells that connection type is "wifi".
> There are several possibilities here:
> - either system (or device driver) gives us incorrect information, or
> - cordova plugin is caching data and/or not listening properly to all the
> events and/or incorrectly processing it
> and most probably the issue manifests itself when the device is asleep for
> many hours (but I'm not sure about this).
> Note that I also noticed another issue, that sometimes the Chrome network
> stack thinks I'm offline (when I do an HTTP call, it fails immediately and I
> see network errors in devtools console) - and then I restart the Cordova app,
> and everything's fine, all HTTP calls are ok - but this is unrelated to this
> ticket, and perhaps a bug in Chrome.
> This ticket seems to be most likely a bug in the plugin, because as I said
> before, doing HTTP call succeeds despite the plugin telling me that I'm
> offline.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12035) [cordova-plugin-network-information] connection info is not reliable on Android 6
[
https://issues.apache.org/jira/browse/CB-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637401#comment-16637401
]
ASF GitHub Bot commented on CB-12035:
-
janpio commented on issue #74: CB-12035 (android) Fix bug
[cordova-plugin-network-information] connection info is not reliable on Android
6
URL:
https://github.com/apache/cordova-plugin-network-information/pull/74#issuecomment-426764955
No, for now there is not really anything you can do - someone will have to
come along and review it. (I'm currently working on fixing test failures across
all plugin PRs, so I am more than busy - and also don't know much about
Android) You could of course spend some time reviewing and commenting on other
PRs of this plugin or others - that might get you some karma 💃
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [cordova-plugin-network-information] connection info is not reliable on
> Android 6
> -
>
> Key: CB-12035
> URL: https://issues.apache.org/jira/browse/CB-12035
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-network-information
>Affects Versions: 1.3.0
> Environment: Samsung Galaxy Edge S6 / Android 6
> useragent: "Mozilla/5.0 (Linux; Android 6.0.1; SM-G925F Build/MMB29K; wv)
> AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/53.0.2785.124
> Mobile Safari/537.36"
> reproduced with:
> cordova-plugin-network-information@1.3.0 (latest)
> cordova-plugin-network-information@1.2.0
>Reporter: jakub-g
>Priority: Major
> Labels: android
>
> I've noticed that information exposed by the plugin is not reliable. It
> happens often that I'm connected to the internet via WiFi, and the plugin
> says that there's no connection.
> It's not easy to reproduce it on-demand, but I reproduced it many times
> recently. It happens most often when in the morning, I open the Cordova app
> that was running in background throughout the night.
> Then, when I connect to Chrome Dev Tools, I can do a repl session like this:
> {code}
> > navigator.connection.type
> "none"
> > window.fetch('http://www.example.org').then(function(res)
> > {console.log(res.status)})
> Promise {[[PromiseStatus]]: "pending", [[PromiseValue]]: undefined}
> 200
> Fetch complete: GET "http://www.example.org/";.(anonymous function)
> > navigator.connection.type
> "none"
> {code}
> So, the plugin thinks I'm offline, yet any HTTP calls done within the app
> without checking if I'm offline or online, are successful (either from the
> app or devtools).
> When I disable WiFi and reenable it, after a few seconds the plugin updates
> its state and then it tells that connection type is "wifi".
> There are several possibilities here:
> - either system (or device driver) gives us incorrect information, or
> - cordova plugin is caching data and/or not listening properly to all the
> events and/or incorrectly processing it
> and most probably the issue manifests itself when the device is asleep for
> many hours (but I'm not sure about this).
> Note that I also noticed another issue, that sometimes the Chrome network
> stack thinks I'm offline (when I do an HTTP call, it fails immediately and I
> see network errors in devtools console) - and then I restart the Cordova app,
> and everything's fine, all HTTP calls are ok - but this is unrelated to this
> ticket, and perhaps a bug in Chrome.
> This ticket seems to be most likely a bug in the plugin, because as I said
> before, doing HTTP call succeeds despite the plugin telling me that I'm
> offline.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637563#comment-16637563 ] ASF GitHub Bot commented on CB-7179: janpio commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-426823874 Confirmed that the switch to Xcode8.3 is not the cause for the test failures: https://github.com/apache/cordova-plugin-inappbrowser/pull/312 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11714) Camera plugin for windows does not properly set content-type when selecting JPG->PNG
[ https://issues.apache.org/jira/browse/CB-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637572#comment-16637572 ] ASF GitHub Bot commented on CB-11714: - brodybits commented on issue #242: CB-11714: (windows) added check for encoding in savePhoto() without height/width URL: https://github.com/apache/cordova-plugin-camera/pull/242#issuecomment-426827285 Looks OK to me, merging This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Camera plugin for windows does not properly set content-type when selecting > JPG->PNG > > > Key: CB-11714 > URL: https://issues.apache.org/jira/browse/CB-11714 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Affects Versions: Master > Environment: Windows 10 >Reporter: Tyler Pham >Priority: Major > Labels: easyfix, triaged, windows > > When selecting a JPG with encodingType = Camera.EncodingType.PNG, the > resizeImage() will not modify the target content type when converting > canvas.toDataURL(...) -- the content-type will still be image/jpeg but with a > .png extension which will cause the browser to not render to image and issue > an error. > Possibly related to: CB-8618 > I have created a small fix at: > https://github.com/DisruptiveMind/cordova-plugin-camera/tree/fix-windows-content-type -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11714) Camera plugin for windows does not properly set content-type when selecting JPG->PNG
[
https://issues.apache.org/jira/browse/CB-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637573#comment-16637573
]
ASF GitHub Bot commented on CB-11714:
-
brodybits closed pull request #242: CB-11714: (windows) added check for
encoding in savePhoto() without height/width
URL: https://github.com/apache/cordova-plugin-camera/pull/242
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/windows/CameraProxy.js b/src/windows/CameraProxy.js
index eb10cd2a..b24f6234 100644
--- a/src/windows/CameraProxy.js
+++ b/src/windows/CameraProxy.js
@@ -800,9 +800,14 @@ function savePhoto(picture, options, successCallback,
errorCallback) {
if (options.targetHeight > 0 && options.targetWidth > 0) {
resizeImage(successCallback, errorCallback, picture,
options.targetWidth, options.targetHeight, options.encodingType);
} else {
+// CB-11714: check if target content-type is PNG to just
rename as *.jpg since camera is captured as JPEG
+if (options.encodingType === Camera.EncodingType.PNG) {
+picture.name = picture.name.replace(/\.png$/, '.jpg');
+}
+
picture.copyAsync(getAppData().localFolder, picture.name,
OptUnique).done(function (copiedFile) {
-successCallback("ms-appdata:///local/" + copiedFile.name);
-},errorCallback);
+successCallback('ms-appdata:///local/' + copiedFile.name);
+}, errorCallback);
}
} else {
if (options.targetHeight > 0 && options.targetWidth > 0) {
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Camera plugin for windows does not properly set content-type when selecting
> JPG->PNG
>
>
> Key: CB-11714
> URL: https://issues.apache.org/jira/browse/CB-11714
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-camera
>Affects Versions: Master
> Environment: Windows 10
>Reporter: Tyler Pham
>Priority: Major
> Labels: easyfix, triaged, windows
>
> When selecting a JPG with encodingType = Camera.EncodingType.PNG, the
> resizeImage() will not modify the target content type when converting
> canvas.toDataURL(...) -- the content-type will still be image/jpeg but with a
> .png extension which will cause the browser to not render to image and issue
> an error.
> Possibly related to: CB-8618
> I have created a small fix at:
> https://github.com/DisruptiveMind/cordova-plugin-camera/tree/fix-windows-content-type
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11714) Camera plugin for windows does not properly set content-type when selecting JPG->PNG
[ https://issues.apache.org/jira/browse/CB-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637574#comment-16637574 ] ASF subversion and git services commented on CB-11714: -- Commit a201722f6d9e94dcd071154287416f53b7423089 in cordova-plugin-camera's branch refs/heads/master from [~DisruptiveArt] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-camera.git;h=a201722 ] CB-11714: (windows) added extra check for content-type in savePhoto() without options.targetWidth/Height > Camera plugin for windows does not properly set content-type when selecting > JPG->PNG > > > Key: CB-11714 > URL: https://issues.apache.org/jira/browse/CB-11714 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Affects Versions: Master > Environment: Windows 10 >Reporter: Tyler Pham >Priority: Major > Labels: easyfix, triaged, windows > > When selecting a JPG with encodingType = Camera.EncodingType.PNG, the > resizeImage() will not modify the target content type when converting > canvas.toDataURL(...) -- the content-type will still be image/jpeg but with a > .png extension which will cause the browser to not render to image and issue > an error. > Possibly related to: CB-8618 > I have created a small fix at: > https://github.com/DisruptiveMind/cordova-plugin-camera/tree/fix-windows-content-type -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11714) Camera plugin for windows does not properly set content-type when selecting JPG->PNG
[ https://issues.apache.org/jira/browse/CB-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637576#comment-16637576 ] ASF subversion and git services commented on CB-11714: -- Commit dc7395410890be9e918e6a7cd05bc2dfabcd24fc in cordova-plugin-camera's branch refs/heads/master from [~brodybits] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-camera.git;h=dc73954 ] Merge pull request #242 from DisruptiveMind/master CB-11714: (windows) added check for encoding in savePhoto() without height/width > Camera plugin for windows does not properly set content-type when selecting > JPG->PNG > > > Key: CB-11714 > URL: https://issues.apache.org/jira/browse/CB-11714 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Affects Versions: Master > Environment: Windows 10 >Reporter: Tyler Pham >Priority: Major > Labels: easyfix, triaged, windows > > When selecting a JPG with encodingType = Camera.EncodingType.PNG, the > resizeImage() will not modify the target content type when converting > canvas.toDataURL(...) -- the content-type will still be image/jpeg but with a > .png extension which will cause the browser to not render to image and issue > an error. > Possibly related to: CB-8618 > I have created a small fix at: > https://github.com/DisruptiveMind/cordova-plugin-camera/tree/fix-windows-content-type -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11714) Camera plugin for windows does not properly set content-type when selecting JPG->PNG
[ https://issues.apache.org/jira/browse/CB-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637575#comment-16637575 ] ASF subversion and git services commented on CB-11714: -- Commit eb57b02ba85429450d35a32ec13f86b88645a511 in cordova-plugin-camera's branch refs/heads/master from [~DisruptiveArt] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-camera.git;h=eb57b02 ] CB-11714: reuse picture.name instead of pictureName > Camera plugin for windows does not properly set content-type when selecting > JPG->PNG > > > Key: CB-11714 > URL: https://issues.apache.org/jira/browse/CB-11714 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Affects Versions: Master > Environment: Windows 10 >Reporter: Tyler Pham >Priority: Major > Labels: easyfix, triaged, windows > > When selecting a JPG with encodingType = Camera.EncodingType.PNG, the > resizeImage() will not modify the target content type when converting > canvas.toDataURL(...) -- the content-type will still be image/jpeg but with a > .png extension which will cause the browser to not render to image and issue > an error. > Possibly related to: CB-8618 > I have created a small fix at: > https://github.com/DisruptiveMind/cordova-plugin-camera/tree/fix-windows-content-type -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14188) Callback to decide whether to open link or not.
[ https://issues.apache.org/jira/browse/CB-14188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637577#comment-16637577 ] ASF GitHub Bot commented on CB-14188: - brodybits commented on issue #276: CB-14188: Add beforeload event, catching navigation before it happens URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/276#issuecomment-426828029 Looks OK to me, merging This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Callback to decide whether to open link or not. > --- > > Key: CB-14188 > URL: https://issues.apache.org/jira/browse/CB-14188 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-plugin-inappbrowser >Affects Versions: 3.0.0 >Reporter: wvengen >Priority: Major > > Several times I've found myself wanting to tell inAppBrowser whether it can > open a link in the embedded webview or using the system web browser. It would > be great if there's a callback _before_ loading a page (loadstart is too late > there), where I can tell inAppBrowser to load the page or not. > CB-14013 introduced AllowedSchemes, but excluded the use of http and https. > -It would be useful to allow intercepting http and https links, e.g. to > decide whether to open the link in the system web browser or not.- At first I > thought this mechanism could be used, but because of the asynchronous nature > of Cordova callbacks, this didn't work out, and I added a beforeload > callback. See comment for an example. > I've submitted a PR -(my approach would be to generate a regexp based on > AllowedSchemes and match the URL on that, instead of the current if logic)-. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14188) Callback to decide whether to open link or not.
[
https://issues.apache.org/jira/browse/CB-14188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637578#comment-16637578
]
ASF GitHub Bot commented on CB-14188:
-
brodybits closed pull request #276: CB-14188: Add beforeload event, catching
navigation before it happens
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/276
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/README.md b/README.md
index eade58a37..9aa1a4382 100644
--- a/README.md
+++ b/README.md
@@ -115,6 +115,7 @@ instance, or the system browser.
Android supports these additional options:
- __hidden__: set to `yes` to create the browser and load the page, but
not show it. The loadstop event fires when loading is complete. Omit or set to
`no` (default) to have the browser open and load normally.
+- __beforeload__: set to `yes` to enable the `beforeload` event to modify
which pages are actually loaded in the browser.
- __clearcache__: set to `yes` to have the browser's cookie cache cleared
before the new window is opened
- __clearsessioncache__: set to `yes` to have the session cookie cache
cleared before the new window is opened
- __closebuttoncaption__: set to a string to use as the close button's
caption instead of a X. Note that you need to localize this value yourself.
@@ -137,6 +138,7 @@ instance, or the system browser.
iOS supports these additional options:
- __hidden__: set to `yes` to create the browser and load the page, but
not show it. The loadstop event fires when loading is complete. Omit or set to
`no` (default) to have the browser open and load normally.
+- __beforeload__: set to `yes` to enable the `beforeload` event to modify
which pages are actually loaded in the browser.
- __clearcache__: set to `yes` to have the browser's cookie cache cleared
before the new window is opened
- __clearsessioncache__: set to `yes` to have the session cookie cache
cleared before the new window is opened
- __closebuttoncolor__: set as a valid hex color string, for example:
`#00ff00`, to change from the default __Done__ button's color. Only applicable
if toolbar is not disabled.
@@ -217,6 +219,7 @@ The object returned from a call to
`cordova.InAppBrowser.open` when the target i
- __loadstop__: event fires when the `InAppBrowser` finishes loading a URL.
- __loaderror__: event fires when the `InAppBrowser` encounters an error
when loading a URL.
- __exit__: event fires when the `InAppBrowser` window is closed.
+ - __beforeload__: event fires when the `InAppBrowser` decides whether to
load an URL or not (only with option `beforeload=yes`).
- __callback__: the function that executes when the event fires. The function
is passed an `InAppBrowserEvent` object as a parameter.
@@ -230,7 +233,7 @@ function showHelp(url) {
var target = "_blank";
-var options = "location=yes,hidden=yes";
+var options = "location=yes,hidden=yes,beforeload=yes";
inAppBrowserRef = cordova.InAppBrowser.open(url, target, options);
@@ -240,6 +243,8 @@ function showHelp(url) {
inAppBrowserRef.addEventListener('loaderror', loadErrorCallBack);
+inAppBrowserRef.addEventListener('beforeload', beforeloadCallBack);
+
}
function loadStartCallBack() {
@@ -288,6 +293,20 @@ function executeScriptCallBack(params) {
}
+function beforeloadCallback(params, callback) {
+
+if (params.url.startsWith("http://www.example.com/";)) {
+
+// Load this URL in the inAppBrowser.
+callback(params.url);
+} else {
+
+// The callback is not invoked, so the page will not be loaded.
+$('#status-message').text("This browser only opens pages on
http://www.example.com/";);
+}
+
+}
+
```
### InAppBrowserEvent Properties
diff --git a/src/android/InAppBrowser.java b/src/android/InAppBrowser.java
index 92ca3c1a1..93d946089 100644
--- a/src/android/InAppBrowser.java
+++ b/src/android/InAppBrowser.java
@@ -110,6 +110,7 @@ Licensed to the Apache Software Foundation (ASF) under one
private static final String HIDE_URL = "hideurlbar";
private static final String FOOTER = "footer";
private static final String FOOTER_COLOR = "footercolor";
+private static final String BEFORELOAD = "beforeload";
private static final List customizableOptions =
Arrays.asList(CLOSE_BUTTON_CAPTION, TOOLBAR_COLOR, NAVIGATION_COLOR,
CLOSE_BUTTON_COLOR, FOOTER_COLOR);
@@ -138,6 +139,7 @@ Licensed to the Apache Software Foundation (ASF) under one
private boolean hideUrlBar = false;
private boolean showFooter = false;
private String footerColor = "";
+private boolean useBeforeloa
[jira] [Commented] (CB-14188) Callback to decide whether to open link or not.
[ https://issues.apache.org/jira/browse/CB-14188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637580#comment-16637580 ] ASF subversion and git services commented on CB-14188: -- Commit eafaedaec4b82c14543e8f4622dc868e43b765e5 in cordova-plugin-inappbrowser's branch refs/heads/master from [~brodybits] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=eafaeda ] Merge pull request #276 from q-m/feature/beforeload-event CB-14188: Add beforeload event, catching navigation before it happens > Callback to decide whether to open link or not. > --- > > Key: CB-14188 > URL: https://issues.apache.org/jira/browse/CB-14188 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-plugin-inappbrowser >Affects Versions: 3.0.0 >Reporter: wvengen >Priority: Major > > Several times I've found myself wanting to tell inAppBrowser whether it can > open a link in the embedded webview or using the system web browser. It would > be great if there's a callback _before_ loading a page (loadstart is too late > there), where I can tell inAppBrowser to load the page or not. > CB-14013 introduced AllowedSchemes, but excluded the use of http and https. > -It would be useful to allow intercepting http and https links, e.g. to > decide whether to open the link in the system web browser or not.- At first I > thought this mechanism could be used, but because of the asynchronous nature > of Cordova callbacks, this didn't work out, and I added a beforeload > callback. See comment for an example. > I've submitted a PR -(my approach would be to generate a regexp based on > AllowedSchemes and match the URL on that, instead of the current if logic)-. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14188) Callback to decide whether to open link or not.
[ https://issues.apache.org/jira/browse/CB-14188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637579#comment-16637579 ] ASF subversion and git services commented on CB-14188: -- Commit 228703a63b088cbb635aa58f8a1015a9d5d818ab in cordova-plugin-inappbrowser's branch refs/heads/master from [~wvengen] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=228703a ] CB-14188: add beforeload event, catching navigation before it happens > Callback to decide whether to open link or not. > --- > > Key: CB-14188 > URL: https://issues.apache.org/jira/browse/CB-14188 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-plugin-inappbrowser >Affects Versions: 3.0.0 >Reporter: wvengen >Priority: Major > > Several times I've found myself wanting to tell inAppBrowser whether it can > open a link in the embedded webview or using the system web browser. It would > be great if there's a callback _before_ loading a page (loadstart is too late > there), where I can tell inAppBrowser to load the page or not. > CB-14013 introduced AllowedSchemes, but excluded the use of http and https. > -It would be useful to allow intercepting http and https links, e.g. to > decide whether to open the link in the system web browser or not.- At first I > thought this mechanism could be used, but because of the asynchronous nature > of Cordova callbacks, this didn't work out, and I added a beforeload > callback. See comment for an example. > I've submitted a PR -(my approach would be to generate a regexp based on > AllowedSchemes and match the URL on that, instead of the current if logic)-. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS
[ https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637586#comment-16637586 ] ASF GitHub Bot commented on CB-14187: - brodybits commented on issue #274: CB-14187: (ios) Change the InAppBrowser to allow custom schemes URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-426829387 @wvengen can you help resolve the conflicts? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova-plugin-inappbrowser AllowedSchemes for iOS > -- > > Key: CB-14187 > URL: https://issues.apache.org/jira/browse/CB-14187 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-plugin-inappbrowser >Affects Versions: 3.0.0 >Reporter: wvengen >Priority: Major > > CB-14013 add support for custom url schemes with the AllowedSchemes > preference. This only works on Android, however. It would be very useful to > have this on iOS (and other platforms) as well. > A pull request for iOS will follow. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14188) Callback to decide whether to open link or not.
[ https://issues.apache.org/jira/browse/CB-14188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637591#comment-16637591 ] ASF GitHub Bot commented on CB-14188: - janpio commented on issue #276: CB-14188: Add beforeload event, catching navigation before it happens URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/276#issuecomment-426831731 This is already merged now, but can this be added to the tests and checked automatically that it works? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Callback to decide whether to open link or not. > --- > > Key: CB-14188 > URL: https://issues.apache.org/jira/browse/CB-14188 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-plugin-inappbrowser >Affects Versions: 3.0.0 >Reporter: wvengen >Priority: Major > > Several times I've found myself wanting to tell inAppBrowser whether it can > open a link in the embedded webview or using the system web browser. It would > be great if there's a callback _before_ loading a page (loadstart is too late > there), where I can tell inAppBrowser to load the page or not. > CB-14013 introduced AllowedSchemes, but excluded the use of http and https. > -It would be useful to allow intercepting http and https links, e.g. to > decide whether to open the link in the system web browser or not.- At first I > thought this mechanism could be used, but because of the asynchronous nature > of Cordova callbacks, this didn't work out, and I added a beforeload > callback. See comment for an example. > I've submitted a PR -(my approach would be to generate a regexp based on > AllowedSchemes and match the URL on that, instead of the current if logic)-. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12270) Getting "Error capturing image" when saveToPhotoAlbum is true on some Android devices
[ https://issues.apache.org/jira/browse/CB-12270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637597#comment-16637597 ] Dan Polivy commented on CB-12270: - I've run into a similar issue, and I believe this is a dupe of https://issues.apache.org/jira/browse/CB-12964 which was fixed on June 28, 2017. Have you all tried this with a newer version of the plugin? > Getting "Error capturing image" when saveToPhotoAlbum is true on some Android > devices > - > > Key: CB-12270 > URL: https://issues.apache.org/jira/browse/CB-12270 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Reporter: Huseyin Candan >Priority: Major > > I get this error on Samsung Galaxy J2 (SM-J200F) with Android v.5.1.1. > When I change saveToPhotoAlbum to false, it works. > According to the user, the issue occurred on device with no change in the > app. It was working and one day error started. Maybe, Android version is > updated. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
