[jira] [Updated] (HBASE-22779) TestTableShell is broken
[
https://issues.apache.org/jira/browse/HBASE-22779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-22779:
--
Description:
{noformat}
Error: test_append_should_work_with_value(Hbase::TableSimpleMethodsTest):
ArgumentError: wrong number of arguments (3 for 1)
/home/zhangduo/hbase/code/hbase-shell/src/main/ruby/hbase/table.rb:291:in
`_append_internal'
/home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell/commands/append.rb:45:in
`append'
/home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell/commands.rb:49:in
`block in command_safe'
/home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell/commands.rb:122:in
`translate_hbase_exceptions'
/home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell/commands.rb:49:in
`command_safe'
/home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell.rb:148:in
`internal_command'
/home/zhangduo/hbase/code/hbase-shell/src/main/ruby/hbase/table.rb:51:in `block
in add_command'
src/test/ruby/hbase/table_test.rb:186:in `block in
test_append_should_work_with_value'
183: end
184:
185: define_test "append should work with value" do
=> 186: @test_table.append("123", 'x:cnt2', '123')
187: assert_equal("123123", @test_table._append_internal("123",
'x:cnt2', '123'))
188: end
189:
Error:
test_append_should_work_without_qualifier(Hbase::TableSimpleMethodsTest):
ArgumentError: wrong number of arguments (3 for 1)
/home/zhangduo/hbase/code/hbase-shell/src/main/ruby/hbase/table.rb:291:in
`_append_internal'
/home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell/commands/append.rb:45:in
`append'
/home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell/commands.rb:49:in
`block in command_safe'
/home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell/commands.rb:122:in
`translate_hbase_exceptions'
/home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell/commands.rb:49:in
`command_safe'
/home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell.rb:148:in
`internal_command'
/home/zhangduo/hbase/code/hbase-shell/src/main/ruby/hbase/table.rb:51:in `block
in add_command'
src/test/ruby/hbase/table_test.rb:191:in `block in
test_append_should_work_without_qualifier'
188: end
189:
190: define_test 'append should work without qualifier' do
=> 191: @test_table.append('1001', 'x', '123')
192: assert_equal('123321', @test_table._append_internal('1001',
'x', '321'))
193: end
194:
{noformat}
was:
{noformat}
Error: test_append_should_work_with_value(Hbase::TableSimpleMethodsTest):
ArgumentError: wrong number of arguments (3 for 1)
/home/zhangduo/hbase/code/hbase-shell/src/main/ruby/hbase/table.rb:291:in
`_append_internal'
/home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell/commands/append.rb:45:in
`append'
/home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell/commands.rb:49:in
`block in command_safe'
/home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell/commands.rb:122:in
`translate_hbase_exceptions'
/home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell/commands.rb:49:in
`command_safe'
/home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell.rb:148:in
`internal_command'
/home/zhangduo/hbase/code/hbase-shell/src/main/ruby/hbase/table.rb:51:in `block
in add_command'
src/test/ruby/hbase/table_test.rb:186:in `block in
test_append_should_work_with_value'
{noformat}
> TestTableShell is broken
>
>
> Key: HBASE-22779
> URL: https://issues.apache.org/jira/browse/HBASE-22779
> Project: HBase
> Issue Type: Bug
> Components: Client, shell
>Reporter: Duo Zhang
>Priority: Major
>
> {noformat}
> Error: test_append_should_work_with_value(Hbase::TableSimpleMethodsTest):
> ArgumentError: wrong number of arguments (3 for 1)
> /home/zhangduo/hbase/code/hbase-shell/src/main/ruby/hbase/table.rb:291:in
> `_append_internal'
> /home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell/commands/append.rb:45:in
> `append'
> /home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell/commands.rb:49:in
> `block in command_safe'
> /home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell/commands.rb:122:in
> `translate_hbase_exceptions'
> /home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell/commands.rb:49:in
> `command_safe'
> /home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell.rb:148:in
> `internal_command'
> /home/zhangduo/hbase/code/hbase-shell/src/main/ruby/hbase/table.rb:51:in
> `block in add_command'
> src/test/ruby/hbase/table_test.rb:186:in `block in
> test_append_should_work_with_value'
> 183: end
> 184:
> 185: define_test "append should work with value" do
> => 186: @test_table.append("123", 'x:cnt2', '123')
> 187: assert_equal("123123", @test_table._append_internal("123",
> 'x:cnt2', '123'))
>
[jira] [Created] (HBASE-22779) TestTableShell is broken
Duo Zhang created HBASE-22779:
-
Summary: TestTableShell is broken
Key: HBASE-22779
URL: https://issues.apache.org/jira/browse/HBASE-22779
Project: HBase
Issue Type: Bug
Components: Client, shell
Reporter: Duo Zhang
{noformat}
Error: test_append_should_work_with_value(Hbase::TableSimpleMethodsTest):
ArgumentError: wrong number of arguments (3 for 1)
/home/zhangduo/hbase/code/hbase-shell/src/main/ruby/hbase/table.rb:291:in
`_append_internal'
/home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell/commands/append.rb:45:in
`append'
/home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell/commands.rb:49:in
`block in command_safe'
/home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell/commands.rb:122:in
`translate_hbase_exceptions'
/home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell/commands.rb:49:in
`command_safe'
/home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell.rb:148:in
`internal_command'
/home/zhangduo/hbase/code/hbase-shell/src/main/ruby/hbase/table.rb:51:in `block
in add_command'
src/test/ruby/hbase/table_test.rb:186:in `block in
test_append_should_work_with_value'
{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22744) Remove deprecated classes around status and load
[
https://issues.apache.org/jira/browse/HBASE-22744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898613#comment-16898613
]
Duo Zhang commented on HBASE-22744:
---
I suggest that we remove the reference of these duplicated class in the shell
module first, and then remove them completely?
> Remove deprecated classes around status and load
>
>
> Key: HBASE-22744
> URL: https://issues.apache.org/jira/browse/HBASE-22744
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Major
> Fix For: 3.0.0
>
>
> The client module has three deprecated classes around metrics,
> {{ClusterStatus}}, {{RegionLoad}} and {{ServerLoad}}, which should be removed.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Created] (HBASE-22778) Upgrade jasckson databind to 2.9.9.2
Duo Zhang created HBASE-22778: - Summary: Upgrade jasckson databind to 2.9.9.2 Key: HBASE-22778 URL: https://issues.apache.org/jira/browse/HBASE-22778 Project: HBase Issue Type: Bug Components: dependencies Reporter: Duo Zhang Due to this CVE https://nvd.nist.gov/vuln/detail/CVE-2019-14379 -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22777: -- Summary: Add a multi-region merge (for fixing overlaps, etc.) (was: Add a multi-region merge (for fixing overlaps)) > Add a multi-region merge (for fixing overlaps, etc.) > > > Key: HBASE-22777 > URL: https://issues.apache.org/jira/browse/HBASE-22777 > Project: HBase > Issue Type: Sub-task > Components: hbck2, proc-v2 >Reporter: stack >Assignee: stack >Priority: Major > Attachments: HBASE-22777.master.001.patch > > > MergeTableRegionProcedure does two regions at a time only. We have hardcoded > notion that merge has an 'A' and 'B' parent. > This issue is about making it so we merge N regions all in the one go. We > need this facility generally; will simplify operator's life being able to > merge up in one go rather than in steps of two. In particular, would make > fixing overlaps easier if could just merge all regions in the overlapping > area. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22777) Add a multi-region merge (for fixing overlaps)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22777: -- Attachment: HBASE-22777.master.001.patch > Add a multi-region merge (for fixing overlaps) > -- > > Key: HBASE-22777 > URL: https://issues.apache.org/jira/browse/HBASE-22777 > Project: HBase > Issue Type: Sub-task > Components: hbck2, proc-v2 >Reporter: stack >Priority: Major > Attachments: HBASE-22777.master.001.patch > > > MergeTableRegionProcedure does two regions at a time only. We have hardcoded > notion that merge has an 'A' and 'B' parent. > This issue is about making it so we merge N regions all in the one go. We > need this facility generally; will simplify operator's life being able to > merge up in one go rather than in steps of two. In particular, would make > fixing overlaps easier if could just merge all regions in the overlapping > area. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22777) Add a multi-region merge (for fixing overlaps)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22777: -- Assignee: stack Status: Patch Available (was: Open) .001 is first cut; lacking doc and my test is failing. Need to figure why (I ask to merge 5 but it is doing 2 still...). Let me see what else I've broke. > Add a multi-region merge (for fixing overlaps) > -- > > Key: HBASE-22777 > URL: https://issues.apache.org/jira/browse/HBASE-22777 > Project: HBase > Issue Type: Sub-task > Components: hbck2, proc-v2 >Reporter: stack >Assignee: stack >Priority: Major > Attachments: HBASE-22777.master.001.patch > > > MergeTableRegionProcedure does two regions at a time only. We have hardcoded > notion that merge has an 'A' and 'B' parent. > This issue is about making it so we merge N regions all in the one go. We > need this facility generally; will simplify operator's life being able to > merge up in one go rather than in steps of two. In particular, would make > fixing overlaps easier if could just merge all regions in the overlapping > area. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache9 commented on a change in pull request #426: HBASE-22695 Store the rsgroup of a table in table configuration
Apache9 commented on a change in pull request #426: HBASE-22695 Store the
rsgroup of a table in table configuration
URL: https://github.com/apache/hbase/pull/426#discussion_r309998255
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupUtil.java
##
@@ -0,0 +1,113 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to you under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless
required by applicable
+ * law or agreed to in writing, software distributed under the License is
distributed on an "AS IS"
+ * BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied. See the License
+ * for the specific language governing permissions and limitations under the
License.
+ */
+package org.apache.hadoop.hbase.rsgroup;
+
+import java.io.IOException;
+import java.util.Collection;
+import java.util.Optional;
+import java.util.function.Predicate;
+import org.apache.hadoop.hbase.NamespaceDescriptor;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.TableDescriptor;
+import org.apache.hadoop.hbase.master.ClusterSchema;
+import org.apache.hadoop.hbase.master.MasterServices;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Helper class for RSGroup implementation
+ */
+@InterfaceAudience.Private
+final class RSGroupUtil {
+
+ private static final Logger LOG = LoggerFactory.getLogger(RSGroupUtil.class);
+
+ private RSGroupUtil() {
+ }
+
+ @FunctionalInterface
+ private interface GetRSGroup {
+RSGroupInfo get(String groupName) throws IOException;
+ }
+
+ private static Optional getRSGroupInfo(MasterServices master,
GetRSGroup getter,
+ TableName tableName) throws IOException {
+TableDescriptor td = master.getTableDescriptors().get(tableName);
+if (td == null) {
+ return Optional.empty();
+}
+Optional optGroupNameOfTable = td.getRegionServerGroup();
+if (optGroupNameOfTable.isPresent()) {
+ RSGroupInfo group = getter.get(optGroupNameOfTable.get());
+ if (group != null) {
+return Optional.of(group);
+ }
+}
+ClusterSchema clusterSchema = master.getClusterSchema();
+if (clusterSchema == null) {
+ if (TableName.isMetaTableName(tableName)) {
+LOG.info("Can not get the namespace rs group config for meta table,
since the" +
+" meta table is not online yet, will use default group to assign
meta first");
+ } else {
+LOG.warn("ClusterSchema is null, can only use default rsgroup, should
not happen?");
+ }
+ return Optional.empty();
+}
+NamespaceDescriptor nd =
clusterSchema.getNamespace(tableName.getNamespaceAsString());
+String groupNameOfNs =
nd.getConfigurationValue(RSGroupInfo.NAMESPACE_DESC_PROP_GROUP);
+if (groupNameOfNs == null) {
+ return Optional.empty();
Review comment:
Empty here can tell the upper layer that there is no rs group setting for
this table. If we return default rs group here, the upper layer can not know if
there is no rs group setting, or user set the rs group to default explicitly.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-22771) [HBCK2] fixMeta method and server-side support
[ https://issues.apache.org/jira/browse/HBASE-22771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898601#comment-16898601 ] stack commented on HBASE-22771: --- .002 incorporates fixes to address reviews up on rb and effects a simplification found while messing around elsewhere. Not done yet. Still only holes. Putting aside a moment while work on HBASE-22777 Add a multi-region merge (for fixing overlaps) > [HBCK2] fixMeta method and server-side support > -- > > Key: HBASE-22771 > URL: https://issues.apache.org/jira/browse/HBASE-22771 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Priority: Major > Attachments: HBASE-22771.master.001.patch, > HBASE-22771.master.002.patch > > > Add a fixMeta method to hbck Service. > HBCK2 tool in hbase-operator-tools will use this if it is available otherwise > it will do its own client-side version. Making these server-side versions so > can copy/exploit code/findings doing hbase-operator-tools HBCK2 tool version. > This does pure meta fixup plug holes and fix overlaps. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22771) [HBCK2] fixMeta method and server-side support
[ https://issues.apache.org/jira/browse/HBASE-22771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22771: -- Attachment: HBASE-22771.master.002.patch > [HBCK2] fixMeta method and server-side support > -- > > Key: HBASE-22771 > URL: https://issues.apache.org/jira/browse/HBASE-22771 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Priority: Major > Attachments: HBASE-22771.master.001.patch, > HBASE-22771.master.002.patch > > > Add a fixMeta method to hbck Service. > HBCK2 tool in hbase-operator-tools will use this if it is available otherwise > it will do its own client-side version. Making these server-side versions so > can copy/exploit code/findings doing hbase-operator-tools HBCK2 tool version. > This does pure meta fixup plug holes and fix overlaps. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (HBASE-22777) Add a multi-region merge (for fixing overlaps)
stack created HBASE-22777: - Summary: Add a multi-region merge (for fixing overlaps) Key: HBASE-22777 URL: https://issues.apache.org/jira/browse/HBASE-22777 Project: HBase Issue Type: Sub-task Components: hbck2, proc-v2 Reporter: stack MergeTableRegionProcedure does two regions at a time only. We have hardcoded notion that merge has an 'A' and 'B' parent. This issue is about making it so we merge N regions all in the one go. We need this facility generally; will simplify operator's life being able to merge up in one go rather than in steps of two. In particular, would make fixing overlaps easier if could just merge all regions in the overlapping area. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] anmolnar commented on issue #428: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (master)
anmolnar commented on issue #428: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (master) URL: https://github.com/apache/hbase/pull/428#issuecomment-517548637 @petersomogyi Good question. We're talking about an almost 3000-line file, so potentially yes, but I have to take a closer look. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] anmolnar commented on a change in pull request #428: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (master)
anmolnar commented on a change in pull request #428: HBASE-22759 Add user info
to AUDITLOG events when doing grant/revoke (master)
URL: https://github.com/apache/hbase/pull/428#discussion_r309981304
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
##
@@ -2584,6 +2586,11 @@ public GrantResponse grant(RpcController controller,
GrantRequest request)
if (master.cpHost != null) {
master.cpHost.postGrant(perm, mergeExistingPermissions);
}
+ User caller = RpcServer.getRequestUser().orElse(null);
+ if (AUDITLOG.isTraceEnabled()) {
Review comment:
Thanks, I'll remove it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] mymeiyi opened a new pull request #440: HBASE-22776 Rename config names in user scan snapshot feature
mymeiyi opened a new pull request #440: HBASE-22776 Rename config names in user scan snapshot feature URL: https://github.com/apache/hbase/pull/440 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve…
Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve… URL: https://github.com/apache/hbase/pull/435#issuecomment-517540760 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 277 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | 0 | shelldocs | 0 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 52 | Maven dependency ordering for branch | | +1 | mvninstall | 409 | master passed | | +1 | compile | 117 | master passed | | +1 | checkstyle | 131 | master passed | | +1 | shadedjars | 370 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 93 | master passed | | 0 | spotbugs | 60 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 438 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 18 | Maven dependency ordering for patch | | +1 | mvninstall | 386 | the patch passed | | +1 | compile | 129 | the patch passed | | +1 | javac | 129 | the patch passed | | -1 | checkstyle | 95 | hbase-server: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9) | | +1 | shellcheck | 0 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 351 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1272 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 89 | the patch passed | | -1 | findbugs | 73 | hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 203 | hbase-common in the patch passed. | | -1 | unit | 18510 | hbase-server in the patch failed. | | +1 | unit | 901 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 70 | The patch does not generate ASF License warnings. | | | | 24922 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-common | | | org.apache.hadoop.hbase.Version.() invokes inefficient new String(String) constructor At Version.java:inefficient new String(String) constructor At Version.java:[line 10] | | Failed junit tests | hadoop.hbase.tool.TestSecureBulkLoadHFiles | | | hadoop.hbase.io.hfile.bucket.TestBucketCache | | | hadoop.hbase.replication.TestReplicationSmallTests | | | hadoop.hbase.tool.TestBulkLoadHFiles | | | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/435 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux b14b628bbbc4 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-435/out/precommit/personality/provided.sh | | git revision | master / 7e6684b1f4 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/3/artifact/out/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/3/artifact/out/new-findbugs-hbase-common.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/3/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/3/testReport/ | | Max. process+thread count | 4937 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server hbase-rsgroup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.ap
[jira] [Created] (HBASE-22776) Rename config names in user scan snapshot feature
Yi Mei created HBASE-22776: -- Summary: Rename config names in user scan snapshot feature Key: HBASE-22776 URL: https://issues.apache.org/jira/browse/HBASE-22776 Project: HBase Issue Type: Sub-task Reporter: Yi Mei As discussed in HBASE-22578, HBASE-22580, the config names are not so proper. And make the SnapshotScannerHDFSAclCleaner load automatically if this feature is enabled. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #436: HBASE-22699 refactor isMetaClearingException
Apache-HBase commented on issue #436: HBASE-22699 refactor isMetaClearingException URL: https://github.com/apache/hbase/pull/436#issuecomment-517533411 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 64 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 31 | Maven dependency ordering for branch | | +1 | mvninstall | 294 | master passed | | +1 | compile | 55 | master passed | | +1 | checkstyle | 71 | master passed | | +1 | shadedjars | 272 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 52 | master passed | | 0 | spotbugs | 91 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 154 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 288 | the patch passed | | +1 | compile | 56 | the patch passed | | +1 | javac | 56 | the patch passed | | +1 | checkstyle | 66 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 267 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 948 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 53 | the patch passed | | +1 | findbugs | 167 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 105 | hbase-client in the patch passed. | | +1 | unit | 264 | hbase-thrift in the patch passed. | | +1 | asflicense | 24 | The patch does not generate ASF License warnings. | | | | 3667 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/436 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux b740afbc2733 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-436/out/precommit/personality/provided.sh | | git revision | master / 7e6684b1f4 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/5/testReport/ | | Max. process+thread count | 1746 (vs. ulimit of 1) | | modules | C: hbase-client hbase-thrift U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/5/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend URL: https://github.com/apache/hbase/pull/390#issuecomment-517531410 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 76 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 532 | master passed | | +1 | compile | 71 | master passed | | +1 | checkstyle | 119 | master passed | | +1 | shadedjars | 371 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 45 | master passed | | 0 | spotbugs | 348 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 338 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 423 | the patch passed | | +1 | compile | 67 | the patch passed | | +1 | javac | 67 | the patch passed | | +1 | checkstyle | 102 | hbase-server: The patch generated 0 new + 375 unchanged - 1 fixed = 375 total (was 376) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 357 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1212 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 45 | the patch passed | | +1 | findbugs | 321 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 15717 | hbase-server in the patch failed. | | +1 | asflicense | 33 | The patch does not generate ASF License warnings. | | | | 20331 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestResultFromCoprocessor | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/25/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/390 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 190d3477e10b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-390/out/precommit/personality/provided.sh | | git revision | master / 7e6684b1f4 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/25/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/25/testReport/ | | Max. process+thread count | 4819 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/25/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22767) System table RIT STUCK if their RSGroup has no highest version RSes
[ https://issues.apache.org/jira/browse/HBASE-22767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898512#comment-16898512 ] Xiaolin Ha commented on HBASE-22767: [~zghaobac] This fix just skipped to assign system table regions to group when no group servers available. But for normal table regions, still need to wait for group servers online. As I have replied in HBASE-22738, should we consider those questions? > System table RIT STUCK if their RSGroup has no highest version RSes > --- > > Key: HBASE-22767 > URL: https://issues.apache.org/jira/browse/HBASE-22767 > Project: HBase > Issue Type: Bug > Components: rsgroup >Reporter: Xiaolin Ha >Assignee: Xiaolin Ha >Priority: Major > > AM chooses highest version region servers as participants for system tables, > including META table. If system table group has no highest version region > servers, then the reassignment of their regions will be always the BOGUS > server defined in RSGroup. > In our test environment using branch-2.2, we isolate system tables in a > rsgroup containing only one server. And when upgrading RSs, we have met the > problem that META is always assigned to the BOGUS server while the group > server has already been online for a while. META RIT is stuck and can not be > recovered by hbck2. > I made a UT reproduce this problem, steps are: > 1. add a group, move 1 server to it; > 2. move meta table to the group; > 3. restart the group server and downgrade its version; > 4. meta rit stuck. > > ROOT cause is AM filters highest version RSs for system tables. So if we do > not change the versions of system table group servers, but upgrade the > versions of other group servers, then if there is reassignment for any system > tables, such as balancer moving their regions, RIT STUCK!! > > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] sunhelly commented on a change in pull request #426: HBASE-22695 Store the rsgroup of a table in table configuration
sunhelly commented on a change in pull request #426: HBASE-22695 Store the
rsgroup of a table in table configuration
URL: https://github.com/apache/hbase/pull/426#discussion_r309967126
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupUtil.java
##
@@ -0,0 +1,113 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to you under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless
required by applicable
+ * law or agreed to in writing, software distributed under the License is
distributed on an "AS IS"
+ * BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied. See the License
+ * for the specific language governing permissions and limitations under the
License.
+ */
+package org.apache.hadoop.hbase.rsgroup;
+
+import java.io.IOException;
+import java.util.Collection;
+import java.util.Optional;
+import java.util.function.Predicate;
+import org.apache.hadoop.hbase.NamespaceDescriptor;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.TableDescriptor;
+import org.apache.hadoop.hbase.master.ClusterSchema;
+import org.apache.hadoop.hbase.master.MasterServices;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Helper class for RSGroup implementation
+ */
+@InterfaceAudience.Private
+final class RSGroupUtil {
+
+ private static final Logger LOG = LoggerFactory.getLogger(RSGroupUtil.class);
+
+ private RSGroupUtil() {
+ }
+
+ @FunctionalInterface
+ private interface GetRSGroup {
+RSGroupInfo get(String groupName) throws IOException;
+ }
+
+ private static Optional getRSGroupInfo(MasterServices master,
GetRSGroup getter,
+ TableName tableName) throws IOException {
+TableDescriptor td = master.getTableDescriptors().get(tableName);
+if (td == null) {
+ return Optional.empty();
+}
+Optional optGroupNameOfTable = td.getRegionServerGroup();
+if (optGroupNameOfTable.isPresent()) {
+ RSGroupInfo group = getter.get(optGroupNameOfTable.get());
+ if (group != null) {
+return Optional.of(group);
+ }
+}
+ClusterSchema clusterSchema = master.getClusterSchema();
+if (clusterSchema == null) {
+ if (TableName.isMetaTableName(tableName)) {
+LOG.info("Can not get the namespace rs group config for meta table,
since the" +
+" meta table is not online yet, will use default group to assign
meta first");
+ } else {
+LOG.warn("ClusterSchema is null, can only use default rsgroup, should
not happen?");
+ }
+ return Optional.empty();
+}
+NamespaceDescriptor nd =
clusterSchema.getNamespace(tableName.getNamespaceAsString());
+String groupNameOfNs =
nd.getConfigurationValue(RSGroupInfo.NAMESPACE_DESC_PROP_GROUP);
+if (groupNameOfNs == null) {
+ return Optional.empty();
Review comment:
Why not return RSGroupInfo.DEFAULT_GROUP instead of empty?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #428: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (master)
Apache-HBase commented on issue #428: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (master) URL: https://github.com/apache/hbase/pull/428#issuecomment-517528897 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 61 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 369 | master passed | | +1 | compile | 73 | master passed | | +1 | checkstyle | 92 | master passed | | +1 | shadedjars | 349 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 65 | master passed | | 0 | spotbugs | 410 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 409 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 395 | the patch passed | | +1 | compile | 69 | the patch passed | | +1 | javac | 69 | the patch passed | | +1 | checkstyle | 94 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 373 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1318 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 43 | the patch passed | | +1 | findbugs | 330 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 16003 | hbase-server in the patch passed. | | +1 | asflicense | 31 | The patch does not generate ASF License warnings. | | | | 20515 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/19/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/428 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 6a224a551655 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh | | git revision | master / 7e6684b1f4 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/19/testReport/ | | Max. process+thread count | 4608 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/19/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-517527934 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 62 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 41 | Maven dependency ordering for branch | | +1 | mvninstall | 386 | master passed | | +1 | compile | 82 | master passed | | +1 | checkstyle | 104 | master passed | | +1 | shadedjars | 271 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 57 | master passed | | 0 | spotbugs | 228 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 295 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 325 | the patch passed | | +1 | compile | 80 | the patch passed | | +1 | javac | 80 | the patch passed | | +1 | checkstyle | 98 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 262 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 972 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 57 | the patch passed | | +1 | findbugs | 322 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 109 | hbase-client in the patch passed. | | -1 | unit | 15899 | hbase-server in the patch failed. | | +1 | asflicense | 62 | The patch does not generate ASF License warnings. | | | | 19886 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.assignment.TestOpenRegionProcedureHang | | | hadoop.hbase.master.TestMasterShutdown | | | hadoop.hbase.client.TestAsyncTableAdminApi | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/57/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/361 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 6547b716ad67 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh | | git revision | master / 7e6684b1f4 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/57/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/57/testReport/ | | Max. process+thread count | 5079 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/57/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22738) Fallback to default group to choose RS when there are no RS in current group
[ https://issues.apache.org/jira/browse/HBASE-22738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898502#comment-16898502 ] Xiaolin Ha commented on HBASE-22738: If we assign regions to regionservers that not belong to its group, then we may need balancer to correct them. Am I right? How can correct if balancer is turned off? And users will not be aware of different group regions combined until there are some interactions. Is this tolerable? > Fallback to default group to choose RS when there are no RS in current group > > > Key: HBASE-22738 > URL: https://issues.apache.org/jira/browse/HBASE-22738 > Project: HBase > Issue Type: Bug >Reporter: Guanghao Zhang >Priority: Major > > We configure one regionserver for hbase system table. But when rolling > upgrade, you need move the region to other regionservers. But because there > are no other regionservers in this group, you cannot move the region... > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22774) [WAL] RegionGroupingStrategy loses its function after split
[
https://issues.apache.org/jira/browse/HBASE-22774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898499#comment-16898499
]
Reid Chan commented on HBASE-22774:
---
The fix is easy, but it breaks UTs which are pretty hard to fix. I'm still
working on it.
> [WAL] RegionGroupingStrategy loses its function after split
> ---
>
> Key: HBASE-22774
> URL: https://issues.apache.org/jira/browse/HBASE-22774
> Project: HBase
> Issue Type: Bug
> Components: wal
>Affects Versions: 1.4.6
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
>
> Having {{hbase.wal.provider}} set {{multiwal}}, it works fine on regionserver
> restart, at the beginning.
> But when region split happened, those daughter regions would inherit her
> parent's WAL, which violates the setting. For example, when
> {{hbase.wal.regiongrouping.strategy}} set {{identity}}, each daughter regions
> should create its own WAL instead of inheriting.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] openinx commented on a change in pull request #437: HBASE-22539 WAL corruption due to early DBBs re-use when Durability.A…
openinx commented on a change in pull request #437: HBASE-22539 WAL corruption
due to early DBBs re-use when Durability.A…
URL: https://github.com/apache/hbase/pull/437#discussion_r309963885
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSWALEntry.java
##
@@ -56,19 +58,24 @@
private final transient boolean inMemstore;
private final transient RegionInfo regionInfo;
private final transient Set familyNames;
+ private final transient Optional> rpcCall;
- FSWALEntry(final long txid, final WALKeyImpl key, final WALEdit edit,
- final RegionInfo regionInfo, final boolean inMemstore) {
+ FSWALEntry(final long txid, final WALKeyImpl key, final WALEdit edit, final
RegionInfo regionInfo,
+final boolean inMemstore, ServerCall rpcCall) {
super(key, edit);
this.inMemstore = inMemstore;
this.regionInfo = regionInfo;
this.txid = txid;
if (inMemstore) {
// construct familyNames here to reduce the work of log sinker.
- Set families = edit.getFamilies();
- this.familyNames = families != null? families:
collectFamilies(edit.getCells());
+ Set families = edit.getFamilies();
+ this.familyNames = families != null ? families :
collectFamilies(edit.getCells());
Review comment:
Unrelated issue: I see the collectFamilies internal , lots of Stream &
lamda code there... That would be a performance issue...
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] openinx commented on a change in pull request #437: HBASE-22539 WAL corruption due to early DBBs re-use when Durability.A…
openinx commented on a change in pull request #437: HBASE-22539 WAL corruption
due to early DBBs re-use when Durability.A…
URL: https://github.com/apache/hbase/pull/437#discussion_r309961914
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AsyncFSWAL.java
##
@@ -323,7 +324,9 @@ private void syncFailed(long epochWhenSync, Throwable
error) {
private void syncCompleted(AsyncWriter writer, long processedTxid, long
startTimeNs) {
highestSyncedTxid.set(processedTxid);
for (Iterator iter = unackedAppends.iterator();
iter.hasNext();) {
- if (iter.next().getTxid() <= processedTxid) {
+ FSWALEntry entry = iter.next();
+ if (entry.getTxid() <= processedTxid) {
+entry.getRpcCall().ifPresent(ServerCall::releaseByWAL);
Review comment:
Not problem as said before.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Resolved] (HBASE-22762) Print the delta between phases in the split/merge/compact/flush transaction journals
[ https://issues.apache.org/jira/browse/HBASE-22762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell resolved HBASE-22762. Resolution: Fixed Nothing to be done. Looks like under mt scenarios the logger only keeps a certain amount of buffer space free per thread and truncates overlong strings at their start. Might be fixable if we use something other than HRegion.LOG to log but no context to do that. Too much work for this change. Pushed addendum to branch-1.3, branch-1.4 and branch-1 > Print the delta between phases in the split/merge/compact/flush transaction > journals > > > Key: HBASE-22762 > URL: https://issues.apache.org/jira/browse/HBASE-22762 > Project: HBase > Issue Type: Improvement > Components: logging >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22762-branch-1-addendum.patch, > HBASE-22762.branch-1.001.patch, HBASE-22762.branch-1.002.patch, > HBASE-22762.branch-1.004.patch > > > We print the start timestamp for each phase when logging the > split/merge/compact/flush transaction journals and so when debugging an > operator must do the math by hand. It would be trivial to also print the > delta from the start timestamp of the previous phase and helpful to do so. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] openinx commented on a change in pull request #437: HBASE-22539 WAL corruption due to early DBBs re-use when Durability.A…
openinx commented on a change in pull request #437: HBASE-22539 WAL corruption
due to early DBBs re-use when Durability.A…
URL: https://github.com/apache/hbase/pull/437#discussion_r309960468
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerCall.java
##
@@ -141,14 +147,43 @@ public void done() {
cleanup();
}
+ private void release(int mask) {
Review comment:
OK, I misunderstood wrong here before...it's not a problem because once the
CAS success, it will return and get out of the loop.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-22767) System table RIT STUCK if their RSGroup has no highest version RSes
[ https://issues.apache.org/jira/browse/HBASE-22767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898492#comment-16898492 ] Xiaolin Ha commented on HBASE-22767: [~zghaobac] Thanks for you comments. Using BOGUS_SERVER_NAME to fix is following the original design of RSGroup. If we choose default group servers, then how can we know a table has regions on servers that not belong to its group? Maybe we can use balancer to correct this. But we will not recognize this in current displayed info. > System table RIT STUCK if their RSGroup has no highest version RSes > --- > > Key: HBASE-22767 > URL: https://issues.apache.org/jira/browse/HBASE-22767 > Project: HBase > Issue Type: Bug > Components: rsgroup >Reporter: Xiaolin Ha >Assignee: Xiaolin Ha >Priority: Major > > AM chooses highest version region servers as participants for system tables, > including META table. If system table group has no highest version region > servers, then the reassignment of their regions will be always the BOGUS > server defined in RSGroup. > In our test environment using branch-2.2, we isolate system tables in a > rsgroup containing only one server. And when upgrading RSs, we have met the > problem that META is always assigned to the BOGUS server while the group > server has already been online for a while. META RIT is stuck and can not be > recovered by hbck2. > I made a UT reproduce this problem, steps are: > 1. add a group, move 1 server to it; > 2. move meta table to the group; > 3. restart the group server and downgrade its version; > 4. meta rit stuck. > > ROOT cause is AM filters highest version RSs for system tables. So if we do > not change the versions of system table group servers, but upgrade the > versions of other group servers, then if there is reassignment for any system > tables, such as balancer moving their regions, RIT STUCK!! > > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22762) Print the delta between phases in the split/merge/compact/flush transaction journals
[ https://issues.apache.org/jira/browse/HBASE-22762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898487#comment-16898487 ] Andrew Purtell commented on HBASE-22762: Still working on the addendum. Monitored task journal dump can get partially clobbered, looks like multithreading issue on the logger not an issue with the patch. Looking at what can be done without any significant change. > Print the delta between phases in the split/merge/compact/flush transaction > journals > > > Key: HBASE-22762 > URL: https://issues.apache.org/jira/browse/HBASE-22762 > Project: HBase > Issue Type: Improvement > Components: logging >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22762-branch-1-addendum.patch, > HBASE-22762.branch-1.001.patch, HBASE-22762.branch-1.002.patch, > HBASE-22762.branch-1.004.patch > > > We print the start timestamp for each phase when logging the > split/merge/compact/flush transaction journals and so when debugging an > operator must do the math by hand. It would be trivial to also print the > delta from the start timestamp of the previous phase and helpful to do so. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] openinx commented on a change in pull request #437: HBASE-22539 WAL corruption due to early DBBs re-use when Durability.A…
openinx commented on a change in pull request #437: HBASE-22539 WAL corruption due to early DBBs re-use when Durability.A… URL: https://github.com/apache/hbase/pull/437#discussion_r309955894 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java ## @@ -1061,8 +1063,10 @@ protected final long stampSequenceIdAndPublishToRingBuffer(RegionInfo hri, WALKe txidHolder.setValue(ringBuffer.next()); }); long txid = txidHolder.longValue(); +ServerCall rpcCall = RpcServer.getCurrentCall().filter(c -> c instanceof ServerCall) Review comment: The currentCall should always be a ServerCall I think, so no need the extra instanceof ? It's also OK, if you think it's fine. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] openinx commented on a change in pull request #437: HBASE-22539 WAL corruption due to early DBBs re-use when Durability.A…
openinx commented on a change in pull request #437: HBASE-22539 WAL corruption
due to early DBBs re-use when Durability.A…
URL: https://github.com/apache/hbase/pull/437#discussion_r309959424
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AsyncFSWAL.java
##
@@ -487,6 +490,7 @@ private void drainNonMarkerEditsAndFailSyncs() {
while (iter.hasNext()) {
FSWALEntry entry = iter.next();
if (!entry.getEdit().isMetaEdit()) {
+entry.getRpcCall().ifPresent(ServerCall::releaseByWAL);
Review comment:
In theory, once we remove a FSWALEntry from the unackedAppended deque, we
should release the BB backend the WAL ? Could we define a deque subclass, once
we remove the entry from it then will release it , then we don't need to
release the wal everywhere, I think...
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] openinx commented on a change in pull request #437: HBASE-22539 WAL corruption due to early DBBs re-use when Durability.A…
openinx commented on a change in pull request #437: HBASE-22539 WAL corruption
due to early DBBs re-use when Durability.A…
URL: https://github.com/apache/hbase/pull/437#discussion_r309956708
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
##
@@ -1002,6 +1001,8 @@ public void onEvent(final RingBufferTruck truck, final
long sequence, boolean en
: new DamagedWALException("On sync", this.exception));
// Return to keep processing events coming off the ringbuffer
return;
+ } finally {
+entry.getRpcCall().ifPresent(ServerCall::releaseByWAL);
Review comment:
Good. Releasing the BB here should be fine, because once the BB was written
into the outputStream, it would be copied to a new memory area, won't depend on
the rpc BB now
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] openinx commented on a change in pull request #437: HBASE-22539 WAL corruption due to early DBBs re-use when Durability.A…
openinx commented on a change in pull request #437: HBASE-22539 WAL corruption
due to early DBBs re-use when Durability.A…
URL: https://github.com/apache/hbase/pull/437#discussion_r309958049
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AsyncFSWAL.java
##
@@ -323,7 +324,9 @@ private void syncFailed(long epochWhenSync, Throwable
error) {
private void syncCompleted(AsyncWriter writer, long processedTxid, long
startTimeNs) {
highestSyncedTxid.set(processedTxid);
for (Iterator iter = unackedAppends.iterator();
iter.hasNext();) {
- if (iter.next().getTxid() <= processedTxid) {
+ FSWALEntry entry = iter.next();
+ if (entry.getTxid() <= processedTxid) {
+entry.getRpcCall().ifPresent(ServerCall::releaseByWAL);
Review comment:
Still worry about the CPU-consuming in ServerCall#release, for AsyncFSWAL,
we will accumulate the batch size entries and then call the sync, so if the
sync not finished, then the ServerCall#release will be always looping..
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] openinx commented on a change in pull request #437: HBASE-22539 WAL corruption due to early DBBs re-use when Durability.A…
openinx commented on a change in pull request #437: HBASE-22539 WAL corruption
due to early DBBs re-use when Durability.A…
URL: https://github.com/apache/hbase/pull/437#discussion_r309955443
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerCall.java
##
@@ -141,14 +147,43 @@ public void done() {
cleanup();
}
+ private void release(int mask) {
Review comment:
So if the WAL Entry did not finish the append processing, then the RpcCall
will be always traped in this for loop ? May be CPU consuming here I think.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #438: HBASE-11062 hbtop
Apache9 commented on a change in pull request #438: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/438#discussion_r309953016
##
File path: hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/Filter.java
##
@@ -0,0 +1,343 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.hbtop;
+
+import java.util.Arrays;
+import java.util.List;
+import java.util.Objects;
+import org.apache.hadoop.hbase.hbtop.field.Field;
+import org.apache.hadoop.hbase.hbtop.field.FieldValue;
+import org.apache.yetus.audience.InterfaceAudience;
+
+
+/**
+ * Represents a filter that's filtering the metric {@link Record}s.
+ */
+@InterfaceAudience.Private
+public final class Filter {
Review comment:
We already have a `Filter` class in HBase so maybe add a special prefix here?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-22762) Print the delta between phases in the split/merge/compact/flush transaction journals
[ https://issues.apache.org/jira/browse/HBASE-22762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898465#comment-16898465 ] Xu Cang commented on HBASE-22762: - +1 > Print the delta between phases in the split/merge/compact/flush transaction > journals > > > Key: HBASE-22762 > URL: https://issues.apache.org/jira/browse/HBASE-22762 > Project: HBase > Issue Type: Improvement > Components: logging >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22762-branch-1-addendum.patch, > HBASE-22762.branch-1.001.patch, HBASE-22762.branch-1.002.patch, > HBASE-22762.branch-1.004.patch > > > We print the start timestamp for each phase when logging the > split/merge/compact/flush transaction journals and so when debugging an > operator must do the math by hand. It would be trivial to also print the > delta from the start timestamp of the previous phase and helpful to do so. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22762) Print the delta between phases in the split/merge/compact/flush transaction journals
[ https://issues.apache.org/jira/browse/HBASE-22762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898462#comment-16898462 ] Andrew Purtell commented on HBASE-22762: Attached addendum patch > Print the delta between phases in the split/merge/compact/flush transaction > journals > > > Key: HBASE-22762 > URL: https://issues.apache.org/jira/browse/HBASE-22762 > Project: HBase > Issue Type: Improvement > Components: logging >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22762-branch-1-addendum.patch, > HBASE-22762.branch-1.001.patch, HBASE-22762.branch-1.002.patch, > HBASE-22762.branch-1.004.patch > > > We print the start timestamp for each phase when logging the > split/merge/compact/flush transaction journals and so when debugging an > operator must do the math by hand. It would be trivial to also print the > delta from the start timestamp of the previous phase and helpful to do so. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22762) Print the delta between phases in the split/merge/compact/flush transaction journals
[ https://issues.apache.org/jira/browse/HBASE-22762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-22762: --- Attachment: HBASE-22762-branch-1-addendum.patch > Print the delta between phases in the split/merge/compact/flush transaction > journals > > > Key: HBASE-22762 > URL: https://issues.apache.org/jira/browse/HBASE-22762 > Project: HBase > Issue Type: Improvement > Components: logging >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22762-branch-1-addendum.patch, > HBASE-22762.branch-1.001.patch, HBASE-22762.branch-1.002.patch, > HBASE-22762.branch-1.004.patch > > > We print the start timestamp for each phase when logging the > split/merge/compact/flush transaction journals and so when debugging an > operator must do the math by hand. It would be trivial to also print the > delta from the start timestamp of the previous phase and helpful to do so. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache9 commented on issue #426: HBASE-22695 Store the rsgroup of a table in table configuration
Apache9 commented on issue #426: HBASE-22695 Store the rsgroup of a table in table configuration URL: https://github.com/apache/hbase/pull/426#issuecomment-517509990 OK, good. Finally we got all UTs passed. Let me address the checkstyle issues. @infraio @sunhelly Any other oncerns? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Reopened] (HBASE-22762) Print the delta between phases in the split/merge/compact/flush transaction journals
[ https://issues.apache.org/jira/browse/HBASE-22762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell reopened HBASE-22762: Assignee: Andrew Purtell (was: Xu Cang) Reviewing recent commits I realized the scope of this drifted to just SplitTransactionImpl but we committed it using the description on the jira, which implies a change to all of the other "transaction journal" dumps too. I'm going to take this over, clone Xu's addition to SplitTransactionImpl to the others, and commit an addendum. > Print the delta between phases in the split/merge/compact/flush transaction > journals > > > Key: HBASE-22762 > URL: https://issues.apache.org/jira/browse/HBASE-22762 > Project: HBase > Issue Type: Improvement > Components: logging >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22762.branch-1.001.patch, > HBASE-22762.branch-1.002.patch, HBASE-22762.branch-1.004.patch > > > We print the start timestamp for each phase when logging the > split/merge/compact/flush transaction journals and so when debugging an > operator must do the math by hand. It would be trivial to also print the > delta from the start timestamp of the previous phase and helpful to do so. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment
Apache-HBase commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment URL: https://github.com/apache/hbase/pull/439#issuecomment-517506875 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 44 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 369 | master passed | | +1 | compile | 68 | master passed | | +1 | checkstyle | 78 | master passed | | +1 | shadedjars | 286 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 40 | master passed | | 0 | spotbugs | 287 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 285 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 311 | the patch passed | | +1 | compile | 57 | the patch passed | | +1 | javac | 57 | the patch passed | | -1 | checkstyle | 86 | hbase-server: The patch generated 17 new + 64 unchanged - 0 fixed = 81 total (was 64) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | -1 | shadedjars | 222 | patch has 10 errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1029 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 34 | the patch passed | | +1 | findbugs | 281 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 9318 | hbase-server in the patch passed. | | -1 | asflicense | 27 | The patch generated 1 ASF License warnings. | | | | 12927 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/439 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux f22a2e9f6da3 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-439/out/precommit/personality/provided.sh | | git revision | master / 7e6684b1f4 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/2/artifact/out/diff-checkstyle-hbase-server.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/2/artifact/out/patch-shadedjars.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/2/testReport/ | | asflicense | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/2/artifact/out/patch-asflicense-problems.txt | | Max. process+thread count | 4576 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #437: HBASE-22539 WAL corruption due to early DBBs re-use when Durability.A…
Apache-HBase commented on issue #437: HBASE-22539 WAL corruption due to early DBBs re-use when Durability.A… URL: https://github.com/apache/hbase/pull/437#issuecomment-517506579 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 33 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 6 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 336 | master passed | | +1 | compile | 61 | master passed | | +1 | checkstyle | 94 | master passed | | +1 | shadedjars | 302 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 38 | master passed | | 0 | spotbugs | 281 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 278 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 328 | the patch passed | | +1 | compile | 59 | the patch passed | | +1 | javac | 59 | the patch passed | | -1 | checkstyle | 92 | hbase-server: The patch generated 1 new + 49 unchanged - 0 fixed = 50 total (was 49) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 304 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1032 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 35 | the patch passed | | +1 | findbugs | 271 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 8999 | hbase-server in the patch passed. | | +1 | asflicense | 25 | The patch does not generate ASF License warnings. | | | | 12739 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-437/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/437 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 331885c1c25d 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-437/out/precommit/personality/provided.sh | | git revision | master / 7e6684b1f4 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-437/4/artifact/out/diff-checkstyle-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-437/4/testReport/ | | Max. process+thread count | 4844 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-437/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend URL: https://github.com/apache/hbase/pull/390#issuecomment-517503726 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 40 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 291 | master passed | | +1 | compile | 54 | master passed | | +1 | checkstyle | 75 | master passed | | +1 | shadedjars | 265 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 31 | master passed | | 0 | spotbugs | 246 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 243 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 280 | the patch passed | | +1 | compile | 52 | the patch passed | | +1 | javac | 52 | the patch passed | | -1 | checkstyle | 79 | hbase-server: The patch generated 5 new + 375 unchanged - 1 fixed = 380 total (was 376) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 267 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 870 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 31 | the patch passed | | +1 | findbugs | 242 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 8358 | hbase-server in the patch passed. | | +1 | asflicense | 23 | The patch does not generate ASF License warnings. | | | | 11584 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/24/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/390 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 0184ad85ab92 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-390/out/precommit/personality/provided.sh | | git revision | master / 7e6684b1f4 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/24/artifact/out/diff-checkstyle-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/24/testReport/ | | Max. process+thread count | 4402 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/24/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment
Apache-HBase commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment URL: https://github.com/apache/hbase/pull/439#issuecomment-517501432 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 77 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 291 | master passed | | +1 | compile | 52 | master passed | | +1 | checkstyle | 76 | master passed | | +1 | shadedjars | 274 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 34 | master passed | | 0 | spotbugs | 231 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 229 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 293 | the patch passed | | +1 | compile | 53 | the patch passed | | +1 | javac | 53 | the patch passed | | -1 | checkstyle | 74 | hbase-server: The patch generated 17 new + 64 unchanged - 0 fixed = 81 total (was 64) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | -1 | shadedjars | 218 | patch has 10 errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 898 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 33 | the patch passed | | +1 | findbugs | 236 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 8231 | hbase-server in the patch passed. | | -1 | asflicense | 38 | The patch generated 1 ASF License warnings. | | | | 11487 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/439 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 6114c73b8132 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-439/out/precommit/personality/provided.sh | | git revision | master / 237229cade | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/1/artifact/out/diff-checkstyle-hbase-server.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/1/artifact/out/patch-shadedjars.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/1/testReport/ | | asflicense | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/1/artifact/out/patch-asflicense-problems.txt | | Max. process+thread count | 4754 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22047) LeaseException in Scan should be retired
[
https://issues.apache.org/jira/browse/HBASE-22047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Purtell updated HBASE-22047:
---
Fix Version/s: 1.5.0
> LeaseException in Scan should be retired
>
>
> Key: HBASE-22047
> URL: https://issues.apache.org/jira/browse/HBASE-22047
> Project: HBase
> Issue Type: Bug
> Components: Client, Scanners
>Affects Versions: 2.2.0, 2.0.4, 2.1.3
>Reporter: Allan Yang
>Assignee: Igor Rudenko
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.2.0, 2.3.0, 2.1.5
>
>
> We should retry LeaseException just like other exceptions like
> OutOfOrderScannerNextException and UnknownScannerException
> Code in ClientScanner：
> {code:java}
> if ((cause != null && cause instanceof NotServingRegionException) ||
> (cause != null && cause instanceof RegionServerStoppedException) ||
> e instanceof OutOfOrderScannerNextException || e instanceof
> UnknownScannerException ||
> e instanceof ScannerResetException) {
> // Pass. It is easier writing the if loop test as list of what is
> allowed rather than
> // as a list of what is not allowed... so if in here, it means we do
> not throw.
> if (retriesLeft <= 0) {
> throw e; // no more retries
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22047) LeaseException in Scan should be retired
[
https://issues.apache.org/jira/browse/HBASE-22047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898436#comment-16898436
]
Andrew Purtell commented on HBASE-22047:
Thanks [~pankaj2461], agree, we can do this for/in 1.5.0. Let me pick it back
> LeaseException in Scan should be retired
>
>
> Key: HBASE-22047
> URL: https://issues.apache.org/jira/browse/HBASE-22047
> Project: HBase
> Issue Type: Bug
> Components: Client, Scanners
>Affects Versions: 2.2.0, 2.0.4, 2.1.3
>Reporter: Allan Yang
>Assignee: Igor Rudenko
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>
>
> We should retry LeaseException just like other exceptions like
> OutOfOrderScannerNextException and UnknownScannerException
> Code in ClientScanner：
> {code:java}
> if ((cause != null && cause instanceof NotServingRegionException) ||
> (cause != null && cause instanceof RegionServerStoppedException) ||
> e instanceof OutOfOrderScannerNextException || e instanceof
> UnknownScannerException ||
> e instanceof ScannerResetException) {
> // Pass. It is easier writing the if loop test as list of what is
> allowed rather than
> // as a list of what is not allowed... so if in here, it means we do
> not throw.
> if (retriesLeft <= 0) {
> throw e; // no more retries
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22707) [HBCK2] MasterRpcServices assigns method should try to reload regions from meta if the passed regions isn't found under AssignmentManager RegionsStateStore
[
https://issues.apache.org/jira/browse/HBASE-22707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898433#comment-16898433
]
Hudson commented on HBASE-22707:
Results for branch master
[build #1304 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1304/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1304//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1304//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1304//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [HBCK2] MasterRpcServices assigns method should try to reload regions from
> meta if the passed regions isn't found under AssignmentManager
> RegionsStateStore
> ---
>
> Key: HBASE-22707
> URL: https://issues.apache.org/jira/browse/HBASE-22707
> Project: HBase
> Issue Type: Task
> Components: hbck2, master
>Affects Versions: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-22707.branch-2.001.patch,
> HBASE-22707.branch-2.002.patch, HBASE-22707.master.001.patch
>
>
> Although HBCK2 related, this is a master side improvement. On situations
> where regions are missing in META, any online fix tool such as the one being
> implemented in HBASE-22567 would require a further master restart to get
> RegionsStateStore reloaded from META, so that master can be aware of the
> newly re-added regions.
> After regions are re-added to meta in CLOSED state, it should be possible to
> bring those by simply invoking hbck2 _assigns_ command. But before
> _MasterRpcServices.assigns_ submits an _Assign_ procedure, it validates first
> if the given region is available on _AssignmentManager.RegionsStateStore_.
> The current patch reloads meta on _MasterRpcServices.assigns_ if the given
> region is not found on the first lookup, then try a new lookup again before
> giving-up on region assignment.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase
[
https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898430#comment-16898430
]
Hudson commented on HBASE-22514:
Results for branch HBASE-22514
[build #40 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/40/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/40//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/40//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/40//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move rsgroup feature into core of HBase
> ---
>
> Key: HBASE-22514
> URL: https://issues.apache.org/jira/browse/HBASE-22514
> Project: HBase
> Issue Type: Umbrella
> Components: Admin, Client, rsgroup
>Reporter: Yechao Chen
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22514.master.001.patch,
> image-2019-05-31-18-25-38-217.png
>
>
> The class RSGroupAdminClient is not public
> we need to use java api RSGroupAdminClient to manager RSG
> so RSGroupAdminClient should be public
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-517481193 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 63 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 493 | master passed | | +1 | compile | 30 | master passed | | +1 | checkstyle | 16 | master passed | | +1 | shadedjars | 340 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 24 | master passed | | 0 | spotbugs | 60 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 57 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 437 | the patch passed | | +1 | compile | 30 | the patch passed | | +1 | javac | 30 | the patch passed | | +1 | checkstyle | 14 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 351 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1156 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 23 | the patch passed | | +1 | findbugs | 68 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 691 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 12 | The patch does not generate ASF License warnings. | | | | 4286 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/47/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/387 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 418126ac5f9c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh | | git revision | master / 7e6684b1f4 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/47/testReport/ | | Max. process+thread count | 4584 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/47/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #436: HBASE-22699 refactor isMetaClearingException
Apache-HBase commented on issue #436: HBASE-22699 refactor isMetaClearingException URL: https://github.com/apache/hbase/pull/436#issuecomment-517478036 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 62 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 20 | Maven dependency ordering for branch | | +1 | mvninstall | 314 | master passed | | +1 | compile | 54 | master passed | | +1 | checkstyle | 63 | master passed | | +1 | shadedjars | 258 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 47 | master passed | | 0 | spotbugs | 92 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 156 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | +1 | mvninstall | 330 | the patch passed | | +1 | compile | 56 | the patch passed | | +1 | javac | 56 | the patch passed | | -1 | checkstyle | 29 | hbase-client: The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 258 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 889 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 51 | the patch passed | | +1 | findbugs | 187 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 110 | hbase-client in the patch passed. | | +1 | unit | 258 | hbase-thrift in the patch passed. | | +1 | asflicense | 29 | The patch does not generate ASF License warnings. | | | | 3638 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/436 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 008191e1bbb8 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-436/out/precommit/personality/provided.sh | | git revision | master / 7e6684b1f4 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/4/artifact/out/diff-checkstyle-hbase-client.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/4/testReport/ | | Max. process+thread count | 1680 (vs. ulimit of 1) | | modules | C: hbase-client hbase-thrift U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes
Apache-HBase commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes URL: https://github.com/apache/hbase/pull/374#issuecomment-517477189 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 187 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 389 | master passed | | +1 | compile | 21 | master passed | | +1 | checkstyle | 24 | master passed | | +1 | shadedjars | 263 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 22 | master passed | | 0 | spotbugs | 54 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 53 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 328 | the patch passed | | +1 | compile | 23 | the patch passed | | +1 | javac | 23 | the patch passed | | -1 | checkstyle | 24 | hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 287 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 895 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 20 | the patch passed | | +1 | findbugs | 62 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 198 | hbase-common in the patch passed. | | +1 | asflicense | 13 | The patch does not generate ASF License warnings. | | | | 3194 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/48/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/374 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 375240ab7d6b 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh | | git revision | master / 7e6684b1f4 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/48/artifact/out/diff-checkstyle-hbase-common.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/48/testReport/ | | Max. process+thread count | 292 (vs. ulimit of 1) | | modules | C: hbase-common U: hbase-common | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/48/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #438: HBASE-11062 hbtop
Apache-HBase commented on issue #438: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/438#issuecomment-517475449 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 40 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | 0 | shelldocs | 0 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 19 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 12 | Maven dependency ordering for branch | | -1 | mvninstall | 79 | root in master failed. | | +1 | compile | 161 | master passed | | +1 | checkstyle | 134 | master passed | | +1 | shadedjars | 261 | branch has no errors when building our shaded downstream artifacts. | | -1 | javadoc | 86 | root in master failed. | | 0 | spotbugs | 887 | Used deprecated FindBugs config; considering switching to SpotBugs. | | 0 | findbugs | 26 | branch/hbase-assembly no findbugs output file (findbugsXml.xml) | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | -1 | mvninstall | 85 | root in the patch failed. | | -1 | compile | 158 | root in the patch failed. | | -1 | javac | 158 | root in the patch failed. | | -1 | checkstyle | 144 | The patch fails to run checkstyle in root | | +1 | shellcheck | 2 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 3 | The patch has no ill-formed XML file. | | +1 | shadedjars | 268 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 76 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 152 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 231 | The patch causes 10 errors with Hadoop v3.1.2. | | -1 | javadoc | 14 | hbase-hbtop generated 25 new + 0 unchanged - 0 fixed = 25 total (was 0) | | -1 | javadoc | 91 | root in the patch failed. | | -1 | javadoc | 11 | hbase-assembly in the patch failed. | | -1 | findbugs | 18 | hbase-hbtop in the patch failed. | | -1 | findbugs | 863 | root in the patch failed. | | -1 | findbugs | 10 | hbase-assembly in the patch failed. | ||| _ Other Tests _ | | -1 | unit | 11338 | root in the patch failed. | | -1 | asflicense | 75 | The patch generated 2 ASF License warnings. | | | | 15122 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.snapshot.TestExportSnapshotNoCluster | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/438 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle | | uname | Linux 367e087c5f7f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-438/out/precommit/personality/provided.sh | | git revision | master / 237229cade | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/1/artifact/out/branch-mvninstall-root.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/1/artifact/out/branch-javadoc-root.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/1/artifact/out/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/1/artifact/out/patch-compile-root.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/1/artifact/out/patch-compile-root.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/1/artifact/out//home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-438/out/maven-patch-checkstyle-root.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/1/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/1/artifact/out/patch-javac-2.9.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/1/artifact/out/patch-javac-3.1.2.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/1/artifact/out/diff-javadoc-javadoc-hbase-hbtop.txt | | javadoc | https://builds.apache.
[GitHub] [hbase] Apache-HBase commented on issue #434: HBASE-22609 [Docs] More detail documentation about...
Apache-HBase commented on issue #434: HBASE-22609 [Docs] More detail documentation about... URL: https://github.com/apache/hbase/pull/434#issuecomment-517470446 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 123 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 | mvninstall | 430 | master passed | | 0 | refguide | 405 | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 423 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | 0 | refguide | 396 | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Other Tests _ | | +1 | asflicense | 19 | The patch does not generate ASF License warnings. | | | | 1870 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/10/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/434 | | Optional Tests | dupname asflicense refguide | | uname | Linux d6495e0e6608 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-434/out/precommit/personality/provided.sh | | git revision | master / 7e6684b1f4 | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/10/artifact/out/branch-site/book.html | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/10/artifact/out/patch-site/book.html | | Max. process+thread count | 55 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/10/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend URL: https://github.com/apache/hbase/pull/390#issuecomment-517456011 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 42 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 315 | master passed | | +1 | compile | 57 | master passed | | +1 | checkstyle | 85 | master passed | | +1 | shadedjars | 298 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 34 | master passed | | 0 | spotbugs | 247 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 244 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 297 | the patch passed | | +1 | compile | 56 | the patch passed | | +1 | javac | 56 | the patch passed | | -1 | checkstyle | 79 | hbase-server: The patch generated 5 new + 375 unchanged - 1 fixed = 380 total (was 376) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 267 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 921 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 34 | the patch passed | | +1 | findbugs | 268 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 8880 | hbase-server in the patch passed. | | +1 | asflicense | 25 | The patch does not generate ASF License warnings. | | | | 12283 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/23/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/390 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux e8830828fed1 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-390/out/precommit/personality/provided.sh | | git revision | master / 237229cade | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/23/artifact/out/diff-checkstyle-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/23/testReport/ | | Max. process+thread count | 5010 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/23/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22618) Provide a way to have Heterogeneous deployment
[
https://issues.apache.org/jira/browse/HBASE-22618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898356#comment-16898356
]
Pierre Zemb commented on HBASE-22618:
-
I just opened the PR [https://github.com/apache/hbase/pull/439]
> Provide a way to have Heterogeneous deployment
> --
>
> Key: HBASE-22618
> URL: https://issues.apache.org/jira/browse/HBASE-22618
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.1.6, 1.4.11
>Reporter: Pierre Zemb
>Priority: Major
>
> Hi,
> We wouls like to open the discussion about bringing the possibility to have
> regions deployed on {color:#22}Heterogeneous deployment{color}, i.e Hbase
> cluster running different kind of hardware.
> h2. Why?
> * Cloud deployments means that we may not be able to have the same hardware
> throughout the years
> * Some tables may need special requirements such as SSD whereas others
> should be using hard-drives
> * {color:#22} {color}*in our usecase*{color:#22}(single table,
> dedicated HBase and Hadoop tuned for our usecase, good key
> distribution){color}*, the number of regions per RS was the real limit for
> us*{color:#22}.{color}
> h2. Our usecase
> We found out that *in our usecase*(single table, dedicated HBase and Hadoop
> tuned for our usecase, good key distribution)*, the number of regions per RS
> was the real limit for us*.
> Over the years, due to historical reasons and also the need to benchmark new
> machines, we ended-up with differents groups of hardware: some servers can
> handle only 180 regions, whereas the biggest can handle more than 900.
> Because of such a difference, we had to disable the LoadBalancing to avoid
> the {{roundRobinAssigmnent}}. We developed some internal tooling which are
> responsible for load balancing regions across RegionServers. That was 1.5
> year ago.
> h2. Our Proof-of-concept
> We did work on a Proof-of-concept
> [here|https://github.com/PierreZ/hbase/blob/dev/hbase14/balancer/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/HeterogeneousBalancer.java],
> and some early tests
> [here|https://github.com/PierreZ/hbase/blob/dev/hbase14/balancer/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/HeterogeneousBalancer.java],
>
> [here|https://github.com/PierreZ/hbase/blob/dev/hbase14/balancer/hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestHeterogeneousBalancerBalance.java],
> and
> [here|https://github.com/PierreZ/hbase/blob/dev/hbase14/balancer/hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestHeterogeneousBalancerRules.java].
> We wrote the balancer for our use-case, which means that:
> * there is one table
> * there is no region-replica
> * good key dispersion
> * there is no regions on master
> A rule file is loaded before balancing. It contains lines of rules. A rule is
> composed of a regexp for hostname, and a limit. For example, we could have:
>
> {quote}rs[0-9] 200
> rs1[0-9] 50
> {quote}
>
> RegionServers with hostname matching the first rules will have a limit of
> 200, and the others 50. If there's no match, a default is set.
> Thanks to the rule, we have two informations: the max number of regions for
> this cluster, and the rules for each servers. {{HeterogeneousBalancer}} will
> try to balance regions according to their capacity.
> Let's take an example. Let's say that we have 20 RS:
> * 10 RS, named through {{rs0}} to {{rs9}} loaded with 60 regions each, and
> each can handle 200 regions.
> * 10 RS, named through {{rs10}} to {{rs19}} loaded with 60 regions each, and
> each can support 50 regions.
> Based on the following rules:
>
> {quote}rs[0-9] 200
> rs1[0-9] 50
> {quote}
>
> The second group is overloaded, whereas the first group has plenty of space.
> We know that we can handle at maximum *2500 regions* (200*10 + 50*10) and we
> have currently *1200 regions* (60*20). {{HeterogeneousBalancer}} will
> understand that the cluster is *full at 48.0%* (1200/2500). Based on this
> information, we will then *try to put all the RegionServers to ~48% of load
> according to the rules.* In this case, it will move regions from the second
> group to the first.
> The balancer will:
> * compute how many regions needs to be moved. In our example, by moving 36
> regions on rs10, we could go from 120.0% to 46.0%
> * select regions with lowest data-locality
> * try to find an appropriate RS for the region. We will take the lowest
> available RS.
> h2. Other implementations and ideas
> Clay Baenziger proposed this idea on the dev ML:
> {quote}{color:#22}Could it work to have the stochastic load balancer use
> [pluggable cost functions instead of this static list of cost
> functions|[https://github.com/apache/hbase/blob/baf3
[GitHub] [hbase] PierreZ opened a new pull request #439: HBASE-22618 Provide a way to have Heterogeneous deployment
PierreZ opened a new pull request #439: HBASE-22618 Provide a way to have Heterogeneous deployment URL: https://github.com/apache/hbase/pull/439 Hi! This is the PR regarding [HBASE-22618 ](https://issues.apache.org/jira/browse/HBASE-22618). The goal of the PR is to allow Heterogeneous HBase clusters. The goal is to allow users to load custom cost functions that can implement newer ways of balance regions. This first commit is providing to possibility load them, and a second commit on this branch will be added to add an working example of a custom cost function. This custom function will allow users to balance regions according to an allowed number of regions per RS. Before implementing the cost function, I want to validate first the dynamic load :smiley: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-517451208 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 73 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 13 | Maven dependency ordering for branch | | +1 | mvninstall | 317 | master passed | | +1 | compile | 80 | master passed | | +1 | checkstyle | 120 | master passed | | +1 | shadedjars | 293 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 56 | master passed | | 0 | spotbugs | 240 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 303 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 325 | the patch passed | | +1 | compile | 83 | the patch passed | | +1 | javac | 83 | the patch passed | | +1 | checkstyle | 119 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 293 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 999 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 57 | the patch passed | | +1 | findbugs | 328 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 104 | hbase-client in the patch passed. | | +1 | unit | 13349 | hbase-server in the patch passed. | | +1 | asflicense | 51 | The patch does not generate ASF License warnings. | | | | 17389 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/56/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/361 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux e842c76b60d2 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh | | git revision | master / 237229cade | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/56/testReport/ | | Max. process+thread count | 4546 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/56/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend URL: https://github.com/apache/hbase/pull/390#issuecomment-517447360 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 84 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 351 | master passed | | +1 | compile | 63 | master passed | | +1 | checkstyle | 103 | master passed | | +1 | shadedjars | 300 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 35 | master passed | | 0 | spotbugs | 261 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 259 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 327 | the patch passed | | +1 | compile | 58 | the patch passed | | +1 | javac | 58 | the patch passed | | -1 | checkstyle | 92 | hbase-server: The patch generated 1 new + 375 unchanged - 0 fixed = 376 total (was 375) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 308 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1036 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 | javadoc | 34 | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | findbugs | 269 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 12935 | hbase-server in the patch passed. | | +1 | asflicense | 24 | The patch does not generate ASF License warnings. | | | | 16700 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/22/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/390 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux a3b3659cf2d8 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-390/out/precommit/personality/provided.sh | | git revision | master / 237229cade | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/22/artifact/out/diff-checkstyle-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/22/artifact/out/diff-javadoc-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/22/testReport/ | | Max. process+thread count | 4400 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/22/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #437: HBASE-22539 WAL corruption due to early DBBs re-use when Durability.A…
Apache-HBase commented on issue #437: HBASE-22539 WAL corruption due to early DBBs re-use when Durability.A… URL: https://github.com/apache/hbase/pull/437#issuecomment-517444707 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 87 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 6 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 336 | master passed | | +1 | compile | 60 | master passed | | +1 | checkstyle | 90 | master passed | | +1 | shadedjars | 302 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 37 | master passed | | 0 | spotbugs | 246 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 244 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 333 | the patch passed | | +1 | compile | 59 | the patch passed | | +1 | javac | 59 | the patch passed | | -1 | checkstyle | 92 | hbase-server: The patch generated 1 new + 49 unchanged - 0 fixed = 50 total (was 49) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 300 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 994 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 33 | the patch passed | | +1 | findbugs | 255 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 12556 | hbase-server in the patch failed. | | +1 | asflicense | 25 | The patch does not generate ASF License warnings. | | | | 16220 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-437/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/437 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux e83908dbb657 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-437@2/out/precommit/personality/provided.sh | | git revision | master / 237229cade | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-437/3/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-437/3/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-437/3/testReport/ | | Max. process+thread count | 4475 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-437/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #426: HBASE-22695 Store the rsgroup of a table in table configuration
Apache-HBase commented on issue #426: HBASE-22695 Store the rsgroup of a table in table configuration URL: https://github.com/apache/hbase/pull/426#issuecomment-517441253 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 80 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 10 new or modified test files. | ||| _ HBASE-22514 Compile Tests _ | | 0 | mvndep | 36 | Maven dependency ordering for branch | | +1 | mvninstall | 408 | HBASE-22514 passed | | +1 | compile | 134 | HBASE-22514 passed | | +1 | checkstyle | 170 | HBASE-22514 passed | | +1 | shadedjars | 367 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 95 | HBASE-22514 passed | | 0 | spotbugs | 349 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 494 | HBASE-22514 passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 18 | Maven dependency ordering for patch | | +1 | mvninstall | 385 | the patch passed | | +1 | compile | 125 | the patch passed | | +1 | javac | 125 | the patch passed | | -1 | checkstyle | 95 | hbase-server: The patch generated 1 new + 136 unchanged - 15 fixed = 137 total (was 151) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 344 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1204 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 93 | the patch passed | | +1 | findbugs | 516 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 207 | hbase-common in the patch passed. | | +1 | unit | 126 | hbase-client in the patch passed. | | +1 | unit | 15495 | hbase-server in the patch passed. | | +1 | asflicense | 72 | The patch does not generate ASF License warnings. | | | | 21052 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/10/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/426 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux f5320d6ddfbc 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-426/out/precommit/personality/provided.sh | | git revision | HBASE-22514 / 33a99f2d28 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/10/artifact/out/diff-checkstyle-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/10/testReport/ | | Max. process+thread count | 4470 (vs. ulimit of 1) | | modules | C: hbase-common hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/10/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #428: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (master)
Apache-HBase commented on issue #428: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (master) URL: https://github.com/apache/hbase/pull/428#issuecomment-517424767 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 32 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 323 | master passed | | +1 | compile | 59 | master passed | | +1 | checkstyle | 88 | master passed | | +1 | shadedjars | 316 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 44 | master passed | | 0 | spotbugs | 278 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 276 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 346 | the patch passed | | +1 | compile | 80 | the patch passed | | +1 | javac | 80 | the patch passed | | +1 | checkstyle | 109 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 318 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1039 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 39 | the patch passed | | +1 | findbugs | 292 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 8961 | hbase-server in the patch passed. | | +1 | asflicense | 25 | The patch does not generate ASF License warnings. | | | | 12766 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/18/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/428 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 30cf60deaca1 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh | | git revision | master / 237229cade | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/18/testReport/ | | Max. process+thread count | 4236 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/18/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22707) [HBCK2] MasterRpcServices assigns method should try to reload regions from meta if the passed regions isn't found under AssignmentManager RegionsStateStore
[
https://issues.apache.org/jira/browse/HBASE-22707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898290#comment-16898290
]
HBase QA commented on HBASE-22707:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
38s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
59s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
11s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
42s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
7s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
25s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
50s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
5s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
12m 8s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
20s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}134m 42s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
37s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}188m 32s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.regionserver.TestScannerHeartbeatMessages |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/703/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22707 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12976449/HBASE-22707.branch-2.002.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 3876d1477b45 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 918f7ca24a |
| maven | vers
[jira] [Updated] (HBASE-11062) hbtop
[ https://issues.apache.org/jira/browse/HBASE-11062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-11062: - Status: Patch Available (was: In Progress) This still has the license issue for Lanterna (https://github.com/mabe02/lanterna) but other than that it's ready for review. I created a PR for this. > hbtop > - > > Key: HBASE-11062 > URL: https://issues.apache.org/jira/browse/HBASE-11062 > Project: HBase > Issue Type: New Feature > Components: hbtop >Reporter: Andrew Purtell >Assignee: Toshihiro Suzuki >Priority: Major > > A top-like monitor could be useful for testing, debugging, operations of > clusters of moderate size, and possibly for diagnosing issues in large > clusters. > Consider a curses interface like the one presented by atop > (http://www.atoptool.nl/images/screenshots/genericw.png) - with aggregate > metrics collected over a monitoring interval in the upper portion of the > pane, and a listing of discrete measurements sorted and filtered by various > criteria in the bottom part of the pane. One might imagine a cluster overview > with cluster aggregate metrics above and a list of regionservers sorted by > utilization below; and a regionserver view with process metrics above and a > list of metrics by operation type below, or a list of client connections, or > a list of threads, sorted by utilization, throughput, or latency. > Generically 'htop' is taken but would be distinctive in the HBase context, a > utility org.apache.hadoop.hbase.HTop > No need necessarily for a curses interface. Could be an external monitor with > a web front end as has been discussed before. I do like the idea of a process > that runs in a terminal because I interact with dev and test HBase clusters > exclusively by SSH. > UPDATE: > The tool name is changed from htop to hbtop. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] brfrn169 opened a new pull request #438: HBASE-11062 hbtop
brfrn169 opened a new pull request #438: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/438 This still has the license issue for Lanterna (https://github.com/mabe02/lanterna) but other than that it's ready for review. For the details of the discussion for the license issue: https://lists.apache.org/thread.html/7c6d5fc00d870d52253ce429aca1ef5f8f477fe2a8e384e3793e277e@%3Cdev.hbase.apache.org%3E https://github.com/mabe02/lanterna/issues/415 We can run hbtop by running `hbase top` command, and press 'h' key in the top screen for the help screen. For the details of hbtop, this is the presentation slides in NoSQL day 2019 (the name is changed from htop to hbtop): https://dataworkssummit.com/nosql-day-2019/session/supporting-apache-hbase-troubleshooting-and-supportability-improvements/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-11062) hbtop
[ https://issues.apache.org/jira/browse/HBASE-11062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-11062: - Component/s: (was: hbase-operator-tools) > hbtop > - > > Key: HBASE-11062 > URL: https://issues.apache.org/jira/browse/HBASE-11062 > Project: HBase > Issue Type: New Feature >Reporter: Andrew Purtell >Assignee: Toshihiro Suzuki >Priority: Major > > A top-like monitor could be useful for testing, debugging, operations of > clusters of moderate size, and possibly for diagnosing issues in large > clusters. > Consider a curses interface like the one presented by atop > (http://www.atoptool.nl/images/screenshots/genericw.png) - with aggregate > metrics collected over a monitoring interval in the upper portion of the > pane, and a listing of discrete measurements sorted and filtered by various > criteria in the bottom part of the pane. One might imagine a cluster overview > with cluster aggregate metrics above and a list of regionservers sorted by > utilization below; and a regionserver view with process metrics above and a > list of metrics by operation type below, or a list of client connections, or > a list of threads, sorted by utilization, throughput, or latency. > Generically 'htop' is taken but would be distinctive in the HBase context, a > utility org.apache.hadoop.hbase.HTop > No need necessarily for a curses interface. Could be an external monitor with > a web front end as has been discussed before. I do like the idea of a process > that runs in a terminal because I interact with dev and test HBase clusters > exclusively by SSH. > UPDATE: > The tool name is changed from htop to hbtop. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-11062) hbtop
[ https://issues.apache.org/jira/browse/HBASE-11062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-11062: - Component/s: hbtop > hbtop > - > > Key: HBASE-11062 > URL: https://issues.apache.org/jira/browse/HBASE-11062 > Project: HBase > Issue Type: New Feature > Components: hbtop >Reporter: Andrew Purtell >Assignee: Toshihiro Suzuki >Priority: Major > > A top-like monitor could be useful for testing, debugging, operations of > clusters of moderate size, and possibly for diagnosing issues in large > clusters. > Consider a curses interface like the one presented by atop > (http://www.atoptool.nl/images/screenshots/genericw.png) - with aggregate > metrics collected over a monitoring interval in the upper portion of the > pane, and a listing of discrete measurements sorted and filtered by various > criteria in the bottom part of the pane. One might imagine a cluster overview > with cluster aggregate metrics above and a list of regionservers sorted by > utilization below; and a regionserver view with process metrics above and a > list of metrics by operation type below, or a list of client connections, or > a list of threads, sorted by utilization, throughput, or latency. > Generically 'htop' is taken but would be distinctive in the HBase context, a > utility org.apache.hadoop.hbase.HTop > No need necessarily for a curses interface. Could be an external monitor with > a web front end as has been discussed before. I do like the idea of a process > that runs in a terminal because I interact with dev and test HBase clusters > exclusively by SSH. > UPDATE: > The tool name is changed from htop to hbtop. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-11062) hbtop
[ https://issues.apache.org/jira/browse/HBASE-11062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-11062: - Description: A top-like monitor could be useful for testing, debugging, operations of clusters of moderate size, and possibly for diagnosing issues in large clusters. Consider a curses interface like the one presented by atop (http://www.atoptool.nl/images/screenshots/genericw.png) - with aggregate metrics collected over a monitoring interval in the upper portion of the pane, and a listing of discrete measurements sorted and filtered by various criteria in the bottom part of the pane. One might imagine a cluster overview with cluster aggregate metrics above and a list of regionservers sorted by utilization below; and a regionserver view with process metrics above and a list of metrics by operation type below, or a list of client connections, or a list of threads, sorted by utilization, throughput, or latency. Generically 'htop' is taken but would be distinctive in the HBase context, a utility org.apache.hadoop.hbase.HTop No need necessarily for a curses interface. Could be an external monitor with a web front end as has been discussed before. I do like the idea of a process that runs in a terminal because I interact with dev and test HBase clusters exclusively by SSH. UPDATE: The tool name is changed from htop to hbtop. was: A top-like monitor could be useful for testing, debugging, operations of clusters of moderate size, and possibly for diagnosing issues in large clusters. Consider a curses interface like the one presented by atop (http://www.atoptool.nl/images/screenshots/genericw.png) - with aggregate metrics collected over a monitoring interval in the upper portion of the pane, and a listing of discrete measurements sorted and filtered by various criteria in the bottom part of the pane. One might imagine a cluster overview with cluster aggregate metrics above and a list of regionservers sorted by utilization below; and a regionserver view with process metrics above and a list of metrics by operation type below, or a list of client connections, or a list of threads, sorted by utilization, throughput, or latency. Generically 'htop' is taken but would be distinctive in the HBase context, a utility org.apache.hadoop.hbase.HTop No need necessarily for a curses interface. Could be an external monitor with a web front end as has been discussed before. I do like the idea of a process that runs in a terminal because I interact with dev and test HBase clusters exclusively by SSH. > hbtop > - > > Key: HBASE-11062 > URL: https://issues.apache.org/jira/browse/HBASE-11062 > Project: HBase > Issue Type: New Feature > Components: hbase-operator-tools >Reporter: Andrew Purtell >Assignee: Toshihiro Suzuki >Priority: Major > > A top-like monitor could be useful for testing, debugging, operations of > clusters of moderate size, and possibly for diagnosing issues in large > clusters. > Consider a curses interface like the one presented by atop > (http://www.atoptool.nl/images/screenshots/genericw.png) - with aggregate > metrics collected over a monitoring interval in the upper portion of the > pane, and a listing of discrete measurements sorted and filtered by various > criteria in the bottom part of the pane. One might imagine a cluster overview > with cluster aggregate metrics above and a list of regionservers sorted by > utilization below; and a regionserver view with process metrics above and a > list of metrics by operation type below, or a list of client connections, or > a list of threads, sorted by utilization, throughput, or latency. > Generically 'htop' is taken but would be distinctive in the HBase context, a > utility org.apache.hadoop.hbase.HTop > No need necessarily for a curses interface. Could be an external monitor with > a web front end as has been discussed before. I do like the idea of a process > that runs in a terminal because I interact with dev and test HBase clusters > exclusively by SSH. > UPDATE: > The tool name is changed from htop to hbtop. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-11062) hbtop
[ https://issues.apache.org/jira/browse/HBASE-11062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-11062: - Summary: hbtop (was: htop) > hbtop > - > > Key: HBASE-11062 > URL: https://issues.apache.org/jira/browse/HBASE-11062 > Project: HBase > Issue Type: New Feature > Components: hbase-operator-tools >Reporter: Andrew Purtell >Assignee: Toshihiro Suzuki >Priority: Major > > A top-like monitor could be useful for testing, debugging, operations of > clusters of moderate size, and possibly for diagnosing issues in large > clusters. > Consider a curses interface like the one presented by atop > (http://www.atoptool.nl/images/screenshots/genericw.png) - with aggregate > metrics collected over a monitoring interval in the upper portion of the > pane, and a listing of discrete measurements sorted and filtered by various > criteria in the bottom part of the pane. One might imagine a cluster overview > with cluster aggregate metrics above and a list of regionservers sorted by > utilization below; and a regionserver view with process metrics above and a > list of metrics by operation type below, or a list of client connections, or > a list of threads, sorted by utilization, throughput, or latency. > Generically 'htop' is taken but would be distinctive in the HBase context, a > utility org.apache.hadoop.hbase.HTop > No need necessarily for a curses interface. Could be an external monitor with > a web front end as has been discussed before. I do like the idea of a process > that runs in a terminal because I interact with dev and test HBase clusters > exclusively by SSH. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-517367869 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 45 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 1 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 298 | master passed | | +1 | compile | 25 | master passed | | +1 | checkstyle | 13 | master passed | | +1 | shadedjars | 269 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 20 | master passed | | 0 | spotbugs | 45 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 42 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 295 | the patch passed | | +1 | compile | 24 | the patch passed | | +1 | javac | 24 | the patch passed | | +1 | checkstyle | 12 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 273 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 901 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 20 | the patch passed | | +1 | findbugs | 51 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 361 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 12 | The patch does not generate ASF License warnings. | | | | 3019 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/46/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/387 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux d4e865ab0b40 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh | | git revision | master / 237229cade | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/46/testReport/ | | Max. process+thread count | 4154 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/46/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve…
Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve… URL: https://github.com/apache/hbase/pull/435#issuecomment-517361926 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 45 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | 0 | shelldocs | 0 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 22 | Maven dependency ordering for branch | | -1 | mvninstall | 86 | root in master failed. | | -1 | compile | 34 | hbase-server in master failed. | | -1 | compile | 19 | hbase-rsgroup in master failed. | | +1 | checkstyle | 96 | master passed | | +1 | shadedjars | 255 | branch has no errors when building our shaded downstream artifacts. | | -1 | javadoc | 27 | hbase-server in master failed. | | 0 | spotbugs | 47 | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 | findbugs | 34 | hbase-server in master failed. | | -1 | findbugs | 19 | hbase-rsgroup in master failed. | ||| _ Patch Compile Tests _ | | 0 | mvndep | 13 | Maven dependency ordering for patch | | -1 | mvninstall | 85 | root in the patch failed. | | -1 | compile | 35 | hbase-server in the patch failed. | | -1 | compile | 20 | hbase-rsgroup in the patch failed. | | -1 | javac | 35 | hbase-server in the patch failed. | | -1 | javac | 20 | hbase-rsgroup in the patch failed. | | -1 | checkstyle | 72 | hbase-server: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9) | | +1 | shellcheck | 0 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 267 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 76 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 150 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 226 | The patch causes 10 errors with Hadoop v3.1.2. | | -1 | javadoc | 30 | hbase-server in the patch failed. | | -1 | findbugs | 54 | hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | -1 | findbugs | 37 | hbase-server in the patch failed. | | -1 | findbugs | 20 | hbase-rsgroup in the patch failed. | ||| _ Other Tests _ | | +1 | unit | 179 | hbase-common in the patch passed. | | -1 | unit | 36 | hbase-server in the patch failed. | | -1 | unit | 21 | hbase-rsgroup in the patch failed. | | +1 | asflicense | 31 | The patch does not generate ASF License warnings. | | | | 2049 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-common | | | org.apache.hadoop.hbase.Version.() invokes inefficient new String(String) constructor At Version.java:inefficient new String(String) constructor At Version.java:[line 10] | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/435 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 9be41672025a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-435/out/precommit/personality/provided.sh | | git revision | master / 237229cade | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/2/artifact/out/branch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/2/artifact/out/branch-compile-hbase-server.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/2/artifact/out/branch-compile-hbase-rsgroup.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/2/artifact/out/branch-javadoc-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/2/artifact/out/branch-findbugs-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/2/artifact/out/branch-findbugs-hbase-rsgroup.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/2/artifact/out/patch-mvninstall-root.txt | | compile | https://builds
[GitHub] [hbase] Apache-HBase commented on issue #436: HBASE-22699 refactor isMetaClearingException
Apache-HBase commented on issue #436: HBASE-22699 refactor isMetaClearingException URL: https://github.com/apache/hbase/pull/436#issuecomment-517360787 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 152 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 34 | Maven dependency ordering for branch | | +1 | mvninstall | 466 | master passed | | +1 | compile | 73 | master passed | | +1 | checkstyle | 83 | master passed | | +1 | shadedjars | 359 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 68 | master passed | | 0 | spotbugs | 106 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 190 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 414 | the patch passed | | +1 | compile | 68 | the patch passed | | +1 | javac | 68 | the patch passed | | -1 | checkstyle | 37 | hbase-client: The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 319 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1243 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 70 | the patch passed | | +1 | findbugs | 227 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 121 | hbase-client in the patch passed. | | +1 | unit | 368 | hbase-thrift in the patch passed. | | +1 | asflicense | 26 | The patch does not generate ASF License warnings. | | | | 4870 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/436 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 504a7a07cb48 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-436/out/precommit/personality/provided.sh | | git revision | master / 8cfc46d8d0 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/2/artifact/out/diff-checkstyle-hbase-client.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/2/testReport/ | | Max. process+thread count | 1511 (vs. ulimit of 1) | | modules | C: hbase-client hbase-thrift U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #437: HBASE-22539 WAL corruption due to early DBBs re-use when Durability.A…
Apache-HBase commented on issue #437: HBASE-22539 WAL corruption due to early DBBs re-use when Durability.A… URL: https://github.com/apache/hbase/pull/437#issuecomment-517360799 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 78 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 6 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 349 | master passed | | +1 | compile | 63 | master passed | | +1 | checkstyle | 103 | master passed | | +1 | shadedjars | 336 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 40 | master passed | | 0 | spotbugs | 272 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 271 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 321 | the patch passed | | +1 | compile | 57 | the patch passed | | +1 | javac | 57 | the patch passed | | -1 | checkstyle | 87 | hbase-server: The patch generated 1 new + 49 unchanged - 0 fixed = 50 total (was 49) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 292 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1001 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 34 | the patch passed | | +1 | findbugs | 264 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 1763 | hbase-server in the patch failed. | | +1 | asflicense | 13 | The patch does not generate ASF License warnings. | | | | 5482 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.coprocessor.TestCoreRegionCoprocessor | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-437/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/437 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux bf2fdf909ae7 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-437/out/precommit/personality/provided.sh | | git revision | master / 8cfc46d8d0 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-437/2/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-437/2/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-437/2/testReport/ | | Max. process+thread count | 673 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-437/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #436: HBASE-22699 refactor isMetaClearingException
Apache-HBase commented on issue #436: HBASE-22699 refactor isMetaClearingException URL: https://github.com/apache/hbase/pull/436#issuecomment-517358752 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 84 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 18 | Maven dependency ordering for branch | | -1 | mvninstall | 73 | root in master failed. | | -1 | compile | 20 | hbase-client in master failed. | | +1 | checkstyle | 58 | master passed | | +1 | shadedjars | 256 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 48 | master passed | | 0 | spotbugs | 93 | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 | findbugs | 17 | hbase-client in master failed. | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | -1 | mvninstall | 74 | root in the patch failed. | | -1 | compile | 19 | hbase-client in the patch failed. | | -1 | compile | 26 | hbase-thrift in the patch failed. | | -1 | javac | 19 | hbase-client in the patch failed. | | -1 | javac | 26 | hbase-thrift in the patch failed. | | -1 | checkstyle | 27 | hbase-client: The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 260 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 53 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 104 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 160 | The patch causes 10 errors with Hadoop v3.1.2. | | +1 | javadoc | 51 | the patch passed | | -1 | findbugs | 21 | hbase-client in the patch failed. | | -1 | findbugs | 26 | hbase-thrift in the patch failed. | ||| _ Other Tests _ | | -1 | unit | 20 | hbase-client in the patch failed. | | -1 | unit | 26 | hbase-thrift in the patch failed. | | +1 | asflicense | 19 | The patch does not generate ASF License warnings. | | | | 1552 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/436 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 2f3c0944caa3 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-436/out/precommit/personality/provided.sh | | git revision | master / 237229cade | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/3/artifact/out/branch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/3/artifact/out/branch-compile-hbase-client.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/3/artifact/out/branch-findbugs-hbase-client.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/3/artifact/out/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/3/artifact/out/patch-compile-hbase-client.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/3/artifact/out/patch-compile-hbase-thrift.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/3/artifact/out/patch-compile-hbase-client.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/3/artifact/out/patch-compile-hbase-thrift.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/3/artifact/out/diff-checkstyle-hbase-client.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/3/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/3/artifact/out/patch-javac-2.9.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/3/artifact/out/patch-javac-3.1.2.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/3/artifact/out/patch-findbugs-hbase-client.txt | | findbugs | ht
[GitHub] [hbase] Apache-HBase commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes
Apache-HBase commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes URL: https://github.com/apache/hbase/pull/374#issuecomment-517357561 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 84 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | -1 | mvninstall | 79 | root in master failed. | | +1 | compile | 19 | master passed | | +1 | checkstyle | 20 | master passed | | +1 | shadedjars | 259 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 17 | master passed | | 0 | spotbugs | 46 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 43 | master passed | ||| _ Patch Compile Tests _ | | -1 | mvninstall | 79 | root in the patch failed. | | +1 | compile | 20 | the patch passed | | +1 | javac | 20 | the patch passed | | -1 | checkstyle | 21 | hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 256 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 52 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 104 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 157 | The patch causes 10 errors with Hadoop v3.1.2. | | +1 | javadoc | 17 | the patch passed | | +1 | findbugs | 51 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 168 | hbase-common in the patch passed. | | +1 | asflicense | 9 | The patch does not generate ASF License warnings. | | | | 1369 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/47/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/374 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 33eb0c36e5b5 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh | | git revision | master / 237229cade | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/47/artifact/out/branch-mvninstall-root.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/47/artifact/out/patch-mvninstall-root.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/47/artifact/out/diff-checkstyle-hbase-common.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/47/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/47/artifact/out/patch-javac-2.9.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/47/artifact/out/patch-javac-3.1.2.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/47/testReport/ | | Max. process+thread count | 291 (vs. ulimit of 1) | | modules | C: hbase-common U: hbase-common | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/47/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #434: HBASE-22609 [Docs] More detail documentation about...
Apache-HBase commented on issue #434: HBASE-22609 [Docs] More detail documentation about... URL: https://github.com/apache/hbase/pull/434#issuecomment-517354384 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 45 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | -1 | mvninstall | 86 | root in master failed. | | -1 | refguide | 298 | branch has 21 errors when building the reference guide. | ||| _ Patch Compile Tests _ | | -1 | mvninstall | 82 | root in the patch failed. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | -1 | refguide | 310 | patch has 21 errors when building the reference guide. | ||| _ Other Tests _ | | +1 | asflicense | 12 | The patch does not generate ASF License warnings. | | | | 891 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/9/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/434 | | Optional Tests | dupname asflicense refguide | | uname | Linux f5f00196d92b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-434/out/precommit/personality/provided.sh | | git revision | master / 237229cade | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/9/artifact/out/branch-mvninstall-root.txt | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/9/artifact/out/branch-refguide.log | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/9/artifact/out/patch-mvninstall-root.txt | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/9/artifact/out/patch-refguide.log | | Max. process+thread count | 55 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/9/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22707) [HBCK2] MasterRpcServices assigns method should try to reload regions from meta if the passed regions isn't found under AssignmentManager RegionsStateStore
[ https://issues.apache.org/jira/browse/HBASE-22707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898174#comment-16898174 ] Wellington Chevreuil commented on HBASE-22707: -- Committed to master. Attaching a branch-2 patch for further validations, before applying it on branch-2. > [HBCK2] MasterRpcServices assigns method should try to reload regions from > meta if the passed regions isn't found under AssignmentManager > RegionsStateStore > --- > > Key: HBASE-22707 > URL: https://issues.apache.org/jira/browse/HBASE-22707 > Project: HBase > Issue Type: Task > Components: hbck2, master >Affects Versions: 3.0.0, 2.2.0, 2.3.0, 2.1.5 >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Major > Fix For: 3.0.0, 2.3.0 > > Attachments: HBASE-22707.branch-2.001.patch, > HBASE-22707.branch-2.002.patch, HBASE-22707.master.001.patch > > > Although HBCK2 related, this is a master side improvement. On situations > where regions are missing in META, any online fix tool such as the one being > implemented in HBASE-22567 would require a further master restart to get > RegionsStateStore reloaded from META, so that master can be aware of the > newly re-added regions. > After regions are re-added to meta in CLOSED state, it should be possible to > bring those by simply invoking hbck2 _assigns_ command. But before > _MasterRpcServices.assigns_ submits an _Assign_ procedure, it validates first > if the given region is available on _AssignmentManager.RegionsStateStore_. > The current patch reloads meta on _MasterRpcServices.assigns_ if the given > region is not found on the first lookup, then try a new lookup again before > giving-up on region assignment. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22707) [HBCK2] MasterRpcServices assigns method should try to reload regions from meta if the passed regions isn't found under AssignmentManager RegionsStateStore
[ https://issues.apache.org/jira/browse/HBASE-22707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-22707: - Attachment: HBASE-22707.branch-2.002.patch > [HBCK2] MasterRpcServices assigns method should try to reload regions from > meta if the passed regions isn't found under AssignmentManager > RegionsStateStore > --- > > Key: HBASE-22707 > URL: https://issues.apache.org/jira/browse/HBASE-22707 > Project: HBase > Issue Type: Task > Components: hbck2, master >Affects Versions: 3.0.0, 2.2.0, 2.3.0, 2.1.5 >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Major > Fix For: 3.0.0, 2.3.0 > > Attachments: HBASE-22707.branch-2.001.patch, > HBASE-22707.branch-2.002.patch, HBASE-22707.master.001.patch > > > Although HBCK2 related, this is a master side improvement. On situations > where regions are missing in META, any online fix tool such as the one being > implemented in HBASE-22567 would require a further master restart to get > RegionsStateStore reloaded from META, so that master can be aware of the > newly re-added regions. > After regions are re-added to meta in CLOSED state, it should be possible to > bring those by simply invoking hbck2 _assigns_ command. But before > _MasterRpcServices.assigns_ submits an _Assign_ procedure, it validates first > if the given region is available on _AssignmentManager.RegionsStateStore_. > The current patch reloads meta on _MasterRpcServices.assigns_ if the given > region is not found on the first lookup, then try a new lookup again before > giving-up on region assignment. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22707) [HBCK2] MasterRpcServices assigns method should try to reload regions from meta if the passed regions isn't found under AssignmentManager RegionsStateStore
[ https://issues.apache.org/jira/browse/HBASE-22707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898161#comment-16898161 ] Wellington Chevreuil commented on HBASE-22707: -- Latest build test failure is unrelated, got it passing locally. > [HBCK2] MasterRpcServices assigns method should try to reload regions from > meta if the passed regions isn't found under AssignmentManager > RegionsStateStore > --- > > Key: HBASE-22707 > URL: https://issues.apache.org/jira/browse/HBASE-22707 > Project: HBase > Issue Type: Task > Components: hbck2, master >Affects Versions: 3.0.0, 2.2.0, 2.3.0, 2.1.5 >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Major > Fix For: 3.0.0, 2.3.0 > > Attachments: HBASE-22707.branch-2.001.patch, > HBASE-22707.master.001.patch > > > Although HBCK2 related, this is a master side improvement. On situations > where regions are missing in META, any online fix tool such as the one being > implemented in HBASE-22567 would require a further master restart to get > RegionsStateStore reloaded from META, so that master can be aware of the > newly re-added regions. > After regions are re-added to meta in CLOSED state, it should be possible to > bring those by simply invoking hbck2 _assigns_ command. But before > _MasterRpcServices.assigns_ submits an _Assign_ procedure, it validates first > if the given region is available on _AssignmentManager.RegionsStateStore_. > The current patch reloads meta on _MasterRpcServices.assigns_ if the given > region is not found on the first lookup, then try a new lookup again before > giving-up on region assignment. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT
[
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898150#comment-16898150
]
Hudson commented on HBASE-22735:
Results for branch branch-2.2
[build #487 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/487/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/487//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/487//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/487//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/487//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735-master-tmp-justforreview.patch,
> HBASE-22735.branch-1.01.patch, HBASE-22735.branch-1.02.patch,
> HBASE-22735.branch-1.03.patch, HBASE-22735.branch-1.04.patch,
> HBASE-22735.master.01.patch, HBASE-22735.master.02.patch,
> HBASE-22735.master.03.patch, HBASE-22735.master.04.patch, Screen Shot
> 2019-07-30 at 11.53.53 PM.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and
> then prints them and some attributes such as the server where they are
> located, current request count, data locality, and such.
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil
> references and just display what we can.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22737) Add a new admin method and shell cmd to trigger the hbck chore to run
[
https://issues.apache.org/jira/browse/HBASE-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898149#comment-16898149
]
Hudson commented on HBASE-22737:
Results for branch branch-2.2
[build #487 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/487/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/487//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/487//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/487//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/487//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Add a new admin method and shell cmd to trigger the hbck chore to run
> -
>
> Key: HBASE-22737
> URL: https://issues.apache.org/jira/browse/HBASE-22737
> Project: HBase
> Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
>
> A follow-on issue after HBASE-22709.
> {quote}Oh, also as a follow-on, should make it so user can trigger this chore
> to run... or perhaps a new shell command which is called hbck_report that
> runs this chore and the catalogjanitor, etc., to produce all hbck.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Comment Edited] (HBASE-22539) WAL corruption due to early DBBs re-use when Durability.ASYNC_WAL is used
[
https://issues.apache.org/jira/browse/HBASE-22539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898148#comment-16898148
]
Wellington Chevreuil edited comment on HBASE-22539 at 8/1/19 3:36 PM:
--
{quote}Oh the UT has some problem, you should change the loop number to 100 for
the verifying loop...{quote}
Which problems did you have with the UT? I could consistently fail it without
the fix, and consistently pass it with the fix in place. The UT is also passing
in the patch build.
I'll check the submitted PR, meanwhile.
was (Author: wchevreuil):
{quote}Oh the UT has some problem, you should change the loop number to 100 for
the verifying loop...{quote}
Which problems did you have with the UT? I could consistently fail it without
the fix, and consistently pass it with the fix in place. The UT is also passing
in the patch build.
Looking on the submitted PR.
> WAL corruption due to early DBBs re-use when Durability.ASYNC_WAL is used
> -
>
> Key: HBASE-22539
> URL: https://issues.apache.org/jira/browse/HBASE-22539
> Project: HBase
> Issue Type: Bug
> Components: rpc, wal
>Affects Versions: 2.2.0, 2.0.5, 2.1.5
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Blocker
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22539-UT.patch, HBASE-22539.branch-2.001.patch
>
>
> Summary
> We had been chasing a WAL corruption issue reported on one of our customers
> deployments running release 2.1.1 (CDH 6.1.0). After providing a custom
> modified jar with the extra sanity checks implemented by HBASE-21401 applied
> on some code points, plus additional debugging messages, we believe it is
> related to DirectByteBuffer usage, and Unsafe copy from offheap memory to
> on-heap array triggered
> [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java#L1157],
> such as when writing into a non ByteBufferWriter type, as done
> [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferWriterOutputStream.java#L84].
> More details on the following comment.
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22539) WAL corruption due to early DBBs re-use when Durability.ASYNC_WAL is used
[
https://issues.apache.org/jira/browse/HBASE-22539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898148#comment-16898148
]
Wellington Chevreuil commented on HBASE-22539:
--
{quote}Oh the UT has some problem, you should change the loop number to 100 for
the verifying loop...{quote}
Which problems did you have with the UT? I could consistently fail it without
the fix, and consistently pass it with the fix in place. The UT is also passing
in the patch build.
Looking on the submitted PR.
> WAL corruption due to early DBBs re-use when Durability.ASYNC_WAL is used
> -
>
> Key: HBASE-22539
> URL: https://issues.apache.org/jira/browse/HBASE-22539
> Project: HBase
> Issue Type: Bug
> Components: rpc, wal
>Affects Versions: 2.2.0, 2.0.5, 2.1.5
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Blocker
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22539-UT.patch, HBASE-22539.branch-2.001.patch
>
>
> Summary
> We had been chasing a WAL corruption issue reported on one of our customers
> deployments running release 2.1.1 (CDH 6.1.0). After providing a custom
> modified jar with the extra sanity checks implemented by HBASE-21401 applied
> on some code points, plus additional debugging messages, we believe it is
> related to DirectByteBuffer usage, and Unsafe copy from offheap memory to
> on-heap array triggered
> [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java#L1157],
> such as when writing into a non ByteBufferWriter type, as done
> [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferWriterOutputStream.java#L84].
> More details on the following comment.
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-21879) Read HFile's block to ByteBuffer directly instead of to byte for reducing young gc purpose
[
https://issues.apache.org/jira/browse/HBASE-21879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898135#comment-16898135
]
Hudson commented on HBASE-21879:
Results for branch HBASE-21879
[build #195 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/195/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/195//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/195//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/195//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Read HFile's block to ByteBuffer directly instead of to byte for reducing
> young gc purpose
> --
>
> Key: HBASE-21879
> URL: https://issues.apache.org/jira/browse/HBASE-21879
> Project: HBase
> Issue Type: Improvement
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-21879.v1.patch, HBASE-21879.v1.patch,
> QPS-latencies-before-HBASE-21879.png, gc-data-before-HBASE-21879.png
>
>
> In HFileBlock#readBlockDataInternal, we have the following:
> {code}
> @VisibleForTesting
> protected HFileBlock readBlockDataInternal(FSDataInputStream is, long offset,
> long onDiskSizeWithHeaderL, boolean pread, boolean verifyChecksum,
> boolean updateMetrics)
> throws IOException {
> // .
> // TODO: Make this ByteBuffer-based. Will make it easier to go to HDFS with
> BBPool (offheap).
> byte [] onDiskBlock = new byte[onDiskSizeWithHeader + hdrSize];
> int nextBlockOnDiskSize = readAtOffset(is, onDiskBlock, preReadHeaderSize,
> onDiskSizeWithHeader - preReadHeaderSize, true, offset +
> preReadHeaderSize, pread);
> if (headerBuf != null) {
> // ...
> }
> // ...
> }
> {code}
> In the read path, we still read the block from hfile to on-heap byte[], then
> copy the on-heap byte[] to offheap bucket cache asynchronously, and in my
> 100% get performance test, I also observed some frequent young gc, The
> largest memory footprint in the young gen should be the on-heap block byte[].
> In fact, we can read HFile's block to ByteBuffer directly instead of to
> byte[] for reducing young gc purpose. we did not implement this before,
> because no ByteBuffer reading interface in the older HDFS client, but 2.7+
> has supported this now, so we can fix this now. I think.
> Will provide an patch and some perf-comparison for this.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve…
Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve… URL: https://github.com/apache/hbase/pull/435#issuecomment-517318638 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 125 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | 0 | shelldocs | 0 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for branch | | +1 | mvninstall | 390 | master passed | | +1 | compile | 109 | master passed | | +1 | checkstyle | 126 | master passed | | +1 | shadedjars | 291 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 80 | master passed | | 0 | spotbugs | 56 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 395 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 406 | the patch passed | | +1 | compile | 126 | the patch passed | | +1 | javac | 126 | the patch passed | | -1 | checkstyle | 91 | hbase-server: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9) | | +1 | shellcheck | 0 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 332 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1262 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 84 | the patch passed | | -1 | findbugs | 61 | hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 172 | hbase-common in the patch passed. | | +1 | unit | 15494 | hbase-server in the patch passed. | | +1 | unit | 435 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 75 | The patch does not generate ASF License warnings. | | | | 20943 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-common | | | org.apache.hadoop.hbase.Version.() invokes inefficient new String(String) constructor At Version.java:inefficient new String(String) constructor At Version.java:[line 10] | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/435 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 83f01673c8ef 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-435/out/precommit/personality/provided.sh | | git revision | master / 8cfc46d8d0 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/1/artifact/out/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/1/artifact/out/new-findbugs-hbase-common.html | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/1/testReport/ | | Max. process+thread count | 4890 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server hbase-rsgroup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #437: HBASE-22539 WAL corruption due to early DBBs re-use when Durability.A…
Apache-HBase commented on issue #437: HBASE-22539 WAL corruption due to early DBBs re-use when Durability.A… URL: https://github.com/apache/hbase/pull/437#issuecomment-517308414 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 43 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 4 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 297 | master passed | | +1 | compile | 51 | master passed | | +1 | checkstyle | 72 | master passed | | +1 | shadedjars | 266 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 35 | master passed | | 0 | spotbugs | 240 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 237 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 296 | the patch passed | | +1 | compile | 57 | the patch passed | | +1 | javac | 57 | the patch passed | | -1 | checkstyle | 73 | hbase-server: The patch generated 1 new + 49 unchanged - 0 fixed = 50 total (was 49) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 258 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 881 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 36 | the patch passed | | +1 | findbugs | 253 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 8447 | hbase-server in the patch failed. | | +1 | asflicense | 23 | The patch does not generate ASF License warnings. | | | | 11695 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.security.TestSecureIPC | | | hadoop.hbase.wal.TestWALCorruptionDueToDanglingByteBuffer | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-437/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/437 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux accfd33bafd3 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-437/out/precommit/personality/provided.sh | | git revision | master / 8cfc46d8d0 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-437/1/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-437/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-437/1/testReport/ | | Max. process+thread count | 4932 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-437/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22707) [HBCK2] MasterRpcServices assigns method should try to reload regions from meta if the passed regions isn't found under AssignmentManager RegionsStateStore
[
https://issues.apache.org/jira/browse/HBASE-22707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898089#comment-16898089
]
HBase QA commented on HBASE-22707:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
35s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
29s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
27s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
16s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
28s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
15m 10s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
38s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}133m 20s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
55s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}193m 8s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/702/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22707 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12976418/HBASE-22707.master.001.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux fbf9574b73e9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 8cfc46d8d0 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| f
[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT
[
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898074#comment-16898074
]
Hudson commented on HBASE-22735:
Results for branch branch-2
[build #2138 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2138/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2138//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2138//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2138//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735-master-tmp-justforreview.patch,
> HBASE-22735.branch-1.01.patch, HBASE-22735.branch-1.02.patch,
> HBASE-22735.branch-1.03.patch, HBASE-22735.branch-1.04.patch,
> HBASE-22735.master.01.patch, HBASE-22735.master.02.patch,
> HBASE-22735.master.03.patch, HBASE-22735.master.04.patch, Screen Shot
> 2019-07-30 at 11.53.53 PM.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and
> then prints them and some attributes such as the server where they are
> located, current request count, data locality, and such.
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil
> references and just display what we can.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22737) Add a new admin method and shell cmd to trigger the hbck chore to run
[
https://issues.apache.org/jira/browse/HBASE-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898073#comment-16898073
]
Hudson commented on HBASE-22737:
Results for branch branch-2
[build #2138 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2138/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2138//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2138//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2138//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add a new admin method and shell cmd to trigger the hbck chore to run
> -
>
> Key: HBASE-22737
> URL: https://issues.apache.org/jira/browse/HBASE-22737
> Project: HBase
> Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
>
> A follow-on issue after HBASE-22709.
> {quote}Oh, also as a follow-on, should make it so user can trigger this chore
> to run... or perhaps a new shell command which is called hbck_report that
> runs this chore and the catalogjanitor, etc., to produce all hbck.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache9 commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes
Apache9 commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes URL: https://github.com/apache/hbase/pull/374#issuecomment-517278661 Please finish this @HorizonNet ? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22767) System table RIT STUCK if their RSGroup has no highest version RSes
[ https://issues.apache.org/jira/browse/HBASE-22767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898054#comment-16898054 ] Guanghao Zhang commented on HBASE-22767: I thought the better fix should fallback to default group to find a RS... No need to add a BOGUS_SERVER_NAME and no need to fix these special cases. > System table RIT STUCK if their RSGroup has no highest version RSes > --- > > Key: HBASE-22767 > URL: https://issues.apache.org/jira/browse/HBASE-22767 > Project: HBase > Issue Type: Bug > Components: rsgroup >Reporter: Xiaolin Ha >Assignee: Xiaolin Ha >Priority: Major > > AM chooses highest version region servers as participants for system tables, > including META table. If system table group has no highest version region > servers, then the reassignment of their regions will be always the BOGUS > server defined in RSGroup. > In our test environment using branch-2.2, we isolate system tables in a > rsgroup containing only one server. And when upgrading RSs, we have met the > problem that META is always assigned to the BOGUS server while the group > server has already been online for a while. META RIT is stuck and can not be > recovered by hbck2. > I made a UT reproduce this problem, steps are: > 1. add a group, move 1 server to it; > 2. move meta table to the group; > 3. restart the group server and downgrade its version; > 4. meta rit stuck. > > ROOT cause is AM filters highest version RSs for system tables. So if we do > not change the versions of system table group servers, but upgrade the > versions of other group servers, then if there is reassignment for any system > tables, such as balancer moving their regions, RIT STUCK!! > > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22737) Add a new admin method and shell cmd to trigger the hbck chore to run
[
https://issues.apache.org/jira/browse/HBASE-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guanghao Zhang updated HBASE-22737:
---
Release Note: Add a new method runHbckChore in Hbck interface and a new
shell cmd hbck_chore_run to request HBCK chore to run at master side.
> Add a new admin method and shell cmd to trigger the hbck chore to run
> -
>
> Key: HBASE-22737
> URL: https://issues.apache.org/jira/browse/HBASE-22737
> Project: HBase
> Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
>
> A follow-on issue after HBASE-22709.
> {quote}Oh, also as a follow-on, should make it so user can trigger this chore
> to run... or perhaps a new shell command which is called hbck_report that
> runs this chore and the catalogjanitor, etc., to produce all hbck.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Resolved] (HBASE-22737) Add a new admin method and shell cmd to trigger the hbck chore to run
[
https://issues.apache.org/jira/browse/HBASE-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guanghao Zhang resolved HBASE-22737.
Resolution: Fixed
Fix Version/s: 2.1.6
2.2.1
2.0.6
2.3.0
3.0.0
Pushed to branch-2.0+. Thanks [~stack] for reviewing.
> Add a new admin method and shell cmd to trigger the hbck chore to run
> -
>
> Key: HBASE-22737
> URL: https://issues.apache.org/jira/browse/HBASE-22737
> Project: HBase
> Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
>
> A follow-on issue after HBASE-22709.
> {quote}Oh, also as a follow-on, should make it so user can trigger this chore
> to run... or perhaps a new shell command which is called hbck_report that
> runs this chore and the catalogjanitor, etc., to produce all hbck.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT
[
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897999#comment-16897999
]
Hudson commented on HBASE-22735:
Results for branch branch-2.1
[build #1441 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1441/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1441//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1441//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1441//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735-master-tmp-justforreview.patch,
> HBASE-22735.branch-1.01.patch, HBASE-22735.branch-1.02.patch,
> HBASE-22735.branch-1.03.patch, HBASE-22735.branch-1.04.patch,
> HBASE-22735.master.01.patch, HBASE-22735.master.02.patch,
> HBASE-22735.master.03.patch, HBASE-22735.master.04.patch, Screen Shot
> 2019-07-30 at 11.53.53 PM.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and
> then prints them and some attributes such as the server where they are
> located, current request count, data locality, and such.
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil
> references and just display what we can.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22737) Add a new admin method and shell cmd to trigger the hbck chore to run
[
https://issues.apache.org/jira/browse/HBASE-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898000#comment-16898000
]
Hudson commented on HBASE-22737:
Results for branch branch-2.1
[build #1441 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1441/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1441//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1441//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1441//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add a new admin method and shell cmd to trigger the hbck chore to run
> -
>
> Key: HBASE-22737
> URL: https://issues.apache.org/jira/browse/HBASE-22737
> Project: HBase
> Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
>
> A follow-on issue after HBASE-22709.
> {quote}Oh, also as a follow-on, should make it so user can trigger this chore
> to run... or perhaps a new shell command which is called hbck_report that
> runs this chore and the catalogjanitor, etc., to produce all hbck.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22737) Add a new admin method and shell cmd to trigger the hbck chore to run
[
https://issues.apache.org/jira/browse/HBASE-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897990#comment-16897990
]
Hudson commented on HBASE-22737:
Results for branch branch-2.0
[build #1820 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1820/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1820//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1820//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1820//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Add a new admin method and shell cmd to trigger the hbck chore to run
> -
>
> Key: HBASE-22737
> URL: https://issues.apache.org/jira/browse/HBASE-22737
> Project: HBase
> Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
>
> A follow-on issue after HBASE-22709.
> {quote}Oh, also as a follow-on, should make it so user can trigger this chore
> to run... or perhaps a new shell command which is called hbck_report that
> runs this chore and the catalogjanitor, etc., to produce all hbck.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache9 opened a new pull request #437: HBASE-22539 WAL corruption due to early DBBs re-use when Durability.A…
Apache9 opened a new pull request #437: HBASE-22539 WAL corruption due to early DBBs re-use when Durability.A… URL: https://github.com/apache/hbase/pull/437 …SYNC_WAL is used This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22539) WAL corruption due to early DBBs re-use when Durability.ASYNC_WAL is used
[ https://issues.apache.org/jira/browse/HBASE-22539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897966#comment-16897966 ] Duo Zhang commented on HBASE-22539: --- Oh the UT has some problem, you should change the loop number to 100 for the verifying loop... Anyway, I've implemented an ugly fix... Let me open a PR... > WAL corruption due to early DBBs re-use when Durability.ASYNC_WAL is used > - > > Key: HBASE-22539 > URL: https://issues.apache.org/jira/browse/HBASE-22539 > Project: HBase > Issue Type: Bug > Components: rpc, wal >Affects Versions: 2.2.0, 2.0.5, 2.1.5 >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Blocker > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > Attachments: HBASE-22539-UT.patch, HBASE-22539.branch-2.001.patch > > > Summary > We had been chasing a WAL corruption issue reported on one of our customers > deployments running release 2.1.1 (CDH 6.1.0). After providing a custom > modified jar with the extra sanity checks implemented by HBASE-21401 applied > on some code points, plus additional debugging messages, we believe it is > related to DirectByteBuffer usage, and Unsafe copy from offheap memory to > on-heap array triggered > [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java#L1157], > such as when writing into a non ByteBufferWriter type, as done > [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferWriterOutputStream.java#L84]. > More details on the following comment. > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT
[
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897957#comment-16897957
]
Hudson commented on HBASE-22735:
Results for branch master
[build #1302 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1302/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1302//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1302//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1302//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735-master-tmp-justforreview.patch,
> HBASE-22735.branch-1.01.patch, HBASE-22735.branch-1.02.patch,
> HBASE-22735.branch-1.03.patch, HBASE-22735.branch-1.04.patch,
> HBASE-22735.master.01.patch, HBASE-22735.master.02.patch,
> HBASE-22735.master.03.patch, HBASE-22735.master.04.patch, Screen Shot
> 2019-07-30 at 11.53.53 PM.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and
> then prints them and some attributes such as the server where they are
> located, current request count, data locality, and such.
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil
> references and just display what we can.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT
[
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897958#comment-16897958
]
Hudson commented on HBASE-22735:
Results for branch branch-1
[build #986 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/986/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/986//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/986//JDK7_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/986//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735-master-tmp-justforreview.patch,
> HBASE-22735.branch-1.01.patch, HBASE-22735.branch-1.02.patch,
> HBASE-22735.branch-1.03.patch, HBASE-22735.branch-1.04.patch,
> HBASE-22735.master.01.patch, HBASE-22735.master.02.patch,
> HBASE-22735.master.03.patch, HBASE-22735.master.04.patch, Screen Shot
> 2019-07-30 at 11.53.53 PM.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and
> then prints them and some attributes such as the server where they are
> located, current request count, data locality, and such.
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil
> references and just display what we can.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
