[jira] [Updated] (HBASE-22771) [HBCK2] fixMeta method and server-side support
[ https://issues.apache.org/jira/browse/HBASE-22771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22771: -- Release Note: Adds a fixMeta method to hbck Service. Fixes holes and overlaps in hbase:meta. Follow-on is adding a client-side to hbase-operator-tools that can exploit this new addition. > [HBCK2] fixMeta method and server-side support > -- > > Key: HBASE-22771 > URL: https://issues.apache.org/jira/browse/HBASE-22771 > Project: HBase > Issue Type: Sub-task > Components: hbck2 >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > Attachments: HBASE-22771.master.001.patch, > HBASE-22771.master.002.patch, HBASE-22771.master.003.patch, > HBASE-22771.master.004.patch > > > Add a fixMeta method to hbck Service. > HBCK2 tool in hbase-operator-tools will use this if it is available otherwise > it will do its own client-side version. Making these server-side versions so > can copy/exploit code/findings doing hbase-operator-tools HBCK2 tool version. > This does pure meta fixup plug holes and fix overlaps. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22771) [HBCK2] fixMeta method and server-side support
[ https://issues.apache.org/jira/browse/HBASE-22771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22771: -- Fix Version/s: 2.1.6 2.0.6 > [HBCK2] fixMeta method and server-side support > -- > > Key: HBASE-22771 > URL: https://issues.apache.org/jira/browse/HBASE-22771 > Project: HBase > Issue Type: Sub-task > Components: hbck2 >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > Attachments: HBASE-22771.master.001.patch, > HBASE-22771.master.002.patch, HBASE-22771.master.003.patch, > HBASE-22771.master.004.patch > > > Add a fixMeta method to hbck Service. > HBCK2 tool in hbase-operator-tools will use this if it is available otherwise > it will do its own client-side version. Making these server-side versions so > can copy/exploit code/findings doing hbase-operator-tools HBCK2 tool version. > This does pure meta fixup plug holes and fix overlaps. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #428: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (master)
Apache-HBase commented on issue #428: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (master) URL: https://github.com/apache/hbase/pull/428#issuecomment-518512225 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 104 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | -1 | mvninstall | 18 | root in master failed. | | -1 | compile | 55 | hbase-server in master failed. | | +1 | checkstyle | 95 | master passed | | +1 | shadedjars | 310 | branch has no errors when building our shaded downstream artifacts. | | -1 | javadoc | 38 | hbase-server in master failed. | | 0 | spotbugs | 393 | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 | findbugs | 44 | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | -1 | mvninstall | 11 | root in the patch failed. | | -1 | compile | 43 | hbase-server in the patch failed. | | -1 | javac | 43 | hbase-server in the patch failed. | | +1 | checkstyle | 92 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 303 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 9 | The patch causes 7 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 18 | The patch causes 7 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 27 | The patch causes 7 errors with Hadoop v3.1.2. | | -1 | javadoc | 31 | hbase-server in the patch failed. | | -1 | findbugs | 37 | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 | unit | 39 | hbase-server in the patch failed. | | +1 | asflicense | 9 | The patch does not generate ASF License warnings. | | | | 1322 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/33/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/428 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 4d08813ac48e 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh | | git revision | master / 08677143e8 | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/33/artifact/out/branch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/33/artifact/out/branch-compile-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/33/artifact/out/branch-javadoc-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/33/artifact/out/branch-findbugs-hbase-server.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/33/artifact/out/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/33/artifact/out/patch-compile-hbase-server.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/33/artifact/out/patch-compile-hbase-server.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/33/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/33/artifact/out/patch-javac-2.9.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/33/artifact/out/patch-javac-3.1.2.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/33/artifact/out/patch-javadoc-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/33/artifact/out/patch-findbugs-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/33/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/33/testReport/ | | Max. process+thread count | 77 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output |
[GitHub] [hbase] Apache-HBase commented on issue #436: HBASE-22699 refactor isMetaClearingException
Apache-HBase commented on issue #436: HBASE-22699 refactor isMetaClearingException URL: https://github.com/apache/hbase/pull/436#issuecomment-518511888 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 76 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | -1 | mvninstall | 75 | root in master failed. | | -1 | compile | 22 | hbase-client in master failed. | | +1 | checkstyle | 30 | master passed | | +1 | shadedjars | 282 | branch has no errors when building our shaded downstream artifacts. | | -1 | javadoc | 18 | hbase-client in master failed. | | 0 | spotbugs | 322 | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 | findbugs | 20 | hbase-client in master failed. | ||| _ Patch Compile Tests _ | | -1 | mvninstall | 71 | root in the patch failed. | | -1 | compile | 21 | hbase-client in the patch failed. | | -1 | javac | 21 | hbase-client in the patch failed. | | +1 | checkstyle | 31 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 290 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 59 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 120 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 179 | The patch causes 10 errors with Hadoop v3.1.2. | | -1 | javadoc | 22 | hbase-client in the patch failed. | | -1 | findbugs | 24 | hbase-client in the patch failed. | ||| _ Other Tests _ | | -1 | unit | 24 | hbase-client in the patch failed. | | +1 | asflicense | 10 | The patch does not generate ASF License warnings. | | | | 1255 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/20/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/436 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux c19ede384557 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-436/out/precommit/personality/provided.sh | | git revision | master / 08677143e8 | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/20/artifact/out/branch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/20/artifact/out/branch-compile-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/20/artifact/out/branch-javadoc-hbase-client.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/20/artifact/out/branch-findbugs-hbase-client.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/20/artifact/out/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/20/artifact/out/patch-compile-hbase-client.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/20/artifact/out/patch-compile-hbase-client.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/20/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/20/artifact/out/patch-javac-2.9.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/20/artifact/out/patch-javac-3.1.2.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/20/artifact/out/patch-javadoc-hbase-client.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/20/artifact/out/patch-findbugs-hbase-client.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/20/artifact/out/patch-unit-hbase-client.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/20/testReport/ | | Max. process+thread count | 77 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output |
[jira] [Commented] (HBASE-22771) [HBCK2] fixMeta method and server-side support
[ https://issues.apache.org/jira/browse/HBASE-22771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900642#comment-16900642 ] stack commented on HBASE-22771: --- Link to the addition of fix overlaps to the fixMeta added here. > [HBCK2] fixMeta method and server-side support > -- > > Key: HBASE-22771 > URL: https://issues.apache.org/jira/browse/HBASE-22771 > Project: HBase > Issue Type: Sub-task > Components: hbck2 >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1 > > Attachments: HBASE-22771.master.001.patch, > HBASE-22771.master.002.patch, HBASE-22771.master.003.patch, > HBASE-22771.master.004.patch > > > Add a fixMeta method to hbck Service. > HBCK2 tool in hbase-operator-tools will use this if it is available otherwise > it will do its own client-side version. Making these server-side versions so > can copy/exploit code/findings doing hbase-operator-tools HBCK2 tool version. > This does pure meta fixup plug holes and fix overlaps. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (HBASE-22796) [HBCK2] Add fix of overlaps to fixMeta hbck Service
stack created HBASE-22796: - Summary: [HBCK2] Add fix of overlaps to fixMeta hbck Service Key: HBASE-22796 URL: https://issues.apache.org/jira/browse/HBASE-22796 Project: HBase Issue Type: New Feature Reporter: stack fixMeta currently does holes in meta only courtesy of HBASE-22771 which added fixMeta to hbck Service; missing was fix of overlaps too. This JIRA is about adding fix of overlaps to general fixMeta call. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22771) [HBCK2] fixMeta method and server-side support
[ https://issues.apache.org/jira/browse/HBASE-22771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22771: -- Fix Version/s: 2.2.1 2.3.0 3.0.0 > [HBCK2] fixMeta method and server-side support > -- > > Key: HBASE-22771 > URL: https://issues.apache.org/jira/browse/HBASE-22771 > Project: HBase > Issue Type: Sub-task > Components: hbck2 >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1 > > Attachments: HBASE-22771.master.001.patch, > HBASE-22771.master.002.patch, HBASE-22771.master.003.patch, > HBASE-22771.master.004.patch > > > Add a fixMeta method to hbck Service. > HBCK2 tool in hbase-operator-tools will use this if it is available otherwise > it will do its own client-side version. Making these server-side versions so > can copy/exploit code/findings doing hbase-operator-tools HBCK2 tool version. > This does pure meta fixup plug holes and fix overlaps. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22771) [HBCK2] fixMeta method and server-side support
[ https://issues.apache.org/jira/browse/HBASE-22771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900627#comment-16900627 ] stack commented on HBASE-22771: --- Ok. I have signoff on this patch though it incomplete (does not have overlap fixes). Let me add those in a follow-on. This patch has infrastructure and fix holes. The failed test passes locally and seems totally unrelated. I fixed the checkstyle issues. Let me push. > [HBCK2] fixMeta method and server-side support > -- > > Key: HBASE-22771 > URL: https://issues.apache.org/jira/browse/HBASE-22771 > Project: HBase > Issue Type: Sub-task > Components: hbck2 >Reporter: stack >Assignee: stack >Priority: Major > Attachments: HBASE-22771.master.001.patch, > HBASE-22771.master.002.patch, HBASE-22771.master.003.patch, > HBASE-22771.master.004.patch > > > Add a fixMeta method to hbck Service. > HBCK2 tool in hbase-operator-tools will use this if it is available otherwise > it will do its own client-side version. Making these server-side versions so > can copy/exploit code/findings doing hbase-operator-tools HBCK2 tool version. > This does pure meta fixup plug holes and fix overlaps. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22778) Upgrade jasckson databind to 2.9.9.2
[ https://issues.apache.org/jira/browse/HBASE-22778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900609#comment-16900609 ] Duo Zhang commented on HBASE-22778: --- I’m not sure. Last time when upgrading to 2.9.9.1, [~apurtell] filed a separated issue for branch-1. > Upgrade jasckson databind to 2.9.9.2 > > > Key: HBASE-22778 > URL: https://issues.apache.org/jira/browse/HBASE-22778 > Project: HBase > Issue Type: Bug > Components: dependencies >Reporter: Duo Zhang >Assignee: niuyulin >Priority: Blocker > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > > Due to this CVE > https://nvd.nist.gov/vuln/detail/CVE-2019-14379 -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[
https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900607#comment-16900607
]
HBase QA commented on HBASE-22777:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
59s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 6 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
39s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
45s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 8m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
43s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 2m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
39s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
30s{color} | {color:red} hbase-client: The patch generated 12 new + 71
unchanged - 52 fixed = 83 total (was 123) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
13s{color} | {color:red} hbase-server: The patch generated 24 new + 426
unchanged - 5 fixed = 450 total (was 431) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
14s{color} | {color:red} hbase-rest: The patch generated 1 new + 3 unchanged -
0 fixed = 4 total (was 3) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
47s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
17m 28s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
2m 11s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
21s{color} | {color:red} hbase-client generated 2 new + 0 unchanged - 0 fixed =
2 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
34s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
32s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 6m
11s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
43s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}255m 29s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} |
[jira] [Created] (HBASE-22795) Align the API interfaces in TimeRange
Zheng Hu created HBASE-22795: Summary: Align the API interfaces in TimeRange Key: HBASE-22795 URL: https://issues.apache.org/jira/browse/HBASE-22795 Project: HBase Issue Type: Improvement Reporter: Zheng Hu Assignee: Zheng Hu There's a mail from user list , says TimeRange API is not good enough now. https://mail-archives.apache.org/mod_mbox/hbase-user/201908.mbox/%3C1D1D5676-615A-47ED-9A48-77445FAF1B29%40csiro.au%3E Need to align the API interfaces in TimeRange. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Comment Edited] (HBASE-22781) Not suitable params of StoreScanner in the test case TestStoreScanner.testScanSameTimestamp
[
https://issues.apache.org/jira/browse/HBASE-22781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900577#comment-16900577
]
Zheng Wang edited comment on HBASE-22781 at 8/6/19 3:31 AM:
If specfiy a col,the matcher will return INCLUDE_AND_SEEK_NEXT_ROW in first
loop,due to enough columns(and versions),it will never peek next cell,no matter
its timestamp.
But if set to null,the matcher will return INCLUDE in first loop, and return
SKIP in second loop,due to the below logic
(there is some wrong in my comment before):
{code:java}
ScanWildcardColumnTracker.java
checkVersions()
{
...
// If column matches, check if it is a duplicate timestamp
if (sameAsPreviousTSAndType(timestamp, type)) {
return ScanQueryMatcher.MatchCode.SKIP;
}
...
}
{code}
Another angle,if we remove the code above,the test can still pass with a col
specified,but can not pass if set null.
was (Author: filtertip):
If specfiy a col,the matcher will return INCLUDE_AND_SEEK_NEXT_ROW in first
loop,due to enough columns(and versions)
,it will never peek next cell,no matter its timestamp.
But if set to null,the matcher will return INCLUDE in first loop, and return
SKIP in second loop,due to the below logic
(there is some wrong in my comment before):
{code:java}
ScanWildcardColumnTracker.java
checkVersions()
{
...
// If column matches, check if it is a duplicate timestamp
if (sameAsPreviousTSAndType(timestamp, type)) {
return ScanQueryMatcher.MatchCode.SKIP;
}
...
}
{code}
Another angle,if we remove the code above,the test can still pass with a col
specified,but can not pass if set null.
> Not suitable params of StoreScanner in the test case
> TestStoreScanner.testScanSameTimestamp
> ---
>
> Key: HBASE-22781
> URL: https://issues.apache.org/jira/browse/HBASE-22781
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 2.0.0
>Reporter: Zheng Wang
>Assignee: Zheng Wang
>Priority: Minor
>
> {code:java}
> public void testScanSameTimestamp() throws IOException {
> // returns only 1 of these 2 even though same timestamp
> KeyValue [] kvs = new KeyValue[] {
> create("R1", "cf", "a", 1, KeyValue.Type.Put, "dont-care"),
> create("R1", "cf", "a", 1, KeyValue.Type.Put, "dont-care"),
> };
> List scanners = Arrays.asList(
> new KeyValueScanner[] {
> new KeyValueScanFixture(CellComparator.getInstance(), kvs)
> });
> Scan scanSpec = new Scan().withStartRow(Bytes.toBytes("R1"));
> // this only uses maxVersions (default=1) and TimeRange (default=all)
> try (StoreScanner scan = new StoreScanner(scanSpec, scanInfo, getCols("a"),
> scanners)) {
> List results = new ArrayList<>();
> assertEquals(true, scan.next(results));
> assertEquals(1, results.size());
> assertEquals(kvs[0], results.get(0));
> }
> }
> {code}
>
> It will not to compare the timestamp of the two cells,because of the
> 'getCols("a")' limit only one column and one version(default).
> For example,modify the timestamp of the first cell to 2 can also pass.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Comment Edited] (HBASE-22781) Not suitable params of StoreScanner in the test case TestStoreScanner.testScanSameTimestamp
[
https://issues.apache.org/jira/browse/HBASE-22781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900577#comment-16900577
]
Zheng Wang edited comment on HBASE-22781 at 8/6/19 3:31 AM:
If specfiy a col,the matcher will return INCLUDE_AND_SEEK_NEXT_ROW in first
loop,due to enough columns(and versions),it will never peek next cell,no matter
its timestamp.
But if set to null,the matcher will return INCLUDE in first loop, and return
SKIP in second loop,due to the below logic(there is some wrong in my comment
before):
{code:java}
ScanWildcardColumnTracker.java
checkVersions()
{
...
// If column matches, check if it is a duplicate timestamp
if (sameAsPreviousTSAndType(timestamp, type)) {
return ScanQueryMatcher.MatchCode.SKIP;
}
...
}
{code}
Another angle,if we remove the code above,the test can still pass with a col
specified,but can not pass if set null.
was (Author: filtertip):
If specfiy a col,the matcher will return INCLUDE_AND_SEEK_NEXT_ROW in first
loop,due to enough columns(and versions),it will never peek next cell,no matter
its timestamp.
But if set to null,the matcher will return INCLUDE in first loop, and return
SKIP in second loop,due to the below logic
(there is some wrong in my comment before):
{code:java}
ScanWildcardColumnTracker.java
checkVersions()
{
...
// If column matches, check if it is a duplicate timestamp
if (sameAsPreviousTSAndType(timestamp, type)) {
return ScanQueryMatcher.MatchCode.SKIP;
}
...
}
{code}
Another angle,if we remove the code above,the test can still pass with a col
specified,but can not pass if set null.
> Not suitable params of StoreScanner in the test case
> TestStoreScanner.testScanSameTimestamp
> ---
>
> Key: HBASE-22781
> URL: https://issues.apache.org/jira/browse/HBASE-22781
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 2.0.0
>Reporter: Zheng Wang
>Assignee: Zheng Wang
>Priority: Minor
>
> {code:java}
> public void testScanSameTimestamp() throws IOException {
> // returns only 1 of these 2 even though same timestamp
> KeyValue [] kvs = new KeyValue[] {
> create("R1", "cf", "a", 1, KeyValue.Type.Put, "dont-care"),
> create("R1", "cf", "a", 1, KeyValue.Type.Put, "dont-care"),
> };
> List scanners = Arrays.asList(
> new KeyValueScanner[] {
> new KeyValueScanFixture(CellComparator.getInstance(), kvs)
> });
> Scan scanSpec = new Scan().withStartRow(Bytes.toBytes("R1"));
> // this only uses maxVersions (default=1) and TimeRange (default=all)
> try (StoreScanner scan = new StoreScanner(scanSpec, scanInfo, getCols("a"),
> scanners)) {
> List results = new ArrayList<>();
> assertEquals(true, scan.next(results));
> assertEquals(1, results.size());
> assertEquals(kvs[0], results.get(0));
> }
> }
> {code}
>
> It will not to compare the timestamp of the two cells,because of the
> 'getCols("a")' limit only one column and one version(default).
> For example,modify the timestamp of the first cell to 2 can also pass.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-20952) Re-visit the WAL API
[
https://issues.apache.org/jira/browse/HBASE-20952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900579#comment-16900579
]
Hudson commented on HBASE-20952:
Results for branch HBASE-20952
[build #101 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20952/101/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20952/101//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20952/101//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20952/101//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Re-visit the WAL API
>
>
> Key: HBASE-20952
> URL: https://issues.apache.org/jira/browse/HBASE-20952
> Project: HBase
> Issue Type: Improvement
> Components: wal
>Reporter: Josh Elser
>Priority: Major
> Attachments: 20952.v1.txt
>
>
> Take a step back from the current WAL implementations and think about what an
> HBase WAL API should look like. What are the primitive calls that we require
> to guarantee durability of writes with a high degree of performance?
> The API needs to take the current implementations into consideration. We
> should also have a mind for what is happening in the Ratis LogService (but
> the LogService should not dictate what HBase's WAL API looks like RATIS-272).
> Other "systems" inside of HBase that use WALs are replication and
> backup Replication has the use-case for "tail"'ing the WAL which we
> should provide via our new API. B doesn't do anything fancy (IIRC). We
> should make sure all consumers are generally going to be OK with the API we
> create.
> The API may be "OK" (or OK in a part). We need to also consider other methods
> which were "bolted" on such as {{AbstractFSWAL}} and
> {{WALFileLengthProvider}}. Other corners of "WAL use" (like the
> {{WALSplitter}} should also be looked at to use WAL-APIs only).
> We also need to make sure that adequate interface audience and stability
> annotations are chosen.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22781) Not suitable params of StoreScanner in the test case TestStoreScanner.testScanSameTimestamp
[
https://issues.apache.org/jira/browse/HBASE-22781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900577#comment-16900577
]
Zheng Wang commented on HBASE-22781:
If specfiy a col,the matcher will return INCLUDE_AND_SEEK_NEXT_ROW in first
loop,due to enough columns(and versions)
,it will never peek next cell,no matter its timestamp.
But if set to null,the matcher will return INCLUDE in first loop, and return
SKIP in second loop,due to the below logic
(there is some wrong in my comment before):
{code:java}
ScanWildcardColumnTracker.java
checkVersions()
{
...
// If column matches, check if it is a duplicate timestamp
if (sameAsPreviousTSAndType(timestamp, type)) {
return ScanQueryMatcher.MatchCode.SKIP;
}
...
}
{code}
Another angle,if we remove the code above,the test can still pass with a col
specified,but can not pass if set null.
> Not suitable params of StoreScanner in the test case
> TestStoreScanner.testScanSameTimestamp
> ---
>
> Key: HBASE-22781
> URL: https://issues.apache.org/jira/browse/HBASE-22781
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 2.0.0
>Reporter: Zheng Wang
>Assignee: Zheng Wang
>Priority: Minor
>
> {code:java}
> public void testScanSameTimestamp() throws IOException {
> // returns only 1 of these 2 even though same timestamp
> KeyValue [] kvs = new KeyValue[] {
> create("R1", "cf", "a", 1, KeyValue.Type.Put, "dont-care"),
> create("R1", "cf", "a", 1, KeyValue.Type.Put, "dont-care"),
> };
> List scanners = Arrays.asList(
> new KeyValueScanner[] {
> new KeyValueScanFixture(CellComparator.getInstance(), kvs)
> });
> Scan scanSpec = new Scan().withStartRow(Bytes.toBytes("R1"));
> // this only uses maxVersions (default=1) and TimeRange (default=all)
> try (StoreScanner scan = new StoreScanner(scanSpec, scanInfo, getCols("a"),
> scanners)) {
> List results = new ArrayList<>();
> assertEquals(true, scan.next(results));
> assertEquals(1, results.size());
> assertEquals(kvs[0], results.get(0));
> }
> }
> {code}
>
> It will not to compare the timestamp of the two cells,because of the
> 'getCols("a")' limit only one column and one version(default).
> For example,modify the timestamp of the first cell to 2 can also pass.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] openinx commented on a change in pull request #440: HBASE-22776 Rename config names in user scan snapshot feature
openinx commented on a change in pull request #440: HBASE-22776 Rename config
names in user scan snapshot feature
URL: https://github.com/apache/hbase/pull/440#discussion_r310865311
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/SnapshotScannerHDFSAclController.java
##
@@ -233,9 +234,11 @@ public void
postDeleteTable(ObserverContext ctx,
try (Table aclTable =
ctx.getEnvironment().getConnection().getTable(PermissionStorage.ACL_TABLE_NAME))
{
Set users =
SnapshotScannerHDFSAclStorage.getTableUsers(aclTable, tableName);
-// 1. Delete table owner permission is synced to HDFS in acl table
+// 1. Remove table archive directory default ACLs
+hdfsAclHelper.removeTableDefaultAcl(tableName, users);
Review comment:
Also here , any UT to address the default acl removing ? If no , please add
some..
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] openinx commented on a change in pull request #440: HBASE-22776 Rename config names in user scan snapshot feature
openinx commented on a change in pull request #440: HBASE-22776 Rename config
names in user scan snapshot feature
URL: https://github.com/apache/hbase/pull/440#discussion_r310864902
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/SnapshotScannerHDFSAclHelper.java
##
@@ -71,23 +72,23 @@
public class SnapshotScannerHDFSAclHelper implements Closeable {
private static final Logger LOG =
LoggerFactory.getLogger(SnapshotScannerHDFSAclHelper.class);
- public static final String USER_SCAN_SNAPSHOT_ENABLE =
"hbase.user.scan.snapshot.enable";
- public static final String USER_SCAN_SNAPSHOT_THREAD_NUMBER =
- "hbase.user.scan.snapshot.thread.number";
+ public static final String ACL_SYNC_TO_HDFS_ENABLE =
"hbase.acl.sync.to.hdfs.enable";
Review comment:
better to name it as 'hbase.table.acl.sync.to.hdfs.enable' ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] openinx commented on a change in pull request #440: HBASE-22776 Rename config names in user scan snapshot feature
openinx commented on a change in pull request #440: HBASE-22776 Rename config
names in user scan snapshot feature
URL: https://github.com/apache/hbase/pull/440#discussion_r310864653
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/SnapshotScannerHDFSAclController.java
##
@@ -213,6 +213,7 @@ public void
postCompletedSnapshotAction(ObserverContext
c,
TableName tableName) throws IOException {
if (needHandleTableHdfsAcl(tableName, "truncateTable " + tableName)) {
+ hdfsAclHelper.createTableDirectories(tableName);
Review comment:
Why create the table directories here ? I guess the TruncateTableProcedure
will create the dir ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] openinx commented on a change in pull request #440: HBASE-22776 Rename config names in user scan snapshot feature
openinx commented on a change in pull request #440: HBASE-22776 Rename config
names in user scan snapshot feature
URL: https://github.com/apache/hbase/pull/440#discussion_r310865092
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/SnapshotScannerHDFSAclController.java
##
@@ -290,17 +293,24 @@ public void
postModifyTable(ObserverContext ctx,
public void
postDeleteNamespace(ObserverContext ctx,
String namespace) throws IOException {
if (checkInitialized("deleteNamespace " + namespace)) {
- // 1. Record namespace user acl is not synced to HDFS
-
SnapshotScannerHDFSAclStorage.deleteNamespaceHdfsAcl(ctx.getEnvironment().getConnection(),
-namespace);
- // 2. Delete tmp namespace directory
- /**
- * Delete namespace tmp directory because it's created by this
coprocessor when namespace is
- * created to make namespace default acl can be inherited by tables. The
namespace data
- * directory is deleted by DeleteNamespaceProcedure, the namespace
archive directory is
- * deleted by HFileCleaner.
- */
- hdfsAclHelper.deleteEmptyDir(pathHelper.getTmpNsDir(namespace));
+ try (Table aclTable =
+
ctx.getEnvironment().getConnection().getTable(PermissionStorage.ACL_TABLE_NAME))
{
+// 1. Delete namespace archive dir default ACLs
+Set users =
SnapshotScannerHDFSAclStorage.getEntryUsers(aclTable,
+ PermissionStorage.toNamespaceEntry(Bytes.toBytes(namespace)));
+hdfsAclHelper.removeNamespaceDefaultAcl(namespace, users);
Review comment:
Is there any test case to address the default acl removing ? Better to
have one, seems easy to miss this..
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] openinx commented on a change in pull request #440: HBASE-22776 Rename config names in user scan snapshot feature
openinx commented on a change in pull request #440: HBASE-22776 Rename config
names in user scan snapshot feature
URL: https://github.com/apache/hbase/pull/440#discussion_r310864062
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/SnapshotScannerHDFSAclHelper.java
##
@@ -511,9 +556,16 @@ boolean isNotFamilyOrQualifierPermission(TablePermission
tablePermission) {
return !tablePermission.hasFamily() && !tablePermission.hasQualifier();
}
- boolean isTableUserScanSnapshotEnabled(TableDescriptor tableDescriptor) {
+ public static boolean isAclSyncToHdfsEnabled(Configuration conf) {
+String masterCoprocessors =
conf.get(CoprocessorHost.MASTER_COPROCESSOR_CONF_KEY);
Review comment:
Use conf.getStrings to parse the masterCoprocessors ? and then use the
HashSet to check the existence of SnapshotScannerHDFSAclController &
AccessController ... that would be better...
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-22778) Upgrade jasckson databind to 2.9.9.2
[ https://issues.apache.org/jira/browse/HBASE-22778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900554#comment-16900554 ] Reid Chan commented on HBASE-22778: --- Can this back-port to branch-1 as well? (I'm not sure if any limitations > Upgrade jasckson databind to 2.9.9.2 > > > Key: HBASE-22778 > URL: https://issues.apache.org/jira/browse/HBASE-22778 > Project: HBase > Issue Type: Bug > Components: dependencies >Reporter: Duo Zhang >Assignee: niuyulin >Priority: Blocker > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > > Due to this CVE > https://nvd.nist.gov/vuln/detail/CVE-2019-14379 -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] sunhelly commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
sunhelly commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-518468536 ping @xcangCRM for reviewing This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] sunhelly commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve…
sunhelly commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve… URL: https://github.com/apache/hbase/pull/435#issuecomment-518468662 Ping @infraio for reviewing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22775) Enhance logging for peer related operations
[ https://issues.apache.org/jira/browse/HBASE-22775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900520#comment-16900520 ] Xu Cang commented on HBASE-22775: - Not yet [~apurtell] > Enhance logging for peer related operations > --- > > Key: HBASE-22775 > URL: https://issues.apache.org/jira/browse/HBASE-22775 > Project: HBase > Issue Type: Improvement >Reporter: Xu Cang >Assignee: Xu Cang >Priority: Minor > > Now we don't have good logging regarding peer operations, for example addPeer > does not log itself: > [https://github.com/apache/hbase/blob/master/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ZKReplicationPeerStorage.java#L102] > This Jira is aiming to enhancing this area -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Comment Edited] (HBASE-22775) Enhance logging for peer related operations
[ https://issues.apache.org/jira/browse/HBASE-22775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900519#comment-16900519 ] Andrew Purtell edited comment on HBASE-22775 at 8/6/19 1:26 AM: Is there a patch coming soon? Just wondering was (Author: apurtell): Is there a patch pending? > Enhance logging for peer related operations > --- > > Key: HBASE-22775 > URL: https://issues.apache.org/jira/browse/HBASE-22775 > Project: HBase > Issue Type: Improvement >Reporter: Xu Cang >Assignee: Xu Cang >Priority: Minor > > Now we don't have good logging regarding peer operations, for example addPeer > does not log itself: > [https://github.com/apache/hbase/blob/master/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ZKReplicationPeerStorage.java#L102] > This Jira is aiming to enhancing this area -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22775) Enhance logging for peer related operations
[ https://issues.apache.org/jira/browse/HBASE-22775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900519#comment-16900519 ] Andrew Purtell commented on HBASE-22775: Is there a patch pending? > Enhance logging for peer related operations > --- > > Key: HBASE-22775 > URL: https://issues.apache.org/jira/browse/HBASE-22775 > Project: HBase > Issue Type: Improvement >Reporter: Xu Cang >Assignee: Xu Cang >Priority: Minor > > Now we don't have good logging regarding peer operations, for example addPeer > does not log itself: > [https://github.com/apache/hbase/blob/master/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ZKReplicationPeerStorage.java#L102] > This Jira is aiming to enhancing this area -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22783) Remove deprecated classes(status and load) usage from hbase-shell
[ https://issues.apache.org/jira/browse/HBASE-22783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900518#comment-16900518 ] Andrew Purtell commented on HBASE-22783: The PR has an approver but we are waiting on other feedback to address some rubocop warnings > Remove deprecated classes(status and load) usage from hbase-shell > - > > Key: HBASE-22783 > URL: https://issues.apache.org/jira/browse/HBASE-22783 > Project: HBase > Issue Type: Sub-task > Components: shell >Affects Versions: 3.0.0 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-22783.master.01.patch > > > Need to replace deprecated usages of classes: ClusterStatus, RegionLoad, > ServerLoad from hbase-shell -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] apurtell commented on issue #455: HBASE-22783 : shell with removal of status and load classes
apurtell commented on issue #455: HBASE-22783 : shell with removal of status and load classes URL: https://github.com/apache/hbase/pull/455#issuecomment-518458973 IMHO some of the rubocop violations should be disabled. For example Metrics/AbcSize, Metrics/ClassLength, Metrics/MethodLength, and Metrics/BlockLength. These are highly opinionated and I'm not sure we share those opinions especially since the shell is a limited application of ruby. We aren't building a webapp with a ruby code base here. But please do address the Naming and Layout ones. I think the syntax warnings are good to have and adhere to. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] apurtell edited a comment on issue #455: HBASE-22783 : shell with removal of status and load classes
apurtell edited a comment on issue #455: HBASE-22783 : shell with removal of status and load classes URL: https://github.com/apache/hbase/pull/455#issuecomment-518458973 IMHO some of the rubocop violations should be disabled. For example Metrics/AbcSize, Metrics/ClassLength, Metrics/MethodLength, and Metrics/BlockLength. These are highly opinionated and I'm not sure we share those opinions especially since the shell is a limited application of ruby. This is jruby, not cruby. Do the performance implications implied by these warnings even apply? We aren't building a webapp with a ruby code base here. But please do address the Naming and Layout ones. I think the syntax warnings are good to have and adhere to. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22760) Stop/Resume Snapshot Auto-Cleanup activity with shell command
[ https://issues.apache.org/jira/browse/HBASE-22760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900514#comment-16900514 ] Andrew Purtell commented on HBASE-22760: I like the idea of shell triggered configuration reloads, but it would be new to switch functions on and off by reloading configuration (even if that is how it is implemented behind the scenes) and we would still end up with a balance_switch command, because we would be keeping the other foo_switch commands for backwards compatibility, and not having a switch function just for the balancer when we have them for the other functions would be weird. Agree with [~vjasani] and [~anoop.hbase], a new switch command for the balancer makes sense and is congruent with existing commands. > Stop/Resume Snapshot Auto-Cleanup activity with shell command > - > > Key: HBASE-22760 > URL: https://issues.apache.org/jira/browse/HBASE-22760 > Project: HBase > Issue Type: Improvement > Components: Admin, shell, snapshots >Affects Versions: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 1.4.11 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > > For any scheduled snapshot backup activity, we would like to disable > auto-cleaner for snapshot based on TTL. However, as per HBASE-22648 we have a > config to disable snapshot auto-cleaner: > hbase.master.cleaner.snapshot.disable, which would take effect only upon > HMaster restart just similar to any other hbase-site configs. > For any running cluster, we should be able to stop/resume auto-cleanup > activity for snapshot based on shell command. Something similar to below > command should be able to stop/start cleanup chore: > hbase(main):001:0> auto_snapshot_cleaner false (disable auto-cleaner) > hbase(main):001:0> auto_snapshot_cleaner true (enable auto-cleaner) -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-518457607 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 63 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 24 | Maven dependency ordering for branch | | +1 | mvninstall | 392 | master passed | | +1 | compile | 101 | master passed | | +1 | checkstyle | 133 | master passed | | +1 | shadedjars | 339 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 71 | master passed | | 0 | spotbugs | 325 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 409 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 18 | Maven dependency ordering for patch | | +1 | mvninstall | 384 | the patch passed | | +1 | compile | 100 | the patch passed | | +1 | javac | 100 | the patch passed | | +1 | checkstyle | 132 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 344 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1152 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 70 | the patch passed | | +1 | findbugs | 424 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 126 | hbase-client in the patch passed. | | -1 | unit | 16332 | hbase-server in the patch failed. | | +1 | asflicense | 58 | The patch does not generate ASF License warnings. | | | | 21143 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/70/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/361 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 76366cd1c553 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh | | git revision | master / ad3674f337 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/70/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/70/testReport/ | | Max. process+thread count | 4607 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/70/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22709) Add a chore thread in master to do hbck checking and display results in 'HBCK Report' page
[ https://issues.apache.org/jira/browse/HBASE-22709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900510#comment-16900510 ] Guanghao Zhang commented on HBASE-22709: bq. If yes, I can file the Jira & work on it. +1 to add a config to trun it off. > Add a chore thread in master to do hbck checking and display results in 'HBCK > Report' page > -- > > Key: HBASE-22709 > URL: https://issues.apache.org/jira/browse/HBASE-22709 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > Attachments: HBASE-22709.master.001.patch > > > See HBASE-21965. There may have two type of failed splited/merged regions. > One is orphan region on filesystem. Another one is unassigned daughter > regions or merged regions. Plan to add a seperate hbck.jsp for them. Will add > more hbck problems to this UI in future. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #438: HBASE-11062 hbtop
Apache-HBase commented on issue #438: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/438#issuecomment-518456208 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 85 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | 0 | shelldocs | 1 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 19 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 27 | Maven dependency ordering for branch | | -1 | mvninstall | 17 | root in master failed. | | +1 | compile | 199 | master passed | | +1 | checkstyle | 152 | master passed | | +1 | shadedjars | 279 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 210 | master passed | | 0 | spotbugs | 980 | Used deprecated FindBugs config; considering switching to SpotBugs. | | 0 | findbugs | 28 | branch/hbase-assembly no findbugs output file (findbugsXml.xml) | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | -1 | mvninstall | 10 | root in the patch failed. | | -1 | compile | 178 | root in the patch failed. | | -1 | javac | 178 | root in the patch failed. | | -1 | checkstyle | 150 | The patch fails to run checkstyle in root | | +1 | shellcheck | 2 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 4 | The patch has no ill-formed XML file. | | +1 | shadedjars | 298 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 11 | The patch causes 7 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 19 | The patch causes 7 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 29 | The patch causes 7 errors with Hadoop v3.1.2. | | -1 | javadoc | 156 | root in the patch failed. | | -1 | javadoc | 10 | hbase-assembly in the patch failed. | | -1 | findbugs | 1007 | root in the patch failed. | | -1 | findbugs | 11 | hbase-assembly in the patch failed. | ||| _ Other Tests _ | | -1 | unit | 16941 | root in the patch failed. | | -1 | asflicense | 120 | The patch generated 2 ASF License warnings. | | | | 21072 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.procedure.TestRestoreSnapshotProcedure | | | hadoop.hbase.client.TestAsyncTableAdminApi | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/16/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/438 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle | | uname | Linux dd5723be7aa4 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-438/out/precommit/personality/provided.sh | | git revision | master / ad3674f337 | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/16/artifact/out/branch-mvninstall-root.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/16/artifact/out/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/16/artifact/out/patch-compile-root.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/16/artifact/out/patch-compile-root.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/16/artifact/out//home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-438/out/maven-patch-checkstyle-root.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/16/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/16/artifact/out/patch-javac-2.9.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/16/artifact/out/patch-javac-3.1.2.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/16/artifact/out/patch-javadoc-root.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/16/artifact/out/patch-javadoc-hbase-assembly.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/16/artifact/out/patch-findbugs-root.txt | |
[GitHub] [hbase] Apache-HBase commented on issue #428: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (master)
Apache-HBase commented on issue #428: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (master) URL: https://github.com/apache/hbase/pull/428#issuecomment-518455992 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 65 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 365 | master passed | | +1 | compile | 70 | master passed | | +1 | checkstyle | 98 | master passed | | +1 | shadedjars | 351 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 43 | master passed | | 0 | spotbugs | 316 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 314 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 379 | the patch passed | | +1 | compile | 69 | the patch passed | | +1 | javac | 69 | the patch passed | | +1 | checkstyle | 92 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 349 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1189 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 43 | the patch passed | | +1 | findbugs | 319 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 16715 | hbase-server in the patch failed. | | +1 | asflicense | 35 | The patch does not generate ASF License warnings. | | | | 20971 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestAsyncTableAdminApi | | | hadoop.hbase.master.assignment.TestOpenRegionProcedureHang | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/32/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/428 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 8e5117f27b98 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh | | git revision | master / ad3674f337 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/32/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/32/testReport/ | | Max. process+thread count | 4904 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/32/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900145#comment-16900145 ] Geoffrey Jacoby edited comment on HBASE-22623 at 8/6/19 1:04 AM: - So, I see that the immutability of the Region-created WALEdit is an explicit goal of the current code, but what I'm trying to understand is _why_. Immutability can be a wonderful thing; it lets you write idempotent code along functional principles where methods have no side effects, just an output. But it seems to me the entire point of coprocessors _is to have side effects_. I'm sure we could come up with an indirect way to accomplish the adding of cells -- maybe something like WALEdit or List preWALAppend(WALKey, WALEditSuperInterfaceWithoutAddMethods edit), where HRegion then takes the returned new WALEdit or List and combines its Cells with the Cells of the existing WALEdit -- but I don't see what the added complexity achieves. It would just be more object churn for the garbage collector. Because coprocessors are embedded in core HBase logic, an operator is explicitly trusting the coproc author to get things right. It's good for the framework to make it easy to do the right thing, and guide people away from doing wrong or risky things. However, the messiest coproc-related bugs I've seen (both in Phoenix and some proprietary coprocs) have come from the hooks that are actually the most immutable: resource leaks from trying to recreate various types of scanners because setters aren't available. Not suggesting we change those hooks, just illustrating that immutable doesn't automatically mean "safe" or "easy" and mutable doesn't automatically mean "risky". It all depends on context. So I'm very curious what the context is here that makes the idea of changing the HRegion WALEdit directly risky, if changing it indirectly is OK. was (Author: gjacoby): So, I see that the immutability of the Region-created WALEdit is an explicit goal of the current code, but what I'm trying to understand is _why_. Immutability can be a wonderful thing; it lets you write idempotent code along functional principles where code has no side effects, just an output. But it seems to me the entire point of coprocessors _is to have side effects_. I'm sure we could come up with an indirect way to accomplish the adding of cells -- maybe something like WALEdit preWALAppend(WALKey, WALEditSuperInterfaceWithoutAddMethods edit), where HRegion then takes the returned new WALEdit and combines its Cells with the Cells of the existing WALEdit -- but I don't see what the added complexity achieves. It would just be more object churn for the garbage collector. > Add RegionObserver coprocessor hook for preWALAppend > > > Key: HBASE-22623 > URL: https://issues.apache.org/jira/browse/HBASE-22623 > Project: HBase > Issue Type: New Feature >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Fix For: 3.0.0, 1.5.0, 2.3.0 > > > While many coprocessor hooks expose the WALEdit to implementing coprocs, > there aren't any that expose the WALKey before it's created and added to the > WALEntry. > It's sometimes useful for coprocessors to be able to edit the WALKey, for > example to add extended attributes using the fields to be added in > HBASE-22622. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Comment Edited] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900506#comment-16900506 ] Andrew Purtell edited comment on HBASE-22623 at 8/6/19 12:59 AM: - bq. WALEdit preWALAppend(WALKey, WALEditSuperInterfaceWithoutAddMethods edit) :-) I don't think immutable WALedits buy us anything, but I was not the one who did the refactor of the WAL interface so don't have the context. [~busbey] might you point us in the right direction? In my opinion we decorate WALedits with special cells, the compaction marker etc., and a coprocessor may want to do this too. Although it does not do so today I am thinking especially of Phoenix. We did consider special cells instead of WALkey attributes for HBASE-22622. Turns out special cells wouldn't work there but, now that we are adding a hook where a coprocessor can get control to decorate the key, we should include coverage for decorating/mutating the edit as well, or I fear this will be a miss later when someone needs it. was (Author: apurtell): bq. WALEdit preWALAppend(WALKey, WALEditSuperInterfaceWithoutAddMethods edit) :-) I don't think immutable WALedits buy us anything, but I was not the one who did the refactor of the WAL interface so don't have the context. [~busbey] might you point us in the right direction? In my opinion we decorate WALedits with special cells, the compaction marker etc., and a coprocessor may want to do this too. Although it does not do so today I am thinking especially of Phoenix. We did consider special cells instead of WALkey attributes for HBASE-22622. Now that we are adding a hook where a coprocessor can get control to decorate the key, we should include coverage for decorating/mutating the edit as well, or I fear this will be a miss later when someone needs it. > Add RegionObserver coprocessor hook for preWALAppend > > > Key: HBASE-22623 > URL: https://issues.apache.org/jira/browse/HBASE-22623 > Project: HBase > Issue Type: New Feature >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Fix For: 3.0.0, 1.5.0, 2.3.0 > > > While many coprocessor hooks expose the WALEdit to implementing coprocs, > there aren't any that expose the WALKey before it's created and added to the > WALEntry. > It's sometimes useful for coprocessors to be able to edit the WALKey, for > example to add extended attributes using the fields to be added in > HBASE-22622. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900506#comment-16900506 ] Andrew Purtell commented on HBASE-22623: bq. WALEdit preWALAppend(WALKey, WALEditSuperInterfaceWithoutAddMethods edit) :-) I don't think immutable WALedits buy us anything, but I was not the one who did the refactor of the WAL interface so don't have the context. [~busbey] might you point us in the right direction? In my opinion we decorate WALedits with special cells, the compaction marker etc., and a coprocessor may want to do this too. Although it does not do so today I am thinking especially of Phoenix. We did consider special cells instead of WALkey attributes for HBASE-22622. Now that we are adding a hook for decorating the key, we should include coverage for decorating/mutating the edit as well, or I fear this will be a miss later when someone needs it. > Add RegionObserver coprocessor hook for preWALAppend > > > Key: HBASE-22623 > URL: https://issues.apache.org/jira/browse/HBASE-22623 > Project: HBase > Issue Type: New Feature >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Fix For: 3.0.0, 1.5.0, 2.3.0 > > > While many coprocessor hooks expose the WALEdit to implementing coprocs, > there aren't any that expose the WALKey before it's created and added to the > WALEntry. > It's sometimes useful for coprocessors to be able to edit the WALKey, for > example to add extended attributes using the fields to be added in > HBASE-22622. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Comment Edited] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900506#comment-16900506 ] Andrew Purtell edited comment on HBASE-22623 at 8/6/19 12:57 AM: - bq. WALEdit preWALAppend(WALKey, WALEditSuperInterfaceWithoutAddMethods edit) :-) I don't think immutable WALedits buy us anything, but I was not the one who did the refactor of the WAL interface so don't have the context. [~busbey] might you point us in the right direction? In my opinion we decorate WALedits with special cells, the compaction marker etc., and a coprocessor may want to do this too. Although it does not do so today I am thinking especially of Phoenix. We did consider special cells instead of WALkey attributes for HBASE-22622. Now that we are adding a hook where a coprocessor can get control to decorate the key, we should include coverage for decorating/mutating the edit as well, or I fear this will be a miss later when someone needs it. was (Author: apurtell): bq. WALEdit preWALAppend(WALKey, WALEditSuperInterfaceWithoutAddMethods edit) :-) I don't think immutable WALedits buy us anything, but I was not the one who did the refactor of the WAL interface so don't have the context. [~busbey] might you point us in the right direction? In my opinion we decorate WALedits with special cells, the compaction marker etc., and a coprocessor may want to do this too. Although it does not do so today I am thinking especially of Phoenix. We did consider special cells instead of WALkey attributes for HBASE-22622. Now that we are adding a hook for decorating the key, we should include coverage for decorating/mutating the edit as well, or I fear this will be a miss later when someone needs it. > Add RegionObserver coprocessor hook for preWALAppend > > > Key: HBASE-22623 > URL: https://issues.apache.org/jira/browse/HBASE-22623 > Project: HBase > Issue Type: New Feature >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Fix For: 3.0.0, 1.5.0, 2.3.0 > > > While many coprocessor hooks expose the WALEdit to implementing coprocs, > there aren't any that expose the WALKey before it's created and added to the > WALEntry. > It's sometimes useful for coprocessors to be able to edit the WALKey, for > example to add extended attributes using the fields to be added in > HBASE-22622. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22791) Wrong order of asserts in TestZKMulti
[
https://issues.apache.org/jira/browse/HBASE-22791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900500#comment-16900500
]
Hudson commented on HBASE-22791:
Results for branch branch-2
[build #2145 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2145/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2145//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2145//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2145//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Wrong order of asserts in TestZKMulti
> -
>
> Key: HBASE-22791
> URL: https://issues.apache.org/jira/browse/HBASE-22791
> Project: HBase
> Issue Type: Improvement
> Components: Zookeeper
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Fix For: 3.0.0, 2.3.0
>
>
> {{TestZKMulti}} contains a few asserts, where expected and actual values are
> in the wrong order.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22786) Fix Checkstyle issues in tests of hbase-client
[
https://issues.apache.org/jira/browse/HBASE-22786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900501#comment-16900501
]
Hudson commented on HBASE-22786:
Results for branch branch-2
[build #2145 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2145/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2145//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2145//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2145//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Fix Checkstyle issues in tests of hbase-client
> --
>
> Key: HBASE-22786
> URL: https://issues.apache.org/jira/browse/HBASE-22786
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
> The {{hbase-client}} module has some Checkstyle issues in its tests, which
> should get fixed.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22790) Add deprecation version for hbase.ipc.server.reservoir.initial.buffer.size & hbase.ipc.server.reservoir.initial.max
[
https://issues.apache.org/jira/browse/HBASE-22790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900498#comment-16900498
]
Hudson commented on HBASE-22790:
Results for branch branch-2
[build #2145 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2145/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2145//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2145//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2145//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add deprecation version for hbase.ipc.server.reservoir.initial.buffer.size &
> hbase.ipc.server.reservoir.initial.max
> ---
>
> Key: HBASE-22790
> URL: https://issues.apache.org/jira/browse/HBASE-22790
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Fix For: 3.0.0, 2.3.0
>
>
> During the deprecation in HBASE-22598 the deprecation version was not added
> in the documentation. It should be added as a reminder in what version it can
> be removed.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22785) Reduce number of Checkstyle issues in client exceptions
[
https://issues.apache.org/jira/browse/HBASE-22785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900503#comment-16900503
]
Hudson commented on HBASE-22785:
Results for branch branch-2
[build #2145 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2145/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2145//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2145//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2145//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Reduce number of Checkstyle issues in client exceptions
> ---
>
> Key: HBASE-22785
> URL: https://issues.apache.org/jira/browse/HBASE-22785
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
> The exceptions in the client module have some Checkstyle issues. Also, the
> Javadocs should be extended and enhanced.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22539) WAL corruption due to early DBBs re-use when Durability.ASYNC_WAL is used
[
https://issues.apache.org/jira/browse/HBASE-22539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900499#comment-16900499
]
Hudson commented on HBASE-22539:
Results for branch branch-2
[build #2145 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2145/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2145//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2145//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2145//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> WAL corruption due to early DBBs re-use when Durability.ASYNC_WAL is used
> -
>
> Key: HBASE-22539
> URL: https://issues.apache.org/jira/browse/HBASE-22539
> Project: HBase
> Issue Type: Bug
> Components: rpc, wal
>Affects Versions: 2.2.0, 2.0.5, 2.1.5
>Reporter: Wellington Chevreuil
>Assignee: Duo Zhang
>Priority: Blocker
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22539-UT.patch, HBASE-22539.branch-2.001.patch
>
>
> Summary
> We had been chasing a WAL corruption issue reported on one of our customers
> deployments running release 2.1.1 (CDH 6.1.0). After providing a custom
> modified jar with the extra sanity checks implemented by HBASE-21401 applied
> on some code points, plus additional debugging messages, we believe it is
> related to DirectByteBuffer usage, and Unsafe copy from offheap memory to
> on-heap array triggered
> [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java#L1157],
> such as when writing into a non ByteBufferWriter type, as done
> [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferWriterOutputStream.java#L84].
> More details on the following comment.
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22778) Upgrade jasckson databind to 2.9.9.2
[
https://issues.apache.org/jira/browse/HBASE-22778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900502#comment-16900502
]
Hudson commented on HBASE-22778:
Results for branch branch-2
[build #2145 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2145/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2145//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2145//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2145//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Upgrade jasckson databind to 2.9.9.2
>
>
> Key: HBASE-22778
> URL: https://issues.apache.org/jira/browse/HBASE-22778
> Project: HBase
> Issue Type: Bug
> Components: dependencies
>Reporter: Duo Zhang
>Assignee: niuyulin
>Priority: Blocker
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
>
> Due to this CVE
> https://nvd.nist.gov/vuln/detail/CVE-2019-14379
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #440: HBASE-22776 Rename config names in user scan snapshot feature
Apache-HBase commented on issue #440: HBASE-22776 Rename config names in user scan snapshot feature URL: https://github.com/apache/hbase/pull/440#issuecomment-518448918 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 64 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | -1 | mvninstall | 174 | root in master failed. | | +1 | compile | 68 | master passed | | +1 | checkstyle | 96 | master passed | | +1 | shadedjars | 359 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 41 | master passed | | 0 | spotbugs | 316 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 313 | master passed | ||| _ Patch Compile Tests _ | | -1 | mvninstall | 171 | root in the patch failed. | | +1 | compile | 70 | the patch passed | | +1 | javac | 70 | the patch passed | | -1 | checkstyle | 89 | hbase-server: The patch generated 1 new + 15 unchanged - 0 fixed = 16 total (was 15) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 353 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 121 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 238 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 358 | The patch causes 10 errors with Hadoop v3.1.2. | | +1 | javadoc | 42 | the patch passed | | +1 | findbugs | 333 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 15984 | hbase-server in the patch failed. | | +1 | asflicense | 59 | The patch does not generate ASF License warnings. | | | | 18650 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestAsyncRegionAdminApi2 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-440/15/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/440 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux ef1b1abc5974 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-440/out/precommit/personality/provided.sh | | git revision | master / ad3674f337 | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-440/15/artifact/out/branch-mvninstall-root.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-440/15/artifact/out/patch-mvninstall-root.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-440/15/artifact/out/diff-checkstyle-hbase-server.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-440/15/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-440/15/artifact/out/patch-javac-2.9.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-440/15/artifact/out/patch-javac-3.1.2.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-440/15/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-440/15/testReport/ | | Max. process+thread count | 4852 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-440/15/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment
Apache-HBase commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment URL: https://github.com/apache/hbase/pull/439#issuecomment-518447686 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 93 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 425 | master passed | | +1 | compile | 69 | master passed | | +1 | checkstyle | 97 | master passed | | +1 | shadedjars | 317 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 38 | master passed | | 0 | spotbugs | 271 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 269 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 349 | the patch passed | | +1 | compile | 64 | the patch passed | | +1 | javac | 64 | the patch passed | | -1 | checkstyle | 90 | hbase-server: The patch generated 1 new + 64 unchanged - 0 fixed = 65 total (was 64) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 298 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1031 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 38 | the patch passed | | +1 | findbugs | 263 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 14270 | hbase-server in the patch passed. | | +1 | asflicense | 52 | The patch does not generate ASF License warnings. | | | | 18185 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/18/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/439 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux b85d00234196 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-439/out/precommit/personality/provided.sh | | git revision | master / ad3674f337 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/18/artifact/out/diff-checkstyle-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/18/testReport/ | | Max. process+thread count | 4658 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/18/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22771) [HBCK2] fixMeta method and server-side support
[
https://issues.apache.org/jira/browse/HBASE-22771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900489#comment-16900489
]
HBase QA commented on HBASE-22771:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
52s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
0s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 9m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
25s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
22s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 2m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
31s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
36s{color} | {color:red} hbase-server: The patch generated 3 new + 271
unchanged - 0 fixed = 274 total (was 271) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
1s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
23m 7s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
2m 14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 9m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
45s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
49s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}244m 29s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}344m 19s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.0 Server=19.03.0 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/718/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22771 |
| JIRA Patch URL |
[jira] [Commented] (HBASE-22785) Reduce number of Checkstyle issues in client exceptions
[
https://issues.apache.org/jira/browse/HBASE-22785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900485#comment-16900485
]
Hudson commented on HBASE-22785:
Results for branch branch-1
[build #994 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/994/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/994//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/994//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/994//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Reduce number of Checkstyle issues in client exceptions
> ---
>
> Key: HBASE-22785
> URL: https://issues.apache.org/jira/browse/HBASE-22785
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
> The exceptions in the client module have some Checkstyle issues. Also, the
> Javadocs should be extended and enhanced.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22786) Fix Checkstyle issues in tests of hbase-client
[
https://issues.apache.org/jira/browse/HBASE-22786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900484#comment-16900484
]
Hudson commented on HBASE-22786:
Results for branch branch-1
[build #994 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/994/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/994//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/994//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/994//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Fix Checkstyle issues in tests of hbase-client
> --
>
> Key: HBASE-22786
> URL: https://issues.apache.org/jira/browse/HBASE-22786
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
> The {{hbase-client}} module has some Checkstyle issues in its tests, which
> should get fixed.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22709) Add a chore thread in master to do hbck checking and display results in 'HBCK Report' page
[ https://issues.apache.org/jira/browse/HBASE-22709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900476#comment-16900476 ] Sakthi commented on HBASE-22709: Agree with that stack. > Add a chore thread in master to do hbck checking and display results in 'HBCK > Report' page > -- > > Key: HBASE-22709 > URL: https://issues.apache.org/jira/browse/HBASE-22709 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > Attachments: HBASE-22709.master.001.patch > > > See HBASE-21965. There may have two type of failed splited/merged regions. > One is orphan region on filesystem. Another one is unassigned daughter > regions or merged regions. Plan to add a seperate hbck.jsp for them. Will add > more hbck problems to this UI in future. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22785) Reduce number of Checkstyle issues in client exceptions
[
https://issues.apache.org/jira/browse/HBASE-22785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900473#comment-16900473
]
Hudson commented on HBASE-22785:
Results for branch branch-2.1
[build #1452 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1452/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1452//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1452//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1452//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Reduce number of Checkstyle issues in client exceptions
> ---
>
> Key: HBASE-22785
> URL: https://issues.apache.org/jira/browse/HBASE-22785
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
> The exceptions in the client module have some Checkstyle issues. Also, the
> Javadocs should be extended and enhanced.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22778) Upgrade jasckson databind to 2.9.9.2
[
https://issues.apache.org/jira/browse/HBASE-22778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900472#comment-16900472
]
Hudson commented on HBASE-22778:
Results for branch branch-2.1
[build #1452 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1452/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1452//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1452//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1452//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Upgrade jasckson databind to 2.9.9.2
>
>
> Key: HBASE-22778
> URL: https://issues.apache.org/jira/browse/HBASE-22778
> Project: HBase
> Issue Type: Bug
> Components: dependencies
>Reporter: Duo Zhang
>Assignee: niuyulin
>Priority: Blocker
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
>
> Due to this CVE
> https://nvd.nist.gov/vuln/detail/CVE-2019-14379
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22778) Upgrade jasckson databind to 2.9.9.2
[
https://issues.apache.org/jira/browse/HBASE-22778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900468#comment-16900468
]
Hudson commented on HBASE-22778:
Results for branch branch-2.0
[build #1831 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1831/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1831//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1831//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1831//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Upgrade jasckson databind to 2.9.9.2
>
>
> Key: HBASE-22778
> URL: https://issues.apache.org/jira/browse/HBASE-22778
> Project: HBase
> Issue Type: Bug
> Components: dependencies
>Reporter: Duo Zhang
>Assignee: niuyulin
>Priority: Blocker
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
>
> Due to this CVE
> https://nvd.nist.gov/vuln/detail/CVE-2019-14379
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22785) Reduce number of Checkstyle issues in client exceptions
[
https://issues.apache.org/jira/browse/HBASE-22785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900469#comment-16900469
]
Hudson commented on HBASE-22785:
Results for branch branch-2.0
[build #1831 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1831/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1831//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1831//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1831//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Reduce number of Checkstyle issues in client exceptions
> ---
>
> Key: HBASE-22785
> URL: https://issues.apache.org/jira/browse/HBASE-22785
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
> The exceptions in the client module have some Checkstyle issues. Also, the
> Javadocs should be extended and enhanced.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #455: HBASE-22783 : shell with removal of status and load classes
Apache-HBase commented on issue #455: HBASE-22783 : shell with removal of status and load classes URL: https://github.com/apache/hbase/pull/455#issuecomment-518431299 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 40 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for branch | | +1 | mvninstall | 306 | master passed | | +1 | javadoc | 172 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 12 | Maven dependency ordering for patch | | +1 | mvninstall | 288 | the patch passed | | -1 | rubocop | 21 | The patch generated 11 new + 374 unchanged - 14 fixed = 385 total (was 388) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | javadoc | 181 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 12170 | root in the patch passed. | | +1 | asflicense | 61 | The patch does not generate ASF License warnings. | | | | 13347 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-455/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/455 | | Optional Tests | dupname asflicense rubocop javac javadoc unit | | uname | Linux d2d8d13cb59b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-455/out/precommit/personality/provided.sh | | git revision | master / ad3674f337 | | Default Java | 1.8.0_181 | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-455/3/artifact/out/diff-patch-rubocop.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-455/3/testReport/ | | Max. process+thread count | 4982 (vs. ulimit of 1) | | modules | C: hbase-shell . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-455/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.74.0 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve…
Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve… URL: https://github.com/apache/hbase/pull/435#issuecomment-518431294 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 40 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | 0 | shelldocs | 0 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for branch | | +1 | mvninstall | 302 | master passed | | +1 | compile | 101 | master passed | | +1 | checkstyle | 114 | master passed | | +1 | shadedjars | 281 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 71 | master passed | | 0 | spotbugs | 47 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 339 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 13 | Maven dependency ordering for patch | | +1 | mvninstall | 303 | the patch passed | | +1 | compile | 101 | the patch passed | | +1 | javac | 101 | the patch passed | | -1 | checkstyle | 72 | hbase-server: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9) | | +1 | shellcheck | 1 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 274 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 942 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 82 | the patch passed | | -1 | findbugs | 62 | hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 182 | hbase-common in the patch passed. | | -1 | unit | 8645 | hbase-server in the patch failed. | | +1 | unit | 227 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 88 | The patch does not generate ASF License warnings. | | | | 13049 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-common | | | org.apache.hadoop.hbase.Version.() invokes inefficient new String(String) constructor At Version.java:inefficient new String(String) constructor At Version.java:[line 10] | | Failed junit tests | hadoop.hbase.replication.TestReplicationSmallTests | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/16/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/435 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux aa553c76b6d8 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-435/out/precommit/personality/provided.sh | | git revision | master / ad3674f337 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/16/artifact/out/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/16/artifact/out/new-findbugs-hbase-common.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/16/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/16/testReport/ | | Max. process+thread count | 4559 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server hbase-rsgroup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/16/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22785) Reduce number of Checkstyle issues in client exceptions
[
https://issues.apache.org/jira/browse/HBASE-22785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900457#comment-16900457
]
Hudson commented on HBASE-22785:
Results for branch master
[build #1312 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1312/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1312//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1312//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1312//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Reduce number of Checkstyle issues in client exceptions
> ---
>
> Key: HBASE-22785
> URL: https://issues.apache.org/jira/browse/HBASE-22785
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
> The exceptions in the client module have some Checkstyle issues. Also, the
> Javadocs should be extended and enhanced.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22789) Remove deprecated method from ImmutableBytesWritable
[
https://issues.apache.org/jira/browse/HBASE-22789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900458#comment-16900458
]
Hudson commented on HBASE-22789:
Results for branch master
[build #1312 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1312/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1312//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1312//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1312//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove deprecated method from ImmutableBytesWritable
>
>
> Key: HBASE-22789
> URL: https://issues.apache.org/jira/browse/HBASE-22789
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Fix For: 3.0.0
>
>
> {{ImmutableBytesWritable}} contains a deprecated method, which should be
> removed.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22791) Wrong order of asserts in TestZKMulti
[
https://issues.apache.org/jira/browse/HBASE-22791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900454#comment-16900454
]
Hudson commented on HBASE-22791:
Results for branch master
[build #1312 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1312/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1312//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1312//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1312//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Wrong order of asserts in TestZKMulti
> -
>
> Key: HBASE-22791
> URL: https://issues.apache.org/jira/browse/HBASE-22791
> Project: HBase
> Issue Type: Improvement
> Components: Zookeeper
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Fix For: 3.0.0, 2.3.0
>
>
> {{TestZKMulti}} contains a few asserts, where expected and actual values are
> in the wrong order.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22788) Remove deprecated methods from Bytes
[
https://issues.apache.org/jira/browse/HBASE-22788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900453#comment-16900453
]
Hudson commented on HBASE-22788:
Results for branch master
[build #1312 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1312/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1312//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1312//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1312//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove deprecated methods from Bytes
>
>
> Key: HBASE-22788
> URL: https://issues.apache.org/jira/browse/HBASE-22788
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Fix For: 3.0.0
>
>
> The {{Bytes}} class contains some deprecated methods, which can be removed
> for 3.0.0.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22778) Upgrade jasckson databind to 2.9.9.2
[
https://issues.apache.org/jira/browse/HBASE-22778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900456#comment-16900456
]
Hudson commented on HBASE-22778:
Results for branch master
[build #1312 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1312/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1312//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1312//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1312//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Upgrade jasckson databind to 2.9.9.2
>
>
> Key: HBASE-22778
> URL: https://issues.apache.org/jira/browse/HBASE-22778
> Project: HBase
> Issue Type: Bug
> Components: dependencies
>Reporter: Duo Zhang
>Assignee: niuyulin
>Priority: Blocker
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
>
> Due to this CVE
> https://nvd.nist.gov/vuln/detail/CVE-2019-14379
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22786) Fix Checkstyle issues in tests of hbase-client
[
https://issues.apache.org/jira/browse/HBASE-22786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900455#comment-16900455
]
Hudson commented on HBASE-22786:
Results for branch master
[build #1312 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1312/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1312//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1312//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1312//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Fix Checkstyle issues in tests of hbase-client
> --
>
> Key: HBASE-22786
> URL: https://issues.apache.org/jira/browse/HBASE-22786
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
> The {{hbase-client}} module has some Checkstyle issues in its tests, which
> should get fixed.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900452#comment-16900452 ] Andrew Purtell commented on HBASE-22728: bq. if we're going to make downstream deal with removing jackson 1 from the classpath then we should try to just have no exposed jackson for downstream at the end of the day. This is my feedback as well. I also think we should backport hbase-rest for HBase 2 from hbase-connectors back to branch-1 so we don't have something using a vulnerable version of Jackson in branch-1, and do not expose Jackson from this module either. > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22728.branch-1.01.patch, > HBASE-22728.branch-1.02.patch, HBASE-22728.branch-1.04.patch, > HBASE-22728.branch-1.06.patch, dependency_codehaus.out > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22539) WAL corruption due to early DBBs re-use when Durability.ASYNC_WAL is used
[
https://issues.apache.org/jira/browse/HBASE-22539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900448#comment-16900448
]
Hudson commented on HBASE-22539:
Results for branch branch-2.2
[build #493 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/493/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/493//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/493//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/493//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> WAL corruption due to early DBBs re-use when Durability.ASYNC_WAL is used
> -
>
> Key: HBASE-22539
> URL: https://issues.apache.org/jira/browse/HBASE-22539
> Project: HBase
> Issue Type: Bug
> Components: rpc, wal
>Affects Versions: 2.2.0, 2.0.5, 2.1.5
>Reporter: Wellington Chevreuil
>Assignee: Duo Zhang
>Priority: Blocker
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22539-UT.patch, HBASE-22539.branch-2.001.patch
>
>
> Summary
> We had been chasing a WAL corruption issue reported on one of our customers
> deployments running release 2.1.1 (CDH 6.1.0). After providing a custom
> modified jar with the extra sanity checks implemented by HBASE-21401 applied
> on some code points, plus additional debugging messages, we believe it is
> related to DirectByteBuffer usage, and Unsafe copy from offheap memory to
> on-heap array triggered
> [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java#L1157],
> such as when writing into a non ByteBufferWriter type, as done
> [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferWriterOutputStream.java#L84].
> More details on the following comment.
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22741) Show catalogjanitor consistency complaints in new 'HBCK Report' page
[
https://issues.apache.org/jira/browse/HBASE-22741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900447#comment-16900447
]
Hudson commented on HBASE-22741:
Results for branch branch-2.2
[build #493 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/493/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/493//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/493//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/493//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Show catalogjanitor consistency complaints in new 'HBCK Report' page
>
>
> Key: HBASE-22741
> URL: https://issues.apache.org/jira/browse/HBASE-22741
> Project: HBase
> Issue Type: Sub-task
> Components: hbck2, UI
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments:
> 0001-HBASE-22741-Show-catalogjanitor-consistency-complain.patch,
> HBASE-22741.master.001.patch, HBASE-22741.master.002.patch, Screen Shot
> 2019-07-25 at 11.12.40 PM.png, Screen Shot 2019-07-30 at 11.29.09 AM.png
>
>
> HBASE-22723 makes it so catalogjanitor looks for holes and overlaps when it
> scans hbase:meta. HBASE-22709 added a new HBCK Report page to the master in
> which it notes findings its figured looking at regionserver reports and
> current state of Master.
> This issue is about exposing the inconsistencies found scanning hbase:meta in
> the HBCK Report page.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22786) Fix Checkstyle issues in tests of hbase-client
[
https://issues.apache.org/jira/browse/HBASE-22786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900449#comment-16900449
]
Hudson commented on HBASE-22786:
Results for branch branch-2.2
[build #493 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/493/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/493//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/493//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/493//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Fix Checkstyle issues in tests of hbase-client
> --
>
> Key: HBASE-22786
> URL: https://issues.apache.org/jira/browse/HBASE-22786
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
> The {{hbase-client}} module has some Checkstyle issues in its tests, which
> should get fixed.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22778) Upgrade jasckson databind to 2.9.9.2
[
https://issues.apache.org/jira/browse/HBASE-22778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900450#comment-16900450
]
Hudson commented on HBASE-22778:
Results for branch branch-2.2
[build #493 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/493/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/493//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/493//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/493//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Upgrade jasckson databind to 2.9.9.2
>
>
> Key: HBASE-22778
> URL: https://issues.apache.org/jira/browse/HBASE-22778
> Project: HBase
> Issue Type: Bug
> Components: dependencies
>Reporter: Duo Zhang
>Assignee: niuyulin
>Priority: Blocker
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
>
> Due to this CVE
> https://nvd.nist.gov/vuln/detail/CVE-2019-14379
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22785) Reduce number of Checkstyle issues in client exceptions
[
https://issues.apache.org/jira/browse/HBASE-22785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900451#comment-16900451
]
Hudson commented on HBASE-22785:
Results for branch branch-2.2
[build #493 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/493/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/493//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/493//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/493//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Reduce number of Checkstyle issues in client exceptions
> ---
>
> Key: HBASE-22785
> URL: https://issues.apache.org/jira/browse/HBASE-22785
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
> The exceptions in the client module have some Checkstyle issues. Also, the
> Javadocs should be extended and enhanced.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22709) Add a chore thread in master to do hbck checking and display results in 'HBCK Report' page
[ https://issues.apache.org/jira/browse/HBASE-22709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900446#comment-16900446 ] stack commented on HBASE-22709: --- Should we allow turning it off? Could change config and rolling restart if an issue. I'm thinking that adding on/off of this Chore in the shell -- while it matches an ability we expose for a few chores -- is TMI for operators? > Add a chore thread in master to do hbck checking and display results in 'HBCK > Report' page > -- > > Key: HBASE-22709 > URL: https://issues.apache.org/jira/browse/HBASE-22709 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > Attachments: HBASE-22709.master.001.patch > > > See HBASE-21965. There may have two type of failed splited/merged regions. > One is orphan region on filesystem. Another one is unassigned daughter > regions or merged regions. Plan to add a seperate hbck.jsp for them. Will add > more hbck problems to this UI in future. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes…
Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes… URL: https://github.com/apache/hbase/pull/446#issuecomment-518426556 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 33 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 327 | master passed | | +1 | compile | 56 | master passed | | +1 | checkstyle | 87 | master passed | | +1 | shadedjars | 293 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 33 | master passed | | 0 | spotbugs | 254 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 251 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 319 | the patch passed | | +1 | compile | 56 | the patch passed | | +1 | javac | 56 | the patch passed | | +1 | checkstyle | 84 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 293 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 988 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 33 | the patch passed | | +1 | findbugs | 265 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 8521 | hbase-server in the patch passed. | | +1 | asflicense | 25 | The patch does not generate ASF License warnings. | | | | 12055 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/14/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/446 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 2a06d7be6047 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-446/out/precommit/personality/provided.sh | | git revision | master / ad3674f337 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/14/testReport/ | | Max. process+thread count | 4770 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/14/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22786) Fix Checkstyle issues in tests of hbase-client
[
https://issues.apache.org/jira/browse/HBASE-22786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900439#comment-16900439
]
Hudson commented on HBASE-22786:
Results for branch branch-1.3
[build #904 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/904/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/904//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/904//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/904//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Fix Checkstyle issues in tests of hbase-client
> --
>
> Key: HBASE-22786
> URL: https://issues.apache.org/jira/browse/HBASE-22786
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
> The {{hbase-client}} module has some Checkstyle issues in its tests, which
> should get fixed.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22785) Reduce number of Checkstyle issues in client exceptions
[
https://issues.apache.org/jira/browse/HBASE-22785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900440#comment-16900440
]
Hudson commented on HBASE-22785:
Results for branch branch-1.3
[build #904 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/904/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/904//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/904//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/904//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Reduce number of Checkstyle issues in client exceptions
> ---
>
> Key: HBASE-22785
> URL: https://issues.apache.org/jira/browse/HBASE-22785
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
> The exceptions in the client module have some Checkstyle issues. Also, the
> Javadocs should be extended and enhanced.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22777: -- Attachment: HBASE-22777.master.002.patch > Add a multi-region merge (for fixing overlaps, etc.) > > > Key: HBASE-22777 > URL: https://issues.apache.org/jira/browse/HBASE-22777 > Project: HBase > Issue Type: Sub-task > Components: hbck2, proc-v2 >Reporter: stack >Assignee: stack >Priority: Major > Attachments: HBASE-22777.master.001.patch, > HBASE-22777.master.002.patch > > > MergeTableRegionProcedure does two regions at a time only. We have hardcoded > notion that merge has an 'A' and 'B' parent. > This issue is about making it so we merge N regions all in the one go. We > need this facility generally; will simplify operator's life being able to > merge up in one go rather than in steps of two. In particular, would make > fixing overlaps easier if could just merge all regions in the overlapping > area. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900436#comment-16900436 ] stack commented on HBASE-22777: --- .002 address reviews and fix tests. > Add a multi-region merge (for fixing overlaps, etc.) > > > Key: HBASE-22777 > URL: https://issues.apache.org/jira/browse/HBASE-22777 > Project: HBase > Issue Type: Sub-task > Components: hbck2, proc-v2 >Reporter: stack >Assignee: stack >Priority: Major > Attachments: HBASE-22777.master.001.patch, > HBASE-22777.master.002.patch > > > MergeTableRegionProcedure does two regions at a time only. We have hardcoded > notion that merge has an 'A' and 'B' parent. > This issue is about making it so we merge N regions all in the one go. We > need this facility generally; will simplify operator's life being able to > merge up in one go rather than in steps of two. In particular, would make > fixing overlaps easier if could just merge all regions in the overlapping > area. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #455: HBASE-22783 : shell with removal of status and load classes
Apache-HBase commented on issue #455: HBASE-22783 : shell with removal of status and load classes URL: https://github.com/apache/hbase/pull/455#issuecomment-518416547 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 97 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for branch | | +1 | mvninstall | 333 | master passed | | +1 | javadoc | 196 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 12 | Maven dependency ordering for patch | | +1 | mvninstall | 333 | the patch passed | | -1 | rubocop | 23 | The patch generated 11 new + 373 unchanged - 14 fixed = 384 total (was 387) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | javadoc | 220 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 19808 | root in the patch passed. | | +1 | asflicense | 58 | The patch does not generate ASF License warnings. | | | | 21185 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-455/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/455 | | Optional Tests | dupname asflicense rubocop javac javadoc unit | | uname | Linux b476cc37fa1f 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-455/out/precommit/personality/provided.sh | | git revision | master / 3f524abdeb | | Default Java | 1.8.0_181 | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-455/2/artifact/out/diff-patch-rubocop.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-455/2/testReport/ | | Max. process+thread count | 4842 (vs. ulimit of 1) | | modules | C: hbase-shell . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-455/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.73.0 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #438: HBASE-11062 hbtop
Apache-HBase commented on issue #438: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/438#issuecomment-518412060 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 92 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | 0 | shelldocs | 1 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 19 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 22 | Maven dependency ordering for branch | | -1 | mvninstall | 84 | root in master failed. | | +1 | compile | 175 | master passed | | +1 | checkstyle | 150 | master passed | | +1 | shadedjars | 287 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 189 | master passed | | 0 | spotbugs | 912 | Used deprecated FindBugs config; considering switching to SpotBugs. | | 0 | findbugs | 27 | branch/hbase-assembly no findbugs output file (findbugsXml.xml) | ||| _ Patch Compile Tests _ | | 0 | mvndep | 13 | Maven dependency ordering for patch | | -1 | mvninstall | 78 | root in the patch failed. | | -1 | compile | 165 | root in the patch failed. | | -1 | javac | 165 | root in the patch failed. | | -1 | checkstyle | 141 | The patch fails to run checkstyle in root | | +1 | shellcheck | 0 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 4 | The patch has no ill-formed XML file. | | +1 | shadedjars | 277 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 57 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 113 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 171 | The patch causes 10 errors with Hadoop v3.1.2. | | -1 | javadoc | 161 | root in the patch failed. | | -1 | javadoc | 11 | hbase-assembly in the patch failed. | | -1 | findbugs | 845 | root in the patch failed. | | -1 | findbugs | 11 | hbase-assembly in the patch failed. | ||| _ Other Tests _ | | -1 | unit | 16240 | root in the patch failed. | | -1 | asflicense | 73 | The patch generated 2 ASF License warnings. | | | | 20266 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestAsyncRegionAdminApi2 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/15/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/438 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle | | uname | Linux f28a3a141f29 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-438@2/out/precommit/personality/provided.sh | | git revision | master / 3f524abdeb | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/15/artifact/out/branch-mvninstall-root.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/15/artifact/out/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/15/artifact/out/patch-compile-root.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/15/artifact/out/patch-compile-root.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/15/artifact/out//home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-438@2/out/maven-patch-checkstyle-root.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/15/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/15/artifact/out/patch-javac-2.9.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/15/artifact/out/patch-javac-3.1.2.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/15/artifact/out/patch-javadoc-root.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/15/artifact/out/patch-javadoc-hbase-assembly.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/15/artifact/out/patch-findbugs-root.txt | | findbugs |
[GitHub] [hbase] Apache-HBase commented on issue #438: HBASE-11062 hbtop
Apache-HBase commented on issue #438: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/438#issuecomment-518404102 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 168 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | 0 | shelldocs | 3 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 19 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 21 | Maven dependency ordering for branch | | +1 | mvninstall | 439 | master passed | | +1 | compile | 246 | master passed | | +1 | checkstyle | 210 | master passed | | +1 | shadedjars | 394 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 232 | master passed | | 0 | spotbugs | 1169 | Used deprecated FindBugs config; considering switching to SpotBugs. | | 0 | findbugs | 33 | branch/hbase-assembly no findbugs output file (findbugsXml.xml) | ||| _ Patch Compile Tests _ | | 0 | mvndep | 20 | Maven dependency ordering for patch | | +1 | mvninstall | 421 | the patch passed | | -1 | compile | 235 | root in the patch failed. | | -1 | javac | 235 | root in the patch failed. | | +1 | checkstyle | 190 | the patch passed | | +1 | shellcheck | 3 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 6 | The patch has no ill-formed XML file. | | +1 | shadedjars | 354 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1272 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 233 | the patch passed | | -1 | findbugs | 1092 | root in the patch failed. | | 0 | findbugs | 37 | hbase-assembly has no data from findbugs | ||| _ Other Tests _ | | -1 | unit | 17493 | root in the patch failed. | | -1 | asflicense | 90 | The patch generated 2 ASF License warnings. | | | | 24928 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestSnapshotCloneIndependence | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/14/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/438 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle | | uname | Linux b7ccc88127e6 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-438/out/precommit/personality/provided.sh | | git revision | master / da114ac727 | | Default Java | 1.8.0_181 | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/14/artifact/out/patch-compile-root.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/14/artifact/out/patch-compile-root.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/14/artifact/out/patch-findbugs-root.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/14/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/14/testReport/ | | asflicense | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/14/artifact/out/patch-asflicense-problems.txt | | Max. process+thread count | 4610 (vs. ulimit of 1) | | modules | C: hbase-hbtop . hbase-assembly U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/14/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #428: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (master)
Apache-HBase commented on issue #428: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (master) URL: https://github.com/apache/hbase/pull/428#issuecomment-518402056 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 96 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 328 | master passed | | +1 | compile | 60 | master passed | | +1 | checkstyle | 93 | master passed | | +1 | shadedjars | 303 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 36 | master passed | | 0 | spotbugs | 278 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 276 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 333 | the patch passed | | +1 | compile | 61 | the patch passed | | +1 | javac | 61 | the patch passed | | +1 | checkstyle | 89 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 306 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1029 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 37 | the patch passed | | +1 | findbugs | 280 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 14638 | hbase-server in the patch passed. | | +1 | asflicense | 33 | The patch does not generate ASF License warnings. | | | | 18406 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/31/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/428 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 6c291d197925 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh | | git revision | master / 3f524abdeb | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/31/testReport/ | | Max. process+thread count | 4776 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/31/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22731) ReplicationSource and HBaseInterClusterReplicationEndpoint log messages should include a target Peer identifier
[
https://issues.apache.org/jira/browse/HBASE-22731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900406#comment-16900406
]
HBase QA commented on HBASE-22731:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
5s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
49s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
6s{color} | {color:red} hbase-server: The patch generated 2 new + 0 unchanged -
0 fixed = 2 total (was 0) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
33s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
16m 42s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}282m 21s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
26s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}339m 29s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.replication.TestReplicationDisableInactivePeer |
| | hadoop.hbase.master.procedure.TestProcedurePriority |
| | hadoop.hbase.client.TestCloneSnapshotFromClientNormal |
| | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory |
| | hadoop.hbase.master.TestMasterOperationsForRegionReplicas |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/715/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22731 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12976718/HBASE-22731.master.004.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 0119df841d3c 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24
13:14:43 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / da114ac727 |
| maven | version: Apache
[jira] [Commented] (HBASE-22786) Fix Checkstyle issues in tests of hbase-client
[
https://issues.apache.org/jira/browse/HBASE-22786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900401#comment-16900401
]
Hudson commented on HBASE-22786:
Results for branch branch-1.4
[build #943 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/943/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/943//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/943//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/943//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Fix Checkstyle issues in tests of hbase-client
> --
>
> Key: HBASE-22786
> URL: https://issues.apache.org/jira/browse/HBASE-22786
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
> The {{hbase-client}} module has some Checkstyle issues in its tests, which
> should get fixed.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22785) Reduce number of Checkstyle issues in client exceptions
[
https://issues.apache.org/jira/browse/HBASE-22785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900402#comment-16900402
]
Hudson commented on HBASE-22785:
Results for branch branch-1.4
[build #943 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/943/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/943//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/943//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/943//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Reduce number of Checkstyle issues in client exceptions
> ---
>
> Key: HBASE-22785
> URL: https://issues.apache.org/jira/browse/HBASE-22785
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
> The exceptions in the client module have some Checkstyle issues. Also, the
> Javadocs should be extended and enhanced.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-518380665 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 39 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 308 | master passed | | +1 | compile | 25 | master passed | | +1 | checkstyle | 11 | master passed | | +1 | shadedjars | 277 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 18 | master passed | | 0 | spotbugs | 47 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 44 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 310 | the patch passed | | +1 | compile | 24 | the patch passed | | +1 | javac | 24 | the patch passed | | +1 | checkstyle | 10 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 267 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 922 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 20 | the patch passed | | +1 | findbugs | 50 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 227 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 12 | The patch does not generate ASF License warnings. | | | | 2922 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/60/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/387 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux f97fc9d147f0 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh | | git revision | master / ad3674f337 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/60/testReport/ | | Max. process+thread count | 4257 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/60/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #456: HBASE-22631 assign failed may make gced parent region appear again
Apache-HBase commented on issue #456: HBASE-22631 assign failed may make gced parent region appear again URL: https://github.com/apache/hbase/pull/456#issuecomment-518380419 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 166 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | +1 | mvninstall | 366 | branch-2.1 passed | | +1 | compile | 73 | branch-2.1 passed | | +1 | checkstyle | 100 | branch-2.1 passed | | +1 | shadedjars | 319 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 42 | branch-2.1 passed | | 0 | spotbugs | 224 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 221 | branch-2.1 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 398 | the patch passed | | +1 | compile | 70 | the patch passed | | +1 | javac | 70 | the patch passed | | +1 | checkstyle | 99 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 310 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1372 | Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2. | | +1 | javadoc | 33 | the patch passed | | +1 | findbugs | 179 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 11661 | hbase-server in the patch failed. | | +1 | asflicense | 24 | The patch does not generate ASF License warnings. | | | | 15862 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-456/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/456 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 0600a28ce47a 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-456/out/precommit/personality/provided.sh | | git revision | branch-2.1 / 946f5e6eb5 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-456/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-456/1/testReport/ | | Max. process+thread count | 4484 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-456/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend URL: https://github.com/apache/hbase/pull/390#issuecomment-518379287 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 95 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 442 | master passed | | +1 | compile | 70 | master passed | | +1 | checkstyle | 107 | master passed | | +1 | shadedjars | 395 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 44 | master passed | | 0 | spotbugs | 314 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 311 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 391 | the patch passed | | +1 | compile | 69 | the patch passed | | +1 | javac | 69 | the patch passed | | +1 | checkstyle | 98 | hbase-server: The patch generated 0 new + 376 unchanged - 1 fixed = 376 total (was 377) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 345 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1172 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 44 | the patch passed | | +1 | findbugs | 332 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 16020 | hbase-server in the patch passed. | | +1 | asflicense | 28 | The patch does not generate ASF License warnings. | | | | 20436 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/37/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/390 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 852bc2546e3a 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-390/out/precommit/personality/provided.sh | | git revision | master / da114ac727 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/37/testReport/ | | Max. process+thread count | 4504 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/37/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #436: HBASE-22699 refactor isMetaClearingException
Apache-HBase commented on issue #436: HBASE-22699 refactor isMetaClearingException URL: https://github.com/apache/hbase/pull/436#issuecomment-518378820 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 37 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 287 | master passed | | +1 | compile | 24 | master passed | | +1 | checkstyle | 29 | master passed | | +1 | shadedjars | 262 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 20 | master passed | | 0 | spotbugs | 67 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 66 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 284 | the patch passed | | +1 | compile | 23 | the patch passed | | +1 | javac | 23 | the patch passed | | +1 | checkstyle | 28 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 264 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 926 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 20 | the patch passed | | +1 | findbugs | 78 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 100 | hbase-client in the patch passed. | | +1 | asflicense | 10 | The patch does not generate ASF License warnings. | | | | 2827 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/19/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/436 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux d91086f14085 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-436/out/precommit/personality/provided.sh | | git revision | master / ad3674f337 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/19/testReport/ | | Max. process+thread count | 293 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/19/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #440: HBASE-22776 Rename config names in user scan snapshot feature
Apache-HBase commented on issue #440: HBASE-22776 Rename config names in user scan snapshot feature URL: https://github.com/apache/hbase/pull/440#issuecomment-518378016 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 105 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 343 | master passed | | +1 | compile | 55 | master passed | | +1 | checkstyle | 74 | master passed | | +1 | shadedjars | 284 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 38 | master passed | | 0 | spotbugs | 261 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 258 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 356 | the patch passed | | +1 | compile | 59 | the patch passed | | +1 | javac | 59 | the patch passed | | -1 | checkstyle | 81 | hbase-server: The patch generated 1 new + 15 unchanged - 0 fixed = 16 total (was 15) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 305 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1047 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 34 | the patch passed | | +1 | findbugs | 270 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 16795 | hbase-server in the patch failed. | | +1 | asflicense | 37 | The patch does not generate ASF License warnings. | | | | 20536 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-440/13/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/440 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 8e2a337c705d 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-440/out/precommit/personality/provided.sh | | git revision | master / da114ac727 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-440/13/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-440/13/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-440/13/testReport/ | | Max. process+thread count | 4814 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-440/13/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve…
Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve… URL: https://github.com/apache/hbase/pull/435#issuecomment-518377303 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 75 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | 0 | shelldocs | 0 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for branch | | +1 | mvninstall | 318 | master passed | | +1 | compile | 109 | master passed | | +1 | checkstyle | 134 | master passed | | +1 | shadedjars | 309 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 90 | master passed | | 0 | spotbugs | 59 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 425 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 429 | the patch passed | | +1 | compile | 135 | the patch passed | | +1 | javac | 135 | the patch passed | | -1 | checkstyle | 96 | hbase-server: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9) | | +1 | shellcheck | 0 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 352 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1364 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 88 | the patch passed | | -1 | findbugs | 70 | hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 197 | hbase-common in the patch passed. | | -1 | unit | 14556 | hbase-server in the patch failed. | | +1 | unit | 416 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 69 | The patch does not generate ASF License warnings. | | | | 20179 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-common | | | org.apache.hadoop.hbase.Version.() invokes inefficient new String(String) constructor At Version.java:inefficient new String(String) constructor At Version.java:[line 10] | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/14/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/435 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux f9acd8a3b338 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-435/out/precommit/personality/provided.sh | | git revision | master / da114ac727 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/14/artifact/out/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/14/artifact/out/new-findbugs-hbase-common.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/14/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/14/testReport/ | | Max. process+thread count | 5046 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server hbase-rsgroup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/14/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22631) assign failed may make gced parent region appear again !!!
[
https://issues.apache.org/jira/browse/HBASE-22631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900373#comment-16900373
]
HBase QA commented on HBASE-22631:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 3m
3s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-2.1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
43s{color} | {color:green} branch-2.1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
59s{color} | {color:green} branch-2.1 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
30s{color} | {color:green} branch-2.1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
49s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
30s{color} | {color:green} branch-2.1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
42s{color} | {color:green} branch-2.1 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
2s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
21m 48s{color} | {color:green} Patch does not cause any errors with Hadoop
2.7.7 2.8.5 or 3.0.3 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}190m 11s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
21s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}254m 29s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.TestRegionRebalancing |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/717/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22631 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12976720/HBASE-22631-branch-2.1-01.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux b5173f9349f7 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3
08:28:49 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.1 / 946f5e6eb5 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/717/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
[jira] [Commented] (HBASE-22780) Missing table descriptor may cause STUCK Region-In-Transition forever
[
https://issues.apache.org/jira/browse/HBASE-22780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900357#comment-16900357
]
HBase QA commented on HBASE-22780:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
18s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-2.1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
43s{color} | {color:green} branch-2.1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
54s{color} | {color:green} branch-2.1 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
14s{color} | {color:green} branch-2.1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
54s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
10s{color} | {color:green} branch-2.1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} branch-2.1 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
8s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
20m 3s{color} | {color:green} Patch does not cause any errors with Hadoop
2.7.7 2.8.5 or 3.0.3 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}210m 49s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
28s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}266m 14s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/714/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22780 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12976716/HBASE-22780-branch-2.1-01.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 0c4dbc347840 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24
13:14:43 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.1 / 946f5e6eb5 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/714/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/714/testReport/ |
| Max. process+thread count | 4875 (vs. ulimit
[GitHub] [hbase] Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend URL: https://github.com/apache/hbase/pull/390#issuecomment-518370785 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 71 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | -1 | mvninstall | 20 | root in master failed. | | -1 | compile | 60 | hbase-server in master failed. | | +1 | checkstyle | 81 | master passed | | +1 | shadedjars | 282 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 34 | master passed | | 0 | spotbugs | 354 | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 | findbugs | 36 | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | -1 | mvninstall | 13 | root in the patch failed. | | -1 | compile | 35 | hbase-server in the patch failed. | | -1 | javac | 35 | hbase-server in the patch failed. | | +1 | checkstyle | 80 | hbase-server: The patch generated 0 new + 376 unchanged - 1 fixed = 376 total (was 377) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 275 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 13 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 25 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 37 | The patch causes 10 errors with Hadoop v3.1.2. | | +1 | javadoc | 32 | the patch passed | | -1 | findbugs | 34 | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 | unit | 36 | hbase-server in the patch failed. | | +1 | asflicense | 11 | The patch does not generate ASF License warnings. | | | | 1207 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/39/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/390 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux ca024ea8c7ed 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-390/out/precommit/personality/provided.sh | | git revision | master / ad3674f337 | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/39/artifact/out/branch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/39/artifact/out/branch-compile-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/39/artifact/out/branch-findbugs-hbase-server.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/39/artifact/out/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/39/artifact/out/patch-compile-hbase-server.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/39/artifact/out/patch-compile-hbase-server.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/39/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/39/artifact/out/patch-javac-2.9.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/39/artifact/out/patch-javac-3.1.2.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/39/artifact/out/patch-findbugs-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/39/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/39/testReport/ | | Max. process+thread count | 87 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/39/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git
[GitHub] [hbase] Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve…
Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve… URL: https://github.com/apache/hbase/pull/435#issuecomment-518369408 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 43 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | 0 | shelldocs | 0 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 13 | Maven dependency ordering for branch | | +1 | mvninstall | 322 | master passed | | +1 | compile | 106 | master passed | | +1 | checkstyle | 108 | master passed | | +1 | shadedjars | 284 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 75 | master passed | | 0 | spotbugs | 47 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 344 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | +1 | mvninstall | 310 | the patch passed | | +1 | compile | 105 | the patch passed | | +1 | javac | 105 | the patch passed | | -1 | checkstyle | 72 | hbase-server: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9) | | +1 | shellcheck | 1 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 280 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 966 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 74 | the patch passed | | -1 | findbugs | 58 | hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 176 | hbase-common in the patch passed. | | +1 | unit | 8199 | hbase-server in the patch passed. | | +1 | unit | 190 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 80 | The patch does not generate ASF License warnings. | | | | 12599 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-common | | | org.apache.hadoop.hbase.Version.() invokes inefficient new String(String) constructor At Version.java:inefficient new String(String) constructor At Version.java:[line 10] | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/15/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/435 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 60a0ed6a3417 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-435/out/precommit/personality/provided.sh | | git revision | master / 3f524abdeb | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/15/artifact/out/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/15/artifact/out/new-findbugs-hbase-common.html | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/15/testReport/ | | Max. process+thread count | 4535 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server hbase-rsgroup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/15/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-518368924 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 52 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for branch | | +1 | mvninstall | 319 | master passed | | +1 | compile | 79 | master passed | | +1 | checkstyle | 109 | master passed | | +1 | shadedjars | 285 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 56 | master passed | | 0 | spotbugs | 273 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 342 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 307 | the patch passed | | +1 | compile | 84 | the patch passed | | +1 | javac | 84 | the patch passed | | +1 | checkstyle | 101 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 279 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 958 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 57 | the patch passed | | +1 | findbugs | 321 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 100 | hbase-client in the patch passed. | | -1 | unit | 8339 | hbase-server in the patch failed. | | +1 | asflicense | 40 | The patch does not generate ASF License warnings. | | | | 12236 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.assignment.TestOpenRegionProcedureHang | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/69/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/361 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 55fa6b291ad8 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh | | git revision | master / 3f524abdeb | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/69/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/69/testReport/ | | Max. process+thread count | 4778 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/69/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22724) Add a emoji on the vote table for pre commit result on github
[ https://issues.apache.org/jira/browse/HBASE-22724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900333#comment-16900333 ] Sean Busbey commented on HBASE-22724: - sorry, I haven't dug into the github integration in yetus much. that said if you need a yetus release I'm happy to push on rolling one. > Add a emoji on the vote table for pre commit result on github > - > > Key: HBASE-22724 > URL: https://issues.apache.org/jira/browse/HBASE-22724 > Project: HBase > Issue Type: Improvement >Reporter: Duo Zhang >Priority: Major > > [~zghaobac] said that the current vote table on github is not good enough, as > the colors are almost the same, it is not easy to find out which line is > broken. > Since github can not change the color of the text, he suggested that we add a > column at the left most with some emojis to better notify the developpers. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend URL: https://github.com/apache/hbase/pull/390#issuecomment-518363252 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 33 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 304 | master passed | | +1 | compile | 55 | master passed | | +1 | checkstyle | 83 | master passed | | +1 | shadedjars | 288 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 36 | master passed | | 0 | spotbugs | 261 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 259 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 307 | the patch passed | | +1 | compile | 55 | the patch passed | | +1 | javac | 55 | the patch passed | | +1 | checkstyle | 81 | hbase-server: The patch generated 0 new + 376 unchanged - 1 fixed = 376 total (was 377) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 278 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 956 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 36 | the patch passed | | +1 | findbugs | 270 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 8056 | hbase-server in the patch passed. | | +1 | asflicense | 25 | The patch does not generate ASF License warnings. | | | | 11491 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/38/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/390 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 3f270e8342bf 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-390/out/precommit/personality/provided.sh | | git revision | master / 3f524abdeb | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/38/testReport/ | | Max. process+thread count | 4614 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/38/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #440: HBASE-22776 Rename config names in user scan snapshot feature
Apache-HBase commented on issue #440: HBASE-22776 Rename config names in user scan snapshot feature URL: https://github.com/apache/hbase/pull/440#issuecomment-518363268 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 43 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 298 | master passed | | +1 | compile | 54 | master passed | | +1 | checkstyle | 74 | master passed | | +1 | shadedjars | 273 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 32 | master passed | | 0 | spotbugs | 343 | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 | findbugs | 36 | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 296 | the patch passed | | +1 | compile | 55 | the patch passed | | +1 | javac | 55 | the patch passed | | -1 | checkstyle | 73 | hbase-server: The patch generated 1 new + 15 unchanged - 0 fixed = 16 total (was 15) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 270 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 921 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 33 | the patch passed | | +1 | findbugs | 249 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 8416 | hbase-server in the patch failed. | | +1 | asflicense | 22 | The patch does not generate ASF License warnings. | | | | 11507 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-440/14/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/440 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 1b07e379bb71 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-440/out/precommit/personality/provided.sh | | git revision | master / 3f524abdeb | | Default Java | 1.8.0_181 | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-440/14/artifact/out/branch-findbugs-hbase-server.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-440/14/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-440/14/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-440/14/testReport/ | | Max. process+thread count | 4630 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-440/14/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #428: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (master)
Apache-HBase commented on issue #428: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (master) URL: https://github.com/apache/hbase/pull/428#issuecomment-518362572 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 115 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 405 | master passed | | +1 | compile | 78 | master passed | | +1 | checkstyle | 108 | master passed | | +1 | shadedjars | 363 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 46 | master passed | | 0 | spotbugs | 312 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 309 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 369 | the patch passed | | +1 | compile | 69 | the patch passed | | +1 | javac | 69 | the patch passed | | +1 | checkstyle | 98 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 350 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1140 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 44 | the patch passed | | +1 | findbugs | 295 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 13053 | hbase-server in the patch failed. | | +1 | asflicense | 33 | The patch does not generate ASF License warnings. | | | | 17370 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.TestGetLastFlushedSequenceId | | | hadoop.hbase.security.access.TestWithDisabledAuthorization | | | hadoop.hbase.coprocessor.TestCoprocessorStop | | | hadoop.hbase.filter.TestColumnRangeFilter | | | hadoop.hbase.master.TestMirroringTableStateManager | | | hadoop.hbase.filter.TestMultiRowRangeFilter | | | hadoop.hbase.master.procedure.TestSCP | | | hadoop.hbase.TestRegionLoad | | | hadoop.hbase.master.TestMasterMetrics | | | hadoop.hbase.master.TestMasterRestartAfterDisablingTable | | | hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd | | | hadoop.hbase.io.encoding.TestBufferedDataBlockEncoder | | | hadoop.hbase.io.encoding.TestEncodedSeekers | | | hadoop.hbase.filter.TestFilterListOnMini | | | hadoop.hbase.coprocessor.TestRegionObserverForAddingMutationsFromCoprocessors | | | hadoop.hbase.TestGlobalMemStoreSize | | | hadoop.hbase.master.procedure.TestProcedurePriority | | | hadoop.hbase.master.procedure.TestSCPWithMetaWithReplicasWithoutZKCoordinated | | | hadoop.hbase.master.procedure.TestModifyTableProcedure | | | TEST-null | | | hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk | | | hadoop.hbase.master.procedure.TestReopenTableRegionsProcedureBackoff | | | hadoop.hbase.io.encoding.TestDataBlockEncoders | | | hadoop.hbase.master.TestMergeTableRegionsWhileRSCrash | | | hadoop.hbase.master.TestCatalogJanitorCluster | | | hadoop.hbase.filter.TestFilterWrapper | | | hadoop.hbase.master.replication.TestTransitPeerSyncReplicationStateProcedureRetry | | | hadoop.hbase.filter.TestScanRowPrefix | | | hadoop.hbase.master.TestRollingRestart | | | hadoop.hbase.master.procedure.TestTableDescriptorModificationFromClient | | | hadoop.hbase.coprocessor.TestOpenTableInCoprocessor | | | hadoop.hbase.master.TestMaster | | | hadoop.hbase.master.TestMetaShutdownHandler | | | hadoop.hbase.coprocessor.TestMasterCoprocessorExceptionWithAbort | | | hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes | | | hadoop.hbase.fs.TestBlockReorderBlockLocation | | | hadoop.hbase.master.TestMigrateNamespaceTable | | | hadoop.hbase.coprocessor.TestNegativeMemStoreSizeWithSlowCoprocessor | | | hadoop.hbase.TestMultiVersions | | | hadoop.hbase.master.TestCatalogJanitorInMemoryStates | | | hadoop.hbase.io.encoding.TestChangingEncoding | | | hadoop.hbase.coprocessor.TestRegionObserverInterface | | | hadoop.hbase.security.access.TestNamespaceCommands | | | hadoop.hbase.TestJMXConnectorServer | | | hadoop.hbase.master.TestDLSFSHLog | | | hadoop.hbase.master.locking.TestLockManager | | | hadoop.hbase.master.TestDLSAsyncFSWAL | | | hadoop.hbase.security.access.TestAccessController2 | | |
[jira] [Updated] (HBASE-19741) Port CSRF prevention filter (HBASE-15187) to the HBase Thrift server
[ https://issues.apache.org/jira/browse/HBASE-19741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-19741: Component/s: Thrift security > Port CSRF prevention filter (HBASE-15187) to the HBase Thrift server > > > Key: HBASE-19741 > URL: https://issues.apache.org/jira/browse/HBASE-19741 > Project: HBase > Issue Type: Bug > Components: security, Thrift >Reporter: Esteban Gutierrez >Priority: Minor > > Our thrift server is prone to the same CSRF issue described in HBASE-15187. > Even it only affects browsers it triggers a positive match in some > venerability scanners even there is no real impact. We should correct our > headers in the HBase Thrift server to avoid that problem. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment
Apache-HBase commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment URL: https://github.com/apache/hbase/pull/439#issuecomment-518362124 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 108 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | -1 | mvninstall | 247 | root in master failed. | | +1 | compile | 74 | master passed | | +1 | checkstyle | 103 | master passed | | +1 | shadedjars | 396 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 46 | master passed | | 0 | spotbugs | 321 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 317 | master passed | ||| _ Patch Compile Tests _ | | -1 | mvninstall | 176 | root in the patch failed. | | +1 | compile | 72 | the patch passed | | +1 | javac | 72 | the patch passed | | -1 | checkstyle | 97 | hbase-server: The patch generated 1 new + 64 unchanged - 0 fixed = 65 total (was 64) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 372 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 117 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 232 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 351 | The patch causes 10 errors with Hadoop v3.1.2. | | +1 | javadoc | 43 | the patch passed | | +1 | findbugs | 338 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 14649 | hbase-server in the patch failed. | | +1 | asflicense | 25 | The patch does not generate ASF License warnings. | | | | 17497 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.replication.TestReplicationDisableInactivePeer | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/16/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/439 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 81c862a1a89d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-439/out/precommit/personality/provided.sh | | git revision | master / da114ac727 | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/16/artifact/out/branch-mvninstall-root.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/16/artifact/out/patch-mvninstall-root.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/16/artifact/out/diff-checkstyle-hbase-server.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/16/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/16/artifact/out/patch-javac-2.9.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/16/artifact/out/patch-javac-3.1.2.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/16/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/16/testReport/ | | Max. process+thread count | 4762 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/16/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22728) Upgrade jackson dependencies in branch-1
[
https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900330#comment-16900330
]
Sean Busbey commented on HBASE-22728:
-
{quote}
bq. Above QA failure message for shadedjar is: Found Banned Dependency:
jdk.tools:jdk.tools:jar:1.8 (which also comes without the patch applied on
branch-1). Hope it is not a concern.
I'm not sure what that is about. Sean Busbey?{quote}
I think we used to accidentally include the tools.jar from the JDK in our
assembly? we can't do that because it's under the same terms as the JDK. if
it's also in the branch and shows up on nightly, then I wouldn't worry about
fixing it here. But we should figure out what's going on, generally. I'll make
a jira and dig in when I can. If anyone else has time before a linked jira
shows up, please feel free to not wait for me.
> Upgrade jackson dependencies in branch-1
>
>
> Key: HBASE-22728
> URL: https://issues.apache.org/jira/browse/HBASE-22728
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 1.4.10, 1.3.5
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
> Attachments: HBASE-22728.branch-1.01.patch,
> HBASE-22728.branch-1.02.patch, HBASE-22728.branch-1.04.patch,
> HBASE-22728.branch-1.06.patch, dependency_codehaus.out
>
>
> Avoid Jackson versions and dependencies with known CVEs
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22728) Upgrade jackson dependencies in branch-1
[
https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900327#comment-16900327
]
Sean Busbey commented on HBASE-22728:
-
{quote}
If the ans is no due to downstreamers, they can break even with removal of
Jackson 1 from classpath now. May be I am missing something specific? Or
"version upgrade should be done in major release only" is a very strict rule to
follow even if version in use is ~ 7 yr old?
{quote}
that guideline is specifically about non backwards compatible version changes.
if we're going to make downstream deal with removing jackson 1 from the
classpath then we should try to just have no exposed jackson for downstream at
the end of the day. I think [~Apache9] has mentioned wanting to move to shaded
gson, but I haven't kept up on how that went. If there's a relocated gson in
hbase-thirdparty maybe it's time to move branch-1 to it as well.
> Upgrade jackson dependencies in branch-1
>
>
> Key: HBASE-22728
> URL: https://issues.apache.org/jira/browse/HBASE-22728
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 1.4.10, 1.3.5
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
> Attachments: HBASE-22728.branch-1.01.patch,
> HBASE-22728.branch-1.02.patch, HBASE-22728.branch-1.04.patch,
> HBASE-22728.branch-1.06.patch, dependency_codehaus.out
>
>
> Avoid Jackson versions and dependencies with known CVEs
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
