[GitHub] [hbase] Apache-HBase commented on issue #1536: HBASE-24198 Make nightly job run hadoop3 check on JDK8
Apache-HBase commented on issue #1536: HBASE-24198 Make nightly job run hadoop3 check on JDK8 URL: https://github.com/apache/hbase/pull/1536#issuecomment-615074395 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 1m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1536/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1536 | | Optional Tests | | | uname | Linux d9f84a06453c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b7a6d36be4 | | Max. process+thread count | 49 (vs. ulimit of 12500) | | modules | C: U: | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1536/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1537: HBASE-24174 Fix findbugs warning on ServiceAuthorizationManager for master branch
Apache-HBase commented on issue #1537: HBASE-24174 Fix findbugs warning on ServiceAuthorizationManager for master branch URL: https://github.com/apache/hbase/pull/1537#issuecomment-615074168 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 37s | master passed | | +1 :green_heart: | checkstyle | 1m 7s | master passed | | +1 :green_heart: | spotbugs | 2m 1s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 14s | the patch passed | | +1 :green_heart: | checkstyle | 1m 3s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 5m 22s | Patch does not cause any errors with Hadoop 3.1.2. | | -1 :x: | spotbugs | 2m 10s | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 26m 21s | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-server | | | Inconsistent synchronization of org.apache.hadoop.hbase.ipc.RpcServer.authManager; locked 71% of time Unsynchronized access at RpcServer.java:71% of time Unsynchronized access at RpcServer.java:[line 599] | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1537/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1537 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 9e627464c0d9 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b7a6d36be4 | | spotbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1537/1/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1537/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1536: HBASE-24198 Make nightly job run hadoop3 check on JDK8
Apache-HBase commented on issue #1536: HBASE-24198 Make nightly job run hadoop3 check on JDK8 URL: https://github.com/apache/hbase/pull/1536#issuecomment-615073571 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 1m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1536/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1536 | | Optional Tests | | | uname | Linux b015ea14539e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b7a6d36be4 | | Max. process+thread count | 48 (vs. ulimit of 12500) | | modules | C: U: | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1536/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1536: HBASE-24198 Make nightly job run hadoop3 check on JDK8
Apache-HBase commented on issue #1536: HBASE-24198 Make nightly job run hadoop3 check on JDK8 URL: https://github.com/apache/hbase/pull/1536#issuecomment-615072763 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 33s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | ||| _ Other Tests _ | | +0 :ok: | asflicense | 0m 0s | ASF License check generated no output? | | | | 2m 16s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1536/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1536 | | Optional Tests | dupname asflicense shellcheck shelldocs | | uname | Linux efc68f309255 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b7a6d36be4 | | Max. process+thread count | 52 (vs. ulimit of 12500) | | modules | C: U: | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1536/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-24198) Skip hadoop2 check for master branch
[ https://issues.apache.org/jira/browse/HBASE-24198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24198: -- Summary: Skip hadoop2 check for master branch (was: Make nightly job run hadoop3 check on JDK8) > Skip hadoop2 check for master branch > > > Key: HBASE-24198 > URL: https://issues.apache.org/jira/browse/HBASE-24198 > Project: HBase > Issue Type: Sub-task > Components: hadoop2, hadoop3, pom, scripts >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > Now we will run hadoop2 check on jdk8 and hadoop3 check on jdk11, since the > support of hadoop2 has been dropped, let's make jdk8 check also on hadoop3. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24184) listSnapshots returns empty when just use simple acl but not use authentication
[
https://issues.apache.org/jira/browse/HBASE-24184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085471#comment-17085471
]
Lijin Bin commented on HBASE-24184:
---
Should be duplicate of https://issues.apache.org/jira/browse/HBASE-23896.
> listSnapshots returns empty when just use simple acl but not use
> authentication
> ---
>
> Key: HBASE-24184
> URL: https://issues.apache.org/jira/browse/HBASE-24184
> Project: HBase
> Issue Type: Bug
> Components: snapshots
>Reporter: tianhang tang
>Assignee: tianhang tang
>Priority: Minor
>
> For the owner of snapshots(not global admin user), currently list_snapshots
> returns empty if i just use simple acls for authorization but not use
> authentication.
> The code in AccessController.preListSnapshot:
> {code:java}
> if (SnapshotDescriptionUtils.isSnapshotOwner(snapshot, user)) {
> // list it, if user is the owner of snapshot
> AuthResult result = AuthResult.allow("listSnapshot " + snapshot.getName(),
> "Snapshot owner check allowed", user, null, null, null);
> accessChecker.logResult(result);
> }{code}
> And SnapshotManager.takeSnapshotInternal:
> {code:java}
> if (User.isHBaseSecurityEnabled(master.getConfiguration()) && user != null) {
> builder.setOwner(user.getShortName());
> }
> {code}
> User.isHBaseSecurityEnabled：
> {code:java}
> public static boolean isHBaseSecurityEnabled(Configuration conf) {
> return "kerberos".equalsIgnoreCase(conf.get(HBASE_SECURITY_CONF_KEY));
> }
> {code}
> So i think the logic of setOwner is used for authorization, not
> authentication, SnapshotManager should not only setOwner when
> hbase.security.authentication = kerberos, which cause listSnapshots returns
> empty when i just use simple acls.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1436: HBASE-23933 Separate a hbase-balancer module
Apache-HBase commented on issue #1436: HBASE-23933 Separate a hbase-balancer module URL: https://github.com/apache/hbase/pull/1436#issuecomment-615064416 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 42s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 29s | master passed | | +1 :green_heart: | checkstyle | 2m 1s | master passed | | +1 :green_heart: | spotbugs | 10m 18s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 16s | the patch passed | | +1 :green_heart: | checkstyle | 2m 0s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 4s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 5m 22s | Patch does not cause any errors with Hadoop 3.1.2. | | +1 :green_heart: | spotbugs | 11m 8s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 40s | The patch does not generate ASF License warnings. | | | | 47m 30s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1436/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1436 | | Optional Tests | dupname asflicense hadoopcheck xml spotbugs hbaseanti checkstyle | | uname | Linux b76482b9c1ec 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b7a6d36be4 | | Max. process+thread count | 137 (vs. ulimit of 12500) | | modules | C: hbase-balancer . hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1436/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Reidddddd opened a new pull request #1537: HBASE-24174 Fix findbugs warning on ServiceAuthorizationManager for master branch
Reidd opened a new pull request #1537: HBASE-24174 Fix findbugs warning on ServiceAuthorizationManager for master branch URL: https://github.com/apache/hbase/pull/1537 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24154) HdfsFileStatus incompatibility when used with Hadoop 3.1.3 and Hbase version 2.2.4
[ https://issues.apache.org/jira/browse/HBASE-24154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085457#comment-17085457 ] Mohankumar K H commented on HBASE-24154: Hi, Even after compiling the options only I posted these errors. Can you reply please mvn -DskipTests clean install && mvn -Dhadoop.profile=3.0 -Dhadoop-three.version=3.1.3 -DskipTests package assembly:single > HdfsFileStatus incompatibility when used with Hadoop 3.1.3 and Hbase version > 2.2.4 > -- > > Key: HBASE-24154 > URL: https://issues.apache.org/jira/browse/HBASE-24154 > Project: HBase > Issue Type: Bug > Components: hadoop3, regionserver >Affects Versions: 2.2.4 > Environment: cenots 7.6 > util.VersionInfo: HBase 2.2.4,/usr/lib/jvm/java-1.8.0-openjdk >Reporter: Mohankumar K H >Priority: Blocker > Original Estimate: 96h > Remaining Estimate: 96h > > Hi, > Even after compiling from source I am getting below error message. Hbasse > master start without any issue, but region server fails with below message > handler.AssignRegionHandler: Fatal error occurred while opening region > hbase:meta,,1.1588230740, aborting... > java.lang.IncompatibleClassChangeError: Found interface > org.apache.hadoop.hdfs.protocol.HdfsFileStatus, but class was expected > at > org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.createOutput(FanOutOneBlockAsyncDFSOutputHelper.java:496) > at > org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.access$400(FanOutOneBlockAsyncDFSOutputHelper.java:116) > at > org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper$8.doCall(FanOutOneBlockAsyncDFSOutputHelper.java:576) > at > org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper$8.doCall(FanOutOneBlockAsyncDFSOutputHelper.java:571) > at > org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81) > at > org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.createOutput(FanOutOneBlockAsyncDFSOutputHelper.java:584) > at > org.apache.hadoop.hbase.io.asyncfs.AsyncFSOutputHelper.createOutput(AsyncFSOutputHelper.java:51) > at > org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.initOutput(AsyncProtobufLogWriter.java:169) > at > org.apache.hadoop.hbase.regionserver.wal.AbstractProtobufLogWriter.init(AbstractProtobufLogWriter.java:166) > at > org.apache.hadoop.hbase.wal.AsyncFSWALProvider.createAsyncWriter(AsyncFSWALProvider.java:113) > at > org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:643) > at > org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:126) > at > org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:767) > at > org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:501) > at > org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.init(AbstractFSWAL.java:442) > at > org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:156) > at > org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:61) > at org.apache.hadoop.hbase.wal.WALFactory.getWAL(WALFactory.java:284) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.getWAL(HRegionServer.java:2181) > at > org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:133) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24174) Fix findbugs warning on ServiceAuthorizationManager
[ https://issues.apache.org/jira/browse/HBASE-24174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-24174: -- Summary: Fix findbugs warning on ServiceAuthorizationManager (was: Fix findbugs warning in branch-1) > Fix findbugs warning on ServiceAuthorizationManager > --- > > Key: HBASE-24174 > URL: https://issues.apache.org/jira/browse/HBASE-24174 > Project: HBase > Issue Type: Bug >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Major > Fix For: 1.7.0, 1.4.14 > > > Inconsistent synchronization of > org.apache.hadoop.hbase.ipc.RpcServer.authManager; locked 66% of time. > It is introduced by HBASE-24121, let me fix it. It haven't got released yet. > Looks affect branch-1 so far. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Reidddddd merged pull request #1494: HBASE-24174 Fix findbugs warning in branch-1
Reidd merged pull request #1494: HBASE-24174 Fix findbugs warning in branch-1 URL: https://github.com/apache/hbase/pull/1494 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1530: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication
Apache-HBase commented on issue #1530: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication URL: https://github.com/apache/hbase/pull/1530#issuecomment-615052672 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 19s | master passed | | +1 :green_heart: | compile | 1m 8s | master passed | | +1 :green_heart: | shadedjars | 5m 39s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 40s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 26s | the patch passed | | +1 :green_heart: | compile | 1m 8s | the patch passed | | +1 :green_heart: | javac | 1m 8s | the patch passed | | +1 :green_heart: | shadedjars | 5m 40s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 41s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 178m 26s | hbase-server in the patch passed. | | | | 206m 19s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1530/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1530 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux cd4daa6b58c2 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b7a6d36be4 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1530/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1530/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1530/2/testReport/ | | Max. process+thread count | 3335 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1530/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Reidddddd commented on issue #1494: HBASE-24174 Fix findbugs warning in branch-1
Reidd commented on issue #1494: HBASE-24174 Fix findbugs warning in branch-1 URL: https://github.com/apache/hbase/pull/1494#issuecomment-615051883 Thanks @virajjasani , we finally get here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #1494: HBASE-24174 Fix findbugs warning in branch-1
virajjasani commented on a change in pull request #1494: HBASE-24174 Fix
findbugs warning in branch-1
URL: https://github.com/apache/hbase/pull/1494#discussion_r41898
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
##
@@ -2265,14 +2264,9 @@ public void onConfigurationChange(Configuration
newConf) {
if (scheduler instanceof ConfigurationObserver) {
((ConfigurationObserver)scheduler).onConfigurationChange(newConf);
}
-// Make sure authManager will read hbase-policy file
-System.setProperty("hadoop.policy.file", "hbase-policy.xml");
-synchronized (authManager) {
- authManager.refresh(newConf, new HBasePolicyProvider());
+if (authorize) {
Review comment:
👍
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Reidddddd commented on a change in pull request #1494: HBASE-24174 Fix findbugs warning in branch-1
Reidd commented on a change in pull request #1494: HBASE-24174 Fix findbugs
warning in branch-1
URL: https://github.com/apache/hbase/pull/1494#discussion_r41670
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
##
@@ -2265,14 +2264,9 @@ public void onConfigurationChange(Configuration
newConf) {
if (scheduler instanceof ConfigurationObserver) {
((ConfigurationObserver)scheduler).onConfigurationChange(newConf);
}
-// Make sure authManager will read hbase-policy file
-System.setProperty("hadoop.policy.file", "hbase-policy.xml");
-synchronized (authManager) {
- authManager.refresh(newConf, new HBasePolicyProvider());
+if (authorize) {
Review comment:
Yes, it is, to avoid unnecessary refresh. If authorization is disabled, then
no need to refresh it which it is time consuming.
We should forward-port this patch to branch-2+ and master as well, quite
some changes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #1494: HBASE-24174 Fix findbugs warning in branch-1
virajjasani commented on a change in pull request #1494: HBASE-24174 Fix
findbugs warning in branch-1
URL: https://github.com/apache/hbase/pull/1494#discussion_r40855
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
##
@@ -2265,14 +2264,9 @@ public void onConfigurationChange(Configuration
newConf) {
if (scheduler instanceof ConfigurationObserver) {
((ConfigurationObserver)scheduler).onConfigurationChange(newConf);
}
-// Make sure authManager will read hbase-policy file
-System.setProperty("hadoop.policy.file", "hbase-policy.xml");
-synchronized (authManager) {
- authManager.refresh(newConf, new HBasePolicyProvider());
+if (authorize) {
Review comment:
btw, this if condition is an enhancement for this patch? is it necessary?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on issue #1494: HBASE-24174 Fix findbugs warning in branch-1
virajjasani commented on issue #1494: HBASE-24174 Fix findbugs warning in branch-1 URL: https://github.com/apache/hbase/pull/1494#issuecomment-615050116 Yup, we are good :) ``` hbase-server generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) -- ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1494: HBASE-24174 Fix findbugs warning in branch-1
Apache-HBase commented on issue #1494: HBASE-24174 Fix findbugs warning in branch-1 URL: https://github.com/apache/hbase/pull/1494#issuecomment-615049521 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ branch-1 Compile Tests _ | | +1 :green_heart: | mvninstall | 9m 52s | branch-1 passed | | +1 :green_heart: | compile | 0m 41s | branch-1 passed with JDK v1.8.0_242 | | +1 :green_heart: | compile | 0m 44s | branch-1 passed with JDK v1.7.0_252 | | +1 :green_heart: | checkstyle | 1m 39s | branch-1 passed | | +1 :green_heart: | shadedjars | 2m 53s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 42s | branch-1 passed with JDK v1.8.0_242 | | +1 :green_heart: | javadoc | 0m 40s | branch-1 passed with JDK v1.7.0_252 | | +0 :ok: | spotbugs | 2m 54s | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 :x: | findbugs | 2m 51s | hbase-server in branch-1 has 1 extant findbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 1m 56s | the patch passed | | +1 :green_heart: | compile | 0m 40s | the patch passed with JDK v1.8.0_242 | | +1 :green_heart: | javac | 0m 40s | the patch passed | | +1 :green_heart: | compile | 0m 45s | the patch passed with JDK v1.7.0_252 | | +1 :green_heart: | javac | 0m 45s | the patch passed | | +1 :green_heart: | checkstyle | 1m 30s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 2m 46s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 5m 2s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | +1 :green_heart: | javadoc | 0m 34s | the patch passed with JDK v1.8.0_242 | | +1 :green_heart: | javadoc | 0m 42s | the patch passed with JDK v1.7.0_252 | | +1 :green_heart: | findbugs | 2m 52s | hbase-server generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 122m 21s | hbase-server in the patch passed. | | +1 :green_heart: | asflicense | 0m 31s | The patch does not generate ASF License warnings. | | | | 163m 55s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/10/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1494 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux e92de0aa6775 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1494/out/precommit/personality/provided.sh | | git revision | branch-1 / d4b64c2 | | Default Java | 1.7.0_252 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252 | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/10/artifact/out/branch-findbugs-hbase-server-warnings.html | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/10/testReport/ | | Max. process+thread count | 4060 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/10/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1536: HBASE-24198 Make nightly job run hadoop3 check on JDK8
Apache-HBase commented on issue #1536: HBASE-24198 Make nightly job run hadoop3 check on JDK8 URL: https://github.com/apache/hbase/pull/1536#issuecomment-615045913 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 2m 39s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1536/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1536 | | Optional Tests | | | uname | Linux ca247decdf81 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b7a6d36be4 | | Max. process+thread count | 45 (vs. ulimit of 12500) | | modules | C: U: | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1536/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1536: HBASE-24198 Make nightly job run hadoop3 check on JDK8
Apache-HBase commented on issue #1536: HBASE-24198 Make nightly job run hadoop3 check on JDK8 URL: https://github.com/apache/hbase/pull/1536#issuecomment-615044998 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 28s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 33s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | ||| _ Other Tests _ | | +0 :ok: | asflicense | 0m 0s | ASF License check generated no output? | | | | 3m 14s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1536/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1536 | | Optional Tests | dupname asflicense shellcheck shelldocs | | uname | Linux 9d5e011a0ab9 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b7a6d36be4 | | Max. process+thread count | 47 (vs. ulimit of 12500) | | modules | C: U: | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1536/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1536: HBASE-24198 Make nightly job run hadoop3 check on JDK8
Apache-HBase commented on issue #1536: HBASE-24198 Make nightly job run hadoop3 check on JDK8 URL: https://github.com/apache/hbase/pull/1536#issuecomment-615045319 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 2m 9s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1536/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1536 | | Optional Tests | | | uname | Linux 683a6405168d 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b7a6d36be4 | | Max. process+thread count | 47 (vs. ulimit of 12500) | | modules | C: U: | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1536/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #1509: HBASE-24182 log when the region is set to closing status
virajjasani commented on a change in pull request #1509: HBASE-24182 log when
the region is set to closing status
URL: https://github.com/apache/hbase/pull/1509#discussion_r409993847
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##
@@ -1655,6 +1655,7 @@ public void setTimeoutForWriteLock(long
timeoutForWriteLock) {
}
}
this.closing.set(true);
+LOG.info("Closing {}", this);
Review comment:
@Joseph295 Can you change this to "Closing region {}"? `this` is anyways
going to print region name as string only.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] nyl3532016 opened a new pull request #1436: HBASE-23933 Separate a hbase-balancer module
nyl3532016 opened a new pull request #1436: HBASE-23933 Separate a hbase-balancer module URL: https://github.com/apache/hbase/pull/1436 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] virajjasani commented on issue #1509: HBASE-24182 log when the region is set to closing status
virajjasani commented on issue #1509: HBASE-24182 log when the region is set to closing status URL: https://github.com/apache/hbase/pull/1509#issuecomment-615041930 > @virajjasani No strong opinion from me but the one new INFO level log inline with other logging seems fine. The close journal is printed after the fact and so is a bit confusing if you are sorting log lines chronologically. Sure, overall the logging is redundant. Sure, for the sake of chronological sorting, it is good to log this. Let's get it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] nyl3532016 closed pull request #1436: HBASE-23933 Separate a hbase-balancer module
nyl3532016 closed pull request #1436: HBASE-23933 Separate a hbase-balancer module URL: https://github.com/apache/hbase/pull/1436 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24198) Make nightly job run hadoop3 check on JDK8
[
https://issues.apache.org/jira/browse/HBASE-24198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085428#comment-17085428
]
Hudson commented on HBASE-24198:
Results for branch HBASE-24198
[build #1 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-24198/1/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-24198/1/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-24198/1/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-24198/1/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-24198/1/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-24198/1//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Make nightly job run hadoop3 check on JDK8
> --
>
> Key: HBASE-24198
> URL: https://issues.apache.org/jira/browse/HBASE-24198
> Project: HBase
> Issue Type: Sub-task
> Components: hadoop2, hadoop3, pom, scripts
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> Now we will run hadoop2 check on jdk8 and hadoop3 check on jdk11, since the
> support of hadoop2 has been dropped, let's make jdk8 check also on hadoop3.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24049) "Packaging and Integration" check fails
[
https://issues.apache.org/jira/browse/HBASE-24049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085429#comment-17085429
]
Hudson commented on HBASE-24049:
Results for branch HBASE-24049-packaging-integration-hadoop-2.10.0
[build #7 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-24049-packaging-integration-hadoop-2.10.0/7/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-24049-packaging-integration-hadoop-2.10.0/7/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-24049-packaging-integration-hadoop-2.10.0/7/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-24049-packaging-integration-hadoop-2.10.0/7/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-24049-packaging-integration-hadoop-2.10.0/7/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> "Packaging and Integration" check fails
> ---
>
> Key: HBASE-24049
> URL: https://issues.apache.org/jira/browse/HBASE-24049
> Project: HBase
> Issue Type: Task
> Components: build
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> Looks like this is running with Hadoop 2.8.5, despite HBASE-23986
> {noformat}
> [2020-03-24T09:14:00.930Z] ++ ls -1
> /home/jenkins/jenkins-slave/workspace/HBase_Nightly_master/hadoop-2.8.5-bin.tar.gz
> [2020-03-24T09:14:00.930Z] ++ head -n 1
> [2020-03-24T09:14:00.930Z] +
> artifact=/home/jenkins/jenkins-slave/workspace/HBase_Nightly_master/hadoop-2.8.5-bin.tar.gz
> [2020-03-24T09:14:00.930Z] + tar --strip-components=1 -xzf
> /home/jenkins/jenkins-slave/workspace/HBase_Nightly_master/hadoop-2.8.5-bin.tar.gz
> -C hadoop-2
> [2020-03-24T09:14:06.186Z] +
> /home/jenkins/jenkins-slave/workspace/HBase_Nightly_master/component/dev-support/hbase_nightly_pseudo-distributed-test.sh
> --single-process --working-dir output-integration/hadoop-2
> --hbase-client-install hbase-client hbase-install hadoop-2/bin/hadoop
> hadoop-2/share/hadoop/yarn/test/hadoop-yarn-server-tests-2.8.5-tests.jar
> hadoop-2/share/hadoop/mapreduce/hadoop-mapreduce-client-jobclient-2.8.5-tests.jar
> hadoop-2/bin/mapred
> [2020-03-24T17:50:28.859Z] Sending interrupt signal to process
> [2020-03-24T17:50:30.005Z] Sending interrupt signal to process
> [2020-03-24T17:50:42.558Z] + echo '(x) {color:red}-1 client integration
> test{color}
> [2020-03-24T17:50:42.558Z] --Failed when running client tests on top of
> Hadoop 2. [see log for
> details|https://builds.apache.org/job/HBase%20Nightly/job/master/1677//artifact/output-integration/hadoop-2.log].
> (note that this means we didn'\''t run on Hadoop 3)'
> [2020-03-24T17:50:42.558Z] + exit 2
> [2020-03-24T17:50:42.866Z] script returned exit code 2
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1530: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication
Apache-HBase commented on issue #1530: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication URL: https://github.com/apache/hbase/pull/1530#issuecomment-615037544 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 2s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 4s | master passed | | +1 :green_heart: | compile | 1m 1s | master passed | | +1 :green_heart: | shadedjars | 6m 6s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 43s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 59s | the patch passed | | +1 :green_heart: | compile | 1m 1s | the patch passed | | +1 :green_heart: | javac | 1m 1s | the patch passed | | +1 :green_heart: | shadedjars | 5m 47s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 123m 1s | hbase-server in the patch passed. | | | | 150m 13s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1530/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1530 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 0174d5ec1674 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b7a6d36be4 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1530/2/testReport/ | | Max. process+thread count | 3822 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1530/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] nyl3532016 closed pull request #1501: HBASE-23933 Separate a hbase-balancer module
nyl3532016 closed pull request #1501: HBASE-23933 Separate a hbase-balancer module URL: https://github.com/apache/hbase/pull/1501 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on issue #1536: HBASE-24198 Make nightly job run hadoop3 check on JDK8
Apache9 commented on issue #1536: HBASE-24198 Make nightly job run hadoop3 check on JDK8 URL: https://github.com/apache/hbase/pull/1536#issuecomment-615030557 Oh, the condition can not deal with feature branch... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] nyl3532016 opened a new pull request #1436: HBASE-23933 Separate a hbase-balancer module
nyl3532016 opened a new pull request #1436: HBASE-23933 Separate a hbase-balancer module URL: https://github.com/apache/hbase/pull/1436 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 opened a new pull request #1536: HBASE-24198 Make nightly job run hadoop3 check on JDK8
Apache9 opened a new pull request #1536: HBASE-24198 Make nightly job run hadoop3 check on JDK8 URL: https://github.com/apache/hbase/pull/1536 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1533: HBASE-24148 Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs.
Apache-HBase commented on issue #1533: HBASE-24148 Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs. URL: https://github.com/apache/hbase/pull/1533#issuecomment-615017710 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-1 Compile Tests _ | | +0 :ok: | mvndep | 2m 3s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 8m 26s | branch-1 passed | | +1 :green_heart: | compile | 1m 39s | branch-1 passed with JDK v1.8.0_242 | | +1 :green_heart: | compile | 1m 45s | branch-1 passed with JDK v1.7.0_252 | | +1 :green_heart: | checkstyle | 5m 34s | branch-1 passed | | +1 :green_heart: | shadedjars | 2m 54s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 37s | branch-1 passed with JDK v1.8.0_242 | | +1 :green_heart: | javadoc | 5m 5s | branch-1 passed with JDK v1.7.0_252 | | +0 :ok: | spotbugs | 1m 28s | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 :x: | findbugs | 10m 36s | root in branch-1 has 1 extant findbugs warnings. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 29s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 1m 51s | the patch passed | | +1 :green_heart: | compile | 1m 41s | the patch passed with JDK v1.8.0_242 | | +1 :green_heart: | javac | 1m 41s | the patch passed | | +1 :green_heart: | compile | 1m 41s | the patch passed with JDK v1.7.0_252 | | -1 :x: | javac | 1m 41s | root-jdk1.7.0_252 with JDK v1.7.0_252 generated 116 new + 38 unchanged - 0 fixed = 154 total (was 38) | | +1 :green_heart: | checkstyle | 0m 29s | hbase-thrift: The patch generated 0 new + 38 unchanged - 1 fixed = 38 total (was 39) | | +1 :green_heart: | checkstyle | 5m 9s | root: The patch generated 0 new + 38 unchanged - 1 fixed = 38 total (was 39) | | -1 :x: | whitespace | 0m 0s | The patch 4 line(s) with tabs. | | -1 :x: | xml | 0m 0s | The patch has 2 ill-formed XML file(s). | | +1 :green_heart: | shadedjars | 2m 49s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 5m 4s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | +1 :green_heart: | javadoc | 2m 31s | the patch passed with JDK v1.8.0_242 | | +1 :green_heart: | javadoc | 5m 11s | the patch passed with JDK v1.7.0_252 | | +1 :green_heart: | findbugs | 12m 37s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 174m 25s | root in the patch failed. | | +1 :green_heart: | asflicense | 0m 54s | The patch does not generate ASF License warnings. | | | | 261m 48s | | | Reason | Tests | |---:|:--| | XML | Parsing Error(s): | | | hbase-thrift/pom.xml | | | pom.xml | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1533/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1533 | | Optional Tests | dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle | | uname | Linux 3bdb84911ac4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1533/out/precommit/personality/provided.sh | | git revision | branch-1 / d4b64c2 | | Default Java | 1.7.0_252 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252 | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1533/2/artifact/out/branch-findbugs-root-warnings.html | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1533/2/artifact/out/diff-compile-javac-root-jdk1.7.0_252.txt | | whitespace | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1533/2/artifact/out/whitespace-tabs.txt | | xml | https://bu
[GitHub] [hbase] Reidddddd commented on issue #1494: HBASE-24174 Fix findbugs warning in branch-1
Reidd commented on issue #1494: HBASE-24174 Fix findbugs warning in branch-1 URL: https://github.com/apache/hbase/pull/1494#issuecomment-615007594 Rebased branch-1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1530: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication
Apache-HBase commented on issue #1530: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication URL: https://github.com/apache/hbase/pull/1530#issuecomment-615005842 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 55s | master passed | | +1 :green_heart: | checkstyle | 1m 12s | master passed | | +1 :green_heart: | spotbugs | 2m 7s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 33s | the patch passed | | +1 :green_heart: | checkstyle | 1m 12s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 5m 52s | Patch does not cause any errors with Hadoop 3.1.2. | | +1 :green_heart: | spotbugs | 2m 16s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 27m 58s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1530/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1530 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux e591f84601ee 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b7a6d36be4 | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1530/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24186) RegionMover ignores replicationId
[
https://issues.apache.org/jira/browse/HBASE-24186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085335#comment-17085335
]
Hudson commented on HBASE-24186:
Results for branch branch-2.2
[build #839 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/839/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/839//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/839//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/839//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> RegionMover ignores replicationId
> -
>
> Key: HBASE-24186
> URL: https://issues.apache.org/jira/browse/HBASE-24186
> Project: HBase
> Issue Type: Bug
> Components: read replicas
>Reporter: Szabolcs Bukros
>Assignee: Szabolcs Bukros
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.1.10, 2.2.5
>
>
> When RegionMover looks up which rs hosts a region, it does this based on
> startRowKey. When read replication is enabled this might not return the
> expected region's data and this can prevent the moving of these regions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24151) [rsgroup] The master server aborted for IllegalThreadStateException
[
https://issues.apache.org/jira/browse/HBASE-24151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085334#comment-17085334
]
Hudson commented on HBASE-24151:
Results for branch branch-2.2
[build #839 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/839/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/839//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/839//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/839//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [rsgroup] The master server aborted for IllegalThreadStateException
>
>
> Key: HBASE-24151
> URL: https://issues.apache.org/jira/browse/HBASE-24151
> Project: HBase
> Issue Type: Bug
> Components: rsgroup
>Affects Versions: 2.3.0, 2.1.7, 2.2.3
>Reporter: kangkang.guo
>Assignee: kangkang.guo
>Priority: Minor
> Fix For: 2.3.0, 2.1.10, 2.2.5
>
>
> if
> 'hbase.master.loadbalancer.class=org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer'
> and
> 'hbase.rsgroup.grouploadbalancer.class=org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer',
> The master server will aborted for IllegalThreadStateException.
> {code:java}
> 2020-04-09 11:24:26,142 ERROR [master/xx.xx.xx.xx:16000:becomeActiveMaster]
> master.HMaster: Failed to become active master
> java.lang.IllegalThreadStateException
> at java.lang.Thread.start(Thread.java:705)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl.start(RSGroupInfoManagerImpl.java:172)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.initialize(RSGroupBasedLoadBalancer.java:417)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.initialize(RSGroupBasedLoadBalancer.java:430)
> at
> org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:968)
> at
> org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2275)
> at
> org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:584)
> at java.lang.Thread.run(Thread.java:745)
> 2020-04-09 11:24:26,144 ERROR [master/xx.xx.xx.xx:16000:becomeActiveMaster]
> master.HMaster: Master server abort: loaded coprocessors are:
> [org.apache.hadoop.hbase.security.access.AccessController,
> org.apache.hadoop.hbase.quotas.MasterQuotasObserver,
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint]{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24158) [Flakey Tests] TestAsyncTableGetMultiThreaded
[
https://issues.apache.org/jira/browse/HBASE-24158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085336#comment-17085336
]
Hudson commented on HBASE-24158:
Results for branch branch-2.2
[build #839 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/839/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/839//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/839//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/839//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [Flakey Tests] TestAsyncTableGetMultiThreaded
> -
>
> Key: HBASE-24158
> URL: https://issues.apache.org/jira/browse/HBASE-24158
> Project: HBase
> Issue Type: Bug
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.5
>
> Attachments:
> 0001-HBASE-24158-Flakey-Tests-TestAsyncTableGetMultiThrea.addendum.patch,
> 0001-HBASE-24158-Flakey-Tests-TestAsyncTableGetMultiThrea.patch
>
>
> I've already cut down the number of threads used by this test but it failed
> in nightly last night unable to close out its xml and locally it failed too
> in a run overnight. I ran it under harness and it seems well-behaved. It
> doesn't use much memory -- 700MB -- and thread counts are usual (~450). It
> does use near 100% CPU which is a little unusual. Otherwise, looks fine.
> Let me keep an eye on it. Could down the thread count more and use less
> processes... this makes it use less CPU. There does seems a bunch of overlap
> with tests done elsewhere.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24197) TestHttpServer.testBindAddress failure with latest jetty
[
https://issues.apache.org/jira/browse/HBASE-24197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085333#comment-17085333
]
Hudson commented on HBASE-24197:
Results for branch branch-2.2
[build #839 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/839/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/839//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/839//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/839//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> TestHttpServer.testBindAddress failure with latest jetty
>
>
> Key: HBASE-24197
> URL: https://issues.apache.org/jira/browse/HBASE-24197
> Project: HBase
> Issue Type: Bug
>Affects Versions: master
>Reporter: Istvan Toth
>Assignee: Istvan Toth
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.4.0, 2.2.5
>
>
> The latest jetty version (tested with 9.4.28.v20200408 which is not included
> in HBase yet) wraps BindException into an IOException when it fails to bind
> to a port.
> This breaks HttpServer's findPort functionality, which manifests in
> TestHttpServer.testBindAddress failing.
> The proposed patch handles both the old and the new jetty behaviour correctly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24186) RegionMover ignores replicationId
[
https://issues.apache.org/jira/browse/HBASE-24186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085327#comment-17085327
]
Hudson commented on HBASE-24186:
Results for branch branch-2.1
[build #1853 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1853/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1853//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1853//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1853//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
-- Something went wrong with this stage, [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1853//console].
> RegionMover ignores replicationId
> -
>
> Key: HBASE-24186
> URL: https://issues.apache.org/jira/browse/HBASE-24186
> Project: HBase
> Issue Type: Bug
> Components: read replicas
>Reporter: Szabolcs Bukros
>Assignee: Szabolcs Bukros
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.1.10, 2.2.5
>
>
> When RegionMover looks up which rs hosts a region, it does this based on
> startRowKey. When read replication is enabled this might not return the
> expected region's data and this can prevent the moving of these regions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24151) [rsgroup] The master server aborted for IllegalThreadStateException
[
https://issues.apache.org/jira/browse/HBASE-24151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085326#comment-17085326
]
Hudson commented on HBASE-24151:
Results for branch branch-2.1
[build #1853 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1853/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1853//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1853//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1853//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
-- Something went wrong with this stage, [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1853//console].
> [rsgroup] The master server aborted for IllegalThreadStateException
>
>
> Key: HBASE-24151
> URL: https://issues.apache.org/jira/browse/HBASE-24151
> Project: HBase
> Issue Type: Bug
> Components: rsgroup
>Affects Versions: 2.3.0, 2.1.7, 2.2.3
>Reporter: kangkang.guo
>Assignee: kangkang.guo
>Priority: Minor
> Fix For: 2.3.0, 2.1.10, 2.2.5
>
>
> if
> 'hbase.master.loadbalancer.class=org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer'
> and
> 'hbase.rsgroup.grouploadbalancer.class=org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer',
> The master server will aborted for IllegalThreadStateException.
> {code:java}
> 2020-04-09 11:24:26,142 ERROR [master/xx.xx.xx.xx:16000:becomeActiveMaster]
> master.HMaster: Failed to become active master
> java.lang.IllegalThreadStateException
> at java.lang.Thread.start(Thread.java:705)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl.start(RSGroupInfoManagerImpl.java:172)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.initialize(RSGroupBasedLoadBalancer.java:417)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.initialize(RSGroupBasedLoadBalancer.java:430)
> at
> org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:968)
> at
> org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2275)
> at
> org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:584)
> at java.lang.Thread.run(Thread.java:745)
> 2020-04-09 11:24:26,144 ERROR [master/xx.xx.xx.xx:16000:becomeActiveMaster]
> master.HMaster: Master server abort: loaded coprocessors are:
> [org.apache.hadoop.hbase.security.access.AccessController,
> org.apache.hadoop.hbase.quotas.MasterQuotasObserver,
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint]{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1534: HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal
Apache-HBase commented on issue #1534: HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal URL: https://github.com/apache/hbase/pull/1534#issuecomment-614961646 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 15s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 27s | branch-2 passed | | +1 :green_heart: | compile | 1m 11s | branch-2 passed | | +1 :green_heart: | shadedjars | 5m 46s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 42s | hbase-server in branch-2 failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 16s | the patch passed | | +1 :green_heart: | compile | 1m 8s | the patch passed | | +1 :green_heart: | javac | 1m 8s | the patch passed | | +1 :green_heart: | shadedjars | 5m 45s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 39s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 180m 32s | hbase-server in the patch passed. | | | | 207m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1534/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1534 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 73534d750a78 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 3f43b9e349 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1534/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1534/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1534/1/testReport/ | | Max. process+thread count | 3009 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1534/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1534: HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal
Apache-HBase commented on issue #1534: HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal URL: https://github.com/apache/hbase/pull/1534#issuecomment-614943310 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 33s | branch-2 passed | | +1 :green_heart: | compile | 0m 55s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 28s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 14s | the patch passed | | +1 :green_heart: | compile | 0m 55s | the patch passed | | +1 :green_heart: | javac | 0m 55s | the patch passed | | +1 :green_heart: | shadedjars | 4m 29s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 34s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 131m 40s | hbase-server in the patch failed. | | | | 153m 6s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1534/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1534 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux df5e2751b340 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 3f43b9e349 | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1534/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1534/1/testReport/ | | Max. process+thread count | 3315 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1534/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1533: HBASE-24148 Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs.
Apache-HBase commented on issue #1533: HBASE-24148 Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs. URL: https://github.com/apache/hbase/pull/1533#issuecomment-614940859 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 50s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-1 Compile Tests _ | | +0 :ok: | mvndep | 1m 49s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 7m 51s | branch-1 passed | | +1 :green_heart: | compile | 1m 44s | branch-1 passed with JDK v1.8.0_242 | | +1 :green_heart: | compile | 1m 44s | branch-1 passed with JDK v1.7.0_252 | | +1 :green_heart: | checkstyle | 5m 39s | branch-1 passed | | +1 :green_heart: | shadedjars | 3m 3s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 39s | branch-1 passed with JDK v1.8.0_242 | | +1 :green_heart: | javadoc | 5m 12s | branch-1 passed with JDK v1.7.0_252 | | +0 :ok: | spotbugs | 1m 30s | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 :x: | findbugs | 10m 39s | root in branch-1 has 1 extant findbugs warnings. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 28s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 1m 55s | the patch passed | | +1 :green_heart: | compile | 1m 39s | the patch passed with JDK v1.8.0_242 | | +1 :green_heart: | javac | 1m 39s | the patch passed | | +1 :green_heart: | compile | 1m 44s | the patch passed with JDK v1.7.0_252 | | -1 :x: | javac | 1m 44s | root-jdk1.7.0_252 with JDK v1.7.0_252 generated 116 new + 38 unchanged - 0 fixed = 154 total (was 38) | | +1 :green_heart: | checkstyle | 0m 30s | hbase-thrift: The patch generated 0 new + 38 unchanged - 1 fixed = 38 total (was 39) | | +1 :green_heart: | checkstyle | 4m 56s | root: The patch generated 0 new + 38 unchanged - 1 fixed = 38 total (was 39) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | -1 :x: | xml | 0m 0s | The patch has 2 ill-formed XML file(s). | | +1 :green_heart: | shadedjars | 2m 44s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 4m 54s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | +1 :green_heart: | javadoc | 2m 30s | the patch passed with JDK v1.8.0_242 | | +1 :green_heart: | javadoc | 5m 18s | the patch passed with JDK v1.7.0_252 | | +1 :green_heart: | findbugs | 12m 33s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 168m 12s | root in the patch failed. | | +1 :green_heart: | asflicense | 1m 0s | The patch does not generate ASF License warnings. | | | | 255m 24s | | | Reason | Tests | |---:|:--| | XML | Parsing Error(s): | | | hbase-thrift/pom.xml | | | pom.xml | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1533/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1533 | | Optional Tests | dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle | | uname | Linux a6f8a89504c4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1533/out/precommit/personality/provided.sh | | git revision | branch-1 / d4b64c2 | | Default Java | 1.7.0_252 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252 | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1533/1/artifact/out/branch-findbugs-root-warnings.html | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1533/1/artifact/out/diff-compile-javac-root-jdk1.7.0_252.txt | | xml | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1533/1/artifact/out/xml.txt | | unit | https://buil
[GitHub] [hbase] Apache-HBase commented on issue #1535: HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal
Apache-HBase commented on issue #1535: HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal URL: https://github.com/apache/hbase/pull/1535#issuecomment-614941034 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.3 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 2s | branch-2.3 passed | | +1 :green_heart: | compile | 1m 3s | branch-2.3 passed | | +1 :green_heart: | shadedjars | 5m 48s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 42s | hbase-server in branch-2.3 failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 50s | the patch passed | | +1 :green_heart: | compile | 1m 2s | the patch passed | | +1 :green_heart: | javac | 1m 2s | the patch passed | | +1 :green_heart: | shadedjars | 5m 11s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 38s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 120m 22s | hbase-server in the patch passed. | | | | 145m 22s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1535 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux e8cc6519a1dd 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / e1dcc7bdca | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/testReport/ | | Max. process+thread count | 4010 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1535: HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal
Apache-HBase commented on issue #1535: HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal URL: https://github.com/apache/hbase/pull/1535#issuecomment-614940316 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 50s | Docker mode activated. | | -0 :warning: | yetus | 0m 8s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.3 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 45s | branch-2.3 passed | | +1 :green_heart: | compile | 0m 55s | branch-2.3 passed | | +1 :green_heart: | shadedjars | 4m 27s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | branch-2.3 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 12s | the patch passed | | +1 :green_heart: | compile | 0m 56s | the patch passed | | +1 :green_heart: | javac | 0m 56s | the patch passed | | +1 :green_heart: | shadedjars | 4m 26s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 121m 9s | hbase-server in the patch passed. | | | | 143m 21s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1535 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux ebd9c2d2512f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / e1dcc7bdca | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/testReport/ | | Max. process+thread count | 3842 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-24202) Nightly CI's USE_YETUS_PRERELEASE feature is broken
Nick Dimiduk created HBASE-24202:
Summary: Nightly CI's USE_YETUS_PRERELEASE feature is broken
Key: HBASE-24202
URL: https://issues.apache.org/jira/browse/HBASE-24202
Project: HBase
Issue Type: Task
Components: build
Reporter: Nick Dimiduk
I tried kicking off a
[build|https://builds.apache.org/blue/organizations/jenkins/HBase%20Nightly/detail/master/1701/pipeline/]
with the latest Yetus today, only to find
{noformat}
[2020-04-16T20:54:09.742Z] bash:
/home/jenkins/jenkins-slave/workspace/HBase_Nightly_master/yetus-git/precommit/test-patch.sh:
No such file or directory
{noformat}
Looks like we don't adjust the path to test-patch.sh based on working from a
source tarball vs. a release tarball.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase-operator-tools] joshelser commented on a change in pull request #55: HBASE-24039
joshelser commented on a change in pull request #55: HBASE-24039
URL:
https://github.com/apache/hbase-operator-tools/pull/55#discussion_r409883440
##
File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java
##
@@ -133,6 +143,19 @@ void checkHBCKSupport(ClusterConnection connection,
String cmd, String ... suppo
}
}
+ void checkFunctionSupported(ClusterConnection connection, String cmd) throws
IOException {
+if (skipCheck) {
+ LOG.info("Skipped {} command version check; 'skip' set", cmd);
+ return;
+}
+List methods =
Arrays.asList(connection.getHbck().getClass().getDeclaredMethods());
Review comment:
We see this pretty often, actually. Folks will remain on a release line,
either upstream releases or downstream re-packagings of those releases.
It would definitely be an improvement to get the discrete list of things
that the server supports rather than guessing based on a version string. Like
you say, that makes for good follow-on work.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1511: HBASE-24139 : Balancer should avoid leaving idle region servers
Apache-HBase commented on issue #1511: HBASE-24139 : Balancer should avoid leaving idle region servers URL: https://github.com/apache/hbase/pull/1511#issuecomment-614913281 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 56s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 32s | master passed | | +1 :green_heart: | compile | 1m 26s | master passed | | +1 :green_heart: | shadedjars | 6m 37s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 54s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 10s | the patch passed | | +1 :green_heart: | compile | 1m 27s | the patch passed | | +1 :green_heart: | javac | 1m 27s | the patch passed | | +1 :green_heart: | shadedjars | 6m 13s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 47s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 202m 27s | hbase-server in the patch passed. | | | | 234m 17s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1511/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1511 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux f9fee70d4695 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b7a6d36be4 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1511/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1511/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1511/4/testReport/ | | Max. process+thread count | 3123 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1511/4/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1535: HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal
Apache-HBase commented on issue #1535: HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal URL: https://github.com/apache/hbase/pull/1535#issuecomment-614901788 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 49s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2.3 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 52s | branch-2.3 passed | | +1 :green_heart: | checkstyle | 1m 13s | branch-2.3 passed | | +1 :green_heart: | spotbugs | 2m 7s | branch-2.3 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 29s | the patch passed | | -0 :warning: | checkstyle | 1m 13s | hbase-server: The patch generated 5 new + 2 unchanged - 0 fixed = 7 total (was 2) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 45s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 2m 31s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. | | | | 38m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1535 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 428bc91ecd30 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / e1dcc7bdca | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24158) [Flakey Tests] TestAsyncTableGetMultiThreaded
[
https://issues.apache.org/jira/browse/HBASE-24158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085268#comment-17085268
]
Hudson commented on HBASE-24158:
Results for branch master
[build #1701 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1701/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1701/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1701/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1701/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1701/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [Flakey Tests] TestAsyncTableGetMultiThreaded
> -
>
> Key: HBASE-24158
> URL: https://issues.apache.org/jira/browse/HBASE-24158
> Project: HBase
> Issue Type: Bug
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.5
>
> Attachments:
> 0001-HBASE-24158-Flakey-Tests-TestAsyncTableGetMultiThrea.addendum.patch,
> 0001-HBASE-24158-Flakey-Tests-TestAsyncTableGetMultiThrea.patch
>
>
> I've already cut down the number of threads used by this test but it failed
> in nightly last night unable to close out its xml and locally it failed too
> in a run overnight. I ran it under harness and it seems well-behaved. It
> doesn't use much memory -- 700MB -- and thread counts are usual (~450). It
> does use near 100% CPU which is a little unusual. Otherwise, looks fine.
> Let me keep an eye on it. Could down the thread count more and use less
> processes... this makes it use less CPU. There does seems a bunch of overlap
> with tests done elsewhere.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24197) TestHttpServer.testBindAddress failure with latest jetty
[
https://issues.apache.org/jira/browse/HBASE-24197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085263#comment-17085263
]
Hudson commented on HBASE-24197:
Results for branch master
[build #1701 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1701/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1701/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1701/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1701/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1701/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> TestHttpServer.testBindAddress failure with latest jetty
>
>
> Key: HBASE-24197
> URL: https://issues.apache.org/jira/browse/HBASE-24197
> Project: HBase
> Issue Type: Bug
>Affects Versions: master
>Reporter: Istvan Toth
>Assignee: Istvan Toth
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.4.0, 2.2.5
>
>
> The latest jetty version (tested with 9.4.28.v20200408 which is not included
> in HBase yet) wraps BindException into an IOException when it fails to bind
> to a port.
> This breaks HttpServer's findPort functionality, which manifests in
> TestHttpServer.testBindAddress failing.
> The proposed patch handles both the old and the new jetty behaviour correctly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24170) Remove hadoop-2.0 profile
[
https://issues.apache.org/jira/browse/HBASE-24170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085264#comment-17085264
]
Hudson commented on HBASE-24170:
Results for branch master
[build #1701 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1701/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1701/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1701/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1701/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1701/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove hadoop-2.0 profile
> -
>
> Key: HBASE-24170
> URL: https://issues.apache.org/jira/browse/HBASE-24170
> Project: HBase
> Issue Type: Sub-task
> Components: hadoop2, hadoop3, pom, scripts
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24186) RegionMover ignores replicationId
[
https://issues.apache.org/jira/browse/HBASE-24186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085266#comment-17085266
]
Hudson commented on HBASE-24186:
Results for branch master
[build #1701 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1701/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1701/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1701/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1701/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1701/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> RegionMover ignores replicationId
> -
>
> Key: HBASE-24186
> URL: https://issues.apache.org/jira/browse/HBASE-24186
> Project: HBase
> Issue Type: Bug
> Components: read replicas
>Reporter: Szabolcs Bukros
>Assignee: Szabolcs Bukros
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.1.10, 2.2.5
>
>
> When RegionMover looks up which rs hosts a region, it does this based on
> startRowKey. When read replication is enabled this might not return the
> expected region's data and this can prevent the moving of these regions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24194) Refactor BufferedEncodedSeeker anonymous classes to named inner class
[
https://issues.apache.org/jira/browse/HBASE-24194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085265#comment-17085265
]
Hudson commented on HBASE-24194:
Results for branch master
[build #1701 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1701/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1701/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1701/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1701/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1701/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Refactor BufferedEncodedSeeker anonymous classes to named inner class
> -
>
> Key: HBASE-24194
> URL: https://issues.apache.org/jira/browse/HBASE-24194
> Project: HBase
> Issue Type: Task
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.7.0
>
>
> BufferedEncodedSeeker has multiple anonymous inner sub-classes with huge
> code. Better to refactor them to named inner classes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24195) Admin.getRegionServers() should return live servers excluding decom RS optionally
[
https://issues.apache.org/jira/browse/HBASE-24195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085267#comment-17085267
]
Hudson commented on HBASE-24195:
Results for branch master
[build #1701 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1701/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1701/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1701/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1701/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1701/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Admin.getRegionServers() should return live servers excluding decom RS
> optionally
> -
>
> Key: HBASE-24195
> URL: https://issues.apache.org/jira/browse/HBASE-24195
> Project: HBase
> Issue Type: Improvement
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> Admin.getRegionServers() returns all live RS of the cluster. It should
> consider optionally excluding decommissioned RS for operators to get live
> non-decommissioned RS list from single API.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1534: HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal
Apache-HBase commented on issue #1534: HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal URL: https://github.com/apache/hbase/pull/1534#issuecomment-614899496 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 50s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 32s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 9s | branch-2 passed | | +1 :green_heart: | spotbugs | 1m 57s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 7s | the patch passed | | -0 :warning: | checkstyle | 1m 7s | hbase-server: The patch generated 5 new + 2 unchanged - 0 fixed = 7 total (was 2) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 5s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 2m 7s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 33m 15s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1534/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1534 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 5e29c4c19438 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 3f43b9e349 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1534/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1534/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1511: HBASE-24139 : Balancer should avoid leaving idle region servers
Apache-HBase commented on issue #1511: HBASE-24139 : Balancer should avoid leaving idle region servers URL: https://github.com/apache/hbase/pull/1511#issuecomment-614895530 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 5s | master passed | | +1 :green_heart: | compile | 1m 0s | master passed | | +1 :green_heart: | shadedjars | 5m 28s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 45s | the patch passed | | +1 :green_heart: | compile | 0m 58s | the patch passed | | +1 :green_heart: | javac | 0m 58s | the patch passed | | +1 :green_heart: | shadedjars | 5m 24s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 170m 10s | hbase-server in the patch passed. | | | | 194m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1511/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1511 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 0befb8d823d8 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b7a6d36be4 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1511/4/testReport/ | | Max. process+thread count | 3131 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1511/4/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1531: HBASE-24200 Upgrade to Yetus 0.12.0
Apache-HBase commented on issue #1531: HBASE-24200 Upgrade to Yetus 0.12.0 URL: https://github.com/apache/hbase/pull/1531#issuecomment-614887007 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 46s | master passed | | +1 :green_heart: | compile | 2m 20s | master passed | | +1 :green_heart: | shadedjars | 5m 5s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 3s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 21s | the patch passed | | +1 :green_heart: | compile | 2m 15s | the patch passed | | +1 :green_heart: | javac | 2m 15s | the patch passed | | +1 :green_heart: | shadedjars | 4m 57s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 59s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 151m 40s | root in the patch passed. | | | | 181m 19s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1531/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1531 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux c1f2d013b3f4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b7a6d36be4 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1531/2/testReport/ | | Max. process+thread count | 6825 (vs. ulimit of 12500) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1531/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1531: HBASE-24200 Upgrade to Yetus 0.12.0
Apache-HBase commented on issue #1531: HBASE-24200 Upgrade to Yetus 0.12.0 URL: https://github.com/apache/hbase/pull/1531#issuecomment-614885977 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 7s | master passed | | +1 :green_heart: | compile | 2m 40s | master passed | | +1 :green_heart: | shadedjars | 5m 3s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 20s | root in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 48s | the patch passed | | +1 :green_heart: | compile | 2m 42s | the patch passed | | +1 :green_heart: | javac | 2m 42s | the patch passed | | +1 :green_heart: | shadedjars | 5m 3s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 18s | root in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 152m 2s | root in the patch passed. | | | | 179m 22s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1531/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1531 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 956ab8ffcc2f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b7a6d36be4 | | Default Java | AdoptOpenJDK-11.0.6+10 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1531/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1531/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1531/2/testReport/ | | Max. process+thread count | 6270 (vs. ulimit of 12500) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1531/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23833) The relocated hadoop-thirdparty protobuf breaks HBase asyncwal
[
https://issues.apache.org/jira/browse/HBASE-23833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085247#comment-17085247
]
Wei-Chiu Chuang commented on HBASE-23833:
-
Opened PR #1534 and #1535 to get this into the respective branches. The
cherrypick are both clean.
I intend to get HBase 2.2 to support Hadoop 3.3.0. If not, I'd be equally happy
to see HBase 2.3 or 2.4 support Hadoop 3.3.0
> The relocated hadoop-thirdparty protobuf breaks HBase asyncwal
> --
>
> Key: HBASE-23833
> URL: https://issues.apache.org/jira/browse/HBASE-23833
> Project: HBase
> Issue Type: Bug
> Components: wal
>Affects Versions: 3.0.0
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Major
>
> Hadoop trunk (3.3.0) shaded protobuf and moved it to hadoop-thirdparty. As
> the result, hbase asyncwal fails to compile because asyncwal uses the
> Hadoop's protobuf objects.
> The following command
> {code}
> mvn clean install -Dhadoop.profile=3.0 -Dhadoop.version=3.3.0-SNAPSHOT
> {code}
> fails with the following error:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile
> (default-compile) on project hbase-server: Compilation failure: Compilation
> failure:
> [ERROR]
> /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputSaslHelper.java:[361,44]
> cannot access org.apache.hadoop.thirdparty.protobuf.MessageOrBuilder
> [ERROR] class file for
> org.apache.hadoop.thirdparty.protobuf.MessageOrBuilder not found
> [ERROR]
> /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputSaslHelper.java:[362,14]
> cannot access org.apache.hadoop.thirdparty.protobuf.GeneratedMessageV3
> [ERROR] class file for
> org.apache.hadoop.thirdparty.protobuf.GeneratedMessageV3 not found
> [ERROR]
> /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputSaslHelper.java:[366,16]
> cannot access org.apache.hadoop.thirdparty.protobuf.ByteString
> [ERROR] class file for org.apache.hadoop.thirdparty.protobuf.ByteString not
> found
> [ERROR]
> /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputSaslHelper.java:[375,12]
> cannot find symbol
> [ERROR] symbol: method
> writeDelimitedTo(org.apache.hbase.thirdparty.io.netty.buffer.ByteBufOutputStream)
> [ERROR] location: variable proto of type
> org.apache.hadoop.hdfs.protocol.proto.DataTransferProtos.DataTransferEncryptorMessageProto
> [ERROR]
> /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputSaslHelper.java:[702,81]
> incompatible types:
> org.apache.hadoop.hdfs.protocol.proto.DataTransferProtos.DataTransferEncryptorMessageProto
> cannot be converted to com.google.protobuf.MessageLite
> [ERROR]
> /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputHelper.java:[314,66]
> incompatible types:
> org.apache.hadoop.hdfs.protocol.proto.DataTransferProtos.BlockOpResponseProto
> cannot be converted to com.google.protobuf.MessageLite
> [ERROR]
> /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputHelper.java:[330,81]
> cannot access org.apache.hadoop.thirdparty.protobuf.ProtocolMessageEnum
> [ERROR] class file for
> org.apache.hadoop.thirdparty.protobuf.ProtocolMessageEnum not found
> [ERROR]
> /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputHelper.java:[380,10]
> cannot find symbol
> [ERROR] symbol: method
> writeDelimitedTo(org.apache.hbase.thirdparty.io.netty.buffer.ByteBufOutputStream)
> [ERROR] location: variable proto of type
> org.apache.hadoop.hdfs.protocol.proto.DataTransferProtos.OpWriteBlockProto
> [ERROR]
> /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputHelper.java:[422,77]
> cannot access org.apache.hadoop.thirdparty.protobuf.Descriptors
> [ERROR] class file for org.apache.hadoop.thirdparty.protobuf.Descriptors
> not found
> [ERROR]
> /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutput.java:[323,64]
> incompatible types:
> org.apache.hadoop.hdfs.protocol.proto.DataTransferProtos.PipelineAckProto
> cannot be converted to com.google.protobuf.MessageLite
> [ERROR]
> /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/SyncReplicationWALProvide
[GitHub] [hbase] jojochuang opened a new pull request #1535: HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal
jojochuang opened a new pull request #1535: HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal URL: https://github.com/apache/hbase/pull/1535 Cherrypick the commit to branch-2.3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] jojochuang opened a new pull request #1534: HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal
jojochuang opened a new pull request #1534: HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal URL: https://github.com/apache/hbase/pull/1534 Cherry pick this to branch-2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24195) Admin.getRegionServers() should return live servers excluding decom RS optionally
[
https://issues.apache.org/jira/browse/HBASE-24195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085227#comment-17085227
]
Hudson commented on HBASE-24195:
Results for branch branch-2.3
[build #37 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/37/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/37/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/37/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/37/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/37/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Admin.getRegionServers() should return live servers excluding decom RS
> optionally
> -
>
> Key: HBASE-24195
> URL: https://issues.apache.org/jira/browse/HBASE-24195
> Project: HBase
> Issue Type: Improvement
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> Admin.getRegionServers() returns all live RS of the cluster. It should
> consider optionally excluding decommissioned RS for operators to get live
> non-decommissioned RS list from single API.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24194) Refactor BufferedEncodedSeeker anonymous classes to named inner class
[
https://issues.apache.org/jira/browse/HBASE-24194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085225#comment-17085225
]
Hudson commented on HBASE-24194:
Results for branch branch-2.3
[build #37 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/37/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/37/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/37/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/37/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/37/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Refactor BufferedEncodedSeeker anonymous classes to named inner class
> -
>
> Key: HBASE-24194
> URL: https://issues.apache.org/jira/browse/HBASE-24194
> Project: HBase
> Issue Type: Task
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.7.0
>
>
> BufferedEncodedSeeker has multiple anonymous inner sub-classes with huge
> code. Better to refactor them to named inner classes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24158) [Flakey Tests] TestAsyncTableGetMultiThreaded
[
https://issues.apache.org/jira/browse/HBASE-24158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085228#comment-17085228
]
Hudson commented on HBASE-24158:
Results for branch branch-2.3
[build #37 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/37/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/37/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/37/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/37/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/37/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [Flakey Tests] TestAsyncTableGetMultiThreaded
> -
>
> Key: HBASE-24158
> URL: https://issues.apache.org/jira/browse/HBASE-24158
> Project: HBase
> Issue Type: Bug
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.5
>
> Attachments:
> 0001-HBASE-24158-Flakey-Tests-TestAsyncTableGetMultiThrea.addendum.patch,
> 0001-HBASE-24158-Flakey-Tests-TestAsyncTableGetMultiThrea.patch
>
>
> I've already cut down the number of threads used by this test but it failed
> in nightly last night unable to close out its xml and locally it failed too
> in a run overnight. I ran it under harness and it seems well-behaved. It
> doesn't use much memory -- 700MB -- and thread counts are usual (~450). It
> does use near 100% CPU which is a little unusual. Otherwise, looks fine.
> Let me keep an eye on it. Could down the thread count more and use less
> processes... this makes it use less CPU. There does seems a bunch of overlap
> with tests done elsewhere.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24186) RegionMover ignores replicationId
[
https://issues.apache.org/jira/browse/HBASE-24186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085226#comment-17085226
]
Hudson commented on HBASE-24186:
Results for branch branch-2.3
[build #37 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/37/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/37/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/37/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/37/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/37/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> RegionMover ignores replicationId
> -
>
> Key: HBASE-24186
> URL: https://issues.apache.org/jira/browse/HBASE-24186
> Project: HBase
> Issue Type: Bug
> Components: read replicas
>Reporter: Szabolcs Bukros
>Assignee: Szabolcs Bukros
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.1.10, 2.2.5
>
>
> When RegionMover looks up which rs hosts a region, it does this based on
> startRowKey. When read replication is enabled this might not return the
> expected region's data and this can prevent the moving of these regions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24151) [rsgroup] The master server aborted for IllegalThreadStateException
[
https://issues.apache.org/jira/browse/HBASE-24151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085224#comment-17085224
]
Hudson commented on HBASE-24151:
Results for branch branch-2.3
[build #37 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/37/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/37/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/37/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/37/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/37/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [rsgroup] The master server aborted for IllegalThreadStateException
>
>
> Key: HBASE-24151
> URL: https://issues.apache.org/jira/browse/HBASE-24151
> Project: HBase
> Issue Type: Bug
> Components: rsgroup
>Affects Versions: 2.3.0, 2.1.7, 2.2.3
>Reporter: kangkang.guo
>Assignee: kangkang.guo
>Priority: Minor
> Fix For: 2.3.0, 2.1.10, 2.2.5
>
>
> if
> 'hbase.master.loadbalancer.class=org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer'
> and
> 'hbase.rsgroup.grouploadbalancer.class=org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer',
> The master server will aborted for IllegalThreadStateException.
> {code:java}
> 2020-04-09 11:24:26,142 ERROR [master/xx.xx.xx.xx:16000:becomeActiveMaster]
> master.HMaster: Failed to become active master
> java.lang.IllegalThreadStateException
> at java.lang.Thread.start(Thread.java:705)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl.start(RSGroupInfoManagerImpl.java:172)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.initialize(RSGroupBasedLoadBalancer.java:417)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.initialize(RSGroupBasedLoadBalancer.java:430)
> at
> org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:968)
> at
> org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2275)
> at
> org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:584)
> at java.lang.Thread.run(Thread.java:745)
> 2020-04-09 11:24:26,144 ERROR [master/xx.xx.xx.xx:16000:becomeActiveMaster]
> master.HMaster: Master server abort: loaded coprocessors are:
> [org.apache.hadoop.hbase.security.access.AccessController,
> org.apache.hadoop.hbase.quotas.MasterQuotasObserver,
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint]{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24197) TestHttpServer.testBindAddress failure with latest jetty
[
https://issues.apache.org/jira/browse/HBASE-24197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085223#comment-17085223
]
Hudson commented on HBASE-24197:
Results for branch branch-2.3
[build #37 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/37/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/37/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/37/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/37/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/37/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> TestHttpServer.testBindAddress failure with latest jetty
>
>
> Key: HBASE-24197
> URL: https://issues.apache.org/jira/browse/HBASE-24197
> Project: HBase
> Issue Type: Bug
>Affects Versions: master
>Reporter: Istvan Toth
>Assignee: Istvan Toth
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.4.0, 2.2.5
>
>
> The latest jetty version (tested with 9.4.28.v20200408 which is not included
> in HBase yet) wraps BindException into an IOException when it fails to bind
> to a port.
> This breaks HttpServer's findPort functionality, which manifests in
> TestHttpServer.testBindAddress failing.
> The proposed patch handles both the old and the new jetty behaviour correctly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] ndimiduk commented on a change in pull request #1527: HBASE-24143 [JDK11] Switch default garbage collector from CMS
ndimiduk commented on a change in pull request #1527: HBASE-24143 [JDK11]
Switch default garbage collector from CMS
URL: https://github.com/apache/hbase/pull/1527#discussion_r409811933
##
File path: bin/hbase
##
@@ -136,6 +136,21 @@ if [ -f "$HBASE_HOME/conf/hbase-env-$COMMAND.sh" ]; then
. "$HBASE_HOME/conf/hbase-env-$COMMAND.sh"
fi
+# establish a default value for HBASE_OPTS if it's not already set. For now,
+# all we set is the garbage collector.
+if [ -z "${HBASE_OPTS}" ] ; then
+ major_version_number="$(parse_java_major_version "$(read_java_version)")"
+ case "$major_version_number" in
+ 8|9|10)
+HBASE_OPTS="-XX:+UseConcMarkSweepGC"
+;;
+ 11|*)
+HBASE_OPTS="-XX:+UseG1GC"
Review comment:
The idea is to be explicit with the collector selection.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1527: HBASE-24143 [JDK11] Switch default garbage collector from CMS
ndimiduk commented on a change in pull request #1527: HBASE-24143 [JDK11]
Switch default garbage collector from CMS
URL: https://github.com/apache/hbase/pull/1527#discussion_r409815532
##
File path: bin/hbase-config.sh
##
@@ -168,3 +168,27 @@ if [ -z "$JAVA_HOME" ]; then
EOF
exit 1
fi
+
+function read_java_version() {
+ properties="$("${JAVA_HOME}/bin/java" -XshowSettings:properties -version
2>&1)"
+ #shellcheck disable=SC2016 # shellcheck cannot see through "${AWK}"
Review comment:
Oh really?
I think there's more to it than that. I added on this patch but I still get
the SC2016 warning.
```
modified bin/hbase-config.sh
@@ -130,6 +130,7 @@ fi
# Source the hbase-env.sh. Will have JAVA_HOME defined.
# HBASE-7817 - Source the hbase-env.sh only if it has not already been
done. HBASE_ENV_INIT keeps track of it.
if [ -z "$HBASE_ENV_INIT" ] && [ -f "${HBASE_CONF_DIR}/hbase-env.sh" ]; then
+ # shellcheck source=../conf/hbase-env.sh
. "${HBASE_CONF_DIR}/hbase-env.sh"
export HBASE_ENV_INIT="true"
fi
@@ -171,7 +172,6 @@ fi
function read_java_version() {
properties="$("${JAVA_HOME}/bin/java" -XshowSettings:properties -version
2>&1)"
- #shellcheck disable=SC2016 # shellcheck cannot see through "${AWK}"
echo "${properties}" | "${GREP}" java.runtime.version | head -1 |
"${AWK}" 'BEGIN {FS = " = "} ; {print $NF}'
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-24151) [rsgroup] The master server aborted for IllegalThreadStateException
[
https://issues.apache.org/jira/browse/HBASE-24151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085211#comment-17085211
]
Hudson commented on HBASE-24151:
Results for branch branch-2
[build #2611 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [rsgroup] The master server aborted for IllegalThreadStateException
>
>
> Key: HBASE-24151
> URL: https://issues.apache.org/jira/browse/HBASE-24151
> Project: HBase
> Issue Type: Bug
> Components: rsgroup
>Affects Versions: 2.3.0, 2.1.7, 2.2.3
>Reporter: kangkang.guo
>Assignee: kangkang.guo
>Priority: Minor
> Fix For: 2.3.0, 2.1.10, 2.2.5
>
>
> if
> 'hbase.master.loadbalancer.class=org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer'
> and
> 'hbase.rsgroup.grouploadbalancer.class=org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer',
> The master server will aborted for IllegalThreadStateException.
> {code:java}
> 2020-04-09 11:24:26,142 ERROR [master/xx.xx.xx.xx:16000:becomeActiveMaster]
> master.HMaster: Failed to become active master
> java.lang.IllegalThreadStateException
> at java.lang.Thread.start(Thread.java:705)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl.start(RSGroupInfoManagerImpl.java:172)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.initialize(RSGroupBasedLoadBalancer.java:417)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.initialize(RSGroupBasedLoadBalancer.java:430)
> at
> org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:968)
> at
> org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2275)
> at
> org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:584)
> at java.lang.Thread.run(Thread.java:745)
> 2020-04-09 11:24:26,144 ERROR [master/xx.xx.xx.xx:16000:becomeActiveMaster]
> master.HMaster: Master server abort: loaded coprocessors are:
> [org.apache.hadoop.hbase.security.access.AccessController,
> org.apache.hadoop.hbase.quotas.MasterQuotasObserver,
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint]{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24148) Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs.
[
https://issues.apache.org/jira/browse/HBASE-24148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085208#comment-17085208
]
Hudson commented on HBASE-24148:
Results for branch branch-2
[build #2611 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs.
> --
>
> Key: HBASE-24148
> URL: https://issues.apache.org/jira/browse/HBASE-24148
> Project: HBase
> Issue Type: Improvement
> Components: Thrift
>Affects Versions: 3.0.0
>Reporter: Tamas Penzes
>Assignee: Tamas Penzes
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 1.7.0, 2.4.0, 2.2.5
>
>
> In Apache Thrift all versions up to and including 0.12.0, a server or client
> may run into an endless loop when feed with specific input data. Because the
> issue had already been partially fixed in version 0.11.0, depending on the
> installed version it affects only certain language bindings.
> To be on the safe side, we could update to 0.13.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24183) [flakey test] replication.TestAddToSerialReplicationPeer
[
https://issues.apache.org/jira/browse/HBASE-24183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085207#comment-17085207
]
Hudson commented on HBASE-24183:
Results for branch branch-2
[build #2611 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [flakey test] replication.TestAddToSerialReplicationPeer
>
>
> Key: HBASE-24183
> URL: https://issues.apache.org/jira/browse/HBASE-24183
> Project: HBase
> Issue Type: Test
> Components: Client
>Affects Versions: 3.0.0, 2.3.0, 2.4.0
>Reporter: Huaxiang Sun
>Assignee: Hua Xiang
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> From both 2.3 and branch-2 flaky test board, it constantly runs into the
> following flaky:
>
> {code:java}
> org.apache.hadoop.hbase.replication.TestAddToSerialReplicationPeer.testAddToSerialPeerFailing
> for the past 1 build (Since #6069 )Took 15 sec.Error MessageSequence id go
> backwards from 122 to 24Stacktracejava.lang.AssertionError: Sequence id go
> backwards from 122 to 24
> at
> org.apache.hadoop.hbase.replication.TestAddToSerialReplicationPeer.testAddToSerialPeer(TestAddToSerialReplicationPeer.java:176)
> Standard Output{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24194) Refactor BufferedEncodedSeeker anonymous classes to named inner class
[
https://issues.apache.org/jira/browse/HBASE-24194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085212#comment-17085212
]
Hudson commented on HBASE-24194:
Results for branch branch-2
[build #2611 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Refactor BufferedEncodedSeeker anonymous classes to named inner class
> -
>
> Key: HBASE-24194
> URL: https://issues.apache.org/jira/browse/HBASE-24194
> Project: HBase
> Issue Type: Task
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.7.0
>
>
> BufferedEncodedSeeker has multiple anonymous inner sub-classes with huge
> code. Better to refactor them to named inner classes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24175) [Flakey Tests] TestSecureExportSnapshot FileNotFoundException
[
https://issues.apache.org/jira/browse/HBASE-24175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085209#comment-17085209
]
Hudson commented on HBASE-24175:
Results for branch branch-2
[build #2611 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [Flakey Tests] TestSecureExportSnapshot FileNotFoundException
> -
>
> Key: HBASE-24175
> URL: https://issues.apache.org/jira/browse/HBASE-24175
> Project: HBase
> Issue Type: Sub-task
> Components: flakies
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.5
>
> Attachments:
> 0001-HBASE-24175-Flakey-Tests-TestSecureExportSnapshot-Fi.addendum.patch,
> 0001-HBASE-24175-Flakey-Tests-TestSecureExportSnapshot-Fi.addendum2.patch,
> 0001-HBASE-24175-Flakey-Tests-TestSecureExportSnapshot-Fi.patch
>
>
> Why we writing '/tmp' dir?
> {code}
> Error Message
> org.apache.hadoop.service.ServiceStateException:
> java.io.FileNotFoundException: File
> file:/tmp/hadoop-yarn-jenkins/node-attribute/nodeattribute.mirror.writing
> does not exist
> Stacktrace
> org.apache.hadoop.yarn.exceptions.YarnRuntimeException:
> org.apache.hadoop.service.ServiceStateException:
> java.io.FileNotFoundException: File
> file:/tmp/hadoop-yarn-jenkins/node-attribute/nodeattribute.mirror.writing
> does not exist
> at
> org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot.setUpBeforeClass(TestSecureExportSnapshot.java:56)
> Caused by: org.apache.hadoop.service.ServiceStateException:
> java.io.FileNotFoundException: File
> file:/tmp/hadoop-yarn-jenkins/node-attribute/nodeattribute.mirror.writing
> does not exist
> at
> org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot.setUpBeforeClass(TestSecureExportSnapshot.java:56)
> Caused by: java.io.FileNotFoundException: File
> file:/tmp/hadoop-yarn-jenkins/node-attribute/nodeattribute.mirror.writing
> does not exist
> at
> org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot.setUpBeforeClass(TestSecureExportSnapshot.java:56)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24195) Admin.getRegionServers() should return live servers excluding decom RS optionally
[
https://issues.apache.org/jira/browse/HBASE-24195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085214#comment-17085214
]
Hudson commented on HBASE-24195:
Results for branch branch-2
[build #2611 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Admin.getRegionServers() should return live servers excluding decom RS
> optionally
> -
>
> Key: HBASE-24195
> URL: https://issues.apache.org/jira/browse/HBASE-24195
> Project: HBase
> Issue Type: Improvement
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> Admin.getRegionServers() returns all live RS of the cluster. It should
> consider optionally excluding decommissioned RS for operators to get live
> non-decommissioned RS list from single API.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24158) [Flakey Tests] TestAsyncTableGetMultiThreaded
[
https://issues.apache.org/jira/browse/HBASE-24158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085215#comment-17085215
]
Hudson commented on HBASE-24158:
Results for branch branch-2
[build #2611 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [Flakey Tests] TestAsyncTableGetMultiThreaded
> -
>
> Key: HBASE-24158
> URL: https://issues.apache.org/jira/browse/HBASE-24158
> Project: HBase
> Issue Type: Bug
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.5
>
> Attachments:
> 0001-HBASE-24158-Flakey-Tests-TestAsyncTableGetMultiThrea.addendum.patch,
> 0001-HBASE-24158-Flakey-Tests-TestAsyncTableGetMultiThrea.patch
>
>
> I've already cut down the number of threads used by this test but it failed
> in nightly last night unable to close out its xml and locally it failed too
> in a run overnight. I ran it under harness and it seems well-behaved. It
> doesn't use much memory -- 700MB -- and thread counts are usual (~450). It
> does use near 100% CPU which is a little unusual. Otherwise, looks fine.
> Let me keep an eye on it. Could down the thread count more and use less
> processes... this makes it use less CPU. There does seems a bunch of overlap
> with tests done elsewhere.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24197) TestHttpServer.testBindAddress failure with latest jetty
[
https://issues.apache.org/jira/browse/HBASE-24197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085210#comment-17085210
]
Hudson commented on HBASE-24197:
Results for branch branch-2
[build #2611 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> TestHttpServer.testBindAddress failure with latest jetty
>
>
> Key: HBASE-24197
> URL: https://issues.apache.org/jira/browse/HBASE-24197
> Project: HBase
> Issue Type: Bug
>Affects Versions: master
>Reporter: Istvan Toth
>Assignee: Istvan Toth
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.4.0, 2.2.5
>
>
> The latest jetty version (tested with 9.4.28.v20200408 which is not included
> in HBase yet) wraps BindException into an IOException when it fails to bind
> to a port.
> This breaks HttpServer's findPort functionality, which manifests in
> TestHttpServer.testBindAddress failing.
> The proposed patch handles both the old and the new jetty behaviour correctly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24186) RegionMover ignores replicationId
[
https://issues.apache.org/jira/browse/HBASE-24186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085213#comment-17085213
]
Hudson commented on HBASE-24186:
Results for branch branch-2
[build #2611 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2611/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> RegionMover ignores replicationId
> -
>
> Key: HBASE-24186
> URL: https://issues.apache.org/jira/browse/HBASE-24186
> Project: HBase
> Issue Type: Bug
> Components: read replicas
>Reporter: Szabolcs Bukros
>Assignee: Szabolcs Bukros
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.1.10, 2.2.5
>
>
> When RegionMover looks up which rs hosts a region, it does this based on
> startRowKey. When read replication is enabled this might not return the
> expected region's data and this can prevent the moving of these regions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] busbey commented on a change in pull request #1527: HBASE-24143 [JDK11] Switch default garbage collector from CMS
busbey commented on a change in pull request #1527: HBASE-24143 [JDK11] Switch
default garbage collector from CMS
URL: https://github.com/apache/hbase/pull/1527#discussion_r409806498
##
File path: bin/hbase-config.sh
##
@@ -168,3 +168,27 @@ if [ -z "$JAVA_HOME" ]; then
EOF
exit 1
fi
+
+function read_java_version() {
+ properties="$("${JAVA_HOME}/bin/java" -XshowSettings:properties -version
2>&1)"
+ #shellcheck disable=SC2016 # shellcheck cannot see through "${AWK}"
Review comment:
nit, but this usually means we didn't tell shellcheck how to source some
file we presume is present in the environment. in this case hbase-env. it'd be
nice if we fixed that, but I don't think it needs to be your problem in this PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1527: HBASE-24143 [JDK11] Switch default garbage collector from CMS
busbey commented on a change in pull request #1527: HBASE-24143 [JDK11] Switch
default garbage collector from CMS
URL: https://github.com/apache/hbase/pull/1527#discussion_r409804666
##
File path: bin/hbase
##
@@ -136,6 +136,21 @@ if [ -f "$HBASE_HOME/conf/hbase-env-$COMMAND.sh" ]; then
. "$HBASE_HOME/conf/hbase-env-$COMMAND.sh"
fi
+# establish a default value for HBASE_OPTS if it's not already set. For now,
+# all we set is the garbage collector.
+if [ -z "${HBASE_OPTS}" ] ; then
+ major_version_number="$(parse_java_major_version "$(read_java_version)")"
+ case "$major_version_number" in
+ 8|9|10)
+HBASE_OPTS="-XX:+UseConcMarkSweepGC"
+;;
+ 11|*)
+HBASE_OPTS="-XX:+UseG1GC"
Review comment:
G1GC is the default, why aren't we just leaving this out?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] apurtell commented on issue #1509: HBASE-24182 log when the region is set to closing status
apurtell commented on issue #1509: HBASE-24182 log when the region is set to closing status URL: https://github.com/apache/hbase/pull/1509#issuecomment-614851524 @virajjasani No strong opinion from me but the one new INFO level log inline with other logging seems fine. The close journal is printed after the fact and so is a bit confusing if you are sorting log lines chronologically. Sure, overall the logging is redundant. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1511: HBASE-24139 : Balancer should avoid leaving idle region servers
busbey commented on a change in pull request #1511: HBASE-24139 : Balancer
should avoid leaving idle region servers
URL: https://github.com/apache/hbase/pull/1511#discussion_r409793644
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java
##
@@ -1223,6 +1227,20 @@ protected boolean
areSomeRegionReplicasColocated(Cluster c) {
return false;
}
+ protected final synchronized boolean idleRegionExist(Cluster c){
Review comment:
why is this synchronized?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] apurtell commented on issue #1533: HBASE-24148 Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs.
apurtell commented on issue #1533: HBASE-24148 Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs. URL: https://github.com/apache/hbase/pull/1533#issuecomment-614842529 Local results FWIW [INFO] --- [INFO] T E S T S [INFO] --- [INFO] Running org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandlerWithReadOnly [INFO] Tests run: 15, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.724 s - in org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandlerWithReadOnly [INFO] Running org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler [INFO] Tests run: 30, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 48.375 s - in org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler [INFO] Running org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandlerWithLabels [INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.408 s - in org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandlerWithLabels [INFO] Running org.apache.hadoop.hbase.thrift.TestCallQueue [INFO] Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.212 s - in org.apache.hadoop.hbase.thrift.TestCallQueue [INFO] Running org.apache.hadoop.hbase.thrift.TestThriftHttpServer [INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.943 s - in org.apache.hadoop.hbase.thrift.TestThriftHttpServer [INFO] Running org.apache.hadoop.hbase.thrift.TestThriftServer [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 80.47 s - in org.apache.hadoop.hbase.thrift.TestThriftServer [INFO] Running org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine [INFO] Tests run: 32, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 51.129 s - in org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine [INFO] [INFO] Results: [INFO] [INFO] Tests run: 110, Failures: 0, Errors: 0, Skipped: 0 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1440: HBASE-23113: Improve and add additional Netty configuration for RPC.
ndimiduk commented on issue #1440: HBASE-23113: Improve and add additional Netty configuration for RPC. URL: https://github.com/apache/hbase/pull/1440#issuecomment-614836602 > Failures look related. Complaint about netty on construction of RegionServer. @markrmiller you see the comment above? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] apurtell commented on issue #1533: HBASE-24148 Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs.
apurtell commented on issue #1533: HBASE-24148 Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs. URL: https://github.com/apache/hbase/pull/1533#issuecomment-614835493 I need to add an exclusion to libthrift to fix an assembly enforcer error. Pushing an update in a sec. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-24201) Fix CI builds on branch-2.2
[
https://issues.apache.org/jira/browse/HBASE-24201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-24201:
-
Summary: Fix CI builds on branch-2.2 (was: Fix PR builds on branch-2.2)
> Fix CI builds on branch-2.2
> ---
>
> Key: HBASE-24201
> URL: https://issues.apache.org/jira/browse/HBASE-24201
> Project: HBase
> Issue Type: Task
> Components: build
>Affects Versions: 2.2.5
>Reporter: Nick Dimiduk
>Priority: Major
>
> From a recent [PR
> build|https://builds.apache.org/blue/organizations/jenkins/HBase-PreCommit-GitHub-PR/detail/PR-1532/1/pipeline/]
> {noformat}
> [2020-04-16T18:43:21.548Z] Setting up ruby2.3 (2.3.3-1+deb9u7) ...
> [2020-04-16T18:43:21.548Z] Setting up ruby2.3-dev:amd64 (2.3.3-1+deb9u7) ...
> [2020-04-16T18:43:21.548Z] Setting up ruby-dev:amd64 (1:2.3.3) ...
> [2020-04-16T18:43:21.548Z] Setting up ruby (1:2.3.3) ...
> [2020-04-16T18:43:22.261Z] Processing triggers for libc-bin (2.24-11+deb9u3)
> ...
> [2020-04-16T18:43:22.975Z] Successfully installed rake-13.0.1
> [2020-04-16T18:43:22.975Z] Building native extensions. This could take a
> while...
> [2020-04-16T18:43:25.277Z] ERROR: Error installing rubocop:
> [2020-04-16T18:43:25.277Z]rubocop requires Ruby version >= 2.4.0.
> {noformat}
> Looks like the Dockerfile on branch-2.2 has bit-rot. I suspect package
> versions are partially pinned or not pinned at all: the rubocop version has
> incremented by ruby version has not.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (HBASE-24201) Fix PR builds on branch-2.2
Nick Dimiduk created HBASE-24201:
Summary: Fix PR builds on branch-2.2
Key: HBASE-24201
URL: https://issues.apache.org/jira/browse/HBASE-24201
Project: HBase
Issue Type: Task
Components: build
Affects Versions: 2.2.5
Reporter: Nick Dimiduk
>From a recent [PR
>build|https://builds.apache.org/blue/organizations/jenkins/HBase-PreCommit-GitHub-PR/detail/PR-1532/1/pipeline/]
{noformat}
[2020-04-16T18:43:21.548Z] Setting up ruby2.3 (2.3.3-1+deb9u7) ...
[2020-04-16T18:43:21.548Z] Setting up ruby2.3-dev:amd64 (2.3.3-1+deb9u7) ...
[2020-04-16T18:43:21.548Z] Setting up ruby-dev:amd64 (1:2.3.3) ...
[2020-04-16T18:43:21.548Z] Setting up ruby (1:2.3.3) ...
[2020-04-16T18:43:22.261Z] Processing triggers for libc-bin (2.24-11+deb9u3) ...
[2020-04-16T18:43:22.975Z] Successfully installed rake-13.0.1
[2020-04-16T18:43:22.975Z] Building native extensions. This could take a
while...
[2020-04-16T18:43:25.277Z] ERROR: Error installing rubocop:
[2020-04-16T18:43:25.277Z] rubocop requires Ruby version >= 2.4.0.
{noformat}
Looks like the Dockerfile on branch-2.2 has bit-rot. I suspect package versions
are partially pinned or not pinned at all: the rubocop version has incremented
by ruby version has not.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] apurtell commented on issue #1532: HBASE-24148 Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs.
apurtell commented on issue #1532: HBASE-24148 Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs. URL: https://github.com/apache/hbase/pull/1532#issuecomment-614834098 Thanks @ndimiduk We have prioritized CVE fixes over compatibility usually (always?) and should continue to do so IMHO This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] apurtell merged pull request #1532: HBASE-24148 Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs.
apurtell merged pull request #1532: HBASE-24148 Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs. URL: https://github.com/apache/hbase/pull/1532 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1532: HBASE-24148 Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs.
ndimiduk commented on issue #1532: HBASE-24148 Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs. URL: https://github.com/apache/hbase/pull/1532#issuecomment-614833024 Looks like the Dockerfile on branch-2.2 has bit-rot. I suspect package versions are partially pinned or not pinned at all: the rubocop version has incremented by ruby version has not. ``` [2020-04-16T18:43:21.548Z] Setting up ruby2.3 (2.3.3-1+deb9u7) ... [2020-04-16T18:43:21.548Z] Setting up ruby2.3-dev:amd64 (2.3.3-1+deb9u7) ... [2020-04-16T18:43:21.548Z] Setting up ruby-dev:amd64 (1:2.3.3) ... [2020-04-16T18:43:21.548Z] Setting up ruby (1:2.3.3) ... [2020-04-16T18:43:22.261Z] Processing triggers for libc-bin (2.24-11+deb9u3) ... [2020-04-16T18:43:22.975Z] Successfully installed rake-13.0.1 [2020-04-16T18:43:22.975Z] Building native extensions. This could take a while... [2020-04-16T18:43:25.277Z] ERROR: Error installing rubocop: [2020-04-16T18:43:25.277Z] rubocop requires Ruby version >= 2.4.0. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1532: HBASE-24148 Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs.
Apache-HBase commented on issue #1532: HBASE-24148 Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs. URL: https://github.com/apache/hbase/pull/1532#issuecomment-614833157 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s | Docker mode activated. | | -1 :x: | docker | 1m 19s | Docker failed to build yetus/hbase:d9b4982ad4. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase/pull/1532 | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1532/2/console | | versions | git=2.17.1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] apurtell opened a new pull request #1533: HBASE-24148 Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs.
apurtell opened a new pull request #1533: HBASE-24148 Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs. URL: https://github.com/apache/hbase/pull/1533 Backport for branch-1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1532: HBASE-24148 Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs.
Apache-HBase commented on issue #1532: HBASE-24148 Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs. URL: https://github.com/apache/hbase/pull/1532#issuecomment-614829559 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s | Docker mode activated. | | -1 :x: | docker | 2m 23s | Docker failed to build yetus/hbase:d9b4982ad4. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase/pull/1532 | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1532/1/console | | versions | git=2.17.1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1530: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication
Apache-HBase commented on issue #1530: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication URL: https://github.com/apache/hbase/pull/1530#issuecomment-614828493 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 23s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 15s | master passed | | +1 :green_heart: | compile | 1m 11s | master passed | | +1 :green_heart: | shadedjars | 5m 41s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 43s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 23s | the patch passed | | +1 :green_heart: | compile | 1m 9s | the patch passed | | +1 :green_heart: | javac | 1m 9s | the patch passed | | +1 :green_heart: | shadedjars | 5m 39s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 39s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 202m 58s | hbase-server in the patch passed. | | | | 231m 5s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1530/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1530 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3520378260d5 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d212dc4df0 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1530/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1530/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1530/1/testReport/ | | Max. process+thread count | 2646 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1530/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-24148) Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs.
[ https://issues.apache.org/jira/browse/HBASE-24148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-24148: Fix Version/s: 2.2.5 2.4.0 1.7.0 > Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs. > -- > > Key: HBASE-24148 > URL: https://issues.apache.org/jira/browse/HBASE-24148 > Project: HBase > Issue Type: Improvement > Components: Thrift >Affects Versions: 3.0.0 >Reporter: Tamas Penzes >Assignee: Tamas Penzes >Priority: Major > Fix For: 3.0.0, 2.3.0, 1.7.0, 2.4.0, 2.2.5 > > > In Apache Thrift all versions up to and including 0.12.0, a server or client > may run into an endless loop when feed with specific input data. Because the > issue had already been partially fixed in version 0.11.0, depending on the > installed version it affects only certain language bindings. > To be on the safe side, we could update to 0.13.0. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] apurtell opened a new pull request #1532: HBASE-24148 Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs.
apurtell opened a new pull request #1532: HBASE-24148 Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs. URL: https://github.com/apache/hbase/pull/1532 Backport for branch-2.2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24148) Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs.
[ https://issues.apache.org/jira/browse/HBASE-24148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085174#comment-17085174 ] Andrew Kyle Purtell commented on HBASE-24148: - I have a patch for 2.2 also, let me put that up. > Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs. > -- > > Key: HBASE-24148 > URL: https://issues.apache.org/jira/browse/HBASE-24148 > Project: HBase > Issue Type: Improvement > Components: Thrift >Affects Versions: 3.0.0 >Reporter: Tamas Penzes >Assignee: Tamas Penzes >Priority: Major > Fix For: 3.0.0, 2.3.0 > > > In Apache Thrift all versions up to and including 0.12.0, a server or client > may run into an endless loop when feed with specific input data. Because the > issue had already been partially fixed in version 0.11.0, depending on the > installed version it affects only certain language bindings. > To be on the safe side, we could update to 0.13.0. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24148) Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs.
[ https://issues.apache.org/jira/browse/HBASE-24148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085173#comment-17085173 ] Andrew Kyle Purtell commented on HBASE-24148: - This has been committed to some places but the issue is still open? Let me do the branch-1 backport now. PR coming in an hour or so. > Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs. > -- > > Key: HBASE-24148 > URL: https://issues.apache.org/jira/browse/HBASE-24148 > Project: HBase > Issue Type: Improvement > Components: Thrift >Affects Versions: 3.0.0 >Reporter: Tamas Penzes >Assignee: Tamas Penzes >Priority: Major > Fix For: 3.0.0, 2.3.0 > > > In Apache Thrift all versions up to and including 0.12.0, a server or client > may run into an endless loop when feed with specific input data. Because the > issue had already been partially fixed in version 0.11.0, depending on the > installed version it affects only certain language bindings. > To be on the safe side, we could update to 0.13.0. -- This message was sent by Atlassian Jira (v8.3.4#803005)
