[GitHub] [hbase] Apache-HBase commented on pull request #3556: HBASE-26127 Backport HBASE-23898 "Add trace support for simple apis i…
Apache-HBase commented on pull request #3556: URL: https://github.com/apache/hbase/pull/3556#issuecomment-892282725 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-25853 Compile Tests _ | | +0 :ok: | mvndep | 0m 29s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 58s | HBASE-25853 passed | | +1 :green_heart: | compile | 11m 23s | HBASE-25853 passed | | +1 :green_heart: | checkstyle | 2m 40s | HBASE-25853 passed | | +1 :green_heart: | spotbugs | 12m 26s | HBASE-25853 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 20s | the patch passed | | +1 :green_heart: | compile | 8m 44s | the patch passed | | -0 :warning: | javac | 8m 44s | root generated 2 new + 1887 unchanged - 0 fixed = 1889 total (was 1887) | | -0 :warning: | checkstyle | 2m 3s | root: The patch generated 2 new + 21 unchanged - 0 fixed = 23 total (was 21) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 11m 13s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 13m 2s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 54s | The patch does not generate ASF License warnings. | | | | 81m 19s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3556/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3556 | | Optional Tests | dupname asflicense javac hadoopcheck xml compile spotbugs hbaseanti checkstyle | | uname | Linux e785d4ac65c9 4.15.0-151-generic #157-Ubuntu SMP Fri Jul 9 23:07:57 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-25853 / 3d29c0c2b4 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3556/1/artifact/yetus-general-check/output/diff-compile-javac-root.txt | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3556/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt | | Max. process+thread count | 141 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-client hbase-server . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3556/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26158) MiniZooKeeperCluster should not be IA.Public
[ https://issues.apache.org/jira/browse/HBASE-26158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392618#comment-17392618 ] Duo Zhang commented on HBASE-26158: --- And on forking the code, if it is not designed to be used by downstream projects, forking it is the correct decision IMO. > MiniZooKeeperCluster should not be IA.Public > > > Key: HBASE-26158 > URL: https://issues.apache.org/jira/browse/HBASE-26158 > Project: HBase > Issue Type: Sub-task > Components: API, test >Reporter: Duo Zhang >Priority: Major > > End users do not need to test HBase when zookeeper is broken. And if users > want to start only a zookeeper cluster, they can just use curator-test, so I > do not think we should expose this class as IA.Public. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-26158) MiniZooKeeperCluster should not be IA.Public
[ https://issues.apache.org/jira/browse/HBASE-26158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392617#comment-17392617 ] Duo Zhang commented on HBASE-26158: --- No, you do not need to use mini zookeeper directly for most cases. HBTU will manage it for you. And what you describe above is you write code with both Kafka and HBase, I do not think this is the same with writing code inside the HBase code base. Still the same question, why not let Kafka to provide the ability to start a mini zookeeper cluster? Only HBase community needs to eat the dog food but Kafka community does not? > MiniZooKeeperCluster should not be IA.Public > > > Key: HBASE-26158 > URL: https://issues.apache.org/jira/browse/HBASE-26158 > Project: HBase > Issue Type: Sub-task > Components: API, test >Reporter: Duo Zhang >Priority: Major > > End users do not need to test HBase when zookeeper is broken. And if users > want to start only a zookeeper cluster, they can just use curator-test, so I > do not think we should expose this class as IA.Public. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-26158) MiniZooKeeperCluster should not be IA.Public
[ https://issues.apache.org/jira/browse/HBASE-26158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392613#comment-17392613 ] Geoffrey Jacoby commented on HBASE-26158: - I don't know the details of the Hadoop and HBase community's decisions that led to the forking of metrics and http, so I can't offer an informed opinion on it. As a general rule, I consider permanent forks of code such as those cases a last resort. What you describe isn't dogfooding, at least as I understand the term. Say I need to coordinate between two in-process services via ZK, or to kill a ZK quorum to test some error path code. If I'm writing code for the HBase project itself, under this JIRA's proposal I would use the MiniZookeeperCluster. If I'm writing code for anything else, under this JIRA's proposal I would need to use curator-test, and manage the dependency myself, or fork the MiniZookeeperCluster, and have to keep it up to date with any changes from upstream forever. Different people would be using different APIs to do the same thing. The fact that in _other_, simpler use cases they'd go through the same code path doesn't change this. > MiniZooKeeperCluster should not be IA.Public > > > Key: HBASE-26158 > URL: https://issues.apache.org/jira/browse/HBASE-26158 > Project: HBase > Issue Type: Sub-task > Components: API, test >Reporter: Duo Zhang >Priority: Major > > End users do not need to test HBase when zookeeper is broken. And if users > want to start only a zookeeper cluster, they can just use curator-test, so I > do not think we should expose this class as IA.Public. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3555: HBASE-25469 Add detailed RIT info in JSON format for consumption as metrics
Apache-HBase commented on pull request #3555: URL: https://github.com/apache/hbase/pull/3555#issuecomment-892260585 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 55s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 42s | branch-2 passed | | +1 :green_heart: | javadoc | 0m 38s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 26s | the patch passed | | +1 :green_heart: | javadoc | 0m 37s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 145m 11s | hbase-server in the patch passed. | | | | 159m 59s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3555/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3555 | | Optional Tests | javac javadoc unit | | uname | Linux efff2bab704a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / ca096437d7 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3555/1/testReport/ | | Max. process+thread count | 4105 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3555/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3535: HBASE-25469 Add detailed RIT info in JSON format for consumption as metrics
Apache-HBase commented on pull request #3535: URL: https://github.com/apache/hbase/pull/3535#issuecomment-892258125 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 45s | master passed | | +1 :green_heart: | compile | 1m 15s | master passed | | +1 :green_heart: | shadedjars | 8m 23s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 46s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 26s | the patch passed | | +1 :green_heart: | compile | 1m 12s | the patch passed | | +1 :green_heart: | javac | 1m 12s | the patch passed | | +1 :green_heart: | shadedjars | 8m 7s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 143m 9s | hbase-server in the patch passed. | | | | 176m 34s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3535 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4959e9b93c53 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f3175c5ab6 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/5/testReport/ | | Max. process+thread count | 3712 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/5/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3535: HBASE-25469 Add detailed RIT info in JSON format for consumption as metrics
Apache-HBase commented on pull request #3535: URL: https://github.com/apache/hbase/pull/3535#issuecomment-892257224 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 36s | master passed | | +1 :green_heart: | compile | 1m 0s | master passed | | +1 :green_heart: | shadedjars | 8m 15s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 39s | the patch passed | | +1 :green_heart: | compile | 1m 2s | the patch passed | | +1 :green_heart: | javac | 1m 2s | the patch passed | | +1 :green_heart: | shadedjars | 8m 8s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 145m 37s | hbase-server in the patch passed. | | | | 175m 2s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3535 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 2826a858416b 4.15.0-151-generic #157-Ubuntu SMP Fri Jul 9 23:07:57 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f3175c5ab6 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/5/testReport/ | | Max. process+thread count | 4188 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/5/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26158) MiniZooKeeperCluster should not be IA.Public
[ https://issues.apache.org/jira/browse/HBASE-26158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392604#comment-17392604 ] Duo Zhang commented on HBASE-26158: --- I do not think we should shade curator, still I do not see why HBase should take care of zookeeper, if you say HBase is a platform, what about Hadoop? It also uses zookeeper and HBase is even built on it which means it is more like a platform than HBase, so why not rely on Hadoop to provide a zookeeper mini cluster? Just because it does not do this in the past so it is not its duty? Technically on the curator version, it has different versions for zookeeper 3.4.x and 3.5.x. It has already considered the compatibility issue, and also shaded a bunch of dependencies. This is its duty, to make end users easy to use zookeeper. I do not think on this topic HBase can do better than curator. And on your current code base, I do not think it is a strong argument. I also have lots of code depend on the old HBTU, I also need to change them. If you think it is really a pain, just copy the mini zk cluster code into your own code base and use it. This is what we have done in HBase many times, copy code from Hadoop and use it by our own. The HBase metrics and HBase http module are both started by copying code from Hadoop. And on the last ‘dog fooding’, technically, we just wrap the HBTU and provide a simpler interface to end users, so I do not think we break the rule, as we just want to hide the internal things which should not be exposed to end users. Thanks. > MiniZooKeeperCluster should not be IA.Public > > > Key: HBASE-26158 > URL: https://issues.apache.org/jira/browse/HBASE-26158 > Project: HBase > Issue Type: Sub-task > Components: API, test >Reporter: Duo Zhang >Priority: Major > > End users do not need to test HBase when zookeeper is broken. And if users > want to start only a zookeeper cluster, they can just use curator-test, so I > do not think we should expose this class as IA.Public. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-26128) Backport HBASE-25454 "Add trace support for connection registry" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-26128: - Summary: Backport HBASE-25454 "Add trace support for connection registry" to branch-2 (was: Backport HBASE-25454 to branch-2) > Backport HBASE-25454 "Add trace support for connection registry" to branch-2 > > > Key: HBASE-26128 > URL: https://issues.apache.org/jira/browse/HBASE-26128 > Project: HBase > Issue Type: Sub-task >Reporter: Tak-Lon (Stephen) Wu >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3556: HBASE-26127 Backport HBASE-23898 "Add trace support for simple apis i…
Apache-HBase commented on pull request #3556: URL: https://github.com/apache/hbase/pull/3556#issuecomment-892245418 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docker mode activated. | | -0 :warning: | yetus | 0m 8s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-25853 Compile Tests _ | | +0 :ok: | mvndep | 0m 28s | Maven dependency ordering for branch | | -1 :x: | mvninstall | 0m 13s | root in HBASE-25853 failed. | | -1 :x: | compile | 0m 11s | root in HBASE-25853 failed. | | -1 :x: | shadedjars | 0m 8s | branch has 7 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 11s | root in HBASE-25853 failed. | | -0 :warning: | javadoc | 0m 19s | hbase-client in HBASE-25853 failed. | | -0 :warning: | javadoc | 0m 13s | hbase-common in HBASE-25853 failed. | | -0 :warning: | javadoc | 0m 23s | hbase-server in HBASE-25853 failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 0m 10s | root in the patch failed. | | -1 :x: | compile | 0m 10s | root in the patch failed. | | -0 :warning: | javac | 0m 10s | root in the patch failed. | | -1 :x: | shadedjars | 0m 9s | patch has 7 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 11s | root in the patch failed. | | -0 :warning: | javadoc | 0m 9s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 10s | hbase-common in the patch failed. | | -0 :warning: | javadoc | 0m 10s | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 0m 10s | root in the patch failed. | | | | 6m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3556/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3556 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 42988d9e22f9 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-25853 / 3d29c0c2b4 | | Default Java | AdoptOpenJDK-11.0.10+9 | | mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3556/1/artifact/yetus-jdk11-hadoop3-check/output/branch-mvninstall-root.txt | | compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3556/1/artifact/yetus-jdk11-hadoop3-check/output/branch-compile-root.txt | | shadedjars | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3556/1/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3556/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3556/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3556/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3556/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3556/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt | | compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3556/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt | | javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3556/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt | | shadedjars | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3556/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3556/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt | | javadoc |
[jira] [Updated] (HBASE-26130) Backport HBASE-25455 "Add trace support for HRegion read/write operation" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-26130: - Summary: Backport HBASE-25455 "Add trace support for HRegion read/write operation" to branch-2 (was: Backport HBASE-25455 to branch-2) > Backport HBASE-25455 "Add trace support for HRegion read/write operation" to > branch-2 > - > > Key: HBASE-26130 > URL: https://issues.apache.org/jira/browse/HBASE-26130 > Project: HBase > Issue Type: Sub-task >Reporter: Tak-Lon (Stephen) Wu >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-26131) Backport HBASE-25484 "Add trace support for WAL sync" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-26131: - Summary: Backport HBASE-25484 "Add trace support for WAL sync" to branch-2 (was: Backport HBASE-25484 to branch-2) > Backport HBASE-25484 "Add trace support for WAL sync" to branch-2 > - > > Key: HBASE-26131 > URL: https://issues.apache.org/jira/browse/HBASE-26131 > Project: HBase > Issue Type: Sub-task >Reporter: Tak-Lon (Stephen) Wu >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-26132) Backport HBASE-25535 "Set span kind to CLIENT in AbstractRpcClient" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-26132: - Summary: Backport HBASE-25535 "Set span kind to CLIENT in AbstractRpcClient" to branch-2 (was: Backport HBASE-25535 to branch-2) > Backport HBASE-25535 "Set span kind to CLIENT in AbstractRpcClient" to > branch-2 > --- > > Key: HBASE-26132 > URL: https://issues.apache.org/jira/browse/HBASE-26132 > Project: HBase > Issue Type: Sub-task >Reporter: Tak-Lon (Stephen) Wu >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-26133) Backport HBASE-25591 "Upgrade opentelemetry to 0.17.1" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-26133: - Summary: Backport HBASE-25591 "Upgrade opentelemetry to 0.17.1" to branch-2 (was: Backport HBASE-25591 to branch-2) > Backport HBASE-25591 "Upgrade opentelemetry to 0.17.1" to branch-2 > -- > > Key: HBASE-26133 > URL: https://issues.apache.org/jira/browse/HBASE-26133 > Project: HBase > Issue Type: Sub-task >Reporter: Tak-Lon (Stephen) Wu >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-26129) Backport HBASE-25481 "Add host and port attribute when tracing rpc call at client side" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-26129: - Summary: Backport HBASE-25481 "Add host and port attribute when tracing rpc call at client side" to branch-2 (was: Backport HBASE-25481 to branch-2) > Backport HBASE-25481 "Add host and port attribute when tracing rpc call at > client side" to branch-2 > --- > > Key: HBASE-26129 > URL: https://issues.apache.org/jira/browse/HBASE-26129 > Project: HBase > Issue Type: Sub-task >Reporter: Tak-Lon (Stephen) Wu >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-26134) Backport HBASE-25617 "Revisit the span names" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-26134: - Summary: Backport HBASE-25617 "Revisit the span names" to branch-2 (was: Backport HBASE-25617 to branch-2) > Backport HBASE-25617 "Revisit the span names" to branch-2 > - > > Key: HBASE-26134 > URL: https://issues.apache.org/jira/browse/HBASE-26134 > Project: HBase > Issue Type: Sub-task >Reporter: Tak-Lon (Stephen) Wu >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-26137) Backport HBASE-25732 "Change the command line argument for tracing after upgrading opentelemtry to 1.0.0" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-26137: - Summary: Backport HBASE-25732 "Change the command line argument for tracing after upgrading opentelemtry to 1.0.0" to branch-2 (was: Backport HBASE-25732 to branch-2) > Backport HBASE-25732 "Change the command line argument for tracing after > upgrading opentelemtry to 1.0.0" to branch-2 > - > > Key: HBASE-26137 > URL: https://issues.apache.org/jira/browse/HBASE-26137 > Project: HBase > Issue Type: Sub-task >Reporter: Tak-Lon (Stephen) Wu >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-26136) Backport HBASE-25723 "Temporarily remove the trace support for RegionScanner.next" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-26136: - Summary: Backport HBASE-25723 "Temporarily remove the trace support for RegionScanner.next" to branch-2 (was: Backport HBASE-25723 to branch-2) > Backport HBASE-25723 "Temporarily remove the trace support for > RegionScanner.next" to branch-2 > -- > > Key: HBASE-26136 > URL: https://issues.apache.org/jira/browse/HBASE-26136 > Project: HBase > Issue Type: Sub-task >Reporter: Tak-Lon (Stephen) Wu >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-26135) Backport HBASE-25616 "Upgrade opentelemetry to 1.0.0" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-26135: - Summary: Backport HBASE-25616 "Upgrade opentelemetry to 1.0.0" to branch-2 (was: Backport Backport HBASE-25616 "Upgrade opentelemetry to 1.0.0" to branch-2) > Backport HBASE-25616 "Upgrade opentelemetry to 1.0.0" to branch-2 > - > > Key: HBASE-26135 > URL: https://issues.apache.org/jira/browse/HBASE-26135 > Project: HBase > Issue Type: Sub-task >Reporter: Tak-Lon (Stephen) Wu >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-26135) Backport Backport HBASE-25616 "Upgrade opentelemetry to 1.0.0" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-26135: - Summary: Backport Backport HBASE-25616 "Upgrade opentelemetry to 1.0.0" to branch-2 (was: Backport HBASE-25616 to branch-2) > Backport Backport HBASE-25616 "Upgrade opentelemetry to 1.0.0" to branch-2 > -- > > Key: HBASE-26135 > URL: https://issues.apache.org/jira/browse/HBASE-26135 > Project: HBase > Issue Type: Sub-task >Reporter: Tak-Lon (Stephen) Wu >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-26138) Backport HBASE-25733 "Upgrade opentelemetry to 1.0.1" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-26138: - Summary: Backport HBASE-25733 "Upgrade opentelemetry to 1.0.1" to branch-2 (was: Backport HBASE-25733 to branch-2) > Backport HBASE-25733 "Upgrade opentelemetry to 1.0.1" to branch-2 > - > > Key: HBASE-26138 > URL: https://issues.apache.org/jira/browse/HBASE-26138 > Project: HBase > Issue Type: Sub-task >Reporter: Tak-Lon (Stephen) Wu >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-26140) Backport HBASE-25778 "The tracinig implementation for AsyncConnectionImpl.getHbck is incorrect" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-26140: - Summary: Backport HBASE-25778 "The tracinig implementation for AsyncConnectionImpl.getHbck is incorrect" to branch-2 (was: Backport HBASE-25778 to branch-2) > Backport HBASE-25778 "The tracinig implementation for > AsyncConnectionImpl.getHbck is incorrect" to branch-2 > --- > > Key: HBASE-26140 > URL: https://issues.apache.org/jira/browse/HBASE-26140 > Project: HBase > Issue Type: Sub-task >Reporter: Tak-Lon (Stephen) Wu >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25853) Backport HBASE-22120 (Replace HTrace with OpenTelemetry) to branch-2
[
https://issues.apache.org/jira/browse/HBASE-25853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392602#comment-17392602
]
Tak-Lon (Stephen) Wu commented on HBASE-25853:
--
[~zhangduo] [~apurtell] [~psomogyi]
I have been sending PRs one by one, and I I can continue to cherry-pick what I
have in my personal fork
[https://github.com/taklwu/hbase/commits/HBASE-25853-all-reworded] for all
remaining commits. At one point I was wondered, do you guys think I can open a
single PR for about 13 commits at once into the feature branch of HBASE-25853
based on branch-2? we can create a following up tasks for fix javac, style, and
ruby style when needed, but my goal is to speed up the reviewer time (or it's
the same for you guys). any comments ?
> Backport HBASE-22120 (Replace HTrace with OpenTelemetry) to branch-2
>
>
> Key: HBASE-25853
> URL: https://issues.apache.org/jira/browse/HBASE-25853
> Project: HBase
> Issue Type: Task
> Components: tracing
>Affects Versions: 2.5.0
>Reporter: Duo Zhang
>Assignee: Tak-Lon (Stephen) Wu
>Priority: Major
> Fix For: 2.5.0
>
>
> list of commits from upstream/master need to be backported
> {code}
> HBASE-25373
> https://github.com/apache/hbase/commit/302d9ea8b888762a5a20a5ba5c2be7bc239afaef
>
> HBASE-25401
> https://github.com/apache/hbase/commit/242028671535dfed67ec13d9ed0d6067f3ccfd04
>
> HBASE-25424
> https://github.com/apache/hbase/commit/57960fa8fa7228d65b1a4adc8e9b5b1a8158824d
>
> HBASE-23898
> https://github.com/apache/hbase/commit/805b2ae2ad0f6325515d46043ff01e4e2c7a9f59
>
> HBASE-25454
> https://github.com/apache/hbase/commit/dcb78bd4bda4a4ae13d863df8aec266031e5bc93
> HBASE-25481
> https://github.com/apache/hbase/commit/ae2c62ffaad5ba4c976b0a79c10a365edf2844fd
> HBASE-25455
> https://github.com/apache/hbase/commit/03e12bfa4ad62ecc6eee6a2c68d431bea2d5c473
> HBASE-25484
> https://github.com/apache/hbase/commit/2be2c63f0d3917a243b74af9754cbfc805b858d1
> HBASE-25535
> https://github.com/apache/hbase/commit/bb8c4967f8ce2c89ebaf1ddc5d8a1bf55f1e20d3
> HBASE-25591
> https://github.com/apache/hbase/commit/f6ff519dd0c7fe0e3ae3c175eefee27a26a065a4
> HBASE-25617
> https://github.com/apache/hbase/commit/8d68f8cd1c8613be1b499eaa99f46806b2743294
> HBASE-25616
> https://github.com/apache/hbase/commit/8399293e21127df3ffdcb757242e4cb5964c7e99
> HBASE-25723
> https://github.com/apache/hbase/commit/7f90c2201f6a17d2e2d031505c35ae7c2b1ed7ea
> HBASE-25732
> https://github.com/apache/hbase/commit/8df9bebdd367d52a32b08c18a7cf4f9c2d712071
> HBASE-25733
> https://github.com/apache/hbase/commit/b71488998970a3353086a34736ed1edab527f673
> HBASE-23762
> https://github.com/apache/hbase/commit/be4503d9f82f044fbfce21c8a42d0b1684607238
> HBASE-25778
> https://github.com/apache/hbase/commit/f36e1539648bbaee84c626fd54d1605baebf3c5a
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-26139) Backport HBASE-23762 "Add documentation on how to enable and view tracing with OpenTelemetry" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-26139: - Summary: Backport HBASE-23762 "Add documentation on how to enable and view tracing with OpenTelemetry" to branch-2 (was: Backport HBASE-23762 to branch-2) > Backport HBASE-23762 "Add documentation on how to enable and view tracing > with OpenTelemetry" to branch-2 > - > > Key: HBASE-26139 > URL: https://issues.apache.org/jira/browse/HBASE-26139 > Project: HBase > Issue Type: Sub-task >Reporter: Tak-Lon (Stephen) Wu >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-26127) Backport HBASE-23898 "Add trace support for simple apis in async client" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu reassigned HBASE-26127: Assignee: Tak-Lon (Stephen) Wu > Backport HBASE-23898 "Add trace support for simple apis in async client" to > branch-2 > > > Key: HBASE-26127 > URL: https://issues.apache.org/jira/browse/HBASE-26127 > Project: HBase > Issue Type: Sub-task >Reporter: Tak-Lon (Stephen) Wu >Assignee: Tak-Lon (Stephen) Wu >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] taklwu opened a new pull request #3556: HBASE-26127 Backport HBASE-23898 "Add trace support for simple apis i…
taklwu opened a new pull request #3556: URL: https://github.com/apache/hbase/pull/3556 …n async client" to branch-2 4/17 commits of HBASE-22120, original commit 805b2ae2ad0f6325515d46043ff01e4e2c7a9f59 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3542: HBASE-26153 [create-release] Use cmd-line defined env vars
Apache-HBase commented on pull request #3542: URL: https://github.com/apache/hbase/pull/3542#issuecomment-892231139 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 10m 16s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 7s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 11m 42s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3542/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3542 | | Optional Tests | | | uname | Linux cb348181b09a 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f3175c5ab6 | | Max. process+thread count | 47 (vs. ulimit of 3) | | modules | C: U: | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3542/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3542: HBASE-26153 [create-release] Use cmd-line defined env vars
Apache-HBase commented on pull request #3542: URL: https://github.com/apache/hbase/pull/3542#issuecomment-892230954 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 9m 53s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 7s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 11m 16s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3542/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3542 | | Optional Tests | | | uname | Linux 5a527898fd74 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f3175c5ab6 | | Max. process+thread count | 51 (vs. ulimit of 3) | | modules | C: U: | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3542/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3542: HBASE-26153 [create-release] Use cmd-line defined env vars
Apache-HBase commented on pull request #3542: URL: https://github.com/apache/hbase/pull/3542#issuecomment-892227407 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 6s | Maven dependency ordering for patch | | +1 :green_heart: | shellcheck | 0m 3s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | ||| _ Other Tests _ | | +0 :ok: | asflicense | 0m 0s | ASF License check generated no output? | | | | 2m 40s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3542/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3542 | | Optional Tests | dupname asflicense shellcheck shelldocs | | uname | Linux 4da8210b855f 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f3175c5ab6 | | Max. process+thread count | 45 (vs. ulimit of 3) | | modules | C: U: | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3542/3/console | | versions | git=2.17.1 maven=3.6.3 shellcheck=0.4.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-26127) Backport HBASE-23898 "Add trace support for simple apis in async client" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-26127: - Summary: Backport HBASE-23898 "Add trace support for simple apis in async client" to branch-2 (was: Backport HBASE-23898 to branch-2) > Backport HBASE-23898 "Add trace support for simple apis in async client" to > branch-2 > > > Key: HBASE-26127 > URL: https://issues.apache.org/jira/browse/HBASE-26127 > Project: HBase > Issue Type: Sub-task >Reporter: Tak-Lon (Stephen) Wu >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-26126) Backport HBASE-25424 "Find a way to config OpenTelemetry tracing without directly depending on opentelemetry-sdk" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu resolved HBASE-26126. -- Fix Version/s: 2.5.0 Hadoop Flags: Reviewed Release Note: https://github.com/apache/hbase/commit/3d29c0c2b4520edb06c0c5d3674cdb6547a57651 Resolution: Fixed https://github.com/apache/hbase/commit/3d29c0c2b4520edb06c0c5d3674cdb6547a57651 pushed to feature branch HBASE-25853 > Backport HBASE-25424 "Find a way to config OpenTelemetry tracing without > directly depending on opentelemetry-sdk" to branch-2 > - > > Key: HBASE-26126 > URL: https://issues.apache.org/jira/browse/HBASE-26126 > Project: HBase > Issue Type: Sub-task >Reporter: Tak-Lon (Stephen) Wu >Assignee: Tak-Lon (Stephen) Wu >Priority: Major > Fix For: 2.5.0 > > > [3/17 commits of > HBASE-22120|https://github.com/apache/hbase/pull/2901/commits], original > commit of HBASE-25424 was > [https://github.com/apache/hbase/commit/57960fa8fa7228d65b1a4adc8e9b5b1a8158824d] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-26126) Backport HBASE-25424 "Find a way to config OpenTelemetry tracing without directly depending on opentelemetry-sdk" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392587#comment-17392587 ] Tak-Lon (Stephen) Wu commented on HBASE-26126: -- from now on, all remaining backport will be pushed to feature branch [HBASE-25853|https://github.com/apache/hbase/tree/HBASE-25853] of branch-2 before we completes and merging into branch-2 > Backport HBASE-25424 "Find a way to config OpenTelemetry tracing without > directly depending on opentelemetry-sdk" to branch-2 > - > > Key: HBASE-26126 > URL: https://issues.apache.org/jira/browse/HBASE-26126 > Project: HBase > Issue Type: Sub-task >Reporter: Tak-Lon (Stephen) Wu >Assignee: Tak-Lon (Stephen) Wu >Priority: Major > > [3/17 commits of > HBASE-22120|https://github.com/apache/hbase/pull/2901/commits], original > commit of HBASE-25424 was > [https://github.com/apache/hbase/commit/57960fa8fa7228d65b1a4adc8e9b5b1a8158824d] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-26165) 2.3.5 listed on website downloads page but row intends to be for 2.3.6
[ https://issues.apache.org/jira/browse/HBASE-26165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392577#comment-17392577 ] Michael Stack commented on HBASE-26165: --- Thanks boys. > 2.3.5 listed on website downloads page but row intends to be for 2.3.6 > -- > > Key: HBASE-26165 > URL: https://issues.apache.org/jira/browse/HBASE-26165 > Project: HBase > Issue Type: Task > Components: website >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Trivial > Fix For: 3.0.0-alpha-2 > > > Typo on downloads.html. Row is for 2.3.6 but still says 2.3.5. > Missed in HBASE-26162. PR coming. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-26158) MiniZooKeeperCluster should not be IA.Public
[ https://issues.apache.org/jira/browse/HBASE-26158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392574#comment-17392574 ] Geoffrey Jacoby commented on HBASE-26158: - As for why I think it's not good to have one ZK API for internal use cases and another for end-users: HBase isn't just a fast, powerful key-value storage engine. It's also a platform (and platform component) on which other developers build applications. One of the principles of platform development is that when an internal use case and an external use case are both trying to do the same thing, they should always use the same API [1]. This allows platform developers (such as the HBase community) to experience the ease or difficulties that end-users experience when using their platform. [1] https://deviq.com/practices/dogfooding > MiniZooKeeperCluster should not be IA.Public > > > Key: HBASE-26158 > URL: https://issues.apache.org/jira/browse/HBASE-26158 > Project: HBase > Issue Type: Sub-task > Components: API, test >Reporter: Duo Zhang >Priority: Major > > End users do not need to test HBase when zookeeper is broken. And if users > want to start only a zookeeper cluster, they can just use curator-test, so I > do not think we should expose this class as IA.Public. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3535: HBASE-25469 Add detailed RIT info in JSON format for consumption as metrics
Apache-HBase commented on pull request #3535: URL: https://github.com/apache/hbase/pull/3535#issuecomment-892202671 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 29s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 53s | master passed | | +1 :green_heart: | compile | 3m 16s | master passed | | +1 :green_heart: | checkstyle | 1m 9s | master passed | | +1 :green_heart: | spotbugs | 2m 2s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 40s | the patch passed | | +1 :green_heart: | compile | 3m 18s | the patch passed | | +1 :green_heart: | javac | 3m 18s | the patch passed | | -0 :warning: | checkstyle | 1m 1s | hbase-server: The patch generated 1 new + 89 unchanged - 0 fixed = 90 total (was 89) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 21m 7s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 2m 54s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 54m 13s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/5/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3535 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 1311fee22873 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f3175c5ab6 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 96 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/5/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (HBASE-26158) MiniZooKeeperCluster should not be IA.Public
[ https://issues.apache.org/jira/browse/HBASE-26158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392569#comment-17392569 ] Geoffrey Jacoby edited comment on HBASE-26158 at 8/3/21, 10:12 PM: --- I agree the curator version compatibility is a big issue here too. There's a curator.version in the HBase pom.xml, but it only seems to be used for a coproc example. There's little to no guidance to end users about what version of curator are compatible with what versions of HBase. Again, I think [~zhangduo] makes a good point that with a publicly available ZK minicluster, the MiniZookeeperCluster may no longer be necessary. It's working fine both internally and externally, so I don't feel strongly that it needs to go, but I wouldn't mind if it did -- so long as it was deprecated both externally AND internally, via the usual deprecation method. I believe that would be, in HBase 3.0: 1. Take on curator-test as a formal dependency of HBase. This requires figuring out which version to use, excluding conflicting transitive dependencies, etc 2. Probably shade it into hbase-thirdparty? 3. Do HBASE-26167 to allow for overriding ZK with an external embedded ZK quorum. 4. Switch TestingHBaseCluster and HBTU to use curator-test by default 5. Fix any HBase tests that break because of this effort 6. Fix any bugs found in curator-test because of this effort 7. Deprecate the MiniZookeeperCluster and the methods in HBTU that reference it (but still support them during the 3.x cycle). In HBase 4.0: 1. Delete the MiniZookeeperCluster and the methods in HBTU that reference it. At this point, HBase will have offloaded its embedded ZK onto a ZK-based project, similarly to how MiniDFSCluster is I believe part of HDFS. Which would be good. On the other hand, if that sounds like a lot of work compared to the benefit...please remember that that aside from HBASE-26167 and the actual deprecation JIRA, that's almost the same work you're asking end-users to do. was (Author: gjacoby): I agree the curator version compatibility is a big issue here too. There's a curator.version in the HBase pom.xml, but it only seems to be used for a coproc example. There's little to no guidance to end users about what version of curator are compatible with what versions of HBase. Again, I think [~zhangduo] makes a good point that with a publicly available ZK minicluster, the MiniZookeeperCluster may no longer be necessary. It's working fine both internally and externally, so I don't feel strongly that it needs to go, but I wouldn't mind if it did -- so long as it was deprecated both externally AND internally, via the usual deprecation method. I believe that would be, in HBase 3.0: 1. Take on curator-test as a formal dependency of HBase. This requires figuring out which version to use, excluding conflicting transitive dependencies, etc 2. Probably shade it into hbase-thirdparty? 3. Do HBASE-26167 to allow for overriding ZK with an external embedded ZK quorum. 4. Switch TestingHBaseCluster and HBTU to use curator-test by default 5. Fix any HBase tests that break because of this effort 6. Fix any bugs found in curator-test because of this effort 5. Deprecate the MiniZookeeperCluster and the methods in HBTU that reference it (but still support them during the 3.x cycle). In HBase 4.0: 1. Delete the MiniZookeeperCluster and the methods in HBTU that reference it. At this point, HBase will have offloaded its embedded ZK onto a ZK-based project, similarly to how MiniDFSCluster is I believe part of HDFS. Which would be good. On the other hand, if that sounds like a lot of work compared to the benefit...please remember that that aside from HBASE-26167 and the actual deprecation JIRA, that's almost the same work you're asking end-users to do. > MiniZooKeeperCluster should not be IA.Public > > > Key: HBASE-26158 > URL: https://issues.apache.org/jira/browse/HBASE-26158 > Project: HBase > Issue Type: Sub-task > Components: API, test >Reporter: Duo Zhang >Priority: Major > > End users do not need to test HBase when zookeeper is broken. And if users > want to start only a zookeeper cluster, they can just use curator-test, so I > do not think we should expose this class as IA.Public. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-26158) MiniZooKeeperCluster should not be IA.Public
[ https://issues.apache.org/jira/browse/HBASE-26158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392569#comment-17392569 ] Geoffrey Jacoby commented on HBASE-26158: - I agree the curator version compatibility is a big issue here too. There's a curator.version in the HBase pom.xml, but it only seems to be used for a coproc example. There's little to no guidance to end users about what version of curator are compatible with what versions of HBase. Again, I think [~zhangduo] makes a good point that with a publicly available ZK minicluster, the MiniZookeeperCluster may no longer be necessary. It's working fine both internally and externally, so I don't feel strongly that it needs to go, but I wouldn't mind if it did -- so long as it was deprecated both externally AND internally, via the usual deprecation method. I believe that would be, in HBase 3.0: 1. Take on curator-test as a formal dependency of HBase. This requires figuring out which version to use, excluding conflicting transitive dependencies, etc 2. Probably shade it into hbase-thirdparty? 3. Do HBASE-26167 to allow for overriding ZK with an external embedded ZK quorum. 4. Switch TestingHBaseCluster and HBTU to use curator-test by default 5. Fix any HBase tests that break because of this effort 6. Fix any bugs found in curator-test because of this effort 5. Deprecate the MiniZookeeperCluster and the methods in HBTU that reference it (but still support them during the 3.x cycle). In HBase 4.0: 1. Delete the MiniZookeeperCluster and the methods in HBTU that reference it. At this point, HBase will have offloaded its embedded ZK onto a ZK-based project, similarly to how MiniDFSCluster is I believe part of HDFS. Which would be good. On the other hand, if that sounds like a lot of work compared to the benefit...please remember that that aside from HBASE-26167 and the actual deprecation JIRA, that's almost the same work you're asking end-users to do. > MiniZooKeeperCluster should not be IA.Public > > > Key: HBASE-26158 > URL: https://issues.apache.org/jira/browse/HBASE-26158 > Project: HBase > Issue Type: Sub-task > Components: API, test >Reporter: Duo Zhang >Priority: Major > > End users do not need to test HBase when zookeeper is broken. And if users > want to start only a zookeeper cluster, they can just use curator-test, so I > do not think we should expose this class as IA.Public. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3488: HBASE-25393 Support split and merge region with direct insert into CF…
Apache-HBase commented on pull request #3488: URL: https://github.com/apache/hbase/pull/3488#issuecomment-892198061 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m 40s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-24749 Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 30s | HBASE-24749 passed | | +1 :green_heart: | compile | 5m 13s | HBASE-24749 passed | | +1 :green_heart: | checkstyle | 1m 20s | HBASE-24749 passed | | +1 :green_heart: | spotbugs | 6m 21s | HBASE-24749 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 19s | the patch passed | | -1 :x: | compile | 1m 35s | hbase-server in the patch failed. | | -0 :warning: | cc | 1m 35s | hbase-server in the patch failed. | | -0 :warning: | javac | 1m 35s | hbase-server in the patch failed. | | -0 :warning: | checkstyle | 1m 12s | hbase-server: The patch generated 34 new + 40 unchanged - 3 fixed = 74 total (was 43) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 22m 34s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | hbaseprotoc | 1m 58s | the patch passed | | -1 :x: | spotbugs | 2m 52s | hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. | | | | 77m 12s | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-server | | | org.apache.hadoop.hbase.regionserver.DirectStoreFSWriteStrategy.commitDaughterRegion(RegionInfo) makes inefficient use of keySet iterator instead of entrySet iterator At DirectStoreFSWriteStrategy.java:keySet iterator instead of entrySet iterator At DirectStoreFSWriteStrategy.java:[line 231] | | | org.apache.hadoop.hbase.regionserver.DirectStoreFSWriteStrategy.commitMergedRegion(RegionInfo) makes inefficient use of keySet iterator instead of entrySet iterator At DirectStoreFSWriteStrategy.java:keySet iterator instead of entrySet iterator At DirectStoreFSWriteStrategy.java:[line 253] | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3488/7/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3488 | | Optional Tests | dupname asflicense cc hbaseprotoc prototool javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux fd89c336d6bb 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-24749 / 78999ab725 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3488/7/artifact/yetus-general-check/output/patch-compile-hbase-server.txt | | cc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3488/7/artifact/yetus-general-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3488/7/artifact/yetus-general-check/output/patch-compile-hbase-server.txt | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3488/7/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3488/7/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html | | Max. process+thread count | 86 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3488/7/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond
[GitHub] [hbase] Apache-HBase commented on pull request #3552: HBASE-26126 Backport HBASE-25424 "Find a way to config OpenTelemetry …
Apache-HBase commented on pull request #3552: URL: https://github.com/apache/hbase/pull/3552#issuecomment-892193982 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-25853 Compile Tests _ | | +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 36s | HBASE-25853 passed | | +1 :green_heart: | compile | 2m 16s | HBASE-25853 passed | | +1 :green_heart: | shadedjars | 6m 20s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 24s | HBASE-25853 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 20s | the patch passed | | +1 :green_heart: | compile | 2m 17s | the patch passed | | +1 :green_heart: | javac | 2m 17s | the patch passed | | +1 :green_heart: | shadedjars | 6m 23s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 27s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 274m 57s | root in the patch failed. | | | | 308m 7s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3552 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux e179bcddbdfc 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-25853 / ca096437d7 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/testReport/ | | Max. process+thread count | 3870 (vs. ulimit of 12500) | | modules | C: hbase-assembly . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3555: HBASE-25469 Add detailed RIT info in JSON format for consumption as metrics
Apache-HBase commented on pull request #3555: URL: https://github.com/apache/hbase/pull/3555#issuecomment-892191671 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 1s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 41s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 10m 48s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3555/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3555 | | Optional Tests | dupname asflicense javac | | uname | Linux 43828e00b298 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / ca096437d7 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 66 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3555/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] caroliney14 opened a new pull request #3555: Add detailed RIT info in JSON format for consumption as metrics
caroliney14 opened a new pull request #3555: URL: https://github.com/apache/hbase/pull/3555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3535: HBASE-25469 Add detailed RIT info in JSON format for consumption as metrics
Apache-HBase commented on pull request #3535: URL: https://github.com/apache/hbase/pull/3535#issuecomment-892173820 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 10s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 37s | master passed | | +1 :green_heart: | compile | 1m 17s | master passed | | +1 :green_heart: | shadedjars | 8m 32s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 46s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 31s | the patch passed | | +1 :green_heart: | compile | 1m 14s | the patch passed | | +1 :green_heart: | javac | 1m 14s | the patch passed | | +1 :green_heart: | shadedjars | 8m 19s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 143m 47s | hbase-server in the patch passed. | | | | 179m 9s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3535 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 934f16c3e208 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f3175c5ab6 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/4/testReport/ | | Max. process+thread count | 3792 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3535: HBASE-25469 Add detailed RIT info in JSON format for consumption as metrics
Apache-HBase commented on pull request #3535: URL: https://github.com/apache/hbase/pull/3535#issuecomment-892171634 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 38s | master passed | | +1 :green_heart: | compile | 1m 2s | master passed | | +1 :green_heart: | shadedjars | 8m 17s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 43s | the patch passed | | +1 :green_heart: | compile | 1m 1s | the patch passed | | +1 :green_heart: | javac | 1m 1s | the patch passed | | +1 :green_heart: | shadedjars | 8m 9s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 145m 12s | hbase-server in the patch failed. | | | | 174m 56s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3535 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a5cb3761a0a4 4.15.0-151-generic #157-Ubuntu SMP Fri Jul 9 23:07:57 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f3175c5ab6 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/4/testReport/ | | Max. process+thread count | 4100 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25900) HBoss tests compile/failure against Hadoop 3.3.1
[ https://issues.apache.org/jira/browse/HBASE-25900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392546#comment-17392546 ] Josh Elser commented on HBASE-25900: FYI, I started building on top of SteveL's draft in #23 with #25. > HBoss tests compile/failure against Hadoop 3.3.1 > > > Key: HBASE-25900 > URL: https://issues.apache.org/jira/browse/HBASE-25900 > Project: HBase > Issue Type: Bug > Components: Filesystem Integration >Affects Versions: 1.0.2 >Reporter: Steve Loughran >Priority: Major > > Changes in Hadoop 3.3.x stop the tests compiling/working. > * changes in signature of nominally private classes (HADOOP-17497): fix, > update > * HADOOP-16721 -s3a rename throwing more exceptions, but no longer failing > if the dest parent doesn't exist. Fix: change s3a.xml > * HADOOP-17531/HADOOP-17620 distcp moving to listIterator; test failures. > * HADOOP-13327: tests on syncable which expect files being written to to be > visible. Fix: skip that test > The fix for HADOOP-17497 stops this compiling against Hadoop < 3.3.1. This is > unfortunate but I can't see an easy fix. The new signature takes a parameters > class, so we can (and already are) adding new config options without breaking > this signature again. And I've tagged it as LimitedPrivate so that future > developers will know it's used here -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-25900) HBoss tests compile/failure against Hadoop 3.3.1
[ https://issues.apache.org/jira/browse/HBASE-25900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser reassigned HBASE-25900: -- Assignee: Josh Elser > HBoss tests compile/failure against Hadoop 3.3.1 > > > Key: HBASE-25900 > URL: https://issues.apache.org/jira/browse/HBASE-25900 > Project: HBase > Issue Type: Bug > Components: Filesystem Integration >Affects Versions: 1.0.2 >Reporter: Steve Loughran >Assignee: Josh Elser >Priority: Major > > Changes in Hadoop 3.3.x stop the tests compiling/working. > * changes in signature of nominally private classes (HADOOP-17497): fix, > update > * HADOOP-16721 -s3a rename throwing more exceptions, but no longer failing > if the dest parent doesn't exist. Fix: change s3a.xml > * HADOOP-17531/HADOOP-17620 distcp moving to listIterator; test failures. > * HADOOP-13327: tests on syncable which expect files being written to to be > visible. Fix: skip that test > The fix for HADOOP-17497 stops this compiling against Hadoop < 3.3.1. This is > unfortunate but I can't see an easy fix. The new signature takes a parameters > class, so we can (and already are) adding new config options without breaking > this signature again. And I've tagged it as LimitedPrivate so that future > developers will know it's used here -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase-filesystem] joshelser opened a new pull request #25: HBASE-25900 Hadoop 3.2 and 3.3 support
joshelser opened a new pull request #25: URL: https://github.com/apache/hbase-filesystem/pull/25 This builds on @steveloughran's changes in #23 , pretty much doing everything he said needed to be done. * Creates some new maven modules to separate the S3ClientFactory which inevitably won't compile (I don' think we can have the 3.2 and 3.3 versions of the factory existing on the classpath at the same time) * Lots of indirection to determine what hadoop version is "active" * disabling of the new tests codes on the older versions of hadoop where the rename() changes don't exist I have _not_ gotten into testing the hadoop 2/hbase 1 compatibility at this point. This change needs some more polish, but thought it could benefit from some eyes on it now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] wchevreuil commented on a change in pull request #3488: HBASE-25393 Support split and merge region with direct insert into CF…
wchevreuil commented on a change in pull request #3488: URL: https://github.com/apache/hbase/pull/3488#discussion_r682092734 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/DirectStoreMergeRegionsStrategy.java ## @@ -0,0 +1,105 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.master.assignment; + +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.hbase.client.ColumnFamilyDescriptor; +import org.apache.hadoop.hbase.client.RegionInfo; +import org.apache.hadoop.hbase.client.TableDescriptor; +import org.apache.hadoop.hbase.io.hfile.CacheConfig; +import org.apache.hadoop.hbase.master.procedure.MasterProcedureEnv; +import org.apache.hadoop.hbase.regionserver.HRegionFileSystem; +import org.apache.hadoop.hbase.regionserver.HStoreFile; +import org.apache.hadoop.hbase.regionserver.StoreFileInfo; +import org.apache.yetus.audience.InterfaceAudience; + +import java.io.IOException; +import java.util.Collection; + +/** + * MergeRegionStrategy implementation to be used in combination with + * PersistedStoreEngine to avoid renames when merging regions. + * + * To use it, define the following properties under master configuration: Review comment: Changed to load both mergestrategy and write strategy from the table config. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-25469) Add detailed RIT info in JSON format for consumption as metrics
[
https://issues.apache.org/jira/browse/HBASE-25469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caroline Zhou updated HBASE-25469:
--
Summary: Add detailed RIT info in JSON format for consumption as metrics
(was: Create RIT servlet in HMaster to track more detailed RIT info not
captured in metrics)
> Add detailed RIT info in JSON format for consumption as metrics
> ---
>
> Key: HBASE-25469
> URL: https://issues.apache.org/jira/browse/HBASE-25469
> Project: HBase
> Issue Type: Improvement
> Components: master
>Affects Versions: 3.0.0-alpha-1, 2.4.6, 2.3.7
>Reporter: Caroline Zhou
>Assignee: Caroline Zhou
>Priority: Minor
> Labels: observability
> Attachments: Screen Shot 2021-07-27 at 10.34.45.png, Screen Shot
> 2021-07-27 at 10.34.53.png
>
>
> In HBase 2.1+, there is a RIT jsp page that was added as part of HBASE-21410.
> There are some additional RIT details that would be helpful to have in one
> place:
> * RIT Start Time
> * RIT Duration (ms)
> * Server
> * Procedure Type
> This info can be added to the table under the {{/rit.jsp}} page, and we can
> also add a button on that page to view info as JSON, for easy parsing into
> metrics, etc. This JSON dump can be served as a servlet.
> We may also consider different ways of grouping the JSON results, such as by
> state, table, or server name, and/or adding counts of RIT by state or server
> name.
> !Screen Shot 2021-07-27 at 10.34.45.png!
> !Screen Shot 2021-07-27 at 10.34.53.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3535: HBASE-25469 Create RIT servlet in HMaster to track more detailed RIT info not captured in metrics
Apache-HBase commented on pull request #3535: URL: https://github.com/apache/hbase/pull/3535#issuecomment-892098428 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 5s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 49s | master passed | | +1 :green_heart: | compile | 3m 16s | master passed | | +1 :green_heart: | checkstyle | 1m 3s | master passed | | +1 :green_heart: | spotbugs | 2m 10s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 40s | the patch passed | | +1 :green_heart: | compile | 3m 19s | the patch passed | | +1 :green_heart: | javac | 3m 19s | the patch passed | | -0 :warning: | checkstyle | 1m 2s | hbase-server: The patch generated 1 new + 89 unchanged - 0 fixed = 90 total (was 89) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 20m 59s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 2m 55s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 55m 37s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3535 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux e2da1bdc59e9 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f3175c5ab6 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 96 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/4/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bharathv commented on a change in pull request #3535: HBASE-25469 Create RIT servlet in HMaster to track more detailed RIT info not captured in metrics
bharathv commented on a change in pull request #3535: URL: https://github.com/apache/hbase/pull/3535#discussion_r682026570 ## File path: hbase-server/src/main/resources/hbase-webapps/master/rits.jsp ## @@ -69,24 +75,29 @@ Regions in text format Procedures in text format +RIT info as JSON Review comment: Add table and state filters (=null) for completeness? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] caroliney14 commented on pull request #3535: HBASE-25469 Create RIT servlet in HMaster to track more detailed RIT info not captured in metrics
caroliney14 commented on pull request #3535: URL: https://github.com/apache/hbase/pull/3535#issuecomment-892063682 @bharathv ok, I moved the JSON logic into `rit.jsp`. please take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26152) Exclude javax.servlet:servlet-api in hbase-shaded-testing-util
[
https://issues.apache.org/jira/browse/HBASE-26152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392463#comment-17392463
]
Hudson commented on HBASE-26152:
Results for branch branch-2
[build #313 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/313/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/313/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/313/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/313/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/313/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/313//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Exclude javax.servlet:servlet-api in hbase-shaded-testing-util
> --
>
> Key: HBASE-26152
> URL: https://issues.apache.org/jira/browse/HBASE-26152
> Project: HBase
> Issue Type: Task
>Affects Versions: 2.4.0, 2.4.1, 2.4.2, 2.4.3, 2.4.4, 2.4.5
>Reporter: Andrew Kyle Purtell
>Assignee: Peter Somogyi
>Priority: Major
> Fix For: 2.5.0, 2.4.6
>
>
> {noformat}
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running org.apache.hbase.shaded.TestShadedHBaseTestingUtility
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 19.515 s <<< FAILURE! - in
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility
> [ERROR] org.apache.hbase.shaded.TestShadedHBaseTestingUtility Time elapsed:
> 19.513 s <<< ERROR!
> java.io.IOException: Shutting down
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.lang.RuntimeException: Failed construction of Master: class
> org.apache.hadoop.hbase.master.HMasterMultiple exceptions
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.io.IOException: Problem starting http server
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: org.apache.hbase.thirdparty.org.eclipse.jetty.util.MultiException:
> Multiple exceptions
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.lang.NoSuchMethodError:
> javax.servlet.ServletContext.createFilter(Ljava/lang/Class;)Ljavax/servlet/Filter;
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> [INFO]
> [INFO] Results:
> [INFO]
> [ERROR] Errors:
> [ERROR] TestShadedHBaseTestingUtility.setUp:47 » IO Shutting down
> [INFO]
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0
> {noformat}
> The hadoop-common and hadoop-mapreduce-client-app dependencies are leaking
> javax.servlet:servlet-api:2.5.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-26125) Backport HBASE-25401 "Add trace support for async call in rpc client" to branch-2
[
https://issues.apache.org/jira/browse/HBASE-26125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392464#comment-17392464
]
Hudson commented on HBASE-26125:
Results for branch branch-2
[build #313 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/313/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/313/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/313/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/313/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/313/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/313//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Backport HBASE-25401 "Add trace support for async call in rpc client" to
> branch-2
> -
>
> Key: HBASE-26125
> URL: https://issues.apache.org/jira/browse/HBASE-26125
> Project: HBase
> Issue Type: Sub-task
> Components: tracing
>Affects Versions: 2.5.0
>Reporter: Tak-Lon (Stephen) Wu
>Assignee: Tak-Lon (Stephen) Wu
>Priority: Major
> Fix For: 2.5.0
>
>
> [2/17 commits of
> HBASE-22120|https://github.com/apache/hbase/pull/2901/commits], original
> commit of HBASE-25401 was
> [https://github.com/apache/hbase/commit/242028671535dfed67ec13d9ed0d6067f3ccfd04]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25401) Add trace support for async call in rpc client
[
https://issues.apache.org/jira/browse/HBASE-25401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392465#comment-17392465
]
Hudson commented on HBASE-25401:
Results for branch branch-2
[build #313 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/313/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/313/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/313/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/313/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/313/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/313//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Add trace support for async call in rpc client
> --
>
> Key: HBASE-25401
> URL: https://issues.apache.org/jira/browse/HBASE-25401
> Project: HBase
> Issue Type: Sub-task
> Components: Client, rpc, tracing
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0-alpha-1
>
>
> For verifying that OpenTelemetry can deal with async operations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-26165) 2.3.5 listed on website downloads page but row intends to be for 2.3.6
[
https://issues.apache.org/jira/browse/HBASE-26165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392445#comment-17392445
]
Hudson commented on HBASE-26165:
Results for branch master
[build #359 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/359/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/359/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/359/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/359/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> 2.3.5 listed on website downloads page but row intends to be for 2.3.6
> --
>
> Key: HBASE-26165
> URL: https://issues.apache.org/jira/browse/HBASE-26165
> Project: HBase
> Issue Type: Task
> Components: website
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Trivial
> Fix For: 3.0.0-alpha-2
>
>
> Typo on downloads.html. Row is for 2.3.6 but still says 2.3.5.
> Missed in HBASE-26162. PR coming.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-26154) Provide exception metric for quota exceeded and throttling
[
https://issues.apache.org/jira/browse/HBASE-26154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392443#comment-17392443
]
Hudson commented on HBASE-26154:
Results for branch master
[build #359 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/359/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/359/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/359/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/359/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Provide exception metric for quota exceeded and throttling
> --
>
> Key: HBASE-26154
> URL: https://issues.apache.org/jira/browse/HBASE-26154
> Project: HBase
> Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Minor
> Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6
>
>
> We should add metrics for QuotaExceededException and RpcThrottlingException.
> This is something we've found very useful to track as it helps us identify
> bad access patterns in clients.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-26162) Release 2.3.6
[
https://issues.apache.org/jira/browse/HBASE-26162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392444#comment-17392444
]
Hudson commented on HBASE-26162:
Results for branch master
[build #359 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/359/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/359/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/359/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/359/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Release 2.3.6
> -
>
> Key: HBASE-26162
> URL: https://issues.apache.org/jira/browse/HBASE-26162
> Project: HBase
> Issue Type: Task
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 2.3.7
>
> Attachments: image-2021-08-02-09-54-56-469.png
>
>
> 2.3.6RC3 was voted as 2.3.6 release.
> Run the release steps listed here for 2.3.6
> !image-2021-08-02-09-54-56-469.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3552: HBASE-26126 Backport HBASE-25424 "Find a way to config OpenTelemetry …
Apache-HBase commented on pull request #3552: URL: https://github.com/apache/hbase/pull/3552#issuecomment-892033135 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-25853 Compile Tests _ | | +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 35s | HBASE-25853 passed | | +1 :green_heart: | compile | 8m 45s | HBASE-25853 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 22s | the patch passed | | +1 :green_heart: | compile | 8m 45s | the patch passed | | +1 :green_heart: | javac | 8m 45s | the patch passed | | +1 :green_heart: | shellcheck | 0m 2s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 11m 10s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 29s | The patch does not generate ASF License warnings. | | | | 45m 15s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3552 | | Optional Tests | dupname asflicense shellcheck shelldocs javac hadoopcheck xml compile | | uname | Linux 015748b28e92 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-25853 / ca096437d7 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 141 (vs. ulimit of 12500) | | modules | C: hbase-assembly . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/console | | versions | git=2.17.1 maven=3.6.3 shellcheck=0.4.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3550: HBASE-26150 Let region server also carry ClientMetaService
Apache-HBase commented on pull request #3550: URL: https://github.com/apache/hbase/pull/3550#issuecomment-892020752 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 54s | master passed | | +1 :green_heart: | compile | 3m 19s | master passed | | +1 :green_heart: | shadedjars | 9m 17s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 41s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 53s | the patch passed | | +1 :green_heart: | compile | 3m 21s | the patch passed | | +1 :green_heart: | javac | 3m 21s | the patch passed | | +1 :green_heart: | shadedjars | 9m 14s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 42s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 6s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 40s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 0m 50s | hbase-zookeeper in the patch passed. | | -1 :x: | unit | 204m 30s | hbase-server in the patch failed. | | | | 250m 45s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3550 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 89c96543e322 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f3175c5ab6 | | Default Java | AdoptOpenJDK-11.0.10+9 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/3/testReport/ | | Max. process+thread count | 3530 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-zookeeper hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3552: HBASE-26126 Backport HBASE-25424 "Find a way to config OpenTelemetry …
Apache-HBase commented on pull request #3552: URL: https://github.com/apache/hbase/pull/3552#issuecomment-892007244 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-25853 Compile Tests _ | | +0 :ok: | mvndep | 0m 29s | Maven dependency ordering for branch | | -1 :x: | mvninstall | 0m 11s | root in HBASE-25853 failed. | | -1 :x: | compile | 0m 8s | root in HBASE-25853 failed. | | -1 :x: | shadedjars | 0m 6s | branch has 7 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 9s | root in HBASE-25853 failed. | | -0 :warning: | javadoc | 0m 30s | hbase-assembly in HBASE-25853 failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 0m 9s | root in the patch failed. | | -1 :x: | compile | 0m 8s | root in the patch failed. | | -0 :warning: | javac | 0m 8s | root in the patch failed. | | -1 :x: | shadedjars | 0m 6s | patch has 7 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 9s | root in the patch failed. | | -0 :warning: | javadoc | 0m 10s | hbase-assembly in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 0m 9s | root in the patch failed. | | | | 5m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3552 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 7dc294d8d353 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-25853 / ca096437d7 | | Default Java | AdoptOpenJDK-11.0.10+9 | | mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/artifact/yetus-jdk11-hadoop3-check/output/branch-mvninstall-root.txt | | compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/artifact/yetus-jdk11-hadoop3-check/output/branch-compile-root.txt | | shadedjars | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-assembly.txt | | mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt | | compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt | | javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt | | shadedjars | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-assembly.txt | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/testReport/ | | Max. process+thread count | 51 (vs. ulimit of 12500) | | modules | C: . hbase-assembly U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated.
[GitHub] [hbase] taklwu merged pull request #3552: HBASE-26126 Backport HBASE-25424 "Find a way to config OpenTelemetry …
taklwu merged pull request #3552: URL: https://github.com/apache/hbase/pull/3552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] taklwu edited a comment on pull request #3552: HBASE-26126 Backport HBASE-25424 "Find a way to config OpenTelemetry …
taklwu edited a comment on pull request #3552: URL: https://github.com/apache/hbase/pull/3552#issuecomment-892004619 as suggested by @Apache9 Duo in https://github.com/apache/hbase/pull/3529, changing the base to HBASE-25853 as the feature branch of branch-2 for all remaining commits and PR of HBASE-22120, merging as the HEAD is the same as the branch-2 when opening this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] taklwu commented on pull request #3552: HBASE-26126 Backport HBASE-25424 "Find a way to config OpenTelemetry …
taklwu commented on pull request #3552: URL: https://github.com/apache/hbase/pull/3552#issuecomment-892004619 changing the base to HBASE-25853 as the feature branch of branch-2 for all remaining commits and PR of HBASE-22120, merging as the HEAD is the same as the branch-2 when opening this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26158) MiniZooKeeperCluster should not be IA.Public
[ https://issues.apache.org/jira/browse/HBASE-26158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392420#comment-17392420 ] Bharath Vissapragada commented on HBASE-26158: -- As Geoffrey mentioned, we use this class quite extensively as shared ZK test instance across multiple mini clusters and other services. It is a very handy wrapper that is tightly integrated with mini cluster and handles all the boiler plate code for us. We also don't have to worry about curator version compatibility with hbase. > MiniZooKeeperCluster should not be IA.Public > > > Key: HBASE-26158 > URL: https://issues.apache.org/jira/browse/HBASE-26158 > Project: HBase > Issue Type: Sub-task > Components: API, test >Reporter: Duo Zhang >Priority: Major > > End users do not need to test HBase when zookeeper is broken. And if users > want to start only a zookeeper cluster, they can just use curator-test, so I > do not think we should expose this class as IA.Public. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] taklwu commented on pull request #3529: HBASE-26124 Backport HBASE-25373 "Remove HTrace completely in code base and try to make use of OpenTelemetry" to branch-2
taklwu commented on pull request #3529: URL: https://github.com/apache/hbase/pull/3529#issuecomment-891997941 cool, thanks @Apache9 Duo, I will open a feature branch HBASE-25853 based on branch-2 and and open up PRs with all remaining commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3550: HBASE-26150 Let region server also carry ClientMetaService
Apache-HBase commented on pull request #3550: URL: https://github.com/apache/hbase/pull/3550#issuecomment-891981804 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 59s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 52s | master passed | | +1 :green_heart: | compile | 2m 34s | master passed | | +1 :green_heart: | shadedjars | 8m 9s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 31s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 40s | the patch passed | | +1 :green_heart: | compile | 2m 36s | the patch passed | | +1 :green_heart: | javac | 2m 36s | the patch passed | | +1 :green_heart: | shadedjars | 8m 15s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 29s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 45s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 16s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 0m 45s | hbase-zookeeper in the patch passed. | | -1 :x: | unit | 149m 29s | hbase-server in the patch failed. | | | | 191m 55s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3550 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux dd7076410109 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f3175c5ab6 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/3/testReport/ | | Max. process+thread count | 4329 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-zookeeper hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bharathv commented on pull request #3535: HBASE-25469 Create RIT servlet in HMaster to track more detailed RIT info not captured in metrics
bharathv commented on pull request #3535: URL: https://github.com/apache/hbase/pull/3535#issuecomment-891975851 > there already are multiple places where RIT info can be found: the main /master-status page and the rits.jsp page. I don't think it's that confusing what the differences between the different RIT info sources are; the /master-status gives an overview of the RIT, the rits.jsp gives more details in a human-friendly format, and the /rit servlet displays the metrics we want as JSON. there are indeed overlaps between these places, but each has its own purpose that is independent of the other ones. we may choose to display different info in the JSON than on the rits.jsp page (I asked for feedback in this JIRA comment about whether we should consider displaying only RITs over threshold in the JSON, or consider grouping by server name or state in the JSON I'm not convinced by the explanation. I can see how /master-status has a summary in the footer and is a bit different from the other pages but it is usually a common pattern to do something like /rits?type=html /rits?type=json /rits?type=txt etc and all are served by the backing page (especially when they are serving the same information presented in different ways). Not a big deal though, don't want to block the progress here. I'm ok if @apurtell has already +1ed the patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bbeaudreault commented on pull request #3549: HBASE-26160: Configurable disallowlist for live editing of loglevels
bbeaudreault commented on pull request #3549: URL: https://github.com/apache/hbase/pull/3549#issuecomment-891966897 Looks like all checks are passing now. Thanks whoever fixed that :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3549: HBASE-26160: Configurable disallowlist for live editing of loglevels
Apache-HBase commented on pull request #3549: URL: https://github.com/apache/hbase/pull/3549#issuecomment-891943481 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 48s | master passed | | +1 :green_heart: | compile | 0m 33s | master passed | | +1 :green_heart: | checkstyle | 0m 16s | master passed | | +1 :green_heart: | spotbugs | 0m 39s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 49s | the patch passed | | +1 :green_heart: | compile | 0m 31s | the patch passed | | +1 :green_heart: | javac | 0m 31s | the patch passed | | -0 :warning: | checkstyle | 0m 13s | hbase-http: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 18m 50s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 0m 45s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 37m 57s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/5/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3549 | | JIRA Issue | HBASE-26160 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux b3c5d5a56f3f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f3175c5ab6 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-http.txt | | Max. process+thread count | 96 (vs. ulimit of 3) | | modules | C: hbase-http U: hbase-http | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/5/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3549: HBASE-26160: Configurable disallowlist for live editing of loglevels
Apache-HBase commented on pull request #3549: URL: https://github.com/apache/hbase/pull/3549#issuecomment-891936025 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 15s | master passed | | +1 :green_heart: | compile | 0m 22s | master passed | | +1 :green_heart: | shadedjars | 8m 7s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 18s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 18s | the patch passed | | +1 :green_heart: | compile | 0m 21s | the patch passed | | +1 :green_heart: | javac | 0m 21s | the patch passed | | +1 :green_heart: | shadedjars | 8m 11s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 19s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 46s | hbase-http in the patch passed. | | | | 28m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3549 | | JIRA Issue | HBASE-26160 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 8ab0ad7f48a4 4.15.0-151-generic #157-Ubuntu SMP Fri Jul 9 23:07:57 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f3175c5ab6 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/5/testReport/ | | Max. process+thread count | 491 (vs. ulimit of 3) | | modules | C: hbase-http U: hbase-http | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/5/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3549: HBASE-26160: Configurable disallowlist for live editing of loglevels
Apache-HBase commented on pull request #3549: URL: https://github.com/apache/hbase/pull/3549#issuecomment-891935505 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 55s | master passed | | +1 :green_heart: | compile | 0m 20s | master passed | | +1 :green_heart: | shadedjars | 8m 14s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 19s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 42s | the patch passed | | +1 :green_heart: | compile | 0m 21s | the patch passed | | +1 :green_heart: | javac | 0m 21s | the patch passed | | +1 :green_heart: | shadedjars | 8m 29s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 17s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 48s | hbase-http in the patch passed. | | | | 28m 8s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3549 | | JIRA Issue | HBASE-26160 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux c037aff5bce3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f3175c5ab6 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/5/testReport/ | | Max. process+thread count | 542 (vs. ulimit of 3) | | modules | C: hbase-http U: hbase-http | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/5/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bbeaudreault commented on pull request #3549: HBASE-26160: Configurable disallowlist for live editing of loglevels
bbeaudreault commented on pull request #3549: URL: https://github.com/apache/hbase/pull/3549#issuecomment-891893427 @jojochuang not sure why my latest commit did not kick off a re-build. Would you mind kicking one off when you get a chance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3550: HBASE-26150 Let region server also carry ClientMetaService
Apache-HBase commented on pull request #3550: URL: https://github.com/apache/hbase/pull/3550#issuecomment-891886303 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 46s | master passed | | +1 :green_heart: | compile | 6m 14s | master passed | | +1 :green_heart: | checkstyle | 2m 0s | master passed | | +1 :green_heart: | spotbugs | 7m 45s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 44s | the patch passed | | +1 :green_heart: | compile | 6m 14s | the patch passed | | +1 :green_heart: | cc | 6m 14s | the patch passed | | +1 :green_heart: | javac | 6m 14s | the patch passed | | -0 :warning: | checkstyle | 1m 6s | hbase-server: The patch generated 1 new + 172 unchanged - 7 fixed = 173 total (was 179) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 18m 26s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | hbaseprotoc | 2m 19s | the patch passed | | +1 :green_heart: | spotbugs | 8m 33s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 49s | The patch does not generate ASF License warnings. | | | | 71m 59s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3550 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool | | uname | Linux f8ad221f3b61 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f3175c5ab6 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 96 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-zookeeper hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/3/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3549: HBASE-26160: Configurable disallowlist for live editing of loglevels
Apache-HBase commented on pull request #3549: URL: https://github.com/apache/hbase/pull/3549#issuecomment-891880540 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 13s | master passed | | +1 :green_heart: | compile | 0m 22s | master passed | | +1 :green_heart: | shadedjars | 8m 14s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 19s | master passed | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 1m 57s | root in the patch failed. | | -1 :x: | compile | 0m 13s | hbase-http in the patch failed. | | -0 :warning: | javac | 0m 13s | hbase-http in the patch failed. | | -1 :x: | shadedjars | 4m 9s | patch has 10 errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 18s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 0m 13s | hbase-http in the patch failed. | | | | 21m 45s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3549 | | JIRA Issue | HBASE-26160 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux db8950b5f3cf 4.15.0-151-generic #157-Ubuntu SMP Fri Jul 9 23:07:57 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f3175c5ab6 | | Default Java | AdoptOpenJDK-11.0.10+9 | | mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/4/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt | | compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/4/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-http.txt | | javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/4/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-http.txt | | shadedjars | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/4/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-http.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/4/testReport/ | | Max. process+thread count | 100 (vs. ulimit of 3) | | modules | C: hbase-http U: hbase-http | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3549: HBASE-26160: Configurable disallowlist for live editing of loglevels
Apache-HBase commented on pull request #3549: URL: https://github.com/apache/hbase/pull/3549#issuecomment-891879768 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 39s | master passed | | +1 :green_heart: | compile | 0m 21s | master passed | | +1 :green_heart: | shadedjars | 8m 12s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 17s | master passed | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 1m 39s | root in the patch failed. | | -1 :x: | compile | 0m 13s | hbase-http in the patch failed. | | -0 :warning: | javac | 0m 13s | hbase-http in the patch failed. | | -1 :x: | shadedjars | 4m 8s | patch has 10 errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 16s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 0m 14s | hbase-http in the patch failed. | | | | 20m 47s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3549 | | JIRA Issue | HBASE-26160 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 66bfeb5dfce2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f3175c5ab6 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/4/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt | | compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/4/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-http.txt | | javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/4/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-http.txt | | shadedjars | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/4/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-http.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/4/testReport/ | | Max. process+thread count | 88 (vs. ulimit of 3) | | modules | C: hbase-http U: hbase-http | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3552: HBASE-26126 Backport HBASE-25424 "Find a way to config OpenTelemetry …
Apache-HBase commented on pull request #3552: URL: https://github.com/apache/hbase/pull/3552#issuecomment-891879144 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 27s | branch-2 passed | | +1 :green_heart: | compile | 2m 19s | branch-2 passed | | +1 :green_heart: | shadedjars | 6m 23s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 25s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 19s | the patch passed | | +1 :green_heart: | compile | 2m 11s | the patch passed | | +1 :green_heart: | javac | 2m 11s | the patch passed | | +1 :green_heart: | shadedjars | 6m 26s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 25s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 309m 45s | root in the patch failed. | | | | 343m 56s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3552 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux e46d835fb084 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / ca096437d7 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/2/testReport/ | | Max. process+thread count | 5049 (vs. ulimit of 12500) | | modules | C: hbase-assembly . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3549: HBASE-26160: Configurable disallowlist for live editing of loglevels
Apache-HBase commented on pull request #3549: URL: https://github.com/apache/hbase/pull/3549#issuecomment-891875247 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 8s | master passed | | +1 :green_heart: | compile | 0m 28s | master passed | | +1 :green_heart: | checkstyle | 0m 11s | master passed | | +1 :green_heart: | spotbugs | 0m 31s | master passed | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 1m 44s | root in the patch failed. | | -1 :x: | compile | 0m 10s | hbase-http in the patch failed. | | -0 :warning: | javac | 0m 10s | hbase-http in the patch failed. | | -0 :warning: | checkstyle | 0m 10s | hbase-http: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | -1 :x: | hadoopcheck | 1m 38s | The patch causes 10 errors with Hadoop v3.1.2. | | -1 :x: | hadoopcheck | 3m 16s | The patch causes 10 errors with Hadoop v3.2.1. | | -1 :x: | hadoopcheck | 4m 51s | The patch causes 10 errors with Hadoop v3.3.0. | | -1 :x: | spotbugs | 0m 10s | hbase-http in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 8s | The patch does not generate ASF License warnings. | | | | 15m 12s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3549 | | JIRA Issue | HBASE-26160 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux e08bffda063c 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f3175c5ab6 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/4/artifact/yetus-general-check/output/patch-mvninstall-root.txt | | compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/4/artifact/yetus-general-check/output/patch-compile-hbase-http.txt | | javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/4/artifact/yetus-general-check/output/patch-compile-hbase-http.txt | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-http.txt | | hadoopcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/4/artifact/yetus-general-check/output/patch-javac-3.1.2.txt | | hadoopcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/4/artifact/yetus-general-check/output/patch-javac-3.2.1.txt | | hadoopcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/4/artifact/yetus-general-check/output/patch-javac-3.3.0.txt | | spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/4/artifact/yetus-general-check/output/patch-spotbugs-hbase-http.txt | | Max. process+thread count | 86 (vs. ulimit of 3) | | modules | C: hbase-http U: hbase-http | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/4/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3549: HBASE-26160: Configurable disallowlist for live editing of loglevels
Apache-HBase commented on pull request #3549: URL: https://github.com/apache/hbase/pull/3549#issuecomment-891862358 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 57s | master passed | | +1 :green_heart: | compile | 0m 20s | master passed | | +1 :green_heart: | shadedjars | 8m 16s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 19s | master passed | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 1m 40s | root in the patch failed. | | -1 :x: | compile | 0m 13s | hbase-http in the patch failed. | | -0 :warning: | javac | 0m 13s | hbase-http in the patch failed. | | -1 :x: | shadedjars | 4m 10s | patch has 10 errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 17s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 0m 14s | hbase-http in the patch failed. | | | | 25m 13s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3549 | | JIRA Issue | HBASE-26160 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux aecc140b5081 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f3175c5ab6 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/3/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt | | compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/3/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-http.txt | | javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/3/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-http.txt | | shadedjars | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/3/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-http.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/3/testReport/ | | Max. process+thread count | 88 (vs. ulimit of 3) | | modules | C: hbase-http U: hbase-http | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3549: HBASE-26160: Configurable disallowlist for live editing of loglevels
Apache-HBase commented on pull request #3549: URL: https://github.com/apache/hbase/pull/3549#issuecomment-891860151 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 33s | master passed | | +1 :green_heart: | compile | 0m 22s | master passed | | +1 :green_heart: | shadedjars | 8m 21s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 21s | master passed | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 1m 55s | root in the patch failed. | | -1 :x: | compile | 0m 14s | hbase-http in the patch failed. | | -0 :warning: | javac | 0m 14s | hbase-http in the patch failed. | | -1 :x: | shadedjars | 4m 12s | patch has 10 errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 18s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 0m 14s | hbase-http in the patch failed. | | | | 22m 14s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3549 | | JIRA Issue | HBASE-26160 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux c92bc693c51b 4.15.0-151-generic #157-Ubuntu SMP Fri Jul 9 23:07:57 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f3175c5ab6 | | Default Java | AdoptOpenJDK-11.0.10+9 | | mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/3/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt | | compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/3/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-http.txt | | javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/3/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-http.txt | | shadedjars | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/3/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-http.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/3/testReport/ | | Max. process+thread count | 97 (vs. ulimit of 3) | | modules | C: hbase-http U: hbase-http | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bbeaudreault edited a comment on pull request #3549: HBASE-26160: Configurable disallowlist for live editing of loglevels
bbeaudreault edited a comment on pull request #3549: URL: https://github.com/apache/hbase/pull/3549#issuecomment-891857680 @jojochuang let me know if this looks good with the latest commit. If so, I'll squash and clean up the commits for merging. I'd also like to get this merged into branch-2 and branch-2.4. The LogLevel changes apply cleanly, but TestLogLevel has a bunch of merge conflicts. I'll need to submit a PR which reconciles those once ready. I think the latest test failure is because I force pushed as the build was starting. Hopefully will succeed on re-run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bbeaudreault commented on pull request #3549: HBASE-26160: Configurable disallowlist for live editing of loglevels
bbeaudreault commented on pull request #3549: URL: https://github.com/apache/hbase/pull/3549#issuecomment-891857680 @jojochuang let me know if this looks good with the latest commit. If so, I'll squash and clean up the commits for merging. I'd also like to get this merged into branch-2 and branch-2.4. The LogLevel changes apply cleanly, but TestLogLevel has a bunch of merge conflicts. I'll need to submit a PR which reconciles those once ready. I think the latest test failure is because I force pushed as the build was starting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3549: HBASE-26160: Configurable disallowlist for live editing of loglevels
Apache-HBase commented on pull request #3549: URL: https://github.com/apache/hbase/pull/3549#issuecomment-891855220 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 20s | master passed | | +1 :green_heart: | compile | 0m 31s | master passed | | +1 :green_heart: | checkstyle | 0m 14s | master passed | | +1 :green_heart: | spotbugs | 0m 35s | master passed | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 1m 45s | root in the patch failed. | | -1 :x: | compile | 0m 10s | hbase-http in the patch failed. | | -0 :warning: | javac | 0m 10s | hbase-http in the patch failed. | | -0 :warning: | checkstyle | 0m 11s | hbase-http: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | -1 :x: | hadoopcheck | 1m 36s | The patch causes 10 errors with Hadoop v3.1.2. | | -1 :x: | hadoopcheck | 3m 15s | The patch causes 10 errors with Hadoop v3.2.1. | | -1 :x: | hadoopcheck | 4m 55s | The patch causes 10 errors with Hadoop v3.3.0. | | -1 :x: | spotbugs | 0m 10s | hbase-http in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 15m 39s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3549 | | JIRA Issue | HBASE-26160 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux d07bcb77d02f 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f3175c5ab6 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/3/artifact/yetus-general-check/output/patch-mvninstall-root.txt | | compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/3/artifact/yetus-general-check/output/patch-compile-hbase-http.txt | | javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/3/artifact/yetus-general-check/output/patch-compile-hbase-http.txt | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-http.txt | | hadoopcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/3/artifact/yetus-general-check/output/patch-javac-3.1.2.txt | | hadoopcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/3/artifact/yetus-general-check/output/patch-javac-3.2.1.txt | | hadoopcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/3/artifact/yetus-general-check/output/patch-javac-3.3.0.txt | | spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/3/artifact/yetus-general-check/output/patch-spotbugs-hbase-http.txt | | Max. process+thread count | 86 (vs. ulimit of 3) | | modules | C: hbase-http U: hbase-http | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/3/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-26166) table list in master ui has a minor bug
[ https://issues.apache.org/jira/browse/HBASE-26166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ruanhui updated HBASE-26166: Attachment: (was: image-2021-08-03-13-09-24-030.png) > table list in master ui has a minor bug > --- > > Key: HBASE-26166 > URL: https://issues.apache.org/jira/browse/HBASE-26166 > Project: HBase > Issue Type: Bug > Components: UI >Affects Versions: 2.4.5 >Reporter: ruanhui >Assignee: ruanhui >Priority: Minor > Attachments: image-2021-08-03-20-20-25-352.png > > > !image-2021-08-03-20-20-25-352.png|width=931,height=162! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] bbeaudreault commented on a change in pull request #3549: HBASE-26160: Configurable disallowlist for live editing of loglevels
bbeaudreault commented on a change in pull request #3549:
URL: https://github.com/apache/hbase/pull/3549#discussion_r681759233
##
File path:
hbase-http/src/main/java/org/apache/hadoop/hbase/http/log/LogLevel.java
##
@@ -360,6 +368,18 @@ public void doGet(HttpServletRequest request,
HttpServletResponse response)
out.close();
}
+private boolean isLogLevelChangeAllowed(String logger, String[]
readOnlyLogLevels) {
+ if (readOnlyLogLevels == null) {
+return true;
+ }
+ for (String readOnlyLogLevel : readOnlyLogLevels) {
+if (readOnlyLogLevel.startsWith(logger)) {
Review comment:
Good catch. Fixed and added a test.
As you may have anticipated in your original comment about response code
verification, this meant I needed to update LogLevel to use `setStatus` as you
said :). This meant having to validate the response in the CLI, which is used
in in the test. These were minor tweaks, but you'll see them in the latest
commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-26158) MiniZooKeeperCluster should not be IA.Public
[ https://issues.apache.org/jira/browse/HBASE-26158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392297#comment-17392297 ] Duo Zhang commented on HBASE-26158: --- The project name tells everything, we are ‘HBase’, not ‘Zookeeper’, and on your problem, if it is something about how to config HBase to make use of an external zookeeper, then it certainly should be asked in HBase community. If you ask something about the TestingServer itself, then you should ask the curator community. IMO, if you ask something about MiniZookeeperCluster in the HBase community, you will likely get an answer about just use TestingServer in curator. On why MiniZookeeperCluster is IA.Public, it is easy, HBTU is public in the past, so in general all the related things you can get from HBTU should be IA.Public, and finally we found that this is not the correct way, this is why we have the parent issue here. And on the changing of the existing testing code, we can copy the code to HBase-testing-util module and keep it for the whole 3.x, so you have plenty of time to change you code. And finally, you can use IA.Private class in HBase, no one can stop you, just like what we have done in HBase to implement AsyncWAL, we used a lot of internal classes in Hadoop. Just take your own risk. And I really do not see any problems that we have our own internal test way while providing another way for end users. We need to test internal of HBase, so we need to expose lots of internal stuff in our own testing framework, but I do not think we need to expose this to end users, and end users should not rely on this. Maybe in the future we may change some internal implementations and lots of UTs are not useful any more, but since the we have exposed the internal stuff in HBTU then we can not change our code? That’s really painful. But if we changed HBTU in this way, or just keep the interface the same but the behavior is completely changed, then what is the idfference between marking it IA.Public and IA.Private? > MiniZooKeeperCluster should not be IA.Public > > > Key: HBASE-26158 > URL: https://issues.apache.org/jira/browse/HBASE-26158 > Project: HBase > Issue Type: Sub-task > Components: API, test >Reporter: Duo Zhang >Priority: Major > > End users do not need to test HBase when zookeeper is broken. And if users > want to start only a zookeeper cluster, they can just use curator-test, so I > do not think we should expose this class as IA.Public. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3552: HBASE-26126 Backport HBASE-25424 "Find a way to config OpenTelemetry …
Apache-HBase commented on pull request #3552: URL: https://github.com/apache/hbase/pull/3552#issuecomment-891836221 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 18s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 10s | branch-2 passed | | +1 :green_heart: | compile | 3m 22s | branch-2 passed | | +1 :green_heart: | shadedjars | 8m 27s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 25s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 0s | the patch passed | | +1 :green_heart: | compile | 3m 21s | the patch passed | | +1 :green_heart: | javac | 3m 21s | the patch passed | | +1 :green_heart: | shadedjars | 8m 27s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 31s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 242m 31s | root in the patch passed. | | | | 288m 6s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3552 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 1992cb733be9 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / ca096437d7 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/2/testReport/ | | Max. process+thread count | 3919 (vs. ulimit of 12500) | | modules | C: hbase-assembly . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26158) MiniZooKeeperCluster should not be IA.Public
[ https://issues.apache.org/jira/browse/HBASE-26158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392282#comment-17392282 ] Geoffrey Jacoby commented on HBASE-26158: - You keep saying "HBase is not designed to do X" but not providing evidence. HBase is the result of many people's decisions and designs -- how do you know it's not designed to do this? The code and annotation certainly indicates it was, and the code is the concrete form of a design. The problem with having HBase continue to use MiniZookeeperCluster internally, but allowing TestingServer to be passed in via config, is that it makes tests using it that way unsupported. My worry is that if I have a problem, the HBase community might say, "TestingServer is owned by curator, we don't use it at all, so go ask the Curator community", while the Curator community would know nothing about the HBase minicluster, and probably point me back to HBase. Now, if we want the HBase minicluster to formally adopt curator-test internally and deprecate MiniZookeeperCluster because MiniZookeeperCluster is now redundant given curator-test's existence, that sounds fine -- but having a supported option for internal tests and an unsupported option for end-user tests just seems like it would lead to lots of problems for end-users. > MiniZooKeeperCluster should not be IA.Public > > > Key: HBASE-26158 > URL: https://issues.apache.org/jira/browse/HBASE-26158 > Project: HBase > Issue Type: Sub-task > Components: API, test >Reporter: Duo Zhang >Priority: Major > > End users do not need to test HBase when zookeeper is broken. And if users > want to start only a zookeeper cluster, they can just use curator-test, so I > do not think we should expose this class as IA.Public. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] ddupg commented on pull request #3477: HBASE-26084 Add owner of replication queue for ReplicationQueueInfo
ddupg commented on pull request #3477: URL: https://github.com/apache/hbase/pull/3477#issuecomment-891823320 > Do we have a section in the design doc about how to deal with this? This is [simple description of how to schedule the queue](https://docs.google.com/document/d/16kRPVGctFSf__nC3yaVZmAm3GTxIbHefekKC_rMmTw8/edit#heading=h.wtxjomhvlfx9). The current implementation is that Master uses a chore to check and schedule queues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26158) MiniZooKeeperCluster should not be IA.Public
[ https://issues.apache.org/jira/browse/HBASE-26158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392278#comment-17392278 ] Duo Zhang commented on HBASE-26158: --- Filed HBASE-26167. > MiniZooKeeperCluster should not be IA.Public > > > Key: HBASE-26158 > URL: https://issues.apache.org/jira/browse/HBASE-26158 > Project: HBase > Issue Type: Sub-task > Components: API, test >Reporter: Duo Zhang >Priority: Major > > End users do not need to test HBase when zookeeper is broken. And if users > want to start only a zookeeper cluster, they can just use curator-test, so I > do not think we should expose this class as IA.Public. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-26167) Allow users to not start zookeeper and dfs cluster when using TestingHBaseCluster
Duo Zhang created HBASE-26167: - Summary: Allow users to not start zookeeper and dfs cluster when using TestingHBaseCluster Key: HBASE-26167 URL: https://issues.apache.org/jira/browse/HBASE-26167 Project: HBase Issue Type: Sub-task Reporter: Duo Zhang Users may start zookeeper and dfs cluster outside TestingHBaseCluster to make different components share the same zookeeper and dfs cluster. We should allow users to not start zookeeper and dfs cluster when using TestingHBaseCluster, and maybe we could provide utility class to let users easily set the configurations to switch to external zookeeper and dfs cluster. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work started] (HBASE-26089) Support RegionCoprocessor on CompactionServer
[ https://issues.apache.org/jira/browse/HBASE-26089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-26089 started by Yulin Niu. - > Support RegionCoprocessor on CompactionServer > - > > Key: HBASE-26089 > URL: https://issues.apache.org/jira/browse/HBASE-26089 > Project: HBase > Issue Type: Sub-task >Reporter: Yulin Niu >Assignee: Yulin Niu >Priority: Major > > We have two kinds of RegionCoprocessor: CoreCoprocessor or not. > 1.The CoreCoprocessor(AccessController, TokenProvider, > SecureBulkLoadEndpoint...), They have RegionEnvironmentForCoreCoprocessors > which expose RegionServerServices. And they involve authorization, > permission, etc, We don't need to support these CoreCoprocessor on > compactionServer > 2. Not CoreCoprocessor: They have RegionEnvironment which do not expose > RegionServerServices, only offer Connection/ OnlineRegions, We can propose > RegionEnvironmentOnCS, offer Connection, but the OnlineRegions may leave to > discuss -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work started] (HBASE-26045) Master control the global throughtput of all compaction servers
[ https://issues.apache.org/jira/browse/HBASE-26045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-26045 started by Yulin Niu. - > Master control the global throughtput of all compaction servers > --- > > Key: HBASE-26045 > URL: https://issues.apache.org/jira/browse/HBASE-26045 > Project: HBase > Issue Type: Sub-task >Reporter: Yulin Niu >Assignee: Yulin Niu >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work started] (HBASE-26076) Support favoredNodes when do compaction offload
[ https://issues.apache.org/jira/browse/HBASE-26076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-26076 started by Yulin Niu. - > Support favoredNodes when do compaction offload > --- > > Key: HBASE-26076 > URL: https://issues.apache.org/jira/browse/HBASE-26076 > Project: HBase > Issue Type: Sub-task >Reporter: Yulin Niu >Assignee: Yulin Niu >Priority: Major > > 1.If we have favoredNodes for region, We use this policy > 2.If we not have favoredNodes, we add the regionServer request compaction as > favoredNodes when do compact on compaction server, to guarantee locality -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-26158) MiniZooKeeperCluster should not be IA.Public
[
https://issues.apache.org/jira/browse/HBASE-26158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392276#comment-17392276
]
Duo Zhang commented on HBASE-26158:
---
{quote}
The reason why we can't use curator-test is that there's no way I can see to
inject HBaseTestingUtility with a curator-test TestingServer instead of an
MiniZookeeperCluster. So we have to inject a MiniZookeeperCluster into the
custom process's in-process test harness. The test just wouldn't work with
curator-test.
{quote}
So the solution is very clear then. We could provide configs for
TestingHBaseCluster to not start a mini zookeeper cluster and the mini dfs
cluster. And I need to correct you that, you do not need to inject the HBTU
with a curator-test TestingServer, you just need to set configurations to let
HBase use the zookeeper you start outside HBTU, it is 'hbase.zookeeper.quorum'.
You need to set this when actually starting a hbase cluster in production
right? Just set it in UT too.
Again, HBase is not designed to provide a utility class to start zookeeper, it
is the duty for the zookeeper related projects.
Thanks.
> MiniZooKeeperCluster should not be IA.Public
>
>
> Key: HBASE-26158
> URL: https://issues.apache.org/jira/browse/HBASE-26158
> Project: HBase
> Issue Type: Sub-task
> Components: API, test
>Reporter: Duo Zhang
>Priority: Major
>
> End users do not need to test HBase when zookeeper is broken. And if users
> want to start only a zookeeper cluster, they can just use curator-test, so I
> do not think we should expose this class as IA.Public.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-26165) 2.3.5 listed on website downloads page but row intends to be for 2.3.6
[ https://issues.apache.org/jira/browse/HBASE-26165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-26165: -- Fix Version/s: 3.0.0-alpha-2 Resolution: Fixed Status: Resolved (was: Patch Available) > 2.3.5 listed on website downloads page but row intends to be for 2.3.6 > -- > > Key: HBASE-26165 > URL: https://issues.apache.org/jira/browse/HBASE-26165 > Project: HBase > Issue Type: Task > Components: website >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Trivial > Fix For: 3.0.0-alpha-2 > > > Typo on downloads.html. Row is for 2.3.6 but still says 2.3.5. > Missed in HBASE-26162. PR coming. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] petersomogyi merged pull request #3551: HBASE-26165 Fix the 2.3.6 downloads page version column
petersomogyi merged pull request #3551: URL: https://github.com/apache/hbase/pull/3551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26158) MiniZooKeeperCluster should not be IA.Public
[ https://issues.apache.org/jira/browse/HBASE-26158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392269#comment-17392269 ] Geoffrey Jacoby commented on HBASE-26158: - A correction: the Kafka minicluster in my example above is using the Kafka EmbeddedZookeeper class and not sharing a ZK quorum with the HBase minicluster or custom process. (Which do share with each other) So let's ignore it for this discussion. The reason why we can't use curator-test is that there's no way I can see to inject HBaseTestingUtility with a curator-test TestingServer instead of an MiniZookeeperCluster. So we have to inject a MiniZookeeperCluster into the custom process's in-process test harness. The test just wouldn't work with curator-test. (There _definitely_ isn't a way to do it with the TestingHBaseCluster, which is one of many reasons I proposed HBASE-26115.) HBase didn't have a "duty" to make MiniZookeeperCluster -- it could use curator-test internally and allow tests to inject a TestingServer in the HBTU -- but it did, and deliberately exposed it as IA.Public, and downstream users are allowed to rely on that. It _is_ literally designed to allow end users the ability to start a ZK to write UT. That's what IA.Public means. :-) > MiniZooKeeperCluster should not be IA.Public > > > Key: HBASE-26158 > URL: https://issues.apache.org/jira/browse/HBASE-26158 > Project: HBase > Issue Type: Sub-task > Components: API, test >Reporter: Duo Zhang >Priority: Major > > End users do not need to test HBase when zookeeper is broken. And if users > want to start only a zookeeper cluster, they can just use curator-test, so I > do not think we should expose this class as IA.Public. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-26166) table list in master ui has a minor bug
[ https://issues.apache.org/jira/browse/HBASE-26166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guangxu Cheng updated HBASE-26166: -- Attachment: image-2021-08-03-20-20-25-352.png > table list in master ui has a minor bug > --- > > Key: HBASE-26166 > URL: https://issues.apache.org/jira/browse/HBASE-26166 > Project: HBase > Issue Type: Bug > Components: UI >Affects Versions: 2.4.5 >Reporter: ruanhui >Assignee: ruanhui >Priority: Minor > Attachments: image-2021-08-03-13-09-24-030.png, > image-2021-08-03-20-20-25-352.png > > > !image-2021-08-03-13-09-24-030.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-26166) table list in master ui has a minor bug
[ https://issues.apache.org/jira/browse/HBASE-26166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guangxu Cheng updated HBASE-26166: -- Description: !image-2021-08-03-20-20-25-352.png|width=931,height=162! (was: !image-2021-08-03-13-09-24-030.png!) > table list in master ui has a minor bug > --- > > Key: HBASE-26166 > URL: https://issues.apache.org/jira/browse/HBASE-26166 > Project: HBase > Issue Type: Bug > Components: UI >Affects Versions: 2.4.5 >Reporter: ruanhui >Assignee: ruanhui >Priority: Minor > Attachments: image-2021-08-03-13-09-24-030.png, > image-2021-08-03-20-20-25-352.png > > > !image-2021-08-03-20-20-25-352.png|width=931,height=162! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] shahrs87 commented on a change in pull request #3518: HBASE-25881: Create a chore to update age related metrics
shahrs87 commented on a change in pull request #3518:
URL: https://github.com/apache/hbase/pull/3518#discussion_r681702358
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceRefresherChore.java
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.replication.regionserver;
+
+import java.util.Map;
+import java.util.concurrent.PriorityBlockingQueue;
+
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hbase.ScheduledChore;
+import org.apache.hadoop.hbase.Stoppable;
+import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
+import org.apache.hadoop.hbase.wal.AbstractFSWALProvider;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.yetus.audience.InterfaceStability;
+
+/**
+ * The Class MetricsReplicationSourceRefresherChore for refreshing age related
replication source
+ * metrics
+ */
+@InterfaceAudience.Private
+@InterfaceStability.Evolving
+public class MetricsReplicationSourceRefresherChore extends ScheduledChore {
+
+ private ReplicationSource replicationSource;
+
+ private MetricsSource metrics;
+
+ public static final String DURATION =
"hbase.metrics.replication.source.refresher.duration";
+ public static final int DEFAULT_DURATION_MILLISECONDS = 6;
+
+ public MetricsReplicationSourceRefresherChore(Stoppable stopper,
+ ReplicationSource replicationSource) {
+this(DEFAULT_DURATION_MILLISECONDS, stopper, replicationSource);
+ }
+
+ public MetricsReplicationSourceRefresherChore(int duration, Stoppable
stopper,
+ ReplicationSource replicationSource) {
+super("MetricsSourceRefresherChore", stopper, duration);
+this.replicationSource = replicationSource;
+this.metrics = this.replicationSource.getSourceMetrics();
+ }
+
+ @Override
+ protected void chore() {
+this.metrics.setOldestWalAge(getOldestWalAge());
+ }
+
+ /*
+ * Returns the age of oldest wal.
+ */
+ long getOldestWalAge() {
Review comment:
@rahulLiving There are many `age` related metrics in Replication
subsytem. We want to update all the metrics from this Chore. I don't think it
is a good idea to move the implementation from ReplicationSourceLogQueue to
here.
What I had in my mind is: Compute `oldestWalTimestamp` (not the age, just
the timestamp) in `ReplicationSourceLogQueue` and keep it as a class variable.
Don't calculate the age there. Instead calculate the age in this chore. So for
some reason if Replication thread is stuck, it will not update
`oldestWalTimestamp` and since age is calculated in this chore, it will be
updated. Does that make sense ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
