[jira] [Commented] (HBASE-28329) Output hbase logs to working directory in client integration test

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810721#comment-17810721
 ] 

ASF GitHub Bot commented on HBASE-28329:


NihalJain commented on code in PR #5648:
URL: https://github.com/apache/hbase/pull/5648#discussion_r1465930203


##
dev-support/hbase_nightly_pseudo-distributed-test.sh:
##
@@ -324,7 +324,7 @@ redirect_and_run "${working_dir}/hadoop_cluster_smoke" \
 "${hadoop_exec}" --config "${working_dir}/hbase-conf/" fs -ls -R /
 
 echo "Starting up HBase"
-HBASE_CONF_DIR="${working_dir}/hbase-conf/" 
"${component_install}/bin/start-hbase.sh"
+HBASE_CONF_DIR="${working_dir}/hbase-conf/" HBASE_LOG_DIR="${working_dir}" 
"${component_install}/bin/start-hbase.sh"

Review Comment:
   Ah cool. i'm fine with this.





> Output hbase logs to working directory in client integration test
> -
>
> Key: HBASE-28329
> URL: https://issues.apache.org/jira/browse/HBASE-28329
> Project: HBase
>  Issue Type: Task
>  Components: jenkins, scripts
>Reporter: Duo Zhang
>Priority: Major
>
> So we can see them in the job artifacts, currently it will be logged to hbase 
> install directory which is outside the working dir so we can not see them.
> The client integration test for master branch is failing because can not 
> start hbase cluster, we need the logs to find out the root cause.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] HBASE-28329 Output hbase logs to working directory in client integrat… [hbase]

2024-01-24 Thread via GitHub


NihalJain commented on code in PR #5648:
URL: https://github.com/apache/hbase/pull/5648#discussion_r1465930203


##
dev-support/hbase_nightly_pseudo-distributed-test.sh:
##
@@ -324,7 +324,7 @@ redirect_and_run "${working_dir}/hadoop_cluster_smoke" \
 "${hadoop_exec}" --config "${working_dir}/hbase-conf/" fs -ls -R /
 
 echo "Starting up HBase"
-HBASE_CONF_DIR="${working_dir}/hbase-conf/" 
"${component_install}/bin/start-hbase.sh"
+HBASE_CONF_DIR="${working_dir}/hbase-conf/" HBASE_LOG_DIR="${working_dir}" 
"${component_install}/bin/start-hbase.sh"

Review Comment:
   Ah cool. i'm fine with this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-28329) Output hbase logs to working directory in client integration test

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810714#comment-17810714
 ] 

ASF GitHub Bot commented on HBASE-28329:


Apache9 commented on code in PR #5648:
URL: https://github.com/apache/hbase/pull/5648#discussion_r1465920494


##
dev-support/hbase_nightly_pseudo-distributed-test.sh:
##
@@ -324,7 +324,7 @@ redirect_and_run "${working_dir}/hadoop_cluster_smoke" \
 "${hadoop_exec}" --config "${working_dir}/hbase-conf/" fs -ls -R /
 
 echo "Starting up HBase"
-HBASE_CONF_DIR="${working_dir}/hbase-conf/" 
"${component_install}/bin/start-hbase.sh"
+HBASE_CONF_DIR="${working_dir}/hbase-conf/" HBASE_LOG_DIR="${working_dir}" 
"${component_install}/bin/start-hbase.sh"

Review Comment:
   We just output the related logs to working_dir
   
   
https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/972/artifact/output-integration/hadoop-3/





> Output hbase logs to working directory in client integration test
> -
>
> Key: HBASE-28329
> URL: https://issues.apache.org/jira/browse/HBASE-28329
> Project: HBase
>  Issue Type: Task
>  Components: jenkins, scripts
>Reporter: Duo Zhang
>Priority: Major
>
> So we can see them in the job artifacts, currently it will be logged to hbase 
> install directory which is outside the working dir so we can not see them.
> The client integration test for master branch is failing because can not 
> start hbase cluster, we need the logs to find out the root cause.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] HBASE-28329 Output hbase logs to working directory in client integrat… [hbase]

2024-01-24 Thread via GitHub


Apache9 commented on code in PR #5648:
URL: https://github.com/apache/hbase/pull/5648#discussion_r1465920494


##
dev-support/hbase_nightly_pseudo-distributed-test.sh:
##
@@ -324,7 +324,7 @@ redirect_and_run "${working_dir}/hadoop_cluster_smoke" \
 "${hadoop_exec}" --config "${working_dir}/hbase-conf/" fs -ls -R /
 
 echo "Starting up HBase"
-HBASE_CONF_DIR="${working_dir}/hbase-conf/" 
"${component_install}/bin/start-hbase.sh"
+HBASE_CONF_DIR="${working_dir}/hbase-conf/" HBASE_LOG_DIR="${working_dir}" 
"${component_install}/bin/start-hbase.sh"

Review Comment:
   We just output the related logs to working_dir
   
   
https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/972/artifact/output-integration/hadoop-3/



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-28329) Output hbase logs to working directory in client integration test

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810710#comment-17810710
 ] 

ASF GitHub Bot commented on HBASE-28329:


NihalJain commented on code in PR #5648:
URL: https://github.com/apache/hbase/pull/5648#discussion_r1465915201


##
dev-support/hbase_nightly_pseudo-distributed-test.sh:
##
@@ -324,7 +324,7 @@ redirect_and_run "${working_dir}/hadoop_cluster_smoke" \
 "${hadoop_exec}" --config "${working_dir}/hbase-conf/" fs -ls -R /
 
 echo "Starting up HBase"
-HBASE_CONF_DIR="${working_dir}/hbase-conf/" 
"${component_install}/bin/start-hbase.sh"
+HBASE_CONF_DIR="${working_dir}/hbase-conf/" HBASE_LOG_DIR="${working_dir}" 
"${component_install}/bin/start-hbase.sh"

Review Comment:
   nit: should this not be ${working _dir}/logs?





> Output hbase logs to working directory in client integration test
> -
>
> Key: HBASE-28329
> URL: https://issues.apache.org/jira/browse/HBASE-28329
> Project: HBase
>  Issue Type: Task
>  Components: jenkins, scripts
>Reporter: Duo Zhang
>Priority: Major
>
> So we can see them in the job artifacts, currently it will be logged to hbase 
> install directory which is outside the working dir so we can not see them.
> The client integration test for master branch is failing because can not 
> start hbase cluster, we need the logs to find out the root cause.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] HBASE-28329 Output hbase logs to working directory in client integrat… [hbase]

2024-01-24 Thread via GitHub


NihalJain commented on code in PR #5648:
URL: https://github.com/apache/hbase/pull/5648#discussion_r1465915201


##
dev-support/hbase_nightly_pseudo-distributed-test.sh:
##
@@ -324,7 +324,7 @@ redirect_and_run "${working_dir}/hadoop_cluster_smoke" \
 "${hadoop_exec}" --config "${working_dir}/hbase-conf/" fs -ls -R /
 
 echo "Starting up HBase"
-HBASE_CONF_DIR="${working_dir}/hbase-conf/" 
"${component_install}/bin/start-hbase.sh"
+HBASE_CONF_DIR="${working_dir}/hbase-conf/" HBASE_LOG_DIR="${working_dir}" 
"${component_install}/bin/start-hbase.sh"

Review Comment:
   nit: should this not be ${working _dir}/logs?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-28329) Output hbase logs to working directory in client integration test

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810706#comment-17810706
 ] 

ASF GitHub Bot commented on HBASE-28329:


Apache-HBase commented on PR #5648:
URL: https://github.com/apache/hbase/pull/5648#issuecomment-1909447623

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 24s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +0 :ok: |  shelldocs  |   0m  0s |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  spotless  |   0m 38s |  branch has no errors when 
running spotless:check.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m  4s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  shellcheck  |   0m  0s |  There were no new shellcheck 
issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  spotless  |   0m 36s |  patch has no errors when 
running spotless:check.  |
   ||| _ Other Tests _ |
   | +0 :ok: |  asflicense  |   0m  0s |  ASF License check generated no 
output?  |
   |  |   |   2m 37s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5648/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5648 |
   | Optional Tests | dupname asflicense spotless shellcheck shelldocs |
   | uname | Linux fa4b00656949 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Max. process+thread count | 43 (vs. ulimit of 3) |
   | modules | C:  U:  |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5648/1/console 
|
   | versions | git=2.34.1 maven=3.8.6 shellcheck=0.8.0 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Output hbase logs to working directory in client integration test
> -
>
> Key: HBASE-28329
> URL: https://issues.apache.org/jira/browse/HBASE-28329
> Project: HBase
>  Issue Type: Task
>  Components: jenkins, scripts
>Reporter: Duo Zhang
>Priority: Major
>
> So we can see them in the job artifacts, currently it will be logged to hbase 
> install directory which is outside the working dir so we can not see them.
> The client integration test for master branch is failing because can not 
> start hbase cluster, we need the logs to find out the root cause.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] HBASE-28329 Output hbase logs to working directory in client integrat… [hbase]

2024-01-24 Thread via GitHub


Apache-HBase commented on PR #5648:
URL: https://github.com/apache/hbase/pull/5648#issuecomment-1909447623

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 24s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +0 :ok: |  shelldocs  |   0m  0s |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  spotless  |   0m 38s |  branch has no errors when 
running spotless:check.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m  4s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  shellcheck  |   0m  0s |  There were no new shellcheck 
issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  spotless  |   0m 36s |  patch has no errors when 
running spotless:check.  |
   ||| _ Other Tests _ |
   | +0 :ok: |  asflicense  |   0m  0s |  ASF License check generated no 
output?  |
   |  |   |   2m 37s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5648/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5648 |
   | Optional Tests | dupname asflicense spotless shellcheck shelldocs |
   | uname | Linux fa4b00656949 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Max. process+thread count | 43 (vs. ulimit of 3) |
   | modules | C:  U:  |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5648/1/console 
|
   | versions | git=2.34.1 maven=3.8.6 shellcheck=0.8.0 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-28329) Output hbase logs to working directory in client integration test

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810705#comment-17810705
 ] 

ASF GitHub Bot commented on HBASE-28329:


Apache-HBase commented on PR #5648:
URL: https://github.com/apache/hbase/pull/5648#issuecomment-1909446629

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 38s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  Maven dependency ordering for branch  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m  3s |  Maven dependency ordering for patch  |
   ||| _ Other Tests _ |
   |  |   |   1m 32s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5648/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5648 |
   | Optional Tests |  |
   | uname | Linux 1df7cc447439 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Max. process+thread count | 40 (vs. ulimit of 3) |
   | modules | C:  U:  |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5648/1/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Output hbase logs to working directory in client integration test
> -
>
> Key: HBASE-28329
> URL: https://issues.apache.org/jira/browse/HBASE-28329
> Project: HBase
>  Issue Type: Task
>  Components: jenkins, scripts
>Reporter: Duo Zhang
>Priority: Major
>
> So we can see them in the job artifacts, currently it will be logged to hbase 
> install directory which is outside the working dir so we can not see them.
> The client integration test for master branch is failing because can not 
> start hbase cluster, we need the logs to find out the root cause.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] HBASE-28329 Output hbase logs to working directory in client integrat… [hbase]

2024-01-24 Thread via GitHub


Apache-HBase commented on PR #5648:
URL: https://github.com/apache/hbase/pull/5648#issuecomment-1909446629

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 38s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  Maven dependency ordering for branch  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m  3s |  Maven dependency ordering for patch  |
   ||| _ Other Tests _ |
   |  |   |   1m 32s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5648/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5648 |
   | Optional Tests |  |
   | uname | Linux 1df7cc447439 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Max. process+thread count | 40 (vs. ulimit of 3) |
   | modules | C:  U:  |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5648/1/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-28329) Output hbase logs to working directory in client integration test

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810704#comment-17810704
 ] 

ASF GitHub Bot commented on HBASE-28329:


Apache-HBase commented on PR #5648:
URL: https://github.com/apache/hbase/pull/5648#issuecomment-1909446449

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 27s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  Maven dependency ordering for branch  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m  3s |  Maven dependency ordering for patch  |
   ||| _ Other Tests _ |
   |  |   |   1m 19s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5648/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5648 |
   | Optional Tests |  |
   | uname | Linux 010787fb8946 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Max. process+thread count | 32 (vs. ulimit of 3) |
   | modules | C:  U:  |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5648/1/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Output hbase logs to working directory in client integration test
> -
>
> Key: HBASE-28329
> URL: https://issues.apache.org/jira/browse/HBASE-28329
> Project: HBase
>  Issue Type: Task
>  Components: jenkins, scripts
>Reporter: Duo Zhang
>Priority: Major
>
> So we can see them in the job artifacts, currently it will be logged to hbase 
> install directory which is outside the working dir so we can not see them.
> The client integration test for master branch is failing because can not 
> start hbase cluster, we need the logs to find out the root cause.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] HBASE-28329 Output hbase logs to working directory in client integrat… [hbase]

2024-01-24 Thread via GitHub


Apache-HBase commented on PR #5648:
URL: https://github.com/apache/hbase/pull/5648#issuecomment-1909446449

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 27s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  Maven dependency ordering for branch  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m  3s |  Maven dependency ordering for patch  |
   ||| _ Other Tests _ |
   |  |   |   1m 19s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5648/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5648 |
   | Optional Tests |  |
   | uname | Linux 010787fb8946 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Max. process+thread count | 32 (vs. ulimit of 3) |
   | modules | C:  U:  |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5648/1/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-26220) Use P2P communicate between region servers to sync the list for bootstrap node

2024-01-24 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810700#comment-17810700
 ] 

Hudson commented on HBASE-26220:


Results for branch branch-3
[build #132 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/132/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/132/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/132/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/132/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for 
details|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/132//artifact/output-integration/hadoop-3.log].
 (note that this means we didn't check the Hadoop 3 shaded client)


> Use P2P communicate between region servers to sync the list for bootstrap node
> --
>
> Key: HBASE-26220
> URL: https://issues.apache.org/jira/browse/HBASE-26220
> Project: HBase
>  Issue Type: Sub-task
>  Components: master, regionserver
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0-alpha-2
>
>
> For returning bootstrap nodes to client, we do not need to always track 
> exactly the current live region server. But now, we just set a watcher on 
> zookeeper to watch all the live region servers, on every region server, for 
> large cluster, it will be a big pressure for zookeeper.
> So here I think, we could let region servers to communicate with each other 
> to sync the available bootstrap node, like a P2P network.
> Will put a simple design doc soon.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-28326) All nightly jobs are failing

2024-01-24 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810701#comment-17810701
 ] 

Hudson commented on HBASE-28326:


Results for branch branch-3
[build #132 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/132/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/132/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/132/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/132/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for 
details|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/132//artifact/output-integration/hadoop-3.log].
 (note that this means we didn't check the Hadoop 3 shaded client)


> All nightly jobs are failing
> 
>
> Key: HBASE-28326
> URL: https://issues.apache.org/jira/browse/HBASE-28326
> Project: HBase
>  Issue Type: Bug
>  Components: jenkins
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 2.4.18, 2.5.8, 3.0.0-beta-2
>
>
> https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/991/console
> Failed in yetus install stage, seems to be related to gpg.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-28322) Attach the design doc in HBASE-26220 to our code base

2024-01-24 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810699#comment-17810699
 ] 

Hudson commented on HBASE-28322:


Results for branch branch-3
[build #132 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/132/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/132/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/132/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/132/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for 
details|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/132//artifact/output-integration/hadoop-3.log].
 (note that this means we didn't check the Hadoop 3 shaded client)


> Attach the design doc in HBASE-26220 to our code base
> -
>
> Key: HBASE-28322
> URL: https://issues.apache.org/jira/browse/HBASE-28322
> Project: HBase
>  Issue Type: Sub-task
>  Components: documentation
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 3.0.0-beta-2
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-28329) Output hbase logs to working directory in client integration test

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810698#comment-17810698
 ] 

ASF GitHub Bot commented on HBASE-28329:


Apache9 opened a new pull request, #5648:
URL: https://github.com/apache/hbase/pull/5648

   …ion test




> Output hbase logs to working directory in client integration test
> -
>
> Key: HBASE-28329
> URL: https://issues.apache.org/jira/browse/HBASE-28329
> Project: HBase
>  Issue Type: Task
>  Components: jenkins, scripts
>Reporter: Duo Zhang
>Priority: Major
>
> So we can see them in the job artifacts, currently it will be logged to hbase 
> install directory which is outside the working dir so we can not see them.
> The client integration test for master branch is failing because can not 
> start hbase cluster, we need the logs to find out the root cause.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] HBASE-28329 Output hbase logs to working directory in client integrat… [hbase]

2024-01-24 Thread via GitHub


Apache9 opened a new pull request, #5648:
URL: https://github.com/apache/hbase/pull/5648

   …ion test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (HBASE-28329) Output hbase logs to working directory in client integration test

2024-01-24 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-28329:
-

 Summary: Output hbase logs to working directory in client 
integration test
 Key: HBASE-28329
 URL: https://issues.apache.org/jira/browse/HBASE-28329
 Project: HBase
  Issue Type: Task
  Components: jenkins, scripts
Reporter: Duo Zhang


So we can see them in the job artifacts, currently it will be logged to hbase 
install directory which is outside the working dir so we can not see them.

The client integration test for master branch is failing because can not start 
hbase cluster, we need the logs to find out the root cause.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-28328) Add an option to count different types of Delete Markers in RowCounter

2024-01-24 Thread Viraj Jasani (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810692#comment-17810692
 ] 

Viraj Jasani commented on HBASE-28328:
--

In addition to total num of delete marker cells, shall we also output total num 
of rows that have delete markers? Since this is row counter, it might be good 
to output rows that have delete markers (vs rows that don't have any delete 
markers).

Otherwise, total count of DELETE, DELETE_COLUMN, DELETE_FAMILY and 
DELETE_FAMILY_VERSION cells would be great anyways.

> Add an option to count different types of Delete Markers in RowCounter
> --
>
> Key: HBASE-28328
> URL: https://issues.apache.org/jira/browse/HBASE-28328
> Project: HBase
>  Issue Type: Improvement
>  Components: mapreduce
>Reporter: Himanshu Gwalani
>Assignee: Himanshu Gwalani
>Priority: Minor
>
> Add an option (count-delete-markers) to the 
> [RowCounter|https://github.com/apache/hbase/blob/8a9ad0736621fa1b00b5ae90529ca6065f88c67f/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/RowCounter.java#L240C62-L240C75]
>  tool to count the number of Delete Markers of all types, i.e. (DELETE, 
> DELETE_COLUMN, DELETE_FAMILY,DELETE_FAMILY_VERSION)
> We already have such a feature within our internal implementation of 
> RowCounter and it's very useful.
> Implementation Ideas:
> 1. If the option is passed, initialize the empty job counters for all 4 types 
> of deletes.
> 2. Within mapper, increase the respective delete counts while processing each 
> row.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-28322) Attach the design doc in HBASE-26220 to our code base

2024-01-24 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810685#comment-17810685
 ] 

Hudson commented on HBASE-28322:


Results for branch branch-2
[build #972 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/972/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/972/General_20Nightly_20Build_20Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/972/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/972/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/972/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Attach the design doc in HBASE-26220 to our code base
> -
>
> Key: HBASE-28322
> URL: https://issues.apache.org/jira/browse/HBASE-28322
> Project: HBase
>  Issue Type: Sub-task
>  Components: documentation
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 3.0.0-beta-2
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-26220) Use P2P communicate between region servers to sync the list for bootstrap node

2024-01-24 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810686#comment-17810686
 ] 

Hudson commented on HBASE-26220:


Results for branch branch-2
[build #972 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/972/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/972/General_20Nightly_20Build_20Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/972/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/972/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/972/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Use P2P communicate between region servers to sync the list for bootstrap node
> --
>
> Key: HBASE-26220
> URL: https://issues.apache.org/jira/browse/HBASE-26220
> Project: HBase
>  Issue Type: Sub-task
>  Components: master, regionserver
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0-alpha-2
>
>
> For returning bootstrap nodes to client, we do not need to always track 
> exactly the current live region server. But now, we just set a watcher on 
> zookeeper to watch all the live region servers, on every region server, for 
> large cluster, it will be a big pressure for zookeeper.
> So here I think, we could let region servers to communicate with each other 
> to sync the available bootstrap node, like a P2P network.
> Will put a simple design doc soon.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-28326) All nightly jobs are failing

2024-01-24 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810687#comment-17810687
 ] 

Hudson commented on HBASE-28326:


Results for branch branch-2
[build #972 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/972/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/972/General_20Nightly_20Build_20Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/972/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/972/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/972/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> All nightly jobs are failing
> 
>
> Key: HBASE-28326
> URL: https://issues.apache.org/jira/browse/HBASE-28326
> Project: HBase
>  Issue Type: Bug
>  Components: jenkins
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 2.4.18, 2.5.8, 3.0.0-beta-2
>
>
> https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/991/console
> Failed in yetus install stage, seems to be related to gpg.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-28326) All nightly jobs are failing

2024-01-24 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810683#comment-17810683
 ] 

Hudson commented on HBASE-28326:


Results for branch master
[build #993 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/993/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/993/General_20Nightly_20Build_20Report/]




(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/993/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/993/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for 
details|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/993//artifact/output-integration/hadoop-3.log].
 (note that this means we didn't check the Hadoop 3 shaded client)


> All nightly jobs are failing
> 
>
> Key: HBASE-28326
> URL: https://issues.apache.org/jira/browse/HBASE-28326
> Project: HBase
>  Issue Type: Bug
>  Components: jenkins
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 2.4.18, 2.5.8, 3.0.0-beta-2
>
>
> https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/991/console
> Failed in yetus install stage, seems to be related to gpg.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (HBASE-28328) Add an option to count different types of Delete Markers in RowCounter

2024-01-24 Thread Himanshu Gwalani (Jira)
Himanshu Gwalani created HBASE-28328:


 Summary: Add an option to count different types of Delete Markers 
in RowCounter
 Key: HBASE-28328
 URL: https://issues.apache.org/jira/browse/HBASE-28328
 Project: HBase
  Issue Type: Improvement
  Components: mapreduce
Reporter: Himanshu Gwalani
Assignee: Himanshu Gwalani


Add an option (count-delete-markers) to the 
[RowCounter|https://github.com/apache/hbase/blob/8a9ad0736621fa1b00b5ae90529ca6065f88c67f/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/RowCounter.java#L240C62-L240C75]
 tool to count the number of Delete Markers of all types, i.e. (DELETE, 
DELETE_COLUMN, DELETE_FAMILY,DELETE_FAMILY_VERSION)

We already have such a feature within our internal implementation of RowCounter 
and it's very useful.

Implementation Ideas:
1. If the option is passed, initialize the empty job counters for all 4 types 
of deletes.
2. Within mapper, increase the respective delete counts while processing each 
row.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-28216) HDFS erasure coding support for table data dirs

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810673#comment-17810673
 ] 

ASF GitHub Bot commented on HBASE-28216:


Apache-HBase commented on PR #5591:
URL: https://github.com/apache/hbase/pull/5591#issuecomment-1909361432

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 41s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 15s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 15s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   1m 46s |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   4m 38s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 59s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 21s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 47s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 47s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m 38s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  1s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 28s |  hbase-protocol-shaded in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   7m 59s |  hbase-client in the patch passed.  
|
   | -1 :x: |  unit  | 230m 40s |  hbase-server in the patch failed.  |
   | +1 :green_heart: |  unit  |   9m 40s |  hbase-shell in the patch passed.  |
   |  |   | 274m 34s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.44 ServerAPI=1.44 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5591 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 9678f842e218 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 
13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 97974024a8 |
   | Default Java | Temurin-1.8.0_352-b08 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/5/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/5/testReport/
 |
   | Max. process+thread count | 4496 (vs. ulimit of 3) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-shell 
U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/5/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> HDFS erasure coding support for table data dirs
> ---
>
> Key: HBASE-28216
> URL: https://issues.apache.org/jira/browse/HBASE-28216
> Project: HBase
>  Issue Type: New Feature
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Major
>  Labels: patch-available
>
> [Erasure 
> coding|https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-hdfs/HDFSErasureCoding.html]
>  (EC) is a hadoop-3 feature which can drastically reduce storage 
> requirements, at the expense of locality. At my company we have a few hbase 
> clusters which are extremely data dense and take mostly write traffic, fewer 
> reads (cold data). We'd like to reduce the cost of these clusters, and EC is 
> a great way to do that since it can reduce replication related storage costs 
> by 50%.
> It's possible to enable EC policies on sub directories of HDFS. One can 
> manually set this with {{{}hdfs ec -setPolicy -path 
> /hbase/data/default/usertable -policy {}}}. This can work without any 
> hbase support.
> One problem with that is a lack of visibility by operators into which tables 
> might have EC enabled. I think this is where HBase can help. Here's my 
> proposal:
>  * Add a new TableDescriptor and ColumnDescriptor field ERASURE_CODING_POLICY
>  * In ModifyTableProcedure preflightChecks, if ERASURE_CODING_POLICY is set, 
> verify that the requested policy is available 

Re: [PR] HBASE-28216 HDFS erasure coding support for table data dirs [hbase]

2024-01-24 Thread via GitHub


Apache-HBase commented on PR #5591:
URL: https://github.com/apache/hbase/pull/5591#issuecomment-1909361432

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 41s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 15s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 15s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   1m 46s |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   4m 38s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 59s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 21s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 47s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 47s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m 38s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  1s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 28s |  hbase-protocol-shaded in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   7m 59s |  hbase-client in the patch passed.  
|
   | -1 :x: |  unit  | 230m 40s |  hbase-server in the patch failed.  |
   | +1 :green_heart: |  unit  |   9m 40s |  hbase-shell in the patch passed.  |
   |  |   | 274m 34s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.44 ServerAPI=1.44 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5591 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 9678f842e218 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 
13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 97974024a8 |
   | Default Java | Temurin-1.8.0_352-b08 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/5/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/5/testReport/
 |
   | Max. process+thread count | 4496 (vs. ulimit of 3) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-shell 
U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/5/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-28216) HDFS erasure coding support for table data dirs

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810672#comment-17810672
 ] 

ASF GitHub Bot commented on HBASE-28216:


Apache-HBase commented on PR #5591:
URL: https://github.com/apache/hbase/pull/5591#issuecomment-1909357199

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 40s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 15s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 50s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   2m  3s |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   5m 14s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  6s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 15s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 44s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m  1s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m  1s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m  9s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  6s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 35s |  hbase-protocol-shaded in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   8m  8s |  hbase-client in the patch passed.  
|
   | +1 :green_heart: |  unit  | 223m 59s |  hbase-server in the patch passed.  
|
   | +1 :green_heart: |  unit  |   8m  0s |  hbase-shell in the patch passed.  |
   |  |   | 269m 17s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.44 ServerAPI=1.44 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5591 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 6e7d7aaa4815 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 
14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 97974024a8 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/5/testReport/
 |
   | Max. process+thread count | 4395 (vs. ulimit of 3) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-shell 
U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/5/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> HDFS erasure coding support for table data dirs
> ---
>
> Key: HBASE-28216
> URL: https://issues.apache.org/jira/browse/HBASE-28216
> Project: HBase
>  Issue Type: New Feature
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Major
>  Labels: patch-available
>
> [Erasure 
> coding|https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-hdfs/HDFSErasureCoding.html]
>  (EC) is a hadoop-3 feature which can drastically reduce storage 
> requirements, at the expense of locality. At my company we have a few hbase 
> clusters which are extremely data dense and take mostly write traffic, fewer 
> reads (cold data). We'd like to reduce the cost of these clusters, and EC is 
> a great way to do that since it can reduce replication related storage costs 
> by 50%.
> It's possible to enable EC policies on sub directories of HDFS. One can 
> manually set this with {{{}hdfs ec -setPolicy -path 
> /hbase/data/default/usertable -policy {}}}. This can work without any 
> hbase support.
> One problem with that is a lack of visibility by operators into which tables 
> might have EC enabled. I think this is where HBase can help. Here's my 
> proposal:
>  * Add a new TableDescriptor and ColumnDescriptor field ERASURE_CODING_POLICY
>  * In ModifyTableProcedure preflightChecks, if ERASURE_CODING_POLICY is set, 
> verify that the requested policy is available and enabled via 
> DistributedFileSystem.
> getErasureCodingPolicies().
>  * During ModifyTableProcedure, add a new state for 
> 

Re: [PR] HBASE-28216 HDFS erasure coding support for table data dirs [hbase]

2024-01-24 Thread via GitHub


Apache-HBase commented on PR #5591:
URL: https://github.com/apache/hbase/pull/5591#issuecomment-1909357199

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 40s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 15s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 50s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   2m  3s |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   5m 14s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  6s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 15s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 44s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m  1s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m  1s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m  9s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  6s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 35s |  hbase-protocol-shaded in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   8m  8s |  hbase-client in the patch passed.  
|
   | +1 :green_heart: |  unit  | 223m 59s |  hbase-server in the patch passed.  
|
   | +1 :green_heart: |  unit  |   8m  0s |  hbase-shell in the patch passed.  |
   |  |   | 269m 17s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.44 ServerAPI=1.44 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5591 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 6e7d7aaa4815 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 
14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 97974024a8 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/5/testReport/
 |
   | Max. process+thread count | 4395 (vs. ulimit of 3) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-shell 
U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/5/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-28326) All nightly jobs are failing

2024-01-24 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810622#comment-17810622
 ] 

Hudson commented on HBASE-28326:


Results for branch branch-2.6
[build #39 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/39/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/39/General_20Nightly_20Build_20Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/39/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/39/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/39/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> All nightly jobs are failing
> 
>
> Key: HBASE-28326
> URL: https://issues.apache.org/jira/browse/HBASE-28326
> Project: HBase
>  Issue Type: Bug
>  Components: jenkins
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 2.4.18, 2.5.8, 3.0.0-beta-2
>
>
> https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/991/console
> Failed in yetus install stage, seems to be related to gpg.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-28322) Attach the design doc in HBASE-26220 to our code base

2024-01-24 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810620#comment-17810620
 ] 

Hudson commented on HBASE-28322:


Results for branch branch-2.6
[build #39 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/39/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/39/General_20Nightly_20Build_20Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/39/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/39/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/39/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Attach the design doc in HBASE-26220 to our code base
> -
>
> Key: HBASE-28322
> URL: https://issues.apache.org/jira/browse/HBASE-28322
> Project: HBase
>  Issue Type: Sub-task
>  Components: documentation
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 3.0.0-beta-2
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-26220) Use P2P communicate between region servers to sync the list for bootstrap node

2024-01-24 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810621#comment-17810621
 ] 

Hudson commented on HBASE-26220:


Results for branch branch-2.6
[build #39 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/39/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/39/General_20Nightly_20Build_20Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/39/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/39/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/39/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Use P2P communicate between region servers to sync the list for bootstrap node
> --
>
> Key: HBASE-26220
> URL: https://issues.apache.org/jira/browse/HBASE-26220
> Project: HBase
>  Issue Type: Sub-task
>  Components: master, regionserver
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0-alpha-2
>
>
> For returning bootstrap nodes to client, we do not need to always track 
> exactly the current live region server. But now, we just set a watcher on 
> zookeeper to watch all the live region servers, on every region server, for 
> large cluster, it will be a big pressure for zookeeper.
> So here I think, we could let region servers to communicate with each other 
> to sync the available bootstrap node, like a P2P network.
> Will put a simple design doc soon.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-28302) Add tracking of fs read times in ScanMetrics and slow logs

2024-01-24 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810619#comment-17810619
 ] 

Hudson commented on HBASE-28302:


Results for branch branch-2.6
[build #39 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/39/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/39/General_20Nightly_20Build_20Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/39/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/39/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/39/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Add tracking of fs read times in ScanMetrics and slow logs
> --
>
> Key: HBASE-28302
> URL: https://issues.apache.org/jira/browse/HBASE-28302
> Project: HBase
>  Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Major
> Fix For: 2.6.0, 3.0.0-beta-2
>
>
> We've had this in our production for a while, and it's useful info to have. 
> We already track FS read times in 
> [HFileBlock|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java#L1828-L1831C10].
>  We can project that into the ScanMetrics instance and slow log pretty 
> easily. It is also helpful to add a slow.fs.read.threshold, over which we log 
> a warn



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-28216) HDFS erasure coding support for table data dirs

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810610#comment-17810610
 ] 

ASF GitHub Bot commented on HBASE-28216:


Apache-HBase commented on PR #5591:
URL: https://github.com/apache/hbase/pull/5591#issuecomment-1909183769

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 38s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +0 :ok: |  prototool  |   0m  0s |  prototool was not available.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 13s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   4m  5s |  branch-2 passed  |
   | +1 :green_heart: |  checkstyle  |   1m  4s |  branch-2 passed  |
   | +1 :green_heart: |  spotless  |   0m 46s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   4m 20s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 15s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 54s |  the patch passed  |
   | +1 :green_heart: |  compile  |   4m  1s |  the patch passed  |
   | +1 :green_heart: |  cc  |   4m  1s |  the patch passed  |
   | -0 :warning: |  javac  |   2m 31s |  hbase-server generated 1 new + 194 
unchanged - 1 fixed = 195 total (was 195)  |
   | +1 :green_heart: |  checkstyle  |   1m  1s |  the patch passed  |
   | -0 :warning: |  rubocop  |   0m 11s |  The patch generated 13 new + 728 
unchanged - 3 fixed = 741 total (was 731)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |   9m 54s |  Patch does not cause any 
errors with Hadoop 2.10.2 or 3.3.6.  |
   | +1 :green_heart: |  hbaseprotoc  |   1m 28s |  the patch passed  |
   | +1 :green_heart: |  spotless  |   0m 42s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   4m 42s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 32s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  42m  6s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/5/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5591 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile cc hbaseprotoc prototool rubocop |
   | uname | Linux 07aa66e8002e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 97974024a8 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | javac | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/5/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
 |
   | rubocop | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/5/artifact/yetus-general-check/output/diff-patch-rubocop.txt
 |
   | Max. process+thread count | 81 (vs. ulimit of 3) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-shell 
U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/5/console 
|
   | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> HDFS erasure coding support for table data dirs
> ---
>
> Key: HBASE-28216
> URL: https://issues.apache.org/jira/browse/HBASE-28216
> Project: HBase
>  Issue Type: New Feature
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Major
>  Labels: patch-available
>
> [Erasure 
> coding|https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-hdfs/HDFSErasureCoding.html]
>  (EC) is a hadoop-3 feature which can drastically reduce storage 
> requirements, at the expense of locality. At my company we have a few hbase 
> clusters which are extremely data dense and take mostly write traffic, fewer 
> reads (cold data). We'd like to reduce the cost 

Re: [PR] HBASE-28216 HDFS erasure coding support for table data dirs [hbase]

2024-01-24 Thread via GitHub


Apache-HBase commented on PR #5591:
URL: https://github.com/apache/hbase/pull/5591#issuecomment-1909183769

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 38s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +0 :ok: |  prototool  |   0m  0s |  prototool was not available.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 13s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   4m  5s |  branch-2 passed  |
   | +1 :green_heart: |  checkstyle  |   1m  4s |  branch-2 passed  |
   | +1 :green_heart: |  spotless  |   0m 46s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   4m 20s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 15s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 54s |  the patch passed  |
   | +1 :green_heart: |  compile  |   4m  1s |  the patch passed  |
   | +1 :green_heart: |  cc  |   4m  1s |  the patch passed  |
   | -0 :warning: |  javac  |   2m 31s |  hbase-server generated 1 new + 194 
unchanged - 1 fixed = 195 total (was 195)  |
   | +1 :green_heart: |  checkstyle  |   1m  1s |  the patch passed  |
   | -0 :warning: |  rubocop  |   0m 11s |  The patch generated 13 new + 728 
unchanged - 3 fixed = 741 total (was 731)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |   9m 54s |  Patch does not cause any 
errors with Hadoop 2.10.2 or 3.3.6.  |
   | +1 :green_heart: |  hbaseprotoc  |   1m 28s |  the patch passed  |
   | +1 :green_heart: |  spotless  |   0m 42s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   4m 42s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 32s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  42m  6s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/5/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5591 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile cc hbaseprotoc prototool rubocop |
   | uname | Linux 07aa66e8002e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 97974024a8 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | javac | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/5/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
 |
   | rubocop | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/5/artifact/yetus-general-check/output/diff-patch-rubocop.txt
 |
   | Max. process+thread count | 81 (vs. ulimit of 3) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-shell 
U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/5/console 
|
   | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-28216) HDFS erasure coding support for table data dirs

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810608#comment-17810608
 ] 

ASF GitHub Bot commented on HBASE-28216:


bbeaudreault commented on PR #5591:
URL: https://github.com/apache/hbase/pull/5591#issuecomment-1909171517

   @NihalJain can you take a look? The guts of the change is the same, but I 
had to update much of ErasureCodingUtils to use reflection. The tests have been 
updated to work in both hadoop3 (verifying the EC management works) and in 
hadoop2 (verifying we throw an UnsupportedException)




> HDFS erasure coding support for table data dirs
> ---
>
> Key: HBASE-28216
> URL: https://issues.apache.org/jira/browse/HBASE-28216
> Project: HBase
>  Issue Type: New Feature
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Major
>  Labels: patch-available
>
> [Erasure 
> coding|https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-hdfs/HDFSErasureCoding.html]
>  (EC) is a hadoop-3 feature which can drastically reduce storage 
> requirements, at the expense of locality. At my company we have a few hbase 
> clusters which are extremely data dense and take mostly write traffic, fewer 
> reads (cold data). We'd like to reduce the cost of these clusters, and EC is 
> a great way to do that since it can reduce replication related storage costs 
> by 50%.
> It's possible to enable EC policies on sub directories of HDFS. One can 
> manually set this with {{{}hdfs ec -setPolicy -path 
> /hbase/data/default/usertable -policy {}}}. This can work without any 
> hbase support.
> One problem with that is a lack of visibility by operators into which tables 
> might have EC enabled. I think this is where HBase can help. Here's my 
> proposal:
>  * Add a new TableDescriptor and ColumnDescriptor field ERASURE_CODING_POLICY
>  * In ModifyTableProcedure preflightChecks, if ERASURE_CODING_POLICY is set, 
> verify that the requested policy is available and enabled via 
> DistributedFileSystem.
> getErasureCodingPolicies().
>  * During ModifyTableProcedure, add a new state for 
> MODIFY_TABLE_SYNC_ERASURE_CODING_POLICY.
>  ** When adding or changing a policy, use DistributedFileSystem.
> setErasureCodingPolicy to sync it for the data and archive dir of that table 
> (or column in table)
>  ** When removing the property or setting it to empty, use 
> DistributedFileSystem.
> unsetErasureCodingPolicy to remove it from the data and archive dir.
> Since this new API is in hadoop-3 only, we'll need to add a reflection 
> wrapper class for managing the calls and verifying that the API is available. 
> We'll similarly do that API check in preflightChecks.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] HBASE-28216 HDFS erasure coding support for table data dirs [hbase]

2024-01-24 Thread via GitHub


bbeaudreault commented on PR #5591:
URL: https://github.com/apache/hbase/pull/5591#issuecomment-1909171517

   @NihalJain can you take a look? The guts of the change is the same, but I 
had to update much of ErasureCodingUtils to use reflection. The tests have been 
updated to work in both hadoop3 (verifying the EC management works) and in 
hadoop2 (verifying we throw an UnsupportedException)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-28317) RpcCallContext should expose client's TLS certificate

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810605#comment-17810605
 ] 

ASF GitHub Bot commented on HBASE-28317:


Apache-HBase commented on PR #5644:
URL: https://github.com/apache/hbase/pull/5644#issuecomment-1909153312

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 14s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   5m  6s |  master passed  |
   | +1 :green_heart: |  compile  |   1m 17s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   8m 22s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 47s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 33s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m  9s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m  9s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   8m 13s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | -0 :warning: |  javadoc  |   0m 47s |  hbase-server generated 2 new + 95 
unchanged - 0 fixed = 97 total (was 95)  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 289m 26s |  hbase-server in the patch failed.  |
   |  |   | 324m 41s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.44 ServerAPI=1.44 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5644/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5644 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux b6cdd35ed0e6 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 
11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | javadoc | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5644/2/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt
 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5644/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5644/2/testReport/
 |
   | Max. process+thread count | 4473 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5644/2/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> RpcCallContext should expose client's TLS certificate
> -
>
> Key: HBASE-28317
> URL: https://issues.apache.org/jira/browse/HBASE-28317
> Project: HBase
>  Issue Type: Improvement
>Reporter: Charles Connell
>Assignee: Charles Connell
>Priority: Minor
>
> At my employer we plan on using a coprocessor to log information about some 
> requests to HBase. For this to be useful to us, we need to know who each 
> request is coming from. We use HBase's TLS support with mutual authentication 
> to authenticate clients. I'd like a way to expose the client certificate used 
> on a request to coprocessors. For setups using Kerberos authentication, 
> RpcCall exposes the Kerberos principal shortname via {{getRequestUser()}}, so 
> this would be the TLS equivalent to that.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] HBASE-28317: Expose client TLS certificate on RpcCallContext [hbase]

2024-01-24 Thread via GitHub


Apache-HBase commented on PR #5644:
URL: https://github.com/apache/hbase/pull/5644#issuecomment-1909153312

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 14s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   5m  6s |  master passed  |
   | +1 :green_heart: |  compile  |   1m 17s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   8m 22s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 47s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 33s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m  9s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m  9s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   8m 13s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | -0 :warning: |  javadoc  |   0m 47s |  hbase-server generated 2 new + 95 
unchanged - 0 fixed = 97 total (was 95)  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 289m 26s |  hbase-server in the patch failed.  |
   |  |   | 324m 41s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.44 ServerAPI=1.44 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5644/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5644 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux b6cdd35ed0e6 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 
11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | javadoc | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5644/2/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt
 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5644/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5644/2/testReport/
 |
   | Max. process+thread count | 4473 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5644/2/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-28216) HDFS erasure coding support for table data dirs

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810604#comment-17810604
 ] 

ASF GitHub Bot commented on HBASE-28216:


Apache-HBase commented on PR #5591:
URL: https://github.com/apache/hbase/pull/5591#issuecomment-1909148092

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 55s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 16s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 58s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   1m 57s |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   5m  5s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  6s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 53s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m  9s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m  9s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 20s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  8s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 31s |  hbase-protocol-shaded in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   8m 25s |  hbase-client in the patch passed.  
|
   | -1 :x: |  unit  | 241m 33s |  hbase-server in the patch failed.  |
   | +1 :green_heart: |  unit  |   8m 10s |  hbase-shell in the patch passed.  |
   |  |   | 288m 12s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.44 ServerAPI=1.44 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5591 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 6fd72ae33876 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 
14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 97974024a8 |
   | Default Java | Temurin-1.8.0_352-b08 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/4/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/4/testReport/
 |
   | Max. process+thread count | 4118 (vs. ulimit of 3) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-shell 
U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/4/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> HDFS erasure coding support for table data dirs
> ---
>
> Key: HBASE-28216
> URL: https://issues.apache.org/jira/browse/HBASE-28216
> Project: HBase
>  Issue Type: New Feature
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Major
>  Labels: patch-available
>
> [Erasure 
> coding|https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-hdfs/HDFSErasureCoding.html]
>  (EC) is a hadoop-3 feature which can drastically reduce storage 
> requirements, at the expense of locality. At my company we have a few hbase 
> clusters which are extremely data dense and take mostly write traffic, fewer 
> reads (cold data). We'd like to reduce the cost of these clusters, and EC is 
> a great way to do that since it can reduce replication related storage costs 
> by 50%.
> It's possible to enable EC policies on sub directories of HDFS. One can 
> manually set this with {{{}hdfs ec -setPolicy -path 
> /hbase/data/default/usertable -policy {}}}. This can work without any 
> hbase support.
> One problem with that is a lack of visibility by operators into which tables 
> might have EC enabled. I think this is where HBase can help. Here's my 
> proposal:
>  * Add a new TableDescriptor and ColumnDescriptor field ERASURE_CODING_POLICY
>  * In ModifyTableProcedure preflightChecks, if ERASURE_CODING_POLICY is set, 
> verify that the requested policy is 

Re: [PR] HBASE-28216 HDFS erasure coding support for table data dirs [hbase]

2024-01-24 Thread via GitHub


Apache-HBase commented on PR #5591:
URL: https://github.com/apache/hbase/pull/5591#issuecomment-1909148092

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 55s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 16s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 58s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   1m 57s |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   5m  5s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  6s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 53s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m  9s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m  9s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 20s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  8s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 31s |  hbase-protocol-shaded in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   8m 25s |  hbase-client in the patch passed.  
|
   | -1 :x: |  unit  | 241m 33s |  hbase-server in the patch failed.  |
   | +1 :green_heart: |  unit  |   8m 10s |  hbase-shell in the patch passed.  |
   |  |   | 288m 12s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.44 ServerAPI=1.44 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5591 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 6fd72ae33876 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 
14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 97974024a8 |
   | Default Java | Temurin-1.8.0_352-b08 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/4/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/4/testReport/
 |
   | Max. process+thread count | 4118 (vs. ulimit of 3) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-shell 
U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/4/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-28326) All nightly jobs are failing

2024-01-24 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810603#comment-17810603
 ] 

Hudson commented on HBASE-28326:


Results for branch branch-2.5
[build #468 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/468/]:
 (/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/468/General_20Nightly_20Build_20Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/468/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/468/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/468/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> All nightly jobs are failing
> 
>
> Key: HBASE-28326
> URL: https://issues.apache.org/jira/browse/HBASE-28326
> Project: HBase
>  Issue Type: Bug
>  Components: jenkins
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 2.4.18, 2.5.8, 3.0.0-beta-2
>
>
> https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/991/console
> Failed in yetus install stage, seems to be related to gpg.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-28216) HDFS erasure coding support for table data dirs

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810602#comment-17810602
 ] 

ASF GitHub Bot commented on HBASE-28216:


Apache-HBase commented on PR #5591:
URL: https://github.com/apache/hbase/pull/5591#issuecomment-1909122434

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 39s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 11s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   1m 47s |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   5m 45s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 57s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 16s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 52s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 52s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 52s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   6m 18s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 57s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 31s |  hbase-protocol-shaded in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   8m 33s |  hbase-client in the patch passed.  
|
   | +1 :green_heart: |  unit  | 213m 55s |  hbase-server in the patch passed.  
|
   | +1 :green_heart: |  unit  |   7m 41s |  hbase-shell in the patch passed.  |
   |  |   | 259m 50s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5591 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 5ca6b5ffa6c3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 97974024a8 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/4/testReport/
 |
   | Max. process+thread count | 4393 (vs. ulimit of 3) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-shell 
U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/4/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> HDFS erasure coding support for table data dirs
> ---
>
> Key: HBASE-28216
> URL: https://issues.apache.org/jira/browse/HBASE-28216
> Project: HBase
>  Issue Type: New Feature
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Major
>  Labels: patch-available
>
> [Erasure 
> coding|https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-hdfs/HDFSErasureCoding.html]
>  (EC) is a hadoop-3 feature which can drastically reduce storage 
> requirements, at the expense of locality. At my company we have a few hbase 
> clusters which are extremely data dense and take mostly write traffic, fewer 
> reads (cold data). We'd like to reduce the cost of these clusters, and EC is 
> a great way to do that since it can reduce replication related storage costs 
> by 50%.
> It's possible to enable EC policies on sub directories of HDFS. One can 
> manually set this with {{{}hdfs ec -setPolicy -path 
> /hbase/data/default/usertable -policy {}}}. This can work without any 
> hbase support.
> One problem with that is a lack of visibility by operators into which tables 
> might have EC enabled. I think this is where HBase can help. Here's my 
> proposal:
>  * Add a new TableDescriptor and ColumnDescriptor field ERASURE_CODING_POLICY
>  * In ModifyTableProcedure preflightChecks, if ERASURE_CODING_POLICY is set, 
> verify that the requested policy is available and enabled via 
> DistributedFileSystem.
> getErasureCodingPolicies().
>  * During ModifyTableProcedure, add a new state for 
> 

Re: [PR] HBASE-28216 HDFS erasure coding support for table data dirs [hbase]

2024-01-24 Thread via GitHub


Apache-HBase commented on PR #5591:
URL: https://github.com/apache/hbase/pull/5591#issuecomment-1909122434

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 39s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 11s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   1m 47s |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   5m 45s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 57s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 16s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 52s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 52s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 52s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   6m 18s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 57s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 31s |  hbase-protocol-shaded in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   8m 33s |  hbase-client in the patch passed.  
|
   | +1 :green_heart: |  unit  | 213m 55s |  hbase-server in the patch passed.  
|
   | +1 :green_heart: |  unit  |   7m 41s |  hbase-shell in the patch passed.  |
   |  |   | 259m 50s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5591 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 5ca6b5ffa6c3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 97974024a8 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/4/testReport/
 |
   | Max. process+thread count | 4393 (vs. ulimit of 3) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-shell 
U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/4/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-28317) RpcCallContext should expose client's TLS certificate

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810596#comment-17810596
 ] 

ASF GitHub Bot commented on HBASE-28317:


Apache-HBase commented on PR #5644:
URL: https://github.com/apache/hbase/pull/5644#issuecomment-1909110355

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 11s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 49s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 41s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   5m  2s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 25s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 25s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 42s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 42s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m 58s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | -0 :warning: |  javadoc  |   0m 24s |  hbase-server generated 2 new + 22 
unchanged - 0 fixed = 24 total (was 22)  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 253m 11s |  hbase-server in the patch passed.  
|
   |  |   | 275m 25s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.44 ServerAPI=1.44 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5644/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5644 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux dc87d0522825 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 
11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Default Java | Temurin-1.8.0_352-b08 |
   | javadoc | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5644/2/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5644/2/testReport/
 |
   | Max. process+thread count | 4993 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5644/2/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> RpcCallContext should expose client's TLS certificate
> -
>
> Key: HBASE-28317
> URL: https://issues.apache.org/jira/browse/HBASE-28317
> Project: HBase
>  Issue Type: Improvement
>Reporter: Charles Connell
>Assignee: Charles Connell
>Priority: Minor
>
> At my employer we plan on using a coprocessor to log information about some 
> requests to HBase. For this to be useful to us, we need to know who each 
> request is coming from. We use HBase's TLS support with mutual authentication 
> to authenticate clients. I'd like a way to expose the client certificate used 
> on a request to coprocessors. For setups using Kerberos authentication, 
> RpcCall exposes the Kerberos principal shortname via {{getRequestUser()}}, so 
> this would be the TLS equivalent to that.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] HBASE-28317: Expose client TLS certificate on RpcCallContext [hbase]

2024-01-24 Thread via GitHub


Apache-HBase commented on PR #5644:
URL: https://github.com/apache/hbase/pull/5644#issuecomment-1909110355

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 11s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 49s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 41s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   5m  2s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 25s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 25s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 42s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 42s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m 58s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | -0 :warning: |  javadoc  |   0m 24s |  hbase-server generated 2 new + 22 
unchanged - 0 fixed = 24 total (was 22)  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 253m 11s |  hbase-server in the patch passed.  
|
   |  |   | 275m 25s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.44 ServerAPI=1.44 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5644/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5644 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux dc87d0522825 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 
11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Default Java | Temurin-1.8.0_352-b08 |
   | javadoc | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5644/2/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5644/2/testReport/
 |
   | Max. process+thread count | 4993 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5644/2/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-28327) Add remove(String key, Metric metric) method to MetricRegistry interface

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810593#comment-17810593
 ] 

ASF GitHub Bot commented on HBASE-28327:


Apache-HBase commented on PR #5647:
URL: https://github.com/apache/hbase/pull/5647#issuecomment-1909072401

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 58s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 36s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 31s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   7m 22s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 29s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 20s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 54s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 33s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 33s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   7m 14s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 30s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 19s |  hbase-metrics-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   0m 22s |  hbase-metrics in the patch passed. 
 |
   |  |   |  27m 32s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.44 ServerAPI=1.44 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5647/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5647 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 4b9b9175c0d4 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 
14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Default Java | Temurin-1.8.0_352-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5647/1/testReport/
 |
   | Max. process+thread count | 168 (vs. ulimit of 3) |
   | modules | C: hbase-metrics-api hbase-metrics U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5647/1/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Add remove(String key, Metric metric) method to MetricRegistry interface
> 
>
> Key: HBASE-28327
> URL: https://issues.apache.org/jira/browse/HBASE-28327
> Project: HBase
>  Issue Type: Improvement
>Reporter: Evelyn Boland
>Priority: Major
>
> Add a `remove(String name, Metric metric)` method to the `MetricRegistry` 
> interface. Right now the interface only contains a `remove(String name)` 
> method.
> This additional remove method will give users the power to remove a `Metric` 
> with the specified `name` from the metric registry if and only if the 
> provided `metric` matches the object in the registry.
> Implementing the new `remove(String name, Metric metric)` should be straight 
> forward because the `MetricRegistryImpl` class stores metrics in a 
> `ConcurrentMap`, which already contains a `remove(Object key, Object value)` 
> method
> This change will not be a breaking one because the interface is marked with 
> `@IntefaceStability.Evolving`
> [~rmdmattingly]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] HBASE-28327 Add `remove(String name, Metric metric)` method to MetricRegistry [hbase]

2024-01-24 Thread via GitHub


Apache-HBase commented on PR #5647:
URL: https://github.com/apache/hbase/pull/5647#issuecomment-1909072401

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 58s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 36s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 31s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   7m 22s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 29s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 20s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 54s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 33s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 33s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   7m 14s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 30s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 19s |  hbase-metrics-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   0m 22s |  hbase-metrics in the patch passed. 
 |
   |  |   |  27m 32s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.44 ServerAPI=1.44 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5647/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5647 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 4b9b9175c0d4 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 
14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Default Java | Temurin-1.8.0_352-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5647/1/testReport/
 |
   | Max. process+thread count | 168 (vs. ulimit of 3) |
   | modules | C: hbase-metrics-api hbase-metrics U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5647/1/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-28327) Add remove(String key, Metric metric) method to MetricRegistry interface

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810592#comment-17810592
 ] 

ASF GitHub Bot commented on HBASE-28327:


Apache-HBase commented on PR #5647:
URL: https://github.com/apache/hbase/pull/5647#issuecomment-1909066183

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 36s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 35s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 23s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   6m 27s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 23s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 59s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 26s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 26s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   6m 51s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 25s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 16s |  hbase-metrics-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   0m 22s |  hbase-metrics in the patch passed. 
 |
   |  |   |  25m 16s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5647/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5647 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 8d47f0204bba 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5647/1/testReport/
 |
   | Max. process+thread count | 197 (vs. ulimit of 3) |
   | modules | C: hbase-metrics-api hbase-metrics U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5647/1/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Add remove(String key, Metric metric) method to MetricRegistry interface
> 
>
> Key: HBASE-28327
> URL: https://issues.apache.org/jira/browse/HBASE-28327
> Project: HBase
>  Issue Type: Improvement
>Reporter: Evelyn Boland
>Priority: Major
>
> Add a `remove(String name, Metric metric)` method to the `MetricRegistry` 
> interface. Right now the interface only contains a `remove(String name)` 
> method.
> This additional remove method will give users the power to remove a `Metric` 
> with the specified `name` from the metric registry if and only if the 
> provided `metric` matches the object in the registry.
> Implementing the new `remove(String name, Metric metric)` should be straight 
> forward because the `MetricRegistryImpl` class stores metrics in a 
> `ConcurrentMap`, which already contains a `remove(Object key, Object value)` 
> method
> This change will not be a breaking one because the interface is marked with 
> `@IntefaceStability.Evolving`
> [~rmdmattingly]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] HBASE-28327 Add `remove(String name, Metric metric)` method to MetricRegistry [hbase]

2024-01-24 Thread via GitHub


Apache-HBase commented on PR #5647:
URL: https://github.com/apache/hbase/pull/5647#issuecomment-1909066183

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 36s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 35s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 23s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   6m 27s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 23s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 59s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 26s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 26s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   6m 51s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 25s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 16s |  hbase-metrics-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   0m 22s |  hbase-metrics in the patch passed. 
 |
   |  |   |  25m 16s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5647/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5647 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 8d47f0204bba 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5647/1/testReport/
 |
   | Max. process+thread count | 197 (vs. ulimit of 3) |
   | modules | C: hbase-metrics-api hbase-metrics U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5647/1/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-28327) Add remove(String key, Metric metric) method to MetricRegistry interface

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810591#comment-17810591
 ] 

ASF GitHub Bot commented on HBASE-28327:


Apache-HBase commented on PR #5647:
URL: https://github.com/apache/hbase/pull/5647#issuecomment-1909063763

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 28s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 10s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 25s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 12s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 44s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   0m 32s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 10s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 57s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 24s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 24s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 12s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |   5m 33s |  Patch does not cause any 
errors with Hadoop 3.3.6.  |
   | +1 :green_heart: |  spotless  |   0m 42s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   0m 46s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 14s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  23m 44s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5647/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5647 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux b646b7786b2e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | Max. process+thread count | 84 (vs. ulimit of 3) |
   | modules | C: hbase-metrics-api hbase-metrics U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5647/1/console 
|
   | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Add remove(String key, Metric metric) method to MetricRegistry interface
> 
>
> Key: HBASE-28327
> URL: https://issues.apache.org/jira/browse/HBASE-28327
> Project: HBase
>  Issue Type: Improvement
>Reporter: Evelyn Boland
>Priority: Major
>
> Add a `remove(String name, Metric metric)` method to the `MetricRegistry` 
> interface. Right now the interface only contains a `remove(String name)` 
> method.
> This additional remove method will give users the power to remove a `Metric` 
> with the specified `name` from the metric registry if and only if the 
> provided `metric` matches the object in the registry.
> Implementing the new `remove(String name, Metric metric)` should be straight 
> forward because the `MetricRegistryImpl` class stores metrics in a 
> `ConcurrentMap`, which already contains a `remove(Object key, Object value)` 
> method
> This change will not be a breaking one because the interface is marked with 
> `@IntefaceStability.Evolving`
> [~rmdmattingly]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] HBASE-28327 Add `remove(String name, Metric metric)` method to MetricRegistry [hbase]

2024-01-24 Thread via GitHub


Apache-HBase commented on PR #5647:
URL: https://github.com/apache/hbase/pull/5647#issuecomment-1909063763

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 28s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 10s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 25s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 12s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 44s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   0m 32s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 10s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 57s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 24s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 24s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 12s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |   5m 33s |  Patch does not cause any 
errors with Hadoop 3.3.6.  |
   | +1 :green_heart: |  spotless  |   0m 42s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   0m 46s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 14s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  23m 44s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5647/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5647 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux b646b7786b2e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | Max. process+thread count | 84 (vs. ulimit of 3) |
   | modules | C: hbase-metrics-api hbase-metrics U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5647/1/console 
|
   | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (HBASE-28327) Add remove(String key, Metric metric) method to MetricRegistry interface

2024-01-24 Thread Evelyn Boland (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-28327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Evelyn Boland updated HBASE-28327:
--
Description: 
Add a `remove(String name, Metric metric)` method to the `MetricRegistry` 
interface. Right now the interface only contains a `remove(String name)` method.

This additional remove method will give users the power to remove a `Metric` 
with the specified `name` from the metric registry if and only if the provided 
`metric` matches the object in the registry.

Implementing the new `remove(String name, Metric metric)` should be straight 
forward because the `MetricRegistryImpl` class stores metrics in a 
`ConcurrentMap`, which already contains a `remove(Object key, Object value)` 
method

This change will not be a breaking one because the interface is marked with 
`@IntefaceStability.Evolving`

[~rmdmattingly]

  was:
Add a `remove(String name, Metric metric)` method to the `MetricRegistry` 
interface. Right now the interface only contains a `remove(String name)` method.

This additional remove method will give users the power to remove a `Metric` 
with the specified `name` from the metric registry if and only if the provided 
`metric` matches the object in the registry.

Implementing the new `remove(String metric, Metric metric)` should be straight 
forward because the `MetricRegistryImpl` class stores metrics in a 
`ConcurrentMap`, which already contains a `remove(Object key, Object value)` 
method

This change will not be a breaking one because the interface is marked with 
`@IntefaceStability.Evolving`

[~rmdmattingly]


> Add remove(String key, Metric metric) method to MetricRegistry interface
> 
>
> Key: HBASE-28327
> URL: https://issues.apache.org/jira/browse/HBASE-28327
> Project: HBase
>  Issue Type: Improvement
>Reporter: Evelyn Boland
>Priority: Major
>
> Add a `remove(String name, Metric metric)` method to the `MetricRegistry` 
> interface. Right now the interface only contains a `remove(String name)` 
> method.
> This additional remove method will give users the power to remove a `Metric` 
> with the specified `name` from the metric registry if and only if the 
> provided `metric` matches the object in the registry.
> Implementing the new `remove(String name, Metric metric)` should be straight 
> forward because the `MetricRegistryImpl` class stores metrics in a 
> `ConcurrentMap`, which already contains a `remove(Object key, Object value)` 
> method
> This change will not be a breaking one because the interface is marked with 
> `@IntefaceStability.Evolving`
> [~rmdmattingly]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-28303) Interrupt cache prefetch thread when a heap usage threshold is reached

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810585#comment-17810585
 ] 

ASF GitHub Bot commented on HBASE-28303:


Apache-HBase commented on PR #5615:
URL: https://github.com/apache/hbase/pull/5615#issuecomment-1909041510

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 10s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  3s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 50s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   5m  8s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 27s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 46s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 49s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 49s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m  7s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 26s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 292m 50s |  hbase-server in the patch passed.  
|
   |  |   | 316m 27s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.44 ServerAPI=1.44 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5615 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 64d23fb143e7 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 
11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/8/testReport/
 |
   | Max. process+thread count | 4587 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/8/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Interrupt cache prefetch thread when a heap usage threshold is reached
> --
>
> Key: HBASE-28303
> URL: https://issues.apache.org/jira/browse/HBASE-28303
> Project: HBase
>  Issue Type: Improvement
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
>
> Mostly critical when using non heap cache implementations, such as offheap or 
> file based. If the cache medium is too large and there are many blocks to be 
> cached, it may create a lot of cache index object in the RegionServer heap. 
> We should have guardrails to preventing caching from exhausting available 
> heap.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] HBASE-28303 Interrupt cache prefetch thread when a heap usage threshold is reached [hbase]

2024-01-24 Thread via GitHub


Apache-HBase commented on PR #5615:
URL: https://github.com/apache/hbase/pull/5615#issuecomment-1909041510

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 10s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  3s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 50s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   5m  8s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 27s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 46s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 49s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 49s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m  7s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 26s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 292m 50s |  hbase-server in the patch passed.  
|
   |  |   | 316m 27s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.44 ServerAPI=1.44 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5615 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 64d23fb143e7 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 
11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/8/testReport/
 |
   | Max. process+thread count | 4587 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/8/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-28303) Interrupt cache prefetch thread when a heap usage threshold is reached

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810584#comment-17810584
 ] 

ASF GitHub Bot commented on HBASE-28303:


Apache-HBase commented on PR #5615:
URL: https://github.com/apache/hbase/pull/5615#issuecomment-1909036162

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 52s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 55s |  master passed  |
   | +1 :green_heart: |  compile  |   1m  3s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   7m 54s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 42s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 43s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m  4s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m  4s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   7m 23s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 34s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 281m 30s |  hbase-server in the patch failed.  |
   |  |   | 313m 14s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.44 ServerAPI=1.44 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/8/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5615 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 1d31674a6e6a 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 
14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Default Java | Temurin-1.8.0_352-b08 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/8/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/8/testReport/
 |
   | Max. process+thread count | 4837 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/8/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Interrupt cache prefetch thread when a heap usage threshold is reached
> --
>
> Key: HBASE-28303
> URL: https://issues.apache.org/jira/browse/HBASE-28303
> Project: HBase
>  Issue Type: Improvement
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
>
> Mostly critical when using non heap cache implementations, such as offheap or 
> file based. If the cache medium is too large and there are many blocks to be 
> cached, it may create a lot of cache index object in the RegionServer heap. 
> We should have guardrails to preventing caching from exhausting available 
> heap.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] HBASE-28303 Interrupt cache prefetch thread when a heap usage threshold is reached [hbase]

2024-01-24 Thread via GitHub


Apache-HBase commented on PR #5615:
URL: https://github.com/apache/hbase/pull/5615#issuecomment-1909036162

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 52s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 55s |  master passed  |
   | +1 :green_heart: |  compile  |   1m  3s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   7m 54s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 42s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 43s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m  4s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m  4s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   7m 23s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 34s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 281m 30s |  hbase-server in the patch failed.  |
   |  |   | 313m 14s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.44 ServerAPI=1.44 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/8/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5615 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 1d31674a6e6a 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 
14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Default Java | Temurin-1.8.0_352-b08 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/8/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/8/testReport/
 |
   | Max. process+thread count | 4837 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/8/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-28327) Add remove(String key, Metric metric) method to MetricRegistry interface

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810580#comment-17810580
 ] 

ASF GitHub Bot commented on HBASE-28327:


eab148 opened a new pull request, #5647:
URL: https://github.com/apache/hbase/pull/5647

   JIRA: https://issues.apache.org/jira/browse/HBASE-28327
   
   This will help us clean up metrics safely. We will remove a `Metric` with 
the specified `name` from the metric registry if and only if the provided 
`metric` matches the object in the registry.
   
   




> Add remove(String key, Metric metric) method to MetricRegistry interface
> 
>
> Key: HBASE-28327
> URL: https://issues.apache.org/jira/browse/HBASE-28327
> Project: HBase
>  Issue Type: Improvement
>Reporter: Evelyn Boland
>Priority: Major
>
> Add a `remove(String name, Metric metric)` method to the `MetricRegistry` 
> interface. Right now the interface only contains a `remove(String name)` 
> method.
> This additional remove method will give users the power to remove a `Metric` 
> with the specified `name` from the metric registry if and only if the 
> provided `metric` matches the object in the registry.
> Implementing the new `remove(String metric, Metric metric)` should be 
> straight forward because the `MetricRegistryImpl` class stores metrics in a 
> `ConcurrentMap`, which already contains a `remove(Object key, Object value)` 
> method
> This change will not be a breaking one because the interface is marked with 
> `@IntefaceStability.Evolving`
> [~rmdmattingly]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HBASE-28327) Add remove(String key, Metric metric) method to MetricRegistry interface

2024-01-24 Thread Evelyn Boland (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-28327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Evelyn Boland updated HBASE-28327:
--
Description: 
Add a `remove(String name, Metric metric)` method to the `MetricRegistry` 
interface. Right now the interface only contains a `remove(String name)` method.

This additional remove method will give users the power to remove a `Metric` 
with the specified `name` from the metric registry if and only if the provided 
`metric` matches the object in the registry.

Implementing the new `remove(String metric, Metric metric)` should be straight 
forward because the `MetricRegistryImpl` class stores metrics in a 
`ConcurrentMap`, which already contains a `remove(Object key, Object value)` 
method

This change will not be a breaking one because the interface is marked with 
`@IntefaceStability.Evolving`

[~rmdmattingly]

  was:
Add a `remove(String name, Metric metric)` method to the `MetricRegistry` 
interface. Right now the interface only contains a `remove(String name)` method.

This additional remove method will give users the power to remove a `Metric` 
with the specified `name` from the metric registry if and only if the provided 
`metric` matches the object in the registry.

Implementing the new `remove(String metric, Metric metric)`}}{}}} should be 
straight forward because the `MetricRegistryImpl` class stores metrics in a 
`ConcurrentMap`, which already contains a `remove(Object key, Object value)` 
method

This change will not be a breaking one because the interface is marked with 
`@IntefaceStability.Evolving`

[~rmdmattingly]


> Add remove(String key, Metric metric) method to MetricRegistry interface
> 
>
> Key: HBASE-28327
> URL: https://issues.apache.org/jira/browse/HBASE-28327
> Project: HBase
>  Issue Type: Improvement
>Reporter: Evelyn Boland
>Priority: Major
>
> Add a `remove(String name, Metric metric)` method to the `MetricRegistry` 
> interface. Right now the interface only contains a `remove(String name)` 
> method.
> This additional remove method will give users the power to remove a `Metric` 
> with the specified `name` from the metric registry if and only if the 
> provided `metric` matches the object in the registry.
> Implementing the new `remove(String metric, Metric metric)` should be 
> straight forward because the `MetricRegistryImpl` class stores metrics in a 
> `ConcurrentMap`, which already contains a `remove(Object key, Object value)` 
> method
> This change will not be a breaking one because the interface is marked with 
> `@IntefaceStability.Evolving`
> [~rmdmattingly]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-28216) HDFS erasure coding support for table data dirs

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810561#comment-17810561
 ] 

ASF GitHub Bot commented on HBASE-28216:


Apache-HBase commented on PR #5591:
URL: https://github.com/apache/hbase/pull/5591#issuecomment-1908883547

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 20s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +0 :ok: |  prototool  |   0m  0s |  prototool was not available.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 14s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 59s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   5m 18s |  branch-2 passed  |
   | +1 :green_heart: |  checkstyle  |   1m 50s |  branch-2 passed  |
   | +1 :green_heart: |  spotless  |   1m  2s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   7m  6s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 18s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   4m  8s |  the patch passed  |
   | +1 :green_heart: |  compile  |   6m 33s |  the patch passed  |
   | +1 :green_heart: |  cc  |   6m 33s |  the patch passed  |
   | -0 :warning: |  javac  |   4m  4s |  hbase-server generated 1 new + 194 
unchanged - 1 fixed = 195 total (was 195)  |
   | -0 :warning: |  checkstyle  |   0m 58s |  hbase-server: The patch 
generated 1 new + 7 unchanged - 0 fixed = 8 total (was 7)  |
   | -0 :warning: |  rubocop  |   0m 17s |  The patch generated 21 new + 728 
unchanged - 3 fixed = 749 total (was 731)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |  14m 38s |  Patch does not cause any 
errors with Hadoop 2.10.2 or 3.3.6.  |
   | +1 :green_heart: |  hbaseprotoc  |   2m 25s |  the patch passed  |
   | +1 :green_heart: |  spotless  |   1m  3s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   7m  3s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 48s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  61m 36s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.44 ServerAPI=1.44 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/4/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5591 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile cc hbaseprotoc prototool rubocop |
   | uname | Linux 516f06d635eb 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 
11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 97974024a8 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | javac | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/4/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
 |
   | checkstyle | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
 |
   | rubocop | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/4/artifact/yetus-general-check/output/diff-patch-rubocop.txt
 |
   | Max. process+thread count | 80 (vs. ulimit of 3) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-shell 
U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/4/console 
|
   | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> HDFS erasure coding support for table data dirs
> ---
>
> Key: HBASE-28216
> URL: https://issues.apache.org/jira/browse/HBASE-28216
> Project: HBase
>  Issue Type: New Feature
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Major
>  Labels: patch-available
>
> [Erasure 
> coding|https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-hdfs/HDFSErasureCoding.html]
>  (EC) is a hadoop-3 feature which can drastically reduce 

Re: [PR] HBASE-28216 HDFS erasure coding support for table data dirs [hbase]

2024-01-24 Thread via GitHub


Apache-HBase commented on PR #5591:
URL: https://github.com/apache/hbase/pull/5591#issuecomment-1908883547

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 20s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +0 :ok: |  prototool  |   0m  0s |  prototool was not available.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 14s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 59s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   5m 18s |  branch-2 passed  |
   | +1 :green_heart: |  checkstyle  |   1m 50s |  branch-2 passed  |
   | +1 :green_heart: |  spotless  |   1m  2s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   7m  6s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 18s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   4m  8s |  the patch passed  |
   | +1 :green_heart: |  compile  |   6m 33s |  the patch passed  |
   | +1 :green_heart: |  cc  |   6m 33s |  the patch passed  |
   | -0 :warning: |  javac  |   4m  4s |  hbase-server generated 1 new + 194 
unchanged - 1 fixed = 195 total (was 195)  |
   | -0 :warning: |  checkstyle  |   0m 58s |  hbase-server: The patch 
generated 1 new + 7 unchanged - 0 fixed = 8 total (was 7)  |
   | -0 :warning: |  rubocop  |   0m 17s |  The patch generated 21 new + 728 
unchanged - 3 fixed = 749 total (was 731)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |  14m 38s |  Patch does not cause any 
errors with Hadoop 2.10.2 or 3.3.6.  |
   | +1 :green_heart: |  hbaseprotoc  |   2m 25s |  the patch passed  |
   | +1 :green_heart: |  spotless  |   1m  3s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   7m  3s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 48s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  61m 36s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.44 ServerAPI=1.44 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/4/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5591 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile cc hbaseprotoc prototool rubocop |
   | uname | Linux 516f06d635eb 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 
11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 97974024a8 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | javac | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/4/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
 |
   | checkstyle | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
 |
   | rubocop | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/4/artifact/yetus-general-check/output/diff-patch-rubocop.txt
 |
   | Max. process+thread count | 80 (vs. ulimit of 3) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-shell 
U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5591/4/console 
|
   | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (HBASE-28327) Add remove(String key, Metric metric) method to MetricRegistry interface

2024-01-24 Thread Evelyn Boland (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-28327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Evelyn Boland updated HBASE-28327:
--
Description: 
Add a `remove(String name, Metric metric)` method to the `MetricRegistry` 
interface. Right now the interface only contains a `remove(String name)` method.

This additional remove method will give users the power to remove a `Metric` 
with the specified `name` from the metric registry if and only if the provided 
`metric` matches the object in the registry.

Implementing the new `remove(String metric, Metric metric)`}}{}}} should be 
straight forward because the `MetricRegistryImpl` class stores metrics in a 
`ConcurrentMap`, which already contains a `remove(Object key, Object value)` 
method

This change will not be a breaking one because the interface is marked with 
`@IntefaceStability.Evolving`

[~rmdmattingly]

  was:
Add a `remove(String name, Metric metric)` {{{}{}}}method to the 
`MetricRegistry` interface. Right now the interface only contains a 
`remove(String name)` method.

This additional remove method will give users the power to remove a `Metric` 
with the specified `name` from the metric registry if and only if the provided 
`metric` matches the object in the registry.

Implementing the new `remove(String metric, Metric metric)`{{{}{}}} should be 
straight forward because the `MetricRegistryImpl` class stores metrics in a 
`ConcurrentMap`, which already contains a `remove(Object key, Object value)` 
method

This change will not be a breaking one because the interface is marked with 
`@IntefaceStability.Evolving`

[~rmdmattingly]


> Add remove(String key, Metric metric) method to MetricRegistry interface
> 
>
> Key: HBASE-28327
> URL: https://issues.apache.org/jira/browse/HBASE-28327
> Project: HBase
>  Issue Type: Improvement
>Reporter: Evelyn Boland
>Priority: Major
>
> Add a `remove(String name, Metric metric)` method to the `MetricRegistry` 
> interface. Right now the interface only contains a `remove(String name)` 
> method.
> This additional remove method will give users the power to remove a `Metric` 
> with the specified `name` from the metric registry if and only if the 
> provided `metric` matches the object in the registry.
> Implementing the new `remove(String metric, Metric metric)`}}{}}} should 
> be straight forward because the `MetricRegistryImpl` class stores metrics in 
> a `ConcurrentMap`, which already contains a `remove(Object key, Object 
> value)` method
> This change will not be a breaking one because the interface is marked with 
> `@IntefaceStability.Evolving`
> [~rmdmattingly]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (HBASE-28327) Add remove(String key, Metric metric) method to MetricRegistry interface

2024-01-24 Thread Evelyn Boland (Jira)
Evelyn Boland created HBASE-28327:
-

 Summary: Add remove(String key, Metric metric) method to 
MetricRegistry interface
 Key: HBASE-28327
 URL: https://issues.apache.org/jira/browse/HBASE-28327
 Project: HBase
  Issue Type: Improvement
Reporter: Evelyn Boland


Add a `remove(String name, Metric metric)` {{{}{}}}method to the 
`MetricRegistry` interface. Right now the interface only contains a 
`remove(String name)` method.

This additional remove method will give users the power to remove a `Metric` 
with the specified `name` from the metric registry if and only if the provided 
`metric` matches the object in the registry.

Implementing the new `remove(String metric, Metric metric)`{{{}{}}} should be 
straight forward because the `MetricRegistryImpl` class stores metrics in a 
`ConcurrentMap`, which already contains a `remove(Object key, Object value)` 
method

This change will not be a breaking one because the interface is marked with 
`@IntefaceStability.Evolving`

[~rmdmattingly]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-28255) Correcting spelling errors or annotations with non-standard spelling

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810553#comment-17810553
 ] 

ASF GitHub Bot commented on HBASE-28255:


Apache-HBase commented on PR #5577:
URL: https://github.com/apache/hbase/pull/5577#issuecomment-1908847667

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 37s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 54s |  master passed  |
   | +1 :green_heart: |  compile  |   1m 45s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   5m  5s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 13s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 45s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 43s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 43s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m  6s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 10s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 29s |  hbase-client in the patch passed.  
|
   | +1 :green_heart: |  unit  |   1m 27s |  hbase-procedure in the patch 
passed.  |
   | -1 :x: |  unit  | 268m 43s |  hbase-server in the patch failed.  |
   | +1 :green_heart: |  unit  |   3m 15s |  hbase-examples in the patch 
passed.  |
   |  |   | 303m 16s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.44 ServerAPI=1.44 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5577/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5577 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 75ed7e39360d 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 
14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5577/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5577/2/testReport/
 |
   | Max. process+thread count | 4780 (vs. ulimit of 3) |
   | modules | C: hbase-client hbase-procedure hbase-server hbase-examples U: . 
|
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5577/2/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Correcting spelling errors or annotations with non-standard spelling
> 
>
> Key: HBASE-28255
> URL: https://issues.apache.org/jira/browse/HBASE-28255
> Project: HBase
>  Issue Type: Improvement
>Reporter: mazhengxuan
>Priority: Minor
>  Labels: documentation
>
> Modify some spelling errors or non-standard spelling comments pointed out by 
> Typo



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] HBASE-28255 Correcting spelling errors or annotations with non-standard spelling [hbase]

2024-01-24 Thread via GitHub


Apache-HBase commented on PR #5577:
URL: https://github.com/apache/hbase/pull/5577#issuecomment-1908847667

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 37s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 54s |  master passed  |
   | +1 :green_heart: |  compile  |   1m 45s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   5m  5s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 13s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 45s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 43s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 43s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m  6s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 10s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 29s |  hbase-client in the patch passed.  
|
   | +1 :green_heart: |  unit  |   1m 27s |  hbase-procedure in the patch 
passed.  |
   | -1 :x: |  unit  | 268m 43s |  hbase-server in the patch failed.  |
   | +1 :green_heart: |  unit  |   3m 15s |  hbase-examples in the patch 
passed.  |
   |  |   | 303m 16s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.44 ServerAPI=1.44 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5577/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5577 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 75ed7e39360d 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 
14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5577/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5577/2/testReport/
 |
   | Max. process+thread count | 4780 (vs. ulimit of 3) |
   | modules | C: hbase-client hbase-procedure hbase-server hbase-examples U: . 
|
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5577/2/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-28255) Correcting spelling errors or annotations with non-standard spelling

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810551#comment-17810551
 ] 

ASF GitHub Bot commented on HBASE-28255:


Apache-HBase commented on PR #5577:
URL: https://github.com/apache/hbase/pull/5577#issuecomment-1908843799

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 30s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 22s |  master passed  |
   | +1 :green_heart: |  compile  |   1m 48s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   6m 38s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 14s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 55s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 44s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 44s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   6m 10s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 11s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 30s |  hbase-client in the patch passed.  
|
   | +1 :green_heart: |  unit  |   1m 31s |  hbase-procedure in the patch 
passed.  |
   | -1 :x: |  unit  | 263m 42s |  hbase-server in the patch failed.  |
   | +1 :green_heart: |  unit  |   2m 38s |  hbase-examples in the patch 
passed.  |
   |  |   | 299m 55s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5577/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5577 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 32b352daa60b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Default Java | Temurin-1.8.0_352-b08 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5577/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5577/2/testReport/
 |
   | Max. process+thread count | 4833 (vs. ulimit of 3) |
   | modules | C: hbase-client hbase-procedure hbase-server hbase-examples U: . 
|
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5577/2/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Correcting spelling errors or annotations with non-standard spelling
> 
>
> Key: HBASE-28255
> URL: https://issues.apache.org/jira/browse/HBASE-28255
> Project: HBase
>  Issue Type: Improvement
>Reporter: mazhengxuan
>Priority: Minor
>  Labels: documentation
>
> Modify some spelling errors or non-standard spelling comments pointed out by 
> Typo



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] HBASE-28255 Correcting spelling errors or annotations with non-standard spelling [hbase]

2024-01-24 Thread via GitHub


Apache-HBase commented on PR #5577:
URL: https://github.com/apache/hbase/pull/5577#issuecomment-1908843799

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 30s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 22s |  master passed  |
   | +1 :green_heart: |  compile  |   1m 48s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   6m 38s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 14s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 55s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 44s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 44s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   6m 10s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 11s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 30s |  hbase-client in the patch passed.  
|
   | +1 :green_heart: |  unit  |   1m 31s |  hbase-procedure in the patch 
passed.  |
   | -1 :x: |  unit  | 263m 42s |  hbase-server in the patch failed.  |
   | +1 :green_heart: |  unit  |   2m 38s |  hbase-examples in the patch 
passed.  |
   |  |   | 299m 55s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5577/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5577 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 32b352daa60b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Default Java | Temurin-1.8.0_352-b08 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5577/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5577/2/testReport/
 |
   | Max. process+thread count | 4833 (vs. ulimit of 3) |
   | modules | C: hbase-client hbase-procedure hbase-server hbase-examples U: . 
|
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5577/2/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-28317) RpcCallContext should expose client's TLS certificate

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810542#comment-17810542
 ] 

ASF GitHub Bot commented on HBASE-28317:


Apache-HBase commented on PR #5644:
URL: https://github.com/apache/hbase/pull/5644#issuecomment-1908808308

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 33s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 36s |  master passed  |
   | +1 :green_heart: |  compile  |   3m  2s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 40s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 52s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 45s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 34s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 54s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 54s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 40s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |   6m 44s |  Patch does not cause any 
errors with Hadoop 3.3.6.  |
   | +1 :green_heart: |  spotless  |   0m 46s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   2m  9s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 10s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  36m 11s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5644/2/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5644 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux 7c1e15ae606f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | Max. process+thread count | 79 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5644/2/console 
|
   | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> RpcCallContext should expose client's TLS certificate
> -
>
> Key: HBASE-28317
> URL: https://issues.apache.org/jira/browse/HBASE-28317
> Project: HBase
>  Issue Type: Improvement
>Reporter: Charles Connell
>Assignee: Charles Connell
>Priority: Minor
>
> At my employer we plan on using a coprocessor to log information about some 
> requests to HBase. For this to be useful to us, we need to know who each 
> request is coming from. We use HBase's TLS support with mutual authentication 
> to authenticate clients. I'd like a way to expose the client certificate used 
> on a request to coprocessors. For setups using Kerberos authentication, 
> RpcCall exposes the Kerberos principal shortname via {{getRequestUser()}}, so 
> this would be the TLS equivalent to that.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] HBASE-28317: Expose client TLS certificate on RpcCallContext [hbase]

2024-01-24 Thread via GitHub


Apache-HBase commented on PR #5644:
URL: https://github.com/apache/hbase/pull/5644#issuecomment-1908808308

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 33s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 36s |  master passed  |
   | +1 :green_heart: |  compile  |   3m  2s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 40s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 52s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 45s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 34s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 54s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 54s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 40s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |   6m 44s |  Patch does not cause any 
errors with Hadoop 3.3.6.  |
   | +1 :green_heart: |  spotless  |   0m 46s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   2m  9s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 10s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  36m 11s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5644/2/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5644 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux 7c1e15ae606f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | Max. process+thread count | 79 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5644/2/console 
|
   | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-28317) RpcCallContext should expose client's TLS certificate

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810534#comment-17810534
 ] 

ASF GitHub Bot commented on HBASE-28317:


charlesconnell commented on code in PR #5644:
URL: https://github.com/apache/hbase/pull/5644#discussion_r1465412933


##
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServer.java:
##
@@ -413,6 +415,19 @@ private void initSSL(ChannelPipeline p, boolean 
supportPlaintext)
   sslHandler.setWrapDataSize(
 conf.getInt(HBASE_SERVER_NETTY_TLS_WRAP_SIZE, 
DEFAULT_HBASE_SERVER_NETTY_TLS_WRAP_SIZE));
 
+  sslHandler.handshakeFuture().addListener(future -> {
+try {
+  Certificate[] certificates = 
sslHandler.engine().getSession().getPeerCertificates();
+  if (certificates.length > 0) {
+conn.clientCertificate = (X509Certificate) certificates[0];
+  } else {

Review Comment:
   I've changed the interface to use the certificate chain. I'm also logging 
when `getNeedClientAuth()` is true but no certificate is found. I don't think 
throwing an exception in this listener is any more useful than logging, it 
wouldn't block a connection from forming. I also don't necessarily think that 
it's the job of this code to verify that connections that require mutual auth 
are doing it. Netty is already enforcing that.





> RpcCallContext should expose client's TLS certificate
> -
>
> Key: HBASE-28317
> URL: https://issues.apache.org/jira/browse/HBASE-28317
> Project: HBase
>  Issue Type: Improvement
>Reporter: Charles Connell
>Assignee: Charles Connell
>Priority: Minor
>
> At my employer we plan on using a coprocessor to log information about some 
> requests to HBase. For this to be useful to us, we need to know who each 
> request is coming from. We use HBase's TLS support with mutual authentication 
> to authenticate clients. I'd like a way to expose the client certificate used 
> on a request to coprocessors. For setups using Kerberos authentication, 
> RpcCall exposes the Kerberos principal shortname via {{getRequestUser()}}, so 
> this would be the TLS equivalent to that.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] HBASE-28317: Expose client TLS certificate on RpcCallContext [hbase]

2024-01-24 Thread via GitHub


charlesconnell commented on code in PR #5644:
URL: https://github.com/apache/hbase/pull/5644#discussion_r1465412933


##
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServer.java:
##
@@ -413,6 +415,19 @@ private void initSSL(ChannelPipeline p, boolean 
supportPlaintext)
   sslHandler.setWrapDataSize(
 conf.getInt(HBASE_SERVER_NETTY_TLS_WRAP_SIZE, 
DEFAULT_HBASE_SERVER_NETTY_TLS_WRAP_SIZE));
 
+  sslHandler.handshakeFuture().addListener(future -> {
+try {
+  Certificate[] certificates = 
sslHandler.engine().getSession().getPeerCertificates();
+  if (certificates.length > 0) {
+conn.clientCertificate = (X509Certificate) certificates[0];
+  } else {

Review Comment:
   I've changed the interface to use the certificate chain. I'm also logging 
when `getNeedClientAuth()` is true but no certificate is found. I don't think 
throwing an exception in this listener is any more useful than logging, it 
wouldn't block a connection from forming. I also don't necessarily think that 
it's the job of this code to verify that connections that require mutual auth 
are doing it. Netty is already enforcing that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-28313) StorefileRefresherChore should not refresh readonly table

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810531#comment-17810531
 ] 

ASF GitHub Bot commented on HBASE-28313:


Apache-HBase commented on PR #5641:
URL: https://github.com/apache/hbase/pull/5641#issuecomment-1908730798

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 24s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 20s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 38s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   5m 20s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 21s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 18s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 36s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 36s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 16s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 20s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 237m 25s |  hbase-server in the patch passed.  
|
   |  |   | 259m 38s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5641/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5641 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 462019d83b62 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Default Java | Temurin-1.8.0_352-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5641/3/testReport/
 |
   | Max. process+thread count | 5202 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5641/3/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> StorefileRefresherChore should not refresh readonly table
> -
>
> Key: HBASE-28313
> URL: https://issues.apache.org/jira/browse/HBASE-28313
> Project: HBase
>  Issue Type: Improvement
>  Components: regionserver
>Affects Versions: 2.4.17
>Reporter: Hao Sun
>Priority: Major
> Fix For: 2.4.17
>
>
> According to semantics, when StoreFile Refresher is turned on, only the area 
> with replicas should be refreshed. *Tables with read-only attributes will not 
> be refreshed.*
> There are the following scenarios: Assume that some tables in the database 
> have replica enabled, while others do not. If a table that does not have 
> replica enabled needs to perform migration tasks - first enable readonly and 
> then export the snapshot, StorefileRefresherChore will always refresh the 
> table that does not have replica enabled but performs migration tasks. This 
> is obviously illogical.
> Therefore, StorefileRefresherChore needs to determine whether the region has 
> a read-only copy, and refresh it if it has a read-only copy. And tables with 
> read-only properties are not refreshed.
> patch:[HBASE-28313|https://github.com/apache/hbase/pull/5641]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] HBASE-28313 StorefileRefresherChore should not refresh readonly table [hbase]

2024-01-24 Thread via GitHub


Apache-HBase commented on PR #5641:
URL: https://github.com/apache/hbase/pull/5641#issuecomment-1908730798

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 24s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 20s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 38s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   5m 20s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 21s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 18s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 36s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 36s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 16s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 20s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 237m 25s |  hbase-server in the patch passed.  
|
   |  |   | 259m 38s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5641/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5641 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 462019d83b62 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Default Java | Temurin-1.8.0_352-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5641/3/testReport/
 |
   | Max. process+thread count | 5202 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5641/3/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-28313) StorefileRefresherChore should not refresh readonly table

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810522#comment-17810522
 ] 

ASF GitHub Bot commented on HBASE-28313:


Apache-HBase commented on PR #5641:
URL: https://github.com/apache/hbase/pull/5641#issuecomment-1908705325

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 25s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 50s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 45s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   5m 37s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 23s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 52s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 45s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 45s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 38s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 23s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 217m 46s |  hbase-server in the patch passed.  
|
   |  |   | 241m  7s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5641/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5641 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 6286e4881dfb 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5641/3/testReport/
 |
   | Max. process+thread count | 5025 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5641/3/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> StorefileRefresherChore should not refresh readonly table
> -
>
> Key: HBASE-28313
> URL: https://issues.apache.org/jira/browse/HBASE-28313
> Project: HBase
>  Issue Type: Improvement
>  Components: regionserver
>Affects Versions: 2.4.17
>Reporter: Hao Sun
>Priority: Major
> Fix For: 2.4.17
>
>
> According to semantics, when StoreFile Refresher is turned on, only the area 
> with replicas should be refreshed. *Tables with read-only attributes will not 
> be refreshed.*
> There are the following scenarios: Assume that some tables in the database 
> have replica enabled, while others do not. If a table that does not have 
> replica enabled needs to perform migration tasks - first enable readonly and 
> then export the snapshot, StorefileRefresherChore will always refresh the 
> table that does not have replica enabled but performs migration tasks. This 
> is obviously illogical.
> Therefore, StorefileRefresherChore needs to determine whether the region has 
> a read-only copy, and refresh it if it has a read-only copy. And tables with 
> read-only properties are not refreshed.
> patch:[HBASE-28313|https://github.com/apache/hbase/pull/5641]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] HBASE-28313 StorefileRefresherChore should not refresh readonly table [hbase]

2024-01-24 Thread via GitHub


Apache-HBase commented on PR #5641:
URL: https://github.com/apache/hbase/pull/5641#issuecomment-1908705325

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 25s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 50s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 45s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   5m 37s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 23s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 52s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 45s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 45s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 38s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 23s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 217m 46s |  hbase-server in the patch passed.  
|
   |  |   | 241m  7s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5641/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5641 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 6286e4881dfb 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5641/3/testReport/
 |
   | Max. process+thread count | 5025 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5641/3/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28303 Interrupt cache prefetch thread when a heap usage threshold is reached [hbase]

2024-01-24 Thread via GitHub


Apache-HBase commented on PR #5615:
URL: https://github.com/apache/hbase/pull/5615#issuecomment-1908652864

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 43s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 22s |  master passed  |
   | +1 :green_heart: |  compile  |   3m  4s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 46s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 53s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 51s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 30s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 53s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 53s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   0m 39s |  hbase-server: The patch 
generated 11 new + 24 unchanged - 0 fixed = 35 total (was 24)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |   5m 15s |  Patch does not cause any 
errors with Hadoop 3.3.6.  |
   | +1 :green_heart: |  spotless  |   0m 58s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   2m 11s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 10s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  33m 36s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.44 ServerAPI=1.44 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/8/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5615 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux 0f8cf4cf104d 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 
13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | checkstyle | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/8/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
 |
   | Max. process+thread count | 79 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/8/console 
|
   | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-28303) Interrupt cache prefetch thread when a heap usage threshold is reached

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810516#comment-17810516
 ] 

ASF GitHub Bot commented on HBASE-28303:


Apache-HBase commented on PR #5615:
URL: https://github.com/apache/hbase/pull/5615#issuecomment-1908652864

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 43s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 22s |  master passed  |
   | +1 :green_heart: |  compile  |   3m  4s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 46s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 53s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 51s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 30s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 53s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 53s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   0m 39s |  hbase-server: The patch 
generated 11 new + 24 unchanged - 0 fixed = 35 total (was 24)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |   5m 15s |  Patch does not cause any 
errors with Hadoop 3.3.6.  |
   | +1 :green_heart: |  spotless  |   0m 58s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   2m 11s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 10s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  33m 36s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.44 ServerAPI=1.44 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/8/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5615 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux 0f8cf4cf104d 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 
13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | checkstyle | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/8/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
 |
   | Max. process+thread count | 79 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/8/console 
|
   | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Interrupt cache prefetch thread when a heap usage threshold is reached
> --
>
> Key: HBASE-28303
> URL: https://issues.apache.org/jira/browse/HBASE-28303
> Project: HBase
>  Issue Type: Improvement
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
>
> Mostly critical when using non heap cache implementations, such as offheap or 
> file based. If the cache medium is too large and there are many blocks to be 
> cached, it may create a lot of cache index object in the RegionServer heap. 
> We should have guardrails to preventing caching from exhausting available 
> heap.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-28255) Correcting spelling errors or annotations with non-standard spelling

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810470#comment-17810470
 ] 

ASF GitHub Bot commented on HBASE-28255:


Apache-HBase commented on PR #5577:
URL: https://github.com/apache/hbase/pull/5577#issuecomment-1908417796

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 27s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 19s |  master passed  |
   | +1 :green_heart: |  compile  |   4m 36s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   1m 22s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 55s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   3m 52s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 10s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 36s |  the patch passed  |
   | +1 :green_heart: |  compile  |   4m 36s |  the patch passed  |
   | +1 :green_heart: |  javac  |   4m 36s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   1m 25s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |   6m  4s |  Patch does not cause any 
errors with Hadoop 3.3.6.  |
   | +1 :green_heart: |  spotless  |   0m 46s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   4m 20s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 36s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  44m 29s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5577/2/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5577 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux 9d54d5c421b2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | Max. process+thread count | 79 (vs. ulimit of 3) |
   | modules | C: hbase-client hbase-procedure hbase-server hbase-examples U: . 
|
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5577/2/console 
|
   | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Correcting spelling errors or annotations with non-standard spelling
> 
>
> Key: HBASE-28255
> URL: https://issues.apache.org/jira/browse/HBASE-28255
> Project: HBase
>  Issue Type: Improvement
>Reporter: mazhengxuan
>Priority: Minor
>  Labels: documentation
>
> Modify some spelling errors or non-standard spelling comments pointed out by 
> Typo



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] HBASE-28255 Correcting spelling errors or annotations with non-standard spelling [hbase]

2024-01-24 Thread via GitHub


Apache-HBase commented on PR #5577:
URL: https://github.com/apache/hbase/pull/5577#issuecomment-1908417796

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 27s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 19s |  master passed  |
   | +1 :green_heart: |  compile  |   4m 36s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   1m 22s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 55s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   3m 52s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 10s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 36s |  the patch passed  |
   | +1 :green_heart: |  compile  |   4m 36s |  the patch passed  |
   | +1 :green_heart: |  javac  |   4m 36s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   1m 25s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |   6m  4s |  Patch does not cause any 
errors with Hadoop 3.3.6.  |
   | +1 :green_heart: |  spotless  |   0m 46s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   4m 20s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 36s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  44m 29s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5577/2/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5577 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux 9d54d5c421b2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | Max. process+thread count | 79 (vs. ulimit of 3) |
   | modules | C: hbase-client hbase-procedure hbase-server hbase-examples U: . 
|
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5577/2/console 
|
   | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-28313) StorefileRefresherChore should not refresh readonly table

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810445#comment-17810445
 ] 

ASF GitHub Bot commented on HBASE-28313:


Apache-HBase commented on PR #5641:
URL: https://github.com/apache/hbase/pull/5641#issuecomment-1908315197

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 12s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  7s |  master passed  |
   | +1 :green_heart: |  compile  |   3m 11s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 44s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 52s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   2m 29s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 22s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m  7s |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m  7s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 44s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |   5m 37s |  Patch does not cause any 
errors with Hadoop 3.3.6.  |
   | +1 :green_heart: |  spotless  |   0m 42s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 48s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m  9s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  32m  8s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.44 ServerAPI=1.44 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5641/3/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5641 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux 5ddf8893bce4 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 
11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | Max. process+thread count | 87 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5641/3/console 
|
   | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> StorefileRefresherChore should not refresh readonly table
> -
>
> Key: HBASE-28313
> URL: https://issues.apache.org/jira/browse/HBASE-28313
> Project: HBase
>  Issue Type: Improvement
>  Components: regionserver
>Affects Versions: 2.4.17
>Reporter: Hao Sun
>Priority: Major
> Fix For: 2.4.17
>
>
> According to semantics, when StoreFile Refresher is turned on, only the area 
> with replicas should be refreshed. *Tables with read-only attributes will not 
> be refreshed.*
> There are the following scenarios: Assume that some tables in the database 
> have replica enabled, while others do not. If a table that does not have 
> replica enabled needs to perform migration tasks - first enable readonly and 
> then export the snapshot, StorefileRefresherChore will always refresh the 
> table that does not have replica enabled but performs migration tasks. This 
> is obviously illogical.
> Therefore, StorefileRefresherChore needs to determine whether the region has 
> a read-only copy, and refresh it if it has a read-only copy. And tables with 
> read-only properties are not refreshed.
> patch:[HBASE-28313|https://github.com/apache/hbase/pull/5641]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] HBASE-28313 StorefileRefresherChore should not refresh readonly table [hbase]

2024-01-24 Thread via GitHub


Apache-HBase commented on PR #5641:
URL: https://github.com/apache/hbase/pull/5641#issuecomment-1908315197

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 12s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  7s |  master passed  |
   | +1 :green_heart: |  compile  |   3m 11s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 44s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 52s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   2m 29s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 22s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m  7s |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m  7s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 44s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |   5m 37s |  Patch does not cause any 
errors with Hadoop 3.3.6.  |
   | +1 :green_heart: |  spotless  |   0m 42s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 48s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m  9s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  32m  8s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.44 ServerAPI=1.44 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5641/3/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5641 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux 5ddf8893bce4 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 
11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | Max. process+thread count | 87 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5641/3/console 
|
   | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix the inaccurate expired time of MOB HFiles [hbase]

2024-01-24 Thread via GitHub


Apache9 closed pull request #5597: Fix the inaccurate expired time of MOB HFiles
URL: https://github.com/apache/hbase/pull/5597


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Resolved] (HBASE-28326) All nightly jobs are failing

2024-01-24 Thread Duo Zhang (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-28326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang resolved HBASE-28326.
---
Fix Version/s: 2.6.0
   2.4.18
   2.5.8
   3.0.0-beta-2
 Hadoop Flags: Reviewed
 Assignee: Duo Zhang
   Resolution: Fixed

Pushed to all active branches.

Thanks [~sunxin] and [~nihaljain.cs] for reviewing!

> All nightly jobs are failing
> 
>
> Key: HBASE-28326
> URL: https://issues.apache.org/jira/browse/HBASE-28326
> Project: HBase
>  Issue Type: Bug
>  Components: jenkins
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 2.4.18, 2.5.8, 3.0.0-beta-2
>
>
> https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/991/console
> Failed in yetus install stage, seems to be related to gpg.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-28326) All nightly jobs are failing

2024-01-24 Thread Duo Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810413#comment-17810413
 ] 

Duo Zhang commented on HBASE-28326:
---

https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/993/console

Seems all right now.

Let me push all branches.

> All nightly jobs are failing
> 
>
> Key: HBASE-28326
> URL: https://issues.apache.org/jira/browse/HBASE-28326
> Project: HBase
>  Issue Type: Bug
>  Components: jenkins
>Reporter: Duo Zhang
>Priority: Major
>
> https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/991/console
> Failed in yetus install stage, seems to be related to gpg.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (HBASE-28322) Attach the design doc in HBASE-26220 to our code base

2024-01-24 Thread Duo Zhang (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-28322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang resolved HBASE-28322.
---
Fix Version/s: 2.6.0
   3.0.0-beta-2
 Hadoop Flags: Reviewed
   Resolution: Fixed

Pushed to branch-2.6+.

Thanks [~meiyi] and [~sunxin] for reviewing!

> Attach the design doc in HBASE-26220 to our code base
> -
>
> Key: HBASE-28322
> URL: https://issues.apache.org/jira/browse/HBASE-28322
> Project: HBase
>  Issue Type: Sub-task
>  Components: documentation
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 3.0.0-beta-2
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-28322) Attach the design doc in HBASE-26220 to our code base

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810401#comment-17810401
 ] 

ASF GitHub Bot commented on HBASE-28322:


Apache9 merged PR #5640:
URL: https://github.com/apache/hbase/pull/5640




> Attach the design doc in HBASE-26220 to our code base
> -
>
> Key: HBASE-28322
> URL: https://issues.apache.org/jira/browse/HBASE-28322
> Project: HBase
>  Issue Type: Sub-task
>  Components: documentation
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] HBASE-28322 Attach the design doc in HBASE-26220 to our code base [hbase]

2024-01-24 Thread via GitHub


Apache9 merged PR #5640:
URL: https://github.com/apache/hbase/pull/5640


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-28326) All nightly jobs are failing

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810400#comment-17810400
 ] 

ASF GitHub Bot commented on HBASE-28326:


Apache9 merged PR #5646:
URL: https://github.com/apache/hbase/pull/5646




> All nightly jobs are failing
> 
>
> Key: HBASE-28326
> URL: https://issues.apache.org/jira/browse/HBASE-28326
> Project: HBase
>  Issue Type: Bug
>  Components: jenkins
>Reporter: Duo Zhang
>Priority: Major
>
> https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/991/console
> Failed in yetus install stage, seems to be related to gpg.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] HBASE-28326 All nightly jobs are failing [hbase]

2024-01-24 Thread via GitHub


Apache9 merged PR #5646:
URL: https://github.com/apache/hbase/pull/5646


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-28303) Interrupt cache prefetch thread when a heap usage threshold is reached

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810396#comment-17810396
 ] 

ASF GitHub Bot commented on HBASE-28303:


Apache-HBase commented on PR #5615:
URL: https://github.com/apache/hbase/pull/5615#issuecomment-1908173494

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 24s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 41s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 45s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   5m 31s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 23s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 44s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 44s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 44s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 32s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 22s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 217m 54s |  hbase-server in the patch failed.  |
   |  |   | 240m 46s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5615 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 45b0b39c0d40 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 3a91c5b698 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/7/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/7/testReport/
 |
   | Max. process+thread count | 4720 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/7/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Interrupt cache prefetch thread when a heap usage threshold is reached
> --
>
> Key: HBASE-28303
> URL: https://issues.apache.org/jira/browse/HBASE-28303
> Project: HBase
>  Issue Type: Improvement
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
>
> Mostly critical when using non heap cache implementations, such as offheap or 
> file based. If the cache medium is too large and there are many blocks to be 
> cached, it may create a lot of cache index object in the RegionServer heap. 
> We should have guardrails to preventing caching from exhausting available 
> heap.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] HBASE-28303 Interrupt cache prefetch thread when a heap usage threshold is reached [hbase]

2024-01-24 Thread via GitHub


Apache-HBase commented on PR #5615:
URL: https://github.com/apache/hbase/pull/5615#issuecomment-1908173494

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 24s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 41s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 45s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   5m 31s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 23s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 44s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 44s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 44s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 32s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 22s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 217m 54s |  hbase-server in the patch failed.  |
   |  |   | 240m 46s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5615 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 45b0b39c0d40 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 3a91c5b698 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/7/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/7/testReport/
 |
   | Max. process+thread count | 4720 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/7/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-28303) Interrupt cache prefetch thread when a heap usage threshold is reached

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810314#comment-17810314
 ] 

ASF GitHub Bot commented on HBASE-28303:


Apache-HBase commented on PR #5615:
URL: https://github.com/apache/hbase/pull/5615#issuecomment-1907839316

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 24s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 58s |  master passed  |
   | +1 :green_heart: |  compile  |   2m 34s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 34s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 41s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 30s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 56s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 30s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 30s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   0m 34s |  hbase-server: The patch 
generated 11 new + 24 unchanged - 0 fixed = 35 total (was 24)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |   5m 31s |  Patch does not cause any 
errors with Hadoop 3.3.6.  |
   | +1 :green_heart: |  spotless  |   0m 42s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 37s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m  8s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  29m 23s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/7/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5615 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux 8be3cf5209cc 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 3a91c5b698 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | checkstyle | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/7/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
 |
   | Max. process+thread count | 79 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/7/console 
|
   | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Interrupt cache prefetch thread when a heap usage threshold is reached
> --
>
> Key: HBASE-28303
> URL: https://issues.apache.org/jira/browse/HBASE-28303
> Project: HBase
>  Issue Type: Improvement
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
>
> Mostly critical when using non heap cache implementations, such as offheap or 
> file based. If the cache medium is too large and there are many blocks to be 
> cached, it may create a lot of cache index object in the RegionServer heap. 
> We should have guardrails to preventing caching from exhausting available 
> heap.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] HBASE-28303 Interrupt cache prefetch thread when a heap usage threshold is reached [hbase]

2024-01-24 Thread via GitHub


Apache-HBase commented on PR #5615:
URL: https://github.com/apache/hbase/pull/5615#issuecomment-1907839316

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 24s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 58s |  master passed  |
   | +1 :green_heart: |  compile  |   2m 34s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 34s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 41s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 30s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 56s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 30s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 30s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   0m 34s |  hbase-server: The patch 
generated 11 new + 24 unchanged - 0 fixed = 35 total (was 24)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |   5m 31s |  Patch does not cause any 
errors with Hadoop 3.3.6.  |
   | +1 :green_heart: |  spotless  |   0m 42s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 37s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m  8s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  29m 23s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/7/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5615 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux 8be3cf5209cc 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 3a91c5b698 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | checkstyle | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/7/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
 |
   | Max. process+thread count | 79 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5615/7/console 
|
   | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-28326) All nightly jobs are failing

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810308#comment-17810308
 ] 

ASF GitHub Bot commented on HBASE-28326:


Apache-HBase commented on PR #5646:
URL: https://github.com/apache/hbase/pull/5646#issuecomment-1907790748

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 25s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +0 :ok: |  shelldocs  |   0m  0s |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  spotless  |   0m 42s |  branch has no errors when 
running spotless:check.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m  4s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  shellcheck  |   0m  0s |  There were no new shellcheck 
issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  spotless  |   0m 39s |  patch has no errors when 
running spotless:check.  |
   ||| _ Other Tests _ |
   | +0 :ok: |  asflicense  |   0m  0s |  ASF License check generated no 
output?  |
   |  |   |   2m 56s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5646/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5646 |
   | Optional Tests | dupname asflicense spotless shellcheck shelldocs |
   | uname | Linux 5754a981a4dc 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 3a91c5b698 |
   | Max. process+thread count | 45 (vs. ulimit of 3) |
   | modules | C:  U:  |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5646/1/console 
|
   | versions | git=2.34.1 maven=3.8.6 shellcheck=0.8.0 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> All nightly jobs are failing
> 
>
> Key: HBASE-28326
> URL: https://issues.apache.org/jira/browse/HBASE-28326
> Project: HBase
>  Issue Type: Bug
>  Components: jenkins
>Reporter: Duo Zhang
>Priority: Major
>
> https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/991/console
> Failed in yetus install stage, seems to be related to gpg.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] HBASE-28326 All nightly jobs are failing [hbase]

2024-01-24 Thread via GitHub


Apache-HBase commented on PR #5646:
URL: https://github.com/apache/hbase/pull/5646#issuecomment-1907790748

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 25s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +0 :ok: |  shelldocs  |   0m  0s |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  spotless  |   0m 42s |  branch has no errors when 
running spotless:check.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m  4s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  shellcheck  |   0m  0s |  There were no new shellcheck 
issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  spotless  |   0m 39s |  patch has no errors when 
running spotless:check.  |
   ||| _ Other Tests _ |
   | +0 :ok: |  asflicense  |   0m  0s |  ASF License check generated no 
output?  |
   |  |   |   2m 56s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5646/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5646 |
   | Optional Tests | dupname asflicense spotless shellcheck shelldocs |
   | uname | Linux 5754a981a4dc 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 3a91c5b698 |
   | Max. process+thread count | 45 (vs. ulimit of 3) |
   | modules | C:  U:  |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5646/1/console 
|
   | versions | git=2.34.1 maven=3.8.6 shellcheck=0.8.0 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-28326) All nightly jobs are failing

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810307#comment-17810307
 ] 

ASF GitHub Bot commented on HBASE-28326:


Apache-HBase commented on PR #5646:
URL: https://github.com/apache/hbase/pull/5646#issuecomment-1907788055

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 37s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for branch  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m  5s |  Maven dependency ordering for patch  |
   ||| _ Other Tests _ |
   |  |   |   1m 35s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.44 ServerAPI=1.44 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5646/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5646 |
   | Optional Tests |  |
   | uname | Linux 002d550564fe 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 
13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 3a91c5b698 |
   | Max. process+thread count | 41 (vs. ulimit of 3) |
   | modules | C:  U:  |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5646/1/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> All nightly jobs are failing
> 
>
> Key: HBASE-28326
> URL: https://issues.apache.org/jira/browse/HBASE-28326
> Project: HBase
>  Issue Type: Bug
>  Components: jenkins
>Reporter: Duo Zhang
>Priority: Major
>
> https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/991/console
> Failed in yetus install stage, seems to be related to gpg.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-28326) All nightly jobs are failing

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810306#comment-17810306
 ] 

ASF GitHub Bot commented on HBASE-28326:


Apache-HBase commented on PR #5646:
URL: https://github.com/apache/hbase/pull/5646#issuecomment-1907788004

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 25s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  Maven dependency ordering for branch  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m  4s |  Maven dependency ordering for patch  |
   ||| _ Other Tests _ |
   |  |   |   1m 24s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5646/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5646 |
   | Optional Tests |  |
   | uname | Linux 8d1981fe447a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 3a91c5b698 |
   | Max. process+thread count | 32 (vs. ulimit of 3) |
   | modules | C:  U:  |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5646/1/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> All nightly jobs are failing
> 
>
> Key: HBASE-28326
> URL: https://issues.apache.org/jira/browse/HBASE-28326
> Project: HBase
>  Issue Type: Bug
>  Components: jenkins
>Reporter: Duo Zhang
>Priority: Major
>
> https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/991/console
> Failed in yetus install stage, seems to be related to gpg.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] HBASE-28326 All nightly jobs are failing [hbase]

2024-01-24 Thread via GitHub


Apache-HBase commented on PR #5646:
URL: https://github.com/apache/hbase/pull/5646#issuecomment-1907788055

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 37s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for branch  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m  5s |  Maven dependency ordering for patch  |
   ||| _ Other Tests _ |
   |  |   |   1m 35s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.44 ServerAPI=1.44 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5646/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5646 |
   | Optional Tests |  |
   | uname | Linux 002d550564fe 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 
13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 3a91c5b698 |
   | Max. process+thread count | 41 (vs. ulimit of 3) |
   | modules | C:  U:  |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5646/1/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28326 All nightly jobs are failing [hbase]

2024-01-24 Thread via GitHub


Apache-HBase commented on PR #5646:
URL: https://github.com/apache/hbase/pull/5646#issuecomment-1907788004

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 25s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  Maven dependency ordering for branch  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m  4s |  Maven dependency ordering for patch  |
   ||| _ Other Tests _ |
   |  |   |   1m 24s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5646/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5646 |
   | Optional Tests |  |
   | uname | Linux 8d1981fe447a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 3a91c5b698 |
   | Max. process+thread count | 32 (vs. ulimit of 3) |
   | modules | C:  U:  |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5646/1/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-28326) All nightly jobs are failing

2024-01-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-28326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810297#comment-17810297
 ] 

ASF GitHub Bot commented on HBASE-28326:


Apache9 opened a new pull request, #5646:
URL: https://github.com/apache/hbase/pull/5646

   Use downloads.a.o instead of a.o/dist




> All nightly jobs are failing
> 
>
> Key: HBASE-28326
> URL: https://issues.apache.org/jira/browse/HBASE-28326
> Project: HBase
>  Issue Type: Bug
>  Components: jenkins
>Reporter: Duo Zhang
>Priority: Major
>
> https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/991/console
> Failed in yetus install stage, seems to be related to gpg.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] HBASE-28326 All nightly jobs are failing [hbase]

2024-01-24 Thread via GitHub


Apache9 opened a new pull request, #5646:
URL: https://github.com/apache/hbase/pull/5646

   Use downloads.a.o instead of a.o/dist


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



  1   2   >